12019-08-09T00:00:02  *** popey1 has quit IRC
  22019-08-09T00:00:24  *** pinheadmz has joined #bitcoin-core-dev
  32019-08-09T00:04:11  *** wright has joined #bitcoin-core-dev
  42019-08-09T00:14:48  *** lightlike has quit IRC
  52019-08-09T00:31:49  *** pinheadmz_ has joined #bitcoin-core-dev
  62019-08-09T00:32:33  *** pinheadmz has quit IRC
  72019-08-09T00:32:33  *** pinheadmz_ is now known as pinheadmz
  82019-08-09T00:43:49  *** ercwl has quit IRC
  92019-08-09T00:44:18  *** ercwl has joined #bitcoin-core-dev
 102019-08-09T00:47:14  *** DeanWeen has joined #bitcoin-core-dev
 112019-08-09T00:51:33  *** captjakk has joined #bitcoin-core-dev
 122019-08-09T00:57:04  *** ercwl has quit IRC
 132019-08-09T01:00:19  *** ercwl has joined #bitcoin-core-dev
 142019-08-09T01:00:50  *** mryandao has quit IRC
 152019-08-09T01:02:47  *** mryandao has joined #bitcoin-core-dev
 162019-08-09T01:05:27  *** ercwl has quit IRC
 172019-08-09T01:21:45  *** ercwl has joined #bitcoin-core-dev
 182019-08-09T01:26:30  *** ercwl has quit IRC
 192019-08-09T02:06:23  *** elichai2 has quit IRC
 202019-08-09T02:16:27  *** promag has joined #bitcoin-core-dev
 212019-08-09T02:17:38  *** captjakk has quit IRC
 222019-08-09T02:20:52  *** promag has quit IRC
 232019-08-09T02:24:50  *** Zenton has joined #bitcoin-core-dev
 242019-08-09T02:51:50  *** luke-jr has quit IRC
 252019-08-09T02:52:45  *** luke-jr has joined #bitcoin-core-dev
 262019-08-09T02:58:00  *** dviola has joined #bitcoin-core-dev
 272019-08-09T03:00:02  *** wright has quit IRC
 282019-08-09T03:00:42  *** luke-jr has quit IRC
 292019-08-09T03:01:28  *** luke-jr has joined #bitcoin-core-dev
 302019-08-09T03:04:00  *** serAphim has joined #bitcoin-core-dev
 312019-08-09T03:04:24  *** serAphim is now known as Guest59591
 322019-08-09T03:18:51  *** elichai2 has joined #bitcoin-core-dev
 332019-08-09T03:20:03  *** xzytrewq has quit IRC
 342019-08-09T03:25:48  *** xzytrewq has joined #bitcoin-core-dev
 352019-08-09T03:31:47  *** Eagle[TM] has joined #bitcoin-core-dev
 362019-08-09T03:33:27  *** EagleTM has quit IRC
 372019-08-09T03:36:41  *** jeremyrubin has joined #bitcoin-core-dev
 382019-08-09T03:48:25  *** baldur has quit IRC
 392019-08-09T04:01:34  *** baldur has joined #bitcoin-core-dev
 402019-08-09T04:39:58  *** luke-jr has quit IRC
 412019-08-09T04:40:50  *** luke-jr has joined #bitcoin-core-dev
 422019-08-09T04:41:34  *** dviola has quit IRC
 432019-08-09T04:55:31  *** luke-jr has quit IRC
 442019-08-09T04:56:32  *** luke-jr has joined #bitcoin-core-dev
 452019-08-09T05:15:00  *** bitcoin-git has joined #bitcoin-core-dev
 462019-08-09T05:15:00  <bitcoin-git> [bitcoin] fanquake opened pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573
 472019-08-09T05:15:14  *** bitcoin-git has left #bitcoin-core-dev
 482019-08-09T05:27:51  *** liberiga has joined #bitcoin-core-dev
 492019-08-09T05:28:52  *** luke-jr has quit IRC
 502019-08-09T05:29:28  *** luke-jr has joined #bitcoin-core-dev
 512019-08-09T05:33:23  *** lalitmee has joined #bitcoin-core-dev
 522019-08-09T05:39:30  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 532019-08-09T05:39:38  *** StopAndDecrypt has quit IRC
 542019-08-09T05:50:22  *** luke-jr has quit IRC
 552019-08-09T05:50:58  *** luke-jr has joined #bitcoin-core-dev
 562019-08-09T05:57:16  *** luke-jr has quit IRC
 572019-08-09T05:58:13  *** luke-jr has joined #bitcoin-core-dev
 582019-08-09T05:58:29  *** elichai2 has quit IRC
 592019-08-09T06:00:01  *** Guest59591 has quit IRC
 602019-08-09T06:04:26  *** fredy1 has joined #bitcoin-core-dev
 612019-08-09T06:09:09  *** luke-jr has quit IRC
 622019-08-09T06:10:12  *** luke-jr has joined #bitcoin-core-dev
 632019-08-09T06:14:10  *** luke-jr has quit IRC
 642019-08-09T06:15:05  *** luke-jr has joined #bitcoin-core-dev
 652019-08-09T06:18:06  *** promag has joined #bitcoin-core-dev
 662019-08-09T06:22:54  *** promag has quit IRC
 672019-08-09T06:25:50  *** luke-jr has quit IRC
 682019-08-09T06:28:08  *** luke-jr has joined #bitcoin-core-dev
 692019-08-09T06:30:41  *** luke-jr has quit IRC
 702019-08-09T06:31:42  *** luke-jr has joined #bitcoin-core-dev
 712019-08-09T06:34:41  *** Krellan has quit IRC
 722019-08-09T06:35:20  *** Krellan has joined #bitcoin-core-dev
 732019-08-09T06:37:50  *** luke-jr has quit IRC
 742019-08-09T06:38:23  *** luke-jr has joined #bitcoin-core-dev
 752019-08-09T06:50:11  *** lnostdal has quit IRC
 762019-08-09T06:51:14  *** luke-jr has quit IRC
 772019-08-09T06:51:17  *** jpe has joined #bitcoin-core-dev
 782019-08-09T06:51:54  *** luke-jr has joined #bitcoin-core-dev
 792019-08-09T06:53:44  *** liberiga has quit IRC
 802019-08-09T06:59:59  *** luke-jr has quit IRC
 812019-08-09T07:00:34  *** luke-jr has joined #bitcoin-core-dev
 822019-08-09T07:10:27  *** luke-jr has quit IRC
 832019-08-09T07:12:28  *** luke-jr has joined #bitcoin-core-dev
 842019-08-09T07:14:10  *** luke-jr has quit IRC
 852019-08-09T07:15:09  *** luke-jr has joined #bitcoin-core-dev
 862019-08-09T07:17:07  *** luke-jr has quit IRC
 872019-08-09T07:19:03  *** luke-jr has joined #bitcoin-core-dev
 882019-08-09T07:24:13  *** lalitmee has quit IRC
 892019-08-09T07:25:27  *** luke-jr has quit IRC
 902019-08-09T07:26:01  *** luke-jr has joined #bitcoin-core-dev
 912019-08-09T07:26:15  *** jungly has joined #bitcoin-core-dev
 922019-08-09T07:32:06  *** luke-jr has quit IRC
 932019-08-09T07:32:31  *** luke-jr has joined #bitcoin-core-dev
 942019-08-09T07:35:27  *** csknk has joined #bitcoin-core-dev
 952019-08-09T07:35:48  *** jpe has quit IRC
 962019-08-09T07:36:16  *** luke-jr has quit IRC
 972019-08-09T07:40:03  *** luke-jr has joined #bitcoin-core-dev
 982019-08-09T07:43:03  *** luke-jr has quit IRC
 992019-08-09T07:44:22  *** luke-jr has joined #bitcoin-core-dev
1002019-08-09T07:45:21  *** luke-jr has quit IRC
1012019-08-09T07:47:40  *** luke-jr has joined #bitcoin-core-dev
1022019-08-09T07:47:41  *** luke-jr has quit IRC
1032019-08-09T07:48:41  *** luke-jr has joined #bitcoin-core-dev
1042019-08-09T08:23:32  *** jb551 has joined #bitcoin-core-dev
1052019-08-09T08:26:08  *** jb55 has quit IRC
1062019-08-09T08:28:25  *** lalitmee has joined #bitcoin-core-dev
1072019-08-09T08:33:03  *** AaronvanW has joined #bitcoin-core-dev
1082019-08-09T08:36:18  *** Eagle[TM] has quit IRC
1092019-08-09T08:36:34  *** jl2012 has left #bitcoin-core-dev
1102019-08-09T08:37:06  *** Aaronvan_ has joined #bitcoin-core-dev
1112019-08-09T08:40:58  *** AaronvanW has quit IRC
1122019-08-09T09:00:01  *** fredy1 has quit IRC
1132019-08-09T09:00:10  *** timothy has joined #bitcoin-core-dev
1142019-08-09T09:00:34  *** emilengler_ has joined #bitcoin-core-dev
1152019-08-09T09:01:13  *** emilengler has quit IRC
1162019-08-09T09:04:07  *** amcrae has joined #bitcoin-core-dev
1172019-08-09T09:04:31  *** amcrae is now known as Guest53083
1182019-08-09T09:16:45  *** promag has joined #bitcoin-core-dev
1192019-08-09T09:19:10  *** Victor_sueca is now known as Victorsueca
1202019-08-09T09:20:35  *** emilengler_ has quit IRC
1212019-08-09T09:20:55  *** promag has quit IRC
1222019-08-09T09:26:03  *** emilengler has joined #bitcoin-core-dev
1232019-08-09T10:18:35  *** michaelfolkson has joined #bitcoin-core-dev
1242019-08-09T10:22:39  *** csknk has quit IRC
1252019-08-09T10:23:43  *** Squidicuz has joined #bitcoin-core-dev
1262019-08-09T10:24:41  *** davereik1 has joined #bitcoin-core-dev
1272019-08-09T10:26:32  *** davereikher has quit IRC
1282019-08-09T10:30:06  *** ercwl has joined #bitcoin-core-dev
1292019-08-09T10:32:19  *** ercwl has quit IRC
1302019-08-09T10:38:03  *** phwalkr has joined #bitcoin-core-dev
1312019-08-09T10:46:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1322019-08-09T10:49:11  *** ercwl has joined #bitcoin-core-dev
1332019-08-09T10:55:58  *** setpill has joined #bitcoin-core-dev
1342019-08-09T11:00:39  *** michaelfolkson has quit IRC
1352019-08-09T11:01:29  *** michaelfolkson has joined #bitcoin-core-dev
1362019-08-09T11:04:41  *** michaelfolkson has quit IRC
1372019-08-09T11:06:52  *** michaelfolkson has joined #bitcoin-core-dev
1382019-08-09T11:10:16  *** michaelfolkson has quit IRC
1392019-08-09T11:23:23  *** bitcoin-git has joined #bitcoin-core-dev
1402019-08-09T11:23:23  <bitcoin-git> [bitcoin] laanwj opened pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574
1412019-08-09T11:23:37  *** bitcoin-git has left #bitcoin-core-dev
1422019-08-09T12:00:01  *** Guest53083 has quit IRC
1432019-08-09T12:03:03  *** emilengler has quit IRC
1442019-08-09T12:03:56  *** emilengler has joined #bitcoin-core-dev
1452019-08-09T12:06:55  *** michaelfolkson has joined #bitcoin-core-dev
1462019-08-09T12:11:17  <jonasschnelli> Is there a clever way to access private members from a boost unit test?
1472019-08-09T12:14:22  *** Khaytsus1 has joined #bitcoin-core-dev
1482019-08-09T12:16:04  <jonasschnelli> nm, ... going to try a friendly test struct
1492019-08-09T12:22:51  <emilengler> You could use a dirty pointer trick
1502019-08-09T12:23:19  <jonasschnelli> Yes. Or that.
1512019-08-09T12:25:12  *** emilengler has quit IRC
1522019-08-09T12:31:02  *** lalitmee has quit IRC
1532019-08-09T12:34:03  *** emilengler has joined #bitcoin-core-dev
1542019-08-09T12:38:56  *** ercwl has quit IRC
1552019-08-09T12:53:10  *** Aaronvan_ is now known as AaronvanW
1562019-08-09T12:53:31  *** emilengler_ has joined #bitcoin-core-dev
1572019-08-09T12:55:16  *** emilengler has quit IRC
1582019-08-09T13:03:19  *** ercwl has joined #bitcoin-core-dev
1592019-08-09T13:08:14  *** emilengler_ has quit IRC
1602019-08-09T13:10:22  *** bixus has joined #bitcoin-core-dev
1612019-08-09T13:12:32  *** bixus has quit IRC
1622019-08-09T13:17:24  *** emilengler has joined #bitcoin-core-dev
1632019-08-09T13:19:47  *** bitcoin-git has joined #bitcoin-core-dev
1642019-08-09T13:19:47  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5fdda68c6d2...32776276ef07
1652019-08-09T13:19:48  <bitcoin-git> bitcoin/master 61c5c64 Wladimir J. van der Laan: doc: Add historical release notes for 0.18.1
1662019-08-09T13:19:48  <bitcoin-git> bitcoin/master 3277627 fanquake: Merge #16574: doc: Add historical release notes for 0.18.1
1672019-08-09T13:19:50  *** bitcoin-git has left #bitcoin-core-dev
1682019-08-09T13:20:57  *** bitcoin-git has joined #bitcoin-core-dev
1692019-08-09T13:20:57  <bitcoin-git> [bitcoin] fanquake merged pull request #16574: doc: Add historical release notes for 0.18.1 (master...2019_08_relnot_0_18_1) https://github.com/bitcoin/bitcoin/pull/16574
1702019-08-09T13:20:59  *** bitcoin-git has left #bitcoin-core-dev
1712019-08-09T13:23:40  *** elichai2 has joined #bitcoin-core-dev
1722019-08-09T13:35:35  *** dgfhdfg has joined #bitcoin-core-dev
1732019-08-09T13:38:45  *** lightlike has joined #bitcoin-core-dev
1742019-08-09T13:43:55  *** davterra has quit IRC
1752019-08-09T13:46:19  *** Guyver2 has joined #bitcoin-core-dev
1762019-08-09T13:49:18  *** bitcoin-git has joined #bitcoin-core-dev
1772019-08-09T13:49:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32776276ef07...9ab9d6356938
1782019-08-09T13:49:19  <bitcoin-git> bitcoin/master b7b9f6e Antoine Riard: Remove p2pEnabled from Chain interface
1792019-08-09T13:49:20  <bitcoin-git> bitcoin/master 9ab9d63 MarcoFalke: Merge #16503: Remove p2pEnabled from Chain interface
1802019-08-09T13:49:22  *** bitcoin-git has left #bitcoin-core-dev
1812019-08-09T13:50:13  *** bitcoin-git has joined #bitcoin-core-dev
1822019-08-09T13:50:13  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #16503: Remove p2pEnabled from Chain interface (master...2019-07-remove-p2p-chain) https://github.com/bitcoin/bitcoin/pull/16503
1832019-08-09T13:50:16  *** bitcoin-git has left #bitcoin-core-dev
1842019-08-09T13:55:10  *** ercwl has quit IRC
1852019-08-09T13:55:37  *** lalitmee has joined #bitcoin-core-dev
1862019-08-09T13:58:31  *** davereik1 has quit IRC
1872019-08-09T13:59:17  *** davereik1 has joined #bitcoin-core-dev
1882019-08-09T14:03:20  *** xzytrewq has quit IRC
1892019-08-09T14:20:35  *** TheHoliestRoger is now known as [monk]
1902019-08-09T14:23:58  *** michaelfolkson has quit IRC
1912019-08-09T14:36:42  <BlueMatt> hm, looks like the only dnsseeds resolvable over v6 are mine, jonasschnelli's and emzy's :(
1922019-08-09T14:36:57  <emzy> :(
1932019-08-09T14:37:10  <BlueMatt> sipa petertodd, cdecker, luke-jr and provoostenator need to fix their shitz
1942019-08-09T14:37:29  <jonasschnelli> glad I can claim I did my homework... :)
1952019-08-09T14:37:51  <BlueMatt> heh, indeed
1962019-08-09T14:38:03  <emzy> ipv4 is only legacy. v6 is the Internet :)
1972019-08-09T14:40:08  <provoostenator> TIL mine crawls IPv6 diligently, but can't reached that way :-)
1982019-08-09T14:40:29  *** michaelfolkson has joined #bitcoin-core-dev
1992019-08-09T14:41:32  *** dgfhdfg has quit IRC
2002019-08-09T14:41:35  *** ptiyoyip has joined #bitcoin-core-dev
2012019-08-09T14:44:47  *** emilengler has quit IRC
2022019-08-09T14:45:35  *** michaelfolkson has quit IRC
2032019-08-09T14:47:44  *** emilengler has joined #bitcoin-core-dev
2042019-08-09T14:47:48  *** michaelfolkson has joined #bitcoin-core-dev
2052019-08-09T14:49:04  *** mdunnio has joined #bitcoin-core-dev
2062019-08-09T14:54:12  *** michaelfolkson has quit IRC
2072019-08-09T15:00:02  *** Khaytsus1 has quit IRC
2082019-08-09T15:00:46  *** hebasto has joined #bitcoin-core-dev
2092019-08-09T15:02:39  *** mdunnio has quit IRC
2102019-08-09T15:03:19  *** mdunnio has joined #bitcoin-core-dev
2112019-08-09T15:06:36  *** jb551 is now known as jb55
2122019-08-09T15:09:05  *** [monk] is now known as [THR]
2132019-08-09T15:09:22  *** [THR] is now known as [TheHoliestRoger
2142019-08-09T15:09:40  *** [TheHoliestRoger is now known as [Holiest]
2152019-08-09T15:10:31  *** [Holiest] is now known as [poopster]
2162019-08-09T15:10:40  <BlueMatt> right :) and there are seriously quite a few v6-only isps in the world these days
2172019-08-09T15:10:56  *** [poopster] is now known as TheHoliestRoger
2182019-08-09T15:11:49  *** lalitmee has quit IRC
2192019-08-09T15:20:14  *** mdunnio has quit IRC
2202019-08-09T15:34:15  *** clintbellanger has joined #bitcoin-core-dev
2212019-08-09T15:35:48  *** mdunnio has joined #bitcoin-core-dev
2222019-08-09T15:38:35  <provoostenator> Working on a solution, but the rabbit hole goes deep...
2232019-08-09T15:41:07  *** mdunnio has quit IRC
2242019-08-09T15:42:46  *** hardforkthis has quit IRC
2252019-08-09T15:43:05  *** hardforkthis has joined #bitcoin-core-dev
2262019-08-09T15:46:12  *** mdunnio has joined #bitcoin-core-dev
2272019-08-09T15:48:00  *** jarthur has joined #bitcoin-core-dev
2282019-08-09T15:51:31  *** jarthur has quit IRC
2292019-08-09T15:51:43  *** jarthur has joined #bitcoin-core-dev
2302019-08-09T15:57:47  *** mdunnio has quit IRC
2312019-08-09T16:00:05  <sipa> BlueMatt: $ dig -t AAAA seed.bitcoin.sipa.be
2322019-08-09T16:00:07  <sipa> works
2332019-08-09T16:01:59  <BlueMatt> sipa: the sipa.be ns servers dont have v6 entries
2342019-08-09T16:02:05  <BlueMatt> ie the ulyssis.org ones
2352019-08-09T16:02:14  <BlueMatt> you want dig -6 +trace seed.bitcoin.sipa.be aaaa
2362019-08-09T16:02:19  <sipa> ah
2372019-08-09T16:02:52  <sipa> yup
2382019-08-09T16:02:59  *** mdunnio_ has joined #bitcoin-core-dev
2392019-08-09T16:16:52  *** ptiyoyip has quit IRC
2402019-08-09T16:31:48  *** tryphe has quit IRC
2412019-08-09T16:32:15  *** tryphe has joined #bitcoin-core-dev
2422019-08-09T16:32:20  *** kljasdfvv has quit IRC
2432019-08-09T16:33:00  *** mdunnio_ has quit IRC
2442019-08-09T16:36:59  *** setpill has quit IRC
2452019-08-09T16:38:01  *** Chris_Stewart_5 has quit IRC
2462019-08-09T16:45:13  *** ercwl has joined #bitcoin-core-dev
2472019-08-09T16:45:16  *** kewde[m] has quit IRC
2482019-08-09T16:45:18  *** tuirektiujm[m] has quit IRC
2492019-08-09T16:45:20  *** electric-sheep[m has quit IRC
2502019-08-09T16:45:51  *** TheFuzzStone[m] has quit IRC
2512019-08-09T16:45:51  *** ercwl has left #bitcoin-core-dev
2522019-08-09T16:45:52  *** DavidMitchell[m] has quit IRC
2532019-08-09T16:52:19  *** TheFuzzStone[m] has joined #bitcoin-core-dev
2542019-08-09T16:54:51  <achow101> provoostenator: After actually attempting to make all of the commits in #16341 compile with the whole move instead of copy thing, I don't think it will make it any easier to review, actually probably harder. IMO Having to introduce temporary functions and changes everywhere only to remove them a few commits later makes it way harder to review as some commits basically have no effect on the final product
2552019-08-09T16:54:55  <gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub
2562019-08-09T16:56:15  <achow101> I ended up having to introduce several temp functions to expose some internals of LegacyScriptPubKeyMan which resulted in a bunch of changes to CWallet that were basically then removed in the subsequent commit. Having to keep track of all of these temp things and then removing them and restoring the correct behavior is far more work than it's worth IMO
2572019-08-09T16:56:31  <achow101> so I'm not going to continue doing that
2582019-08-09T16:58:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2592019-08-09T16:59:35  *** kewde[m] has joined #bitcoin-core-dev
2602019-08-09T16:59:35  *** tuirektiujm[m] has joined #bitcoin-core-dev
2612019-08-09T16:59:41  *** electric-sheep[m has joined #bitcoin-core-dev
2622019-08-09T16:59:45  *** DavidMitchell[m] has joined #bitcoin-core-dev
2632019-08-09T17:00:25  <provoostenator> That sounds painful indeed
2642019-08-09T17:00:35  <provoostenator> Can you push a temp branch somewhere though?
2652019-08-09T17:00:58  <provoostenator> Either way, it was worth watching the stream the Wednesday just to see you try :-)
2662019-08-09T17:01:20  <gleb> Public bitcoin nodes use about 1200 ASNs. 20 of those ASNs represent 50% of the nodes, and just 3 ASNs represent 25%. This means that suggested ASN-based bucketing bias would make more (potentially, mission-critical) connections  to those tiny unpopular ASNs than it is today. Is this well-understood? Is this the effect we want?  I'm not sure.
2672019-08-09T17:03:15  <provoostenator> BlueMatt: the good news is, this works now: dig -6 -t AAAA seed.bitcoin.sprovoost.nl
2682019-08-09T17:03:35  <provoostenator> The bad news is that I probably messed up the DNS for my entire domain in the process, so will clean that up now :-(
2692019-08-09T17:03:56  <gleb> The benefit from ASN bucketing is clear from the standpoint of a single node, but for the network overall I dunno. Should we additionally enforce everybody connecting to a random node from top-3 ASNs?
2702019-08-09T17:05:39  <sipa> gleb: i'm not sure, but maybe it helps to look at it from the other direction: it's expected that a huge number of nodes right now are on large providers (AWS, large VPS providers, ...); biasing by ASN would significantly reduce the number of connections to those in favor of others, but I think that's desirable
2712019-08-09T17:06:13  <sipa> having 100s of nodes on AWS doesn't actually add much partition resistance from the perspective of someone connecting to it
2722019-08-09T17:09:17  <BlueMatt> gleb: indeed, what sipa said...last I looked the vast majority of nodes were on a few providers - aws, digitalocean, hertzner and such
2732019-08-09T17:09:21  <achow101> provoostenator: https://github.com/achow101/bitcoin/tree/wallet-boxes-2 it's currently broken as I didn't actually finish it
2742019-08-09T17:09:34  <BlueMatt> connecting only to those is, thus, likely not an uncommon case
2752019-08-09T17:09:37  *** mdunnio has joined #bitcoin-core-dev
2762019-08-09T17:09:37  <BlueMatt> and is clearly useless
2772019-08-09T17:10:07  <sipa> an orthogonal idea may be to have 1 or 2 additional connections within your local network/ASN
2782019-08-09T17:10:34  <BlueMatt> I dont know how much "few nodes on an asn" correlates with "small isp in the middle of nowhere which doesn't want to serve a lot of traffic", it probably correlates a bit but I'd presume it correlates more with "residential isp with few hosted nodes"
2792019-08-09T17:10:41  <BlueMatt> right, likely want that, too
2802019-08-09T17:10:52  <BlueMatt> maybe a third and fourth blocks-only connection or so to local asn
2812019-08-09T17:11:26  <gleb> Now it's very possible to connect to only those, which is obviously bad. I'm just saying that ASN bucketing might result in connecting to ONLY pocket vulnerable ISPs
2822019-08-09T17:12:08  <gleb> So if the cost of partition is bribing, I think having 7 pocket ISPs + AWS is in this case better than 8 pocket ISPs :)
2832019-08-09T17:12:21  <sipa> what is a pocket ISP?
2842019-08-09T17:12:41  <gleb> something unpopular and easy to influence
2852019-08-09T17:13:00  <gleb> I might be missing the threat model here
2862019-08-09T17:13:22  <sipa> actually, the rule "at most one outgoing connection per ASN" isn't quite the same as "connections are uniformly sampled over all ASNs"; larger networks are still more likely to reason connections - just not more than one per outgoing peer
2872019-08-09T17:14:38  <sipa> s/reason/receive/ no idea how i made that typo
2882019-08-09T17:14:41  * sipa drinks coffee
2892019-08-09T17:15:14  *** mdunnio has quit IRC
2902019-08-09T17:15:17  <gleb> Well, that's partially what i'm asking about. I thought the current idea is uniformly random  sample over all ASNs, and I questioned this idea.
2912019-08-09T17:15:38  <sipa> no, clearly an ASN with no known peers won't get any connections :)
2922019-08-09T17:16:25  <sipa> the outgoing connection logic just randomly picks a known peer (with some biases already, like favoring port 8333), and then there is a rejection sampling which throws away results within a "group" we already have an outgoing connection to
2932019-08-09T17:16:32  <gleb> I just thought of it this way: take all ASNs you know peers from, sample 8 unique ones, connect to peers from those 8
2942019-08-09T17:16:52  <gleb> But I guess we will sample peers first, which would result in connecting to AWS at least once anyways.
2952019-08-09T17:17:00  <sipa> right
2962019-08-09T17:17:33  *** promag has joined #bitcoin-core-dev
2972019-08-09T17:18:06  <gleb> Okay, I'll see if there's a good place in the code or PR I can document this observation, because for me it took a while to understand it.
2982019-08-09T17:18:41  <sipa> the suggestion is to change the definition of groups to be ASNs
2992019-08-09T17:22:16  *** promag has quit IRC
3002019-08-09T17:23:28  <sipa> gleb: https://github.com/bitcoin/bitcoin/blob/v0.18.1/src/net.cpp#L1763L1808
3012019-08-09T17:23:35  <sipa> that's the outgoing connection peer selection logic
3022019-08-09T17:23:44  <sipa> it's fairly well documented
3032019-08-09T17:24:13  *** Chris_Stewart_5 has quit IRC
3042019-08-09T17:27:12  <gleb> I was more worried that if this code is changed we might end up with uniform distribution across all asns due to this new bucket logic
3052019-08-09T17:27:26  <gleb> "If changing bucketing code again, don't shoot in your leg"
3062019-08-09T17:27:56  *** mdunnio has joined #bitcoin-core-dev
3072019-08-09T17:28:10  <sipa> if we feel the bias towards small asns is too strong as a result of this, the policy could also be permitting two connections to large asns
3082019-08-09T17:28:26  <sipa> or to treat large asns as multiple groups
3092019-08-09T17:29:21  *** captjakk has joined #bitcoin-core-dev
3102019-08-09T17:32:29  <gleb> Now that you mitigated my misunderstanding I think it's fine since we'll very likely to have one connection to large asns and I don't see a huge benefit in having 2 instead of 1
3112019-08-09T17:34:18  *** Deacyde has joined #bitcoin-core-dev
3122019-08-09T17:39:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3132019-08-09T17:56:51  <provoostenator> sipa petertodd, cdecker, luke-jr: to make my seed visible to IPv6-only nodes, I had to do two things:
3142019-08-09T17:57:20  <provoostenator> 1. add an AAAA record from seed.bitcoin.sprovoost.nl. to the IPv6 address of the seed
3152019-08-09T17:58:06  <provoostenator> 2. make sure all DNS providers starting from my domain registrar can actually handle IPv6 (I had to move stuff for that reason)
3162019-08-09T17:58:52  *** TheHoliestRoger is now known as Testicycle
3172019-08-09T17:58:59  *** LarryRuane has joined #bitcoin-core-dev
3182019-08-09T17:59:05  <provoostenator> "dig -6 -t AAAA +trace seed.bitcoin.sprovoost.nl" can be helpful seeing where the buck stops, ht BlueMatt
3192019-08-09T17:59:20  <provoostenator> Where -6 forces going over IPv6
3202019-08-09T18:00:01  *** clintbellanger has quit IRC
3212019-08-09T18:01:36  *** mdunnio has quit IRC
3222019-08-09T18:02:48  *** mdunnio has joined #bitcoin-core-dev
3232019-08-09T18:04:47  *** jackalope has joined #bitcoin-core-dev
3242019-08-09T18:11:36  *** captjakk has quit IRC
3252019-08-09T18:11:52  *** captjakk has joined #bitcoin-core-dev
3262019-08-09T18:18:45  *** reallll has joined #bitcoin-core-dev
3272019-08-09T18:20:55  *** jungly has quit IRC
3282019-08-09T18:22:01  *** belcher has quit IRC
3292019-08-09T18:23:36  *** reallll is now known as belcher
3302019-08-09T18:23:42  *** promag has joined #bitcoin-core-dev
3312019-08-09T18:26:24  *** Testicycle is now known as TheHoliestRoger
3322019-08-09T18:27:58  *** promag has quit IRC
3332019-08-09T18:27:58  *** hebasto has quit IRC
3342019-08-09T18:44:18  *** davterra has joined #bitcoin-core-dev
3352019-08-09T18:51:49  *** Victor_sueca has joined #bitcoin-core-dev
3362019-08-09T18:52:19  *** Victorsueca has quit IRC
3372019-08-09T18:58:44  *** bitcoin-git has joined #bitcoin-core-dev
3382019-08-09T18:58:44  <bitcoin-git> [bitcoin] LarryRuane opened pull request #16577: util: CBufferedFile fixes and unit test (master...CBufferedFile-fixes) https://github.com/bitcoin/bitcoin/pull/16577
3392019-08-09T18:58:45  *** bitcoin-git has left #bitcoin-core-dev
3402019-08-09T18:58:53  *** promag has joined #bitcoin-core-dev
3412019-08-09T18:59:04  *** bitcoin-git has joined #bitcoin-core-dev
3422019-08-09T18:59:05  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9ab9d6356938...e47e36cb4975
3432019-08-09T18:59:05  <bitcoin-git> bitcoin/master bf72b8a fanquake: build: disable libsecp256k1 benchmarks
3442019-08-09T18:59:06  <bitcoin-git> bitcoin/master e47e36c Wladimir J. van der Laan: Merge #16573: build: disable building libsecp256k1 benchmarks
3452019-08-09T18:59:08  *** bitcoin-git has left #bitcoin-core-dev
3462019-08-09T18:59:59  *** bitcoin-git has joined #bitcoin-core-dev
3472019-08-09T18:59:59  <bitcoin-git> [bitcoin] laanwj merged pull request #16573: build: disable building libsecp256k1 benchmarks (master...disable-secp256k1-benchmarks) https://github.com/bitcoin/bitcoin/pull/16573
3482019-08-09T19:00:02  *** bitcoin-git has left #bitcoin-core-dev
3492019-08-09T19:02:00  *** Kitsch has joined #bitcoin-core-dev
3502019-08-09T19:02:58  *** promag has quit IRC
3512019-08-09T19:17:57  *** mdunnio has quit IRC
3522019-08-09T19:18:04  *** captjakk has joined #bitcoin-core-dev
3532019-08-09T19:25:04  *** mdunnio has joined #bitcoin-core-dev
3542019-08-09T19:27:20  *** DeanWeen has quit IRC
3552019-08-09T19:27:59  *** DeanWeen has joined #bitcoin-core-dev
3562019-08-09T19:31:17  *** Chris_Stewart_5 has quit IRC
3572019-08-09T19:34:49  *** tryphe has quit IRC
3582019-08-09T19:35:15  *** tryphe has joined #bitcoin-core-dev
3592019-08-09T19:46:16  *** timothy has quit IRC
3602019-08-09T19:52:57  *** bitcoin-git has joined #bitcoin-core-dev
3612019-08-09T19:52:57  <bitcoin-git> [bitcoin] achow101 opened pull request #16578: Do not pass in command line arguments to QApplication (master...no-qapp-args) https://github.com/bitcoin/bitcoin/pull/16578
3622019-08-09T19:52:59  *** bitcoin-git has left #bitcoin-core-dev
3632019-08-09T20:12:52  <roasbeef> does everyone use the same software to operate their DNS seed? do they need to be manually updated to respond to queries for "new" service bits? for example, of the seeds i'm aware of, only seed.bitnodes.io responds to queries for teh x49 subdomain (full node, segwit, bip 158)
3642019-08-09T20:14:55  <emzy> I think most using sipas dnsseed software, ecexpt one.
3652019-08-09T20:17:30  <sipa> my seeder can be configured to support any subset of service bit combinations
3662019-08-09T20:19:01  <emzy> I run the default.
3672019-08-09T20:26:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3682019-08-09T20:35:25  *** nos has joined #bitcoin-core-dev
3692019-08-09T20:36:23  *** Kitsch has left #bitcoin-core-dev
3702019-08-09T20:36:28  *** DeanWeen has quit IRC
3712019-08-09T20:37:41  *** nos has quit IRC
3722019-08-09T20:38:00  *** nos2 has joined #bitcoin-core-dev
3732019-08-09T20:40:03  *** nos2 has quit IRC
3742019-08-09T20:40:42  *** linkd has joined #bitcoin-core-dev
3752019-08-09T20:41:53  *** promag has joined #bitcoin-core-dev
3762019-08-09T20:42:35  *** linkd has quit IRC
3772019-08-09T20:42:56  *** nos2 has joined #bitcoin-core-dev
3782019-08-09T20:44:12  *** nos2 has quit IRC
3792019-08-09T20:45:09  <emzy> any recomendation which service bit combinations to enable on the dnsseed?
3802019-08-09T20:45:20  *** Guyver2 has quit IRC
3812019-08-09T20:47:55  *** nos has joined #bitcoin-core-dev
3822019-08-09T20:51:50  *** nos has quit IRC
3832019-08-09T20:52:07  *** nos has joined #bitcoin-core-dev
3842019-08-09T20:53:17  *** nosss2 has joined #bitcoin-core-dev
3852019-08-09T20:54:54  *** nosss2 has quit IRC
3862019-08-09T20:56:22  *** nosss2 has joined #bitcoin-core-dev
3872019-08-09T20:58:50  *** tuirektiujm[m] has quit IRC
3882019-08-09T20:59:26  *** nosss2 has quit IRC
3892019-08-09T21:00:02  *** jackalope has quit IRC
3902019-08-09T21:00:10  *** nosss2 has joined #bitcoin-core-dev
3912019-08-09T21:00:57  *** mdunnio has quit IRC
3922019-08-09T21:01:10  *** justanotheruser has quit IRC
3932019-08-09T21:01:13  *** pinheadmz has quit IRC
3942019-08-09T21:01:16  *** pinheadmz_ has joined #bitcoin-core-dev
3952019-08-09T21:04:23  *** KuluBot has joined #bitcoin-core-dev
3962019-08-09T21:05:10  *** nosss2 has quit IRC
3972019-08-09T21:06:15  *** nosss2 has joined #bitcoin-core-dev
3982019-08-09T21:06:39  *** mdunnio has joined #bitcoin-core-dev
3992019-08-09T21:10:07  *** nosss2 has quit IRC
4002019-08-09T21:10:18  *** nosss2 has joined #bitcoin-core-dev
4012019-08-09T21:11:51  *** nosss2_ has joined #bitcoin-core-dev
4022019-08-09T21:14:33  *** mdunnio has quit IRC
4032019-08-09T21:15:16  *** nosss2 has quit IRC
4042019-08-09T21:15:18  *** nosss2_ is now known as nosss2
4052019-08-09T21:29:22  *** Phil48 has joined #bitcoin-core-dev
4062019-08-09T21:32:01  *** promag has quit IRC
4072019-08-09T21:33:58  *** mdunnio has joined #bitcoin-core-dev
4082019-08-09T21:38:42  *** mdunnio has quit IRC
4092019-08-09T21:44:59  *** Phil48 has quit IRC
4102019-08-09T21:45:50  *** Phil14 has joined #bitcoin-core-dev
4112019-08-09T21:57:37  *** justanotheruser has joined #bitcoin-core-dev
4122019-08-09T22:05:33  *** xzytrewq has joined #bitcoin-core-dev
4132019-08-09T22:07:07  *** Chris_Stewart_5 has quit IRC
4142019-08-09T22:16:28  *** xzytrewq has quit IRC
4152019-08-09T22:16:42  *** jarthur has quit IRC
4162019-08-09T22:17:59  *** afk11 has quit IRC
4172019-08-09T22:18:29  *** afk11 has joined #bitcoin-core-dev
4182019-08-09T22:19:28  <roasbeef> emzy: x49? ;) that's bits 1, 3, and 6
4192019-08-09T22:25:59  *** LarryRuane has quit IRC
4202019-08-09T23:08:33  *** davterra has quit IRC
4212019-08-09T23:22:50  *** lowentropy has quit IRC
4222019-08-09T23:23:01  *** lowentropy has joined #bitcoin-core-dev
4232019-08-09T23:24:37  *** MasterdonX has quit IRC
4242019-08-09T23:31:01  *** MasterdonX has joined #bitcoin-core-dev
4252019-08-09T23:31:54  *** elichai2 has quit IRC
4262019-08-09T23:32:36  *** promag has joined #bitcoin-core-dev
4272019-08-09T23:37:07  *** promag has quit IRC