12020-01-17T00:00:01 *** reeiiko has quit IRC
22020-01-17T00:02:14 <fanquake> meshcollider: can you look at #17889 when available
32020-01-17T00:02:16 <gribble> https://github.com/bitcoin/bitcoin/issues/17889 | wallet: Improve CWallet:MarkDestinationsDirty by promag · Pull Request #17889 · bitcoin/bitcoin · GitHub
42020-01-17T00:05:36 *** turbo_choo has quit IRC
52020-01-17T00:12:10 <meshcollider> Yep :)
62020-01-17T00:12:49 <fanquake> ð»
72020-01-17T00:16:57 *** justmay has joined #bitcoin-core-dev
82020-01-17T00:17:19 *** justmay is now known as Guest95916
92020-01-17T00:31:48 *** promag has joined #bitcoin-core-dev
102020-01-17T00:32:34 *** ExEric3 has quit IRC
112020-01-17T00:33:07 *** Eric3 has joined #bitcoin-core-dev
122020-01-17T00:41:40 *** justanotheruser has quit IRC
132020-01-17T00:41:55 *** justanotheruser has joined #bitcoin-core-dev
142020-01-17T01:10:50 <promag> meshcollider: i can fix the typo
152020-01-17T01:11:02 <meshcollider> alright I'll wait :)
162020-01-17T01:13:09 <promag> meshcollider: done https://github.com/bitcoin/bitcoin/compare/fd6d0679e7c3a956afc273fa38f64dab3f0ed223..2b1641492fbf81e2c5a95f3e580811ca8700adc5
172020-01-17T01:14:38 <meshcollider> thanks!
182020-01-17T01:16:08 *** bitcoin-git has joined #bitcoin-core-dev
192020-01-17T01:16:08 <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/95ca6aeec7b8...7fb94c0ed418
202020-01-17T01:16:09 <bitcoin-git> bitcoin/master 2b16414 João Barbosa: wallet: Improve CWallet:MarkDestinationsDirty
212020-01-17T01:16:09 <bitcoin-git> bitcoin/master 7fb94c0 Samuel Dobson: Merge #17889: wallet: Improve CWallet:MarkDestinationsDirty
222020-01-17T01:16:11 *** bitcoin-git has left #bitcoin-core-dev
232020-01-17T01:16:28 *** bitcoin-git has joined #bitcoin-core-dev
242020-01-17T01:16:28 <bitcoin-git> [bitcoin] meshcollider merged pull request #17889: wallet: Improve CWallet:MarkDestinationsDirty (master...2020-01-wallettx-iscacheempty) https://github.com/bitcoin/bitcoin/pull/17889
252020-01-17T01:16:30 *** bitcoin-git has left #bitcoin-core-dev
262020-01-17T01:16:36 *** turbo_choo has joined #bitcoin-core-dev
272020-01-17T01:26:22 *** belcher has quit IRC
282020-01-17T01:26:55 *** turbo_choo has quit IRC
292020-01-17T01:27:16 *** turbo_choo has joined #bitcoin-core-dev
302020-01-17T01:49:16 *** Highway61 has quit IRC
312020-01-17T01:53:35 *** AaronvanW has quit IRC
322020-01-17T01:54:51 <meshcollider> ah sorry achow101, another rebase on the boxes :'(
332020-01-17T01:55:23 <meshcollider> its one of my priorities this week to try and get that in though
342020-01-17T02:06:20 <promag> meshcollider: I believe a rebase was already necessary, https://github.com/bitcoin/bitcoin/pull/17261/commits/b92575c5a838709e00f90d49bc377e68b5683e9a is already in master :/
352020-01-17T02:09:47 <achow101> how'd that commit sneak in? I guess my last rebase got screwed up somewhere
362020-01-17T02:11:02 <achow101> meshcollider: rebased it. hurry up and merge it please :)
372020-01-17T02:13:33 *** greypw has quit IRC
382020-01-17T02:26:15 *** AaronvanW has joined #bitcoin-core-dev
392020-01-17T02:26:38 *** bitcoin-git has joined #bitcoin-core-dev
402020-01-17T02:26:38 <bitcoin-git> [bitcoin] Empact opened pull request #17945: doc: Fix doxygen errors (master...2020-01-wdocumentation) https://github.com/bitcoin/bitcoin/pull/17945
412020-01-17T02:26:50 *** bitcoin-git has left #bitcoin-core-dev
422020-01-17T02:31:14 *** AaronvanW has quit IRC
432020-01-17T02:31:39 *** pinheadmz has joined #bitcoin-core-dev
442020-01-17T02:32:18 *** promag has quit IRC
452020-01-17T02:33:22 *** promag has joined #bitcoin-core-dev
462020-01-17T02:33:55 *** promag_ has joined #bitcoin-core-dev
472020-01-17T02:37:38 *** promag has quit IRC
482020-01-17T02:38:23 *** promag_ has quit IRC
492020-01-17T02:38:57 <luke-jr> ugh, GBT is broken in 0.19?
502020-01-17T02:41:04 * luke-jr facepalms putting such a bug in release notes rather than just fixing it
512020-01-17T02:45:02 *** DeanGuss has quit IRC
522020-01-17T02:45:08 <aj> luke-jr: ?
532020-01-17T02:45:31 *** DeanGuss has joined #bitcoin-core-dev
542020-01-17T02:45:35 <luke-jr> aj: "rules" with csv & segwit is absolutely needed
552020-01-17T02:46:07 <luke-jr> without it, miners have no way to know what rules are being used and might produce invalid blocks
562020-01-17T02:46:18 <luke-jr> the BIP is perfectly clear :/
572020-01-17T02:49:56 <aj> ah, i did raise that https://github.com/bitcoin/bitcoin/pull/16060#discussion_r309036184 and https://github.com/bitcoin/bitcoin/pull/16060#issuecomment-520900105 but took your lack of more explicit objection as an okay
582020-01-17T02:55:17 *** pinheadmz has quit IRC
592020-01-17T02:56:09 *** lio17 has quit IRC
602020-01-17T02:56:58 *** lio17 has joined #bitcoin-core-dev
612020-01-17T03:00:01 *** Guest95916 has quit IRC
622020-01-17T03:01:45 *** abrissbi1ne has joined #bitcoin-core-dev
632020-01-17T03:02:59 *** dongcarl has quit IRC
642020-01-17T03:03:26 <luke-jr> aj: I don't think I saw it
652020-01-17T03:04:45 <aj> yeah, you replied on that first thread, but doesn't look like you looked in any detail
662020-01-17T03:04:58 *** abrissbirne has quit IRC
672020-01-17T03:07:17 *** AaronvanW has joined #bitcoin-core-dev
682020-01-17T03:08:41 *** dongcarl has joined #bitcoin-core-dev
692020-01-17T03:17:28 *** kutio has joined #bitcoin-core-dev
702020-01-17T03:21:29 *** dongcarl has quit IRC
712020-01-17T03:35:58 *** turbo_choo has quit IRC
722020-01-17T03:36:18 *** turbo_choo has joined #bitcoin-core-dev
732020-01-17T03:40:07 *** AaronvanW has quit IRC
742020-01-17T03:49:14 *** pinheadmz has joined #bitcoin-core-dev
752020-01-17T03:50:54 *** volbil has joined #bitcoin-core-dev
762020-01-17T03:55:21 *** ddustin has joined #bitcoin-core-dev
772020-01-17T04:01:27 *** felixfoertsch has joined #bitcoin-core-dev
782020-01-17T04:03:33 *** felixfoertsch23 has quit IRC
792020-01-17T04:11:35 *** krvopije has joined #bitcoin-core-dev
802020-01-17T04:15:26 *** krvopije has quit IRC
812020-01-17T04:23:08 *** krvopije has joined #bitcoin-core-dev
822020-01-17T04:23:46 *** krvopije has quit IRC
832020-01-17T04:24:00 *** krvopije has joined #bitcoin-core-dev
842020-01-17T04:24:22 *** krvopije has joined #bitcoin-core-dev
852020-01-17T04:32:35 *** krvopije has quit IRC
862020-01-17T04:33:03 *** krvopije has joined #bitcoin-core-dev
872020-01-17T04:34:13 *** krvopije has quit IRC
882020-01-17T04:34:36 *** krvopije has joined #bitcoin-core-dev
892020-01-17T04:35:03 *** mryandao has quit IRC
902020-01-17T04:36:20 *** krvopije has quit IRC
912020-01-17T04:45:04 *** mryandao has joined #bitcoin-core-dev
922020-01-17T05:13:47 *** promag has joined #bitcoin-core-dev
932020-01-17T05:18:13 *** promag has quit IRC
942020-01-17T05:18:31 *** Kiminuo has quit IRC
952020-01-17T05:35:09 *** bitcoin-git has joined #bitcoin-core-dev
962020-01-17T05:35:09 <bitcoin-git> [bitcoin] luke-jr opened pull request #17946: Fix GBT: Restore "!segwit" and "csv" to "rules" key (master...fix_gbt_buried) https://github.com/bitcoin/bitcoin/pull/17946
972020-01-17T05:35:10 *** bitcoin-git has left #bitcoin-core-dev
982020-01-17T05:37:07 *** AaronvanW has joined #bitcoin-core-dev
992020-01-17T05:48:44 *** ddustin has quit IRC
1002020-01-17T05:53:40 *** ppisati has quit IRC
1012020-01-17T06:00:02 *** kutio has quit IRC
1022020-01-17T06:00:23 *** ppisati has joined #bitcoin-core-dev
1032020-01-17T06:11:17 *** AaronvanW has quit IRC
1042020-01-17T06:17:12 *** dfj1 has joined #bitcoin-core-dev
1052020-01-17T06:28:19 *** Kiminuo has joined #bitcoin-core-dev
1062020-01-17T06:58:43 *** hex17or has joined #bitcoin-core-dev
1072020-01-17T06:59:11 *** Highway61 has joined #bitcoin-core-dev
1082020-01-17T07:02:59 *** bitcoin-git has joined #bitcoin-core-dev
1092020-01-17T07:03:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7fb94c0ed418...2ddf041a8d5e
1102020-01-17T07:03:00 <bitcoin-git> bitcoin/master 22c5a98 Peter Bushnell: depends: Consistent use of package variable
1112020-01-17T07:03:01 <bitcoin-git> bitcoin/master 2ddf041 fanquake: Merge #17928: depends: Consistent use of package variable
1122020-01-17T07:03:03 *** bitcoin-git has left #bitcoin-core-dev
1132020-01-17T07:03:19 *** bitcoin-git has joined #bitcoin-core-dev
1142020-01-17T07:03:19 <bitcoin-git> [bitcoin] fanquake merged pull request #17928: depends: Consistent use of package variable (master...patch-4) https://github.com/bitcoin/bitcoin/pull/17928
1152020-01-17T07:03:20 *** bitcoin-git has left #bitcoin-core-dev
1162020-01-17T07:13:47 *** ariard_ has joined #bitcoin-core-dev
1172020-01-17T07:14:33 *** promag has joined #bitcoin-core-dev
1182020-01-17T07:16:25 *** harrigan has quit IRC
1192020-01-17T07:16:27 *** warren_ has joined #bitcoin-core-dev
1202020-01-17T07:17:46 *** harrigan has joined #bitcoin-core-dev
1212020-01-17T07:18:06 *** jimpo has quit IRC
1222020-01-17T07:18:07 *** Madars has quit IRC
1232020-01-17T07:18:07 *** chjj has quit IRC
1242020-01-17T07:18:07 *** Nebraskka has quit IRC
1252020-01-17T07:18:07 *** warren has quit IRC
1262020-01-17T07:18:07 *** tecnovert has quit IRC
1272020-01-17T07:18:07 *** adiabat has quit IRC
1282020-01-17T07:18:08 *** ariard has quit IRC
1292020-01-17T07:18:08 *** sez has quit IRC
1302020-01-17T07:18:08 *** ensign has quit IRC
1312020-01-17T07:18:17 *** Nebraskka_ has joined #bitcoin-core-dev
1322020-01-17T07:19:29 *** promag has quit IRC
1332020-01-17T07:20:14 *** Nebraskka has joined #bitcoin-core-dev
1342020-01-17T07:21:14 *** cdecker has quit IRC
1352020-01-17T07:23:18 *** cdecker has joined #bitcoin-core-dev
1362020-01-17T07:39:21 *** goatpig has joined #bitcoin-core-dev
1372020-01-17T07:43:39 *** harrigan has quit IRC
1382020-01-17T07:44:19 *** harrigan has joined #bitcoin-core-dev
1392020-01-17T08:05:49 *** jimpo has joined #bitcoin-core-dev
1402020-01-17T08:05:50 *** Madars has joined #bitcoin-core-dev
1412020-01-17T08:05:50 *** chjj has joined #bitcoin-core-dev
1422020-01-17T08:05:50 *** tecnovert has joined #bitcoin-core-dev
1432020-01-17T08:05:50 *** adiabat has joined #bitcoin-core-dev
1442020-01-17T08:05:50 *** sez has joined #bitcoin-core-dev
1452020-01-17T08:05:50 *** ensign has joined #bitcoin-core-dev
1462020-01-17T08:07:51 *** AaronvanW has joined #bitcoin-core-dev
1472020-01-17T08:08:42 *** sipsorcery has joined #bitcoin-core-dev
1482020-01-17T08:10:31 *** bitcoin-git has joined #bitcoin-core-dev
1492020-01-17T08:10:31 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2ddf041a8d5e...c20fbb7be864
1502020-01-17T08:10:32 <bitcoin-git> bitcoin/master c279a81 João Barbosa: gui: Remove warning "unused variable 'wallet_model'"
1512020-01-17T08:10:32 <bitcoin-git> bitcoin/master c20fbb7 fanquake: Merge #17939: gui: Remove warning "unused variable 'wallet_model'"
1522020-01-17T08:10:34 *** bitcoin-git has left #bitcoin-core-dev
1532020-01-17T08:10:51 *** bitcoin-git has joined #bitcoin-core-dev
1542020-01-17T08:10:51 <bitcoin-git> [bitcoin] fanquake merged pull request #17939: gui: Remove warning "unused variable 'wallet_model'" (master...2020/01/disable-wallet-unused-variable) https://github.com/bitcoin/bitcoin/pull/17939
1552020-01-17T08:10:52 *** bitcoin-git has left #bitcoin-core-dev
1562020-01-17T08:18:46 *** SiAnDoG__ has joined #bitcoin-core-dev
1572020-01-17T08:19:26 *** promag has joined #bitcoin-core-dev
1582020-01-17T08:21:03 *** SiAnDoG_ has quit IRC
1592020-01-17T08:23:52 *** promag has quit IRC
1602020-01-17T08:26:53 *** volbil has quit IRC
1612020-01-17T08:40:14 *** AaronvanW has quit IRC
1622020-01-17T08:43:28 *** Highway61 has quit IRC
1632020-01-17T08:52:35 *** awalvie_ has joined #bitcoin-core-dev
1642020-01-17T08:52:49 *** promag has joined #bitcoin-core-dev
1652020-01-17T08:53:01 *** awalvie_ has quit IRC
1662020-01-17T08:53:14 *** promag_ has joined #bitcoin-core-dev
1672020-01-17T08:57:39 *** promag has quit IRC
1682020-01-17T08:57:58 *** promag_ has quit IRC
1692020-01-17T09:00:01 *** dfj1 has quit IRC
1702020-01-17T09:02:05 *** turbo_choo has quit IRC
1712020-01-17T09:05:50 *** jcoe has joined #bitcoin-core-dev
1722020-01-17T09:06:16 *** turbo_choo has joined #bitcoin-core-dev
1732020-01-17T09:10:11 *** promag has joined #bitcoin-core-dev
1742020-01-17T09:13:16 *** DeanGuss has quit IRC
1752020-01-17T09:13:36 *** DeanGuss has joined #bitcoin-core-dev
1762020-01-17T09:15:53 *** AaronvanW has joined #bitcoin-core-dev
1772020-01-17T09:17:43 *** maop has joined #bitcoin-core-dev
1782020-01-17T09:41:23 *** vasild has quit IRC
1792020-01-17T09:42:37 *** Kiminuo has quit IRC
1802020-01-17T09:47:47 *** vasild has joined #bitcoin-core-dev
1812020-01-17T09:52:45 *** Zenton has joined #bitcoin-core-dev
1822020-01-17T09:54:32 *** timothy has joined #bitcoin-core-dev
1832020-01-17T09:56:41 *** tsujp has joined #bitcoin-core-dev
1842020-01-17T09:58:09 *** sipa has quit IRC
1852020-01-17T09:58:24 *** sipa has joined #bitcoin-core-dev
1862020-01-17T10:01:07 *** ddustin has joined #bitcoin-core-dev
1872020-01-17T10:01:57 *** fengling has quit IRC
1882020-01-17T10:05:37 *** ddustin has quit IRC
1892020-01-17T10:06:41 *** jonatack has quit IRC
1902020-01-17T10:08:08 *** shigeya has quit IRC
1912020-01-17T10:15:46 *** shigeya has joined #bitcoin-core-dev
1922020-01-17T10:18:43 *** AaronvanW has quit IRC
1932020-01-17T10:21:03 *** dviola has joined #bitcoin-core-dev
1942020-01-17T10:23:29 *** kljasdfvv has quit IRC
1952020-01-17T10:26:31 *** dr-orlovsky has quit IRC
1962020-01-17T10:28:44 *** fengling has joined #bitcoin-core-dev
1972020-01-17T10:48:45 *** belcher has joined #bitcoin-core-dev
1982020-01-17T10:57:40 *** jonatack has joined #bitcoin-core-dev
1992020-01-17T11:02:03 *** ddustin has joined #bitcoin-core-dev
2002020-01-17T11:03:42 *** tys0n_ has joined #bitcoin-core-dev
2012020-01-17T11:03:57 *** Minerva88Becker has joined #bitcoin-core-dev
2022020-01-17T11:06:55 *** ddustin has quit IRC
2032020-01-17T11:16:08 *** bitcoin-git has joined #bitcoin-core-dev
2042020-01-17T11:16:09 <bitcoin-git> [bitcoin] theStack opened pull request #17947: test: add unit test for non-standard txs with too large tx size (master...20200116-test-check-for-non-standard-txs-with-too-large-tx-size) https://github.com/bitcoin/bitcoin/pull/17947
2052020-01-17T11:16:09 *** bitcoin-git has left #bitcoin-core-dev
2062020-01-17T11:19:42 *** AaronvanW has joined #bitcoin-core-dev
2072020-01-17T11:22:01 *** bitcoin-git has joined #bitcoin-core-dev
2082020-01-17T11:22:01 <bitcoin-git> [bitcoin] fanquake closed pull request #17570: test: add unit test for non-standard txs w/ too large tx size (master...test_unit_IsStandardTx_tx-size) https://github.com/bitcoin/bitcoin/pull/17570
2092020-01-17T11:22:11 *** bitcoin-git has left #bitcoin-core-dev
2102020-01-17T11:22:16 *** AaronvanW has quit IRC
2112020-01-17T11:22:34 *** AaronvanW has joined #bitcoin-core-dev
2122020-01-17T11:23:21 *** Minerva88Becker has quit IRC
2132020-01-17T11:28:58 *** Guest83_ has joined #bitcoin-core-dev
2142020-01-17T11:30:39 *** swamp has quit IRC
2152020-01-17T11:35:43 *** Victorsueca has joined #bitcoin-core-dev
2162020-01-17T11:38:31 *** Victorsueca has quit IRC
2172020-01-17T11:42:36 *** Victorsueca has joined #bitcoin-core-dev
2182020-01-17T12:00:01 *** maop has quit IRC
2192020-01-17T12:01:18 *** Guest83_ has quit IRC
2202020-01-17T12:17:26 *** Pysis|work has joined #bitcoin-core-dev
2212020-01-17T12:33:54 *** bitcoin-git has joined #bitcoin-core-dev
2222020-01-17T12:33:55 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c20fbb7be864...0deba680646f
2232020-01-17T12:33:55 <bitcoin-git> bitcoin/master 7d0a8f4 Hennadii Stepanov: refactor: Remove never used default parameter
2242020-01-17T12:33:56 <bitcoin-git> bitcoin/master 1a53b0d Hennadii Stepanov: refactor: Simplify connection syntax
2252020-01-17T12:33:56 <bitcoin-git> bitcoin/master 0deba68 fanquake: Merge #17943: qt, refactor: Remove never used default parameter
2262020-01-17T12:33:58 *** bitcoin-git has left #bitcoin-core-dev
2272020-01-17T12:34:15 *** bitcoin-git has joined #bitcoin-core-dev
2282020-01-17T12:34:15 <bitcoin-git> [bitcoin] fanquake merged pull request #17943: qt, refactor: Remove never used default parameter (master...20200116-message-parameter) https://github.com/bitcoin/bitcoin/pull/17943
2292020-01-17T12:34:16 *** bitcoin-git has left #bitcoin-core-dev
2302020-01-17T12:52:38 *** ddustin has joined #bitcoin-core-dev
2312020-01-17T12:54:18 *** promag has quit IRC
2322020-01-17T12:57:37 *** ddustin has quit IRC
2332020-01-17T12:59:25 *** laurentmt has joined #bitcoin-core-dev
2342020-01-17T13:00:36 *** emilengler has joined #bitcoin-core-dev
2352020-01-17T13:01:50 *** promag has joined #bitcoin-core-dev
2362020-01-17T13:02:19 *** promag has quit IRC
2372020-01-17T13:06:15 *** dr-orlovsky has joined #bitcoin-core-dev
2382020-01-17T13:06:58 *** zavan has joined #bitcoin-core-dev
2392020-01-17T13:10:50 *** dviola has quit IRC
2402020-01-17T13:15:58 *** jonatack has quit IRC
2412020-01-17T13:19:10 *** kljasdfvv has joined #bitcoin-core-dev
2422020-01-17T13:34:01 *** bitcoin-git has joined #bitcoin-core-dev
2432020-01-17T13:34:01 <bitcoin-git> [bitcoin] fanquake opened pull request #17948: build: pass -fno-ident to prevent compilers emitting ident directives (master...pass_fno_ident) https://github.com/bitcoin/bitcoin/pull/17948
2442020-01-17T13:34:02 *** bitcoin-git has left #bitcoin-core-dev
2452020-01-17T13:46:18 *** fox2p has quit IRC
2462020-01-17T13:49:31 *** fox2p has joined #bitcoin-core-dev
2472020-01-17T13:58:59 *** turbo_choo has quit IRC
2482020-01-17T14:00:48 *** ddustin has joined #bitcoin-core-dev
2492020-01-17T14:06:57 *** Guest83_ has joined #bitcoin-core-dev
2502020-01-17T14:07:02 *** laurentmt has quit IRC
2512020-01-17T14:09:15 *** ddustin has quit IRC
2522020-01-17T14:20:01 *** filchef has joined #bitcoin-core-dev
2532020-01-17T14:21:17 *** ddustin has joined #bitcoin-core-dev
2542020-01-17T14:26:20 *** ddustin has quit IRC
2552020-01-17T14:30:20 *** promag has joined #bitcoin-core-dev
2562020-01-17T14:39:15 *** turbo_choo has joined #bitcoin-core-dev
2572020-01-17T14:48:15 *** jonatack has joined #bitcoin-core-dev
2582020-01-17T14:50:02 *** justanotheruser has quit IRC
2592020-01-17T14:57:31 *** Highway61 has joined #bitcoin-core-dev
2602020-01-17T15:00:01 *** Pysis|work has quit IRC
2612020-01-17T15:17:10 *** csadilek has joined #bitcoin-core-dev
2622020-01-17T15:17:55 *** justanotheruser has joined #bitcoin-core-dev
2632020-01-17T15:19:13 *** Guyver2 has joined #bitcoin-core-dev
2642020-01-17T15:20:12 *** promag has quit IRC
2652020-01-17T15:21:26 *** jonatack has quit IRC
2662020-01-17T15:40:12 *** ddustin has joined #bitcoin-core-dev
2672020-01-17T15:41:16 *** Highway61 has quit IRC
2682020-01-17T15:41:27 *** Highway61 has joined #bitcoin-core-dev
2692020-01-17T15:46:05 *** ddustin has quit IRC
2702020-01-17T15:46:40 *** mdunnio has joined #bitcoin-core-dev
2712020-01-17T15:48:40 *** justanotheruser has quit IRC
2722020-01-17T15:54:20 *** justanotheruser has joined #bitcoin-core-dev
2732020-01-17T16:21:43 *** krvopije has joined #bitcoin-core-dev
2742020-01-17T16:24:47 *** zavan has quit IRC
2752020-01-17T16:26:02 *** dr-orlovsky has quit IRC
2762020-01-17T16:29:33 *** Talkless has joined #bitcoin-core-dev
2772020-01-17T16:31:54 *** goatpig has quit IRC
2782020-01-17T16:32:47 *** bitcoin-git has joined #bitcoin-core-dev
2792020-01-17T16:32:47 <bitcoin-git> [bitcoin] emilengler opened pull request #17949: doc: Remove double space in README_windows.txt (master...2020-01-remove-double-space-in-readme-win) https://github.com/bitcoin/bitcoin/pull/17949
2802020-01-17T16:32:58 *** bitcoin-git has left #bitcoin-core-dev
2812020-01-17T16:37:03 *** bitcoin-git has joined #bitcoin-core-dev
2822020-01-17T16:37:03 <bitcoin-git> [bitcoin] emilengler closed pull request #17949: doc: Remove double space in README_windows.txt (master...2020-01-remove-double-space-in-readme-win) https://github.com/bitcoin/bitcoin/pull/17949
2832020-01-17T16:37:14 *** bitcoin-git has left #bitcoin-core-dev
2842020-01-17T16:52:53 *** bitcoin-git has joined #bitcoin-core-dev
2852020-01-17T16:52:53 <bitcoin-git> [bitcoin] emilengler opened pull request #17950: gui: Check the strength of an encryption password (master...2020-01-password-strength-checker) https://github.com/bitcoin/bitcoin/pull/17950
2862020-01-17T16:52:54 *** bitcoin-git has left #bitcoin-core-dev
2872020-01-17T16:54:36 *** promag has joined #bitcoin-core-dev
2882020-01-17T16:57:49 *** turbo_choo has quit IRC
2892020-01-17T16:58:37 *** jonatack has joined #bitcoin-core-dev
2902020-01-17T17:03:27 *** Guest83_ has quit IRC
2912020-01-17T17:10:13 *** promag_ has joined #bitcoin-core-dev
2922020-01-17T17:11:24 *** promag_ has joined #bitcoin-core-dev
2932020-01-17T17:12:19 *** promag has quit IRC
2942020-01-17T17:13:58 *** Zenton has quit IRC
2952020-01-17T17:14:44 *** Highway61 has quit IRC
2962020-01-17T17:16:34 *** Highway61 has joined #bitcoin-core-dev
2972020-01-17T17:17:05 *** kljasdfvv has quit IRC
2982020-01-17T17:19:47 *** emilengler has quit IRC
2992020-01-17T17:22:39 *** bitcoin-git has joined #bitcoin-core-dev
3002020-01-17T17:22:39 <bitcoin-git> [bitcoin] sdaftuar opened pull request #17951: Use rolling bloom filter of recent block txs for AlreadyHave() check (master...2020-01-improve-alreadyhave) https://github.com/bitcoin/bitcoin/pull/17951
3012020-01-17T17:22:41 *** bitcoin-git has left #bitcoin-core-dev
3022020-01-17T17:29:28 *** dr-orlovsky has joined #bitcoin-core-dev
3032020-01-17T17:33:10 *** jarthur has joined #bitcoin-core-dev
3042020-01-17T17:33:52 *** promag_ has quit IRC
3052020-01-17T17:34:07 *** dr-orlovsky has quit IRC
3062020-01-17T17:34:10 *** promag has joined #bitcoin-core-dev
3072020-01-17T17:35:59 *** tys0n_ has quit IRC
3082020-01-17T17:44:03 *** tryphe_ has joined #bitcoin-core-dev
3092020-01-17T17:44:34 *** ddustin_ has joined #bitcoin-core-dev
3102020-01-17T17:45:51 *** ddustin_ has joined #bitcoin-core-dev
3112020-01-17T17:46:04 *** tryphe has quit IRC
3122020-01-17T17:50:02 *** ddustin_ has quit IRC
3132020-01-17T17:56:41 *** krvopije has left #bitcoin-core-dev
3142020-01-17T17:57:41 *** krvopije has joined #bitcoin-core-dev
3152020-01-17T17:57:58 *** justan0theruser has joined #bitcoin-core-dev
3162020-01-17T17:58:47 *** justanotheruser has quit IRC
3172020-01-17T18:00:02 *** csadilek has quit IRC
3182020-01-17T18:02:12 *** bitcoin-git has joined #bitcoin-core-dev
3192020-01-17T18:02:12 <bitcoin-git> [bitcoin] elichai opened pull request #17953: refactor: Abstract boost::variant out (master...2020-01-variant) https://github.com/bitcoin/bitcoin/pull/17953
3202020-01-17T18:02:13 *** bitcoin-git has left #bitcoin-core-dev
3212020-01-17T18:09:18 *** promag has quit IRC
3222020-01-17T18:15:01 *** ghost43_ is now known as ghost43
3232020-01-17T18:17:26 *** ddustin has joined #bitcoin-core-dev
3242020-01-17T18:17:57 *** uptime has joined #bitcoin-core-dev
3252020-01-17T18:18:20 *** uptime is now known as Guest83058
3262020-01-17T18:28:10 *** thelounge2467250 has joined #bitcoin-core-dev
3272020-01-17T18:29:39 *** turbo_choo has joined #bitcoin-core-dev
3282020-01-17T18:34:35 <elichai2> What's the easiest way to locally reproduce weird configuration failures on travis? (ie run CentOS and/or the TSan case) MarcoFalke
3292020-01-17T18:38:28 *** krvopije has quit IRC
3302020-01-17T18:52:15 *** krvopije has joined #bitcoin-core-dev
3312020-01-17T18:52:27 *** krvopije has quit IRC
3322020-01-17T19:00:26 <meshcollider> #startmeeting
3332020-01-17T19:00:26 <lightningbot> Meeting started Fri Jan 17 19:00:26 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
3342020-01-17T19:00:26 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3352020-01-17T19:00:32 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball
3362020-01-17T19:00:38 <kanzure> hi
3372020-01-17T19:00:47 <jnewbery> hi
3382020-01-17T19:00:52 <meshcollider> Welcome to the first wallet meeting for 2020 :)
3392020-01-17T19:00:55 <jonatack> hi
3402020-01-17T19:00:58 <sipa> hi
3412020-01-17T19:01:19 <achow101> hi
3422020-01-17T19:01:34 <wumpus> hi
3432020-01-17T19:02:17 <meshcollider> Does anyone have topic proposals? I'd like to quickly just have a discussion about wallet goals for the longer term since are are getting close to merging #17261
3442020-01-17T19:02:20 <gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 · Pull Request #17261 · bitcoin/bitcoin · GitHub
3452020-01-17T19:03:07 <meshcollider> So wallet boxes are really a shorter term goal now \o/
3462020-01-17T19:03:12 <fjahr> hi
3472020-01-17T19:03:30 <achow101> finally
3482020-01-17T19:03:59 <jonatack> I'd propose the topic of multilabels
3492020-01-17T19:04:24 <jonatack> (after wallet boxes)
3502020-01-17T19:05:56 <achow101> meshcollider: so what are the long term goals?
3512020-01-17T19:06:59 <jnewbery> meshcollider: are you polling for long-term goals or were you going to tell us what your long-term goals are for the wallet?
3522020-01-17T19:07:05 <meshcollider> jnewbery's contributor survey asks everyone what their goals for core are, so if people have been thinking about it, does anyone want to discuss anything they'd like to see in the wallet
3532020-01-17T19:07:10 <meshcollider> Polling :)
3542020-01-17T19:08:00 <achow101> I'd like hardware wallet support :)
3552020-01-17T19:08:25 <achow101> but, in general, I think wallet boxes will let us do a lot more things
3562020-01-17T19:08:39 <jnewbery> clean up the node-wallet interface and make progress towards multiprocess
3572020-01-17T19:09:18 <achow101> and I guess semi-related would be miniscript and generic signing code
3582020-01-17T19:09:37 <meshcollider> yeah I think there will be lots of opportunities for really good cleanups after the boxes are all merged
3592020-01-17T19:10:01 <meshcollider> sipa: anything you envision?
3602020-01-17T19:11:49 <sipa> nothing specifically
3612020-01-17T19:12:03 <meshcollider> Alright awesome, so we do still have some clear longer term goals to continue with +1
3622020-01-17T19:12:20 <meshcollider> #topic Multilabels (jonatack)
3632020-01-17T19:12:23 <wumpus> would also like hardware wallet support
3642020-01-17T19:12:23 <achow101> also descriptor wallets as a mid-term goal
3652020-01-17T19:12:42 *** jungly has quit IRC
3662020-01-17T19:13:31 <jonatack> Multilabels: looking for concept acks on enabling passing an array of labels to
3672020-01-17T19:13:32 <achow101> jonatack: can you explain what you mean by mulitlabels>
3682020-01-17T19:14:10 <jonatack> RPCs setlabel, getnewaddress, importaddress, etc
3692020-01-17T19:14:35 <jonatack> and for listransactions to output an array of labels
3702020-01-17T19:14:52 <jonatack> and for listreceivedbylabels to filter on said array
3712020-01-17T19:15:25 <jonatack> and possibly rm the purpose field in the getaddressesbylabel response
3722020-01-17T19:15:48 <meshcollider> Have you thought about whether the GUI display would all labels for each address?
3732020-01-17T19:15:58 *** krvopije has joined #bitcoin-core-dev
3742020-01-17T19:16:03 <meshcollider> Would display*
3752020-01-17T19:16:07 <achow101> I think purpose is separate from labels
3762020-01-17T19:16:08 <jonatack> and possibly add a case insensitive arg option for the label filtering in getaddressesbylabel and listtransactions
3772020-01-17T19:17:16 <jonatack> meshcollider: i'll admit that i've thought only about the rpc interface so far, if concept ack, would add gui to my thoughts :)
3782020-01-17T19:17:24 <jonatack> achow101: agreed
3792020-01-17T19:17:40 <achow101> concept ack multiple labels on things
3802020-01-17T19:18:00 <meshcollider> Yep supporting multiple labels makes logical sense to me
3812020-01-17T19:18:18 <jonatack> also possibly setlabel could receive an array of addresses as well as an array of labels
3822020-01-17T19:18:41 <achow101> keep in mind api compatibility though
3832020-01-17T19:19:11 <achow101> every place we take a label will need to be able to tae both a string and array of strings otherwise we lose compatibility
3842020-01-17T19:19:28 <achow101> same with output. that could be problematic
3852020-01-17T19:19:31 <meshcollider> Is "purpose" able to be set by the user currently or does it just default to "receive" automatically
3862020-01-17T19:19:35 <jonatack> *etc above also including the importmulti, addmultisigaddress, importprivkey, importpubkey
3872020-01-17T19:19:50 <achow101> meshcollider: I don't think it's user accesible
3882020-01-17T19:20:04 <jonatack> meshcollider: set to receive or send automatically
3892020-01-17T19:20:51 <meshcollider> Sweet
3902020-01-17T19:21:04 <achow101> it's "receive", "send", or "". "" is how we determine change
3912020-01-17T19:21:10 <jonatack> achow101: api compat -- agreed
3922020-01-17T19:21:18 <jonatack> good point
3932020-01-17T19:22:36 <meshcollider> Alright any other topics?
3942020-01-17T19:22:45 <jonatack> achow101: output hmmmmm
3952020-01-17T19:23:55 <jonatack> thanks. any other thoughts hit me up.
3962020-01-17T19:25:57 <meshcollider> Alright I guess that's it for today then
3972020-01-17T19:26:00 <meshcollider> #endmeeting
3982020-01-17T19:26:00 <lightningbot> Meeting ended Fri Jan 17 19:26:00 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3992020-01-17T19:26:00 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-17-19.00.html
4002020-01-17T19:26:00 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-17-19.00.txt
4012020-01-17T19:26:00 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-01-17-19.00.log.html
4022020-01-17T19:27:09 <meshcollider> And remember to send (wallet or otherwise) topic discussion ideas for coredev to John or kanzure or someone
4032020-01-17T19:27:22 *** krvopije has quit IRC
4042020-01-17T19:30:16 <kanzure> thank you meshcollider
4052020-01-17T19:30:36 <kanzure> and remember, if you don't send topics, then i will randomly assign them to you
4062020-01-17T19:34:08 <instagibbs> slept through the meeting oops. For me it's Descriptor-wallets->{HWW/Miniscript} and also more flexible fee-bumping, just *assuming* someday we'll have real fees again
4072020-01-17T19:34:36 <jonatack> instagibbs: sgtm
4082020-01-17T19:34:41 <instagibbs> achow101 did some related prep work which should make auto-CPFP doable
4092020-01-17T19:35:36 <instagibbs> RBF is pretty ok now(anything better is way more complicated), so having CPFP as another tool in the box would be super
4102020-01-17T19:38:00 <instagibbs> #17331 is the PR I mentioned, makes effective value everywhere, kills off stupid CreateTransaction loop that has plagued us for years
4112020-01-17T19:38:02 <gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
4122020-01-17T19:38:20 <achow101> unforunately no one wants to review coin selection
4132020-01-17T19:38:37 <elichai2> I would love to see Descriptor wallets. I hate a PR kinda ready for taproot descriptors so with descriptor wallets I should be able to integrate taproot into the wallet pretty easily
4142020-01-17T19:38:46 <instagibbs> Well, boxing wallet is sucking the air out for now, chill :)
4152020-01-17T19:38:46 <elichai2> (not saying it's anytime soon :P)
4162020-01-17T19:39:21 <instagibbs> achow101, also it doesn't appear you have to rebase yet so not very painful
4172020-01-17T19:40:02 <achow101> instagibbs: on the bright side, no one touches coin selection so it doesn't need rebasing :)
4182020-01-17T19:41:58 <kanzure> i'd rather review a coin selection simulator before i'd view an individual coin selection implementation?
4192020-01-17T19:42:12 <kanzure> e.g. test against variety of circumstances and fee markets
4202020-01-17T19:42:26 <instagibbs> kanzure, well I don't particularly care about the algorithms now, see the above PR
4212020-01-17T19:42:44 <instagibbs> it's mostly structuring txn creation code to be less dumb
4222020-01-17T19:43:04 <achow101> it has a minor impact on the selection algo though
4232020-01-17T19:43:10 <jonatack> achow101: i think coin control is interesting :) am just constrained by amount of free time i can spend on bitcoin core
4242020-01-17T19:43:41 <instagibbs> If you're ok with being a UTXO cop, I think Core selection is fine. It's when people are dusting you it costs.
4252020-01-17T19:44:14 <instagibbs> Verbose and too complicated, but fine :)
4262020-01-17T19:47:38 <elichai2> I'll try again :) Any tips on how to recreate failed travis enviroments locally? I have two weird failures in travis I want to test locally (CentOS one and `x86_64 Linux [GOAL: install] [xenial] [no depends, only system libs, sanitizers: thread (TSan), no wallet]`)
4272020-01-17T19:49:08 <jonatack> elichai2: the failing travis logs are unhelpful?
4282020-01-17T19:49:43 <elichai2> jonatack: basically compile errors. now I need to figure out why it compiles on some machines and other not
4292020-01-17T19:50:04 <achow101> elichai2: what pr?
4302020-01-17T19:50:10 <achow101> or travis job
4312020-01-17T19:50:17 <elichai2> https://github.com/bitcoin/bitcoin/pull/17953
4322020-01-17T19:50:29 <elichai2> the 2 Mac ones I know, my problem is with the other 2
4332020-01-17T19:51:20 *** bitcoin-git has joined #bitcoin-core-dev
4342020-01-17T19:51:21 <bitcoin-git> [bitcoin] ryanofsky opened pull request #17954: wallet: Remove calls to Chain::Lock methods in wallet (master...pr/unlock) https://github.com/bitcoin/bitcoin/pull/17954
4352020-01-17T19:51:22 *** bitcoin-git has left #bitcoin-core-dev
4362020-01-17T19:51:32 <elichai2> jonatack: especially when travis doesn't print the exact commands being run :/
4372020-01-17T19:52:37 <achow101> elichai2: all of the commands travis runs are in .travis.yml
4382020-01-17T19:53:01 <achow101> it calls a bunch of scripts in ci/
4392020-01-17T19:53:25 <achow101> those'll have all of the configure commands so you can replicate the config
4402020-01-17T19:53:33 <elichai2> achow101: well you need to chase enviroment variables to figure out the exact commands, that what I'm doing now, launched a docker and trying to recreate the env, I think I was able to recreate the TSan error
4412020-01-17T19:53:51 <elichai2> hopes there's a ./run_ci_locally lol
4422020-01-17T19:54:10 <jonatack> elichai2: i avoid docker like the plague but yeah was thinking test those build environments with it
4432020-01-17T19:54:30 <elichai2> jonatack: well easier to have the right g++ version with dockers
4442020-01-17T19:54:46 *** justan0theruser is now known as justanotheruser
4452020-01-17T19:56:01 <jonatack> yes. and maybe push on a different branch running travis locally for the final checks
4462020-01-17T19:56:23 <elichai2> jonatack: right. that's usually what I do after I think i've fixed it
4472020-01-17T19:56:35 <jonatack> with just the problematic builds. right. sorry not more helpful
4482020-01-17T19:56:51 <elichai2> hmm the Tsan one seems to be either an error in boost or the fact that it's g++5.4 :( I guess I need to include the whole module because of that, why distros why :(
4492020-01-17T19:57:34 <achow101> elichai2: you can make a new private repo and setup travis debug builds
4502020-01-17T19:57:50 <elichai2> achow101: good idea, i'll add `set -x`
4512020-01-17T19:57:51 <achow101> then you can ssh into the travis vm and do things there
4522020-01-17T19:58:00 <elichai2> you can ssh into travis?!
4532020-01-17T19:58:07 <achow101> https://docs.travis-ci.com/user/running-build-in-debug-mode/
4542020-01-17T19:58:13 <achow101> private repos only
4552020-01-17T19:58:27 <jonatack> til. cool
4562020-01-17T19:58:54 <elichai2> :D Thanks
4572020-01-17T19:59:35 <achow101> one thing though, the vms tend to crash when you try to do too much or take too long. happens to me quite a bit
4582020-01-17T19:59:35 <luke-jr> it's annoying tho
4592020-01-17T19:59:45 <luke-jr> if a step fails, it kills the session still
4602020-01-17T19:59:46 <achow101> also private repos are low priority so builds run one at a time and take forever
4612020-01-17T19:59:49 <luke-jr> and there's a time limit
4622020-01-17T20:00:29 <achow101> I only use it when I can't figure out the problem from logs or replicate it locally
4632020-01-17T20:07:25 <luke-jr> travis logs have been super annoying lately IMO - sometimes I enter debug mode simply because I can't figure out *what* failed
4642020-01-17T20:10:45 *** Zenton has joined #bitcoin-core-dev
4652020-01-17T20:15:28 *** tys0n_ has joined #bitcoin-core-dev
4662020-01-17T20:23:44 *** krvopije has joined #bitcoin-core-dev
4672020-01-17T20:43:15 *** emilengler has joined #bitcoin-core-dev
4682020-01-17T20:46:32 *** timothy has quit IRC
4692020-01-17T20:49:22 *** SiAnDoG__ has quit IRC
4702020-01-17T20:49:49 *** SiAnDoG__ has joined #bitcoin-core-dev
4712020-01-17T20:53:41 *** Guyver2_ has joined #bitcoin-core-dev
4722020-01-17T20:55:32 *** Talkless has quit IRC
4732020-01-17T20:57:03 *** Guyver2 has quit IRC
4742020-01-17T21:00:01 *** Guest83058 has quit IRC
4752020-01-17T21:12:32 *** luke-jr has quit IRC
4762020-01-17T21:14:41 *** emilengler has quit IRC
4772020-01-17T21:17:33 *** Linoleum has joined #bitcoin-core-dev
4782020-01-17T21:25:06 *** jcoe has quit IRC
4792020-01-17T21:25:32 *** jcoe has joined #bitcoin-core-dev
4802020-01-17T21:27:27 *** Guyver2_ has quit IRC
4812020-01-17T21:31:49 *** justanotheruser has quit IRC
4822020-01-17T21:40:43 *** vasild has quit IRC
4832020-01-17T21:42:44 *** vasild has joined #bitcoin-core-dev
4842020-01-17T22:03:45 *** jcoe has quit IRC
4852020-01-17T22:04:03 *** jcoe has joined #bitcoin-core-dev
4862020-01-17T22:04:25 *** dongcarl has joined #bitcoin-core-dev
4872020-01-17T22:07:17 *** krvopije has quit IRC
4882020-01-17T22:08:36 *** Jackielove4u has quit IRC
4892020-01-17T22:10:02 *** Eric3 has quit IRC
4902020-01-17T22:10:52 *** ExEric3 has joined #bitcoin-core-dev
4912020-01-17T22:12:29 *** filchef has quit IRC
4922020-01-17T22:19:35 *** justanotheruser has joined #bitcoin-core-dev
4932020-01-17T22:20:34 <fanquake> kanzure what do you mean by randomly assign topics?
4942020-01-17T22:20:50 <kanzure> fanquake: just joking :-)
4952020-01-17T22:21:06 <kanzure> fanquake: usually i write down topics that i think certain people should talk about
4962020-01-17T22:21:18 <kanzure> fanquake: but usually it's not so random and instead based on what people have been working on that i happen to know about
4972020-01-17T22:21:38 <fanquake> ð
4982020-01-17T22:21:49 *** jeremyrubin has joined #bitcoin-core-dev
4992020-01-17T22:22:42 *** AaronvanW has quit IRC
5002020-01-17T22:47:09 *** promag has joined #bitcoin-core-dev
5012020-01-17T22:56:10 *** AaronvanW has joined #bitcoin-core-dev
5022020-01-17T23:00:26 *** AaronvanW has quit IRC
5032020-01-17T23:09:32 *** jeremyrubin has quit IRC
5042020-01-17T23:12:56 *** tys0n_ has quit IRC
5052020-01-17T23:14:42 *** krvopije has joined #bitcoin-core-dev
5062020-01-17T23:18:26 *** jarthur has quit IRC
5072020-01-17T23:22:29 *** mdunnio has quit IRC
5082020-01-17T23:27:07 *** julien-boudry has joined #bitcoin-core-dev
5092020-01-17T23:28:21 *** AaronvanW has joined #bitcoin-core-dev
5102020-01-17T23:30:42 *** Highway62 has joined #bitcoin-core-dev
5112020-01-17T23:30:43 *** julien-boudry has quit IRC
5122020-01-17T23:32:02 *** Highway61 has quit IRC
5132020-01-17T23:32:03 *** Highway62 is now known as Highway61
5142020-01-17T23:33:45 *** owowo has quit IRC
5152020-01-17T23:38:58 *** owowo has joined #bitcoin-core-dev
5162020-01-17T23:45:47 *** turbo_choo has quit IRC