12015-11-23T00:01:58 *** tripleslash has quit IRC
22015-11-23T00:04:06 *** tripleslash has joined #bitcoin-core-dev
32015-11-23T00:06:17 *** tripleslash_k has joined #bitcoin-core-dev
42015-11-23T00:08:56 *** tripleslash has quit IRC
52015-11-23T00:10:30 *** tripleslash_k has quit IRC
62015-11-23T00:14:10 *** jtimon has quit IRC
72015-11-23T00:17:07 *** tripleslash has joined #bitcoin-core-dev
82015-11-23T00:18:19 *** jtimon has joined #bitcoin-core-dev
92015-11-23T00:21:27 *** tripleslash has quit IRC
102015-11-23T00:27:29 *** tripleslash has joined #bitcoin-core-dev
112015-11-23T00:45:26 *** jtimon has quit IRC
122015-11-23T00:49:38 *** jtimon has joined #bitcoin-core-dev
132015-11-23T00:56:13 *** dgenr8 has quit IRC
142015-11-23T00:57:42 *** tripleslash has quit IRC
152015-11-23T00:58:08 *** arowser has joined #bitcoin-core-dev
162015-11-23T01:00:42 *** jtimon has quit IRC
172015-11-23T01:04:28 *** jtimon has joined #bitcoin-core-dev
182015-11-23T01:28:06 *** JackH has quit IRC
192015-11-23T01:30:12 *** tripleslash has joined #bitcoin-core-dev
202015-11-23T01:35:04 *** tripleslash has quit IRC
212015-11-23T01:37:24 *** tripleslash has joined #bitcoin-core-dev
222015-11-23T01:39:52 *** tripleslash_c has joined #bitcoin-core-dev
232015-11-23T01:41:45 *** tripleslash has quit IRC
242015-11-23T01:44:06 *** tripleslash_c has quit IRC
252015-11-23T01:44:28 *** Ylbam has quit IRC
262015-11-23T01:50:42 *** tripleslash has joined #bitcoin-core-dev
272015-11-23T02:06:20 *** tripleslash has quit IRC
282015-11-23T02:10:58 <GitHub54> [bitcoin] arowser opened pull request #7078: uint256::GetCheapHash bigendian compatibility (master...ppc) https://github.com/bitcoin/bitcoin/pull/7078
292015-11-23T02:13:44 <GitHub96> [bitcoin] gmaxwell opened pull request #7079: Prevent peer flooding inv request queue (redux) (redux) (master...setAskFor) https://github.com/bitcoin/bitcoin/pull/7079
302015-11-23T02:16:25 *** tripleslash has joined #bitcoin-core-dev
312015-11-23T02:18:44 *** tripleslash_g has joined #bitcoin-core-dev
322015-11-23T02:20:59 *** tripleslash has quit IRC
332015-11-23T02:25:59 *** belcher has quit IRC
342015-11-23T02:40:45 <gmaxwell> Luke-Jr: where is your sigops limiting patch?
352015-11-23T02:41:06 *** tripleslash_g has quit IRC
362015-11-23T02:41:29 <Luke-Jr> https://github.com/luke-jr/bitcoin/commit/a524f5449ecffebfeae7df3da36c109357fc2e1e
372015-11-23T02:43:06 <gmaxwell> what are you setting it to?
382015-11-23T02:43:32 <Luke-Jr> 20
392015-11-23T02:45:50 *** tripleslash has joined #bitcoin-core-dev
402015-11-23T02:46:16 <gmaxwell> okay, thats safe, I think, in terms of not getting tripped up by transactions with lots of p2pkh outputs. Can you PR that with the default of 20?
412015-11-23T02:46:34 <gmaxwell> each p2pkh output adds 34 bytes, so still above your threshold.
422015-11-23T02:49:30 <gmaxwell> ratio of limits is 50, so in theory 20 could still be used in an attack, but not a very interesting attack.
432015-11-23T02:50:06 *** tripleslash has quit IRC
442015-11-23T02:53:26 <Luke-Jr> should the default be 34 then?
452015-11-23T02:55:16 <gmaxwell> Luke-Jr: well the other thing this screws over is non-p2sh multisig,
462015-11-23T02:55:44 <Luke-Jr> "screws over" only in policy.. and frankly, people should policy be blocking bare multisig anyway
472015-11-23T02:56:14 <gmaxwell> I think 20 is fine.
482015-11-23T02:56:32 <Luke-Jr> k
492015-11-23T02:57:32 <gmaxwell> It makes attacking uninteresting... at worst the attack effectively limits the blocksize to 400k. Which isn't so far from the average in any case.
502015-11-23T02:58:06 *** guest234234 has quit IRC
512015-11-23T03:00:03 *** tripleslash has joined #bitcoin-core-dev
522015-11-23T03:10:08 <GitHub1> [bitcoin] luke-jr opened pull request #7081: -bytespersigop option to additionally limit sigops in transactions we relay and mine (master...bytespersigop) https://github.com/bitcoin/bitcoin/pull/7081
532015-11-23T03:10:10 <Luke-Jr> gmaxwell: ^
542015-11-23T03:12:06 *** tripleslash has quit IRC
552015-11-23T03:21:29 *** tripleslash has joined #bitcoin-core-dev
562015-11-23T03:25:46 *** tripleslash has quit IRC
572015-11-23T03:37:35 *** tripleslash has joined #bitcoin-core-dev
582015-11-23T03:37:54 *** davec has quit IRC
592015-11-23T03:38:24 *** davec has joined #bitcoin-core-dev
602015-11-23T03:43:29 *** tripleslash has quit IRC
612015-11-23T03:54:43 <GitHub70> [bitcoin] gmaxwell opened pull request #7082: Do not absolutely protect local peers and make eviction more aggressive. (master...evict_more) https://github.com/bitcoin/bitcoin/pull/7082
622015-11-23T03:56:13 *** PaulCape_ has quit IRC
632015-11-23T03:56:26 *** adam3us has quit IRC
642015-11-23T03:56:35 *** PaulCapestany has joined #bitcoin-core-dev
652015-11-23T03:57:55 *** tripleslash has joined #bitcoin-core-dev
662015-11-23T04:02:38 *** tripleslash has quit IRC
672015-11-23T04:03:09 *** dgenr8 has joined #bitcoin-core-dev
682015-11-23T04:05:28 <phantomcircuit> first ssd failure
692015-11-23T04:07:20 *** tulip has joined #bitcoin-core-dev
702015-11-23T04:41:35 *** guest234234 has joined #bitcoin-core-dev
712015-11-23T04:55:06 *** Luke-Jr has quit IRC
722015-11-23T04:55:40 *** Luke-Jr has joined #bitcoin-core-dev
732015-11-23T05:02:46 *** CodeShark has joined #bitcoin-core-dev
742015-11-23T05:04:53 *** Luke-Jr has quit IRC
752015-11-23T05:08:54 *** tripleslash has joined #bitcoin-core-dev
762015-11-23T05:21:10 <phantomcircuit> gmaxwell, well... being able to process the expensive script sigs in parallel would improve the pipelining
772015-11-23T05:56:13 *** tripleslash has quit IRC
782015-11-23T06:07:29 *** pigeons has quit IRC
792015-11-23T06:08:00 *** pigeons has joined #bitcoin-core-dev
802015-11-23T06:08:22 *** pigeons is now known as Guest32712
812015-11-23T06:17:32 *** adam3us has joined #bitcoin-core-dev
822015-11-23T06:27:28 *** tripleslash has joined #bitcoin-core-dev
832015-11-23T06:34:06 *** tripleslash has quit IRC
842015-11-23T06:44:48 *** adam3us has quit IRC
852015-11-23T06:49:19 *** adam3us has joined #bitcoin-core-dev
862015-11-23T07:03:54 <BlueMatt> comical gcc brokenness of the day: gcc does not print a warning (even with -Wextra) when you compile this http://pastebin.com/BFH5xzx0
872015-11-23T07:04:01 <BlueMatt> hint: it prints "1 2" not "1 3"
882015-11-23T07:08:04 *** tripleslash has joined #bitcoin-core-dev
892015-11-23T07:12:05 <aj> BlueMatt: hmm llvm/clang doesn't either...
902015-11-23T07:12:42 *** tripleslash has quit IRC
912015-11-23T07:16:41 <gmaxwell> In C code I generally consider use of [] in prototypes to be an error in and of itself; I'd never considered the lovely interactions with C++.
922015-11-23T07:28:19 *** tulip has quit IRC
932015-11-23T07:35:04 *** Thireus has quit IRC
942015-11-23T07:42:32 <midnightmagic> like a weird sort of .. union or something.
952015-11-23T07:42:48 *** adam3us has quit IRC
962015-11-23T07:43:40 <gmaxwell> well I guessed the correct behavior (knowing from the setup it would be 'weird'), that it would behave like a type coerced struct. But I was surprised that didn't elicit a warning.
972015-11-23T07:44:05 <gmaxwell> So much for type safty, then again array protypes do awful stuff in plain C.
982015-11-23T07:46:33 <midnightmagic> I always thought arrays made a lot of sense in C, personally, but C++ prototypes aren't nearly so intelligible..
992015-11-23T07:52:20 *** tripleslash has joined #bitcoin-core-dev
1002015-11-23T08:26:18 <aj> midnightmagic: you can get the same behaviour in C with struct A { int a; } struct B { struct A a; int b; } and go(&bs[0].a); though it's a bit more obvious what you're doing wrong there...
1012015-11-23T08:32:47 *** midnightmagic has quit IRC
1022015-11-23T08:37:30 *** tripleslash has quit IRC
1032015-11-23T08:38:53 *** tulip has joined #bitcoin-core-dev
1042015-11-23T08:50:10 *** tripleslash has joined #bitcoin-core-dev
1052015-11-23T09:04:58 *** JackH has joined #bitcoin-core-dev
1062015-11-23T09:10:22 *** Guyver2 has joined #bitcoin-core-dev
1072015-11-23T09:29:51 *** Luke-Jr has joined #bitcoin-core-dev
1082015-11-23T09:32:56 *** tripleslash has quit IRC
1092015-11-23T09:49:30 *** guest234234 has quit IRC
1102015-11-23T09:53:28 *** tripleslash has joined #bitcoin-core-dev
1112015-11-23T09:57:51 *** tripleslash has quit IRC
1122015-11-23T09:58:49 *** rubensayshi has joined #bitcoin-core-dev
1132015-11-23T10:07:07 *** tripleslash has joined #bitcoin-core-dev
1142015-11-23T10:07:09 *** randy-waterhouse has quit IRC
1152015-11-23T10:09:15 *** d_t has quit IRC
1162015-11-23T10:09:18 *** tripleslash_h has joined #bitcoin-core-dev
1172015-11-23T10:11:26 *** tripleslash has quit IRC
1182015-11-23T10:14:20 *** Ylbam has joined #bitcoin-core-dev
1192015-11-23T10:16:12 *** tripleslash_h has quit IRC
1202015-11-23T10:34:19 *** tripleslash has joined #bitcoin-core-dev
1212015-11-23T10:38:58 *** tripleslash has quit IRC
1222015-11-23T10:43:26 *** tripleslash has joined #bitcoin-core-dev
1232015-11-23T11:08:14 *** Thireus has joined #bitcoin-core-dev
1242015-11-23T11:27:31 *** Thireus has quit IRC
1252015-11-23T11:28:00 *** Thireus has joined #bitcoin-core-dev
1262015-11-23T11:29:06 *** Thireus has joined #bitcoin-core-dev
1272015-11-23T11:47:53 *** guest234234 has joined #bitcoin-core-dev
1282015-11-23T11:55:06 *** tripleslash has quit IRC
1292015-11-23T11:59:37 *** tripleslash has joined #bitcoin-core-dev
1302015-11-23T12:04:22 *** tripleslash has quit IRC
1312015-11-23T12:12:16 *** tripleslash has joined #bitcoin-core-dev
1322015-11-23T12:26:34 *** arowser has quit IRC
1332015-11-23T12:27:01 *** arowser has joined #bitcoin-core-dev
1342015-11-23T12:29:30 *** tripleslash has quit IRC
1352015-11-23T12:35:37 *** Jetflame has joined #bitcoin-core-dev
1362015-11-23T12:41:57 *** tripleslash has joined #bitcoin-core-dev
1372015-11-23T12:42:21 *** Jetflame has quit IRC
1382015-11-23T12:46:06 *** tripleslash has quit IRC
1392015-11-23T12:46:06 *** tripleslash_d has joined #bitcoin-core-dev
1402015-11-23T12:49:54 *** Guest32712 is now known as pigeons
1412015-11-23T12:51:17 *** tripleslash_d has quit IRC
1422015-11-23T12:53:06 *** tripleslash has joined #bitcoin-core-dev
1432015-11-23T12:53:14 *** dcousens has joined #bitcoin-core-dev
1442015-11-23T13:03:46 *** dcousens has quit IRC
1452015-11-23T13:18:19 *** midnightmagic has joined #bitcoin-core-dev
1462015-11-23T13:18:47 *** tripleslash has quit IRC
1472015-11-23T13:28:45 *** arowser has quit IRC
1482015-11-23T13:29:31 *** arowser has joined #bitcoin-core-dev
1492015-11-23T13:53:08 *** tripleslash has joined #bitcoin-core-dev
1502015-11-23T14:02:52 *** guest234234 has quit IRC
1512015-11-23T14:10:35 *** tulip has quit IRC
1522015-11-23T14:16:50 *** tripleslash has quit IRC
1532015-11-23T14:19:57 *** treehug8_ has joined #bitcoin-core-dev
1542015-11-23T14:20:27 *** treehug8_ has quit IRC
1552015-11-23T14:22:33 *** tripleslash has joined #bitcoin-core-dev
1562015-11-23T14:23:26 *** adam3us has joined #bitcoin-core-dev
1572015-11-23T14:55:12 *** ParadoxSpiral has joined #bitcoin-core-dev
1582015-11-23T15:53:32 *** adam3us has quit IRC
1592015-11-23T15:57:11 *** zookolaptop has joined #bitcoin-core-dev
1602015-11-23T16:02:51 *** skyraider has joined #bitcoin-core-dev
1612015-11-23T16:21:43 <sdaftuar_> sipa: i think i'm going to rework the direct fetch logic in 6494... not sure how i missed this before but i realized this morning (while trying to fix a different issue) that limiting direct fetch to the blocks announced in a headers message is a bit broken
1622015-11-23T16:22:04 <sdaftuar_> really we want to direct fetch all the blocks that lead to the tip (even if we already had an intermediate header, and hence it wasn't announced to us)
1632015-11-23T16:22:37 *** sdaftuar_ is now known as sdaftuar
1642015-11-23T16:24:09 *** paveljanik has joined #bitcoin-core-dev
1652015-11-23T16:24:09 *** paveljanik has joined #bitcoin-core-dev
1662015-11-23T16:39:07 *** moli has quit IRC
1672015-11-23T16:41:47 *** molly has joined #bitcoin-core-dev
1682015-11-23T16:56:19 *** treehug88 has joined #bitcoin-core-dev
1692015-11-23T17:01:37 *** adam3us has joined #bitcoin-core-dev
1702015-11-23T17:04:53 <bsm1175321> BlueMatt that sucks. It's because sizeof(A) = 4 and sizeof(B) = 8.
1712015-11-23T17:07:34 *** Thireus has quit IRC
1722015-11-23T17:07:36 <sipa> BlueMatt: in function prototypes, [] reduces to *, so your function is accepring a pointer to A :)
1732015-11-23T17:08:17 <sipa> (though a warning would be appropriate, even if it's strictly allowed)
1742015-11-23T17:08:20 <bsm1175321> I agree a warning would be appropriate. It's just mean.
1752015-11-23T17:08:51 <sipa> they have other "helpful" warnings anyway for perfectly legal things, like not using the result of a comparison, or ambiguous parenthesis
1762015-11-23T17:33:16 *** adam3us has quit IRC
1772015-11-23T17:45:37 *** ParadoxSpiral_ has joined #bitcoin-core-dev
1782015-11-23T17:48:11 *** ParadoxSpiral has quit IRC
1792015-11-23T17:51:10 *** adam3us has joined #bitcoin-core-dev
1802015-11-23T17:57:46 *** treehug88 has quit IRC
1812015-11-23T18:01:29 *** adam3us has quit IRC
1822015-11-23T18:02:10 *** adam3us has joined #bitcoin-core-dev
1832015-11-23T18:02:32 *** rubensayshi has quit IRC
1842015-11-23T18:05:16 <GitHub151> [bitcoin] MarcoFalke opened pull request #7083: [init] Print OpenSSL version fix (master...MarcoFalke-2015-initOpenSSL) https://github.com/bitcoin/bitcoin/pull/7083
1852015-11-23T18:05:54 *** adam3us has quit IRC
1862015-11-23T18:06:19 *** MarcoFalke has joined #bitcoin-core-dev
1872015-11-23T18:14:08 *** d_t has joined #bitcoin-core-dev
1882015-11-23T18:16:38 *** adam3us has joined #bitcoin-core-dev
1892015-11-23T19:15:57 <sdaftuar> sipa: it looks like the parallel fetch logic causes a node to download towards a tip that has the same work as chainActive.Tip(), can you confirm that is correct and intentional?
1902015-11-23T19:17:05 <sdaftuar> i had written the direct fetch logic to only fetch towards a tip that had more work than chainActive.Tip(); i assume i should change it to match what's happening in FindNextBlocksToDownload
1912015-11-23T19:21:38 *** andytoshi has quit IRC
1922015-11-23T19:21:39 *** andytoshi has joined #bitcoin-core-dev
1932015-11-23T19:22:10 <sipa> sdaftuar: it's intentional, but you're making me question the reason behind it
1942015-11-23T19:22:52 <sdaftuar> sipa: well i don't think it's crazy to download it -- seems like it would help reorgs propagate faster between peers on different forks
1952015-11-23T19:23:40 <sipa> sdaftuar: it is ppssible that we already have the tip, and in fact had it earlier than the tip we are currently at; if we fetch the blocks in between, we should switch to it
1962015-11-23T19:23:54 <sdaftuar> ah good point
1972015-11-23T19:24:00 <sdaftuar> oh
1982015-11-23T19:24:07 <sdaftuar> no i think that's incorrect
1992015-11-23T19:24:09 <sipa> that is testable, though
2002015-11-23T19:24:29 *** Ylbam has quit IRC
2012015-11-23T19:24:31 <sdaftuar> we shouldn't and don't prefer a block unless it and all parents arrived first
2022015-11-23T19:25:15 <sipa> i think you're right that we shouldn't
2032015-11-23T19:25:18 <sipa> but i think we do
2042015-11-23T19:25:21 <sdaftuar> #6010
2052015-11-23T19:25:26 <sdaftuar> we fixed this earlier this year
2062015-11-23T19:25:30 <sipa> we only compare the tips nSequence
2072015-11-23T19:25:32 <sipa> oh, ok!
2082015-11-23T19:25:52 <BlueMatt> sipa: yea, I knew it wouldnt work when I wrote it, I was just writing code and was like "oh i should...wait, no, that cant work....I wonder if that even compiles...wait, no warning?!"
2092015-11-23T19:26:25 *** arowser has quit IRC
2102015-11-23T19:26:33 <sipa> BlueMatt: fair reaction
2112015-11-23T19:26:50 <sdaftuar> i think i'll just make the direct fetch logic mirror the existing behavior in FindNextBlocksToDownload...
2122015-11-23T19:27:01 <sipa> sdaftuar: ack
2132015-11-23T19:27:02 *** arowser has joined #bitcoin-core-dev
2142015-11-23T19:28:19 <gmaxwell> BlueMatt: ping on PR 6915
2152015-11-23T19:36:55 <GitHub164> [bitcoin] MarcoFalke opened pull request #7084: mempool: Replace maxFeeRate of 10000*minRelayTxFee with maxTxFee (master...MarcoFalke-2015-mempoolMaxTxFee) https://github.com/bitcoin/bitcoin/pull/7084
2162015-11-23T19:40:46 <MarcoFalke> sdaftuar, Do you plan to address the nit in 7063?
2172015-11-23T19:41:02 <MarcoFalke> The code looks clean so you get my ACK anyway, just asking.
2182015-11-23T19:43:46 <sdaftuar> MarcoFalke: i was going to look at it again next week if it wasn't merged by then! trying to get the other PRs tagged for 0.12 ready before the feature freeze
2192015-11-23T19:45:48 <sdaftuar> sipa: i'm going to push updates to 6494. i had to rework the direct fetch logic somewhat substantially :( would you prefer to see the original commit you already reviewed, or should i squash down now?
2202015-11-23T20:00:27 <sipa> sdaftuar: feel free to squash
2212015-11-23T20:45:30 *** lightningbot has joined #bitcoin-core-dev
2222015-11-23T20:47:35 *** wangchun has joined #bitcoin-core-dev
2232015-11-23T20:48:25 *** aj_ has joined #bitcoin-core-dev
2242015-11-23T20:48:36 *** aj_ is now known as aj
2252015-11-23T20:49:27 *** aj has quit IRC
2262015-11-23T20:49:34 *** aj has joined #bitcoin-core-dev
2272015-11-23T20:50:10 <sdaftuar> sipa: thanks, done
2282015-11-23T20:53:54 <sdaftuar> BlueMatt: regarding #6915, do you think we should just repeat the logic that's in CheckFinalTx each place we invoke mempool.removeForReorg():
2292015-11-23T20:54:11 <sdaftuar> const int64_t nBlockTime = (flags & LOCKTIME_MEDIAN_TIME_PAST)
2302015-11-23T20:54:11 <sdaftuar> ? chainActive.Tip()->GetMedianTimePast()
2312015-11-23T20:54:11 <sdaftuar> : GetAdjustedTime();
2322015-11-23T21:03:41 *** davec has quit IRC
2332015-11-23T21:04:12 *** davec has joined #bitcoin-core-dev
2342015-11-23T21:08:48 <sdaftuar> that seems not so bad, just tried it out and replaced the last commit in #6915 with one that does this instead.
2352015-11-23T21:13:20 *** d4de has joined #bitcoin-core-dev
2362015-11-23T21:24:15 *** PaulCape_ has joined #bitcoin-core-dev
2372015-11-23T21:25:43 *** PaulCapestany has quit IRC
2382015-11-23T22:44:33 *** lightningbot has joined #bitcoin-core-dev
2392015-11-23T22:58:42 *** treehug88 has quit IRC
2402015-11-23T23:08:50 *** ParadoxSpiral_ has quit IRC
2412015-11-23T23:12:45 *** guest234234 has joined #bitcoin-core-dev
2422015-11-23T23:14:45 *** tulip has joined #bitcoin-core-dev
2432015-11-23T23:16:04 *** randy-waterhouse has joined #bitcoin-core-dev
2442015-11-23T23:17:02 <BlueMatt> sdaftuar: wait, I'm confused...this doesnt seem right
2452015-11-23T23:17:40 <BlueMatt> sdaftuar: the rule is block-time-cannot-go-back-from-MTP
2462015-11-23T23:17:55 <BlueMatt> sdaftuar: so the rule for mempool removal should be max(GMTP(), GetAdjustedTime())
2472015-11-23T23:21:34 <BlueMatt> oops, nvm
2482015-11-23T23:23:01 <BlueMatt> anyway, I'd prefer to not duplicate the code....can we pull that out into a function?
2492015-11-23T23:23:04 <BlueMatt> but, yea, i like that better
2502015-11-23T23:23:07 * BlueMatt -> lunch
2512015-11-23T23:57:01 *** droark has joined #bitcoin-core-dev