12015-12-04T00:01:13 <GitHub68> [bitcoin] jameshilliard opened pull request #7167: Move TestBlockValidity into a background thread (master...TBVBackground) https://github.com/bitcoin/bitcoin/pull/7167
22015-12-04T00:36:19 <phantomcircuit> so we should probably reconsider a block that's marked invalid once for every valid header on top of it (since we cant tell if the blocks on top are invalid)
32015-12-04T00:36:30 <phantomcircuit> that might help with the "my system is shitty and randomly flips bits" people
42015-12-04T00:41:02 <gmaxwell> I'm not really comfortable with people running wallets on such systems; not at least until we add a fair bit more protection.
52015-12-04T00:44:47 <tulip> maybe just run CheckBlock in a loop until the bit happens to flip back.
62015-12-04T01:04:51 <phantomcircuit> gmaxwell, fair
72015-12-04T01:05:02 <phantomcircuit> tulip, har
82015-12-04T01:20:17 *** Ylbam has quit IRC
92015-12-04T01:23:04 *** Tera2342 has quit IRC
102015-12-04T01:29:29 *** tulip has quit IRC
112015-12-04T01:35:06 *** tulip- has joined #bitcoin-core-dev
122015-12-04T01:36:42 *** tulip- has quit IRC
132015-12-04T01:37:01 *** tulip- has joined #bitcoin-core-dev
142015-12-04T01:38:10 *** tulip- has quit IRC
152015-12-04T01:38:10 *** tulip- has joined #bitcoin-core-dev
162015-12-04T01:39:50 *** tulp has joined #bitcoin-core-dev
172015-12-04T01:51:14 *** belcher has quit IRC
182015-12-04T01:57:33 *** tulp has quit IRC
192015-12-04T02:08:22 *** tulp has joined #bitcoin-core-dev
202015-12-04T02:08:31 *** tulp has left #bitcoin-core-dev
212015-12-04T02:08:36 *** tulp has joined #bitcoin-core-dev
222015-12-04T02:30:28 *** tulp is now known as tulip
232015-12-04T03:05:35 *** CodeShark_ has joined #bitcoin-core-dev
242015-12-04T03:15:34 *** zookolaptop has quit IRC
252015-12-04T03:36:35 *** aj has quit IRC
262015-12-04T03:43:59 *** aj has joined #bitcoin-core-dev
272015-12-04T04:14:56 <GitHub149> [bitcoin] tadasvaranavicius opened pull request #7168: Fix socket recv buffer bug (master...fix_network_buffer_bug) https://github.com/bitcoin/bitcoin/pull/7168
282015-12-04T04:23:11 *** droark has joined #bitcoin-core-dev
292015-12-04T04:35:53 <GitHub179> [bitcoin] tadasvaranavicius closed pull request #7168: Fix socket recv buffer bug (master...fix_network_buffer_bug) https://github.com/bitcoin/bitcoin/pull/7168
302015-12-04T04:48:41 *** nkuttler has quit IRC
312015-12-04T04:49:51 *** nkuttler has joined #bitcoin-core-dev
322015-12-04T05:02:28 *** droark has quit IRC
332015-12-04T05:06:04 *** pmienk has quit IRC
342015-12-04T05:08:27 *** roasbeef has joined #bitcoin-core-dev
352015-12-04T05:20:41 *** pmienk has joined #bitcoin-core-dev
362015-12-04T05:24:31 *** therealnanotube is now known as nanotube
372015-12-04T05:28:34 *** instagibbs has quit IRC
382015-12-04T05:32:32 *** raedah has joined #bitcoin-core-dev
392015-12-04T05:41:30 *** instagibbs has joined #bitcoin-core-dev
402015-12-04T06:16:14 *** raedah has quit IRC
412015-12-04T06:20:35 *** moley has joined #bitcoin-core-dev
422015-12-04T06:22:31 *** arowser has quit IRC
432015-12-04T06:23:19 *** arowser has joined #bitcoin-core-dev
442015-12-04T06:23:39 *** moli has quit IRC
452015-12-04T06:32:35 *** dcousens has joined #bitcoin-core-dev
462015-12-04T06:33:27 *** instagibbs has quit IRC
472015-12-04T06:34:01 <dcousens> gmaxwell: rpc is still slow as *insert crude culturally relevant derogitory comment here*
482015-12-04T06:34:25 <dcousens> at least, in terms of parsing the whole blockchain over it :P
492015-12-04T06:38:36 *** instagibbs has joined #bitcoin-core-dev
502015-12-04T06:43:05 *** raedah has joined #bitcoin-core-dev
512015-12-04T06:54:26 *** raedah has quit IRC
522015-12-04T06:57:45 *** droark has joined #bitcoin-core-dev
532015-12-04T07:02:23 *** dcousens has quit IRC
542015-12-04T07:17:21 <GitHub136> [bitcoin] paveljanik opened pull request #7169: [Trivial] Disable compiler warnings about unused functions (master...20151204_scheduler_tests_warning) https://github.com/bitcoin/bitcoin/pull/7169
552015-12-04T07:28:58 *** paveljanik has joined #bitcoin-core-dev
562015-12-04T07:28:58 *** paveljanik has joined #bitcoin-core-dev
572015-12-04T08:06:51 *** davec has quit IRC
582015-12-04T08:12:34 *** davec has joined #bitcoin-core-dev
592015-12-04T08:43:43 <GitHub164> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5548d9cb11c8...792259278e4f
602015-12-04T08:43:43 <GitHub164> bitcoin/master 6aadc75 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
612015-12-04T08:43:44 <GitHub164> bitcoin/master 7922592 Wladimir J. van der Laan: Merge pull request #7166...
622015-12-04T08:43:47 <GitHub147> [bitcoin] laanwj closed pull request #7166: Disconnect on mempool requests from peers when over the upload limit. (master...mempool_p2p_when_overlimit) https://github.com/bitcoin/bitcoin/pull/7166
632015-12-04T08:45:02 <GitHub63> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/6ba25d28868146d5d6dbd671881db3a58f549567
642015-12-04T08:45:03 <GitHub63> bitcoin/0.12 6ba25d2 Gregory Maxwell: Disconnect on mempool requests from peers when over the upload limit....
652015-12-04T08:45:26 *** paveljanik has quit IRC
662015-12-04T08:51:11 *** arowser has quit IRC
672015-12-04T08:51:24 *** arowser has joined #bitcoin-core-dev
682015-12-04T08:57:02 *** Ylbam has joined #bitcoin-core-dev
692015-12-04T08:58:46 *** Amnez777 has quit IRC
702015-12-04T08:58:46 *** Amnez777 has joined #bitcoin-core-dev
712015-12-04T09:42:49 <jonasschnelli> wumpus: the message header size is always 24 bytes, correct?
722015-12-04T09:44:04 <wumpus> jonasschnelli: I don't know the exact value by heart, let me see
732015-12-04T09:44:19 <jonasschnelli> hmm... another magic number.
742015-12-04T09:44:50 <jonasschnelli> i think i can use CMessageHeader::COMMAND_SIZE, etc.
752015-12-04T09:44:55 <wumpus> CMessageHeader::HEADER_SIZE
762015-12-04T09:45:12 <jonasschnelli> Right! Thanks
772015-12-04T09:45:18 <wumpus> and yes, should be 24
782015-12-04T09:48:50 <wumpus> jonasschnelli: did you forget it for mapSendBytesPerCmd[std::string(pszCommand)] += nSize; ?
792015-12-04T09:50:32 <jonasschnelli> wumpus: Thanks! right. there it's also required because of nSize = ssSend.size() - CMessageHeader::HEADER_SIZE
802015-12-04T09:50:39 <jonasschnelli> pushed
812015-12-04T09:51:01 <jonasschnelli> I'm also testing it now
822015-12-04T09:51:03 <wumpus> yeah that's where I noticed (verack is outgoing message)
832015-12-04T09:51:17 <wumpus> +also
842015-12-04T09:52:05 *** baldur has quit IRC
852015-12-04T09:53:51 <jonasschnelli> Yes. Now it's correct. The bytesrecv/bytessent (totals per node) matches now the sum of the aggregated values.
862015-12-04T09:54:30 <wumpus> nice!
872015-12-04T09:54:46 *** ParadoxSpiral has joined #bitcoin-core-dev
882015-12-04T09:58:25 <wumpus> maybe we want an 'other' catch-all for received commands that we don't recognize otherwise?
892015-12-04T09:59:43 <wumpus> (say someone is bombarding us with large packets that we don't recognize, right now it won't show up in bytesrecv_per_cmd) - of course we have the total already, so this may be unnecessary, I don't know
902015-12-04T09:59:43 <jonasschnelli> wumpus: hmm.. yes. Would be nice... and it would not introduce a mem DOS attack (if combined to one map key "other").
912015-12-04T09:59:55 <wumpus> right :)
922015-12-04T10:00:10 <jonasschnelli> others = total - <sum of aggregated>, ...
932015-12-04T10:00:20 <jonasschnelli> we could just render that in the rpc output.
942015-12-04T10:00:44 <wumpus> but it may be good to report, it's nice if numbers add up
952015-12-04T10:01:24 <wumpus> the problem is that any string up to 12(?) chars can be an actual command name
962015-12-04T10:01:32 <jonasschnelli> Yeah. Sure. Let me add it. I think this number is very helpful to detect strange nodes.
972015-12-04T10:02:21 <wumpus> so is this the command 'other' or ... an other command... lol ok that doesn't matter much I guess, as 'other' would, being an unknown command, also go into the category 'other' . Hmm.
982015-12-04T10:02:59 <jonasschnelli> use "*other*" instead of "other"? or to much magic?
992015-12-04T10:03:12 <wumpus> making it distinct makes sense yes
1002015-12-04T10:03:54 <wumpus> I even mean even though *other* is strictly a valid command name, no one is ever actually going to agree on using that
1012015-12-04T10:04:04 <wumpus> yes makes sense
1022015-12-04T10:05:22 *** baldur has joined #bitcoin-core-dev
1032015-12-04T10:08:52 <wumpus> this is nice, it allows for doing a (simple kind of, better than looking at subvers) behavioral profiling of peers
1042015-12-04T10:09:47 <wumpus> some peers do nothing except connect and ping! :o
1052015-12-04T10:10:01 <jonasschnelli> Yes. I wrote this to analyze the traffic before I wrote maxuploadtarget PR.
1062015-12-04T10:10:24 <jonasschnelli> And it would allow to do some clever throttling based on this data.
1072015-12-04T10:22:14 <wumpus> jonasschnelli: would it be a reasonable compromise to have `logAllowIncomingCmds` available via RPC somewhere (say `getnetworkinfo`)? This avoids having to add empty rows to every peer.
1082015-12-04T10:23:25 <jonasschnelli> wumpus: yes. That would be useful and reduce the whole rpc response size.
1092015-12-04T10:23:41 <jonasschnelli> getpeerinfo looks after a command that is ideal to poll... so reducing size there is fine
1102015-12-04T10:24:02 <wumpus> (and still accomplishes the same, the stats collector can know the total set of messages accepted by the peer)
1112015-12-04T10:24:12 <wumpus> right - it makes sense to try to save space there
1122015-12-04T10:26:29 <jonasschnelli> wumpus: Okay. Switch to your find("other") approach, but i need to pre-populate "*other*" as well (which is fine): https://github.com/bitcoin/bitcoin/pull/6589/files#diff-9a82240fe7dfe86564178691cc57f2f1R2358
1132015-12-04T10:28:01 <wumpus> jonasschnelli: maybe static const std::string NET_COMMAND_OTHER="*other*";
1142015-12-04T10:28:03 *** Thireus1 has joined #bitcoin-core-dev
1152015-12-04T10:28:28 <wumpus> jonasschnelli: then explicitly mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0; and use the constant in the other place too
1162015-12-04T10:28:51 <jonasschnelli> Yeah. Better. Cleaner.
1172015-12-04T10:28:59 <wumpus> jonasschnelli: given how critical it is that it exist, don't think adding it to logAllowIncomingCmds is a good idea, someone may just remove it and crash everything
1182015-12-04T10:29:25 <wumpus> jonasschnelli: maybe add an assert(i != mapRecvBytesPerCmd.end()); before the increase just incase :p
1192015-12-04T10:29:32 *** Thireus has quit IRC
1202015-12-04T10:29:36 <jonasschnelli> Yeah. Good idea.
1212015-12-04T10:31:40 <wumpus> (ideally we would have constants for all net commands and use those in the code instead of hardcoded strings, this avoids typos and such, but far out of scope of your pull)
1222015-12-04T10:33:35 <jonasschnelli> Indeed
1232015-12-04T10:41:13 <jonasschnelli> wumpus: Added a commit that hides the 0 entries... need to add the command list to getnetworkinfo.. will do soon.
1242015-12-04T10:41:21 * wumpus must have the craziest multi-stage bitcoind launch command "nice -+19 screen -d -m gdb -x run.gdbscript -args ./bitcoind -datadir=/usb/bitcoin" (run.gdbscript is http://stackoverflow.com/a/5286038/216357 )
1252015-12-04T10:42:16 <jonasschnelli> hah
1262015-12-04T10:42:22 <wumpus> maybe I should propose it for #7111 "Recommend how to run bitcoind in a production environment"? *ducks*
1272015-12-04T10:42:49 <jonasschnelli> you forgot the while 1 loop (in case it crashes)
1282015-12-04T10:42:55 <wumpus> hahahhahaah
1292015-12-04T10:43:02 <jonasschnelli> ;-)
1302015-12-04T10:44:58 *** CodeShark_ has quit IRC
1312015-12-04T11:15:36 *** paveljanik has joined #bitcoin-core-dev
1322015-12-04T11:15:36 *** paveljanik has joined #bitcoin-core-dev
1332015-12-04T11:24:17 <wumpus> jonasschnelli: hm I got a "bitcoind: net.cpp:703: bool CNode::ReceiveMsgBytes(const char*, unsigned int): Assertion `i != mapRecvBytesPerCmd.end()' failed."
1342015-12-04T11:25:57 <wumpus> jonasschnelli: you're not prepopulating NET_COMMAND_OTHER, either need to re-add it to logAllowIncomingCmds, either add it or (I think preferably) add it explicilty with mapRecvBytesPerCmd[NET_COMMAND_OTHER] = 0
1352015-12-04T11:29:59 *** Thireus1 has quit IRC
1362015-12-04T11:30:13 *** Thireus has joined #bitcoin-core-dev
1372015-12-04T11:39:31 *** Thireus1 has joined #bitcoin-core-dev
1382015-12-04T11:42:50 *** Thireus has quit IRC
1392015-12-04T12:01:51 *** dcousens has joined #bitcoin-core-dev
1402015-12-04T12:10:17 *** droark has quit IRC
1412015-12-04T12:18:49 <jonasschnelli> wumpus: Fixed (force pushed)
1422015-12-04T12:26:06 <GitHub74> [bitcoin] laanwj opened pull request #7170: tests: Disable Tor interaction (master...2015_12_tests_nolistentor) https://github.com/bitcoin/bitcoin/pull/7170
1432015-12-04T12:26:56 <GitHub73> [bitcoin] laanwj opened pull request #7171: test: remove necessity to call create_callback_map (master...2015_12_p2p_test_no_cbmap) https://github.com/bitcoin/bitcoin/pull/7171
1442015-12-04T12:48:13 *** afk11 has joined #bitcoin-core-dev
1452015-12-04T12:50:09 <wumpus> jonasschnelli: great
1462015-12-04T13:09:35 <wumpus> "bytesrecv_per_cmd": { "reject": 140788, } whoa some nodes send a lot of reject
1472015-12-04T13:10:33 <wumpus> that's a lot for a message we don't use at all
1482015-12-04T13:12:36 <tulip> are people setting the "reason" string?
1492015-12-04T13:13:15 <wumpus> I don't know, going to log the contents
1502015-12-04T13:15:31 <afk11> hmm, I am getting reject messages this morning using electrum
1512015-12-04T13:15:38 <afk11> the one that comes with tails :/ not great.
1522015-12-04T13:16:03 <afk11> "Your transaction was rejected by the network, please upgrade away to > electrum 2.6"
1532015-12-04T13:16:48 <wumpus> at least that message is clear on what to do (but I don't believe it has to do with P2P network reject messages)
1542015-12-04T13:16:59 <tulip> that's unrelated.
1552015-12-04T13:17:20 <tulip> that'll be to do with low-s signatures, older versions of Electrum generate now-invalid signatures.
1562015-12-04T13:20:50 *** afk11 has quit IRC
1572015-12-04T13:22:01 <wumpus> we should have made reject messages optional, eg like announce headers, a 'enablerejects' message that has to be received before the node starts sending them
1582015-12-04T13:22:53 <wumpus> only a small extract of what nodes are sending: http://www.hastebin.com/imipusiqan.txt
1592015-12-04T13:26:00 <tulip> I'm not sure why the server software doesn't just re-pack the points in the signature, guess there's a good reason.
1602015-12-04T13:35:20 <wumpus> some nodes do that, but it has some other drawbacks, effectively it's malleating transactions
1612015-12-04T13:39:57 *** evoskuil has joined #bitcoin-core-dev
1622015-12-04T14:01:55 <GitHub93> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/f31955d9da152e5e849575f0297f8fe1904cbfbc
1632015-12-04T14:01:55 <GitHub93> bitcoin/0.12 f31955d Gregory Maxwell: Replace setInventoryKnown with a rolling bloom filter....
1642015-12-04T14:43:24 *** tulip has quit IRC
1652015-12-04T14:43:56 *** tulip has joined #bitcoin-core-dev
1662015-12-04T14:49:06 *** evoskuil has quit IRC
1672015-12-04T14:51:27 *** jtimon has quit IRC
1682015-12-04T14:58:51 *** moley is now known as moli
1692015-12-04T15:07:58 *** Guyver2 has joined #bitcoin-core-dev
1702015-12-04T16:19:54 *** tripleslash has quit IRC
1712015-12-04T16:57:54 *** tripleslash has joined #bitcoin-core-dev
1722015-12-04T17:03:55 *** tripleslash_p has joined #bitcoin-core-dev
1732015-12-04T17:04:20 *** tripleslash has quit IRC
1742015-12-04T17:04:48 *** Thireus1 has quit IRC
1752015-12-04T17:05:02 *** Thireus has joined #bitcoin-core-dev
1762015-12-04T17:08:34 *** tripleslash_p has quit IRC
1772015-12-04T17:33:18 *** PaulCapestany has quit IRC
1782015-12-04T17:34:06 <Thireus> I received this a couple of hours ago: "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)" on my full nodes
1792015-12-04T17:34:42 <Thireus> there seem to be some TX flood going on, has anyone else been impacted as well?
1802015-12-04T17:34:51 *** PaulCapestany has joined #bitcoin-core-dev
1812015-12-04T17:35:01 <Thireus> c.f. block https://tradeblock.com/bitcoin/block/386689
1822015-12-04T17:46:53 *** ParadoxSpiral_ has joined #bitcoin-core-dev
1832015-12-04T17:50:06 *** ParadoxSpiral has quit IRC
1842015-12-04T18:41:35 *** tulip has quit IRC
1852015-12-04T18:42:56 *** tulip has joined #bitcoin-core-dev
1862015-12-04T19:26:32 *** treehug88 has joined #bitcoin-core-dev
1872015-12-04T19:55:09 <Squidicuz> Thireus getting the same thing
1882015-12-04T20:47:18 <tulip> Thireus: that seems to be buggy. other people have encountered the same thing.
1892015-12-04T20:58:26 <Squidicuz> I rebooted the services and it is okay for now :S
1902015-12-04T20:59:00 <Squidicuz> what does that message mean though? I can't be blocks behind when minig O_o
1912015-12-04T20:59:35 <Squidicuz> apologies if this is the wrong channel, i just realized where I is.
1922015-12-04T21:08:59 *** arowser has quit IRC
1932015-12-04T21:09:21 *** arowser has joined #bitcoin-core-dev
1942015-12-04T21:09:55 *** treehug88 has quit IRC
1952015-12-04T21:14:14 *** evoskuil has joined #bitcoin-core-dev
1962015-12-04T21:28:49 *** Guyver2_ has joined #bitcoin-core-dev
1972015-12-04T21:29:10 *** Guyver2 has quit IRC
1982015-12-04T21:30:38 *** opitka has joined #bitcoin-core-dev
1992015-12-04T22:08:24 *** coco has joined #bitcoin-core-dev
2002015-12-04T22:13:51 <tulip> Squidicuz: it's probably on topic, if you aren't falling behind triggering that is definitely a bug. someone has encountered that before recently.
2012015-12-04T22:15:38 <Squidicuz> the node did not seem behind when i checked on it. i restarted and havent gotten the messgae since. the logs shows that bitcoind timed out a few times prior.
2022015-12-04T22:16:08 <tulip> timed out?
2032015-12-04T22:20:07 *** paveljanik has quit IRC
2042015-12-04T22:21:37 <Squidicuz> yes. my connection to bitcoind timed out, I mean.
2052015-12-04T22:22:01 <Squidicuz> for getBlockTemplate
2062015-12-04T22:25:41 *** coco has quit IRC
2072015-12-04T23:03:06 *** coco has joined #bitcoin-core-dev
2082015-12-04T23:10:31 *** coco has quit IRC
2092015-12-04T23:36:14 *** ghtdak has quit IRC
2102015-12-04T23:53:28 *** randy-waterhouse has joined #bitcoin-core-dev