12016-03-14T00:16:04  *** PRab has quit IRC
  22016-03-14T00:24:10  *** Guyver2 has quit IRC
  32016-03-14T00:46:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  42016-03-14T01:14:06  *** Chris_Stewart_5 has quit IRC
  52016-03-14T01:30:00  *** dcousens has joined #bitcoin-core-dev
  62016-03-14T01:37:15  *** justanotheruser has quit IRC
  72016-03-14T01:38:11  *** justanotheruser has joined #bitcoin-core-dev
  82016-03-14T01:40:13  <dcousens> wc
  92016-03-14T01:40:15  *** dcousens has left #bitcoin-core-dev
 102016-03-14T01:55:29  *** fengling has joined #bitcoin-core-dev
 112016-03-14T02:00:59  *** Ylbam has quit IRC
 122016-03-14T02:02:56  *** paveljanik has quit IRC
 132016-03-14T02:03:06  *** pavel_ has joined #bitcoin-core-dev
 142016-03-14T02:18:04  *** PRab has joined #bitcoin-core-dev
 152016-03-14T02:40:01  *** belcher has quit IRC
 162016-03-14T02:59:33  *** fengling has quit IRC
 172016-03-14T03:07:21  *** fengling has joined #bitcoin-core-dev
 182016-03-14T03:30:35  *** anchow101 has quit IRC
 192016-03-14T03:38:53  *** xiangfu has joined #bitcoin-core-dev
 202016-03-14T03:41:08  *** jl2012 has joined #bitcoin-core-dev
 212016-03-14T03:44:13  *** fengling has quit IRC
 222016-03-14T03:51:11  *** fengling has joined #bitcoin-core-dev
 232016-03-14T03:52:32  *** Giszmo has quit IRC
 242016-03-14T04:18:56  *** Guest35513 is now known as [_smitty]
 252016-03-14T04:47:57  *** xiangfu_ has joined #bitcoin-core-dev
 262016-03-14T05:22:00  *** [_smitty] has quit IRC
 272016-03-14T05:59:37  *** pavel_ has quit IRC
 282016-03-14T06:00:08  *** dermoth has quit IRC
 292016-03-14T06:01:00  *** dermoth has joined #bitcoin-core-dev
 302016-03-14T06:21:23  *** jtimon has quit IRC
 312016-03-14T06:38:26  *** AaronvanW has joined #bitcoin-core-dev
 322016-03-14T06:51:04  *** sharkattack1999 has joined #bitcoin-core-dev
 332016-03-14T06:53:02  <sharkattack1999> is virwox safe
 342016-03-14T07:05:22  *** mr_burdell_ has joined #bitcoin-core-dev
 352016-03-14T07:06:12  *** lahwran has joined #bitcoin-core-dev
 362016-03-14T07:07:16  *** pigeons_ has joined #bitcoin-core-dev
 372016-03-14T07:07:16  *** heath__ has joined #bitcoin-core-dev
 382016-03-14T07:07:19  *** devrando1 has joined #bitcoin-core-dev
 392016-03-14T07:13:46  *** sharkattack1999 has quit IRC
 402016-03-14T07:14:35  *** davec has quit IRC
 412016-03-14T07:15:28  *** dermoth has quit IRC
 422016-03-14T07:15:30  *** mr_burdell has quit IRC
 432016-03-14T07:15:30  *** phantomcircuit has quit IRC
 442016-03-14T07:15:32  *** lauren has quit IRC
 452016-03-14T07:15:34  *** heath has quit IRC
 462016-03-14T07:15:36  *** pigeons has quit IRC
 472016-03-14T07:15:36  *** devrandom has quit IRC
 482016-03-14T07:15:38  *** gijensen has quit IRC
 492016-03-14T07:15:43  *** mr_burdell_ is now known as mr_burdell
 502016-03-14T07:16:09  *** davec has joined #bitcoin-core-dev
 512016-03-14T07:16:12  *** gijensen has joined #bitcoin-core-dev
 522016-03-14T07:16:12  *** dermoth has joined #bitcoin-core-dev
 532016-03-14T07:16:15  *** phantomcircuit has joined #bitcoin-core-dev
 542016-03-14T07:16:16  *** mr_burdell is now known as Guest67852
 552016-03-14T07:39:23  *** Thireus has quit IRC
 562016-03-14T07:56:06  *** AaronvanW has quit IRC
 572016-03-14T07:56:49  *** BashCo_ has quit IRC
 582016-03-14T08:07:59  *** Ylbam has joined #bitcoin-core-dev
 592016-03-14T08:14:33  *** Guyver2 has joined #bitcoin-core-dev
 602016-03-14T08:14:54  *** Thireus has joined #bitcoin-core-dev
 612016-03-14T08:16:21  *** Don_John has quit IRC
 622016-03-14T08:20:49  <GitHub69> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0fa88ef784dd...3798e5de334c
 632016-03-14T08:20:50  <GitHub69> bitcoin/master ce7413f Luv Khemani: Add autocomplete to bitcoin-qt's console window....
 642016-03-14T08:20:50  <GitHub69> bitcoin/master 3798e5d Jonas Schnelli: Merge #7613: Add autocomplete to bitcoin-qt's console window....
 652016-03-14T08:20:59  <GitHub94> [bitcoin] jonasschnelli closed pull request #7613: Add autocomplete to bitcoin-qt's console window. (master...autocomplete) https://github.com/bitcoin/bitcoin/pull/7613
 662016-03-14T08:25:05  <GitHub88> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3798e5de334c...b24266c20748
 672016-03-14T08:25:06  <GitHub88> bitcoin/master 21e45a0 Andrew C: Fix history deletion bug after font change...
 682016-03-14T08:25:07  <GitHub88> bitcoin/master b24266c Jonas Schnelli: Merge #7668: Fix history deletion bug after font size change...
 692016-03-14T08:25:10  <GitHub180> [bitcoin] jonasschnelli closed pull request #7668: Fix history deletion bug after font size change (master...rpcconsole-hist-fix) https://github.com/bitcoin/bitcoin/pull/7668
 702016-03-14T08:27:41  *** BashCo has joined #bitcoin-core-dev
 712016-03-14T08:28:53  *** paveljanik has joined #bitcoin-core-dev
 722016-03-14T08:28:53  *** paveljanik has joined #bitcoin-core-dev
 732016-03-14T08:31:58  *** BashCo has quit IRC
 742016-03-14T08:40:20  *** BashCo has joined #bitcoin-core-dev
 752016-03-14T09:12:47  <jonasschnelli> Hmm... getting a new warning:
 762016-03-14T09:12:47  <jonasschnelli> torcontrol.cpp:365:24: warning: private field 'base' is not used [-Wunused-private-field]
 772016-03-14T09:13:26  *** jannes has joined #bitcoin-core-dev
 782016-03-14T09:13:40  <jonasschnelli> But seems to be used in TorController::TorController constructor... strange..
 792016-03-14T09:16:06  <paveljanik> there is a global base
 802016-03-14T09:16:49  <paveljanik> it can be removed from TorController::TorController and commented out around l. 365
 812016-03-14T09:17:19  <paveljanik> I do not know if the global should be prefer or the private one there.
 822016-03-14T09:17:45  <paveljanik> let's wait for wumpus
 832016-03-14T09:29:08  <wumpus> we should probably rename the global one
 842016-03-14T09:29:20  *** p15x has joined #bitcoin-core-dev
 852016-03-14T09:29:27  <wumpus> (I'd like to go without it completely, but I don't think that's possible)
 862016-03-14T09:30:19  <wumpus> it would work if our initialization sequence was structured differently, and StartTorControl would return an instance instead, but with the global StartTorControl/InterruptTorControl/StopTorControl flow, some state needs to be global
 872016-03-14T09:30:29  <wumpus> it shouldn't be called the same as an instance variable though
 882016-03-14T09:31:33  *** gevs has joined #bitcoin-core-dev
 892016-03-14T09:39:13  *** Squidicuz has quit IRC
 902016-03-14T09:41:07  <wumpus> e.g. like this https://github.com/laanwj/bitcoin/commit/0a48b56bdc60f9dafaea7a7b2a770eb819dbfe55
 912016-03-14T09:42:26  <jonasschnelli> ACK https://github.com/laanwj/bitcoin/commit/0a48b56bdc60f9dafaea7a7b2a770eb819dbfe55
 922016-03-14T09:43:54  <GitHub154> [bitcoin] laanwj opened pull request #7676: torcontrol: rename global base, avoid overlap with field (master...2016_03_torcontrol_rename_base) https://github.com/bitcoin/bitcoin/pull/7676
 932016-03-14T09:44:54  <wumpus> eventually we could want to move toward having one libevent base, instead of having separate ones for RPC and torcontrol, but best to do this after cfields_' net refactor
 942016-03-14T09:45:13  <wumpus> (which will introduce a third one for the P2P)
 952016-03-14T09:48:00  <wumpus> so, it looks like 0.12 finally broke windows XP compatibility (https://github.com/bitcoin/bitcoin/issues/7639, https://github.com/bitcoin/bitcoin/issues/7674)
 962016-03-14T09:48:40  <wumpus> I'd almost say 'congratulations', if it wasn't that I'm afraid that it's some kind of race that may be hiding on other platforms as well
 972016-03-14T09:49:32  <wumpus> on the other hand this could be simply the new mingw (from ubuntu 14.04 i.s.o 12.04)
 982016-03-14T09:52:29  *** AaronvanW has joined #bitcoin-core-dev
 992016-03-14T09:52:29  *** AaronvanW has quit IRC
1002016-03-14T09:52:29  *** AaronvanW has joined #bitcoin-core-dev
1012016-03-14T10:12:38  <NicolasDorier> I would appreciate some feedback on https://github.com/bitcoin/bitcoin/issues/7677
1022016-03-14T10:18:04  *** xiangfu has quit IRC
1032016-03-14T10:19:45  *** xiangfu_ has quit IRC
1042016-03-14T10:21:25  <GitHub107> [bitcoin] laanwj closed pull request #7676: torcontrol: rename global base, avoid overlap with field (master...2016_03_torcontrol_rename_base) https://github.com/bitcoin/bitcoin/pull/7676
1052016-03-14T10:27:29  <GitHub42> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b24266c20748...56d2c4e0fee3
1062016-03-14T10:27:30  <GitHub42> bitcoin/master 393b22e Mustafa: Add a source file for unit test utils.
1072016-03-14T10:27:30  <GitHub42> bitcoin/master 2fdaa25 Mustafa: Move GetTempPath() to testutil.
1082016-03-14T10:27:31  <GitHub42> bitcoin/master 56d2c4e Wladimir J. van der Laan: Merge #7667: Move GetTempPath() to testutil...
1092016-03-14T10:27:34  <GitHub100> [bitcoin] laanwj closed pull request #7667: Move GetTempPath() to testutil (master...patch-gettemppath) https://github.com/bitcoin/bitcoin/pull/7667
1102016-03-14T10:28:48  *** laurentmt has joined #bitcoin-core-dev
1112016-03-14T10:29:37  *** p15x has quit IRC
1122016-03-14T10:30:26  <GitHub97> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/56d2c4e0fee3...f1ca8915bb22
1132016-03-14T10:30:27  <GitHub97> bitcoin/master b0ff857 Wladimir J. van der Laan: test: Move non-generated script_invalid test to the correct place...
1142016-03-14T10:30:27  <GitHub97> bitcoin/master 2317ad7 Wladimir J. van der Laan: test: Re-introduce JSON pretty printing in test builder
1152016-03-14T10:30:28  <GitHub97> bitcoin/master 0ecb340 Wladimir J. van der Laan: test: Script_error checking in script_invalid tests...
1162016-03-14T10:30:31  <GitHub32> [bitcoin] laanwj closed pull request #7517: test: script_error checking in script_invalid tests (master...2016_02_test_script_errors) https://github.com/bitcoin/bitcoin/pull/7517
1172016-03-14T10:32:21  *** p15x has joined #bitcoin-core-dev
1182016-03-14T10:32:40  *** fengling has quit IRC
1192016-03-14T10:34:11  <wumpus> paveljanik: I don't like that warning - it's correct, after #7637 we don't need to keep `base` around at all in TorController right now because we only use it in the constructor.  But I think it's good practice to do so anyway, in case it's needed again in later changes...
1202016-03-14T10:35:09  <GitHub160> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f1ca8915bb22...5b3b5a7d711c
1212016-03-14T10:35:10  <GitHub160> bitcoin/master fc7c60d Jonas Schnelli: [Wallet] move "load wallet phase" to CWallet
1222016-03-14T10:35:10  <GitHub160> bitcoin/master 15e6e13 Jonas Schnelli: [Wallet] optimize return value of InitLoadWallet()
1232016-03-14T10:35:11  <GitHub160> bitcoin/master 5b3b5a7 Wladimir J. van der Laan: Merge #7577: [Wallet] move "load wallet phase" to CWallet...
1242016-03-14T10:35:17  <GitHub41> [bitcoin] laanwj closed pull request #7577: [Wallet] move "load wallet phase" to CWallet (master...2016/02/wallet_ref2) https://github.com/bitcoin/bitcoin/pull/7577
1252016-03-14T10:35:59  <GitHub130> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b3b5a7d711c...11c769966ad7
1262016-03-14T10:35:59  <GitHub130> bitcoin/master 8d1de43 Leviathn: Remove internal miner...
1272016-03-14T10:36:00  <GitHub130> bitcoin/master 11c7699 Wladimir J. van der Laan: Merge #7507: Remove internal miner...
1282016-03-14T10:36:02  <GitHub30> [bitcoin] laanwj closed pull request #7507: Remove internal miner (master...master) https://github.com/bitcoin/bitcoin/pull/7507
1292016-03-14T10:36:37  <GitHub155> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/11c769966ad7...c87f51e55bc3
1302016-03-14T10:36:37  <GitHub155> bitcoin/master 8a253b3 Pieter Wuille: Make the generate RPC call function for non-regtest
1312016-03-14T10:36:38  <GitHub155> bitcoin/master c87f51e Wladimir J. van der Laan: Merge #7663: Make the generate RPC call function for non-regtest...
1322016-03-14T10:36:47  <GitHub3> [bitcoin] laanwj closed pull request #7663: Make the generate RPC call function for non-regtest (master...generatenonreg) https://github.com/bitcoin/bitcoin/pull/7663
1332016-03-14T10:37:01  <paveljanik> wumpus, 8) When it is needed in later changes, it can be resurrected from git history 8)
1342016-03-14T10:37:22  <wumpus> paveljanik: of course, but I think the warning is over-eager
1352016-03-14T10:38:29  <paveljanik> every warning is disturbing, hides probles etc. But I know you have a different opinion :-)
1362016-03-14T10:39:08  <paveljanik> and I respect that.
1372016-03-14T10:39:17  <wumpus> sure, they're annoying, but in some cases it makes more sense to disable the warning than change the code
1382016-03-14T10:40:03  <paveljanik> I agree with that - in some cases. Like known compiler bug etc...
1392016-03-14T10:40:06  <wumpus> it's not up to compiler authors to decide about our code style
1402016-03-14T10:40:45  <wumpus> looks like they're making the compiler behave like a nanny with too much time on their hands
1412016-03-14T10:41:00  <paveljanik> I agree with that completely ;-)
1422016-03-14T10:42:01  <wumpus> all time spent on 'fixing' the code to be as acceptable as possible to the compiler is not spent on facing user-facing issues, ok and that concludes my rant on this
1432016-03-14T10:44:40  *** paveljanik has quit IRC
1442016-03-14T11:10:25  <GitHub102> [bitcoin] laanwj closed pull request #7655: [qt] Add .clang-format (master...Mf1603-qt-clang-format-0.12) https://github.com/bitcoin/bitcoin/pull/7655
1452016-03-14T11:23:08  <GitHub7> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c87f51e55bc3...c9a12657545f
1462016-03-14T11:23:08  <GitHub7> bitcoin/master a6ee0ca Pavel Vasin: use cached block hash in blockToJSON()
1472016-03-14T11:23:09  <GitHub7> bitcoin/master c9a1265 Wladimir J. van der Laan: Merge #7670: use cached block hash in blockToJSON()...
1482016-03-14T11:23:18  <GitHub70> [bitcoin] laanwj closed pull request #7670: use cached block hash in blockToJSON() (master...patch) https://github.com/bitcoin/bitcoin/pull/7670
1492016-03-14T11:24:43  <GitHub199> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c9a12657545f...c15eb2824184
1502016-03-14T11:24:43  <GitHub199> bitcoin/master ce41cf0 BtcDrak: Add curl to Gitian setup instrustions...
1512016-03-14T11:24:44  <GitHub199> bitcoin/master c15eb28 Wladimir J. van der Laan: Merge #7658: Add curl to Gitian setup instructions...
1522016-03-14T11:24:48  <GitHub192> [bitcoin] laanwj closed pull request #7658: Add curl to Gitian setup instructions (master...curl) https://github.com/bitcoin/bitcoin/pull/7658
1532016-03-14T11:26:54  *** xabbix_ has joined #bitcoin-core-dev
1542016-03-14T11:26:55  *** MarcoFalke has joined #bitcoin-core-dev
1552016-03-14T11:28:06  *** xabbix has quit IRC
1562016-03-14T11:55:05  <GitHub32> [bitcoin] laanwj opened pull request #7680: qt: Remove reflection from `about` icon (master...2016_03_image_optimize) https://github.com/bitcoin/bitcoin/pull/7680
1572016-03-14T11:59:25  *** laurentmt has quit IRC
1582016-03-14T12:02:30  *** Guest67852 is now known as mr_burdell
1592016-03-14T12:02:44  *** mr_burdell has quit IRC
1602016-03-14T12:02:44  *** mr_burdell has joined #bitcoin-core-dev
1612016-03-14T12:27:30  *** wasi has joined #bitcoin-core-dev
1622016-03-14T12:28:02  *** BashCo_ has joined #bitcoin-core-dev
1632016-03-14T12:32:02  *** BashCo has quit IRC
1642016-03-14T12:43:26  <GitHub195> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c15eb2824184...41d2dfa9e73b
1652016-03-14T12:43:26  <GitHub195> bitcoin/master 322a7a2 Wladimir J. van der Laan: qt: Remove reflection from `about` icon...
1662016-03-14T12:43:27  <GitHub195> bitcoin/master 41d2dfa Wladimir J. van der Laan: Merge #7680: qt: Remove reflection from `about` icon...
1672016-03-14T12:43:33  <GitHub2> [bitcoin] laanwj closed pull request #7680: qt: Remove reflection from `about` icon (master...2016_03_image_optimize) https://github.com/bitcoin/bitcoin/pull/7680
1682016-03-14T12:50:15  *** jyap has quit IRC
1692016-03-14T12:52:06  *** jyap has joined #bitcoin-core-dev
1702016-03-14T12:52:06  *** jyap has joined #bitcoin-core-dev
1712016-03-14T12:56:44  <GitHub179> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41d2dfa9e73b...0735c0ca7c22
1722016-03-14T12:56:45  <GitHub179> bitcoin/master fa19b18 MarcoFalke: [wallet] Move hardcoded file name out of log messages
1732016-03-14T12:56:46  <GitHub179> bitcoin/master 0735c0c Wladimir J. van der Laan: Merge #7608: [wallet] Move hardcoded file name out of log messages...
1742016-03-14T12:56:53  <GitHub194> [bitcoin] laanwj closed pull request #7608: [wallet] Move hardcoded file name out of log messages (master...Mf1602-walletFileName) https://github.com/bitcoin/bitcoin/pull/7608
1752016-03-14T13:00:26  *** laurentmt has joined #bitcoin-core-dev
1762016-03-14T13:04:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1772016-03-14T13:13:01  *** jtimon has joined #bitcoin-core-dev
1782016-03-14T13:35:04  *** Chris_Stewart_5 has quit IRC
1792016-03-14T13:50:34  *** Guyver2 has quit IRC
1802016-03-14T14:06:35  <GitHub98> [bitcoin] MarcoFalke opened pull request #7682: [0.11.3] Backports (0.11...Mf1603-011wallet) https://github.com/bitcoin/bitcoin/pull/7682
1812016-03-14T14:13:17  <MarcoFalke> wumpus, what is the plan for 0.10.4 and 0.11.3?
1822016-03-14T14:13:25  <wumpus> no plan at this moment
1832016-03-14T14:14:23  <wumpus> another 0.10.x would require a critical reason, we could do a 0.11.x if there's good reason
1842016-03-14T14:17:22  <btcdrak> the next maint release should be the CSV softfork imo
1852016-03-14T14:17:53  *** paveljanik has joined #bitcoin-core-dev
1862016-03-14T14:20:27  <wumpus> sure, well, to be honest I don't really keep track of 0.11 backports, may make sense to appoint another release manager for backport releases
1872016-03-14T14:20:40  <wumpus> (e.g. as linux has)
1882016-03-14T14:20:49  <MarcoFalke> 0.11 currently has my "[dbwrapper] Detect obfuscation" patch and the wallet issues
1892016-03-14T14:21:11  <MarcoFalke> Though, it also includes the "paytxfee changed behavior without warning"
1902016-03-14T14:21:37  <wumpus> possibly Luke-Jr, though maybe he is a bit too trigger-happy with backporting
1912016-03-14T14:21:54  <wumpus> the list in https://github.com/bitcoin/bitcoin/pull/7047 is pretty scary :)
1922016-03-14T14:22:22  *** xabbix_ has quit IRC
1932016-03-14T14:22:37  <MarcoFalke> Jup, preferrably only changes that the end user can see should be backported.
1942016-03-14T14:22:47  <wumpus> the changed fee behavior is backported to 0.11?
1952016-03-14T14:23:17  *** wasi has quit IRC
1962016-03-14T14:23:18  *** xabbix_ has joined #bitcoin-core-dev
1972016-03-14T14:23:32  <wumpus> ah yeah: * 7d0a05f - Default fPayAtLeastCustomFee to false
1982016-03-14T14:23:44  <wumpus> going to revert that one, I don't want to do that on th 0.11 branch
1992016-03-14T14:28:22  <GitHub35> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/b6f59048d33a360246e000fc45daf26d08a693de
2002016-03-14T14:28:22  <GitHub35> bitcoin/0.11 b6f5904 Wladimir J. van der Laan: Revert "Default fPayAtLeastCustomFee to false"...
2012016-03-14T14:29:54  <MarcoFalke> Don't forget to revert 5f09cda0bf4cddc7d33989717a97ae53e85a7a00 as well.
2022016-03-14T14:30:27  <MarcoFalke> The unit tests will fail now because the wallet pays too much.
2032016-03-14T14:30:40  <wumpus> good point
2042016-03-14T14:31:03  <GitHub97> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/d49f72420b86cff446961f007dce050b84594373
2052016-03-14T14:31:03  <GitHub97> bitcoin/0.11 d49f724 Wladimir J. van der Laan: Revert "[wallet] Add rpc tests to verify fee calculations"...
2062016-03-14T14:41:49  *** treehug88 has joined #bitcoin-core-dev
2072016-03-14T14:51:29  *** Giszmo has joined #bitcoin-core-dev
2082016-03-14T14:57:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2092016-03-14T14:58:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2102016-03-14T15:15:43  <jonasschnelli> wumpus: this fixes the torcontrol warning for me: https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2016/03/torctrl?expand=1
2112016-03-14T15:16:03  <jonasschnelli> But the current constructor should be "legal" -> base(base)
2122016-03-14T15:16:16  <jonasschnelli> Not sure why it does fix the clang warning...
2132016-03-14T15:20:49  *** laurentmt has quit IRC
2142016-03-14T15:28:25  *** laurentmt has joined #bitcoin-core-dev
2152016-03-14T15:34:16  <GitHub147> [bitcoin] jonasschnelli opened pull request #7683: Fix torcontrol.cpp unused private field warning (master...2016/03/torctrl) https://github.com/bitcoin/bitcoin/pull/7683
2162016-03-14T15:34:41  <jonasschnelli> paveljanik maybe verify https://github.com/bitcoin/bitcoin/pull/7683?
2172016-03-14T15:35:11  <paveljanik> will do
2182016-03-14T15:35:42  <paveljanik> hmm
2192016-03-14T15:35:57  <paveljanik> I'd like to see a mix of your and Wladimir's solution ;-)
2202016-03-14T15:36:20  <paveljanik> it is not clear now, what is the concept behind two variables, named the same.
2212016-03-14T15:36:58  <paveljanik> it is not clear what "base" is used from the first review of the source.
2222016-03-14T15:37:14  <paveljanik> but I'll confirm if it fixes the warning
2232016-03-14T15:37:53  *** Thireus has quit IRC
2242016-03-14T15:43:45  *** wasi has joined #bitcoin-core-dev
2252016-03-14T15:46:40  <GitHub148> [bitcoin] MarcoFalke opened pull request #7684: [qa] Extend tests (master...Mf1603-qaCleanup1) https://github.com/bitcoin/bitcoin/pull/7684
2262016-03-14T15:48:51  <jonasschnelli> paveljanik: I agree the var names should be different... but no strong opinion. The struct event_base *base; at L662 should not interfere the private struct event_base* base; of TorController (not even shadow).
2272016-03-14T15:50:09  <paveljanik> jonasschnelli, and this is what your and wumpus 's change does :-)
2282016-03-14T15:50:19  <paveljanik> but anyway, warning gone with your PR
2292016-03-14T15:50:24  <jonasschnelli> +1
2302016-03-14T15:50:38  <jonasschnelli> paveljanik: thanks for testing...
2312016-03-14T15:51:09  <paveljanik> it was done almost without me, automagically 8)
2322016-03-14T15:52:58  *** Guyver2 has joined #bitcoin-core-dev
2332016-03-14T15:58:58  *** Thireus has joined #bitcoin-core-dev
2342016-03-14T16:14:01  *** BashCo_ has quit IRC
2352016-03-14T16:16:36  *** dermoth has quit IRC
2362016-03-14T16:20:54  *** rubensayshi has joined #bitcoin-core-dev
2372016-03-14T16:23:57  *** laurentmt has quit IRC
2382016-03-14T16:31:00  *** treehug88 has quit IRC
2392016-03-14T16:31:11  *** treehug88 has joined #bitcoin-core-dev
2402016-03-14T16:36:36  *** BashCo has joined #bitcoin-core-dev
2412016-03-14T16:50:38  *** treehug88 has quit IRC
2422016-03-14T16:53:04  <GitHub73> [bitcoin] jonasschnelli opened pull request #7685: [WIP] Add bloom filter usage statistics (master...2016/03/bf_stats) https://github.com/bitcoin/bitcoin/pull/7685
2432016-03-14T17:03:37  *** treehug88 has joined #bitcoin-core-dev
2442016-03-14T17:10:02  *** laurentmt has joined #bitcoin-core-dev
2452016-03-14T17:15:10  *** dermoth has joined #bitcoin-core-dev
2462016-03-14T17:28:34  *** dermoth has quit IRC
2472016-03-14T17:38:08  <GitHub16> [bitcoin] MarcoFalke opened pull request #7686: [qt] Remove 0-fee from send dialog (master...Mf1603-qt-0-fee) https://github.com/bitcoin/bitcoin/pull/7686
2482016-03-14T17:38:12  <MarcoFalke> spring-cleaning. Let's remove all the code!
2492016-03-14T17:38:32  <GitHub33> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0735c0ca7c22...48f39058315c
2502016-03-14T17:38:33  <GitHub33> bitcoin/master 3d7e973 Jonas Schnelli: Fix torcontrol.cpp unused private field warning
2512016-03-14T17:38:33  <GitHub33> bitcoin/master 48f3905 Wladimir J. van der Laan: Merge #7683: Fix torcontrol.cpp unused private field warning...
2522016-03-14T17:38:40  <GitHub32> [bitcoin] laanwj closed pull request #7683: Fix torcontrol.cpp unused private field warning (master...2016/03/torctrl) https://github.com/bitcoin/bitcoin/pull/7683
2532016-03-14T17:45:11  <morcos> btcdrak: ok, i submitted a PR to your repo for my new RPC test.  it's a handful, but i think it now tests much much more of the consensus logic.
2542016-03-14T17:56:39  *** Tasoshi has joined #bitcoin-core-dev
2552016-03-14T18:03:58  <GitHub177> [bitcoin] sipa opened pull request #7687: Stop treating importaddress'ed scripts as change (master...fixscriptimport) https://github.com/bitcoin/bitcoin/pull/7687
2562016-03-14T18:07:33  *** laurentmt has quit IRC
2572016-03-14T18:22:04  <btcdrak> morcos: thank you very much! I'll take a look after dinner.
2582016-03-14T18:22:46  <GitHub73> [bitcoin] sipa opened pull request #7688: List solvability in listunspent output and improve help (master...helpspendsolv) https://github.com/bitcoin/bitcoin/pull/7688
2592016-03-14T19:06:44  *** wallet42 has joined #bitcoin-core-dev
2602016-03-14T19:16:29  *** Guyver2_ has joined #bitcoin-core-dev
2612016-03-14T19:19:16  *** achow101 has joined #bitcoin-core-dev
2622016-03-14T19:19:47  *** Guyver2 has quit IRC
2632016-03-14T19:19:53  *** Guyver2_ is now known as Guyver2
2642016-03-14T19:32:50  *** dirtynewshoes has joined #bitcoin-core-dev
2652016-03-14T19:50:09  *** skyraider has joined #bitcoin-core-dev
2662016-03-14T20:23:13  *** schmidty has joined #bitcoin-core-dev
2672016-03-14T20:46:42  *** zooko has joined #bitcoin-core-dev
2682016-03-14T20:49:55  *** Don_John has joined #bitcoin-core-dev
2692016-03-14T20:55:52  *** d_t has quit IRC
2702016-03-14T20:58:03  *** Don_John has joined #bitcoin-core-dev
2712016-03-14T21:03:13  *** Don_John has joined #bitcoin-core-dev
2722016-03-14T21:26:19  *** JackH has joined #bitcoin-core-dev
2732016-03-14T21:44:44  *** pigeons_ is now known as pigeons
2742016-03-14T21:50:33  *** skyraider has quit IRC
2752016-03-14T21:55:32  *** jannes has quit IRC
2762016-03-14T22:00:25  *** treehug88 has quit IRC
2772016-03-14T22:03:11  *** [1]evoskuil has joined #bitcoin-core-dev
2782016-03-14T22:05:14  *** evoskuil has quit IRC
2792016-03-14T22:07:34  *** [1]evoskuil has quit IRC
2802016-03-14T22:08:01  *** evoskuil has joined #bitcoin-core-dev
2812016-03-14T22:14:01  *** zooko has quit IRC
2822016-03-14T22:43:46  *** Guyver2 has quit IRC
2832016-03-14T22:47:09  <GitHub87> [bitcoin] sipa opened pull request #7689: Replace OpenSSL AES with our own constant-time version (edit of #5949) (master...const_aes) https://github.com/bitcoin/bitcoin/pull/7689
2842016-03-14T22:47:53  *** d_t has joined #bitcoin-core-dev
2852016-03-14T22:49:38  *** d_t_ has joined #bitcoin-core-dev
2862016-03-14T22:49:43  *** d_t has quit IRC
2872016-03-14T23:20:51  *** d_t_ has quit IRC
2882016-03-14T23:23:36  *** gevs has quit IRC
2892016-03-14T23:49:58  *** Thireus has quit IRC