12016-03-15T00:10:27  *** d_t has joined #bitcoin-core-dev
  22016-03-15T00:20:11  *** d_t_ has joined #bitcoin-core-dev
  32016-03-15T00:20:58  *** belcher has joined #bitcoin-core-dev
  42016-03-15T00:23:09  *** MarcoFalke has quit IRC
  52016-03-15T00:24:06  *** d_t has quit IRC
  62016-03-15T00:38:35  *** d_t_ has quit IRC
  72016-03-15T00:53:53  *** wasi has quit IRC
  82016-03-15T00:58:03  *** AaronvanW has quit IRC
  92016-03-15T01:10:59  *** Ylbam has quit IRC
 102016-03-15T01:45:18  *** molz has quit IRC
 112016-03-15T01:45:58  *** mol11111 has joined #bitcoin-core-dev
 122016-03-15T01:46:25  *** mol11111 is now known as moli
 132016-03-15T01:59:13  *** wallet42 has quit IRC
 142016-03-15T02:16:59  *** Chris_Stewart_5 has quit IRC
 152016-03-15T02:24:29  *** belcher has quit IRC
 162016-03-15T03:02:44  *** fredrin has quit IRC
 172016-03-15T03:03:34  *** fredrin has joined #bitcoin-core-dev
 182016-03-15T03:05:50  *** achow101 has quit IRC
 192016-03-15T03:09:31  *** Giszmo has quit IRC
 202016-03-15T03:12:03  *** fredrin has quit IRC
 212016-03-15T03:13:39  *** fredrin has joined #bitcoin-core-dev
 222016-03-15T03:25:19  *** fengling has joined #bitcoin-core-dev
 232016-03-15T04:21:33  *** wallet42 has joined #bitcoin-core-dev
 242016-03-15T05:38:49  *** davec has quit IRC
 252016-03-15T05:39:19  *** davec has joined #bitcoin-core-dev
 262016-03-15T05:51:51  *** d_t has joined #bitcoin-core-dev
 272016-03-15T06:12:38  *** Thireus has joined #bitcoin-core-dev
 282016-03-15T06:14:00  *** paveljanik has quit IRC
 292016-03-15T06:39:01  *** Alopex has quit IRC
 302016-03-15T06:40:06  *** Alopex has joined #bitcoin-core-dev
 312016-03-15T07:04:30  *** Ylbam has joined #bitcoin-core-dev
 322016-03-15T07:24:39  *** PaulCapestany has quit IRC
 332016-03-15T07:29:22  *** PaulCapestany has joined #bitcoin-core-dev
 342016-03-15T07:43:19  *** jannes has joined #bitcoin-core-dev
 352016-03-15T07:47:04  *** Thireus has quit IRC
 362016-03-15T07:48:43  *** xiangfu has joined #bitcoin-core-dev
 372016-03-15T07:55:04  *** JackH has quit IRC
 382016-03-15T07:58:57  *** Don_John has quit IRC
 392016-03-15T07:59:12  *** BashCo has quit IRC
 402016-03-15T08:13:55  *** Thireus has joined #bitcoin-core-dev
 412016-03-15T08:14:02  *** JackH has joined #bitcoin-core-dev
 422016-03-15T08:19:56  <GitHub126> [bitcoin] laanwj closed pull request #7682: [0.11.3] Fix "Unclear error when starting Bitcoin Core" (0.11...Mf1603-011wallet) https://github.com/bitcoin/bitcoin/pull/7682
 432016-03-15T08:21:51  <GitHub138> [bitcoin] laanwj closed pull request #5949: Replace openssl aes encryption/decryption/key creation implementations with our own (master...aes-keys) https://github.com/bitcoin/bitcoin/pull/5949
 442016-03-15T08:25:09  *** Thireus has quit IRC
 452016-03-15T08:27:23  *** gevs has joined #bitcoin-core-dev
 462016-03-15T08:27:37  <jonasschnelli> sipa, wumpus: Why is https://github.com/bitcoin/bitcoin/pull/7689 labeled with prio high?
 472016-03-15T08:28:06  <jonasschnelli> Side channel attacks? Or did I miss a openssl CVS?
 482016-03-15T08:29:23  *** Thireus has joined #bitcoin-core-dev
 492016-03-15T08:29:47  <midnightmagic> when was the planned date for that CVE release anyway?
 502016-03-15T08:30:04  <jonasschnelli> SPV Info: during the last 12h, one of my nodes (where I collecting stats), served 4.5 GB of filtered blocks (12h!).
 512016-03-15T08:30:18  <GitHub62> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/48f39058315c...a6a860796a44
 522016-03-15T08:30:18  <GitHub62> bitcoin/master 0040118 mrbandrews: Fixes ZMQ startup with bad arguments.
 532016-03-15T08:30:19  <GitHub62> bitcoin/master a6a8607 Wladimir J. van der Laan: Merge #7621: Fixes ZMQ startup with bad arguments....
 542016-03-15T08:30:23  <GitHub34> [bitcoin] laanwj closed pull request #7621: Fixes ZMQ startup with bad arguments. (master...ba-fix-zmq) https://github.com/bitcoin/bitcoin/pull/7621
 552016-03-15T08:30:54  <jonasschnelli> And during the same 12h, the node got 5688 filtered mempool requests
 562016-03-15T08:31:38  <jonasschnelli> Which took: 73min to process (in total)?! can that be possible?
 572016-03-15T08:36:33  *** BashCo has joined #bitcoin-core-dev
 582016-03-15T08:43:26  *** xabbix__ has joined #bitcoin-core-dev
 592016-03-15T08:44:36  *** xabbix_ has quit IRC
 602016-03-15T09:02:41  *** Thireus has quit IRC
 612016-03-15T09:09:56  *** Thireus has joined #bitcoin-core-dev
 622016-03-15T09:20:49  *** fkhan_ has quit IRC
 632016-03-15T09:22:29  *** Naphex has quit IRC
 642016-03-15T09:34:00  *** fkhan_ has joined #bitcoin-core-dev
 652016-03-15T09:35:46  <GitHub139> [bitcoin] jonasschnelli opened pull request #7691: [Wallet] refactor wallet/init interaction (master...2016/03/wallet_mod) https://github.com/bitcoin/bitcoin/pull/7691
 662016-03-15T09:45:43  <GitHub69> [bitcoin] btcdrak opened pull request #7692: Remove p2p alert system (master...remove_alert) https://github.com/bitcoin/bitcoin/pull/7692
 672016-03-15T10:00:07  *** AaronvanW has joined #bitcoin-core-dev
 682016-03-15T10:02:15  *** gevs has quit IRC
 692016-03-15T10:03:42  *** gevs has joined #bitcoin-core-dev
 702016-03-15T10:03:42  *** gevs has joined #bitcoin-core-dev
 712016-03-15T10:05:26  *** jtimon has quit IRC
 722016-03-15T10:13:48  *** MarcoFalke has joined #bitcoin-core-dev
 732016-03-15T10:15:24  <MarcoFalke> btcdrak, there is an issue with the recent cherry-pick: https://bitcoincore.org/en/2016/01/26/segwit-benefits/
 742016-03-15T10:16:13  <btcdrak> weird, fixing.
 752016-03-15T10:20:04  *** MarcoFalke has quit IRC
 762016-03-15T10:39:38  *** fengling has quit IRC
 772016-03-15T10:54:22  *** MarcoFalke has joined #bitcoin-core-dev
 782016-03-15T11:08:35  <MarcoFalke> jonasschnelli, blame qtcreator for the 104px. ;) I assume the program did this because I removed the widget.
 792016-03-15T11:09:10  <MarcoFalke> There were other changes introduced by qtcreator but I was unsure what to do with them
 802016-03-15T11:09:54  <jonasschnelli> MarcoFalke: Yes. But it might be good to rearrange that height. Maybe 70 or 80px.
 812016-03-15T11:13:13  <MarcoFalke> -                    <string>total at least</string>
 822016-03-15T11:13:13  <MarcoFalke> -                    <string>total at least</string>
 832016-03-15T11:13:13  <MarcoFalke> -                    <string>total at least</string>
 842016-03-15T11:13:13  <MarcoFalke> -                    <string>total at least</string>
 852016-03-15T11:13:13  <MarcoFalke> -                    <string>total at least</string>
 862016-03-15T11:13:14  <MarcoFalke> -                    <string>total at least</string>
 872016-03-15T11:13:14  <MarcoFalke> -                    <string>total at least</string>
 882016-03-15T11:13:15  <MarcoFalke> Right, we want to make sure the default size can still hold all widgets when expanded ( https://github.com/bitcoin/bitcoin/issues/6601#issuecomment-196464704 )
 892016-03-15T11:13:42  <MarcoFalke> (sry for junk, I should get a proper IRC client)
 902016-03-15T11:16:04  *** paveljanik has joined #bitcoin-core-dev
 912016-03-15T11:17:04  <MarcoFalke> The only issue with this pull is probably when someone has "-sendfreetransactions" set in their conf.
 922016-03-15T11:17:27  <MarcoFalke> IIRC this will "overwrite" the GUI settings done at run time.
 932016-03-15T11:32:34  *** Noice has quit IRC
 942016-03-15T11:42:07  *** p15x has quit IRC
 952016-03-15T11:56:57  <sipa> jonasschnelli: cory's pull request was also priority high
 962016-03-15T12:01:52  *** Guyver2 has joined #bitcoin-core-dev
 972016-03-15T12:11:57  *** p15x has joined #bitcoin-core-dev
 982016-03-15T12:12:06  <MarcoFalke> jonasschenlli, 7691 looks really neat.
 992016-03-15T12:12:23  <MarcoFalke> But it seems you forgot to remove parameter interaction from init?
1002016-03-15T12:26:09  *** MarcoFalke has quit IRC
1012016-03-15T12:33:51  <morcos> sipa: ping
1022016-03-15T12:37:06  *** BashCo_ has joined #bitcoin-core-dev
1032016-03-15T12:38:25  *** cfields_ has quit IRC
1042016-03-15T12:39:53  *** BashCo has quit IRC
1052016-03-15T12:45:43  <morcos> sipa: I'm just trying to reason through whether your new warning logic is sufficient or not for BIP 9.
1062016-03-15T12:46:23  <morcos> It's unclear what should be fixed in this PR and what should be fixed in a separate PR which cleans up alert logic (for instance making sure the RPC getinfo returns the warnings probably belongs there)
1072016-03-15T12:47:38  <morcos> But part of what concerns me about your PR is the if (!fWarned) guard, it seems like its too easy to accidentally miss whatever warning has happened, especially due to the buggy alert logic where strMiscWarning could be overwritten by too many blocks than expected or something silly
1082016-03-15T12:47:51  *** laurentmt has joined #bitcoin-core-dev
1092016-03-15T12:48:42  <morcos> What do you think it is that we are trying to avoid happening more than once with that guard?  The Notify?  perhaps we should just guard that.
1102016-03-15T12:49:17  *** Giszmo has joined #bitcoin-core-dev
1112016-03-15T12:49:24  <morcos> I'd like to make sure that before we release this code we have something in place such that 0.12.1 code with this released won't accidentally miss future upgrades of either known or unknown type if the user isn't paying very close attention.
1122016-03-15T12:49:30  <morcos> I'm not sure we're quite there yet.
1132016-03-15T12:52:02  <sipa> morcos: i tried to leave as much of the way warnings are issued untouched
1142016-03-15T12:52:56  <morcos> sipa: yeah, but i think the fact that the elegant way your warnings checker doesn't need to run during IBD (which i'd missed before) is a bit hampered by that !fWarned guard.
1152016-03-15T12:53:37  <morcos> which might be a problem with the existing code honestly
1162016-03-15T12:54:17  *** Guyver2 has quit IRC
1172016-03-15T12:54:29  *** Guyver2 has joined #bitcoin-core-dev
1182016-03-15T12:56:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1192016-03-15T12:58:11  <sipa> morcos: and i missed that that fWarned flag was a static, so i had removed it in an earlier version
1202016-03-15T12:59:04  <sipa> i think the whole warning system is broken (not visible enough, no way to have multiple parallel warnings, not having transient warnings, ...)
1212016-03-15T12:59:33  <sipa> but i don't feel that should be fixed in this PR
1222016-03-15T12:59:56  <sipa> maybe it does need fixing separately before we release any bip9 code
1232016-03-15T13:00:15  <morcos> sipa: yeah i was just looking at that
1242016-03-15T13:00:19  <morcos> thats what i think
1252016-03-15T13:00:28  <morcos> i don't think it has to be that hard
1262016-03-15T13:00:42  <morcos> but i'm just a bit hesitant b/c i'm not familiar with the statusBar/GUI stuff
1272016-03-15T13:00:57  <morcos> but for the RPC warnings, it seems we could just concatenate any active warnings
1282016-03-15T13:01:15  *** Chris_Stewart_5 has quit IRC
1292016-03-15T13:01:17  <morcos> but i think its worth fixing at least to some degree before release
1302016-03-15T13:01:27  <morcos> but if you dont' want to do that, i'd say an alternative
1312016-03-15T13:01:37  <sipa> i think you want warnings to be a set of strings, that is constructed by merging the warning sets computed by different subsystems
1322016-03-15T13:01:55  <morcos> is to put the !fWarned guard on Notify and strMiscWarning, but keep logprintf's happening period
1332016-03-15T13:01:58  <sipa> each subsystem is responsible for caching its own warnings for as long as they are applicable
1342016-03-15T13:02:13  <morcos> so then at the very least the debug log will be constantly telling you if your version is out of date
1352016-03-15T13:02:21  <morcos> sipa: yes agree
1362016-03-15T13:02:41  <morcos> the problem is do we want to back port all those changes to .11 and .12?
1372016-03-15T13:04:36  <morcos> It seems like its the case now that anybody running .11.2 or .12.0 might miss warnings of the upgrade to BIP9 right?  they'll have that warning set once, but then it might be wiped out by one of the frivolous warnings
1382016-03-15T13:06:04  <morcos> brb
1392016-03-15T13:10:15  *** laurentmt has quit IRC
1402016-03-15T13:13:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1412016-03-15T13:37:29  <morcos> sipa: heh, shows how much i know.  that strRPC is only for determining whether safeMode is required for RPC commands.  strStatusBar is what is returned by RPC commands, so that does get updated.
1422016-03-15T13:37:50  <morcos> but we still have the problem of transient warnings
1432016-03-15T13:42:52  *** Guyver2 has quit IRC
1442016-03-15T13:45:34  <dgenr8> morcos: is it silly to warn the user if some miner breaks sha256 and starts issuing a block per 10s?
1452016-03-15T13:45:38  *** AaronvanW has quit IRC
1462016-03-15T13:46:06  <morcos> dgenr8: i called them silly because they happen all the time as false positives now, not that the idea is silly
1472016-03-15T13:46:51  <morcos> although maybe that just got fixed?
1482016-03-15T13:48:03  *** AaronvanW has joined #bitcoin-core-dev
1492016-03-15T13:48:04  *** AaronvanW has quit IRC
1502016-03-15T13:48:04  *** AaronvanW has joined #bitcoin-core-dev
1512016-03-15T13:52:11  <dgenr8> oh ok.  i think #7568 fixes it
1522016-03-15T14:00:33  <morcos> sipa: i think we should just do the quick and dirty fix for backports.  which in my mind is only use the !fWarned guard on calling Notify.
1532016-03-15T14:00:56  <morcos> This means that unknown block versions will always overwrite partition checks
1542016-03-15T14:01:23  <morcos> But LargeWorkForks will overwrite either of those
1552016-03-15T14:02:05  <morcos> Then we can clean up the Alert system for 0.13 properly, but right now there is no locking around any of these variables used in alerts and it seems a bit invasive to do it properly
1562016-03-15T14:02:09  <morcos> thoughts?
1572016-03-15T14:03:08  <sipa> seems reasonable
1582016-03-15T14:04:13  *** Guyver2 has joined #bitcoin-core-dev
1592016-03-15T14:10:13  *** jtimon has joined #bitcoin-core-dev
1602016-03-15T14:20:22  *** zooko has joined #bitcoin-core-dev
1612016-03-15T14:21:50  <GitHub2> [bitcoin] btcdrak closed pull request #7544: Backport BIP112 implementation for 0.12 (0.12...dot12_backport_bip112) https://github.com/bitcoin/bitcoin/pull/7544
1622016-03-15T14:43:20  *** laurentmt has joined #bitcoin-core-dev
1632016-03-15T14:44:31  *** laurentmt has quit IRC
1642016-03-15T14:51:48  *** xiangfu_ has joined #bitcoin-core-dev
1652016-03-15T15:13:57  *** JackH has quit IRC
1662016-03-15T15:18:47  *** xiangfu_ has quit IRC
1672016-03-15T15:56:17  *** Thireus has quit IRC
1682016-03-15T16:08:33  *** amiller_ has quit IRC
1692016-03-15T16:13:26  *** Guest80236 has joined #bitcoin-core-dev
1702016-03-15T16:21:36  *** laurentmt has joined #bitcoin-core-dev
1712016-03-15T16:23:39  *** laurentmt has quit IRC
1722016-03-15T16:32:06  *** BashCo_ has quit IRC
1732016-03-15T16:40:19  *** zooko has quit IRC
1742016-03-15T16:46:37  *** cfields has joined #bitcoin-core-dev
1752016-03-15T16:51:34  *** Squidicuz has joined #bitcoin-core-dev
1762016-03-15T16:52:29  *** BashCo has joined #bitcoin-core-dev
1772016-03-15T17:18:43  *** murch has joined #bitcoin-core-dev
1782016-03-15T17:37:16  *** Thireus has joined #bitcoin-core-dev
1792016-03-15T17:37:37  *** murch has quit IRC
1802016-03-15T17:38:36  *** murch has joined #bitcoin-core-dev
1812016-03-15T17:51:00  *** BashCo_ has joined #bitcoin-core-dev
1822016-03-15T17:52:45  *** gevs has quit IRC
1832016-03-15T17:53:05  *** BashCo has quit IRC
1842016-03-15T17:58:24  *** p15x has quit IRC
1852016-03-15T18:08:18  *** slackircbridge has quit IRC
1862016-03-15T18:09:27  *** xabbix__ has quit IRC
1872016-03-15T18:09:34  *** gevs has joined #bitcoin-core-dev
1882016-03-15T18:09:34  *** gevs has joined #bitcoin-core-dev
1892016-03-15T18:10:15  *** xabbix__ has joined #bitcoin-core-dev
1902016-03-15T18:12:16  *** wallet421 has joined #bitcoin-core-dev
1912016-03-15T18:12:22  *** slackircbridge has joined #bitcoin-core-dev
1922016-03-15T18:15:28  *** wallet42 has quit IRC
1932016-03-15T18:21:10  *** hybridsole has quit IRC
1942016-03-15T18:21:10  *** Hybrids0le has joined #bitcoin-core-dev
1952016-03-15T18:30:29  *** dermoth has joined #bitcoin-core-dev
1962016-03-15T18:53:41  <GitHub85> [bitcoin] btcdrak closed pull request #7561: IsSuperMajority() softfork for BIPs 68,112 and 113 (master...softfork) https://github.com/bitcoin/bitcoin/pull/7561
1972016-03-15T19:38:37  <GitHub97> [bitcoin] btcdrak opened pull request #7693: [0.11 backport] BIP112 CHECKSEQUENCEVERIFY mempool-only (0.11...bip112-backport-0.11) https://github.com/bitcoin/bitcoin/pull/7693
1982016-03-15T19:46:29  *** achow101 has joined #bitcoin-core-dev
1992016-03-15T19:58:17  *** Hybrids0le is now known as hybridsole
2002016-03-15T20:07:45  *** laurentmt has joined #bitcoin-core-dev
2012016-03-15T20:24:00  <GitHub175> [bitcoin] pstratem opened pull request #7694: Rename AcceptBlock/AcceptBlockHeader to StoreBlock/StoreBlockHeader (master...2016-03-15-naming) https://github.com/bitcoin/bitcoin/pull/7694
2022016-03-15T20:24:22  *** Guyver2_ has joined #bitcoin-core-dev
2032016-03-15T20:27:07  *** Guyver2 has quit IRC
2042016-03-15T20:27:15  *** Guyver2_ is now known as Guyver2
2052016-03-15T20:30:12  *** murch has quit IRC
2062016-03-15T20:48:35  *** fredrin has quit IRC
2072016-03-15T20:49:04  *** afk11 has quit IRC
2082016-03-15T20:50:20  *** fredrin has joined #bitcoin-core-dev
2092016-03-15T20:50:57  *** afk11 has joined #bitcoin-core-dev
2102016-03-15T20:55:36  *** fredrin has quit IRC
2112016-03-15T20:58:21  *** treehug88 has joined #bitcoin-core-dev
2122016-03-15T21:06:43  *** fredrin has joined #bitcoin-core-dev
2132016-03-15T21:11:08  <GitHub72> [bitcoin] morcos opened pull request #7695: [0.11] Backport BIP 68 mempool only (0.11...68backport) https://github.com/bitcoin/bitcoin/pull/7695
2142016-03-15T21:18:05  *** Don_John has joined #bitcoin-core-dev
2152016-03-15T21:29:38  *** treehug88 has quit IRC
2162016-03-15T21:33:21  <Luke-Jr> http://seclists.org/oss-sec/2016/q1/645
2172016-03-15T21:44:01  *** neha has quit IRC
2182016-03-15T22:00:29  *** randy-waterhouse has joined #bitcoin-core-dev
2192016-03-15T22:09:20  *** laurentmt has quit IRC
2202016-03-15T22:15:14  *** Guest80236 has quit IRC
2212016-03-15T22:15:15  *** Guest80236 has joined #bitcoin-core-dev
2222016-03-15T22:15:15  *** Guest80236 is now known as amiller
2232016-03-15T22:20:53  *** BashCo has joined #bitcoin-core-dev
2242016-03-15T22:23:42  *** BashCo_ has quit IRC
2252016-03-15T22:59:44  *** Guyver2_ has joined #bitcoin-core-dev
2262016-03-15T22:59:52  *** Guyver2 has quit IRC
2272016-03-15T23:09:17  *** arubi has quit IRC
2282016-03-15T23:16:36  *** arubi has joined #bitcoin-core-dev
2292016-03-15T23:23:36  *** wallet421 has quit IRC
2302016-03-15T23:24:37  *** Don_John_ has joined #bitcoin-core-dev
2312016-03-15T23:25:28  *** wallet42 has joined #bitcoin-core-dev
2322016-03-15T23:26:21  *** wallet42 has quit IRC
2332016-03-15T23:27:18  *** wallet42 has joined #bitcoin-core-dev
2342016-03-15T23:27:49  *** Don_John has quit IRC
2352016-03-15T23:27:55  *** wallet42 has quit IRC
2362016-03-15T23:28:18  *** wallet42 has joined #bitcoin-core-dev
2372016-03-15T23:41:16  *** wallet42 has quit IRC
2382016-03-15T23:46:25  *** Don_John_ has quit IRC
2392016-03-15T23:46:26  *** instagibbs has quit IRC
2402016-03-15T23:48:22  *** instagibbs has joined #bitcoin-core-dev