12016-04-01T00:11:56  *** fengling has joined #bitcoin-core-dev
  22016-04-01T00:16:16  *** fengling has quit IRC
  32016-04-01T00:21:02  *** Ylbam has quit IRC
  42016-04-01T00:33:43  *** fengling has joined #bitcoin-core-dev
  52016-04-01T00:37:41  <ebfull> the bitcoin core contributing guidelines are vague on one point; is the author of a pull request free to rebase as their changes become unmergeable?
  62016-04-01T00:38:22  <ebfull> it does claim that rebasing and squashing may be asked of the author by "maintainers"
  72016-04-01T00:40:10  <gmaxwell> ebfull: just try to not confuse other reviewers, if its gone quiet (like your HTLC) is, I think it's fine to slice and dice the whole thing up.
  82016-04-01T00:41:28  <ebfull> thanks. moreover, would you find a policy asking contributors to submit a new pull request to avoid force pushes to their branches to be a silly rule/guideline? (presumably out of a fear of destroying history for reviewers)
  92016-04-01T00:42:10  <gmaxwell> it wouldn't be silly but it might be a bit over strong.   Esp for trivial patches.
 102016-04-01T00:42:19  <ebfull> or trivial rebases
 112016-04-01T00:42:23  <ebfull> cool, thanks!
 122016-04-01T00:42:34  *** Thireus has quit IRC
 132016-04-01T00:42:54  *** Thireus has joined #bitcoin-core-dev
 142016-04-01T01:01:47  *** justanotheruser has quit IRC
 152016-04-01T01:02:54  *** justanotheruser has joined #bitcoin-core-dev
 162016-04-01T01:15:04  *** dirtynewshoes has quit IRC
 172016-04-01T01:15:33  *** dirtynewshoes has joined #bitcoin-core-dev
 182016-04-01T01:18:43  *** frankenmint has joined #bitcoin-core-dev
 192016-04-01T01:35:34  *** Giszmo has quit IRC
 202016-04-01T01:41:17  *** p15 has joined #bitcoin-core-dev
 212016-04-01T01:47:32  <cfields> what's the purpose of mapRelay? Just a cache to avoid hitting the mempool for fresh transactions?
 222016-04-01T01:48:45  <gmaxwell> no so you will answer transactions you advertised recently even if they're not in mempool anymore. (e.g. just got mined.)
 232016-04-01T01:50:10  <cfields> aha, thanks
 242016-04-01T02:00:59  *** zooko has joined #bitcoin-core-dev
 252016-04-01T02:13:13  <Luke-Jr> hm, is there a reason to do that?
 262016-04-01T02:13:31  <Luke-Jr> if it got mined, you're presumably going to resend it as part of the block anyway, right?
 272016-04-01T02:17:08  <gmaxwell> who says the peer even fetches the block?
 282016-04-01T02:25:43  *** frankenmint has quit IRC
 292016-04-01T02:33:26  <GitHub137> [bitcoin] morcos closed pull request #7557: Encapsulate options for mempool policy (master...policyOptions) https://github.com/bitcoin/bitcoin/pull/7557
 302016-04-01T02:34:53  <GitHub66> [bitcoin] morcos closed pull request #7556: Some cleanup work for mempool and policy estimator (master...cleanupMempool) https://github.com/bitcoin/bitcoin/pull/7556
 312016-04-01T02:48:06  *** xiangfu has joined #bitcoin-core-dev
 322016-04-01T03:13:33  *** achow101 has quit IRC
 332016-04-01T03:14:02  *** Alopex has quit IRC
 342016-04-01T03:15:07  *** Alopex has joined #bitcoin-core-dev
 352016-04-01T03:15:54  *** ajweutr has quit IRC
 362016-04-01T03:24:05  *** zooko has quit IRC
 372016-04-01T03:44:45  *** Don_John has quit IRC
 382016-04-01T03:51:30  *** frankenmint has joined #bitcoin-core-dev
 392016-04-01T04:15:15  *** cguida has quit IRC
 402016-04-01T04:19:18  *** cguida has joined #bitcoin-core-dev
 412016-04-01T04:21:19  *** kangx has quit IRC
 422016-04-01T04:28:01  *** Alopex has quit IRC
 432016-04-01T04:29:06  *** Alopex has joined #bitcoin-core-dev
 442016-04-01T04:55:33  *** d_t has quit IRC
 452016-04-01T05:01:19  *** davec has quit IRC
 462016-04-01T05:03:06  *** Tasoshi_ has quit IRC
 472016-04-01T05:07:25  *** davec has joined #bitcoin-core-dev
 482016-04-01T05:10:01  *** Alopex has quit IRC
 492016-04-01T05:11:06  *** Alopex has joined #bitcoin-core-dev
 502016-04-01T05:36:49  *** p15 has quit IRC
 512016-04-01T05:39:02  *** p15 has joined #bitcoin-core-dev
 522016-04-01T05:43:26  *** jtimon has quit IRC
 532016-04-01T06:06:00  <btcdrak> ebfull: we don't have a policy against rebasing in pull requests. most of rerbase and even ask for PR authors to squash where it makes sense.
 542016-04-01T06:06:45  <sipa> i tend to rebase continuously, updating individual commits in a way to make the history most logical
 552016-04-01T06:06:56  <sipa> until there is significant review
 562016-04-01T06:07:30  <ebfull> i agree with your policy (and it's what i'm used to on github); i had other reasons for asking :)
 572016-04-01T06:07:36  *** Ylbam has joined #bitcoin-core-dev
 582016-04-01T06:29:19  *** wallet42 has quit IRC
 592016-04-01T06:50:48  *** paveljanik has quit IRC
 602016-04-01T06:55:17  *** trippysalmon has quit IRC
 612016-04-01T07:01:47  *** frankenmint has quit IRC
 622016-04-01T07:20:05  <sipa> ahERROR: no certificate subject alternative name matches
 632016-04-01T07:20:05  <sipa> requested host name `fukuchi.org'.
 642016-04-01T07:20:05  <sipa> To connect to fukuchi.org insecurely, use `--no-check-certificate'.
 652016-04-01T07:20:06  <sipa> OpenSSL: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
 662016-04-01T07:20:09  <sipa> in travis?
 672016-04-01T07:26:29  <jouke>  /win 38
 682016-04-01T07:26:32  <jouke> ...
 692016-04-01T07:27:29  <sipa> jouke: no, win 10
 702016-04-01T07:43:05  *** AaronvanW has joined #bitcoin-core-dev
 712016-04-01T07:49:40  *** abritoid has joined #bitcoin-core-dev
 722016-04-01T07:57:43  *** PaulCapestany has joined #bitcoin-core-dev
 732016-04-01T08:00:42  *** PaulCape_ has quit IRC
 742016-04-01T08:04:58  *** paveljanik has joined #bitcoin-core-dev
 752016-04-01T08:12:30  *** dgenr8 has quit IRC
 762016-04-01T08:12:55  *** Evel-Knievel has quit IRC
 772016-04-01T08:13:01  *** dgenr8 has joined #bitcoin-core-dev
 782016-04-01T08:13:22  *** Evel-Knievel has joined #bitcoin-core-dev
 792016-04-01T08:14:38  *** dgenr8 has quit IRC
 802016-04-01T08:19:07  *** dgenr8 has joined #bitcoin-core-dev
 812016-04-01T08:24:04  *** PaulCape_ has joined #bitcoin-core-dev
 822016-04-01T08:24:56  <Luke-Jr> well, it's technically a bad practice to rebase once published, but most of us tend to ignore that for better or worse :x
 832016-04-01T08:26:49  *** PaulCapestany has quit IRC
 842016-04-01T08:27:03  <sipa> Luke-Jr: depends whether you want to optimize for convenience of mergers, or convenience of future reviewers of the code.
 852016-04-01T08:27:42  <gmaxwell> There is no such thing as technically in the affairs of men.
 862016-04-01T08:28:07  <Luke-Jr> sipa: therefore you rebase until there is nobody to benefit from the no-longer-rebasing? :P
 872016-04-01T08:28:25  *** fengling has quit IRC
 882016-04-01T08:28:26  <Luke-Jr> gmaxwell: technically a bad practice because it screws up git badly ;)
 892016-04-01T08:28:33  <gmaxwell> for us we should optimize strongly for long term maintance... which suggests rebasing extensively until it's not useful to do so anymore. :)
 902016-04-01T08:29:10  <Luke-Jr> gmaxwell: I could argue against that, but not worth spending time debating it.
 912016-04-01T08:29:19  <Luke-Jr> it is what it is
 922016-04-01T08:29:38  *** Guyver2 has joined #bitcoin-core-dev
 932016-04-01T08:31:26  <gmaxwell> can't make everyone happy.
 942016-04-01T08:31:37  <Luke-Jr> maybe some day when Bitcoin is 1.0 and we're all down to <=40 hour weeks with nothing to do, it will make sense to reconsider XD
 952016-04-01T08:51:20  *** PaulCapestany has joined #bitcoin-core-dev
 962016-04-01T08:53:46  *** PaulCape_ has quit IRC
 972016-04-01T08:58:32  *** Guyver2 has quit IRC
 982016-04-01T09:01:34  *** paveljanik has quit IRC
 992016-04-01T09:16:42  *** PaulCape_ has joined #bitcoin-core-dev
1002016-04-01T09:20:00  *** PaulCapestany has quit IRC
1012016-04-01T09:45:06  *** PaulCapestany has joined #bitcoin-core-dev
1022016-04-01T09:47:51  *** PaulCape_ has quit IRC
1032016-04-01T10:07:07  *** ghtdak has quit IRC
1042016-04-01T10:07:35  *** ghtdak has joined #bitcoin-core-dev
1052016-04-01T10:08:27  *** PaulCape_ has joined #bitcoin-core-dev
1062016-04-01T10:11:15  *** PaulCapestany has quit IRC
1072016-04-01T10:37:39  *** PaulCapestany has joined #bitcoin-core-dev
1082016-04-01T10:40:21  *** PaulCape_ has quit IRC
1092016-04-01T10:52:07  *** fredrin has quit IRC
1102016-04-01T11:24:01  *** Alopex has quit IRC
1112016-04-01T11:25:06  *** Alopex has joined #bitcoin-core-dev
1122016-04-01T11:52:17  *** paveljanik has joined #bitcoin-core-dev
1132016-04-01T12:08:21  *** fredrin has joined #bitcoin-core-dev
1142016-04-01T12:17:14  <GitHub52> [bitcoin] laanwj pushed 2 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/4d035bcc9aa3...c5f94f6584cb
1152016-04-01T12:17:14  <GitHub52> bitcoin/0.12 8692626 BtcDrak: Disable bad chain alerts...
1162016-04-01T12:17:14  <GitHub66> [bitcoin] laanwj closed pull request #7780: [0.12] Disable bad-chain alert (0.12...spurious) https://github.com/bitcoin/bitcoin/pull/7780
1172016-04-01T12:17:15  <GitHub52> bitcoin/0.12 c5f94f6 Wladimir J. van der Laan: Merge #7780: [0.12] Disable bad-chain alert...
1182016-04-01T12:20:37  *** MarcoFalke has joined #bitcoin-core-dev
1192016-04-01T12:23:08  *** jtimon has joined #bitcoin-core-dev
1202016-04-01T12:40:08  <GitHub181> [bitcoin] laanwj opened pull request #7781: devtools: Auto-set branch to merge to in github-merge (master...2016_04_github_merge_autobranch) https://github.com/bitcoin/bitcoin/pull/7781
1212016-04-01T12:42:06  *** goregrind has quit IRC
1222016-04-01T12:42:09  *** ryan-c has quit IRC
1232016-04-01T12:43:03  <GitHub124> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/28ad4d9fc2be...e9723cb27384
1242016-04-01T12:43:03  <GitHub124> bitcoin/master 7539f1a Wladimir J. van der Laan: tests: Make proxy_test work on travis servers without IPv6
1252016-04-01T12:43:03  <GitHub179> [bitcoin] laanwj closed pull request #7489: tests: Make proxy_test work on travis servers without IPv6 (master...2016_02_ipv6_tests_conditional) https://github.com/bitcoin/bitcoin/pull/7489
1262016-04-01T12:43:04  <GitHub124> bitcoin/master e9723cb Wladimir J. van der Laan: Merge #7489: tests: Make proxy_test work on travis servers without IPv6...
1272016-04-01T12:44:47  *** goregrind has joined #bitcoin-core-dev
1282016-04-01T12:44:52  *** arubi has quit IRC
1292016-04-01T12:49:46  *** ryan-c has joined #bitcoin-core-dev
1302016-04-01T12:51:08  *** arubi has joined #bitcoin-core-dev
1312016-04-01T13:06:03  *** Giszmo has joined #bitcoin-core-dev
1322016-04-01T13:09:09  *** Luke-Jr has quit IRC
1332016-04-01T13:10:11  *** Luke-Jr has joined #bitcoin-core-dev
1342016-04-01T13:12:29  *** cryptapus_afk is now known as cryptapus
1352016-04-01T13:14:12  *** Luke-Jr has quit IRC
1362016-04-01T13:17:02  *** Luke-Jr has joined #bitcoin-core-dev
1372016-04-01T13:28:14  *** laurentmt has joined #bitcoin-core-dev
1382016-04-01T13:31:04  *** p15 has quit IRC
1392016-04-01T13:59:44  *** abritoid has quit IRC
1402016-04-01T14:05:05  *** laurentmt has quit IRC
1412016-04-01T15:15:17  <GitHub3> [bitcoin] jonasschnelli opened pull request #7783: [Qt] RPC-Console: support nested commands and simple value queries (master...2016/04/qt_console_nested) https://github.com/bitcoin/bitcoin/pull/7783
1422016-04-01T15:55:00  <GitHub44> [bitcoin] laanwj closed pull request #7485: Use system univalue by default (master...sys_univalue_def) https://github.com/bitcoin/bitcoin/pull/7485
1432016-04-01T16:00:17  <GitHub75> [bitcoin] laanwj closed pull request #7464: Opt-in RBF must be strictly enabled or disabled before GBT can be called (master...master) https://github.com/bitcoin/bitcoin/pull/7464
1442016-04-01T16:04:55  *** bn0t has joined #bitcoin-core-dev
1452016-04-01T16:11:53  *** frankenmint has joined #bitcoin-core-dev
1462016-04-01T16:22:04  <instagibbs> in TestingSetup constructor, is the coinbaseKey.MakeNewKey stuff to just over-write the true genesis block for testing?
1472016-04-01T16:35:03  *** laurentmt has joined #bitcoin-core-dev
1482016-04-01T16:38:43  *** laurentmt has quit IRC
1492016-04-01T16:41:58  *** Squidicuz has joined #bitcoin-core-dev
1502016-04-01T16:53:08  *** bn0t has quit IRC
1512016-04-01T17:03:05  *** Luke-Jr has quit IRC
1522016-04-01T17:18:11  *** Luke-Jr has joined #bitcoin-core-dev
1532016-04-01T17:22:19  *** murch has joined #bitcoin-core-dev
1542016-04-01T17:28:40  *** Luke-Jr has quit IRC
1552016-04-01T17:32:07  *** Luke-Jr has joined #bitcoin-core-dev
1562016-04-01T17:39:00  *** Luke-Jr has quit IRC
1572016-04-01T17:42:28  *** Luke-Jr has joined #bitcoin-core-dev
1582016-04-01T17:47:06  *** luke-jr_ has joined #bitcoin-core-dev
1592016-04-01T17:47:25  <paveljanik> jonasschnelli, do you have Qt5DBus.pc in 5.6?
1602016-04-01T17:47:27  *** Luke-Jr has quit IRC
1612016-04-01T18:31:50  <jonasschnelli> paveljanik: I saw you have found it. Or should I try to locate the file?
1622016-04-01T18:32:18  <paveljanik> jonasschnelli, I generated it 8)
1632016-04-01T18:32:30  <paveljanik> do you have it in your installation?
1642016-04-01T18:33:54  <paveljanik> The official installer has DBus framework...
1652016-04-01T18:47:21  *** luke-jr_ has quit IRC
1662016-04-01T19:03:02  *** achow101 has joined #bitcoin-core-dev
1672016-04-01T19:03:51  * jonasschnelli checks for paveljaniks file
1682016-04-01T19:08:42  <jonasschnelli> paveljanik: no. no Qt5DBus.pc
1692016-04-01T19:08:50  <jonasschnelli> But also not in 5.5.1
1702016-04-01T19:08:58  <jonasschnelli> maybe not on OSX?
1712016-04-01T19:10:01  <paveljanik> Don't know. There was one in 5.4.
1722016-04-01T19:12:51  *** luke-jr_ has joined #bitcoin-core-dev
1732016-04-01T19:22:01  *** jannes has quit IRC
1742016-04-01T19:24:03  *** jtimon has quit IRC
1752016-04-01T19:24:55  <gmaxwell> https://github.com/blog/2141-squash-your-commits but can you turn off both?
1762016-04-01T19:27:45  <jonasschnelli> sipa: p2penc: you said the size of the size of the encrypted payload should be after the payload itself to increase performance of the AEAD. Right?
1772016-04-01T19:28:22  <jonasschnelli> But my humble net/buffer experience tells me the size must be before the payload in order to work with chunked messages transmitting
1782016-04-01T19:29:10  <gmaxwell> how can the size be after? how would you find the size?  the authentication code should be after so you can read/write it in a streaming manner.
1792016-04-01T19:29:35  *** Guyver2 has joined #bitcoin-core-dev
1802016-04-01T19:30:17  <gmaxwell> the only way I know to make the size 'after' is to use a self-delimiting encoding which doesn't have an explicit size at all.
1812016-04-01T19:30:51  <sipa> jonasschnelli: the size obviously has to go first!
1822016-04-01T19:31:00  <sipa> jonasschnelli: but the authentication tag goes after
1832016-04-01T19:31:09  <jonasschnelli> Ah. Mixed it up. Right.
1842016-04-01T19:31:23  <jonasschnelli> And the tag has a fixed size. Right.
1852016-04-01T19:31:32  <jonasschnelli> [09:29:02] <gmaxwell> by sending a message in the channel, "everything that follows will be the next key"
1862016-04-01T19:31:49  <jonasschnelli> I also think about the rekeying issue. Do we really need an additional message for that?
1872016-04-01T19:32:02  <jonasschnelli> hmm.. I think so.
1882016-04-01T19:33:03  <jonasschnelli> Or we could reuse the "encinit" message with a 33 zero bytes as pubkey to indicate "a next key".
1892016-04-01T19:35:54  <GitHub128> [bitcoin] instagibbs opened pull request #7784: miner_tests number clarification (master...patch-4) https://github.com/bitcoin/bitcoin/pull/7784
1902016-04-01T19:37:44  <GitHub151> [bitcoin] paveljanik opened pull request #7785: Trivial: Fix typo: Optimizaton -> Optimization [skip ci] (master...patch-16) https://github.com/bitcoin/bitcoin/pull/7785
1912016-04-01T19:41:39  <btcdrak> gmaxwell: no, you have to choose one https://usercontent.irccloud-cdn.com/file/mf5sjbnQ/screenshot-github.com%202016-04-01%2020-41-08.png
1922016-04-01T19:43:52  <Arnavion> Why turn both off? Is it that you want to remove the ability to merge from the web page, and only allow it from CLI + push?
1932016-04-01T19:45:15  <MarcoFalke> turning off both would mean auto-rebase, I assume
1942016-04-01T19:45:55  <jonasschnelli> btcdrak: we do not merge with github, right?
1952016-04-01T19:45:57  <MarcoFalke> I am wondering who is the author of the squash commit?
1962016-04-01T19:46:02  <MarcoFalke> no we don't
1972016-04-01T19:46:07  <gmaxwell> Arnavion: correct. Some projects, like bitcoin core forbid webpage merges by procedure.
1982016-04-01T19:46:12  <Arnavion> Yeah
1992016-04-01T19:46:15  <jonasschnelli> MarcoFalke: the merger.
2002016-04-01T19:46:37  <jonasschnelli> Arnavion: Github merges are not GPG signed.
2012016-04-01T19:46:54  <Arnavion> I don't know if GH will want to put in an option to reduce the functionality of their website, heh
2022016-04-01T19:46:56  <jonasschnelli> Github could smuggle in a MAX_BLOCKSIZE change. :)
2032016-04-01T19:47:50  <jonasschnelli> sipa gmaxwell: Is it relevant to hash(old_session_id) the session-id during re-keying?
2042016-04-01T19:48:05  <btcdrak> gmaxwell: "merge by webpage", you make it sound so dirty!
2052016-04-01T19:48:10  <btcdrak> :)
2062016-04-01T19:48:14  <MarcoFalke> Is there an "emergency plan" ready in case somone hit's the GitHub merge button by accident :) ?
2072016-04-01T19:48:26  <jonasschnelli> MarcoFalke: I think its disabled.
2082016-04-01T19:48:41  *** Don_John has joined #bitcoin-core-dev
2092016-04-01T19:49:02  <gmaxwell> AFAIK it's not because there is no way to do so.
2102016-04-01T20:42:22  <cfields> github also allows you to disable a merge until tests have passed
2112016-04-01T20:42:36  <cfields> so at least a MAX_BLOCKSIZE would have to fix the unit tests as well :p
2122016-04-01T20:42:49  <cfields> *MAX_BLOCKSIZE change
2132016-04-01T20:47:42  * jonasschnelli is wondering if kanzure is looking for something to type...
2142016-04-01T20:48:21  <jonasschnelli> kanzure: If you have time, I need a native english to fix the enc/auth BIPs. https://github.com/bitcoin/bips/pull/362/files
2152016-04-01T20:48:52  *** frankenmint has quit IRC
2162016-04-01T20:49:01  <jonasschnelli> Its not final but a clean language/grammar would be good at this point.
2172016-04-01T20:49:21  <jonasschnelli> (can also be any other volunteer)
2182016-04-01T20:50:35  <jonasschnelli> Can directly be PRed (no I'm getting impudent) https://github.com/jonasschnelli/bips/commits/2016/03/auth_enc2
2192016-04-01T20:53:36  *** d_t has joined #bitcoin-core-dev
2202016-04-01T20:58:26  *** droark has joined #bitcoin-core-dev
2212016-04-01T21:25:01  *** wallet42 has joined #bitcoin-core-dev
2222016-04-01T21:32:20  *** frankenmint has joined #bitcoin-core-dev
2232016-04-01T21:45:07  <GitHub5> [bitcoin] s-matthew-english opened pull request #7786: Update policy.cpp (master...patch-2) https://github.com/bitcoin/bitcoin/pull/7786
2242016-04-01T21:50:33  *** murch has left #bitcoin-core-dev
2252016-04-01T22:05:17  *** achow101 has quit IRC
2262016-04-01T22:09:38  *** achow101 has joined #bitcoin-core-dev
2272016-04-01T22:11:08  *** cryptapus is now known as cryptapus_afk
2282016-04-01T22:11:26  *** achow101 has quit IRC
2292016-04-01T22:12:38  *** achow101 has joined #bitcoin-core-dev
2302016-04-01T22:17:17  *** supasonic has joined #bitcoin-core-dev
2312016-04-01T22:19:42  *** MarcoFalke has quit IRC
2322016-04-01T22:24:45  <kanzure> jonasschnelli: so basic rewrite keep meaning the same?
2332016-04-01T22:25:07  <kanzure> i will look at this.
2342016-04-01T22:26:53  *** frankenmint has quit IRC
2352016-04-01T22:27:21  *** frankenmint has joined #bitcoin-core-dev
2362016-04-01T22:29:02  *** Guyver2 has quit IRC
2372016-04-01T22:42:28  *** jtimon has joined #bitcoin-core-dev
2382016-04-01T22:53:35  *** AaronvanW has quit IRC
2392016-04-01T23:04:34  *** PRab has joined #bitcoin-core-dev
2402016-04-01T23:07:36  *** davec has quit IRC
2412016-04-01T23:07:54  *** davec has joined #bitcoin-core-dev
2422016-04-01T23:18:43  *** laurentmt has joined #bitcoin-core-dev
2432016-04-01T23:21:55  *** laurentmt has quit IRC
2442016-04-01T23:51:10  *** AaronvanW has joined #bitcoin-core-dev
2452016-04-01T23:51:11  *** AaronvanW has joined #bitcoin-core-dev
2462016-04-01T23:59:19  *** wallet42 has quit IRC