12016-04-05T00:01:57  *** zooko has quit IRC
  22016-04-05T00:02:47  *** zooko`` has joined #bitcoin-core-dev
  32016-04-05T00:17:19  *** zooko`` has quit IRC
  42016-04-05T00:21:03  *** Ylbam has quit IRC
  52016-04-05T00:39:26  *** cguida has joined #bitcoin-core-dev
  62016-04-05T00:52:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  72016-04-05T00:53:31  *** zooko`` has joined #bitcoin-core-dev
  82016-04-05T01:26:37  *** [b__b] has quit IRC
  92016-04-05T01:26:56  *** [b__b] has joined #bitcoin-core-dev
 102016-04-05T01:29:23  *** Luke-Jr has quit IRC
 112016-04-05T01:31:59  *** Luke-Jr has joined #bitcoin-core-dev
 122016-04-05T01:32:26  *** Giszmo has quit IRC
 132016-04-05T01:40:07  *** fengling has joined #bitcoin-core-dev
 142016-04-05T01:44:24  *** zooko`` has quit IRC
 152016-04-05T01:49:25  *** wallet42 has joined #bitcoin-core-dev
 162016-04-05T02:02:58  *** p15 has joined #bitcoin-core-dev
 172016-04-05T02:18:14  *** gevs has quit IRC
 182016-04-05T02:41:27  *** zooko has joined #bitcoin-core-dev
 192016-04-05T02:41:41  *** hsmiths2 is now known as hsmiths
 202016-04-05T02:42:03  *** hsmiths has joined #bitcoin-core-dev
 212016-04-05T02:42:18  <gmaxwell> sipa: jonasschnelli:  Here is the authentication protocol I was thinking of:
 222016-04-05T02:42:21  <gmaxwell> https://people.xiph.org/~greg/auth0.txt
 232016-04-05T02:43:35  <gmaxwell> And this is an extension to the former that allows for mutual autentication while keeping the client identity private: https://people.xiph.org/~greg/auth1.txt  This is useful because it would protect against a shared server tracking clients (e.g. observing what they broadcast), but still allow the client to authenticate for elevated service.
 242016-04-05T02:45:41  *** jtimon has quit IRC
 252016-04-05T02:48:17  <gmaxwell> An example application where this would be important, is if clients paid a server for a priority access account. (more bandwidth, protection against DOS limits).. it would be unfortunate if the existance of such a service compromised the users privacy by giving them a persistant identity that the server could track them with.  I don't think it's something we'd implement right away, but it shows
 262016-04-05T02:48:23  <gmaxwell> how our channel authentication could be extended.
 272016-04-05T02:48:31  *** xiangfu has joined #bitcoin-core-dev
 282016-04-05T03:03:58  *** zooko has quit IRC
 292016-04-05T03:05:01  *** Alopex has quit IRC
 302016-04-05T03:06:07  *** Alopex has joined #bitcoin-core-dev
 312016-04-05T03:19:32  *** frankenmint has joined #bitcoin-core-dev
 322016-04-05T03:45:16  *** Chris_Stewart_5 has quit IRC
 332016-04-05T05:01:01  *** Alopex has quit IRC
 342016-04-05T05:02:06  *** Alopex has joined #bitcoin-core-dev
 352016-04-05T05:02:33  *** paveljanik has quit IRC
 362016-04-05T05:17:01  *** Alopex has quit IRC
 372016-04-05T05:18:06  *** Alopex has joined #bitcoin-core-dev
 382016-04-05T05:53:02  *** Ylbam has joined #bitcoin-core-dev
 392016-04-05T06:06:11  *** murch has joined #bitcoin-core-dev
 402016-04-05T06:09:01  *** Alopex has quit IRC
 412016-04-05T06:10:06  *** Alopex has joined #bitcoin-core-dev
 422016-04-05T06:19:36  *** fengling has quit IRC
 432016-04-05T06:20:48  *** paveljanik has joined #bitcoin-core-dev
 442016-04-05T06:28:00  *** mesmer_ has joined #bitcoin-core-dev
 452016-04-05T06:31:04  *** mesmer has quit IRC
 462016-04-05T06:33:54  *** fengling has joined #bitcoin-core-dev
 472016-04-05T06:55:01  *** Alopex has quit IRC
 482016-04-05T06:56:06  *** Alopex has joined #bitcoin-core-dev
 492016-04-05T07:01:23  *** frankenmint has quit IRC
 502016-04-05T07:14:07  <jonasschnelli> gmaxwell: Nice! Will try to fully understand it now...
 512016-04-05T07:22:11  *** chris2000 has joined #bitcoin-core-dev
 522016-04-05T07:36:34  *** frankenmint has joined #bitcoin-core-dev
 532016-04-05T07:44:53  <GitHub111> [bitcoin] paveljanik opened pull request #7810: Refactor AlertNotifyOnce out of UpdateTip (master...20160405_AlertNotifyOnce) https://github.com/bitcoin/bitcoin/pull/7810
 542016-04-05T07:55:01  *** Alopex has quit IRC
 552016-04-05T07:56:07  *** Alopex has joined #bitcoin-core-dev
 562016-04-05T07:59:19  *** lejitz has joined #bitcoin-core-dev
 572016-04-05T08:02:37  *** lejitz has quit IRC
 582016-04-05T08:09:04  *** xiangfu has quit IRC
 592016-04-05T08:11:03  *** paveljanik has quit IRC
 602016-04-05T08:11:15  *** xiangfu has joined #bitcoin-core-dev
 612016-04-05T08:29:02  <jonasschnelli> This looks ready: https://github.com/bitcoin/bitcoin/pull/7753
 622016-04-05T08:40:10  *** abritoid has joined #bitcoin-core-dev
 632016-04-05T08:46:45  *** Guyver2 has joined #bitcoin-core-dev
 642016-04-05T08:50:24  *** MarcoFalke has joined #bitcoin-core-dev
 652016-04-05T08:56:22  <StringerBell> ok it's killing me. How does that github bot work?
 662016-04-05T08:58:22  <jonasschnelli> StringerBell: Its publishing created/closed/merged PRs issues?
 672016-04-05T08:58:53  * jonasschnelli thinks GitHub is extraslow today.
 682016-04-05T08:59:09  <StringerBell> I mean it is a user but it's not connected to the channel
 692016-04-05T08:59:45  <StringerBell> Don't mean to get off topic but never seen that before.
 702016-04-05T08:59:46  <Luke-Jr> StringerBell: the channel is not +n which restricts sending to members
 712016-04-05T08:59:46  <sipa> StringerBell: be default you can send messages to a channel without being joined
 722016-04-05T08:59:59  <StringerBell> oh lol ok
 732016-04-05T09:00:13  <Luke-Jr> IRC isn't designed to be "rooms" as much as it is pub/sub IM ;)
 742016-04-05T09:00:47  <Luke-Jr> so JOIN = subscribe, and PRIVMSG = publish
 752016-04-05T09:00:58  <StringerBell> ah
 762016-04-05T09:05:12  <btcdrak> It can be set to authorise,  join, mag and leave but then it is a lot more messages
 772016-04-05T09:05:37  <btcdrak> It is a github commit hook
 782016-04-05T09:05:41  <Luke-Jr> not like anyone abuses the -n
 792016-04-05T09:38:42  <wumpus> yes the side is a tad slow
 802016-04-05T09:38:45  <wumpus> site*
 812016-04-05T09:38:58  *** lejitz has joined #bitcoin-core-dev
 822016-04-05T09:39:21  *** wallet42 has quit IRC
 832016-04-05T09:43:28  *** lejitz has quit IRC
 842016-04-05T09:49:04  *** AaronvanW has joined #bitcoin-core-dev
 852016-04-05T09:49:05  *** AaronvanW has quit IRC
 862016-04-05T09:49:05  *** AaronvanW has joined #bitcoin-core-dev
 872016-04-05T09:59:03  <GitHub37> [bitcoin] MarcoFalke opened pull request #7811: [0.12.2] qa Backports (0.12...Mf1604-qa012) https://github.com/bitcoin/bitcoin/pull/7811
 882016-04-05T10:09:42  *** murch has quit IRC
 892016-04-05T10:18:07  *** xiangfu has quit IRC
 902016-04-05T10:18:57  *** fengling has quit IRC
 912016-04-05T10:19:46  *** xiangfu has joined #bitcoin-core-dev
 922016-04-05T10:30:17  *** gevs has joined #bitcoin-core-dev
 932016-04-05T10:30:17  *** gevs has joined #bitcoin-core-dev
 942016-04-05T10:35:47  *** xabbix has quit IRC
 952016-04-05T10:36:15  *** xabbix has joined #bitcoin-core-dev
 962016-04-05T10:44:54  *** gevs has quit IRC
 972016-04-05T10:44:55  *** chris2000 has quit IRC
 982016-04-05T10:46:34  *** gevs has joined #bitcoin-core-dev
 992016-04-05T11:06:55  *** Luke-Jr has quit IRC
1002016-04-05T11:07:37  *** Luke-Jr has joined #bitcoin-core-dev
1012016-04-05T11:26:22  *** xiangfu has quit IRC
1022016-04-05T11:32:24  <btcdrak> Last week's meeting summary: https://bitcoincore.org/en/meetings/2016/03/31/
1032016-04-05T11:34:13  *** cryptapus_ has joined #bitcoin-core-dev
1042016-04-05T11:35:03  *** slackircbridge has joined #bitcoin-core-dev
1052016-04-05T11:37:59  *** cryptapus_ is now known as cryptapus
1062016-04-05T11:38:53  <btcdrak> wumpus: can you try an experiment for me please, by kicking slackircbridge
1072016-04-05T11:40:21  *** davec has quit IRC
1082016-04-05T11:40:54  *** davec has joined #bitcoin-core-dev
1092016-04-05T11:51:15  <sipa> hmm, when i regenerate the script_tests, i get lines like:
1102016-04-05T11:51:16  <sipa> [
1112016-04-05T11:51:18  <sipa> ...
1122016-04-05T11:51:21  <sipa>    ],
1132016-04-05T11:51:24  <sipa> instead of:
1142016-04-05T11:51:26  <sipa> [
1152016-04-05T11:51:27  <sipa> ...
1162016-04-05T11:51:29  <sipa> ],
1172016-04-05T11:51:36  <sipa> wumpus: you touched that code last
1182016-04-05T11:52:04  *** ChanServ sets mode: +o sipa
1192016-04-05T11:52:12  *** slackircbridge was kicked by sipa (btcdrak does not like you)
1202016-04-05T11:52:28  <sipa> btcdrak: done
1212016-04-05T11:52:36  *** ChanServ sets mode: -o sipa
1222016-04-05T11:52:50  <btcdrak> sipa thanks
1232016-04-05T11:57:08  *** slackircbridge has joined #bitcoin-core-dev
1242016-04-05T11:57:43  <btcdrak> sipa: thanks. one last time please boot him again.
1252016-04-05T11:58:46  *** slackircbridge has quit IRC
1262016-04-05T11:58:49  <jonasschnelli> ping sdaftuar
1272016-04-05T11:58:58  *** slackircbridge has joined #bitcoin-core-dev
1282016-04-05T11:59:05  <sipa> btcdrak: you've got op
1292016-04-05T11:59:41  <jonasschnelli> Or anyone else... check https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85  I think this is wrong.
1302016-04-05T11:59:46  <jonasschnelli> (Already merged)
1312016-04-05T12:00:09  <jonasschnelli> If a tx is not in the mempool and signal rbf, we can't be sure if it's rbfable.
1322016-04-05T12:00:16  <jonasschnelli> *signals
1332016-04-05T12:01:04  <sipa> why not?
1342016-04-05T12:03:54  <jonasschnelli> sipa: ancestors?
1352016-04-05T12:04:08  <jonasschnelli> sipa: I think this check is more appropriate: https://github.com/bitcoin/bitcoin/pull/7222/files#diff-d0eca4d0f80c5b045d2aa64609e811ecR28?
1362016-04-05T12:05:27  <jonasschnelli> Because a unconfirmed input could signal RBF?
1372016-04-05T12:06:07  *** ChanServ sets mode: +o btcdrak
1382016-04-05T12:06:21  *** slackircbridge was kicked by btcdrak (testing rejoin)
1392016-04-05T12:07:41  *** slackircbridge has joined #bitcoin-core-dev
1402016-04-05T12:08:18  *** slackircbridge was kicked by btcdrak (remember false != true)
1412016-04-05T12:08:19  *** slackircbridge has joined #bitcoin-core-dev
1422016-04-05T12:10:04  *** ChanServ sets mode: -o btcdrak
1432016-04-05T12:17:07  *** randy-waterhouse has left #bitcoin-core-dev
1442016-04-05T12:23:56  *** SteveTaylor has joined #bitcoin-core-dev
1452016-04-05T12:24:39  *** davec has quit IRC
1462016-04-05T12:25:03  *** davec has joined #bitcoin-core-dev
1472016-04-05T12:27:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1482016-04-05T12:29:06  <sipa> jonasschnelli: i think it's correct
1492016-04-05T12:29:16  <jonasschnelli> sipa: Yes. Me2!
1502016-04-05T12:29:22  <sipa> if it signals rbf by itself, it should be yes; if it doesn't, it's unknown
1512016-04-05T12:29:35  <sipa> and IsRBFOptIn can't be called for things not in the mempool
1522016-04-05T12:29:44  <jonasschnelli> I overlooked https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85
1532016-04-05T12:29:49  <jonasschnelli> if (!mempool.exists(hash)) {
1542016-04-05T12:30:18  <jonasschnelli> The "unknown" https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR89 is not 100% true.
1552016-04-05T12:30:29  <jonasschnelli> But "unknown" from the local peer perspective is right.
1562016-04-05T12:30:54  <sipa> what other perspective is there?
1572016-04-05T12:31:19  <jonasschnelli> We could miss a ancestor/input in the mempool that has a final nSequence and therefore the transaction would _not_ be replaceable.
1582016-04-05T12:33:27  <jonasschnelli> But however, I think its correct. Yes.
1592016-04-05T12:33:52  <jonasschnelli> But doing a tiny refactor (before I extend it to the GUI)
1602016-04-05T12:34:03  *** Chris_Stewart_5 has quit IRC
1612016-04-05T12:40:17  <sipa> jonasschnelli, wumpus: i don't understand the univalue json pretty printer
1622016-04-05T12:40:28  <jonasschnelli> write(2)
1632016-04-05T12:40:41  <jonasschnelli> sipa: what is unclear?
1642016-04-05T12:41:13  <sipa> it puts spaces between comma's and the end of a line
1652016-04-05T12:41:33  <jonasschnelli> sipa: yes. You need to ask jeff. :) Or fix it.
1662016-04-05T12:41:57  <jonasschnelli> sipa: Are you referring to your script_tests issue above?
1672016-04-05T12:42:06  <sipa> yes
1682016-04-05T12:43:18  <GitHub178> [bitcoin] jonasschnelli opened pull request #7812: Tiny refactor of `IsRBFOptIn`, avoid exception (master...2016/04/rbf_refact) https://github.com/bitcoin/bitcoin/pull/7812
1692016-04-05T12:44:16  <jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L79
1702016-04-05T12:44:44  <sdaftuar> jonasschnelli: pong.  happy to review any refactors of that code...
1712016-04-05T12:44:47  *** dermoth has joined #bitcoin-core-dev
1722016-04-05T12:45:18  <jonasschnelli> sdaftuar: Thanks. Not sure if it makes sense. I think the code is fine. Its just the exception that kinda disturbs me.
1732016-04-05T12:45:21  <jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L100
1742016-04-05T12:45:50  <jonasschnelli> sipa: it misses a newline before L100
1752016-04-05T12:46:03  <jonasschnelli> no wait...
1762016-04-05T12:46:15  <sipa> jonasschnelli: it's complicated; i'm writing a workaround for now
1772016-04-05T12:46:18  <jonasschnelli> L98-99 is wrong.
1782016-04-05T12:46:23  <jonasschnelli> I'll fix it.
1792016-04-05T12:47:06  <sipa> please add tests for the pretty printer, i think it's very easy to break
1802016-04-05T12:47:46  <jonasschnelli> sipa: yes.
1812016-04-05T12:47:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822016-04-05T12:49:40  *** cryptapus has quit IRC
1832016-04-05T12:51:05  *** jannes has quit IRC
1842016-04-05T12:53:59  *** jannes has joined #bitcoin-core-dev
1852016-04-05T12:57:02  <GitHub91> [bitcoin] MarcoFalke opened pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813
1862016-04-05T12:58:07  *** jtimon has joined #bitcoin-core-dev
1872016-04-05T13:00:07  <GitHub153> [bitcoin] MarcoFalke opened pull request #7814: [qa] Switch to py3 (master...Mf1604-qaPy3) https://github.com/bitcoin/bitcoin/pull/7814
1882016-04-05T13:08:34  <jonasschnelli> sipa: script_tests.cpp uses "write(1,4)" (which means 1 whitespace indent, start at level 4).
1892016-04-05T13:08:49  <jonasschnelli> But there is a bug at the opening "[" (not the closing)
1902016-04-05T13:09:18  *** Chris_Stewart_5 has quit IRC
1912016-04-05T13:13:54  <sipa> jonasschnelli: yeah, changing it to write(4)
1922016-04-05T13:21:47  *** mesmer_ has quit IRC
1932016-04-05T13:21:47  *** cheese_ has quit IRC
1942016-04-05T13:21:47  *** cfields has quit IRC
1952016-04-05T13:21:48  *** Guest27562 has quit IRC
1962016-04-05T13:21:48  *** Alopex has quit IRC
1972016-04-05T13:21:48  *** Arnavion has quit IRC
1982016-04-05T13:21:48  *** Madars has quit IRC
1992016-04-05T13:21:48  *** Squidicuz has quit IRC
2002016-04-05T13:21:48  *** harding has quit IRC
2012016-04-05T13:21:48  *** wumpus has quit IRC
2022016-04-05T13:21:48  *** BlueMatt has quit IRC
2032016-04-05T13:21:48  *** fkhan_ has quit IRC
2042016-04-05T13:21:48  *** windsok has quit IRC
2052016-04-05T13:21:48  *** cjcj has quit IRC
2062016-04-05T13:21:48  *** gijensen has quit IRC
2072016-04-05T13:21:48  *** Eliel_ has quit IRC
2082016-04-05T13:21:49  *** davec has quit IRC
2092016-04-05T13:21:49  *** cryptapus_afk has quit IRC
2102016-04-05T13:21:49  *** dgenr8 has quit IRC
2112016-04-05T13:21:49  *** ghtdak has quit IRC
2122016-04-05T13:21:49  *** baldur has quit IRC
2132016-04-05T13:21:49  *** rubensayshi has quit IRC
2142016-04-05T13:21:49  *** ebfull has quit IRC
2152016-04-05T13:21:50  *** zxzzt has quit IRC
2162016-04-05T13:21:50  *** nanotube has quit IRC
2172016-04-05T13:21:50  *** adam3us has quit IRC
2182016-04-05T13:21:50  *** frankenmint has quit IRC
2192016-04-05T13:21:50  *** phantomcircuit has quit IRC
2202016-04-05T13:21:50  *** neha has quit IRC
2212016-04-05T13:21:50  *** zmanian__ has quit IRC
2222016-04-05T13:21:50  *** eragmus has quit IRC
2232016-04-05T13:21:50  *** binns has quit IRC
2242016-04-05T13:21:50  *** Amnez777 has quit IRC
2252016-04-05T13:21:50  *** heath has quit IRC
2262016-04-05T13:21:50  *** CyrusV has quit IRC
2272016-04-05T13:21:50  *** jl2012 has quit IRC
2282016-04-05T13:21:51  *** helo has quit IRC
2292016-04-05T13:21:51  *** jonasschnelli has quit IRC
2302016-04-05T13:21:51  *** slackircbridge has quit IRC
2312016-04-05T13:21:51  *** Luke-Jr has quit IRC
2322016-04-05T13:21:51  *** Ylbam has quit IRC
2332016-04-05T13:21:51  *** [b__b] has quit IRC
2342016-04-05T13:21:51  *** AtashiCon has quit IRC
2352016-04-05T13:21:51  *** Thireus has quit IRC
2362016-04-05T13:21:51  *** gribble has quit IRC
2372016-04-05T13:21:51  *** ryan-c has quit IRC
2382016-04-05T13:21:52  *** sturles has quit IRC
2392016-04-05T13:21:52  *** teward has quit IRC
2402016-04-05T13:21:52  *** petertodd has quit IRC
2412016-04-05T13:21:52  *** Expanse has quit IRC
2422016-04-05T13:21:52  *** StringerBell has quit IRC
2432016-04-05T13:21:53  *** PaulCapestany has quit IRC
2442016-04-05T13:21:53  *** arubi has quit IRC
2452016-04-05T13:21:53  *** da2ce7_mobile has quit IRC
2462016-04-05T13:21:53  *** sanada has quit IRC
2472016-04-05T13:21:53  *** jyap has quit IRC
2482016-04-05T13:21:53  *** go1111111 has quit IRC
2492016-04-05T13:21:53  *** warren has quit IRC
2502016-04-05T13:21:53  *** OxADADA has quit IRC
2512016-04-05T13:21:53  *** [Author] has quit IRC
2522016-04-05T13:21:53  *** gevs has quit IRC
2532016-04-05T13:21:53  *** justanotheruser has quit IRC
2542016-04-05T13:21:53  *** afk11 has quit IRC
2552016-04-05T13:21:53  *** amiller has quit IRC
2562016-04-05T13:21:53  *** aureianimus has quit IRC
2572016-04-05T13:21:53  *** kanzure has quit IRC
2582016-04-05T13:21:53  *** nkuttler has quit IRC
2592016-04-05T13:21:54  *** roasbeef has quit IRC
2602016-04-05T13:21:54  *** dermoth has quit IRC
2612016-04-05T13:21:54  *** Guyver2 has quit IRC
2622016-04-05T13:21:54  *** cguida has quit IRC
2632016-04-05T13:21:54  *** goregrind has quit IRC
2642016-04-05T13:21:54  *** jouke has quit IRC
2652016-04-05T13:21:54  *** mr_burdell has quit IRC
2662016-04-05T13:21:54  *** berndj has quit IRC
2672016-04-05T13:21:54  *** zibbo has quit IRC
2682016-04-05T13:21:54  *** morcos has quit IRC
2692016-04-05T13:21:54  *** d9b4bef9 has quit IRC
2702016-04-05T13:21:54  *** sdaftuar has quit IRC
2712016-04-05T13:21:55  *** haakonn has quit IRC
2722016-04-05T13:21:55  *** jtimon has quit IRC
2732016-04-05T13:21:55  *** xabbix has quit IRC
2742016-04-05T13:21:55  *** MarcoFalke has quit IRC
2752016-04-05T13:21:55  *** moli has quit IRC
2762016-04-05T13:21:55  *** da2ce7 has quit IRC
2772016-04-05T13:21:55  *** achow101 has quit IRC
2782016-04-05T13:21:55  *** mkarrer has quit IRC
2792016-04-05T13:21:55  *** fredrin has quit IRC
2802016-04-05T13:21:55  *** gmaxwell has quit IRC
2812016-04-05T13:21:55  *** Anduck has quit IRC
2822016-04-05T13:21:55  *** lclc has quit IRC
2832016-04-05T13:21:55  *** lecusemble has quit IRC
2842016-04-05T13:21:55  *** instagibbs has quit IRC
2852016-04-05T13:21:55  *** crescendo has quit IRC
2862016-04-05T13:21:55  *** murr4y has quit IRC
2872016-04-05T13:21:56  *** droark has quit IRC
2882016-04-05T13:21:56  *** Evel-Knievel has quit IRC
2892016-04-05T13:21:56  *** btcdrak has quit IRC
2902016-04-05T13:21:56  *** CodeShark has quit IRC
2912016-04-05T13:21:56  *** wangchun has quit IRC
2922016-04-05T13:21:56  *** tucenaber has quit IRC
2932016-04-05T13:21:56  *** ibrightly has quit IRC
2942016-04-05T13:21:56  *** lesderid has quit IRC
2952016-04-05T13:21:56  *** limpkin has quit IRC
2962016-04-05T13:21:56  *** AaronvanW has quit IRC
2972016-04-05T13:21:57  *** Cory has quit IRC
2982016-04-05T13:21:57  *** devrandom has quit IRC
2992016-04-05T13:21:57  *** pigeons has quit IRC
3002016-04-05T13:21:57  *** mm_1 has quit IRC
3012016-04-05T13:21:57  *** nickler has quit IRC
3022016-04-05T13:21:57  *** bad_duck has quit IRC
3032016-04-05T13:21:57  *** midnightmagic has quit IRC
3042016-04-05T13:21:57  *** aj has quit IRC
3052016-04-05T13:21:57  *** so has quit IRC
3062016-04-05T13:21:57  *** jannes has quit IRC
3072016-04-05T13:21:57  *** abritoid has quit IRC
3082016-04-05T13:21:58  *** jarret has quit IRC
3092016-04-05T13:21:58  *** JackH has quit IRC
3102016-04-05T13:21:58  *** BCBot has quit IRC
3112016-04-05T13:21:58  *** Bootvis has quit IRC
3122016-04-05T13:21:58  *** SteveTaylor has quit IRC
3132016-04-05T13:21:58  *** hsmiths has quit IRC
3142016-04-05T13:21:58  *** PRab has quit IRC
3152016-04-05T13:21:58  *** hybridsole has quit IRC
3162016-04-05T13:21:58  *** e0_ has quit IRC
3172016-04-05T13:21:58  *** kinlo has quit IRC
3182016-04-05T13:21:58  *** Lightsword has quit IRC
3192016-04-05T13:21:59  *** isis has quit IRC
3202016-04-05T13:24:34  *** mesmer_ has joined #bitcoin-core-dev
3212016-04-05T13:24:34  *** cfields_ has joined #bitcoin-core-dev
3222016-04-05T13:24:34  *** gavinandresen has joined #bitcoin-core-dev
3232016-04-05T13:24:34  *** Cheeseo has joined #bitcoin-core-dev
3242016-04-05T13:24:34  *** jtimon has joined #bitcoin-core-dev
3252016-04-05T13:24:34  *** jannes has joined #bitcoin-core-dev
3262016-04-05T13:24:34  *** dermoth has joined #bitcoin-core-dev
3272016-04-05T13:24:34  *** davec has joined #bitcoin-core-dev
3282016-04-05T13:24:34  *** SteveTaylor has joined #bitcoin-core-dev
3292016-04-05T13:24:34  *** slackircbridge has joined #bitcoin-core-dev
3302016-04-05T13:24:34  *** Luke-Jr has joined #bitcoin-core-dev
3312016-04-05T13:24:34  *** gevs has joined #bitcoin-core-dev
3322016-04-05T13:24:34  *** xabbix has joined #bitcoin-core-dev
3332016-04-05T13:24:34  *** AaronvanW has joined #bitcoin-core-dev
3342016-04-05T13:24:34  *** MarcoFalke has joined #bitcoin-core-dev
3352016-04-05T13:24:34  *** Guyver2 has joined #bitcoin-core-dev
3362016-04-05T13:24:34  *** abritoid has joined #bitcoin-core-dev
3372016-04-05T13:24:34  *** Alopex has joined #bitcoin-core-dev
3382016-04-05T13:24:34  *** frankenmint has joined #bitcoin-core-dev
3392016-04-05T13:24:34  *** Ylbam has joined #bitcoin-core-dev
3402016-04-05T13:24:34  *** hsmiths has joined #bitcoin-core-dev
3412016-04-05T13:24:34  *** [b__b] has joined #bitcoin-core-dev
3422016-04-05T13:24:34  *** cguida has joined #bitcoin-core-dev
3432016-04-05T13:24:34  *** moli has joined #bitcoin-core-dev
3442016-04-05T13:24:34  *** cryptapus_afk has joined #bitcoin-core-dev
3452016-04-05T13:24:34  *** da2ce7 has joined #bitcoin-core-dev
3462016-04-05T13:24:34  *** droark has joined #bitcoin-core-dev
3472016-04-05T13:24:34  *** AtashiCon has joined #bitcoin-core-dev
3482016-04-05T13:24:34  *** Anduck has joined #bitcoin-core-dev
3492016-04-05T13:24:34  *** Thireus has joined #bitcoin-core-dev
3502016-04-05T13:24:34  *** Evel-Knievel has joined #bitcoin-core-dev
3512016-04-05T13:24:34  *** justanotheruser has joined #bitcoin-core-dev
3522016-04-05T13:24:34  *** dgenr8 has joined #bitcoin-core-dev
3532016-04-05T13:24:34  *** sanada has joined #bitcoin-core-dev
3542016-04-05T13:24:34  *** achow101 has joined #bitcoin-core-dev
3552016-04-05T13:24:34  *** PRab has joined #bitcoin-core-dev
3562016-04-05T13:24:34  *** StringerBell has joined #bitcoin-core-dev
3572016-04-05T13:24:34  *** gribble has joined #bitcoin-core-dev
3582016-04-05T13:24:34  *** phantomcircuit has joined #bitcoin-core-dev
3592016-04-05T13:24:34  *** btcdrak has joined #bitcoin-core-dev
3602016-04-05T13:24:34  *** PaulCapestany has joined #bitcoin-core-dev
3612016-04-05T13:24:34  *** Arnavion has joined #bitcoin-core-dev
3622016-04-05T13:24:34  *** mkarrer has joined #bitcoin-core-dev
3632016-04-05T13:24:34  *** jarret has joined #bitcoin-core-dev
3642016-04-05T13:24:34  *** JackH has joined #bitcoin-core-dev
3652016-04-05T13:24:34  *** BCBot has joined #bitcoin-core-dev
3662016-04-05T13:24:34  *** Cory has joined #bitcoin-core-dev
3672016-04-05T13:24:34  *** Madars has joined #bitcoin-core-dev
3682016-04-05T13:24:34  *** neha has joined #bitcoin-core-dev
3692016-04-05T13:24:34  *** Squidicuz has joined #bitcoin-core-dev
3702016-04-05T13:24:34  *** arubi has joined #bitcoin-core-dev
3712016-04-05T13:24:34  *** ryan-c has joined #bitcoin-core-dev
3722016-04-05T13:24:34  *** goregrind has joined #bitcoin-core-dev
3732016-04-05T13:24:34  *** fredrin has joined #bitcoin-core-dev
3742016-04-05T13:24:34  *** ghtdak has joined #bitcoin-core-dev
3752016-04-05T13:24:34  *** Bootvis has joined #bitcoin-core-dev
3762016-04-05T13:24:34  *** gijensen has joined #bitcoin-core-dev
3772016-04-05T13:24:34  *** afk11 has joined #bitcoin-core-dev
3782016-04-05T13:24:34  *** baldur has joined #bitcoin-core-dev
3792016-04-05T13:24:34  *** da2ce7_mobile has joined #bitcoin-core-dev
3802016-04-05T13:24:34  *** devrandom has joined #bitcoin-core-dev
3812016-04-05T13:24:34  *** CodeShark has joined #bitcoin-core-dev
3822016-04-05T13:24:34  *** zmanian__ has joined #bitcoin-core-dev
3832016-04-05T13:24:34  *** cjcj has joined #bitcoin-core-dev
3842016-04-05T13:24:34  *** wangchun has joined #bitcoin-core-dev
3852016-04-05T13:24:34  *** harding has joined #bitcoin-core-dev
3862016-04-05T13:24:34  *** eragmus has joined #bitcoin-core-dev
3872016-04-05T13:24:34  *** binns has joined #bitcoin-core-dev
3882016-04-05T13:24:34  *** amiller has joined #bitcoin-core-dev
3892016-04-05T13:24:34  *** teward has joined #bitcoin-core-dev
3902016-04-05T13:24:34  *** Eliel_ has joined #bitcoin-core-dev
3912016-04-05T13:24:34  *** sturles has joined #bitcoin-core-dev
3922016-04-05T13:24:34  *** Amnez777 has joined #bitcoin-core-dev
3932016-04-05T13:24:34  *** rubensayshi has joined #bitcoin-core-dev
3942016-04-05T13:24:34  *** ebfull has joined #bitcoin-core-dev
3952016-04-05T13:24:34  *** jouke has joined #bitcoin-core-dev
3962016-04-05T13:24:34  *** wumpus has joined #bitcoin-core-dev
3972016-04-05T13:24:34  *** BlueMatt has joined #bitcoin-core-dev
3982016-04-05T13:24:34  *** pigeons has joined #bitcoin-core-dev
3992016-04-05T13:24:34  *** tucenaber has joined #bitcoin-core-dev
4002016-04-05T13:24:34  *** heath has joined #bitcoin-core-dev
4012016-04-05T13:24:34  *** aureianimus has joined #bitcoin-core-dev
4022016-04-05T13:24:34  *** kanzure has joined #bitcoin-core-dev
4032016-04-05T13:24:34  *** fkhan_ has joined #bitcoin-core-dev
4042016-04-05T13:24:34  *** hybridsole has joined #bitcoin-core-dev
4052016-04-05T13:24:34  *** jyap has joined #bitcoin-core-dev
4062016-04-05T13:24:34  *** ibrightly has joined #bitcoin-core-dev
4072016-04-05T13:24:34  *** windsok has joined #bitcoin-core-dev
4082016-04-05T13:24:34  *** lesderid has joined #bitcoin-core-dev
4092016-04-05T13:24:34  *** CyrusV has joined #bitcoin-core-dev
4102016-04-05T13:24:34  *** gmaxwell has joined #bitcoin-core-dev
4112016-04-05T13:24:34  *** go1111111 has joined #bitcoin-core-dev
4122016-04-05T13:24:34  *** [Author] has joined #bitcoin-core-dev
4132016-04-05T13:24:34  *** lclc has joined #bitcoin-core-dev
4142016-04-05T13:24:34  *** petertodd has joined #bitcoin-core-dev
4152016-04-05T13:24:34  *** lecusemble has joined #bitcoin-core-dev
4162016-04-05T13:24:34  *** warren has joined #bitcoin-core-dev
4172016-04-05T13:24:34  *** OxADADA has joined #bitcoin-core-dev
4182016-04-05T13:24:34  *** jl2012 has joined #bitcoin-core-dev
4192016-04-05T13:24:34  *** instagibbs has joined #bitcoin-core-dev
4202016-04-05T13:24:34  *** mr_burdell has joined #bitcoin-core-dev
4212016-04-05T13:24:34  *** crescendo has joined #bitcoin-core-dev
4222016-04-05T13:24:34  *** limpkin has joined #bitcoin-core-dev
4232016-04-05T13:24:34  *** Expanse has joined #bitcoin-core-dev
4242016-04-05T13:24:34  *** berndj has joined #bitcoin-core-dev
4252016-04-05T13:24:34  *** e0_ has joined #bitcoin-core-dev
4262016-04-05T13:24:34  *** mm_1 has joined #bitcoin-core-dev
4272016-04-05T13:24:34  *** nkuttler has joined #bitcoin-core-dev
4282016-04-05T13:24:34  *** murr4y has joined #bitcoin-core-dev
4292016-04-05T13:24:34  *** zibbo has joined #bitcoin-core-dev
4302016-04-05T13:24:34  *** kinlo has joined #bitcoin-core-dev
4312016-04-05T13:24:34  *** so has joined #bitcoin-core-dev
4322016-04-05T13:24:34  *** helo has joined #bitcoin-core-dev
4332016-04-05T13:24:34  *** zxzzt has joined #bitcoin-core-dev
4342016-04-05T13:24:34  *** nanotube has joined #bitcoin-core-dev
4352016-04-05T13:24:34  *** nickler has joined #bitcoin-core-dev
4362016-04-05T13:24:34  *** roasbeef has joined #bitcoin-core-dev
4372016-04-05T13:24:34  *** adam3us has joined #bitcoin-core-dev
4382016-04-05T13:24:34  *** jonasschnelli has joined #bitcoin-core-dev
4392016-04-05T13:24:34  *** morcos has joined #bitcoin-core-dev
4402016-04-05T13:24:34  *** bad_duck has joined #bitcoin-core-dev
4412016-04-05T13:24:34  *** d9b4bef9 has joined #bitcoin-core-dev
4422016-04-05T13:24:34  *** midnightmagic has joined #bitcoin-core-dev
4432016-04-05T13:24:34  *** Lightsword has joined #bitcoin-core-dev
4442016-04-05T13:24:34  *** sdaftuar has joined #bitcoin-core-dev
4452016-04-05T13:24:34  *** aj has joined #bitcoin-core-dev
4462016-04-05T13:24:34  *** isis has joined #bitcoin-core-dev
4472016-04-05T13:24:34  *** haakonn has joined #bitcoin-core-dev
4482016-04-05T13:24:35  <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667 should be write(1)
4492016-04-05T13:24:35  *** michagogo has quit IRC
4502016-04-05T13:25:58  *** cryptapus has joined #bitcoin-core-dev
4512016-04-05T13:26:26  <wumpus> sipa: jonasschnelli: yes I had some problems generating the tests as well last time
4522016-04-05T13:26:37  <jl2012> sorry for OT.  OP_VERIF is invalid even when occuring in an unexecuted OP_IF branch. Where this rule is defined in the code?
4532016-04-05T13:27:01  <wumpus> I added the pretty printing because it ended up all on one line
4542016-04-05T13:27:30  <wumpus> I don't think this was tested after introducing univalue
4552016-04-05T13:27:42  <jonasschnelli> wumpus: the issue is here: https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667
4562016-04-05T13:28:02  <jonasschnelli> you add a root level on level 4
4572016-04-05T13:28:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4582016-04-05T13:28:04  *** michagogo has joined #bitcoin-core-dev
4592016-04-05T13:28:08  <wumpus> ok
4602016-04-05T13:28:35  <jonasschnelli> I guess if i change this i need to update all static test data.
4612016-04-05T13:28:38  <wumpus> apparently I didn't really know what pretty print arguments to use
4622016-04-05T13:28:49  <jonasschnelli> heh. Yes. I was also not sure.
4632016-04-05T13:28:51  <wumpus> no, I don't think you need to do that
4642016-04-05T13:29:17  <wumpus> I probably fixed the excessive indent by hand last time
4652016-04-05T13:29:52  <sipa> wumpus: i'm making some changes, and fixing it
4662016-04-05T13:30:03  <jonasschnelli> sipa: thanks!
4672016-04-05T13:30:06  <wumpus> this was less work than manually formatting the json from everything on one line
4682016-04-05T13:30:12  <wumpus> but stil not ideal no
4692016-04-05T13:30:15  <wumpus> sipa: ok great!
4702016-04-05T13:30:22  * jonasschnelli is heading back to GUI RBF
4712016-04-05T13:30:48  <sipa> wumpus: any objections to merging the valid and invalid script tests into one file?
4722016-04-05T13:31:13  <sipa> it's annoying for generating, and makes the tests less clear
4732016-04-05T13:31:15  <wumpus> sipa: I haven't; though you could consider it an interface change, as it's used by other projects
4742016-04-05T13:31:35  <jonasschnelli> sipa: I think you should use write(1) (1 whitespace ident) and only use write(1, X) if you want to insert a sublevel at level x
4752016-04-05T13:31:40  <wumpus> and it makes it harder to backport/forward-port tests
4762016-04-05T13:31:42  <wumpus> so I'm not sure
4772016-04-05T13:31:48  <wumpus> I did consider the same at some point
4782016-04-05T13:32:10  <sipa> wumpus: well, i'm working on segwit tests, and i have no intention of manually writing everything for both master and backports
4792016-04-05T13:32:24  <sipa> so that would also mean backporting that merging
4802016-04-05T13:32:28  <btcdrak> wumpus: no thanks!
4812016-04-05T13:32:40  <wumpus> okay
4822016-04-05T13:32:50  <btcdrak> kinlo: yes, it's only one way though, so you can read on the Bitcoin Core Slack
4832016-04-05T13:33:43  <kinlo> as long as this is the only official channel and we don't actually use slack it's all ok
4842016-04-05T13:33:58  <sipa> wumpus: and for segwit, an interface change is inevitable, as we'll need to add a witness field
4852016-04-05T13:34:05  <wumpus> sipa: I agree
4862016-04-05T13:34:13  <wumpus> sipa: that's a good excuse, go ahead :)
4872016-04-05T13:35:15  <wumpus> kinlo: I'm not sure how happy I really am about it. I mean, in principe everything here is public, but on the other hand non-technical people will put everything under a magnifying glass and are bound to misinterpret things
4882016-04-05T13:35:23  <btcdrak> wumpus: no thanks!
4892016-04-05T13:36:48  <wumpus> this happened before a while ago though i don't remember the specific instance, oh yeah some commit that bumped the version to 0.12.1 on the 0.12 branch was misinterpreted as '0.12.1 tagged!'
4902016-04-05T13:38:46  *** cryptapus__ has joined #bitcoin-core-dev
4912016-04-05T13:38:46  *** cryptapus__ has joined #bitcoin-core-dev
4922016-04-05T13:40:29  *** cryptapus has quit IRC
4932016-04-05T13:40:30  <GitHub15> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9149688f87c...214ec0b5e8b2
4942016-04-05T13:40:30  <GitHub15> bitcoin/master 3373c43 Adam Brown: [doc] Update port in tor.md...
4952016-04-05T13:40:31  <GitHub15> bitcoin/master 214ec0b Wladimir J. van der Laan: Merge #7813: [doc] Update port in tor.md...
4962016-04-05T13:40:39  *** cryptapus__ is now known as cryptapus
4972016-04-05T13:40:40  <GitHub21> [bitcoin] laanwj closed pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813
4982016-04-05T13:41:55  <GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/214ec0b5e8b2...55db5f07b1c4
4992016-04-05T13:41:56  <GitHub48> bitcoin/master 10d3ae1 Wladimir J. van der Laan: devtools: Auto-set branch to merge to in github-merge...
5002016-04-05T13:41:56  <GitHub48> bitcoin/master 55db5f0 Wladimir J. van der Laan: Merge #7781: devtools: Auto-set branch to merge to in github-merge...
5012016-04-05T13:42:00  <GitHub91> [bitcoin] laanwj closed pull request #7781: devtools: Auto-set branch to merge to in github-merge (master...2016_04_github_merge_autobranch) https://github.com/bitcoin/bitcoin/pull/7781
5022016-04-05T13:43:18  *** frankenmint has quit IRC
5032016-04-05T13:45:07  <GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55db5f07b1c4...3cc0fb3a23e5
5042016-04-05T13:45:07  <GitHub129> bitcoin/master f063863 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release...
5052016-04-05T13:45:08  <GitHub129> bitcoin/master 3cc0fb3 Wladimir J. van der Laan: Merge #7776: build: Remove unnecessary executables from gitian release...
5062016-04-05T13:45:14  <GitHub28> [bitcoin] laanwj closed pull request #7776: build: Remove unnecessary executables from gitian release (master...2016_03_gitian_release_cleanup) https://github.com/bitcoin/bitcoin/pull/7776
5072016-04-05T13:46:08  <GitHub41> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/a784675a329d6206af125d997381221dd1e99d11
5082016-04-05T13:46:09  <GitHub41> bitcoin/0.12 a784675 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release...
5092016-04-05T13:47:04  *** crescendo has quit IRC
5102016-04-05T13:48:16  *** crescendo has joined #bitcoin-core-dev
5112016-04-05T13:51:09  *** cryptapus has quit IRC
5122016-04-05T13:56:16  <jl2012> re OP_VERIF I think I find the answer at https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L295
5132016-04-05T13:57:44  <GitHub158> [bitcoin] jonasschnelli opened pull request #7816: [Wallet] slighly refactor GetOldestKeyPoolTime() (master...2016/04/wallet_oldest_key) https://github.com/bitcoin/bitcoin/pull/7816
5142016-04-05T14:08:09  <btcdrak> wumpus: kinlo: the slackbridge has been in operation for a few months already
5152016-04-05T14:09:08  <btcdrak> I was just setting the rejoin flag
5162016-04-05T14:09:40  <GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cc0fb3a23e5...916b15a87a1f
5172016-04-05T14:09:41  <GitHub91> bitcoin/master 92107d5 mruddy: RPC: add versionHex in getblock and getblockheader JSON results; expand data in getblockchaininfo bip9_softforks field.
5182016-04-05T14:09:41  <GitHub91> bitcoin/master 916b15a Wladimir J. van der Laan: Merge #7774: RPC: add versionHex in getblock and getblockheader JSON results...
5192016-04-05T14:09:47  <GitHub102> [bitcoin] laanwj closed pull request #7774: RPC: add versionHex in getblock and getblockheader JSON results (master...hexver) https://github.com/bitcoin/bitcoin/pull/7774
5202016-04-05T14:13:59  <wumpus> btcdrak: okay
5212016-04-05T14:14:18  <GitHub49> [bitcoin] jonasschnelli opened pull request #7817: [Qt] attribute replaceable (RBF) transactions (master...2016/04/qt_rbf) https://github.com/bitcoin/bitcoin/pull/7817
5222016-04-05T14:16:14  <btcdrak> wumpus: do we need to do a hard coded seeds update for 0.12.1?
5232016-04-05T14:16:36  <wumpus> I only do that for major releases
5242016-04-05T14:16:59  <GitHub175> [bitcoin] sipa opened pull request #7818: Refactor script tests (master...refactorscriptests) https://github.com/bitcoin/bitcoin/pull/7818
5252016-04-05T14:17:40  <wumpus> should update the translation strings though
5262016-04-05T14:21:39  <GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/916b15a87a1f...e30a5b0aaaa9
5272016-04-05T14:21:39  <GitHub48> bitcoin/master 190c1e2 JeremyRand: Doc: change Precise to Trusty in gitian-building.md...
5282016-04-05T14:21:40  <GitHub48> bitcoin/master e30a5b0 Wladimir J. van der Laan: Merge #7791: Doc: change Precise to Trusty in gitian-building.md...
5292016-04-05T14:21:53  <GitHub42> [bitcoin] laanwj closed pull request #7791: Doc: change Precise to Trusty in gitian-building.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7791
5302016-04-05T15:06:29  <Chris_Stewart_5> I'm looking at this test case from script_invalid.json inside of bitcoin core, shouldn't this have a MINIMALDATA flag?
5312016-04-05T15:06:31  <Chris_Stewart_5> ["0x4c01","0x01 NOP", "P2SH,STRICTENC", "PUSHDATA1 with not enough bytes"]
5322016-04-05T15:12:47  *** Giszmo has joined #bitcoin-core-dev
5332016-04-05T15:15:30  <GitHub68> [bitcoin] jonasschnelli opened pull request #7819: [Qt] Simple opt-in-RBF checkbox (master...2016/04/qt_rbf_set) https://github.com/bitcoin/bitcoin/pull/7819
5342016-04-05T15:17:48  *** zooko has joined #bitcoin-core-dev
5352016-04-05T15:18:36  <sipa> Chris_Stewart_5: the test should fail even without minimaldata rule
5362016-04-05T15:19:26  <sipa> Chris_Stewart_5: as it's trying to push a 1-byte value which is past the end of scriptSig
5372016-04-05T15:23:27  *** abritoid has quit IRC
5382016-04-05T15:39:12  <GitHub31> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e30a5b0aaaa9...4dc1b3a29693
5392016-04-05T15:39:12  <GitHub31> bitcoin/master 0087f26 Pavel Janík: Use relative paths instead of absolute paths
5402016-04-05T15:39:13  <GitHub31> bitcoin/master 4dc1b3a Wladimir J. van der Laan: Merge #7788: Use relative paths instead of absolute paths in protoc calls...
5412016-04-05T15:39:17  <GitHub118> [bitcoin] laanwj closed pull request #7788: Use relative paths instead of absolute paths in protoc calls (master...20160402_protoc_use_relpath) https://github.com/bitcoin/bitcoin/pull/7788
5422016-04-05T15:40:21  <Chris_Stewart_5> sipa: interesting. I didn't realize that limitation was there. I thought you think of the scriptSig & scriptPubKey as one big concatenated list when you were running it through the interpreter.
5432016-04-05T15:41:20  <sipa> Chris_Stewart_5: yes
5442016-04-05T15:41:46  *** cryptapus has joined #bitcoin-core-dev
5452016-04-05T15:41:46  <sipa> Chris_Stewart_5: but the scriptSig here contains an opcode that says "The next 1 byte is to be pushed: ", and then no more bytes
5462016-04-05T15:41:51  <sipa> which is obviously invalid
5472016-04-05T15:42:10  <sipa> it's like an unterminated quotation mark, or a missing endif
5482016-04-05T15:45:52  <sipa> Chris_Stewart_5: typically you want negative tests that specify the weakest condition under which failure is expected
5492016-04-05T15:48:33  <Chris_Stewart_5> sipa: If it was evaluated at as one big concatenated list though the next byte could be in the scriptPubKey. Where does the validation fail in bitcoin core?
5502016-04-05T15:48:38  <Chris_Stewart_5> is it this line? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L294
5512016-04-05T15:49:01  <sipa> Chris_Stewart_5: that changed in early 2010
5522016-04-05T15:49:11  <sipa> Chris_Stewart_5: scriptPubKey and scriptSig are evaluated separately
5532016-04-05T15:49:18  <Chris_Stewart_5> haha just realized that :-)
5542016-04-05T15:49:50  <Chris_Stewart_5> stack state is shared between the two, is there a reason this is done? Is it one of those things "Its always been done this way so we are going to keep doing it that way" or is there more reason to it
5552016-04-05T15:50:08  <GitHub120> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4dc1b3a29693...1b2460bd5824
5562016-04-05T15:50:08  <GitHub120> bitcoin/master fada0c4 MarcoFalke: [doc] Fix doxygen comments for members
5572016-04-05T15:50:09  <GitHub120> bitcoin/master 1b2460b Wladimir J. van der Laan: Merge #7793: [doxygen] Fix member comments...
5582016-04-05T15:50:13  <GitHub171> [bitcoin] laanwj closed pull request #7793: [doxygen] Fix member comments (master...Mf1604-doxygenMembers) https://github.com/bitcoin/bitcoin/pull/7793
5592016-04-05T15:51:05  <sipa> Chris_Stewart_5: that's how the scriptSig communicates its resulting stack to the scriptPubKey
5602016-04-05T15:51:12  <sipa> Chris_Stewart_5: what alternative would you suggest?
5612016-04-05T15:52:52  <Chris_Stewart_5> concatenate the scriptSig ++ scriptPubKey together and run the entire thing through the interpreter instead of mamking two calls to EvalScript and maintaing stack state
5622016-04-05T15:53:16  <sipa> that's how Bitcoin was in 2009, and it had massive security risks
5632016-04-05T15:53:22  <sipa> as the scriptSig is under control of the attacker
5642016-04-05T15:54:11  <sipa> say your scriptPubKey is 47 bytes, you'd just make a scriptSig 0x3F (which means "push the next 47 bytes onto the stack"), and the result would be accepted
5652016-04-05T15:54:38  <sipa> as it would treat the whole scriptPubKey that's concatenated after it as data being pushed, rather than code
5662016-04-05T15:54:53  <instagibbs> sipa, ok now that section of code makes sense
5672016-04-05T15:56:46  <Chris_Stewart_5> sipa: Wow that is a great way to explain it. So basically that would allow the script to trivially succeed since the scriptPubKey != OP_0 || OP_FALSE right?
5682016-04-05T15:57:25  <sipa> Chris_Stewart_5: furthermore, changing it back to that model of execution would almost by definition be a hard fork
5692016-04-05T15:57:39  <sipa> because if it has any effect at all, it's going to turn invalid things into valid things
5702016-04-05T15:58:00  <Chris_Stewart_5> sipa: Ok. Thanks for the explanation. I appreciate it
5712016-04-05T16:01:36  <GitHub166> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c2106543fe017d443c2e50daf3dd1d42e6ec35a2
5722016-04-05T16:01:37  <GitHub166> bitcoin/0.12 c210654 Wladimir J. van der Laan: pre-rc1 translations update...
5732016-04-05T16:08:09  <GitHub174> [bitcoin] laanwj closed pull request #7654: Add net2 debug option (master...DebugNet2) https://github.com/bitcoin/bitcoin/pull/7654
5742016-04-05T16:17:12  <gmaxwell>   "errors": "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)"
5752016-04-05T16:17:50  <gmaxwell> of course I dunno when that triggered, though I don't think that host has had any network outages.
5762016-04-05T16:18:15  <wumpus> that's the one we disabled on 0.12 right?
5772016-04-05T16:18:26  <gmaxwell> yep.
5782016-04-05T16:18:55  *** zooko has quit IRC
5792016-04-05T16:35:42  *** cjcj has quit IRC
5802016-04-05T16:51:20  *** Don_John has joined #bitcoin-core-dev
5812016-04-05T17:01:27  *** paveljanik has joined #bitcoin-core-dev
5822016-04-05T17:01:27  *** paveljanik has joined #bitcoin-core-dev
5832016-04-05T17:07:58  *** abritoid has joined #bitcoin-core-dev
5842016-04-05T17:11:31  *** cjcj has joined #bitcoin-core-dev
5852016-04-05T17:28:44  <cfields_> wumpus: have you looked into the spurious (possible) race condition that we're hitting on travis sometimes? I'm going to poke at it now, curious if you have anything to go on
5862016-04-05T17:29:04  *** bsm1175321 has joined #bitcoin-core-dev
5872016-04-05T17:29:39  <MarcoFalke> which one do you mean?
5882016-04-05T17:30:06  <cfields_> MarcoFalke: https://github.com/bitcoin/bitcoin/issues/7470
5892016-04-05T17:30:10  *** bsm1175321 is now known as bsm117532
5902016-04-05T17:30:30  <cfields_> I've noticed a few of those (or similar) lately
5912016-04-05T17:31:01  <MarcoFalke> Ok, this is not travis only. I think some people could "reproduce" those locally
5922016-04-05T17:31:20  <MarcoFalke> Note: Please don't retrigger https://github.com/bitcoin/bitcoin/pull/7817 (just reported the issue to travis)
5932016-04-05T17:31:30  <cfields_> MarcoFalke: ah nice, you happen to have a repro case handy?
5942016-04-05T17:32:49  <MarcoFalke> Unfortunatley not, but didn't someone mention it can happen after some time?
5952016-04-05T17:33:15  <cfields_> not sure
5962016-04-05T17:33:22  <MarcoFalke> So I was thinking about adding some random sleeps in the test suite and let it run over night
5972016-04-05T17:37:01  <cfields_> sure, if there's a race condition caused by arbitrary sleeps, we'd definitely want to know about those
5982016-04-05T17:52:06  *** Thireus has quit IRC
5992016-04-05T17:52:24  *** Thireus has joined #bitcoin-core-dev
6002016-04-05T17:59:00  *** e0_ has quit IRC
6012016-04-05T18:03:41  *** PaulCapestany has quit IRC
6022016-04-05T18:05:21  *** PaulCapestany has joined #bitcoin-core-dev
6032016-04-05T18:05:50  *** Don_John has quit IRC
6042016-04-05T18:08:30  *** moli has quit IRC
6052016-04-05T18:10:19  *** jtimon has quit IRC
6062016-04-05T18:13:15  *** moli has joined #bitcoin-core-dev
6072016-04-05T18:21:03  *** supasonic has joined #bitcoin-core-dev
6082016-04-05T18:34:03  *** supasonic has quit IRC
6092016-04-05T18:42:22  *** d_t has joined #bitcoin-core-dev
6102016-04-05T18:47:41  *** supasonic has joined #bitcoin-core-dev
6112016-04-05T18:57:10  <paveljanik> GH is a bit slow right now...
6122016-04-05T18:57:45  *** abritoid has quit IRC
6132016-04-05T19:33:42  *** cryptapus has quit IRC
6142016-04-05T19:41:47  <GitHub127> [bitcoin] jtimon opened pull request #7820: Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface (master...0.12.99-consensus-dust-out) https://github.com/bitcoin/bitcoin/pull/7820
6152016-04-05T19:45:07  *** jtimon has joined #bitcoin-core-dev
6162016-04-05T19:53:07  *** e0_ has joined #bitcoin-core-dev
6172016-04-05T19:57:31  *** xabbix has quit IRC
6182016-04-05T20:02:43  *** xabbix has joined #bitcoin-core-dev
6192016-04-05T20:02:43  *** xabbix has joined #bitcoin-core-dev
6202016-04-05T20:03:25  *** arubi has quit IRC
6212016-04-05T20:03:55  *** arubi has joined #bitcoin-core-dev
6222016-04-05T20:13:53  *** frankenmint has joined #bitcoin-core-dev
6232016-04-05T20:21:54  *** frankenmint has quit IRC
6242016-04-05T20:33:03  *** Chris_Stewart_5 has quit IRC
6252016-04-05T20:36:29  *** MarcoFalke has quit IRC
6262016-04-05T20:41:03  *** Guyver2_ has joined #bitcoin-core-dev
6272016-04-05T20:45:12  *** Guyver2 has quit IRC
6282016-04-05T20:45:19  *** Guyver2_ is now known as Guyver2
6292016-04-05T20:49:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6302016-04-05T21:04:05  *** d_t has quit IRC
6312016-04-05T21:07:04  *** supasonic has quit IRC
6322016-04-05T21:20:16  *** zmanian__ has quit IRC
6332016-04-05T21:22:38  *** supasonic has joined #bitcoin-core-dev
6342016-04-05T21:23:09  *** zmanian__ has joined #bitcoin-core-dev
6352016-04-05T21:45:01  *** Squidicc has joined #bitcoin-core-dev
6362016-04-05T21:45:13  *** Squidicuz has quit IRC
6372016-04-05T21:46:01  *** Arnavion has quit IRC
6382016-04-05T21:46:05  *** Arnavion3 has joined #bitcoin-core-dev
6392016-04-05T21:46:09  *** Arnavion3 is now known as Arnavion
6402016-04-05T21:48:52  *** fkhan_ has quit IRC
6412016-04-05T21:52:56  *** fkhan_ has joined #bitcoin-core-dev
6422016-04-05T22:10:47  *** frankenmint has joined #bitcoin-core-dev
6432016-04-05T22:13:03  *** p15 has quit IRC
6442016-04-05T22:26:18  *** Chris_Stewart_5 has quit IRC
6452016-04-05T22:40:06  *** Guyver2 has quit IRC
6462016-04-05T22:40:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6472016-04-05T22:57:36  <sipa> oh, github supports verifying gpg signatures now
6482016-04-05T22:58:01  *** AaronvanW has quit IRC
6492016-04-05T23:15:05  <PRab> sipa: You figure out how to verify your gpg key? I added mine to https://github.com/settings/keys, but its still showing "Unverified".
6502016-04-05T23:15:56  <sipa> yeah, works for me: https://github.com/bitcoin/secp256k1/commits/master
6512016-04-05T23:16:16  <sipa> does your commit email address match an email address in the key?
6522016-04-05T23:18:17  <PRab> sipa: It should. Maybe it doesn't scan old commits. I believe https://github.com/bitcoin/gitian.sigs/commits/master/0.12.0rc5-linux/prab/bitcoin-linux-0.12-build.assert should have been signed with that key.
6532016-04-05T23:20:15  <sipa> committer Paul Rabahy <PRabahy@gmail.com> 1455405253 -0500
6542016-04-05T23:20:33  <sipa> maybe upper/lower case mix?
6552016-04-05T23:21:39  <PRab> Looks the same to me.
6562016-04-05T23:21:40  <PRab> https://imgur.com/WN1kiEt
6572016-04-05T23:22:08  <sipa> PRab: ah, but that email address is not associated with your github account
6582016-04-05T23:22:44  <PRab> Ah, got it.
6592016-04-05T23:23:14  <PRab> github has it as prabahy@gmail.com
6602016-04-05T23:23:41  <PRab> I'll get ahold of github support.
6612016-04-05T23:27:20  <sipa> and it works pretty far back: https://github.com/bitcoin/bitcoin/commit/9269d0e96e621a6e02da8074785ac310ce64db73
6622016-04-05T23:28:42  <PRab> Hum, I managed to fix my email address (had to go through a temp email because of case insensitivity), but its still not working.
6632016-04-05T23:30:26  *** frankenmint has quit IRC
6642016-04-05T23:31:00  *** frankenmint has joined #bitcoin-core-dev
6652016-04-05T23:31:15  <PRab> Anyway, really cool feature.
6662016-04-05T23:35:30  *** frankenmint has quit IRC
6672016-04-05T23:47:38  *** wallet42 has joined #bitcoin-core-dev
6682016-04-05T23:50:02  *** frankenmint has joined #bitcoin-core-dev