12016-05-18T00:01:04  *** PRab has joined #bitcoin-core-dev
  22016-05-18T00:47:26  <petertodd> luke-jr: but that's unrelated to the opt-in rbf detection; I agree that in general we want to display doublespends
  32016-05-18T00:48:00  <luke-jr> petertodd: well, I mean if we're displaying "replacable" as an indication
  42016-05-18T00:50:45  <petertodd> luke-jr: right, but I'm only talking about incoming txs
  52016-05-18T01:05:04  *** dermoth__ has quit IRC
  62016-05-18T01:05:40  *** dermoth__ has joined #bitcoin-core-dev
  72016-05-18T01:19:01  *** Alopex has quit IRC
  82016-05-18T01:20:06  *** Alopex has joined #bitcoin-core-dev
  92016-05-18T01:21:11  *** Ylbam has quit IRC
 102016-05-18T01:29:35  *** alpalp has quit IRC
 112016-05-18T01:29:47  *** alpalp has joined #bitcoin-core-dev
 122016-05-18T01:29:48  *** alpalp has joined #bitcoin-core-dev
 132016-05-18T01:30:33  <GitHub150> [bitcoin] theuni opened pull request #8067: travis: use slim generic image, and some fixups (master...travis-generic-image) https://github.com/bitcoin/bitcoin/pull/8067
 142016-05-18T01:32:42  *** molz has joined #bitcoin-core-dev
 152016-05-18T01:36:03  *** moli has quit IRC
 162016-05-18T01:40:42  *** belcher has quit IRC
 172016-05-18T01:44:29  *** Chris_Stewart_5 has quit IRC
 182016-05-18T01:49:20  <GitHub3> [bitcoin] TheBlueMatt opened pull request #8068: Compact Blocks (master...udp) https://github.com/bitcoin/bitcoin/pull/8068
 192016-05-18T01:52:56  *** alpalp has quit IRC
 202016-05-18T01:53:59  *** alpalp has joined #bitcoin-core-dev
 212016-05-18T02:01:08  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 222016-05-18T02:04:40  *** Michail1 has quit IRC
 232016-05-18T02:07:14  *** Chris_Stewart_5 has quit IRC
 242016-05-18T02:23:32  *** Giszmo has quit IRC
 252016-05-18T02:25:05  *** Giszmo has joined #bitcoin-core-dev
 262016-05-18T02:34:01  *** Michail1 has joined #bitcoin-core-dev
 272016-05-18T02:36:51  *** TomMc has quit IRC
 282016-05-18T02:38:07  *** alpalp has quit IRC
 292016-05-18T02:40:12  *** Michail1 has quit IRC
 302016-05-18T02:50:27  *** Michail1 has joined #bitcoin-core-dev
 312016-05-18T03:21:01  *** Alopex has quit IRC
 322016-05-18T03:22:07  *** Alopex has joined #bitcoin-core-dev
 332016-05-18T03:44:01  *** Alopex has quit IRC
 342016-05-18T03:45:06  *** Alopex has joined #bitcoin-core-dev
 352016-05-18T04:16:40  *** justanotheruser has quit IRC
 362016-05-18T04:17:40  <BlueMatt> sipa/gmaxwell
 372016-05-18T04:17:55  <BlueMatt> so I was just going back and checking, and the new varint stuff doesnt help anywhere that matters
 382016-05-18T04:19:08  *** justanotheruser has joined #bitcoin-core-dev
 392016-05-18T04:19:49  <BlueMatt> its an extra few kb in getblocktxn, but thats not really critical-path since that is still one-per-block-per-node
 402016-05-18T04:20:37  <BlueMatt> its only like 10 or 20 bytes in cmpctblock, which is the all-important potentially-multiple-times-per-block
 412016-05-18T04:22:30  <BlueMatt> gmaxwell: since you're the one with no b/w at home, how much would you care if there is an extra few kb (if even that) in getblocktxn?
 422016-05-18T04:22:39  <BlueMatt> somehow I had thought it was a savings in cmpctblock
 432016-05-18T04:24:04  <sipa> i'm fine with sticking to the existing varint scheme
 442016-05-18T04:24:11  <luke-jr> "one" <.<
 452016-05-18T04:24:33  <luke-jr> BlueMatt: How is blocktxn not part of the critical path?
 462016-05-18T04:26:55  *** Giszmo has quit IRC
 472016-05-18T04:27:38  *** zooko has quit IRC
 482016-05-18T04:56:01  *** Alopex has quit IRC
 492016-05-18T04:57:07  *** Alopex has joined #bitcoin-core-dev
 502016-05-18T05:05:09  *** jl2012_ has joined #bitcoin-core-dev
 512016-05-18T05:11:03  *** paveljanik has joined #bitcoin-core-dev
 522016-05-18T05:11:04  *** paveljanik has joined #bitcoin-core-dev
 532016-05-18T05:11:37  *** Pat_Boy has joined #bitcoin-core-dev
 542016-05-18T05:12:54  *** Evel-Knievel has quit IRC
 552016-05-18T05:12:55  *** amiller has quit IRC
 562016-05-18T05:12:55  *** jl2012 has quit IRC
 572016-05-18T05:12:55  *** da2ce7_mobile has quit IRC
 582016-05-18T05:12:55  *** PatBoy has quit IRC
 592016-05-18T05:12:57  *** spudowiar has quit IRC
 602016-05-18T05:12:59  *** JackH has quit IRC
 612016-05-18T05:13:02  *** Pat_Boy is now known as PatBoy
 622016-05-18T05:13:03  *** jl2012_ is now known as jl2012
 632016-05-18T05:13:36  *** Evel-Knievel has joined #bitcoin-core-dev
 642016-05-18T05:13:47  *** JackH has joined #bitcoin-core-dev
 652016-05-18T05:14:56  *** amiller_ has joined #bitcoin-core-dev
 662016-05-18T05:15:48  *** spudowiar has joined #bitcoin-core-dev
 672016-05-18T05:16:45  *** da2ce7_mobile has joined #bitcoin-core-dev
 682016-05-18T05:24:01  *** Alopex has quit IRC
 692016-05-18T05:25:07  *** Alopex has joined #bitcoin-core-dev
 702016-05-18T05:27:43  *** pet_rock has quit IRC
 712016-05-18T05:57:37  *** tErik_mc has joined #bitcoin-core-dev
 722016-05-18T06:00:03  <BlueMatt> luke-jr: I said getblocktxn
 732016-05-18T06:00:18  <BlueMatt> luke-jr: meh, do you care about an extra few kb once per block?
 742016-05-18T06:00:26  <luke-jr> right, but that's before blocktxn
 752016-05-18T06:00:32  <BlueMatt> indeed?
 762016-05-18T06:00:41  <luke-jr> I don't know if it matters; it may not.
 772016-05-18T06:02:01  <BlueMatt> it'll be an extra packet or two
 782016-05-18T06:02:17  <BlueMatt> and it doesnt effect udp stuff
 792016-05-18T06:13:14  *** gribble has quit IRC
 802016-05-18T06:20:22  *** jannes has quit IRC
 812016-05-18T06:22:31  *** gribble has joined #bitcoin-core-dev
 822016-05-18T06:26:01  *** Alopex has quit IRC
 832016-05-18T06:26:22  *** gabridome has joined #bitcoin-core-dev
 842016-05-18T06:27:06  *** Alopex has joined #bitcoin-core-dev
 852016-05-18T06:37:48  *** gabridome has quit IRC
 862016-05-18T06:43:26  <jonasschnelli> luke-jr, petertodd: would you silently ignore (list as normal) incoming RBF txes?
 872016-05-18T06:43:58  <luke-jr> jonasschnelli: sure. they are no different in any practical sense than any other incoming txs
 882016-05-18T06:44:18  <jonasschnelli> except that they can be replaced.. :)
 892016-05-18T06:44:29  <luke-jr> all unconfirmed txs can be replaced.
 902016-05-18T06:44:40  <jonasschnelli> Sure. But they don't signal it explicit.
 912016-05-18T06:44:44  <luke-jr> irrelevant.
 922016-05-18T06:45:08  <jonasschnelli> So why do we have RBF then?
 932016-05-18T06:45:12  <luke-jr> because politics
 942016-05-18T06:45:20  <luke-jr> if you mean BIP 125
 952016-05-18T06:45:27  <luke-jr> RBF in general is just common sense really
 962016-05-18T06:46:21  <luke-jr> double spending was always easy for the criminal uses. RBF makes it practical for legitimate users too.
 972016-05-18T06:46:39  <luke-jr> BIP 125 is necessary to get around anti-RBF trolls.
 982016-05-18T06:48:20  <jonasschnelli> I don't care about politics and trolls. All I care is about a mempool rule that was written down in a Bip (125) and if a tx matches that bip rule (nSequence), it should be visible somewhere (can also be in the tx details once you doubleclick a tx).
 992016-05-18T06:49:57  <luke-jr> I don't care if you have the unenforcable nSequence stuff in the tx debug info window you get by double clicking it. I just don't think it should be presented to end users and relevant.
1002016-05-18T06:50:15  <luke-jr> mempool policy is not a rule, and is a per-node decision
1012016-05-18T06:50:38  <jonasschnelli> I kinda agree. 0-conf should be listed a 0-conf... maybe a slightly different icon (but same color attributes)?
1022016-05-18T06:51:10  <luke-jr> there are plenty of nodes and even some miners who do RBF ignoring BIP 125 signalling, and that's not a problem.
1032016-05-18T06:51:27  <luke-jr> there's no such thing as 0-conf, it's unconfirmed ;)
1042016-05-18T06:51:50  <luke-jr> unconfirmed should of course be presented differently from confirmed, but AFAIK we already do that
1052016-05-18T06:52:07  <jonasschnelli> luke-jr: requesting BIP number assignment for Peer-to-Peer Communication Encryption (https://github.com/bitcoin/bips/pull/362/files) (https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-April/012599.html)
1062016-05-18T06:52:24  <luke-jr> jonasschnelli: just encryption? or auth too?
1072016-05-18T06:52:26  <jonasschnelli> Number assignment for "Authentication" is not required at this point.
1082016-05-18T06:52:34  <jonasschnelli> (needs further discussion)
1092016-05-18T06:53:03  <luke-jr> k, 151 for encryption
1102016-05-18T06:53:13  <jonasschnelli> Super. Thanks!
1112016-05-18T06:53:26  <luke-jr> I guess split the PR up so 151 can be merged alone..?
1122016-05-18T06:54:44  <jonasschnelli> Yes. I'll remove the auth BIP from the PR and update the enc bip
1132016-05-18T07:04:45  *** tErik_mc1 has joined #bitcoin-core-dev
1142016-05-18T07:04:46  *** tErik_mc1 has joined #bitcoin-core-dev
1152016-05-18T07:05:16  *** tErik_mc1 has joined #bitcoin-core-dev
1162016-05-18T07:05:17  *** tErik_mc1 has joined #bitcoin-core-dev
1172016-05-18T07:05:50  *** tErik_mc1 has joined #bitcoin-core-dev
1182016-05-18T07:05:50  *** tErik_mc1 has joined #bitcoin-core-dev
1192016-05-18T07:06:23  *** tErik_mc1 has joined #bitcoin-core-dev
1202016-05-18T07:06:23  *** tErik_mc1 has joined #bitcoin-core-dev
1212016-05-18T07:06:55  *** tErik_mc1 has joined #bitcoin-core-dev
1222016-05-18T07:06:55  *** tErik_mc1 has joined #bitcoin-core-dev
1232016-05-18T07:07:27  *** tErik_mc1 has joined #bitcoin-core-dev
1242016-05-18T07:07:28  *** tErik_mc1 has joined #bitcoin-core-dev
1252016-05-18T07:07:56  *** Guest75560 has joined #bitcoin-core-dev
1262016-05-18T07:08:40  *** tErik_mc has quit IRC
1272016-05-18T07:12:02  *** Alopex has quit IRC
1282016-05-18T07:13:07  *** Alopex has joined #bitcoin-core-dev
1292016-05-18T07:22:43  *** Guyver2 has joined #bitcoin-core-dev
1302016-05-18T07:25:59  *** Ylbam has joined #bitcoin-core-dev
1312016-05-18T07:31:01  *** Alopex has quit IRC
1322016-05-18T07:32:06  *** Alopex has joined #bitcoin-core-dev
1332016-05-18T07:35:26  *** droark has quit IRC
1342016-05-18T07:38:30  <gmaxwell> BlueMatt: I'm sad to continue propagating the old varints in the protocol into more places. They're gratitiously inefficient for no reason... but I don't think the difference between the two really makes a meaningful bandwidth difference in this case.
1352016-05-18T07:39:03  <gmaxwell> (the differential encoding otoh makes a huge difference)
1362016-05-18T07:40:19  <sipa> gmaxwell: git btw uses little-endian varints, we use big endian ones
1372016-05-18T07:44:35  <gmaxwell> BlueMatt: I believe use of the bitcoin one will never cause a increase in packet count, even in the worst case with a 2MB sw block.
1382016-05-18T07:45:17  <BlueMatt> gmaxwell: it could with cmpctblock :p
1392016-05-18T07:46:00  <gmaxwell> yes, there it could. but not in getblocktxn
1402016-05-18T07:46:34  <gmaxwell> consider to get the 3 byte CompactSize, you'd need to have deltas of 254 or more. Well if you have 4000 btc, you can only have 15 such deltas.
1412016-05-18T07:46:54  <gmaxwell> s/btc/txn/
1422016-05-18T07:48:05  <BlueMatt> those extra few bytes...you never know :p
1432016-05-18T07:48:30  <gmaxwell> Well in any case if we cared the fact that small ranges take a whole byte is the real problem. :)
1442016-05-18T07:48:41  <gmaxwell> but I wasn't going to suggest you include a range coder.
1452016-05-18T07:50:04  <gmaxwell> Though someday when we do a compactblk v2 that uses set reconcil. we'd need a range coder to efficiently encode the transaction ordering...
1462016-05-18T07:53:05  <gmaxwell> BlueMatt: in any case, make whatever change you need to make so that I never again hear someone arguing that it should use "UTF-8".
1472016-05-18T07:53:53  <BlueMatt> ..........
1482016-05-18T07:53:54  <BlueMatt> "I wasn't going to suggest"....you keep saying this...........
1492016-05-18T07:54:32  <BlueMatt> i mean i dont really give a shit about people making statements that are highly disconnected from reality...just that after having implemented it, I'm not sure its worth the protocol-complexity
1502016-05-18T07:56:39  <gmaxwell> BlueMatt: yea, yank it out. I agree.
1512016-05-18T08:02:29  <gmaxwell> https://people.xiph.org/~greg/temp/perm.tar.gz   permutation encoder that I started writing using the range coder from the daala video codec (which is a fast and efficient multiply free range coder with a nice API), which gets within about 0.5% of information thoretic efficiency. (e.g. it takes 1074 bytes to encode a permutation for 1000 elements).
1522016-05-18T08:08:31  <gmaxwell> BlueMatt: the spec should say what happens if you send non-canonical CompactSize encodings.
1532016-05-18T08:13:28  *** AaronvanW has joined #bitcoin-core-dev
1542016-05-18T08:14:58  <BlueMatt> gmaxwell: i will point out that undefined behavior may eat cats, including non-canonical CompactSize :)
1552016-05-18T08:15:17  *** davec has quit IRC
1562016-05-18T08:16:50  *** BCBot has quit IRC
1572016-05-18T08:20:37  *** davec has joined #bitcoin-core-dev
1582016-05-18T08:29:29  *** AaronvanW has quit IRC
1592016-05-18T08:34:55  *** AaronvanW has joined #bitcoin-core-dev
1602016-05-18T08:42:01  *** CodeShark_ has joined #bitcoin-core-dev
1612016-05-18T08:42:44  *** jl2012_ has joined #bitcoin-core-dev
1622016-05-18T08:42:51  *** Taek42 has joined #bitcoin-core-dev
1632016-05-18T08:44:07  *** kadoban_ has joined #bitcoin-core-dev
1642016-05-18T08:44:45  *** Madars has joined #bitcoin-core-dev
1652016-05-18T08:44:47  *** nickler_ has joined #bitcoin-core-dev
1662016-05-18T08:44:47  *** jyap_ has joined #bitcoin-core-dev
1672016-05-18T08:44:53  *** michagogo_ has joined #bitcoin-core-dev
1682016-05-18T08:45:05  *** cfields_ has joined #bitcoin-core-dev
1692016-05-18T08:45:19  *** Eliel_ has joined #bitcoin-core-dev
1702016-05-18T08:45:39  *** TD--Linux has joined #bitcoin-core-dev
1712016-05-18T08:45:39  *** jl2012 has quit IRC
1722016-05-18T08:45:44  *** GreenIsMyPepper has quit IRC
1732016-05-18T08:45:45  *** jyap has quit IRC
1742016-05-18T08:45:46  *** CodeShark has quit IRC
1752016-05-18T08:45:47  *** Madars_ has quit IRC
1762016-05-18T08:45:49  *** michagogo has quit IRC
1772016-05-18T08:45:50  *** spudowiar has quit IRC
1782016-05-18T08:45:50  *** musalbas has quit IRC
1792016-05-18T08:45:51  *** donal has quit IRC
1802016-05-18T08:45:51  *** teward has quit IRC
1812016-05-18T08:45:54  *** Eliel has quit IRC
1822016-05-18T08:45:56  *** nsh has quit IRC
1832016-05-18T08:45:57  *** kadoban has quit IRC
1842016-05-18T08:45:59  *** nickler has quit IRC
1852016-05-18T08:45:59  *** cfields has quit IRC
1862016-05-18T08:46:02  *** TD-Linux has quit IRC
1872016-05-18T08:46:03  *** Taek has quit IRC
1882016-05-18T08:46:05  *** GreenIsMyPepper has joined #bitcoin-core-dev
1892016-05-18T08:46:07  *** jl2012_ is now known as jl2012
1902016-05-18T08:46:07  *** jyap_ is now known as jyap
1912016-05-18T08:46:08  *** musalbas- is now known as musalbas
1922016-05-18T08:46:09  *** jyap has quit IRC
1932016-05-18T08:46:09  *** jyap has joined #bitcoin-core-dev
1942016-05-18T08:46:19  *** lysobit- has joined #bitcoin-core-dev
1952016-05-18T08:47:23  *** CodeShark_ is now known as CodeShark
1962016-05-18T08:48:18  *** wallet42 has quit IRC
1972016-05-18T08:48:28  *** spudowiar has joined #bitcoin-core-dev
1982016-05-18T08:49:22  *** NicolasDorier has quit IRC
1992016-05-18T08:49:36  *** eragmus has quit IRC
2002016-05-18T08:49:49  *** teward has joined #bitcoin-core-dev
2012016-05-18T08:51:02  *** nsh- has joined #bitcoin-core-dev
2022016-05-18T08:52:55  <gmaxwell> jonasschnelli: sure the rpc and such shows the BIP125 replacability status. My only concern was that we not do something like printing a warning.
2032016-05-18T08:53:18  <gmaxwell> jonasschnelli: because a warning would be material misinformation (as it would imply that transactions without the warning were more safe)
2042016-05-18T08:54:04  <jonasschnelli> Yes. I agree. I think we should use a slighly different transaction icon (which should not imply a warning)
2052016-05-18T08:54:11  <gmaxwell> jonasschnelli: though there are a dozen other characteristics we don't show anywhere in the UI that are often more interesting... we don't show when a transaction uses nlocktime.. we don't show the sighash flasgs of its signatures (for the latter, not even in the RPC).
2062016-05-18T08:54:35  <gmaxwell> So I dunno why there would be an indicator icoin for 125 replacablity when there isn't one for nlocktime.
2072016-05-18T08:55:22  <jonasschnelli> Yes. We should be careful with what we add to the gui level. Maybe I was to focused on bip125 and thought its important to see it "everywhere". But right,... its not.
2082016-05-18T08:56:30  <jonasschnelli> IMO https://github.com/bitcoin/bitcoin/pull/7826 is more important. Because the GUI/current master does not list mempool conflicts as conflicts.
2092016-05-18T08:56:38  *** NicolasDorier has joined #bitcoin-core-dev
2102016-05-18T08:56:39  *** pedrobranco has joined #bitcoin-core-dev
2112016-05-18T08:56:45  <jonasschnelli> Only conflicts with transactions in blocks
2122016-05-18T08:56:58  <jonasschnelli> screenshots: https://github.com/bitcoin/bitcoin/pull/7826#issuecomment-206424972
2132016-05-18T08:57:04  *** michagogo_ is now known as michagogo
2142016-05-18T08:57:18  <gmaxwell> oh thats no good. The RPC gets that right.
2152016-05-18T08:57:40  *** eragmus has joined #bitcoin-core-dev
2162016-05-18T08:58:07  *** wallet42 has joined #bitcoin-core-dev
2172016-05-18T08:58:38  <gmaxwell> jonasschnelli: hm. so a downside of that X if it's only mempool conflicted is that it sort of suggests the conflict can't actually go through.
2182016-05-18T08:59:19  *** pedrobranco has quit IRC
2192016-05-18T08:59:34  *** pedrobranco has joined #bitcoin-core-dev
2202016-05-18T08:59:49  <jonasschnelli> gmaxwell: the "X" then would show that this transaction is replaced by another one.
2212016-05-18T08:59:58  <jonasschnelli> gmaxwell: But maybe there are better ways to deal with that.
2222016-05-18T09:00:06  <jonasschnelli> And yes. RPC does handle this, GUI currently not.
2232016-05-18T09:00:48  <gmaxwell> which can lead to funds loss, e.g. say I pay Alice and then do something stupid with my wallet and pay Bob.   The payment to bob is conflicted with the alice transaction in my own mempool.  The Bob payment has an X.   Bob is whining that I haven't paid him, so then I go to pay him again, since that txn is "bad" (it has an X).   Then both bob payments go through.
2242016-05-18T09:02:16  <GitHub116> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c3f8ddcaa11...5e374f73060d
2252016-05-18T09:02:17  <GitHub116> bitcoin/master 0b1295b Pieter Wuille: Add SipHash-2-4 primitives to hash
2262016-05-18T09:02:17  <GitHub116> bitcoin/master 382c871 Pieter Wuille: Use SipHash-2-4 for CCoinsCache index...
2272016-05-18T09:02:18  <GitHub116> bitcoin/master 8cc9cfe Pieter Wuille: Switch CTxMempool::mapTx to use a hash index for txids
2282016-05-18T09:02:24  *** Arnavion has quit IRC
2292016-05-18T09:02:33  <jonasschnelli> gmaxwell: Hmm... how could you create a conflict with the GUI?
2302016-05-18T09:02:39  *** Arnavion has joined #bitcoin-core-dev
2312016-05-18T09:02:56  <gmaxwell> jonasschnelli: you can do it by loading two copies of the same wallet at once.
2322016-05-18T09:02:58  <jonasschnelli> IMO it would only be possible with the rawtx* API
2332016-05-18T09:03:01  <gmaxwell> or using raw txn.
2342016-05-18T09:03:10  <gmaxwell> or by loading a wallet backup.
2352016-05-18T09:03:35  <gmaxwell> Or by exporting a private key and using it in something else.
2362016-05-18T09:04:02  <jonasschnelli> Same problem would be present on RPC listtransaction I guess.
2372016-05-18T09:04:12  <gmaxwell> Obviously we try hard to make this difficult to do, but I've seen users do it unintentionally.
2382016-05-18T09:04:27  <jonasschnelli> I don't see a easy solution to this.
2392016-05-18T09:04:43  <gmaxwell> listtransactions though still will show you the confirmcount of 0. The additional information hopefully would reduce misunderstandings.
2402016-05-18T09:04:51  <gmaxwell> I would suggest a ! instead of an X.
2412016-05-18T09:04:56  <jonasschnelli> But I see there is a big value in attributing mempool conflicts (with RBF now).
2422016-05-18T09:05:15  <jonasschnelli> Yes. Something different then a "X"
2432016-05-18T09:05:19  <gmaxwell> "!" suggests there is something going wrong here without as much implication that it is dead.
2442016-05-18T09:05:26  <gmaxwell> or something else.  Traffic cone. :)
2452016-05-18T09:05:53  <gmaxwell> (for a transaction at -6 confirms ... then I would say an X is okay! :) )
2462016-05-18T09:06:11  <jonasschnelli> But I guess the "!" transaction would never disappear.
2472016-05-18T09:06:44  <jonasschnelli> Once the replaced transaction got mined, the original-replaced transaction would still be in the wallet.
2482016-05-18T09:06:50  <jonasschnelli> This might lead to user confusion.
2492016-05-18T09:07:24  <jonasschnelli> A right-click-context menu "hide transaction" for some transactions would be good IMO
2502016-05-18T09:07:42  <gmaxwell> sure, so long as there is a way to 'show hidden transactions'
2512016-05-18T09:08:05  <jonasschnelli> Yes... would be required. Maybe over the options.
2522016-05-18T09:09:05  <gmaxwell> A good general UI design principle is that it should never be possible to do something that can't be undone... unless it's at least behind a confirmation.
2532016-05-18T09:09:28  *** jannes has joined #bitcoin-core-dev
2542016-05-18T09:09:35  <jonasschnelli> Yes. Especially if its a bookkeeping transaction list.
2552016-05-18T09:09:53  <gmaxwell> and I think for this having a show/hide and a show hidden in the options menu.. would be okay. Perhaps even an automatically hide conflicted txn with -6 or more anti-confirmations. :)
2562016-05-18T09:11:01  <jonasschnelli> Good point!
2572016-05-18T09:11:20  <jonasschnelli> Also autohide "!" (mempool conflicts) once the replacement has been mined.
2582016-05-18T09:18:04  *** binns has quit IRC
2592016-05-18T09:19:46  *** binns has joined #bitcoin-core-dev
2602016-05-18T09:27:26  <GitHub126> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e374f73060d...457b9df6b595
2612016-05-18T09:27:26  <GitHub126> bitcoin/master fe80102 Matthew English: changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)"
2622016-05-18T09:27:27  <GitHub126> bitcoin/master 457b9df Wladimir J. van der Laan: Merge #8031: improvement to readability...
2632016-05-18T09:27:36  <GitHub191> [bitcoin] laanwj closed pull request #8031: improvement to readability (master...patch-3) https://github.com/bitcoin/bitcoin/pull/8031
2642016-05-18T09:54:05  <GitHub152> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/457b9df6b595...ed749bdb6480
2652016-05-18T09:54:06  <GitHub152> bitcoin/master fb26bf0 Patrick Strateman: CAddrMan::Deserialize handle corrupt serializations better.
2662016-05-18T09:54:06  <GitHub152> bitcoin/master ed749bd Wladimir J. van der Laan: Merge #7932: CAddrMan::Deserialize handle corrupt serializations better....
2672016-05-18T09:54:15  <GitHub57> [bitcoin] laanwj closed pull request #7932: CAddrMan::Deserialize handle corrupt serializations better. (master...2016-04-23-addrman-deserialize-limits) https://github.com/bitcoin/bitcoin/pull/7932
2682016-05-18T09:56:50  *** paveljanik has quit IRC
2692016-05-18T10:13:26  <GitHub84> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed749bdb6480...83121cca7573
2702016-05-18T10:13:27  <GitHub84> bitcoin/master 52cbce2 Cory Fields: net: don't import std namespace...
2712016-05-18T10:13:27  <GitHub84> bitcoin/master 9faa490 Cory Fields: net: remove unused set
2722016-05-18T10:13:28  <GitHub84> bitcoin/master 563f375 Cory Fields: net: use the exposed GetNodeSignals() rather than g_signals directly
2732016-05-18T10:13:36  <GitHub163> [bitcoin] laanwj closed pull request #7906: net: prerequisites for p2p encapsulation changes (master...net-refactor-prerequisites) https://github.com/bitcoin/bitcoin/pull/7906
2742016-05-18T10:16:24  <GitHub77> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/83121cca7573...c74837b724d1
2752016-05-18T10:16:25  <GitHub77> bitcoin/master e5764e6 Wladimir J. van der Laan: doc: Remove outdated qt4 install information from README.md...
2762016-05-18T10:16:26  <GitHub77> bitcoin/master 6075bc4 Wladimir J. van der Laan: doc: 32 and 64 bit packages are seperate
2772016-05-18T10:16:26  <GitHub77> bitcoin/master c74837b Wladimir J. van der Laan: Merge #8048: doc: Remove outdated qt4 install information from README.md...
2782016-05-18T10:16:36  <GitHub148> [bitcoin] laanwj closed pull request #8048: doc: Remove outdated qt4 install information from README.md (master...2016_05_doc_noqt4) https://github.com/bitcoin/bitcoin/pull/8048
2792016-05-18T10:18:31  <GitHub163> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c3aedca2df890916aee78351dbb24bada9887c64
2802016-05-18T10:18:31  <GitHub163> bitcoin/0.12 c3aedca Wladimir J. van der Laan: doc: Remove outdated qt4 install information from README.md...
2812016-05-18T10:28:39  <GitHub23> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c74837b724d1...8e8bebc040a9
2822016-05-18T10:28:40  <GitHub23> bitcoin/master f93c2a1 Daniel Kraft: net: Avoid duplicate getheaders requests....
2832016-05-18T10:28:41  <GitHub23> bitcoin/master 8e8bebc Wladimir J. van der Laan: Merge #8054: net: Avoid duplicate getheaders requests....
2842016-05-18T10:28:50  <GitHub41> [bitcoin] laanwj closed pull request #8054: net: Avoid duplicate getheaders requests. (master...per-client-duplicate-getheaders) https://github.com/bitcoin/bitcoin/pull/8054
2852016-05-18T10:31:54  <GitHub120> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/8e8bebc040a9...239d41986454
2862016-05-18T10:31:56  <GitHub120> bitcoin/master d253ec4 Pieter Wuille: Make ProcessNewBlock dbp const and update comment
2872016-05-18T10:31:56  <GitHub120> bitcoin/master 316623f Pieter Wuille: Switch reindexing to AcceptBlock in-loop and ActivateBestChain afterwards
2882016-05-18T10:31:57  <GitHub120> bitcoin/master fb8fad1 Pieter Wuille: Optimize ActivateBestChain for long chains
2892016-05-18T10:32:02  <GitHub49> [bitcoin] laanwj closed pull request #7917: Optimize reindex (master...betterreindex) https://github.com/bitcoin/bitcoin/pull/7917
2902016-05-18T11:29:25  *** kadoban_ has quit IRC
2912016-05-18T11:32:41  *** gabridome has joined #bitcoin-core-dev
2922016-05-18T11:36:04  *** ghtdak has quit IRC
2932016-05-18T11:48:32  *** pedrobranco has quit IRC
2942016-05-18T11:50:36  *** ghtdak has joined #bitcoin-core-dev
2952016-05-18T11:51:03  *** pedrobranco has joined #bitcoin-core-dev
2962016-05-18T11:52:59  *** arowser has quit IRC
2972016-05-18T11:53:27  *** arowser has joined #bitcoin-core-dev
2982016-05-18T12:04:06  *** pedrobranco has quit IRC
2992016-05-18T12:05:33  *** gevs has quit IRC
3002016-05-18T12:08:25  *** laurentmt has joined #bitcoin-core-dev
3012016-05-18T12:13:56  *** gevs has joined #bitcoin-core-dev
3022016-05-18T12:13:57  *** gevs has joined #bitcoin-core-dev
3032016-05-18T12:18:20  *** gabridome has quit IRC
3042016-05-18T12:28:00  *** pedrobranco has joined #bitcoin-core-dev
3052016-05-18T12:28:53  *** cryptapus_ has joined #bitcoin-core-dev
3062016-05-18T12:31:38  *** pedrobranco has quit IRC
3072016-05-18T12:32:35  *** pedrobranco has joined #bitcoin-core-dev
3082016-05-18T12:33:21  *** Guyver2 has quit IRC
3092016-05-18T12:44:21  *** cryptapus_ is now known as cryptapus
3102016-05-18T12:54:17  *** laurentmt has quit IRC
3112016-05-18T12:54:39  *** laurentmt has joined #bitcoin-core-dev
3122016-05-18T12:58:15  *** laurentmt has quit IRC
3132016-05-18T13:04:19  *** pedrobranco has quit IRC
3142016-05-18T13:09:49  *** pet_rock has joined #bitcoin-core-dev
3152016-05-18T13:11:36  *** hrusti has joined #bitcoin-core-dev
3162016-05-18T13:21:27  *** pedrobranco has joined #bitcoin-core-dev
3172016-05-18T13:28:20  *** TomMc has joined #bitcoin-core-dev
3182016-05-18T13:41:53  *** JackH has quit IRC
3192016-05-18T13:43:27  *** xiangfu has joined #bitcoin-core-dev
3202016-05-18T13:57:32  *** pedrobranco has quit IRC
3212016-05-18T13:59:37  *** pedrobranco has joined #bitcoin-core-dev
3222016-05-18T14:01:34  *** xiangfu has quit IRC
3232016-05-18T14:03:10  *** xiangfu has joined #bitcoin-core-dev
3242016-05-18T14:09:06  *** xiangfu has quit IRC
3252016-05-18T14:19:22  *** xiangfu has joined #bitcoin-core-dev
3262016-05-18T14:20:15  *** Inaltoasinistra has joined #bitcoin-core-dev
3272016-05-18T14:22:58  *** Giszmo has joined #bitcoin-core-dev
3282016-05-18T14:35:44  *** Guyver2 has joined #bitcoin-core-dev
3292016-05-18T14:57:12  *** xiangfu has quit IRC
3302016-05-18T15:03:31  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3312016-05-18T15:09:39  *** Chris_Stewart_5 has quit IRC
3322016-05-18T15:10:34  *** MarcoFalke has joined #bitcoin-core-dev
3332016-05-18T15:12:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3342016-05-18T15:15:34  *** gabridome has joined #bitcoin-core-dev
3352016-05-18T15:19:37  *** gabridome has quit IRC
3362016-05-18T15:31:24  *** paveljanik has joined #bitcoin-core-dev
3372016-05-18T15:48:27  *** zooko has joined #bitcoin-core-dev
3382016-05-18T16:08:31  <GitHub40> [bitcoin] EthanHeilman opened pull request #8070: Remove non-determinism which is breaking net_tests #8069 (master...bug) https://github.com/bitcoin/bitcoin/pull/8070
3392016-05-18T16:09:46  *** Taek42 is now known as Taek
3402016-05-18T16:16:02  *** molz has quit IRC
3412016-05-18T16:16:25  *** molz has joined #bitcoin-core-dev
3422016-05-18T16:30:54  *** Chris_Stewart_5 has quit IRC
3432016-05-18T16:32:56  *** MarcoFalke has quit IRC
3442016-05-18T16:54:20  *** zooko has quit IRC
3452016-05-18T17:00:50  <GitHub123> [bitcoin] morcos closed pull request #7716: [0.11] Backport BIP9 and softfork for BIP's 68,112,113 (0.11...backportBIP9SoftFork) https://github.com/bitcoin/bitcoin/pull/7716
3462016-05-18T17:05:56  *** Gnar has joined #bitcoin-core-dev
3472016-05-18T17:05:59  <Gnar> shitcoins
3482016-05-18T17:14:18  *** earlest has joined #bitcoin-core-dev
3492016-05-18T17:17:34  *** bysherper has quit IRC
3502016-05-18T17:19:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3512016-05-18T17:25:13  *** Gnar has left #bitcoin-core-dev
3522016-05-18T17:57:23  *** molly has joined #bitcoin-core-dev
3532016-05-18T18:00:34  *** molz has quit IRC
3542016-05-18T18:05:20  *** Chris_Stewart_5 has quit IRC
3552016-05-18T18:09:15  *** jonasschnelli has quit IRC
3562016-05-18T18:11:06  *** jonasschnelli has joined #bitcoin-core-dev
3572016-05-18T18:14:00  *** laurentmt has joined #bitcoin-core-dev
3582016-05-18T18:16:32  *** laurentmt has quit IRC
3592016-05-18T18:20:57  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3602016-05-18T18:20:58  *** moli has joined #bitcoin-core-dev
3612016-05-18T18:24:13  *** molly has quit IRC
3622016-05-18T18:32:25  *** gabridome has joined #bitcoin-core-dev
3632016-05-18T18:32:26  *** TD--Linux is now known as TD-Linux
3642016-05-18T18:32:26  *** TD-Linux has joined #bitcoin-core-dev
3652016-05-18T18:36:29  *** molz has joined #bitcoin-core-dev
3662016-05-18T18:40:10  *** moli has quit IRC
3672016-05-18T18:50:52  *** jtimon has joined #bitcoin-core-dev
3682016-05-18T18:50:55  *** jtimon has quit IRC
3692016-05-18T18:51:25  *** gabridome has quit IRC
3702016-05-18T18:53:34  *** pedrobranco has quit IRC
3712016-05-18T18:54:39  *** zooko has joined #bitcoin-core-dev
3722016-05-18T19:02:44  *** belcher has joined #bitcoin-core-dev
3732016-05-18T19:05:26  *** zooko` has joined #bitcoin-core-dev
3742016-05-18T19:07:04  *** zooko has quit IRC
3752016-05-18T19:17:40  *** gabridome has joined #bitcoin-core-dev
3762016-05-18T19:19:04  *** jannes has quit IRC
3772016-05-18T19:20:34  *** gabridome has quit IRC
3782016-05-18T19:24:31  *** pedrobranco has joined #bitcoin-core-dev
3792016-05-18T19:29:01  *** pedrobranco has quit IRC
3802016-05-18T19:30:23  *** kadoban_ has joined #bitcoin-core-dev
3812016-05-18T19:34:17  <luke-jr> jonasschnelli: https://travis-ci.org/bitcoin/bips/builds/131230516
3822016-05-18T19:37:13  <jonasschnelli> Okay. Force pushed something... lets have a look. Thanks @luke-jr
3832016-05-18T19:38:37  *** kadoban_ is now known as kadoban
3842016-05-18T19:38:44  <jonasschnelli> Looks good now: https://travis-ci.org/bitcoin/bips/builds/131233173
3852016-05-18T19:55:52  *** cryptapus has quit IRC
3862016-05-18T20:01:04  <morcos> i'm getting this intermittant testing error: test/net_tests.cpp(92): error in "caddrdb_read": check addrman1.size() == 3 failed   (also in line 102)
3872016-05-18T20:01:07  *** bysherper has joined #bitcoin-core-dev
3882016-05-18T20:01:54  <paveljanik> morcos, #8070
3892016-05-18T20:02:15  <paveljanik> and #8069 8)
3902016-05-18T20:02:53  <morcos> paveljanik: thanks!
3912016-05-18T20:04:04  *** earlest has quit IRC
3922016-05-18T20:10:27  *** Chris_Stewart_5 has quit IRC
3932016-05-18T20:27:48  <cjcj> Will compact blocks make it into 0.13?
3942016-05-18T20:40:05  <gmaxwell> cjcj: why do you ask?
3952016-05-18T20:40:17  <cjcj> Curiosity
3962016-05-18T20:41:11  <gmaxwell> Hopefully. No guarentees can be made for things that aren't in yet.
3972016-05-18T20:54:32  *** cryptapus_afk is now known as cryptapus
3982016-05-18T20:55:57  *** spudowiar has quit IRC
3992016-05-18T20:58:34  *** gabridome has joined #bitcoin-core-dev
4002016-05-18T21:00:06  *** earlest has joined #bitcoin-core-dev
4012016-05-18T21:03:04  *** bysherper has quit IRC
4022016-05-18T21:23:50  *** zooko` has quit IRC
4032016-05-18T21:27:47  *** Gnar has joined #bitcoin-core-dev
4042016-05-18T21:27:50  <Gnar> shticoins
4052016-05-18T21:29:02  *** ChanServ sets mode: +o sipa
4062016-05-18T21:29:11  *** sipa sets mode: +b *!*Gnar@unaffiliated/gnar
4072016-05-18T21:29:11  *** Gnar was kicked by sipa (Gnar)
4082016-05-18T21:29:24  *** sipa sets mode: -o sipa
4092016-05-18T21:35:25  *** pmienk has quit IRC
4102016-05-18T21:38:37  *** gabridome has quit IRC
4112016-05-18T21:44:41  *** bysherper has joined #bitcoin-core-dev
4122016-05-18T21:47:33  *** earlest has quit IRC
4132016-05-18T21:48:42  *** raedah has quit IRC
4142016-05-18T21:52:19  *** [Author] has quit IRC
4152016-05-18T21:56:15  *** spudowiar has joined #bitcoin-core-dev
4162016-05-18T22:01:40  *** Guyver2 has quit IRC
4172016-05-18T22:13:46  <bad_duck> It might be a good idea to replace this link (wget -P inputs http://downloads.sourceforge.net/project/osslsigncode/osslsigncode/osslsigncode-1.7.1.tar.gz )
4182016-05-18T22:13:59  <bad_duck> with an https version, here -> https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md
4192016-05-18T22:14:23  <bad_duck> the links seems to work in https too
4202016-05-18T22:17:19  *** kadoban has quit IRC
4212016-05-18T22:20:43  *** Alopex has quit IRC
4222016-05-18T22:22:31  *** kadoban has joined #bitcoin-core-dev
4232016-05-18T22:26:06  *** Alopex has joined #bitcoin-core-dev
4242016-05-18T22:29:33  *** kadoban has quit IRC
4252016-05-18T22:30:24  *** pedrobranco has joined #bitcoin-core-dev
4262016-05-18T22:31:20  *** supasonic has joined #bitcoin-core-dev
4272016-05-18T22:31:21  *** bsm117532 has quit IRC
4282016-05-18T22:32:26  *** kadoban has joined #bitcoin-core-dev
4292016-05-18T22:35:05  *** pedrobranco has quit IRC
4302016-05-18T22:59:56  *** laurentmt has joined #bitcoin-core-dev
4312016-05-18T23:19:14  <phantomcircuit> bad_duck: it doesn't matter, the file downloaded is checked against a hash
4322016-05-18T23:24:17  <bad_duck> phantomcircuit: ok, thx!
4332016-05-18T23:25:11  *** alpalp has joined #bitcoin-core-dev
4342016-05-18T23:30:06  *** laurentmt has quit IRC