12016-07-19T00:01:54 *** NicLin has joined #bitcoin-core-dev
22016-07-19T00:15:47 *** Ylbam has quit IRC
32016-07-19T00:18:23 *** gmaxwell has joined #bitcoin-core-dev
42016-07-19T00:29:30 *** justanotheruser has quit IRC
52016-07-19T00:30:30 *** justanotheruser has joined #bitcoin-core-dev
62016-07-19T00:40:03 *** supasonic has quit IRC
72016-07-19T00:43:57 *** nickler has quit IRC
82016-07-19T00:44:56 *** skyraider has joined #bitcoin-core-dev
92016-07-19T00:50:07 *** nickler has joined #bitcoin-core-dev
102016-07-19T00:51:45 *** anu1 has quit IRC
112016-07-19T01:01:40 <BlueMatt> why is the hd wallet seed interpreted as an ecdsa privkey in a few places?
122016-07-19T01:01:50 <BlueMatt> that seems like type confusion in a cryptographic system
132016-07-19T01:02:02 <BlueMatt> though afaict its not really used as a pubkey anywhere, this seems like a very, very bad idea generally
142016-07-19T01:03:42 <BlueMatt> (every way I can think about it its nbd, just seems like bad practice)
152016-07-19T01:05:59 <sipa> BlueMatt: it's the other way around... we generate a (valid) private key, and then reinterpret it as a seed
162016-07-19T01:06:09 <BlueMatt> yes, this seems strange
172016-07-19T01:06:15 <sipa> this surprised me too
182016-07-19T01:06:27 <BlueMatt> because it seems to be the pubkey thing is only used to go find the data that we want to hash
192016-07-19T01:06:44 <sipa> but i only noticed it after merge, and i can't find any problems with it
202016-07-19T01:07:05 <BlueMatt> yea, I mean it doesnt seem to be broken, just bad practice
212016-07-19T01:07:22 <BlueMatt> (for encrypted wallets we store the pubkey-version in plaintext on disk, afaict, which is not ideal)
222016-07-19T01:07:32 <BlueMatt> ^ about the only real issue I see
232016-07-19T01:07:57 <gmaxwell> more or less bypasses the kdf then.
242016-07-19T01:08:08 <sipa> what kdf?
252016-07-19T01:08:21 <sipa> bip32 does not have any
262016-07-19T01:08:48 <gmaxwell> The computationally hard function used for the passphrase in wallet encryption. But nevermind, I'm incorrect, it doesn't bypass it.
272016-07-19T01:09:03 <sipa> ah, for encryption - no, indeed
282016-07-19T01:09:10 <BlueMatt> gmaxwell: no, remember the padding bug
292016-07-19T01:09:11 <BlueMatt> :(
302016-07-19T01:09:34 *** Chris_Stewart_5 has quit IRC
312016-07-19T01:09:36 <gmaxwell> I don't consider the padding bug interesting.
322016-07-19T01:09:39 <sipa> still needs KDF; just no ec operation anymore
332016-07-19T01:09:47 <BlueMatt> gmaxwell: indeed, I consider it a novelty
342016-07-19T01:10:48 <sipa> BlueMatt: the alternative for the bip32 derivation is that we'd use the private key of the generated root as master key (with chaincode stored on disk), rather than treating it as a seed
352016-07-19T01:11:03 <sipa> which would pretty much have identical security properties
362016-07-19T01:11:41 <BlueMatt> sipa: kinda, ideally we wouldnt store the pubkey of that on disk
372016-07-19T01:11:56 <BlueMatt> sipa: actually, your suggestion is worse
382016-07-19T01:12:00 <BlueMatt> well, different
392016-07-19T01:12:08 *** nickler has quit IRC
402016-07-19T01:12:20 *** nickler has joined #bitcoin-core-dev
412016-07-19T01:12:30 <gmaxwell> I believe there is a way to quickly disqualify candidate private keys without EC operations in any case; assuming you know two signatures with that key.
422016-07-19T01:12:34 *** Chris_Stewart_5 has joined #bitcoin-core-dev
432016-07-19T01:12:47 <BlueMatt> well, maybe better? right now you need to have your wallet unlocked to create new pubkeys (ie scan the chain, ish)
442016-07-19T01:12:59 <BlueMatt> but we could store master pubkey on disk and then we wouldnt
452016-07-19T01:13:05 <BlueMatt> dunno if better, but different
462016-07-19T01:13:22 <sipa> BlueMatt: it uses hardened derivation, so you always need to unlock in any case
472016-07-19T01:13:27 <BlueMatt> gmaxwell: mmm, didnt know that
482016-07-19T01:13:34 <gmaxwell> BlueMatt: that would require using public derrivation.
492016-07-19T01:13:37 <BlueMatt> sipa: ahh
502016-07-19T01:13:45 <BlueMatt> well, I mean you could store that as well
512016-07-19T01:15:00 *** jannes has quit IRC
522016-07-19T01:21:21 *** supasonic has joined #bitcoin-core-dev
532016-07-19T01:21:31 <BlueMatt> is there any way to get an rpc or so to give you the master key?
542016-07-19T01:21:37 <BlueMatt> if you dump it, probably?
552016-07-19T01:29:10 <BlueMatt> the way I read the current code, every time we go to GenerateNewKey() we will iterate over every key we have already generated before generating a new one (as we never call SetHDChain to store the updated counter on disk)....anyone with a test hd wallet lying around want to see what their disk-counter is?
562016-07-19T01:32:56 *** Giszmo1 has joined #bitcoin-core-dev
572016-07-19T01:35:16 *** Giszmo has quit IRC
582016-07-19T01:40:32 <BlueMatt> hmm...I also dont see any discussion of the non-switch of FEATURE_LATEST on the pr....this might complicate future wallet changes...it seems to me that this locks us in such that the next change to wallet version must either be the same non-default or we will, at that time, have to force hd wallets to be the default
592016-07-19T01:41:31 <BlueMatt> I'm not strictly aginst this, just noting that it seems it was not at all discussed but locks us into a future path
602016-07-19T01:44:11 <BlueMatt> oh ffs, ok, I'ma copy this into the hd wallet pr
612016-07-19T01:49:00 <BlueMatt> ok, https://github.com/bitcoin/bitcoin/pull/8035#issuecomment-233508913
622016-07-19T01:49:02 <BlueMatt> few more there, too
632016-07-19T01:52:54 *** kadoban has quit IRC
642016-07-19T02:00:39 *** Chris_Stewart_5 has quit IRC
652016-07-19T02:04:03 *** belcher has quit IRC
662016-07-19T02:12:45 <luke-jr> BlueMatt: the odd thing IMO is that it isn't already default, but I'm okay with that
672016-07-19T02:13:01 <luke-jr> normally the default would be bumped immediately, and -walletupgrade needed for old wallets
682016-07-19T02:16:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
692016-07-19T02:17:43 *** jtimon has quit IRC
702016-07-19T02:20:48 *** supasonic has quit IRC
712016-07-19T02:24:19 *** Chris_Stewart_5 has quit IRC
722016-07-19T02:26:49 *** jonhbit has joined #bitcoin-core-dev
732016-07-19T02:27:44 *** FNinTak has joined #bitcoin-core-dev
742016-07-19T02:28:57 *** fengling has joined #bitcoin-core-dev
752016-07-19T02:36:33 *** jonhbit has joined #bitcoin-core-dev
762016-07-19T02:38:08 *** jonhbit has left #bitcoin-core-dev
772016-07-19T02:39:11 *** FNinTak has quit IRC
782016-07-19T02:48:07 *** achow101 has quit IRC
792016-07-19T02:52:05 *** skyraider has quit IRC
802016-07-19T03:06:26 *** fengling has quit IRC
812016-07-19T03:07:18 *** fengling has joined #bitcoin-core-dev
822016-07-19T03:37:48 *** kadoban has joined #bitcoin-core-dev
832016-07-19T03:42:05 *** kadoban has quit IRC
842016-07-19T03:46:49 *** kadoban has joined #bitcoin-core-dev
852016-07-19T04:44:46 *** fengling has quit IRC
862016-07-19T04:56:54 *** aalex has quit IRC
872016-07-19T05:00:24 *** aalex has joined #bitcoin-core-dev
882016-07-19T05:04:37 *** fengling has joined #bitcoin-core-dev
892016-07-19T05:16:49 *** slackircbridge has quit IRC
902016-07-19T05:18:08 *** slackircbridge has joined #bitcoin-core-dev
912016-07-19T05:25:44 *** NicLin has quit IRC
922016-07-19T05:28:37 *** kadoban has quit IRC
932016-07-19T05:32:06 *** fengling has quit IRC
942016-07-19T05:40:14 *** fengling has joined #bitcoin-core-dev
952016-07-19T06:15:46 *** Lysanders has quit IRC
962016-07-19T06:33:29 *** PaulCapestany has quit IRC
972016-07-19T06:34:44 *** PaulCapestany has joined #bitcoin-core-dev
982016-07-19T07:32:04 *** slackircbridge has quit IRC
992016-07-19T07:32:10 *** nohup has joined #bitcoin-core-dev
1002016-07-19T07:32:16 *** slackircbridge has joined #bitcoin-core-dev
1012016-07-19T07:34:30 *** whphhg has quit IRC
1022016-07-19T07:37:00 *** whphhg has joined #bitcoin-core-dev
1032016-07-19T07:37:15 *** davec has quit IRC
1042016-07-19T07:37:48 *** davec has joined #bitcoin-core-dev
1052016-07-19T07:52:27 *** NicLin has joined #bitcoin-core-dev
1062016-07-19T08:13:39 *** paveljanik has quit IRC
1072016-07-19T08:14:12 *** molz has joined #bitcoin-core-dev
1082016-07-19T08:15:46 *** moli has quit IRC
1092016-07-19T08:23:07 *** Ylbam has joined #bitcoin-core-dev
1102016-07-19T08:27:13 <jonasschnelli> luke-jr: how do you mean not the default? Per default core 0.13 will generate hd wallets (when starting a new wallet).
1112016-07-19T08:44:17 *** Guyver2 has joined #bitcoin-core-dev
1122016-07-19T08:47:04 *** MarcoFalke has joined #bitcoin-core-dev
1132016-07-19T08:47:26 <MarcoFalke> Also you can't do -walletupgrade to get an HD wallet
1142016-07-19T08:53:38 *** pedrobranco has joined #bitcoin-core-dev
1152016-07-19T08:58:04 *** mn3monic has quit IRC
1162016-07-19T08:58:05 <jonasschnelli> Yes. That would not work. HD can only be enabled during creation.
1172016-07-19T08:58:11 <jonasschnelli> (for now)
1182016-07-19T09:07:17 *** pedrobranco has quit IRC
1192016-07-19T09:07:30 *** pedrobranco has joined #bitcoin-core-dev
1202016-07-19T09:09:20 *** pedrobranco has joined #bitcoin-core-dev
1212016-07-19T09:12:21 *** NicLin has quit IRC
1222016-07-19T09:12:37 *** pedrobranco has quit IRC
1232016-07-19T09:12:51 *** pedrobranco has joined #bitcoin-core-dev
1242016-07-19T09:12:51 *** go1111111 has quit IRC
1252016-07-19T09:16:03 *** jtimon has joined #bitcoin-core-dev
1262016-07-19T09:24:56 *** foo1 has quit IRC
1272016-07-19T09:27:39 *** go1111111 has joined #bitcoin-core-dev
1282016-07-19T09:30:12 *** jtimon has quit IRC
1292016-07-19T09:30:12 *** pedrobranco has quit IRC
1302016-07-19T09:30:35 *** pedrobranco has joined #bitcoin-core-dev
1312016-07-19T09:33:06 *** pedrobra_ has joined #bitcoin-core-dev
1322016-07-19T09:35:58 *** pedrobranco has quit IRC
1332016-07-19T09:57:22 <GitHub114> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/37269105c881...a07c8a032c0d
1342016-07-19T09:57:22 <GitHub114> bitcoin/0.13 df85463 Pieter Wuille: Some 0.13 release notes about p2p changes
1352016-07-19T09:57:23 <GitHub99> [bitcoin] laanwj closed pull request #8361: Some 0.13 release notes about p2p changes (0.13...relnotes-0.13) https://github.com/bitcoin/bitcoin/pull/8361
1362016-07-19T09:57:23 <GitHub114> bitcoin/0.13 a07c8a0 Wladimir J. van der Laan: Merge #8361: Some 0.13 release notes about p2p changes...
1372016-07-19T10:09:35 <GitHub70> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e3557b8e363...ca7550e128a3
1382016-07-19T10:09:35 <GitHub70> bitcoin/master 2c06bae Suhas Daftuar: Rename "block cost" to "block weight"
1392016-07-19T10:09:36 <GitHub70> bitcoin/master ca7550e Wladimir J. van der Laan: Merge #8363: Rename "block cost" to "block weight"...
1402016-07-19T10:09:50 <GitHub19> [bitcoin] laanwj closed pull request #8363: Rename "block cost" to "block weight" (master...cost-to-weight) https://github.com/bitcoin/bitcoin/pull/8363
1412016-07-19T10:10:38 *** nohup has quit IRC
1422016-07-19T10:10:52 <GitHub24> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/fca1a415cec6b7655448ce8b30778784ab4c181e
1432016-07-19T10:10:52 <GitHub24> bitcoin/0.13 fca1a41 Suhas Daftuar: Rename "block cost" to "block weight"...
1442016-07-19T10:13:29 <GitHub123> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca7550e128a3...045106b4f13c
1452016-07-19T10:13:29 <GitHub123> bitcoin/master a4f137f Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
1462016-07-19T10:13:30 <GitHub123> bitcoin/master 045106b Wladimir J. van der Laan: Merge #8367: [Wallet] Ensure <0.13 clients can't open HD wallets...
1472016-07-19T10:13:43 <GitHub41> [bitcoin] laanwj closed pull request #8367: [Wallet] Ensure <0.13 clients can't open HD wallets (master...2016/07/hd_minversion_014) https://github.com/bitcoin/bitcoin/pull/8367
1482016-07-19T10:14:13 *** Samdney has joined #bitcoin-core-dev
1492016-07-19T10:14:28 <GitHub48> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/fca1a415cec6...24f117ef05f5
1502016-07-19T10:14:28 <GitHub48> bitcoin/0.13 3b38a6a Jonas Schnelli: [Wallet] Ensure <0.13 clients can't open HD wallets
1512016-07-19T10:14:28 <GitHub68> [bitcoin] laanwj closed pull request #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets (0.13...2016/07/hd_minversion) https://github.com/bitcoin/bitcoin/pull/8366
1522016-07-19T10:14:29 <GitHub48> bitcoin/0.13 24f117e Wladimir J. van der Laan: Merge #8366: [0.13] [Wallet] Ensure <0.13 clients can't open HD wallets...
1532016-07-19T10:16:27 *** pedrobra_ has quit IRC
1542016-07-19T10:18:21 <MarcoFalke> rc1 time? *.*
1552016-07-19T10:18:56 *** pedrobranco has joined #bitcoin-core-dev
1562016-07-19T10:19:04 <MarcoFalke> wait what about 8362?
1572016-07-19T10:22:32 *** MarcoFalke has quit IRC
1582016-07-19T10:22:43 *** MarcoFalke has joined #bitcoin-core-dev
1592016-07-19T10:23:47 *** Guyver2 has quit IRC
1602016-07-19T10:24:36 <GitHub184> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/ec8f5fc8b5f68ddf7fed0d74a5ec82e6b03f7f92
1612016-07-19T10:24:36 <GitHub184> bitcoin/0.13 ec8f5fc Wladimir J. van der Laan: doc: Add list of pulls and authors to release notes
1622016-07-19T10:25:26 <GitHub184> [bitcoin] laanwj pushed 2 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/ec8f5fc8b5f6...d6bb231a9fa9
1632016-07-19T10:25:26 <GitHub184> bitcoin/0.13 ded0599 Wladimir J. van der Laan: doc: Add a few items to release notes...
1642016-07-19T10:25:26 <GitHub126> [bitcoin] laanwj closed pull request #8360: doc: Add a few items to release notes (0.13...2016_07_release_notes) https://github.com/bitcoin/bitcoin/pull/8360
1652016-07-19T10:25:27 <GitHub184> bitcoin/0.13 d6bb231 Wladimir J. van der Laan: Merge #8360: doc: Add a few items to release notes...
1662016-07-19T10:36:58 <wumpus> going to tag rc1 in a bit
1672016-07-19T10:37:58 <wumpus> anything that really still needs to go in? last chance
1682016-07-19T10:39:12 <jonasschnelli> wumpus: what about TheBlueMatts concern about FEATURE_HD?
1692016-07-19T10:39:26 *** fengling has quit IRC
1702016-07-19T10:39:31 <jonasschnelli> I have worked out a PR that can support a set of strings (features).
1712016-07-19T10:39:34 <wumpus> I don't see it as a large problem
1722016-07-19T10:39:38 <jonasschnelli> But probably to late for 0.13
1732016-07-19T10:39:57 <sipa> i think string-based features can wait until later
1742016-07-19T10:40:05 <wumpus> over time, HD wallets are probably going to be the default anyway, and the at-least-0.13 requirement is not a big issue
1752016-07-19T10:40:19 <jonasschnelli> The only concern is, that if we introduce another feature (lets say KEY_ORIGIN_FLAGS [there is a PR]) that this feature would require 0.13 even if it would be compatible with < 0.13.
1762016-07-19T10:40:20 <wumpus> I think how you handled the transfer period is fine
1772016-07-19T10:40:27 <MarcoFalke> Jup, we can just make -upgradewallet take care of this
1782016-07-19T10:40:33 <MarcoFalke> There is plenty of time till .14
1792016-07-19T10:40:36 <wumpus> jonasschnelli: I don't see that as a big problem honestly
1802016-07-19T10:40:42 <jonasschnelli> Yes. Agree.
1812016-07-19T10:40:55 <jonasschnelli> But let me PR the set-of-strings feature work for later usage
1822016-07-19T10:40:58 <wumpus> yes, we need a better feature system for the wallet, but it's not urgent
1832016-07-19T10:41:06 <sipa> string-based features is a much more clean solution... but the current one works fine as long as versioning is completely serial
1842016-07-19T10:41:26 <jonasschnelli> Yes. The optional HDness made it a bit more complex.
1852016-07-19T10:41:29 <wumpus> I don't see the-next-feature-will-require-at-least-0.13 as a problem, as that'd likely be the case anyway
1862016-07-19T10:41:34 <wumpus> it doesn't force actually using HD does it?
1872016-07-19T10:41:48 <sipa> indeed
1882016-07-19T10:42:00 <MarcoFalke> Also we don't do feature backports, so it should be easy
1892016-07-19T10:42:06 <wumpus> right
1902016-07-19T10:42:14 <sipa> wumpus: there is still time for release notes, right?
1912016-07-19T10:42:18 <jonasschnelli> If we add another feature, we cannot go bellow FEATURE_HD. So all new features will require HD support.
1922016-07-19T10:42:25 <wumpus> #8362 is lacking a rationale: what bug is fixed there?
1932016-07-19T10:42:28 <jonasschnelli> We could no longer add features that run with <0.13
1942016-07-19T10:42:35 <wumpus> sipa: yes, there is no need to do that before rc1
1952016-07-19T10:43:30 <wumpus> jonasschnelli: they require hd *support*, they don't require the wallet to be hd
1962016-07-19T10:43:45 <wumpus> jonasschnelli: the latter I would see as a problem, but not this
1972016-07-19T10:43:55 <jonasschnelli> Sure. The point is only, that we can't add optional features that would run on 0.12 and below.
1982016-07-19T10:44:17 <MarcoFalke> We don't do that?
1992016-07-19T10:44:19 <wumpus> we could. Just don't increase the wallet min version?
2002016-07-19T10:44:19 <sipa> i'd also like to see 8365 in... but it needs more review/discussion than we can do at this point, i'm afraid
2012016-07-19T10:44:42 <jonasschnelli> wumpus: Yes. But you would need to increase it over FEATURE_HD.
2022016-07-19T10:44:57 <MarcoFalke> I guess 8365 is not a blocker for rc1?
2032016-07-19T10:44:58 <wumpus> jonasschnelli: why?
2042016-07-19T10:45:38 <wumpus> you can give it any value, depending on the first version that would be able to cope with it. But aren't features always introduced in the future?
2052016-07-19T10:45:43 *** pedrobranco has quit IRC
2062016-07-19T10:45:49 <sipa> MarcoFalke: i think we've neglected fixing #8079 for some reason, and i don't like needing to say now "sorry, we didn't care enough to fix this bug we accidentally introduced"
2072016-07-19T10:45:51 * jonasschnelli is caught in the corner
2082016-07-19T10:46:12 <jonasschnelli> I think your right..
2092016-07-19T10:46:16 *** pedrobranco has joined #bitcoin-core-dev
2102016-07-19T10:47:03 <jonasschnelli> Yes. Its not a problem. Indeed.
2112016-07-19T10:47:10 <wumpus> phew :)
2122016-07-19T10:47:21 <wumpus> we shouldn't add any new blockers for rc1
2132016-07-19T10:47:30 <wumpus> I'm sure rc2 will be necessary anyhow
2142016-07-19T10:47:36 <wumpus> major releases always have long rc cycles
2152016-07-19T10:47:46 <wumpus> the sooner we start testing, the better
2162016-07-19T10:48:03 <jonasschnelli> Yes.
2172016-07-19T10:48:08 <MarcoFalke> agree. There is so much to test
2182016-07-19T10:48:11 <wumpus> unless there is a really a critical this-will-crash-everything or security issue, of course
2192016-07-19T10:48:43 <MarcoFalke> Neither 8365 nor 8362 are critical
2202016-07-19T10:50:30 *** pedrobranco has quit IRC
2212016-07-19T10:50:54 <sipa> i think 8362 has actually 0 effect in practice
2222016-07-19T10:51:33 <sipa> as GBT does not report the coinbase's sigops, and the 'generateblocks' call ignores it
2232016-07-19T10:53:15 *** sdaftuar_ has joined #bitcoin-core-dev
2242016-07-19T10:53:43 <MarcoFalke> ERROR: src/leveldb is not a subtree
2252016-07-19T10:53:46 <MarcoFalke> https://travis-ci.org/bitcoin/bitcoin/jobs/145713130
2262016-07-19T10:53:54 *** mn3monic has joined #bitcoin-core-dev
2272016-07-19T10:54:31 <MarcoFalke> weird
2282016-07-19T10:58:21 <wumpus> MarcoFalke: travis issue or repository issue?
2292016-07-19T10:58:36 <MarcoFalke> Likely a travis issue
2302016-07-19T10:59:20 <wumpus> this is git-subtree-check.sh failing on something?
2312016-07-19T11:01:47 <wumpus> * [new tag] v0.13.0rc1 -> v0.13.0rc1
2322016-07-19T11:03:56 <sipa> $ ./contrib/devtools/git-subtree-check.sh src/leveldb
2332016-07-19T11:03:56 <sipa> src/leveldb in HEAD was last updated to upstream commit 20ca81f08fb7fa108923a091668e447dcf5c6b9d (tree 1c185cba2ddcb6a77ece1094bc22aea072db84d1)
2342016-07-19T11:03:59 <sipa> src/leveldb in HEAD currently refers to tree 1c185cba2ddcb6a77ece1094bc22aea072db84d1
2352016-07-19T11:04:02 <sipa> GOOD
2362016-07-19T11:04:45 *** NicLin has joined #bitcoin-core-dev
2372016-07-19T11:05:19 *** Guyver2 has joined #bitcoin-core-dev
2382016-07-19T11:09:46 * sipa dusts off his gitian skills
2392016-07-19T11:12:24 * MarcoFalke googles "release process bitcoin" and copies the commands
2402016-07-19T11:13:26 <sipa> should i rebuild base image?
2412016-07-19T11:14:22 *** Evel-Knievel has quit IRC
2422016-07-19T11:14:49 <MarcoFalke> Gitian should handle this?
2432016-07-19T11:14:56 <jonasschnelli> Not sure.
2442016-07-19T11:15:27 <jonasschnelli> When did we update to Trusty? I guess sipa hasn't used gitian since the 0.12 release. :)
2452016-07-19T11:15:35 <sipa> i have a trusty image already
2462016-07-19T11:15:37 <sipa> but it's old
2472016-07-19T11:15:42 <MarcoFalke> Mine is from Dec 13
2482016-07-19T11:15:43 <jonasschnelli> Give it a try. :)
2492016-07-19T11:15:43 <sipa> i assume there have been point releases?
2502016-07-19T11:15:49 <sipa> already deleted the old one
2512016-07-19T11:16:12 <jonasschnelli> Jan 6 2016 base-trusty-amd64.qcow2
2522016-07-19T11:16:33 <sipa> hmm qcow2
2532016-07-19T11:16:38 <sipa> mine does not have any extension
2542016-07-19T11:17:41 <jonasschnelli> No idea why... :)
2552016-07-19T11:17:54 <jonasschnelli> https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
2562016-07-19T11:21:59 <sipa> do i need the mac thing?
2572016-07-19T11:22:56 <jonasschnelli> Yes.
2582016-07-19T11:23:03 <jonasschnelli> sipa: I'll open you an URL.
2592016-07-19T11:23:38 <jonasschnelli> https://bitcoin.jonasschnelli.ch/MacOSX10.11.sdk.tar.gz
2602016-07-19T11:23:53 <jonasschnelli> (don't tell Tim Cook)
2612016-07-19T11:24:11 *** molz has quit IRC
2622016-07-19T11:24:53 *** Guyver2 has quit IRC
2632016-07-19T11:25:32 *** achow101 has joined #bitcoin-core-dev
2642016-07-19T11:27:08 <sipa> should i use lxc or not?
2652016-07-19T11:27:29 *** pedrobranco has joined #bitcoin-core-dev
2662016-07-19T11:27:49 <GitHub180> [bitcoin] jonasschnelli opened pull request #8369: [FOR LATER USE][WIP][Wallet]Â add support for a flexible "set of features" (master...2016/07/wallet_features) https://github.com/bitcoin/bitcoin/pull/8369
2672016-07-19T11:27:58 <jonasschnelli> sipa: I use KVM. Never got warm with LXC
2682016-07-19T11:28:18 <achow101> yay gitian building
2692016-07-19T11:28:29 *** AaronvanW has quit IRC
2702016-07-19T11:28:57 <sipa> jonasschnelli: the gitian-building.md guide says use lxn
2712016-07-19T11:28:59 <sipa> lxc
2722016-07-19T11:29:13 <jonasschnelli> Its because wumpus uses LXC and write the doc. :)
2732016-07-19T11:29:16 <jonasschnelli> *wrote
2742016-07-19T11:29:19 <sipa> ah
2752016-07-19T11:29:31 <jonasschnelli> But I think its good if we have build of both worlds.
2762016-07-19T11:29:38 <jonasschnelli> *builds
2772016-07-19T11:29:39 <sipa> so it should work and result in identical builds?
2782016-07-19T11:29:48 <jonasschnelli> Yes. (I hope).
2792016-07-19T11:29:56 <jonasschnelli> I always uses KVM and had the same hashes
2802016-07-19T11:31:14 *** AaronvanW has joined #bitcoin-core-dev
2812016-07-19T11:31:14 *** AaronvanW has joined #bitcoin-core-dev
2822016-07-19T11:32:14 <jonasschnelli> MarcoFalke: what do I need to pass to gbuild to use parallelism? I now pass "-j2 --memory 3000" (had crashed with -j5)... but a tripple build takes >80mins.
2832016-07-19T11:32:19 <wumpus> yes, KVM and LXC both work, and yield indentical results
2842016-07-19T11:32:24 <MarcoFalke> j is default 2
2852016-07-19T11:32:46 <jonasschnelli> Okay. I uses -j5 without -memory 3000 in the past... maybe this was the issue.
2862016-07-19T11:32:54 <jonasschnelli> There are no other arguments?
2872016-07-19T11:32:58 <wumpus> I use LXC because I don't like nesting qemus
2882016-07-19T11:32:59 <MarcoFalke> but memory default is 2000, I think
2892016-07-19T11:33:14 <MarcoFalke> ./gbuild -help
2902016-07-19T11:33:21 <wumpus> I have KVM on an older machine though and last time the gitian build just worked with it
2912016-07-19T11:33:50 <jonasschnelli> We should really extend gitian-builder to support ECDSA and add a binary verified to Qt
2922016-07-19T11:34:09 <wumpus> LXC is somewhat harder to set up though
2932016-07-19T11:34:15 <jonasschnelli> *binary verifier
2942016-07-19T11:34:17 <MarcoFalke> wumpus: Why nest. Run it on metal?
2952016-07-19T11:34:25 <jonasschnelli> metal?
2962016-07-19T11:34:34 <MarcoFalke> no virtual cpu
2972016-07-19T11:34:38 <MarcoFalke> the actual hardware
2982016-07-19T11:35:04 <jonasschnelli> ah
2992016-07-19T11:35:05 <wumpus> MarcoFalke: meh, too much bother - the big machine i have runs tons of VMs, and I don't really want to install anything in the top level
3002016-07-19T11:35:59 *** fengling has joined #bitcoin-core-dev
3012016-07-19T11:37:02 <MarcoFalke> I wonder how long it would take on my machine if I was using the nested approach
3022016-07-19T11:37:28 <wumpus> (of course it would be possible to dual-boot it into something else, for example with an external harddisk, but that means shutting down all other things)
3032016-07-19T11:37:42 <sipa> wumpus: you don't use VirtualBox?
3042016-07-19T11:38:32 <wumpus> I use virsh (from libvirt), inside there I have a debian VM, and inside that runs LXC with the builder
3052016-07-19T11:38:32 <MarcoFalke> But I always populate caches, so it runs quick on the actual tag
3062016-07-19T11:39:24 <wumpus> virsh is a bit unwieldy to set up, but nice and efficient if you have lots of VM instances
3072016-07-19T11:39:36 <wumpus> it doesn't have a nice user interface like virtualbox
3082016-07-19T11:40:46 *** fengling has quit IRC
3092016-07-19T11:40:52 <achow101> what about vmware?
3102016-07-19T11:41:11 *** pedrobranco has quit IRC
3112016-07-19T11:41:22 <jonasschnelli> achow101: vmware, who knows whats running inside the VM then... :-)
3122016-07-19T11:41:29 <jonasschnelli> (or on the host)
3132016-07-19T11:42:08 <jonasschnelli> But I have to admit, I'm also using VMWare on my local mac. But for gitian it won't work I guess (at least not with significant fiddling).
3142016-07-19T11:42:15 <wumpus> I don't know anything about vmware, last time I used it must be some time in the 90's :)
3152016-07-19T11:43:16 <wumpus> but in principle you can run LXC inside *any* kind of virtualization
3162016-07-19T11:44:15 *** cryptapus has joined #bitcoin-core-dev
3172016-07-19T11:44:20 <sipa> ah, kvm does not work inside virtualbox?
3182016-07-19T11:44:35 <wumpus> as it simply uses linux' namespacing to keep processes contained, instead of virtualizing actual hardware, it doesn't need any special CPU bits either
3192016-07-19T11:44:38 <jonasschnelli> sipa: no.
3202016-07-19T11:44:40 *** jtimon has joined #bitcoin-core-dev
3212016-07-19T11:44:42 <jonasschnelli> But in VM ware
3222016-07-19T11:44:55 <wumpus> sipa: I don't think so; or only with special cpus
3232016-07-19T11:44:58 <sipa> jonasschnelli: knowing that would have saved me a lot of time :)
3242016-07-19T11:44:59 <jonasschnelli> sipa: AFAIK VirtualBox has no native KVM support
3252016-07-19T11:45:06 <jonasschnelli> sipa: you didn't asked. :)
3262016-07-19T11:45:15 <wumpus> there is something as 'nested virtualization' , but I have no idea what supports it
3272016-07-19T11:45:25 <sipa> i was just following the guide, and you said KVM worked fine :)
3282016-07-19T11:45:29 *** jtimon has quit IRC
3292016-07-19T11:45:50 <wumpus> you can also disable the CPU virtualization completely and use x86 emulation, but then compiling will likely take a year or so :-)
3302016-07-19T11:45:59 <jonasschnelli> sipa: I just run gitian-builder on my host
3312016-07-19T11:46:07 *** Evel-Knievel has joined #bitcoin-core-dev
3322016-07-19T11:46:27 <jonasschnelli> I don't care about running in host mode because it's in a remote servercenter anyways.
3332016-07-19T11:47:19 *** pedrobranco has joined #bitcoin-core-dev
3342016-07-19T11:48:37 <achow101> if anyone cares, here's a script I made for gitian building: https://gist.github.com/achow101/1bdd85cd4934b61a373d
3352016-07-19T11:49:56 <jonasschnelli> achow101: nice. I won't publish mine. It's a hell of a mess!
3362016-07-19T11:50:08 <wumpus> yes it looks better than my set of hacks too :)
3372016-07-19T11:50:33 <jonasschnelli> I had to add some html / apaxy hacks to get the html pages up: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
3382016-07-19T11:50:40 <jonasschnelli> Also it copies around the build.log, etc.
3392016-07-19T11:51:10 <jonasschnelli> achow101 looks pretty nice. You could also add support for building a PR and optional disable platforms...
3402016-07-19T11:51:19 <wumpus> especially copying the result immediately after the build can avoid a lot of annoyance, is my experience
3412016-07-19T11:52:19 <achow101> jonasschnelli: how does building from a PR work?
3422016-07-19T11:52:56 <wumpus> my script does automatically copy files which should be uploaded (and rename where necessary), and creates a SHA256SUMS. Although this will need to be updated for 0.13, with the new naming for the linux files, thinking of it.
3432016-07-19T11:53:05 <jonasschnelli> achow101: my scripts does something like: /bin/gbuild "+gbuildadd+" --commit signature="+VERSIONCOMMIT+"
3442016-07-19T11:53:26 <sipa> wumpus: ah, yes, i'll need to update my script as well...
3452016-07-19T11:53:27 <jonasschnelli> stuff like: --url bitcoin="+giturl+"
3462016-07-19T11:53:37 * sipa thinks we should ship such a script inside contrib/ ...
3472016-07-19T11:53:46 <jonasschnelli> *me agrees with sipa
3482016-07-19T11:53:51 * jonasschnelli looks over to achow101
3492016-07-19T11:54:18 <wumpus> yes possibly, mine is too hacky and specific to my setup to upload though
3502016-07-19T11:54:36 <wumpus> e.g. I don't have the GPG keys on the machine that builds, for example
3512016-07-19T11:54:55 *** harrymm has quit IRC
3522016-07-19T11:55:12 <jonasschnelli> achow101: also check: https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#building-an-alternative-repository
3532016-07-19T11:56:10 <achow101> jonasschnelli: thanks.
3542016-07-19T11:56:11 <wumpus> the rest is pretty much just copy/paste from the release notes. So at some point the script needs to be customized that much before it's useful, that providing an example isn't much more useful than just pointing at the release notes :)
3552016-07-19T11:56:58 <wumpus> yes --url bitcoin=${URI} --commit bitcoin=${COMMIT} can be very useful. You can also use local paths.
3562016-07-19T11:59:31 *** pedrobranco has quit IRC
3572016-07-19T12:03:06 *** pedrobranco has joined #bitcoin-core-dev
3582016-07-19T12:06:19 *** YOU-JI has joined #bitcoin-core-dev
3592016-07-19T12:08:51 <jonasschnelli> linux build complete: hashes to compare: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
3602016-07-19T12:09:06 <jonasschnelli> 19499e5a569d5d8685a043bf3e5cf9d34450733333295b636af84d7a2589d881 bitcoin-0.13.0-x86_64-linux-gnu.tar.gz
3612016-07-19T12:09:15 <jonasschnelli> all: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/bitcoin-linux-0.13-build.assert
3622016-07-19T12:09:59 <wumpus> all match with my build, even the ARM ones
3632016-07-19T12:15:24 <wumpus> windows build: http://www.hastebin.com/luwelodopa
3642016-07-19T12:19:02 *** jannes has joined #bitcoin-core-dev
3652016-07-19T12:20:44 <achow101> how big should I make -j and -m to make it build faster?
3662016-07-19T12:22:08 <sipa> -j: not more than you have cpu cores
3672016-07-19T12:22:22 <sipa> -m: something like 1500 times the number you pass to j
3682016-07-19T12:22:37 <sipa> but -m also not more than the physical memory you have in your vm
3692016-07-19T12:26:55 *** pedrobranco has quit IRC
3702016-07-19T12:28:49 <kinlo> -j should be a bit higher then cores right? you usually end up with processes waiting for disk and not utilizing cpu, so oversubscribing a bit should increase speed
3712016-07-19T12:29:41 <sipa> i've tried various numbers between 5 and 10 (i have 4 core, 8 threads), but it doesn't seem to matter much for overall compilation speed
3722016-07-19T12:29:51 *** pedrobranco has joined #bitcoin-core-dev
3732016-07-19T12:31:22 <wumpus> kinlo: I usually use cores+1 for that reason, but haven't benchmarked wether it is any faster
3742016-07-19T12:32:02 <sipa> my gitian build scripts seems to use -j 4 -m 8000
3752016-07-19T12:32:11 <sipa> but no idea how those numbers came about
3762016-07-19T12:32:23 <wumpus> compiling bitcoin is quite CPU intensive, so the i/o overhead may be very little in comparison, it may not be the same for every project
3772016-07-19T12:33:24 <wumpus> e.g. for a project such as tor with tons of C files that compile very quickly, I think using -j >> cores will achieve more, as all those gcc's spend a relatively large part of their lifespan accessing disk
3782016-07-19T12:35:29 <kinlo> I usually only compile the kernel, noticed speedups there but indeed, makes sense...
3792016-07-19T12:36:27 <wumpus> kernel is similar
3802016-07-19T12:37:28 <achow101> I set my -j to double the cores I have. I don't know whether that makes a significant difference though
3812016-07-19T12:37:28 *** fengling has joined #bitcoin-core-dev
3822016-07-19T12:42:26 *** fengling has quit IRC
3832016-07-19T12:45:18 <jonasschnelli> match with wumpuses windows hashes: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/bitcoin-win-0.13-build.assert
3842016-07-19T12:47:52 *** pedrobranco has quit IRC
3852016-07-19T12:51:28 *** pedrobranco has joined #bitcoin-core-dev
3862016-07-19T13:01:55 *** sdaftuar_ has quit IRC
3872016-07-19T13:05:50 *** kadoban has joined #bitcoin-core-dev
3882016-07-19T13:19:32 *** face_ has joined #bitcoin-core-dev
3892016-07-19T13:21:33 *** Guyver2 has joined #bitcoin-core-dev
3902016-07-19T13:22:06 *** NicLin has quit IRC
3912016-07-19T13:28:42 *** molz has joined #bitcoin-core-dev
3922016-07-19T13:31:29 <achow101> linux build finally done. Matches wumpus and jonasschnelli hashes
3932016-07-19T13:32:09 <jonasschnelli> Nice!
3942016-07-19T13:32:17 <sipa> still going here...
3952016-07-19T13:35:30 *** pedrobranco has quit IRC
3962016-07-19T13:38:50 *** pedrobranco has joined #bitcoin-core-dev
3972016-07-19T13:39:10 *** fengling has joined #bitcoin-core-dev
3982016-07-19T13:41:05 <btcdrak> isnt -m deprecated and ignored now?
3992016-07-19T13:41:23 <sipa> on lxc it has no effect i think
4002016-07-19T13:41:47 <btcdrak> according to man pages it's ignored
4012016-07-19T13:41:54 <btcdrak> (GNU Make 4.0)
4022016-07-19T13:42:04 <sipa> it's a parameter to gbuild
4032016-07-19T13:42:09 <btcdrak> ah
4042016-07-19T13:44:06 *** fengling has quit IRC
4052016-07-19T13:48:21 *** YOU-JI has quit IRC
4062016-07-19T13:57:46 <GitHub182> [bitcoin] jonasschnelli opened pull request #8371: [Qt] Add out-of-sync modal info layer (master...2016/07/UI-out-of-sync) https://github.com/bitcoin/bitcoin/pull/8371
4072016-07-19T13:58:36 <MarcoFalke> looks neat
4082016-07-19T14:00:42 *** NicLin has joined #bitcoin-core-dev
4092016-07-19T14:01:28 <jonasschnelli> would be cool if this modal info layer would have two sliders: one for dbcache mem, one for CPU (-par)
4102016-07-19T14:03:37 <MarcoFalke> how come the mac mismatches?
4112016-07-19T14:04:00 <MarcoFalke> https://github.com/bitcoin-core/gitian.sigs/pull/359#issue-166339496
4122016-07-19T14:05:12 <MarcoFalke> three builders, three different bitcoin-0.13.0-osx-unsigned.tar.gz
4132016-07-19T14:05:57 <achow101> that's a problem isn't it
4142016-07-19T14:07:17 <jonasschnelli> hmm..
4152016-07-19T14:08:35 <jonasschnelli> Yes. OSX build are non-deterministic...
4162016-07-19T14:08:49 * jonasschnelli ringing the cfields alarm bell
4172016-07-19T14:10:03 <jonasschnelli> Hmm.. on my end I have some strange Qt5.5 packages: https://github.com/bitcoin-core/gitian.sigs/blob/master/0.13.0rc1-osx-unsigned/jonasschnelli/bitcoin-osx-0.13-build.assert#L808
4182016-07-19T14:10:14 <jonasschnelli> maybe issue with the cache
4192016-07-19T14:11:55 <MarcoFalke> Is it due to my depends faketime patch?
4202016-07-19T14:12:05 *** NicLin has quit IRC
4212016-07-19T14:14:18 <jonasschnelli> MarcoFalke: could be. But I think more likely my Qt5.6 PKGConfig hacking patch
4222016-07-19T14:15:12 *** NicLin has joined #bitcoin-core-dev
4232016-07-19T14:21:13 <MarcoFalke> but bdb is a mismatch as well? You didn't fiddle with this
4242016-07-19T14:24:08 *** NicLin has quit IRC
4252016-07-19T14:25:05 <jonasschnelli> I guess mismatches are okay in the packages...
4262016-07-19T14:27:42 <MarcoFalke> right
4272016-07-19T14:30:49 *** haakonn has quit IRC
4282016-07-19T14:30:52 *** so has quit IRC
4292016-07-19T14:30:56 *** trippysalmon has quit IRC
4302016-07-19T14:30:57 *** limpkin has quit IRC
4312016-07-19T14:30:58 *** dirtynewshoes has quit IRC
4322016-07-19T14:30:58 *** helo has quit IRC
4332016-07-19T14:30:59 *** Guyver2 has quit IRC
4342016-07-19T14:31:00 *** gribble has quit IRC
4352016-07-19T14:31:02 *** Cory has quit IRC
4362016-07-19T14:31:04 *** BonyM has quit IRC
4372016-07-19T14:31:06 *** helo has joined #bitcoin-core-dev
4382016-07-19T14:31:07 *** btcdrak has quit IRC
4392016-07-19T14:31:08 *** ghtdak has quit IRC
4402016-07-19T14:31:11 *** tucenaber has quit IRC
4412016-07-19T14:31:17 *** Evel-Knievel has quit IRC
4422016-07-19T14:31:19 *** wallet42 has quit IRC
4432016-07-19T14:31:21 *** zxzzt has quit IRC
4442016-07-19T14:31:24 *** sanada has quit IRC
4452016-07-19T14:31:29 *** pedrobranco has quit IRC
4462016-07-19T14:31:29 *** Arnavion has quit IRC
4472016-07-19T14:31:40 *** pedrobranco has joined #bitcoin-core-dev
4482016-07-19T14:31:40 *** isis has quit IRC
4492016-07-19T14:31:43 *** tucenaber has joined #bitcoin-core-dev
4502016-07-19T14:31:43 *** tucenaber has joined #bitcoin-core-dev
4512016-07-19T14:31:44 *** kanzure has quit IRC
4522016-07-19T14:31:46 *** LeMiner has quit IRC
4532016-07-19T14:31:52 *** binns has quit IRC
4542016-07-19T14:31:55 *** sanada has joined #bitcoin-core-dev
4552016-07-19T14:31:56 *** squidicuz has quit IRC
4562016-07-19T14:31:57 *** zxzzt has joined #bitcoin-core-dev
4572016-07-19T14:32:02 *** molz has quit IRC
4582016-07-19T14:32:03 *** BonyM has joined #bitcoin-core-dev
4592016-07-19T14:32:04 *** jouke has quit IRC
4602016-07-19T14:32:07 *** michagogo has quit IRC
4612016-07-19T14:32:08 *** zmanian__ has quit IRC
4622016-07-19T14:32:10 *** Sosumi has quit IRC
4632016-07-19T14:32:10 *** Guyver2 has joined #bitcoin-core-dev
4642016-07-19T14:32:11 *** CodeShark has quit IRC
4652016-07-19T14:32:16 *** jouke has joined #bitcoin-core-dev
4662016-07-19T14:32:21 *** ghtdak has joined #bitcoin-core-dev
4672016-07-19T14:32:22 *** Evel-Knievel has joined #bitcoin-core-dev
4682016-07-19T14:32:26 *** sanada has quit IRC
4692016-07-19T14:32:32 *** BonyM has quit IRC
4702016-07-19T14:32:32 *** Guyver2 has quit IRC
4712016-07-19T14:32:34 *** NicolasDorier has quit IRC
4722016-07-19T14:32:37 *** Arnavion has joined #bitcoin-core-dev
4732016-07-19T14:32:45 *** Arnavion has quit IRC
4742016-07-19T14:32:55 *** kanzure has joined #bitcoin-core-dev
4752016-07-19T14:32:56 *** sanada has joined #bitcoin-core-dev
4762016-07-19T14:33:00 *** Arnavion has joined #bitcoin-core-dev
4772016-07-19T14:33:00 *** binns has joined #bitcoin-core-dev
4782016-07-19T14:33:02 *** PRab has quit IRC
4792016-07-19T14:33:03 *** squidicuz has joined #bitcoin-core-dev
4802016-07-19T14:33:17 *** Guyver2 has joined #bitcoin-core-dev
4812016-07-19T14:33:19 *** pedrobranco has quit IRC
4822016-07-19T14:33:33 *** AtashiCon has quit IRC
4832016-07-19T14:33:39 *** CodeShark has joined #bitcoin-core-dev
4842016-07-19T14:33:40 *** dirtynewshoes has joined #bitcoin-core-dev
4852016-07-19T14:33:57 *** AtashiCon has joined #bitcoin-core-dev
4862016-07-19T14:34:10 *** zmanian__ has joined #bitcoin-core-dev
4872016-07-19T14:34:18 *** LeMiner has joined #bitcoin-core-dev
4882016-07-19T14:34:18 *** limpkin has joined #bitcoin-core-dev
4892016-07-19T14:34:19 *** wallet42 has joined #bitcoin-core-dev
4902016-07-19T14:34:23 *** laurentmt has joined #bitcoin-core-dev
4912016-07-19T14:34:25 *** NicolasDorier has joined #bitcoin-core-dev
4922016-07-19T14:34:29 *** btcdrak has joined #bitcoin-core-dev
4932016-07-19T14:34:35 *** Cory has joined #bitcoin-core-dev
4942016-07-19T14:35:22 *** pedrobranco has joined #bitcoin-core-dev
4952016-07-19T14:35:38 *** BonyM has joined #bitcoin-core-dev
4962016-07-19T14:36:02 *** michagogo has joined #bitcoin-core-dev
4972016-07-19T14:36:42 *** MarcoFalke has left #bitcoin-core-dev
4982016-07-19T14:36:44 *** MarcoFalke has joined #bitcoin-core-dev
4992016-07-19T14:36:46 *** trippysalmon has joined #bitcoin-core-dev
5002016-07-19T14:36:48 *** gribble has joined #bitcoin-core-dev
5012016-07-19T14:37:04 *** pedrobranco has quit IRC
5022016-07-19T14:37:10 *** pedrobranco has joined #bitcoin-core-dev
5032016-07-19T14:39:42 *** moli has joined #bitcoin-core-dev
5042016-07-19T14:40:39 *** fengling has joined #bitcoin-core-dev
5052016-07-19T14:43:26 *** isis has joined #bitcoin-core-dev
5062016-07-19T14:45:26 *** fengling has quit IRC
5072016-07-19T14:45:34 *** laurentmt has quit IRC
5082016-07-19T14:51:14 *** alpalp has joined #bitcoin-core-dev
5092016-07-19T14:56:35 <achow101> Also have an OSX mismatch
5102016-07-19T14:58:05 *** alpalp has left #bitcoin-core-dev
5112016-07-19T14:58:59 *** NicLin has joined #bitcoin-core-dev
5122016-07-19T14:59:07 <GitHub185> [bitcoin] UdjinM6 opened pull request #8372: Fix AddRef() usage for CNode (master...fixNodeRefCount) https://github.com/bitcoin/bitcoin/pull/8372
5132016-07-19T14:59:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5142016-07-19T15:06:33 *** Chris_Stewart_5 has quit IRC
5152016-07-19T15:09:44 *** NicLin has quit IRC
5162016-07-19T15:10:25 *** paveljanik has joined #bitcoin-core-dev
5172016-07-19T15:10:25 *** paveljanik has joined #bitcoin-core-dev
5182016-07-19T15:12:07 *** AtashiCon has quit IRC
5192016-07-19T15:19:13 *** AtashiCon has joined #bitcoin-core-dev
5202016-07-19T15:21:12 *** Sosumi has joined #bitcoin-core-dev
5212016-07-19T15:23:09 *** pedrobra_ has joined #bitcoin-core-dev
5222016-07-19T15:23:09 *** pedrobranco has quit IRC
5232016-07-19T15:24:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5242016-07-19T15:26:39 *** pedrobra_ has quit IRC
5252016-07-19T15:27:05 *** pedrobranco has joined #bitcoin-core-dev
5262016-07-19T15:31:15 *** so has joined #bitcoin-core-dev
5272016-07-19T15:33:09 *** pedrobranco has quit IRC
5282016-07-19T15:33:17 *** pedrobranco has joined #bitcoin-core-dev
5292016-07-19T15:33:22 *** haakonn has joined #bitcoin-core-dev
5302016-07-19T15:35:23 *** pedrobra_ has joined #bitcoin-core-dev
5312016-07-19T15:35:23 *** pedrobranco has quit IRC
5322016-07-19T15:38:52 *** pedrobra_ has quit IRC
5332016-07-19T15:40:17 *** pedrobranco has joined #bitcoin-core-dev
5342016-07-19T15:42:13 *** Guyver2 has quit IRC
5352016-07-19T15:42:15 *** fengling has joined #bitcoin-core-dev
5362016-07-19T15:44:13 *** harrymm has joined #bitcoin-core-dev
5372016-07-19T15:44:17 *** pedrobra_ has joined #bitcoin-core-dev
5382016-07-19T15:44:22 *** pedrobranco has quit IRC
5392016-07-19T15:47:06 *** fengling has quit IRC
5402016-07-19T15:47:34 *** pedrobranco has joined #bitcoin-core-dev
5412016-07-19T15:47:59 *** pedrobra_ has quit IRC
5422016-07-19T15:48:08 *** jiggalator has joined #bitcoin-core-dev
5432016-07-19T15:48:45 *** Samdney has quit IRC
5442016-07-19T15:49:47 *** pedrobranco has quit IRC
5452016-07-19T15:50:38 *** pedrobranco has joined #bitcoin-core-dev
5462016-07-19T15:59:08 *** jannes has quit IRC
5472016-07-19T16:00:06 <michagogo> Could someone please paste a `git diff v0.12.1..v0.13.0rc1 doc/release-process.md`?
5482016-07-19T16:00:31 *** Chris_Stewart_5 has quit IRC
5492016-07-19T16:05:36 <MarcoFalke> http://pastebin.ubuntu.com/20051707/
5502016-07-19T16:06:30 *** jiggalator has quit IRC
5512016-07-19T16:07:52 *** MarcoFalke has left #bitcoin-core-dev
5522016-07-19T16:13:10 *** jiggalator has joined #bitcoin-core-dev
5532016-07-19T16:14:23 *** jiggalator has quit IRC
5542016-07-19T16:15:06 *** jiggalator has joined #bitcoin-core-dev
5552016-07-19T16:15:48 <wumpus> jonasschnelli: aren't the osx-unsigned always non-deterministic? cfields can confirm this, but I remember something like that
5562016-07-19T16:17:54 <cfields> wumpus: mm, i don't believe so.
5572016-07-19T16:18:02 <cfields> internet was down this morning, building now.
5582016-07-19T16:19:42 <gmaxwell> [semi-OT for this channel] https://www.reddit.com/r/Bitcoin/comments/4tly0n/blockstream_announces_an_open_patent_pledge_and/
5592016-07-19T16:20:17 *** MarcoFalke has joined #bitcoin-core-dev
5602016-07-19T16:21:13 <michagogo> MarcoFalke: thanks!
5612016-07-19T16:21:34 <cfields> wumpus / jonasschnelli / achow101: could one of you make your osx build results available for comparison? I'm building now, not sure exactly what to ask for in particular yet.
5622016-07-19T16:31:02 <jonasschnelli> cfields: https://bitcoin.jonasschnelli.ch/releasebuilds/v0.13.0rc1/
5632016-07-19T16:31:16 <jonasschnelli> And there are two signatures in the gitian sigs repo.
5642016-07-19T16:31:34 <jonasschnelli> Plus MarcoFalkes PR (also OS X sig)
5652016-07-19T16:32:28 <cfields> jonasschnelli: great, thanks.
5662016-07-19T16:41:20 *** pedrobra_ has joined #bitcoin-core-dev
5672016-07-19T16:41:23 *** pedrobranco has quit IRC
5682016-07-19T16:41:31 <michagogo> My builds are dubbing now
5692016-07-19T16:41:34 <michagogo> Running
5702016-07-19T16:41:44 <michagogo> (Qt rebuild :-( )
5712016-07-19T16:41:51 <achow101> cfields: everything I built is at https://github.com/achow101/bitcoin/releases/tag/v0.13.0rc1. sigs have been PR'ed
5722016-07-19T16:42:12 <cfields> achow101: thanks
5732016-07-19T16:43:41 *** fengling has joined #bitcoin-core-dev
5742016-07-19T16:44:40 *** Samdney has joined #bitcoin-core-dev
5752016-07-19T16:45:58 <cfields> jonasschnelli: hmm, our end-result osx binaries are the same, despite the different tarball hashes. I'm thinking it might just be timestamps in .tar's or so
5762016-07-19T16:45:58 <cfields> looking deeper now.
5772016-07-19T16:48:26 *** fengling has quit IRC
5782016-07-19T16:50:22 <cfields> whoops, nm. the osx64.tar.gz is the same for everyone.
5792016-07-19T16:53:12 *** cryptapus has quit IRC
5802016-07-19T16:53:14 <michagogo> Wait, we bumped the SDK?
5812016-07-19T16:53:24 <MarcoFalke> jup
5822016-07-19T16:53:32 <michagogo> :-/
5832016-07-19T16:54:09 * michagogo looks up details
5842016-07-19T16:55:13 <cfields> achow101 / jonasschnelli: either of you have the bitcoin-0.13.0-osx-unsigned.tar.gz available?
5852016-07-19T16:56:30 <achow101> cfields: is that file supposed to be produced? I don't see it
5862016-07-19T16:56:50 <cfields> achow101: your script probably automatically moves it to gitian/inputs
5872016-07-19T16:57:10 <michagogo> (I'm still not used to having things like my browser launch instantaneously...)
5882016-07-19T16:59:05 *** pedrobra_ has quit IRC
5892016-07-19T16:59:08 *** pedrobranco has joined #bitcoin-core-dev
5902016-07-19T16:59:19 <achow101> cfields: found it (I think) and uploaded to the page I linked earlier
5912016-07-19T16:59:27 <cfields> achow101: thanks
5922016-07-19T17:02:30 *** pedrobra_ has joined #bitcoin-core-dev
5932016-07-19T17:02:46 *** pedrobranco has quit IRC
5942016-07-19T17:05:56 *** pedrobranco has joined #bitcoin-core-dev
5952016-07-19T17:06:14 *** pedrobra_ has quit IRC
5962016-07-19T17:08:01 *** pedrobra_ has joined #bitcoin-core-dev
5972016-07-19T17:08:01 *** pedrobranco has quit IRC
5982016-07-19T17:10:08 <jl2012> to build for osx, should I just put the MacOSX10.11.sdk.tar.gz to the inputs directory?
5992016-07-19T17:10:19 <achow101> jl2012: yes
6002016-07-19T17:10:48 <jl2012> thanks
6012016-07-19T17:19:06 <sdaftuar> sipa: in #8365 i noticed you didn't change the rpc handlers to output the sigops-adjusted-vsize. was that intentional? looks like the mempool rpc's would do the right thing, but decoderawtransaction would report unadjusted vsize
6022016-07-19T17:20:31 <cfields> aha, found the difference
6032016-07-19T17:20:55 <cfields> looks like the DS_Store generator isn't deterministic somehow. mine doesn't match achow101's
6042016-07-19T17:21:34 <sipa> sdaftuar: it's intentional, but i'm not sure what the best approach is
6052016-07-19T17:21:37 <MarcoFalke> You can also run twice and it doesn't match
6062016-07-19T17:21:47 <achow101> cfields: so how is that fixed?
6072016-07-19T17:22:04 <cfields> achow101: looking now to see how/why it differs
6082016-07-19T17:22:40 <sdaftuar> sipa: seems like the cleanest thing would be for vsize to our policy-adjusted vsize, and for us to add a field to the output which is the transaction weight
6092016-07-19T17:23:09 <sipa> sdaftuar: the difficulty is determining the sigops...
6102016-07-19T17:23:15 <sipa> for wallet txn
6112016-07-19T17:23:28 <sipa> for raw transactions it's just impossuble
6122016-07-19T17:24:42 <sdaftuar> i was thinking that there's an ambiguity for things that are in our mempool, but right i see your point
6132016-07-19T17:25:44 <sipa> i'd rather try to make sure we never produce transactions ourselves for which it has an effect :)
6142016-07-19T17:27:30 <sdaftuar> yeah, that might work fine for the wallet code. i'm a little worried that the approach of having two different sizes we use, a policy size and an actual size, will be error prone in the future.
6152016-07-19T17:27:44 <sdaftuar> so i was just trying to go through and identify every usage to make sure it made sense
6162016-07-19T17:29:34 <sdaftuar> seems like if we do end up eventually changing bytespersigop to 50, it'll be easy for wallet users to accidentally generate transactions that are affected by the policy
6172016-07-19T17:29:46 <sdaftuar> if you have a bunch of p2pkh outputs, you'll hit it
6182016-07-19T17:31:51 <sipa> really?
6192016-07-19T17:31:56 <sipa> signatures are 72 bytes
6202016-07-19T17:32:08 <sdaftuar> outputs -- legacy sigop count will get you
6212016-07-19T17:33:32 <sdaftuar> for instance, i found this tx, which is a bit extreme, but illustrates the point: https://www.blocktrail.com/BTC/tx/c9daddde3379f16e11a547b34e9723c7b5ca71c82bf1213fc93bf13d81cd601f
6222016-07-19T17:34:46 <sdaftuar> that's the one i found with sigop cost of 9644
6232016-07-19T17:37:56 *** spudowiar has joined #bitcoin-core-dev
6242016-07-19T17:45:12 *** fengling has joined #bitcoin-core-dev
6252016-07-19T17:50:06 *** fengling has quit IRC
6262016-07-19T18:00:35 *** pedrobra_ has quit IRC
6272016-07-19T18:00:50 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6282016-07-19T18:01:06 *** pedrobranco has joined #bitcoin-core-dev
6292016-07-19T18:05:54 *** pedrobranco has quit IRC
6302016-07-19T18:10:51 *** Chris_Stewart_5 has quit IRC
6312016-07-19T18:26:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6322016-07-19T18:30:38 *** pedrobranco has joined #bitcoin-core-dev
6332016-07-19T18:32:52 *** Chris_Stewart_5 has quit IRC
6342016-07-19T18:35:16 *** pedrobranco has quit IRC
6352016-07-19T18:37:11 *** bsm117532 has quit IRC
6362016-07-19T18:37:37 *** bsm117532 has joined #bitcoin-core-dev
6372016-07-19T18:38:07 *** TomMc has joined #bitcoin-core-dev
6382016-07-19T18:39:25 *** cryptapus has joined #bitcoin-core-dev
6392016-07-19T18:46:44 *** fengling has joined #bitcoin-core-dev
6402016-07-19T18:49:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6412016-07-19T18:51:46 *** fengling has quit IRC
6422016-07-19T19:03:12 *** Chris_Stewart_5 has quit IRC
6432016-07-19T19:03:36 *** mkarrer has quit IRC
6442016-07-19T19:06:20 *** mkarrer has joined #bitcoin-core-dev
6452016-07-19T19:11:25 <BlueMatt> wumpus: needed a fix for "I think IsKeyType should be changed to include hdchain, not add an explicit hdchain check in ::Recover, since we probably definitely want it in ::LoadWallet as well." first
6462016-07-19T19:11:34 <BlueMatt> that is very bad behavior
6472016-07-19T19:12:54 <BlueMatt> oh, you already tagged rc1...ugh
6482016-07-19T19:17:27 <BlueMatt> wumpus: also you merged 8367 without fixing the bug I pointed out in it..........
6492016-07-19T19:18:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6502016-07-19T19:19:53 *** jiggalator has joined #bitcoin-core-dev
6512016-07-19T19:21:17 <gmaxwell> BlueMatt: open a PR to fix it. your "not that it really matters" might have understated your expectation that it would get fixed.
6522016-07-19T19:21:53 <BlueMatt> I mean I figured it'd get fixed before merge, even if its not a huge deal
6532016-07-19T19:27:10 <sipa> BlueMatt: i'm sure there'll be a second rc anyway
6542016-07-19T19:27:40 <sipa> i guess wumpus wanted to get an rc out to get testing from a wider audience
6552016-07-19T19:27:52 <gmaxwell> we're seriously late on the RC. It was good to get one out.
6562016-07-19T19:27:53 <cfields> i think i have the osx determinism issue worked out. any gitian builders around to verify?
6572016-07-19T19:28:02 <BlueMatt> yeayea, I'm not suggesting anything is gonna catch fire, just saying there are a few things here to fix for rc2
6582016-07-19T19:28:07 *** schmidty has quit IRC
6592016-07-19T19:31:37 <MarcoFalke> The check is dead code and the strings in the exceptions need the function names adjusted ...
6602016-07-19T19:31:55 <MarcoFalke> It is good to have rc1 out. We can fix those later
6612016-07-19T19:32:07 <MarcoFalke> cfields: I can try
6622016-07-19T19:32:28 <cfields> MarcoFalke: ok. tested by hand, plugging it all in now. ready in ~10min
6632016-07-19T19:32:29 <MarcoFalke> Is it just a descriptor bump or do we need rc2 already?
6642016-07-19T19:33:07 <achow101> cfields: I can try it too
6652016-07-19T19:34:14 <cfields> MarcoFalke: i'll leave it up to wumpus. it's the .DS_Store, which is inconsequential and has no influence on the binary. but it means that gitian results won't match.
6662016-07-19T19:34:50 <michagogo> Got the new SDK -- my rc1 is building right now
6672016-07-19T19:39:47 <luke-jr> did we bump ds_store Python or smth? O.o
6682016-07-19T19:44:42 <GitHub16> [bitcoin] theuni opened pull request #8373: Fix OSX non-deterministic dmg (master...biplist-determinism) https://github.com/bitcoin/bitcoin/pull/8373
6692016-07-19T19:47:04 <luke-jr> ahh
6702016-07-19T19:48:12 *** fengling has joined #bitcoin-core-dev
6712016-07-19T19:51:53 *** jiggalator has quit IRC
6722016-07-19T19:52:46 *** fengling has quit IRC
6732016-07-19T19:54:36 <cfields> luke-jr: think there's any way to post-process an existing ds_store with unsorted plists inside so that we can just fix it up in the gitian descriptor for rc1?
6742016-07-19T19:55:38 <luke-jr> I would imagine so, but meh? :/
6752016-07-19T19:55:59 <cfields> luke-jr: otherwise i don't think i can sign rc1
6762016-07-19T19:58:54 <luke-jr> cfields: can DS_Store do anything malicious? why not just compare the binaries without it?
6772016-07-19T19:58:58 <cfields> hmm, i guess that's not right. that file's outside of the .app, so i suppose it's not signed at all
6782016-07-19T19:59:54 <luke-jr> right
6792016-07-19T20:00:19 <luke-jr> so it's not a technical issue AFAIK, just potentially philosophical
6802016-07-19T20:01:49 <cfields> yep. i guess a few builders could manually fixup inside gitian to force an order, then at least there's a reference for a matching hash
6812016-07-19T20:02:45 <cfields> but yes, since it's not signed data and everyone's binaries should match, i'll carry on signing as usual
6822016-07-19T20:03:34 *** cryptapus has quit IRC
6832016-07-19T20:04:19 <michagogo> If you push the sigs before my script finishes running, it should grab them and generate sigs for the -signeds too
6842016-07-19T20:04:44 <michagogo> (I'm going to sleep now, but the PR should be pushed automatically)
6852016-07-19T20:08:20 <GitHub18> [bitcoin] sdaftuar opened pull request #8374: Add release notes for mining changes (0.13...release-notes-mining) https://github.com/bitcoin/bitcoin/pull/8374
6862016-07-19T20:08:34 <cfields> michagogo: great, thanks
6872016-07-19T20:11:38 *** bsm117532 has quit IRC
6882016-07-19T20:12:08 *** bsm117532 has joined #bitcoin-core-dev
6892016-07-19T20:12:37 *** bsm117532 has quit IRC
6902016-07-19T20:14:52 *** bsm117532 has joined #bitcoin-core-dev
6912016-07-19T20:20:00 <achow101> Finished my build with cfields patch
6922016-07-19T20:20:21 <achow101> 9fa6b31128eee2cfa535774fe4eebaa384f0471c094ce6ee6aefe9aef93f134b bitcoin-0.13.99-osx-unsigned.dmg
6932016-07-19T20:20:21 <achow101> e2e33efea3d2c86d34391b3be20d032343b359909cdbe55b1153ba109ae5af4f bitcoin-0.13.99-osx-unsigned.tar.gz
6942016-07-19T20:20:21 <achow101> fc5a233b3be260ec7be63f699bbc128240ad190692cd5d4a82cc1352eb3c57df bitcoin-0.13.99-osx64.tar.gz
6952016-07-19T20:20:21 <achow101> 0269f915640886ba16c73450ab2dbcdde0304fa79807414c7e0cf4d4ba8f39df src/bitcoin-0.13.99.tar.gz
6962016-07-19T20:20:22 <achow101> ab0a5e271e81fb48cf355f866a105eca12713260e703da35330ae66e03336367 bitcoin-osx-0.13-res.yml
6972016-07-19T20:22:04 *** Chris_Stewart_5 has quit IRC
6982016-07-19T20:26:06 <MarcoFalke> achow101: You applied the patch on the gitian vm?
6992016-07-19T20:26:29 <achow101> yes
7002016-07-19T20:28:56 <MarcoFalke> cfields: Let us know if signing the binaries worked out for you
7012016-07-19T20:31:17 * luke-jr ponders how to best get P2SH^2 deployed.
7022016-07-19T20:31:38 <luke-jr> at least bloated spam discourages miners from including it
7032016-07-19T20:33:02 *** Guyver2 has joined #bitcoin-core-dev
7042016-07-19T20:42:49 *** laurentmt has joined #bitcoin-core-dev
7052016-07-19T20:44:12 *** laurentmt has quit IRC
7062016-07-19T20:44:47 *** molz has joined #bitcoin-core-dev
7072016-07-19T20:45:32 *** bsm117532 has quit IRC
7082016-07-19T20:45:52 *** bsm117532 has joined #bitcoin-core-dev
7092016-07-19T20:46:33 *** moli has quit IRC
7102016-07-19T20:49:16 *** fengling has joined #bitcoin-core-dev
7112016-07-19T20:52:29 *** jiggalator has joined #bitcoin-core-dev
7122016-07-19T20:54:06 *** fengling has quit IRC
7132016-07-19T20:56:20 <cfields> MarcoFalke: will do, still working on it.
7142016-07-19T20:56:36 <MarcoFalke> great
7152016-07-19T20:57:04 *** jiggalator has quit IRC
7162016-07-19T20:58:07 <achow101> ran the build again and got the same results
7172016-07-19T20:59:13 <cfields> achow101: to clarify, you're testing master now, right?
7182016-07-19T20:59:22 <achow101> yes
7192016-07-19T21:00:09 <cfields> ok
7202016-07-19T21:04:51 *** jiggalator has joined #bitcoin-core-dev
7212016-07-19T21:07:11 *** spudowiar1 has joined #bitcoin-core-dev
7222016-07-19T21:08:44 *** spudowiar has quit IRC
7232016-07-19T21:11:11 *** spudowiar2 has joined #bitcoin-core-dev
7242016-07-19T21:13:34 *** spudowiar1 has quit IRC
7252016-07-19T21:15:31 *** MarcoFalke has left #bitcoin-core-dev
7262016-07-19T21:20:42 <cfields> 0.13.0rc1 sigs pushed.
7272016-07-19T21:21:09 <cfields> achow101: building master with that PR on top now. thanks for doing that so quickly :)
7282016-07-19T21:24:17 <cfields> achow101: actually, before i build, could you specify the commit you built? Not sure if you cherry-picked or merged, and that'll change the result
7292016-07-19T21:26:36 <achow101> I grabbed the diff and applied it.
7302016-07-19T21:26:55 <achow101> probably wasn't the right thing to do, but i was being lazy
7312016-07-19T21:29:24 *** spudowiar2 has quit IRC
7322016-07-19T21:29:51 <cfields> achow101: mm, i don't think i'm going to be able to match your result, then
7332016-07-19T21:29:55 <achow101> err. actually I think I just built your branch. I was originally just going to use the diff but I screwed something up
7342016-07-19T21:30:13 *** spudowiar has joined #bitcoin-core-dev
7352016-07-19T21:31:18 <cfields> 3b3ce25df6cc, then?
7362016-07-19T21:31:56 <achow101> yes
7372016-07-19T21:32:30 <cfields> ok great, building that.
7382016-07-19T21:36:58 <phantomcircuit> jonasschnelli, i rebased 8152 can you review again
7392016-07-19T21:45:16 <phantomcircuit> jonasschnelli, why does CHDKeyStore::PrivateKeyDerivation take the keypath as a string?
7402016-07-19T21:50:50 *** fengling has joined #bitcoin-core-dev
7412016-07-19T21:55:26 *** fengling has quit IRC
7422016-07-19T22:08:45 *** Guyver2 has quit IRC
7432016-07-19T22:16:17 *** spudowiar has quit IRC
7442016-07-19T22:31:51 *** jiggalator has quit IRC
7452016-07-19T22:32:15 *** jcliff42 has joined #bitcoin-core-dev
7462016-07-19T22:33:53 *** Chris_Stewart_5 has joined #bitcoin-core-dev
7472016-07-19T22:36:18 *** aalex has quit IRC
7482016-07-19T22:40:23 *** aalex has joined #bitcoin-core-dev
7492016-07-19T22:51:48 *** fengling has joined #bitcoin-core-dev
7502016-07-19T22:53:06 *** jiggalator has joined #bitcoin-core-dev
7512016-07-19T22:56:46 *** fengling has quit IRC
7522016-07-19T23:15:48 *** jcliff42 has quit IRC
7532016-07-19T23:20:17 <Chris_Stewart_5> Is nFilterBytes suppose to be a compact sized unsigned integer on this documentation? https://bitcoin.org/en/developer-reference#filterload
7542016-07-19T23:22:32 <phantomcircuit> Chris_Stewart_5, the docs there are literally wrong
7552016-07-19T23:22:36 <phantomcircuit> the literal serialization is
7562016-07-19T23:22:48 <phantomcircuit> serialized vector of uint8_t
7572016-07-19T23:22:49 *** jcliff42 has joined #bitcoin-core-dev
7582016-07-19T23:23:03 <sipa> phantomcircuit: the docs always make lengths of vectors explicit
7592016-07-19T23:23:14 <phantomcircuit> uint32_t nhashfuncs, uint32_t ntweak, uint8_t nflags
7602016-07-19T23:23:23 <phantomcircuit> sipa, either way it's missing ntweak entirely
7612016-07-19T23:23:28 <sipa> ah
7622016-07-19T23:23:32 <sipa> eh, no?
7632016-07-19T23:23:36 <phantomcircuit> oh no it's not
7642016-07-19T23:23:38 <phantomcircuit> what
7652016-07-19T23:23:48 <Chris_Stewart_5> nTweak is there, is there suppose to be a tweak along with it?
7662016-07-19T23:23:52 <phantomcircuit> oh the weird warning makes it look like there's nothing below the fold
7672016-07-19T23:24:20 <sipa> Chris_Stewart_5: to answer your first question: yes
7682016-07-19T23:24:26 <phantomcircuit> yeah nvm it's right
7692016-07-19T23:24:27 <sipa> it's a compact integer
7702016-07-19T23:26:03 <Chris_Stewart_5> I've had issues even trying to find the classes/structs that correspond to some of these messages, where can I find the actual message structure in core?
7712016-07-19T23:26:41 *** aalex has quit IRC
7722016-07-19T23:27:03 *** jcliff42 has quit IRC
7732016-07-19T23:28:16 <Chris_Stewart_5> If I do a search I find references to 'FilterLoad' for instance in main.cpp, protocol.cpp and protocol.h but no class or struct, unless i'm missing something obvious
7742016-07-19T23:29:55 *** jcliff42 has joined #bitcoin-core-dev
7752016-07-19T23:30:26 *** aalex has joined #bitcoin-core-dev
7762016-07-19T23:30:29 <sipa> else if (strCommand == NetMsgType::FILTERLOAD)
7772016-07-19T23:30:29 <sipa> {
7782016-07-19T23:30:29 <sipa> CBloomFilter filter;
7792016-07-19T23:30:29 <sipa> vRecv >> filter;
7802016-07-19T23:30:37 <sipa> CBloomFilter is defined in bloom.h
7812016-07-19T23:31:20 <Chris_Stewart_5> and there is some ffunction defined in CBloomFilter to deserialize the DataStream?
7822016-07-19T23:33:48 *** jiggalator is now known as netsin
7832016-07-19T23:35:18 *** jcliff42 has quit IRC
7842016-07-19T23:36:26 <Chris_Stewart_5> I'm just following the stack and it seems like we go from streams.h -> serialize.h which starts parsing the varint, but I don't see where the contents are explicitly passed to a constructure or anything
7852016-07-19T23:36:47 <Chris_Stewart_5> is there some C++ convention going on here?
7862016-07-19T23:36:49 *** jcliff42 has joined #bitcoin-core-dev
7872016-07-19T23:37:08 <sipa> there is a lot of magic in serialize.h
7882016-07-19T23:38:00 <sipa> ADD_SERIALIZE_METHODS expands into the necessary serialization boilerplate
7892016-07-19T23:39:11 <Chris_Stewart_5> oh ok. Does it use some sort of reflection to call the necessary constructors?
7902016-07-19T23:39:36 <sipa> there are no constructors inbolved
7912016-07-19T23:39:57 <sipa> the constructor of CBloomFilter is invoked on the line where filter is declared
7922016-07-19T23:40:38 <sipa> the 'vRecv >> filter' just reads data from vRecv stream and fills filter with it
7932016-07-19T23:42:48 <Chris_Stewart_5> and this 'fill' function is defined in ADD_SERIALIZE_METHODS?
7942016-07-19T23:44:07 <GitHub8> [bitcoin] pstratem opened pull request #8375: Move key derivation logic from GenerateNewKey to DeriveNewKey (master...2016-07-19-cwallet-derivenewkey) https://github.com/bitcoin/bitcoin/pull/8375
7952016-07-19T23:44:50 <sipa> yes, it's called Deserializr
7962016-07-19T23:44:56 <sipa> Deserializr
7972016-07-19T23:45:01 <sipa> grr, stupid keyboard
7982016-07-19T23:45:03 <sipa> Deserialize
7992016-07-19T23:45:34 <Chris_Stewart_5> Your 'e' key wants you to go to sleep :-). Thanks sipa
8002016-07-19T23:50:14 <phantomcircuit> i think it's easier to read that way ^
8012016-07-19T23:53:52 *** Giszmo1 has quit IRC
8022016-07-19T23:54:06 *** fengling has joined #bitcoin-core-dev