12016-08-17T00:08:01 *** Alopex has quit IRC
22016-08-17T00:09:06 *** Alopex has joined #bitcoin-core-dev
32016-08-17T00:11:41 *** fengling has joined #bitcoin-core-dev
42016-08-17T00:13:51 *** Giszmo has quit IRC
52016-08-17T00:16:26 *** fengling has quit IRC
62016-08-17T00:20:53 *** spudowiar has quit IRC
72016-08-17T00:21:20 *** JZA has joined #bitcoin-core-dev
82016-08-17T00:40:44 *** TomMc has joined #bitcoin-core-dev
92016-08-17T00:41:46 *** fengling has joined #bitcoin-core-dev
102016-08-17T00:55:03 *** TomMc has quit IRC
112016-08-17T00:57:11 *** TomMc has joined #bitcoin-core-dev
122016-08-17T01:26:25 *** JackH has quit IRC
132016-08-17T01:35:52 *** Ylbam has quit IRC
142016-08-17T01:37:05 *** Samdney has quit IRC
152016-08-17T01:55:11 *** Alopex has quit IRC
162016-08-17T01:56:17 *** Alopex has joined #bitcoin-core-dev
172016-08-17T02:33:16 *** Alopex has quit IRC
182016-08-17T02:33:52 *** cryptapus_afk has quit IRC
192016-08-17T02:33:56 *** cryptapus has joined #bitcoin-core-dev
202016-08-17T02:33:57 *** cryptapus is now known as cryptapus_afk
212016-08-17T02:34:21 *** Alopex has joined #bitcoin-core-dev
222016-08-17T02:44:11 *** Samdney has joined #bitcoin-core-dev
232016-08-17T03:01:25 *** Samdney has quit IRC
242016-08-17T03:03:16 *** Alopex has quit IRC
252016-08-17T03:04:22 *** Alopex has joined #bitcoin-core-dev
262016-08-17T03:04:52 *** zooko has quit IRC
272016-08-17T03:13:28 *** TomMc has quit IRC
282016-08-17T03:16:02 *** Chris_Stewart_5 has quit IRC
292016-08-17T03:47:06 *** Alopex has quit IRC
302016-08-17T03:48:11 *** Alopex has joined #bitcoin-core-dev
312016-08-17T03:58:16 *** Alopex has quit IRC
322016-08-17T03:59:21 *** Alopex has joined #bitcoin-core-dev
332016-08-17T04:09:26 *** Alopex has quit IRC
342016-08-17T04:10:32 *** Alopex has joined #bitcoin-core-dev
352016-08-17T04:23:06 *** Alopex has quit IRC
362016-08-17T04:24:11 *** Alopex has joined #bitcoin-core-dev
372016-08-17T04:34:06 *** Alopex has quit IRC
382016-08-17T04:35:11 *** Alopex has joined #bitcoin-core-dev
392016-08-17T04:43:55 *** kadoban has quit IRC
402016-08-17T05:09:17 *** Alopex has quit IRC
412016-08-17T05:10:22 *** Alopex has joined #bitcoin-core-dev
422016-08-17T05:46:33 *** wangchun has quit IRC
432016-08-17T05:47:11 *** wangchun has joined #bitcoin-core-dev
442016-08-17T06:00:16 *** Alopex has quit IRC
452016-08-17T06:01:22 *** Alopex has joined #bitcoin-core-dev
462016-08-17T06:27:06 *** fengling has quit IRC
472016-08-17T06:49:44 *** BashCo has quit IRC
482016-08-17T07:04:28 *** fengling has joined #bitcoin-core-dev
492016-08-17T07:10:58 *** BashCo has joined #bitcoin-core-dev
502016-08-17T07:12:41 *** BashCo_ has joined #bitcoin-core-dev
512016-08-17T07:16:44 *** BashCo has quit IRC
522016-08-17T07:16:54 *** rubensayshi has joined #bitcoin-core-dev
532016-08-17T07:28:12 *** MarcoFalke has joined #bitcoin-core-dev
542016-08-17T07:33:30 *** laurentmt has joined #bitcoin-core-dev
552016-08-17T07:34:49 *** laurentmt has quit IRC
562016-08-17T07:35:55 <jonasschnelli> luke-jr: requesting BIP number for the authentication BIP: https://github.com/jonasschnelli/bips/blob/2016/07/auth_bip/bip-undef-0.mediawiki
572016-08-17T07:38:42 <luke-jr> jonasschnelli: isn't that what we already gave BIP 150?
582016-08-17T07:39:03 <luke-jr> hm, I guess it's still marked tentative on my end; so BIP 150 :p
592016-08-17T07:39:08 <jonasschnelli> luke-jr: Could be? Wasn't aware of that. Thanks
602016-08-17T07:39:26 *** spudowiar has joined #bitcoin-core-dev
612016-08-17T07:39:36 <luke-jr> jonasschnelli: used to be part of https://github.com/bitcoin/bips/pull/362, right?
622016-08-17T07:39:53 <jonasschnelli> Ah. Right... it was combine at the PR level once.
632016-08-17T08:03:26 *** fengling has quit IRC
642016-08-17T08:08:30 *** JackH has joined #bitcoin-core-dev
652016-08-17T08:09:16 *** fengling has joined #bitcoin-core-dev
662016-08-17T08:13:35 *** belcher has joined #bitcoin-core-dev
672016-08-17T08:18:41 *** Guyver2 has joined #bitcoin-core-dev
682016-08-17T08:38:18 *** laurentmt has joined #bitcoin-core-dev
692016-08-17T08:38:29 *** laurentmt has quit IRC
702016-08-17T08:40:02 *** ratoder has joined #bitcoin-core-dev
712016-08-17T08:58:12 *** spudowiar has quit IRC
722016-08-17T09:12:25 *** Giszmo has joined #bitcoin-core-dev
732016-08-17T09:19:31 *** Megaf has joined #bitcoin-core-dev
742016-08-17T09:31:49 *** Ylbam has joined #bitcoin-core-dev
752016-08-17T09:51:06 *** fengling has quit IRC
762016-08-17T09:52:24 *** fengling has joined #bitcoin-core-dev
772016-08-17T10:00:03 <GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c2d471e18f0...b40e19c6c48f
782016-08-17T10:00:04 <GitHub26> bitcoin/master 936c144 Wladimir J. van der Laan: build: Remove check for `openssl/ec.h`...
792016-08-17T10:00:04 <GitHub26> bitcoin/master b40e19c Wladimir J. van der Laan: Merge #8520: build: Remove check for `openssl/ec.h`...
802016-08-17T10:00:18 <GitHub114> [bitcoin] laanwj closed pull request #8520: build: Remove check for `openssl/ec.h` (master...2016_08_remove_openssl_ech_check) https://github.com/bitcoin/bitcoin/pull/8520
812016-08-17T10:00:54 *** BlueMatt has quit IRC
822016-08-17T10:01:08 <GitHub99> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b40e19c6c48f...b41ac928b89f
832016-08-17T10:01:08 <GitHub99> bitcoin/master c1582d5 Wladimir J. van der Laan: qa: Remove duplicate `hash160` implementation...
842016-08-17T10:01:09 <GitHub99> bitcoin/master b41ac92 Wladimir J. van der Laan: Merge #8521: qa: Remove duplicate `hash160` implementation...
852016-08-17T10:01:16 <GitHub157> [bitcoin] laanwj closed pull request #8521: qa: Remove duplicate `hash160` implementation (master...2016_08_hash160_dupe) https://github.com/bitcoin/bitcoin/pull/8521
862016-08-17T10:02:06 <GitHub138> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b41ac928b89f...29496fc9e095
872016-08-17T10:02:07 <GitHub138> bitcoin/master 6ffd996 Sev: Corrected JSON typo on setban of net.cpp
882016-08-17T10:02:07 <GitHub138> bitcoin/master 29496fc Wladimir J. van der Laan: Merge #8512: Trivial: Corrected JSON typo on setban of net.cpp...
892016-08-17T10:02:21 <GitHub20> [bitcoin] laanwj closed pull request #8512: Trivial: Corrected JSON typo on setban of net.cpp (master...setban) https://github.com/bitcoin/bitcoin/pull/8512
902016-08-17T10:06:30 *** BlueMatt has joined #bitcoin-core-dev
912016-08-17T10:06:50 *** mapass has joined #bitcoin-core-dev
922016-08-17T10:07:32 *** owowo has quit IRC
932016-08-17T10:16:56 *** owowo has joined #bitcoin-core-dev
942016-08-17T10:16:56 *** owowo has joined #bitcoin-core-dev
952016-08-17T10:20:01 *** paveljanik has quit IRC
962016-08-17T10:26:44 <GitHub170> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/29496fc9e095...740cff5808c3
972016-08-17T10:26:45 <GitHub170> bitcoin/master fae596f MarcoFalke: [qa] Sort scripts by time for pull_tester and don't overwrite setup_chain
982016-08-17T10:26:45 <GitHub170> bitcoin/master fa2d68f MarcoFalke: [qa] Adjust timeouts for micro-optimization of run time
992016-08-17T10:26:46 <GitHub170> bitcoin/master fad8cf6 MarcoFalke: [qa] Use single cache dir for chains
1002016-08-17T10:26:50 <GitHub62> [bitcoin] laanwj closed pull request #8296: [qa] Don't overwrite setup_chain and sort scripts (master...Mf1607-qaSetupChain) https://github.com/bitcoin/bitcoin/pull/8296
1012016-08-17T10:26:55 <GitHub83> [bitcoin] laanwj closed pull request #8482: [qa] Use single cache dir for chains (master...Mf1608-qaCache) https://github.com/bitcoin/bitcoin/pull/8482
1022016-08-17T10:33:23 <GitHub110> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/740cff5808c3...65e644418106
1032016-08-17T10:33:23 <GitHub110> bitcoin/master 8194a6e Jeremy Rubin: Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
1042016-08-17T10:33:24 <GitHub110> bitcoin/master 65e6444 Wladimir J. van der Laan: Merge #8513: Fix a type error that would not compile on OSX....
1052016-08-17T10:33:33 <GitHub120> [bitcoin] laanwj closed pull request #8513: Fix a type error that would not compile on OSX. (master...fix-osx-break) https://github.com/bitcoin/bitcoin/pull/8513
1062016-08-17T10:34:39 *** Ginnarr has joined #bitcoin-core-dev
1072016-08-17T10:46:04 *** molz has quit IRC
1082016-08-17T10:51:36 <GitHub146> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65e644418106...e753eaeb343c
1092016-08-17T10:51:37 <GitHub146> bitcoin/master 1aacfc2 leijurv: various typos
1102016-08-17T10:51:37 <GitHub146> bitcoin/master e753eae Wladimir J. van der Laan: Merge #8505: Trivial: Fix typos in various files...
1112016-08-17T10:51:46 <GitHub132> [bitcoin] laanwj closed pull request #8505: Trivial: Fix typos in various files (master...replacable-typo) https://github.com/bitcoin/bitcoin/pull/8505
1122016-08-17T10:53:19 <sipa> m-m-m-megamerge
1132016-08-17T10:58:26 *** fengling has quit IRC
1142016-08-17T10:59:58 *** rubensayshi has quit IRC
1152016-08-17T11:00:57 *** laurentmt has joined #bitcoin-core-dev
1162016-08-17T11:01:18 *** laurentmt has quit IRC
1172016-08-17T11:07:16 <GitHub176> [bitcoin] laanwj pushed 4 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/4374f0ee35f8...a402396dce64
1182016-08-17T11:07:16 <GitHub55> [bitcoin] laanwj closed pull request #8490: [0.13] release notes: Mention new relevance of non-mining nodes on network policy; and misc fixes (0.13...relnotes_013_misc) https://github.com/bitcoin/bitcoin/pull/8490
1192016-08-17T11:07:17 <GitHub176> bitcoin/0.13 4f55293 Luke Dashjr: doc/release-notes: Misc
1202016-08-17T11:07:17 <GitHub176> bitcoin/0.13 40d705c Luke Dashjr: doc/release-notes: Mention the relevance of Compact Blocks on non-mining nodes' influence on network policy
1212016-08-17T11:07:18 <GitHub176> bitcoin/0.13 5e499e7 Luke Dashjr: doc/release-notes: Document changed bytespersigop behaviour
1222016-08-17T11:12:43 <GitHub138> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e753eaeb343c...733035bdb755
1232016-08-17T11:12:44 <GitHub138> bitcoin/master 3c5251d Wladimir J. van der Laan: test: Remove java comparison tool
1242016-08-17T11:12:44 <GitHub138> bitcoin/master eb0c52e Wladimir J. van der Laan: travis: Remove hostname hack...
1252016-08-17T11:12:45 <GitHub138> bitcoin/master 733035b Wladimir J. van der Laan: Merge #8504: test: Remove java comparison tool...
1262016-08-17T11:12:54 <GitHub95> [bitcoin] laanwj closed pull request #8504: test: Remove java comparison tool (master...2016_08_jexit) https://github.com/bitcoin/bitcoin/pull/8504
1272016-08-17T11:15:55 *** Ginnarr has quit IRC
1282016-08-17T11:28:07 <GitHub97> [bitcoin] MarcoFalke opened pull request #8531: [qa] abandonconflict: Use assert_equal (master...Mf1608-qaAssert) https://github.com/bitcoin/bitcoin/pull/8531
1292016-08-17T11:55:04 *** fengling has joined #bitcoin-core-dev
1302016-08-17T12:00:06 *** fengling has quit IRC
1312016-08-17T12:35:52 *** Ylbam has quit IRC
1322016-08-17T12:40:35 *** cryptapus has joined #bitcoin-core-dev
1332016-08-17T12:41:54 *** Guyver2 has quit IRC
1342016-08-17T12:42:11 *** murch has joined #bitcoin-core-dev
1352016-08-17T12:56:36 *** fengling has joined #bitcoin-core-dev
1362016-08-17T13:00:46 *** fengling has quit IRC
1372016-08-17T13:01:02 <jonasschnelli> Is there a way to locally detect unsafe iterator usage? https://travis-ci.org/bitcoin/bitcoin/jobs/152408747#L1413
1382016-08-17T13:01:18 <jonasschnelli> I compiled it locally on different machines and can't get that test failure...
1392016-08-17T13:02:07 <sipa> jonasschnelli: it requires rebuilding glibc with debug options, i think
1402016-08-17T13:02:11 <jonasschnelli> It could be a bug in gcc, I'm using std::prev(myVector.end()) which should be valid and safe?
1412016-08-17T13:02:26 <sipa> jonasschnelli: only if the vector is not empty
1422016-08-17T13:02:50 <jonasschnelli> Yes. There is a check for empty vectors above..
1432016-08-17T13:02:57 <sipa> ah, right
1442016-08-17T13:03:20 <jonasschnelli> I stepped with the debugger through the whole unit test and cannot fine a invalid std::prev
1452016-08-17T13:03:46 <jonasschnelli> *find
1462016-08-17T13:04:39 <sipa> maybe it's not in a call to std::prev?
1472016-08-17T13:05:48 <jonasschnelli> wait.. found the issue! nm
1482016-08-17T13:06:08 <jonasschnelli> There is a call of std::prev(vector.begin()) which is invalid
1492016-08-17T13:07:17 *** moli has joined #bitcoin-core-dev
1502016-08-17T13:23:29 *** Guyver2 has joined #bitcoin-core-dev
1512016-08-17T13:34:59 *** Samdney has joined #bitcoin-core-dev
1522016-08-17T13:39:42 *** kadoban has joined #bitcoin-core-dev
1532016-08-17T13:48:50 *** Ylbam has joined #bitcoin-core-dev
1542016-08-17T13:55:06 *** murch has quit IRC
1552016-08-17T13:57:20 *** fengling has joined #bitcoin-core-dev
1562016-08-17T14:02:06 *** fengling has quit IRC
1572016-08-17T14:04:58 *** cryptapus_afk has quit IRC
1582016-08-17T14:10:23 *** Samdney has quit IRC
1592016-08-17T14:31:30 *** laurentmt has joined #bitcoin-core-dev
1602016-08-17T14:32:28 *** laurentmt has quit IRC
1612016-08-17T14:33:01 *** zooko has joined #bitcoin-core-dev
1622016-08-17T14:51:04 *** Guyver2 has quit IRC
1632016-08-17T14:55:13 *** Guyver2 has joined #bitcoin-core-dev
1642016-08-17T14:58:14 *** BashCo_ has quit IRC
1652016-08-17T14:58:47 *** fengling has joined #bitcoin-core-dev
1662016-08-17T15:03:46 *** fengling has quit IRC
1672016-08-17T15:12:46 *** Guyver2 has quit IRC
1682016-08-17T15:23:20 *** Guyver2 has joined #bitcoin-core-dev
1692016-08-17T15:27:23 *** Guyver2 has quit IRC
1702016-08-17T15:42:16 *** BashCo has joined #bitcoin-core-dev
1712016-08-17T15:47:04 *** MarcoFalke has left #bitcoin-core-dev
1722016-08-17T16:00:33 *** fengling has joined #bitcoin-core-dev
1732016-08-17T16:05:26 *** fengling has quit IRC
1742016-08-17T16:18:21 *** spudowiar has joined #bitcoin-core-dev
1752016-08-17T16:19:55 *** mapass has left #bitcoin-core-dev
1762016-08-17T16:30:05 *** zooko has quit IRC
1772016-08-17T16:40:20 *** TomMc has joined #bitcoin-core-dev
1782016-08-17T16:47:41 <btcdrak> Seeking reviews of the 0.13.0 release blog post https://github.com/bitcoin-core/bitcoincore.org/pull/199
1792016-08-17T17:01:53 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1802016-08-17T17:02:04 *** fengling has joined #bitcoin-core-dev
1812016-08-17T17:02:06 *** Yogh has quit IRC
1822016-08-17T17:03:00 *** Yogh has joined #bitcoin-core-dev
1832016-08-17T17:06:40 *** belcher has quit IRC
1842016-08-17T17:06:46 *** fengling has quit IRC
1852016-08-17T17:08:02 *** Guest21946 has joined #bitcoin-core-dev
1862016-08-17T17:17:06 *** laurentmt has joined #bitcoin-core-dev
1872016-08-17T17:25:59 *** laurentmt has quit IRC
1882016-08-17T17:28:37 *** Samdney has joined #bitcoin-core-dev
1892016-08-17T17:30:01 *** zooko has joined #bitcoin-core-dev
1902016-08-17T17:37:01 <Anduck> bitcoin core slack has leaked my e-mail to scammers
1912016-08-17T17:37:17 <Anduck> i used unique e-mail when i joined bitcoincore.slack.com
1922016-08-17T17:38:06 <Anduck> do bitcoincore.slack.com maintainer/admin have access to the e-mails or does slack only have them?
1932016-08-17T17:44:49 *** brg444 has joined #bitcoin-core-dev
1942016-08-17T17:45:17 <brg444> Anduck unfortunately that is just how slack is set up, every user's email address is public
1952016-08-17T17:45:34 *** zooko has quit IRC
1962016-08-17T17:46:12 <Anduck> i've not received any attempts from other slacks
1972016-08-17T17:47:22 <btcdrak> Anduck, this is a feature of Slack and cannot be changed. Anyone can slurp up all member emails addresses.
1982016-08-17T17:47:35 <Anduck> ok.
1992016-08-17T17:47:38 <Anduck> thanks for replys
2002016-08-17T17:47:46 <btcdrak> Anduck, make sure you use 2FA and a unique password.
2012016-08-17T17:47:50 <brg444> It's likely Core's slack is particularly targeted, unfortunately :/
2022016-08-17T17:49:04 *** jl2012 has quit IRC
2032016-08-17T17:50:14 *** Ylbam has quit IRC
2042016-08-17T17:50:58 <Anduck> i see, i see
2052016-08-17T17:54:41 *** Ylbam has joined #bitcoin-core-dev
2062016-08-17T17:57:20 <GitHub166> [bitcoin] jl2012 opened pull request #8533: Implement LOW_S and NULLDUMMY softfork (BIP146) (master...bip146) https://github.com/bitcoin/bitcoin/pull/8533
2072016-08-17T17:59:16 <GitHub170> [bitcoin] jl2012 closed pull request #8514: Enforce LOW_S rules on all transactions with WITNESS BIP9 parameters (master...lows) https://github.com/bitcoin/bitcoin/pull/8514
2082016-08-17T18:01:44 *** Guest21946 has quit IRC
2092016-08-17T18:02:49 *** jl2012 has joined #bitcoin-core-dev
2102016-08-17T18:03:20 *** kadoban has quit IRC
2112016-08-17T18:03:34 *** fengling has joined #bitcoin-core-dev
2122016-08-17T18:03:48 *** kadoban has joined #bitcoin-core-dev
2132016-08-17T18:05:52 *** Ylbam has quit IRC
2142016-08-17T18:08:26 *** fengling has quit IRC
2152016-08-17T18:14:17 *** laurentmt has joined #bitcoin-core-dev
2162016-08-17T18:17:20 *** ArthurNumbanumba has joined #bitcoin-core-dev
2172016-08-17T18:27:33 *** spudowiar has quit IRC
2182016-08-17T18:53:11 *** lextt has joined #bitcoin-core-dev
2192016-08-17T18:56:07 *** Megaf has quit IRC
2202016-08-17T18:59:38 *** shesek has quit IRC
2212016-08-17T19:00:03 *** execut3 has quit IRC
2222016-08-17T19:05:02 *** fengling has joined #bitcoin-core-dev
2232016-08-17T19:06:21 *** Guyver2 has joined #bitcoin-core-dev
2242016-08-17T19:08:06 *** MarcoFalke has joined #bitcoin-core-dev
2252016-08-17T19:09:46 *** fengling has quit IRC
2262016-08-17T19:33:20 *** adiabat has joined #bitcoin-core-dev
2272016-08-17T19:37:30 <GitHub1> [bitcoin] MarcoFalke opened pull request #8534: [travis] Drop java (master...Mf1608-qaJava) https://github.com/bitcoin/bitcoin/pull/8534
2282016-08-17T19:49:59 *** adiabat has quit IRC
2292016-08-17T19:55:27 *** Megaf has joined #bitcoin-core-dev
2302016-08-17T19:57:18 *** cryptapus has quit IRC
2312016-08-17T19:57:28 *** cryptapus has joined #bitcoin-core-dev
2322016-08-17T19:57:28 *** cryptapus has joined #bitcoin-core-dev
2332016-08-17T19:59:07 *** brg444 has quit IRC
2342016-08-17T20:06:09 *** fengling has joined #bitcoin-core-dev
2352016-08-17T20:11:06 *** fengling has quit IRC
2362016-08-17T20:13:39 *** harrymm has quit IRC
2372016-08-17T20:23:18 *** harrymm has joined #bitcoin-core-dev
2382016-08-17T20:25:24 *** cryptapus has quit IRC
2392016-08-17T20:29:04 *** Megaf has quit IRC
2402016-08-17T20:35:08 *** Megaf has joined #bitcoin-core-dev
2412016-08-17T20:35:49 *** Megaf has quit IRC
2422016-08-17T20:39:07 *** adiabat has joined #bitcoin-core-dev
2432016-08-17T20:47:06 *** adiabat has quit IRC
2442016-08-17T20:47:32 *** adiabat has joined #bitcoin-core-dev
2452016-08-17T20:49:32 *** adiabat has quit IRC
2462016-08-17T20:50:36 *** adiabat has joined #bitcoin-core-dev
2472016-08-17T20:51:22 *** waxwing has joined #bitcoin-core-dev
2482016-08-17T20:52:05 *** mkarrer has joined #bitcoin-core-dev
2492016-08-17T20:54:13 <Chris_Stewart_5> In the bitcoin developer reference, when decoding a partial merkle tree it says: Fail if there are unused flag bitsâexcept for the minimum number of bits necessary to pad up to the next full byte.
2502016-08-17T20:54:30 <Chris_Stewart_5> I can't seem to actually find this anywhere in Core though -- is this an actual requirement?
2512016-08-17T20:54:59 <Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/merkleblock.cpp#L136
2522016-08-17T20:55:24 <sipa> line 177
2532016-08-17T20:59:00 <Chris_Stewart_5> Hmm I guess I thought it would be in TraverseAndExtract I guess. Thanks
2542016-08-17T21:01:24 *** mappum has joined #bitcoin-core-dev
2552016-08-17T21:05:53 *** MarcoFalke has left #bitcoin-core-dev
2562016-08-17T21:07:37 *** fengling has joined #bitcoin-core-dev
2572016-08-17T21:09:58 *** Ylbam has joined #bitcoin-core-dev
2582016-08-17T21:12:26 *** fengling has quit IRC
2592016-08-17T21:15:39 *** cryptapus has joined #bitcoin-core-dev
2602016-08-17T21:21:43 <phantomcircuit> while trying to fix 8445 i noticed that pwalletMain is NULL if -disablewallet is passed
2612016-08-17T21:22:21 <phantomcircuit> and yet the disablewallet test passes despite there being things doing pwalletMain-> accesses
2622016-08-17T21:22:24 <phantomcircuit> sipa: ^
2632016-08-17T21:22:42 <phantomcircuit> jonasschnelli: ^
2642016-08-17T21:22:46 <phantomcircuit> am i missing something here?
2652016-08-17T21:23:04 <gmaxwell> may be due to the compiler rerorginzing things so that those accesses don't happen
2662016-08-17T21:24:37 <phantomcircuit> gmaxwell: oooh im dumb
2672016-08-17T21:24:43 <phantomcircuit> pwalletMain ? pwalletMain->GetKeyPoolSize() : 0
2682016-08-17T21:26:13 *** shesek has joined #bitcoin-core-dev
2692016-08-17T21:26:26 *** execut3 has joined #bitcoin-core-dev
2702016-08-17T21:28:26 <gmaxwell> or that
2712016-08-17T21:44:01 *** laurentmt has quit IRC
2722016-08-17T21:49:08 *** murch has joined #bitcoin-core-dev
2732016-08-17T22:04:28 *** TomMc has quit IRC
2742016-08-17T22:08:03 *** whphhg has quit IRC
2752016-08-17T22:08:16 *** whphhg has joined #bitcoin-core-dev
2762016-08-17T22:09:19 *** fengling has joined #bitcoin-core-dev
2772016-08-17T22:11:42 *** spudowiar has joined #bitcoin-core-dev
2782016-08-17T22:12:09 *** lextt has quit IRC
2792016-08-17T22:14:06 *** fengling has quit IRC
2802016-08-17T22:16:12 *** Megaf has joined #bitcoin-core-dev
2812016-08-17T22:16:26 *** lextt has joined #bitcoin-core-dev
2822016-08-17T22:33:09 *** cryptapus is now known as cryptapus_afk
2832016-08-17T22:35:30 <jeremyrubin> Hey, what's the preffered practice for rebasing a PR onto master?
2842016-08-17T22:36:04 <jeremyrubin> push -f onto my branch ok?
2852016-08-17T22:37:26 <sipa> sure
2862016-08-17T22:45:35 *** Giszmo has quit IRC
2872016-08-17T22:53:34 *** FNinTak has joined #bitcoin-core-dev
2882016-08-17T23:06:52 <achow101> what's up with this: https://bitcoin.org/en/alert/2016-08-17-binary-safety
2892016-08-17T23:06:59 <sipa> we don't know
2902016-08-17T23:07:23 <achow101> so cobra went rogue?
2912016-08-17T23:07:52 *** FNinTak has quit IRC
2922016-08-17T23:07:59 <Lauda> If by rogue, you mean skipping the peer review process, then yes.
2932016-08-17T23:10:00 *** FNinTak has joined #bitcoin-core-dev
2942016-08-17T23:10:41 *** fengling has joined #bitcoin-core-dev
2952016-08-17T23:15:26 *** fengling has quit IRC
2962016-08-17T23:25:46 *** Guyver2 has quit IRC
2972016-08-17T23:29:30 *** jcorgan has joined #bitcoin-core-dev
2982016-08-17T23:36:24 <phantomcircuit> cfields: is travis broken?
2992016-08-17T23:36:40 <phantomcircuit> 8445 passes on my local system but not on travis and the travis failures keep changing
3002016-08-17T23:37:28 <cfields> phantomcircuit: unsure, will have a look
3012016-08-17T23:37:53 <cfields> achow101: erm, i'd say. no mention of gitian...
3022016-08-17T23:40:16 *** btcdrak has quit IRC
3032016-08-17T23:41:56 <cfields> phantomcircuit: https://github.com/bitcoin/bitcoin/issues/8532
3042016-08-17T23:50:35 <kanzure> jeremyrubin: force-pushing to your branch might be a little rude if anyone has been doing work on top of your branch. if you're pretty sure that's not happening, then go for it.
3052016-08-17T23:51:32 <gmaxwell> the question was related to PRs against master. people should not generally be doing work on top of those.
3062016-08-17T23:51:49 <gmaxwell> And we will often _require_ people to tidy up their branches before merging in any case.