12016-11-04T00:03:53  *** fengling has quit IRC
  22016-11-04T00:32:21  <murch> Does signaling start with the epoch time listed in the Deployment on BIP141 or with the first difficulty retarget after the epoch time listed in deployment?
  32016-11-04T00:37:05  <murch> Nevermind, reading BIP0009 now. :p
  42016-11-04T00:48:57  *** luke-jr has quit IRC
  52016-11-04T00:49:06  *** luke-jr has joined #bitcoin-core-dev
  62016-11-04T00:49:45  <murch> Answer is only with the next retarget, if anyone is interested. ;)
  72016-11-04T00:54:49  *** abpa has quit IRC
  82016-11-04T00:58:30  *** Victorsueca has joined #bitcoin-core-dev
  92016-11-04T00:59:39  *** roidster has joined #bitcoin-core-dev
 102016-11-04T01:00:00  *** fengling has joined #bitcoin-core-dev
 112016-11-04T01:00:23  *** echonaut6 has quit IRC
 122016-11-04T01:00:46  *** echonaut has joined #bitcoin-core-dev
 132016-11-04T01:04:54  *** Sosumi has quit IRC
 142016-11-04T01:04:56  *** fengling has quit IRC
 152016-11-04T01:07:12  <sipa> murch: indeed :)
 162016-11-04T01:08:05  <murch> sipa: So, did you have a chance to take a glimpse at my thesis? :)
 172016-11-04T01:08:09  <sipa> murch: i haven't
 182016-11-04T01:08:29  <murch> Ah, I'm really curious what you'll think.
 192016-11-04T01:09:13  <murch> (if you have time)
 202016-11-04T01:16:16  *** AtashiCon has joined #bitcoin-core-dev
 212016-11-04T01:16:58  <phantomcircuit> wumpus: can you take another look at #8831 ?
 222016-11-04T01:16:59  <gribble> https://github.com/bitcoin/bitcoin/issues/8831 | Replace CWalletDB::ReadKeyValue with CWallet::LoadKeyValue by pstratem · Pull Request #8831 · bitcoin/bitcoin · GitHub
 232016-11-04T01:17:03  <phantomcircuit> (i'm going to rebase now)
 242016-11-04T01:17:32  *** Arnavion has quit IRC
 252016-11-04T01:18:16  *** Arnavion has joined #bitcoin-core-dev
 262016-11-04T01:42:34  *** arowser has joined #bitcoin-core-dev
 272016-11-04T01:43:43  *** pigeons has quit IRC
 282016-11-04T01:51:08  *** Victorsueca has quit IRC
 292016-11-04T01:57:08  *** Giszmo has quit IRC
 302016-11-04T02:01:00  *** fengling has joined #bitcoin-core-dev
 312016-11-04T02:05:59  *** fengling has quit IRC
 322016-11-04T02:07:26  *** Chris_Stewart_5 has quit IRC
 332016-11-04T02:07:39  *** lesderid has quit IRC
 342016-11-04T02:17:54  *** btcdrak has quit IRC
 352016-11-04T02:17:56  *** pigeons has joined #bitcoin-core-dev
 362016-11-04T02:18:00  *** lesderid has joined #bitcoin-core-dev
 372016-11-04T02:18:08  *** fengling has joined #bitcoin-core-dev
 382016-11-04T02:18:17  *** murch has quit IRC
 392016-11-04T02:20:09  *** Ylbam has quit IRC
 402016-11-04T02:23:15  *** fengling has quit IRC
 412016-11-04T02:23:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 422016-11-04T02:28:30  *** fengling has joined #bitcoin-core-dev
 432016-11-04T02:41:13  *** jtimon has quit IRC
 442016-11-04T02:43:35  *** Chris_Stewart_5 has quit IRC
 452016-11-04T02:58:28  *** abpa has joined #bitcoin-core-dev
 462016-11-04T03:38:13  *** DigiByteDev has joined #bitcoin-core-dev
 472016-11-04T03:40:09  *** DigiByteDev has quit IRC
 482016-11-04T03:48:08  *** Victorsueca has joined #bitcoin-core-dev
 492016-11-04T03:50:18  <GitHub47> [bitcoin] rebroad opened pull request #9082: Fix peer selection so that non-Witness peers are still connected to (master...FixPeerSelection) https://github.com/bitcoin/bitcoin/pull/9082
 502016-11-04T03:58:29  *** PaulCape_ has quit IRC
 512016-11-04T03:58:59  *** PaulCapestany has joined #bitcoin-core-dev
 522016-11-04T04:18:02  *** PRab_ has joined #bitcoin-core-dev
 532016-11-04T04:19:10  *** PRab has quit IRC
 542016-11-04T04:19:18  *** PRab_ is now known as PRab
 552016-11-04T04:30:52  *** Victorsueca has quit IRC
 562016-11-04T04:36:01  *** Alopex has quit IRC
 572016-11-04T04:37:06  *** Alopex has joined #bitcoin-core-dev
 582016-11-04T04:51:29  *** btcdrak has joined #bitcoin-core-dev
 592016-11-04T04:51:57  *** rebroad has joined #bitcoin-core-dev
 602016-11-04T04:55:08  <rebroad> gmaxwell, in response to your comment to #9061 - it's already ignoring getheaders - this pull make it ignore less of them
 612016-11-04T04:55:10  <gribble> https://github.com/bitcoin/bitcoin/issues/9061 | Ignore getheaders prior to passing all checkpoints. by rebroad · Pull Request #9061 · bitcoin/bitcoin · GitHub
 622016-11-04T05:06:11  *** Alopex has quit IRC
 632016-11-04T05:07:17  *** Alopex has joined #bitcoin-core-dev
 642016-11-04T05:42:31  *** roidster has quit IRC
 652016-11-04T05:46:00  *** rebroad has quit IRC
 662016-11-04T05:53:06  *** Alopex has quit IRC
 672016-11-04T05:54:11  *** Alopex has joined #bitcoin-core-dev
 682016-11-04T06:02:47  *** Cheeseo has quit IRC
 692016-11-04T06:03:32  *** owowo has quit IRC
 702016-11-04T06:13:50  *** wasi has quit IRC
 712016-11-04T06:27:20  *** Victorsueca has joined #bitcoin-core-dev
 722016-11-04T06:29:04  *** rebroad has joined #bitcoin-core-dev
 732016-11-04T06:36:49  *** Ylbam has joined #bitcoin-core-dev
 742016-11-04T06:47:48  *** rebroad has quit IRC
 752016-11-04T06:50:07  *** DigiByteDev has joined #bitcoin-core-dev
 762016-11-04T06:59:22  *** rebroad has joined #bitcoin-core-dev
 772016-11-04T07:26:20  *** Victorsueca has quit IRC
 782016-11-04T07:31:51  <GitHub133> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82077ef6e49a...ed64bcec2dde
 792016-11-04T07:31:51  <GitHub133> bitcoin/master 2b175d4 John Newbery: Clean up bctest.py and bitcoin-util-test.py...
 802016-11-04T07:31:52  <GitHub133> bitcoin/master ed64bce Wladimir J. van der Laan: Merge #9069: Clean up bctest.py and bitcoin-util-test.py...
 812016-11-04T07:31:56  *** davec has quit IRC
 822016-11-04T07:32:00  <GitHub61> [bitcoin] laanwj closed pull request #9069: Clean up bctest.py and bitcoin-util-test.py (master...btutiltestcleanup) https://github.com/bitcoin/bitcoin/pull/9069
 832016-11-04T07:32:34  *** davec has joined #bitcoin-core-dev
 842016-11-04T07:47:57  *** GreenIsMyPepper has quit IRC
 852016-11-04T07:50:01  *** BashCo has quit IRC
 862016-11-04T08:10:13  *** GreenIsMyPepper has joined #bitcoin-core-dev
 872016-11-04T08:12:57  *** BashCo_ has joined #bitcoin-core-dev
 882016-11-04T08:14:52  *** rebroad has quit IRC
 892016-11-04T08:20:57  *** Victorsueca has joined #bitcoin-core-dev
 902016-11-04T08:24:15  *** kadoban has quit IRC
 912016-11-04T08:33:24  *** rebroad has joined #bitcoin-core-dev
 922016-11-04T08:41:57  *** murch has joined #bitcoin-core-dev
 932016-11-04T08:56:53  *** Victorsueca has quit IRC
 942016-11-04T08:57:17  <rebroad> wumpus, gmaxwell, just want to say thank you for all the hard work you do on bitcoin-core and apologies that I sometimes facilitate a perception of distraction from the more important duties... certainly not my intention. and apologies for the paranoia I sometimes exhibit.. I just find it so hard to understand some of your decisions but I realise you feel you have too little time to explain them fully, so it's ok
 952016-11-04T08:58:10  *** Victorsueca has joined #bitcoin-core-dev
 962016-11-04T08:59:12  <rebroad> I do sometimes wonder how much egos come into the weird dynamics I perceive on github, with various maintainers accusing people of trolling, when they are just trying to be constructive...  I think the term "trolling" is used a little too much in general and is, IMHO, a rather unnecessary "bad faith assumption", and I would quite like to see some better standards of ettiquette if possible for github, etc
 972016-11-04T09:00:06  <rebroad> but i realise we're all only human so maybe I'm setting my standards too high given the design limitation of the human race :)
 982016-11-04T09:01:05  <rebroad> I just want to see bitcoin do well. I certainly don't want to see anyone burn out.. i'd rather see more collaboration rather than empire building
 992016-11-04T09:01:41  <Victorsueca> rebroad: never seen "empire building" on core
1002016-11-04T09:01:47  <rebroad> i think some of the recent exchanges between lead deveopers between classic and core for example are all rather silly with egos getting in the way of potential collaboration which could be awesome
1012016-11-04T09:02:03  <rebroad> Victorsueca, wasn't referring specifically to core regarding that statement
1022016-11-04T09:02:17  <Victorsueca> ahh, makes more sense then
1032016-11-04T09:02:42  <rebroad> i just see too much competition.. e.g. core, classic, zcash... I think if forces were combined better (and outsiders accepted more readily) that something better could exist.
1042016-11-04T09:02:54  <rebroad> anyway, I'll get off my soapbox now
1052016-11-04T09:04:28  <rebroad> It does seem that some people are stressed... I'm not quite sure why or what's behind this. I do sometimes wonder if there are things going on in a covert attempt to sabotage the project. I'm a little concerned about the current stress levels I perceive... then again, I could also get a little less stressed when my contributions are dismissed so rapidly..!
1062016-11-04T09:04:42  <Victorsueca> actually nobody cares about classic or zcash, there's no competition at all because reasonable people just ignores them, they will eventually die like all other attempts to compete with bitcoin did so nothing to worry about and nothing we can do about
1072016-11-04T09:05:01  <rebroad> I guess it's hard to be enthused without being attached (in the buddhist sense)
1082016-11-04T09:06:16  <rebroad> Victorsueca, I hope you are right... although I do get the impression that zcash has some quite clever technology in it... but why ddn't they help put this into bitcoin instead of an alt-coin... well.. I think I already know the answer to this...  greed
1092016-11-04T09:07:30  <rebroad> anyway.. all a little OT for this channel perhaps
1102016-11-04T09:07:55  *** laurentmt has joined #bitcoin-core-dev
1112016-11-04T09:08:11  *** laurentmt has quit IRC
1122016-11-04T09:08:13  <gmaxwell> Speculating about that kind of stuff does no one any good. All you'll  do is make yourself a target of the currency speculators that are invested in that system. Not worth your time.
1132016-11-04T09:14:13  <jouke> In wallet.cpp on line 2565 I see a transaction is added to wallet, but only fails at 2582, but since it's in the wallet it get's rebroadcasted right? (which I see happening in debug log).
1142016-11-04T09:15:45  <gmaxwell> jouke: if its acceptable to the memory pool ater, then I believe so...
1152016-11-04T09:16:24  <gmaxwell> I think thats a little obnoxious, looks like it could cause the rpc to return an error but still have the txn go out. (though at least it whould show in listtransactions in the meantime)
1162016-11-04T09:16:42  <jouke> That's excactly what's happening now
1172016-11-04T09:17:03  <gmaxwell> would*
1182016-11-04T09:17:36  <gmaxwell> How did you manage to construct a txn that wasn't acceptable to the mempool at the time of construction? that in and of itself is a bug.
1192016-11-04T09:17:56  <sipa> indeed
1202016-11-04T09:18:04  <jouke> gmaxwell: just using bitcoin core 12.0
1212016-11-04T09:18:08  <sipa> i believe the source code has a "this should never happen" comment in that place
1222016-11-04T09:18:13  <jouke> sipa: indeed
1232016-11-04T09:18:30  <jouke> It's a big wallet
1242016-11-04T09:18:32  <gmaxwell> hm. we have had bugs in the past where it could happen.
1252016-11-04T09:18:48  <sipa> ah, 0.12 may have had some issue there - it had just introduced the mempool limiting, and not adapted some of the wallet code to deal with that
1262016-11-04T09:18:53  <gmaxwell> and a lot of wallet things were fixed since 0.12.0
1272016-11-04T09:19:16  <gmaxwell> not a very satisifying answer.
1282016-11-04T09:19:16  <jouke> sipa: ah, right
1292016-11-04T09:20:30  <jouke> Hmm, mempool bytes is at 10% of maxmempool
1302016-11-04T09:20:37  *** rubensayshi has joined #bitcoin-core-dev
1312016-11-04T09:20:55  <jouke> These was also a commit ten days ago that would provide more information about this happening.
1322016-11-04T09:21:05  <sipa> how large is the created txn?
1332016-11-04T09:21:08  <sipa> in bytes
1342016-11-04T09:21:46  *** gielbier has joined #bitcoin-core-dev
1352016-11-04T09:22:05  *** NielsvG has joined #bitcoin-core-dev
1362016-11-04T09:22:17  <jouke> one input, three outputs, 260 bytes
1372016-11-04T09:22:29  <jouke> no dust output
1382016-11-04T09:28:55  *** Guyver2 has joined #bitcoin-core-dev
1392016-11-04T09:30:55  <jouke> probably this: https://github.com/bitcoin/bitcoin/pull/7084
1402016-11-04T09:37:20  *** rebroad has quit IRC
1412016-11-04T09:41:07  *** jannes has joined #bitcoin-core-dev
1422016-11-04T09:44:36  <jouke> wallet with 250+ keys and working like a charm otherwise :)
1432016-11-04T09:47:11  *** AaronvanW has quit IRC
1442016-11-04T09:50:46  *** AaronvanW has joined #bitcoin-core-dev
1452016-11-04T09:51:11  *** rebroad has joined #bitcoin-core-dev
1462016-11-04T09:55:43  <NielsvG> for the record, jouke means 250k+ 😉
1472016-11-04T09:56:10  <jouke> euh, that.
1482016-11-04T09:56:31  <jouke> 250k+ unlocking takes ages
1492016-11-04T09:57:38  <jouke> anyway, great job @ core devs :)
1502016-11-04T10:05:24  *** rebroad has quit IRC
1512016-11-04T10:22:05  *** Guyver2 has quit IRC
1522016-11-04T10:39:45  <wumpus> tnx jouke :)
1532016-11-04T10:42:37  *** ibrightly has quit IRC
1542016-11-04T10:43:05  *** pindarhk has quit IRC
1552016-11-04T10:43:06  *** aspect_ has quit IRC
1562016-11-04T10:43:34  *** zmanian____ has quit IRC
1572016-11-04T10:43:34  *** sipa has quit IRC
1582016-11-04T10:43:34  *** jonasschnelli has quit IRC
1592016-11-04T10:44:02  *** blkdb has quit IRC
1602016-11-04T10:44:02  *** belcher has quit IRC
1612016-11-04T10:45:20  *** rebroad has joined #bitcoin-core-dev
1622016-11-04T10:47:16  *** zmanian____ has joined #bitcoin-core-dev
1632016-11-04T10:51:56  *** Victorsueca has quit IRC
1642016-11-04T10:52:58  *** jonasschnelli has joined #bitcoin-core-dev
1652016-11-04T10:56:47  *** belcher has joined #bitcoin-core-dev
1662016-11-04T10:56:48  *** pindarhk has joined #bitcoin-core-dev
1672016-11-04T10:57:54  *** aspect_ has joined #bitcoin-core-dev
1682016-11-04T10:58:48  *** ibrightly has joined #bitcoin-core-dev
1692016-11-04T11:05:53  *** sipa has joined #bitcoin-core-dev
1702016-11-04T11:08:45  *** rebroad has quit IRC
1712016-11-04T11:23:04  *** rebroad has joined #bitcoin-core-dev
1722016-11-04T11:29:13  *** cryptapus_afk is now known as cryptapus
1732016-11-04T11:34:10  *** jonasschnelli has quit IRC
1742016-11-04T11:34:10  *** jonasschnelli has joined #bitcoin-core-dev
1752016-11-04T11:34:33  *** fengling has quit IRC
1762016-11-04T11:40:21  *** jtimon has joined #bitcoin-core-dev
1772016-11-04T11:43:02  <jonasschnelli> 250k+ keys.. holy cow!
1782016-11-04T11:43:11  *** paveljanik has quit IRC
1792016-11-04T11:43:38  *** blkdb has joined #bitcoin-core-dev
1802016-11-04T11:58:40  *** Victorsueca has joined #bitcoin-core-dev
1812016-11-04T12:02:33  <GitHub142> [bitcoin] s-matthew-english opened pull request #9083: Enforcing consistency, 'gitian' to 'Gitian' (master...patch-9) https://github.com/bitcoin/bitcoin/pull/9083
1822016-11-04T12:10:00  *** rebroad has quit IRC
1832016-11-04T12:23:14  *** owowo has joined #bitcoin-core-dev
1842016-11-04T12:24:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1852016-11-04T12:25:47  *** laurentmt has joined #bitcoin-core-dev
1862016-11-04T12:26:04  *** laurentmt has quit IRC
1872016-11-04T12:29:41  *** Chris_Stewart_5 has quit IRC
1882016-11-04T12:40:47  *** rebroad has joined #bitcoin-core-dev
1892016-11-04T12:41:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1902016-11-04T12:47:12  *** Chris_Stewart_5 has quit IRC
1912016-11-04T12:50:34  *** Victorsueca has quit IRC
1922016-11-04T12:53:24  <jonasschnelli> Any ideas why my gitian builder (night builds) is failing?
1932016-11-04T12:53:25  <jonasschnelli> test/coins_tests.cpp:6:25: fatal error: test_random.h: No such file or directory
1942016-11-04T12:53:42  <jonasschnelli> I have in mind we did already mentioned this issue somewhere
1952016-11-04T12:53:43  <jonasschnelli> https://bitcoin.jonasschnelli.ch/nightlybuilds/2016-11-04/build-linux.log
1962016-11-04T12:59:09  *** Victorsueca has joined #bitcoin-core-dev
1972016-11-04T13:10:58  *** rebroad_ has joined #bitcoin-core-dev
1982016-11-04T13:13:28  *** rebroad has quit IRC
1992016-11-04T13:18:44  *** rebroad_ has quit IRC
2002016-11-04T13:25:30  <wumpus> jonasschnelli: I have no clue, haven't seen that error anywhere else, looks like a header file wasn't committed or not added to the makefile (so it doesn't get packaged0
2012016-11-04T13:25:52  <jonasschnelli> It's not in the Makefile.test.include
2022016-11-04T13:25:59  <jonasschnelli> But so are the other headers IMO
2032016-11-04T13:26:54  <wumpus> that could be the reason, though travis would crash on that too
2042016-11-04T13:27:15  <jonasschnelli> hmm...
2052016-11-04T13:46:17  <timothy> hi, which is the "reference" platform for bitcoin-core on linux? aka which distro and version is used with gitian to build it?
2062016-11-04T13:47:45  <jonasschnelli> timothy: Expect of libc/c++, everything is linkes statically. You should be capable of using those binaries on (almost) all linux platforms.
2072016-11-04T13:47:55  <jonasschnelli> timothy: It's built on Ubuntu trusty
2082016-11-04T13:47:59  <jonasschnelli> but portable
2092016-11-04T13:49:41  <timothy> not so portable since it can't work under alpine linux (mostly used for docker) :P I'll use ubuntu:trusty
2102016-11-04T13:55:27  *** To7 has quit IRC
2112016-11-04T13:55:39  *** roidster has joined #bitcoin-core-dev
2122016-11-04T13:57:22  <jonasschnelli> timothy: what error you get when running on alpine?
2132016-11-04T13:57:28  <timothy> alpine uses musl
2142016-11-04T13:57:34  <timothy> so no glibc
2152016-11-04T13:58:07  <jonasschnelli> Yes. That won't work.
2162016-11-04T13:58:22  <jonasschnelli> Compile it on alpine?!
2172016-11-04T14:07:42  *** rebroad has joined #bitcoin-core-dev
2182016-11-04T14:15:23  <wumpus> libraries need to be compatible with libgcc 4.4.0 and glibc 2.11
2192016-11-04T14:15:35  *** otium has joined #bitcoin-core-dev
2202016-11-04T14:15:52  <wumpus> musl or bionic, not so much
2212016-11-04T14:16:11  *** otium has left #bitcoin-core-dev
2222016-11-04T14:16:23  <otium> ……………………………….. in the year 2016 before Segwit ……………………………..
2232016-11-04T14:16:23  <otium> Thank you core dev for my new Bitcoin core node
2242016-11-04T14:16:24  <otium> it’s fast as lightning
2252016-11-04T14:16:24  <otium> it welcomes  every node thats speaks Segwit fluently
2262016-11-04T14:16:26  <otium> awesome !
2272016-11-04T14:16:26  <otium>                        ;-)
2282016-11-04T14:16:28  <otium> ………………………………………………… 2016 BS ………………………………………
2292016-11-04T14:17:09  *** abpa has quit IRC
2302016-11-04T14:17:11  <wumpus> libstdc++ is also statically linked (-static-libstdc++)
2312016-11-04T14:18:14  <wumpus> woohoo :)
2322016-11-04T14:21:33  *** Cheeseo has joined #bitcoin-core-dev
2332016-11-04T14:21:33  *** Cheeseo has joined #bitcoin-core-dev
2342016-11-04T14:47:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2352016-11-04T14:51:44  <GitHub114> [bitcoin] TheBlueMatt opened pull request #9085: Remove unused CTxOut::GetHash() (master...2016-11-remove-outpoint-hash) https://github.com/bitcoin/bitcoin/pull/9085
2362016-11-04T14:54:53  <BlueMatt> sipa: now you lost the commit message text for "Make nType and nVersion private and sometimes const"
2372016-11-04T14:55:00  <instagibbs> does a block ever set CorruptionPossible?
2382016-11-04T14:55:01  <BlueMatt> its similar text to the next commit, but not the same
2392016-11-04T14:55:08  <BlueMatt> instagibbs: it should?!
2402016-11-04T14:55:18  <instagibbs> BlueMatt, ok, rephrase, what situation :)
2412016-11-04T14:56:01  <BlueMatt> instagibbs: it refers to someone having changed the block such that it is no longer the data which the miner committed to - eg my merkle tree malleability or removing witnesses
2422016-11-04T14:56:26  <instagibbs> oh, like handing simply a bad merkle tree
2432016-11-04T14:56:26  <instagibbs> ok
2442016-11-04T14:56:47  <BlueMatt> please rename and add comments
2452016-11-04T14:56:57  <BlueMatt> it was originally names obscurely to hide a bug, but this was years ago
2462016-11-04T14:57:51  <BlueMatt> sipa: previously the corresponding commit text was "Make the various stream implementations' nType and nVersion private and const (except in CDataStream where we really need a setter)."
2472016-11-04T15:01:42  <sipa> BlueMatt: gah
2482016-11-04T15:01:50  *** Victorsueca has quit IRC
2492016-11-04T15:25:35  *** Giszmo has joined #bitcoin-core-dev
2502016-11-04T15:44:10  <instagibbs> On master running rpc tests im getting a smattering of: Unexpected exception caught during testing: Exception('bitcoind exited with status 1 during initialization',)
2512016-11-04T15:44:30  <instagibbs> basically a couple each time, some tests more prone than others, and it gets better if i run with only one thread
2522016-11-04T15:46:43  <instagibbs> I'll open an issue :)
2532016-11-04T15:49:48  *** abpa has joined #bitcoin-core-dev
2542016-11-04T15:51:15  *** cdecker has joined #bitcoin-core-dev
2552016-11-04T15:51:28  *** BonyM1 has quit IRC
2562016-11-04T15:52:15  <morcos> cfields_: did you ever look at maxuploadtarget.py failing?  i had guessed a couple months ago that it was due to your refactor and i never really dived into it.  i'm surprised no one else has had issues with it.  i can look into if if you haven't?
2572016-11-04T15:54:56  *** ryanofsky has quit IRC
2582016-11-04T15:56:07  *** kadoban has joined #bitcoin-core-dev
2592016-11-04T15:58:29  *** ryanofsky has joined #bitcoin-core-dev
2602016-11-04T16:01:30  *** To7 has joined #bitcoin-core-dev
2612016-11-04T16:05:09  *** Victorsueca has joined #bitcoin-core-dev
2622016-11-04T16:07:08  *** BonyM1 has joined #bitcoin-core-dev
2632016-11-04T16:19:57  *** jm22 has joined #bitcoin-core-dev
2642016-11-04T16:21:28  <jm22> just wanted to let you know that when importing private keys or addresses you need to add rescan after the address or the private key. for releases before 13.1 there was no need for that.
2652016-11-04T16:22:43  <sipa> jm22: what? please file an issue
2662016-11-04T16:23:59  <jm22> iam talking about importing keys or addresses with the console of bitcoin-qt.
2672016-11-04T16:25:57  <sipa> yes, i know what you are saying
2682016-11-04T16:26:06  <sipa> you should file an issue, so we don't forget
2692016-11-04T16:26:24  <jm22> I am not familiar with filing issues. there is nothing wrong just that before there was no need to specify rescan.. just wanted to help in cse someone else have the same problem
2702016-11-04T16:26:36  *** rebroad has quit IRC
2712016-11-04T16:27:19  <sipa> https://github.com/bitcoin/bitcoin/issues
2722016-11-04T16:27:34  <jm22>  ok thanks
2732016-11-04T16:27:47  <sipa> click new issue, and describe what you're typing, what you expect to happen, what really happens
2742016-11-04T16:27:59  <sipa> if the behaviour changed in 0.13.1, that is a bug
2752016-11-04T16:30:06  <jm22> the funny thing is that after you have have try to import thekey  without specifying rescan, if you try again with former release is does not work any more either
2762016-11-04T16:30:33  <sipa> ?
2772016-11-04T16:32:54  <jm22> when I run 13.1 and try imporiting a key without rescan the app freezes. now it I reboot and use a former release the same thing happen even though beforeusing 13.1 it was working.
2782016-11-04T16:34:12  <sipa> it freezes??
2792016-11-04T16:35:29  <jm22> now if I take a blockchain I updated with a former release importing the key works without rescan
2802016-11-04T16:37:13  <jm22> well I need to reboot to stop the app.
2812016-11-04T16:42:07  <sipa> how long did you wait?
2822016-11-04T16:45:05  <jm22> I have done it many times I must have waited for 1/2 or 1 hour. I cna run it again and leave it on as long as you want.
2832016-11-04T16:45:56  <jm22> the dis would work but with long pauses while when you import the disk works nonstop
2842016-11-04T16:48:55  *** murch has quit IRC
2852016-11-04T16:51:36  <sipa> and how do you fix it?
2862016-11-04T16:51:58  <sipa> "by specifying rescan"... what does that mean?
2872016-11-04T16:52:09  <sipa> do you put a 'true' after the command
2882016-11-04T16:52:22  <sipa> or do you restart with -rescan
2892016-11-04T16:54:22  <jm22> importaddress "address"    for releases before 13.1  importaddress "address" rescan    for 13.1
2902016-11-04T16:55:45  <jm22> importaddress "address" rescan works fine with former releases just that I never  put rescan
2912016-11-04T16:59:21  <sipa> just literally 'rescan' ?
2922016-11-04T16:59:28  <jm22> yes
2932016-11-04T16:59:30  <sipa> not 'true' or '1'?
2942016-11-04T16:59:39  <jm22> no nothing else
2952016-11-04T17:00:58  <sipa> the argument after address is the label to assign to ot
2962016-11-04T17:01:09  <sipa> and rescan is on by default
2972016-11-04T17:02:34  <sipa> putting rescan as a literal directly after the address has no effect but giving the imported address a label
2982016-11-04T17:02:45  <sipa> and certainly does not affect rescanning or not
2992016-11-04T17:03:03  <sipa> maybe there was some other unrelated issue that caused it to hang
3002016-11-04T17:03:24  <jm22> yes but with 13.1 it did not work for me I had to add it.
3012016-11-04T17:03:47  <sipa> i'm sorry but that makes no sensr
3022016-11-04T17:04:12  <sipa> the way you'd pass a rescan argument would be:
3032016-11-04T17:04:26  <sipa> importaddress "1abcbdaddress" "" true
3042016-11-04T17:04:33  <jm22> maybe I did something wrong however I did exactly the same with former releases and 13.1 and to make it work on 13.1 I need to write rescan.
3052016-11-04T17:05:03  <sipa> that makes no sense at all
3062016-11-04T17:05:44  <sipa> i believe you have some unrelated issue that triggers randomly, and you mistakenly believe it has anything to do with putting 'rescan' in the command
3072016-11-04T17:06:04  <sipa> anyway, if it persists, please file an issue
3082016-11-04T17:06:15  <sipa> so that more people can look into iy
3092016-11-04T17:06:34  <jm22> all I can tell you is        importaddress 1QARJNqw4QNZwiNDEu1XVqZQreRSGzvLHB rescan works on 13.1 and
3102016-11-04T17:06:46  <sipa> i urge you to try more combinations
3112016-11-04T17:06:52  <jm22> importaddress 1QARJNqw4QNZwiNDEu1XVqZQreRSGzvLHB  does not.
3122016-11-04T17:07:09  <sipa> ok, please file an issue
3132016-11-04T17:07:16  <jm22> the address is not the one I used.
3142016-11-04T17:09:05  *** jnewbery has joined #bitcoin-core-dev
3152016-11-04T17:09:43  <jm22> ok I did not mean to make a fuss I just wanted to help and sipa  I really appreciate your dedication and work
3162016-11-04T17:10:25  <sipa> i appreciate it, but saying "nothing but X" works when it's obvious it is unrelated, is not helpful
3172016-11-04T17:10:58  <sipa> i don't mean to tell you there is no problem
3182016-11-04T17:11:18  <sipa> but it has nothing to do with putting 'rescan' in the command
3192016-11-04T17:11:40  <sipa> and if you want to further resolve the problem, file an issue
3202016-11-04T17:11:47  <sipa> with the actual commands
3212016-11-04T17:13:50  <jm22> the command I gave you were exactly what I specified except I change the address.
3222016-11-04T17:14:09  <jm22> ok thanks.
3232016-11-04T17:18:32  <sipa> jm22: i believe you, but it still has nothing to do with the rescan being there. can you try a few morw times without? my expectation is that sometimes it will work and sometimes it won't
3242016-11-04T17:18:47  <sipa> jm22: if that is the case, there is a really issue we need to solve
3252016-11-04T17:19:14  <sipa> if you want to help with that, please file an issue so people can look into it in more detail than i can right now
3262016-11-04T17:20:20  <jm22> ok I will.
3272016-11-04T17:21:59  <sipa> thanks!
3282016-11-04T17:29:39  *** rubensayshi has quit IRC
3292016-11-04T17:29:43  <gmaxwell> jm22: what release do you believe what you're describing worked in? 0.13.0 ?
3302016-11-04T17:30:36  *** atroxes has quit IRC
3312016-11-04T17:38:59  *** atroxes has joined #bitcoin-core-dev
3322016-11-04T17:55:08  *** Victorsueca has quit IRC
3332016-11-04T17:55:25  *** atroxes has quit IRC
3342016-11-04T17:59:35  <jm22> gmaxwell wel    /  importaddress "address" has always worked since I have been using it, however when I troed to do it with 13.1 it would just freeze and had to reboot manually to stop it. It could be something else ofc. I will try again.
3352016-11-04T18:00:09  <sipa> jm22: but what was the last version you know of that does not have this problem?
3362016-11-04T18:01:11  <jm22> 13.0
3372016-11-04T18:02:45  <jm22> maybe it comes from the way I work since I work exclusively off line, so matbe I screwed up something I will go over that again with the different releases.
3382016-11-04T18:03:10  *** atroxes has joined #bitcoin-core-dev
3392016-11-04T18:03:14  <gmaxwell> if you are exclusively offline what are using importaddress for?
3402016-11-04T18:03:34  *** agner_io has joined #bitcoin-core-dev
3412016-11-04T18:03:35  <jm22> just to create watchonly wallets
3422016-11-04T18:04:01  <sipa> if you're offline, what are you watching?
3432016-11-04T18:04:02  <jm22> I actually really use it to import keys
3442016-11-04T18:04:26  <sipa> oh, the importaddress is on the online machine, while the private keys are on the offline one?
3452016-11-04T18:05:13  <jm22> I do both on offline, actually I almost do everything offline except for broadcasting
3462016-11-04T18:06:40  <jm22> that is why I thing bitcoin-qt is amazing and safe.
3472016-11-04T18:08:39  <sipa> then how do you learn about incoming payments?
3482016-11-04T18:09:21  <jm22> watchonly wallets
3492016-11-04T18:12:24  *** paveljanik has joined #bitcoin-core-dev
3502016-11-04T18:15:44  *** Victorsueca has joined #bitcoin-core-dev
3512016-11-04T18:19:50  *** agner_io has quit IRC
3522016-11-04T18:22:43  *** jnewbery has quit IRC
3532016-11-04T18:24:59  *** BashCo_ has quit IRC
3542016-11-04T18:26:15  *** nsh has quit IRC
3552016-11-04T18:27:52  *** nsh has joined #bitcoin-core-dev
3562016-11-04T18:37:40  <sipa> BlueMatt: fixed the commit messages... i hope
3572016-11-04T18:38:00  <BlueMatt> sipa: damn, now I lost my partial-review....fuck github
3582016-11-04T18:39:42  *** adiabat has joined #bitcoin-core-dev
3592016-11-04T18:45:14  *** BashCo has joined #bitcoin-core-dev
3602016-11-04T18:46:49  <GitHub138> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ed64bcec2dde...05009935f9ac
3612016-11-04T18:46:49  <GitHub138> bitcoin/master 190fd32 Matt Corallo: Remove unused CTxOut::GetHash()
3622016-11-04T18:46:50  <GitHub138> bitcoin/master 0500993 Pieter Wuille: Merge #9085: Remove unused CTxOut::GetHash()...
3632016-11-04T18:46:59  <GitHub147> [bitcoin] sipa closed pull request #9085: Remove unused CTxOut::GetHash() (master...2016-11-remove-outpoint-hash) https://github.com/bitcoin/bitcoin/pull/9085
3642016-11-04T18:51:55  *** Victorsueca has quit IRC
3652016-11-04T18:59:45  *** jlopp has joined #bitcoin-core-dev
3662016-11-04T19:01:25  *** jtimon has quit IRC
3672016-11-04T19:13:56  *** achow101 has quit IRC
3682016-11-04T19:13:58  <BlueMatt>  /query sipa
3692016-11-04T19:14:01  <BlueMatt> lol
3702016-11-04T19:21:50  *** achow101 has joined #bitcoin-core-dev
3712016-11-04T19:22:14  *** Victorsueca has joined #bitcoin-core-dev
3722016-11-04T19:23:29  *** f0g has quit IRC
3732016-11-04T19:47:06  *** Chris_Stewart_5 has quit IRC
3742016-11-04T20:03:03  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3752016-11-04T20:26:48  *** Victorsueca has quit IRC
3762016-11-04T20:35:11  *** Guyver2 has joined #bitcoin-core-dev
3772016-11-04T20:36:04  *** roidster has quit IRC
3782016-11-04T20:37:57  <jm22> sipa I probably screwed up something because after rebuilding a new blockchain from stored blockchain that I keep, I do not seem to have any problem with importkey that I encountered yesterday. mea culpa.
3792016-11-04T20:39:01  *** Victorsueca has joined #bitcoin-core-dev
3802016-11-04T20:42:24  *** Ylbam_ has joined #bitcoin-core-dev
3812016-11-04T20:44:35  *** jyap_ has joined #bitcoin-core-dev
3822016-11-04T20:44:56  <sipa> jm22: ok, good to hear!
3832016-11-04T20:48:33  *** Ylbam has quit IRC
3842016-11-04T20:48:34  *** jyap has quit IRC
3852016-11-04T20:48:34  *** jyap_ is now known as jyap
3862016-11-04T20:48:35  *** jyap has joined #bitcoin-core-dev
3872016-11-04T20:48:36  *** Ylbam_ is now known as Ylbam
3882016-11-04T20:48:38  *** nanotube has quit IRC
3892016-11-04T20:50:08  *** therealnanotube has joined #bitcoin-core-dev
3902016-11-04T20:53:14  *** davec has quit IRC
3912016-11-04T20:54:24  *** davec has joined #bitcoin-core-dev
3922016-11-04T21:16:22  *** e4xit has quit IRC
3932016-11-04T21:31:45  *** gabridome has quit IRC
3942016-11-04T21:48:28  *** Victorsueca has quit IRC
3952016-11-04T21:52:52  *** Victorsueca has joined #bitcoin-core-dev
3962016-11-04T21:57:55  *** jlopp has quit IRC
3972016-11-04T22:02:51  *** agner_io has joined #bitcoin-core-dev
3982016-11-04T22:05:44  *** agner_io has quit IRC
3992016-11-04T22:12:33  *** cdecker has quit IRC
4002016-11-04T22:13:21  *** aalex has quit IRC
4012016-11-04T22:13:42  *** aalex has joined #bitcoin-core-dev
4022016-11-04T22:35:01  *** cryptapus is now known as cryptapus_afk
4032016-11-04T22:40:22  *** JackH has quit IRC
4042016-11-04T22:51:55  *** JackH has joined #bitcoin-core-dev
4052016-11-04T22:56:12  *** aalex has quit IRC
4062016-11-04T22:58:32  *** aalex has joined #bitcoin-core-dev
4072016-11-04T23:06:32  *** Victorsueca has quit IRC
4082016-11-04T23:17:36  *** wasi has joined #bitcoin-core-dev
4092016-11-04T23:19:39  *** notmike has joined #bitcoin-core-dev
4102016-11-04T23:24:25  *** JackH has quit IRC
4112016-11-04T23:26:15  *** JackH has joined #bitcoin-core-dev
4122016-11-04T23:38:02  *** abpa has quit IRC
4132016-11-04T23:40:27  *** murch has joined #bitcoin-core-dev
4142016-11-04T23:46:47  *** whphhg has quit IRC
4152016-11-04T23:50:51  *** whphhg has joined #bitcoin-core-dev
4162016-11-04T23:53:33  *** jtimon has joined #bitcoin-core-dev