12016-11-14T00:34:28 *** takashi has joined #bitcoin-core-dev
22016-11-14T01:08:52 *** AaronvanW has quit IRC
32016-11-14T01:27:08 *** BCBot_ has joined #bitcoin-core-dev
42016-11-14T01:27:27 *** BCBot has quit IRC
52016-11-14T01:45:30 *** h1d has joined #bitcoin-core-dev
62016-11-14T01:49:11 *** Alopex has quit IRC
72016-11-14T01:50:16 *** Alopex has joined #bitcoin-core-dev
82016-11-14T01:52:38 *** Ylbam has quit IRC
92016-11-14T01:52:52 *** h1d has quit IRC
102016-11-14T02:00:23 *** fengling has joined #bitcoin-core-dev
112016-11-14T02:03:22 *** DigiByteDev has joined #bitcoin-core-dev
122016-11-14T02:07:23 *** DigiByteDev_ has joined #bitcoin-core-dev
132016-11-14T02:10:32 *** DigiByteDev has quit IRC
142016-11-14T02:10:33 *** DigiByteDev_ is now known as DigiByteDev
152016-11-14T02:12:08 *** DigiByteDev_ has joined #bitcoin-core-dev
162016-11-14T02:14:37 *** DigiByteDev has quit IRC
172016-11-14T02:14:50 *** DigiByteDev has joined #bitcoin-core-dev
182016-11-14T02:15:29 *** Giszmo has quit IRC
192016-11-14T02:16:52 *** moli has quit IRC
202016-11-14T02:17:58 *** DigiByteDev_ has quit IRC
212016-11-14T02:18:48 *** moli has joined #bitcoin-core-dev
222016-11-14T02:20:19 *** DigiByteDev_ has joined #bitcoin-core-dev
232016-11-14T02:23:44 *** DigiByteDev has quit IRC
242016-11-14T02:24:02 *** DigiByteDev_ is now known as DigiByteDev
252016-11-14T02:29:15 *** DigiByteDev has joined #bitcoin-core-dev
262016-11-14T02:33:27 *** Alopex has quit IRC
272016-11-14T02:33:59 *** DigiByteDev_ has joined #bitcoin-core-dev
282016-11-14T02:34:32 *** Alopex has joined #bitcoin-core-dev
292016-11-14T02:36:18 *** DigiByteDev has quit IRC
302016-11-14T02:36:19 *** DigiByteDev_ is now known as DigiByteDev
312016-11-14T02:37:17 *** DigiByteDev_ has joined #bitcoin-core-dev
322016-11-14T02:40:45 *** DigiByteDev has quit IRC
332016-11-14T02:40:58 *** DigiByteDev has joined #bitcoin-core-dev
342016-11-14T02:43:28 *** DigiByteDev_ has quit IRC
352016-11-14T02:45:02 *** Alopex has quit IRC
362016-11-14T02:45:27 *** DigiByteDev_ has joined #bitcoin-core-dev
372016-11-14T02:46:07 *** Alopex has joined #bitcoin-core-dev
382016-11-14T02:48:15 *** DigiByteDev has quit IRC
392016-11-14T02:48:55 *** DigiByteDev has joined #bitcoin-core-dev
402016-11-14T02:51:48 *** DigiByteDev_ has quit IRC
412016-11-14T02:52:44 *** DigiByteDev_ has joined #bitcoin-core-dev
422016-11-14T02:55:48 *** DigiByteDev has quit IRC
432016-11-14T02:56:30 *** DigiByteDev has joined #bitcoin-core-dev
442016-11-14T02:58:01 *** btcdrak has quit IRC
452016-11-14T02:59:15 *** DigiByteDev_ has quit IRC
462016-11-14T02:59:57 *** DigiByteDev_ has joined #bitcoin-core-dev
472016-11-14T03:03:00 *** DigiByteDev has quit IRC
482016-11-14T03:03:49 *** DigiByteDev has joined #bitcoin-core-dev
492016-11-14T03:06:13 *** DigiByteDev_ has quit IRC
502016-11-14T03:06:42 *** DigiByteDev_ has joined #bitcoin-core-dev
512016-11-14T03:09:25 *** DigiByteDev has quit IRC
522016-11-14T03:10:23 *** DigiByteDev has joined #bitcoin-core-dev
532016-11-14T03:13:20 *** DigiByteDev_ has quit IRC
542016-11-14T03:15:00 *** DigiByteDev has quit IRC
552016-11-14T03:33:48 *** jtimon has quit IRC
562016-11-14T03:42:26 *** kadoban has joined #bitcoin-core-dev
572016-11-14T04:18:14 *** DigiByteDev has joined #bitcoin-core-dev
582016-11-14T04:21:52 *** DigiByteDev_ has joined #bitcoin-core-dev
592016-11-14T04:25:13 *** DigiByteDev has quit IRC
602016-11-14T04:25:46 *** DigiByteDev has joined #bitcoin-core-dev
612016-11-14T04:28:18 *** DigiByteDev_ has quit IRC
622016-11-14T04:29:15 *** DigiByteDev_ has joined #bitcoin-core-dev
632016-11-14T04:32:00 *** DigiByteDev has quit IRC
642016-11-14T04:33:01 *** DigiByteDev has joined #bitcoin-core-dev
652016-11-14T04:35:41 *** DigiByteDev_ has quit IRC
662016-11-14T04:37:47 *** DigiByteDev_ has joined #bitcoin-core-dev
672016-11-14T04:40:22 *** DigiByteDev has quit IRC
682016-11-14T04:42:01 *** Alopex has quit IRC
692016-11-14T04:43:07 *** Alopex has joined #bitcoin-core-dev
702016-11-14T04:54:16 *** dcousens has joined #bitcoin-core-dev
712016-11-14T04:55:06 <dcousens> with P2WSH, can the scriptSig have non-push opcodes?
722016-11-14T04:55:20 <dcousens> (the witness script Sig... "stack")
732016-11-14T04:56:04 <dcousens> I'm looking at https://github.com/bitcoin/bitcoin/blob/e81df49644c21f835e25028ab4643aa9bf5ae8da/src/script/interpreter.cpp#L1367-L1397, and it appears that it can
742016-11-14T04:59:10 <dcousens> nevermind... its treated as stack not CScript, my bad
752016-11-14T04:59:40 <aj> dcousens: yeah, the first item on the stack is the program which gets converted to a CScript, but that's it... ?
762016-11-14T04:59:50 <dcousens> last item*?
772016-11-14T05:00:09 *** kadoban has quit IRC
782016-11-14T05:02:28 <sipa> last, indeed
792016-11-14T05:02:31 <sipa> top of the stack
802016-11-14T05:07:57 *** aalex has joined #bitcoin-core-dev
812016-11-14T05:13:01 *** Alopex has quit IRC
822016-11-14T05:14:06 *** Alopex has joined #bitcoin-core-dev
832016-11-14T05:18:18 *** DigiByteDev_ has quit IRC
842016-11-14T05:24:06 *** Alopex has quit IRC
852016-11-14T05:25:12 *** Alopex has joined #bitcoin-core-dev
862016-11-14T05:25:26 <aj> eh, i'm australian, can you blame me if i look at stacks upside down?
872016-11-14T05:28:36 *** DigiByteDev has joined #bitcoin-core-dev
882016-11-14T05:33:47 *** DigiByteDev_ has joined #bitcoin-core-dev
892016-11-14T05:35:44 <bitcoin-git> [bitcoin] XertroV opened pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154
902016-11-14T05:36:10 *** DigiByteDev has quit IRC
912016-11-14T05:36:33 <bitcoin-git> [bitcoin] fanquake closed pull request #9154: Add recent checkpoints to remove CPU load during sync (master...f/new-checkpoints) https://github.com/bitcoin/bitcoin/pull/9154
922016-11-14T05:38:13 *** DigiByteDev_ has quit IRC
932016-11-14T05:39:35 *** DigiByteDev has joined #bitcoin-core-dev
942016-11-14T05:43:21 *** aalex has quit IRC
952016-11-14T06:10:06 *** Alopex has quit IRC
962016-11-14T06:10:35 *** fengling has quit IRC
972016-11-14T06:11:01 *** paveljanik has quit IRC
982016-11-14T06:11:11 *** Alopex has joined #bitcoin-core-dev
992016-11-14T06:12:04 *** btcdrak has joined #bitcoin-core-dev
1002016-11-14T06:13:03 *** fengling has joined #bitcoin-core-dev
1012016-11-14T06:21:01 *** Alopex has quit IRC
1022016-11-14T06:22:06 *** Alopex has joined #bitcoin-core-dev
1032016-11-14T06:29:40 *** Ylbam has joined #bitcoin-core-dev
1042016-11-14T06:40:16 *** Alopex has quit IRC
1052016-11-14T06:41:21 *** Alopex has joined #bitcoin-core-dev
1062016-11-14T06:44:22 <bitcoin-git> [bitcoin] carryforward opened pull request #9155: [trivial] update comments for tx weight (master...master) https://github.com/bitcoin/bitcoin/pull/9155
1072016-11-14T06:52:59 *** thokon00 has quit IRC
1082016-11-14T06:53:07 *** thokon00 has joined #bitcoin-core-dev
1092016-11-14T07:27:49 *** DigiByteDev has quit IRC
1102016-11-14T07:36:23 *** wolfspraul has quit IRC
1112016-11-14T07:37:11 *** cjcj has joined #bitcoin-core-dev
1122016-11-14T07:46:33 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/87ab49e4fe38...924745dd6f5f
1132016-11-14T07:46:34 <bitcoin-git> bitcoin/master fa42e4a MarcoFalke: [qt] Make network disabled icon 50% opaque
1142016-11-14T07:46:34 <bitcoin-git> bitcoin/master 924745d Jonas Schnelli: Merge #9145: [qt] Make network disabled icon 50% opaque...
1152016-11-14T07:46:43 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9145: [qt] Make network disabled icon 50% opaque (master...Mf1611-qtNetworkIcon) https://github.com/bitcoin/bitcoin/pull/9145
1162016-11-14T07:54:12 <gmaxwell> Anyone know where I can go to sign this? http://imgur.com/a/iv3m6 doesn't say much but it's pretty unobjectionable.
1172016-11-14T07:57:11 <btcdrak> gmaxwell: no no, we're not allowed to sign that, because it's Roger Ver's attempt to snub Bitcoin Core. Looks like a more watered down version of the first leak http://pastebin.com/cgkqcWBS.
1182016-11-14T07:58:47 <luke-jr> gmaxwell: I emailed them a few days ago asking and got no response
1192016-11-14T08:09:16 *** Alopex has quit IRC
1202016-11-14T08:10:21 *** Alopex has joined #bitcoin-core-dev
1212016-11-14T08:11:56 <jonasschnelli> bench gives me something like: SHA256,36,0.030114054679871,0.032101750373840,0.031019667784373
1222016-11-14T08:12:01 <jonasschnelli> Are the time values in ms?
1232016-11-14T08:12:20 <jonasschnelli> And is the time value * count or per a single execution?
1242016-11-14T08:14:25 <gmaxwell> microseconds, IIRC. and not per count, count is already divided out.
1252016-11-14T08:14:59 <wumpus> count is divided out otherwise it'd be entirely pointless :) I don't know the unit hough
1262016-11-14T08:15:48 <wumpus> the header row should really have unit indicators [ms] [s] or such
1272016-11-14T08:16:15 <wumpus> appears to be seconds, looking at the code
1282016-11-14T08:17:03 <gmaxwell> indeed.
1292016-11-14T08:17:48 <gmaxwell> ... 30 microseconds is absurdly slow for sha256 unless that is testing someting non-obvious.
1302016-11-14T08:18:15 <wumpus> doesn't it depend on how much data it is hashing per run?
1312016-11-14T08:18:39 <gmaxwell> er 30 milliseconds.
1322016-11-14T08:18:46 <gmaxwell> Yes, if it's a lot of data, indeed.
1332016-11-14T08:18:59 <wumpus> and yes, hashing benchmarks are best expressed in MB/s or such
1342016-11-14T08:19:41 <wumpus> would make sense at some point to split the bench into multiple tables, with one for hashing and CRCing algos
1352016-11-14T08:20:18 <gmaxwell> sometimes we care about the time to hash a minimum size piece of data: thats the sigcache case, the hashes inside the hashtree, etc.
1362016-11-14T08:20:39 <jonasschnelli> Then am I correct when I say for the values above it takes in avg 30ns per hash (need to lookup how mach data being hash)?
1372016-11-14T08:20:58 <wumpus> right, probably there should be a specific benchmark for that
1382016-11-14T08:21:06 <jonasschnelli> (what I'm trying to do is to compare it against ChaCha20Poly1305AEAD per byte at the end)
1392016-11-14T08:21:38 <wumpus> well in that case you should absolutely compare MB/s not anything else
1402016-11-14T08:21:41 <gmaxwell> jonasschnelli: no, it's seconds, and it's saying it takes 31 milliseconds for however much it's hashing (presumably a lot or something is broken)
1412016-11-14T08:21:41 <jonasschnelli> BUFFER_SIZE = 1000*1000; (for the hash test)
1422016-11-14T08:22:43 <jonasschnelli> 31 milliseconds per 1MB, right?
1432016-11-14T08:22:44 <wumpus> e.g. something like I did here https://github.com/laanwj/crcbench
1442016-11-14T08:23:01 <jonasschnelli> wumpus: thanks..
1452016-11-14T08:23:21 <wumpus> jonasschnelli: yes
1462016-11-14T08:24:28 <wumpus> 1000*1000/0.031019667784373 -> 32,237,611 bytes per second
1472016-11-14T08:26:18 *** rubensayshi has joined #bitcoin-core-dev
1482016-11-14T08:26:21 <gmaxwell> jonasschnelli: sounds like it, yes. which is only 32.2 MB/s which sounds quite slow.
1492016-11-14T08:26:49 <jonasschnelli> -O0
1502016-11-14T08:26:55 <gmaxwell> openssl speed sha256 on my sluggish laptop says 96,185,000 bytes/s.
1512016-11-14T08:26:59 <gmaxwell> oh okay.
1522016-11-14T08:27:15 <gmaxwell> well you -O0 is "make bencmarks worthless" :P
1532016-11-14T08:27:18 <jonasschnelli> It's not the numbers i want to compare, just for understanding
1542016-11-14T08:27:22 <wumpus> why would you compare benchmarks with O0?!
1552016-11-14T08:27:33 <gmaxwell> s/you// :)
1562016-11-14T08:27:42 <jonasschnelli> I just don't wanted to configure/compile again. :-)
1572016-11-14T08:27:52 <jonasschnelli> Will to the benchmark on a different machine... and fix the clock, etc.
1582016-11-14T08:28:23 <jonasschnelli> I guess benchmark on a Mac laptop with tons of applications open doesn't really make sense.
1592016-11-14T08:28:27 <gmaxwell> Just don't use the results for _anything_ O0 radically changes the performance profile of different code.
1602016-11-14T08:28:43 <jonasschnelli> Yes. I learned that from my IBD benchmarks. :)
1612016-11-14T08:32:12 <gmaxwell> on the same sluggish laptop mentioned above our bench returns 0.02038276 which is about 49.06 milillion bytes/sec. So I suppose thats about what I'd expect vs OpenSSL given that we know our sha256 is slower than the faster ones using SSE2.
1622016-11-14T08:41:57 *** aalex has joined #bitcoin-core-dev
1632016-11-14T08:48:15 *** aalex has quit IRC
1642016-11-14T08:51:20 <jonasschnelli> SHA -O3 on Skylark: SHA256,256,0.002107024192810,0.004232339560986,0.004217050969601
1652016-11-14T08:51:50 <jonasschnelli> Same setup, ChaCha20Poly1305@openssh (own draft implementation): 0.00278858
1662016-11-14T08:52:01 *** Ginnarr has joined #bitcoin-core-dev
1672016-11-14T08:53:06 *** Ginnarr has quit IRC
1682016-11-14T08:53:09 <gmaxwell> hm. thats not that impressive!
1692016-11-14T08:53:24 <jonasschnelli> Well.. faster then I have expected.
1702016-11-14T08:53:27 *** Ginnarr has joined #bitcoin-core-dev
1712016-11-14T08:53:54 <gmaxwell> run "openssl speed sha256" on the same hardware.
1722016-11-14T08:54:02 * jonasschnelli doing...
1732016-11-14T08:54:30 <jonasschnelli> sha256 64116.34k 140875.75k 245123.77k 296262.31k 320731.87k
1742016-11-14T08:55:52 <jonasschnelli> I took the ChaCha20Poly1305 from openssh: https://github.com/jonasschnelli/chacha20poly1305
1752016-11-14T08:56:02 <gmaxwell> okay, bitcoin's sha256 is 237.1 million bytes per second, openssl is 320.7 million bytes per second.. and the chacha is 358.6 million bytes per second. (openssl at slight disadvantage due to 8k vs 1m size, but it doesn't matter much)
1762016-11-14T08:57:24 <gmaxwell> okay, not so bad, encrypt+auth, about 11% faster than highly optimized sha256 alone for large blocks. IIRC the chacha/poly will have a bigger advantage for smaller messages.
1772016-11-14T08:57:45 <jonasschnelli> Yes. Thats true.
1782016-11-14T08:57:57 <gmaxwell> and better, it should wipe the floor with sha256 on arm.
1792016-11-14T08:58:08 <jonasschnelli> Also, i'm not sure about the constant time properties of chacha20 here: https://github.com/jonasschnelli/chacha20poly1305/blob/master/chacha.c
1802016-11-14T09:03:01 <gmaxwell> quick glance through shows all that to be constant time (other than the number of bytes going into it, of course) ... and the position counter carry. (odd that they did that, but it's just a counter)
1812016-11-14T09:05:25 *** moli has quit IRC
1822016-11-14T09:06:22 *** Ginnarr has quit IRC
1832016-11-14T09:08:18 <jonasschnelli> gmaxwell: I guess the implementation above is more or less from DJB itself.
1842016-11-14T09:08:41 <jonasschnelli> not sure if the openssh guys did modificate it, though
1852016-11-14T09:08:47 *** aalex has joined #bitcoin-core-dev
1862016-11-14T09:09:43 <gmaxwell> it looks fine to me.
1872016-11-14T09:11:38 *** DigiByteDev has joined #bitcoin-core-dev
1882016-11-14T09:13:43 *** Ginnarr has joined #bitcoin-core-dev
1892016-11-14T09:14:17 *** jannes has joined #bitcoin-core-dev
1902016-11-14T09:14:49 *** shesek has joined #bitcoin-core-dev
1912016-11-14T09:15:05 *** aalex has quit IRC
1922016-11-14T09:22:09 *** luke-jr has quit IRC
1932016-11-14T09:22:29 *** luke-jr has joined #bitcoin-core-dev
1942016-11-14T09:27:38 *** Ginnarr has quit IRC
1952016-11-14T09:30:29 *** Ginnarr has joined #bitcoin-core-dev
1962016-11-14T09:33:08 *** Ginnarr has quit IRC
1972016-11-14T09:34:29 *** Guyver2 has joined #bitcoin-core-dev
1982016-11-14T09:34:39 *** DigiByteDev has quit IRC
1992016-11-14T09:36:02 *** laurentmt has joined #bitcoin-core-dev
2002016-11-14T09:39:16 *** laurentmt has quit IRC
2012016-11-14T09:42:58 *** arinaga has quit IRC
2022016-11-14T09:52:17 *** AaronvanW has joined #bitcoin-core-dev
2032016-11-14T09:52:17 *** AaronvanW has quit IRC
2042016-11-14T09:52:17 *** AaronvanW has joined #bitcoin-core-dev
2052016-11-14T09:59:08 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9156: Add compile and link options echo to configure (master...2016/11/configure) https://github.com/bitcoin/bitcoin/pull/9156
2062016-11-14T11:33:43 *** fengling has quit IRC
2072016-11-14T11:34:34 *** moli has joined #bitcoin-core-dev
2082016-11-14T12:03:28 *** JackH has quit IRC
2092016-11-14T12:06:18 *** JackH has joined #bitcoin-core-dev
2102016-11-14T12:07:14 *** Giszmo has joined #bitcoin-core-dev
2112016-11-14T12:30:42 *** fengling has joined #bitcoin-core-dev
2122016-11-14T12:32:49 *** windsok has quit IRC
2132016-11-14T12:35:23 *** fengling has quit IRC
2142016-11-14T13:02:59 *** takashi has quit IRC
2152016-11-14T13:07:37 *** jtimon has joined #bitcoin-core-dev
2162016-11-14T13:15:30 *** windsok has joined #bitcoin-core-dev
2172016-11-14T13:18:45 *** kadoban has joined #bitcoin-core-dev
2182016-11-14T13:31:44 *** fengling has joined #bitcoin-core-dev
2192016-11-14T13:32:24 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2202016-11-14T13:36:26 *** fengling has quit IRC
2212016-11-14T14:03:12 *** paveljanik has joined #bitcoin-core-dev
2222016-11-14T14:25:21 *** aalex has joined #bitcoin-core-dev
2232016-11-14T14:25:44 *** aalex_ has joined #bitcoin-core-dev
2242016-11-14T14:30:52 *** Chris_Stewart_5 has quit IRC
2252016-11-14T14:32:43 *** fengling has joined #bitcoin-core-dev
2262016-11-14T14:38:06 *** fengling has quit IRC
2272016-11-14T14:44:06 *** aalex_ has quit IRC
2282016-11-14T14:49:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2292016-11-14T14:51:03 *** Chris_Stewart_5 has quit IRC
2302016-11-14T14:54:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2312016-11-14T15:14:13 *** murch has joined #bitcoin-core-dev
2322016-11-14T15:14:28 *** cryptapus_afk has quit IRC
2332016-11-14T15:21:14 *** cryptapus has joined #bitcoin-core-dev
2342016-11-14T15:33:59 *** fengling has joined #bitcoin-core-dev
2352016-11-14T15:36:06 *** Lauda has quit IRC
2362016-11-14T15:37:31 *** Chris_Stewart_5 has quit IRC
2372016-11-14T15:39:09 *** fengling has quit IRC
2382016-11-14T15:41:33 *** murchandamus has joined #bitcoin-core-dev
2392016-11-14T15:42:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2402016-11-14T15:43:36 *** murch has quit IRC
2412016-11-14T15:44:35 *** Micha|iPhone has joined #bitcoin-core-dev
2422016-11-14T15:44:36 *** Micha|iPhone has left #bitcoin-core-dev
2432016-11-14T15:51:09 *** Chris_Stewart_5 has quit IRC
2442016-11-14T15:53:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2452016-11-14T16:03:22 *** Lauda has joined #bitcoin-core-dev
2462016-11-14T16:08:18 *** achow101_ has joined #bitcoin-core-dev
2472016-11-14T16:13:08 *** Chris_Stewart_5 has quit IRC
2482016-11-14T16:13:18 *** cryptapus_ has joined #bitcoin-core-dev
2492016-11-14T16:13:19 *** cryptapus_ has joined #bitcoin-core-dev
2502016-11-14T16:16:03 *** cryptapus_ has quit IRC
2512016-11-14T16:16:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2522016-11-14T16:19:54 *** achow101 has quit IRC
2532016-11-14T16:20:18 *** achow101_ is now known as achow101
2542016-11-14T16:20:38 *** achow101 has joined #bitcoin-core-dev
2552016-11-14T16:36:02 *** fengling has joined #bitcoin-core-dev
2562016-11-14T16:36:16 *** achow101 has quit IRC
2572016-11-14T16:38:35 *** achow101 has joined #bitcoin-core-dev
2582016-11-14T16:40:49 *** fengling has quit IRC
2592016-11-14T17:00:20 *** rubensayshi has quit IRC
2602016-11-14T17:20:19 *** abpa has joined #bitcoin-core-dev
2612016-11-14T17:37:04 *** fengling has joined #bitcoin-core-dev
2622016-11-14T17:37:38 *** aalex has quit IRC
2632016-11-14T17:39:50 *** aalex has joined #bitcoin-core-dev
2642016-11-14T17:41:52 *** fengling has quit IRC
2652016-11-14T17:47:09 <bitcoin-git> [bitcoin] Leviathn opened pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
2662016-11-14T18:07:08 *** wolfspraul has joined #bitcoin-core-dev
2672016-11-14T18:07:43 *** wolfspraul has joined #bitcoin-core-dev
2682016-11-14T18:17:10 <bitcoin-git> [bitcoin] Leviathn closed pull request #9158: Removal of "free transaction" logic from codebase (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9158
2692016-11-14T18:22:25 *** Chris_Stewart_5 has quit IRC
2702016-11-14T18:23:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2712016-11-14T18:25:07 *** laurentmt has joined #bitcoin-core-dev
2722016-11-14T18:25:36 *** laurentmt has quit IRC
2732016-11-14T18:35:51 <sdaftuar> sipa: are you planning to PR the rest of your shared-ptr-all-the-things branch soon?
2742016-11-14T18:37:41 <sdaftuar> i have a change to the way we manage the mempool during reorgs, which i think would make sense to rebase on to your branch, wasn't sure if i should use #9125 or some later commit in your branch
2752016-11-14T18:37:43 <gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
2762016-11-14T18:38:04 *** fengling has joined #bitcoin-core-dev
2772016-11-14T18:43:32 *** fengling has quit IRC
2782016-11-14T18:43:43 <sipa> sdaftuar: several parts of that branch are included in #8580 now
2792016-11-14T18:43:45 <gribble> https://github.com/bitcoin/bitcoin/issues/8580 | Make CTransaction actually immutable by sipa · Pull Request #8580 · bitcoin/bitcoin · GitHub
2802016-11-14T18:44:09 <sipa> there is one more commit that makes ATMT take a shared_ptr
2812016-11-14T18:46:03 <sdaftuar> yeah i was thinking i'd rebase on that one, as that'll help during processing of reorg'ed out transactions as well
2822016-11-14T18:46:09 *** Chris_Stewart_5 has quit IRC
2832016-11-14T18:49:16 <sipa> i could just push the one remaining patch into 8580, but it's already quite big
2842016-11-14T18:50:20 <sdaftuar> no problem, i can be patient (and help review!)
2852016-11-14T18:51:15 <sipa> i'll run a benchmark for those PRs soon
2862016-11-14T19:01:11 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9159: [qa] Wait for specific block announcement in p2p-compactblocks (master...cmpct-announce-wait) https://github.com/bitcoin/bitcoin/pull/9159
2872016-11-14T19:02:43 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2882016-11-14T19:03:21 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9160: [trivial] Fix hungarian variable name (master...hungarian) https://github.com/bitcoin/bitcoin/pull/9160
2892016-11-14T19:26:55 *** Victorsueca has quit IRC
2902016-11-14T19:28:15 *** MarcoFalke has joined #bitcoin-core-dev
2912016-11-14T19:28:18 *** Victorsueca has joined #bitcoin-core-dev
2922016-11-14T19:28:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/924745dd6f5f...b42291334651
2932016-11-14T19:28:59 <bitcoin-git> bitcoin/master fd6bb70 Russell Yanofsky: [qa] Improve sync_blocks error messages.
2942016-11-14T19:28:59 <bitcoin-git> bitcoin/master 05e57cc Russell Yanofsky: [qa] Fix sync_blocks timeout argument...
2952016-11-14T19:29:00 <bitcoin-git> bitcoin/master 7943b13 Russell Yanofsky: [qa] Avoid 2 list comprehensions in sync_blocks
2962016-11-14T19:29:08 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9136: sync_blocks cleanup (master...sync-clean) https://github.com/bitcoin/bitcoin/pull/9136
2972016-11-14T19:31:17 *** eenoch has quit IRC
2982016-11-14T19:31:20 *** aj has quit IRC
2992016-11-14T19:37:47 *** wasi has quit IRC
3002016-11-14T19:39:12 *** wasi has joined #bitcoin-core-dev
3012016-11-14T19:39:23 *** fengling has joined #bitcoin-core-dev
3022016-11-14T19:44:35 *** fengling has quit IRC
3032016-11-14T19:46:55 *** aj has joined #bitcoin-core-dev
3042016-11-14T19:47:15 *** eenoch has joined #bitcoin-core-dev
3052016-11-14T20:00:57 *** belcher has quit IRC
3062016-11-14T20:13:51 *** belcher has joined #bitcoin-core-dev
3072016-11-14T20:17:55 *** belcher has quit IRC
3082016-11-14T20:26:50 <morcos> What is the assumption for how the wallet supports txs for which some of the inputs are yours and some aren't?
3092016-11-14T20:26:58 <morcos> I'm asking in context of the bumpfee command.
3102016-11-14T20:27:40 <morcos> In particular is there a way to identify such wallet txs?
3112016-11-14T20:40:26 *** fengling has joined #bitcoin-core-dev
3122016-11-14T20:40:26 <morcos> As a crutch instead of properly supporting such txs, would people accept a wallet function IsAllFromMe(filter), that let you know if all of the inputs were from you? so you'd know if your calculation of Debits was correct
3132016-11-14T20:41:40 <morcos> I'd use this in bumpfee to just do nothing if not all the inputs were from you, and in listtransactions and gettransaction to not output an erroneous fee calculation
3142016-11-14T20:45:38 *** fengling has quit IRC
3152016-11-14T20:55:16 <Victorsueca> what about this:
3162016-11-14T20:55:57 <Victorsueca> instead of using the IsMine logic, when the bumpfee command is issued then check whether the needed private keys are available
3172016-11-14T20:58:05 <Victorsueca> if not available then assume the transaction was not involve the user in a way that allows him to use bumpfee
3182016-11-14T20:58:12 <Victorsueca> does*
3192016-11-14T20:59:07 <Victorsueca> sounds less resource-consuming than checking the IsMine logic
3202016-11-14T21:03:43 <morcos> The problem is even if you have all the keys to sign the tx, if not all the inputs are you, you can't actually calculate the proper fee.
3212016-11-14T21:04:07 <morcos> This is why listtransactions and gettransaction return erroneous results
3222016-11-14T21:41:35 *** fengling has joined #bitcoin-core-dev
3232016-11-14T21:46:41 *** fengling has quit IRC
3242016-11-14T22:07:13 *** Guyver2 has quit IRC
3252016-11-14T22:42:36 *** fengling has joined #bitcoin-core-dev
3262016-11-14T22:45:10 *** MarcoFalke has left #bitcoin-core-dev
3272016-11-14T22:45:55 <Victorsueca> what would be the appropriate way to suggest a new GUI feature?
3282016-11-14T22:46:36 *** cryptapus is now known as cryptapus_afk
3292016-11-14T22:47:44 *** fengling has quit IRC
3302016-11-14T22:56:50 *** go1111111 has joined #bitcoin-core-dev
3312016-11-14T23:10:59 *** shinyg has joined #bitcoin-core-dev
3322016-11-14T23:36:49 *** belcher has joined #bitcoin-core-dev
3332016-11-14T23:37:56 *** dcousens has quit IRC
3342016-11-14T23:43:56 *** fengling has joined #bitcoin-core-dev
3352016-11-14T23:48:47 *** fengling has quit IRC
3362016-11-14T23:52:31 <shinyg> Hi people, I was after a little assistance from those who know more about Bitcoin Core and those who support Wikipedia.
3372016-11-14T23:53:16 <shinyg> I have recently expanded the Wikipedia article for Bitcoin Core by a factor of 10. Could someone spend just a few minutes to see if there are any major ommission or errors?
3382016-11-14T23:54:53 <shinyg> I have almost no programming skills so I ask here because I imagine there are a few experts around, apologies if this is too off-topic
3392016-11-14T23:56:58 <achow101> shinyg: blockstream does not fund Bitcoin Core development at all. There are developers who work on Bitcoin Core who also have jobs at Blockstream. The people who actually partially fund development are the MIT DCI who actually pay some people to work on Core (wladimir, cory)
3402016-11-14T23:57:40 <shinyg> got it
3412016-11-14T23:58:10 *** tulip has joined #bitcoin-core-dev
3422016-11-14T23:58:20 <achow101> also, IIRC bitcoin.org and the bitcoin foundation are no longer related