12016-11-15T00:08:56 *** jannes has quit IRC
22016-11-15T00:25:50 *** trippysa1mon has quit IRC
32016-11-15T00:44:38 *** trippysalmon has joined #bitcoin-core-dev
42016-11-15T00:45:07 *** fengling has joined #bitcoin-core-dev
52016-11-15T00:46:00 <sipa> achow101: i believe they never have been
62016-11-15T00:49:06 <achow101> well they're listed here: https://bitcoin.org/en/about-us#sponsorship
72016-11-15T00:49:50 *** fengling has quit IRC
82016-11-15T00:57:33 *** DigiByteDev has joined #bitcoin-core-dev
92016-11-15T00:59:28 *** Chris_Stewart_5 has quit IRC
102016-11-15T01:03:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
112016-11-15T01:08:04 *** DigiByteDev has quit IRC
122016-11-15T01:13:21 <shinyg> so was there a specific reason why new releases stopped coming from bitcoin.org?
132016-11-15T01:13:49 *** Chris_Stewart_5 has quit IRC
142016-11-15T01:13:55 <sipa> they're still published there
152016-11-15T01:14:10 <sipa> but bitcoin core has its own project website now
162016-11-15T01:14:26 <achow101> they're trying to separate bitcoin core from bitcoin.org as bitcoin.org is for bitcoin in general whilst bitcoin core is a specific project
172016-11-15T01:15:09 <shinyg> makes sense, how about is Bitcoin Core a Solution stack or software as some describe it/
182016-11-15T01:16:08 *** DigiByteDev has joined #bitcoin-core-dev
192016-11-15T01:17:11 <shinyg> Maybe bitcoin is a software stack but Core is just software
202016-11-15T01:20:51 *** DigiByteDev has quit IRC
212016-11-15T01:28:17 <Squidicuz> sipa, cool. I take it that site is bitcoincore.org, right?
222016-11-15T01:28:39 <achow101> Squidicuz: yes, bitcoincore.org is Bitcoin Core's site
232016-11-15T01:29:10 <Squidicuz> just double checking. ty
242016-11-15T01:29:12 <Squidicuz> :)
252016-11-15T01:29:26 <tulip> shinyg: with tools like gitian there's no real need for a canonical binary source.
262016-11-15T01:31:17 <Squidicuz> ...I'm a little late
272016-11-15T01:43:03 *** DigiByteDev has joined #bitcoin-core-dev
282016-11-15T01:43:55 <moli> sipa, hi, could you update your graph?
292016-11-15T01:45:29 <sipa> which?
302016-11-15T01:45:37 <achow101> bip9 bits graph
312016-11-15T01:45:48 <sipa> oh, will do
322016-11-15T01:45:54 <sipa> before the 18th
332016-11-15T01:46:07 *** fengling has joined #bitcoin-core-dev
342016-11-15T01:46:14 <moli> ah still too early? ok, thanks, sipa :)
352016-11-15T01:46:33 <sipa> yes, first retarget after the 15th midnight utc
362016-11-15T01:46:35 <achow101> miners can signal now, right? just that it won't matter because the retarget period is almsot over
372016-11-15T01:46:49 <btcdrak> at this rate of acceleration it might just at the end of 17th...
382016-11-15T01:46:53 <sipa> them signalling right now will trigger the unknown softfork warning
392016-11-15T01:47:24 <achow101> oh, that's interesting
402016-11-15T01:47:46 <btcdrak> sipa: would those trigger while in the defined state?
412016-11-15T01:48:10 <btcdrak> oh nvm, ofc it will trigger, derp
422016-11-15T01:48:33 *** DigiByteDev_ has joined #bitcoin-core-dev
432016-11-15T01:48:36 *** DigiByteDev has quit IRC
442016-11-15T01:48:37 <achow101> why would it trigger?
452016-11-15T01:48:37 *** DigiByteDev_ is now known as DigiByteDev
462016-11-15T01:50:48 <achow101> oh, is it because it is still in the defined state, not started?
472016-11-15T01:50:53 <sipa> indeed
482016-11-15T01:50:53 *** fengling has quit IRC
492016-11-15T01:51:09 <sipa> so it would be seen as signalling for an unrelated fork
502016-11-15T01:52:04 <sipa> which the current software does not know about
512016-11-15T01:52:23 <achow101> why are the two graphs on the segwit adoption page on opposite ends of the page? also, chrome is super not liking that sipa's website doesn't have https for those graphs
522016-11-15T01:52:38 *** Ylbam has quit IRC
532016-11-15T01:54:35 *** abpa has quit IRC
542016-11-15T02:00:24 *** DigiByteDev_ has joined #bitcoin-core-dev
552016-11-15T02:00:28 *** DigiByteDev has quit IRC
562016-11-15T02:07:13 <shinyg> thanks for the replies sipa and wiki contribs achow
572016-11-15T02:07:18 *** shinyg has quit IRC
582016-11-15T02:20:01 *** DigiByteDev has joined #bitcoin-core-dev
592016-11-15T02:24:21 *** blkdb has quit IRC
602016-11-15T02:24:29 *** blkdb has joined #bitcoin-core-dev
612016-11-15T02:33:24 *** Victor_sueca has joined #bitcoin-core-dev
622016-11-15T02:35:55 *** Victorsueca has quit IRC
632016-11-15T02:47:11 *** fengling has joined #bitcoin-core-dev
642016-11-15T02:51:21 * jtimon pushed jtimon/0.13-blocksign-latest on top of jtimon/0.13-blocksign on top of jtimon/0.13-new-testchain on top of jtimon/0.13-chainparams-factory eb6c595e on top of origin/master 924745dd
652016-11-15T02:51:56 *** fengling has quit IRC
662016-11-15T02:52:14 *** crudel has joined #bitcoin-core-dev
672016-11-15T02:52:43 <achow101> wut
682016-11-15T03:00:37 *** abpa has joined #bitcoin-core-dev
692016-11-15T03:08:52 <phantomcircuit> #8831
702016-11-15T03:08:53 <gribble> https://github.com/bitcoin/bitcoin/issues/8831 | Replace CWalletDB::ReadKeyValue with CWallet::LoadKeyValue by pstratem · Pull Request #8831 · bitcoin/bitcoin · GitHub
712016-11-15T03:08:55 <phantomcircuit> please
722016-11-15T03:08:57 <phantomcircuit> someone
732016-11-15T03:08:59 <phantomcircuit> review
742016-11-15T03:09:01 <phantomcircuit> please
752016-11-15T03:14:14 *** Chris_Stewart_5 has joined #bitcoin-core-dev
762016-11-15T03:21:44 *** DigiByteDev has quit IRC
772016-11-15T03:29:53 *** DigiByteDev has joined #bitcoin-core-dev
782016-11-15T03:35:06 *** Alopex has quit IRC
792016-11-15T03:36:11 *** Alopex has joined #bitcoin-core-dev
802016-11-15T03:43:17 *** Chris_Stewart_5 has quit IRC
812016-11-15T03:46:01 *** Alopex has quit IRC
822016-11-15T03:47:07 *** Alopex has joined #bitcoin-core-dev
832016-11-15T03:48:01 *** fengling has joined #bitcoin-core-dev
842016-11-15T03:51:45 *** arowser has quit IRC
852016-11-15T03:52:59 *** fengling has quit IRC
862016-11-15T03:53:13 *** arowser has joined #bitcoin-core-dev
872016-11-15T03:57:12 *** Giszmo has quit IRC
882016-11-15T04:05:56 *** arowser has quit IRC
892016-11-15T04:07:22 *** arowser has joined #bitcoin-core-dev
902016-11-15T04:10:20 *** tulip has quit IRC
912016-11-15T04:14:32 *** fengling has joined #bitcoin-core-dev
922016-11-15T04:18:01 *** btcdrak has quit IRC
932016-11-15T04:21:21 *** fengling has quit IRC
942016-11-15T04:23:35 *** fengling has joined #bitcoin-core-dev
952016-11-15T04:52:45 *** baldur has quit IRC
962016-11-15T04:53:36 *** DigiByteDev has quit IRC
972016-11-15T04:56:32 *** baldur has joined #bitcoin-core-dev
982016-11-15T05:13:43 *** tulip has joined #bitcoin-core-dev
992016-11-15T06:05:06 *** Alopex has quit IRC
1002016-11-15T06:06:11 *** Alopex has joined #bitcoin-core-dev
1012016-11-15T06:20:07 <gmaxwell> looks like some folks are signaling segwit prematurely.
1022016-11-15T06:21:08 *** DigiByteDev has joined #bitcoin-core-dev
1032016-11-15T06:36:38 *** DigiByteDev has quit IRC
1042016-11-15T06:37:18 *** DigiByteDev has joined #bitcoin-core-dev
1052016-11-15T06:43:16 *** jtimon has quit IRC
1062016-11-15T06:45:16 *** kadoban has quit IRC
1072016-11-15T06:52:01 *** Alopex has quit IRC
1082016-11-15T06:53:07 *** Alopex has joined #bitcoin-core-dev
1092016-11-15T06:59:33 <midnightmagic> :-o
1102016-11-15T07:00:32 <gmaxwell> Not harmful, but it's more evidence for my concern that version has been burned for consensus critical use.
1112016-11-15T07:00:53 <gmaxwell> I blame Luke. :P
1122016-11-15T07:02:53 <luke-jr> â¹
1132016-11-15T07:03:09 * luke-jr doesn't deny being at fault in part.
1142016-11-15T07:05:06 <gmaxwell> I think the big interface error is that mining exposes gnarly consensus internals to people who are not primarily interested in them but instead have simpler (though critical) goals like: Get mining working fast and reliably.
1152016-11-15T07:06:02 *** btcdrak has joined #bitcoin-core-dev
1162016-11-15T07:06:06 <gmaxwell> E.g. it's not a good seperation of concerns. I don't have any doubt that any of the pool ops couldn't be great consensus plumbers if they wanted to be, but when they're hacking on pool software that isn't what they're trying to do.
1172016-11-15T07:06:13 <luke-jr> yes, in hindsight it may have been better to do a more stratum-like getwork replacement in bitcoind (but that had its own share of problems)
1182016-11-15T07:06:38 <luke-jr> by separation of this, we did gain a few things: miners can upgrade easier now than with 0.3+tons of patching
1192016-11-15T07:06:58 <gmaxwell> We could be much worse off for sure.
1202016-11-15T07:07:37 <luke-jr> I tried to make it simpler by having a GBT client library (libblkmaker), but it seems it isn't in any real use outside of BFGMiner
1212016-11-15T07:10:26 <gmaxwell> One of the lessons (which I already knew from before) is that having a 'bad' interface, then a 'make it friendly' layer often doesn't work. People will either never find the friendlyness layer, or not use it because your own test cases don't (which they look at to understand the interface), will encounter some limitation in it and go raw, or otherwise insist on doing their own for some better o
1222016-11-15T07:10:32 <gmaxwell> r worse reason.
1232016-11-15T07:12:42 <gmaxwell> I explirenced this with libvorbis, which had a vorbisfile API which was 100x easier to use right than the raw interface, included with the same library... and mostly used, but still bypassed often enough to cause frequent bogus support issues that would have been avoided by using vorbisfile. ... and especially with liboggz which is a high level interface to many ogg embedded formats and ogg han
1242016-11-15T07:12:48 <gmaxwell> dling which handles most of the gnarly stuff, ... and which virtually no one uses... instead implementing the same functionality themselves, usually incorrectly.
1252016-11-15T07:13:24 <luke-jr> :/
1262016-11-15T07:13:24 *** DigiByteDev has quit IRC
1272016-11-15T07:14:10 <jl2012> which block is signalling segwit?
1282016-11-15T07:14:24 <gmaxwell> Then Opus (which has a much more carefully contstructed raw API) didn't ship with a opusfile (analog of the vorbisfile high level API), and relative usage of opusfile is probably 100x lower than vorbisfile. Shipping it with it as a single package makes a big difference.
1292016-11-15T07:14:25 *** DigiByteDev has joined #bitcoin-core-dev
1302016-11-15T07:15:48 <gmaxwell> jl2012: 438958 and 438914 I think.
1312016-11-15T07:16:30 <jl2012> oh, slush
1322016-11-15T07:17:39 <gmaxwell> luke-jr: in any case, the general advice I think we should follow is whe should always imagine the goals of the person using an API, and them assume that they will only correctly handle any non-trivial steps that were obvious from a statement of their goals.
1332016-11-15T07:18:48 *** DigiByteDev has quit IRC
1342016-11-15T07:19:36 <gmaxwell> Like an API for signing should not ask the signer to provide a nonce that must obey some byzantine set of security requirements. Their goal was signing, not generating random numbers. If it's easy to get it working without getting it right, it's a cointoss if they'll get it right or not. (I don't mean this in a superior or condecending way-- it's human nature to get tunnel vision around your o
1352016-11-15T07:19:42 <gmaxwell> wn goals).
1362016-11-15T07:21:02 <gmaxwell> plus, expecting people to worry about details that aren't related to their goals is a failure to respect their time.
1372016-11-15T07:23:59 *** DigiByteDev has joined #bitcoin-core-dev
1382016-11-15T07:30:20 *** tulip has quit IRC
1392016-11-15T07:36:07 *** jannes has joined #bitcoin-core-dev
1402016-11-15T07:42:35 *** ratoder has joined #bitcoin-core-dev
1412016-11-15T08:28:26 *** rubensayshi has joined #bitcoin-core-dev
1422016-11-15T08:32:29 *** luke-jr has quit IRC
1432016-11-15T08:45:33 *** DigiByteDev has joined #bitcoin-core-dev
1442016-11-15T08:46:40 <wumpus> it doesn't help that 'friendly' layers have a reputation to increase overhead and make things slower, deserved or not
1452016-11-15T08:48:51 <wumpus> so this may be mainly an issue for cases where there are (perceived) performance concerns, like with media APIs and mining... people always clamoring for a more 'raw' interface instead of a 'friendly' one. Same for 3D rendering with the Vulkan instead of OpenGL interface. "closer to the hardware" etc
1462016-11-15T08:50:00 *** luke-jr has joined #bitcoin-core-dev
1472016-11-15T08:52:43 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b42291334651...770364b8eaf7
1482016-11-15T08:52:43 <bitcoin-git> bitcoin/master ec34648 Russell Yanofsky: [trivial] Fix hungarian variable name...
1492016-11-15T08:52:44 <bitcoin-git> bitcoin/master 770364b Wladimir J. van der Laan: Merge #9160: [trivial] Fix hungarian variable name...
1502016-11-15T08:52:58 <bitcoin-git> [bitcoin] laanwj closed pull request #9160: [trivial] Fix hungarian variable name (master...hungarian) https://github.com/bitcoin/bitcoin/pull/9160
1512016-11-15T08:57:49 <wumpus> also some attempts at friendly interfaces have actually made things harder by abstracting away details that matter, causing the API user to do brittle or nonsensical things when you see the whole picture. Or including scope/dependencies which are not necessary for a project (e.g. texture loaders for 33 image formats while the game only needs one). Good API/library design is hard and both
1522016-11-15T08:57:55 <wumpus> commercial projects and open source projects have a lot of sins there
1532016-11-15T09:02:22 <wumpus> the best way of 'imagining the goal of the person using the API' is probably to be a user of the API yourself, instead of just guessing to imagine what the goal of a user of the API could be. With mining we have some issues there because there are so few miners involved with development at any level :(
1542016-11-15T09:06:30 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/770364b8eaf7...f54e4605fc31
1552016-11-15T09:06:30 <bitcoin-git> bitcoin/master f734505 Jonas Schnelli: Make strWalletFile const
1562016-11-15T09:06:31 <bitcoin-git> bitcoin/master f54e460 Wladimir J. van der Laan: Merge #9132: Make strWalletFile const...
1572016-11-15T09:06:45 <bitcoin-git> [bitcoin] laanwj closed pull request #9132: Make strWalletFile const (master...2016/11/strWalletFile_const) https://github.com/bitcoin/bitcoin/pull/9132
1582016-11-15T09:07:41 *** jrayhawk_ has quit IRC
1592016-11-15T09:08:00 *** kanzure has quit IRC
1602016-11-15T09:08:00 *** ybit has quit IRC
1612016-11-15T09:08:33 *** DigiByteDev has quit IRC
1622016-11-15T09:12:54 <jonasschnelli> wumpus: would a configuration option for a specific block-files path make sense?
1632016-11-15T09:14:10 <jonasschnelli> paveljanik: what do you mean with ""Conditionalize" QR on QT?"?
1642016-11-15T09:14:25 <wumpus> yes - however that needs more infrastructure than just adding an option. If bitcoind's state can be distributed over multiple places, those all need a 'datadir lock'
1652016-11-15T09:14:43 <paveljanik> jonasschnelli, I qt = yes then echo $QR;
1662016-11-15T09:14:46 <wumpus> the symbolic link hack is unsupported but works
1672016-11-15T09:14:56 <paveljanik> ie if Qt is disabled, no need to print info on QR
1682016-11-15T09:15:22 <wumpus> an official option + infrastructure for it would make it slightly harder to shoot yourself in the foot though, as people will try to share a blocks directory between instances and shit like that
1692016-11-15T09:15:26 <jonasschnelli> wumpus: Yes. Dir locking would be required. You mean with a simple .lock file?
1702016-11-15T09:15:45 <wumpus> jonasschnelli: exactly the same as we do for the data directory
1712016-11-15T09:16:05 <jonasschnelli> wumpus: Okay. Thanks...
1722016-11-15T09:16:14 <wumpus> however, there's a snag: locking doesn't work very well on remote filesystems
1732016-11-15T09:16:18 <jonasschnelli> paveljanik: Yes. This makes sense.
1742016-11-15T09:16:30 <jonasschnelli> Also, not sure how easy it would be to print out the Qt version...
1752016-11-15T09:16:44 <wumpus> you don't need to print the qt version - just 4 or 6
1762016-11-15T09:16:47 <wumpus> eh, 5
1772016-11-15T09:17:14 <luke-jr> yeah, probably don't need the exact version
1782016-11-15T09:17:37 *** Lauda has left #bitcoin-core-dev
1792016-11-15T09:17:50 <wumpus> printing the exact version is possible if pkgconfig was used, but it's not really what people care about usually
1802016-11-15T09:17:53 *** Lauda has joined #bitcoin-core-dev
1812016-11-15T09:18:20 <wumpus> +the minor versions can change if the distribution version is upgraded and shared libraries are used
1822016-11-15T09:18:27 <wumpus> the major version is a compile-time decision
1832016-11-15T09:18:49 <luke-jr> good point, for that reason it's actually preferable to only print major
1842016-11-15T09:19:03 <jonasschnelli> Yes. But I guess getting the version number in configure.ac would require changes in the bitcoin-qt m4 macro.
1852016-11-15T09:19:16 <wumpus> jonasschnelli: yese, don't get stuck in that rabbit hole, just print the major version
1862016-11-15T09:19:28 <jonasschnelli> Will have a look
1872016-11-15T09:20:15 *** paveljanik has quit IRC
1882016-11-15T09:20:21 <wumpus> though possible that needs deeper autoconf changes too, as the macro needs to export the version, but maybe it alredy does as the major version is printed while configure is running
1892016-11-15T09:24:14 <jonasschnelli> Indeed. Will have a look.
1902016-11-15T09:28:20 *** jrayhawk has joined #bitcoin-core-dev
1912016-11-15T09:35:23 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f54e4605fc31...018a4eb120dc
1922016-11-15T09:35:23 <bitcoin-git> bitcoin/master b74ff5c Luke Dashjr: Bugfix: Correctly replace generated headers and fail cleanly...
1932016-11-15T09:35:24 <bitcoin-git> bitcoin/master 018a4eb Wladimir J. van der Laan: Merge #9140: Bugfix: Correctly replace generated headers and fail cleanly...
1942016-11-15T09:35:37 <bitcoin-git> [bitcoin] laanwj closed pull request #9140: Bugfix: Correctly replace generated headers and fail cleanly (master...bugfix_genheaders) https://github.com/bitcoin/bitcoin/pull/9140
1952016-11-15T09:50:46 *** DigiByteDev has joined #bitcoin-core-dev
1962016-11-15T09:54:57 *** DigiByteDev has quit IRC
1972016-11-15T09:59:21 *** DigiByteDev has joined #bitcoin-core-dev
1982016-11-15T10:04:20 *** DigiByteDev has quit IRC
1992016-11-15T10:12:34 *** rabidus has joined #bitcoin-core-dev
2002016-11-15T10:18:14 <phantomcircuit> sipa: thanks for the review
2012016-11-15T10:18:16 <phantomcircuit> but why
2022016-11-15T10:36:43 *** DigiByteDev has joined #bitcoin-core-dev
2032016-11-15T10:42:45 *** grubles has quit IRC
2042016-11-15T10:55:45 *** grubles has joined #bitcoin-core-dev
2052016-11-15T10:59:33 *** BCBot_ has quit IRC
2062016-11-15T10:59:53 *** BCBot has joined #bitcoin-core-dev
2072016-11-15T11:01:53 *** thrasher` has joined #bitcoin-core-dev
2082016-11-15T11:02:37 <thrasher`> hey all, just wondering how https://github.com/bitcoin/bitcoin/blob/master/src/qt/test/paymentrequestdata.h#L440 this request was generated?
2092016-11-15T11:04:13 *** DigiByteDev has quit IRC
2102016-11-15T11:06:30 *** fengling has quit IRC
2112016-11-15T11:07:18 *** DigiByteDev has joined #bitcoin-core-dev
2122016-11-15T11:09:37 *** Ylbam has joined #bitcoin-core-dev
2132016-11-15T11:30:36 <bitcoin-git> [bitcoin] jonathan0405 opened pull request #9162: Ict block (master...ict) https://github.com/bitcoin/bitcoin/pull/9162
2142016-11-15T11:33:17 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9162: Ict (master...ict) https://github.com/bitcoin/bitcoin/pull/9162
2152016-11-15T12:15:39 <wumpus> thrasher`: no idea; there must be some code out there to generate payment requests, but I don't know any specific one
2162016-11-15T12:33:38 *** laurentmt has joined #bitcoin-core-dev
2172016-11-15T12:37:18 *** cryptapus has joined #bitcoin-core-dev
2182016-11-15T12:37:18 *** cryptapus has joined #bitcoin-core-dev
2192016-11-15T12:46:52 *** Victor_sueca has quit IRC
2202016-11-15T12:48:14 *** Victor_sueca has joined #bitcoin-core-dev
2212016-11-15T12:59:56 *** owowo has quit IRC
2222016-11-15T13:08:30 *** owowo has joined #bitcoin-core-dev
2232016-11-15T13:09:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2242016-11-15T13:24:50 *** Lauda is now known as Sbot1
2252016-11-15T13:24:57 *** Sbot1 is now known as Lauda
2262016-11-15T13:26:17 *** Chris_Stewart_5 has quit IRC
2272016-11-15T13:31:05 *** Victor_sueca is now known as Victorsueca
2282016-11-15T13:31:50 *** kanzure has joined #bitcoin-core-dev
2292016-11-15T13:48:43 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2302016-11-15T13:48:52 *** justanotheruser has quit IRC
2312016-11-15T13:50:53 *** DigiByteDev has left #bitcoin-core-dev
2322016-11-15T13:51:19 *** Giszmo has joined #bitcoin-core-dev
2332016-11-15T14:01:56 *** DigiByteDev has joined #bitcoin-core-dev
2342016-11-15T14:03:53 *** tulip has joined #bitcoin-core-dev
2352016-11-15T14:16:20 *** laurentmt has quit IRC
2362016-11-15T14:16:56 *** Guyver2 has joined #bitcoin-core-dev
2372016-11-15T14:20:16 <bitcoin-git> [bitcoin] instagibbs opened pull request #9164: [trivial] credit values are CAmount (master...intcredit) https://github.com/bitcoin/bitcoin/pull/9164
2382016-11-15T14:21:00 *** abpa has quit IRC
2392016-11-15T14:33:09 *** Chris_Stewart_5 has quit IRC
2402016-11-15T14:36:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2412016-11-15T14:38:42 <sdaftuar> thrasher`: i don't know where that test case came from, but i do recall this github comment that may be of help: https://github.com/bitcoin/bitcoin/pull/5620#issuecomment-69351549
2422016-11-15T14:44:04 *** cryptapus has quit IRC
2432016-11-15T14:44:20 *** cryptapus has joined #bitcoin-core-dev
2442016-11-15T14:44:21 *** cryptapus has joined #bitcoin-core-dev
2452016-11-15T14:45:07 *** arowser has quit IRC
2462016-11-15T14:49:49 *** cryptapus has quit IRC
2472016-11-15T14:56:12 *** cryptapus has joined #bitcoin-core-dev
2482016-11-15T15:00:39 *** arowser has joined #bitcoin-core-dev
2492016-11-15T15:03:53 *** arowser has quit IRC
2502016-11-15T15:05:09 *** cryptapus has quit IRC
2512016-11-15T15:13:05 *** cryptapus has joined #bitcoin-core-dev
2522016-11-15T15:13:06 *** cryptapus has joined #bitcoin-core-dev
2532016-11-15T15:14:39 *** arowser has joined #bitcoin-core-dev
2542016-11-15T15:24:54 *** arowser has quit IRC
2552016-11-15T15:26:49 *** arowser has joined #bitcoin-core-dev
2562016-11-15T15:27:42 *** Chris_Stewart_5 has quit IRC
2572016-11-15T15:30:04 *** arowser has quit IRC
2582016-11-15T15:30:40 <jonasschnelli> This one is easy to review if someone has 2-3 minutes of boringness: https://github.com/bitcoin/bitcoin/pull/9142
2592016-11-15T15:41:03 *** thermoman has joined #bitcoin-core-dev
2602016-11-15T15:41:36 <thermoman> hi there. just upgraded a 0.11.2 node to 0.13.1 and found out that RPC calls "listtransaction" doesn't work anymore
2612016-11-15T15:41:44 <thermoman> bitcoin-cli says can't parse reply
2622016-11-15T15:42:01 <thermoman> tcpdump reveals that the answer is sent to the client, looks like valid jason
2632016-11-15T15:42:23 <thermoman> EXCEPT: there are non-utf8 chars mixed in between in the comments associated with some TXs
2642016-11-15T15:42:42 <thermoman> like 0xFC for german umlaut ü (ue)
2652016-11-15T15:42:58 <thermoman> latin1 1byte instead of utf8 two bytes
2662016-11-15T15:43:36 <jonasschnelli> thermoman: I'm just trying to reproduce this
2672016-11-15T15:43:40 <thermoman> so now I'm stuck and luke-jr suggested starting a discussion here about how to handle non-utf8 wallets
2682016-11-15T15:45:29 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2692016-11-15T15:45:37 <jonasschnelli> thermoman: Just did: sendtoaddress(getnewaddress(), 1, "Dr Schmöörenbröd, Bèrtälzç")
2702016-11-15T15:45:50 <jonasschnelli> listtransaction works (in Qt though): "comment": "Dr Schmöörenbröd, Bèrtälzç",
2712016-11-15T15:45:55 <jonasschnelli> Now testing bitcoin-cli
2722016-11-15T15:46:03 *** arowser has joined #bitcoin-core-dev
2732016-11-15T15:46:26 <jonasschnelli> works as well
2742016-11-15T15:46:30 <thermoman> but what about comments entered in 0.11.2 or even before?
2752016-11-15T15:46:47 <jonasschnelli> hmm... yes.
2762016-11-15T15:46:54 <jonasschnelli> Give me your wallet.dat. :)
2772016-11-15T15:47:07 <jonasschnelli> Let me check the code
2782016-11-15T15:47:09 <thermoman> with the RPC calls there the client would send umlauts as latin1 instead of utf8
2792016-11-15T15:47:48 <jonasschnelli> thermoman: does it work for you when you create (temporary) a new wallet and send tx with a comment with umlaute?
2802016-11-15T15:48:03 <thermoman> didn't try this yet
2812016-11-15T15:48:10 <jonasschnelli> Maybe give it a try...
2822016-11-15T15:49:19 <luke-jr> jonasschnelli: most likely your sendtoaddress call used UTF-8? :p
2832016-11-15T15:50:24 <jonasschnelli> Yeah. I guess you can get stuck with a wtx holding an latin1 char. But why does that break JSON parsing?
2842016-11-15T15:51:22 <jonasschnelli> Hmm.. thinking of an easy solution.. i guess there is non.
2852016-11-15T15:51:22 <luke-jr> because we just send the wtx comment as-is, Univalue passes it through as-is, and valid JSON may only use UTF-8
2862016-11-15T15:51:58 <jonasschnelli> I guess best solution is to fiddle with the BDB file directly
2872016-11-15T15:52:04 <jonasschnelli> remove the char there...
2882016-11-15T15:52:14 <jonasschnelli> But I wouldn't do that with a hex editor.
2892016-11-15T15:52:23 <jonasschnelli> Maybe some berkley-db tool
2902016-11-15T15:53:13 <thermoman> there is db_dump
2912016-11-15T15:53:32 <thermoman> but i'm not sure I will see the text in plain there to be edited
2922016-11-15T15:54:26 <rafalcpp> maybe rebuild the bitcoind with a path that replaces the comment field with empty string when generating rpc reply?
2932016-11-15T15:54:32 <rafalcpp> *patch
2942016-11-15T15:55:00 <thermoman> If there was an official patch I would like to test that
2952016-11-15T15:57:50 *** kadoban has joined #bitcoin-core-dev
2962016-11-15T16:00:12 <thermoman> do I need to open an issue on github or how will this be handled the best way?
2972016-11-15T16:00:27 <jonasschnelli> thermoman: Yes. Opening an issue would be good.
2982016-11-15T16:00:42 <jonasschnelli> I guess we should patch this, though not sure what priority this will have
2992016-11-15T16:01:19 <jonasschnelli> Comments are used rarely, and even more rarely with non-utf8 compatible chars.
3002016-11-15T16:01:28 <jonasschnelli> But feel free to fix it. :)
3012016-11-15T16:10:21 *** tulip has quit IRC
3022016-11-15T16:13:07 *** achow101 has quit IRC
3032016-11-15T16:15:03 *** Chris_Stewart_5 has quit IRC
3042016-11-15T16:18:46 *** DigiByteDev has joined #bitcoin-core-dev
3052016-11-15T16:20:22 *** achow101 has joined #bitcoin-core-dev
3062016-11-15T16:21:26 *** cryptapus has quit IRC
3072016-11-15T16:26:09 *** cryptapus has joined #bitcoin-core-dev
3082016-11-15T16:26:09 *** cryptapus has joined #bitcoin-core-dev
3092016-11-15T16:31:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3102016-11-15T16:37:25 *** Chris_Stewart_5 has quit IRC
3112016-11-15T16:42:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3122016-11-15T16:54:57 *** Giszmo has quit IRC
3132016-11-15T16:55:51 *** DigiByteDev_ has joined #bitcoin-core-dev
3142016-11-15T16:57:28 *** DigiByteDev has quit IRC
3152016-11-15T16:57:29 *** DigiByteDev_ is now known as DigiByteDev
3162016-11-15T17:08:45 *** rubensayshi has quit IRC
3172016-11-15T17:10:48 *** DigiByteDev has quit IRC
3182016-11-15T17:33:33 *** afk11 has quit IRC
3192016-11-15T17:34:03 *** paveljanik has joined #bitcoin-core-dev
3202016-11-15T17:34:04 *** paveljanik has joined #bitcoin-core-dev
3212016-11-15T17:38:25 *** Chris_Stewart_5 has quit IRC
3222016-11-15T17:38:44 *** afk11 has joined #bitcoin-core-dev
3232016-11-15T17:38:45 *** afk11 has quit IRC
3242016-11-15T17:38:45 *** afk11 has joined #bitcoin-core-dev
3252016-11-15T17:44:32 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/018a4eb120dc...6eeac6e30d65
3262016-11-15T17:44:33 <bitcoin-git> bitcoin/master 20c3215 Gregory Sanders: credit values are CAmount
3272016-11-15T17:44:34 <bitcoin-git> bitcoin/master 6eeac6e Pieter Wuille: Merge #9164: [trivial] credit values are CAmount...
3282016-11-15T17:44:48 <bitcoin-git> [bitcoin] sipa closed pull request #9164: [trivial] credit values are CAmount (master...intcredit) https://github.com/bitcoin/bitcoin/pull/9164
3292016-11-15T18:01:38 <bitcoin-git> [bitcoin] instagibbs opened pull request #9165: [trivial] SendMoney: use already-calculated balance (master...triv-curbal) https://github.com/bitcoin/bitcoin/pull/9165
3302016-11-15T18:04:48 *** jtimon has joined #bitcoin-core-dev
3312016-11-15T18:08:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3322016-11-15T18:12:45 <thermoman> jonasschnelli, luke-jr: https://github.com/bitcoin/bitcoin/issues/9166
3332016-11-15T18:14:46 <timothy> drizzt@liara ~ % bitcoin-cli listtransactions '*' 2
3342016-11-15T18:14:47 <timothy> [
3352016-11-15T18:14:47 <timothy> ]
3362016-11-15T18:14:47 <timothy> drizzt@liara ~ %
3372016-11-15T18:14:55 <sipa> sdaftuar: i have a branch sharedblock2 (which is rebased on top of #8589) that includes making the orphanmap and ATMT use shared_ptrs
3382016-11-15T18:14:57 <gribble> https://github.com/bitcoin/bitcoin/issues/8589 | Inline CTxInWitness inside CTxIn (on top of #8580) by sipa · Pull Request #8589 · bitcoin/bitcoin · GitHub
3392016-11-15T18:14:59 *** Chris_Stewart_5 has quit IRC
3402016-11-15T18:15:30 <sdaftuar> sipa: thanks, i found it yesterday and am working off it
3412016-11-15T18:15:42 <thermoman> timothy: empty wallet?
3422016-11-15T18:21:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3432016-11-15T19:01:36 *** owowo has quit IRC
3442016-11-15T19:06:38 *** owowo has joined #bitcoin-core-dev
3452016-11-15T19:06:38 *** owowo has joined #bitcoin-core-dev
3462016-11-15T19:06:39 *** owowo has joined #bitcoin-core-dev
3472016-11-15T19:17:06 *** Chris_Stewart_5 has quit IRC
3482016-11-15T19:22:49 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3492016-11-15T19:33:00 *** Victorsueca has quit IRC
3502016-11-15T20:10:58 *** Victorsueca has joined #bitcoin-core-dev
3512016-11-15T20:14:30 *** harrymm has quit IRC
3522016-11-15T20:30:34 <bitcoin-git> [bitcoin] morcos opened pull request #9167: IsAllFromMe (master...IsAllFromMe) https://github.com/bitcoin/bitcoin/pull/9167
3532016-11-15T20:30:38 *** harrymm has joined #bitcoin-core-dev
3542016-11-15T20:46:29 <bitcoin-git> [bitcoin] mrbandrews opened pull request #9168: [qa] add assert_raises_message to check specific error message (master...ba-assert-raises) https://github.com/bitcoin/bitcoin/pull/9168
3552016-11-15T20:50:45 *** cryptapus has quit IRC
3562016-11-15T21:14:22 <bitcoin-git> [bitcoin] theuni opened pull request #9169: build: fix qt5.7 build under macOS (master...fix-objcxx-std) https://github.com/bitcoin/bitcoin/pull/9169
3572016-11-15T21:15:29 <cfields> morcos: ^^
3582016-11-15T21:20:53 <morcos> cfields: thanks. i did a make clean and re-autogen/configure. if that's sufficient to test it, it works
3592016-11-15T21:21:58 *** aalex has quit IRC
3602016-11-15T21:22:22 *** aalex has joined #bitcoin-core-dev
3612016-11-15T21:22:23 <cfields> morcos: assuming bitcoin-qt build succeeds after that, then yes, that's enough
3622016-11-15T21:22:36 <morcos> cfields: ha ha. yes.
3632016-11-15T21:23:01 <cfields> great, thanks for the quick test
3642016-11-15T21:23:37 <morcos> cfields: pretty please PR the prevector move commit too...
3652016-11-15T21:24:13 <cfields> morcos: uhm, sure. I never fully cleaned it up, but I suppose I can pr the bit that's already done
3662016-11-15T21:24:25 <cfields> morcos: though I should think it would matter much less after the shared_ptr merge?
3672016-11-15T21:25:47 <cfields> #9125, that is
3682016-11-15T21:25:48 <gribble> https://github.com/bitcoin/bitcoin/issues/9125 | Make CBlock a vector of shared_ptr of CTransactions by sipa · Pull Request #9125 · bitcoin/bitcoin · GitHub
3692016-11-15T21:25:56 <morcos> i can try again, but it has consistently made a difference to me, not sure its just in txs that it matters
3702016-11-15T21:28:03 *** btcdrak has quit IRC
3712016-11-15T21:31:20 <cfields> morcos: ok, i'll PR a very simplified version
3722016-11-15T21:54:10 *** Chris_Stewart_5 has quit IRC
3732016-11-15T21:56:18 *** jannes has quit IRC
3742016-11-15T22:06:56 <cfields> morcos: top two commits here: https://github.com/theuni/bitcoin/commits/prevector-move
3752016-11-15T22:07:38 <cfields> morcos: mind seeing if you get the same speedup from those? I'd be much more comfortable PRing that than the set of much bigger changes
3762016-11-15T22:08:37 <morcos> cfields: no problem, but will have to wait til tomorrow now...
3772016-11-15T22:09:06 <cfields> morcos: np
3782016-11-15T22:11:49 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3792016-11-15T22:33:38 *** Guyver2 has quit IRC
3802016-11-15T22:48:00 *** Chris_Stewart_5 has quit IRC
3812016-11-15T22:56:26 *** elix0r has joined #bitcoin-core-dev
3822016-11-15T23:05:18 *** justanotheruser has joined #bitcoin-core-dev
3832016-11-15T23:17:01 *** fengling has joined #bitcoin-core-dev
3842016-11-15T23:59:37 *** elix0r has left #bitcoin-core-dev