12016-11-22T00:18:54  *** wasi has quit IRC
  22016-11-22T00:27:03  *** JackH has quit IRC
  32016-11-22T01:14:09  *** mol is now known as moli
  42016-11-22T01:20:19  *** go1111111 has quit IRC
  52016-11-22T01:32:29  *** windsok has quit IRC
  62016-11-22T01:33:16  *** abpa has quit IRC
  72016-11-22T01:42:40  *** Ylbam has quit IRC
  82016-11-22T01:44:00  *** Chris_Stewart_5 has quit IRC
  92016-11-22T01:45:53  *** abpa has joined #bitcoin-core-dev
 102016-11-22T01:51:31  *** skyraider has quit IRC
 112016-11-22T01:56:17  *** abpa has quit IRC
 122016-11-22T02:00:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 132016-11-22T02:16:22  *** windsok has joined #bitcoin-core-dev
 142016-11-22T02:43:59  *** abpa has joined #bitcoin-core-dev
 152016-11-22T02:44:57  *** Cory has quit IRC
 162016-11-22T02:47:32  *** Pasha has joined #bitcoin-core-dev
 172016-11-22T02:54:26  *** Pasha is now known as Cory
 182016-11-22T02:55:28  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9199: Always drop the least preferred HB peer when adding a new one. (master...remove_high_bandwidth_zombies) https://github.com/bitcoin/bitcoin/pull/9199
 192016-11-22T02:58:39  *** abpa has quit IRC
 202016-11-22T03:04:22  *** vanishing-coins has joined #bitcoin-core-dev
 212016-11-22T03:04:31  <vanishing-coins> hey guys, I believe I have found a rather serious issue with 0.13.1 but I am trying to figure out what is causing it
 222016-11-22T03:04:34  *** brg444 has joined #bitcoin-core-dev
 232016-11-22T03:04:38  <vanishing-coins> the symptom is that as coins are being sent through standard sendtoaddress RPC calls, overtime some change gets 'lost' until the wallet trends to 0, and the true balance is only restored when restarting Bitcoind. I am not speaking hyperbolically
 242016-11-22T03:04:43  <vanishing-coins> coins are never 'lost' but bitcoind has to restart for the correct balance to be shown
 252016-11-22T03:05:00  <vanishing-coins> I help multiple clients manage their nodes and this is the second time that I have seen this happen
 262016-11-22T03:05:17  <vanishing-coins> both clients were running 0.12 before without issue, upgraded to 0.13.1 and HD wallets and both had the issue within 48 hours of upgrading
 272016-11-22T03:08:05  *** btcdrak has quit IRC
 282016-11-22T03:08:40  *** Giszmo has quit IRC
 292016-11-22T03:15:16  <vanishing-coins> both are running on m1.smalls on Amazon EC2
 302016-11-22T03:15:39  <vanishing-coins> 1.7 gigs of ram, is it possible that unexpected behavior manifest due to low RAM? what would I be grepping for in the debug.log if so
 312016-11-22T03:17:13  <vanishing-coins> the max memory pool is set to 300mb
 322016-11-22T03:23:22  *** jtimon has quit IRC
 332016-11-22T03:29:38  <instagibbs> vanishing-coins, do you have debug.log to share?
 342016-11-22T03:30:26  <instagibbs> it sounds awfully similar to if you somehow chain too many transactions in mempool, it can throw an error and "lose" coins until restart
 352016-11-22T03:32:36  <vanishing-coins> instagibbs i do
 362016-11-22T03:32:44  <vanishing-coins> and that is definitely very possible -- can you elaborate on that chaining issue?
 372016-11-22T03:32:54  <vanishing-coins> is that a product of having too small a memory pool? any link i can read up on?
 382016-11-22T03:32:55  <instagibbs> well a look at the debug log when this happens would be helpful
 392016-11-22T03:33:16  *** Chris_Stewart_5 has quit IRC
 402016-11-22T03:33:20  <instagibbs> no, sorry it's likely not the issue, just thinking out loud. debug.log sharing is best
 412016-11-22T03:33:48  *** jyap has quit IRC
 422016-11-22T03:39:35  *** jyap has joined #bitcoin-core-dev
 432016-11-22T03:39:35  *** jyap has joined #bitcoin-core-dev
 442016-11-22T03:44:06  *** DigiByteDev has joined #bitcoin-core-dev
 452016-11-22T03:44:35  *** jtimon has joined #bitcoin-core-dev
 462016-11-22T03:45:51  *** vanishing-coins has quit IRC
 472016-11-22T03:46:09  *** justanotheruser has quit IRC
 482016-11-22T03:47:13  *** justanotheruser has joined #bitcoin-core-dev
 492016-11-22T03:55:01  *** jtimon has quit IRC
 502016-11-22T03:56:21  <gmaxwell> instagibbs: that wouldn't be until restart, no, it would be until after some of the chain confirms and then the retransmit logic fires.
 512016-11-22T04:02:30  *** DigiByteDev has quit IRC
 522016-11-22T04:08:45  *** vanishing-coins has joined #bitcoin-core-dev
 532016-11-22T04:08:57  <vanishing-coins> hey sorry got disconnected
 542016-11-22T04:09:01  <vanishing-coins> I am uploading the debug.log now
 552016-11-22T04:10:29  <vanishing-coins> I also dropped memorypool size to 150 mb, and dbcache to 80
 562016-11-22T04:10:54  <vanishing-coins> but very strange all around that two completely separate instances on EC2 of the same type were running fine on 0.12 but both, within 72 hours of upgrading, had the same exact issue :/
 572016-11-22T04:23:11  *** vanishing-coins has quit IRC
 582016-11-22T04:26:06  *** brg444 has quit IRC
 592016-11-22T04:43:20  *** abpa has joined #bitcoin-core-dev
 602016-11-22T04:46:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 612016-11-22T04:47:10  *** molz has joined #bitcoin-core-dev
 622016-11-22T04:49:14  *** moli has quit IRC
 632016-11-22T04:50:18  *** DigiByteDev has joined #bitcoin-core-dev
 642016-11-22T04:51:56  *** Chris_Stewart_5 has quit IRC
 652016-11-22T05:10:19  *** Cory has quit IRC
 662016-11-22T05:11:33  *** Pasha has joined #bitcoin-core-dev
 672016-11-22T05:13:27  *** DigiByteDev has joined #bitcoin-core-dev
 682016-11-22T05:18:27  *** Pasha is now known as Cory
 692016-11-22T05:53:16  *** Alopex has quit IRC
 702016-11-22T05:54:21  *** Alopex has joined #bitcoin-core-dev
 712016-11-22T06:03:21  *** fanquake has joined #bitcoin-core-dev
 722016-11-22T06:21:40  <luke-jr> cfields: ping
 732016-11-22T06:21:52  <luke-jr> should we be doing UpdateUncommittedBlockStructures in GBT proposals? :x
 742016-11-22T06:22:52  <cfields> luke-jr: are gbt proposals used?
 752016-11-22T06:23:07  <luke-jr> cfields: that's currently how I'm trying to test :D
 762016-11-22T06:23:19  <cfields> luke-jr: heh, i've been using #9000
 772016-11-22T06:23:21  <gribble> https://github.com/bitcoin/bitcoin/issues/9000 | miner debugging: faux-mining by theuni · Pull Request #9000 · bitcoin/bitcoin · GitHub
 782016-11-22T06:23:44  <cfields> but, as long as they're there, yea, i suppose so
 792016-11-22T06:24:17  <cfields> luke-jr: which reminds me, in the same vein, i think vbrequired needs some segwit love too?
 802016-11-22T06:24:30  <luke-jr> ?
 812016-11-22T06:25:36  <cfields> luke-jr: i just glanced at it briefly tonight, vbrequired is hard-coded to 0 as far as i can tell?
 822016-11-22T06:25:44  <luke-jr> cfields: as it should be right now
 832016-11-22T06:25:56  <cfields> maybe i don't really understand what it's for, i just made a note to look deeper into it later
 842016-11-22T06:26:01  <cfields> (or ping you :p )
 852016-11-22T06:26:24  <gmaxwell> jonasschnelli: I think the GUI should say "X blocks behind" instead of "X days/weeks/months/years" -- the latter seems to be frequently misunderstood as how long the sync is going to take. .. or perhaps we could do something smarter than that.
 862016-11-22T06:26:47  <luke-jr> cfields: it's a constraint on the miner, vbs they *must* signal
 872016-11-22T06:27:30  <luke-jr> gmaxwell: the master/0.14 GUI currently has a real ETA
 882016-11-22T06:27:57  <cfields> luke-jr: ah, ok. I thought it was vbs they must understand. nm, then.
 892016-11-22T06:28:14  <luke-jr> cfields: that's "rules", since when they must understand it, there is no bit assigned anymore ;)
 902016-11-22T06:28:59  <cfields> luke-jr: yep, makes sense
 912016-11-22T06:29:08  <luke-jr> huh, serializing CTransaction can modify it? :o
 922016-11-22T06:29:31  <cfields> luke-jr: sorry, didn't mean to hijack. But we may as well fix up proposals if there's a use-case
 932016-11-22T06:29:39  <luke-jr> (it resizes the witness vector to match the input vector)
 942016-11-22T06:30:08  <luke-jr> cfields: well, I guess it's either that and/or make Eloipool submit witness-form gen tx
 952016-11-22T06:41:13  *** DigiByteDev has quit IRC
 962016-11-22T06:57:50  <wumpus> gmaxwell: it used to say 'N blocks behind' a long time ago, was switched after lots of people complaining that blocks aren't a good indication of anything, though I'm not sure the time is that useful either...
 972016-11-22T06:58:01  <wumpus> gmaxwell: there's been so much iteration on that damn progress bar at some point :p
 982016-11-22T06:58:33  <gmaxwell> I was thinking that as I typed it...
 992016-11-22T06:58:51  <wumpus> oh I remember now, that complaint was more like 'blocks are too technical!'
1002016-11-22T06:59:00  <wumpus> 'show only blocks count in the debug interface and hover' well okay
1012016-11-22T06:59:15  <gmaxwell> luke-jr: I was just looking at gui in master... got 'n days behind'. which sounds like how long it will take.
1022016-11-22T06:59:17  <wumpus> maybe things changed with the blockchains hype
1032016-11-22T07:00:10  <luke-jr> gmaxwell: so the ETA doesn't distract enough from it, you're saying? :x
1042016-11-22T07:00:11  <gmaxwell> To be honest it might as well say "working hard at catching up! here is a spinner /-\_/-\..."
1052016-11-22T07:00:15  <luke-jr> lol
1062016-11-22T07:00:21  <gmaxwell> luke-jr: I didn't see it! :P
1072016-11-22T07:00:23  <wumpus> here's dancing hamsters...
1082016-11-22T07:00:36  <luke-jr> I wasn't even looking for it, yet saw and appreciated it :p
1092016-11-22T07:01:06  <gmaxwell> but I've seen two reddit threads recently where they thought the x years behind was the catchup time, and one person on IRC. ... lemme go look
1102016-11-22T07:01:15  <sipa> use this early in the chain when we don't have a good estimate yet: ¯\_(ツ)_/¯
1112016-11-22T07:01:18  <wumpus> yes I believe you that people get confused about it
1122016-11-22T07:01:18  <luke-jr> yeah, Core 0.13 doesn't have it yet
1132016-11-22T07:02:03  <luke-jr> I once had a feature request for Knots to have a button to click to play an audible "to the moon" sound bite..
1142016-11-22T07:02:07  <sipa> luke-jr: fixed in 8580
1152016-11-22T07:02:31  <wumpus> it's not really telling what it is doing either, e.g. if it was more apparent that it was validating history then in that context 'X years behind' makes sense
1162016-11-22T07:03:03  <luke-jr> someone want to make an animation of it checking the blocks? :p
1172016-11-22T07:03:22  <gmaxwell> okay the progress popup box I just dismissed. maybe now that we have that we don't need the progress bar to say 'foo behind'?
1182016-11-22T07:03:28  <wumpus> then again the new modal overlay with ETA and such is really nice and mitigates these concerns
1192016-11-22T07:03:51  <luke-jr> gmaxwell: I suggest change the progress bar to "Synchronising (ETA <x>)" ☺
1202016-11-22T07:03:58  <wumpus> luke-jr: +1
1212016-11-22T07:04:02  <fanquake> I agree, the new overlay is a good improvement.
1222016-11-22T07:04:25  <gmaxwell> luke-jr: that would be fine.
1232016-11-22T07:04:31  <wumpus> luke-jr: haha an animation of someone retrieving books of transactions from a chain of blocks and checking them?
1242016-11-22T07:05:26  *** Alina-malina has quit IRC
1252016-11-22T07:05:26  *** Alina-malina has joined #bitcoin-core-dev
1262016-11-22T07:05:28  <fanquake> wumpus or gmaxwell, have you seen any Boost related memory leaks during your testing?
1272016-11-22T07:05:43  <gmaxwell> the popup is kind of a sea of grey on my screen.
1282016-11-22T07:05:51  <fanquake> Sorry to change topic, but I seem to have fallen down some memory leaks rabbit holes.
1292016-11-22T07:05:57  <gmaxwell> fanquake: no!
1302016-11-22T07:06:01  <wumpus> fanquake: nope.
1312016-11-22T07:06:21  <wumpus> fanquake: qt and ancillary GUI libs (Fontconfig etc) is the only thing leaking here
1322016-11-22T07:06:54  <wumpus> and all the leaks apparent in other libraries downstream seem to come from there
1332016-11-22T07:06:54  <fanquake> Hmm ok you see leaks from leveldb as well?
1342016-11-22T07:06:59  <wumpus> no
1352016-11-22T07:07:12  <luke-jr> wumpus: I was thinking more of a horizontal line of pages sized based on the block size, and a red line scanning over them ;)
1362016-11-22T07:07:14  <wumpus> nothing in the core code
1372016-11-22T07:07:26  <gmaxwell> No. There is a little bit from the openssl RNG.
1382016-11-22T07:07:28  <wumpus> bitcoind is 100% leak clen
1392016-11-22T07:07:40  <gmaxwell> but bitcoind itself is 100% leak clean for me.
1402016-11-22T07:07:41  <luke-jr> wumpus: valgrind thinks the wallet code leaks
1412016-11-22T07:07:58  <wumpus> (at least the normal exit path, I haven't tried all kinds of panic shutdown scenarios ofc)
1422016-11-22T07:08:08  <luke-jr> it was around some BDB mess, so I didn't look far
1432016-11-22T07:08:22  <luke-jr> (one time at startup)
1442016-11-22T07:08:36  <wumpus> luke-jr: not seeing that here. But I use the system berkeleydb in Ubuntu 16.04
1452016-11-22T07:08:43  <wumpus> not 4.8 or that shit :)
1462016-11-22T07:09:42  <luke-jr> I use system 4.8 :P
1472016-11-22T07:09:58  <fanquake> Ok, I'll post a few details in a sec.
1482016-11-22T07:10:38  <wumpus> I honestly don't even know what version it is... lemme check. 5.3.
1492016-11-22T07:11:40  <wumpus> in any case I don't think we can ever prevent all one-time leaks in the GUI code, too many moving parts
1502016-11-22T07:12:36  <gmaxwell> they're mostly interesting to fix because sometimes they're actual bugs, and keeping down the inconsequential ones avoids hiding the actual bugs.
1512016-11-22T07:12:48  <wumpus> the only reason they're annoying at all is that they clutter the overview, so you may miss repeated leaks
1522016-11-22T07:13:07  <wumpus> right - I found an actual (minor) bug due to it with the rpc console thread
1532016-11-22T07:14:10  <fanquake> What I'm seeing seems to be Boost related, somewhere in CCoinsViewCache::FetchCoins()
1542016-11-22T07:15:03  <wumpus> do you see it with only the GUI, or with bitcoind too?
1552016-11-22T07:15:40  <wumpus> (not seeing them in any case but maybe an OSX thing?)
1562016-11-22T07:17:00  <fanquake> Have only tested with bitcoin-qt so far, I'll look at bitcoind now.
1572016-11-22T07:22:15  *** Ylbam has joined #bitcoin-core-dev
1582016-11-22T07:23:30  <fanquake> Here's a stack trace for the Boost leak, http://pastebin.com/V2QY8NT4 , not seeing anything on bitcoind so far (other than something related to berkely-db)
1592016-11-22T07:23:33  <wumpus> the most sneaky leak (and also most bytes wasted) I fixed in #9190 was the openssl certstore one (https://github.com/bitcoin/bitcoin/pull/9190/commits/4b2c2888868cb49806cd734ea36e7f5b032c3b00) . OpenSSL's documentation is somewhat fuzzy about it, but the assumption there was wrong, that X509_STORE_add_cert really tkaes ownership
1602016-11-22T07:23:34  <gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
1612016-11-22T07:25:10  <wumpus> fanquake: what version of boost?
1622016-11-22T07:25:20  <sipa> fanquake: is that with a clean shutdown?
1632016-11-22T07:25:58  <fanquake> Boost 1.62.0
1642016-11-22T07:26:08  <fanquake> That is without shutting down, just while it's running.
1652016-11-22T07:26:23  <jonasschnelli> fanquake: I'm also compiling against Qt 5.7
1662016-11-22T07:26:47  <wumpus> you can only see *leaks* after you've shut down
1672016-11-22T07:26:56  <jonasschnelli> though I don't see the CCoinsViewCache::FetchCoins() leak
1682016-11-22T07:27:50  <wumpus> profilers can't predict the future of what an application is going to do with some memory, so you can't be sure some memory won't be released until the end of the shutdown sequence
1692016-11-22T07:28:29  <jonasschnelli> wumpus: I guess some leaks are detectable during runtime (when all pointers have lost the object)... not?
1702016-11-22T07:28:30  <wumpus> (although it could use some heuristic like "does the application retain any pointers to it" but that's horribly imprecise at most for C++)
1712016-11-22T07:28:45  <wumpus> jonasschnelli: not in general for unmanaged languages
1722016-11-22T07:29:11  <wumpus> and managed languages tend to have garbage collectors anyway :-)
1732016-11-22T07:29:20  <jonasschnelli> I guess it often leads to wrong detected leaks... (maybe losts).
1742016-11-22T07:29:28  <luke-jr> wumpus: I think it can be done with sufficient accuracy that the alternative is undefined behaviour?
1752016-11-22T07:29:36  <luke-jr> or at least very bad code :p
1762016-11-22T07:30:10  <jonasschnelli> I also think the Leak detector fanquake and I are using (Apples "Instruments") are not really made for C++... It's perfect when analyzing objective-C code.
1772016-11-22T07:30:23  * luke-jr actually finds runtime leak detection more useful than after exit, since many things use data but don't clean it up as well
1782016-11-22T07:30:35  <fanquake> Ok, I'm probably using the wrong terminology here then. I don't have too much experience using these kind of tools.
1792016-11-22T07:30:46  <wumpus> luke-jr: well that depends on your definition of 'bad code' I suppose, I'm just talking about theoretic properties not judging any particular use of cpu cycles :p
1802016-11-22T07:30:49  <fanquake> jonas Yes, hat might also be a part of the problem.
1812016-11-22T07:31:04  <luke-jr> wumpus: by bad code, I mean serializing the pointer in a uint8_t array or something
1822016-11-22T07:31:17  <luke-jr> or XORing it
1832016-11-22T07:31:22  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c577f2638b7...e4dbeb94998d
1842016-11-22T07:31:23  <bitcoin-git> bitcoin/master 76af4eb Jonas Schnelli: [Qt] fix coincontrol sort issue
1852016-11-22T07:31:23  <bitcoin-git> bitcoin/master 4231032 Wladimir J. van der Laan: [Qt] Clean up and fix coincontrol tree widget handling...
1862016-11-22T07:31:24  <bitcoin-git> bitcoin/master e4dbeb9 Jonas Schnelli: Merge #9185: [Qt] fix coincontrol sort issue...
1872016-11-22T07:31:35  <jonasschnelli> fanquake: But I was also surprised how many leaks I found with "Instruments" when writing pure C code.
1882016-11-22T07:31:50  <jonasschnelli> Though, you need a sleep(100) at the end of your application/unit-tests.
1892016-11-22T07:32:00  <jonasschnelli> Brews Valgrind is pretty broken on OSX:
1902016-11-22T07:32:05  <jonasschnelli> s/:/.
1912016-11-22T07:32:22  <luke-jr> LLVM also has a leak sanitizer
1922016-11-22T07:32:30  <fanquake> jonass As far as I know it won't work at all for a while https://bugs.kde.org/show_bug.cgi?id=365327
1932016-11-22T07:32:42  <fanquake> Neither does GDB
1942016-11-22T07:32:48  <wumpus> luke-jr: yes but I don't think e.g. pointer bit flipping tricks are by definition bad code, it just depends on the context, the resources available etc
1952016-11-22T07:33:42  <jonasschnelli> IMO all the CDB (BDB) leaks reported by "Instruments" are wrong reports...
1962016-11-22T07:33:51  <fanquake> jonasschnelli so when we're looking at anything CWallet related in instruments (which is all I see looking at bitcoind) what are we seeing exactly?
1972016-11-22T07:34:10  <fanquake> heh, just what I was wondering.
1982016-11-22T07:34:17  <jonasschnelli> fanquake: tons of BDB leaks...
1992016-11-22T07:34:20  <jonasschnelli> I guess >10MB
2002016-11-22T07:34:28  <jonasschnelli> (for a 300tx regtext wallet)
2012016-11-22T07:34:28  <wumpus> PSA: the macosx tools are wasting your time
2022016-11-22T07:34:29  <wumpus> :-)
2032016-11-22T07:34:39  <fanquake> :o
2042016-11-22T07:34:53  <jonasschnelli> wumpus: there is also the time profiler in "Instrumenst"... this is really cool.
2052016-11-22T07:34:58  <jonasschnelli> gpref like
2062016-11-22T07:35:08  <jonasschnelli> gperf
2072016-11-22T07:35:57  <jonasschnelli> wumpus: how did you detected the Qt leaks? IMO last time I used it on Bitcoin-Qt on Ubuntu I had to force shutdown my machine.. :)
2082016-11-22T07:36:04  <wumpus> luke-jr: yes - LLVM sanitizers that's what I used in #9190, built from latest LLVM git even, I have to track that anyhow for some GPU stuff
2092016-11-22T07:36:05  <gribble> https://github.com/bitcoin/bitcoin/issues/9190 | qt: Plug many memory leaks by laanwj · Pull Request #9190 · bitcoin/bitcoin · GitHub
2102016-11-22T07:36:43  <wumpus> jonasschnelli: ^
2112016-11-22T07:36:50  <jonasschnelli> Yes. Thanks...
2122016-11-22T07:37:40  <wumpus> CPPFLAGS="-ggdb -fsanitize=address -fno-omit-frame-pointer"   LDFLAGS="-fsanitize=address"
2132016-11-22T07:38:24  <fanquake> So we can ignore all of the certificate related Qt stuff as well?
2142016-11-22T07:39:03  <wumpus> it generates really nice rainbow console output, makes finding a use-after-free bug almost enjoyable
2152016-11-22T07:39:48  <wumpus> fanquake: not sure about ignoring anything, but please if you report leaks make sure that you are talking about the allocation residue after quitting the application
2162016-11-22T07:40:47  <fanquake> wumpus: Yep, have a bit better handle on this now. Looks like using some tools other than the native OS X stuff could be the way to go.
2172016-11-22T07:43:26  <wumpus> jonasschnelli: but yes visual profilers can be really cool, at a previous employer for solaris we had one that showed exactly what an application was doing on each core in a timeline overview, that was really useful for checking efficiency of concurrency etc
2182016-11-22T07:44:06  <wumpus> I kind of miss that in the linux toolset but I may be missing something, so many different tools and instrumentations
2192016-11-22T07:47:06  *** baldur has quit IRC
2202016-11-22T07:48:23  *** btcdrak has joined #bitcoin-core-dev
2212016-11-22T07:51:30  *** wasi has joined #bitcoin-core-dev
2222016-11-22T07:52:00  *** wasi has quit IRC
2232016-11-22T07:52:30  *** wasi has joined #bitcoin-core-dev
2242016-11-22T07:55:02  <sipa> dtrace?
2252016-11-22T07:58:45  <wumpus> yes I think it was based on that
2262016-11-22T08:00:32  <wumpus> but without having to actaully write dtrace scripts :)
2272016-11-22T08:08:12  *** baldur has joined #bitcoin-core-dev
2282016-11-22T08:13:08  <jonasschnelli> wumpus: when compiling with CPPFLAGS/LDFLAGS +"-fsanitize=address", I get Undefined symbols during liking (___asan_stack_malloc_5, etc.)? Any ideas?
2292016-11-22T08:14:38  *** gielbier has quit IRC
2302016-11-22T08:21:29  <wumpus> jonasschnelli: it should try to link against the asan runtime library
2312016-11-22T08:21:59  <jonasschnelli> I passed -fasnitize=address as LDFLAGS ... hmm...
2322016-11-22T08:22:03  *** wasi has quit IRC
2332016-11-22T08:22:09  <jonasschnelli> *-fsanitize=address
2342016-11-22T08:22:19  <wumpus> things like "libclang_rt.asan_cxx-i686.a"
2352016-11-22T08:22:26  *** rubensayshi has joined #bitcoin-core-dev
2362016-11-22T08:22:36  *** wasi has joined #bitcoin-core-dev
2372016-11-22T08:23:01  <wumpus> I had to put compiler-rt in my llvm/clang build to get them in the first place, but I'd expect distro-build versions to have that enabled by default
2382016-11-22T08:23:24  <wumpus> in any case yes passing that to the linker should try to link them automatically
2392016-11-22T08:25:51  <jonasschnelli> hmm... libclang_rt.asan_osx_dynamic is present...
2402016-11-22T08:29:11  <jonasschnelli> I guess OSX XCode clang uses a different linking approach in oder to support ASAN for all its supported platforms (iOS/ apple tv/ apple watch, etc.).
2412016-11-22T08:29:28  <jonasschnelli> Probably better to use a self-compiled clang (or though homebrew)
2422016-11-22T08:31:10  <fanquake> I know we already need documentation for lots of existing stuff, but this kind of debugging/configuration/dev tool type stuff would also be worth documenting. At least more than what we have now.
2432016-11-22T08:31:45  <fanquake> It'd be nice to have *lots* of people running the identical binary, and similar tools.
2442016-11-22T08:32:21  <jonasschnelli> I tried to add the ASAN to the cofigure.ac
2452016-11-22T08:34:07  <wumpus> agree that tooling documentation would be useful, though none of this is specific to bitcoin core
2462016-11-22T08:35:11  <wumpus> some projects have a wiki with this kind of auxiliary documentation
2472016-11-22T08:36:03  <fanquake> Yes I'm assuming there must be similar projects, maybe something like Tor, that would already have alot of this kind of stuff written/documented somewhere.
2482016-11-22T08:40:17  <paveljanik> fanquake, the documentation is generic for debugging tools...
2492016-11-22T08:40:31  <paveljanik> and there already is a lot of such documentation.
2502016-11-22T08:49:32  * wumpus is trying to add CPU cycles measure to the bench framework and probably stumbled on a subtle counting bug w/ rescaling the iteration count
2512016-11-22T08:49:50  <wumpus> this can cause especially the 'min' time to be off
2522016-11-22T08:55:42  <gmaxwell> wumpus: darn. I thought I'd tested that fairly well.
2532016-11-22T09:00:50  <bitcoin-git> [bitcoin] laanwj opened pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
2542016-11-22T09:08:15  <gmaxwell> oh pfft.
2552016-11-22T09:08:26  <wumpus> yea :)
2562016-11-22T09:16:11  *** paveljanik has quit IRC
2572016-11-22T09:17:33  *** jannes has joined #bitcoin-core-dev
2582016-11-22T09:28:35  <gmaxwell> wumpus: I guess I'd reasoned it would be 0 mod n due to the initial count, oh well.
2592016-11-22T09:29:33  <wumpus> yes it's really subtle, I only discovered it because I was printing lots of debug info to debug the cycle counter, then saw the first run after a scale was off
2602016-11-22T09:31:51  <wumpus> the use of floating point arithmetic in the benchmarking loop isn't too great either but I'll leave that for another time
2612016-11-22T09:32:24  <gmaxwell> yea, esp on the kind of platforms that you really need to benchmark things on.
2622016-11-22T09:33:32  <gmaxwell> I wanted to eliminate that too when I last touched it but I thought it would be too much at once. :)
2632016-11-22T09:47:01  <wumpus> exactly
2642016-11-22T09:52:38  *** laurentmt has joined #bitcoin-core-dev
2652016-11-22T09:55:55  *** laurentmt has quit IRC
2662016-11-22T09:56:32  <jouke> re IRC meeting: we use the account system
2672016-11-22T09:59:01  *** d9b4bef9 has quit IRC
2682016-11-22T10:00:07  *** d9b4bef9 has joined #bitcoin-core-dev
2692016-11-22T10:01:29  *** echonaut has quit IRC
2702016-11-22T10:01:35  *** echonaut7 has joined #bitcoin-core-dev
2712016-11-22T10:10:13  <jouke> Basically the same use case as dooglus in https://github.com/bitcoin/bitcoin/issues/3816
2722016-11-22T10:11:07  <wumpus> yes there needs to be an explanation how to do that without accounts / with the new labels API
2732016-11-22T10:11:45  <jouke> Not something we can't do ourselves, but it was there, so why not use it :P
2742016-11-22T10:12:23  <wumpus> and for that specific use case you don't really need accounts, just a way to track/group incoming payments using a label
2752016-11-22T10:16:12  <jouke> And keep track of reorgs?
2762016-11-22T10:24:24  *** jeroen has joined #bitcoin-core-dev
2772016-11-22T10:27:35  <jouke> Again, not something we can't do ourselves and we've known that accounts are deprecated for a while, but I was reading the IRC meeting summary and someone was wondering if anyone talking to the devs was using accounts, so I started talking :P
2782016-11-22T10:29:42  <Victorsueca> the whole accounts thing doesn't make a lot of sense
2792016-11-22T10:30:36  <jouke> What do you mean Victorsueca?
2802016-11-22T10:30:44  <Victorsueca> I received some bitcoins to a address labeled "Victor" and later spent them all
2812016-11-22T10:31:09  <Victorsueca> now the account "Victor" still has the balance and the default "" account is in negative
2822016-11-22T10:31:28  <Victorsueca> and I didn't use the move command
2832016-11-22T10:31:53  <jouke> Victorsueca: because you didn't use "senfrom"?
2842016-11-22T10:32:13  *** gielbier has joined #bitcoin-core-dev
2852016-11-22T10:32:21  <Victorsueca> nope, didn't use that either
2862016-11-22T10:32:41  <thermoman> sdaftuar: we do import privkeys every 2 or 3 days
2872016-11-22T10:32:50  <jouke> That's why it's negative :).
2882016-11-22T10:33:17  <jouke> Victorsueca: but I get why it's confusing, that's one of the reasons it's deprecated :)
2892016-11-22T10:35:59  <Victorsueca> is it safe if I move all from bitcoin to "" or I would mess with the wallet balance calculation?
2902016-11-22T10:36:07  <Victorsueca> from Victor*
2912016-11-22T10:37:28  <jouke> Victorsueca: sendtoaddress only subtracts the amount from the default account, sendfrom subtracts the amount from a specific account. Victorsueca it's safe, but again, don't start using accounts, it will be removed in future versions.
2922016-11-22T10:38:09  <Victorsueca> ahh nice
2932016-11-22T10:47:29  <luke-jr> Victorsueca: it makes sense.
2942016-11-22T10:48:02  <luke-jr> jouke: unless you're willing to *maintain* the account system, your usage isn't likely to change its removal
2952016-11-22T10:48:18  <luke-jr> jouke: and even if you're willing to maintain it, I think the conclusion will be "please do it outside bitcoind"
2962016-11-22T10:49:26  <jouke> luke-jr: I know.
2972016-11-22T10:49:31  <Victorsueca> luke-jr: btw, I was wondering when will you be able to push segwit into bfgminer
2982016-11-22T10:50:17  <luke-jr> Victorsueca: you mean libblkmaker :P
2992016-11-22T10:50:22  <luke-jr> Victorsueca: testing would be helpful
3002016-11-22T10:51:44  <Victorsueca> luke-jr: I would, but my Antminer U3 seems to only work on windows and I didn't find any instructions on how to cross-compile
3012016-11-22T10:52:09  <luke-jr> review is helpful too
3022016-11-22T10:52:25  <Victorsueca> don't know coding C++
3032016-11-22T10:54:04  <luke-jr> https://github.com/bitcoin/libblkmaker/pull/6  https://github.com/luke-jr/eloipool/pull/15
3042016-11-22T10:54:16  <luke-jr> Eloipool is Python <.<
3052016-11-22T10:54:31  <luke-jr> will get you Windows bins for BFG in a min
3062016-11-22T10:55:00  <Victorsueca> nice thanks
3072016-11-22T10:57:44  <luke-jr> :| build failure, a few more min..
3082016-11-22T10:58:15  <Victorsueca> hehhehe
3092016-11-22T10:58:44  <Victorsueca> windoze will always be windoze
3102016-11-22T11:02:59  <luke-jr> in this case, it is libgcrypt's fault
3112016-11-22T11:03:13  <luke-jr> but that's okay because it shouldn't be using libgcrypt in the first place :P
3122016-11-22T11:04:11  *** shesek has quit IRC
3132016-11-22T11:07:57  <luke-jr> Victorsueca: http://luke.dashjr.org/tmp/code/webisect/webisect.php?dobuild=segwit
3142016-11-22T11:09:38  <Victorsueca> nice, going to try it out
3152016-11-22T11:10:30  <thermoman> gmaxwell, sipa, sdaftuar: https://github.com/bitcoin/bitcoin/issues/9201
3162016-11-22T11:16:56  <luke-jr> Victorsueca: p.s. if you want to mine testnet with it, tmp.pool.bitcoin.dashjr.org port 3334 (stratum) or 8337 (GBT & getwork)
3172016-11-22T11:17:22  <luke-jr> Victorsueca: no promises I don't kill it in a few hours tho, it's eating CPU time
3182016-11-22T11:17:34  *** shesek has joined #bitcoin-core-dev
3192016-11-22T11:17:37  <luke-jr> besides, better to solo mine :P
3202016-11-22T11:17:51  <wumpus> jouke: no, with labels instead of accounts you don't have to manually keep track of reorgs, you can still check the total balance received to a label, for example. You just cannot do accounting, so move coins instead of addresses from one label to another
3212016-11-22T11:18:41  <luke-jr> can't send from labels either :p
3222016-11-22T11:18:52  <wumpus> right
3232016-11-22T11:19:16  *** fanquake has left #bitcoin-core-dev
3242016-11-22T11:21:03  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e4dbeb94998d...55b2eddcc8fd
3252016-11-22T11:21:04  <bitcoin-git> bitcoin/master e0a9cb2 Wladimir J. van der Laan: bench: Fix subtle counting issue when rescaling iteration count...
3262016-11-22T11:21:05  <bitcoin-git> bitcoin/master 55b2edd Wladimir J. van der Laan: Merge #9200: bench: Fix subtle counting issue when rescaling iteration count...
3272016-11-22T11:21:17  <bitcoin-git> [bitcoin] laanwj closed pull request #9200: bench: Fix subtle counting issue when rescaling iteration count (master...2016_11_bench_fix) https://github.com/bitcoin/bitcoin/pull/9200
3282016-11-22T11:22:18  <Victorsueca> luke-jr: thanks, I will try to solo-mine for a while too to see if it signals segwit properly
3292016-11-22T11:23:18  <bitcoin-git> [bitcoin] laanwj opened pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202
3302016-11-22T11:45:12  *** abpa has quit IRC
3312016-11-22T11:57:02  <Victorsueca> luke-jr: any tip on how to detect my Antminer U3? I've been following the instructions on README.ASIC ut it won't detect it
3322016-11-22T11:57:10  <Victorsueca> but*
3332016-11-22T11:57:23  <luke-jr> Victorsueca: the official drivers are installed? (not WinUSB/Zadig)
3342016-11-22T11:59:28  <Victorsueca> ahh, It needs to be with the default driver?
3352016-11-22T11:59:41  <Victorsueca> I have WinUSB
3362016-11-22T12:02:11  <luke-jr> yes
3372016-11-22T12:08:01  *** CubicEarth has quit IRC
3382016-11-22T12:27:21  <Victorsueca> luke-jr: still not detecting it
3392016-11-22T12:27:35  <luke-jr> with the options in README.ASIC?
3402016-11-22T12:28:02  <Victorsueca> yep, and with the default sillabs driver
3412016-11-22T12:28:09  <wumpus> this is not related to bitcoin core development, can you move this to #bitcoin?
3422016-11-22T12:28:15  <Victorsueca> sure
3432016-11-22T12:57:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
3442016-11-22T13:08:31  *** CubicEarth has joined #bitcoin-core-dev
3452016-11-22T13:12:50  <bitcoin-git> [bitcoin] jnewbery closed pull request #9203: [trivial] Fixes the RPC help text for waitforblockheight (master...waitforblockheightcomment) https://github.com/bitcoin/bitcoin/pull/9203
3462016-11-22T13:13:16  *** CubicEarth has quit IRC
3472016-11-22T13:31:47  *** Giszmo has joined #bitcoin-core-dev
3482016-11-22T13:46:34  *** laurentmt has joined #bitcoin-core-dev
3492016-11-22T13:46:39  *** laurentmt has quit IRC
3502016-11-22T13:48:47  <instagibbs> ;;later tell vanishing-coins Looks like you are trying to make dust, aka too-small outputs, and your wallet is refusing to send them
3512016-11-22T13:48:48  <gribble> The operation succeeded.
3522016-11-22T13:52:15  *** aalex__ has joined #bitcoin-core-dev
3532016-11-22T13:58:48  *** aalex__ has quit IRC
3542016-11-22T14:04:37  *** wasi has quit IRC
3552016-11-22T14:04:59  *** BashCo has joined #bitcoin-core-dev
3562016-11-22T14:05:09  *** wasi has joined #bitcoin-core-dev
3572016-11-22T14:16:12  *** jtimon has joined #bitcoin-core-dev
3582016-11-22T14:23:55  *** cryptapus has joined #bitcoin-core-dev
3592016-11-22T14:23:55  *** cryptapus has joined #bitcoin-core-dev
3602016-11-22T14:27:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3612016-11-22T14:31:57  *** cryptapus has quit IRC
3622016-11-22T14:32:22  *** cryptapus has joined #bitcoin-core-dev
3632016-11-22T14:33:04  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55b2eddcc8fd...ac489b24453c
3642016-11-22T14:33:04  <bitcoin-git> bitcoin/master 1260c11 Pavel Janík: Mention the new network toggle functionality in the tooltip.
3652016-11-22T14:33:04  <bitcoin-git> bitcoin/master ac489b2 Jonas Schnelli: Merge #9130: Mention the new network toggle functionality in the tooltip....
3662016-11-22T14:33:17  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9130: Mention the new network toggle functionality in the tooltip. (master...20161111_disable_network_tooltip) https://github.com/bitcoin/bitcoin/pull/9130
3672016-11-22T14:34:38  *** Guyver2 has joined #bitcoin-core-dev
3682016-11-22T14:42:19  <nsh> toggles all network activity?
3692016-11-22T14:42:22  <nsh> handy i guess
3702016-11-22T14:42:44  *** aalex__ has joined #bitcoin-core-dev
3712016-11-22T14:43:05  <jonasschnelli> nsh: The PR above is just a cosmetic one.
3722016-11-22T14:43:20  <jonasschnelli> The actual toggle It's in master since some days
3732016-11-22T14:43:31  <jonasschnelli> Just press the network-icon on the top right in the status bar.
3742016-11-22T14:43:38  <jonasschnelli> (if you are using the GUI)
3752016-11-22T14:43:39  * nsh nods
3762016-11-22T14:45:43  *** laurentmt has joined #bitcoin-core-dev
3772016-11-22T14:50:20  <wumpus> setnetworkactive through rpc
3782016-11-22T14:52:01  *** laurentmt has quit IRC
3792016-11-22T15:56:17  *** abpa has joined #bitcoin-core-dev
3802016-11-22T15:58:07  *** abpa has quit IRC
3812016-11-22T16:21:15  *** jeroen has quit IRC
3822016-11-22T16:22:36  *** Chris_Stewart_5 has quit IRC
3832016-11-22T16:54:25  *** instagibbs has quit IRC
3842016-11-22T17:00:35  *** instagibbs has joined #bitcoin-core-dev
3852016-11-22T17:03:21  *** rubensayshi has quit IRC
3862016-11-22T17:05:42  *** abpa has joined #bitcoin-core-dev
3872016-11-22T17:34:38  *** atroxes_ has joined #bitcoin-core-dev
3882016-11-22T17:35:08  *** atroxes_ has quit IRC
3892016-11-22T17:36:46  *** atroxes has quit IRC
3902016-11-22T17:39:21  *** protomar has joined #bitcoin-core-dev
3912016-11-22T17:58:54  *** abpa has quit IRC
3922016-11-22T18:00:54  *** ryanofsky has quit IRC
3932016-11-22T18:12:10  *** CubicEarth has joined #bitcoin-core-dev
3942016-11-22T18:14:19  *** aalex__ is now known as aalex
3952016-11-22T18:17:38  *** abpa has joined #bitcoin-core-dev
3962016-11-22T18:22:14  <bitcoin-git> [bitcoin] instagibbs opened pull request #9204: Clarify CreateTransaction error messages (master...nonneg) https://github.com/bitcoin/bitcoin/pull/9204
3972016-11-22T18:23:18  *** ryanofsky has joined #bitcoin-core-dev
3982016-11-22T18:29:26  *** abpa has quit IRC
3992016-11-22T18:36:23  *** abpa has joined #bitcoin-core-dev
4002016-11-22T18:38:13  *** paveljanik has joined #bitcoin-core-dev
4012016-11-22T18:38:13  *** paveljanik has joined #bitcoin-core-dev
4022016-11-22T18:41:01  *** abpa has quit IRC
4032016-11-22T18:43:30  *** abpa has joined #bitcoin-core-dev
4042016-11-22T18:43:41  *** laurentmt has joined #bitcoin-core-dev
4052016-11-22T18:44:45  *** laurentmt has quit IRC
4062016-11-22T18:55:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4072016-11-22T19:06:01  <bitcoin-git> [bitcoin] in3rsha opened pull request #9205: Minor change to comment for consistency. (master...master) https://github.com/bitcoin/bitcoin/pull/9205
4082016-11-22T19:33:03  *** instagibbs has quit IRC
4092016-11-22T19:33:49  *** instagibbs has joined #bitcoin-core-dev
4102016-11-22T19:38:32  *** instagibbs has quit IRC
4112016-11-22T19:43:21  *** instagibbs has joined #bitcoin-core-dev
4122016-11-22T19:45:04  <adiabat> howdy, I've having trouble getting 0.13.1 synced up to testnet3
4132016-11-22T19:45:09  <adiabat> running on a raspi2
4142016-11-22T19:45:36  <adiabat> got a "EXCEPTION: St9bad_alloc" in debug.log
4152016-11-22T19:45:50  <sipa> how much ram does that have?
4162016-11-22T19:45:57  <adiabat> 1G
4172016-11-22T19:46:24  <adiabat> I've gotten that exception in different places when deleting and starting over
4182016-11-22T19:46:25  <sipa> hmm, maybe you need a bit of tweaking to reduce dbcache/mempool, and limit the number of peers?
4192016-11-22T19:46:35  <sipa> it shouldn't be much
4202016-11-22T19:46:49  <adiabat> this is all with 1 peer via connect= in the conf
4212016-11-22T19:46:59  <adiabat> also I'm running txindex=1
4222016-11-22T19:47:03  <sipa> ah
4232016-11-22T19:48:15  <adiabat> it was working OK on 0.13.1 but that had been upgraded many times.  Then I broke my microSD card in half :(
4242016-11-22T19:48:48  <adiabat> IBD from scratch on .13.1 on the pi may need different settings?
4252016-11-22T19:50:06  <sipa> maybe... it clearly means OOM
4262016-11-22T19:50:55  <adiabat> I'll try dbcache=64
4272016-11-22T19:56:59  *** aalex_ has joined #bitcoin-core-dev
4282016-11-22T19:57:12  *** cfields has quit IRC
4292016-11-22T20:00:48  *** aalex has quit IRC
4302016-11-22T20:00:48  *** cfields has joined #bitcoin-core-dev
4312016-11-22T20:02:42  <adiabat> If this works (will know in ~24hrs) maybe we can put a readme or something.  With the arm binaries I think more people will try running on a pi2/pi3
4322016-11-22T20:03:40  <adiabat> also far be it from me to complain but trashing the who DB requiring re-index on an OOM error is... unfortunate.
4332016-11-22T20:03:48  <adiabat> (Not offering to fix that! heh)
4342016-11-22T20:03:58  <adiabat> who = *whole
4352016-11-22T20:05:08  <sipa> we should work on being able to dump the utxo set to a file and load it back
4362016-11-22T20:07:51  <adiabat> I've never had bitcoind get in trouble with RAM on a regular x86 computer, and I've run it on PCs with 2G of RAM
4372016-11-22T20:10:36  *** cysm has quit IRC
4382016-11-22T20:15:21  <gmaxwell> 2GB is a lot more than 1GB. :)
4392016-11-22T20:17:05  <adiabat> heh... I wonder what the least powerful full node is.  raspi is getting close maybe, but I'm sure someone out there has it running with 512MB
4402016-11-22T20:17:41  <Victorsueca> adiabat: just download more ram ;)
4412016-11-22T20:18:33  <sipa> it's not cisco hardware
4422016-11-22T20:18:55  <pigeons> ramdoubler.exe
4432016-11-22T20:31:22  <Chris_Stewart_5> Is the serialization format described in BIP141 only used when calculating a wtxid, or is this serialization format also used when propogating a tx across the p2p network?
4442016-11-22T20:31:24  <Chris_Stewart_5> https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#transaction-id
4452016-11-22T20:32:02  <sipa> Chris_Stewart_5: see bip144 for that
4462016-11-22T20:32:55  <Chris_Stewart_5> ahhh that makes a lot more sense :-)
4472016-11-22T20:37:52  *** aalex__ has joined #bitcoin-core-dev
4482016-11-22T20:41:53  *** aalex_ has quit IRC
4492016-11-22T20:42:22  *** laurentmt has joined #bitcoin-core-dev
4502016-11-22T20:42:43  *** laurentmt has quit IRC
4512016-11-22T20:48:31  <instagibbs> too-many-bips problem :P
4522016-11-22T20:48:52  <instagibbs> is there a zmq/rest test suite?
4532016-11-22T21:29:58  *** jannes has quit IRC
4542016-11-22T21:38:51  <bitcoin-git> [bitcoin] btcdrak opened pull request #9206: Make test constant consistent with consensus.h (master...consistency) https://github.com/bitcoin/bitcoin/pull/9206
4552016-11-22T21:45:15  *** laurentmt has joined #bitcoin-core-dev
4562016-11-22T21:51:40  *** laurentmt has quit IRC
4572016-11-22T22:00:35  *** CubicEarth has quit IRC
4582016-11-22T22:03:59  *** CubicEarth has joined #bitcoin-core-dev
4592016-11-22T22:06:38  <jtimon> updated https://github.com/bitcoin/bitcoin/pull/9177 's description
4602016-11-22T22:15:16  <jtimon> also if anyone is bored, you can fetch #8994 , grep and remove 'self.chain = "regtest"' and you should have 4 tests failing, ie p2p-comapctblocks.py,  segwit.py,  mempool_packages.py (extended) and  pruning.py (extended)
4612016-11-22T22:15:17  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
4622016-11-22T22:17:38  <jtimon> also please review #8855 (takes +86 −81 out of review from #8994 's +360 −201 and #9177 's +866 −286)
4632016-11-22T22:17:40  <gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
4642016-11-22T22:17:42  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
4652016-11-22T22:17:44  <gribble> https://github.com/bitcoin/bitcoin/issues/9177 | NOMERGE: WIP: Support block signed custom testchains by jtimon · Pull Request #9177 · bitcoin/bitcoin · GitHub
4662016-11-22T22:18:36  <jtimon> plus I wouldn't need to rebase every time a new test uses Params(std::string)
4672016-11-22T22:18:59  <jtimon> </review begging>
4682016-11-22T22:20:50  <jtimon> final note (I believe #8994 could be merged as it is modulo squash)
4692016-11-22T22:20:52  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
4702016-11-22T22:25:58  *** Guyver2 has quit IRC
4712016-11-22T22:31:08  *** protomar has quit IRC
4722016-11-22T22:36:03  <luke-jr> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/8877#discussion_r89126900 <-- ?
4732016-11-22T23:36:52  *** laurentmt has joined #bitcoin-core-dev
4742016-11-22T23:37:13  *** laurentmt has quit IRC