12016-11-29T00:18:57  *** moli has joined #bitcoin-core-dev
  22016-11-29T00:44:23  *** dcousens has joined #bitcoin-core-dev
  32016-11-29T00:48:43  *** owowo has quit IRC
  42016-11-29T00:50:27  *** owowo has joined #bitcoin-core-dev
  52016-11-29T00:50:27  *** owowo has joined #bitcoin-core-dev
  62016-11-29T00:50:27  *** owowo has joined #bitcoin-core-dev
  72016-11-29T01:02:35  *** mrkent has joined #bitcoin-core-dev
  82016-11-29T01:02:40  *** Ylbam has quit IRC
  92016-11-29T01:45:44  *** CubicEarth has joined #bitcoin-core-dev
 102016-11-29T01:49:37  <bitcoin-git> [bitcoin] kallewoof opened pull request #9235: Refactor: Removes all uses of `using namespace` in all source files. (master...no-using-ns2) https://github.com/bitcoin/bitcoin/pull/9235
 112016-11-29T01:53:41  *** Chris_Stewart_5 has quit IRC
 122016-11-29T01:55:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 132016-11-29T01:56:26  *** CubicEarth has joined #bitcoin-core-dev
 142016-11-29T02:00:40  *** btcdrak has joined #bitcoin-core-dev
 152016-11-29T02:00:55  *** abpa has quit IRC
 162016-11-29T02:06:42  *** CubicEarth has quit IRC
 172016-11-29T02:10:05  *** 14WAAM8DN has joined #bitcoin-core-dev
 182016-11-29T02:15:39  *** fanquake has joined #bitcoin-core-dev
 192016-11-29T02:20:15  *** dcousens has quit IRC
 202016-11-29T02:22:10  *** dcousens has joined #bitcoin-core-dev
 212016-11-29T02:54:15  *** wasi has quit IRC
 222016-11-29T03:37:41  *** dcousens has quit IRC
 232016-11-29T03:39:36  *** dcousens has joined #bitcoin-core-dev
 242016-11-29T03:44:32  *** abpa has joined #bitcoin-core-dev
 252016-11-29T03:47:45  *** cysm has joined #bitcoin-core-dev
 262016-11-29T04:40:24  *** 14WAAM8DN is now known as CubicEarth
 272016-11-29T04:46:37  *** abpa has quit IRC
 282016-11-29T05:17:48  <achow101> what happened to createwitnessaddress?
 292016-11-29T05:23:44  *** jtimon has quit IRC
 302016-11-29T05:36:53  <btcdrak> achow101: it was removed
 312016-11-29T05:39:10  <achow101> I gathered that much. I don't quite understand why it was removed. Couldn't it just have been modified to check for address validity too?
 322016-11-29T05:41:22  <sipa> achow101: it has no access to the wallet, so it would at least need an api change
 332016-11-29T05:41:34  <sipa> where you pass it the full script, pubkeys, ...
 342016-11-29T05:43:06  <achow101> oh. i see
 352016-11-29T05:46:10  *** Giszmo has quit IRC
 362016-11-29T06:10:18  *** aalex__ has joined #bitcoin-core-dev
 372016-11-29T06:17:50  *** aalex__ has quit IRC
 382016-11-29T06:18:17  *** Alopex has quit IRC
 392016-11-29T06:19:22  *** Alopex has joined #bitcoin-core-dev
 402016-11-29T06:27:19  *** Ylbam has joined #bitcoin-core-dev
 412016-11-29T06:31:49  *** dermoth_ has joined #bitcoin-core-dev
 422016-11-29T06:32:15  *** dermoth has quit IRC
 432016-11-29T06:32:17  *** dermoth_ is now known as dermoth
 442016-11-29T06:35:11  *** Alopex has quit IRC
 452016-11-29T06:36:16  *** Alopex has joined #bitcoin-core-dev
 462016-11-29T07:00:20  *** dermoth has quit IRC
 472016-11-29T07:03:04  *** dermoth has joined #bitcoin-core-dev
 482016-11-29T07:10:11  *** aalex__ has joined #bitcoin-core-dev
 492016-11-29T07:19:45  <fanquake> Finally finished a deterministic fuzzing cycle with 9172. Happy to share the outputs with anyone who'd like a look.
 502016-11-29T07:25:33  *** crudel has quit IRC
 512016-11-29T07:31:02  *** Alopex has quit IRC
 522016-11-29T07:32:07  *** Alopex has joined #bitcoin-core-dev
 532016-11-29T07:37:49  *** Atomicat_ has joined #bitcoin-core-dev
 542016-11-29T07:39:44  *** Atomicat has quit IRC
 552016-11-29T07:39:44  *** Atomicat_ is now known as Atomicat
 562016-11-29T07:43:54  *** paveljanik has quit IRC
 572016-11-29T07:48:08  *** aalex__ has quit IRC
 582016-11-29T08:10:49  *** aalex__ has joined #bitcoin-core-dev
 592016-11-29T08:17:07  *** aalex__ has quit IRC
 602016-11-29T08:32:23  <gmaxwell> https://www.reddit.com/r/Bitcoin/comments/5ffwg2/raspberry_pi_1_b_512mb_ram_running_bitcoind_0131/  positive report.
 612016-11-29T08:33:21  <rabidus> next step: pebble
 622016-11-29T08:33:25  <rabidus> :)
 632016-11-29T08:37:01  <rabidus> wow, i didn't know that pebble has some sort of crypto/hash processor
 642016-11-29T08:37:07  <rabidus> https://www.reddit.com/r/pebble/wiki/tech_specs
 652016-11-29T08:37:10  <rabidus> /offtopic
 662016-11-29T08:47:03  *** murchandamus has joined #bitcoin-core-dev
 672016-11-29T09:05:17  *** cryptapus_afk has quit IRC
 682016-11-29T09:10:41  *** jannes has joined #bitcoin-core-dev
 692016-11-29T09:40:30  *** cryptapus_afk has joined #bitcoin-core-dev
 702016-11-29T09:40:43  *** cryptapus_afk has joined #bitcoin-core-dev
 712016-11-29T09:43:12  *** wvr has quit IRC
 722016-11-29T09:44:31  *** laurentmt has joined #bitcoin-core-dev
 732016-11-29T09:46:57  <btcdrak> fullnode wrist watches? I like the idea.
 742016-11-29T09:52:23  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9236: Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings (master...strMiscraceless) https://github.com/bitcoin/bitcoin/pull/9236
 752016-11-29T09:54:10  *** laurentmt has quit IRC
 762016-11-29T10:03:01  *** Alopex has quit IRC
 772016-11-29T10:04:06  *** Alopex has joined #bitcoin-core-dev
 782016-11-29T10:08:29  *** CubicEarth has quit IRC
 792016-11-29T10:08:31  *** cryptapus_afk has quit IRC
 802016-11-29T10:08:41  *** aalex__ has joined #bitcoin-core-dev
 812016-11-29T10:14:20  *** MarcoFalke has joined #bitcoin-core-dev
 822016-11-29T10:14:50  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4522e71c7e1...7bd1aa566fb4
 832016-11-29T10:14:50  <bitcoin-git> bitcoin/master 15fa95d fsb4000: Fix some typos
 842016-11-29T10:14:51  <bitcoin-git> bitcoin/master 7bd1aa5 MarcoFalke: Merge #9233: Fix some typos...
 852016-11-29T10:15:09  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9233: Fix some typos (master...master) https://github.com/bitcoin/bitcoin/pull/9233
 862016-11-29T10:15:12  *** aalex__ has quit IRC
 872016-11-29T10:20:29  *** moli has quit IRC
 882016-11-29T10:23:17  <gmaxwell> damn, I noticed that github is now setting that 'allow edits from maintainers' thing without prompting you.
 892016-11-29T10:23:25  *** cryptapus_afk has joined #bitcoin-core-dev
 902016-11-29T10:27:58  *** moli has joined #bitcoin-core-dev
 912016-11-29T10:28:55  *** wasi has joined #bitcoin-core-dev
 922016-11-29T10:29:18  <luke-jr> gmaxwell: wasn't it always, since introduction?
 932016-11-29T10:30:12  <gmaxwell> at least before on the pull req screen it was a clear option there, I don't see it now and it's just on.
 942016-11-29T10:30:52  <luke-jr> :/
 952016-11-29T10:42:25  *** MarcoFalke has left #bitcoin-core-dev
 962016-11-29T10:47:32  *** Guyver2 has joined #bitcoin-core-dev
 972016-11-29T10:53:19  *** Victorsueca has quit IRC
 982016-11-29T11:09:21  *** aalex__ has joined #bitcoin-core-dev
 992016-11-29T11:15:21  *** aalex__ has quit IRC
1002016-11-29T11:16:45  *** Victorsueca has joined #bitcoin-core-dev
1012016-11-29T11:22:09  *** murchandamus has quit IRC
1022016-11-29T11:23:21  *** murchandamus has joined #bitcoin-core-dev
1032016-11-29T11:25:40  <wumpus> yea it always defaulted to on from when the option was there, not sure whether you can change that default for your account
1042016-11-29T11:26:52  *** murchandamus has quit IRC
1052016-11-29T11:27:28  *** murchandamus has joined #bitcoin-core-dev
1062016-11-29T11:30:25  *** murchandamus has quit IRC
1072016-11-29T11:38:05  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7bd1aa566fb4...0a0441358c81
1082016-11-29T11:38:06  <bitcoin-git> bitcoin/master 498a1d7 Ivo van der Sangen: Include select.h when WIN32 is not defined
1092016-11-29T11:38:06  <bitcoin-git> bitcoin/master 0a04413 Wladimir J. van der Laan: Merge #9224: Prevent FD_SETSIZE error building on OpenBSD...
1102016-11-29T11:38:20  <bitcoin-git> [bitcoin] laanwj closed pull request #9224: Prevent FD_SETSIZE error building on OpenBSD (master...unix-compilation) https://github.com/bitcoin/bitcoin/pull/9224
1112016-11-29T11:40:04  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a0441358c81...5488514b901d
1122016-11-29T11:40:05  <bitcoin-git> bitcoin/master 42071ca Matt Corallo: Make fDisconnect an std::atomic
1132016-11-29T11:40:06  <bitcoin-git> bitcoin/master 047ea10 Matt Corallo: Make fImporting an std::atomic
1142016-11-29T11:40:06  <bitcoin-git> bitcoin/master dbfaade Matt Corallo: Fix AddrMan locking
1152016-11-29T11:40:14  <bitcoin-git> [bitcoin] laanwj closed pull request #9225: Fix some benign races (master...2016-11-lockfixes) https://github.com/bitcoin/bitcoin/pull/9225
1162016-11-29T11:40:24  *** murchandamus has joined #bitcoin-core-dev
1172016-11-29T11:41:56  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5488514b901d...e56cf67e6b3f
1182016-11-29T11:41:56  <bitcoin-git> bitcoin/master 3532818 Wladimir J. van der Laan: bench: Add support for measuring CPU cycles...
1192016-11-29T11:41:57  <bitcoin-git> bitcoin/master e56cf67 Wladimir J. van der Laan: Merge #9202: bench: Add support for measuring CPU cycles...
1202016-11-29T11:42:09  <bitcoin-git> [bitcoin] laanwj closed pull request #9202: bench: Add support for measuring CPU cycles (master...2016_11_bench_cpu_cycles) https://github.com/bitcoin/bitcoin/pull/9202
1212016-11-29T11:42:28  *** murchandamus has quit IRC
1222016-11-29T11:43:03  *** murchandamus has joined #bitcoin-core-dev
1232016-11-29T11:51:58  *** dcousens has quit IRC
1242016-11-29T11:53:54  *** dcousens has joined #bitcoin-core-dev
1252016-11-29T12:58:56  *** jtimon has joined #bitcoin-core-dev
1262016-11-29T13:02:30  *** mrkent has quit IRC
1272016-11-29T13:08:38  *** To7 has quit IRC
1282016-11-29T13:10:50  *** fanquake has quit IRC
1292016-11-29T13:38:32  *** laurentmt has joined #bitcoin-core-dev
1302016-11-29T13:43:06  *** laurentmt has quit IRC
1312016-11-29T14:00:10  *** laurentmt has joined #bitcoin-core-dev
1322016-11-29T14:02:22  *** laurentmt has quit IRC
1332016-11-29T14:24:11  *** murchandamus has quit IRC
1342016-11-29T14:25:57  *** murchandamus has joined #bitcoin-core-dev
1352016-11-29T14:50:19  *** aalex__ has joined #bitcoin-core-dev
1362016-11-29T14:59:41  *** laurentmt has joined #bitcoin-core-dev
1372016-11-29T15:00:39  *** laurentmt has quit IRC
1382016-11-29T15:00:58  *** wvr has joined #bitcoin-core-dev
1392016-11-29T15:07:12  *** dcousens has quit IRC
1402016-11-29T15:22:14  *** laurentmt has joined #bitcoin-core-dev
1412016-11-29T15:23:35  *** laurentmt has quit IRC
1422016-11-29T15:24:26  *** Giszmo has joined #bitcoin-core-dev
1432016-11-29T15:29:07  *** owowo has quit IRC
1442016-11-29T15:36:36  *** jtimon has quit IRC
1452016-11-29T15:37:53  <Chris_Stewart_5> Do redeem scripts have a push op added to them when they are removed from the stack? I'm looking at this test case specifically
1462016-11-29T15:37:55  <Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/test/data/script_tests.json#L1863
1472016-11-29T15:39:05  <Chris_Stewart_5> When the tx is serialized for a signature, the redeem script has a '43' pushop prepended to it so the script is '4341047...'
1482016-11-29T15:43:46  *** owowo has joined #bitcoin-core-dev
1492016-11-29T15:48:59  <Chris_Stewart_5> in the case of segwit I should say
1502016-11-29T15:55:34  <morcos> sipa: What do you think about removing txConflicted from the block connection logic?  You and I had a discussion about it referenced here: #8692 and sdaftuar and I have been discussing all morning
1512016-11-29T15:55:35  <gribble> https://github.com/bitcoin/bitcoin/issues/8692 | Marking chains of txs conflicted properly · Issue #8692 · bitcoin/bitcoin · GitHub
1522016-11-29T15:56:26  <morcos> Right now, it does effectively nothing (marks balances dirty, but the balance recalculation will result in the same balance because the txs conflicted via mempool detection aren't actually marked conflicted)
1532016-11-29T15:57:24  <morcos> I propose commenting (in the code?) about a general out line of how we could do a better best efforts for also using the mempool for conflict detection.   but there are several corner cases that make this a larger project.
1542016-11-29T15:57:59  <morcos> I think it woudl be simpler to understand if for now we didn' thave this ineffective method sitting around, and later if anyone is inclined they could try a new design to do it properly?
1552016-11-29T15:59:55  <morcos> BlueMatt: ^ ?
1562016-11-29T16:19:56  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9238: Ignore BIP35 mempool command by default (master...2016/11/dis_mempool) https://github.com/bitcoin/bitcoin/pull/9238
1572016-11-29T16:22:40  *** Ylbam has quit IRC
1582016-11-29T16:31:18  *** Lauda has quit IRC
1592016-11-29T16:32:34  *** Lauda has joined #bitcoin-core-dev
1602016-11-29T16:33:53  *** Ylbam has joined #bitcoin-core-dev
1612016-11-29T17:04:36  <sipa> morcos: i vaguely remember we're effectively only using the in-wallet confict detection?
1622016-11-29T17:05:24  <morcos> sipa: correct, the in-wallet detection is the only one that marks conflicted..  that issue links to the IRC convo you and i had, but in short you were proposing we could make the mempool conflict detection also mark conflicted
1632016-11-29T17:05:38  <morcos> and then be smarter later about how to mark things dirty if they might have become unconflicted
1642016-11-29T17:05:47  <sipa> hmm
1652016-11-29T17:05:50  <morcos> this would improve our "best efforts" basis of finding all conflicts
1662016-11-29T17:06:03  <morcos> but i think there are lots of corner cases and its basically impossible to get perfect
1672016-11-29T17:06:41  <sipa> my only concern was that it felt stupid to delete code which has a reasonable chance of being close to working
1682016-11-29T17:06:45  <morcos> my only suggestion now, is remove the misleading and useless mempool conflict detection for now, until we decide to do it better, if we ever do
1692016-11-29T17:07:00  <sipa> but if you say there are many edge cases to get right, delete it
1702016-11-29T17:07:18  <morcos> yeah that was my concern too, but i think there are enough issues around it .. yep.. ok, i'll propose a PR
1712016-11-29T17:07:43  <morcos> not necessarily too many, but too many that we're about to do it anytime soon, and it might look a bit different when we do
1722016-11-29T17:15:02  <morcos> jonasschnelli: I have some questions about the new smart fee slider label introduced in #8989
1732016-11-29T17:15:04  <gribble> https://github.com/bitcoin/bitcoin/issues/8989 | [Qt] overhaul smart-fee slider, adjust default confirmation target by jonasschnelli · Pull Request #8989 · bitcoin/bitcoin · GitHub
1742016-11-29T17:15:54  <morcos> The way the smart fee slider always worked was it was displaying to you the estimate that estimateSMARTfee was returning which might have been at a different number of blocks than your requested target.
1752016-11-29T17:17:00  <morcos> now it is true, that the pre-existing code was then actually trying to send your transaction with estimatesmartefee from you requested target, which i guess might have changed if that was all of a sudden now possible to return an answer
1762016-11-29T17:17:06  <morcos> so that was maybe already a slight bug
1772016-11-29T17:18:05  <morcos> but i think it is confusing now that the label below the slider shows your requested target, which maybe different from the label above ths slider which shows the found target
1782016-11-29T17:18:58  <morcos> That said... i'm not really sure what the solution is
1792016-11-29T17:35:11  *** aalex__ has quit IRC
1802016-11-29T17:51:18  *** jannes has quit IRC
1812016-11-29T17:55:50  *** aalex__ has joined #bitcoin-core-dev
1822016-11-29T18:12:03  *** aalex_ has joined #bitcoin-core-dev
1832016-11-29T18:14:42  <bitcoin-git> [bitcoin] morcos opened pull request #9239: Disable fee estimates for 1 block target (master...blockstreamtil2blocks) https://github.com/bitcoin/bitcoin/pull/9239
1842016-11-29T18:15:29  *** aalex__ has quit IRC
1852016-11-29T18:24:24  <morcos> jonasschnelli: I think the way I did above PR, the problem will be rare that the 2 numbers will be different...  so its probably not worth worrying about..  although you should make sure you are ok with changes to smartfeeslider
1862016-11-29T18:43:00  *** aalex__ has joined #bitcoin-core-dev
1872016-11-29T18:46:45  *** aalex_ has quit IRC
1882016-11-29T18:59:38  *** aalex__ has quit IRC
1892016-11-29T19:00:22  *** aalex has joined #bitcoin-core-dev
1902016-11-29T19:22:13  *** bsm117532 has quit IRC
1912016-11-29T19:25:03  *** bsm117532 has joined #bitcoin-core-dev
1922016-11-29T19:27:56  *** murchandamus has quit IRC
1932016-11-29T19:28:09  *** belcher has quit IRC
1942016-11-29T19:29:46  *** murchandamus has joined #bitcoin-core-dev
1952016-11-29T19:39:39  *** murchandamus has quit IRC
1962016-11-29T19:40:21  *** murchandamus has joined #bitcoin-core-dev
1972016-11-29T19:41:08  <Chris_Stewart_5> Is casting to CScriptBase the only way to serialize CScript to a hex string while keeping the push ops around?
1982016-11-29T19:47:04  *** belcher has joined #bitcoin-core-dev
1992016-11-29T19:48:53  <BlueMatt> morcos: hum, I dont think I've looked at the conflict-detection code in forever
2002016-11-29T19:49:03  *** murchandamus has quit IRC
2012016-11-29T19:49:12  <BlueMatt> if you fix it up I'm more than happy to take a look :p
2022016-11-29T19:49:49  *** murchandamus has joined #bitcoin-core-dev
2032016-11-29T19:50:45  <morcos> BlueMatt: i'm not fixing it up (at least not now) i'm removing the code that doesn't serve a valuable function..  partly pinging you as it affects #9014.  anyway, will do and then we can discuss on PR.  right now i'm swimming in asserts
2042016-11-29T19:50:47  <gribble> https://github.com/bitcoin/bitcoin/issues/9014 | Fix block-connection performance regression by TheBlueMatt · Pull Request #9014 · bitcoin/bitcoin · GitHub
2052016-11-29T19:51:16  <BlueMatt> morcos: yea, i figured it'd effect 9014, but probably not in any way I care about :p
2062016-11-29T20:03:04  *** echonaut has quit IRC
2072016-11-29T20:03:44  *** echonaut has joined #bitcoin-core-dev
2082016-11-29T20:29:33  *** Atomicat has quit IRC
2092016-11-29T20:30:16  *** Atomicat has joined #bitcoin-core-dev
2102016-11-29T20:39:51  <jonasschnelli> morcos: good point.
2112016-11-29T20:40:01  <jonasschnelli> The label does show the requested target
2122016-11-29T20:42:18  *** Atomicat_ has joined #bitcoin-core-dev
2132016-11-29T20:45:06  *** Atomicat has quit IRC
2142016-11-29T20:45:58  *** paveljanik has joined #bitcoin-core-dev
2152016-11-29T20:45:58  *** paveljanik has joined #bitcoin-core-dev
2162016-11-29T20:46:22  *** AaronvanW has joined #bitcoin-core-dev
2172016-11-29T20:46:22  *** AaronvanW has quit IRC
2182016-11-29T20:46:22  *** AaronvanW has joined #bitcoin-core-dev
2192016-11-29T20:46:38  *** Atomicat__ has joined #bitcoin-core-dev
2202016-11-29T20:46:39  *** Atomicat__ is now known as Atomicat
2212016-11-29T20:48:31  *** Atomicat_ has quit IRC
2222016-11-29T20:48:40  *** abpa has joined #bitcoin-core-dev
2232016-11-29T20:54:30  <morcos> jonasschnelli: once we eliminate fee estimates for 1, they will only disagree either on startup or very rarely..  so i think its probably ok..
2242016-11-29T21:22:26  *** CubicEarth has joined #bitcoin-core-dev
2252016-11-29T22:07:26  *** grubles has quit IRC
2262016-11-29T22:14:16  *** Guyver2 has quit IRC
2272016-11-29T22:22:21  *** grubles has joined #bitcoin-core-dev
2282016-11-29T22:42:17  *** dermoth has quit IRC
2292016-11-29T22:49:31  *** e4xit has quit IRC
2302016-11-29T23:04:02  <bitcoin-git> [bitcoin] morcos opened pull request #9240: Remove txConflicted (master...removeTxConflicted) https://github.com/bitcoin/bitcoin/pull/9240
2312016-11-29T23:16:01  *** dermoth has joined #bitcoin-core-dev
2322016-11-29T23:16:18  *** e4xit has joined #bitcoin-core-dev