12016-12-14T00:04:57 *** chris__ has joined #bitcoin-core-dev
22016-12-14T00:13:16 *** alpalp has joined #bitcoin-core-dev
32016-12-14T00:15:23 *** jtimon has quit IRC
42016-12-14T00:18:54 *** wasi has quit IRC
52016-12-14T00:24:29 *** wasi has joined #bitcoin-core-dev
62016-12-14T01:04:11 *** AaronvanW has quit IRC
72016-12-14T01:34:39 *** PRab has joined #bitcoin-core-dev
82016-12-14T01:34:45 <gmaxwell> jonasschnelli: want to go comment on http://bitcoin.stackexchange.com/questions/50125/failing-to-build-bitcoin-core-v0-13-1-on-debian-stretch and point out its fixed in master?
92016-12-14T01:36:37 *** brg444 has quit IRC
102016-12-14T01:37:54 *** brg444 has joined #bitcoin-core-dev
112016-12-14T01:51:43 <bitcoin-git> [bitcoin] gmaxwell opened pull request #9344: Do not run functions with necessary side-effects in assert() (master...assert_no_sideeffects) https://github.com/bitcoin/bitcoin/pull/9344
122016-12-14T01:53:05 <BlueMatt> again? :(
132016-12-14T01:53:20 <gmaxwell> looks like we missed some.
142016-12-14T01:54:04 <sipa> or 2.
152016-12-14T01:54:20 <gmaxwell> or 4.
162016-12-14T01:54:37 <BlueMatt> missed, or re-added?
172016-12-14T01:54:53 <gmaxwell> the flush ones are from 2013, didn't check the others.
182016-12-14T01:54:54 <gmaxwell> looking
192016-12-14T01:56:45 <gmaxwell> BlueMatt: the other two you introduced in 9c837d54.
202016-12-14T01:57:02 <gmaxwell> You have have the brownpaper bag when 2013-sipa is done with it.
212016-12-14T01:57:15 <BlueMatt> lol, oops
222016-12-14T01:57:22 *** Ylbam has quit IRC
232016-12-14T01:58:14 *** Chris_Stewart_5 has quit IRC
242016-12-14T01:59:12 *** abpa has quit IRC
252016-12-14T02:13:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
262016-12-14T02:14:11 *** Alopex has quit IRC
272016-12-14T02:15:16 *** Alopex has joined #bitcoin-core-dev
282016-12-14T02:46:17 *** Giszmo has quit IRC
292016-12-14T02:49:02 *** warren has joined #bitcoin-core-dev
302016-12-14T02:49:59 *** adam3us has joined #bitcoin-core-dev
312016-12-14T02:52:08 *** Chris_Stewart_5 has quit IRC
322016-12-14T02:54:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
332016-12-14T03:07:29 *** PRab has quit IRC
342016-12-14T03:27:03 *** abpa has joined #bitcoin-core-dev
352016-12-14T03:27:58 *** NielsvG has quit IRC
362016-12-14T03:44:54 *** Chris_Stewart_5 has quit IRC
372016-12-14T03:47:37 *** Chris_Stewart_5 has joined #bitcoin-core-dev
382016-12-14T03:54:36 *** NielsvG has joined #bitcoin-core-dev
392016-12-14T03:54:37 *** NielsvG has joined #bitcoin-core-dev
402016-12-14T03:55:46 *** abpa has quit IRC
412016-12-14T04:06:17 *** alpalp has quit IRC
422016-12-14T04:08:33 * luke-jr wonders if it would be useful to have a prune-to-slow-storage mode.
432016-12-14T04:15:11 <adam3us> djb has a database called cdb (used in djbdns) that guarantees key->value lookup in 2 disk hits. cost is it is slow to update (batch job)
442016-12-14T04:15:49 <luke-jr> I just mean for block data. Instead of deleting, move it to a USB drive or smth
452016-12-14T04:15:59 <luke-jr> maybe even a location that can be offline when you don't need it
462016-12-14T04:16:18 <luke-jr> so when you want to restore an old backup or whatever, you just plug it in
472016-12-14T04:17:07 <adam3us> yes. i am talking about something only semi-related. that utxo access latency (with sig checking disabled) is increasing due to less spam creating lower cache hit rates, and larger utxo hitting disk more.
482016-12-14T04:18:24 <adam3us> so then maybe a three tier strategy could be old stuff in cdb, more recent (eg last 2months?) in current disk layout, plus memory cache. once per month do the batch to move another 1month chunk to the cdb compact/efficient lookup format.
492016-12-14T04:18:48 <adam3us> cdb has constant time lookup, where general lookup is log n.
502016-12-14T04:34:19 *** wasi has quit IRC
512016-12-14T04:35:46 *** GAit has quit IRC
522016-12-14T04:35:55 *** chris2000 has joined #bitcoin-core-dev
532016-12-14T04:36:37 <Lightsword> are there any known issues getting master to compile on the latest osx?
542016-12-14T04:38:48 *** chris200_ has quit IRC
552016-12-14T04:43:29 *** GAit has joined #bitcoin-core-dev
562016-12-14T04:44:44 *** wasi has joined #bitcoin-core-dev
572016-12-14T04:47:15 *** alpalp has joined #bitcoin-core-dev
582016-12-14T04:47:15 *** alpalp has joined #bitcoin-core-dev
592016-12-14T04:52:56 *** alpalp has quit IRC
602016-12-14T04:53:53 *** kadoban has quit IRC
612016-12-14T04:55:33 <Lightsword> nvm was protobuf version issue
622016-12-14T05:08:28 <luke-jr> why is secp256k1.c +x now?
632016-12-14T05:08:37 <luke-jr> main_impl.h also
642016-12-14T05:52:45 *** justanotheruser has quit IRC
652016-12-14T05:54:19 *** wasi has quit IRC
662016-12-14T05:55:19 *** wasi has joined #bitcoin-core-dev
672016-12-14T06:02:26 *** justanotheruser has joined #bitcoin-core-dev
682016-12-14T06:11:00 *** arubi has joined #bitcoin-core-dev
692016-12-14T06:27:11 *** Alopex has quit IRC
702016-12-14T06:28:16 *** Alopex has joined #bitcoin-core-dev
712016-12-14T06:38:07 <phantomcircuit> instagibbs, are wallet transactions loaded into the mempool on restart?
722016-12-14T06:38:11 <phantomcircuit> i didn't think they were
732016-12-14T06:38:25 <phantomcircuit> wouldn't that break #9262
742016-12-14T06:38:27 <gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
752016-12-14T06:38:46 <gmaxwell> phantomcircuit: yes, they are.
762016-12-14T06:38:55 <phantomcircuit> gmaxwell, hmm
772016-12-14T06:39:01 <gmaxwell> (assuming the mempool would take them).
782016-12-14T06:39:03 <gmaxwell> they do you say it would break 9262?
792016-12-14T06:39:08 <phantomcircuit> they're not rebroadcast though right?
802016-12-14T06:39:19 <gmaxwell> they're rebroadcast if they get into the mempool.
812016-12-14T06:39:28 <phantomcircuit> if they're not in the mempool then checking their ancestor depth will always fail of course
822016-12-14T06:40:18 <gmaxwell> Yea, I see what you're saying-- they're put into the mempool. (and IIRC the wallet will not try to spend them if they're unconfirmed and not in the mempool)
832016-12-14T06:40:44 <phantomcircuit> hmm
842016-12-14T06:40:48 <gmaxwell> (but I could be wrong there and instead remembering the behavior it should have instead of does have... :) )
852016-12-14T06:50:12 *** aalex has quit IRC
862016-12-14T06:50:53 *** aalex has joined #bitcoin-core-dev
872016-12-14T06:51:24 *** wasi has quit IRC
882016-12-14T06:58:12 *** wasi has joined #bitcoin-core-dev
892016-12-14T07:00:11 *** dermoth has quit IRC
902016-12-14T07:01:07 *** dermoth has joined #bitcoin-core-dev
912016-12-14T07:05:01 *** chris__ has quit IRC
922016-12-14T07:11:14 *** paveljanik has quit IRC
932016-12-14T07:20:51 *** paveljanik has joined #bitcoin-core-dev
942016-12-14T07:33:02 *** Chris_Stewart_5 has quit IRC
952016-12-14T07:53:21 *** BashCo has quit IRC
962016-12-14T07:53:56 *** BashCo has joined #bitcoin-core-dev
972016-12-14T07:58:21 *** BashCo has quit IRC
982016-12-14T08:10:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
992016-12-14T08:20:39 *** paveljanik has quit IRC
1002016-12-14T08:26:58 *** BashCo has joined #bitcoin-core-dev
1012016-12-14T08:33:15 <bitcoin-git> [bitcoin] laanwj closed pull request #9264: 0.13.2 backports (0.13...2016_12_backports_0_13) https://github.com/bitcoin/bitcoin/pull/9264
1022016-12-14T08:33:52 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26fe5c98ab6a...82ccac739e2a
1032016-12-14T08:33:52 <bitcoin-git> bitcoin/master da9cdd2 Gregory Maxwell: Do not run functions with necessary side-effects in assert()
1042016-12-14T08:33:53 <bitcoin-git> bitcoin/master 82ccac7 Wladimir J. van der Laan: Merge #9344: Do not run functions with necessary side-effects in assert()...
1052016-12-14T08:34:07 <bitcoin-git> [bitcoin] sipa opened pull request #9346: Batch construct batches (master...reusebatch) https://github.com/bitcoin/bitcoin/pull/9346
1062016-12-14T08:34:52 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ccac739e2a...47e6a19e6b57
1072016-12-14T08:34:52 <bitcoin-git> bitcoin/master ed6b377 Jonas Schnelli: [Qt] Console: add security warning
1082016-12-14T08:34:53 <bitcoin-git> bitcoin/master 47e6a19 Wladimir J. van der Laan: Merge #9330: [Qt] Console: add security warning...
1092016-12-14T08:35:07 <bitcoin-git> [bitcoin] laanwj closed pull request #9330: [Qt] Console: add security warning (master...2016/12/qt_add_sec) https://github.com/bitcoin/bitcoin/pull/9330
1102016-12-14T08:35:27 <bitcoin-git> [bitcoin] laanwj closed pull request #9323: [0.13] Add release notes for wallet/mempool rejections. (PR #9302 and #9290) (0.13...mempool_relnote) https://github.com/bitcoin/bitcoin/pull/9323
1112016-12-14T09:00:11 <phantomcircuit> gmaxwell, that is indeed the behaviour it has
1122016-12-14T09:18:43 <bitcoin-git> [bitcoin] laanwj closed pull request #9211: [0.12 branch] Backports (0.12...Mf1611-back12) https://github.com/bitcoin/bitcoin/pull/9211
1132016-12-14T09:25:54 <wumpus> what's the status on #9037? "Add test-before-evict discipline to addrman" looks like it's finished for a while but hasn't got any review yet
1142016-12-14T09:25:56 <gribble> https://github.com/bitcoin/bitcoin/issues/9037 | net: Add test-before-evict discipline to addrman by EthanHeilman · Pull Request #9037 · bitcoin/bitcoin · GitHub
1152016-12-14T09:28:31 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/47e6a19e6b57...57e337d40e94
1162016-12-14T09:28:31 <bitcoin-git> bitcoin/master f692fce Gregory Maxwell: Make RelayWalletTransaction attempt to AcceptToMemoryPool....
1172016-12-14T09:28:32 <bitcoin-git> bitcoin/master 57e337d Pieter Wuille: Merge #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool....
1182016-12-14T09:28:45 <bitcoin-git> [bitcoin] sipa closed pull request #9290: Make RelayWalletTransaction attempt to AcceptToMemoryPool. (master...resend_retries_mempool) https://github.com/bitcoin/bitcoin/pull/9290
1192016-12-14T09:30:56 <phantomcircuit> gmaxwell, iirc SelectMinCoins can be supppper expensive
1202016-12-14T09:31:06 <phantomcircuit> er SelectCoinsMinConf
1212016-12-14T09:31:41 <gmaxwell> phantomcircuit: it has linear cost in the number of spendable coins below the amount you're sending.
1222016-12-14T09:32:15 <phantomcircuit> ok
1232016-12-14T09:32:24 <phantomcircuit> was that fixed from something much worse in the past?
1242016-12-14T09:32:54 <gmaxwell> wumpus: fell off my radar before I finished review; I will review later today (your time).
1252016-12-14T09:33:21 <gmaxwell> phantomcircuit: it used to call the IsFromMe stuff that could be O(terrible).
1262016-12-14T09:33:30 <sipa> morcos: so, initial report (see https://github.com/sipa/bitcoin/commits/pertxoutcache)... gmaxwell benchmarked it, and it seems to make normal operation somewhat faster, but the cache memory usage larger resulting in more frequent flushes, and the flushes themselves are maybe 3x slower
1272016-12-14T09:33:49 <sipa> so for large dbcache it seems to be a win, while for low dbcache sizes it clearly is not
1282016-12-14T09:38:38 *** cjamthagen has joined #bitcoin-core-dev
1292016-12-14T09:38:51 <gmaxwell> basically for largeish dbcache it looked ~15% faster than master until the moment where it flushed, then it took 2.5x longer... the cache also used about 20% more memory, so 20% less cache in a given size... so flushing more often and the further it went the performance change tended to a large slowdown. :( The cache using more memory is perhaps something of an illusion of an effect, since a m
1302016-12-14T09:38:57 <gmaxwell> ajor motivator of the change was to eliminate the existance of modified entries in the cache, which would make a good replacement policy possible instead of dumbly dumping the whole thing.
1312016-12-14T09:39:14 <gmaxwell> so if the issue were only the 20% reduction in cache size, that much could easily be recovered by smarter cache handling that it makes possible.
1322016-12-14T09:39:25 <gmaxwell> The flushing slowdown though... :(
1332016-12-14T09:50:15 <wumpus> bah :(
1342016-12-14T09:57:19 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57e337d40e94...b68685a16a81
1352016-12-14T09:57:19 <bitcoin-git> bitcoin/master a13fa4c Matt Corallo: Remove unused CDiskBlockPos* argument from ProcessNewBlock
1362016-12-14T09:57:20 <bitcoin-git> bitcoin/master b68685a Wladimir J. van der Laan: Merge #9273: Remove unused CDiskBlockPos* argument from ProcessNewBlock...
1372016-12-14T09:57:36 <bitcoin-git> [bitcoin] laanwj closed pull request #9273: Remove unused CDiskBlockPos* argument from ProcessNewBlock (master...2016-12-remove-unused-pnb-param) https://github.com/bitcoin/bitcoin/pull/9273
1382016-12-14T09:59:06 *** MarcoFalke has joined #bitcoin-core-dev
1392016-12-14T10:06:25 *** AaronvanW has joined #bitcoin-core-dev
1402016-12-14T10:06:26 *** AaronvanW has quit IRC
1412016-12-14T10:06:26 *** AaronvanW has joined #bitcoin-core-dev
1422016-12-14T10:09:45 *** JackH has joined #bitcoin-core-dev
1432016-12-14T10:13:44 *** Lauda has quit IRC
1442016-12-14T10:15:39 *** timothy has quit IRC
1452016-12-14T10:19:56 *** Lauda has joined #bitcoin-core-dev
1462016-12-14T10:26:36 *** Lauda has quit IRC
1472016-12-14T10:26:41 *** rubensayshi has joined #bitcoin-core-dev
1482016-12-14T10:29:02 *** Lauda has joined #bitcoin-core-dev
1492016-12-14T10:29:36 *** timothy has joined #bitcoin-core-dev
1502016-12-14T10:34:19 *** Victorsueca has joined #bitcoin-core-dev
1512016-12-14T10:35:05 *** Victorsueca has quit IRC
1522016-12-14T10:35:29 *** Victorsueca has joined #bitcoin-core-dev
1532016-12-14T11:46:20 *** [Author] has quit IRC
1542016-12-14T11:55:41 *** [Author] has joined #bitcoin-core-dev
1552016-12-14T12:04:36 *** jtimon has joined #bitcoin-core-dev
1562016-12-14T12:04:36 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9347: [0.13.2] wallet backports (0.13...Mf1612-013back) https://github.com/bitcoin/bitcoin/pull/9347
1572016-12-14T12:12:36 <MarcoFalke> I assume #9262 is no longer for backport?
1582016-12-14T12:12:39 <gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
1592016-12-14T12:12:55 <MarcoFalke> We already return the txid and try to reaccept to the mempool
1602016-12-14T12:13:10 <MarcoFalke> Also, the default of 9262 is off, and who changes defaults anyway?
1612016-12-14T12:27:06 *** BashCo_ has joined #bitcoin-core-dev
1622016-12-14T12:30:38 *** BashCo has quit IRC
1632016-12-14T12:37:28 *** alpalp has joined #bitcoin-core-dev
1642016-12-14T12:37:28 *** alpalp has joined #bitcoin-core-dev
1652016-12-14T13:05:29 *** kadoban has joined #bitcoin-core-dev
1662016-12-14T13:18:26 <instagibbs> MarcoFalke: only the rejecting of transactions us off by default
1672016-12-14T13:18:46 <instagibbs> That said I don't think it's necessary for backport
1682016-12-14T13:28:26 *** laurentmt has joined #bitcoin-core-dev
1692016-12-14T13:28:40 *** laurentmt has quit IRC
1702016-12-14T14:00:06 *** alpalp has quit IRC
1712016-12-14T14:16:14 *** To7 has quit IRC
1722016-12-14T14:22:38 *** MarcoFalke has left #bitcoin-core-dev
1732016-12-14T14:27:39 *** BashCo_ has quit IRC
1742016-12-14T14:28:53 *** BashCo has joined #bitcoin-core-dev
1752016-12-14T14:29:20 *** Giszmo has joined #bitcoin-core-dev
1762016-12-14T14:45:34 <morcos> I don't think we should discuss 9262 for backport until after its merged... if it's too late then, it's too late.
1772016-12-14T14:46:10 <morcos> if it works right, its a less disruptive change for backport... but, we don't want to take chances on the "if"
1782016-12-14T14:49:50 *** paveljanik has joined #bitcoin-core-dev
1792016-12-14T14:51:41 *** TomMc has joined #bitcoin-core-dev
1802016-12-14T14:59:20 *** gribble has quit IRC
1812016-12-14T15:05:04 *** Giszmo has quit IRC
1822016-12-14T15:06:27 *** Giszmo has joined #bitcoin-core-dev
1832016-12-14T15:08:01 *** gribble has joined #bitcoin-core-dev
1842016-12-14T15:10:41 *** Guyver2 has joined #bitcoin-core-dev
1852016-12-14T15:25:28 *** laurentmt has joined #bitcoin-core-dev
1862016-12-14T15:26:09 *** goregrin1 has joined #bitcoin-core-dev
1872016-12-14T15:27:16 *** BashCo_ has joined #bitcoin-core-dev
1882016-12-14T15:27:42 *** goregrind has quit IRC
1892016-12-14T15:29:21 *** laurentmt has quit IRC
1902016-12-14T15:29:57 *** gluytium_ has quit IRC
1912016-12-14T15:30:22 *** BashCo has quit IRC
1922016-12-14T15:46:55 *** rafalcpp has quit IRC
1932016-12-14T16:10:41 *** rafalcpp has joined #bitcoin-core-dev
1942016-12-14T16:30:29 *** wvr has quit IRC
1952016-12-14T16:34:02 <morcos> sigh... wumpus: i think i messed up with #9240 we might want to revert it
1962016-12-14T16:34:05 <gribble> https://github.com/bitcoin/bitcoin/issues/9240 | Remove txConflicted by morcos · Pull Request #9240 · bitcoin/bitcoin · GitHub
1972016-12-14T16:34:42 <morcos> I didn't properly think through notifications that would no longer happen because SyncTransaction was no longer being called
1982016-12-14T16:35:30 <sipa> where else do we need notifications for conflicts?
1992016-12-14T16:36:04 <morcos> I think there are 3 things that won't happen 1)zmqnotifications (but we dont' do those for other things that leave the mempool, so maybe doesn't matter)
2002016-12-14T16:36:28 <morcos> 2) UI notifications or whatever NotifyTransactionChanged does (haven't dived into this yet, but I also think this doesn't matter)
2012016-12-14T16:36:35 <morcos> 3) -walletnotify notifications
2022016-12-14T16:37:00 <morcos> 3) is tricky, b/c it might make more sense to call those from MarkConflicted in the wallet except for the case of someone paying you
2032016-12-14T16:37:14 <sipa> but what we need for all of those is not conflicts
2042016-12-14T16:37:27 <sipa> maybe we need a class of "reorged" transactions
2052016-12-14T16:37:32 <morcos> someone paying you is not something you would identify in wallet conflict code as now being conflicted, but something you might want to know about in walletnotify
2062016-12-14T16:37:43 <morcos> whats the definition of that if not conflict
2072016-12-14T16:38:11 <wumpus> morcos: well that can happen, at least it's not one of the backported ones :)
2082016-12-14T16:38:28 <sipa> reorged is previously confirmed transactions that are now no longer confirmed
2092016-12-14T16:38:40 <morcos> sipa: you still are notified on those
2102016-12-14T16:38:44 <sipa> conflicted is previously unconfirmed transactions that are now inconsistent with the tip
2112016-12-14T16:39:03 <morcos> this is just mempool transactions that are now conflicted (actually nothing to do with a reorg, just a new block that conflicts with it)
2122016-12-14T16:39:10 <morcos> yeah sorry
2132016-12-14T16:39:27 <sipa> yes, i'm questioning whether we need that
2142016-12-14T16:39:37 <sipa> their confirmation count is not changing
2152016-12-14T16:40:45 <sipa> oh, maybe we need it for wiping a cached balance?
2162016-12-14T16:41:02 <morcos> i think it might be nicer to just have -walletnotify for any wallet transactions that left the mempool... then it might not be necessary to distinguish if you can mark it conflicted or not
2172016-12-14T16:41:07 <morcos> but thats difficult
2182016-12-14T16:42:37 <morcos> sipa: i don't think so... it doesn't add to your credit if its not from you, and if it spends your money, then well... i suppose it could be a mixed debit tx that you don't identify... but imo thats in the class of things we could never fully get anyway
2192016-12-14T16:42:57 <morcos> i think my thinking was just about our own wallet code, which i think is still ok... its the external notifications i hadn't considered
2202016-12-14T16:43:24 <sipa> i didn't even know we sent notifications for left-mempool
2212016-12-14T16:43:37 <morcos> we don't we send them for SyncTransaction
2222016-12-14T16:43:49 <sipa> ?
2232016-12-14T16:43:54 <morcos> which we were calling for things that left the mempool via conflict
2242016-12-14T16:44:12 <morcos> we send them from SyncTransaction for anything that is InvolvingMe
2252016-12-14T16:44:33 <morcos> SyncTransaction -> AddToWalletIfInvolvingMe -> AddToWallet
2262016-12-14T16:44:42 *** rafalcpp has quit IRC
2272016-12-14T16:44:42 <morcos> AddToWallet calls -walletnotify
2282016-12-14T16:45:24 *** rafalcpp has joined #bitcoin-core-dev
2292016-12-14T16:45:39 *** rafalcpp has joined #bitcoin-core-dev
2302016-12-14T16:47:11 *** abpa has joined #bitcoin-core-dev
2312016-12-14T16:47:18 <morcos> I was saying if you had a generic way of calling SyncTransaction for everything that left the mempool (for reasons other than being included in a block which is already covered) then that might be the most logical thing...
2322016-12-14T16:47:50 <morcos> And I don't think it would be all that important to distinguish the reason it left, at least our own wallet isn't smart about that.
2332016-12-14T16:48:06 <morcos> But that is not easy to do I don't think.
2342016-12-14T16:48:59 <sipa> hmm, we could have a callback installed in the mempool
2352016-12-14T16:49:15 <morcos> So maybe its important to still call SyncTransaction for txConflicted (the mempool conflict detection i removed) just so we get the -walletnotify for payments to us that have now been double spent / replaced / conflicted, what have you
2362016-12-14T16:50:24 <sipa> ok
2372016-12-14T16:51:36 <morcos> believe me i don't like txConflicted.. but i'm worried about accidentally making a change that somebody might be relying on for zero-conf doublespend detection
2382016-12-14T16:52:22 <sipa> so you'll revert 9240 entirely, or keep txConflicts but remove its use in wallet conflicts checking
2392016-12-14T16:53:21 <morcos> sipa: i think thats the same thing. it wasn't doing anything in wallet conflicts checking. so reverting 9240 entirely will not affect our wallet.
2402016-12-14T16:54:07 <morcos> i think we should either revert it, or decide that there is a not that complicated better solution.
2412016-12-14T16:55:39 <sipa> i see
2422016-12-14T16:56:09 <morcos> perhaps its worth spending an hour thinking about whether SyncTransaction called from mempool.remove is the right thing to do regardless.. if not.. then revert 9240, if so, then do that before 0.14.
2432016-12-14T16:56:25 *** To7 has joined #bitcoin-core-dev
2442016-12-14T16:56:30 <sdaftuar> i'd be hesitant to make changes without thinking through a clear API for how all these callbacks ought to work, and documenting that
2452016-12-14T17:07:26 *** TomMc has quit IRC
2462016-12-14T17:08:58 *** Ylbam has joined #bitcoin-core-dev
2472016-12-14T17:19:38 *** TomMc has joined #bitcoin-core-dev
2482016-12-14T17:31:19 *** TomMc has quit IRC
2492016-12-14T17:40:06 *** atroxes has quit IRC
2502016-12-14T17:40:50 *** atroxes has joined #bitcoin-core-dev
2512016-12-14T17:47:44 *** TomMc has joined #bitcoin-core-dev
2522016-12-14T17:48:10 *** BashCo_ has quit IRC
2532016-12-14T17:48:45 *** BashCo has joined #bitcoin-core-dev
2542016-12-14T17:51:56 *** laurentmt has joined #bitcoin-core-dev
2552016-12-14T17:53:23 *** laurentmt has quit IRC
2562016-12-14T17:53:33 *** BashCo has quit IRC
2572016-12-14T17:55:16 *** TomMc has quit IRC
2582016-12-14T17:57:07 *** TomMc has joined #bitcoin-core-dev
2592016-12-14T18:16:23 <bitcoin-git> [bitcoin] sipa opened pull request #9349: Make CScript (and prevector) c++11 movable. (master...movescript) https://github.com/bitcoin/bitcoin/pull/9349
2602016-12-14T18:23:51 *** BashCo has joined #bitcoin-core-dev
2612016-12-14T18:36:20 <bitcoin-git> [bitcoin] Christewart opened pull request #9350: Adding label for amount inside of tx_valid/tx_invalid.json (master...master) https://github.com/bitcoin/bitcoin/pull/9350
2622016-12-14T18:45:38 *** laurentmt has joined #bitcoin-core-dev
2632016-12-14T18:45:38 *** laurentmt has quit IRC
2642016-12-14T18:46:27 *** wvr has joined #bitcoin-core-dev
2652016-12-14T18:56:52 <morcos> sipa: wumpus: It turned out to be quite easy to track all mempool removals and call SyncTransaction on them. However there are some tricky issues around edge cases involving reorgs where you might call the Sync for its removal after the Sync for it entering a block.
2662016-12-14T18:57:08 <morcos> I don't believe this actually causes any issues.. but it'll take some time to think through it carefully
2672016-12-14T18:57:59 <morcos> It would be my preference to do that, and try to document this code better.. As I think calling SyncTransaction (and thus walletnotify) on things that leave the mempool makes sense
2682016-12-14T18:58:16 <morcos> And I think reverting 9240 is a step backwards towards cleaning this stuff up
2692016-12-14T18:58:42 <morcos> But it depends on how risk averse you are for leaving it in its current state for a little while.
2702016-12-14T18:59:23 <morcos> To summarize, I think the only regression is that -walletnotify isn't fired on transactions that were in the mempool and then evicted due to a tx in a new block conflicting them
2712016-12-14T18:59:34 <morcos> i've got to run for the day shortly..
2722016-12-14T19:02:24 *** TomMc has quit IRC
2732016-12-14T19:03:11 *** chris2000 has quit IRC
2742016-12-14T19:05:48 *** chris2000 has joined #bitcoin-core-dev
2752016-12-14T19:16:44 *** TomMc has joined #bitcoin-core-dev
2762016-12-14T20:12:49 *** snowden69 has joined #bitcoin-core-dev
2772016-12-14T20:35:02 *** snowden69 has quit IRC
2782016-12-14T20:35:23 *** snowden69 has joined #bitcoin-core-dev
2792016-12-14T21:08:47 *** Guyver2 has quit IRC
2802016-12-14T21:14:55 *** wasi has quit IRC
2812016-12-14T21:27:37 *** Chris_Stewart_5 has quit IRC
2822016-12-14T21:30:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2832016-12-14T21:32:03 *** MarcoFalke has joined #bitcoin-core-dev
2842016-12-14T21:33:40 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9351: Remove CWalletTx::fFromMe member. (master...pr/atw-fromme) https://github.com/bitcoin/bitcoin/pull/9351
2852016-12-14T21:39:02 *** Chris_Stewart_5 has quit IRC
2862016-12-14T21:41:35 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2872016-12-14T22:07:41 *** MarcoFalke has left #bitcoin-core-dev
2882016-12-14T22:09:15 *** abpa has quit IRC
2892016-12-14T22:12:05 <bitcoin-git> [bitcoin] sdaftuar opened pull request #9352: Attempt reconstruction from all compact block announcements (master...optimistic-cb-2) https://github.com/bitcoin/bitcoin/pull/9352
2902016-12-14T22:16:22 *** abpa has joined #bitcoin-core-dev
2912016-12-14T22:34:10 *** belcher has quit IRC
2922016-12-14T22:46:31 *** belcher has joined #bitcoin-core-dev
2932016-12-14T22:47:42 *** jasonv77 has quit IRC
2942016-12-14T22:58:44 *** MarcoFalke has joined #bitcoin-core-dev
2952016-12-14T23:05:47 *** TomMc has quit IRC
2962016-12-14T23:28:02 *** d9b4bef9 has quit IRC
2972016-12-14T23:35:12 *** TomMc has joined #bitcoin-core-dev
2982016-12-14T23:42:06 *** MykelSIlver has quit IRC
2992016-12-14T23:42:23 *** MykelSIlver has joined #bitcoin-core-dev