12017-01-07T00:01:44 *** abpa has quit IRC
22017-01-07T00:03:06 *** Giszmo has joined #bitcoin-core-dev
32017-01-07T00:03:20 *** wrkrcoop has quit IRC
42017-01-07T00:15:19 *** Squidicuz has joined #bitcoin-core-dev
52017-01-07T00:18:18 *** wrkrcoop has joined #bitcoin-core-dev
62017-01-07T00:22:13 *** laurentmt has quit IRC
72017-01-07T00:33:35 *** wrkrcoop has quit IRC
82017-01-07T00:51:03 *** brg444 has quit IRC
92017-01-07T01:32:34 *** Chris_Stewart_5 has quit IRC
102017-01-07T01:36:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
112017-01-07T01:49:34 *** LeMiner2 has joined #bitcoin-core-dev
122017-01-07T01:51:46 *** LeMiner has quit IRC
132017-01-07T01:51:46 *** LeMiner2 is now known as LeMiner
142017-01-07T01:53:36 *** btcdrak has joined #bitcoin-core-dev
152017-01-07T02:09:33 <gmaxwell> morcos: actually the parallel signature checking gains are better than expected. So consider (all reindex chainstate, dbcache2000) no-scriptchecks par=4 10680.346728 seconds, all scriptchecks par=4 24453.715550 , all scriptchecks part=default (24 core, 48 thread host): 12182.296543 ... so if you compute (par4-none)/(parN-none) = 9.17 ... impressive trick considering MAX_SCRIPTCHECK_THREADS i
162017-01-07T02:09:39 <gmaxwell> s 16. ... my numbers may not be totally compariable because I had a rebase between the par4 and parN cases, that I didn't _think_ would impact performance.
172017-01-07T02:09:51 <gmaxwell> Good test hygine is hard when doing tests that take 7 hours.
182017-01-07T02:12:31 <Chris_Stewart_5> jonasschnelli: Do you have any numbers on how long it takes to sync headers with your pull req?
192017-01-07T02:19:55 *** Giszmo1 has joined #bitcoin-core-dev
202017-01-07T02:21:38 *** Giszmo has quit IRC
212017-01-07T02:21:49 <warren> jonasschnelli: hmm, I'm excited to use your SPV mode in conjunction with BIP150 (authenticated connection to my own full nodes)
222017-01-07T02:23:41 <gmaxwell> warren: just need 5 more regular contributors to get all the outstanding things done.
232017-01-07T02:34:09 *** AaronvanW has quit IRC
242017-01-07T02:57:37 *** Squidicuz has quit IRC
252017-01-07T03:04:30 *** Squidicuz has joined #bitcoin-core-dev
262017-01-07T03:04:47 <morcos> gmaxwell: i don't think thats a fair calculation though since during the none part the script checking threads are running
272017-01-07T03:04:53 <morcos> or at least N-1 of them
282017-01-07T03:06:52 <gmaxwell> morcos: I agree someone is wrong, but I don't follow your explination. None is effectively fScriptChecks = false. The threads may be running but they're not doing anything.
292017-01-07T03:07:20 <gmaxwell> all is fScriptChecks wedged true. (no checkpoints).
302017-01-07T03:08:10 <morcos> yes but during the all time so take the par=default case.. you have 15 script check threads running for 10k seconds and then 16 running for another 2k seconds, so its not fair to say it only took them 2k seconds
312017-01-07T03:09:27 <gmaxwell> duh right.
322017-01-07T03:09:33 <gmaxwell> okay, it's been a long day.
332017-01-07T03:10:09 <morcos> all this flurry of trying to fix concurrency problems showed up when it turned out that it could actually be faster to NOT have signatures cached because of the contention on the sigcache
342017-01-07T03:10:22 <morcos> thats certainly been fixed with the cuckoocache
352017-01-07T03:10:29 <gmaxwell> well for IBD it still might be. :P
362017-01-07T03:11:07 <morcos> but it is still the case that when sigs are cached, its harder to see the benefits of more parallelism, b/c then the contention on the checkqueue is greater
372017-01-07T03:12:29 <gmaxwell> I wish our design made it easier to get multiple blocks in the scriptchecking pipeline at once.
382017-01-07T03:13:19 <morcos> I suspect that improvement wouldn't be that much any more
392017-01-07T03:13:42 <morcos> with full blocks, there isn't much time where you have idle cores with nothing to do
402017-01-07T03:13:57 <morcos> it makes a much bigger difference with the old small blocks though
412017-01-07T03:14:19 <morcos> i do think if i had your computer i'd change MAX_SCRIPTCHECK_THREADS though!
422017-01-07T03:14:30 <gmaxwell> yes. well, also, I'm usually using 48 or 56 thread hosts.
432017-01-07T03:14:41 <gmaxwell> well it used to make it _slower_ I'm trying now with it at 48.
442017-01-07T03:15:56 <gmaxwell> it's at height 250k at hte moment and not making it much past 700% cpu according to top... but thats still early.
452017-01-07T03:16:46 <morcos> it's worse than video games. you're still going to be doing that at 3am
462017-01-07T03:16:50 <morcos> have a good night!
472017-01-07T03:17:25 <gmaxwell> hah
482017-01-07T03:17:27 *** Ylbam has quit IRC
492017-01-07T03:18:10 <gmaxwell> "I thought mine-craft was a graphical program?"
502017-01-07T03:50:31 <Chris_Stewart_5> How is CScript serialized? It doesn't seem to use ADD_SERIALIZE_METHODS
512017-01-07T03:54:03 <luke-jr> Chris_Stewart_5: it's just a vector of uint8s
522017-01-07T04:04:26 <Chris_Stewart_5> luke-jr: Which is why we things like this? static_cast<const CScriptBase&>
532017-01-07T04:09:05 <sipa> yes CScript is just a subclass of std::vector<char>
542017-01-07T04:23:42 *** dcousens has quit IRC
552017-01-07T04:25:49 *** dcousens has joined #bitcoin-core-dev
562017-01-07T04:35:38 *** Victor_sueca has joined #bitcoin-core-dev
572017-01-07T04:36:08 <warren> https://0bin.net/paste/iJSqUPkqv-zAG-ZN#vKw4haQ8j5fbQZK7NAkYO+nXugLmLPZP73uJghKj6nl This is an example of a double-spent transaction, previously confirmed in the local wallet but now invalid. I think years ago this output would continue to show the blockhash of the block that it was previously confirmed (but no longer the longest chain)? Any idea when this changed?
582017-01-07T04:38:06 *** Victorsueca has quit IRC
592017-01-07T04:53:58 *** droark has joined #bitcoin-core-dev
602017-01-07T05:07:49 *** Squidicuz has quit IRC
612017-01-07T05:08:18 *** Squidicuz has joined #bitcoin-core-dev
622017-01-07T05:22:49 *** Squidicuz has quit IRC
632017-01-07T05:23:15 *** Squidicuz has joined #bitcoin-core-dev
642017-01-07T05:50:12 *** afk11 has quit IRC
652017-01-07T05:56:53 *** afk11 has joined #bitcoin-core-dev
662017-01-07T05:56:53 *** afk11 has quit IRC
672017-01-07T05:56:53 *** afk11 has joined #bitcoin-core-dev
682017-01-07T05:57:41 *** Giszmo has joined #bitcoin-core-dev
692017-01-07T05:59:32 *** Giszmo1 has quit IRC
702017-01-07T06:09:46 *** dcousens has quit IRC
712017-01-07T06:36:21 *** Giszmo has quit IRC
722017-01-07T07:00:21 *** dermoth has quit IRC
732017-01-07T07:01:04 *** dermoth has joined #bitcoin-core-dev
742017-01-07T07:20:40 *** LeMiner2 has joined #bitcoin-core-dev
752017-01-07T07:23:06 *** LeMiner has quit IRC
762017-01-07T07:23:06 *** LeMiner2 is now known as LeMiner
772017-01-07T07:29:13 *** Sosumi has joined #bitcoin-core-dev
782017-01-07T07:37:37 *** LeMiner2 has joined #bitcoin-core-dev
792017-01-07T07:39:54 *** LeMiner has quit IRC
802017-01-07T07:39:54 *** LeMiner2 is now known as LeMiner
812017-01-07T07:40:15 *** sqltest has joined #bitcoin-core-dev
822017-01-07T07:42:56 <sqltest> hello. I'm having a problem getting bitcoind to run as a different user (other than logged in user) using init conf. It always fails because it tries to create a .bitcoin dir. If I create a /.bitcoin dir with ownership of user it works. But I don't want a root .bitcoin dir. The running user has no home dir. The bitcoin.conf is provided on cmd and datadir is in conf so works fine. No need to create an empty .bitcoin dir at a
832017-01-07T07:44:58 <sqltest> eg. "sudo -u btc bitcoind -conf=/etc/bitcoin/bitcoin.conf" works only if an extraneous .bitcoin dir exists even when not used
842017-01-07T07:48:09 <gmaxwell> you need to set the datadir path, not conf.
852017-01-07T07:48:44 <gmaxwell> you can just <sudo...> bitcoind -datadir=/etc/bitcoin/
862017-01-07T07:49:45 <sqltest> I do set that in the conf file and it works. But only when an empty .bitcoin is "hanging around". The .bitcoin remains empty even when daemon is full functionaing.
872017-01-07T07:50:16 <sqltest> I have other settings I need in the bitcoin.conf as well so provide that instead of datadir alone.
882017-01-07T07:50:44 <sqltest> It seems to test the exitence of .bitcoin even when using another datadir path.
892017-01-07T07:51:48 <sqltest> The issue is it is run as btc user by start-stop-daemon but that process chdirs to root first.
902017-01-07T07:52:33 <sqltest> So if I create an empty /.bitcoin dir it starts fine. But when that is not present it cannot start.
912017-01-07T07:52:54 <jonasschnelli> <*highlight> <Chris_Stewart_5:#bitcoin-core-dev> jonasschnelli: Do you have any numbers on how long it takes to sync headers with your pull req?
922017-01-07T07:53:00 <jonasschnelli> 2-3min
932017-01-07T07:53:15 <sqltest> If I tell start-stop-daemon to chdir to a writeable dir I thought it would create a .bitcoin dir there but for some reason it doesn't.
942017-01-07T07:53:17 <jonasschnelli> Headers-Sync does not run in parallel (from different peers)
952017-01-07T07:53:33 <jonasschnelli> So.. if you have download them from a slow peer, it may take longer.
962017-01-07T07:56:18 *** dcousens has joined #bitcoin-core-dev
972017-01-07T07:57:31 <gmaxwell> sqltest: don't use the config file to set it, thats too late.
982017-01-07T07:57:50 <gmaxwell> hm. well, that might be a bug then.
992017-01-07T07:57:52 <jcorgan> sqltest: i can confirm i've seen exactly the same behavior as you describe. i don't know if it is a feature or a bug, but nowadays i run bincoind inside a container so i map $HOME/.bitcoin inside the container to wherever i want outside the container
1002017-01-07T07:57:58 <gmaxwell> though I don't think so.
1012017-01-07T07:58:06 * gmaxwell straces.
1022017-01-07T07:59:03 <gmaxwell> with datadir set on the commandline I don't see any access to $HOME/.bitcoin
1032017-01-07T07:59:19 <gmaxwell> with master, I don't have a 0.13.2 binary handy to test at the moment.
1042017-01-07T07:59:24 <jcorgan> i did trace through the code (though this was back in the 0.8 or 0.9 days, so it's probably all changed)
1052017-01-07T08:00:26 <jcorgan> and it did seem that bitcoind was checking for $HOME/.bitcoin/bitcoin.conf before parsing the cmdline for -conf
1062017-01-07T08:01:02 <sqltest> so I guess i need to set datadir and conf on command line unless I decide to move bitcoin.conf to datadir. I have a bunch of confs for daemons and wanted to keep them all in /etc/bitcoin
1072017-01-07T08:01:13 *** dcousens has quit IRC
1082017-01-07T08:01:58 <jcorgan> that's not an unreasonable way of doing things
1092017-01-07T08:02:33 <sqltest> well, thanks. I guess I'll have to work around that. The docs seems to say you can set conf on cmdline but that's incorrect unless datadir also provided.
1102017-01-07T08:02:51 <gmaxwell> sqltest: yes. you can't even put a datadir in the config of many of the altcoins.
1112017-01-07T08:04:09 <gmaxwell> you can set a conf on the commandline. but what you're trying to do is override the conf and datadir at the same time and there is some interaction there it seems.
1122017-01-07T08:05:25 <sqltest> Ok. I added datadir so both are provided to start-start-daemon exec args and it works ok like that. I'm creating an install script for my sqlchain daemon and this will work ok. Just need extra arg.
1132017-01-07T08:06:42 <sqltest> Thanks for help.
1142017-01-07T08:08:42 *** sqltest has left #bitcoin-core-dev
1152017-01-07T08:27:06 *** Ylbam has joined #bitcoin-core-dev
1162017-01-07T09:12:37 *** Squidicuz has quit IRC
1172017-01-07T09:13:04 *** Squidicuz has joined #bitcoin-core-dev
1182017-01-07T09:29:52 *** windsok has quit IRC
1192017-01-07T09:41:25 *** Squidicuz has quit IRC
1202017-01-07T09:44:32 *** Squidicuz has joined #bitcoin-core-dev
1212017-01-07T09:57:51 *** windsok has joined #bitcoin-core-dev
1222017-01-07T10:38:34 *** fanquake has joined #bitcoin-core-dev
1232017-01-07T10:46:27 *** MarcoFalke has joined #bitcoin-core-dev
1242017-01-07T10:57:01 *** Squidicuz has quit IRC
1252017-01-07T10:57:29 *** Squidicuz has joined #bitcoin-core-dev
1262017-01-07T11:10:53 *** jtimon has joined #bitcoin-core-dev
1272017-01-07T11:11:11 *** fanquake has quit IRC
1282017-01-07T12:11:03 *** AaronvanW has joined #bitcoin-core-dev
1292017-01-07T12:11:30 *** AaronvanW has quit IRC
1302017-01-07T12:11:30 *** AaronvanW has joined #bitcoin-core-dev
1312017-01-07T12:25:34 *** MarcoFalke has left #bitcoin-core-dev
1322017-01-07T12:36:43 *** jtimon has quit IRC
1332017-01-07T13:40:20 *** dcousens has joined #bitcoin-core-dev
1342017-01-07T14:06:05 *** dcousens has quit IRC
1352017-01-07T14:07:45 *** laurentmt has joined #bitcoin-core-dev
1362017-01-07T14:13:10 *** laurentmt has quit IRC
1372017-01-07T14:13:29 *** laurentmt has joined #bitcoin-core-dev
1382017-01-07T14:19:09 *** laurentmt has quit IRC
1392017-01-07T14:21:52 *** Guyver2 has joined #bitcoin-core-dev
1402017-01-07T14:57:26 <Chris_Stewart_5> jonasschnelli: Wow, faster than I expected. Very nice.
1412017-01-07T15:02:24 <Chris_Stewart_5> also, it isn't possible to run in parallel is it?
1422017-01-07T15:07:02 *** pavel_ has joined #bitcoin-core-dev
1432017-01-07T15:07:02 *** paveljanik has quit IRC
1442017-01-07T15:09:12 *** cdecker has joined #bitcoin-core-dev
1452017-01-07T15:09:13 <gmaxwell> not really without hacks.
1462017-01-07T15:10:35 *** cdecker has quit IRC
1472017-01-07T15:11:06 *** cdecker has joined #bitcoin-core-dev
1482017-01-07T15:14:46 *** Chris_Stewart_5 has quit IRC
1492017-01-07T15:24:37 *** LeMiner2 has joined #bitcoin-core-dev
1502017-01-07T15:27:02 *** LeMiner has quit IRC
1512017-01-07T15:27:02 *** LeMiner2 is now known as LeMiner
1522017-01-07T15:30:49 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1532017-01-07T15:51:29 *** laurentmt has joined #bitcoin-core-dev
1542017-01-07T15:51:29 *** laurentmt has quit IRC
1552017-01-07T16:20:43 *** TomMc has joined #bitcoin-core-dev
1562017-01-07T16:26:54 *** laurentmt has joined #bitcoin-core-dev
1572017-01-07T16:33:05 *** TomMc has quit IRC
1582017-01-07T16:42:05 *** jtimon has joined #bitcoin-core-dev
1592017-01-07T16:43:56 *** laurentmt has quit IRC
1602017-01-07T16:47:37 *** LeMiner2 has joined #bitcoin-core-dev
1612017-01-07T16:49:52 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9486: Make peer=%d log prints consistent (master...2017-01-peer-log-consistency) https://github.com/bitcoin/bitcoin/pull/9486
1622017-01-07T16:50:06 *** LeMiner has quit IRC
1632017-01-07T16:50:06 *** LeMiner2 is now known as LeMiner
1642017-01-07T17:24:33 *** norotartagen has quit IRC
1652017-01-07T17:50:49 <bitcoin-git> [bitcoin] droark opened pull request #9487: Remove stray semicolon (Fix empty body warning) (master...9319Fix) https://github.com/bitcoin/bitcoin/pull/9487
1662017-01-07T17:59:53 *** visitor has joined #bitcoin-core-dev
1672017-01-07T18:03:27 *** visitor is now known as visitor50
1682017-01-07T18:06:20 *** haakonn has joined #bitcoin-core-dev
1692017-01-07T18:07:00 *** haakonn is now known as Guest43877
1702017-01-07T18:08:45 *** DrHendrik has joined #bitcoin-core-dev
1712017-01-07T18:09:04 <DrHendrik> Are the last 2 thursday meet-ups skipped because of holidays? or just not updated @ https://bitcoincore.org/en/meetings/
1722017-01-07T18:09:09 *** Guest43877 has quit IRC
1732017-01-07T18:09:25 <sipa> DrHendrik: last thursday there was a meeting
1742017-01-07T18:09:35 <DrHendrik> ok
1752017-01-07T18:09:37 <sipa> but i think it just has not yet been websiteiified
1762017-01-07T18:10:37 <gmaxwell> sipa: it would be nice if this was merged soon, addnode is currently broken in master: https://github.com/bitcoin/bitcoin/pull/9487
1772017-01-07T18:12:48 <gmaxwell> I'd really like us to stop using unbraced ifs. This is the kind of error that results from them, it was my screwup for sure, but getting things right is hard enough without a coding style that includes a predictable source of bugs.
1782017-01-07T18:25:34 *** so has joined #bitcoin-core-dev
1792017-01-07T18:27:48 *** haakonn has joined #bitcoin-core-dev
1802017-01-07T18:27:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/46b249e578e8...25720fc394e2
1812017-01-07T18:27:56 <bitcoin-git> bitcoin/master cc05896 Douglas Roark: Remove stray semicolon (Fix empty body warning)...
1822017-01-07T18:27:57 <bitcoin-git> bitcoin/master 25720fc MarcoFalke: Merge #9487: Remove stray semicolon (Fix empty body warning)...
1832017-01-07T18:28:11 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9487: Remove stray semicolon (Fix empty body warning) (master...9319Fix) https://github.com/bitcoin/bitcoin/pull/9487
1842017-01-07T18:28:12 *** haakonn is now known as Guest53948
1852017-01-07T18:29:15 *** typingmonkey_ has joined #bitcoin-core-dev
1862017-01-07T18:31:02 *** DrHendrik has quit IRC
1872017-01-07T19:00:14 <luke-jr> gmaxwell: not sure if I mentioned, but I also came to that opinion following consideration of your arguments for it some months ago (always using braced blocks)
1882017-01-07T19:00:40 <luke-jr> and as such have been using/adding them where appropriate
1892017-01-07T19:09:12 *** windsok has quit IRC
1902017-01-07T19:12:10 *** protomar has joined #bitcoin-core-dev
1912017-01-07T19:38:04 *** Squidicc has joined #bitcoin-core-dev
1922017-01-07T19:42:01 *** Squidicuz has quit IRC
1932017-01-07T19:42:23 *** laurentmt has joined #bitcoin-core-dev
1942017-01-07T19:42:28 *** laurentmt has quit IRC
1952017-01-07T19:42:53 *** laurentmt has joined #bitcoin-core-dev
1962017-01-07T19:42:54 *** laurentmt has quit IRC
1972017-01-07T19:42:58 *** afk11 has quit IRC
1982017-01-07T19:47:27 *** Ylbam has quit IRC
1992017-01-07T19:47:30 *** afk11 has joined #bitcoin-core-dev
2002017-01-07T19:47:30 *** afk11 has quit IRC
2012017-01-07T19:47:30 *** afk11 has joined #bitcoin-core-dev
2022017-01-07T20:18:24 *** Chris_Stewart_5 has quit IRC
2032017-01-07T20:18:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2042017-01-07T20:22:39 *** typingmonkey_ has quit IRC
2052017-01-07T20:23:17 *** windsok has joined #bitcoin-core-dev
2062017-01-07T20:26:21 <gmaxwell> luke-jr: yea, I see you've been using it.
2072017-01-07T20:26:53 <gmaxwell> I've been inconsistent in my use in Bitcoin Core, I've slipped some in but worry about getting nagged about the coding style.
2082017-01-07T20:39:05 *** btcdrak has quit IRC
2092017-01-07T20:40:34 *** Ylbam has joined #bitcoin-core-dev
2102017-01-07T20:48:57 *** jtimon has quit IRC
2112017-01-07T20:50:11 *** afk11 has quit IRC
2122017-01-07T20:54:43 <phantomcircuit> gmaxwell, unbraced if's are just wrong
2132017-01-07T20:55:29 <gmaxwell> Unfortunately, I don't think any of the autoformaters or linter tools can enforce them. (they certantly can't enforce my preferred style: unbraced only if the whole statement is one line and there is no else.
2142017-01-07T21:16:51 *** btcdrak has joined #bitcoin-core-dev
2152017-01-07T21:30:12 <Chris_Stewart_5> If I am trying to use the 'deserializing constructor' for CTransaction, what am I suppose to be passing in as 'deserialize_type'?
2162017-01-07T21:30:15 <Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L346
2172017-01-07T21:39:48 *** Sosumi has quit IRC
2182017-01-07T21:42:08 *** Guyver2 has quit IRC
2192017-01-07T21:55:52 *** Chris_Stewart_5 has quit IRC
2202017-01-07T21:57:27 *** max4307 has joined #bitcoin-core-dev
2212017-01-07T21:58:46 *** max4307 has quit IRC
2222017-01-07T22:00:34 *** Cheeseo has joined #bitcoin-core-dev
2232017-01-07T22:12:12 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2242017-01-07T22:29:38 *** max4307 has joined #bitcoin-core-dev
2252017-01-07T22:30:34 <max4307> how to reset the password forgot it
2262017-01-07T22:36:01 <kadoban> max4307: Password to what? Alse this probably belongs in #bitcoin, at a guess.
2272017-01-07T22:37:35 <max4307> the purse has created a password and forgot, you can't work Sneem
2282017-01-07T22:40:46 <max4307> encrypted wallet and forgot my password now how to work the ck
2292017-01-07T22:44:38 *** Chris_Stewart_5 has quit IRC
2302017-01-07T22:45:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2312017-01-07T22:48:34 *** protomar has quit IRC
2322017-01-07T22:52:19 *** max4307 has quit IRC
2332017-01-07T22:54:14 <adam3us> phantomcircuit unbraced if's are very wrong.
2342017-01-07T22:54:47 <adam3us> very awesome security defects in other crypto applications have been created by them and poor formatting.
2352017-01-07T22:55:20 <sipa> yeah, unfortunately, in some parts of the codebase they're still common
2362017-01-07T22:55:39 <sipa> and people tend to (and have been advised to) mimick the style of the code surrounging what is being touched
2372017-01-07T22:58:11 *** max4307 has joined #bitcoin-core-dev
2382017-01-07T22:58:15 <max4307> encrypted wallet and forgot password bitcoincore?
2392017-01-07T22:59:11 <sipa> max4307: this channel is not for support
2402017-01-07T22:59:27 <sipa> max4307: perhaps try the forums or stackexchange, or #bitcoin (but beware of scammers)
2412017-01-07T23:01:01 <max4307> And channel support don't know
2422017-01-07T23:01:27 *** max4307 has quit IRC
2432017-01-07T23:06:30 *** juscamarena__ has joined #bitcoin-core-dev
2442017-01-07T23:16:36 *** RoyceX has joined #bitcoin-core-dev
2452017-01-07T23:20:01 *** Cheeseo has quit IRC
2462017-01-07T23:26:11 *** RoyceX has quit IRC
2472017-01-07T23:38:30 <luke-jr> BlueMatt: we are de facto including wallet/rpcwallet.h in the build already (and forever afaik) with --disable-wallet; how else would you suggest I do that?
2482017-01-07T23:40:54 <BlueMatt> oh? where from?
2492017-01-07T23:41:19 <BlueMatt> note: I'm ok with a little duplication of the headers with comments noting "this should go away - do not use in new code, yada yada"
2502017-01-07T23:41:46 <luke-jr> Makefile.am
2512017-01-07T23:43:13 <BlueMatt> you mean via BITCOIN_CORE_H?
2522017-01-07T23:43:22 <luke-jr> yeah
2532017-01-07T23:43:45 <BlueMatt> afaiu that just informs autotools that if this header changes it may need to recompile some files
2542017-01-07T23:43:52 <BlueMatt> it doesnt actually compile/include/etc it in any way
2552017-01-07T23:45:02 <luke-jr> it figures out dependencies automatically. although admittedly, I do not know what that reference actually does do
2562017-01-07T23:46:43 <luke-jr> in any case, so basically you want me to duplicate the header in src/rpc/?
2572017-01-07T23:49:52 *** windsok has quit IRC
2582017-01-07T23:55:40 <BlueMatt> that would be my preference
2592017-01-07T23:59:45 <gmaxwell> phantomcircuit: hm. I thought we had written style mandates that prohibited braces on single line statements. But looking, I can't find that.
2602017-01-07T23:59:59 <gmaxwell> phantomcircuit: so I've been thinking that I was being naughty every time I added one.