12017-01-18T00:09:48 *** chjj has quit IRC
22017-01-18T00:23:05 *** chjj has joined #bitcoin-core-dev
32017-01-18T00:32:39 *** MarcoFalke has quit IRC
42017-01-18T00:46:34 *** chjj has quit IRC
52017-01-18T00:46:54 *** chjj has joined #bitcoin-core-dev
62017-01-18T00:59:46 *** abpa has quit IRC
72017-01-18T01:06:44 *** Chris_Stewart_5 has quit IRC
82017-01-18T01:13:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
92017-01-18T01:16:06 *** Netmage has quit IRC
102017-01-18T01:16:51 *** Netmage has joined #bitcoin-core-dev
112017-01-18T01:21:37 *** shesek has quit IRC
122017-01-18T01:22:22 *** stench has quit IRC
132017-01-18T01:23:34 *** stench has joined #bitcoin-core-dev
142017-01-18T01:27:29 *** Ylbam has quit IRC
152017-01-18T01:27:34 <bitcoin-git> [bitcoin] pinheadmz opened pull request #9571: RPC: getblockchaininfo returns BIP signaling statistics (master...master) https://github.com/bitcoin/bitcoin/pull/9571
162017-01-18T01:27:38 *** BashCo has quit IRC
172017-01-18T01:27:39 *** atroxes has quit IRC
182017-01-18T01:29:13 *** BashCo has joined #bitcoin-core-dev
192017-01-18T01:29:13 *** atroxes has joined #bitcoin-core-dev
202017-01-18T01:35:41 *** laurentmt has joined #bitcoin-core-dev
212017-01-18T01:35:45 *** laurentmt has quit IRC
222017-01-18T01:36:13 *** [Author] has quit IRC
232017-01-18T01:36:13 *** Magma has quit IRC
242017-01-18T01:36:13 *** fengling has quit IRC
252017-01-18T01:38:05 *** handlex has quit IRC
262017-01-18T02:03:01 *** AaronvanW has quit IRC
272017-01-18T02:12:05 *** CubicEarth has joined #bitcoin-core-dev
282017-01-18T02:25:07 *** randy-waterhouse has joined #bitcoin-core-dev
292017-01-18T02:25:15 *** Chris_Stewart_5 has quit IRC
302017-01-18T02:25:27 *** randy-waterhouse has quit IRC
312017-01-18T02:25:27 *** randy-waterhouse has joined #bitcoin-core-dev
322017-01-18T02:27:50 *** Magma has joined #bitcoin-core-dev
332017-01-18T02:29:19 *** [Author] has joined #bitcoin-core-dev
342017-01-18T02:36:50 *** randy-waterhouse has quit IRC
352017-01-18T02:41:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
362017-01-18T02:55:47 *** randy-waterhouse has joined #bitcoin-core-dev
372017-01-18T02:56:35 *** randy-waterhouse has joined #bitcoin-core-dev
382017-01-18T02:57:31 *** fengling has joined #bitcoin-core-dev
392017-01-18T03:00:22 *** cheese_ has quit IRC
402017-01-18T03:00:44 *** cheese_ has joined #bitcoin-core-dev
412017-01-18T03:00:45 *** cheese_ has joined #bitcoin-core-dev
422017-01-18T03:20:51 *** Squidicc has quit IRC
432017-01-18T03:25:40 *** Chris_Stewart_5 has quit IRC
442017-01-18T03:31:11 *** Alopex has quit IRC
452017-01-18T03:32:17 *** Alopex has joined #bitcoin-core-dev
462017-01-18T03:33:25 *** Squidicuz has joined #bitcoin-core-dev
472017-01-18T03:39:08 *** Chris_Stewart_5 has joined #bitcoin-core-dev
482017-01-18T04:02:32 *** randy-waterhouse has quit IRC
492017-01-18T04:04:05 *** droark has joined #bitcoin-core-dev
502017-01-18T04:15:21 *** Alopex has quit IRC
512017-01-18T04:16:27 *** Alopex has joined #bitcoin-core-dev
522017-01-18T04:47:16 *** justan0theruser has joined #bitcoin-core-dev
532017-01-18T04:49:16 *** justanotheruser has quit IRC
542017-01-18T04:54:18 *** waxwing has joined #bitcoin-core-dev
552017-01-18T04:57:26 *** CubicEarth has quit IRC
562017-01-18T05:00:04 *** dermoth has quit IRC
572017-01-18T05:00:45 *** dermoth has joined #bitcoin-core-dev
582017-01-18T05:23:06 *** Alopex has quit IRC
592017-01-18T05:24:12 *** Alopex has joined #bitcoin-core-dev
602017-01-18T05:24:59 *** CubicEarth has joined #bitcoin-core-dev
612017-01-18T05:34:07 *** Alopex has quit IRC
622017-01-18T05:35:12 *** Alopex has joined #bitcoin-core-dev
632017-01-18T06:12:26 *** aalex has joined #bitcoin-core-dev
642017-01-18T06:19:48 *** aalex has quit IRC
652017-01-18T06:21:24 *** bsm117532 has quit IRC
662017-01-18T06:35:04 *** bsm117532 has joined #bitcoin-core-dev
672017-01-18T06:45:31 *** jtimon has quit IRC
682017-01-18T06:45:37 *** cheese_ has quit IRC
692017-01-18T06:47:38 *** bsm117532 has quit IRC
702017-01-18T06:48:59 *** Cheeseo has joined #bitcoin-core-dev
712017-01-18T07:02:52 <jonasschnelli> BlueMatt: I'm working on the fixes for #9461
722017-01-18T07:03:57 <gribble> https://github.com/bitcoin/bitcoin/issues/9461 | [Qt] Improve progress display during headers-sync and peer-finding by jonasschnelli · Pull Request #9461 · bitcoin/bitcoin · GitHub
732017-01-18T07:36:02 *** shesek has joined #bitcoin-core-dev
742017-01-18T07:39:49 *** Ylbam has joined #bitcoin-core-dev
752017-01-18T07:45:33 *** kadoban has quit IRC
762017-01-18T07:55:42 <bitcoin-git> [bitcoin] jl2012 opened pull request #9572: Skip witness sighash cache for non-segwit transactions (master...nocache) https://github.com/bitcoin/bitcoin/pull/9572
772017-01-18T08:13:52 *** BashCo has quit IRC
782017-01-18T08:14:56 *** MarcoFalke has joined #bitcoin-core-dev
792017-01-18T08:20:36 *** paveljanik has quit IRC
802017-01-18T08:35:50 *** BashCo has joined #bitcoin-core-dev
812017-01-18T08:52:53 *** BashCo_ has joined #bitcoin-core-dev
822017-01-18T08:56:11 *** BashCo has quit IRC
832017-01-18T08:57:12 *** Samdney has joined #bitcoin-core-dev
842017-01-18T09:02:08 *** Samdney has quit IRC
852017-01-18T09:07:02 *** Samdney has joined #bitcoin-core-dev
862017-01-18T09:26:05 *** CubicEarth has quit IRC
872017-01-18T09:26:40 *** CubicEarth has joined #bitcoin-core-dev
882017-01-18T09:43:25 *** jannes has joined #bitcoin-core-dev
892017-01-18T09:45:12 *** timothy has quit IRC
902017-01-18T09:56:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6696b4635ceb...b0b57a17306a
912017-01-18T09:56:47 <bitcoin-git> bitcoin/master 95bab82 practicalswift: Remove unused Python imports
922017-01-18T09:56:48 <bitcoin-git> bitcoin/master b0b57a1 MarcoFalke: Merge #9508: Remove unused Python imports...
932017-01-18T09:57:02 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9508: Remove unused Python imports (master...remove-unused-python-import) https://github.com/bitcoin/bitcoin/pull/9508
942017-01-18T10:00:35 *** wvr has quit IRC
952017-01-18T10:00:39 *** Samdney has quit IRC
962017-01-18T10:10:13 *** e4xit has joined #bitcoin-core-dev
972017-01-18T10:14:15 *** wvr has joined #bitcoin-core-dev
982017-01-18T10:15:39 *** MarcoFalke has quit IRC
992017-01-18T10:23:57 *** AaronvanW has joined #bitcoin-core-dev
1002017-01-18T10:26:39 *** CubicEarth has quit IRC
1012017-01-18T10:38:44 *** CubicEarth has joined #bitcoin-core-dev
1022017-01-18T10:41:05 *** chjj has quit IRC
1032017-01-18T11:01:25 *** kittyP has joined #bitcoin-core-dev
1042017-01-18T11:04:04 *** kittyP has left #bitcoin-core-dev
1052017-01-18T11:15:11 *** Guyver2 has joined #bitcoin-core-dev
1062017-01-18T11:27:28 *** chjj has joined #bitcoin-core-dev
1072017-01-18T11:32:51 *** CubicEarth has quit IRC
1082017-01-18T11:36:30 *** waxwing has quit IRC
1092017-01-18T11:37:15 <bitcoin-git> [bitcoin] fanquake opened pull request #9574: [depends] Fix QT build on OSX (master...fix-osx-depends-build) https://github.com/bitcoin/bitcoin/pull/9574
1102017-01-18T11:49:48 *** waxwing has joined #bitcoin-core-dev
1112017-01-18T12:20:31 *** cryptapus has joined #bitcoin-core-dev
1122017-01-18T12:20:31 *** cryptapus has joined #bitcoin-core-dev
1132017-01-18T12:26:06 *** jtimon has joined #bitcoin-core-dev
1142017-01-18T13:01:49 *** moli_ has quit IRC
1152017-01-18T13:08:10 *** waxwing has quit IRC
1162017-01-18T13:15:08 *** blueyez has joined #bitcoin-core-dev
1172017-01-18T13:20:50 *** waxwing has joined #bitcoin-core-dev
1182017-01-18T13:27:02 *** handlex has joined #bitcoin-core-dev
1192017-01-18T13:38:34 *** handlex has quit IRC
1202017-01-18T13:41:47 *** paveljanik has joined #bitcoin-core-dev
1212017-01-18T13:41:47 *** paveljanik has joined #bitcoin-core-dev
1222017-01-18T13:48:01 *** handlex has joined #bitcoin-core-dev
1232017-01-18T13:49:54 *** moli_ has joined #bitcoin-core-dev
1242017-01-18T14:03:43 *** laurentmt has joined #bitcoin-core-dev
1252017-01-18T14:04:53 *** laurentmt has quit IRC
1262017-01-18T14:09:11 *** rafalcpp has joined #bitcoin-core-dev
1272017-01-18T14:15:13 <BlueMatt> cfields: yo
1282017-01-18T14:16:13 <BlueMatt> where are we on #9212 and #9278? The fix for 9212 at https://github.com/bitcoinfibre/bitcoinfibre/commit/8e2c2cf418adb3dad1479c3f8890e0a2c8b6f709 has been in production for a while (albeit not on nodes with a ton of connection churn) so I'm reasonably confident in it, but iirc you were not a fan?
1292017-01-18T14:16:15 <gribble> https://github.com/bitcoin/bitcoin/issues/9212 | Assertion failed: (nSendVersion != 0), function GetSendVersion, file ./net.h, line 775. · Issue #9212 · bitcoin/bitcoin · GitHub
1302017-01-18T14:16:16 <gribble> https://github.com/bitcoin/bitcoin/issues/9278 | test_bitcoin fails valgrind · Issue #9278 · bitcoin/bitcoin · GitHub
1312017-01-18T14:18:20 <BlueMatt> for those bored, #9392 should be an easy fix
1322017-01-18T14:18:21 <gribble> https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub
1332017-01-18T14:48:03 *** aalex has joined #bitcoin-core-dev
1342017-01-18T14:53:13 *** rafalcpp has quit IRC
1352017-01-18T14:53:41 *** moli_ has quit IRC
1362017-01-18T14:58:18 *** handlex has quit IRC
1372017-01-18T15:08:38 *** Chris_Stewart_5 has quit IRC
1382017-01-18T15:16:52 *** juscamarena has quit IRC
1392017-01-18T15:17:03 *** blkdb has quit IRC
1402017-01-18T15:17:13 *** blkdb has joined #bitcoin-core-dev
1412017-01-18T15:17:22 *** berndj has quit IRC
1422017-01-18T15:18:07 *** berndj has joined #bitcoin-core-dev
1432017-01-18T15:18:33 *** jeremyru1in has joined #bitcoin-core-dev
1442017-01-18T15:18:34 *** rabidus_ has joined #bitcoin-core-dev
1452017-01-18T15:18:35 *** helo_ has joined #bitcoin-core-dev
1462017-01-18T15:18:40 *** jeremyrubin has quit IRC
1472017-01-18T15:18:41 *** jnewbery1 has quit IRC
1482017-01-18T15:18:43 *** rabidus has quit IRC
1492017-01-18T15:18:50 *** Anduck_ has joined #bitcoin-core-dev
1502017-01-18T15:18:51 *** sipa_ has joined #bitcoin-core-dev
1512017-01-18T15:18:58 *** kinlo_ has joined #bitcoin-core-dev
1522017-01-18T15:18:58 *** helo has quit IRC
1532017-01-18T15:18:58 *** kinlo has quit IRC
1542017-01-18T15:19:11 *** kinlo_ is now known as kinlo
1552017-01-18T15:19:22 *** paveljanik has quit IRC
1562017-01-18T15:19:22 *** waxwing has quit IRC
1572017-01-18T15:19:22 *** Alopex has quit IRC
1582017-01-18T15:19:23 *** Evel-Knievel has quit IRC
1592017-01-18T15:19:24 *** CodeShark has quit IRC
1602017-01-18T15:19:25 *** jeremias1 has quit IRC
1612017-01-18T15:19:25 *** cfields has quit IRC
1622017-01-18T15:19:25 *** achow101 has quit IRC
1632017-01-18T15:19:25 *** Anduck has quit IRC
1642017-01-18T15:19:25 *** kanzure has quit IRC
1652017-01-18T15:19:26 *** ensign_ has quit IRC
1662017-01-18T15:19:26 *** sipa has quit IRC
1672017-01-18T15:19:27 *** nsh has quit IRC
1682017-01-18T15:19:27 *** lejitz has quit IRC
1692017-01-18T15:19:27 *** jl2012 has quit IRC
1702017-01-18T15:19:27 *** Taek has quit IRC
1712017-01-18T15:20:07 *** achow101 has joined #bitcoin-core-dev
1722017-01-18T15:22:47 *** cfields has joined #bitcoin-core-dev
1732017-01-18T15:22:47 *** 7F1AAKHX0 has joined #bitcoin-core-dev
1742017-01-18T15:22:47 *** paveljanik has joined #bitcoin-core-dev
1752017-01-18T15:22:47 *** waxwing has joined #bitcoin-core-dev
1762017-01-18T15:22:47 *** Alopex has joined #bitcoin-core-dev
1772017-01-18T15:22:47 *** Evel-Knievel has joined #bitcoin-core-dev
1782017-01-18T15:22:47 *** ensign_ has joined #bitcoin-core-dev
1792017-01-18T15:22:47 *** Taek has joined #bitcoin-core-dev
1802017-01-18T15:22:57 *** blueyez has quit IRC
1812017-01-18T15:23:50 *** michagogo has quit IRC
1822017-01-18T15:25:05 *** lejitz has joined #bitcoin-core-dev
1832017-01-18T15:25:57 *** shesek has quit IRC
1842017-01-18T15:26:08 *** cfields has quit IRC
1852017-01-18T15:26:11 *** jl2012 has joined #bitcoin-core-dev
1862017-01-18T15:26:23 *** cfields has joined #bitcoin-core-dev
1872017-01-18T15:26:29 *** CodeShark has joined #bitcoin-core-dev
1882017-01-18T15:27:32 *** nsh has joined #bitcoin-core-dev
1892017-01-18T15:29:03 *** kanzure has joined #bitcoin-core-dev
1902017-01-18T15:31:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1912017-01-18T15:31:44 *** michagogo has joined #bitcoin-core-dev
1922017-01-18T15:32:36 *** cfields has quit IRC
1932017-01-18T15:33:38 *** cfields has joined #bitcoin-core-dev
1942017-01-18T15:36:50 *** blueyez has joined #bitcoin-core-dev
1952017-01-18T15:46:30 *** moli_ has joined #bitcoin-core-dev
1962017-01-18T16:02:07 *** laurentmt has joined #bitcoin-core-dev
1972017-01-18T16:05:55 *** nickler has quit IRC
1982017-01-18T16:06:03 *** nickler has joined #bitcoin-core-dev
1992017-01-18T16:11:33 *** Anduck_ is now known as Anduck
2002017-01-18T16:14:22 *** handlex has joined #bitcoin-core-dev
2012017-01-18T16:15:21 *** laurentmt has quit IRC
2022017-01-18T16:15:34 <cfields> BlueMatt: I didn't like that change at the time because 1. We weren't always disconnecting (or checking fDisconnect) as necessary at the time, and 2. It changes the "you can only send 1 version message" semantics a bit. 1. should be fixed since fedea8a14. I think your change is probably ok, but I think we should think through 2 a little.
2032017-01-18T16:17:37 <BlueMatt> I know we also discussed moving off of the "nVersion is set means connected" to using the fSuccessfullyConnected flag again
2042017-01-18T16:17:45 <BlueMatt> they're kinda confused and redundant atm
2052017-01-18T16:18:39 <cfields> yea
2062017-01-18T16:19:14 <cfields> that would be my preference, only issue there is defining "successfully connected"
2072017-01-18T16:21:01 *** moli_ has quit IRC
2082017-01-18T16:23:27 <cfields> BlueMatt: as a weird example, I think your change would allow for sending infinite version messages in which the addrMe portion fails to deserialize
2092017-01-18T16:23:57 <cfields> so a peer could change their nVersion a bunch of times before locking it in
2102017-01-18T16:24:15 <cfields> (i don't know what good that would do, but we certainly shouldn't be allowing that)
2112017-01-18T16:24:44 <BlueMatt> I'd file that under "undefined behavior" I believe in that case we may be required to make a best effort to eat the sender's cat
2122017-01-18T16:25:18 <BlueMatt> but short that, I'm not sure if we care that they can do that?
2132017-01-18T16:25:32 <BlueMatt> as long as we actually gate on fSuccessfullyConnected
2142017-01-18T16:25:53 <cfields> BlueMatt: right, that was my point. atm we don't in many places
2152017-01-18T16:25:54 <BlueMatt> cfields: do you have time to look at that, or should I just whip something up with fSuccessfullyConnected after I finish review of one or two others?
2162017-01-18T16:26:08 <BlueMatt> well atm we check nVersion != 0 pretty much everywhere, i think
2172017-01-18T16:26:14 <BlueMatt> as a proxy for connectedness
2182017-01-18T16:27:00 <cfields> BlueMatt: right, and in the above scenario, we don't consider them connected, but their nVersion is set.
2192017-01-18T16:27:21 <BlueMatt> ok, so replace nVersion != 0 with fSuccessfullyConnected everywhere, i guess?
2202017-01-18T16:29:07 <cfields> i think so.
2212017-01-18T16:29:13 <BlueMatt> k
2222017-01-18T16:29:18 <cfields> and at this point, we can remove the assert
2232017-01-18T16:29:20 <BlueMatt> I'll do it after lunch if you havent gotten to it
2242017-01-18T16:29:25 <BlueMatt> I'd prefer leaving it in?
2252017-01-18T16:29:31 <BlueMatt> afaict its super easy to fix
2262017-01-18T16:29:37 <BlueMatt> I'm incredibly confident in the above change
2272017-01-18T16:29:48 <BlueMatt> (as its equivalent to the change I've been running for months now)
2282017-01-18T16:30:19 <cfields> BlueMatt: point me at a node running it, let's see if i can bring it down :)
2292017-01-18T16:31:00 <BlueMatt> the fibre nodes
2302017-01-18T16:31:01 <BlueMatt> :p
2312017-01-18T16:31:46 <cfields> heh
2322017-01-18T16:31:54 *** Netmage has quit IRC
2332017-01-18T16:32:49 *** bsm117532 has joined #bitcoin-core-dev
2342017-01-18T16:34:02 <BlueMatt> I'll swap my public node to master soonish
2352017-01-18T16:34:06 <BlueMatt> it gets a shitload of connection churn
2362017-01-18T16:34:17 <BlueMatt> and fun spy nodes and shit which do batshit crazy things
2372017-01-18T16:48:49 *** moli_ has joined #bitcoin-core-dev
2382017-01-18T16:50:33 *** abpa has joined #bitcoin-core-dev
2392017-01-18T16:52:08 <bitcoin-git> [bitcoin] practicalswift opened pull request #9575: [trivial] Add comment about unreachable code (master...never-executed-comment) https://github.com/bitcoin/bitcoin/pull/9575
2402017-01-18T16:52:30 <BlueMatt> jonasschnelli: https://github.com/bitcoin/bitcoin/pull/9461#discussion_r96680764
2412017-01-18T16:52:53 *** BashCo_ has quit IRC
2422017-01-18T16:53:28 *** BashCo has joined #bitcoin-core-dev
2432017-01-18T16:58:09 *** BashCo has quit IRC
2442017-01-18T17:01:36 <bitcoin-git> [bitcoin] practicalswift opened pull request #9576: [wallet] Remove redundant initialization (master...remove-redundant-initialization-ii) https://github.com/bitcoin/bitcoin/pull/9576
2452017-01-18T17:11:54 *** waxwing has quit IRC
2462017-01-18T17:12:51 *** waxwing has joined #bitcoin-core-dev
2472017-01-18T17:15:01 *** echonaut has quit IRC
2482017-01-18T17:15:16 *** echonaut has joined #bitcoin-core-dev
2492017-01-18T17:26:07 <cfields> BlueMatt: ok, whipping something up on top of yours. Think I've got a full picture of it all in my head.
2502017-01-18T17:32:53 *** kadoban has joined #bitcoin-core-dev
2512017-01-18T17:33:49 *** BashCo has joined #bitcoin-core-dev
2522017-01-18T17:34:23 *** waxwing has quit IRC
2532017-01-18T17:36:45 <BlueMatt> cfields: ok, thanks, got distracted on other things
2542017-01-18T17:46:18 *** Chris_Stewart_5 has quit IRC
2552017-01-18T17:50:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2562017-01-18T17:50:50 *** waxwing has joined #bitcoin-core-dev
2572017-01-18T17:51:12 *** jannes has quit IRC
2582017-01-18T18:12:06 *** CubicEarth has joined #bitcoin-core-dev
2592017-01-18T18:14:22 *** handlex has quit IRC
2602017-01-18T18:17:37 *** isis has quit IRC
2612017-01-18T18:19:10 *** waxwing has quit IRC
2622017-01-18T18:33:40 *** handlex has joined #bitcoin-core-dev
2632017-01-18T18:38:55 <BlueMatt> someone should tag #9569, #9371 and #9148 for 0.14 because they fix 0.14-tagged issues
2642017-01-18T18:38:57 <gribble> https://github.com/bitcoin/bitcoin/issues/9569 | Setting -blocksonly sets -maxmempool to zero. by jnewbery · Pull Request #9569 · bitcoin/bitcoin · GitHub
2652017-01-18T18:38:59 <gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
2662017-01-18T18:39:00 <gribble> https://github.com/bitcoin/bitcoin/issues/9148 | Wallet RPCs can return stale info due to ProcessNewBlock Race · Issue #9148 · bitcoin/bitcoin · GitHub
2672017-01-18T18:47:36 *** BitBully has joined #bitcoin-core-dev
2682017-01-18T18:55:54 *** cryptapus has quit IRC
2692017-01-18T18:58:20 <BlueMatt> sorry, that last one should be #9570
2702017-01-18T18:58:21 <gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
2712017-01-18T19:06:17 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b0b57a17306a...6012967c4746
2722017-01-18T19:06:18 <bitcoin-git> bitcoin/master 843c560 Pieter Wuille: Avoid unaligned access in crypto i/o
2732017-01-18T19:06:19 <bitcoin-git> bitcoin/master f94f3e0 Pieter Wuille: Avoid integer overflows in scriptnum tests
2742017-01-18T19:06:19 <bitcoin-git> bitcoin/master 6b03bfb Pieter Wuille: Fix memory leak in wallet tests
2752017-01-18T19:06:35 <bitcoin-git> [bitcoin] laanwj closed pull request #9512: Fix various things -fsanitize complains about (master...sanitize) https://github.com/bitcoin/bitcoin/pull/9512
2762017-01-18T19:08:32 <Chris_Stewart_5> Does some one mind merging in #9350? Pretty trivial, just fixing some documentation on tests
2772017-01-18T19:08:34 <gribble> https://github.com/bitcoin/bitcoin/issues/9350 | [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json by Christewart · Pull Request #9350 · bitcoin/bitcoin · GitHub
2782017-01-18T19:19:02 *** blueyez has quit IRC
2792017-01-18T19:21:25 <morcos> wumpus: sipa: I updated #9371 in a way that I think accomplish both of our goals
2802017-01-18T19:21:27 <gribble> https://github.com/bitcoin/bitcoin/issues/9371 | Notify on removal by morcos · Pull Request #9371 · bitcoin/bitcoin · GitHub
2812017-01-18T19:21:52 * BlueMatt likes it because I have future plans in the area...but will explain on the pr when I review in a minute :p
2822017-01-18T19:29:38 *** BitBully has quit IRC
2832017-01-18T19:32:07 *** CubicEarth has quit IRC
2842017-01-18T19:34:50 <cfields> BlueMatt: hmm, looks like that could make your recent-tx cache significantly smarter
2852017-01-18T19:36:55 *** blueyez has joined #bitcoin-core-dev
2862017-01-18T19:38:07 <BlueMatt> yes, lots of ways it could be made smarter :)
2872017-01-18T19:38:38 *** blueyez has quit IRC
2882017-01-18T19:39:27 *** moli_ has quit IRC
2892017-01-18T19:41:52 *** abpa has quit IRC
2902017-01-18T19:50:05 *** abpa has joined #bitcoin-core-dev
2912017-01-18T19:50:11 *** CubicEarth has joined #bitcoin-core-dev
2922017-01-18T19:52:16 *** handlex has quit IRC
2932017-01-18T19:57:20 <bitcoin-git> [bitcoin] jnewbery opened pull request #9577: Fix docstrings in qa tests (master...docstrings) https://github.com/bitcoin/bitcoin/pull/9577
2942017-01-18T19:58:03 <BlueMatt> sipa_/wumpus: so I think the only way to fix the regression introduced in #7946 without giving up the gains it gave us is to introduce a second cs_wallet - cs_wallet_locked_before_cs_main
2952017-01-18T19:58:06 <gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
2962017-01-18T19:58:13 <BlueMatt> see https://github.com/bitcoin/bitcoin/pull/9570#issuecomment-273583506
2972017-01-18T19:58:16 <BlueMatt> please dont kill me
2982017-01-18T20:01:36 <cfields> morcos: ah, i missed your comment in the description. I guess i'm requesting choice #1 :)
2992017-01-18T20:01:38 <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
3002017-01-18T20:02:07 <BlueMatt> cfields: regarding SyncTransaction changes, see https://github.com/bitcoin/bitcoin/pull/9570/commits/bc4c4c66863fce718402a3f9b2da4e92c1898745
3012017-01-18T20:02:19 <BlueMatt> I do remove the NOT_IN_BLOCK kludge ther
3022017-01-18T20:02:19 <BlueMatt> e
3032017-01-18T20:02:28 <BlueMatt> (but this introduces the need for a second wallet lock)
3042017-01-18T20:02:52 <morcos> cfields: I'm trying to do the minimal required in 9371 to fix the regression though.. as it needs to be merged for 0.14...
3052017-01-18T20:03:23 <cfields> morcos: ok, fair enough
3062017-01-18T20:03:29 <morcos> so i don't want to do a new signal now b/c it will require thinking carefully about what should subscribe to it
3072017-01-18T20:03:48 <morcos> but i'm fine dropping the SYNC_TRANASCTION_NOT_IN_BLOCK as BlueMatt did
3082017-01-18T20:04:26 <cfields> ok, will look over that one too
3092017-01-18T20:10:31 <sipa_> BlueMatt: i'm unclear about it... can you write a simple commit that does the cs_wallet_locked_before_cs_main ?
3102017-01-18T20:10:46 <BlueMatt> sipa_: I think we can push off to 0.15, but I will do that, yes, one sec
3112017-01-18T20:12:35 *** jtimon has quit IRC
3122017-01-18T20:15:40 *** CubicEarth has quit IRC
3132017-01-18T20:21:03 *** CubicEarth has joined #bitcoin-core-dev
3142017-01-18T20:24:03 *** windsok has quit IRC
3152017-01-18T20:29:51 *** juscamarena has joined #bitcoin-core-dev
3162017-01-18T20:29:52 *** juscamarena_ has joined #bitcoin-core-dev
3172017-01-18T20:30:45 *** handlex has joined #bitcoin-core-dev
3182017-01-18T20:43:39 *** CubicEarth has quit IRC
3192017-01-18T20:44:26 *** Victor_sueca has joined #bitcoin-core-dev
3202017-01-18T20:47:38 *** Victorsueca has quit IRC
3212017-01-18T20:51:13 *** windsok has joined #bitcoin-core-dev
3222017-01-18T20:53:25 *** CubicEarth has joined #bitcoin-core-dev
3232017-01-18T20:57:16 *** handlex has quit IRC
3242017-01-18T21:00:01 *** CubicEarth has quit IRC
3252017-01-18T21:07:24 *** jtimon has joined #bitcoin-core-dev
3262017-01-18T21:07:37 <luke-jr> done with reviews I think. ping me if there's anything needed priority on before 0.14 freeze.
3272017-01-18T21:09:06 *** CubicEarth has joined #bitcoin-core-dev
3282017-01-18T21:13:45 *** waxwing has joined #bitcoin-core-dev
3292017-01-18T21:15:48 *** isis has joined #bitcoin-core-dev
3302017-01-18T21:24:11 *** wvr has quit IRC
3312017-01-18T21:37:04 *** CubicEarth has quit IRC
3322017-01-18T21:37:32 *** CubicEarth has joined #bitcoin-core-dev
3332017-01-18T21:45:13 <BlueMatt> sipa_: see https://github.com/TheBlueMatt/bitcoin/commit/c99e4d107aac573e8de892d7592b04c685186e44
3342017-01-18T21:45:57 <BlueMatt> specifically, this half-reverts #9570 to get to the behavior intended in #7946 without introducing the getbalance-etc-may-return-data-from-mid-block-processing regression
3352017-01-18T21:45:59 <gribble> https://github.com/bitcoin/bitcoin/issues/9570 | Block Wallet RPCs until wallet is synced to our current chain by TheBlueMatt · Pull Request #9570 · bitcoin/bitcoin · GitHub
3362017-01-18T21:46:01 <gribble> https://github.com/bitcoin/bitcoin/issues/7946 | Reduce cs_main locks during ConnectTip/SyncWithWallets by jonasschnelli · Pull Request #7946 · bitcoin/bitcoin · GitHub
3372017-01-18T21:57:56 *** cryptapus_afk is now known as cryptapus
3382017-01-18T22:04:40 <BlueMatt> someone wanna kick https://travis-ci.org/bitcoin/bitcoin/builds/193151086 ? looks like it failed due to travis timeout because it built dependancies and not because it failed
3392017-01-18T22:15:37 *** moli_ has joined #bitcoin-core-dev
3402017-01-18T22:27:17 *** bsm117532 has quit IRC
3412017-01-18T22:31:20 <BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/txmempool.cpp#L555 <-- that is wrong...100 block reorg and it could blow up (with the checkmempool debug instrumentation enabled)
3422017-01-18T22:32:11 *** bsm117532 has joined #bitcoin-core-dev
3432017-01-18T22:34:00 *** bsm1175322 has joined #bitcoin-core-dev
3442017-01-18T22:35:27 *** bsm1175322 has quit IRC
3452017-01-18T22:36:57 *** bsm117532 has quit IRC
3462017-01-18T22:37:45 *** bsm117532 has joined #bitcoin-core-dev
3472017-01-18T22:44:35 *** chjj has quit IRC
3482017-01-18T22:55:26 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9578: Add missing mempool lock for CalculateMemPoolAncestors (master...2017-01-fix-missing-wallet-mempool-lock) https://github.com/bitcoin/bitcoin/pull/9578
3492017-01-18T22:59:59 *** Guyver2 has quit IRC
3502017-01-18T23:00:05 *** CubicEarth has quit IRC
3512017-01-18T23:03:27 *** cryptapus is now known as cryptapus_afk
3522017-01-18T23:08:30 *** face has quit IRC
3532017-01-18T23:08:47 *** face has joined #bitcoin-core-dev
3542017-01-18T23:10:24 <cfields> BlueMatt: ok, i've been staring at this for most of the day and i'm reasonably satisfied now. I'm good with your change with 2 tweaks
3552017-01-18T23:11:13 <cfields> 1. deserialize the whole thing locally. Same change you made for nVersion, let's go ahead and do that for everything. That way we don't end up in a weird state if something throws
3562017-01-18T23:11:43 *** CubicEarth has joined #bitcoin-core-dev
3572017-01-18T23:11:49 <cfields> and 2. just a quick reordering that moves the assignment into CNode up a bit, and sets nVersion/fSuccessfullyConnected last.
3582017-01-18T23:12:42 *** vidjogamer has joined #bitcoin-core-dev
3592017-01-18T23:16:59 <cfields> BlueMatt: something like https://github.com/theuni/bitcoin/commit/ed60b005fa0b61ab4454e075e6c7d9a54e2c24a0 on top of yours
3602017-01-18T23:20:40 *** LeMiner has quit IRC
3612017-01-18T23:24:35 *** jtimon has quit IRC
3622017-01-18T23:24:35 *** jl2012 has quit IRC
3632017-01-18T23:24:35 *** lejitz has quit IRC
3642017-01-18T23:24:37 *** atroxes has quit IRC
3652017-01-18T23:24:55 *** jtimon has joined #bitcoin-core-dev
3662017-01-18T23:24:56 *** jl2012 has joined #bitcoin-core-dev
3672017-01-18T23:24:56 *** lejitz has joined #bitcoin-core-dev
3682017-01-18T23:24:56 *** atroxes has joined #bitcoin-core-dev
3692017-01-18T23:29:36 *** chjj has joined #bitcoin-core-dev
3702017-01-18T23:45:40 *** CubicEarth has quit IRC
3712017-01-18T23:47:30 *** chjj has quit IRC