12017-02-14T00:08:21 *** Guyver2 has quit IRC
22017-02-14T00:21:55 *** arubi has quit IRC
32017-02-14T00:22:32 *** arubi has joined #bitcoin-core-dev
42017-02-14T00:31:44 *** xsegfault has joined #bitcoin-core-dev
52017-02-14T00:37:49 *** jannes has quit IRC
62017-02-14T01:00:07 *** Alopex has joined #bitcoin-core-dev
72017-02-14T01:00:46 *** abpa has quit IRC
82017-02-14T01:05:14 *** Alopex has quit IRC
92017-02-14T01:14:05 *** MarcoFalke has joined #bitcoin-core-dev
102017-02-14T01:20:58 *** MarcoFalke has quit IRC
112017-02-14T01:35:44 *** wasi has quit IRC
122017-02-14T01:36:13 *** wasi has joined #bitcoin-core-dev
132017-02-14T01:49:24 *** chjj has quit IRC
142017-02-14T01:49:45 *** chjj has joined #bitcoin-core-dev
152017-02-14T02:04:15 *** droark has quit IRC
162017-02-14T02:12:41 *** xsegfault has quit IRC
172017-02-14T02:24:00 <achow101> does testnet use the bitcoin.conf in the datadir or one in datadir/testnet3?
182017-02-14T02:42:14 <sipa> "it's complicated"
192017-02-14T02:43:59 *** Ylbam has quit IRC
202017-02-14T02:44:33 <achow101> one? both? something else?
212017-02-14T02:44:46 <sipa> both...
222017-02-14T02:44:56 <sipa> depending on whether you explicitly specify a datadir
232017-02-14T02:44:57 <sipa> (i think)
242017-02-14T02:45:25 <achow101> great
252017-02-14T02:57:31 *** goksinen has quit IRC
262017-02-14T03:01:28 *** udiWertheimer has quit IRC
272017-02-14T03:02:06 *** xsegfault has joined #bitcoin-core-dev
282017-02-14T03:05:35 *** xsegfault has left #bitcoin-core-dev
292017-02-14T03:13:00 *** goksinen has joined #bitcoin-core-dev
302017-02-14T03:17:55 *** goksinen has quit IRC
312017-02-14T03:18:17 *** Victor_sueca has joined #bitcoin-core-dev
322017-02-14T03:21:24 *** Victorsueca has quit IRC
332017-02-14T03:22:30 *** Giszmo has quit IRC
342017-02-14T03:30:44 <luke-jr> AFAIK there isn't a bitcoin.conf in datadir/testnet3?
352017-02-14T03:30:50 <luke-jr> (and if you make one it will be ignored)
362017-02-14T03:31:00 <luke-jr> I could be wrong, but I recall expecting it to work, and finding it doesn't..
372017-02-14T03:43:59 *** jtimon has quit IRC
382017-02-14T05:14:10 *** thestringpuller has quit IRC
392017-02-14T05:14:23 *** thestringpuller has joined #bitcoin-core-dev
402017-02-14T05:14:46 *** thestringpuller is now known as Guest14958
412017-02-14T05:26:57 <jcorgan> i have a couple questions/comments about some of the init.cpp network parameter settings
422017-02-14T05:27:29 <jcorgan> my goal is to allow hostname lookups for some of the params (-proxy, -onion, -torcontrol)
432017-02-14T05:28:10 <jcorgan> there is a -dns parameter for enabling this for -connect, -addnode, and -seednode
442017-02-14T05:28:39 <jcorgan> and it gets read into fAllowLookup
452017-02-14T05:29:13 <jcorgan> the initialization for those eventually resolves to Lookup(...) with fAllowNode as the final parameter
462017-02-14T05:30:02 <jcorgan> i changed the LookupNumeric to Lookup for -proxy and -onion, with the same args, and it works
472017-02-14T05:30:38 <jcorgan> but only if i move the initialization for -dns up before this section so the fNameLookup is set already
482017-02-14T05:31:04 <jcorgan> so, this is only a few lines change in init.cpp; is this all it takes?
492017-02-14T05:31:22 <jcorgan> (i haven't touched torcontrol yet, but the other two are working for me now)
502017-02-14T05:32:16 <jcorgan> is it ok to extend the meaning of -dns to cover these three other params in addition to the ones it affects now?
512017-02-14T05:32:48 <jcorgan> oh, s/fAllowLookup/fNameLookup/
522017-02-14T05:33:03 <jcorgan> would this be useful to anyone but me?
532017-02-14T05:36:03 <jcorgan> maybe it would be easier to just do a PR
542017-02-14T05:39:23 <sipa> jcorgan: seems reasonable to me
552017-02-14T05:42:19 <jcorgan> i'll finish the torcontrol stuff and PR it then
562017-02-14T05:42:36 <jcorgan> it will also need some documentation changes to reflect this
572017-02-14T06:00:43 <jcorgan> ah, torcontrol is calling a raw address parser in libevent, will need to do some actual work to implement hostname lookup for that
582017-02-14T06:13:30 *** goksinen has joined #bitcoin-core-dev
592017-02-14T06:18:27 *** lclc has joined #bitcoin-core-dev
602017-02-14T06:38:10 *** Ylbam has joined #bitcoin-core-dev
612017-02-14T06:56:44 *** Alina-malina has quit IRC
622017-02-14T07:05:48 *** paveljanik has quit IRC
632017-02-14T07:08:37 *** juscamarena has quit IRC
642017-02-14T07:09:06 *** juscamarena has joined #bitcoin-core-dev
652017-02-14T07:15:32 *** Victor_sueca is now known as Victorsueca
662017-02-14T07:20:56 *** Alina-malina has joined #bitcoin-core-dev
672017-02-14T07:23:53 *** Alina-malina has quit IRC
682017-02-14T07:23:53 *** Alina-malina has joined #bitcoin-core-dev
692017-02-14T07:29:00 *** goatee has quit IRC
702017-02-14T07:31:52 *** chartractegg has joined #bitcoin-core-dev
712017-02-14T07:41:15 *** BashCo has quit IRC
722017-02-14T07:43:30 *** chartrac_ has joined #bitcoin-core-dev
732017-02-14T07:46:26 *** chartractegg has quit IRC
742017-02-14T07:46:46 *** chartrac_ has quit IRC
752017-02-14T07:47:17 *** chartractegg has joined #bitcoin-core-dev
762017-02-14T07:57:17 *** juscamarena has quit IRC
772017-02-14T07:58:53 *** chartractegg has quit IRC
782017-02-14T07:59:37 *** chartractegg has joined #bitcoin-core-dev
792017-02-14T08:03:16 *** chartractegg has quit IRC
802017-02-14T08:03:38 *** BashCo has joined #bitcoin-core-dev
812017-02-14T08:03:55 *** chartractegg has joined #bitcoin-core-dev
822017-02-14T08:14:22 *** BashCo_ has joined #bitcoin-core-dev
832017-02-14T08:17:05 *** BashCo has quit IRC
842017-02-14T08:47:49 *** lclc has quit IRC
852017-02-14T08:48:19 *** lclc has joined #bitcoin-core-dev
862017-02-14T08:50:31 *** whphhg_ has joined #bitcoin-core-dev
872017-02-14T08:51:58 *** whphhg has quit IRC
882017-02-14T08:54:35 *** juscamarena_ has joined #bitcoin-core-dev
892017-02-14T08:54:36 *** juscamarena has joined #bitcoin-core-dev
902017-02-14T09:05:04 *** chartractegg has quit IRC
912017-02-14T09:10:28 *** laurentmt has joined #bitcoin-core-dev
922017-02-14T09:14:54 *** whphhg_ has quit IRC
932017-02-14T09:17:09 <jonasschnelli> Would it make sense to mention something about the net refactoring in the 0.14er release notes? https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.14.0-Release-notes
942017-02-14T09:18:02 *** MarcoFalke has joined #bitcoin-core-dev
952017-02-14T09:21:24 *** laurentmt has quit IRC
962017-02-14T09:26:18 *** wasi_ has joined #bitcoin-core-dev
972017-02-14T09:26:23 *** wasi has quit IRC
982017-02-14T09:28:44 <gmaxwell> jonasschnelli: need to do a measurement of a sync between a pair of old nodes and a pair of new nodes.
992017-02-14T09:29:24 <gmaxwell> and just mention as a top level release note that the IBD speed went from x to y due to networking improvements, assume valid, validation cache improvements, and other optimizations.
1002017-02-14T09:29:47 <jonasschnelli> gmaxwell: I need to talk about the 0.14 release tomorrow,... do we have a rough estimation already?
1012017-02-14T09:30:20 <gmaxwell> A kazillion fold.
1022017-02-14T09:30:51 <gmaxwell> For a talk you can say reduced by hours.
1032017-02-14T09:31:24 <jonasschnelli> Okay. That seems to be vague but precise enough. :)
1042017-02-14T09:31:40 <gmaxwell> on fast computers the network changes and validation cache help a lot, and on really slow computers the assume valid change is more tens of hours reduction.
1052017-02-14T09:32:29 <jonasschnelli> Regardless of talks, etc. We should mention the sigcache and the network "refactor" in the release notes.
1062017-02-14T09:32:59 <gmaxwell> well as I said, we should mention the performance, and list why. The headline is the performance.
1072017-02-14T09:33:00 <jonasschnelli> It seems to me that the a major part of the effort for 0.14 is missing in the release notes
1082017-02-14T09:33:24 <jonasschnelli> I agree with performance as headline.
1092017-02-14T09:49:05 *** chjj has quit IRC
1102017-02-14T10:08:17 *** juscamarena_ has quit IRC
1112017-02-14T10:10:13 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758
1122017-02-14T10:12:05 *** sanada has quit IRC
1132017-02-14T10:12:17 *** sanada has joined #bitcoin-core-dev
1142017-02-14T10:38:15 *** lclc has quit IRC
1152017-02-14T10:45:45 *** Guyver2 has joined #bitcoin-core-dev
1162017-02-14T11:13:58 *** lclc has joined #bitcoin-core-dev
1172017-02-14T11:20:14 *** chjj has joined #bitcoin-core-dev
1182017-02-14T11:22:01 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d978c41e1ec4...ec66d06e6ef3
1192017-02-14T11:22:02 <bitcoin-git> bitcoin/master 5e903a5 Wladimir J. van der Laan: devtools: Handle Qt formatting characters edge-case in update-translations.py...
1202017-02-14T11:22:03 <bitcoin-git> bitcoin/master 7179e7c Wladimir J. van der Laan: qt: Periodic translations update
1212017-02-14T11:22:05 <bitcoin-git> bitcoin/master ec66d06 Wladimir J. van der Laan: Merge #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py...
1222017-02-14T11:22:16 <bitcoin-git> [bitcoin] laanwj closed pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (master...2017_02_qt_translations) https://github.com/bitcoin/bitcoin/pull/9735
1232017-02-14T11:23:44 *** afk11 has joined #bitcoin-core-dev
1242017-02-14T11:30:17 <bitcoin-git> [bitcoin] laanwj closed pull request #9751: Mini fix bincoin against bitcoin (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9751
1252017-02-14T11:33:45 <wumpus> just bumped the expiration dates for my key (0x74810B012346C9A6) and the bitcoin core release signing key (0x90C8019E36C2E964) two years forward, you might want to re-fetch them
1262017-02-14T11:41:18 <wumpus> (or --refresh-keys)
1272017-02-14T12:00:06 *** afk11 has quit IRC
1282017-02-14T12:24:59 *** laurentmt has joined #bitcoin-core-dev
1292017-02-14T13:24:03 *** laurentmt has quit IRC
1302017-02-14T13:32:51 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/ec66d06e6ef3...edc9e63c5799
1312017-02-14T13:32:52 <bitcoin-git> bitcoin/master 442887f Russell Yanofsky: Require timestamps for importmulti keys...
1322017-02-14T13:32:53 <bitcoin-git> bitcoin/master 3cf9917 Russell Yanofsky: Add test to check new importmulti "now" value...
1332017-02-14T13:32:53 <bitcoin-git> bitcoin/master 266a811 Russell Yanofsky: Use MTP for importmulti "now" timestamps
1342017-02-14T13:33:08 <bitcoin-git> [bitcoin] laanwj closed pull request #9682: Require timestamps for importmulti keys (master...pr/multinow) https://github.com/bitcoin/bitcoin/pull/9682
1352017-02-14T13:35:36 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/edc9e63c5799...b08656e34314
1362017-02-14T13:35:39 <bitcoin-git> bitcoin/master 2cbd119 Matt Corallo: Disconnect peers which we do not receive VERACKs from within 60 sec
1372017-02-14T13:35:39 <bitcoin-git> bitcoin/master 8aaba7a Matt Corallo: qa: mininode learns when a socket connects, not its first action
1382017-02-14T13:35:39 <bitcoin-git> bitcoin/master b436f92 Matt Corallo: qa: Expose on-connection to mininode listeners
1392017-02-14T13:35:58 <bitcoin-git> [bitcoin] laanwj closed pull request #9715: Disconnect peers which we do not receive VERACKs from within 60 sec (master...2017-02-disconnect-no-verack) https://github.com/bitcoin/bitcoin/pull/9715
1402017-02-14T13:40:18 <jonasschnelli> Only two left: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.14.0
1412017-02-14T13:40:25 <jonasschnelli> Going to test 9108 now
1422017-02-14T13:42:53 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/b08656e34314...e87ce95fbdc6
1432017-02-14T13:42:54 <bitcoin-git> bitcoin/master c45b9fb Cory Fields: net: correctly ban before the handshake is complete...
1442017-02-14T13:42:55 <bitcoin-git> bitcoin/master 8502e7a Cory Fields: net: parse reject earlier...
1452017-02-14T13:42:55 <bitcoin-git> bitcoin/master cbfc5a6 Cory Fields: net: require a verack before responding to anything else...
1462017-02-14T13:43:08 <bitcoin-git> [bitcoin] laanwj closed pull request #9720: net: fix banning and disallow sending messages before receiving verack (master...fix-ban) https://github.com/bitcoin/bitcoin/pull/9720
1472017-02-14T13:48:01 *** d9b4bef9 has quit IRC
1482017-02-14T13:49:08 *** d9b4bef9 has joined #bitcoin-core-dev
1492017-02-14T13:51:47 *** instagibbs has joined #bitcoin-core-dev
1502017-02-14T13:53:42 *** Giszmo has joined #bitcoin-core-dev
1512017-02-14T13:53:42 *** Giszmo has quit IRC
1522017-02-14T13:55:19 <jonasschnelli> luke-jr: I think your sensitive datafilter is nice,.. but we always dump the sent command into the console window... this should also be filtered, not?
1532017-02-14T14:19:27 *** isle2983 has quit IRC
1542017-02-14T14:20:53 *** jtimon has joined #bitcoin-core-dev
1552017-02-14T14:23:14 *** isle2983 has joined #bitcoin-core-dev
1562017-02-14T14:41:01 *** Kexkey_ has joined #bitcoin-core-dev
1572017-02-14T14:42:12 *** jamezz has quit IRC
1582017-02-14T14:43:22 *** wbnns has quit IRC
1592017-02-14T14:43:22 *** nOgAnOo has quit IRC
1602017-02-14T14:44:53 *** whphhg has joined #bitcoin-core-dev
1612017-02-14T14:47:52 *** lclc has quit IRC
1622017-02-14T14:48:58 *** wbnns has joined #bitcoin-core-dev
1632017-02-14T14:51:07 <jonasschnelli> Is there a reason why the internal miner mines to p2pk instead of p2pkh?
1642017-02-14T14:51:08 <jonasschnelli> void CWallet::GetScriptForMining(boost::shared_ptr<CReserveScript> &script)
1652017-02-14T14:51:14 <jonasschnelli> seems to generate CScript() << ToByteVector(pubkey) << OP_CHECKSIG;
1662017-02-14T14:53:56 *** face has quit IRC
1672017-02-14T14:54:09 *** face has joined #bitcoin-core-dev
1682017-02-14T14:55:35 *** eenoch_ has quit IRC
1692017-02-14T14:56:10 *** eenoch has joined #bitcoin-core-dev
1702017-02-14T14:57:27 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e87ce95fbdc6...a441db01b527
1712017-02-14T14:57:27 <bitcoin-git> bitcoin/master 0b4f273 Luke Dashjr: Bugfix: Qt/Options: Restore persistent "restart required" notice
1722017-02-14T14:57:28 <bitcoin-git> bitcoin/master a441db0 Jonas Schnelli: Merge #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice...
1732017-02-14T14:58:06 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9755: Bugfix: Qt/Options: Restore persistent "restart required" notice (master...bugfix_gui_opts_restartreq) https://github.com/bitcoin/bitcoin/pull/9755
1742017-02-14T14:59:04 *** lejit has joined #bitcoin-core-dev
1752017-02-14T15:06:50 *** Creeper has joined #bitcoin-core-dev
1762017-02-14T15:07:37 *** Giszmo has joined #bitcoin-core-dev
1772017-02-14T15:20:30 *** e4xit has joined #bitcoin-core-dev
1782017-02-14T15:26:35 *** MarcoFalke has quit IRC
1792017-02-14T15:29:49 *** rafalcpp_ has quit IRC
1802017-02-14T15:30:12 *** rafalcpp has joined #bitcoin-core-dev
1812017-02-14T15:33:52 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9760: [wallet] Remove importmulti always-true check (master...pr/multitaut) https://github.com/bitcoin/bitcoin/pull/9760
1822017-02-14T16:05:13 *** Guest14958 is now known as thestringpuller
1832017-02-14T16:05:36 *** thestringpuller has joined #bitcoin-core-dev
1842017-02-14T16:14:50 *** BashCo has joined #bitcoin-core-dev
1852017-02-14T16:17:24 *** BashCo_ has quit IRC
1862017-02-14T16:43:32 *** nOgAnOo has joined #bitcoin-core-dev
1872017-02-14T16:47:56 *** abpa has joined #bitcoin-core-dev
1882017-02-14T17:00:50 *** chjj has quit IRC
1892017-02-14T17:25:00 *** BashCo_ has joined #bitcoin-core-dev
1902017-02-14T17:25:25 *** BashCo has quit IRC
1912017-02-14T17:26:03 *** jannes has joined #bitcoin-core-dev
1922017-02-14T17:28:50 *** laurentmt has joined #bitcoin-core-dev
1932017-02-14T17:30:03 *** laurentmt has quit IRC
1942017-02-14T17:43:09 *** laurentmt has joined #bitcoin-core-dev
1952017-02-14T17:44:09 <jl2012> jonasschnelli: I think it's overall cheaper to use P2PK
1962017-02-14T18:02:48 *** laurentmt has quit IRC
1972017-02-14T18:14:03 *** BashCo_ has quit IRC
1982017-02-14T18:25:09 *** jl2012 has quit IRC
1992017-02-14T18:25:34 *** jl2012_ has joined #bitcoin-core-dev
2002017-02-14T18:26:53 *** jl2012_ is now known as jl2012
2012017-02-14T18:27:42 *** jl2012 has joined #bitcoin-core-dev
2022017-02-14T18:40:27 *** goksinen has quit IRC
2032017-02-14T18:41:02 *** BashCo has joined #bitcoin-core-dev
2042017-02-14T18:42:04 *** goksinen has joined #bitcoin-core-dev
2052017-02-14T18:42:36 *** jannes has quit IRC
2062017-02-14T18:46:01 *** paveljanik has joined #bitcoin-core-dev
2072017-02-14T18:46:02 *** paveljanik has joined #bitcoin-core-dev
2082017-02-14T18:53:50 *** BashCo_ has joined #bitcoin-core-dev
2092017-02-14T18:57:22 *** BashCo has quit IRC
2102017-02-14T18:58:29 *** BashCo has joined #bitcoin-core-dev
2112017-02-14T19:00:05 *** BashCo_ has quit IRC
2122017-02-14T19:09:10 *** sanada has quit IRC
2132017-02-14T19:37:37 *** Sosumi has joined #bitcoin-core-dev
2142017-02-14T19:53:59 *** Ylbam has quit IRC
2152017-02-14T19:55:17 *** nabu has quit IRC
2162017-02-14T20:16:44 *** Kexkey_ has quit IRC
2172017-02-14T20:21:54 *** abpa has quit IRC
2182017-02-14T20:23:20 *** chjj has joined #bitcoin-core-dev
2192017-02-14T20:36:56 *** helo_ is now known as helo
2202017-02-14T20:45:20 *** chjj has quit IRC
2212017-02-14T20:47:58 <luke-jr> jonasschnelli: dunno, maybe
2222017-02-14T20:52:17 <sipa> jonasschnelli: i think the real reason is just histoical
2232017-02-14T20:52:21 <sipa> *historical
2242017-02-14T20:56:22 *** Lightsword has joined #bitcoin-core-dev
2252017-02-14T21:00:38 *** Sosumi has quit IRC
2262017-02-14T21:07:37 *** abpa has joined #bitcoin-core-dev
2272017-02-14T21:11:50 *** Ylbam has joined #bitcoin-core-dev
2282017-02-14T21:19:52 *** abpa has quit IRC
2292017-02-14T22:18:09 *** chjj has joined #bitcoin-core-dev
2302017-02-14T23:58:35 *** lightningbot has joined #bitcoin-core-dev