12017-02-22T01:00:33 *** abpa has quit IRC
22017-02-22T01:33:35 *** AaronvanW has quit IRC
32017-02-22T01:50:11 *** amiller has quit IRC
42017-02-22T01:51:49 *** jtimon has quit IRC
52017-02-22T01:58:48 *** jtimon has joined #bitcoin-core-dev
62017-02-22T02:16:52 *** jtimon has quit IRC
72017-02-22T02:44:00 *** Ylbam has quit IRC
82017-02-22T02:47:04 *** goksinen_ has quit IRC
92017-02-22T02:59:52 *** goksinen has joined #bitcoin-core-dev
102017-02-22T03:07:29 *** goksinen has quit IRC
112017-02-22T03:07:38 *** goksinen has joined #bitcoin-core-dev
122017-02-22T03:08:05 *** Guest47306 has joined #bitcoin-core-dev
132017-02-22T03:08:18 *** Guest47306 has joined #bitcoin-core-dev
142017-02-22T03:08:18 *** Guest47306 is now known as amiller
152017-02-22T03:36:56 *** Victor_sueca has joined #bitcoin-core-dev
162017-02-22T03:39:16 *** Victorsueca has quit IRC
172017-02-22T03:45:51 *** dodomojo has joined #bitcoin-core-dev
182017-02-22T04:00:04 *** dermoth has quit IRC
192017-02-22T04:00:49 *** dermoth has joined #bitcoin-core-dev
202017-02-22T04:35:36 *** dodomojo has quit IRC
212017-02-22T04:35:57 *** shesek has quit IRC
222017-02-22T04:39:31 *** Giszmo has quit IRC
232017-02-22T04:39:54 *** Giszmo has joined #bitcoin-core-dev
242017-02-22T04:52:12 *** chris200_ has joined #bitcoin-core-dev
252017-02-22T04:55:25 *** chris2000 has quit IRC
262017-02-22T04:57:37 *** dgenr8 has quit IRC
272017-02-22T04:58:03 *** dgenr8 has joined #bitcoin-core-dev
282017-02-22T04:58:34 *** Giszmo has quit IRC
292017-02-22T05:00:04 *** dermoth has quit IRC
302017-02-22T05:00:55 *** dermoth has joined #bitcoin-core-dev
312017-02-22T05:22:01 *** d9b4bef9 has quit IRC
322017-02-22T05:23:09 *** d9b4bef9 has joined #bitcoin-core-dev
332017-02-22T06:10:07 *** asoltys has joined #bitcoin-core-dev
342017-02-22T06:24:29 <bitcoin-git> [bitcoin] benma opened pull request #9822: Refactor: Split part of AppInitMain() into a new function (master...appinitmain) https://github.com/bitcoin/bitcoin/pull/9822
352017-02-22T06:45:33 *** city22 has joined #bitcoin-core-dev
362017-02-22T06:59:08 *** chjj has quit IRC
372017-02-22T07:01:36 *** paveljanik has quit IRC
382017-02-22T07:06:39 *** yahtoo has joined #bitcoin-core-dev
392017-02-22T07:09:39 <wumpus> jonasschnelli, others: any idea about OS-specific random API on OSX? I heard about "SecRandom" (https://opensource.apple.com/source/Security/Security-55471/sec/Security/SecRandom.h), is that what should be used?
402017-02-22T07:09:53 <jonasschnelli> wumpus: Yes. That's simple
412017-02-22T07:10:24 <wumpus> will try to add it to #9821. So SecRandomRef can be left NULL?
422017-02-22T07:10:26 <gribble> https://github.com/bitcoin/bitcoin/issues/9821 | util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD by laanwj · Pull Request #9821 · bitcoin/bitcoin · GitHub
432017-02-22T07:11:07 <jonasschnelli> Let me look at it...
442017-02-22T07:11:15 <jonasschnelli> I know there are other projects that already did this
452017-02-22T07:13:03 <sipa> that's a psuedo random number
462017-02-22T07:13:12 <sipa> i believe we're looking for a pseudo random number!
472017-02-22T07:13:51 <wumpus> kSecRandomDefault
482017-02-22T07:14:32 <sipa> defining a new name for NULL through an external symbol?
492017-02-22T07:14:34 <wumpus> very random, just happens to have all the bits turned off every time
502017-02-22T07:14:46 <sipa> that's pretty inefficient!
512017-02-22T07:14:46 <jonasschnelli> @function SecRandomCopyBytes
522017-02-22T07:14:47 <jonasschnelli> @abstract Return count random bytes in *bytes, allocated by the caller.
532017-02-22T07:14:47 <jonasschnelli> It is critical to check the return value for error
542017-02-22T07:15:08 <jonasschnelli> "Generates an array of cryptographically secure random bytes"
552017-02-22T07:15:16 <jonasschnelli> IMO SecRandomCopyBytes is CPRNG
562017-02-22T07:15:31 <wumpus> it's inefficient, though that is not really our worry here, this is the slow path
572017-02-22T07:15:52 *** whphhg has quit IRC
582017-02-22T07:16:04 <jonasschnelli> I think this is the way to go: "if (SecRandomCopyBytes(kSecRandomDefault, entropy.length, entropy.mutableBytes) != 0) return nil;"
592017-02-22T07:16:09 <wumpus> jonasschnelli: I guess MacOSX also supports the sysctl(ARND), inherited from NetBSD?
602017-02-22T07:16:55 <jonasschnelli> Yes. I think so. But not sure which makes more sense. Maybe add entropy from both?
612017-02-22T07:17:07 *** lclc has joined #bitcoin-core-dev
622017-02-22T07:17:50 <jonasschnelli> I quickly check what apples recommends (that doesn't say it the solution we should go()
632017-02-22T07:18:08 <wumpus> I'd like to keep the GetOSRandom abtraction simple - just get random from the OS, whatever a good option is for that OS. Combining shouldn't make sense there
642017-02-22T07:19:51 <wumpus> an alternative way of going about this would be to check all randomness sources that are available , and somehow call all of them every time and combine them, but I'm not sure whether that's voodoo coding or sensible paranoia
652017-02-22T07:20:29 <wumpus> and note we already combine the output with randomness from other sources in an outer function
662017-02-22T07:22:51 <jonasschnelli> wumpus: has the idea with using fortuna for mixing all sorts of entropy died?
672017-02-22T07:23:03 <wumpus> using the MacOSX API doesn't mean anything scary like using objective c++ does it? all the examples I see have NSLog and NSMutableString etc in them
682017-02-22T07:23:13 <jonasschnelli> No. It's pure C
692017-02-22T07:23:31 <jonasschnelli> You need to link against the Security.frameowkr
702017-02-22T07:23:36 <jonasschnelli> T
712017-02-22T07:23:43 <jonasschnelli> We already link against other framework...
722017-02-22T07:23:50 <wumpus> jonasschnelli: I don't know, but I don't see a reason to combine multiple random streams coming from the OS and portrayed as cryptographic APIs
732017-02-22T07:24:20 *** whphhg has joined #bitcoin-core-dev
742017-02-22T07:24:26 <jonasschnelli> wumpus: I think the only reason could be if you are enough paranoid. :)
752017-02-22T07:24:54 <jonasschnelli> What speaks against using /dev/(u)random on OSX? Concurrency? It would be the simplest approach?
762017-02-22T07:25:07 <jonasschnelli> Apples states that /dev/random is CPRNG
772017-02-22T07:25:11 <wumpus> we already use /dev/urandom
782017-02-22T07:25:30 <jonasschnelli> wumpus: So SecRandomCopyBytes would give additional entrtopy?
792017-02-22T07:25:38 <wumpus> and that will remain the fallback if nothing else is availalbe, however in sandboxes it's not always available
802017-02-22T07:26:06 <wumpus> that was what prompted this, not 'we don't trust /dev/urandom'
812017-02-22T07:27:50 <wumpus> e.g. user created containers and chroots won't have the /dev/urandom device, some sandboxes (such as cluodabi/capsicum) don' t have file access at all (not that we can support those at the moment in bitcoin core). Direct system calls are the new way to get randomness from the OS.
822017-02-22T07:29:06 <jonasschnelli> Apples says "This function reads from /dev/random to obtain an array of cryptographically-secure random bytes" about SecRandomCopyBytes
832017-02-22T07:29:18 <wumpus> lol. okay, so it won't help :)
842017-02-22T07:29:19 <jonasschnelli> Not sure what internal fallback mechanisms are provided
852017-02-22T07:29:29 <jonasschnelli> I think that part is closed source
862017-02-22T07:29:30 <wumpus> thanks for looking that up, that's very useful information
872017-02-22T07:30:06 <jonasschnelli> Heres to code: https://opensource.apple.com/source/Security/Security-55179.11/sec/Security/SecFramework.c
882017-02-22T07:30:56 <jonasschnelli> And yes. It reads from /dev/random :)
892017-02-22T07:31:17 <jonasschnelli> If that's not available, it returns 0.
902017-02-22T07:31:21 <wumpus> yup. So going through all the trouble to link another framework and calling it isn't worth it
912017-02-22T07:31:27 <jonasschnelli> Yes.
922017-02-22T07:33:01 <cfields> er, i don't think we link in frameworks for bitcoind do we?
932017-02-22T07:33:11 <cfields> (seems the point's moot anyway now, though)
942017-02-22T07:34:30 *** yahtoo has quit IRC
952017-02-22T07:35:35 *** Victor_sueca is now known as Victorsueca
962017-02-22T07:36:32 *** whphhg has quit IRC
972017-02-22T07:36:45 <jonasschnelli> cfields: Good point. I guess only for the Qt parts.
982017-02-22T07:36:57 <wumpus> a different thing I noticed is that our code is opening and closing the /dev/urandom device every call to GetOSRand. Nothing wrong with that in itself, though reserving a fd for it would mean it's always available.
992017-02-22T07:38:02 <jonasschnelli> I wonder if it would make more sense to have the random
1002017-02-22T07:38:06 <jonasschnelli> ...
1012017-02-22T07:38:13 <jonasschnelli> the randomness thins abstracted into a library...
1022017-02-22T07:38:27 <jonasschnelli> I think there are lots of other application that also wants to deal with this without openssl
1032017-02-22T07:38:33 <wumpus> well it's abstracted to random.o now :-)
1042017-02-22T07:38:48 *** jnewbery has quit IRC
1052017-02-22T07:38:59 <wumpus> which is sort of a one-file randomness library. Idon't think it depends on any bitcoin specific things
1062017-02-22T07:39:01 <jonasschnelli> Hah. indeed. What are the dependencies?
1072017-02-22T07:39:03 <luke-jr> jonasschnelli: gnutls? :P
1082017-02-22T07:39:12 * jonasschnelli stabs luke-jr
1092017-02-22T07:40:57 <jonasschnelli> my testnet dns seeder will be down for a couple of hours (moving location)
1102017-02-22T07:44:35 *** BashCo has quit IRC
1112017-02-22T07:45:05 <wumpus> ok, thanks for letting us know
1122017-02-22T07:57:50 <jonasschnelli> Does anyone know how I can avoid sudo password prompt in gbuild using LXC? I have added /usr/bin/lxc-start and execute to sudoers (nopassword)
1132017-02-22T07:59:10 <Victorsueca> sudo -i ?
1142017-02-22T07:59:34 <luke-jr> jonasschnelli: check syslog
1152017-02-22T07:59:35 <wumpus> to have passwordless sudo you need to edit sudoers, you can either make all sudo use passwordless or specific commands
1162017-02-22T07:59:55 <wumpus> I don't know the syntax by heart, though. Always have to look at up (and fail at leat three times at it)
1172017-02-22T07:59:56 <jonasschnelli> But why does gbuild require root?
1182017-02-22T07:59:58 <luke-jr> also, some distros have non-root LXC now
1192017-02-22T08:00:09 <luke-jr> because LXC historically has required root
1202017-02-22T08:00:18 <wumpus> jonasschnelli: spinning up a fully featured LXC container requires root
1212017-02-22T08:00:32 <jonasschnelli> okay... I see.
1222017-02-22T08:00:46 <wumpus> this is because the user creating the LXC container will be root in the container (without capabilities), which can be somewhat dangerous if there are security bugs in the kernel
1232017-02-22T08:01:01 <luke-jr> (which there have been)
1242017-02-22T08:01:29 <wumpus> and indeed as luke-jr says it is possible on more recent kernels to create a user LXC, but these have a few restrictions which I'm fairly sure we can't cope with right now
1252017-02-22T08:01:36 <jonasschnelli> it's not just lxc-start and lxc-execute that requires root?
1262017-02-22T08:01:59 <wumpus> it's just those no
1272017-02-22T08:02:06 <wumpus> no->two
1282017-02-22T08:02:10 <wumpus> maybe only lxc-execute
1292017-02-22T08:02:38 <wumpus> not sure. I think there's an example of editing your sudoers file to allow this in gitian-building?
1302017-02-22T08:02:49 <jonasschnelli> Yes. I have set those... still got the sudo promot
1312017-02-22T08:03:34 <jonasschnelli> Ah! Wrong machine... damit
1322017-02-22T08:03:51 <jonasschnelli> Can we have different shell background colors per host?!
1332017-02-22T08:04:01 <wumpus> jonasschnelli: I have different prompt colors per host
1342017-02-22T08:04:11 <wumpus> (even a script to randomly generate them :-)
1352017-02-22T08:04:17 <jonasschnelli> wumpus: That is very clever... I need to do this as well...
1362017-02-22T08:04:54 *** BashCo has joined #bitcoin-core-dev
1372017-02-22T08:05:52 <wumpus> https://gist.github.com/laanwj/3c8c116fc763a149842a07070ca4d6cd
1382017-02-22T08:06:08 <jonasschnelli> wumpus: thanks!
1392017-02-22T08:06:47 <wumpus> setting terminal background is more involved; you can set it with the same escape sequences, however many programs will reset the background
1402017-02-22T08:07:38 <jonasschnelli> I think the background switch should be done on the client side... but the prompt is good enought
1412017-02-22T08:08:06 <wumpus> fairly sure tmux and some terminal emulators such as gnome=terminal have the option of having different profiles, so you could e.g. launch a different profile before ssh'ing. But yeah too much hassle
1422017-02-22T08:08:25 <luke-jr> deterministic generation might be more useful
1432017-02-22T08:08:44 <wumpus> KDE term had/has a nice feature where you could set an icon for the tab too
1442017-02-22T08:09:04 <wumpus> luke-jr: but some combinations are ugly, so I determine them once when setting up the host then just write that into ~/.profile
1452017-02-22T08:09:32 <luke-jr> too bad there's not a nice way to have it colour differently for local vs remote
1462017-02-22T08:11:29 <wumpus> yes I started doing this consistently after shutting down the wrong host one time too many :-)
1472017-02-22T08:12:12 <luke-jr> I disabled the rm command for root, and alias'd it with -i for my normal user :p
1482017-02-22T08:12:49 <wumpus> that's a good idea. Some historical UNIXes had that as default IIRC
1492017-02-22T08:13:10 <wumpus> well the -i thing. Don't know about disabling rm completely
1502017-02-22T08:25:54 *** Lauda has joined #bitcoin-core-dev
1512017-02-22T08:29:26 <Victorsueca> is there going to be a 0.14.0rc2 or is the rc1 definitive so far unless a critical issue appears in the wild?
1522017-02-22T08:29:41 <wumpus> there have already been some issues to warrant rc2
1532017-02-22T08:30:11 <wumpus> for example #9810
1542017-02-22T08:30:12 <gribble> https://github.com/bitcoin/bitcoin/issues/9810 | 0.14 not loading mempool.dat? · Issue #9810 · bitcoin/bitcoin · GitHub
1552017-02-22T08:32:25 <jonasschnelli> Gitian does by default avoid recompiling the dependencies on every build? Right?
1562017-02-22T08:32:25 <wumpus> and #9817
1572017-02-22T08:32:27 <gribble> https://github.com/bitcoin/bitcoin/issues/9817 | Fix segfault crash when shutdown the GUI in disablewallet mode by jonasschnelli · Pull Request #9817 · bitcoin/bitcoin · GitHub
1582017-02-22T08:32:43 <wumpus> jonasschnelli: yes, the dependency caching system should make sure of that
1592017-02-22T08:33:08 <Victorsueca> ahh how not, it had to be yet another thing windows copied and changed slightly to make it incompatible
1602017-02-22T08:33:09 <wumpus> it will recompile if either the dependency definitions changed, or the compilation environment changed
1612017-02-22T08:33:16 <Victorsueca> such CRLF
1622017-02-22T08:33:25 <jonasschnelli> I wonder why that crash (https://github.com/bitcoin/bitcoin/issues/9814) happens
1632017-02-22T08:33:27 <wumpus> Victorsueca: yep :/ the DOS legacy in this case
1642017-02-22T08:34:29 <wumpus> jonasschnelli: yes it's weird
1652017-02-22T08:35:21 <wumpus> jonasschnelli: it happens deep in the bowels of qt, in the X platform handling
1662017-02-22T08:35:32 <jonasschnelli> Yes. Looks like.
1672017-02-22T08:36:13 <jonasschnelli> I wonder if he would get the same crashed building 0.13.1 (I would say so).
1682017-02-22T08:36:20 <jonasschnelli> *crashes
1692017-02-22T08:36:38 <wumpus> jonasschnelli: weird. it looks like both Thread 1 and Thread 2 are in libqxcb.so
1702017-02-22T08:37:05 <wumpus> is some auxiliary thread trying to do rendering / change the GUI?
1712017-02-22T08:38:01 <wumpus> ok on the other hand this is just "xcb_wait_for_event" so probably this is just the event loop
1722017-02-22T08:38:16 <wumpus> no, doesn't seem worrying
1732017-02-22T08:40:37 <wumpus> the traceback of Thread 1 is completely Qt and upstream libraries - none of our own code
1742017-02-22T08:40:39 <jonasschnelli> wumpus: I can't find any link between the crash(es) and our code in both stack traces
1752017-02-22T08:40:56 <jonasschnelli> I think we should recommend to try to compile against a different Qt version
1762017-02-22T08:41:07 <wumpus> thread 1 is the GUI thread so should be the only one that matters here
1772017-02-22T08:41:42 <wumpus> so this is either a race with cleaning up objects (deleteLater or such), or something in Qt/X11 itself. I suspect the second as it happens in the X library not in Qt.
1782017-02-22T08:42:37 <wumpus> cfields: didn't we have some scary xcb compatibility issues before?
1792017-02-22T08:43:02 <cfields> wumpus: heh, i was just clicking the above link with the same thought
1802017-02-22T08:43:11 <cfields> wumpus: only applies to static qt builds
1812017-02-22T08:43:28 <cfields> (it's qt's internal x stubs that cause that issue)
1822017-02-22T08:44:51 <cfields> it's possible that qt manages to crash there in some ugly way if there's no display plugin available, though
1832017-02-22T08:46:21 <cfields> (i haven't read the logs yet, if bitcoin-qt launches at all obviously that's not the culprit)
1842017-02-22T08:46:52 *** chjj has joined #bitcoin-core-dev
1852017-02-22T08:48:06 <cfields> wumpus: there was a touchscreen bug like that that rings a bell, though
1862017-02-22T08:48:24 <cfields> wacom, iirc
1872017-02-22T08:51:53 *** wvr has quit IRC
1882017-02-22T08:53:05 <cfields> headed to bed, nnite
1892017-02-22T09:01:20 *** mol has quit IRC
1902017-02-22T09:11:35 *** JackH has joined #bitcoin-core-dev
1912017-02-22T09:13:31 *** jannes has joined #bitcoin-core-dev
1922017-02-22T09:17:38 *** Ylbam has joined #bitcoin-core-dev
1932017-02-22T09:50:59 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9823: qa: Set correct path for binaries in rpc tests (master...Mf1702-qaPath) https://github.com/bitcoin/bitcoin/pull/9823
1942017-02-22T10:05:20 *** chjj has quit IRC
1952017-02-22T10:08:09 *** chjj has joined #bitcoin-core-dev
1962017-02-22T10:18:41 <jonasschnelli> wumpus: F.Y.I: "%sudo ALL=NOPASSWD: /usr/bin/lxc-execute" hasn't worked for me... I had to allow it per user "jonasschnelli ALL=NOPASSWD:/usr/bin/lxc-execute".
1972017-02-22T10:19:58 <wumpus> strange. It does seem to be the right syntax
1982017-02-22T10:20:14 <jonasschnelli> The goup or per user line?
1992017-02-22T10:20:32 <wumpus> oh, you're not in the sudo group?
2002017-02-22T10:20:51 <wumpus> both
2012017-02-22T10:20:56 <jonasschnelli> Ah... yes.. that could be the issue.. :)
2022017-02-22T10:22:14 <jonasschnelli> Do I need to assign the LXC container specific amount of ram? Or does it share it with the host?
2032017-02-22T10:22:24 <jonasschnelli> I try now -j5
2042017-02-22T10:22:34 * jonasschnelli needs to go afk
2052017-02-22T10:23:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #9824: qa: Check return code when stopping nodes (master...Mf1702-qaRet) https://github.com/bitcoin/bitcoin/pull/9824
2062017-02-22T10:23:35 *** city22 has quit IRC
2072017-02-22T10:26:09 <wumpus> jonasschnelli: LXC limits work in a different way, I've never set any at least
2082017-02-22T10:27:33 <MarcoFalke> wumpus: Can you add jnewbery_ to the list of members on github?
2092017-02-22T10:28:05 <MarcoFalke> Maybe also ryanofsky
2102017-02-22T10:28:26 <wumpus> yes, good idea
2112017-02-22T10:31:25 <wumpus> ok invited both to bitcoin and bitcoin-core
2122017-02-22T10:33:34 *** AaronvanW has joined #bitcoin-core-dev
2132017-02-22T10:35:43 <wumpus> re: release notes, would it make sense to group the two qt debug console changes?
2142017-02-22T10:36:36 *** chjj has quit IRC
2152017-02-22T10:36:53 *** laurentmt has joined #bitcoin-core-dev
2162017-02-22T10:37:05 <wumpus> I mena "Nested RPC Commands in Debug Console" and "Sensitive Data Is No Longer Stored In Debug Console History"
2172017-02-22T10:37:16 <wumpus> we also have "GUI Changes"
2182017-02-22T10:37:48 *** laurentmt has quit IRC
2192017-02-22T10:38:17 <Victorsueca> that's a nice thing, I used to CTRL+L after typing sensitive data
2202017-02-22T10:42:25 *** Guyver2 has joined #bitcoin-core-dev
2212017-02-22T10:42:38 <wumpus> yes, it's certainly a nice thing, it's just spread out a bit haphazardly
2222017-02-22T10:42:41 <wumpus> in the release notes
2232017-02-22T10:49:18 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5628c70f2a44...92dd6c8dfdd6
2242017-02-22T10:49:19 <bitcoin-git> bitcoin/master a87d02a Marko Bencun: use EXIT_ codes instead of magic numbers...
2252017-02-22T10:49:19 <bitcoin-git> bitcoin/master 92dd6c8 Wladimir J. van der Laan: Merge #9815: Trivial: use EXIT_ codes instead of magic numbers...
2262017-02-22T10:49:42 <bitcoin-git> [bitcoin] laanwj closed pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (master...exitcode) https://github.com/bitcoin/bitcoin/pull/9815
2272017-02-22T10:52:10 *** chjj_ has joined #bitcoin-core-dev
2282017-02-22T11:09:45 *** lclc has quit IRC
2292017-02-22T11:12:02 *** d9b4bef9 has quit IRC
2302017-02-22T11:13:07 *** d9b4bef9 has joined #bitcoin-core-dev
2312017-02-22T11:14:58 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/92dd6c8dfdd6...5b583efaa721
2322017-02-22T11:14:58 <bitcoin-git> bitcoin/master 3b4dd2a Peter Todd: Add seed.btc.petertodd.org to mainnet DNS seeds
2332017-02-22T11:14:59 <bitcoin-git> bitcoin/master 5b583ef Wladimir J. van der Laan: Merge #9805: Add seed.btc.petertodd.org to mainnet DNS seeds...
2342017-02-22T11:15:24 <bitcoin-git> [bitcoin] laanwj closed pull request #9805: Add seed.btc.petertodd.org to mainnet DNS seeds (master...2017-02-add-pt-mainnet-seed) https://github.com/bitcoin/bitcoin/pull/9805
2352017-02-22T11:18:59 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5b583efaa721...a8c575103815
2362017-02-22T11:18:59 <bitcoin-git> bitcoin/master eaea2bb gubatron: Removed redundant parameter from mempool.PrioritiseTransaction...
2372017-02-22T11:19:00 <bitcoin-git> bitcoin/master a8c5751 Wladimir J. van der Laan: Merge #9801: Removed redundant parameter from mempool.PrioritiseTransaction...
2382017-02-22T11:19:18 <bitcoin-git> [bitcoin] laanwj closed pull request #9801: Removed redundant parameter from mempool.PrioritiseTransaction (master...refactor-mempool-prioritisetx) https://github.com/bitcoin/bitcoin/pull/9801
2392017-02-22T11:43:30 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a8c575103815...ba7220b5e82f
2402017-02-22T11:43:30 <bitcoin-git> bitcoin/master e2e2f4c Russell Yanofsky: Return errors from importmulti if complete rescans are not successful
2412017-02-22T11:43:31 <bitcoin-git> bitcoin/master ba7220b Wladimir J. van der Laan: Merge #9773: Return errors from importmulti if complete rescans are not successful...
2422017-02-22T11:43:51 <bitcoin-git> [bitcoin] laanwj closed pull request #9773: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773
2432017-02-22T11:49:53 *** dodomojo has joined #bitcoin-core-dev
2442017-02-22T11:59:29 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/9072395e5fddb1f2590138a179ab0868646a38a0
2452017-02-22T11:59:30 <bitcoin-git> bitcoin/0.14 9072395 Russell Yanofsky: Return errors from importmulti if complete rescans are not successful...
2462017-02-22T11:59:45 *** lclc has joined #bitcoin-core-dev
2472017-02-22T12:02:15 *** chjj_ has quit IRC
2482017-02-22T12:02:32 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ba7220b5e82f...1efc99c4dc4d
2492017-02-22T12:02:33 <bitcoin-git> bitcoin/master bc8fd12 Alex Morcos: Remove harmless read of unusued priority estimates
2502017-02-22T12:02:33 <bitcoin-git> bitcoin/master 1efc99c Wladimir J. van der Laan: Merge #9819: Remove harmless read of unusued priority estimates...
2512017-02-22T12:02:52 <bitcoin-git> [bitcoin] laanwj closed pull request #9819: Remove harmless read of unusued priority estimates (master...removeExtraRead) https://github.com/bitcoin/bitcoin/pull/9819
2522017-02-22T12:04:04 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1efc99c4dc4d...bed5b30a5622
2532017-02-22T12:04:04 <bitcoin-git> bitcoin/master 9949ebf John Newbery: [Trivial] Remove incorrect help message from gettxoutproof()
2542017-02-22T12:04:05 <bitcoin-git> bitcoin/master bed5b30 Wladimir J. van der Laan: Merge #9711: [Trivial] Remove incorrect help message from gettxoutproof()...
2552017-02-22T12:04:21 <bitcoin-git> [bitcoin] laanwj closed pull request #9711: [Trivial] Remove incorrect help message from gettxoutproof() (master...gettxoutproofhelp) https://github.com/bitcoin/bitcoin/pull/9711
2562017-02-22T12:18:15 *** vicenteH has joined #bitcoin-core-dev
2572017-02-22T12:19:05 *** dodomojo has quit IRC
2582017-02-22T12:27:58 *** wvr has joined #bitcoin-core-dev
2592017-02-22T12:35:44 *** marcoagner has joined #bitcoin-core-dev
2602017-02-22T12:37:37 *** nOgAnOo has quit IRC
2612017-02-22T12:37:38 *** pindarhk has quit IRC
2622017-02-22T12:38:53 *** mariorz has quit IRC
2632017-02-22T12:39:21 *** pindarhk has joined #bitcoin-core-dev
2642017-02-22T12:40:40 *** marcoagner has quit IRC
2652017-02-22T12:40:55 *** mariorz has joined #bitcoin-core-dev
2662017-02-22T13:04:37 *** xHire has quit IRC
2672017-02-22T13:04:37 *** Cory has quit IRC
2682017-02-22T13:05:31 *** xHire has joined #bitcoin-core-dev
2692017-02-22T13:07:12 *** Pasha has joined #bitcoin-core-dev
2702017-02-22T13:13:38 *** btcdrak has quit IRC
2712017-02-22T13:14:08 *** Pasha is now known as Cory
2722017-02-22T13:14:30 *** btcdrak has joined #bitcoin-core-dev
2732017-02-22T13:35:20 *** pindarhk has quit IRC
2742017-02-22T13:35:41 *** pindarhk has joined #bitcoin-core-dev
2752017-02-22T13:36:46 *** aguycalled has joined #bitcoin-core-dev
2762017-02-22T13:36:47 *** pindarhk has quit IRC
2772017-02-22T13:36:48 *** pindarhk has joined #bitcoin-core-dev
2782017-02-22T13:40:12 *** aguycalled has quit IRC
2792017-02-22T13:40:14 *** jnewbery_ has quit IRC
2802017-02-22T13:40:43 *** aguycalled has joined #bitcoin-core-dev
2812017-02-22T13:41:07 *** jnewbery has joined #bitcoin-core-dev
2822017-02-22T13:41:49 *** whphhg has joined #bitcoin-core-dev
2832017-02-22T13:58:11 *** Giszmo has joined #bitcoin-core-dev
2842017-02-22T13:59:25 *** chjj_ has joined #bitcoin-core-dev
2852017-02-22T14:02:16 *** Alina-malina_ has joined #bitcoin-core-dev
2862017-02-22T14:05:18 *** moli_ has joined #bitcoin-core-dev
2872017-02-22T14:05:25 *** Alina-malina_ has quit IRC
2882017-02-22T14:05:25 *** Alina-malina_ has joined #bitcoin-core-dev
2892017-02-22T14:05:32 *** BashCo_ has joined #bitcoin-core-dev
2902017-02-22T14:06:08 *** Alina-malina has quit IRC
2912017-02-22T14:06:15 *** Alina-malina_ is now known as Alina-malina
2922017-02-22T14:06:40 *** Guest42592 has quit IRC
2932017-02-22T14:08:56 *** chjj_ has quit IRC
2942017-02-22T14:09:22 *** BashCo has quit IRC
2952017-02-22T14:09:30 *** chjj_ has joined #bitcoin-core-dev
2962017-02-22T14:10:58 *** aguycalled has quit IRC
2972017-02-22T14:13:36 *** lclc has quit IRC
2982017-02-22T14:15:57 *** aguycalled has joined #bitcoin-core-dev
2992017-02-22T14:15:58 *** abhishekcs10_ has joined #bitcoin-core-dev
3002017-02-22T14:16:15 <abhishekcs10_> Hello everyone :)
3012017-02-22T14:16:51 <abhishekcs10_> I am new to bitcoin and eager to learn about it.
3022017-02-22T14:19:37 *** lopp has joined #bitcoin-core-dev
3032017-02-22T14:20:51 <lopp> I recently pulled down the changes for Bitcoin Core 0.14 into my Statoshi fork, but one of the metrics is no longer populating and I'm hoping someone can explain if this is by design or if I screwed up
3042017-02-22T14:21:22 <lopp> the specific metric is the "block" inv message (MSG_BLOCK) that I'm populating here: https://github.com/jlopp/statoshi/blob/master/src/net_processing.cpp#L1571
3052017-02-22T14:21:52 <lopp> the "MSG_TX" inv type metric is populating fine (several lines earlier)
3062017-02-22T14:21:54 *** aguycalled has quit IRC
3072017-02-22T14:22:02 <abhishekcs10_> I am having problem understanding following parameters in bitcoin/src/chainparams.cpp
3082017-02-22T14:22:21 <abhishekcs10_> https://www.irccloud.com/pastebin/vVGQDoUJ
3092017-02-22T14:34:08 *** jlopp has joined #bitcoin-core-dev
3102017-02-22T14:34:24 *** nOgAnOo has joined #bitcoin-core-dev
3112017-02-22T14:36:40 *** chjj_ has quit IRC
3122017-02-22T14:49:33 <abhishekcs10_> How can I edit interblock timing
3132017-02-22T14:50:33 <abhishekcs10_> Eg. Setting it to 1min retargetted every 5min
3142017-02-22T14:54:26 *** city22 has joined #bitcoin-core-dev
3152017-02-22T14:55:55 *** lclc has joined #bitcoin-core-dev
3162017-02-22T15:14:39 <sdaftuar> lopp: i'm guessing that is because your peers are using headers or cmpctblocks to announce new blocks, rather than inv's
3172017-02-22T15:15:14 <sdaftuar> lopp: if all your peers or 0.12 or later - i think? - then it's unlikely you'll get block invs, except in rare cases
3182017-02-22T15:15:24 <sdaftuar> maybe 0.11 or later
3192017-02-22T15:15:43 <jlopp> OK I figured it was likely due to protocol changes; my test node is behind a NAT that I don't port forward so it only has 8 peers
3202017-02-22T15:16:22 <jlopp> I'll double check the peer versions
3212017-02-22T15:16:24 <sdaftuar> oh yep that will do it then
3222017-02-22T15:16:44 <sdaftuar> we have preferential peering logic that will make it unlikely for you to connect outbound to older peers (in preparation for segwit)
3232017-02-22T15:16:52 <jlopp> ahhh
3242017-02-22T15:17:12 <sdaftuar> so most likely all your peers are 0.13.1 or later
3252017-02-22T15:19:49 <lopp> @sdaftuar confirmed; they're all 0.13.1+
3262017-02-22T15:44:01 *** chjj_ has joined #bitcoin-core-dev
3272017-02-22T15:49:16 *** udiWertheimer has joined #bitcoin-core-dev
3282017-02-22T16:00:42 *** jlopp has quit IRC
3292017-02-22T16:02:15 *** lclc has quit IRC
3302017-02-22T16:12:29 *** paveljanik has joined #bitcoin-core-dev
3312017-02-22T16:22:16 *** BashCo_ has quit IRC
3322017-02-22T16:38:39 *** senior has joined #bitcoin-core-dev
3332017-02-22T16:38:40 *** senior is now known as Guest82394
3342017-02-22T16:39:41 *** BashCo has joined #bitcoin-core-dev
3352017-02-22T16:53:43 *** abpa has joined #bitcoin-core-dev
3362017-02-22T16:59:45 *** udiWertheimer has quit IRC
3372017-02-22T16:59:45 *** city22 has quit IRC
3382017-02-22T17:36:22 *** abhishekcs10_ has quit IRC
3392017-02-22T17:40:57 *** udiWertheimer has joined #bitcoin-core-dev
3402017-02-22T17:47:52 * BlueMatt . Now providing RaaS
3412017-02-22T17:47:59 <BlueMatt> Review as a Service, that is
3422017-02-22T17:48:24 <BlueMatt> in exchange for review of #9725
3432017-02-22T17:48:32 <gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
3442017-02-22T17:51:20 *** lopp has quit IRC
3452017-02-22T17:52:28 *** jnewbery has quit IRC
3462017-02-22T17:57:01 *** jnewbery has joined #bitcoin-core-dev
3472017-02-22T18:12:17 *** tripleslash has joined #bitcoin-core-dev
3482017-02-22T18:30:01 *** jtimon has joined #bitcoin-core-dev
3492017-02-22T18:31:10 * luke-jr peers at https://testnet.smartbit.com.au/tx/ecb710d1cc86487dbdb3f24b893e7c1d3bb98290097f0f0600c32aaa13312e00
3502017-02-22T18:34:15 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9827: Improve ScanForWalletTransactions return value (master...pr/scanret) https://github.com/bitcoin/bitcoin/pull/9827
3512017-02-22T18:50:10 <luke-jr> fun, left my CTableView bitcoin tx log overnight and no substantial memory usage growth. :D
3522017-02-22T18:50:51 <luke-jr> (I haven't implemented a limit to the log yet, but set it up to use only weak_ptrs)
3532017-02-22T18:51:38 <luke-jr> thinking of making it use maybe 500 lines of non-weak ptrs, and up to 10000 lines of weak_ptrs, or something
3542017-02-22T19:17:19 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9828: Avoid -Wshadow warnings in wallet_tests (master...pr/multishadow) https://github.com/bitcoin/bitcoin/pull/9828
3552017-02-22T19:28:12 *** laurentmt has joined #bitcoin-core-dev
3562017-02-22T19:58:45 *** moli_ has quit IRC
3572017-02-22T19:59:04 *** moli_ has joined #bitcoin-core-dev
3582017-02-22T20:02:49 *** laurentmt has quit IRC
3592017-02-22T20:05:19 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9829: Fix importmulti returning rescan errors for wrong keys (master...pr/multiinc) https://github.com/bitcoin/bitcoin/pull/9829
3602017-02-22T20:21:45 *** shesek has joined #bitcoin-core-dev
3612017-02-22T20:23:08 *** GAit has quit IRC
3622017-02-22T20:23:42 *** GAit has joined #bitcoin-core-dev
3632017-02-22T20:32:17 *** jtimon has quit IRC
3642017-02-22T20:52:36 *** Chris_Stewart_5 has quit IRC
3652017-02-22T21:08:39 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3662017-02-22T21:14:01 *** Ylbam has quit IRC
3672017-02-22T21:21:21 *** Chris_Stewart_5 has quit IRC
3682017-02-22T21:21:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3692017-02-22T21:33:18 *** jtimon has joined #bitcoin-core-dev
3702017-02-22T21:33:28 *** Guyver2 has quit IRC
3712017-02-22T21:35:24 <jtimon> mhmm, in rpcwallet and rpcdump, ensure EnsureWalletIsAvailable( is called before showing the help. if the user selected help but the wallet is not available, the function will return NullUniValue instead of actually showing the help
3722017-02-22T21:35:31 <jtimon> is this the desired behaviour?
3732017-02-22T21:35:53 <jtimon> it seems not, and it's simple to fix
3742017-02-22T21:42:00 <warren> I used linearize-data.py to generate in-order *.blk files. I want to make the very deep historical blocks read-only at the filesystem level and hard-linked into the blocks/ directory to be used by multiple separate instances of bitcoind on the same machine. It seems that bitcoind currently requires opening all *.blk files as writable so it is incompatible with this use case. http://pastebin.com/DMUcTJuT debug.log and relevant parts of b
3752017-02-22T21:42:01 <warren> itcoind source.
3762017-02-22T21:42:37 <warren> I could make a temporary hack for myself, but is there any reason to not support this in the future?
3772017-02-22T21:46:01 *** Ylbam has joined #bitcoin-core-dev
3782017-02-22T22:09:09 <luke-jr> jtimon: it's the intended behaviour, presumably so -wallet=0 behaves the same as if it was compiled without
3792017-02-22T22:09:54 <luke-jr> (I don't mind if someone changes it though)
3802017-02-22T22:18:02 <warren> oh, *.dat files
3812017-02-22T22:18:14 <warren> blk*.dat
3822017-02-22T22:33:24 *** neha has quit IRC
3832017-02-22T22:44:00 <jtimon> luke-jr: I see, the other 2 options would be to either throw the error even if fHelp is true, or show the help even if the wallet is not available
3842017-02-22T22:45:26 <luke-jr> wouldn't throwing an error break `help`?
3852017-02-22T22:56:22 *** neha has joined #bitcoin-core-dev
3862017-02-22T23:01:56 *** tussssss has joined #bitcoin-core-dev
3872017-02-22T23:02:07 <tussssss> Buy/Sell ( Bitcoin - Perfect money - webmoney - western union - moneygram - skrill - neteller ) & giftcards/prepaids ( llike amazon-ebay etc... ) Contact Skype : rodrige.amin ICQ : 690490649
3882017-02-22T23:02:11 *** tussssss has quit IRC
3892017-02-22T23:19:23 <jtimon> luke-jr: help is already broken if the wallet is not available
3902017-02-22T23:19:42 <jtimon> why are all these functions declared as extern? https://github.com/bitcoin/bitcoin/blob/master/src/rpc/server.h#L188
3912017-02-22T23:20:31 <luke-jr> jtimon: is it? :/
3922017-02-22T23:22:24 <jtimon> luke-jr: if the wallet is not available, the function returns NullUniValue before having the opportunity to check if (fHelp || params.size() < 2 || params.size() > 6) (well, of course the exact check depends on the function)
3932017-02-22T23:23:19 <luke-jr> jtimon: and `help` upon getting null just skips it, no?
3942017-02-22T23:23:43 <jtimon> my preferred behaviour would be to only check if the wallet is available after checking if it should show the help, and when doing so, if it's not available just throw the error as if fHelp was false
3952017-02-22T23:24:55 <jtimon> luke-jr: no, if fHelp=false, it returns false, EnsureWalletIsAvailable() returns false instead of throwing the error, thus the calling function returns NullUniValue before having the chance to check if the help should be shown
3962017-02-22T23:25:33 <jtimon> I guess I'll just write my prefferred fix and see what people think
3972017-02-22T23:25:35 <luke-jr> jtimon: â¦
3982017-02-22T23:25:47 <luke-jr> jtimon: foomethod() returns null to help(), which just skips foomethod
3992017-02-22T23:26:23 <jtimon> what help() function ?
4002017-02-22T23:26:32 <luke-jr> rpc/server.cpp
4012017-02-22T23:26:39 <luke-jr> std::string CRPCTable::help(const std::string& strCommand) const
4022017-02-22T23:27:57 <jtimon> oh, no I don't mean the general help, I mean the help for a specific rpc call (or when you have an invalid number of parameters for that call)
4032017-02-22T23:28:14 <jtimon> but let me read that method...
4042017-02-22T23:30:16 <jtimon> I see, yeah, that's the point of returning null instead of launching the error or giving it the opportunity to get the help first
4052017-02-22T23:30:23 <luke-jr> fHelp is only ever true via that method
4062017-02-22T23:38:12 <jtimon> mhmm, if I start the deamon with -wallet=0 and then with the client do sendtoaddress --help it shows the doc...
4072017-02-22T23:39:18 <jtimon> how can I make pwalletMain=NULL ?
4082017-02-22T23:41:50 <jtimon> btw, IIRC we talked before about moving the rpc wallet stuff from BTC to satoshis, but it breaks the interface. Are we decided to never do that?
4092017-02-22T23:42:03 <jtimon> would this be a good time?
4102017-02-22T23:42:21 <luke-jr> `sendtoaddress --help` is simply an invalid address
4112017-02-22T23:43:33 <jtimon> ?? then why it shows the help instead of "Invalid Bitcoin address"
4122017-02-22T23:43:53 <ryanofsky> i know "sendfrom" RPC is deprecated, but is it also broken? I don't see 'fromaccount'
4132017-02-22T23:44:00 <ryanofsky> argument actually used for coin selection
4142017-02-22T23:56:39 <jeremyrubin> no that's not broken
4152017-02-22T23:56:56 <jeremyrubin> As far as I understand, accounts were meant to be internal accounting
4162017-02-22T23:57:05 <jeremyrubin> meaning negative balances could be reported
4172017-02-22T23:57:47 <jeremyrubin> So if I spend 2 from account Y with real balance 1, Y's new balance should be -1
4182017-02-22T23:59:21 <jeremyrubin> so account info has no bearing on coin selection
4192017-02-22T23:59:39 <sipa> that ^
4202017-02-22T23:59:51 <sipa> coins are independent from accounts
4212017-02-22T23:59:56 <sipa> accounts only have a balance