12017-03-06T00:00:33 *** wudayoda has joined #bitcoin-core-dev
22017-03-06T00:05:02 *** wudayoda has quit IRC
32017-03-06T00:12:00 *** afk11_ has joined #bitcoin-core-dev
42017-03-06T00:14:27 *** riemann has quit IRC
52017-03-06T00:31:28 *** wudayoda has joined #bitcoin-core-dev
62017-03-06T00:35:57 *** wudayoda has quit IRC
72017-03-06T00:37:20 *** afk11_ has quit IRC
82017-03-06T00:40:05 *** JackH has quit IRC
92017-03-06T00:46:56 *** cysm has quit IRC
102017-03-06T00:47:54 *** JackH has joined #bitcoin-core-dev
112017-03-06T00:55:08 *** JackH has quit IRC
122017-03-06T00:56:41 *** kadoban has joined #bitcoin-core-dev
132017-03-06T01:02:07 *** cysm has joined #bitcoin-core-dev
142017-03-06T01:04:11 *** JackH has joined #bitcoin-core-dev
152017-03-06T01:10:46 *** chjj has quit IRC
162017-03-06T01:11:04 <gmaxwell> streams.h:407:44: warning: declaration of âdataâ shadows a member of 'this' [-Wshadow]
172017-03-06T01:11:20 <gmaxwell> I boggle at shadow warnings being so compiler specific.
182017-03-06T01:11:32 <gmaxwell> This isn't the case for plain C.
192017-03-06T01:15:25 *** MarcoFalke has quit IRC
202017-03-06T01:24:47 *** chjj has joined #bitcoin-core-dev
212017-03-06T01:34:04 *** Ylbam has quit IRC
222017-03-06T02:20:09 *** wudayoda has joined #bitcoin-core-dev
232017-03-06T02:24:13 *** str4d has joined #bitcoin-core-dev
242017-03-06T02:25:00 *** wudayoda has quit IRC
252017-03-06T02:51:07 *** wudayoda has joined #bitcoin-core-dev
262017-03-06T02:55:02 *** Giszmo has quit IRC
272017-03-06T02:55:36 *** wudayoda has quit IRC
282017-03-06T03:01:31 *** dodomojo has joined #bitcoin-core-dev
292017-03-06T03:02:25 *** dodomojo has quit IRC
302017-03-06T03:09:33 *** Giszmo has joined #bitcoin-core-dev
312017-03-06T03:10:01 *** d9b4bef9 has quit IRC
322017-03-06T03:13:15 *** d9b4bef9 has joined #bitcoin-core-dev
332017-03-06T03:21:56 *** wudayoda has joined #bitcoin-core-dev
342017-03-06T03:26:46 *** wudayoda has quit IRC
352017-03-06T03:35:05 *** Victor_sueca has joined #bitcoin-core-dev
362017-03-06T03:37:07 *** dodomojo has joined #bitcoin-core-dev
372017-03-06T03:37:28 *** Victorsueca has quit IRC
382017-03-06T03:50:13 *** dodomojo has quit IRC
392017-03-06T03:50:42 *** dodomojo has joined #bitcoin-core-dev
402017-03-06T03:51:22 *** dodomojo_ has joined #bitcoin-core-dev
412017-03-06T03:53:59 *** wudayoda has joined #bitcoin-core-dev
422017-03-06T03:54:52 *** dodomojo has quit IRC
432017-03-06T03:58:30 *** wudayoda has quit IRC
442017-03-06T04:03:26 *** dodomojo_ has quit IRC
452017-03-06T04:26:10 *** wudayoda has joined #bitcoin-core-dev
462017-03-06T04:30:48 *** wudayoda has quit IRC
472017-03-06T04:37:46 *** mryandao has quit IRC
482017-03-06T04:58:01 *** wudayoda has joined #bitcoin-core-dev
492017-03-06T05:03:06 *** wudayoda has quit IRC
502017-03-06T05:22:00 *** jtimon has quit IRC
512017-03-06T05:43:48 *** wudayoda has joined #bitcoin-core-dev
522017-03-06T05:48:26 *** wudayoda has quit IRC
532017-03-06T06:08:41 *** Victor_sueca has quit IRC
542017-03-06T06:09:49 *** Victor_sueca has joined #bitcoin-core-dev
552017-03-06T06:26:02 *** str4d has quit IRC
562017-03-06T06:45:16 *** wudayoda has joined #bitcoin-core-dev
572017-03-06T06:49:36 <wumpus> yes for C it seems much better defined
582017-03-06T06:50:12 *** wudayoda has quit IRC
592017-03-06T06:51:50 <wumpus> though it may be historical coincidence that clang and gcc match up so well with most warnings. MSVC on the other hand...
602017-03-06T06:51:51 *** wasi has quit IRC
612017-03-06T06:52:20 *** wasi has joined #bitcoin-core-dev
622017-03-06T06:53:36 *** wudayoda has joined #bitcoin-core-dev
632017-03-06T06:58:08 *** wudayoda has quit IRC
642017-03-06T07:03:56 * luke-jr wonders what Core would look like with -Weverything
652017-03-06T07:09:28 *** wudayoda has joined #bitcoin-core-dev
662017-03-06T07:13:57 *** wudayoda has quit IRC
672017-03-06T07:14:41 <sipa> it hurts.
682017-03-06T07:16:09 <wumpus> that said, it will probably hurt for any moderately-sized C++ project
692017-03-06T07:17:50 <wumpus> except for the compilers themselves maybe; I'd (naively) expect those to compile cleanly in themselves
702017-03-06T07:26:41 *** Ylbam has joined #bitcoin-core-dev
712017-03-06T07:41:31 *** wudayoda has joined #bitcoin-core-dev
722017-03-06T07:46:15 *** BashCo has quit IRC
732017-03-06T07:46:18 *** wudayoda has quit IRC
742017-03-06T07:46:57 *** BashCo has joined #bitcoin-core-dev
752017-03-06T07:51:28 *** BashCo has quit IRC
762017-03-06T08:04:39 *** Kexkey has quit IRC
772017-03-06T08:06:42 *** BashCo has joined #bitcoin-core-dev
782017-03-06T08:08:02 *** d9b4bef9 has quit IRC
792017-03-06T08:09:07 *** d9b4bef9 has joined #bitcoin-core-dev
802017-03-06T08:11:11 *** Victor_sueca has quit IRC
812017-03-06T08:12:19 *** Victor_sueca has joined #bitcoin-core-dev
822017-03-06T08:13:16 *** wudayoda has joined #bitcoin-core-dev
832017-03-06T08:18:02 *** wudayoda has quit IRC
842017-03-06T08:27:48 *** cysm has quit IRC
852017-03-06T08:40:41 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/01b7cda91684...56ab672b59da
862017-03-06T08:40:41 <bitcoin-git> bitcoin/master 343ba8f practicalswift: [wallet] Remove redundant initialization...
872017-03-06T08:40:41 <bitcoin-git> bitcoin/master 56ab672 Wladimir J. van der Laan: Merge #9576: [wallet] Remove redundant initialization...
882017-03-06T08:40:50 <bitcoin-git> [bitcoin] laanwj closed pull request #9576: [wallet] Remove redundant initialization (master...remove-redundant-initialization-ii) https://github.com/bitcoin/bitcoin/pull/9576
892017-03-06T08:57:43 *** MarcoFalke has joined #bitcoin-core-dev
902017-03-06T09:02:25 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56ab672b59da...5a6af3172254
912017-03-06T09:02:25 <bitcoin-git> bitcoin/master e57a1fd Russell Yanofsky: Define 7200 second timestamp window constant
922017-03-06T09:02:26 <bitcoin-git> bitcoin/master 5a6af31 Wladimir J. van der Laan: Merge #9908: Define 7200 second timestamp window constant...
932017-03-06T09:02:46 <bitcoin-git> [bitcoin] laanwj closed pull request #9908: Define 7200 second timestamp window constant (master...pr/timewin) https://github.com/bitcoin/bitcoin/pull/9908
942017-03-06T09:04:49 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a6af3172254...48c3429c50fb
952017-03-06T09:04:49 <bitcoin-git> bitcoin/master 025dec0 NicolasDorier: [qa] assert_start_raises_init_error
962017-03-06T09:04:50 <bitcoin-git> bitcoin/master 48c3429 Wladimir J. van der Laan: Merge #9832: [qa] assert_start_raises_init_error...
972017-03-06T09:05:10 <bitcoin-git> [bitcoin] laanwj closed pull request #9832: [qa] assert_start_raises_init_error (master...assert_start_raises_init_error) https://github.com/bitcoin/bitcoin/pull/9832
982017-03-06T09:06:51 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/48c3429c50fb...9d5fcbfb0889
992017-03-06T09:06:52 <bitcoin-git> bitcoin/master 99c0e81 John Newbery: Fix BIP68 activation test
1002017-03-06T09:06:52 <bitcoin-git> bitcoin/master f5aba8a John Newbery: Move tx version 2 standardness check to after bip68 activation
1012017-03-06T09:06:53 <bitcoin-git> bitcoin/master 9d5fcbf Wladimir J. van der Laan: Merge #9739: Fix BIP68 activation test...
1022017-03-06T09:07:09 <bitcoin-git> [bitcoin] laanwj closed pull request #9739: Fix BIP68 activation test (master...fixbip68testing) https://github.com/bitcoin/bitcoin/pull/9739
1032017-03-06T09:08:34 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d5fcbfb0889...d32581cc29d1
1042017-03-06T09:08:34 <bitcoin-git> bitcoin/master db07f91 practicalswift: Assert that what might look like a possible division by zero is actually unreachable
1052017-03-06T09:08:35 <bitcoin-git> bitcoin/master d32581c Wladimir J. van der Laan: Merge #9547: bench: Assert that division by zero is unreachable...
1062017-03-06T09:08:49 <bitcoin-git> [bitcoin] laanwj closed pull request #9547: bench: Assert that division by zero is unreachable (master...avoid-potential-division-by-zero-in-benchmark-state-keeprunning) https://github.com/bitcoin/bitcoin/pull/9547
1072017-03-06T09:16:18 *** wudayoda has joined #bitcoin-core-dev
1082017-03-06T09:18:38 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d32581cc29d1...fa625b078b01
1092017-03-06T09:18:39 <bitcoin-git> bitcoin/master 654e044 Russell Yanofsky: [trivial] Add comment documenting CWalletTx::mapValue
1102017-03-06T09:18:40 <bitcoin-git> bitcoin/master a1fe944 Russell Yanofsky: Remove reference to nonexistent "version" wallet transaction mapvalue field...
1112017-03-06T09:18:40 <bitcoin-git> bitcoin/master 87ed396 Russell Yanofsky: [trivial] Add comment documenting bumpfee mapValues
1122017-03-06T09:18:47 <bitcoin-git> [bitcoin] laanwj closed pull request #9333: Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry. (master...pr/comment-mapvalue) https://github.com/bitcoin/bitcoin/pull/9333
1132017-03-06T09:20:27 *** wudayoda has quit IRC
1142017-03-06T09:20:35 *** cysm has joined #bitcoin-core-dev
1152017-03-06T09:34:48 *** Victor_sueca is now known as Victorsueca
1162017-03-06T09:37:44 <bitcoin-git> [bitcoin] kobake opened pull request #9926: Rename argument name 'data' to prevent shadowing. (master...fix-shadow-warning) https://github.com/bitcoin/bitcoin/pull/9926
1172017-03-06T09:48:06 <bitcoin-git> [bitcoin] kobake closed pull request #9926: Rename argument name 'data' to prevent shadowing. (master...fix-shadow-warning) https://github.com/bitcoin/bitcoin/pull/9926
1182017-03-06T09:48:29 *** wudayoda has joined #bitcoin-core-dev
1192017-03-06T09:53:14 *** wudayoda has quit IRC
1202017-03-06T09:59:04 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9256: Fix more CWallet/CWalletDB layer violations (master...2016/12/ref_walletdb) https://github.com/bitcoin/bitcoin/pull/9256
1212017-03-06T10:04:20 *** wudayoda has joined #bitcoin-core-dev
1222017-03-06T10:06:26 <wumpus> jonasschnelli: too bade about 9256 :( might pick it up at some point, need to be able to replace the database backend for the cloudabi port
1232017-03-06T10:07:07 <jonasschnelli> wumpus: Oh. Okay.. I'm currently working on #8574 (which is also a BDB abstraction).
1242017-03-06T10:07:09 <gribble> https://github.com/bitcoin/bitcoin/issues/8574 | [Wallet] refactor CWallet/CWalletDB/CDB by jonasschnelli · Pull Request #8574 · bitcoin/bitcoin · GitHub
1252017-03-06T10:07:21 <jonasschnelli> 9256 can be done afterwards..
1262017-03-06T10:07:44 <wumpus> I've noticed that there is a lot of overlap between dbwrapper.h and walletdb.h
1272017-03-06T10:08:03 <wumpus> yeah
1282017-03-06T10:08:08 <jonasschnelli> Yes. We need clean layering first to support multiple db backends
1292017-03-06T10:08:27 *** wudayoda has quit IRC
1302017-03-06T10:08:40 <wumpus> I really like the dbwrapper.h. With that I've mangaed to replace the db backend multiple times. Implementing e.g. a walletdb.h for leveldb seemsto be more work
1312017-03-06T10:09:00 <wumpus> (as it doesn't wrap some of the objects)
1322017-03-06T10:09:31 *** jannes has joined #bitcoin-core-dev
1332017-03-06T10:09:46 * jonasschnelli looking closer at dbwrapper.h/cpp
1342017-03-06T10:10:39 <wumpus> then again - a pure key/value store may not be what we eventually want for the wallet at all, maybe something like sqlite with indexes is better. But on the short term it'd be useful to switch database backends and just consider key/value stores as a given, abstracted.
1352017-03-06T10:10:48 <jonasschnelli> Yes. Something like that for the wallet db would be great. I first though CDBEnv follows that approach... but not really
1362017-03-06T10:11:20 <wumpus> I think they evolved from the same abstraction, but dbwrapper was updated time and time again to be a better abstraction, while walletdb did not :)
1372017-03-06T10:11:40 <jonasschnelli> Sqlite could be useful. I though about it.... but not sure if we want private keys in there.. also not sure about the compatibility between different sqlite implementations..
1382017-03-06T10:11:49 *** riemann has joined #bitcoin-core-dev
1392017-03-06T10:12:49 <jonasschnelli> I still like sipa logdb approach (full in-mem mapping, no on-disk database queries, simple append only log with on-going hash)
1402017-03-06T10:12:52 <wumpus> sqlite actually encourages usage as an applicatiion data format in their faq
1412017-03-06T10:13:32 <wumpus> so I *think* that means they make a commitment to on-disk compatibility. Also their databases are single files, unlike leveldb.
1422017-03-06T10:14:13 <wumpus> yes sure I like that too
1432017-03-06T10:14:43 <wumpus> in any case, for everything we need to improve the abstractions involved
1442017-03-06T10:14:52 <jonasschnelli> For pure transactions and pubkey, I would probably prefere sqlite
1452017-03-06T10:15:16 <wumpus> right - and with HD wallets we need a lot less key storage
1462017-03-06T10:15:17 <jonasschnelli> Yes. Lets focus on abstraction and discuss the new persistence layer later.
1472017-03-06T10:15:31 <wumpus> +private
1482017-03-06T10:16:05 <sipa> the abstractions are complicated by the fact that BDB needs some things (flushing, locking, environment, ...) that nothing else needs
1492017-03-06T10:17:03 <jonasschnelli> Yes. The abstraction needs to support that (at least for the next years)
1502017-03-06T10:17:27 *** e4xit has quit IRC
1512017-03-06T10:17:43 <sipa> no, only until we get rid of BDB
1522017-03-06T10:17:52 <sipa> i hope that's less than a few years
1532017-03-06T10:18:07 <MarcoFalke> Anyone want to review #9880?
1542017-03-06T10:18:09 <gribble> https://github.com/bitcoin/bitcoin/issues/9880 | Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 by TheBlueMatt · Pull Request #9880 · bitcoin/bitcoin · GitHub
1552017-03-06T10:18:21 <jonasschnelli> hmm.. if we offer a good migration option,... but the migration option needs BDB support... :)
1562017-03-06T10:18:28 <MarcoFalke> Currently only wumpus can merge on master
1572017-03-06T10:18:40 <sipa> jonasschnelli: that can just be a trivial "iterate the keys, convert" - not a full db abstraction
1582017-03-06T10:18:50 <jonasschnelli> sipa: Indeed
1592017-03-06T10:22:07 *** Victorsueca has quit IRC
1602017-03-06T10:23:15 *** Victorsueca has joined #bitcoin-core-dev
1612017-03-06T10:34:34 <jonasschnelli> wumpus, sipa: if you care for wallet db abstraction, this (#8574) could be reviewed:
1622017-03-06T10:34:36 <gribble> https://github.com/bitcoin/bitcoin/issues/8574 | [Wallet] refactor CWallet/CWalletDB/CDB by jonasschnelli · Pull Request #8574 · bitcoin/bitcoin · GitHub
1632017-03-06T10:38:18 *** MarcoFalke has quit IRC
1642017-03-06T10:41:58 *** BirneGetreide_ has joined #bitcoin-core-dev
1652017-03-06T10:44:08 <jonasschnelli> MarcoFalke: Oh. Yes. My merged broke verify-commits (and therefor travis on master): https://travis-ci.org/bitcoin/bitcoin/jobs/206917518#L513
1662017-03-06T10:51:00 *** wudayoda has joined #bitcoin-core-dev
1672017-03-06T10:53:46 *** gK-1wm-su has joined #bitcoin-core-dev
1682017-03-06T10:55:34 *** wudayoda has quit IRC
1692017-03-06T10:55:39 *** gK-1wm-su has quit IRC
1702017-03-06T11:00:48 <wumpus> jonasschnelli: I'll take a look. On the short run I just need something that can replace berkeleydb with a different k/v store, no need for any backward compatiblity or migration
1712017-03-06T11:01:11 <jonasschnelli> Thanks. Yes. That's a different path then...
1722017-03-06T11:04:05 <wumpus> jonasschnelli: not using a database or a custom database would be fine too, but that seems like a lot more work :)
1732017-03-06T11:04:53 <wumpus> and would require a huge patch set to maintain on top
1742017-03-06T11:06:29 <wumpus> which would need to be updated for every upstream wallet change
1752017-03-06T11:06:38 <wumpus> so yeah, switching the k/v store is probably the best option
1762017-03-06T11:12:05 *** wudayoda has joined #bitcoin-core-dev
1772017-03-06T11:13:19 <Victorsueca> I just had a question this morning while at was at shower... Is it safe to defrag while bitcoin core is running?
1782017-03-06T11:14:18 <wumpus> defrag? is that still a thing?
1792017-03-06T11:14:43 <BirneGetreide_> Just don't defrag, ever. It is a waste of time
1802017-03-06T11:15:26 <jonasschnelli> Oh... verify-commits.sh gave a "Segmentation fault: 11"! hah
1812017-03-06T11:16:01 <jonasschnelli> I hope it's not coming from gnupg
1822017-03-06T11:16:32 *** wudayoda has quit IRC
1832017-03-06T11:17:22 *** BirneGetreide_ has quit IRC
1842017-03-06T11:17:40 <wumpus> but no, we can't guarantee that that is safe. Moving filesystem blocks in the background could be safe or unsafe depending on whether the OS keeps track of things properly.
1852017-03-06T11:19:33 <Victorsueca> it's windows so I doubt it does lol
1862017-03-06T11:25:56 *** BirneGetreide_ has joined #bitcoin-core-dev
1872017-03-06T11:29:25 <wumpus> right, you didn't even need to ask
1882017-03-06T11:32:06 *** MarcoFalke has joined #bitcoin-core-dev
1892017-03-06T11:34:06 *** MarcoFalke has left #bitcoin-core-dev
1902017-03-06T11:34:30 *** MarcoFalke has joined #bitcoin-core-dev
1912017-03-06T11:35:55 *** pedrobranco has joined #bitcoin-core-dev
1922017-03-06T11:35:56 *** MarcoFalke has quit IRC
1932017-03-06T11:36:02 *** MarcoFalke_ has joined #bitcoin-core-dev
1942017-03-06T11:36:27 *** MarcoFalke_ is now known as MarcoFalke
1952017-03-06T11:37:54 *** BirneGetreide_ has quit IRC
1962017-03-06T11:43:41 <jonasschnelli> Hmm... I think the verify-commit.sh segfault 11 im getting is from /bin/sh
1972017-03-06T11:43:49 *** wudayoda has joined #bitcoin-core-dev
1982017-03-06T11:44:09 <jonasschnelli> It happens when the script calls IS_SIGNED() (recursive call)
1992017-03-06T11:44:28 <jonasschnelli> Happens on master was well...
2002017-03-06T11:48:15 <wumpus> ugh :/
2012017-03-06T11:48:50 *** wudayoda has quit IRC
2022017-03-06T11:50:15 <jonasschnelli> Can't even attach lldb to /bin/sh due to OSX's "integrity protection"... copied out sh and running now in lldb
2032017-03-06T11:51:21 <sipa> too many recursion levels in the shell?
2042017-03-06T11:52:08 <jonasschnelli> sipa: I think so.
2052017-03-06T11:52:12 <jonasschnelli> Stack trace: http://bitcoin.jonasschnelli.ch/st.txt
2062017-03-06T11:53:50 <jonasschnelli> now running in bash
2072017-03-06T11:54:58 <jonasschnelli> same
2082017-03-06T11:57:50 <jonasschnelli> I think some Ubuntu verions are also affected. http://lists.gnu.org/archive/html/bug-bash/2003-12/msg00007.html
2092017-03-06T11:58:56 <jonasschnelli> Would it make sense to port verify-commits.sh to python? We already rely on python for the rest, right? ping BlueMatt
2102017-03-06T11:59:56 <jonasschnelli> BlueMatt: it seems that the current amount of recursive calls on IS_SIGNED() seems to break some shell implementations (OSX 10.11 and I think also Ubuntu 14.04)
2112017-03-06T12:06:06 <wumpus> can we somehow make verify-commits.sh simpler, at least temporary?
2122017-03-06T12:06:33 <wumpus> e.g. do the most important check that the HEAD commit is signed, but no more, that shouldn't take any recursion
2132017-03-06T12:06:52 <wumpus> then after the script is fixed we can go back to the more comphrehensive one
2142017-03-06T12:18:06 *** To7 has quit IRC
2152017-03-06T12:19:05 <jonasschnelli> wumpus: Yes. That's probably a good idea... maybe we add an arg and by default, it just checks the head
2162017-03-06T12:38:26 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9928: Allow verify-commit.sh to just verify the HEAD commit (Use non-recursive verification by default) (master...2017/03/vc_simple) https://github.com/bitcoin/bitcoin/pull/9928
2172017-03-06T12:38:53 *** norotartagen has quit IRC
2182017-03-06T12:48:05 *** wudayoda has joined #bitcoin-core-dev
2192017-03-06T12:52:52 *** wudayoda has quit IRC
2202017-03-06T13:16:59 *** To7 has joined #bitcoin-core-dev
2212017-03-06T13:17:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2222017-03-06T13:19:02 *** d9b4bef9 has quit IRC
2232017-03-06T13:20:08 *** d9b4bef9 has joined #bitcoin-core-dev
2242017-03-06T13:20:14 *** wudayoda has joined #bitcoin-core-dev
2252017-03-06T13:24:19 *** arubi has quit IRC
2262017-03-06T13:24:36 *** wudayoda has quit IRC
2272017-03-06T13:26:32 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa625b078b01...8a3b07529d9c
2282017-03-06T13:26:32 <bitcoin-git> bitcoin/master 7184e25 Jonas Schnelli: [Wallet] refactor CWallet/CWalletDB/CDB...
2292017-03-06T13:26:33 <bitcoin-git> bitcoin/master 8a3b075 Wladimir J. van der Laan: Merge #8574: [Wallet] refactor CWallet/CWalletDB/CDB...
2302017-03-06T13:26:42 <bitcoin-git> [bitcoin] laanwj closed pull request #8574: [Wallet] refactor CWallet/CWalletDB/CDB (master...2016/08/bdb_abstraction_2) https://github.com/bitcoin/bitcoin/pull/8574
2312017-03-06T13:26:52 *** nanotube has quit IRC
2322017-03-06T13:35:39 *** nanotube has joined #bitcoin-core-dev
2332017-03-06T13:37:28 *** AaronvanW has quit IRC
2342017-03-06T13:39:36 *** jcorgan has quit IRC
2352017-03-06T13:41:37 *** jcorgan has joined #bitcoin-core-dev
2362017-03-06T13:51:29 *** AaronvanW has joined #bitcoin-core-dev
2372017-03-06T13:52:01 *** wudayoda has joined #bitcoin-core-dev
2382017-03-06T13:56:54 *** wudayoda has quit IRC
2392017-03-06T14:12:20 *** Kexkey_ has joined #bitcoin-core-dev
2402017-03-06T14:13:47 <wumpus> going to have a stab at making the RPC tests run (optionally) through UNIX sockets
2412017-03-06T14:14:16 <wumpus> don't think much is needed besides abstracting 'url' into 'RPC connect info'
2422017-03-06T14:29:31 <jonasschnelli> wumpus: haven't thought about the RPC test... great idea.
2432017-03-06T14:44:25 <wumpus> jonasschnelli: yep it provides an example on how to use RPC over UNIX sockets in python at the same time
2442017-03-06T14:55:07 *** wudayoda has joined #bitcoin-core-dev
2452017-03-06T14:55:38 <bitcoin-git> [bitcoin] laanwj opened pull request #9929: tests: Delete unused function _rpchost_to_args (master...2017_03_tests_unused) https://github.com/bitcoin/bitcoin/pull/9929
2462017-03-06T14:57:30 *** jtimon has joined #bitcoin-core-dev
2472017-03-06T14:59:48 *** wudayoda has quit IRC
2482017-03-06T15:06:49 *** Guyver2 has joined #bitcoin-core-dev
2492017-03-06T15:12:17 *** JackH has quit IRC
2502017-03-06T15:13:18 *** JackH has joined #bitcoin-core-dev
2512017-03-06T15:17:40 *** chris2000 has joined #bitcoin-core-dev
2522017-03-06T15:22:34 *** nemgun has quit IRC
2532017-03-06T15:27:10 *** wudayoda has joined #bitcoin-core-dev
2542017-03-06T15:29:24 <BlueMatt> jonasschnelli: if you want to feel free, but I wont be able to maintain it anymore :P
2552017-03-06T15:31:32 *** wudayoda has quit IRC
2562017-03-06T15:34:18 <wumpus> many of us have the same problem with shellscript :p
2572017-03-06T15:34:27 *** JackH has quit IRC
2582017-03-06T15:34:42 <wumpus> but I don't care what language it is in, it just needs to work
2592017-03-06T15:36:00 *** JackH has joined #bitcoin-core-dev
2602017-03-06T15:38:21 <wumpus> nesting recursion too deep is a problem in any language
2612017-03-06T15:39:50 <BlueMatt> yea, i should have removed the recursion when i made it not ever look at the second parent
2622017-03-06T15:39:53 <BlueMatt> should be trivial to do
2632017-03-06T15:41:57 *** JackH has quit IRC
2642017-03-06T15:42:35 <bitcoin-git> [bitcoin] laanwj closed pull request #9924: [UI Styling] Left-Align Tab Bar - optionsdialog.ui (master...patch-1) https://github.com/bitcoin/bitcoin/pull/9924
2652017-03-06T15:42:56 <bitcoin-git> [bitcoin] laanwj closed pull request #9925: [UI Styling] Left-Align Tab Bar - debugwindow.ui (master...patch-2) https://github.com/bitcoin/bitcoin/pull/9925
2662017-03-06T15:55:11 *** JackH has joined #bitcoin-core-dev
2672017-03-06T15:55:14 *** bityogi has joined #bitcoin-core-dev
2682017-03-06T16:11:43 *** fengling has quit IRC
2692017-03-06T16:14:18 *** fengling has joined #bitcoin-core-dev
2702017-03-06T16:19:19 *** xiangfu has quit IRC
2712017-03-06T16:19:22 *** BashCo has quit IRC
2722017-03-06T16:19:40 *** xiangfu has joined #bitcoin-core-dev
2732017-03-06T16:19:53 *** wudayoda has joined #bitcoin-core-dev
2742017-03-06T16:20:10 *** BashCo has joined #bitcoin-core-dev
2752017-03-06T16:20:17 <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/8a3b07529d9c...4df8213b98d3
2762017-03-06T16:20:18 <bitcoin-git> bitcoin/master be908a6 Matt Corallo: Fail merge if there are any symlinks
2772017-03-06T16:20:18 <bitcoin-git> bitcoin/master d9c450f Matt Corallo: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1
2782017-03-06T16:20:19 <bitcoin-git> bitcoin/master eddc77a Peter Todd: Add comment re: why SHA1 is disabled
2792017-03-06T16:20:36 <bitcoin-git> [bitcoin] laanwj closed pull request #9880: Verify Tree-SHA512s in merge commits, enforce sigs are not SHA1 (master...2017-02-validate-sha512) https://github.com/bitcoin/bitcoin/pull/9880
2802017-03-06T16:24:13 *** BashCo has quit IRC
2812017-03-06T16:24:48 *** wudayoda has quit IRC
2822017-03-06T16:26:15 *** paveljanik has joined #bitcoin-core-dev
2832017-03-06T16:27:49 *** arubi has joined #bitcoin-core-dev
2842017-03-06T16:28:49 *** riemann has quit IRC
2852017-03-06T16:30:04 <BlueMatt> god damn it, how did it fail on head
2862017-03-06T16:40:11 *** xiangfu has quit IRC
2872017-03-06T16:40:28 *** xiangfu has joined #bitcoin-core-dev
2882017-03-06T16:41:44 *** Chris_Stewart_5 has quit IRC
2892017-03-06T16:43:05 *** justan0theruser has quit IRC
2902017-03-06T16:47:53 *** n1ce has quit IRC
2912017-03-06T16:48:32 <BlueMatt> grrrr it doesnt fail locally
2922017-03-06T16:48:48 *** BashCo has joined #bitcoin-core-dev
2932017-03-06T16:49:25 *** abpa has joined #bitcoin-core-dev
2942017-03-06T16:49:43 *** n1ce has joined #bitcoin-core-dev
2952017-03-06T16:53:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2962017-03-06T16:58:25 <bitcoin-git> [bitcoin] matthias-g opened pull request #9930: Trivial: Correct indentation (master...fix-indent) https://github.com/bitcoin/bitcoin/pull/9930
2972017-03-06T17:06:28 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4df8213b98d3...c78adbf450be
2982017-03-06T17:06:28 <bitcoin-git> bitcoin/master b23dcd2 John Newbery: Fix segwit getblocktemplate test.
2992017-03-06T17:06:29 <bitcoin-git> bitcoin/master c78adbf Wladimir J. van der Laan: Merge #9843: Fix segwit getblocktemplate test...
3002017-03-06T17:06:49 <bitcoin-git> [bitcoin] laanwj closed pull request #9843: Fix segwit getblocktemplate test (master...fixsegwitgetblocktemplate) https://github.com/bitcoin/bitcoin/pull/9843
3012017-03-06T17:13:30 *** wudayoda has joined #bitcoin-core-dev
3022017-03-06T17:13:37 *** justan0theruser has joined #bitcoin-core-dev
3032017-03-06T17:13:52 *** tripleslash has joined #bitcoin-core-dev
3042017-03-06T17:18:04 *** wudayoda has quit IRC
3052017-03-06T17:33:00 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c78adbf450be...d5ce14e22338
3062017-03-06T17:33:00 <bitcoin-git> bitcoin/master 99fecf8 Wladimir J. van der Laan: tests: Delete unused function _rpchost_to_args...
3072017-03-06T17:33:01 <bitcoin-git> bitcoin/master d5ce14e Wladimir J. van der Laan: Merge #9929: tests: Delete unused function _rpchost_to_args...
3082017-03-06T17:33:19 <bitcoin-git> [bitcoin] laanwj closed pull request #9929: tests: Delete unused function _rpchost_to_args (master...2017_03_tests_unused) https://github.com/bitcoin/bitcoin/pull/9929
3092017-03-06T17:33:44 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d5ce14e22338...72fb5158b1c8
3102017-03-06T17:33:44 <bitcoin-git> bitcoin/master 188f89c Gregory Sanders: Disallow copy of CReserveKeys
3112017-03-06T17:33:45 <bitcoin-git> bitcoin/master 72fb515 Wladimir J. van der Laan: Merge #9906: Disallow copy constructor CReserveKeys...
3122017-03-06T17:34:10 <bitcoin-git> [bitcoin] laanwj closed pull request #9906: Disallow copy constructor CReserveKeys (master...noreservecopy) https://github.com/bitcoin/bitcoin/pull/9906
3132017-03-06T17:35:52 *** laurentmt has joined #bitcoin-core-dev
3142017-03-06T17:36:16 <morcos> Call for another set of eyes on #9602.. I think it has enough technical review now, but couldn't hurt to have some more people review the open questions in the PR message and make sure they are ok with the changes made.
3152017-03-06T17:36:19 <gribble> https://github.com/bitcoin/bitcoin/issues/9602 | Remove coin age priority and free transactions - implementation by morcos · Pull Request #9602 · bitcoin/bitcoin · GitHub
3162017-03-06T17:36:26 <morcos> And then lets get it merged please
3172017-03-06T17:36:30 *** laurentmt has quit IRC
3182017-03-06T17:41:46 *** chris2000 has quit IRC
3192017-03-06T17:52:27 *** shesek has quit IRC
3202017-03-06T17:54:21 <gmaxwell> wumpus: for the unix domain socket bitcoin-cli, could you have the client behind an actual feature test? so that when the user's libevent is upgraded it starts working?
3212017-03-06T17:56:33 *** rafalcpp has joined #bitcoin-core-dev
3222017-03-06T17:58:02 <wumpus> gmaxwell: once my patch lands in mainline libevent, it can be enabled based on the libevent version
3232017-03-06T17:58:13 <wumpus> currently there is no way to detect whether libevent can do it or not
3242017-03-06T18:00:17 <wumpus> if it takes a long time to be included in libevent we could add the patch to depends so that the released binaries will have it
3252017-03-06T18:01:11 <wumpus> can always decide on that when the 0.15 release gets close and it's still uncertain
3262017-03-06T18:02:11 *** norotartagen has joined #bitcoin-core-dev
3272017-03-06T18:02:14 <gmaxwell> has the libevent people given any feedback suggesting if they're likely to accept the change or not?
3282017-03-06T18:02:23 <wumpus> nope
3292017-03-06T18:02:50 <gmaxwell> might be good to get that, if they wont we might want a different approach. :(
3302017-03-06T18:03:09 <gmaxwell> (than potentially carrying a patch with release binaries forever)
3312017-03-06T18:03:17 <wumpus> well it's still useful even without the client change
3322017-03-06T18:03:30 <wumpus> and there is no other approach to support it in bitcoin-cli anyhow
3332017-03-06T18:03:33 <BlueMatt> anyone able to reproduce the travis master fail?
3342017-03-06T18:03:40 <BlueMatt> verify-commits is failing again but not locally anymore
3352017-03-06T18:04:04 <wumpus> not that I know of, at least, maybe libevent people could suggest something, butI haven't had feedback on it at all
3362017-03-06T18:04:07 <gmaxwell> BlueMatt: verify commits is failing for me on the 0.14 branch, I haven't checked master today.
3372017-03-06T18:04:15 <wumpus> gmaxwell: wow that's depressing :/
3382017-03-06T18:04:45 <wumpus> they've had, what, two days including a sunday to respond, I wouldn't worry about "carrying a patch forever" yet
3392017-03-06T18:05:04 <BlueMatt> oh wut?
3402017-03-06T18:06:37 <wumpus> on 0.14 it should pass now
3412017-03-06T18:06:50 <BlueMatt> well it should pass on master too
3422017-03-06T18:06:56 <BlueMatt> did it succeed on 0.14 on travis?
3432017-03-06T18:07:13 <wumpus> yes I think so
3442017-03-06T18:07:18 <BlueMatt> yes, it did
3452017-03-06T18:30:39 *** wudayoda has joined #bitcoin-core-dev
3462017-03-06T18:35:08 *** wudayoda has quit IRC
3472017-03-06T18:39:21 *** shesek has joined #bitcoin-core-dev
3482017-03-06T18:40:08 *** pedrobranco has quit IRC
3492017-03-06T18:40:41 *** pedrobranco has joined #bitcoin-core-dev
3502017-03-06T18:42:14 *** jcorgan has quit IRC
3512017-03-06T18:44:19 *** jcorgan has joined #bitcoin-core-dev
3522017-03-06T18:45:20 *** pedrobranco has quit IRC
3532017-03-06T18:59:13 <BlueMatt> hmmm, MarcoFalke i cant reproduce your Tree-SHA512 from https://github.com/bitcoin/bitcoin/commit/f7ec7cfd38b543ba81ac7bed5b77f9a19739460b
3542017-03-06T18:59:27 <BlueMatt> i didnt try the python code, but the bash-based snippet doesnt work here
3552017-03-06T19:03:51 <wumpus> verify-commits.sh passes on master here, locally
3562017-03-06T19:05:57 <BlueMatt> found the issue...needs gpg 2.1 to pass --weak-digest
3572017-03-06T19:06:05 <BlueMatt> also the above tree-sha512 issue
3582017-03-06T19:07:41 <wumpus> can't reproduce that one either,tree_sha512sum() gives dc5cf61d226a16a77f32fab8abc18fd469dfe8bda59a2cb8f9eca3a60e474f180dec4fa59bb3fee86efa0e123ba8c198c7efe76bfdaa2518f4169ab0849f6694
3592017-03-06T19:07:55 <BlueMatt> yea, that looks like what i (and verify-commits) gets
3602017-03-06T19:07:58 <wumpus> it's not causing verify-commits.sh to fail here though
3612017-03-06T19:08:09 <BlueMatt> you have to run verify-commits with --tree-checks
3622017-03-06T19:08:12 <BlueMatt> (because its slowwwww)
3632017-03-06T19:08:33 <BlueMatt> next pr will fix all above issues, and also I think i should do --tree-checks but only for top commit
3642017-03-06T19:08:38 <BlueMatt> so that travis will catch this
3652017-03-06T19:08:48 <BlueMatt> but not for more because otherwise travis would take hours by the time we get to 0.15
3662017-03-06T19:09:01 <wumpus> I agree, we should avoid making the check slower
3672017-03-06T19:09:21 <wumpus> checking just the top commit or top two commits thoroughly should be enough, travis runs often enough
3682017-03-06T19:09:55 *** droark has quit IRC
3692017-03-06T19:10:39 <BlueMatt> yes
3702017-03-06T19:10:46 <BlueMatt> it should run every commit, no?
3712017-03-06T19:10:53 <BlueMatt> we might see it fail hours later, but at least it runs for each one
3722017-03-06T19:11:44 <wumpus> I don't think that's guaranteed. It runs every time it sees a new push
3732017-03-06T19:12:12 <BlueMatt> ahh, yes, race
3742017-03-06T19:12:14 <wumpus> which usually means it runs for every top-level commit as the merge script pushes them one at a time, but still
3752017-03-06T19:13:06 <wumpus> what is it with all those people reporting Ekiga build problems in our issue tracker
3762017-03-06T19:13:43 <sipa> ekiga?
3772017-03-06T19:13:57 <wumpus> apparently some VOIP program
3782017-03-06T19:14:15 <sipa> and what are they reporting? i haven't seen that
3792017-03-06T19:14:17 <wumpus> https://github.com/bitcoin/bitcoin/issues/3219#issuecomment-284464031
3802017-03-06T19:14:32 <wumpus> I first didn't notice they were talking about a different application
3812017-03-06T19:15:12 <gwillen> well, one person happened to get a match on the text of the error message
3822017-03-06T19:15:22 <sipa> hah
3832017-03-06T19:15:28 <BlueMatt> wtf
3842017-03-06T19:15:31 <wumpus> in any case, configure arguments suggestions port very badly between different applications
3852017-03-06T19:15:32 <gwillen> then google indexed the word 'ekiga' when they said it, and now everyone's getting linked to this bug when they google 'ekiga' and the error message :-)
3862017-03-06T19:15:41 <wumpus> lol that must be it
3872017-03-06T19:16:32 <gwillen> indeed, I just checked, that bug is the first hit for the error, and the second hit for 'ekiga' plus the error text.
3882017-03-06T19:17:20 *** wudayoda has joined #bitcoin-core-dev
3892017-03-06T19:22:10 *** wudayoda has quit IRC
3902017-03-06T19:52:02 *** dodomojo has joined #bitcoin-core-dev
3912017-03-06T19:56:40 *** dodomojo has quit IRC
3922017-03-06T19:59:49 *** moli_ has joined #bitcoin-core-dev
3932017-03-06T20:00:48 *** molz_ has quit IRC
3942017-03-06T20:14:31 *** dodomojo has joined #bitcoin-core-dev
3952017-03-06T20:16:16 *** dodomojo_ has joined #bitcoin-core-dev
3962017-03-06T20:19:46 *** dodomojo has quit IRC
3972017-03-06T20:21:18 *** wudayoda has joined #bitcoin-core-dev
3982017-03-06T20:22:29 *** dodomojo has joined #bitcoin-core-dev
3992017-03-06T20:24:13 *** dodomojo has quit IRC
4002017-03-06T20:24:45 *** dodomojo has joined #bitcoin-core-dev
4012017-03-06T20:25:22 *** dodomojo_ has quit IRC
4022017-03-06T20:25:38 *** wudayoda has quit IRC
4032017-03-06T20:35:34 <BlueMatt> wumpus: i cant verify your latest sha512 either
4042017-03-06T20:39:01 <wumpus> sigh :/
4052017-03-06T20:40:38 <wumpus> is it possible that the order is not deterministic?
4062017-03-06T20:40:41 <BlueMatt> hmmm, now I'm confused
4072017-03-06T20:40:43 <BlueMatt> i doubt it?
4082017-03-06T20:41:10 <wumpus> is it hashing any files which are not part of git, but linger around in the directory?
4092017-03-06T20:41:20 <BlueMatt> hmm, maybe I'm wrong, maybe your hash is right
4102017-03-06T20:41:28 <BlueMatt> cant tell from terminal history anymore :(
4112017-03-06T20:41:39 <wumpus> I'll check in a minute, after I push my tree
4122017-03-06T20:46:28 *** jnewbery has quit IRC
4132017-03-06T20:47:22 <wumpus> for me it matches
4142017-03-06T20:47:43 *** dodomojo has quit IRC
4152017-03-06T20:48:03 <wumpus> (using the python code, output is e55ce10bf7f2dc91de9797e60ab7767fb51f25255995d62ddf358c52b7aaa23c26fbfb522e1610ff950b86804ddbc38dc0d7708bfab2c4d33ad99a275d8c77db, which matches what is in the merge commit)
4162017-03-06T20:48:16 *** dodomojo has joined #bitcoin-core-dev
4172017-03-06T20:49:16 <wumpus> "git ls-tree --full-tree -r --name-only HEAD | LANG=C sort | xargs -n 1 sha512sum | sha512sum" gives the same output
4182017-03-06T20:49:43 <BlueMatt> yea, heisenbug
4192017-03-06T20:49:49 <BlueMatt> travis is failing on it but i cant find it
4202017-03-06T20:53:12 *** dodomojo has quit IRC
4212017-03-06T20:53:45 *** dodomojo has joined #bitcoin-core-dev
4222017-03-06T20:55:09 *** dodomojo_ has joined #bitcoin-core-dev
4232017-03-06T20:58:37 *** dodomojo has quit IRC
4242017-03-06T21:12:57 *** wudayoda has joined #bitcoin-core-dev
4252017-03-06T21:15:37 <BlueMatt> wumpus: yes, sipa meant to say LC_ALL when he said LANG (according to the sort man page)
4262017-03-06T21:17:46 *** wudayoda has quit IRC
4272017-03-06T21:25:01 <sipa> i thought i meant to say C, but maybe i thought wrong about what i meant
4282017-03-06T21:25:20 <BlueMatt> sipa: no, you have to set LC_ALL=C, not LANG=C
4292017-03-06T21:25:26 *** droark has joined #bitcoin-core-dev
4302017-03-06T21:28:58 *** wasi has quit IRC
4312017-03-06T21:29:28 *** wasi has joined #bitcoin-core-dev
4322017-03-06T21:34:05 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9932: Fix verify-commits on travis and always check top commit's tree (master...2017-03-fix-verify-commits) https://github.com/bitcoin/bitcoin/pull/9932
4332017-03-06T21:35:21 <sipa> BlueMatt: ahh!
4342017-03-06T21:38:54 <wumpus> whoops, yes, stupid locales :/
4352017-03-06T21:39:22 <BlueMatt> why travis has a different locale is beside me
4362017-03-06T21:39:38 <wumpus> the python version in github-merge.py shouldn't be affected
4372017-03-06T21:40:54 <wumpus> no idea what locale it sets, but it helped find this issue
4382017-03-06T21:41:03 <wumpus> which I suppose is good
4392017-03-06T21:41:25 <BlueMatt> fair
4402017-03-06T21:52:21 *** jnewbery has joined #bitcoin-core-dev
4412017-03-06T21:53:58 *** Guyver2 has quit IRC
4422017-03-06T22:05:40 <bitcoin-git> [bitcoin] jtimon closed pull request #9882: RPC: Introduce -rpcamountdecimals for the RPC to use other units than BTC (master...0.14.99-rpc-amounts) https://github.com/bitcoin/bitcoin/pull/9882
4432017-03-06T22:06:41 <jtimon> ping #9279
4442017-03-06T22:06:43 <gribble> https://github.com/bitcoin/bitcoin/issues/9279 | Consensus: Move CFeeRate out of libconsensus by jtimon · Pull Request #9279 · bitcoin/bitcoin · GitHub
4452017-03-06T22:15:59 *** juscamarena has quit IRC
4462017-03-06T22:17:00 *** wudayoda has joined #bitcoin-core-dev
4472017-03-06T22:21:48 *** wudayoda has quit IRC
4482017-03-06T22:22:58 *** chjj has quit IRC
4492017-03-06T22:35:12 *** pedrobranco has joined #bitcoin-core-dev
4502017-03-06T22:39:38 *** pedrobranco has quit IRC
4512017-03-06T22:48:25 *** cryptapus_afk is now known as cryptapus
4522017-03-06T22:54:49 *** chjj has joined #bitcoin-core-dev
4532017-03-06T22:55:37 *** jannes has quit IRC
4542017-03-06T23:00:04 *** cryptapus has joined #bitcoin-core-dev
4552017-03-06T23:00:23 *** cryptapus has joined #bitcoin-core-dev
4562017-03-06T23:06:24 *** cryptapus is now known as cryptapus_afk
4572017-03-06T23:47:38 *** jnewbery has quit IRC
4582017-03-06T23:48:39 *** bityogi has quit IRC