12017-04-11T00:09:42  *** bsm1175321 is now known as bsm117532
  22017-04-11T00:17:41  *** d_t has quit IRC
  32017-04-11T00:24:10  *** Ylbam has quit IRC
  42017-04-11T00:43:53  <bsm117532> Is there any way for a BIP37 SPV client to obtain the coinbase transaction, if he doesn't know its txid?
  52017-04-11T01:59:01  *** Samdney has quit IRC
  62017-04-11T02:00:07  *** dermoth has quit IRC
  72017-04-11T02:00:57  *** dermoth has joined #bitcoin-core-dev
  82017-04-11T02:09:52  *** d_t has joined #bitcoin-core-dev
  92017-04-11T02:13:57  <bitcoin-git> [bitcoin] jtimon opened pull request #10181: Include cleanup  (master...2017-04-10-includes) https://github.com/bitcoin/bitcoin/pull/10181
 102017-04-11T02:28:27  *** Giszmo has quit IRC
 112017-04-11T02:31:48  *** talmai has joined #bitcoin-core-dev
 122017-04-11T02:32:05  *** goksinen has joined #bitcoin-core-dev
 132017-04-11T02:36:40  *** justanotheruser has quit IRC
 142017-04-11T03:09:14  *** justanotheruser has joined #bitcoin-core-dev
 152017-04-11T03:21:21  *** talmai has quit IRC
 162017-04-11T03:27:42  *** abpa has joined #bitcoin-core-dev
 172017-04-11T03:28:44  *** abpa has quit IRC
 182017-04-11T03:46:08  *** n1ce has joined #bitcoin-core-dev
 192017-04-11T04:32:03  *** goksinen has quit IRC
 202017-04-11T04:45:10  *** jtimon has quit IRC
 212017-04-11T05:13:47  *** DigiByteDev has joined #bitcoin-core-dev
 222017-04-11T05:43:10  *** mol has quit IRC
 232017-04-11T05:45:38  *** moli_ has joined #bitcoin-core-dev
 242017-04-11T05:51:40  *** paveljanik has quit IRC
 252017-04-11T06:04:08  *** Ylbam has joined #bitcoin-core-dev
 262017-04-11T06:23:53  <jonasschnelli> jcorgan: I have started with BIP151... sipa also mentioned he want to work on this
 272017-04-11T06:46:51  *** kayamm has quit IRC
 282017-04-11T06:56:23  *** moli_ has quit IRC
 292017-04-11T06:57:44  <sipa> after the p2p network refactoringb:)
 302017-04-11T06:58:11  *** moli_ has joined #bitcoin-core-dev
 312017-04-11T07:00:56  *** BashCo has quit IRC
 322017-04-11T07:01:43  *** BashCo has joined #bitcoin-core-dev
 332017-04-11T07:03:58  <jcorgan> I'm mostly interested in authenticated addnode and connect over Tor, after which encryption is icing on the cake
 342017-04-11T07:04:22  <jcorgan> but willing to spend cycles on 151 if it helps advance the cause
 352017-04-11T07:04:40  *** kexkey has quit IRC
 362017-04-11T07:06:17  *** BashCo has quit IRC
 372017-04-11T07:06:50  <gmaxwell> jcorgan: our encryption is message auth + encryption, and auth needs message auth. the encryption is just gravy.
 382017-04-11T07:08:09  <wumpus> yes tor authenticates the hidden service you connect to, it can't be used to authenticate the incoming connection
 392017-04-11T07:08:22  <wumpus> so would still need something there
 402017-04-11T07:10:25  <jcorgan> got it
 412017-04-11T07:11:26  <jcorgan> let me know how i can fit in to your plans. time of course is always limited but this seems an area i can both help out in and is important to me personally.
 422017-04-11T07:11:38  <wumpus> encryption over tor hidden services is unnecessary, though I believe some sites do use e.g. https over tor to be able to have the tor endpoint communicate with the https endpoint "last mile" on an internal LAN encrypted
 432017-04-11T07:12:14  <wumpus> (this way, the tor endpoint cannot sniff the connection, it could mitm though)
 442017-04-11T07:12:27  <jcorgan> i always worry about exit nodes but they are really no different from any other chokepoint like an ISP
 452017-04-11T07:12:32  <gmaxwell> the HS encryption/auth is kind of weak, the HS-NG stuff is much stronger (and I believe even includes a post-quantum perfect forward secrecy, unless that didn't make it in).
 462017-04-11T07:13:18  <wumpus> yes I also avoid exit nodes as much as possible, a lot of services are available as onion nowadays
 472017-04-11T07:16:39  <bitcoin-git> [bitcoin] tjps opened pull request #10182: [scheduler] Switched CScheduler to C++11 threading primitives (master...tjps_scheduler) https://github.com/bitcoin/bitcoin/pull/10182
 482017-04-11T07:16:50  <wumpus> though I think it's mainly exit nodes that helped tor gain adoption, it's hard to get critical mass for an isolated network, as cjdns, i2p etc have found out
 492017-04-11T07:17:40  <wumpus> yes the new HS stuff sounds interesting, haven't looked at it in detail yet
 502017-04-11T07:18:04  <jcorgan> exit nodes are indeed crucial, but subject to both legal coercion and operation by less than friendly entities
 512017-04-11T07:18:34  <jcorgan> so as usual being able to do end-to-end authentication oneself is the only way to mitigate.
 522017-04-11T07:19:26  <jcorgan> as well as encryption using a key one can control, but with bitcoin traffic that seems less than essential
 532017-04-11T07:19:42  <wumpus> indeed; also exit node use is free, so what is the incentive. Seems lots of security researchers etc run them just to be able to sample traffic
 542017-04-11T07:20:33  *** BashCo has joined #bitcoin-core-dev
 552017-04-11T07:21:28  <jcorgan> anyway, jonasschnelli, when you get the time clue me in on how best to help your efforts and i'll let you know what i can commit to
 562017-04-11T07:21:43  <wumpus> well at least with HSes there are no exit nodes involved
 572017-04-11T07:33:17  *** mol has joined #bitcoin-core-dev
 582017-04-11T07:37:29  *** moli_ has quit IRC
 592017-04-11T07:57:21  <gmaxwell> petertodd: if you get a chance, please timestamp e2337a7e94f62658180b763e9c1afb70577e32cdad2b06dfce839558912a123f
 602017-04-11T08:27:27  *** davec has quit IRC
 612017-04-11T08:45:06  *** DigiByteDev has quit IRC
 622017-04-11T08:55:52  *** juscamarena has quit IRC
 632017-04-11T08:58:05  *** juscamarena has joined #bitcoin-core-dev
 642017-04-11T09:06:53  *** AaronvanW has quit IRC
 652017-04-11T09:07:49  *** d_t has quit IRC
 662017-04-11T09:08:14  *** AaronvanW has joined #bitcoin-core-dev
 672017-04-11T09:14:01  *** laurentmt has joined #bitcoin-core-dev
 682017-04-11T09:18:40  *** laurentmt has quit IRC
 692017-04-11T09:42:23  <bitcoin-git> [bitcoin] KibbledJiveElkZoo opened pull request #10183: Don't default rescan on private/public key imports. (master...rpc_rescan_fixes) https://github.com/bitcoin/bitcoin/pull/10183
 702017-04-11T10:16:56  *** JackH has joined #bitcoin-core-dev
 712017-04-11T10:29:02  *** d9b4bef9 has quit IRC
 722017-04-11T10:30:15  *** d9b4bef9 has joined #bitcoin-core-dev
 732017-04-11T10:33:16  *** wasi has quit IRC
 742017-04-11T10:59:09  *** jannes has joined #bitcoin-core-dev
 752017-04-11T11:22:12  *** To7 has quit IRC
 762017-04-11T11:32:34  <jonasschnelli> hmm... getaddrinfo on OSX seems not to respect the TTL... I get the same results as 1h ago from a seed.
 772017-04-11T11:32:50  <jonasschnelli> No problem on linux (get fresh addresses every time I call getaddrinfo)
 782017-04-11T11:36:26  <bitcoin-git> [bitcoin] NicolasDorier opened pull request #10184: [Wallet] Worst case performance improvement on KeyPool filtering (master...hdinternalperf) https://github.com/bitcoin/bitcoin/pull/10184
 792017-04-11T12:38:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 802017-04-11T12:43:12  *** laurentmt has joined #bitcoin-core-dev
 812017-04-11T12:43:15  *** jtimon has joined #bitcoin-core-dev
 822017-04-11T12:46:33  *** Samdney has joined #bitcoin-core-dev
 832017-04-11T13:12:00  *** d9b4bef9 has quit IRC
 842017-04-11T13:29:00  *** d9b4bef9 has joined #bitcoin-core-dev
 852017-04-11T13:32:07  <bitcoin-git> [bitcoin] sdaftuar opened pull request #10185: [0.14] Mention dbcache memory changes in release notes (0.14...2017-04-relnotes-0.14.1) https://github.com/bitcoin/bitcoin/pull/10185
 862017-04-11T13:33:07  <BlueMatt> cfields: do you have a take on #10182?
 872017-04-11T13:33:09  <gribble> https://github.com/bitcoin/bitcoin/issues/10182 | [scheduler] Switched CScheduler to C++11 threading primitives by tjps · Pull Request #10182 · bitcoin/bitcoin · GitHub
 882017-04-11T13:41:32  *** Chris_Stewart_5 has quit IRC
 892017-04-11T13:50:13  *** d_t has joined #bitcoin-core-dev
 902017-04-11T13:51:04  *** Guyver2 has joined #bitcoin-core-dev
 912017-04-11T13:53:24  *** Guyver2 has joined #bitcoin-core-dev
 922017-04-11T14:11:01  <cfields> BlueMatt: sure
 932017-04-11T14:30:51  *** Joseph__ has joined #bitcoin-core-dev
 942017-04-11T14:32:52  *** NewLiberty has quit IRC
 952017-04-11T14:33:13  *** NewLiberty_ has quit IRC
 962017-04-11T14:33:42  *** NewLiberty has joined #bitcoin-core-dev
 972017-04-11T14:34:51  <petertodd> gmaxwell: done. BTW there's a javascript timestamper on https://opentimestamps.org now, although it doesn't seem to work on my local version of firefox :(
 982017-04-11T14:37:26  <bitcoin-git> [bitcoin] jnewbery opened pull request #10186: Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number (master...remove_SYNC_TRANSACTION_NOT_IN_BLOCK_magic_number) https://github.com/bitcoin/bitcoin/pull/10186
 992017-04-11T14:45:46  <cfields> petertodd: neat!
1002017-04-11T14:47:00  <cfields> petertodd: why not allow a hash to be specified though? It's a shame I'd have to read the javascript to be sure I'm not actually revealing my file.
1012017-04-11T14:52:27  <jannes> petertodd: nit: "Company using OpenTimeStamps" should be "Companies...", I guess.
1022017-04-11T14:53:01  *** davec has joined #bitcoin-core-dev
1032017-04-11T15:19:48  *** belcher has quit IRC
1042017-04-11T15:28:40  *** kexkey has joined #bitcoin-core-dev
1052017-04-11T15:33:33  *** belcher has joined #bitcoin-core-dev
1062017-04-11T15:33:55  *** belcher is now known as Guest80844
1072017-04-11T15:37:27  *** To7 has joined #bitcoin-core-dev
1082017-04-11T15:44:19  *** kexkey_ has joined #bitcoin-core-dev
1092017-04-11T15:44:41  *** kexkey has quit IRC
1102017-04-11T15:46:28  *** abpa has joined #bitcoin-core-dev
1112017-04-11T15:58:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1122017-04-11T16:27:48  *** talmai has joined #bitcoin-core-dev
1132017-04-11T16:33:10  *** paveljanik has joined #bitcoin-core-dev
1142017-04-11T16:33:11  *** paveljanik has joined #bitcoin-core-dev
1152017-04-11T16:39:47  <jcorgan> what are the various version numbers (0.2, 0.3, etc.) seen in the uasf trackers? my google-fu has deserted me today
1162017-04-11T16:41:26  <instagibbs> jcorgan, some other repo's numbering of bip148
1172017-04-11T16:42:08  *** annanay25 has quit IRC
1182017-04-11T16:42:14  <bincap> jcorgan: there were some proposals, and they used various versions.  activation date was other in old one afair
1192017-04-11T16:42:19  *** annanay25 has joined #bitcoin-core-dev
1202017-04-11T16:42:30  <jcorgan> ah, got it
1212017-04-11T16:59:33  *** Chris_Stewart_5 has quit IRC
1222017-04-11T17:06:54  *** d9b4bef9 has quit IRC
1232017-04-11T17:10:00  *** d9b4bef9 has joined #bitcoin-core-dev
1242017-04-11T17:12:33  *** talmai has quit IRC
1252017-04-11T17:14:38  *** talmai has joined #bitcoin-core-dev
1262017-04-11T17:15:16  *** BashCo has quit IRC
1272017-04-11T17:15:52  *** BashCo has joined #bitcoin-core-dev
1282017-04-11T17:17:10  *** jtimon has quit IRC
1292017-04-11T17:20:10  *** BashCo has quit IRC
1302017-04-11T17:37:30  <wumpus> I don't understand what's wrong with travis on master
1312017-04-11T17:37:47  <wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/220971234 shows as a failed build, but the build, the unit tests and the functional tests seem to pass
1322017-04-11T17:38:08  <wumpus> same for https://travis-ci.org/bitcoin/bitcoin/jobs/220971232
1332017-04-11T17:38:27  <wumpus> did something mess up the return codes?
1342017-04-11T17:39:21  <BlueMatt> yes
1352017-04-11T17:39:23  <BlueMatt> "The command "if [ "$RUN_TESTS" = "true" ]; then test/functional/test_runner.py --coverage --quiet ${extended}; fi" exited with 1.
1362017-04-11T17:39:23  <BlueMatt> "
1372017-04-11T17:39:28  <BlueMatt> jnewbery:
1382017-04-11T17:40:20  <wumpus> oh I see, apparently it sees a skipped tests as a failure, in the final check
1392017-04-11T17:40:51  <BlueMatt> ahh, cool
1402017-04-11T17:41:45  <jnewbery> yes - my fault. Here: https://github.com/bitcoin/bitcoin/commit/63062bda1ac0b57cb92e663596650a6e42508f15#diff-a5b9b84e3a3387476629e74ddb227a7eL271
1412017-04-11T17:41:54  <jnewbery> it'll only cause travis to fail for cron jobs
1422017-04-11T17:42:00  <jnewbery> sorry. I'll PR a fix
1432017-04-11T17:42:32  <wumpus> already working on it
1442017-04-11T17:44:04  <jnewbery> s/test_result.status == "Passed"/test_result.status != "Failed"/
1452017-04-11T17:45:27  <wumpus> yes, well, I'm adding a was_succesful property to TestResult and putting the string check there
1462017-04-11T17:47:00  <jnewbery> ok, let me know the PR number and I'm happy to review
1472017-04-11T17:52:54  <bitcoin-git> [bitcoin] laanwj opened pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187
1482017-04-11T17:53:03  *** moli_ has joined #bitcoin-core-dev
1492017-04-11T17:54:37  *** bsm1175321 has joined #bitcoin-core-dev
1502017-04-11T17:55:40  *** mol has quit IRC
1512017-04-11T18:02:06  <wumpus> hrm the wallet_dump.py test seems to fail locally here
1522017-04-11T18:02:08  *** d_t has joined #bitcoin-core-dev
1532017-04-11T18:07:06  <jnewbery> try clearing the cache
1542017-04-11T18:07:27  <jnewbery> hd split causes a couple of tests to fail if the cache isn't cleared
1552017-04-11T18:08:29  <wumpus> gah.. yes, afraid it is the cache again
1562017-04-11T18:09:30  <BlueMatt> sipa: yo
1572017-04-11T18:09:41  *** EZVPyrTvgJYiEpQZ has joined #bitcoin-core-dev
1582017-04-11T18:10:19  <instagibbs> I have "rm -r cache/" on hotkey by now
1592017-04-11T18:10:44  <jnewbery> I'm tempted to PR removing the cache at the start of each test_runner run
1602017-04-11T18:11:15  <wumpus> jnewbery: yes please
1612017-04-11T18:12:06  <BlueMatt> sipa: I'm super confused on #10148: did you get hashUpto and hashBest confused in ReplayBlocks? The way I read BatchWrite hashBest is the block which has been fully flushed, upto is the possible-partially-flushed tip. But ReplayBlocks seems to use them the other way
1622017-04-11T18:12:07  <gribble> https://github.com/bitcoin/bitcoin/issues/10148 | Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
1632017-04-11T18:12:34  <wumpus> adds a few seconds to the test run in worst-case, but saves a lot of seconds in thinking/troubleshooting time when the tests fail for inexplcable reasons again
1642017-04-11T18:13:28  <jnewbery> wumpus: agreed
1652017-04-11T18:14:01  <wumpus> and for travis it won't even make a difference
1662017-04-11T18:29:16  <sipa> BlueMatt: yes, you read it correctly
1672017-04-11T18:31:25  <sipa> you first update upto, so that if you crash in the middle, Best is still the old best, and Upto is the new one
1682017-04-11T18:31:50  <sipa> then at startup you process the blocks between Best and Upto, in that order
1692017-04-11T18:31:59  *** EZVPyrTvgJYiEpQZ has quit IRC
1702017-04-11T18:32:31  <BlueMatt> ohoh, yes, i confused myself
1712017-04-11T18:56:38  *** kadoban has quit IRC
1722017-04-11T18:57:03  *** kadoban has joined #bitcoin-core-dev
1732017-04-11T19:08:03  *** jtimon has joined #bitcoin-core-dev
1742017-04-11T19:17:55  *** e4xit has joined #bitcoin-core-dev
1752017-04-11T19:21:50  *** BashCo has joined #bitcoin-core-dev
1762017-04-11T19:23:44  <petertodd> cfields: I think that's a good idea! though the guys who did the website might prefer that functionality be an "advanced" option
1772017-04-11T19:24:16  <petertodd> cfields: also, there's actually a hex operator in the opentimestamps standard, so if you timestamp a file containing a hex-encoded digest, you can later convert that into a timestamp directly on the file itself
1782017-04-11T19:30:42  <petertodd> jannes: thanks! filed a pull-req for that
1792017-04-11T19:42:40  *** talmai has quit IRC
1802017-04-11T20:09:23  *** Alina-malina has quit IRC
1812017-04-11T20:10:03  *** Alina-malina has joined #bitcoin-core-dev
1822017-04-11T20:12:29  *** Alina-malina has quit IRC
1832017-04-11T20:12:29  *** Alina-malina has joined #bitcoin-core-dev
1842017-04-11T20:15:37  <cfields> petertodd: ah, sha256d finally explained :p
1852017-04-11T20:16:56  *** e4xit has quit IRC
1862017-04-11T20:30:20  *** moctos has quit IRC
1872017-04-11T20:35:39  <bitcoin-git> [bitcoin] theuni opened pull request #10189: devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. (master...private-nodeid) https://github.com/bitcoin/bitcoin/pull/10189
1882017-04-11T20:38:38  *** Guest80844 has quit IRC
1892017-04-11T20:42:26  *** BashCo has quit IRC
1902017-04-11T20:52:56  <bitcoin-git> [bitcoin] jnewbery opened pull request #10190: Mining functional tests (including regression test for submitblock) (master...mining_functional_test) https://github.com/bitcoin/bitcoin/pull/10190
1912017-04-11T20:59:29  <jtimon> cfields: #10189 is awesome! independently of it being validated by travis (which is awesome), if I had used scripts instead of emacs and kept them in the commit messages like here some disruptive would have been so simple to rebase and review (I mean, not that that kind of change is hard to review, but even simpler with this). Now it seems so obvious that I feel kind of stupid for not having thought about it before
1922017-04-11T20:59:30  <gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
1932017-04-11T21:00:28  <cfields> jtimon: hehe, glad you like it. I was going to poke you to check it out, but you beat me to it :)
1942017-04-11T21:02:33  <cfields> jtimon: and now we have some incentive to write a few simple scripts to move chunks of code around. Combining those two things, that should make reviewing move-only changes much simpler
1952017-04-11T21:03:18  <cfields> ofc they still have to be reviewed for correctness (and correctness of the script), but at least it's easy to see where the changes come from.
1962017-04-11T21:04:20  <jtimon> right, and again trivial to rebase (just run the script again to rewrite the commit, trivial)
1972017-04-11T21:04:40  <cfields> jtimon: yep
1982017-04-11T21:04:41  <jtimon> I just saw it by accident but it is very exciting to me
1992017-04-11T21:06:10  <jtimon> cfields: how stable is it? I saw you force pushed recently
2002017-04-11T21:06:32  <jtimon> I assume a simple last minute fix
2012017-04-11T21:06:40  <cfields> jtimon: i need to force probably one more time. Travis' environment is kinda weird, they build from a detached head
2022017-04-11T21:09:25  <jtimon> cfields: let me know when you're finished, I want to test it by writting something else using it
2032017-04-11T21:10:01  <cfields> jtimon: ok. Pushed. Finished if Travis is happy with that last one.
2042017-04-11T21:11:34  <jtimon> btw, maybe we could add something to the dev notes about using a specific prefix to identiy this kind of commit, maybe "scripted-diff: net: Use accessor rather than node's id directly" or "net: scripted-diff: Use accessor rather than node's id directly"
2052017-04-11T21:15:20  <cfields> sure, that makes sense
2062017-04-11T21:16:15  <jtimon> it's a way to make it more explicit that those are easier to review thanks to the scripts
2072017-04-11T21:16:25  <cfields> jtimon: be careful if you're using it locally. It uses your live repo/workdir. It attempts to put everything back the way it found it, but I certainly wouldn't trust that for now.
2082017-04-11T21:17:22  <cfields> (it works by detaching HEAD, reverting the commit in question, running the script, and comparing the result to HEAD^)
2092017-04-11T21:17:28  <cfields> yep, agreed
2102017-04-11T21:17:30  <jtimon> thanks for the heads up, I will copy the workdir just in case before using it
2112017-04-11T21:18:25  *** laurentmt has quit IRC
2122017-04-11T21:29:22  <bitcoin-git> [bitcoin] jnewbery opened pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
2132017-04-11T21:43:27  <bitcoin-git> [bitcoin] jnewbery closed pull request #10191: [trivial] Remove unused submit block parameters argument (master...remove_submit_block_params) https://github.com/bitcoin/bitcoin/pull/10191
2142017-04-11T21:45:38  *** bsm1175321 has quit IRC
2152017-04-11T21:57:31  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10192: Cache full script execution results in addition to signatures (master...2017-04-cache-scriptchecks) https://github.com/bitcoin/bitcoin/pull/10192
2162017-04-11T21:58:27  <BlueMatt> ^ 1.7x faster in naive braindead benchmark, yay
2172017-04-11T21:58:37  *** Halo has joined #bitcoin-core-dev
2182017-04-11T21:59:11  *** Guyver2 has quit IRC
2192017-04-11T22:00:30  *** belcher has joined #bitcoin-core-dev
2202017-04-11T22:00:53  *** belcher is now known as Guest61146
2212017-04-11T22:03:05  *** Halo has quit IRC
2222017-04-11T22:09:53  *** d9b4bef9 has quit IRC
2232017-04-11T22:10:25  * cfields suppresses his initial reaction and reads the PR in full
2242017-04-11T22:11:00  *** d9b4bef9 has joined #bitcoin-core-dev
2252017-04-11T22:11:01  <gmaxwell> It's logically the same as the ecdsa cache but more efficient most of the time.
2262017-04-11T22:11:22  <gmaxwell> (except in the case of certian dos attacks, which is part of why we didn't change the signature cache to work that way.
2272017-04-11T22:11:25  <gmaxwell> )
2282017-04-11T22:13:00  <BlueMatt> indeed, that is pointed out in the PR text
2292017-04-11T22:13:16  <BlueMatt> the win I measured is just overhead of spinning up the sigcache stuff
2302017-04-11T22:13:21  <BlueMatt> s/sigcache/sigcheck threads/
2312017-04-11T22:13:32  <BlueMatt> and looping over the scripts, even with sigcache set to always return true
2322017-04-11T22:13:49  <gmaxwell> well it's also just a lot less work, doesn't have to run the signature hashing, doesn't have to hash the message hash to look up in the cash, does a lot less lookup.
2332017-04-11T22:13:58  <BlueMatt> (hence why i stopped at 284k - thats the first block which has a tx which checks that a signature is NOT valid)
2342017-04-11T22:14:04  <BlueMatt> yup
2352017-04-11T22:18:36  <cfields> huh.
2362017-04-11T22:20:40  <gmaxwell> BlueMatt: when you made the sigcache return true, where did you do that? pre or post its internal hashing?
2372017-04-11T22:20:54  <BlueMatt> s/return false/return true/
2382017-04-11T22:20:55  <BlueMatt> so post
2392017-04-11T22:21:00  <BlueMatt> but compiler may have optimized it all out
2402017-04-11T22:21:05  <BlueMatt> its internal hashing is cheap, though
2412017-04-11T22:21:13  <BlueMatt> its just getting bytes out of the uint256
2422017-04-11T22:22:14  <gmaxwell> not that internal hashing, the signature cache SHA256(message|pubkey|flags) and uses the result as the key.
2432017-04-11T22:22:26  <BlueMatt> ohoh, very much post that
2442017-04-11T22:22:45  <BlueMatt> sipa: did you misread the ")" in the patch?
2452017-04-11T22:22:50  <BlueMatt> it is outside of getarg?
2462017-04-11T22:27:41  *** Guest61146 is now known as belcher
2472017-04-11T22:27:44  *** belcher has joined #bitcoin-core-dev
2482017-04-11T22:32:33  *** hsmiths has quit IRC
2492017-04-11T22:35:19  *** jannes has quit IRC
2502017-04-11T22:39:10  <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10125: Exit bitcoind immediately on shutdown instead of 200ms later (master...2017-03-faster-shutdown) https://github.com/bitcoin/bitcoin/pull/10125
2512017-04-11T22:46:17  <cfields> jtimon: pushed one last version. Sorry. Really done now.
2522017-04-11T22:58:59  <jtimon> cfields: awesome, no worries, was doing something else
2532017-04-11T22:59:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67023e9004ba...b44adf92342a
2542017-04-11T22:59:45  <bitcoin-git> bitcoin/master e96462f Wladimir J. van der Laan: tests: Fix test_runner return value in case of skipped test...
2552017-04-11T22:59:46  <bitcoin-git> bitcoin/master b44adf9 MarcoFalke: Merge #10187: tests: Fix test_runner return value in case of skipped test...
2562017-04-11T23:00:14  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10187: tests: Fix test_runner return value in case of skipped test (master...2017_04_fix_tracis) https://github.com/bitcoin/bitcoin/pull/10187
2572017-04-11T23:01:23  <jtimon> but yeah, I plan to give a "tested ack by opening this other pr, making it fail on purpose as you can see in this travis link and then fixing it by squashing the part that was left out on purpuse" to #10189
2582017-04-11T23:01:24  <gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
2592017-04-11T23:05:02  <jtimon> now I'm mostly worried about GITHUB_MAX_OPENED_PRS_PER_PROJECT if everyone reviews 10189 like that :p
2602017-04-11T23:29:39  *** AaronvanW has quit IRC
2612017-04-11T23:36:24  *** hsmiths has joined #bitcoin-core-dev
2622017-04-11T23:57:38  *** abpa has quit IRC