12017-04-18T00:16:44 *** Guest84617 has joined #bitcoin-core-dev
22017-04-18T00:19:08 *** chjj has quit IRC
32017-04-18T00:21:05 *** AaronvanW has quit IRC
42017-04-18T00:21:06 *** laurentmt has quit IRC
52017-04-18T00:24:08 *** AaronvanW has joined #bitcoin-core-dev
62017-04-18T00:27:03 <bitcoin-git> [bitcoin] jimmysong opened pull request #10223: Tests: Refactor to create witness script creation function (master...refactor_blocktools_for_segwit) https://github.com/bitcoin/bitcoin/pull/10223
72017-04-18T00:28:36 *** Dyaheon has joined #bitcoin-core-dev
82017-04-18T00:30:57 *** Ylbam has quit IRC
92017-04-18T00:32:53 *** chjj has joined #bitcoin-core-dev
102017-04-18T00:33:58 *** AaronvanW has quit IRC
112017-04-18T00:37:29 *** AaronvanW has joined #bitcoin-core-dev
122017-04-18T00:39:14 *** d_t has joined #bitcoin-core-dev
132017-04-18T00:43:55 *** Guest84617 has quit IRC
142017-04-18T00:52:31 *** AaronvanW has quit IRC
152017-04-18T00:54:55 *** AaronvanW has joined #bitcoin-core-dev
162017-04-18T01:06:54 *** goksinen has joined #bitcoin-core-dev
172017-04-18T01:08:24 *** goksinen has joined #bitcoin-core-dev
182017-04-18T01:08:35 *** AaronvanW has quit IRC
192017-04-18T01:12:21 *** AaronvanW has joined #bitcoin-core-dev
202017-04-18T01:18:40 *** chjj has quit IRC
212017-04-18T01:24:07 *** talmai has joined #bitcoin-core-dev
222017-04-18T01:26:07 *** goksinen has quit IRC
232017-04-18T01:26:34 *** goksinen has joined #bitcoin-core-dev
242017-04-18T01:32:28 *** chjj has joined #bitcoin-core-dev
252017-04-18T01:34:05 *** tw2006 has joined #bitcoin-core-dev
262017-04-18T01:34:23 *** talmai has quit IRC
272017-04-18T01:38:36 *** tw2006 has quit IRC
282017-04-18T01:47:27 <bitcoin-git> [bitcoin] jimmysong opened pull request #10224: Tests: Add simple test for getaddednodeinfo (master...test_getaddednodeinfo) https://github.com/bitcoin/bitcoin/pull/10224
292017-04-18T01:54:43 *** AaronvanW has quit IRC
302017-04-18T01:56:13 *** d_t has quit IRC
312017-04-18T01:56:57 *** AaronvanW has joined #bitcoin-core-dev
322017-04-18T01:57:58 *** belcher has quit IRC
332017-04-18T02:03:05 *** AaronvanW has quit IRC
342017-04-18T02:05:04 *** AaronvanW has joined #bitcoin-core-dev
352017-04-18T02:14:22 *** e4xit has quit IRC
362017-04-18T02:14:46 *** AaronvanW has quit IRC
372017-04-18T02:19:32 *** AaronvanW has joined #bitcoin-core-dev
382017-04-18T02:21:42 *** talmai has joined #bitcoin-core-dev
392017-04-18T02:27:17 *** ensign has quit IRC
402017-04-18T02:27:45 *** nsh has quit IRC
412017-04-18T02:31:24 <midnightmagic> sipa: What does the green spike represent here in your graph? http://bitcoin.sipa.be/ver9-50k.png
422017-04-18T02:32:16 <achow101> midnightmagic: that's csv signalling
432017-04-18T02:33:00 <midnightmagic> achow101: Thanks. I'm colourblind. I thought the blue line next to the first 144 block average was green.
442017-04-18T02:33:14 *** ensign has joined #bitcoin-core-dev
452017-04-18T02:34:44 *** nsh has joined #bitcoin-core-dev
462017-04-18T02:36:43 *** AaronvanW has quit IRC
472017-04-18T02:45:13 *** dermoth_ has joined #bitcoin-core-dev
482017-04-18T02:45:42 *** dermoth has quit IRC
492017-04-18T02:45:45 *** dermoth_ is now known as dermoth
502017-04-18T03:16:27 *** baldur has joined #bitcoin-core-dev
512017-04-18T03:21:06 *** baldur has quit IRC
522017-04-18T03:23:00 *** tw2006 has joined #bitcoin-core-dev
532017-04-18T03:27:36 *** tw2006 has quit IRC
542017-04-18T03:32:40 *** str4d has joined #bitcoin-core-dev
552017-04-18T03:42:10 *** str4d has quit IRC
562017-04-18T04:15:30 <NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/pull/10195 is really too hard to review for me. I think an easier approach for review, would be to make a first PR which only change CCoinView class while making no change to the underlying storage. Then a second PR dealing with the storage change/optimization.
572017-04-18T04:17:45 <NicolasDorier> by "change to CCoinView" I mean only the method signatures to be per txout
582017-04-18T04:18:12 <NicolasDorier> without changing any underlying storage
592017-04-18T04:23:33 *** AaronvanW has joined #bitcoin-core-dev
602017-04-18T04:26:36 *** SopaXorzTaker has joined #bitcoin-core-dev
612017-04-18T04:27:54 *** goksinen has quit IRC
622017-04-18T04:28:20 *** AaronvanW has quit IRC
632017-04-18T04:36:09 *** baldur has joined #bitcoin-core-dev
642017-04-18T05:04:37 *** AaronvanW has joined #bitcoin-core-dev
652017-04-18T05:09:46 *** AaronvanW has quit IRC
662017-04-18T05:11:55 *** tw2006 has joined #bitcoin-core-dev
672017-04-18T05:13:58 *** AaronvanW has joined #bitcoin-core-dev
682017-04-18T05:16:29 *** tw2006 has quit IRC
692017-04-18T05:19:52 <sipa> NicolasDorier: there is no easy way first do one without the other, but i'll try
702017-04-18T05:20:23 <sipa> NicolasDorier: and signatures have nothing to do with it
712017-04-18T05:20:34 <NicolasDorier> I said method signature
722017-04-18T05:20:53 <NicolasDorier> ie like GetCoins() is per Outpoint instead of uint256
732017-04-18T05:21:09 <sipa> also, please review #10408 first
742017-04-18T05:21:09 <gribble> https://github.com/bitcoin/bitcoin/issues/10408 | HTTP Error 404: Not Found
752017-04-18T05:21:18 <sipa> ah yes, my apologies!
762017-04-18T05:22:08 <NicolasDorier> you were in the wrong namespace => using OOP; :D
772017-04-18T05:22:20 *** AaronvanW has quit IRC
782017-04-18T05:22:45 <NicolasDorier> mmh 10408 does not exist
792017-04-18T05:22:52 <NicolasDorier> ha
802017-04-18T05:22:59 <NicolasDorier> https://github.com/bitcoin/bitcoin/pull/10148 you mean ?
812017-04-18T05:26:13 <sipa> yes indeed
822017-04-18T05:26:26 <sipa> sorry, i just woke up
832017-04-18T05:27:18 *** paveljanik has quit IRC
842017-04-18T05:27:25 *** pavel_ has joined #bitcoin-core-dev
852017-04-18T05:27:45 *** AaronvanW has joined #bitcoin-core-dev
862017-04-18T05:27:57 *** pavel_ has quit IRC
872017-04-18T05:30:24 <NicolasDorier> sipa: I will try myself to just change CCoinView signature
882017-04-18T05:30:35 <NicolasDorier> method signatures
892017-04-18T05:30:52 <NicolasDorier> will make a PR if it is usable and indeed easier to review
902017-04-18T05:31:35 <NicolasDorier> will try that today after reviewing https://github.com/bitcoin/bitcoin/pull/10148
912017-04-18T05:31:42 <sipa> NicolasDorier: that's very nontrivial
922017-04-18T05:31:54 <sipa> you'd need a translation layer with ths database
932017-04-18T05:32:27 <sipa> if you create one, i'll happily include, though?
942017-04-18T05:32:32 <sipa> s/?/!/
952017-04-18T05:32:37 <NicolasDorier> ok I will try
962017-04-18T05:33:25 <sipa> it may be easier to do the opposite; first change the db and then CCoinsView
972017-04-18T05:35:40 <sipa> because all that needs is a loop at read or write time to merge the db records/split ccoims
982017-04-18T05:36:38 <NicolasDorier> Not really related to the PR but tricky: https://github.com/bitcoin/bitcoin/blob/2584925077f9658b3953ad931b74779006e59807/src/validation.cpp#L1591 . fClean is passed either as pointer or return value. If pointer is used, return value is useless.
992017-04-18T05:38:43 *** AaronvanW has quit IRC
1002017-04-18T05:38:54 <sipa> no, the return value still indicates disk corruption
1012017-04-18T05:39:05 <sipa> pfClean is only for database inconsistencies
1022017-04-18T05:39:57 <sipa> i'll add a comment to explain
1032017-04-18T05:41:10 *** AaronvanW has joined #bitcoin-core-dev
1042017-04-18T05:42:38 <sipa> but thank you very much for having a look at these PRs
1052017-04-18T05:42:50 <sipa> i know they're pretty invasive
1062017-04-18T05:48:20 *** RubenSomsen has joined #bitcoin-core-dev
1072017-04-18T05:50:35 *** AaronvanW has quit IRC
1082017-04-18T06:05:52 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d86bb075bf6d...393160cf6cda
1092017-04-18T06:05:53 <bitcoin-git> bitcoin/master 75a08e7 Kalle Alm: [wallet] Add support for aborting wallet transaction rescans.
1102017-04-18T06:05:54 <bitcoin-git> bitcoin/master 9141622 Kalle Alm: [rpc] Add abortrescan command to RPC interface.
1112017-04-18T06:05:54 <bitcoin-git> bitcoin/master 393160c Wladimir J. van der Laan: Merge #10208: [wallet] Rescan abortability...
1122017-04-18T06:06:12 <bitcoin-git> [bitcoin] laanwj closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
1132017-04-18T06:25:50 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/393160cf6cda...a86255b11633
1142017-04-18T06:25:51 <bitcoin-git> bitcoin/master 846dc17 Kalle Alm: [doc] Wording fixes in CONTRIBUTING.md.
1152017-04-18T06:25:51 <bitcoin-git> bitcoin/master 3ddd227 Kalle Alm: [doc] Add blob about finding reviewers.
1162017-04-18T06:25:52 <bitcoin-git> bitcoin/master a86255b Wladimir J. van der Laan: Merge #10211: [doc] Contributor fixes & new "finding reviewers" section...
1172017-04-18T06:26:08 <bitcoin-git> [bitcoin] laanwj closed pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
1182017-04-18T06:29:03 *** AaronvanW has joined #bitcoin-core-dev
1192017-04-18T06:29:34 *** Ylbam has joined #bitcoin-core-dev
1202017-04-18T06:29:50 *** d9b4bef9 has quit IRC
1212017-04-18T06:30:57 *** d9b4bef9 has joined #bitcoin-core-dev
1222017-04-18T06:33:30 *** Giszmo has quit IRC
1232017-04-18T06:34:20 *** AaronvanW has quit IRC
1242017-04-18T06:40:57 *** AaronvanW has joined #bitcoin-core-dev
1252017-04-18T06:49:27 <sipa> wumpus: not sure if you know this, but you can run with -reindex, make it process a couple block files, and then abort and restart with -reindex-chainstate
1262017-04-18T06:49:45 <sipa> that will just make it fully process those couple files
1272017-04-18T06:49:51 <wumpus> didn't know that, thanks
1282017-04-18T06:50:05 *** AaronvanW has quit IRC
1292017-04-18T06:51:02 *** talmai has quit IRC
1302017-04-18T06:55:05 *** AaronvanW has joined #bitcoin-core-dev
1312017-04-18T07:00:51 *** tw2006 has joined #bitcoin-core-dev
1322017-04-18T07:05:24 *** tw2006 has quit IRC
1332017-04-18T07:09:21 *** AaronvanW has quit IRC
1342017-04-18T07:23:58 *** rockhouse has joined #bitcoin-core-dev
1352017-04-18T07:24:24 *** rockhouse has joined #bitcoin-core-dev
1362017-04-18T07:29:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a86255b11633...9111df9673be
1372017-04-18T07:29:20 <bitcoin-git> bitcoin/master 637706d Jimmy Song: Tests: Put Extended tests first when they're included...
1382017-04-18T07:29:20 <bitcoin-git> bitcoin/master 9111df9 MarcoFalke: Merge #10219: Tests: Order Python Tests Differently...
1392017-04-18T07:29:30 *** SopaXorzTaker has quit IRC
1402017-04-18T07:29:37 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10219: Tests: Order Python Tests Differently (master...order_tests_by_duration) https://github.com/bitcoin/bitcoin/pull/10219
1412017-04-18T07:29:49 *** SopaXorzTaker has joined #bitcoin-core-dev
1422017-04-18T07:53:29 *** AaronvanW has joined #bitcoin-core-dev
1432017-04-18T08:03:10 *** AaronvanW has quit IRC
1442017-04-18T08:05:01 *** To7 has quit IRC
1452017-04-18T08:13:32 <bitcoin-git> [bitcoin] kallewoof opened pull request #10225: [test] Add aborttrescan tests (master...abort-rescan-tests) https://github.com/bitcoin/bitcoin/pull/10225
1462017-04-18T08:16:29 *** davec has quit IRC
1472017-04-18T08:18:38 *** laurentmt has joined #bitcoin-core-dev
1482017-04-18T08:20:15 *** laurentmt has quit IRC
1492017-04-18T08:27:41 *** davec has joined #bitcoin-core-dev
1502017-04-18T08:41:40 *** SopaXorzTaker has quit IRC
1512017-04-18T08:45:44 *** d_t has joined #bitcoin-core-dev
1522017-04-18T08:49:52 *** tw2006 has joined #bitcoin-core-dev
1532017-04-18T08:54:45 *** tw2006 has quit IRC
1542017-04-18T08:55:09 *** SopaXorzTaker has joined #bitcoin-core-dev
1552017-04-18T09:28:34 *** laurentmt has joined #bitcoin-core-dev
1562017-04-18T09:32:13 *** jannes has joined #bitcoin-core-dev
1572017-04-18T09:42:22 *** thrasher` has quit IRC
1582017-04-18T09:46:53 *** thrasher` has joined #bitcoin-core-dev
1592017-04-18T09:49:44 *** vicenteH has joined #bitcoin-core-dev
1602017-04-18T10:17:25 *** AaronvanW has joined #bitcoin-core-dev
1612017-04-18T10:26:50 *** d9b4bef9 has quit IRC
1622017-04-18T10:28:06 *** d9b4bef9 has joined #bitcoin-core-dev
1632017-04-18T10:38:45 *** tw2006 has joined #bitcoin-core-dev
1642017-04-18T10:43:26 *** tw2006 has quit IRC
1652017-04-18T10:45:12 *** Guyver2 has joined #bitcoin-core-dev
1662017-04-18T11:12:53 <SopaXorzTaker> Can anyone do me a favor?
1672017-04-18T11:13:03 <SopaXorzTaker> please broadcast this nonstandard tx: 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000'
1682017-04-18T11:13:23 <SopaXorzTaker> (remove the trailing quote, of course)
1692017-04-18T11:17:20 <jonasschnelli> SopaXorzTaker: broadcast yourself?
1702017-04-18T11:17:28 <wumpus> only makes sense to send it direct to miners, broadcasting it will just cause it to be ignored/rejected
1712017-04-18T11:17:51 <wumpus> my nodes don't want it at least
1722017-04-18T11:18:42 <jonasschnelli> Ah. It's non-std. Yes. maybe google the miners IP and use something like https://github.com/libbtc/libbtc#the-bitcoin-send-tx-cli
1732017-04-18T11:22:28 <SopaXorzTaker> jonasschnelli, thanks
1742017-04-18T11:22:32 <SopaXorzTaker> I alrready found that
1752017-04-18T11:22:41 <SopaXorzTaker> I am currently doing just that, too
1762017-04-18T11:29:05 *** petertodd has quit IRC
1772017-04-18T11:29:26 <SopaXorzTaker> jonasschnelli, I can't
1782017-04-18T11:29:34 <SopaXorzTaker> I will have to compile bitcoind
1792017-04-18T11:29:57 <jonasschnelli> SopaXorzTaker: why?
1802017-04-18T11:30:40 <SopaXorzTaker> lazy
1812017-04-18T11:30:49 <SopaXorzTaker> Arch doesn't install it
1822017-04-18T11:31:01 <SopaXorzTaker> and if it did, I'd have to download the blockchain
1832017-04-18T11:31:09 <SopaXorzTaker> I have to compile it myself without the checks
1842017-04-18T11:31:54 <sipa> no offence, but this channel is about development of bitcoin core
1852017-04-18T11:32:09 <sipa> if you're not planning to even run it, why are you here?
1862017-04-18T11:32:29 <SopaXorzTaker> I am compiling it now
1872017-04-18T11:32:36 <SopaXorzTaker> that'd take a while
1882017-04-18T11:32:38 <SopaXorzTaker> and I am bored
1892017-04-18T11:33:05 <sipa> ok :)
1902017-04-18T11:46:03 <SopaXorzTaker> tx e1995a7ee78fd11a24591e35f3a7d3cda92c6cf4126879a8e133377d85906284
1912017-04-18T12:01:32 <SopaXorzTaker> sipa, could you do it
1922017-04-18T12:01:43 <SopaXorzTaker> " sendrawtransaction 0100000001af73ff160d0434f1d8da871552ba06b1c24af1e91b494b2f4cbe25457eb9734300000000080106010701000100ffffffff01e0090200000000001976a914f6746dece46a2cd331f9ff7960135bcb587862ac88ac00000000"
1932017-04-18T12:01:51 <SopaXorzTaker> with a full blockchain, obviously
1942017-04-18T12:02:27 <sipa> SopaXorzTaker: i tried, it would reject it because it's nonstandard
1952017-04-18T12:02:39 <sipa> SopaXorzTaker: and modifying the code wouldn't help, as other peers would reject it too
1962017-04-18T12:02:48 <sipa> you need to send it directly to miners, as you were told above
1972017-04-18T12:04:40 <wumpus> yes I tried that about an hour ago, on a few nodes. Please don't repeat yourself. This channel is not for idle bitcoin discussion or technical help but for development discussion
1982017-04-18T12:11:56 *** To7 has joined #bitcoin-core-dev
1992017-04-18T12:27:41 *** tw2006 has joined #bitcoin-core-dev
2002017-04-18T12:32:12 *** tw2006 has quit IRC
2012017-04-18T12:33:59 <bitcoin-git> [bitcoin] laanwj closed pull request #10220: Experiment: test: Disable fsync in travis tests (master...2017_04_tests_eatmydata) https://github.com/bitcoin/bitcoin/pull/10220
2022017-04-18T12:38:40 *** NewLiberty has quit IRC
2032017-04-18T12:39:39 *** paveljanik has joined #bitcoin-core-dev
2042017-04-18T12:39:39 *** paveljanik has joined #bitcoin-core-dev
2052017-04-18T12:41:00 *** aguyonabike has joined #bitcoin-core-dev
2062017-04-18T12:42:37 <aguyonabike> Hi, I'm not sure if this is the right place to ask this question, but could Segwit be changed to be covert-asicboost-compatible? The way I figure this could be done is similar to the extension blocks proposal, adding a special transaction "at the end" instead of using coinbase space for the witness commit
2072017-04-18T12:44:43 <wumpus> yes, wrong channel, this is about concrete development of the source code on github, may be better to ask in #bitcoin-wizards or such
2082017-04-18T12:45:09 <aguyonabike> sorry about it :) thanks
2092017-04-18T12:46:41 <SopaXorzTaker> sipa, eligius doesn't reject
2102017-04-18T12:46:52 <SopaXorzTaker> how do I feed that to a miner node?
2112017-04-18T12:46:55 *** arubi has quit IRC
2122017-04-18T12:47:19 *** arubi has joined #bitcoin-core-dev
2132017-04-18T12:47:22 <wumpus> SopaXorzTaker: different channel please, this is not development related
2142017-04-18T12:47:30 <SopaXorzTaker> sorry
2152017-04-18T12:47:46 <wumpus> general questions like that belong in#bitcoin
2162017-04-18T12:48:40 <wumpus> alternatively, the bitcoin stack exchange can be useful for community support, it doesn't rely on people being who know being around at the time
2172017-04-18T12:48:52 <wumpus> -being
2182017-04-18T13:09:22 *** RubenSomsen has quit IRC
2192017-04-18T13:09:52 *** RubenSomsen has joined #bitcoin-core-dev
2202017-04-18T13:15:32 *** aguyonabike has quit IRC
2212017-04-18T13:16:39 <SopaXorzTaker> offtopic: give an example of a miner node that I can feed the transaction to, please
2222017-04-18T13:16:43 <SopaXorzTaker> wumpus, sipa ^
2232017-04-18T13:16:51 <SopaXorzTaker> I can't find any
2242017-04-18T13:17:08 <sipa> SopaXorzTaker: not here, offtopic
2252017-04-18T13:17:51 <SopaXorzTaker> okay
2262017-04-18T13:45:33 <wumpus> this is not a "highlight developers to get support" channel, last warning
2272017-04-18T13:54:23 <SopaXorzTaker> wumpus, fine
2282017-04-18T13:54:36 <SopaXorzTaker> and sorry for that
2292017-04-18T14:03:15 <SopaXorzTaker> guys
2302017-04-18T14:03:17 <SopaXorzTaker> oops
2312017-04-18T14:12:49 *** Sosumi has joined #bitcoin-core-dev
2322017-04-18T14:16:36 *** tw2006 has joined #bitcoin-core-dev
2332017-04-18T14:20:11 <bincap> back to srs busines on other hand
2342017-04-18T14:20:24 <bincap> luke-jr: laanwj was so kind and confirmed gitian for knots+bip148 https://github.com/magmaship/bitcoin-special-gitian.sigs/pull/1
2352017-04-18T14:20:46 <bincap> dang wrong #bitcoin channel. Disregard that, moving to #bitcoin
2362017-04-18T14:21:26 *** tw2006 has quit IRC
2372017-04-18T14:24:32 *** bsm1175322 has joined #bitcoin-core-dev
2382017-04-18T14:32:16 *** Giszmo has joined #bitcoin-core-dev
2392017-04-18T14:35:12 *** tw2006 has joined #bitcoin-core-dev
2402017-04-18T15:27:03 *** jtimon has joined #bitcoin-core-dev
2412017-04-18T15:31:49 *** tripleslash has quit IRC
2422017-04-18T15:34:07 *** tripleslash has joined #bitcoin-core-dev
2432017-04-18T15:39:55 <bitcoin-git> [bitcoin] luke-jr opened pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
2442017-04-18T15:45:38 *** kexkey has joined #bitcoin-core-dev
2452017-04-18T15:46:03 *** dclxvi has joined #bitcoin-core-dev
2462017-04-18T15:54:39 *** abpa has joined #bitcoin-core-dev
2472017-04-18T16:08:17 *** Soligor has quit IRC
2482017-04-18T16:25:18 *** Cortney has quit IRC
2492017-04-18T16:39:12 *** belcher has joined #bitcoin-core-dev
2502017-04-18T16:39:15 *** belcher has quit IRC
2512017-04-18T16:39:15 *** belcher has joined #bitcoin-core-dev
2522017-04-18T17:21:45 <bitcoin-git> [bitcoin] jtimon opened pull request #10227: Make functions in validation.cpp static: (master...b14-chainparams-validation-static) https://github.com/bitcoin/bitcoin/pull/10227
2532017-04-18T17:22:40 *** annanay25 has quit IRC
2542017-04-18T17:22:48 *** annanay25 has joined #bitcoin-core-dev
2552017-04-18T17:45:37 *** petertodd has joined #bitcoin-core-dev
2562017-04-18T18:01:17 *** LeMiner2 has joined #bitcoin-core-dev
2572017-04-18T18:03:32 *** LeMiner has quit IRC
2582017-04-18T18:04:44 *** Soligor has joined #bitcoin-core-dev
2592017-04-18T18:06:23 *** laurentmt has quit IRC
2602017-04-18T18:28:08 *** bsm1175322 has quit IRC
2612017-04-18T18:34:05 *** bsm1175322 has joined #bitcoin-core-dev
2622017-04-18T18:41:30 *** laurentmt has joined #bitcoin-core-dev
2632017-04-18T18:44:32 *** aceat64 has joined #bitcoin-core-dev
2642017-04-18T18:45:45 *** SopaXorzTaker has quit IRC
2652017-04-18T19:01:26 *** laurentmt has quit IRC
2662017-04-18T19:02:12 *** shesek has quit IRC
2672017-04-18T19:05:10 *** talmai has joined #bitcoin-core-dev
2682017-04-18T19:14:17 <jtimon> so what's next for #10189 ?
2692017-04-18T19:14:18 <gribble> https://github.com/bitcoin/bitcoin/issues/10189 | devtools/net: add a verifier for scriptable changes. Use it to make CNode::id private. by theuni · Pull Request #10189 · bitcoin/bitcoin · GitHub
2702017-04-18T19:14:25 *** RubenSomsen has quit IRC
2712017-04-18T19:15:28 <jtimon> I also read the topic on last meeting which I missed, it seems we agree that this facilitates review but doesn't replace it
2722017-04-18T19:15:51 <BlueMatt> jtimon: I believe cfields has a few things to update on it?
2732017-04-18T19:16:31 <jtimon> BlueMatt: apart from requiring a specific prefix (which can be done later), anything else?
2742017-04-18T19:16:40 <BlueMatt> that was my only comment
2752017-04-18T19:17:01 <BlueMatt> dont think it should be done in a separate pr, though? you dont want to gratuitously change it so that old commits are no longer verifyable for no reason
2762017-04-18T19:17:08 <BlueMatt> (plus its super trivial)
2772017-04-18T19:17:35 <cfields> sure, will add
2782017-04-18T19:18:23 <jtimon> yeah, I actually didn't thought about making it mandatory for the script to be checked, just as a convention to put in the development notes with some explanation on how to use this, but ack on making the script check for the tittle prefix
2792017-04-18T19:27:50 *** talmai has quit IRC
2802017-04-18T19:28:46 *** Sosumi has quit IRC
2812017-04-18T19:29:07 *** arubi has quit IRC
2822017-04-18T19:29:32 *** arubi has joined #bitcoin-core-dev
2832017-04-18T19:29:48 <jtimon> BlueMatt: ack on completing it further, thanks guys
2842017-04-18T19:30:30 <jtimon> I'm also not sure if there's any blocker for #9494, maybe squashing #10119 into it?
2852017-04-18T19:30:33 <gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
2862017-04-18T19:30:33 <gribble> https://github.com/bitcoin/bitcoin/issues/10119 | Util: Remove ArgsManager wrappers: by jtimon · Pull Request #10119 · bitcoin/bitcoin · GitHub
2872017-04-18T19:31:28 <jtimon> ping: jeremyrubin
2882017-04-18T19:36:53 *** tripleslash has quit IRC
2892017-04-18T19:42:32 *** NewLiberty has joined #bitcoin-core-dev
2902017-04-18T19:44:04 *** talmai has joined #bitcoin-core-dev
2912017-04-18T19:45:56 *** Dyaheon has quit IRC
2922017-04-18T19:47:21 *** Dyaheon has joined #bitcoin-core-dev
2932017-04-18T19:51:27 *** tripleslash has joined #bitcoin-core-dev
2942017-04-18T20:07:54 *** talmai has quit IRC
2952017-04-18T20:17:00 *** talmai has joined #bitcoin-core-dev
2962017-04-18T20:23:14 <jtimon> btw, as much excited as I am about #10193, the part replacing BOOST_REVERSE_FOREACH isn't even compiling for prevector_tests.cpp (see https://github.com/bitcoin/bitcoin/pull/10193/commits/cfef34884684e71c6f43ef3e4f2e87590fc87c9e ), and thus https://github.com/bitcoin/bitcoin/pull/10193/commits/d0cbbbe1147dfdf407087816a4e999990907a565 should be done either as it is
2972017-04-18T20:23:16 <gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
2982017-04-18T20:24:38 <jtimon> perhaps I should reduce the scope if I can't find a fix (and I'm still pretty clueless about why the code I "stole" from the interwebs isn't working)
2992017-04-18T20:29:53 *** talmai has quit IRC
3002017-04-18T20:33:28 *** talmai has joined #bitcoin-core-dev
3012017-04-18T20:59:04 *** QBcrusher has joined #bitcoin-core-dev
3022017-04-18T21:04:58 *** jl2012 has quit IRC
3032017-04-18T21:21:21 *** tw2006 has quit IRC
3042017-04-18T21:24:25 *** talmai has quit IRC
3052017-04-18T21:25:27 *** shesek has joined #bitcoin-core-dev
3062017-04-18T21:51:05 *** Dyaheon has quit IRC
3072017-04-18T21:51:57 *** Dyaheon has joined #bitcoin-core-dev
3082017-04-18T22:09:47 *** Guyver2 has quit IRC
3092017-04-18T22:20:41 *** shesek has quit IRC
3102017-04-18T22:36:12 *** bsm1175322 has quit IRC
3112017-04-18T22:53:17 *** chjj has quit IRC
3122017-04-18T23:03:52 *** Evel-Knievel has quit IRC
3132017-04-18T23:04:38 *** Evel-Knievel has joined #bitcoin-core-dev
3142017-04-18T23:06:52 *** chjj has joined #bitcoin-core-dev
3152017-04-18T23:08:08 *** eenoch has quit IRC
3162017-04-18T23:09:08 *** laurentmt has joined #bitcoin-core-dev
3172017-04-18T23:09:22 *** eenoch has joined #bitcoin-core-dev
3182017-04-18T23:10:34 *** tw2006 has joined #bitcoin-core-dev
3192017-04-18T23:11:03 *** laurentmt has quit IRC
3202017-04-18T23:14:00 *** shesek has joined #bitcoin-core-dev
3212017-04-18T23:15:09 *** tw2006 has quit IRC
3222017-04-18T23:32:59 <bitcoin-git> [bitcoin] theuni opened pull request #10228: build: regenerate bitcoin-config.h as necessary (master...fix-config-h) https://github.com/bitcoin/bitcoin/pull/10228
3232017-04-18T23:45:53 *** arubi has quit IRC
3242017-04-18T23:46:46 *** arubi has joined #bitcoin-core-dev
3252017-04-18T23:51:23 *** jannes has quit IRC
3262017-04-18T23:55:04 *** abpa has quit IRC