12017-05-16T00:00:14 *** goksinen has joined #bitcoin-core-dev
22017-05-16T00:14:44 *** jcliff42 has quit IRC
32017-05-16T00:22:00 *** jcliff42 has joined #bitcoin-core-dev
42017-05-16T00:39:56 *** jcliff42 has quit IRC
52017-05-16T00:43:21 *** jcliff42 has joined #bitcoin-core-dev
62017-05-16T00:46:08 *** Dyaheon has quit IRC
72017-05-16T00:48:06 *** Dyaheon has joined #bitcoin-core-dev
82017-05-16T00:50:17 *** d_t has quit IRC
92017-05-16T00:53:18 *** jcliff42 has quit IRC
102017-05-16T01:03:15 *** jcliff42 has joined #bitcoin-core-dev
112017-05-16T01:04:13 *** jcliff42 has quit IRC
122017-05-16T01:11:04 *** moli_ has joined #bitcoin-core-dev
132017-05-16T01:14:58 *** mol has quit IRC
142017-05-16T01:18:24 *** goksinen has quit IRC
152017-05-16T01:20:30 *** helo_ has quit IRC
162017-05-16T01:33:54 *** goksinen has joined #bitcoin-core-dev
172017-05-16T01:38:48 *** goksinen has quit IRC
182017-05-16T02:02:32 *** goksinen has joined #bitcoin-core-dev
192017-05-16T02:13:27 *** goksinen has quit IRC
202017-05-16T02:14:12 *** jcliff42 has joined #bitcoin-core-dev
212017-05-16T02:20:52 *** jcliff42 has quit IRC
222017-05-16T03:19:41 *** Giszmo has quit IRC
232017-05-16T03:23:10 *** fengling has joined #bitcoin-core-dev
242017-05-16T03:35:52 *** pavel_ has joined #bitcoin-core-dev
252017-05-16T03:36:03 *** goksinen has joined #bitcoin-core-dev
262017-05-16T03:36:12 *** cryptapus has joined #bitcoin-core-dev
272017-05-16T03:38:08 *** paveljanik has quit IRC
282017-05-16T03:40:58 *** goksinen has quit IRC
292017-05-16T03:41:31 *** cryptapus is now known as cryptapus_afk
302017-05-16T03:58:15 *** cryptapus_afk has quit IRC
312017-05-16T04:37:56 *** harrymm has quit IRC
322017-05-16T04:39:54 *** harrymm has joined #bitcoin-core-dev
332017-05-16T04:40:47 *** jcliff42 has joined #bitcoin-core-dev
342017-05-16T04:44:56 *** jcliff42 has quit IRC
352017-05-16T04:46:57 *** fengling has quit IRC
362017-05-16T04:46:57 *** Dyaheon has quit IRC
372017-05-16T04:48:54 *** Dyaheon has joined #bitcoin-core-dev
382017-05-16T04:50:39 *** chjj has quit IRC
392017-05-16T04:54:21 *** harrymm has quit IRC
402017-05-16T05:04:36 *** chjj has joined #bitcoin-core-dev
412017-05-16T05:09:11 *** Squidicuz has quit IRC
422017-05-16T05:11:02 *** Squidicuz has joined #bitcoin-core-dev
432017-05-16T05:12:47 *** harrymm has joined #bitcoin-core-dev
442017-05-16T05:18:53 *** jcliff42 has joined #bitcoin-core-dev
452017-05-16T05:33:13 *** fengling has joined #bitcoin-core-dev
462017-05-16T05:37:44 *** pavel_ has quit IRC
472017-05-16T05:45:07 *** rockhouse has quit IRC
482017-05-16T05:48:01 *** jcliff42 has quit IRC
492017-05-16T05:55:24 *** goksinen has joined #bitcoin-core-dev
502017-05-16T05:59:57 *** goksinen has quit IRC
512017-05-16T06:00:45 *** goksinen has joined #bitcoin-core-dev
522017-05-16T06:05:27 *** goksinen has quit IRC
532017-05-16T06:09:22 *** arowser has quit IRC
542017-05-16T06:09:36 *** PaulCape_ has joined #bitcoin-core-dev
552017-05-16T06:10:29 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6ee855b411e...d0c37ee78984
562017-05-16T06:10:30 <bitcoin-git> bitcoin/master 761392d John Newbery: [logging] log system time and mock time
572017-05-16T06:10:30 *** PaulCapestany has quit IRC
582017-05-16T06:10:30 <bitcoin-git> bitcoin/master d0c37ee Wladimir J. van der Laan: Merge #10383: [logging] log system time and mock time...
592017-05-16T06:10:49 *** arowser has joined #bitcoin-core-dev
602017-05-16T06:10:59 <bitcoin-git> [bitcoin] laanwj closed pull request #10383: [logging] log system time and mock time (master...log_mocktime) https://github.com/bitcoin/bitcoin/pull/10383
612017-05-16T06:11:04 *** arowser has quit IRC
622017-05-16T06:16:49 *** goksinen has joined #bitcoin-core-dev
632017-05-16T06:19:43 *** fengling has quit IRC
642017-05-16T06:21:05 *** goksinen has quit IRC
652017-05-16T06:24:07 <bitcoin-git> [bitcoin] str4d opened pull request #10408: Net: Improvements to Tor control port parser (master...torcontrol-parser-patches) https://github.com/bitcoin/bitcoin/pull/10408
662017-05-16T06:47:26 *** BashCo has quit IRC
672017-05-16T06:47:43 *** fengling has joined #bitcoin-core-dev
682017-05-16T06:50:17 *** JackH has quit IRC
692017-05-16T06:54:54 *** mol has joined #bitcoin-core-dev
702017-05-16T06:55:12 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d0c37ee78984...95546c859b71
712017-05-16T06:55:12 <bitcoin-git> bitcoin/master 012fa9b Spencer Lievens: Add OSX keystroke to clear RPCConsole...
722017-05-16T06:55:13 <bitcoin-git> bitcoin/master 95546c8 Jonas Schnelli: Merge #10362: [GUI] Add OSX keystroke to RPCConsole info...
732017-05-16T06:55:39 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10362: [GUI] Add OSX keystroke to RPCConsole info (master...RPC-OSX-Keystroke) https://github.com/bitcoin/bitcoin/pull/10362
742017-05-16T06:57:56 *** moli_ has quit IRC
752017-05-16T06:58:58 <jonasschnelli> Can someone working on the net-code give a final ACK/NACK for https://github.com/bitcoin/bitcoin/pull/9502? sipa, cfields?
762017-05-16T07:06:20 <cfields> jonasschnelli: I'll give it a detailed look in the morning (getting ready for bed atm). Looks ok at a glance, though. Though, I'm a bit confused about nBlocksInFlight being atomic.
772017-05-16T07:07:58 <jonasschnelli> cfields: Okay. Thanks... have a rest (it's not urgent). And yes, I would like to hear why you think nBlocksInFlight as an atomic may be confusing.
782017-05-16T07:08:48 <cfields> jonasschnelli: just looks like it should either be non-atomic and require the lock, or be atomic and possibly out of sync.
792017-05-16T07:09:44 <jonasschnelli> Okay... let me check that again. Thanks for pointing out.
802017-05-16T07:10:25 <cfields> jonasschnelli: (i haven't looked deeply, so no idea if it makes sense), maybe useful to trigger a gui event for mapBlocksInFlight.erase(), similar to the other recent changes like that?
812017-05-16T07:10:47 <cfields> that way you'd keep it cached at the gui and not have to query the other way?
822017-05-16T07:11:08 <jonasschnelli> cfields: But wouldn't mapBlocksInFlight.erase() not result in still downloading the blocks?
832017-05-16T07:11:36 *** BashCo has joined #bitcoin-core-dev
842017-05-16T07:11:41 <jonasschnelli> IMO what the GUI should know is how many blocks are still "in transit" when someone pressed "pause"...
852017-05-16T07:11:55 <jonasschnelli> because you won't stop a peer of sending you the already requestes blocks...
862017-05-16T07:12:00 <jonasschnelli> and you should accept them,...
872017-05-16T07:12:19 <jonasschnelli> *the peer should accept them
882017-05-16T07:13:21 <cfields> jonasschnelli: i just mean add a gui event for when mapBlocksInFlight is added to or removed. that way the gui gets notifications for each change, and doesn't have to try to query
892017-05-16T07:13:50 <jonasschnelli> aha... yeah. That would work.. though seems a bit an overkill to add a signal for that... but maybe not.
902017-05-16T07:14:45 <cfields> jonasschnelli: yea, that's the part i wasn't sure about. I only mentioned because it's the direction things have been going in lately.
912017-05-16T07:15:07 <jonasschnelli> Yes. That's true. Maybe its useful for other stuff as well..
922017-05-16T07:15:28 <jonasschnelli> What are the downside of the atomic approach? Calling the getter in the middle of an "update sequence"?
932017-05-16T07:19:48 <cfields> yea, possible off-by-one in some future code i guess. unlikely to be an actual issue probably, just feels a bit icky to introduce a race strictly because the non-racy path would require the slow lock :(
942017-05-16T07:20:28 <cfields> s/race/de-sync/, i suppose
952017-05-16T07:22:13 *** goksinen has joined #bitcoin-core-dev
962017-05-16T07:33:11 *** Cheeseo has quit IRC
972017-05-16T07:48:36 *** justan0theruser is now known as justanotheruser
982017-05-16T07:56:05 *** goksinen has joined #bitcoin-core-dev
992017-05-16T07:57:24 *** goksinen has quit IRC
1002017-05-16T08:05:52 *** laurentmt has joined #bitcoin-core-dev
1012017-05-16T08:07:21 *** laurentmt has quit IRC
1022017-05-16T08:10:10 *** jannes has joined #bitcoin-core-dev
1032017-05-16T08:12:36 *** laurentmt has joined #bitcoin-core-dev
1042017-05-16T08:13:10 *** JackH has joined #bitcoin-core-dev
1052017-05-16T08:21:37 *** laurentmt has quit IRC
1062017-05-16T08:22:40 *** Guyver2 has joined #bitcoin-core-dev
1072017-05-16T08:32:30 *** vicenteH has joined #bitcoin-core-dev
1082017-05-16T08:43:08 *** BashCo has quit IRC
1092017-05-16T08:44:37 *** BashCo has joined #bitcoin-core-dev
1102017-05-16T08:58:36 *** laurentmt has joined #bitcoin-core-dev
1112017-05-16T09:01:56 *** gielbier has quit IRC
1122017-05-16T09:37:02 *** xczcsadsa has joined #bitcoin-core-dev
1132017-05-16T09:38:41 *** justanotheruser has quit IRC
1142017-05-16T09:42:58 *** laurentmt has quit IRC
1152017-05-16T09:50:10 *** xczcsadsa has quit IRC
1162017-05-16T09:53:12 *** AaronvanW has joined #bitcoin-core-dev
1172017-05-16T09:53:12 *** AaronvanW has joined #bitcoin-core-dev
1182017-05-16T09:57:47 *** goksinen has joined #bitcoin-core-dev
1192017-05-16T09:58:02 *** riemann has joined #bitcoin-core-dev
1202017-05-16T09:59:07 *** riemann has joined #bitcoin-core-dev
1212017-05-16T10:03:18 *** goksinen has quit IRC
1222017-05-16T10:36:33 *** goksinen has joined #bitcoin-core-dev
1232017-05-16T10:37:54 *** goksinen has quit IRC
1242017-05-16T10:55:38 *** jcliff42 has joined #bitcoin-core-dev
1252017-05-16T11:11:04 *** jcliff42 has quit IRC
1262017-05-16T11:11:38 *** jcliff42 has joined #bitcoin-core-dev
1272017-05-16T11:16:41 *** jcliff42 has quit IRC
1282017-05-16T11:30:43 *** BashCo has quit IRC
1292017-05-16T11:31:53 *** mol has quit IRC
1302017-05-16T11:33:18 *** moli_ has joined #bitcoin-core-dev
1312017-05-16T11:33:22 *** BashCo has joined #bitcoin-core-dev
1322017-05-16T11:46:50 *** BashCo has quit IRC
1332017-05-16T11:49:52 *** BashCo has joined #bitcoin-core-dev
1342017-05-16T12:08:42 *** jtimon has joined #bitcoin-core-dev
1352017-05-16T12:09:46 *** str4d has joined #bitcoin-core-dev
1362017-05-16T12:27:43 *** mol has joined #bitcoin-core-dev
1372017-05-16T12:30:26 *** moli_ has quit IRC
1382017-05-16T12:31:13 *** moli_ has joined #bitcoin-core-dev
1392017-05-16T12:34:23 *** mol has quit IRC
1402017-05-16T12:38:18 *** goksinen has joined #bitcoin-core-dev
1412017-05-16T12:42:57 *** goksinen has quit IRC
1422017-05-16T12:51:33 *** mol has joined #bitcoin-core-dev
1432017-05-16T12:53:34 *** goksinen has joined #bitcoin-core-dev
1442017-05-16T12:54:13 *** moli_ has quit IRC
1452017-05-16T12:57:43 *** laurentmt has joined #bitcoin-core-dev
1462017-05-16T12:58:05 *** goksinen has quit IRC
1472017-05-16T13:02:46 *** laurentmt has quit IRC
1482017-05-16T13:24:07 *** str4d has quit IRC
1492017-05-16T13:24:57 *** str4d has joined #bitcoin-core-dev
1502017-05-16T13:31:03 *** laurentmt has joined #bitcoin-core-dev
1512017-05-16T13:31:11 *** laurentmt has quit IRC
1522017-05-16T13:44:01 *** Chris_Stewart_5 has quit IRC
1532017-05-16T13:46:33 *** goksinen has joined #bitcoin-core-dev
1542017-05-16T13:50:15 *** d_t has joined #bitcoin-core-dev
1552017-05-16T14:01:25 *** molz_ has joined #bitcoin-core-dev
1562017-05-16T14:04:11 *** mol has quit IRC
1572017-05-16T14:06:42 *** Sprh has joined #bitcoin-core-dev
1582017-05-16T14:10:35 *** goksinen has joined #bitcoin-core-dev
1592017-05-16T14:15:27 *** goksinen has quit IRC
1602017-05-16T14:18:47 *** goksinen has joined #bitcoin-core-dev
1612017-05-16T14:20:08 *** goksinen has quit IRC
1622017-05-16T14:20:43 *** goksinen has joined #bitcoin-core-dev
1632017-05-16T14:21:04 *** str4d has quit IRC
1642017-05-16T14:22:03 *** goksinen has quit IRC
1652017-05-16T14:22:53 *** goksinen has joined #bitcoin-core-dev
1662017-05-16T14:24:49 *** goksinen has joined #bitcoin-core-dev
1672017-05-16T14:28:02 *** justanotheruser has joined #bitcoin-core-dev
1682017-05-16T14:29:12 *** goksinen has joined #bitcoin-core-dev
1692017-05-16T14:34:38 *** goksinen has quit IRC
1702017-05-16T14:40:10 *** goksinen has joined #bitcoin-core-dev
1712017-05-16T14:50:03 *** Giszmo has joined #bitcoin-core-dev
1722017-05-16T14:51:29 <bitcoin-git> [bitcoin] practicalswift opened pull request #10409: [tests] Add fuzz testing for BlockTransactions (BLOCKTXN) and BlockTransactionsRequest (GETBLOCKTXN) deserialization (master...fuzz-blocktransactions) https://github.com/bitcoin/bitcoin/pull/10409
1732017-05-16T15:06:11 *** QBcrusher has quit IRC
1742017-05-16T15:42:37 *** riemann has quit IRC
1752017-05-16T15:44:38 *** SopaXorzTaker has joined #bitcoin-core-dev
1762017-05-16T15:45:49 *** abpa has joined #bitcoin-core-dev
1772017-05-16T15:48:42 <bitcoin-git> [bitcoin] ryanofsky opened pull request #10410: Fix importwallet edge case rescan bug (master...pr/scanimp) https://github.com/bitcoin/bitcoin/pull/10410
1782017-05-16T16:16:21 *** Guyver2 has quit IRC
1792017-05-16T16:59:27 *** BashCo has quit IRC
1802017-05-16T17:15:23 *** BashCo has joined #bitcoin-core-dev
1812017-05-16T17:17:02 *** d_t has joined #bitcoin-core-dev
1822017-05-16T17:18:07 *** moli_ has joined #bitcoin-core-dev
1832017-05-16T17:18:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1842017-05-16T17:19:25 *** molz_ has quit IRC
1852017-05-16T17:29:58 *** goksinen has quit IRC
1862017-05-16T17:31:42 *** goksinen has joined #bitcoin-core-dev
1872017-05-16T17:31:49 *** paveljanik has joined #bitcoin-core-dev
1882017-05-16T17:31:50 *** paveljanik has joined #bitcoin-core-dev
1892017-05-16T17:33:42 *** jcliff42 has joined #bitcoin-core-dev
1902017-05-16T17:42:43 *** vicenteH has quit IRC
1912017-05-16T17:43:01 *** d9b4bef9 has quit IRC
1922017-05-16T17:44:07 *** d9b4bef9 has joined #bitcoin-core-dev
1932017-05-16T17:46:14 *** laurentmt has joined #bitcoin-core-dev
1942017-05-16T17:47:00 *** laurentmt has quit IRC
1952017-05-16T17:47:13 *** jcliff42 has quit IRC
1962017-05-16T17:52:30 *** jcliff42 has joined #bitcoin-core-dev
1972017-05-16T18:00:26 *** jcliff42 has quit IRC
1982017-05-16T18:11:27 *** chjj has quit IRC
1992017-05-16T18:18:31 *** Cheeseo has joined #bitcoin-core-dev
2002017-05-16T18:20:41 *** Sprh has quit IRC
2012017-05-16T18:23:19 *** d_t has quit IRC
2022017-05-16T18:26:13 *** chjj has joined #bitcoin-core-dev
2032017-05-16T18:28:53 *** twistedline_ has joined #bitcoin-core-dev
2042017-05-16T18:29:04 *** twistedline has quit IRC
2052017-05-16T18:29:04 *** jcliff42 has joined #bitcoin-core-dev
2062017-05-16T18:29:54 *** jcliff42 has joined #bitcoin-core-dev
2072017-05-16T18:41:34 *** goksinen has quit IRC
2082017-05-16T18:43:23 *** goksinen has joined #bitcoin-core-dev
2092017-05-16T18:59:40 *** jcliff42 has quit IRC
2102017-05-16T19:24:48 *** goksinen has quit IRC
2112017-05-16T19:30:43 *** goksinen has joined #bitcoin-core-dev
2122017-05-16T19:32:04 *** goksinen has quit IRC
2132017-05-16T19:37:00 *** goksinen has joined #bitcoin-core-dev
2142017-05-16T19:38:21 *** goksinen has quit IRC
2152017-05-16T19:39:12 *** goksinen has joined #bitcoin-core-dev
2162017-05-16T19:40:33 *** goksinen has quit IRC
2172017-05-16T19:41:09 *** LeMiner has quit IRC
2182017-05-16T19:44:52 <Chris_Stewart_5> If I have a transaction that spends a raw witness spk and the input is already signed on the spending tx, and then I'm trying to call fundrawtransaction to add a fee. Is this currently unsupported in bitcoin core? Do I need to use P2SH(P2WSH)?
2192017-05-16T19:50:54 *** vicenteH has joined #bitcoin-core-dev
2202017-05-16T19:58:43 *** goksinen has joined #bitcoin-core-dev
2212017-05-16T20:00:22 *** laurentmt has joined #bitcoin-core-dev
2222017-05-16T20:01:06 *** laurentmt has quit IRC
2232017-05-16T20:02:59 *** mol has joined #bitcoin-core-dev
2242017-05-16T20:04:07 <bitcoin-git> [bitcoin] ryanofsky opened pull request #10412: Improve wallet rescan API (master...pr/scanclean) https://github.com/bitcoin/bitcoin/pull/10412
2252017-05-16T20:05:48 *** moli_ has quit IRC
2262017-05-16T20:07:07 *** jcliff42 has joined #bitcoin-core-dev
2272017-05-16T20:09:40 *** jcliff42 has quit IRC
2282017-05-16T20:17:24 *** jcliff42 has joined #bitcoin-core-dev
2292017-05-16T20:19:39 *** justan0theruser has joined #bitcoin-core-dev
2302017-05-16T20:21:35 *** jcliff42 has quit IRC
2312017-05-16T20:21:59 *** justanotheruser has quit IRC
2322017-05-16T20:30:31 *** jcliff42 has joined #bitcoin-core-dev
2332017-05-16T20:30:36 *** moli_ has joined #bitcoin-core-dev
2342017-05-16T20:32:44 *** mol has quit IRC
2352017-05-16T20:40:34 *** mol has joined #bitcoin-core-dev
2362017-05-16T20:41:10 *** moli_ has quit IRC
2372017-05-16T20:52:29 *** cryptapus has joined #bitcoin-core-dev
2382017-05-16T20:52:39 *** cryptapus is now known as cryptapus_afk
2392017-05-16T21:30:57 *** goksinen has quit IRC
2402017-05-16T21:31:52 *** goksinen has joined #bitcoin-core-dev
2412017-05-16T21:36:09 *** harrymm has quit IRC
2422017-05-16T21:42:52 *** goksinen has quit IRC
2432017-05-16T21:43:44 *** goksinen has joined #bitcoin-core-dev
2442017-05-16T21:53:30 *** goksinen has quit IRC
2452017-05-16T21:54:13 *** goksinen has joined #bitcoin-core-dev
2462017-05-16T21:54:41 *** jcliff42 has quit IRC
2472017-05-16T22:04:02 *** goksinen has quit IRC
2482017-05-16T22:05:05 *** goksinen has joined #bitcoin-core-dev
2492017-05-16T22:12:22 *** cryptapus_afk has quit IRC
2502017-05-16T22:12:59 *** JackH has quit IRC
2512017-05-16T22:14:56 *** jcliff42 has joined #bitcoin-core-dev
2522017-05-16T22:16:50 *** goksinen has quit IRC
2532017-05-16T22:18:50 *** goksinen has joined #bitcoin-core-dev
2542017-05-16T22:21:38 *** jannes has quit IRC
2552017-05-16T22:23:38 *** jcliff42 has quit IRC
2562017-05-16T22:28:39 *** goksinen has quit IRC
2572017-05-16T22:45:02 *** vicenteH has quit IRC
2582017-05-16T22:45:10 *** jcliff42 has joined #bitcoin-core-dev
2592017-05-16T23:09:40 *** jcliff42 has quit IRC
2602017-05-16T23:09:58 *** jcliff42 has joined #bitcoin-core-dev
2612017-05-16T23:31:51 *** cryptapus_afk has joined #bitcoin-core-dev
2622017-05-16T23:35:11 *** justan0theruser is now known as justanotheruser
2632017-05-16T23:40:25 *** d_t has joined #bitcoin-core-dev
2642017-05-16T23:43:59 *** d_t has quit IRC
2652017-05-16T23:54:44 *** Evel-Knievel has quit IRC
2662017-05-16T23:58:43 *** abpa has quit IRC