12017-06-02T00:04:01 *** emzy has joined #bitcoin-core-dev
22017-06-02T00:05:44 <jtimon> gmaxwell: I'm not sure what the implications of your comments about #10195 are, sadly I didn't find time to take more than a glance at it
32017-06-02T00:05:48 <gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
42017-06-02T00:07:00 <gmaxwell> jtimon: huh?
52017-06-02T00:07:45 <sipa> jtimon: since 10195, at first startup, your chainstate database will be upgraded to a new format
62017-06-02T00:08:06 <sipa> this may take a while, but only happens once
72017-06-02T00:09:41 <jtimon> sipa: thank you, and gmaxwell is pointing out that trying to downgrade the chainstate database format would be painful, but there's no good reason to want that besides testing, right?
82017-06-02T00:09:56 <sipa> indeed
92017-06-02T00:10:48 <jtimon> but gmaxwell tried anyway, nice
102017-06-02T00:11:13 <jtimon> and it works
112017-06-02T00:12:22 <jtimon> I guess I shouldn't have started with the youtube video
122017-06-02T00:22:02 <jtimon> I know it's selfish, but my plan was to partially review 10195 after squashed and merged all along
132017-06-02T00:26:02 <sipa> that's a perfectly gine strategy
142017-06-02T00:26:05 <sipa> *fine
152017-06-02T00:31:18 *** DCLXVI` has joined #bitcoin-core-dev
162017-06-02T00:33:12 *** emzy_ has joined #bitcoin-core-dev
172017-06-02T00:33:26 *** emzy has quit IRC
182017-06-02T00:33:29 *** cfields has quit IRC
192017-06-02T00:34:18 *** cfields has joined #bitcoin-core-dev
202017-06-02T00:38:07 *** dclxvi has quit IRC
212017-06-02T00:43:01 *** AaronvanW has joined #bitcoin-core-dev
222017-06-02T00:45:35 *** Aaronvan_ has quit IRC
232017-06-02T00:49:04 <jtimon> mhmm sipa I cannot find where this check went: https://github.com/bitcoin/bitcoin/pull/8498/commits/e1cddd6c57e0b40d63c6ed5ff8d61e2c6b44ad3e#r110544416
242017-06-02T00:50:27 <sipa> doesn't exist anymore... we can't distinguish already spent from nonexisting
252017-06-02T00:51:25 <sipa> it was unreliable before
262017-06-02T00:53:23 *** Dyaheon has quit IRC
272017-06-02T00:53:37 <jtimon> thank you, I take that as https://github.com/bitcoin/bitcoin/pull/8498/commits/e1cddd6c57e0b40d63c6ed5ff8d61e2c6b44ad3e#diff-ca81084f62961a188f5c1e86a5ff1d7cL206 still being good (chnaging from 0 to 100 )
282017-06-02T00:53:45 <jtimon> rebasing just that now
292017-06-02T00:54:37 <jtimon> anyway, nver mind, new checks right above
302017-06-02T00:55:15 <jtimon> or are they new? I will figure it out, thanks
312017-06-02T00:55:17 <cfields> wumpus: forgot to bump version before tag :(
322017-06-02T00:56:50 *** Ylbam has quit IRC
332017-06-02T00:57:33 *** Dyaheon has joined #bitcoin-core-dev
342017-06-02T01:05:08 *** dabura667 has joined #bitcoin-core-dev
352017-06-02T01:07:04 <jtimon> sipa: ping https://github.com/bitcoin/bitcoin/pull/8498#issuecomment-305661391
362017-06-02T01:08:22 *** gielbier has quit IRC
372017-06-02T01:08:45 *** gielbier has joined #bitcoin-core-dev
382017-06-02T01:13:35 *** justan0theruser has quit IRC
392017-06-02T01:14:35 *** justanotheruser has joined #bitcoin-core-dev
402017-06-02T01:33:21 *** Chris_Stewart_5 has quit IRC
412017-06-02T01:38:52 *** harrymm has quit IRC
422017-06-02T01:40:28 *** Chris_Stewart_5 has joined #bitcoin-core-dev
432017-06-02T01:58:07 *** harrymm has joined #bitcoin-core-dev
442017-06-02T02:13:05 *** PaulCapestany has quit IRC
452017-06-02T02:16:34 *** PaulCapestany has joined #bitcoin-core-dev
462017-06-02T02:44:42 *** RubenSomsen has joined #bitcoin-core-dev
472017-06-02T03:04:35 *** Chris_Stewart_5 has quit IRC
482017-06-02T03:10:05 *** mkarrer has quit IRC
492017-06-02T03:13:57 *** RubenSomsen has quit IRC
502017-06-02T03:25:28 *** RubenSomsen has joined #bitcoin-core-dev
512017-06-02T03:47:05 *** RubenSomsen has quit IRC
522017-06-02T03:48:23 *** guest____ has quit IRC
532017-06-02T03:58:53 <instagibbs> bad timing... https://github.com/drivechain-project/bitcoin/pull/10 just told them about new style guide, haha
542017-06-02T03:59:00 <instagibbs> guess it's good it's merged now
552017-06-02T04:25:38 *** kadoban has quit IRC
562017-06-02T05:12:49 *** harrymm has quit IRC
572017-06-02T05:36:47 <wumpus> cfields: darn
582017-06-02T05:40:28 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/4a41de4585a4dffb451a9be8078abb838235f336
592017-06-02T05:40:28 <bitcoin-git> bitcoin/0.14 4a41de4 Wladimir J. van der Laan: build: bump version to 0.14.2
602017-06-02T05:40:38 <wumpus> well that means there will be a rc2 for sure
612017-06-02T05:43:20 <gmaxwell> oh damnit we did it again.
622017-06-02T05:43:41 <gmaxwell> I somehow missed that we were cutting a rc1.
632017-06-02T05:44:00 <wumpus> another reason it's good that we do rcs in the first place
642017-06-02T05:44:29 <wumpus> that was discussed in the meeting yesterday
652017-06-02T05:44:47 <gmaxwell> yea, I missed part of it.
662017-06-02T05:45:29 <gmaxwell> oh hm. testing is slightly harder because I've upgraded most of my nodes to per txo! :P
672017-06-02T05:45:35 <wumpus> yes, not your fault
682017-06-02T05:45:56 <wumpus> ... same here
692017-06-02T05:49:00 *** Ylbam has joined #bitcoin-core-dev
702017-06-02T06:00:08 *** dermoth has quit IRC
712017-06-02T06:00:56 *** dermoth has joined #bitcoin-core-dev
722017-06-02T06:05:37 *** jtimon has quit IRC
732017-06-02T06:38:21 *** BashCo has quit IRC
742017-06-02T06:44:55 *** Guest60910 has joined #bitcoin-core-dev
752017-06-02T06:47:24 *** Giszmo has quit IRC
762017-06-02T06:48:28 *** Victor_sueca has joined #bitcoin-core-dev
772017-06-02T06:49:29 *** Victorsueca has quit IRC
782017-06-02T06:50:00 *** Victorsueca has joined #bitcoin-core-dev
792017-06-02T06:52:27 *** Victor_sueca has quit IRC
802017-06-02T06:55:42 *** nemgun1 has joined #bitcoin-core-dev
812017-06-02T06:58:46 *** nemgun has quit IRC
822017-06-02T07:04:56 *** BashCo has joined #bitcoin-core-dev
832017-06-02T07:25:59 *** emzy_ is now known as emzy
842017-06-02T07:26:05 *** emzy has joined #bitcoin-core-dev
852017-06-02T07:34:44 *** AaronvanW has joined #bitcoin-core-dev
862017-06-02T07:35:19 *** goatturner has joined #bitcoin-core-dev
872017-06-02T07:35:55 *** Aaronvan_ has joined #bitcoin-core-dev
882017-06-02T07:39:21 *** AaronvanW has quit IRC
892017-06-02T07:39:30 <midnightmagic> ô/w 4
902017-06-02T08:20:30 *** jannes has joined #bitcoin-core-dev
912017-06-02T08:31:58 *** Victorsueca has quit IRC
922017-06-02T08:32:07 *** Victorsueca has joined #bitcoin-core-dev
932017-06-02T08:32:45 *** mkarrer has joined #bitcoin-core-dev
942017-06-02T08:38:53 *** Victorsueca has quit IRC
952017-06-02T08:39:07 *** Victorsueca has joined #bitcoin-core-dev
962017-06-02T08:40:01 *** d9b4bef9 has quit IRC
972017-06-02T08:41:08 *** d9b4bef9 has joined #bitcoin-core-dev
982017-06-02T08:43:11 *** vicenteH has joined #bitcoin-core-dev
992017-06-02T08:59:39 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cc2c670e3d7...00d369239612
1002017-06-02T08:59:40 <bitcoin-git> bitcoin/master e7c1b44 Pieter Wuille: Squashed 'src/secp256k1/' changes from 8225239..84973d3...
1012017-06-02T08:59:40 <bitcoin-git> bitcoin/master 5252827 Pieter Wuille: Update to latest libsecp256k1
1022017-06-02T08:59:41 <bitcoin-git> bitcoin/master 00d3692 Wladimir J. van der Laan: Merge #10323: Update to latest libsecp256k1 master...
1032017-06-02T09:00:06 <bitcoin-git> [bitcoin] laanwj closed pull request #10323: Update to latest libsecp256k1 master (master...secp_up) https://github.com/bitcoin/bitcoin/pull/10323
1042017-06-02T09:03:22 *** cysm_ has quit IRC
1052017-06-02T09:07:20 *** cysm_ has joined #bitcoin-core-dev
1062017-06-02T09:23:11 *** Yogaqueef has joined #bitcoin-core-dev
1072017-06-02T09:26:22 *** SopaXorzTaker has joined #bitcoin-core-dev
1082017-06-02T09:33:01 *** goatturneer has joined #bitcoin-core-dev
1092017-06-02T09:36:01 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00d369239612...1aefc94dd78d
1102017-06-02T09:36:02 <bitcoin-git> bitcoin/master 930deb9 John Newbery: [tests] skipped tests should clean up after themselves
1112017-06-02T09:36:02 <bitcoin-git> bitcoin/master 1aefc94 MarcoFalke: Merge #10423: [tests] skipped tests should clean up after themselves...
1122017-06-02T09:36:34 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10423: [tests] skipped tests should clean up after themselves (master...cleanup_skipped) https://github.com/bitcoin/bitcoin/pull/10423
1132017-06-02T09:36:41 *** goatturner has quit IRC
1142017-06-02T09:41:10 *** Guyver2 has joined #bitcoin-core-dev
1152017-06-02T09:52:05 *** tunafizz has quit IRC
1162017-06-02T09:52:19 *** tunafizz has joined #bitcoin-core-dev
1172017-06-02T10:02:12 *** dabura667 has quit IRC
1182017-06-02T10:13:28 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1aefc94dd78d...329fc1dce7a1
1192017-06-02T10:13:29 <bitcoin-git> bitcoin/master d8c218f John Newbery: [tests] Functional tests call self.start_node(s) and self.stop_node(s)...
1202017-06-02T10:13:29 <bitcoin-git> bitcoin/master a433d8a John Newbery: [tests] Update start/stop node functions to be private module functions...
1212017-06-02T10:13:30 <bitcoin-git> bitcoin/master 53f6775 John Newbery: fixup: fix nits
1222017-06-02T10:13:59 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods (master...test_framework_start_stop_nodes) https://github.com/bitcoin/bitcoin/pull/10359
1232017-06-02T10:16:27 *** Aaronvan_ is now known as AaronvanW
1242017-06-02T10:19:12 *** btcdrak has quit IRC
1252017-06-02T10:49:29 *** btcdrak has joined #bitcoin-core-dev
1262017-06-02T11:00:41 *** john has joined #bitcoin-core-dev
1272017-06-02T11:01:05 *** john is now known as Guest26727
1282017-06-02T11:01:43 *** Guest60910 has quit IRC
1292017-06-02T11:02:14 *** beatrootfarmer has joined #bitcoin-core-dev
1302017-06-02T11:04:57 *** BashCo has quit IRC
1312017-06-02T11:05:40 *** goatturneer has quit IRC
1322017-06-02T11:06:01 *** NewLiberty has quit IRC
1332017-06-02T11:07:26 *** BashCo has joined #bitcoin-core-dev
1342017-06-02T11:15:08 *** goatturneer has joined #bitcoin-core-dev
1352017-06-02T11:18:52 *** beatrootfarmer has quit IRC
1362017-06-02T11:34:53 *** beatrootfarmer has joined #bitcoin-core-dev
1372017-06-02T11:38:20 *** goatturneer has quit IRC
1382017-06-02T11:49:58 *** goatturneer has joined #bitcoin-core-dev
1392017-06-02T11:51:03 *** goatturner has joined #bitcoin-core-dev
1402017-06-02T11:53:46 *** beatrootfarmer has quit IRC
1412017-06-02T11:53:59 *** beatrootfarmer has joined #bitcoin-core-dev
1422017-06-02T11:54:44 *** goatturneer has quit IRC
1432017-06-02T11:55:38 *** goatturner has quit IRC
1442017-06-02T12:08:56 *** goatturneer has joined #bitcoin-core-dev
1452017-06-02T12:12:23 *** RubenSomsen has joined #bitcoin-core-dev
1462017-06-02T12:12:25 *** beatrootfarmer has quit IRC
1472017-06-02T12:13:34 *** beatrootfarmer has joined #bitcoin-core-dev
1482017-06-02T12:17:32 *** goatturner has joined #bitcoin-core-dev
1492017-06-02T12:17:39 *** goatturneer has quit IRC
1502017-06-02T12:20:53 *** beatrootfarmer has quit IRC
1512017-06-02T12:38:52 *** AaronvanW has quit IRC
1522017-06-02T12:41:46 *** AaronvanW has joined #bitcoin-core-dev
1532017-06-02T12:53:44 *** Alina-malina has quit IRC
1542017-06-02T12:54:03 *** Alina-malina has joined #bitcoin-core-dev
1552017-06-02T12:55:44 *** Gnof has joined #bitcoin-core-dev
1562017-06-02T12:56:20 *** Alina-malina has quit IRC
1572017-06-02T12:56:20 *** Alina-malina has joined #bitcoin-core-dev
1582017-06-02T12:59:12 *** btcdrak has quit IRC
1592017-06-02T13:06:16 *** str4d has quit IRC
1602017-06-02T13:07:31 *** jtimon has joined #bitcoin-core-dev
1612017-06-02T13:11:16 *** goatturneer has joined #bitcoin-core-dev
1622017-06-02T13:11:38 *** laurentmt has joined #bitcoin-core-dev
1632017-06-02T13:11:52 *** beatrootfarmer has joined #bitcoin-core-dev
1642017-06-02T13:15:21 *** goatturner has quit IRC
1652017-06-02T13:15:44 *** goatturneer has quit IRC
1662017-06-02T13:15:59 *** laurentmt has quit IRC
1672017-06-02T13:23:52 *** btcdrak has joined #bitcoin-core-dev
1682017-06-02T13:29:51 <bitcoin-git> [bitcoin] ryanofsky opened pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
1692017-06-02T13:35:47 <bitcoin-git> [bitcoin] ryanofsky opened pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
1702017-06-02T13:37:44 *** NewLiberty has joined #bitcoin-core-dev
1712017-06-02T13:38:21 <Anduck> https://twitter.com/movrcx/status/870527842789892096
1722017-06-02T13:41:18 <instagibbs> Anduck, I can do the same offer, but only require 499BTC :)
1732017-06-02T13:41:58 <Anduck> apparently this guy is "vouched" by some earlier found 0days. could be bullshit though
1742017-06-02T13:42:14 <Apocalyptic> instagibbs, DoS is a broad term
1752017-06-02T13:42:45 <Lauda> create 300k TXs per day
1762017-06-02T13:42:51 <Lauda> now pay me 498 BTC
1772017-06-02T13:44:49 *** goatturneer has joined #bitcoin-core-dev
1782017-06-02T13:48:35 *** beatrootfarmer has quit IRC
1792017-06-02T14:00:38 *** beatrootfarmer has joined #bitcoin-core-dev
1802017-06-02T14:04:31 *** goatturneer has quit IRC
1812017-06-02T14:09:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822017-06-02T14:20:32 *** twistedline has quit IRC
1832017-06-02T14:22:21 *** twistedline has joined #bitcoin-core-dev
1842017-06-02T14:24:17 *** Giszmo has joined #bitcoin-core-dev
1852017-06-02T14:27:03 *** Taek42 is now known as Taek
1862017-06-02T14:41:54 *** laurentmt has joined #bitcoin-core-dev
1872017-06-02T14:50:06 <kinlo> mja, ge moest u inschrijven, ik ben aant hore of ik wel kan
1882017-06-02T14:50:15 *** Dyaheon has quit IRC
1892017-06-02T14:50:23 <kinlo> wrong channel :/
1902017-06-02T14:50:53 *** Dyaheon has joined #bitcoin-core-dev
1912017-06-02T14:56:39 *** elkalamar has quit IRC
1922017-06-02T14:56:41 *** laurentmt has quit IRC
1932017-06-02T15:03:52 *** jannes has quit IRC
1942017-06-02T15:20:42 *** goatturneer has joined #bitcoin-core-dev
1952017-06-02T15:24:37 *** beatrootfarmer has quit IRC
1962017-06-02T15:26:41 <jonasschnelli> wumpus: do you intend to directly bump to rc2 or does it make sense to gitian build rc1?
1972017-06-02T15:26:52 <wumpus> I'd prefer to just go on with it
1982017-06-02T15:27:18 <wumpus> I'll just add in the announcement that the version isn't bumped and we'll do that for next rc
1992017-06-02T15:28:43 <jonasschnelli> okay.. fine by me
2002017-06-02T15:30:23 <wumpus> I'd expect something to come up for rc1, and if not, well then we'll do a very short rc2 just to see if the version bump worked
2012017-06-02T15:49:36 *** abpa has joined #bitcoin-core-dev
2022017-06-02T15:57:19 *** beatrootfarmer has joined #bitcoin-core-dev
2032017-06-02T15:58:18 *** goatturner has joined #bitcoin-core-dev
2042017-06-02T16:01:17 *** goatturneer has quit IRC
2052017-06-02T16:01:54 *** beatrootfarmer has quit IRC
2062017-06-02T16:15:11 *** BashCo has quit IRC
2072017-06-02T16:18:49 *** rafalcpp has quit IRC
2082017-06-02T16:37:43 *** BashCo has joined #bitcoin-core-dev
2092017-06-02T16:40:57 *** chjj has quit IRC
2102017-06-02T16:54:07 *** RubenSomsen has quit IRC
2112017-06-02T16:55:02 *** NewLiberty has quit IRC
2122017-06-02T16:55:19 *** chjj has joined #bitcoin-core-dev
2132017-06-02T17:05:15 *** RubenSomsen has joined #bitcoin-core-dev
2142017-06-02T17:25:45 *** Chris_Stewart_5 has quit IRC
2152017-06-02T17:34:35 *** vicenteH has quit IRC
2162017-06-02T17:47:59 *** laurentmt has joined #bitcoin-core-dev
2172017-06-02T18:07:19 *** ula has quit IRC
2182017-06-02T18:07:49 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2192017-06-02T18:09:48 *** spudowiar has joined #bitcoin-core-dev
2202017-06-02T18:11:05 <spudowiar> What's the protocol for adding new strings to Bitcoin Core? Do I have to worry about translation or will that be sorted by others?
2212017-06-02T18:14:13 *** Chris_Stewart_5 has quit IRC
2222017-06-02T18:15:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2232017-06-02T18:15:56 <sipa> spudowiar: don't worry about it
2242017-06-02T18:16:10 <sipa> in the 0.15 release notes there is a string freeze
2252017-06-02T18:16:16 <sipa> eh, release schedule
2262017-06-02T18:16:33 <sipa> after that time, no changes to strings can be made anymore, to give time for translators
2272017-06-02T18:17:09 <spudowiar> Thanks :)
2282017-06-02T18:20:52 *** Gnof_ has joined #bitcoin-core-dev
2292017-06-02T18:24:27 *** Gnof has quit IRC
2302017-06-02T18:29:05 *** RubenSomsen has quit IRC
2312017-06-02T18:33:22 *** Gnof_ has quit IRC
2322017-06-02T18:40:07 <jnewbery> wumpus: please remove #10044 from high priority for review - I'm not actively working on it for now
2332017-06-02T18:40:09 <gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
2342017-06-02T18:40:21 <sipa> jnewbery: :(
2352017-06-02T18:41:06 <sipa> jnewbery: done
2362017-06-02T18:41:51 <jnewbery> sipa: do you particularly want it? I didn't sense there was all that much enthusiasm for it
2372017-06-02T18:43:11 <spudowiar> Can I use C++11 std::map::at()?
2382017-06-02T18:43:53 <sipa> spudowiar: yes, but i would advise against relying on exceptions
2392017-06-02T18:44:03 <spudowiar> Why?
2402017-06-02T18:45:15 <sipa> especially in the case of at; you can just use auto it = map.find(key); if (it != map.end()) { ... } else { ... } instead
2412017-06-02T18:45:34 <spudowiar> Ah, I'll do that instead then
2422017-06-02T18:45:40 <spudowiar> Thanks!
2432017-06-02T18:46:06 <sipa> jnewbery: i conceptually like i very much... i think make check should do ~all reasonable checking
2442017-06-02T18:46:18 <sipa> but i understand there are concerns that make the choice of what to run where and when hard
2452017-06-02T18:47:12 <jnewbery> yeah - I couldn't seem to converge with others on what's a sensible choice of what to run
2462017-06-02T18:47:54 <jnewbery> I'll probably pick it up again at some point, but it shouldn't really be in the review priority bucket since there's nothing to review at this point
2472017-06-02T18:47:56 <sipa> perhaps something to bring up as a meeting topic
2482017-06-02T18:48:06 <sipa> agree with removing it from priority review list
2492017-06-02T18:49:19 *** Dyaheon has quit IRC
2502017-06-02T18:49:40 *** Dyaheon has joined #bitcoin-core-dev
2512017-06-02T18:53:27 *** Guest26727 has quit IRC
2522017-06-02T18:55:06 *** Guest80280 has joined #bitcoin-core-dev
2532017-06-02T18:56:50 *** Chris_Stewart_5 has quit IRC
2542017-06-02T18:59:09 <spudowiar> Do you have any qualms with executing a command and piping data into it?
2552017-06-02T18:59:17 <spudowiar> Also, are there any examples of this in the Bitcoin Core code?
2562017-06-02T19:04:15 <spudowiar> Before, I was using popen but now I want to clean up this patch in order to submit it
2572017-06-02T19:10:22 *** Guyver2 has quit IRC
2582017-06-02T19:17:00 *** PaulCapestany has quit IRC
2592017-06-02T19:19:39 <spudowiar> Should I be adding more code using boost? Because I could use boost::process for this
2602017-06-02T19:20:03 <spudowiar> I mean, should I be avoiding using boost?
2612017-06-02T19:20:13 *** PaulCapestany has joined #bitcoin-core-dev
2622017-06-02T19:32:12 *** SopaXorzTaker has quit IRC
2632017-06-02T19:38:17 *** spudowiar has quit IRC
2642017-06-02T19:41:00 *** talmai has joined #bitcoin-core-dev
2652017-06-02T20:01:53 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2662017-06-02T20:02:40 *** jtimon has quit IRC
2672017-06-02T20:10:45 *** Yogaqueef has quit IRC
2682017-06-02T20:11:56 *** talmai has quit IRC
2692017-06-02T20:15:05 *** talmai has joined #bitcoin-core-dev
2702017-06-02T20:25:03 *** elkalamar has joined #bitcoin-core-dev
2712017-06-02T20:39:07 *** Chris_Stewart_5 has quit IRC
2722017-06-02T20:44:35 *** talmai has quit IRC
2732017-06-02T20:49:18 *** jtimon has joined #bitcoin-core-dev
2742017-06-02T21:09:10 *** talmai has joined #bitcoin-core-dev
2752017-06-02T21:12:57 *** dermoth has quit IRC
2762017-06-02T21:19:04 <bitcoin-git> [bitcoin] achow101 opened pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511
2772017-06-02T21:25:36 *** dermoth has joined #bitcoin-core-dev
2782017-06-02T21:30:27 *** elkalamar has quit IRC
2792017-06-02T21:35:00 *** talmai has quit IRC
2802017-06-02T21:37:06 *** talmai has joined #bitcoin-core-dev
2812017-06-02T21:42:22 *** tiagotrs_ has joined #bitcoin-core-dev
2822017-06-02T21:43:00 *** talmai has quit IRC
2832017-06-02T22:04:01 *** harrymm has joined #bitcoin-core-dev
2842017-06-02T22:05:14 <bitcoin-git> [bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
2852017-06-02T22:11:38 *** tiagotrs_ has quit IRC
2862017-06-02T22:12:54 *** tiagotrs1 has joined #bitcoin-core-dev
2872017-06-02T22:15:19 <bitcoin-git> [bitcoin] ABISprotocol opened pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513
2882017-06-02T22:24:58 *** elkalamar has joined #bitcoin-core-dev
2892017-06-02T22:27:55 *** altoz has quit IRC
2902017-06-02T22:28:11 *** altoz has joined #bitcoin-core-dev
2912017-06-02T22:29:52 *** spudowiar has joined #bitcoin-core-dev
2922017-06-02T22:31:54 *** jrayhawk_ has joined #bitcoin-core-dev
2932017-06-02T22:32:05 <spudowiar> gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
2942017-06-02T22:36:41 <gmaxwell> spudowiar: almost certantly not, needing megabytes of ram to buffer such a thing require several extra dollars in parts.
2952017-06-02T22:36:58 <spudowiar> No, not on the actual hardware wallet
2962017-06-02T22:37:08 <spudowiar> For the vendor specific tools
2972017-06-02T22:37:09 <gmaxwell> spudowiar: existing hardware wallets go through serious work to avoid even having to buffer a single transaction, much less a json encoded one.
2982017-06-02T22:37:37 <gmaxwell> uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
2992017-06-02T22:37:53 <spudowiar> No, because most hardware wallets serialize it themselves
3002017-06-02T22:38:33 <spudowiar> Although I have a very complete understanding of Trezor and a very limited ones of others
3012017-06-02T22:39:03 <spudowiar> Btw, didn't jonasschnelli's hardware wallet used to use JSON :)
3022017-06-02T22:39:31 <spudowiar> Anyway, I was using Protocol Buffers in my PoC but I knew I couldn't submit that because you'd probably kill me ;)
3032017-06-02T22:40:27 *** Lightsword_ has joined #bitcoin-core-dev
3042017-06-02T22:40:27 *** Lightsword has quit IRC
3052017-06-02T22:40:27 *** jrayhawk has quit IRC
3062017-06-02T22:40:27 *** thermoman has quit IRC
3072017-06-02T22:40:34 *** thermoman has joined #bitcoin-core-dev
3082017-06-02T22:41:05 <spudowiar> Basically my patch takes an argument -hardwarewallet=<cmd>
3092017-06-02T22:41:19 *** Lightsword_ is now known as Lightsword
3102017-06-02T22:41:48 <spudowiar> When you spend with the wallet, it executes the command, pipes in the transaction (in Protocol Buffers at the moment) and the command returns the serialized transaction
3112017-06-02T22:41:55 <spudowiar> Then Bitcoin Core verifies that
3122017-06-02T22:42:27 <spudowiar> If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
3132017-06-02T22:42:35 *** tiagotrs1 has quit IRC
3142017-06-02T22:43:51 * luke-jr idly ponders if there's a way to do that such that bitcoind is itself a valid -hardwarewallet
3152017-06-02T22:44:18 <gmaxwell> I don't see why you wouldn't use the ordinary serialization plus metadata, _any_ hardware wallet needs to be able to handle the serialization of transactions. Plus how would you proprose to handle things like coinjoins and partially signed multsigs?
3162017-06-02T22:44:20 <spudowiar> I don't have bitcoind as one, but I have a script that talks to a bitcoind over RPC
3172017-06-02T22:44:51 <spudowiar> gmaxwell: Hardware wallets don't deserialize the transactions, they always accept it in a different format
3182017-06-02T22:45:10 <spudowiar> JSON is so much easier because, otherwise, each tool has to deserialize the transaction
3192017-06-02T22:45:55 <spudowiar> Partially signed multisig, on a TREZOR, is done totally differently to a P2PKH
3202017-06-02T22:47:00 <spudowiar> luke-jr: ln -s bitcoind bitcoind-hardwarewallet and do an argv check :)
3212017-06-02T22:47:44 <gmaxwell> spudowiar: of course they do, e.g. to pass them the inputs for value checking you must pass them the input transactions exactly.
3222017-06-02T22:48:26 <spudowiar> Oh, yeah. But they don't deserialize the to-be-signed transaction
3232017-06-02T22:50:58 <sipa> then how do they compute the sighash?
3242017-06-02T22:51:14 <spudowiar> They serialize it from their own format
3252017-06-02T22:51:21 <spudowiar> e.g. TREZOR uses Protocol Buffers
3262017-06-02T22:52:24 <luke-jr> spudowiar: i was thinking more of using JSON-RPC over stdio
3272017-06-02T22:52:47 <spudowiar> That's an interesting idea
3282017-06-02T22:53:20 <spudowiar> Because a hardware wallet could ask for transactions when it needs them, etc.
3292017-06-02T22:54:01 <spudowiar> Anyway, should I be adding more uses of boost? Was thinking of using boost::process
3302017-06-02T22:54:16 <spudowiar> In my PoC I used popen and pclose but that's not very C++-esque
3312017-06-02T22:56:06 <gmaxwell> it just seems like a total waste of time and effort to define a whole new seralization which has to be completely compatible and able to encode everything a transaction can encode.
3322017-06-02T22:56:10 <gmaxwell> Whats the purpose?
3332017-06-02T22:56:44 <luke-jr> gmaxwell: HW wallet vendor provides a plugin for Core
3342017-06-02T22:56:51 <spudowiar> But then each script has to deserialize the transaction which seems like a total waste of time ;)
3352017-06-02T22:59:37 <gmaxwell> spudowiar: that isn't escape by using a _different_ seralization.
3362017-06-02T23:00:20 <spudowiar> Python, for example, has built-in JSON support
3372017-06-02T23:02:19 <spudowiar> JSON-RPC over stdio seems like a neat idea though
3382017-06-02T23:06:05 <spudowiar> gmaxwell: What about using the format for decoderawtransaction (possibly with a bit more metadata, if needed)
3392017-06-02T23:07:28 <sipa> whatever you do, please don't try to represent multisig as multiple addresses :)
3402017-06-02T23:11:02 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/329fc1dce7a1...098b01dc58ff
3412017-06-02T23:11:02 <bitcoin-git> bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
3422017-06-02T23:11:03 <bitcoin-git> bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
3432017-06-02T23:11:34 <bitcoin-git> [bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
3442017-06-02T23:11:42 *** Guest80280 has quit IRC
3452017-06-02T23:11:56 *** tiagotrs has joined #bitcoin-core-dev
3462017-06-02T23:11:59 <luke-jr> hm, 0.14.2 seems to have missed some fixes still :x
3472017-06-02T23:12:38 <gmaxwell> spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support! and then you have to worry about that your json format cannot losslessly represent a transaction. Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
3482017-06-02T23:13:40 <luke-jr> gmaxwell: the other end would translate the JSON into some hardware interface; the hardware wallet itself does the serialisation
3492017-06-02T23:13:51 <luke-jr> ie, there's a middle-man who has no need to understand ser/des
3502017-06-02T23:14:08 <spudowiar> ^^
3512017-06-02T23:15:02 *** abpa has quit IRC
3522017-06-02T23:16:58 <aj> gmaxwell: (post-segwit you don't want the serialised input tx, you just want the txid, value and some signing key id, no?)
3532017-06-02T23:17:14 <sipa> yes
3542017-06-02T23:17:15 <luke-jr> spudowiar: note that using JSON-RPC means bitcoind will call signrawtransaction, and you'll have to deserialise (or pass as-is?)
3552017-06-02T23:18:38 <spudowiar> What do you mean? I was thinking of sending the current transaction then the hardware wallet could ask for input transactions (and the script would use JSON RPC to grab them)
3562017-06-02T23:20:19 <gmaxwell> aj: not for the inputs, but you still want the whole transaction itself.
3572017-06-02T23:20:41 *** abpa has joined #bitcoin-core-dev
3582017-06-02T23:21:40 <gmaxwell> aj: I think it would be fairly hard and at least wasteful to define a whole new serialization that is a guarenteed superset of the transaction format. I think spudowiar is thinking that you can just say {pay inputs x,y,z to destination a,b,c} but that doesn't work if the hw wallet isn't the author of the whole transaction.
3592017-06-02T23:22:18 *** abpa has quit IRC
3602017-06-02T23:23:23 <spudowiar> gmaxwell: that is literally what all hardware wallets do right now
3612017-06-02T23:23:47 <spudowiar> Even for multisig, they don't accept a serialized transaction
3622017-06-02T23:24:18 <arubi> (this is why I was requesting raw sighash support :) )
3632017-06-02T23:24:24 <aj> gmaxwell: yeah, i think i agree; i think you just want to send the serialised partially-filled out tx you want to create/sign, and extra info needed to do the signature (txids, tx values, pre-segwit-serialised-input-txes, SIGHASH params, etc)?
3642017-06-02T23:24:36 <gmaxwell> spudowiar: that isn't true; ledger takes seralized transactions.
3652017-06-02T23:24:50 <gmaxwell> aj: yes, thats my thinking.
3662017-06-02T23:24:52 <spudowiar> Oh, does it? I didn't know
3672017-06-02T23:26:54 *** andytoshi has joined #bitcoin-core-dev
3682017-06-02T23:41:03 <bitcoin-git> [bitcoin] sipa opened pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
3692017-06-02T23:42:17 <spudowiar> I wonder if it's a good to switch from Google's Protocol Buffers implementation to nanopb
3702017-06-02T23:42:36 <spudowiar> Google's Protocol Buffers code generator generates an utter mess
3712017-06-02T23:42:53 <spudowiar> But nanopb generates some nice code (it's used in TREZOR)
3722017-06-02T23:43:24 <spudowiar> s/a good/a good idea/
3732017-06-02T23:46:00 *** kadoban has joined #bitcoin-core-dev
3742017-06-02T23:53:08 *** tiagotrs has quit IRC
3752017-06-02T23:55:39 *** spudowiar has quit IRC