12017-06-21T00:00:32 *** PRab has quit IRC
22017-06-21T00:01:31 *** chjj has quit IRC
32017-06-21T00:03:04 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d636f3943d39...b33ca14f594e
42017-06-21T00:03:04 <bitcoin-git> bitcoin/master 95543d8 practicalswift: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...)...
52017-06-21T00:03:04 <bitcoin-git> bitcoin/master b33ca14 Pieter Wuille: Merge #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...)...
62017-06-21T00:03:15 <bitcoin-git> [bitcoin] sipa closed pull request #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...) (master...avoid-potential-null-pointer-dereference-in-markblockasinflight) https://github.com/bitcoin/bitcoin/pull/9549
72017-06-21T00:13:08 *** laurentmt has joined #bitcoin-core-dev
82017-06-21T00:13:08 *** laurentmt has quit IRC
92017-06-21T00:14:57 *** chjj has joined #bitcoin-core-dev
102017-06-21T00:17:26 *** petertod1 is now known as petertodd
112017-06-21T00:39:41 *** davec_ has quit IRC
122017-06-21T00:50:54 *** [\\\] is now known as tripleslash
132017-06-21T00:51:59 *** eenoch_ has quit IRC
142017-06-21T00:52:19 *** eenoch has joined #bitcoin-core-dev
152017-06-21T00:56:52 *** sipa_ is now known as sipa
162017-06-21T00:57:12 *** sipa has quit IRC
172017-06-21T00:57:12 *** sipa has joined #bitcoin-core-dev
182017-06-21T00:58:36 *** dabura667 has joined #bitcoin-core-dev
192017-06-21T01:00:49 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b33ca14f594e...efbcf2b1d5ff
202017-06-21T01:00:49 <bitcoin-git> bitcoin/master d9bec88 Pieter Wuille: Use REJECT_DUPLICATE for already known and conflicted txn
212017-06-21T01:00:50 <bitcoin-git> bitcoin/master efbcf2b Pieter Wuille: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn...
222017-06-21T01:01:09 <bitcoin-git> [bitcoin] sipa closed pull request #10503: Use REJECT_DUPLICATE for already known and conflicted txn (master...more61duplicate) https://github.com/bitcoin/bitcoin/pull/10503
232017-06-21T01:09:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
242017-06-21T01:10:39 *** JackH has quit IRC
252017-06-21T01:12:02 *** Ylbam has quit IRC
262017-06-21T01:17:25 *** imposter has joined #bitcoin-core-dev
272017-06-21T01:24:09 *** imposter has quit IRC
282017-06-21T01:26:28 *** BobBarker has joined #bitcoin-core-dev
292017-06-21T01:26:35 *** JackH has joined #bitcoin-core-dev
302017-06-21T01:28:07 <bitcoin-git> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/efbcf2b1d5ff...b3eb0d648551
312017-06-21T01:28:08 <bitcoin-git> bitcoin/master ec1271f Matt Corallo: Remove useless mapNextTx lookup in CTxMemPool::TrimToSize....
322017-06-21T01:28:08 <bitcoin-git> bitcoin/master 3533fb4 Matt Corallo: Return a bool in SpendCoin to restore pre-per-utxo assert semantics...
332017-06-21T01:28:09 <bitcoin-git> bitcoin/master f58349c Matt Corallo: Restore some assert semantics in sigop cost calculations...
342017-06-21T01:28:40 <bitcoin-git> [bitcoin] sipa closed pull request #10537: Few Minor per-utxo assert-semantics re-adds and tweak (master...2017-06-per-utxo-fixes) https://github.com/bitcoin/bitcoin/pull/10537
352017-06-21T01:30:05 *** dermoth has quit IRC
362017-06-21T01:30:47 *** dermoth has joined #bitcoin-core-dev
372017-06-21T01:41:37 *** davec has joined #bitcoin-core-dev
382017-06-21T01:43:11 *** talmai has joined #bitcoin-core-dev
392017-06-21T01:43:53 *** Chris_Stewart_5 has quit IRC
402017-06-21T01:49:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
412017-06-21T01:56:35 *** dermoth has quit IRC
422017-06-21T02:02:00 *** dermoth has joined #bitcoin-core-dev
432017-06-21T02:04:25 *** belcher_ has quit IRC
442017-06-21T02:05:58 *** talmai has quit IRC
452017-06-21T02:23:20 *** harrymm has quit IRC
462017-06-21T02:26:39 *** goatpig has quit IRC
472017-06-21T02:39:38 *** harrymm has joined #bitcoin-core-dev
482017-06-21T03:18:48 *** PRab has joined #bitcoin-core-dev
492017-06-21T03:23:59 *** harrymm has quit IRC
502017-06-21T03:26:36 *** Giszmo has quit IRC
512017-06-21T03:29:27 *** achow101 has quit IRC
522017-06-21T03:32:27 *** shesek has quit IRC
532017-06-21T03:43:29 *** harrymm has joined #bitcoin-core-dev
542017-06-21T03:56:28 *** Chris_Stewart_5 has quit IRC
552017-06-21T04:16:53 *** imposter has joined #bitcoin-core-dev
562017-06-21T04:17:16 *** dermoth has quit IRC
572017-06-21T04:21:31 *** dermoth has joined #bitcoin-core-dev
582017-06-21T04:23:38 *** harrymm has quit IRC
592017-06-21T04:33:34 *** rodarmor has joined #bitcoin-core-dev
602017-06-21T04:37:09 *** harrymm has joined #bitcoin-core-dev
612017-06-21T04:52:33 *** Aaronvan_ has joined #bitcoin-core-dev
622017-06-21T04:54:26 *** AaronvanW has quit IRC
632017-06-21T04:56:53 *** Aaronvan_ has quit IRC
642017-06-21T05:26:16 *** instagibbs has quit IRC
652017-06-21T05:29:44 *** instagibbs has joined #bitcoin-core-dev
662017-06-21T05:41:08 *** AaronvanW has joined #bitcoin-core-dev
672017-06-21T05:48:13 *** jamesob_ has quit IRC
682017-06-21T05:48:29 *** jamesob has joined #bitcoin-core-dev
692017-06-21T05:49:18 *** jamesob has joined #bitcoin-core-dev
702017-06-21T05:50:04 *** jamesob has joined #bitcoin-core-dev
712017-06-21T05:50:54 *** jamesob has joined #bitcoin-core-dev
722017-06-21T05:51:44 *** jamesob has joined #bitcoin-core-dev
732017-06-21T05:52:13 *** jamesob has quit IRC
742017-06-21T05:52:29 *** jamesob has joined #bitcoin-core-dev
752017-06-21T05:53:19 *** jamesob has joined #bitcoin-core-dev
762017-06-21T05:53:49 *** jamesob has quit IRC
772017-06-21T05:54:04 *** jamesob has joined #bitcoin-core-dev
782017-06-21T05:54:54 *** jamesob has joined #bitcoin-core-dev
792017-06-21T05:55:44 *** jamesob has joined #bitcoin-core-dev
802017-06-21T05:56:13 *** jamesob has quit IRC
812017-06-21T05:56:29 *** jamesob has joined #bitcoin-core-dev
822017-06-21T05:57:19 *** jamesob has joined #bitcoin-core-dev
832017-06-21T05:57:49 *** jamesob has quit IRC
842017-06-21T05:58:04 *** jamesob has joined #bitcoin-core-dev
852017-06-21T05:58:52 *** jamesob has joined #bitcoin-core-dev
862017-06-21T05:59:41 *** jamesob has joined #bitcoin-core-dev
872017-06-21T06:00:03 *** dermoth has quit IRC
882017-06-21T06:00:13 *** jamesob has quit IRC
892017-06-21T06:00:32 *** jamesob has joined #bitcoin-core-dev
902017-06-21T06:00:47 *** dermoth has joined #bitcoin-core-dev
912017-06-21T06:01:01 *** jamesob has quit IRC
922017-06-21T06:01:03 *** AaronvanW has quit IRC
932017-06-21T06:01:37 *** jamesob has joined #bitcoin-core-dev
942017-06-21T06:01:42 *** AaronvanW has joined #bitcoin-core-dev
952017-06-21T06:05:55 *** jamesob has quit IRC
962017-06-21T06:06:18 *** AaronvanW has quit IRC
972017-06-21T06:17:06 *** LeMiner has joined #bitcoin-core-dev
982017-06-21T06:43:11 *** achow101 has joined #bitcoin-core-dev
992017-06-21T06:47:10 *** JackH has quit IRC
1002017-06-21T06:51:24 *** rockhouse has joined #bitcoin-core-dev
1012017-06-21T06:59:51 *** JackH has joined #bitcoin-core-dev
1022017-06-21T07:02:07 *** neel has joined #bitcoin-core-dev
1032017-06-21T07:07:06 *** neel has quit IRC
1042017-06-21T07:07:13 *** neel has joined #bitcoin-core-dev
1052017-06-21T07:23:21 *** neel has quit IRC
1062017-06-21T07:29:56 *** Ylbam has joined #bitcoin-core-dev
1072017-06-21T07:30:16 *** griswaalt has quit IRC
1082017-06-21T07:32:24 *** sturles_ is now known as sturles
1092017-06-21T07:58:56 *** neel has joined #bitcoin-core-dev
1102017-06-21T08:01:23 *** goatpig has joined #bitcoin-core-dev
1112017-06-21T08:01:31 *** dermoth has quit IRC
1122017-06-21T08:02:48 *** jamesob has joined #bitcoin-core-dev
1132017-06-21T08:07:27 *** jamesob has quit IRC
1142017-06-21T08:07:48 *** dermoth has joined #bitcoin-core-dev
1152017-06-21T08:13:54 *** timothy has joined #bitcoin-core-dev
1162017-06-21T08:19:24 *** imposter has quit IRC
1172017-06-21T08:19:53 *** neel has quit IRC
1182017-06-21T08:21:19 *** neel has joined #bitcoin-core-dev
1192017-06-21T08:27:35 *** dermoth has quit IRC
1202017-06-21T08:29:41 *** dermoth has joined #bitcoin-core-dev
1212017-06-21T08:44:30 *** vicenteH has joined #bitcoin-core-dev
1222017-06-21T09:23:33 *** dermoth has quit IRC
1232017-06-21T09:25:15 *** neel has quit IRC
1242017-06-21T09:27:46 *** dermoth has joined #bitcoin-core-dev
1252017-06-21T09:28:53 *** riemann has joined #bitcoin-core-dev
1262017-06-21T09:35:13 *** arubi has quit IRC
1272017-06-21T09:38:07 *** dermoth has quit IRC
1282017-06-21T09:40:18 *** dermoth has joined #bitcoin-core-dev
1292017-06-21T09:56:31 *** neel has joined #bitcoin-core-dev
1302017-06-21T09:57:04 *** neel has joined #bitcoin-core-dev
1312017-06-21T10:04:06 *** jamesob has joined #bitcoin-core-dev
1322017-06-21T10:06:06 *** dermoth has quit IRC
1332017-06-21T10:08:16 *** dermoth has joined #bitcoin-core-dev
1342017-06-21T10:08:36 *** jamesob has quit IRC
1352017-06-21T10:13:53 *** nemgun has joined #bitcoin-core-dev
1362017-06-21T10:18:30 *** arubi has joined #bitcoin-core-dev
1372017-06-21T10:20:17 *** dermoth has quit IRC
1382017-06-21T10:22:20 *** dermoth has joined #bitcoin-core-dev
1392017-06-21T10:25:23 *** afk11 has quit IRC
1402017-06-21T10:25:39 *** afk11 has joined #bitcoin-core-dev
1412017-06-21T10:34:48 *** bordeaux_facile has quit IRC
1422017-06-21T10:37:08 *** bordeaux_facile has joined #bitcoin-core-dev
1432017-06-21T10:40:20 *** neel has quit IRC
1442017-06-21T10:41:55 *** neel has joined #bitcoin-core-dev
1452017-06-21T10:43:46 *** neel has quit IRC
1462017-06-21T10:44:47 *** bordeaux_facile has quit IRC
1472017-06-21T10:45:22 *** bordeaux_facile has joined #bitcoin-core-dev
1482017-06-21T10:47:40 *** bordeaux_facile has quit IRC
1492017-06-21T10:48:39 *** bordeaux_facile has joined #bitcoin-core-dev
1502017-06-21T10:55:31 *** AaronvanW has joined #bitcoin-core-dev
1512017-06-21T11:02:08 *** neel_ has joined #bitcoin-core-dev
1522017-06-21T11:05:28 *** jamesob has joined #bitcoin-core-dev
1532017-06-21T11:09:44 *** jamesob has quit IRC
1542017-06-21T11:09:44 *** AaronvanW has quit IRC
1552017-06-21T11:13:27 *** neel_ has quit IRC
1562017-06-21T11:20:43 *** [b__b] has quit IRC
1572017-06-21T11:22:50 <bitcoin-git> [bitcoin] practicalswift opened pull request #10642: Use the _MSC_VER macro only if it is defined (master...undefined-msc-ver) https://github.com/bitcoin/bitcoin/pull/10642
1582017-06-21T11:28:52 *** [b__b] has joined #bitcoin-core-dev
1592017-06-21T11:39:15 *** roasbeef_ is now known as roasbeef
1602017-06-21T11:54:03 *** shesek has joined #bitcoin-core-dev
1612017-06-21T11:56:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1622017-06-21T12:00:58 *** neel has joined #bitcoin-core-dev
1632017-06-21T12:02:26 *** talmai has joined #bitcoin-core-dev
1642017-06-21T12:02:54 *** dabura667 has quit IRC
1652017-06-21T12:05:57 *** jamesob has joined #bitcoin-core-dev
1662017-06-21T12:10:01 *** jamesob has quit IRC
1672017-06-21T12:16:28 *** Dyaheon has quit IRC
1682017-06-21T12:17:09 *** Dyaheon has joined #bitcoin-core-dev
1692017-06-21T12:31:50 *** SopaXorzTaker has joined #bitcoin-core-dev
1702017-06-21T12:42:43 *** laurentmt has joined #bitcoin-core-dev
1712017-06-21T12:44:21 *** laurentmt has quit IRC
1722017-06-21T12:52:31 *** Chris_Stewart_5 has quit IRC
1732017-06-21T12:53:30 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742017-06-21T12:54:26 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/b3eb0d648551...d083bd9b9c52
1752017-06-21T12:54:27 <bitcoin-git> bitcoin/master c53c983 Andrew Chow: Replace cookie auth in tests...
1762017-06-21T12:54:28 <bitcoin-git> bitcoin/master 3ec5ad8 Andrew Chow: Add test for rpcuser/rpcpassword
1772017-06-21T12:54:28 <bitcoin-git> bitcoin/master 279fde5 Andrew Chow: Check for rpcuser/rpcpassword first then for cookie...
1782017-06-21T12:55:02 <bitcoin-git> [bitcoin] laanwj closed pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
1792017-06-21T13:04:54 *** laurentmt has joined #bitcoin-core-dev
1802017-06-21T13:17:20 *** jannes has joined #bitcoin-core-dev
1812017-06-21T13:25:44 *** Guyver2 has joined #bitcoin-core-dev
1822017-06-21T13:30:42 *** laurentmt has quit IRC
1832017-06-21T13:41:02 *** dunatotatos has joined #bitcoin-core-dev
1842017-06-21T13:49:35 *** dermoth has quit IRC
1852017-06-21T13:51:37 *** dermoth has joined #bitcoin-core-dev
1862017-06-21T13:55:54 *** laurentmt has joined #bitcoin-core-dev
1872017-06-21T14:03:46 *** talmai has quit IRC
1882017-06-21T14:07:15 *** jamesob has joined #bitcoin-core-dev
1892017-06-21T14:11:54 *** jamesob has quit IRC
1902017-06-21T14:13:51 *** neel has quit IRC
1912017-06-21T14:14:30 *** dermoth has quit IRC
1922017-06-21T14:18:39 *** dermoth has joined #bitcoin-core-dev
1932017-06-21T14:23:42 *** dermoth has quit IRC
1942017-06-21T14:26:45 *** neel has joined #bitcoin-core-dev
1952017-06-21T14:31:01 *** neel has quit IRC
1962017-06-21T14:31:48 *** dermoth has joined #bitcoin-core-dev
1972017-06-21T14:35:52 <bitcoin-git> [bitcoin] rexuslexus opened pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643
1982017-06-21T14:36:47 <bitcoin-git> [bitcoin] rexuslexus closed pull request #10643: TestCoin 0.0.1 (master...master) https://github.com/bitcoin/bitcoin/pull/10643
1992017-06-21T14:38:39 *** dermoth has quit IRC
2002017-06-21T14:40:40 *** dermoth has joined #bitcoin-core-dev
2012017-06-21T14:52:04 *** dermoth has quit IRC
2022017-06-21T14:53:40 *** Guyver2 has quit IRC
2032017-06-21T14:54:23 *** riemann has quit IRC
2042017-06-21T14:56:11 *** dermoth has joined #bitcoin-core-dev
2052017-06-21T15:02:58 *** Dyaheon has quit IRC
2062017-06-21T15:03:56 *** Dyaheon has joined #bitcoin-core-dev
2072017-06-21T15:10:04 *** talmai has joined #bitcoin-core-dev
2082017-06-21T15:12:30 *** talmai has quit IRC
2092017-06-21T15:17:41 *** neel has joined #bitcoin-core-dev
2102017-06-21T15:18:30 *** harrymm has quit IRC
2112017-06-21T15:22:05 *** neel has quit IRC
2122017-06-21T15:28:10 *** JackH has quit IRC
2132017-06-21T15:29:38 *** dermoth has quit IRC
2142017-06-21T15:33:31 *** neel has joined #bitcoin-core-dev
2152017-06-21T15:37:27 *** harrymm has joined #bitcoin-core-dev
2162017-06-21T15:40:40 *** JackH has joined #bitcoin-core-dev
2172017-06-21T15:50:31 *** abpa has joined #bitcoin-core-dev
2182017-06-21T16:06:24 *** Dizzle has joined #bitcoin-core-dev
2192017-06-21T16:08:39 *** jamesob has joined #bitcoin-core-dev
2202017-06-21T16:09:15 *** goatpig has quit IRC
2212017-06-21T16:09:20 *** Cheeseo has joined #bitcoin-core-dev
2222017-06-21T16:11:12 *** RoyceX has quit IRC
2232017-06-21T16:13:10 *** jamesob has quit IRC
2242017-06-21T16:13:33 *** goatpig has joined #bitcoin-core-dev
2252017-06-21T16:23:08 *** neel has quit IRC
2262017-06-21T16:37:55 *** imposter has joined #bitcoin-core-dev
2272017-06-21T16:46:58 *** neel has joined #bitcoin-core-dev
2282017-06-21T16:49:47 *** Cheeseo has quit IRC
2292017-06-21T16:50:06 *** Cheeseo has joined #bitcoin-core-dev
2302017-06-21T16:54:35 *** Chris_Stewart_5 has quit IRC
2312017-06-21T17:05:47 *** Dyaheon has quit IRC
2322017-06-21T17:10:03 *** jamesob has joined #bitcoin-core-dev
2332017-06-21T17:10:05 *** Dyaheon has joined #bitcoin-core-dev
2342017-06-21T17:14:25 *** jamesob has quit IRC
2352017-06-21T17:15:20 *** timothy has quit IRC
2362017-06-21T17:19:24 *** neel has quit IRC
2372017-06-21T17:20:50 *** JackH has quit IRC
2382017-06-21T17:22:04 *** paracyst_ has quit IRC
2392017-06-21T17:22:16 *** paracyst has joined #bitcoin-core-dev
2402017-06-21T17:23:00 *** chjj has quit IRC
2412017-06-21T17:27:17 *** neel has joined #bitcoin-core-dev
2422017-06-21T17:32:00 *** altoz has joined #bitcoin-core-dev
2432017-06-21T17:36:04 *** chjj has joined #bitcoin-core-dev
2442017-06-21T17:36:38 *** vicenteH has quit IRC
2452017-06-21T17:38:57 *** Alina-malina has quit IRC
2462017-06-21T17:42:59 <achow101> anyone know what's up with travis failing on #10637?
2472017-06-21T17:43:00 <gribble> https://github.com/bitcoin/bitcoin/issues/10637 | Coin Selection with Murchs algorithm by achow101 · Pull Request #10637 · bitcoin/bitcoin · GitHub
2482017-06-21T17:45:37 *** Alina-malina has joined #bitcoin-core-dev
2492017-06-21T17:45:52 *** LeMiner has quit IRC
2502017-06-21T17:49:41 *** Alina-malina has quit IRC
2512017-06-21T17:49:42 *** Alina-malina has joined #bitcoin-core-dev
2522017-06-21T18:06:15 <jonasschnelli> achow101: unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": std::out_of_range: vector::_M_range_check
2532017-06-21T18:06:53 <jonasschnelli> mempool_limit.py | â Failed | 4 s
2542017-06-21T18:06:57 <jonasschnelli> fundrawtransaction.py | â Failed | 12 s
2552017-06-21T18:07:20 <sipa> sounds like an out of bounds access of a vector
2562017-06-21T18:07:24 <jonasschnelli> The rpc test failures are reported here: https://travis-ci.org/bitcoin/bitcoin/jobs/245174021
2572017-06-21T18:07:41 <achow101> jonasschnelli: there's also a build failure too
2582017-06-21T18:07:47 <jonasschnelli> unknown location(0): fatal error: in "coin_selection_tests/bnb_search_test": signal: SIGABRT (application abort requested)
2592017-06-21T18:08:06 <jonasschnelli> test_bitcoin: key.cpp:292: void ECC_Start(): Assertion `secp256k1_context_sign == __null' failed.
2602017-06-21T18:08:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2612017-06-21T18:08:27 <jonasschnelli> haven't spotted the build error so far
2622017-06-21T18:08:35 <achow101> it's in one of the other travis builds
2632017-06-21T18:09:04 <achow101> https://travis-ci.org/bitcoin/bitcoin/jobs/245174020
2642017-06-21T18:09:08 <gmaxwell> some of the builds run with instrumented STL that detect things like out of range accesses to vectors. (often accessing [0] in an empty vector.)
2652017-06-21T18:09:22 <jonasschnelli> achow101: I guess compiling on a Trusty 14.04 VM and valgrund/lldb|gdb could help
2662017-06-21T18:09:34 <jonasschnelli> *valgrind
2672017-06-21T18:09:59 <gmaxwell> you can skip the vm stuff and just run valgrind on your test, it'll likely turn it up.
2682017-06-21T18:10:07 <achow101> I'll try
2692017-06-21T18:11:25 *** LeMiner has joined #bitcoin-core-dev
2702017-06-21T18:27:49 *** chjj has quit IRC
2712017-06-21T18:28:08 *** neel has quit IRC
2722017-06-21T18:30:42 *** jannes has quit IRC
2732017-06-21T18:37:37 *** goatpig has quit IRC
2742017-06-21T18:38:32 <achow101> valgrind reported no problems
2752017-06-21T18:39:00 <jonasschnelli> achow101: OSX?
2762017-06-21T18:39:13 <achow101> no, on ubuntu 17.04
2772017-06-21T18:39:26 <achow101> I don't have a windows or osx machine readily available
2782017-06-21T18:39:56 <jonasschnelli> I had this before and IIRC I could also not reproduce some of the test failures... maybe VM Trusty 14.04
2792017-06-21T18:41:04 <jonasschnelli> achow101: maybe double check the travis build env (see what gmaxwell mentioned above "some of the builds run with instrumented STL")?
2802017-06-21T18:41:21 *** chjj has joined #bitcoin-core-dev
2812017-06-21T18:47:50 <gmaxwell> achow101: https://stackoverflow.com/questions/5594686/gcc-stl-bound-checking
2822017-06-21T18:48:40 *** neel has joined #bitcoin-core-dev
2832017-06-21T18:50:39 <jonasschnelli> sipa: the txdb update skipper prework is here: https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2017/06/chainstate_update_prog?expand=1
2842017-06-21T18:50:58 <jonasschnelli> The progress is fake..
2852017-06-21T18:51:19 <jonasschnelli> And it's a bit hackish... I hope someone has a better design for the callback
2862017-06-21T18:52:07 <jonasschnelli> I detected db corruption when building a UTXO db on regtest with 0.14.2 (generate 100) and then exit on ShutdownRequested() in CCoinsViewDB::Upgrade()
2872017-06-21T18:52:25 <jonasschnelli> * exit on master + the work above
2882017-06-21T18:52:48 <cfields> achow101: note that the last time this came up, it was an issue of: memcpy(foo, bar[0], 0), where bar was empty. Valgrind won't report it because the out-of-bounds memory isn't actually copied, but it's still a bad an idea to [0] an empty container.
2892017-06-21T18:53:50 <achow101> I'm pretty sure I don't have anything like that in my changes
2902017-06-21T18:54:53 <sipa> jonasschnelli: i recently fixed a bug that could cause that
2912017-06-21T18:55:10 <jonasschnelli> sipa: already merged? Then I guess I should retest
2922017-06-21T18:55:17 <sipa> jonasschnelli: a few days ago
2932017-06-21T18:55:33 *** SopaXorzTaker has quit IRC
2942017-06-21T18:56:22 <jonasschnelli> Not sure if the approach of a "c" keypress in splashscreen to abort the UTXO-set upgrade makes sense..
2952017-06-21T18:56:29 <jonasschnelli> Though adding buttons on splashscreen is â with the current design â cumbersome
2962017-06-21T18:58:30 *** Chris_Stewart_5 has quit IRC
2972017-06-21T18:58:43 *** chjj has quit IRC
2982017-06-21T19:10:36 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10644: Slightly overhaul NSI pixmaps (master...2017/06/cleanup) https://github.com/bitcoin/bitcoin/pull/10644
2992017-06-21T19:11:19 *** jamesob has joined #bitcoin-core-dev
3002017-06-21T19:11:52 *** chjj has joined #bitcoin-core-dev
3012017-06-21T19:12:05 *** Dyaheon has quit IRC
3022017-06-21T19:13:00 <bitcoin-git> [bitcoin] practicalswift opened pull request #10645: Use nullptr instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645
3032017-06-21T19:16:00 *** jamesob has quit IRC
3042017-06-21T19:17:45 *** Dyaheon has joined #bitcoin-core-dev
3052017-06-21T19:23:30 <achow101> it seems that the problem may be due to my use of long instead of CAmount in one of the tests I wrote
3062017-06-21T19:24:30 *** ananteris has quit IRC
3072017-06-21T19:24:39 <sipa> jonasschnelli: what is the sleep for?
3082017-06-21T19:24:48 <jonasschnelli> sipa: dummy progress
3092017-06-21T19:24:52 <jonasschnelli> only to test
3102017-06-21T19:25:13 *** ananteris has joined #bitcoin-core-dev
3112017-06-21T19:25:19 <sipa> oh
3122017-06-21T19:25:30 <jonasschnelli> jonasschnelli: you should add the right code and replace "progress += 0.00001;"
3132017-06-21T19:25:45 <jonasschnelli> Now I start to ping myself
3142017-06-21T19:25:56 <jonasschnelli> sipa: ... and remove the sleep
3152017-06-21T19:26:56 <sipa> you should not remove sleep from yourself
3162017-06-21T19:27:08 <sipa> or you'll end up doing things like pining yourself
3172017-06-21T19:27:32 <jonasschnelli> hahaa
3182017-06-21T19:28:22 * jonasschnelli feels like "progress += 0.00001;" in reallife
3192017-06-21T19:31:50 <sipa> jonasschnelli: uh... nvm
3202017-06-21T19:32:05 <sipa> the bug i was talking about is in the non-atomic upgrade PR
3212017-06-21T19:32:05 *** chjj has quit IRC
3222017-06-21T19:32:06 <sipa> not in master
3232017-06-21T19:32:40 <jonasschnelli> okay. Because I just tested with master and still have the corruption..
3242017-06-21T19:33:02 <sipa> :(
3252017-06-21T19:33:02 <jonasschnelli> reminds me that we should have a strategy of how to test upgrades (chainstate-db, old wallet files) in functional tests
3262017-06-21T19:33:24 <sipa> that's very hard, unless you store an old version's chainstate inside the test..
3272017-06-21T19:33:31 <sipa> just logistically
3282017-06-21T19:33:46 <jonasschnelli> I think that would be the simplest solution.
3292017-06-21T19:33:57 <jonasschnelli> Compiling an old version will not be possible (at lest not in travis CI)
3302017-06-21T19:34:32 <sdaftuar> yeah its hard to get to work in travis, but not so hard conceptually to write the test in our test framework. passing in a custom binary to a functional test works fine.
3312017-06-21T19:34:35 <jonasschnelli> I think having some test old blobs fixtures may be okay
3322017-06-21T19:35:10 <sdaftuar> i believe i wrote a test like this in p2p-segwit (before we supported modifying bip9 parameters on the command line)
3332017-06-21T19:35:18 <jonasschnelli> It's one of the most lacking things in our test framework (migrations)
3342017-06-21T19:35:42 <sipa> those blobs could even be dependencies (as in, for the depends framework)
3352017-06-21T19:35:51 <sipa> with known hashes, but downloaded at build time
3362017-06-21T19:36:05 <jonasschnelli> yes.. sure.
3372017-06-21T19:36:22 <jonasschnelli> Especially if they are large...
3382017-06-21T19:36:53 <jonasschnelli> for wallet files, I don't mind having a couple of 20kb bdb 4.8 files in our test framework
3392017-06-21T19:38:20 *** ananteris has quit IRC
3402017-06-21T19:38:20 *** ananteris has joined #bitcoin-core-dev
3412017-06-21T19:45:44 *** chjj has joined #bitcoin-core-dev
3422017-06-21T20:04:35 *** Dizzle has quit IRC
3432017-06-21T20:05:55 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3442017-06-21T20:31:09 *** vicenteH has joined #bitcoin-core-dev
3452017-06-21T20:38:00 *** chjj has quit IRC
3462017-06-21T20:42:54 *** heyjude has joined #bitcoin-core-dev
3472017-06-21T20:44:51 *** heyjude has quit IRC
3482017-06-21T20:46:00 *** imposter has quit IRC
3492017-06-21T20:48:04 *** Dizzle has joined #bitcoin-core-dev
3502017-06-21T20:50:24 *** chjj has joined #bitcoin-core-dev
3512017-06-21T20:53:16 *** cheese_ has joined #bitcoin-core-dev
3522017-06-21T20:55:53 *** Cheeseo has quit IRC
3532017-06-21T21:05:05 *** lifeofguenter has quit IRC
3542017-06-21T21:05:13 *** neel has quit IRC
3552017-06-21T21:05:17 *** lifeofguenter has joined #bitcoin-core-dev
3562017-06-21T21:12:41 *** jamesob has joined #bitcoin-core-dev
3572017-06-21T21:17:28 *** jamesob has quit IRC
3582017-06-21T21:19:57 *** Chris_Stewart_5 has quit IRC
3592017-06-21T21:20:36 *** laurentmt has quit IRC
3602017-06-21T21:35:30 *** chjj has quit IRC
3612017-06-21T21:39:13 *** neel has joined #bitcoin-core-dev
3622017-06-21T21:48:37 *** chjj has joined #bitcoin-core-dev
3632017-06-21T21:55:07 *** dunatotatos has quit IRC
3642017-06-21T21:55:33 *** dunatotatos has joined #bitcoin-core-dev
3652017-06-21T21:58:31 *** dunatotatos has quit IRC
3662017-06-21T21:58:59 *** dunatotatos has joined #bitcoin-core-dev
3672017-06-21T22:01:56 *** dunatotatos has quit IRC
3682017-06-21T22:02:22 *** dunatotatos has joined #bitcoin-core-dev
3692017-06-21T22:05:18 *** dunatotatos has quit IRC
3702017-06-21T22:05:42 *** dunatotatos has joined #bitcoin-core-dev
3712017-06-21T22:08:39 *** dunatotatos has quit IRC
3722017-06-21T22:09:05 *** dunatotatos has joined #bitcoin-core-dev
3732017-06-21T22:11:29 *** neel has quit IRC
3742017-06-21T22:12:02 *** dunatotatos has quit IRC
3752017-06-21T22:12:28 *** dunatotatos has joined #bitcoin-core-dev
3762017-06-21T22:14:05 *** jamesob has joined #bitcoin-core-dev
3772017-06-21T22:15:24 *** dunatotatos has quit IRC
3782017-06-21T22:15:47 *** dunatotatos has joined #bitcoin-core-dev
3792017-06-21T22:18:33 *** jamesob has quit IRC
3802017-06-21T22:18:43 *** dunatotatos has quit IRC
3812017-06-21T22:19:09 *** dunatotatos has joined #bitcoin-core-dev
3822017-06-21T22:19:24 *** Dizzle has quit IRC
3832017-06-21T22:22:05 *** dunatotatos has quit IRC
3842017-06-21T22:42:53 *** nemgun has quit IRC
3852017-06-21T22:43:50 *** nemgun has joined #bitcoin-core-dev
3862017-06-21T22:44:21 *** Cheeseo has joined #bitcoin-core-dev
3872017-06-21T22:47:27 *** chjj has quit IRC
3882017-06-21T23:00:48 *** chjj has joined #bitcoin-core-dev
3892017-06-21T23:05:23 *** Cheeseo has quit IRC
3902017-06-21T23:28:46 *** Cheeseo has joined #bitcoin-core-dev
3912017-06-21T23:35:50 *** Cheeseo has quit IRC
3922017-06-21T23:52:10 *** chjj has quit IRC
3932017-06-21T23:58:23 *** abpa has quit IRC