12017-07-16T00:00:09 *** PRab has joined #bitcoin-core-dev
22017-07-16T00:00:33 *** davec has quit IRC
32017-07-16T00:06:37 *** davec has joined #bitcoin-core-dev
42017-07-16T00:11:12 <sipa> BlueMatt: i'm not
52017-07-16T00:12:30 *** davec has quit IRC
62017-07-16T00:13:07 <bitcoin-git> [bitcoin] practicalswift opened pull request #10839: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.). (master...dont-pass-by-reference-for-cheaply-copied-types) https://github.com/bitcoin/bitcoin/pull/10839
72017-07-16T00:13:27 *** nemgun1 has quit IRC
82017-07-16T00:21:21 <fanquake> sipa same issue as before. Assertion failed: (consensus.hashGenesisBlock etc
92017-07-16T00:22:44 <sipa> fanquake: ok, thank you
102017-07-16T00:26:49 *** luke-jr has quit IRC
112017-07-16T00:27:21 <bitcoin-git> [bitcoin] practicalswift opened pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
122017-07-16T00:37:40 *** luke-jr has joined #bitcoin-core-dev
132017-07-16T00:46:22 *** goatpig has quit IRC
142017-07-16T00:49:58 *** roidster has joined #bitcoin-core-dev
152017-07-16T01:07:04 *** AsadSalman has joined #bitcoin-core-dev
162017-07-16T01:08:09 <AsadSalman> Hi
172017-07-16T01:08:32 <AsadSalman> I'm working in the bitcoin core, trying to get the amount of a transaction sent into the mempool
182017-07-16T01:08:59 <AsadSalman> I'm logging all entries (working on regtestnet, btw)
192017-07-16T01:09:40 <AsadSalman> http://imgur.com/a/olCNk
202017-07-16T01:10:08 <AsadSalman> I am able to get a value out (as you can see in the screenshot)
212017-07-16T01:10:21 <AsadSalman> but that is a sum of both CTxOut
222017-07-16T01:10:58 <AsadSalman> I only want the amount I spent (which was 10BTC, i.e. 1,000,000,000 satoshi)
232017-07-16T01:11:25 <AsadSalman> I don't know what the other CTxOut that is getting summed in is, and how do I get rid of it in the final sum?
242017-07-16T01:11:32 <sipa> it's change
252017-07-16T01:11:55 <AsadSalman> change? I'm not sure what you mean, could you elaborate?
262017-07-16T01:12:04 <sipa> not here, try bitcoin.stackexchange.com
272017-07-16T01:12:11 <sipa> or #bitcoin
282017-07-16T01:12:44 <AsadSalman> okay! (sorry, I thought this would be an appropriate place to ask about core)
292017-07-16T01:13:09 <sipa> your question is about how bitcoin transactions work
302017-07-16T01:27:42 *** Murch has joined #bitcoin-core-dev
312017-07-16T01:30:55 *** Murchone has joined #bitcoin-core-dev
322017-07-16T01:31:10 *** Murch has quit IRC
332017-07-16T01:35:46 *** Murchone has quit IRC
342017-07-16T01:37:37 *** chjj has joined #bitcoin-core-dev
352017-07-16T01:38:00 *** jamesob_ has joined #bitcoin-core-dev
362017-07-16T01:39:13 *** jamesob has quit IRC
372017-07-16T01:50:54 *** Ylbam has quit IRC
382017-07-16T01:59:07 *** davec has joined #bitcoin-core-dev
392017-07-16T02:04:31 *** sanada has joined #bitcoin-core-dev
402017-07-16T02:07:17 *** AsadSalman has quit IRC
412017-07-16T02:08:50 *** Murch has joined #bitcoin-core-dev
422017-07-16T02:09:56 *** Murch has quit IRC
432017-07-16T02:16:57 *** chjj has quit IRC
442017-07-16T02:21:52 *** Chris_Stewart_5 has quit IRC
452017-07-16T02:36:39 *** jamesob_ has quit IRC
462017-07-16T02:37:14 *** jamesob has joined #bitcoin-core-dev
472017-07-16T02:41:54 *** Murch has joined #bitcoin-core-dev
482017-07-16T02:42:48 *** str4d has joined #bitcoin-core-dev
492017-07-16T02:43:04 *** Murch has quit IRC
502017-07-16T02:47:22 <gmaxwell> BlueMatt: on 10831 please review the rebase carefully, I'm sick and wouldn't even have done the rebase today but for merge window urgency.
512017-07-16T02:59:23 *** Murch has joined #bitcoin-core-dev
522017-07-16T03:04:47 *** Murch has quit IRC
532017-07-16T03:16:32 *** Murch has joined #bitcoin-core-dev
542017-07-16T03:19:35 *** Murch has quit IRC
552017-07-16T03:31:26 *** justan0theruser has joined #bitcoin-core-dev
562017-07-16T03:34:34 *** justanotheruser has quit IRC
572017-07-16T03:46:55 *** justan0theruser has quit IRC
582017-07-16T03:47:16 *** justanotheruser has joined #bitcoin-core-dev
592017-07-16T03:49:37 *** blzin2 has joined #bitcoin-core-dev
602017-07-16T03:51:08 *** handlex has joined #bitcoin-core-dev
612017-07-16T03:56:03 *** blzin2 has quit IRC
622017-07-16T03:58:28 <cfields> sipa: still crashes :(
632017-07-16T03:58:44 *** wallet42 has quit IRC
642017-07-16T03:58:46 *** robby938 has quit IRC
652017-07-16T03:59:49 <cfields> sipa: i managed to get lldb to step into the asm, but it doesn't show me where I am when i single-step instructions, only that I'm in the asm block. So i have to step 1 instruction at a time and dump registers
662017-07-16T04:00:49 <cfields> the explicit assignments will help though, since now I'll know where I'm looking
672017-07-16T04:01:38 *** rubensayshi has quit IRC
682017-07-16T04:03:03 *** Dyaheon has quit IRC
692017-07-16T04:03:08 <sipa> cfields: so you do reach the asm block?
702017-07-16T04:03:20 <sipa> can you count how many instructions inside you execute?
712017-07-16T04:03:27 <cfields> sipa: yea, and past the zero-size check
722017-07-16T04:04:54 <cfields> sipa: yea, i can do that. the recent changes should make it much easier, i'll poke some more
732017-07-16T04:05:24 *** Dyaheon has joined #bitcoin-core-dev
742017-07-16T04:10:42 <sipa> cfields: thanks for all the time you're spending on thid
752017-07-16T04:11:18 <cfields> sipa: np. it's a big boost.
762017-07-16T04:12:27 <sipa> cfields: for IBD it seems a 200-300 second reduction to block 450k
772017-07-16T04:12:58 <sipa> at the tip the impact is probably larger, but harder to benchmark
782017-07-16T04:14:03 <cfields> wow
792017-07-16T04:14:29 *** chjj has joined #bitcoin-core-dev
802017-07-16T04:14:50 *** blznblzn2 has joined #bitcoin-core-dev
812017-07-16T04:15:22 <cfields> net-side will benefit at the tip too, though probably not enough to be relevant
822017-07-16T04:15:49 <cfields> sipa: gcc docs says the value of inputs isn't allowed to change. i suppose values of pointers passed in are ok though?
832017-07-16T04:16:09 <sipa> cfields: the only inputs are constants
842017-07-16T04:16:24 <sipa> everything else is marked as an output
852017-07-16T04:16:33 *** str4d has quit IRC
862017-07-16T04:17:28 <cfields> oh right, nm
872017-07-16T04:18:01 <gmaxwell> sha-ni is a bigger boost.
882017-07-16T04:18:14 <sipa> yes, far larger
892017-07-16T04:18:20 <sipa> close to 1000s reduction
902017-07-16T04:18:32 <sipa> more like 800s
912017-07-16T04:18:43 <sipa> (compared to master)
922017-07-16T04:19:59 *** rubensayshi has joined #bitcoin-core-dev
932017-07-16T04:20:16 <gmaxwell> cfields: I expect even just sse4 to make a very measurable improvement in compact block relay... that is mostly bottlenecked on sha2...
942017-07-16T04:20:33 *** davec has quit IRC
952017-07-16T04:21:15 <cfields> whoa
962017-07-16T04:22:47 <cfields> have you benchmarked any benefit to adding a dedicated sha2d?
972017-07-16T04:25:10 <sipa> cfields: can you show another disasm?
982017-07-16T04:25:52 <gmaxwell> haven't though if we want further benefit I think what we really want is a hash tree that hashes multiple things at once, parallel sse4 sha2 is significantly faster than one at a time... and it even looks like for sha-ni for max throughput you want to do at least two at a time.
992017-07-16T04:27:12 <cfields> gmaxwell: yea, i was reading that paper (one of many?) yesterday
1002017-07-16T04:27:16 <cfields> sipa: https://pastebin.com/raw/jY0EGwDB
1012017-07-16T04:27:46 <cfields> stepping through it now
1022017-07-16T04:28:23 <cfields> sipa: note that i haven't hand-modified any flags for that one, so the stack protector is in place where it hasn't been in other dumps
1032017-07-16T04:29:59 <sipa> i can see
1042017-07-16T04:30:03 <sipa> that
1052017-07-16T04:32:51 *** chjj has quit IRC
1062017-07-16T04:34:36 <sipa> cfields: during the entire execution, the rdi register should contain a pointer to the SHA256 state
1072017-07-16T04:34:40 <sipa> and it should never change
1082017-07-16T04:35:42 <sipa> there is not a single instruction in your disasm that modifies that register, so far so good
1092017-07-16T04:36:07 <sipa> so the question is... is rdi actually pointing to the state?
1102017-07-16T04:36:21 <gmaxwell> sipa: you could try taking cfields disasm and monkey patching it into a binary to try to reproduce he failure.
1112017-07-16T04:36:47 <sipa> gmaxwell: nontrivial... linking information would be lost
1122017-07-16T04:36:50 <cfields> sipa: actually, hold on. linker stuck a bunch of nops in the final binary...
1132017-07-16T04:37:07 <cfields> let met give you a dump of that rather than a dump of just the object
1142017-07-16T04:37:13 <sipa> cfields: ah, yes!
1152017-07-16T04:37:36 <gmaxwell> linker replaced the object with foldgers crystals, turns out we noticed.
1162017-07-16T04:38:35 *** davec has joined #bitcoin-core-dev
1172017-07-16T04:38:59 <cfields> uhmm, wtf
1182017-07-16T04:39:31 <sipa> the linker replaced the object with foldgers crystals?
1192017-07-16T04:39:44 <cfields> ok, i don't trust myself enough here to be a proxy debugger...
1202017-07-16T04:39:48 <cfields> sec
1212017-07-16T04:41:13 <cfields> I'm just going to send you the whole dasm. Got anywhere convenient for a 58mb text dump?
1222017-07-16T04:42:30 <sipa> sure
1232017-07-16T04:42:36 <sipa> mail?
1242017-07-16T04:46:30 *** handlex has quit IRC
1252017-07-16T04:47:44 <midnightmagic> lol
1262017-07-16T04:49:35 *** corebob has joined #bitcoin-core-dev
1272017-07-16T04:55:26 *** blznblzn2 has quit IRC
1282017-07-16T04:56:05 *** blznblzn2 has joined #bitcoin-core-dev
1292017-07-16T05:06:06 <sipa> gmaxwell: your foldgers crystals guess is surprisingly accurate
1302017-07-16T05:09:19 <cfields> bingo!
1312017-07-16T05:09:22 <cfields> got it.
1322017-07-16T05:10:11 <sipa> oh?
1332017-07-16T05:11:10 <cfields> now to figure out why :)
1342017-07-16T05:11:11 <cfields> -Wl,-dead_strip
1352017-07-16T05:11:49 <cfields> it's weird that if it's going to strip it, it doesn't strip the whole thing though
1362017-07-16T05:12:44 <cfields> (to be clear, we use -Wl,-dead_strip by default. With that removed, it runs as expected)
1372017-07-16T05:15:08 <sipa> cfields: give local labels a name that starts with L
1382017-07-16T05:15:23 <sipa> that way the linker treats them as local labels rather than separate functions
1392017-07-16T05:18:46 <cfields> sipa: works!
1402017-07-16T05:19:30 <sipa> http://www.galloway.me.uk/2011/03/assembly-beware-local-label-names-with-dead_strip-option/
1412017-07-16T05:19:36 <sipa> i found thst
1422017-07-16T05:20:04 <cfields> hah! well that was some easy googling for once :)
1432017-07-16T05:24:03 <cfields> sipa: do you see that documented anywhere?
1442017-07-16T05:24:24 <sipa> nope
1452017-07-16T05:27:09 *** roidster has quit IRC
1462017-07-16T05:28:34 <bitcoin-git> [bitcoin] jnewbery opened pull request #10841: [rpc] Give users one final warning before depracating getinfo (master...deprecate_getinfo) https://github.com/bitcoin/bitcoin/pull/10841
1472017-07-16T05:30:35 <cfields> sipa: https://sourceware.org/binutils/docs/as/Symbol-Names.html#Symbol-Names
1482017-07-16T05:33:44 <sipa> ah
1492017-07-16T05:36:04 <cfields> sipa: maybe safer to use digits instead, then? Reading the docs like a pedant, I assume some future linker could break win32 the same way.
1502017-07-16T05:40:11 *** discreteunit has joined #bitcoin-core-dev
1512017-07-16T05:44:35 <cfields> nope, that's crashy too
1522017-07-16T06:22:37 <sipa> cfields: so, latest PR version works?
1532017-07-16T06:24:15 <cfields> sipa: i don't think so, i think that matches what i tried
1542017-07-16T06:24:33 <sipa> ?
1552017-07-16T06:24:44 <cfields> sipa: i misread the docs, look at their example
1562017-07-16T06:25:01 <cfields> "So for example, the first 1: may be named .L1C-B1, and the 44th 3: may be named .L3C-B44."
1572017-07-16T06:25:25 <sipa> A local symbol is any symbol beginning with certain local label prefixes. By default, the local label prefix is `.L' for ELF systems or `L' for traditional a.out systems, but each target may have its own set of local label prefixes.
1582017-07-16T06:25:32 <cfields> apparently the numbers aren't a replacement for the L prefix
1592017-07-16T06:25:53 <sipa> you're looking at automatically generated names
1602017-07-16T06:26:03 *** Squidicc has quit IRC
1612017-07-16T06:26:10 <sipa> we don't need that; the asm syntax's %= guaranrees uniqueness already
1622017-07-16T06:28:04 *** SopaXorzTaker has joined #bitcoin-core-dev
1632017-07-16T06:28:37 <cfields> sipa: sorry, misread the diff
1642017-07-16T06:29:33 <sipa> it won't work, i forgot to rename the jumps
1652017-07-16T06:29:45 <cfields> yep, with those renamed, all good
1662017-07-16T06:29:48 *** chjj has joined #bitcoin-core-dev
1672017-07-16T06:39:18 <phantomcircuit> gmaxwell, btw when i did the walletdb stuff i was doing CWalletDB *pwalletdb=NULL and then initializing pwalletdb only if it was null instead of creating a new function
1682017-07-16T07:05:36 *** discreteunit has quit IRC
1692017-07-16T07:11:46 *** Ylbam has joined #bitcoin-core-dev
1702017-07-16T07:13:52 *** Squidicuz has joined #bitcoin-core-dev
1712017-07-16T07:14:06 *** Squidicuz has joined #bitcoin-core-dev
1722017-07-16T08:27:29 *** afk11 has quit IRC
1732017-07-16T08:45:25 *** RUrsu has joined #bitcoin-core-dev
1742017-07-16T08:45:57 *** RUrsu has left #bitcoin-core-dev
1752017-07-16T08:49:23 *** mryandao has joined #bitcoin-core-dev
1762017-07-16T08:52:58 *** blznblzn2 has quit IRC
1772017-07-16T09:09:24 *** SopaXorzTaker has quit IRC
1782017-07-16T09:19:40 *** mmgen has joined #bitcoin-core-dev
1792017-07-16T09:25:22 *** jtimon has joined #bitcoin-core-dev
1802017-07-16T09:49:21 *** chjj has quit IRC
1812017-07-16T09:50:01 *** d9b4bef9 has quit IRC
1822017-07-16T09:51:16 *** d9b4bef9 has joined #bitcoin-core-dev
1832017-07-16T10:06:51 *** corebob has quit IRC
1842017-07-16T10:22:42 <bitcoin-git> [bitcoin] practicalswift opened pull request #10842: Fix incorrect Doxygen tag (@ince â @since) (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
1852017-07-16T10:43:49 *** goatpig has joined #bitcoin-core-dev
1862017-07-16T10:58:39 *** jtimon has quit IRC
1872017-07-16T11:20:51 *** arowser has quit IRC
1882017-07-16T11:27:00 *** arowser has joined #bitcoin-core-dev
1892017-07-16T11:51:29 *** belcher has quit IRC
1902017-07-16T11:55:47 *** belcher has joined #bitcoin-core-dev
1912017-07-16T12:00:19 *** marcoagner has quit IRC
1922017-07-16T12:00:46 *** marcoagner has joined #bitcoin-core-dev
1932017-07-16T12:36:55 *** AaronvanW has joined #bitcoin-core-dev
1942017-07-16T13:03:12 *** vicenteH has quit IRC
1952017-07-16T13:04:52 *** CubicEarth has joined #bitcoin-core-dev
1962017-07-16T13:07:43 <bitcoin-git> [bitcoin] practicalswift opened pull request #10843: Add attribute [[noreturn]] (C++11) to functions that will not return (master...noreturn) https://github.com/bitcoin/bitcoin/pull/10843
1972017-07-16T13:09:50 *** SopaXorzTaker has joined #bitcoin-core-dev
1982017-07-16T13:10:47 *** marcoagner has quit IRC
1992017-07-16T13:20:48 *** hsmiths has quit IRC
2002017-07-16T13:23:04 *** marcoagner has joined #bitcoin-core-dev
2012017-07-16T13:28:53 *** belcher has quit IRC
2022017-07-16T13:30:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2032017-07-16T13:31:52 *** laurentmt has joined #bitcoin-core-dev
2042017-07-16T13:32:01 *** laurentmt has quit IRC
2052017-07-16T13:39:15 *** belcher has joined #bitcoin-core-dev
2062017-07-16T13:40:17 *** CubicEarth has quit IRC
2072017-07-16T13:40:46 *** CubicEarth has joined #bitcoin-core-dev
2082017-07-16T13:42:43 *** Guyver2 has joined #bitcoin-core-dev
2092017-07-16T13:45:13 *** CubicEarth has quit IRC
2102017-07-16T13:48:34 *** terjegun has joined #bitcoin-core-dev
2112017-07-16T13:48:52 <terjegun> Hello! I was wondering, is there any reward for contributing translations to the project?
2122017-07-16T13:50:13 <Lauda> No.
2132017-07-16T13:50:38 <instagibbs> terjegun, satisfaction in knowing you helped others?
2142017-07-16T13:53:00 *** terjegun has quit IRC
2152017-07-16T13:55:10 <bitcoin-git> [bitcoin] ReneNyffenegger opened pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
2162017-07-16T13:58:08 *** CubicEarth has joined #bitcoin-core-dev
2172017-07-16T14:02:35 *** CubicEarth has joined #bitcoin-core-dev
2182017-07-16T14:08:18 *** vicenteH has joined #bitcoin-core-dev
2192017-07-16T14:08:42 *** hsmiths has joined #bitcoin-core-dev
2202017-07-16T14:19:44 *** Dyaheon has quit IRC
2212017-07-16T14:21:44 *** Dyaheon has joined #bitcoin-core-dev
2222017-07-16T14:23:56 *** CubicEarth has quit IRC
2232017-07-16T15:17:58 *** harrymm has quit IRC
2242017-07-16T15:34:06 *** fanquake has left #bitcoin-core-dev
2252017-07-16T15:37:50 *** harrymm has joined #bitcoin-core-dev
2262017-07-16T15:38:00 *** [b__b] has quit IRC
2272017-07-16T16:18:07 *** Chris_Stewart_5 has quit IRC
2282017-07-16T16:24:38 *** BashCo has quit IRC
2292017-07-16T16:25:23 *** BashCo has joined #bitcoin-core-dev
2302017-07-16T16:32:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2312017-07-16T16:47:34 *** sdaftuar has quit IRC
2322017-07-16T16:47:34 *** zxzzt has quit IRC
2332017-07-16T16:47:47 *** morcos has quit IRC
2342017-07-16T16:49:00 *** zxzzt has joined #bitcoin-core-dev
2352017-07-16T16:49:07 *** sdaftuar has joined #bitcoin-core-dev
2362017-07-16T16:49:23 *** morcos has joined #bitcoin-core-dev
2372017-07-16T16:49:56 <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
2382017-07-16T17:10:31 *** mmgen has quit IRC
2392017-07-16T17:16:11 *** deep-book-gk_ has joined #bitcoin-core-dev
2402017-07-16T17:18:29 *** deep-book-gk_ has left #bitcoin-core-dev
2412017-07-16T17:20:55 *** Aaronvan_ has joined #bitcoin-core-dev
2422017-07-16T17:21:31 *** AaronvanW has quit IRC
2432017-07-16T17:27:00 *** Cheeseo has joined #bitcoin-core-dev
2442017-07-16T17:30:24 *** RoyceX has joined #bitcoin-core-dev
2452017-07-16T17:33:30 *** Cheeseo has quit IRC
2462017-07-16T17:37:11 *** [b__b] has joined #bitcoin-core-dev
2472017-07-16T17:37:28 *** chjj has joined #bitcoin-core-dev
2482017-07-16T17:38:05 *** mmgen has joined #bitcoin-core-dev
2492017-07-16T17:39:36 *** AdrianG is now known as Aleph0
2502017-07-16T17:40:33 *** harrymm has quit IRC
2512017-07-16T17:44:20 <bitcoin-git> [bitcoin] practicalswift opened pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845
2522017-07-16T17:50:13 *** mmgen has quit IRC
2532017-07-16T17:54:25 *** Chris_Stewart_5 has quit IRC
2542017-07-16T17:59:27 *** harrymm has joined #bitcoin-core-dev
2552017-07-16T18:03:33 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
2562017-07-16T18:04:49 *** BashCo has quit IRC
2572017-07-16T18:05:27 *** BashCo has joined #bitcoin-core-dev
2582017-07-16T18:21:36 *** Murch has joined #bitcoin-core-dev
2592017-07-16T18:24:57 <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10846: Add stdlib include in qt/test/test_main (for setenv) (master...2017-07-env-include) https://github.com/bitcoin/bitcoin/pull/10846
2602017-07-16T18:32:23 *** laurentmt has joined #bitcoin-core-dev
2612017-07-16T18:36:53 *** Murch has quit IRC
2622017-07-16T18:48:09 *** bincap has joined #bitcoin-core-dev
2632017-07-16T18:51:14 <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5cfdda2503c9...ef37f2033c4a
2642017-07-16T18:51:15 <bitcoin-git> bitcoin/master a9e82f6 Pieter Wuille: Use cpuid intrinsics instead of asm code
2652017-07-16T18:51:15 <bitcoin-git> bitcoin/master 674848f Pieter Wuille: Clarify entropy source
2662017-07-16T18:51:16 <bitcoin-git> bitcoin/master ef37f20 Pieter Wuille: Merge #10820: Use cpuid intrinsics instead of asm code...
2672017-07-16T18:51:44 <bitcoin-git> [bitcoin] sipa closed pull request #10820: Use cpuid intrinsics instead of asm code (master...20170717_cpuid) https://github.com/bitcoin/bitcoin/pull/10820
2682017-07-16T18:52:53 *** laurentmt has quit IRC
2692017-07-16T18:56:32 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef37f2033c4a...b4d03be3cac0
2702017-07-16T18:56:32 <bitcoin-git> bitcoin/master 912da1d René Nyffenegger: Use AC_ARG_VAR to set ARFLAGS....
2712017-07-16T18:56:33 <bitcoin-git> bitcoin/master b4d03be Pieter Wuille: Merge #10766: Building Environment: Set ARFLAGS to cr...
2722017-07-16T18:57:03 <bitcoin-git> [bitcoin] sipa closed pull request #10766: Building Environment: Set ARFLAGS to cr (master...ARFLAGS) https://github.com/bitcoin/bitcoin/pull/10766
2732017-07-16T19:00:42 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4d03be3cac0...99c7db8731cc
2742017-07-16T19:00:43 <bitcoin-git> bitcoin/master c53369c practicalswift: Remove duplicate include
2752017-07-16T19:00:43 <bitcoin-git> bitcoin/master 99c7db8 Pieter Wuille: Merge #10840: Remove duplicate include...
2762017-07-16T19:01:12 <bitcoin-git> [bitcoin] sipa closed pull request #10840: Remove duplicate include (master...remove-duplicate-include) https://github.com/bitcoin/bitcoin/pull/10840
2772017-07-16T19:03:53 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/99c7db8731cc...ad6fce67b9bb
2782017-07-16T19:03:53 <bitcoin-git> bitcoin/master d0413c6 René Nyffenegger: Use range based for loop...
2792017-07-16T19:03:54 <bitcoin-git> bitcoin/master ad6fce6 Pieter Wuille: Merge #10844: Use range based for loop...
2802017-07-16T19:04:23 <bitcoin-git> [bitcoin] sipa closed pull request #10844: Use range based for loop (master...dbwrapper_tests-for) https://github.com/bitcoin/bitcoin/pull/10844
2812017-07-16T19:06:23 *** mmgen has joined #bitcoin-core-dev
2822017-07-16T19:11:45 *** JackH has joined #bitcoin-core-dev
2832017-07-16T19:13:48 *** arowser has quit IRC
2842017-07-16T19:15:45 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ad6fce67b9bb...565494619d80
2852017-07-16T19:15:45 <bitcoin-git> bitcoin/master 6835cb0 practicalswift: Avoid static analyzer warnings regarding uninitialized arguments...
2862017-07-16T19:15:46 <bitcoin-git> bitcoin/master 5654946 Pieter Wuille: Merge #10735: Avoid static analyzer warnings regarding uninitialized arguments...
2872017-07-16T19:16:10 <bitcoin-git> [bitcoin] sipa closed pull request #10735: Avoid static analyzer warnings regarding uninitialized arguments (master...std-array) https://github.com/bitcoin/bitcoin/pull/10735
2882017-07-16T19:19:56 *** arowser has joined #bitcoin-core-dev
2892017-07-16T19:28:48 *** davec has quit IRC
2902017-07-16T19:29:41 <sipa> do we know about this: https://bitcoin.stackexchange.com/questions/56750/autogen-sh-not-working-on-ubuntu-on-windows ?
2912017-07-16T19:30:58 <BlueMatt> that seems to indicate it doesnt support "seg -e"???
2922017-07-16T19:31:05 <BlueMatt> that sounds like an ubuntu-on-windows issue
2932017-07-16T19:31:51 <sipa> I vaguely remember that there were known issues when building on Ubuntu-in-Windows, but I don't remember whether it was this.
2942017-07-16T19:32:39 <BlueMatt> not this, no
2952017-07-16T19:32:45 <BlueMatt> well, afair
2962017-07-16T19:35:22 *** arowser has quit IRC
2972017-07-16T19:39:50 *** davec has joined #bitcoin-core-dev
2982017-07-16T19:41:38 *** arowser has joined #bitcoin-core-dev
2992017-07-16T19:47:00 *** sam_c has joined #bitcoin-core-dev
3002017-07-16T19:48:15 <cfields> IIRC the last round of problems was caused by an update that borked the default path
3012017-07-16T19:51:08 <sipa> cfields: what is the option to make gcc emit every function in its own section?
3022017-07-16T19:51:44 <cfields> sipa: ffunction-section
3032017-07-16T19:51:59 <cfields> er, there's another s in there somewhere though
3042017-07-16T19:52:24 <cfields> -ffunction-sections
3052017-07-16T19:52:25 <sipa> do we enable -Wl,--gc-sections by default?
3062017-07-16T19:52:31 <cfields> sipa: and you want to link with -gc-sections
3072017-07-16T19:52:33 <cfields> no
3082017-07-16T19:54:07 <sipa> any reason not to?
3092017-07-16T19:56:29 <cfields> sipa: i think default-hidden-visibility accomplishes the same thing without the section bloat?
3102017-07-16T19:59:39 <sipa> cfields: is that always set for us?
3112017-07-16T20:00:40 *** arowser has quit IRC
3122017-07-16T20:01:50 <sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0", results in a 6MB stripped bitcoind
3132017-07-16T20:02:14 <sipa> cfields: a build with CFLAGS/CXXFLAGS/LDFLAGS all set to "-O2 -g0 -ffunction-sections -fdata-sections -Wl,--gc-sections", results in a 5.4MB stripped bitcoind
3142017-07-16T20:03:37 <cfields> sipa: it's not set auto, --enable-reduced-exports
3152017-07-16T20:03:41 *** jamesob has quit IRC
3162017-07-16T20:03:44 <cfields> mind comparing with that?
3172017-07-16T20:03:54 <gmaxwell> why don't we do that by default
3182017-07-16T20:03:59 *** jamesob has joined #bitcoin-core-dev
3192017-07-16T20:04:10 <cfields> gmaxwell: there's a visibility issue with some boost versions
3202017-07-16T20:04:16 <gmaxwell> ah
3212017-07-16T20:04:28 *** jamesob has quit IRC
3222017-07-16T20:04:43 *** jamesob has joined #bitcoin-core-dev
3232017-07-16T20:05:30 <sipa> cfields: that option makes no difference; 6.0MB again
3242017-07-16T20:05:35 *** jamesob has joined #bitcoin-core-dev
3252017-07-16T20:05:43 <cfields> huh
3262017-07-16T20:06:05 *** jamesob has quit IRC
3272017-07-16T20:06:23 *** jamesob has joined #bitcoin-core-dev
3282017-07-16T20:06:35 <sipa> make clean && ./configure --with-incompatible-bdb --without-gui --enable-reduced-exports && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
3292017-07-16T20:06:39 <sipa> 6008256 src/bitcoind
3302017-07-16T20:06:52 *** jamesob has quit IRC
3312017-07-16T20:06:52 *** arowser has joined #bitcoin-core-dev
3322017-07-16T20:07:08 *** jamesob has joined #bitcoin-core-dev
3332017-07-16T20:07:31 <cfields> sipa: sounds promising then, though I'm kinda confused as to why
3342017-07-16T20:07:40 *** jamesob has quit IRC
3352017-07-16T20:07:58 <sipa> make clean && COMMON="-O2" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
3362017-07-16T20:07:58 *** jamesob has joined #bitcoin-core-dev
3372017-07-16T20:08:05 <sipa> 6008256 src/bitcoind
3382017-07-16T20:08:28 *** jamesob has quit IRC
3392017-07-16T20:08:33 <sipa> ^ exactly the same
3402017-07-16T20:08:44 *** jamesob has joined #bitcoin-core-dev
3412017-07-16T20:08:49 <sipa> make clean && COMMON="-O2 -ffunction-sections -fdata-sections -Wl,--gc-sections" && ./configure --with-incompatible-bdb --without-gui CFLAGS="$COMMON" CXXFLAGS="$COMMON" LDFLAGS="$COMMON" && make -j9 src/bitcoind && strip src/bitcoind && wc -c src/bitcoind
3422017-07-16T20:08:53 <sipa> 5397952 src/bitcoind
3432017-07-16T20:09:16 *** jamesob has quit IRC
3442017-07-16T20:09:49 *** jamesob has joined #bitcoin-core-dev
3452017-07-16T20:10:00 <cfields> sipa: i wonder if there are any downsides wrt locality?
3462017-07-16T20:10:31 <sipa> cfields: i can run a reindex benchmark
3472017-07-16T20:12:35 *** arowser has quit IRC
3482017-07-16T20:14:15 <sipa> cfields: should --enable-reduced-exports affect the CXXFLAGS/LDFLAGS that get printed in any way?
3492017-07-16T20:14:24 *** jamesob has quit IRC
3502017-07-16T20:14:49 <cfields> sipa: sigh, probably not
3512017-07-16T20:15:03 <cfields> that needs to be cleaned up. There's lots of stuff not reported
3522017-07-16T20:16:20 <gmaxwell> sipa: you mean when doing a V=1 build so you can see the arguments it actually uses
3532017-07-16T20:16:30 <cfields> sipa: aurgh!
3542017-07-16T20:17:24 <cfields> wait, hmm
3552017-07-16T20:18:19 <cfields> sipa: sorry, i lied to you :(
3562017-07-16T20:18:23 <cfields> --enable-reduce-exports
3572017-07-16T20:18:54 <sipa> shouldn't it complain if i make a typo?
3582017-07-16T20:19:01 *** arowser has joined #bitcoin-core-dev
3592017-07-16T20:19:15 <cfields> sipa: it used to, but we can't anymore because config options get forwarded to subconfigs
3602017-07-16T20:19:34 <sipa> heh, i always wondered how it dealt with that...
3612017-07-16T20:21:43 <sipa> -rwxr-xr-x 1 pw pw 6008256 Jul 16 13:15 src/bitcoind-shasse-O2
3622017-07-16T20:21:43 <sipa> -rwxr-xr-x 1 pw pw 5979584 Jul 16 13:21 src/bitcoind-shasse-O2reduce
3632017-07-16T20:21:44 <sipa> -rwxr-xr-x 1 pw pw 5397952 Jul 16 13:19 src/bitcoind-shasse-O2sections
3642017-07-16T20:22:06 <sipa> the middle one is with CXXFLAGS="-O2" --enable-reduce-exports
3652017-07-16T20:23:03 *** SopaXorzTaker has quit IRC
3662017-07-16T20:26:04 <sipa> benchmarking those 3
3672017-07-16T20:26:07 <cfields> sipa: may as well try with -fdata-sections too
3682017-07-16T20:27:17 <sipa> cfields: yeah, that's with both
3692017-07-16T20:27:28 <gmaxwell> sipa: why would you expect a performance difference?
3702017-07-16T20:27:41 <cfields> ah ok
3712017-07-16T20:30:02 <sipa> gmaxwell: cfields asked if there could be a locality impact
3722017-07-16T20:50:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/565494619d80...1fc783fc08bc
3732017-07-16T20:50:25 <bitcoin-git> bitcoin/master 5618b7d Pavel JanÃk: Do not shadow upper local variable `state`.
3742017-07-16T20:50:26 <bitcoin-git> bitcoin/master 1fc783f MarcoFalke: Merge #10739: test: Move variable `state` down where it is used...
3752017-07-16T20:50:36 *** promag has joined #bitcoin-core-dev
3762017-07-16T20:50:45 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10739: test: Move variable `state` down where it is used (master...20170704_Wshadow_txvalidationcache_tests) https://github.com/bitcoin/bitcoin/pull/10739
3772017-07-16T20:51:52 *** mmgen has quit IRC
3782017-07-16T20:53:27 *** Guyver2 has quit IRC
3792017-07-16T20:53:35 *** sam_c has quit IRC
3802017-07-16T20:55:37 <cfields> sipa: if we're using ffunction-sections, we can use -Wl,--icf=safe too
3812017-07-16T20:56:07 *** sam_c has joined #bitcoin-core-dev
3822017-07-16T20:56:37 <cfields> shaves off another ~70k for me
3832017-07-16T20:56:39 <sipa> cfields: i don't see that in man ld
3842017-07-16T20:56:53 <cfields> sipa: man ld.gold
3852017-07-16T20:57:50 *** Aaronvan_ has quit IRC
3862017-07-16T20:57:53 <sipa> ah
3872017-07-16T21:00:16 *** arowser has quit IRC
3882017-07-16T21:02:12 *** AaronvanW has joined #bitcoin-core-dev
3892017-07-16T21:05:58 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3902017-07-16T21:06:25 *** arowser has joined #bitcoin-core-dev
3912017-07-16T21:14:03 *** arowser has quit IRC
3922017-07-16T21:19:29 <bincap> given two gitian.signs asserts (from two people) is there a quick command to compare if their out_manifest is identical?
3932017-07-16T21:20:10 *** arowser has joined #bitcoin-core-dev
3942017-07-16T21:23:30 <bitcoin-git> [bitcoin] practicalswift opened pull request #10847: Enable devirtualization opportunities by using the final specifier (C++11) (master...devirtualization) https://github.com/bitcoin/bitcoin/pull/10847
3952017-07-16T21:24:17 *** Squidicc has joined #bitcoin-core-dev
3962017-07-16T21:25:52 *** arowser has quit IRC
3972017-07-16T21:38:48 *** QBcrusher has joined #bitcoin-core-dev
3982017-07-16T21:39:01 *** arowser has joined #bitcoin-core-dev
3992017-07-16T21:40:46 *** arowser has quit IRC
4002017-07-16T21:44:51 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1fc783fc08bc...3895e25a7736
4012017-07-16T21:44:52 <bitcoin-git> bitcoin/master 2c2e90d practicalswift: Fix incorrect Doxygen tag (@ince â @since). Make Doxygen parameter names match actual parameter names.
4022017-07-16T21:44:52 <bitcoin-git> bitcoin/master 3895e25 MarcoFalke: Merge #10842: Fix incorrect Doxygen tag (@ince â @since). Doxygen parameter name matching....
4032017-07-16T21:45:18 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10842: Fix incorrect Doxygen tag (@ince â @since). Doxygen parameter name matching. (master...doxygen-since) https://github.com/bitcoin/bitcoin/pull/10842
4042017-07-16T21:46:54 *** arowser has joined #bitcoin-core-dev
4052017-07-16T21:59:03 *** arowser has quit IRC
4062017-07-16T22:01:02 <Chris_Stewart_5> In the test framework, using node.generate() will propogate the block to another peer right?
4072017-07-16T22:01:22 <sipa> it'll propagate to whatever other peer it is connected to
4082017-07-16T22:01:45 <sipa> who will do the same
4092017-07-16T22:02:08 <Chris_Stewart_5> Do I need to use some sort of sleep mechanism if I need it to propogate before runnign the next line?
4102017-07-16T22:02:24 <sipa> no, you need to use wait_for_block
4112017-07-16T22:02:31 <sipa> or something similar
4122017-07-16T22:02:42 <Chris_Stewart_5> oh, cool. I'll check that out. Thanks.
4132017-07-16T22:05:12 *** arowser has joined #bitcoin-core-dev
4142017-07-16T22:05:28 *** BashCo has quit IRC
4152017-07-16T22:06:04 *** BashCo has joined #bitcoin-core-dev
4162017-07-16T22:08:38 *** promag has quit IRC
4172017-07-16T22:11:17 *** jamesob has joined #bitcoin-core-dev
4182017-07-16T22:14:29 *** rubensayshi has quit IRC
4192017-07-16T22:16:13 *** jamesob has quit IRC
4202017-07-16T22:21:33 *** marcoagner has quit IRC
4212017-07-16T22:22:15 *** wallet42 has joined #bitcoin-core-dev
4222017-07-16T22:26:19 *** marcoagner has joined #bitcoin-core-dev
4232017-07-16T22:26:51 *** robby938 has joined #bitcoin-core-dev
4242017-07-16T22:30:52 *** coredump_ has joined #bitcoin-core-dev
4252017-07-16T22:31:58 *** rubensayshi has joined #bitcoin-core-dev
4262017-07-16T22:33:41 <BlueMatt> cfields: gonna update 10809?
4272017-07-16T22:35:22 <sipa> BlueMatt: care to investigate #10758?
4282017-07-16T22:35:23 <gribble> https://github.com/bitcoin/bitcoin/issues/10758 | Fix some chainstate-init-order bugs. by TheBlueMatt · Pull Request #10758 · bitcoin/bitcoin · GitHub
4292017-07-16T22:35:43 <sipa> (it seems to forget progress when continuing a reindex)
4302017-07-16T22:36:03 <BlueMatt> oh, yes, thats next on my list
4312017-07-16T22:36:21 <sipa> actually, i may be an idiot there
4322017-07-16T22:37:08 <BlueMatt> hmm, did that not used to happen? I have no idea
4332017-07-16T22:38:19 <sipa> it is supposed to start over from scratch, but go faster through the parts it has already done
4342017-07-16T22:39:51 <sipa> i guess the thing to make sure is that it does not wipe the block index when contonuing a reindex
4352017-07-16T22:40:27 *** arowser has quit IRC
4362017-07-16T22:41:01 <BlueMatt> it shouldnt, though
4372017-07-16T22:41:02 <BlueMatt> hmm
4382017-07-16T22:41:15 <BlueMatt> (thats the section where you commented on the comment you found confusing
4392017-07-16T22:41:32 <BlueMatt> (it says explicitly that we dont want to clear the db even if we're setting fReindex unless its a new reindex...)
4402017-07-16T22:42:32 <sipa> well i failed to understand what it was trying to say :)
4412017-07-16T22:43:30 <BlueMatt> sipa: try now?
4422017-07-16T22:43:32 <BlueMatt> (comment, that is)
4432017-07-16T22:43:35 <BlueMatt> didnt change the code
4442017-07-16T22:43:41 <sipa> ok, will have a look soon
4452017-07-16T22:43:55 <BlueMatt> so, wait, do you think there is a bug that i should go hunt or do you think you mis-read?
4462017-07-16T22:45:22 <sipa> i thought there was a bug, but i'm less sure now
4472017-07-16T22:45:27 <sipa> i'll verify
4482017-07-16T22:46:39 *** arowser has joined #bitcoin-core-dev
4492017-07-16T22:48:52 *** marcoagner has quit IRC
4502017-07-16T22:51:20 *** marcoagner has joined #bitcoin-core-dev
4512017-07-16T22:53:33 <BlueMatt> hmmm...this client-side getinfo thing scares me
4522017-07-16T22:54:01 <BlueMatt> our rpcs are always atomic elements, but if you start calling getinfo, then getwalletinfo, then getmininginfo separately, they could return results based on different views of the current chain
4532017-07-16T22:54:06 <BlueMatt> which would be astoundingly confusing for users
4542017-07-16T22:54:57 <sipa> i'm totally fine with deprecating and then deleting
4552017-07-16T22:55:30 <BlueMatt> well I'm curious what the previously-mentioned "IRC discussion" was that resulted in the pr getting reopened
4562017-07-16T22:55:46 <BlueMatt> i dont want to show up late to the party and shit on it and say it shouldnt happen, but I'm really uneasy about the idea
4572017-07-16T22:58:17 <BlueMatt> sipa: do you want the asm sha in for 15?
4582017-07-16T22:58:20 <BlueMatt> should i bother reviewing it?
4592017-07-16T22:58:25 <BlueMatt> (yet)
4602017-07-16T22:58:56 <sipa> BlueMatt: i think it's a great and easy performance win, and i think it's ready
4612017-07-16T22:59:10 <sipa> whether we want it in 0.15 depends on reviewer interest
4622017-07-16T23:00:19 <BlueMatt> k
4632017-07-16T23:00:23 <BlueMatt> i'll try to get to it
4642017-07-16T23:01:00 <sipa> awesome
4652017-07-16T23:01:15 *** Aaronvan_ has joined #bitcoin-core-dev
4662017-07-16T23:01:33 *** AaronvanW has quit IRC
4672017-07-16T23:01:38 <cfields> BlueMatt: yea, will do in a bit. I'm frantically trying to bump qt atm.
4682017-07-16T23:02:40 <cfields> +1 for sha asm in 0.15
4692017-07-16T23:07:41 *** Aaronvan_ has quit IRC
4702017-07-16T23:09:20 <cfields> sipa: any theories as to what slows down the lto build?
4712017-07-16T23:10:33 *** ula has joined #bitcoin-core-dev
4722017-07-16T23:11:41 <sipa> cfields: over-eager inlining across objects?
4732017-07-16T23:13:06 *** RoyceX has quit IRC
4742017-07-16T23:14:05 <cfields> makes sense
4752017-07-16T23:14:11 <gmaxwell> sipa: wumpus had a comment about where the detection was being triggered for the asm.
4762017-07-16T23:14:13 <cfields> i could see how it might make a mess of our serialization
4772017-07-16T23:14:38 <sipa> gmaxwell: i've long since addressed that and commented about it
4782017-07-16T23:14:42 <gmaxwell> I only haven't acked it because I didn't think the patch was in its final state yet... I've tried it on a few hosts, works as expected.
4792017-07-16T23:14:45 <gmaxwell> sipa: oh
4802017-07-16T23:15:35 <gmaxwell> oh I see there are more commits now
4812017-07-16T23:15:56 <sipa> gmaxwell: where 'long' means 15 hours ago
4822017-07-16T23:16:45 <sipa> it also prints which implementation is being used
4832017-07-16T23:17:29 <sipa> the only unaddressed comment is BlueMatt's concern about printing copyright information for binary-only distributions
4842017-07-16T23:17:52 <BlueMatt> we do it for openssl for qt - we have it in the about dialog or smth iirc
4852017-07-16T23:18:08 <gmaxwell> I don't believe matt is correct in any case; we don't have a "binary only distribution" -- sure you don't have to download the source, but thats up to you.
4862017-07-16T23:18:09 <sipa> easy enough to add something there, if needed
4872017-07-16T23:18:17 <gmaxwell> BlueMatt: openssl is 4-clause BSD
4882017-07-16T23:20:00 <cfields> \o/ a self-test
4892017-07-16T23:20:54 <sipa> cfields: actually, you should test whether reintroducing the foldgers crystals bug in the sse asm causes it to select the basic sha256 implementation at run time
4902017-07-16T23:20:57 <sipa> it should
4912017-07-16T23:22:10 <gmaxwell> sipa: I was thinking of suggesting logging that failure, when cpu id and selftest disagree...
4922017-07-16T23:22:16 <cfields> sipa: hmm, i wonder if we should still fail in that case though, and require a --software-sha256 flag or something
4932017-07-16T23:22:27 <sipa> gmaxwell: the crypto code doesn't have access to logging
4942017-07-16T23:22:34 <cfields> if that's happening in the wild, we really want to know about it
4952017-07-16T23:23:06 <sipa> we could assert in case the selftest doesn't go as expected
4962017-07-16T23:23:14 <sipa> i agree that this may hide bugs
4972017-07-16T23:23:46 <sipa> though in a pretty safe way... i don't think it's easy to screw up SHA256 in a way that wouldn't be detectable with a single test
4982017-07-16T23:24:37 <gmaxwell> sipa: one thing the selftest doesn't extensively test is sensitivity to alignent.
4992017-07-16T23:24:44 <sipa> ok, i can fix that
5002017-07-16T23:24:57 <sipa> i can also extend it to test 0 and/or 2 blocks rather than just a single block
5012017-07-16T23:25:41 <BlueMatt> gmaxwell: hmm? bitcoin.org/bin has binary distributions
5022017-07-16T23:25:47 <BlueMatt> we ship binary-only stuff, at least on windows
5032017-07-16T23:25:52 <BlueMatt> iirc
5042017-07-16T23:26:41 <sipa> BlueMatt: i think gmaxwell's point is that the source code is still available for those
5052017-07-16T23:26:54 <sipa> i have no idea whether that matters, IANAL
5062017-07-16T23:27:16 <BlueMatt> ah, ok
5072017-07-16T23:27:19 <BlueMatt> wellt hen I dont care
5082017-07-16T23:27:36 <BlueMatt> as long as his point isnt "we dont ship binary-only" and is instead "but source is freely available", then he would know :)
5092017-07-16T23:27:51 <gmaxwell> BlueMatt: if it meant what you thought, it wouldn't be GPL compatible. You're interperting the license in the same way that 4-clause bsd is written.
5102017-07-16T23:28:03 <BlueMatt> k :)
5112017-07-16T23:28:34 <gmaxwell> BlueMatt: my point was we always make the source available.
5122017-07-16T23:28:34 *** promag has joined #bitcoin-core-dev
5132017-07-16T23:29:59 *** arowser has quit IRC
5142017-07-16T23:30:19 <bitcoin-git> [bitcoin] TheBlueMatt reopened pull request #10838: (finally) remove the longest-ever-deprecated RPC call getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
5152017-07-16T23:30:45 <BlueMatt> gmaxwell: we dont always *ship* the source along with the binary
5162017-07-16T23:30:48 <BlueMatt> was my point
5172017-07-16T23:30:56 <BlueMatt> as long as I'm misreading the liscense, I withdraw my concern :)
5182017-07-16T23:31:05 <BlueMatt> we just make it available
5192017-07-16T23:36:11 *** arowser has joined #bitcoin-core-dev
5202017-07-16T23:53:54 <gmaxwell> sipa: not something to fix now, but I see that the multiblock code doesn't really make a heroic effort to transform multiple blocks at a time. This may disavantage the avx2-rorx code, which really wants 2 blocks at a time (as it vector processes the initial expander in both blocks)
5212017-07-16T23:54:54 <sipa> gmaxwell: that's not too hard to fix
5222017-07-16T23:55:32 <gmaxwell> ya, I know. e.g. change the buffering to buffer two blocks.
5232017-07-16T23:55:54 <sipa> yeah
5242017-07-16T23:56:13 <gmaxwell> similar, the 8m rorx code is setup for 8 blocks.
5252017-07-16T23:59:08 *** arowser has quit IRC