12017-07-18T00:01:26 *** promag has quit IRC
22017-07-18T00:04:27 *** CubicEarth has quit IRC
32017-07-18T00:09:10 *** goatpig has quit IRC
42017-07-18T00:10:46 *** kexkey has quit IRC
52017-07-18T00:28:34 <bitcoin-git> [bitcoin] jtimon opened pull request #10859: RPC: gettxout: Slightly improve doc and tests (master...b15-rpc-gettxout-mempool) https://github.com/bitcoin/bitcoin/pull/10859
62017-07-18T00:29:32 *** chjj has quit IRC
72017-07-18T00:38:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
82017-07-18T00:41:02 *** chjj has joined #bitcoin-core-dev
92017-07-18T00:46:31 *** talmai has joined #bitcoin-core-dev
102017-07-18T00:46:52 *** Guest38971 has joined #bitcoin-core-dev
112017-07-18T00:49:24 *** jnewbery1 has quit IRC
122017-07-18T00:50:13 *** chjj has quit IRC
132017-07-18T00:54:11 *** chjj has joined #bitcoin-core-dev
142017-07-18T00:56:58 *** Dyaheon has quit IRC
152017-07-18T00:57:21 *** Dyaheon has joined #bitcoin-core-dev
162017-07-18T00:57:47 *** arowser has quit IRC
172017-07-18T01:03:12 *** PRab has quit IRC
182017-07-18T01:04:29 *** arowser has joined #bitcoin-core-dev
192017-07-18T01:07:47 <Guest38971> lets say I wanted my node to support bip148. What do I need to configure in order to allow this? I am currently running bitcoin core 0.14.2 am I just ammending a line of code into the config file? I just need a reference if possible or is it advised to just wait for a release from bitcoin core?. I do not know if this is the proper channel for this so I apologize in advance. Thank you very much for the help.
202017-07-18T01:11:22 <sipa> Bitcoin Core at this point does not support BIP148
212017-07-18T01:11:34 <sipa> There are forks of the codebase that do.
222017-07-18T01:13:08 *** jamesob_ has quit IRC
232017-07-18T01:18:34 *** belcher has quit IRC
242017-07-18T01:19:06 *** Victor_sueca has joined #bitcoin-core-dev
252017-07-18T01:20:40 *** Chris_Stewart_5 has quit IRC
262017-07-18T01:20:49 *** Victorsueca has quit IRC
272017-07-18T01:22:59 <Guest38971> Understood my question was hypethical. My main concern is if I am running my node how can I test BIP148 suppost. I found a link that allows me to download bitcoin core with BIP148 support, but I did not know if this was trustworthy. Thank you
282017-07-18T01:34:06 *** Chris_Stewart_5 has joined #bitcoin-core-dev
292017-07-18T01:50:28 *** QBcrusher_ has quit IRC
302017-07-18T01:52:02 *** d9b4bef9 has quit IRC
312017-07-18T01:53:08 *** d9b4bef9 has joined #bitcoin-core-dev
322017-07-18T02:03:07 *** Murch has quit IRC
332017-07-18T02:05:46 *** blznblzn2 has joined #bitcoin-core-dev
342017-07-18T02:06:53 *** Chris_Stewart_5 has quit IRC
352017-07-18T02:07:00 *** mappum_ has joined #bitcoin-core-dev
362017-07-18T02:07:09 *** mmoya_ has joined #bitcoin-core-dev
372017-07-18T02:08:23 *** michagogo_ has joined #bitcoin-core-dev
382017-07-18T02:09:08 *** emzy_ has joined #bitcoin-core-dev
392017-07-18T02:09:13 *** Bootvis_ has joined #bitcoin-core-dev
402017-07-18T02:09:52 *** Lauda__ has joined #bitcoin-core-dev
412017-07-18T02:09:59 *** niska` has joined #bitcoin-core-dev
422017-07-18T02:12:53 *** Guest38971 has quit IRC
432017-07-18T02:13:56 *** hsmiths has quit IRC
442017-07-18T02:13:56 *** Lauda has quit IRC
452017-07-18T02:13:57 *** michagogo has quit IRC
462017-07-18T02:13:57 *** Bootvis has quit IRC
472017-07-18T02:13:57 *** niska has quit IRC
482017-07-18T02:13:57 *** emzy has quit IRC
492017-07-18T02:13:57 *** bordeaux_facile has quit IRC
502017-07-18T02:13:57 *** mappum has quit IRC
512017-07-18T02:13:57 *** mmoya has quit IRC
522017-07-18T02:14:15 *** michagogo_ is now known as michagogo
532017-07-18T02:14:16 *** mmoya_ is now known as mmoya
542017-07-18T02:14:25 *** mappum_ is now known as mappum
552017-07-18T02:19:11 *** bordeaux_facile has joined #bitcoin-core-dev
562017-07-18T02:30:22 *** Ylbam has quit IRC
572017-07-18T02:32:19 *** harrymm has quit IRC
582017-07-18T02:34:48 *** CubicEarth has joined #bitcoin-core-dev
592017-07-18T02:39:37 <bitcoin-git> [bitcoin] ryanofsky closed pull request #10829: Simple, backwards compatible RPC multiwallet support. (master...pr/multiparam) https://github.com/bitcoin/bitcoin/pull/10829
602017-07-18T02:44:01 *** roasbeef has quit IRC
612017-07-18T02:50:32 *** harrymm has joined #bitcoin-core-dev
622017-07-18T02:51:45 *** Arvidt has joined #bitcoin-core-dev
632017-07-18T02:57:17 *** davec has quit IRC
642017-07-18T02:58:56 *** roasbeef has joined #bitcoin-core-dev
652017-07-18T03:01:33 *** Arvidt has quit IRC
662017-07-18T03:01:35 *** Dyaheon has quit IRC
672017-07-18T03:02:03 *** Dyaheon has joined #bitcoin-core-dev
682017-07-18T03:03:02 *** justanotheruser has joined #bitcoin-core-dev
692017-07-18T03:05:13 *** justan0theruser has quit IRC
702017-07-18T03:07:46 *** justanotheruser has quit IRC
712017-07-18T03:08:24 *** justanotheruser has joined #bitcoin-core-dev
722017-07-18T03:08:42 *** BashCo has quit IRC
732017-07-18T03:09:20 *** BashCo has joined #bitcoin-core-dev
742017-07-18T03:12:45 *** ivan has joined #bitcoin-core-dev
752017-07-18T03:23:28 *** fengling has joined #bitcoin-core-dev
762017-07-18T03:24:37 *** fengling has quit IRC
772017-07-18T03:25:28 *** fengling has joined #bitcoin-core-dev
782017-07-18T03:33:47 *** justan0theruser has joined #bitcoin-core-dev
792017-07-18T03:36:27 *** justan0theruser has quit IRC
802017-07-18T03:36:56 *** justanotheruser has quit IRC
812017-07-18T03:37:01 *** justan0theruser has joined #bitcoin-core-dev
822017-07-18T04:04:12 *** hsmiths has joined #bitcoin-core-dev
832017-07-18T04:05:22 *** Lauda__ is now known as Lauda
842017-07-18T04:24:34 *** dabura667 has joined #bitcoin-core-dev
852017-07-18T04:33:12 *** davec has joined #bitcoin-core-dev
862017-07-18T05:13:15 *** CubicEarth has quit IRC
872017-07-18T05:19:43 *** talmai has quit IRC
882017-07-18T05:22:15 *** mmgen has joined #bitcoin-core-dev
892017-07-18T05:25:51 *** d_t has quit IRC
902017-07-18T05:45:31 *** arowser has quit IRC
912017-07-18T05:53:36 *** arowser has joined #bitcoin-core-dev
922017-07-18T05:57:44 *** arowser has quit IRC
932017-07-18T05:58:25 *** mmgen has quit IRC
942017-07-18T06:04:46 *** arowser has joined #bitcoin-core-dev
952017-07-18T06:08:00 *** arowser has quit IRC
962017-07-18T06:09:10 *** arowser has joined #bitcoin-core-dev
972017-07-18T06:11:41 *** arowser has quit IRC
982017-07-18T06:14:20 *** arowser has joined #bitcoin-core-dev
992017-07-18T06:18:05 *** arowser has quit IRC
1002017-07-18T06:24:12 *** arowser has joined #bitcoin-core-dev
1012017-07-18T06:25:02 *** jouke has quit IRC
1022017-07-18T06:27:10 *** jouke has joined #bitcoin-core-dev
1032017-07-18T06:27:10 *** jouke has quit IRC
1042017-07-18T06:27:10 *** jouke has joined #bitcoin-core-dev
1052017-07-18T06:30:45 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75b5643c47c3...81560b07ce8a
1062017-07-18T06:30:45 <bitcoin-git> bitcoin/master 077d01f Cory Fields: random: only use getentropy on openbsd
1072017-07-18T06:30:46 <bitcoin-git> bitcoin/master 81560b0 Wladimir J. van der Laan: Merge #10855: random: only use getentropy on openbsd...
1082017-07-18T06:31:14 <bitcoin-git> [bitcoin] laanwj closed pull request #10855: random: only use getentropy on openbsd (master...getentropy-openbsd) https://github.com/bitcoin/bitcoin/pull/10855
1092017-07-18T06:44:42 <sipa> wumpus: how about a --sha256= option, which now defaults to basic, but can be changed to auto or a specific implementatio
1102017-07-18T06:44:45 <sipa> ?
1112017-07-18T06:44:46 *** Dyaheon has quit IRC
1122017-07-18T06:45:49 *** Dyaheon has joined #bitcoin-core-dev
1132017-07-18T06:46:15 <wumpus> sipa: if you want to go that way, it needs to be future-proof to be able to add more sha algorithms in the future and select multiple, I guess
1142017-07-18T06:47:29 <wumpus> that's why I proposed a a generic 'experimental assembly' flag, which is not so specific
1152017-07-18T06:47:40 <wumpus> but sure, that makes sense
1162017-07-18T06:56:01 *** Victor_sueca is now known as Victorsueca
1172017-07-18T07:10:37 *** BashCo has quit IRC
1182017-07-18T07:11:15 *** BashCo has joined #bitcoin-core-dev
1192017-07-18T07:14:36 <cfields> sipa: i think that's good to have either way. If nothing else, it makes benchmarking/comparing easier.
1202017-07-18T07:15:38 <sipa> cfields: agree
1212017-07-18T07:16:29 <gmaxwell> more complex is genreally less good because it's costly to test all the options. --enable-expiremental-asm is also what we did in libsecp (and FWIW! how arm still is!)
1222017-07-18T07:21:35 <sipa> gmaxwell: there are other advantages... like being able to run the tests and benchmarks on different hash function impls even if it's not the best available on your platform
1232017-07-18T07:22:47 <wumpus> that doesn't need a compile time option
1242017-07-18T07:23:44 <wumpus> e.g. bench could just cycle through all available sha algorithms
1252017-07-18T07:24:09 <sipa> agree, like your branch did
1262017-07-18T07:24:23 <wumpus> or some run-time override, if you want to do the other tests / a chain sync with it
1272017-07-18T07:24:42 <wumpus> but maybe that's overkill to add an option for such a rare scenario
1282017-07-18T07:25:08 <wumpus> but at least the tests should test all the possibilities (that run on the platform) I guess
1292017-07-18T07:25:12 <sipa> wumpus: by --sha256 i meant a runtime option
1302017-07-18T07:25:19 <wumpus> for basic sanity testing, not for running all tests
1312017-07-18T07:26:03 <wumpus> okay
1322017-07-18T07:26:14 <sipa> i'll keep it simple now
1332017-07-18T07:29:19 *** ivan has quit IRC
1342017-07-18T07:30:57 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/81560b07ce8a...7b6e8bc44240
1352017-07-18T07:30:57 <bitcoin-git> bitcoin/master 1fc8c3d Matt Corallo: No longer ever reuse keypool indexes...
1362017-07-18T07:30:58 <bitcoin-git> bitcoin/master 7b6e8bc Wladimir J. van der Laan: Merge #10795: No longer ever reuse keypool indexes...
1372017-07-18T07:31:06 <sipa> wumpus: oh, i see, you meant a compile time option
1382017-07-18T07:31:08 <sipa> ack
1392017-07-18T07:31:29 <bitcoin-git> [bitcoin] laanwj closed pull request #10795: No longer ever reuse keypool indexes (master...2017-07-wallet-keypool-overwrite) https://github.com/bitcoin/bitcoin/pull/10795
1402017-07-18T07:34:41 *** coredump_ has quit IRC
1412017-07-18T07:40:49 *** d_t has joined #bitcoin-core-dev
1422017-07-18T07:45:00 *** blznblzn2 has quit IRC
1432017-07-18T08:12:06 *** Ylbam has joined #bitcoin-core-dev
1442017-07-18T08:14:01 *** harrymm has quit IRC
1452017-07-18T08:21:08 *** paveljanik has quit IRC
1462017-07-18T08:30:24 *** harrymm has joined #bitcoin-core-dev
1472017-07-18T08:32:06 *** SopaXorzTaker has joined #bitcoin-core-dev
1482017-07-18T08:35:51 *** timothy has joined #bitcoin-core-dev
1492017-07-18T08:36:50 *** d_t has quit IRC
1502017-07-18T08:38:28 *** Guyver2 has joined #bitcoin-core-dev
1512017-07-18T08:40:10 *** ayy1337 has joined #bitcoin-core-dev
1522017-07-18T08:57:35 *** bincap has quit IRC
1532017-07-18T09:02:44 *** bincap has joined #bitcoin-core-dev
1542017-07-18T09:05:34 *** tiagotrs has joined #bitcoin-core-dev
1552017-07-18T09:06:50 *** tiagotrs has joined #bitcoin-core-dev
1562017-07-18T09:09:50 *** coredump_ has joined #bitcoin-core-dev
1572017-07-18T10:02:38 *** dabura667 has quit IRC
1582017-07-18T10:12:49 *** sdfgsdfg has joined #bitcoin-core-dev
1592017-07-18T10:13:07 *** spinza has quit IRC
1602017-07-18T10:17:05 *** coredump_ has quit IRC
1612017-07-18T10:18:59 *** spinza has joined #bitcoin-core-dev
1622017-07-18T10:29:51 <wumpus> yes, I meant a compile-time option, sorry for not being clear
1632017-07-18T10:38:14 *** mmgen has joined #bitcoin-core-dev
1642017-07-18T10:39:47 *** Gudrun has joined #bitcoin-core-dev
1652017-07-18T10:49:09 *** ayy1337|2 has joined #bitcoin-core-dev
1662017-07-18T10:50:28 *** ayy1337 has quit IRC
1672017-07-18T11:09:35 *** BashCo has quit IRC
1682017-07-18T11:10:10 *** BashCo has joined #bitcoin-core-dev
1692017-07-18T11:14:22 *** emzy_ is now known as emzy
1702017-07-18T11:14:28 *** emzy has joined #bitcoin-core-dev
1712017-07-18T11:49:52 *** Gudrun has quit IRC
1722017-07-18T11:59:34 *** jannes has joined #bitcoin-core-dev
1732017-07-18T12:04:36 <bitcoin-git> [bitcoin] practicalswift opened pull request #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" â "condition". (master...nEnd) https://github.com/bitcoin/bitcoin/pull/10862
1742017-07-18T12:06:47 *** Magma has joined #bitcoin-core-dev
1752017-07-18T12:10:34 *** jorge has joined #bitcoin-core-dev
1762017-07-18T12:10:57 *** jorge is now known as Guest56804
1772017-07-18T12:13:12 *** mryandao has quit IRC
1782017-07-18T12:19:23 *** Dyaheon has quit IRC
1792017-07-18T12:21:46 *** Dyaheon has joined #bitcoin-core-dev
1802017-07-18T12:46:31 *** Aiden has joined #bitcoin-core-dev
1812017-07-18T13:00:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1822017-07-18T13:07:51 <bitcoin-git> [bitcoin] corebob opened pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
1832017-07-18T13:10:25 *** marcoagner has quit IRC
1842017-07-18T13:11:31 *** goatpig has joined #bitcoin-core-dev
1852017-07-18T13:13:21 <bitcoin-git> [bitcoin] practicalswift opened pull request #10864: Avoid redundant redeclaration of GetWarnings(const string&) (master...GetWarnings-in-warnings.h) https://github.com/bitcoin/bitcoin/pull/10864
1862017-07-18T13:22:13 *** marcoagner has joined #bitcoin-core-dev
1872017-07-18T13:23:31 *** davec has quit IRC
1882017-07-18T13:24:18 *** mryandao has joined #bitcoin-core-dev
1892017-07-18T13:28:53 <bitcoin-git> [bitcoin] corebob closed pull request #10863: Fix leaking a socket handle if call to SetSocketNonBlocking failed (master...20170718-fix-leak-1) https://github.com/bitcoin/bitcoin/pull/10863
1902017-07-18T13:30:18 *** Aiden has quit IRC
1912017-07-18T13:30:36 *** chjj has quit IRC
1922017-07-18T13:30:43 *** Genesis2 has joined #bitcoin-core-dev
1932017-07-18T13:41:06 *** davec has joined #bitcoin-core-dev
1942017-07-18T13:44:04 *** chjj has joined #bitcoin-core-dev
1952017-07-18T13:46:53 *** Genesis2 has quit IRC
1962017-07-18T13:47:55 *** dabura667 has joined #bitcoin-core-dev
1972017-07-18T13:49:47 *** corebob has quit IRC
1982017-07-18T13:54:32 *** George has joined #bitcoin-core-dev
1992017-07-18T13:59:07 *** George has quit IRC
2002017-07-18T14:09:38 *** mmgen has quit IRC
2012017-07-18T14:09:47 *** Kennedi has joined #bitcoin-core-dev
2022017-07-18T14:11:21 *** jtimon has joined #bitcoin-core-dev
2032017-07-18T14:20:13 *** mmgen has joined #bitcoin-core-dev
2042017-07-18T14:20:16 *** RoyceX has quit IRC
2052017-07-18T14:20:33 *** Cheeseo has joined #bitcoin-core-dev
2062017-07-18T14:26:01 *** Dyaheon has quit IRC
2072017-07-18T14:26:58 *** Dyaheon has joined #bitcoin-core-dev
2082017-07-18T14:31:16 *** Kennedi has quit IRC
2092017-07-18T14:33:17 <bitcoin-git> [bitcoin] corebob opened pull request #10865: Move CloseSocket out of SetSocketNonBlocking in netbase.cpp (master...20170718-refactor-1) https://github.com/bitcoin/bitcoin/pull/10865
2102017-07-18T14:34:32 *** sdfgsdfg has quit IRC
2112017-07-18T14:39:38 *** Murch has joined #bitcoin-core-dev
2122017-07-18T14:47:13 *** Prudence has joined #bitcoin-core-dev
2132017-07-18T14:50:02 <bitcoin-git> [bitcoin] practicalswift opened pull request #10866: Add mutex requirement for AddToCompactExtraTransactions(â¦) (master...lock-requirement-for-AddToCompactExtraTransactions) https://github.com/bitcoin/bitcoin/pull/10866
2142017-07-18T14:50:46 <BlueMatt> wumpus: where did we land on freeze?
2152017-07-18T14:57:10 *** dabura667 has quit IRC
2162017-07-18T15:06:05 *** tiagotrs has quit IRC
2172017-07-18T15:09:54 *** BashCo has quit IRC
2182017-07-18T15:10:30 *** BashCo has joined #bitcoin-core-dev
2192017-07-18T15:16:21 <wumpus> #10849 and #10571 seem ready to go in
2202017-07-18T15:16:23 <gribble> https://github.com/bitcoin/bitcoin/issues/10849 | Multiwallet: simplest endpoint support by jonasschnelli · Pull Request #10849 · bitcoin/bitcoin · GitHub
2212017-07-18T15:16:25 <gribble> https://github.com/bitcoin/bitcoin/issues/10571 | [RPC]Move transaction combining from signrawtransaction to new RPC by achow101 · Pull Request #10571 · bitcoin/bitcoin · GitHub
2222017-07-18T15:16:37 <wumpus> #10579 has missed the window imo
2232017-07-18T15:16:38 <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
2242017-07-18T15:17:04 <wumpus> same for #9502
2252017-07-18T15:17:06 <gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
2262017-07-18T15:18:20 <wumpus> I think the rest tagged for 0.15 qualifies as bug-fix, not feature
2272017-07-18T15:18:26 <wumpus> BlueMatt: #10784 needs rebase btw
2282017-07-18T15:18:27 <gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
2292017-07-18T15:19:15 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/7b6e8bc44240...bde4f937aebc
2302017-07-18T15:19:16 <bitcoin-git> bitcoin/master dd2185c Jonas Schnelli: Register wallet endpoint
2312017-07-18T15:19:17 <bitcoin-git> bitcoin/master 31e0720 Jonas Schnelli: Add wallet endpoint support to bitcoin-cli (-usewallet)
2322017-07-18T15:19:17 <bitcoin-git> bitcoin/master 32c9710 Jonas Schnelli: Fix test_bitcoin circular dependency issue
2332017-07-18T15:20:06 <bitcoin-git> [bitcoin] laanwj closed pull request #10849: Multiwallet: simplest endpoint support (master...2017/07/mw_endpoint_simple) https://github.com/bitcoin/bitcoin/pull/10849
2342017-07-18T15:20:25 *** talmai has joined #bitcoin-core-dev
2352017-07-18T15:21:17 <BlueMatt> wumpus: done
2362017-07-18T15:22:08 <BlueMatt> wumpus: concept ack on 10571, I'm happy to see it merged now and I'll postumously ack it later today
2372017-07-18T15:22:41 <wumpus> just found a bug in 10571
2382017-07-18T15:23:11 <BlueMatt> heh, ok, nevermind, then
2392017-07-18T15:23:30 <BlueMatt> no harm in pushing to 16 imo, no?
2402017-07-18T15:23:32 <wumpus> a very minor one though just an error message
2412017-07-18T15:24:27 <BlueMatt> up to you, we have a few weeks bugfix window anyway
2422017-07-18T15:25:20 <wumpus> well it would be a waste with so many utacks, this is a trivial fix, will wait for achow101
2432017-07-18T15:26:13 *** pandabull has joined #bitcoin-core-dev
2442017-07-18T15:28:54 <wumpus> #10784 does need mention in release notes I guess
2452017-07-18T15:28:55 <gribble> https://github.com/bitcoin/bitcoin/issues/10784 | Do not allow users to get keys from keypool without reserving them by TheBlueMatt · Pull Request #10784 · bitcoin/bitcoin · GitHub
2462017-07-18T15:29:37 <BlueMatt> indeed
2472017-07-18T15:30:26 * wumpus wishes people would do that immediately instead of leaving it until the end
2482017-07-18T15:30:34 <wumpus> but ok, shouldn't hold up merge
2492017-07-18T15:30:55 <BlueMatt> heh, sorry
2502017-07-18T15:31:02 <BlueMatt> been a mad rush this last week or two
2512017-07-18T15:31:32 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bde4f937aebc...9e8d6a3fb43a
2522017-07-18T15:31:32 <bitcoin-git> bitcoin/master cf82a9e Matt Corallo: Do not allow users to get keys from keypool without reserving them...
2532017-07-18T15:31:33 <bitcoin-git> bitcoin/master 9e8d6a3 Wladimir J. van der Laan: Merge #10784: Do not allow users to get keys from keypool without reserving them...
2542017-07-18T15:32:08 <bitcoin-git> [bitcoin] laanwj closed pull request #10784: Do not allow users to get keys from keypool without reserving them (master...2017-07-keep-change) https://github.com/bitcoin/bitcoin/pull/10784
2552017-07-18T15:40:42 *** jamesob_ has joined #bitcoin-core-dev
2562017-07-18T15:46:39 *** dabura667 has joined #bitcoin-core-dev
2572017-07-18T15:56:29 *** talmai has quit IRC
2582017-07-18T15:59:50 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10867: Allow only a single -usewallet argument (master...2017/07/multiwallet_bitcoincli) https://github.com/bitcoin/bitcoin/pull/10867
2592017-07-18T16:06:24 <bitcoin-git> [bitcoin] jnewbery opened pull request #10868: Remove -usewallet (master...remove_use_wallet) https://github.com/bitcoin/bitcoin/pull/10868
2602017-07-18T16:10:29 <jonasschnelli> ^^
2612017-07-18T16:11:03 *** AaronvanW has joined #bitcoin-core-dev
2622017-07-18T16:11:58 *** AaronvanW has joined #bitcoin-core-dev
2632017-07-18T16:25:45 <jonasschnelli> Hmm... isn't the whole wallet endpoint URI encoding really required if we only allow "CHARS_ALPHA_NUM + ".-_"" for wallet filenames?!
2642017-07-18T16:26:01 <jonasschnelli> I guess it's not. Ping ryanofsky
2652017-07-18T16:30:57 *** Chris_Stewart_5 has quit IRC
2662017-07-18T16:31:26 <cfields> jonasschnelli: i wondered about that as well. I tried (unsuccessfully) to get wallets containing sneaky characters to load, and it failed as expected (though sometimes with a segfault that needs to be fixed). I fail to see why it's necessary
2672017-07-18T16:32:24 <cfields> jonasschnelli: i assumed it was for more robust usage in the future
2682017-07-18T16:34:10 <jonasschnelli> cfields: yes. That makes sense.
2692017-07-18T16:35:50 <cfields> jonasschnelli: well that theory is based on absolutely nothing :)
2702017-07-18T16:38:34 <jonasschnelli> Indeed
2712017-07-18T16:43:20 *** Prudence has quit IRC
2722017-07-18T16:55:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2732017-07-18T17:06:14 *** Bobby2 has joined #bitcoin-core-dev
2742017-07-18T17:07:10 *** Bobby2 has quit IRC
2752017-07-18T17:12:48 *** d_t has joined #bitcoin-core-dev
2762017-07-18T17:25:55 *** timothy has quit IRC
2772017-07-18T17:34:38 <ryanofsky> url encoding was suggested when there were still wallet ids. if you want to check for CHARS_ALPHA_NUM in bitcoin-cli instead of percent encoding, that seems fine, though a little more fragile (because maybe we will allow another class of characters in bitcoind and bitcoin-cli will break)
2782017-07-18T17:35:55 *** dgenr8 has quit IRC
2792017-07-18T17:36:49 <sipa> i'd rather leave it this way
2802017-07-18T17:36:56 *** dgenr8 has joined #bitcoin-core-dev
2812017-07-18T17:46:33 <morcos> wumpus: #10817 is not really a bug fix, but its ready for merge and adds a couple strings
2822017-07-18T17:46:34 <gribble> https://github.com/bitcoin/bitcoin/issues/10817 | Redefine Dust and add a discard_rate by morcos · Pull Request #10817 · bitcoin/bitcoin · GitHub
2832017-07-18T17:51:10 *** chjj has quit IRC
2842017-07-18T17:53:54 *** AaronvanW has quit IRC
2852017-07-18T17:54:32 *** AaronvanW has joined #bitcoin-core-dev
2862017-07-18T18:00:01 *** dgenr8 has quit IRC
2872017-07-18T18:03:11 *** chjj has joined #bitcoin-core-dev
2882017-07-18T18:10:44 *** deep-book-gk_ has joined #bitcoin-core-dev
2892017-07-18T18:11:06 *** dgenr8 has joined #bitcoin-core-dev
2902017-07-18T18:12:43 *** deep-book-gk_ has left #bitcoin-core-dev
2912017-07-18T18:16:07 *** jnewbery has quit IRC
2922017-07-18T18:17:10 *** Soledad has joined #bitcoin-core-dev
2932017-07-18T18:17:12 *** jnewbery has joined #bitcoin-core-dev
2942017-07-18T18:21:52 *** Soledad has quit IRC
2952017-07-18T18:25:36 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
2962017-07-18T18:27:28 *** Chris_Stewart_5 has quit IRC
2972017-07-18T18:28:02 *** THoVer has joined #bitcoin-core-dev
2982017-07-18T18:28:59 *** laurentmt has joined #bitcoin-core-dev
2992017-07-18T18:41:16 *** rookie_123_ has joined #bitcoin-core-dev
3002017-07-18T18:49:41 *** jtimon has quit IRC
3012017-07-18T18:52:04 *** arowser has quit IRC
3022017-07-18T18:53:22 *** jtimon has joined #bitcoin-core-dev
3032017-07-18T18:55:02 *** THoVer has quit IRC
3042017-07-18T18:56:36 *** chjj has quit IRC
3052017-07-18T18:58:18 *** arowser has joined #bitcoin-core-dev
3062017-07-18T19:08:05 *** chjj has joined #bitcoin-core-dev
3072017-07-18T19:09:32 <jtimon> jonasschnelli: I'm having problems explaining my suggestion in https://github.com/bitcoin/bips/pull/555
3082017-07-18T19:09:41 <jtimon> do you understand my suggestion?
3092017-07-18T19:09:51 <jtimon> perhaps you can help. communication is hard
3102017-07-18T19:11:26 *** BashCo has quit IRC
3112017-07-18T19:12:15 *** BashCo has joined #bitcoin-core-dev
3122017-07-18T19:21:40 *** tiagotrs has joined #bitcoin-core-dev
3132017-07-18T19:30:50 *** laurentmt has quit IRC
3142017-07-18T19:35:34 *** AaronvanW has quit IRC
3152017-07-18T19:36:10 *** AaronvanW has joined #bitcoin-core-dev
3162017-07-18T19:40:34 *** AaronvanW has quit IRC
3172017-07-18T19:42:28 <goatpig> jtimon: you to provide the outpoint with the address?
3182017-07-18T19:42:31 <goatpig> want*
3192017-07-18T19:44:21 *** paveljanik has joined #bitcoin-core-dev
3202017-07-18T19:44:35 <jtimon> it seems I missunderstood this comment "The checksum should not contain any salted data. Otherwise with 30bits of non-cryptographic checksum one can easily calculate a TxID that is valid for more than one Network"
3212017-07-18T19:45:21 <jtimon> he means that since it's only 30 bits of checksum, with 2^15 tries you can create a collision that is valid for more than 1 network.
3222017-07-18T20:19:05 *** kinetiks has joined #bitcoin-core-dev
3232017-07-18T20:20:35 *** pandabull has joined #bitcoin-core-dev
3242017-07-18T20:28:36 *** promag has joined #bitcoin-core-dev
3252017-07-18T20:35:45 *** AaronvanW has joined #bitcoin-core-dev
3262017-07-18T20:50:02 *** promag has quit IRC
3272017-07-18T20:50:39 *** AaronvanW has quit IRC
3282017-07-18T20:51:15 *** AaronvanW has joined #bitcoin-core-dev
3292017-07-18T20:51:16 *** rookie_123_ has quit IRC
3302017-07-18T20:55:44 *** AaronvanW has quit IRC
3312017-07-18T21:11:55 *** Dyaheon has quit IRC
3322017-07-18T21:13:54 *** Dyaheon has joined #bitcoin-core-dev
3332017-07-18T21:25:00 *** Murch has quit IRC
3342017-07-18T21:25:38 *** Murch has joined #bitcoin-core-dev
3352017-07-18T21:26:34 *** Murch has joined #bitcoin-core-dev
3362017-07-18T21:26:49 *** Murch has quit IRC
3372017-07-18T21:27:22 *** Murch has joined #bitcoin-core-dev
3382017-07-18T21:35:40 *** tucenaber has joined #bitcoin-core-dev
3392017-07-18T21:40:05 *** mmgen has quit IRC
3402017-07-18T21:42:37 *** dabura667 has quit IRC
3412017-07-18T21:46:28 *** kinetiks has quit IRC
3422017-07-18T21:46:35 *** promag has joined #bitcoin-core-dev
3432017-07-18T21:49:18 *** dermoth has quit IRC
3442017-07-18T21:49:46 *** dermoth has joined #bitcoin-core-dev
3452017-07-18T21:51:26 *** promag has quit IRC
3462017-07-18T21:55:21 *** promag has joined #bitcoin-core-dev
3472017-07-18T21:55:44 *** tiagotrs has quit IRC
3482017-07-18T21:56:45 *** promag1 has joined #bitcoin-core-dev
3492017-07-18T21:56:46 *** promag has quit IRC
3502017-07-18T22:10:20 *** chjj has quit IRC
3512017-07-18T22:13:20 *** Guest56804 has quit IRC
3522017-07-18T22:19:49 <bitcoin-git> [bitcoin] achow101 opened pull request #10871: Handle getinfo in bitcoin-cli w/ -getinfo (revival of #8843) (master...cli-getinfo) https://github.com/bitcoin/bitcoin/pull/10871
3532017-07-18T22:22:38 *** chjj has joined #bitcoin-core-dev
3542017-07-18T22:24:06 <bitcoin-git> [bitcoin] eklitzke opened pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
3552017-07-18T22:31:30 *** Guyver2 has quit IRC
3562017-07-18T22:31:54 *** dabura667 has joined #bitcoin-core-dev
3572017-07-18T22:33:23 *** AaronvanW has joined #bitcoin-core-dev
3582017-07-18T22:41:20 *** dabura667 has quit IRC
3592017-07-18T22:46:36 *** ivan has joined #bitcoin-core-dev
3602017-07-18T22:55:54 *** promag1 has quit IRC
3612017-07-18T22:56:25 *** DaggerHashimoto has quit IRC
3622017-07-18T22:59:04 *** promag has joined #bitcoin-core-dev
3632017-07-18T23:03:23 *** vicenteH has quit IRC
3642017-07-18T23:10:57 *** BashCo has quit IRC
3652017-07-18T23:11:33 *** BashCo has joined #bitcoin-core-dev
3662017-07-18T23:12:47 *** discreteunit has joined #bitcoin-core-dev
3672017-07-18T23:21:32 *** promag has quit IRC
3682017-07-18T23:21:51 <jtimon> mhmm it's just me... http://downforeveryoneorjustme.com/github.com
3692017-07-18T23:23:24 *** corebob has joined #bitcoin-core-dev
3702017-07-18T23:23:33 *** discreteunit has quit IRC
3712017-07-18T23:23:40 <jtimon> it's alive! now
3722017-07-18T23:24:26 <sipa> status.github.com
3732017-07-18T23:33:18 *** coredump_ has joined #bitcoin-core-dev
3742017-07-18T23:33:58 <bitcoin-git> [bitcoin] eklitzke opened pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
3752017-07-18T23:39:56 *** promag has joined #bitcoin-core-dev
3762017-07-18T23:40:17 *** promag has left #bitcoin-core-dev
3772017-07-18T23:45:18 *** AaronvanW has quit IRC
3782017-07-18T23:45:53 *** AaronvanW has joined #bitcoin-core-dev
3792017-07-18T23:50:05 *** AaronvanW has quit IRC
3802017-07-18T23:57:07 *** jorge has joined #bitcoin-core-dev
3812017-07-18T23:57:32 *** jorge is now known as Guest33550