12017-07-25T00:08:07 *** chjj has joined #bitcoin-core-dev
22017-07-25T00:13:05 *** AaronvanW has quit IRC
32017-07-25T00:13:53 *** Dyaheon has quit IRC
42017-07-25T00:16:52 *** Dyaheon has joined #bitcoin-core-dev
52017-07-25T00:17:47 *** BashCo has quit IRC
62017-07-25T00:18:23 *** BashCo has joined #bitcoin-core-dev
72017-07-25T00:24:53 *** promag has quit IRC
82017-07-25T00:30:01 *** chjj has quit IRC
92017-07-25T00:31:14 *** intcat has joined #bitcoin-core-dev
102017-07-25T00:39:09 *** promag has joined #bitcoin-core-dev
112017-07-25T00:39:44 *** promag has left #bitcoin-core-dev
122017-07-25T00:40:02 *** wasi has quit IRC
132017-07-25T00:41:01 *** wasi has joined #bitcoin-core-dev
142017-07-25T00:42:16 *** Chris_Stewart_5 has quit IRC
152017-07-25T00:42:32 *** arowser has quit IRC
162017-07-25T00:42:53 *** chjj has joined #bitcoin-core-dev
172017-07-25T00:43:57 *** arowser has joined #bitcoin-core-dev
182017-07-25T00:45:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
192017-07-25T00:53:59 *** Ylbam has quit IRC
202017-07-25T01:03:23 *** miknotauro has quit IRC
212017-07-25T01:05:22 *** dabura667 has joined #bitcoin-core-dev
222017-07-25T01:12:01 *** DrOlmer2 has quit IRC
232017-07-25T01:12:59 *** chjj has quit IRC
242017-07-25T01:15:34 *** ill has joined #bitcoin-core-dev
252017-07-25T01:18:54 *** btcdrak has joined #bitcoin-core-dev
262017-07-25T01:24:47 *** chjj has joined #bitcoin-core-dev
272017-07-25T01:34:40 *** Chris_Stewart_5 has quit IRC
282017-07-25T01:42:25 *** ill has quit IRC
292017-07-25T01:43:15 *** ill has joined #bitcoin-core-dev
302017-07-25T01:58:18 *** goatpig has quit IRC
312017-07-25T02:02:44 *** praxeology has left #bitcoin-core-dev
322017-07-25T02:03:26 *** praxeology has joined #bitcoin-core-dev
332017-07-25T02:10:02 *** Guest24650 has quit IRC
342017-07-25T02:19:06 *** kexkey has joined #bitcoin-core-dev
352017-07-25T02:20:24 *** Dyaheon has quit IRC
362017-07-25T02:21:29 *** Dyaheon has joined #bitcoin-core-dev
372017-07-25T02:28:12 *** kexkey_ has joined #bitcoin-core-dev
382017-07-25T02:28:57 *** kexkey has quit IRC
392017-07-25T02:32:03 *** kexkey_ is now known as kexkey
402017-07-25T02:53:40 *** KevinPan has joined #bitcoin-core-dev
412017-07-25T02:56:49 *** justan0theruser has quit IRC
422017-07-25T02:57:12 *** justanotheruser has joined #bitcoin-core-dev
432017-07-25T03:00:46 *** justanotheruser has quit IRC
442017-07-25T03:01:18 *** justanotheruser has joined #bitcoin-core-dev
452017-07-25T03:08:16 *** davec has quit IRC
462017-07-25T03:13:21 *** elias19r has quit IRC
472017-07-25T03:18:52 *** davec has joined #bitcoin-core-dev
482017-07-25T03:23:32 *** miknotauro has joined #bitcoin-core-dev
492017-07-25T03:29:00 *** Eagle[TM] has joined #bitcoin-core-dev
502017-07-25T03:31:40 *** EagleTM has quit IRC
512017-07-25T03:39:51 *** jifenglei has joined #bitcoin-core-dev
522017-07-25T03:44:38 *** iglobalvn has joined #bitcoin-core-dev
532017-07-25T03:44:51 <iglobalvn> hi
542017-07-25T03:44:58 *** str4d has joined #bitcoin-core-dev
552017-07-25T03:45:19 *** chjj has quit IRC
562017-07-25T03:58:52 *** KevinPan has quit IRC
572017-07-25T04:00:41 *** BashCo has quit IRC
582017-07-25T04:01:20 *** BashCo has joined #bitcoin-core-dev
592017-07-25T04:11:41 *** Murch has quit IRC
602017-07-25T04:11:53 *** str4d has quit IRC
612017-07-25T04:23:53 *** Dyaheon has quit IRC
622017-07-25T04:25:37 *** Dyaheon has joined #bitcoin-core-dev
632017-07-25T04:44:53 *** miknotauro has quit IRC
642017-07-25T04:56:05 *** d_t has quit IRC
652017-07-25T04:59:21 *** d_t has joined #bitcoin-core-dev
662017-07-25T05:06:57 *** adiabat has quit IRC
672017-07-25T05:14:34 *** jouke has quit IRC
682017-07-25T05:16:21 *** adiabat has joined #bitcoin-core-dev
692017-07-25T05:16:41 *** jouke has joined #bitcoin-core-dev
702017-07-25T05:16:41 *** jouke has quit IRC
712017-07-25T05:16:41 *** jouke has joined #bitcoin-core-dev
722017-07-25T05:34:27 *** J-wolf has joined #bitcoin-core-dev
732017-07-25T05:37:43 *** jamesob_ has quit IRC
742017-07-25T05:39:38 *** jamesob_ has joined #bitcoin-core-dev
752017-07-25T05:48:06 *** J-wolf has quit IRC
762017-07-25T06:00:12 *** jamesob_ has quit IRC
772017-07-25T06:10:08 *** J-wolf has joined #bitcoin-core-dev
782017-07-25T06:26:20 *** chjj has joined #bitcoin-core-dev
792017-07-25T06:29:22 *** Dyaheon has quit IRC
802017-07-25T06:30:42 *** Dyaheon has joined #bitcoin-core-dev
812017-07-25T06:42:27 *** Ylbam has joined #bitcoin-core-dev
822017-07-25T06:53:53 *** Cory has quit IRC
832017-07-25T07:00:03 *** DrOlmer2 has joined #bitcoin-core-dev
842017-07-25T07:04:01 *** kexkey has quit IRC
852017-07-25T07:04:35 *** DrOlmer2 has quit IRC
862017-07-25T07:08:21 *** timothy has joined #bitcoin-core-dev
872017-07-25T07:29:46 *** J-wolf has quit IRC
882017-07-25T07:32:07 *** LeMiner has quit IRC
892017-07-25T07:33:52 *** justanotheruser has quit IRC
902017-07-25T07:34:04 *** miknotauro has joined #bitcoin-core-dev
912017-07-25T07:35:15 <bitcoin-git> [bitcoin] practicalswift opened pull request #10923: Use -Wthread-safety-analysis if available (+ -Werror=thread-safety-analysis if --enable-werror) (master...thread-safety-analysis) https://github.com/bitcoin/bitcoin/pull/10923
922017-07-25T07:36:01 *** d9b4bef9 has quit IRC
932017-07-25T07:37:17 *** d9b4bef9 has joined #bitcoin-core-dev
942017-07-25T07:38:34 *** justanotheruser has joined #bitcoin-core-dev
952017-07-25T07:42:44 *** coredump_ has quit IRC
962017-07-25T07:46:58 *** Orion3k has quit IRC
972017-07-25T07:49:50 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0c70e845aa92...1124328ad1e8
982017-07-25T07:49:51 <bitcoin-git> bitcoin/master a5ecaf1 Steven D. Lander: Fix misspellings and remove safety verbiage
992017-07-25T07:49:52 <bitcoin-git> bitcoin/master 1124328 Wladimir J. van der Laan: Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp...
1002017-07-25T07:50:19 <bitcoin-git> [bitcoin] laanwj closed pull request #10789: Punctuation/grammer fixes in rpcwallet.cpp (master...cli-punctuation-standardization) https://github.com/bitcoin/bitcoin/pull/10789
1012017-07-25T07:52:55 *** Cory has joined #bitcoin-core-dev
1022017-07-25T07:59:19 *** AaronvanW has joined #bitcoin-core-dev
1032017-07-25T07:59:32 *** J-wolf has joined #bitcoin-core-dev
1042017-07-25T08:00:34 *** Aaronvan_ has joined #bitcoin-core-dev
1052017-07-25T08:00:42 *** BashCo has quit IRC
1062017-07-25T08:01:18 *** BashCo has joined #bitcoin-core-dev
1072017-07-25T08:04:31 *** AaronvanW has quit IRC
1082017-07-25T08:11:28 *** iglobalvn has quit IRC
1092017-07-25T08:18:45 <jonasschnelli> Is that comment correct? https://github.com/bitcoin/bitcoin/blob/master/src/validationinterface.h#L53 ( BlueMatt )
1102017-07-25T08:18:56 <jonasschnelli> Signal gets fired here: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3187
1112017-07-25T08:21:32 <jonasschnelli> If you request blocks B, C, D while your tip is A, then all three blocks (B, C, D, regardless of the order) would pass and be trigger the BlockChecked() signal
1122017-07-25T08:25:08 *** J-wolf has quit IRC
1132017-07-25T08:25:36 *** J-wolf has joined #bitcoin-core-dev
1142017-07-25T08:30:07 *** J-wolf has quit IRC
1152017-07-25T08:30:21 *** J-wolf has joined #bitcoin-core-dev
1162017-07-25T08:30:47 *** Guest11189 has quit IRC
1172017-07-25T08:34:38 *** mr_burdell has joined #bitcoin-core-dev
1182017-07-25T08:34:38 *** mr_burdell has joined #bitcoin-core-dev
1192017-07-25T08:34:57 *** arubi has quit IRC
1202017-07-25T08:37:52 *** str4d has joined #bitcoin-core-dev
1212017-07-25T08:38:51 *** arubi has joined #bitcoin-core-dev
1222017-07-25T08:42:04 *** J-wolf has quit IRC
1232017-07-25T08:42:36 *** J-wolf has joined #bitcoin-core-dev
1242017-07-25T08:47:13 *** J-wolf has quit IRC
1252017-07-25T08:52:41 *** JackH has joined #bitcoin-core-dev
1262017-07-25T09:10:48 *** praxeology has left #bitcoin-core-dev
1272017-07-25T09:16:17 *** SopaXorzTaker has joined #bitcoin-core-dev
1282017-07-25T09:58:46 *** ill has quit IRC
1292017-07-25T10:00:57 <jonasschnelli> sipa: regarding the CChain object for headers, how to efficiently replace the GetDepthInMainChain in SPV mode?
1302017-07-25T10:01:23 <jonasschnelli> There is a chainActive->Contains(pindex) check in GetDepthInMainChain
1312017-07-25T10:01:55 <jonasschnelli> (which basically is a vector::[] access)
1322017-07-25T10:02:16 <jonasschnelli> without a CChain object this seems to be very inefficient
1332017-07-25T10:02:29 <sipa> jonasschnelli: GetAncestor is log(n)
1342017-07-25T10:03:36 <jonasschnelli> sipa: I see, GetAncestor also uses the pskip
1352017-07-25T10:03:45 <sipa> yes
1362017-07-25T10:03:47 <jonasschnelli> So replacing Contains() with GetAncestor() seems okayish?
1372017-07-25T10:04:07 <sipa> i believe so
1382017-07-25T10:04:14 <jonasschnelli> Okay. Let me benchmark then. Thanks!
1392017-07-25T10:04:58 *** promag has joined #bitcoin-core-dev
1402017-07-25T10:11:17 *** dabura667 has quit IRC
1412017-07-25T10:23:22 <jonasschnelli> sipa: is then the assumption 'chainActive.Tip().GetAncestor(otherBlockIndex.nHeight()) == chainActive.Contains(otherBlockIndex)' correct?
1422017-07-25T10:25:16 <sipa> jonasschnelli: yes
1432017-07-25T10:25:24 <jonasschnelli> Thanks
1442017-07-25T10:37:19 <bitcoin-git> [bitcoin] kore90 opened pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
1452017-07-25T10:38:44 <bitcoin-git> [bitcoin] fanquake closed pull request #10925: bitcoin adder (master...release) https://github.com/bitcoin/bitcoin/pull/10925
1462017-07-25T10:39:12 *** tiagotrs_ has joined #bitcoin-core-dev
1472017-07-25T10:44:06 *** tiagotrs_ has quit IRC
1482017-07-25T10:57:25 <promag> could we have some convention regarding commit messages and PR titles? for instance, prefix with "foo: " or "[foo] " and so on
1492017-07-25T10:58:10 <promag> I know it's not that important, but consistency is nice
1502017-07-25T10:59:28 <sipa> it's a balance between consistency and having people be annoyed at having too many rules :)
1512017-07-25T11:02:19 *** AaronvanW has joined #bitcoin-core-dev
1522017-07-25T11:04:04 *** Aaronvan_ has quit IRC
1532017-07-25T11:09:12 *** Guyver2 has joined #bitcoin-core-dev
1542017-07-25T11:11:03 <luke-jr> promag: I always use "foo: "
1552017-07-25T11:26:01 *** d9b4bef9 has quit IRC
1562017-07-25T11:27:07 *** d9b4bef9 has joined #bitcoin-core-dev
1572017-07-25T11:32:01 <wumpus> I also use foo:, but I don't care what you use
1582017-07-25T11:32:20 <wumpus> (foo: is the same as kernel/mesa so I can't forget that)
1592017-07-25T11:34:09 <jonasschnelli> sipa If use [foo]... but obviously foo: is more pure text conform.
1602017-07-25T11:34:24 <jonasschnelli> (sorry for the wrong highlight)
1612017-07-25T11:34:37 <jonasschnelli> * I use
1622017-07-25T11:35:07 <sipa> we should encourage html3 tags in commit titles
1632017-07-25T11:36:02 <sipa> improve readability on <blink>800x600</blink> resolution!
1642017-07-25T11:36:24 <wumpus> commit stylesheet extensions
1652017-07-25T11:37:38 <instagibbs> commit messages should always be rendered in comic sans
1662017-07-25T11:37:52 <wumpus> color: #ff0000;
1672017-07-25T11:38:32 <wumpus> instagibbs: at the least in large, friendly letters
1682017-07-25T11:39:32 * sipa mentally sees a "DON'T PANIC" now
1692017-07-25T11:39:58 <wumpus> sipa: seems your latest change to 10526 made things better, repeated the test 3 times, FWIW all three times it had done the cleanup
1702017-07-25T11:40:33 <wumpus> will let it run a few more times just to be sure
1712017-07-25T11:40:51 <sipa> wumpus: great... aybe we shouldn't bother running the intermediate compactions?
1722017-07-25T11:41:11 <sipa> the hooe was that during the uograde process the disk usage wouldn't double
1732017-07-25T11:41:17 <sipa> but it does not seem to have that effect
1742017-07-25T11:42:30 <wumpus> I guess trying doesn't hurt either
1752017-07-25T11:43:40 <wumpus> maybe it sometimes works, sometimes doesn't, depending on how the records happen to be distributed on disk
1762017-07-25T11:44:53 *** JackH has quit IRC
1772017-07-25T11:45:11 <promag> lol ok
1782017-07-25T11:46:56 <wumpus> though I don't know the effect on performance
1792017-07-25T11:47:13 *** JackH has joined #bitcoin-core-dev
1802017-07-25T11:47:18 <wumpus> bleh, this time it was 4.5G
1812017-07-25T11:47:35 <wumpus> so no, it's still not entirely reliable
1822017-07-25T11:47:48 <wumpus> (and this is starting with exactly the same database every time!)
1832017-07-25T11:48:15 <sipa> but it does shrink after restart?
1842017-07-25T11:48:22 <wumpus> yes
1852017-07-25T11:49:17 <sipa> that's something at least, i guess
1862017-07-25T11:49:20 <wumpus> it eventually catches on and compacts, but it doesn't seem to be deterministic
1872017-07-25T11:49:58 <wumpus> (well, it always has done so at the next run, up until now)
1882017-07-25T11:51:53 <wumpus> monitoring disk usage *during* the process might be interesting too, to see when it does the compaction, but meh
1892017-07-25T11:52:31 <sipa> yeah
1902017-07-25T11:56:00 <luke-jr> â[11:39:32] â* âsipaââ mentally sees a "DON'T PANIC" now <-- I noticed Android likes to capitalise "Don't Panic" when the words appear in that order.
1912017-07-25T11:57:08 <bitcoin-git> [bitcoin] laanwj closed pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
1922017-07-25T11:57:23 <bitcoin-git> [bitcoin] laanwj closed pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
1932017-07-25T11:58:35 *** promag has quit IRC
1942017-07-25T12:01:04 *** BashCo has quit IRC
1952017-07-25T12:01:49 *** BashCo has joined #bitcoin-core-dev
1962017-07-25T12:07:36 *** J-wolf has joined #bitcoin-core-dev
1972017-07-25T12:08:41 <luke-jr> I guess we should probably remove the systemd file altogether if nobody wants to maintain it
1982017-07-25T12:11:21 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1124328ad1e8...412b466d11ff
1992017-07-25T12:11:21 <bitcoin-git> bitcoin/master 9737572 Jonas Schnelli: [Qt] Use wallet 0 in rpc console if running with multiple wallets
2002017-07-25T12:11:22 <bitcoin-git> bitcoin/master 412b466 Wladimir J. van der Laan: Merge #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets...
2012017-07-25T12:11:39 <wumpus> well for both proposed changes there is no agreement, keeping the PR open for months doesn't help
2022017-07-25T12:11:51 <bitcoin-git> [bitcoin] laanwj closed pull request #10870: [Qt] Use wallet 0 in rpc console if running with multiple wallets (master...2017/07/qt_mw) https://github.com/bitcoin/bitcoin/pull/10870
2032017-07-25T12:11:55 <wumpus> not sure that having no example is better, but it can't accomodate everyone
2042017-07-25T12:16:13 <wumpus> I know nothing about systemd configuration files, so I can't help there at least
2052017-07-25T12:17:02 *** J-wolf has quit IRC
2062017-07-25T12:17:31 <bitcoin-git> [bitcoin] laanwj closed pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
2072017-07-25T12:22:38 *** elias19r has joined #bitcoin-core-dev
2082017-07-25T12:23:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/412b466d11ff...1caafa6cde3b
2092017-07-25T12:23:46 <bitcoin-git> bitcoin/master 4f92b5f Russell Yanofsky: Run Qt wallet tests on travis...
2102017-07-25T12:23:47 <bitcoin-git> bitcoin/master 1caafa6 Wladimir J. van der Laan: Merge #10508: Run Qt wallet tests on travis...
2112017-07-25T12:24:06 <bitcoin-git> [bitcoin] laanwj closed pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
2122017-07-25T12:24:06 <luke-jr> wumpus: 10529 sounded like the current one is just broken IIRC
2132017-07-25T12:26:27 <wumpus> ok, reopening then
2142017-07-25T12:26:43 <bitcoin-git> [bitcoin] laanwj reopened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
2152017-07-25T12:45:57 <bitcoin-git> [bitcoin] laanwj opened pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
2162017-07-25T13:07:35 *** arubi has quit IRC
2172017-07-25T13:09:17 *** arubi has joined #bitcoin-core-dev
2182017-07-25T13:10:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2192017-07-25T13:16:17 *** ula has quit IRC
2202017-07-25T13:23:26 *** miknotauro has quit IRC
2212017-07-25T13:25:35 *** goatpig has joined #bitcoin-core-dev
2222017-07-25T13:31:05 *** str4d has quit IRC
2232017-07-25T13:33:38 *** rjak2 has joined #bitcoin-core-dev
2242017-07-25T13:33:38 *** rjak has quit IRC
2252017-07-25T13:33:56 *** rjak2 is now known as rjak
2262017-07-25T13:34:31 *** moctos_ has joined #bitcoin-core-dev
2272017-07-25T13:34:32 *** PaulCape_ has joined #bitcoin-core-dev
2282017-07-25T13:35:01 *** PaulCapestany has quit IRC
2292017-07-25T13:35:02 *** moctos has quit IRC
2302017-07-25T13:35:02 *** rafalcpp has quit IRC
2312017-07-25T13:35:14 *** phantomcircuit has quit IRC
2322017-07-25T13:35:24 *** johnpark_pj has quit IRC
2332017-07-25T13:36:32 *** johnpark_pj has joined #bitcoin-core-dev
2342017-07-25T13:36:33 *** rafalcpp has joined #bitcoin-core-dev
2352017-07-25T13:36:39 *** phantomcircuit has joined #bitcoin-core-dev
2362017-07-25T13:37:33 *** MarcoFalke has quit IRC
2372017-07-25T13:37:40 *** MarcoFalke has joined #bitcoin-core-dev
2382017-07-25T14:01:37 *** Chris_Stewart_5 has quit IRC
2392017-07-25T14:18:34 *** Yogaqueef has joined #bitcoin-core-dev
2402017-07-25T14:37:31 <BlueMatt> jonasschnelli: I believe thats still "correct", no?
2412017-07-25T14:37:48 <BlueMatt> jonasschnelli: though the comment may only be correct after its moved to a background thread
2422017-07-25T14:39:12 <BlueMatt> jonasschnelli: oh, i see your confusion, no, what you want to look at is https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L2197
2432017-07-25T14:39:33 <BlueMatt> jonasschnelli: the one you linked to is only called if the state is !IsValid()
2442017-07-25T14:43:57 <jonasschnelli> BlueMatt: do you know why its not also called when AcceptBlock does return true?
2452017-07-25T14:44:17 <jonasschnelli> because its also called during ConnectTip() then (called twice)
2462017-07-25T14:44:20 <BlueMatt> jonasschnelli: cause it should only be called once per block
2472017-07-25T14:44:26 <BlueMatt> wait, it shouldnt be?
2482017-07-25T14:44:53 <BlueMatt> jonasschnelli: i think the one you linked to is only AcceptBlock IsInvalid, ie it wasnt even stored on disk
2492017-07-25T14:45:06 <BlueMatt> the ConnectTip one can only fire if AcceptBlock took it
2502017-07-25T14:46:06 <jonasschnelli> i see
2512017-07-25T14:46:16 <BlueMatt> you should double check, but I believe that is correct
2522017-07-25T14:46:20 *** promag has joined #bitcoin-core-dev
2532017-07-25T15:02:29 *** promag has quit IRC
2542017-07-25T15:14:44 *** promag has joined #bitcoin-core-dev
2552017-07-25T15:28:44 <promag> wumpus: please restart job https://travis-ci.org/bitcoin/bitcoin/jobs/257251574
2562017-07-25T15:34:08 <jonasschnelli> promag: done
2572017-07-25T15:34:13 <promag> ty
2582017-07-25T15:36:09 *** elias19r has quit IRC
2592017-07-25T15:37:24 <promag> if (foobar) vs if (foobar != nullptr) vs if (foobar != NULL) ?
2602017-07-25T15:37:33 <promag> don't ban me.. :P
2612017-07-25T15:38:09 <promag> looking the code the most frequent is the 1st..
2622017-07-25T15:40:48 *** Dojixo has joined #bitcoin-core-dev
2632017-07-25T15:47:44 *** jannes has quit IRC
2642017-07-25T15:48:06 *** Dojixo has quit IRC
2652017-07-25T15:48:39 *** Dojixo has joined #bitcoin-core-dev
2662017-07-25T15:51:51 *** Dizzle has joined #bitcoin-core-dev
2672017-07-25T15:57:52 *** ElDojixo has joined #bitcoin-core-dev
2682017-07-25T15:58:57 *** ElDojixo has joined #bitcoin-core-dev
2692017-07-25T15:59:11 *** jannes has joined #bitcoin-core-dev
2702017-07-25T15:59:42 *** ElDojixo has quit IRC
2712017-07-25T16:00:19 *** Dojixo has quit IRC
2722017-07-25T16:00:42 *** Dojixo has joined #bitcoin-core-dev
2732017-07-25T16:01:27 *** BashCo has quit IRC
2742017-07-25T16:02:04 *** BashCo has joined #bitcoin-core-dev
2752017-07-25T16:02:13 *** wasi has quit IRC
2762017-07-25T16:04:39 *** Aaronvan_ has joined #bitcoin-core-dev
2772017-07-25T16:06:29 *** Dojixo has quit IRC
2782017-07-25T16:06:37 *** AaronvanW has quit IRC
2792017-07-25T16:08:17 *** timothy has quit IRC
2802017-07-25T16:09:19 *** jamesob_ has joined #bitcoin-core-dev
2812017-07-25T16:09:24 *** Dojixo has joined #bitcoin-core-dev
2822017-07-25T16:09:53 *** spinza has quit IRC
2832017-07-25T16:14:02 *** jamesob_ has quit IRC
2842017-07-25T16:14:27 *** Dojixo has quit IRC
2852017-07-25T16:14:31 *** ElDojixo has joined #bitcoin-core-dev
2862017-07-25T16:16:14 *** baldur has quit IRC
2872017-07-25T16:16:53 *** promag has quit IRC
2882017-07-25T16:20:41 *** ula has joined #bitcoin-core-dev
2892017-07-25T16:30:03 *** ElDojixo has quit IRC
2902017-07-25T16:30:19 *** ElDojixo has joined #bitcoin-core-dev
2912017-07-25T16:31:05 *** ElDojixo is now known as Dojixo
2922017-07-25T16:32:36 *** ElDojixo has joined #bitcoin-core-dev
2932017-07-25T16:32:43 *** ElDojixo has quit IRC
2942017-07-25T16:33:01 *** ElDojixo has joined #bitcoin-core-dev
2952017-07-25T16:33:37 *** Dyaheon has quit IRC
2962017-07-25T16:33:59 *** Dyaheon has joined #bitcoin-core-dev
2972017-07-25T16:36:41 *** Dojixo has quit IRC
2982017-07-25T16:36:42 *** spinza has joined #bitcoin-core-dev
2992017-07-25T16:36:43 *** kanzure has quit IRC
3002017-07-25T16:38:21 *** ElDojixo is now known as Dojixo
3012017-07-25T16:39:32 *** MarcoFalke has quit IRC
3022017-07-25T16:39:40 *** MarcoFalke has joined #bitcoin-core-dev
3032017-07-25T16:41:43 *** Dojixo has quit IRC
3042017-07-25T16:42:04 *** Dojixo has joined #bitcoin-core-dev
3052017-07-25T16:42:36 *** kanzure has joined #bitcoin-core-dev
3062017-07-25T16:44:28 *** Dojixo has quit IRC
3072017-07-25T16:44:42 *** kanzure is now known as 07EABCRRW
3082017-07-25T16:44:42 *** spinza has quit IRC
3092017-07-25T16:45:54 *** Dojixo has joined #bitcoin-core-dev
3102017-07-25T16:46:00 *** elias19r_ has joined #bitcoin-core-dev
3112017-07-25T16:46:25 *** kanzure has joined #bitcoin-core-dev
3122017-07-25T16:46:47 *** 07EABCRRW has quit IRC
3132017-07-25T16:47:06 *** kanzure has quit IRC
3142017-07-25T16:47:53 *** kanzure has joined #bitcoin-core-dev
3152017-07-25T16:54:37 *** spinza has joined #bitcoin-core-dev
3162017-07-25T16:55:06 *** cheese_ has joined #bitcoin-core-dev
3172017-07-25T17:02:04 *** elias19r_ has quit IRC
3182017-07-25T17:05:05 *** Dojixo has quit IRC
3192017-07-25T17:05:18 *** Dojixo has joined #bitcoin-core-dev
3202017-07-25T17:05:22 *** Murch has joined #bitcoin-core-dev
3212017-07-25T17:05:28 *** jamesob has joined #bitcoin-core-dev
3222017-07-25T17:09:59 *** Dojixo has quit IRC
3232017-07-25T17:10:06 *** Dojixo has joined #bitcoin-core-dev
3242017-07-25T17:11:27 *** tucenaber has quit IRC
3252017-07-25T17:13:00 *** fizzwont_ has joined #bitcoin-core-dev
3262017-07-25T17:13:21 *** fizzwont has quit IRC
3272017-07-25T17:15:29 *** jamesob_ has joined #bitcoin-core-dev
3282017-07-25T17:16:22 *** tucenaber has joined #bitcoin-core-dev
3292017-07-25T17:16:27 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3302017-07-25T17:23:46 *** elias19r has joined #bitcoin-core-dev
3312017-07-25T17:24:35 *** Chris_Stewart_5 has quit IRC
3322017-07-25T17:26:24 *** Dojixo has quit IRC
3332017-07-25T17:30:20 *** elias19r has left #bitcoin-core-dev
3342017-07-25T17:33:54 *** eck has quit IRC
3352017-07-25T17:34:57 *** eck has joined #bitcoin-core-dev
3362017-07-25T17:46:36 *** J-wolf has joined #bitcoin-core-dev
3372017-07-25T17:48:55 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3382017-07-25T17:56:05 *** Chris_Stewart_5 has quit IRC
3392017-07-25T18:01:02 *** elias19r has joined #bitcoin-core-dev
3402017-07-25T18:01:19 *** J-wolf has quit IRC
3412017-07-25T18:03:29 *** elias19r has left #bitcoin-core-dev
3422017-07-25T18:07:40 *** AMaisLeveBrisa has quit IRC
3432017-07-25T18:12:18 *** felco has joined #bitcoin-core-dev
3442017-07-25T18:13:19 *** baldur has joined #bitcoin-core-dev
3452017-07-25T18:18:36 <BlueMatt> things that (probably) need a 15 tag: 10914, 10799
3462017-07-25T18:25:04 *** miknotauro has joined #bitcoin-core-dev
3472017-07-25T18:33:51 *** fizzwont_ is now known as fizzwont
3482017-07-25T18:33:57 *** fizzwont has joined #bitcoin-core-dev
3492017-07-25T18:44:55 *** elias19r has joined #bitcoin-core-dev
3502017-07-25T18:47:40 *** jifenglei has quit IRC
3512017-07-25T18:49:05 *** miknotauro has quit IRC
3522017-07-25T18:49:43 *** chjj has quit IRC
3532017-07-25T18:49:58 *** jamesob has quit IRC
3542017-07-25T19:01:17 *** Guyver2 has quit IRC
3552017-07-25T19:02:31 *** chjj has joined #bitcoin-core-dev
3562017-07-25T19:08:17 *** cryptapus has joined #bitcoin-core-dev
3572017-07-25T19:08:17 *** cryptapus has joined #bitcoin-core-dev
3582017-07-25T19:08:43 *** cryptapus_afk has quit IRC
3592017-07-25T19:14:04 *** chjj has quit IRC
3602017-07-25T19:19:49 *** cryptapus is now known as cryptapus_afk
3612017-07-25T19:24:18 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1caafa6cde3b...f1f1605c22a6
3622017-07-25T19:24:19 <bitcoin-git> bitcoin/master d64ac3f Jonas Schnelli: [tests] Allow tests to pass when stderr is non-empty...
3632017-07-25T19:24:19 <bitcoin-git> bitcoin/master f1f1605 MarcoFalke: Merge #10703: [tests] Allow tests to pass when stderr is non-empty...
3642017-07-25T19:24:44 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10703: [tests] Allow tests to pass when stderr is non-empty (master...test_stderr) https://github.com/bitcoin/bitcoin/pull/10703
3652017-07-25T19:26:12 <gmaxwell> ^ that means we can't use tsan with tests anymore, no?
3662017-07-25T19:27:03 <wumpus> is that so? why don't you reply that on the PR instead of after it is merged?
3672017-07-25T19:27:05 *** chjj has joined #bitcoin-core-dev
3682017-07-25T19:27:28 <wumpus> I don't see why though, tests can still print things to stderr, it just won't cause them to fail
3692017-07-25T19:28:12 <wumpus> apparently #10882 (which has 0.15 milestone) was depending on it
3702017-07-25T19:28:14 <gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
3712017-07-25T19:29:42 <gmaxwell> wumpus: because you commented on it on the original pr, and I hadn't seen the second.
3722017-07-25T19:29:54 <wumpus> it introduces a "passed with warnings" result if a test succeeds but prints to stderr
3732017-07-25T19:29:54 <BlueMatt> gmaxwell: it still prints "Passed with warnings"
3742017-07-25T19:29:57 <wumpus> seems good enough to me
3752017-07-25T19:30:01 <BlueMatt> so you can see it
3762017-07-25T19:30:01 <wumpus> no need to panic
3772017-07-25T19:30:07 <gmaxwell> that wasn't a panic.
3782017-07-25T19:31:00 <gmaxwell> it was a question, seems you've answered it. though I'm concerned that passed with warnings will become the normal state since travis won't reject it. Can someone explain the need for this to me?
3792017-07-25T19:31:04 <BlueMatt> no, what my gpu makes my kernel do is a panic :(
3802017-07-25T19:32:03 <BlueMatt> gmaxwell: i have to assume cause the keypool topup thing prints warnings that you need to top up your keypool? dunno, havent had a chance to review that one yet
3812017-07-25T19:32:03 <gmaxwell> litterally the PR says "not sure how much people want this" and the original PR has no description at all beyond the title.
3822017-07-25T19:32:20 <wumpus> <wumpus> apparently #10882 (which has 0.15 milestone) was depending on it
3832017-07-25T19:32:22 <gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
3842017-07-25T19:32:28 <BlueMatt> ryanofsky or jnewbery may know
3852017-07-25T19:32:31 <wumpus> that's why it was merged
3862017-07-25T19:33:24 <ryanofsky> i'm actually not sure the reason for the dependency
3872017-07-25T19:33:29 <BlueMatt> heh, really shit time for everyone to be in japan
3882017-07-25T19:33:42 <wumpus> anyhow if tests don't succeed they shouldn't return success
3892017-07-25T19:34:25 <gmaxwell> BlueMatt: if so, then does that mean it'll always print that.. in which case, the warnings notice is not useful.
3902017-07-25T19:34:52 <BlueMatt> gmaxwell: ok, lets wait till jnewbery can come back and answer :)
3912017-07-25T19:34:53 <ryanofsky> yeah, that seems reasonable. maybe just revert the change and we can ask john about it to see if there's a better solution
3922017-07-25T19:34:53 <wumpus> revert it then?
3932017-07-25T19:35:06 <ryanofsky> sound good to me
3942017-07-25T19:35:07 <BlueMatt> or just wait till we get an answer
3952017-07-25T19:35:11 <BlueMatt> or...whatever, i dont care
3962017-07-25T19:35:18 <wumpus> I don't, either
3972017-07-25T19:35:24 <ryanofsky> me either
3982017-07-25T19:36:57 <gmaxwell> wumpus: in terms of the test passing, the tests still pass the the sanitizers print important notices that things have gone wrong... they've helped us find a lot of serious bugs, if there is a good reason for making changes that indirectly hobble them; okay. But I am completely clueless as to why this change is desirable, and the PRs did not justify it, AFAICT (though it's fully possibly I'm mis
3992017-07-25T19:37:01 <wumpus> can we now go back to discussing things before they are merged, instead of after?
4002017-07-25T19:37:03 <gmaxwell> sing something).
4012017-07-25T19:37:39 <wumpus> gmaxwell: I don't feel like defending the change at all
4022017-07-25T19:37:46 *** cluelessperson has joined #bitcoin-core-dev
4032017-07-25T19:37:58 <wumpus> afaik I didn't even comment on it
4042017-07-25T19:38:20 <wumpus> oh I did on the previous one, months ago
4052017-07-25T19:38:24 <gmaxwell> wumpus: you commented on the earlier on, first comment, raising the sanitizer compatiblity concern.
4062017-07-25T19:38:25 *** jannes has quit IRC
4072017-07-25T19:38:35 <wumpus> yep
4082017-07-25T19:39:00 <wumpus> ok, reverting it then, seems clearly a misunderstanding
4092017-07-25T19:39:18 <gmaxwell> Thanks.
4102017-07-25T19:48:27 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/60f9778abfea615beac384a08e6a13ebec65275b
4112017-07-25T19:48:28 <bitcoin-git> bitcoin/master 60f9778 Wladimir J. van der Laan: Revert "[tests] Allow tests to pass when stderr is non-empty"...
4122017-07-25T19:54:14 *** J-wolf has joined #bitcoin-core-dev
4132017-07-25T19:57:08 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60f9778abfea...9d5e8f92a7db
4142017-07-25T19:57:08 <bitcoin-git> bitcoin/master 88af227 Wladimir J. van der Laan: test: Make sure wallet.backup is created in temp path...
4152017-07-25T19:57:09 <bitcoin-git> bitcoin/master 9d5e8f9 Wladimir J. van der Laan: Merge #10927: test: Make sure wallet.backup is created in temp path...
4162017-07-25T19:57:43 <bitcoin-git> [bitcoin] laanwj closed pull request #10927: test: Make sure wallet.backup is created in temp path (master...2017_07_wallet_backup_temp_path) https://github.com/bitcoin/bitcoin/pull/10927
4172017-07-25T20:01:01 *** BashCo has quit IRC
4182017-07-25T20:01:39 *** BashCo has joined #bitcoin-core-dev
4192017-07-25T20:03:22 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d5e8f92a7db...8537187d4213
4202017-07-25T20:03:22 <bitcoin-git> bitcoin/master 99c7fc3 Matt Corallo: Prevent user from specifying conflicting parameters to fundrawtx...
4212017-07-25T20:03:23 <bitcoin-git> bitcoin/master 8537187 Wladimir J. van der Laan: Merge #10799: Prevent user from specifying conflicting parameters to fundrawtx...
4222017-07-25T20:03:51 <bitcoin-git> [bitcoin] laanwj closed pull request #10799: Prevent user from specifying conflicting parameters to fundrawtx (master...2017-07-no-fundraw-conflicts) https://github.com/bitcoin/bitcoin/pull/10799
4232017-07-25T20:15:49 *** chjj has quit IRC
4242017-07-25T20:15:56 *** promag has joined #bitcoin-core-dev
4252017-07-25T20:19:20 *** TD-Linux has quit IRC
4262017-07-25T20:21:12 *** TD-Linux has joined #bitcoin-core-dev
4272017-07-25T20:24:37 *** cryptapus_afk has quit IRC
4282017-07-25T20:26:33 *** cryptapus has joined #bitcoin-core-dev
4292017-07-25T20:26:38 *** cryptapus is now known as cryptapus_afk
4302017-07-25T20:28:36 *** chjj has joined #bitcoin-core-dev
4312017-07-25T20:36:47 *** chjj has quit IRC
4322017-07-25T20:36:52 *** Dyaheon has quit IRC
4332017-07-25T20:37:45 *** J-wolf has quit IRC
4342017-07-25T20:38:40 *** Dyaheon has joined #bitcoin-core-dev
4352017-07-25T20:48:35 *** chjj has joined #bitcoin-core-dev
4362017-07-25T20:55:04 <MarcoFalke> Sorry, I missed the discussion about the stderr thing. Agree that it should be reverted.
4372017-07-25T20:55:19 <MarcoFalke> Best is to apply it specifically only where needed
4382017-07-25T20:55:27 <MarcoFalke> Instead of per default for all tests
4392017-07-25T20:58:19 <MarcoFalke> The exact error message ("Number of keys in keypool is below critical minimum") can even be checked when piped into a SpooledTemporaryFile
4402017-07-25T20:59:11 <promag> should we disallow wallet files being symlinks?
4412017-07-25T21:05:06 <gmaxwell> MarcoFalke: yea, I think we should have a specific test for that error, since its intentional functionality.
4422017-07-25T21:05:30 *** jamesob has joined #bitcoin-core-dev
4432017-07-25T21:05:58 <MarcoFalke> We already had those issues that the specific error was not tested against. And run into issues...
4442017-07-25T21:06:02 <MarcoFalke> Not worth repeating
4452017-07-25T21:06:14 <MarcoFalke> Thanks for raising the concern quickly, gmaxwell
4462017-07-25T21:07:18 <gmaxwell> No problem, I think I didn't see the new PR because I confused it for the old one or something.
4472017-07-25T21:07:37 *** jamesob_ has quit IRC
4482017-07-25T21:08:00 *** Yogaqueef has quit IRC
4492017-07-25T21:08:30 <MarcoFalke> too much going. I only keep up with pulls after they are merged atm
4502017-07-25T21:09:16 <MarcoFalke> jnewbery: Let me know if there are any test pulls I should look at with priority
4512017-07-25T21:13:30 *** Murch has quit IRC
4522017-07-25T21:17:45 *** elias19r has quit IRC
4532017-07-25T21:18:14 *** elias19r has joined #bitcoin-core-dev
4542017-07-25T21:41:04 *** chjj has quit IRC
4552017-07-25T21:47:20 <instagibbs> assuming no priority, how does the miner select between two identical feerate transactions if it has to choose between the two?
4562017-07-25T21:48:49 <gmaxwell> instagibbs: whatever comes up first out of the index.
4572017-07-25T21:50:51 <instagibbs> well, yeah :) I guess the answer is "no particular ordering"
4582017-07-25T21:53:41 *** chjj has joined #bitcoin-core-dev
4592017-07-25T22:03:09 *** chjj has quit IRC
4602017-07-25T22:10:10 *** jeep-ss has joined #bitcoin-core-dev
4612017-07-25T22:16:27 *** chjj has joined #bitcoin-core-dev
4622017-07-25T22:21:10 *** chjj has quit IRC
4632017-07-25T22:21:22 *** d_t has quit IRC
4642017-07-25T22:21:49 *** BashCo has quit IRC
4652017-07-25T22:22:27 *** BashCo has joined #bitcoin-core-dev
4662017-07-25T22:26:43 *** BashCo has quit IRC
4672017-07-25T22:27:20 *** Cory has quit IRC
4682017-07-25T22:34:11 *** Cory has joined #bitcoin-core-dev
4692017-07-25T22:34:53 *** chjj has joined #bitcoin-core-dev
4702017-07-25T22:39:54 *** JackH has quit IRC
4712017-07-25T22:40:19 *** d_t has joined #bitcoin-core-dev
4722017-07-25T22:40:28 *** JackH has joined #bitcoin-core-dev
4732017-07-25T22:44:13 *** Dizzle has quit IRC
4742017-07-25T22:52:10 *** chjj has quit IRC
4752017-07-25T22:52:52 *** d_t has quit IRC
4762017-07-25T23:00:59 <gmaxwell> I updated my banlists: https://people.xiph.org/~greg/banlist.cli.txt https://people.xiph.org/~greg/banlist.gui.txt
4772017-07-25T23:01:03 *** J-wolf has joined #bitcoin-core-dev
4782017-07-25T23:03:22 *** J-wolf has quit IRC
4792017-07-25T23:03:24 *** J-wolf_ has joined #bitcoin-core-dev
4802017-07-25T23:04:52 *** chjj has joined #bitcoin-core-dev
4812017-07-25T23:06:19 *** J-wolf has joined #bitcoin-core-dev
4822017-07-25T23:06:34 *** J-wolf_ has quit IRC
4832017-07-25T23:07:54 *** NewLiberty_ has joined #bitcoin-core-dev
4842017-07-25T23:08:47 *** J-wolf has quit IRC
4852017-07-25T23:11:05 *** cheese_ has quit IRC
4862017-07-25T23:11:25 *** NewLiberty has quit IRC
4872017-07-25T23:11:32 *** vicenteH has quit IRC
4882017-07-25T23:14:53 *** J-wolf has joined #bitcoin-core-dev
4892017-07-25T23:15:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4902017-07-25T23:16:46 *** elias19r has left #bitcoin-core-dev
4912017-07-25T23:17:04 *** J-wolf has quit IRC
4922017-07-25T23:17:43 *** J-wolf has joined #bitcoin-core-dev
4932017-07-25T23:20:02 *** J-wolf_ has joined #bitcoin-core-dev
4942017-07-25T23:20:03 *** J-wolf has quit IRC
4952017-07-25T23:20:45 *** ill has joined #bitcoin-core-dev
4962017-07-25T23:21:49 *** chjj has quit IRC
4972017-07-25T23:23:15 *** J-wolf_ has quit IRC
4982017-07-25T23:25:55 *** J-wolf has joined #bitcoin-core-dev
4992017-07-25T23:28:05 *** J-wolf has quit IRC
5002017-07-25T23:33:57 *** J-wolf has joined #bitcoin-core-dev
5012017-07-25T23:34:16 *** chjj has joined #bitcoin-core-dev
5022017-07-25T23:35:04 *** deep-book-gk_ has joined #bitcoin-core-dev
5032017-07-25T23:35:49 *** deep-book-gk_ has left #bitcoin-core-dev
5042017-07-25T23:36:45 *** J-wolf has quit IRC
5052017-07-25T23:36:48 *** J-wolf_ has joined #bitcoin-core-dev
5062017-07-25T23:39:03 *** J-wolf_ has quit IRC
5072017-07-25T23:39:32 *** J-wolf has joined #bitcoin-core-dev
5082017-07-25T23:41:52 *** J-wolf has quit IRC
5092017-07-25T23:45:12 *** J-wolf has joined #bitcoin-core-dev
5102017-07-25T23:47:38 *** J-wolf has quit IRC
5112017-07-25T23:47:52 *** J-wolf has joined #bitcoin-core-dev
5122017-07-25T23:49:59 *** jamesob_ has joined #bitcoin-core-dev
5132017-07-25T23:50:19 *** J-wolf has quit IRC
5142017-07-25T23:50:37 *** J-wolf has joined #bitcoin-core-dev
5152017-07-25T23:51:28 *** jamesob has quit IRC
5162017-07-25T23:53:29 *** J-wolf_ has joined #bitcoin-core-dev
5172017-07-25T23:54:52 *** J-wolf has quit IRC
5182017-07-25T23:56:06 *** J-wolf_ has quit IRC
5192017-07-25T23:56:13 *** J-wolf has joined #bitcoin-core-dev
5202017-07-25T23:58:35 *** J-wolf has quit IRC