12017-08-11T00:03:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  22017-08-11T00:14:14  <bitcoin-git> [bitcoin] sipa opened pull request #11028: Avoid masking of difficulty adjustment errors by checkpoints (master...20170810_maskpow) https://github.com/bitcoin/bitcoin/pull/11028
  32017-08-11T00:19:10  *** jimpo has quit IRC
  42017-08-11T00:35:10  *** Chris_Stewart_5 has quit IRC
  52017-08-11T00:42:48  *** chjj has quit IRC
  62017-08-11T01:16:05  *** dermoth has quit IRC
  72017-08-11T01:30:01  *** Murch has quit IRC
  82017-08-11T01:32:34  *** dermoth has joined #bitcoin-core-dev
  92017-08-11T01:36:24  *** dcousens has joined #bitcoin-core-dev
 102017-08-11T01:49:35  *** Austindoggie has joined #bitcoin-core-dev
 112017-08-11T02:03:31  *** tunafizz has quit IRC
 122017-08-11T02:10:34  *** clarkmoody_ has joined #bitcoin-core-dev
 132017-08-11T02:11:24  *** LeMiner2 has joined #bitcoin-core-dev
 142017-08-11T02:11:26  *** elkalamar_ has joined #bitcoin-core-dev
 152017-08-11T02:13:29  *** cryptapus has joined #bitcoin-core-dev
 162017-08-11T02:13:30  *** cryptapus has joined #bitcoin-core-dev
 172017-08-11T02:17:15  *** aj__ has joined #bitcoin-core-dev
 182017-08-11T02:18:33  *** chjj has joined #bitcoin-core-dev
 192017-08-11T02:18:46  *** arowser_ has joined #bitcoin-core-dev
 202017-08-11T02:18:48  *** chjj has quit IRC
 212017-08-11T02:18:54  *** cryptapus_afk has quit IRC
 222017-08-11T02:18:54  *** LeMiner has quit IRC
 232017-08-11T02:18:55  *** LeMiner has joined #bitcoin-core-dev
 242017-08-11T02:18:55  *** LeMiner has joined #bitcoin-core-dev
 252017-08-11T02:18:55  *** clarkmoody has quit IRC
 262017-08-11T02:18:55  *** elkalamar has quit IRC
 272017-08-11T02:18:56  *** marcoagner has quit IRC
 282017-08-11T02:18:56  *** LeMiner2 has quit IRC
 292017-08-11T02:18:56  *** arowser has quit IRC
 302017-08-11T02:18:56  *** Lauda has quit IRC
 312017-08-11T02:18:56  *** Orion3k has quit IRC
 322017-08-11T02:18:56  *** Anduck has quit IRC
 332017-08-11T02:18:56  *** Dyaheon has quit IRC
 342017-08-11T02:18:56  *** SkynetS has quit IRC
 352017-08-11T02:18:57  *** LeMiner has quit IRC
 362017-08-11T02:18:57  *** Evel-Knievel has quit IRC
 372017-08-11T02:19:04  *** Anduck has joined #bitcoin-core-dev
 382017-08-11T02:19:13  *** Evel-Knievel has joined #bitcoin-core-dev
 392017-08-11T02:19:19  *** Dyaheon has joined #bitcoin-core-dev
 402017-08-11T02:19:40  *** chjj has joined #bitcoin-core-dev
 412017-08-11T02:19:46  *** Lauda has joined #bitcoin-core-dev
 422017-08-11T02:19:57  *** dcousens_ has joined #bitcoin-core-dev
 432017-08-11T02:24:05  *** TD--Linux has joined #bitcoin-core-dev
 442017-08-11T02:24:33  *** Anduck_ has joined #bitcoin-core-dev
 452017-08-11T02:28:15  *** LeMiner has joined #bitcoin-core-dev
 462017-08-11T02:28:16  *** dcousens has quit IRC
 472017-08-11T02:28:16  *** eenoch has quit IRC
 482017-08-11T02:28:16  *** Anduck has quit IRC
 492017-08-11T02:28:16  *** TD-Linux has quit IRC
 502017-08-11T02:28:17  *** LeMiner has quit IRC
 512017-08-11T02:28:17  *** LeMiner has joined #bitcoin-core-dev
 522017-08-11T02:28:17  *** TD--Linux is now known as TD-Linux
 532017-08-11T02:28:17  *** LeMiner has quit IRC
 542017-08-11T02:28:17  *** LeMiner has joined #bitcoin-core-dev
 552017-08-11T02:28:17  *** TD-Linux has quit IRC
 562017-08-11T02:28:17  *** TD-Linux has joined #bitcoin-core-dev
 572017-08-11T02:28:28  *** Orion3k has joined #bitcoin-core-dev
 582017-08-11T02:30:51  *** eenoch has joined #bitcoin-core-dev
 592017-08-11T02:31:00  *** marcoagner has joined #bitcoin-core-dev
 602017-08-11T02:31:32  *** karelb has quit IRC
 612017-08-11T02:46:36  *** jimmysong has joined #bitcoin-core-dev
 622017-08-11T02:57:54  *** HFRadical has joined #bitcoin-core-dev
 632017-08-11T03:03:08  *** HFRadical has quit IRC
 642017-08-11T03:06:21  *** chjj has quit IRC
 652017-08-11T03:10:17  *** chjj has joined #bitcoin-core-dev
 662017-08-11T03:14:06  *** jimmysong has quit IRC
 672017-08-11T03:27:41  *** chjj has quit IRC
 682017-08-11T03:38:34  *** ula has quit IRC
 692017-08-11T03:42:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 702017-08-11T03:47:58  <bitcoin-git> [bitcoin] achow101 closed pull request #10875: BIP 91 deployment parameters (master...bip91-dep-params) https://github.com/bitcoin/bitcoin/pull/10875
 712017-08-11T03:50:31  *** chjj has joined #bitcoin-core-dev
 722017-08-11T03:53:28  *** Chris_Stewart_5 has quit IRC
 732017-08-11T03:54:03  *** sanada has joined #bitcoin-core-dev
 742017-08-11T03:54:20  *** ula has joined #bitcoin-core-dev
 752017-08-11T04:11:05  *** goldstar has quit IRC
 762017-08-11T04:17:40  <bitcoin-git> [bitcoin] FelixWeis opened pull request #11029: [RPC] trivial: gettxout no longer shows version of tx (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11029
 772017-08-11T04:32:22  *** marcoagner has quit IRC
 782017-08-11T04:33:37  *** chjj has quit IRC
 792017-08-11T04:36:21  *** arubi has joined #bitcoin-core-dev
 802017-08-11T04:40:25  *** arubi has quit IRC
 812017-08-11T04:41:27  *** arubi has joined #bitcoin-core-dev
 822017-08-11T04:41:34  *** justanotheruser has joined #bitcoin-core-dev
 832017-08-11T04:43:54  *** marcoagner has joined #bitcoin-core-dev
 842017-08-11T04:51:14  *** arowser_ has quit IRC
 852017-08-11T04:53:28  *** arowser has joined #bitcoin-core-dev
 862017-08-11T05:05:21  *** sam_c has quit IRC
 872017-08-11T05:13:04  *** sam_c has joined #bitcoin-core-dev
 882017-08-11T05:14:38  *** jimmysong has joined #bitcoin-core-dev
 892017-08-11T05:19:05  *** jimmysong has quit IRC
 902017-08-11T05:32:34  *** Austindoggie has quit IRC
 912017-08-11T05:46:44  *** chjj has joined #bitcoin-core-dev
 922017-08-11T06:43:31  *** d_t has quit IRC
 932017-08-11T06:52:29  *** BashCo has quit IRC
 942017-08-11T07:14:35  *** BashCo has joined #bitcoin-core-dev
 952017-08-11T07:28:52  *** justanotheruser has quit IRC
 962017-08-11T07:33:15  *** JackH has joined #bitcoin-core-dev
 972017-08-11T07:35:52  *** timothy has joined #bitcoin-core-dev
 982017-08-11T07:40:04  *** Deacyded has joined #bitcoin-core-dev
 992017-08-11T07:40:28  *** LeMiner has quit IRC
1002017-08-11T07:44:10  *** Deacydal has quit IRC
1012017-08-11T07:55:34  *** justanotheruser has joined #bitcoin-core-dev
1022017-08-11T08:04:45  *** Orion3k has quit IRC
1032017-08-11T08:06:54  *** Yogaqueef has joined #bitcoin-core-dev
1042017-08-11T08:07:34  *** Yogaqueef has quit IRC
1052017-08-11T08:13:39  *** alreadylate has joined #bitcoin-core-dev
1062017-08-11T08:38:36  *** Anduck_ is now known as Anduck
1072017-08-11T08:42:01  *** d9b4bef9 has quit IRC
1082017-08-11T08:43:07  *** d9b4bef9 has joined #bitcoin-core-dev
1092017-08-11T08:44:13  *** vicenteH has joined #bitcoin-core-dev
1102017-08-11T08:46:51  *** vicenteH` has joined #bitcoin-core-dev
1112017-08-11T08:49:32  *** vicenteH has quit IRC
1122017-08-11T08:51:27  *** vicenteH` is now known as vicenteH
1132017-08-11T08:56:06  *** promag has joined #bitcoin-core-dev
1142017-08-11T08:59:10  *** vicenteH has quit IRC
1152017-08-11T08:59:21  *** vicenteH has joined #bitcoin-core-dev
1162017-08-11T09:13:54  *** Guyver2 has joined #bitcoin-core-dev
1172017-08-11T09:16:34  *** jimmysong has joined #bitcoin-core-dev
1182017-08-11T09:21:04  *** jimmysong has quit IRC
1192017-08-11T09:34:25  *** wolfspraul has quit IRC
1202017-08-11T09:34:34  *** wolfspraul has joined #bitcoin-core-dev
1212017-08-11T09:47:41  *** lightningbot has joined #bitcoin-core-dev
1222017-08-11T09:54:59  *** lightningbot has joined #bitcoin-core-dev
1232017-08-11T10:01:50  *** promag has quit IRC
1242017-08-11T10:22:32  *** randy-waterhouse has joined #bitcoin-core-dev
1252017-08-11T10:23:01  *** randy-waterhouse has quit IRC
1262017-08-11T10:23:01  *** randy-waterhouse has joined #bitcoin-core-dev
1272017-08-11T10:37:44  *** btcdrak has quit IRC
1282017-08-11T10:49:00  *** SopaXorzTaker has joined #bitcoin-core-dev
1292017-08-11T10:51:56  *** harrymm has joined #bitcoin-core-dev
1302017-08-11T10:59:50  *** cryptapus is now known as cryptapus_afk
1312017-08-11T11:10:31  *** paveljanik has quit IRC
1322017-08-11T11:12:40  *** Victor_sueca has joined #bitcoin-core-dev
1332017-08-11T11:14:28  *** jimmysong has joined #bitcoin-core-dev
1342017-08-11T11:15:04  *** promag has joined #bitcoin-core-dev
1352017-08-11T11:15:13  *** Victorsueca has quit IRC
1362017-08-11T11:20:52  *** AaronvanW has joined #bitcoin-core-dev
1372017-08-11T11:22:15  *** Aaronvan_ has joined #bitcoin-core-dev
1382017-08-11T11:24:56  *** BashCo has quit IRC
1392017-08-11T11:24:56  *** marcoagner has quit IRC
1402017-08-11T11:24:57  *** eenoch has quit IRC
1412017-08-11T11:26:05  *** AaronvanW has quit IRC
1422017-08-11T11:30:57  *** eenoch has joined #bitcoin-core-dev
1432017-08-11T11:36:39  *** marcoagner has joined #bitcoin-core-dev
1442017-08-11T11:51:37  *** BashCo has joined #bitcoin-core-dev
1452017-08-11T12:19:09  *** rubensayshi has quit IRC
1462017-08-11T12:19:09  *** NicolasDorier has quit IRC
1472017-08-11T12:19:09  *** aspect_ has quit IRC
1482017-08-11T12:19:09  *** jl2012 has quit IRC
1492017-08-11T12:19:23  *** rubensayshi has joined #bitcoin-core-dev
1502017-08-11T12:19:49  *** NicolasDorier has joined #bitcoin-core-dev
1512017-08-11T12:19:52  *** aspect_ has joined #bitcoin-core-dev
1522017-08-11T12:20:10  *** jl2012 has joined #bitcoin-core-dev
1532017-08-11T12:22:04  *** spinza has quit IRC
1542017-08-11T12:30:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1552017-08-11T12:38:12  *** Chris_Stewart_5 has quit IRC
1562017-08-11T12:40:08  *** spinza has joined #bitcoin-core-dev
1572017-08-11T12:46:49  *** randy-waterhouse has quit IRC
1582017-08-11T12:52:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1592017-08-11T12:53:13  *** Victor_sueca has quit IRC
1602017-08-11T12:54:20  *** Victor_sueca has joined #bitcoin-core-dev
1612017-08-11T12:57:09  *** promag has quit IRC
1622017-08-11T13:24:27  *** AaronvanW has joined #bitcoin-core-dev
1632017-08-11T13:25:44  *** Aaronvan_ has quit IRC
1642017-08-11T13:27:36  <luke-jr> so what's with "0.15.SW"? Is the plan for the next release to branch off 0.15 rather than master?
1652017-08-11T13:31:14  *** paveljanik has joined #bitcoin-core-dev
1662017-08-11T13:33:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e526ca6284b9...96a63a3e0cef
1672017-08-11T13:33:39  <bitcoin-git> bitcoin/master 8627946 Felix Weis: [RPC] trivial: gettxout no longer shows version of tx...
1682017-08-11T13:33:40  <bitcoin-git> bitcoin/master 96a63a3 MarcoFalke: Merge #11029: [RPC] trivial: gettxout no longer shows version of tx...
1692017-08-11T13:34:24  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11029: [RPC] trivial: gettxout no longer shows version of tx (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11029
1702017-08-11T13:42:31  *** goldstar has joined #bitcoin-core-dev
1712017-08-11T13:44:36  *** jimmysong has quit IRC
1722017-08-11T13:57:27  *** clarkmoody_ has quit IRC
1732017-08-11T13:57:54  *** jimmysong has joined #bitcoin-core-dev
1742017-08-11T13:57:55  *** clarkmoody has joined #bitcoin-core-dev
1752017-08-11T13:59:07  *** Giszmo has joined #bitcoin-core-dev
1762017-08-11T14:10:57  *** Giszmo has quit IRC
1772017-08-11T14:12:07  <jonasschnelli> I don't entirely understand that check:
1782017-08-11T14:12:07  <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L1655
1792017-08-11T14:12:40  <jonasschnelli> Why do we check 'pindex->nHeight <= chainActive.Tip()->nHeight - nPrunedBlocksLikelyToHave' during pruning when responsing to GETBLOCKS
1802017-08-11T14:13:00  *** Giszmo has joined #bitcoin-core-dev
1812017-08-11T14:13:47  <jonasschnelli> I mean we check for BLOCK_HAVE_DATA, I don't see why we need to check for 'tip - nPrunedBlocksLikelyToHave'
1822017-08-11T14:14:42  <luke-jr> maybe to prevent fingerprinting?
1832017-08-11T14:25:45  <jonasschnelli> Yes. Maybe.
1842017-08-11T14:34:26  *** JackH has quit IRC
1852017-08-11T14:49:41  *** Victor_sueca has quit IRC
1862017-08-11T14:50:41  *** justanotheruser has quit IRC
1872017-08-11T14:50:48  *** Victor_sueca has joined #bitcoin-core-dev
1882017-08-11T15:02:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/96a63a3e0cef...e5d26e47c7a4
1892017-08-11T15:02:03  <bitcoin-git> bitcoin/master faa76d1 MarcoFalke: qa: Fix inv race in example_test
1902017-08-11T15:02:04  <bitcoin-git> bitcoin/master e5d26e4 MarcoFalke: Merge #11025: qa: Fix inv race in example_test...
1912017-08-11T15:02:38  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11025: qa: Fix inv race in example_test (master...Mf1708-qaInvExampleTest) https://github.com/bitcoin/bitcoin/pull/11025
1922017-08-11T15:15:01  <sdaftuar> jonasschnelli: i think the comment explains it -- the idea is that we don't want to respond with block hashes that we may be likely to prune in the near future
1932017-08-11T15:15:41  <sdaftuar> jonasschnelli: because otherwise the peer might request those blocks from us and we'll stall their block download by ignoring the request
1942017-08-11T15:25:07  *** Aaronvan_ has joined #bitcoin-core-dev
1952017-08-11T15:29:01  *** AaronvanW has quit IRC
1962017-08-11T15:33:59  <bitcoin-git> [bitcoin] jnewbery opened pull request #11031: [rpc] deprecate estimatefee (master...deprecate_estimatefee) https://github.com/bitcoin/bitcoin/pull/11031
1972017-08-11T15:36:45  *** BashCo has quit IRC
1982017-08-11T15:37:22  *** BashCo has joined #bitcoin-core-dev
1992017-08-11T15:38:32  *** Murch has joined #bitcoin-core-dev
2002017-08-11T15:41:57  *** BashCo has quit IRC
2012017-08-11T15:44:14  *** vicenteH has quit IRC
2022017-08-11T15:48:10  <jonasschnelli> sdaftuar: but the check to break the response is:  'pindex->nHeight <= chainActive.Tip()->nHeight - nPrunedBlocksLikelyToHave'
2032017-08-11T15:48:50  <jonasschnelli> Isn't that that blocks "older@ the 288+6 can then never be relaxed regardless of the prune target?
2042017-08-11T15:49:13  <jonasschnelli> s/@/"
2052017-08-11T15:49:30  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e5d26e47c7a4...2c811e08db65
2062017-08-11T15:49:31  <bitcoin-git> bitcoin/master c5ebddd René Nyffenegger: Tests: address placement should be deterministic by default
2072017-08-11T15:49:31  <jonasschnelli> *relayed (dry phone typing)
2082017-08-11T15:49:31  <bitcoin-git> bitcoin/master 2c811e0 MarcoFalke: Merge #10765: Tests: address placement should be deterministic by default...
2092017-08-11T15:49:55  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10765: Tests: address placement should be deterministic by default (master...test-addrman) https://github.com/bitcoin/bitcoin/pull/10765
2102017-08-11T15:50:15  <bitcoin-git> [bitcoin] sdaftuar opened pull request #11032: [qa] Fix block message processing error in sendheaders.py (master...2017-08-sendheaders) https://github.com/bitcoin/bitcoin/pull/11032
2112017-08-11T15:51:16  <gmaxwell> jonasschnelli: no-- if we offer a block we need to be willing to provide it or we will dos attack our peers.
2122017-08-11T15:51:48  <gmaxwell> doesn't matter if its 300 blocks deep or 30000 blocks deep.
2132017-08-11T15:52:27  <sdaftuar> also keep in mind that the line of code you're looking at is the getblocks handler, which is no longer really used to sync the chain by anyone (i hope!)
2142017-08-11T15:54:21  <jonasschnelli> Hmm... seems harder then I thought to add by-prune-height-fingerprinting protection for NODE_NETWORK_LIMITED
2152017-08-11T15:55:20  <sdaftuar> you're concerned about fingerprinting protection for nodes using manual pruning?
2162017-08-11T15:56:05  <sdaftuar> i would think that if you support NODE_NETWORK_LIMITED (and not NODE_NETWORK), you just always advertise exactly the last 1008 blocks or whatever that target value is
2172017-08-11T15:56:29  <jonasschnelli> I'm concerned introducing a fingerprinting possibility by NODE_NETWORK_LIMITED
2182017-08-11T15:57:06  <jonasschnelli> Yes. That is what I want. But older messages like getblock must also be covered via that protection
2192017-08-11T15:58:23  <sdaftuar> still don't see the fingerprinting issue -- can't all NODE_NETWORK_LIMITED nodes answer the getblocks issue the same way, with only up to the last 1008 block hashes?
2202017-08-11T16:00:16  <sdaftuar> nPrunedBlocksLikelyToHave can be calculated differently if you're pruning to a 1-week target versus a 2-day target
2212017-08-11T16:00:28  <sdaftuar> which correspond to LIMITED_HIGH and LIMITED_LOW
2222017-08-11T16:01:01  <jonasschnelli> Yes. The check we discussed above is kind of a fingerprinting protection.
2232017-08-11T16:01:49  <jonasschnelli> (Need to check it in detail when im back on my desk)
2242017-08-11T16:02:01  <sdaftuar> i guess!  but that's just a coincidence i think, i believe that getblocks handler predates the manual pruning by a lot.
2252017-08-11T16:02:13  <sdaftuar> so the concern was taht we might return an inv for blocks that we currently have, but are about to prune
2262017-08-11T16:02:40  <sdaftuar> the idea is that pruning only (largely-) guarantees the last 288 blocks, so we're conservative and never advertise more than that
2272017-08-11T16:03:16  *** RoyceX has joined #bitcoin-core-dev
2282017-08-11T16:03:46  <sdaftuar> and that happens to also give fingerprinting protection for manual pruners, too. though really it's just a consequence of manual pruners not having any additional guarantees of what they might keep.
2292017-08-11T16:04:04  <sdaftuar> eg you could manually prune down to 288 right after you send someone a getblocks response, and then cause problems.
2302017-08-11T16:05:04  *** dcousens_ has quit IRC
2312017-08-11T16:05:55  *** promag has joined #bitcoin-core-dev
2322017-08-11T16:06:20  *** d_t has joined #bitcoin-core-dev
2332017-08-11T16:07:01  <sdaftuar> separately i could imagine we could schedule getblocks for deprecation
2342017-08-11T16:07:11  <gmaxwell> we should probably just change to only advertise things releated to the last 288 or 1008 (however configured) blocks, whatever is our minimum.
2352017-08-11T16:07:16  <jonasschnelli> I see. I guess then increasing that protection up to 8 days of blocks in HIGH mode makes sense
2362017-08-11T16:07:37  <gmaxwell> I don't see why.
2372017-08-11T16:08:02  *** btcdrak has joined #bitcoin-core-dev
2382017-08-11T16:08:05  <gmaxwell> What we signal should become the minimum we'll prune to, even with manual pruning.
2392017-08-11T16:08:21  <gmaxwell> And then we can getblock advertise out to that minimum.
2402017-08-11T16:12:38  <jonasschnelli> gmaxwell, sdaftuar: advertise, yes. I see. But I guess we need a protection here: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L977
2412017-08-11T16:13:07  <jonasschnelli> Otherwise one can getdata blocks to fingerprint the prune depth?
2422017-08-11T16:14:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c811e08db65...bf74d377fb8e
2432017-08-11T16:14:02  <bitcoin-git> bitcoin/master cc5d38f John Newbery: Add option to attach a python debugger if test fails
2442017-08-11T16:14:02  <bitcoin-git> bitcoin/master bf74d37 MarcoFalke: Merge #11023: [tests] Add option to attach a python debugger if functional test fails...
2452017-08-11T16:14:36  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11023: [tests] Add option to attach a python debugger if functional test fails (master...func_test_pdb) https://github.com/bitcoin/bitcoin/pull/11023
2462017-08-11T16:14:56  *** BashCo has joined #bitcoin-core-dev
2472017-08-11T16:17:18  <gmaxwell> Yes, but it should allow whitelisted peers.
2482017-08-11T16:21:23  <sdaftuar> agreed
2492017-08-11T16:21:48  <jonasschnelli> ok
2502017-08-11T16:24:57  *** timothy has quit IRC
2512017-08-11T16:26:47  *** smill has joined #bitcoin-core-dev
2522017-08-11T16:31:50  *** promag has quit IRC
2532017-08-11T16:32:40  *** Austindoggie has joined #bitcoin-core-dev
2542017-08-11T16:33:24  *** Austindoggie has left #bitcoin-core-dev
2552017-08-11T16:41:25  *** Aaronvan_ is now known as AaronvanW
2562017-08-11T17:00:05  *** SopaXorzTaker has quit IRC
2572017-08-11T17:02:18  *** wangchun has quit IRC
2582017-08-11T17:03:26  *** amosbird has quit IRC
2592017-08-11T17:03:42  *** amosbird has joined #bitcoin-core-dev
2602017-08-11T17:11:25  *** jimpo has joined #bitcoin-core-dev
2612017-08-11T17:31:41  *** jimpo has quit IRC
2622017-08-11T17:35:04  *** Austindoggie_ has joined #bitcoin-core-dev
2632017-08-11T17:35:30  *** jimpo has joined #bitcoin-core-dev
2642017-08-11T17:39:58  *** d_t has quit IRC
2652017-08-11T17:49:11  *** Austindoggie_ has quit IRC
2662017-08-11T17:51:29  *** Chris_Stewart_5 has quit IRC
2672017-08-11T17:54:43  *** cluelessperson has joined #bitcoin-core-dev
2682017-08-11T17:55:06  *** cluelessperson is now known as Guest54492
2692017-08-11T17:56:20  *** Ylbam has joined #bitcoin-core-dev
2702017-08-11T17:57:57  *** Guest54492 has quit IRC
2712017-08-11T17:58:19  *** cluelessperson has joined #bitcoin-core-dev
2722017-08-11T18:00:55  *** Austindoggie has joined #bitcoin-core-dev
2732017-08-11T18:01:11  *** Austindoggie has quit IRC
2742017-08-11T18:05:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2752017-08-11T18:08:42  *** alreadylate has quit IRC
2762017-08-11T18:12:50  *** d_t has joined #bitcoin-core-dev
2772017-08-11T18:15:26  *** jimpo has quit IRC
2782017-08-11T18:16:00  *** Cheeseo has quit IRC
2792017-08-11T18:17:09  *** jimpo has joined #bitcoin-core-dev
2802017-08-11T18:18:08  *** Dizzle has joined #bitcoin-core-dev
2812017-08-11T18:22:05  *** jimpo has quit IRC
2822017-08-11T18:23:09  *** niska has quit IRC
2832017-08-11T18:23:46  *** herzmeister[m] has quit IRC
2842017-08-11T18:23:47  *** kewde[m] has quit IRC
2852017-08-11T18:24:05  *** SopaXorzTaker has joined #bitcoin-core-dev
2862017-08-11T18:28:55  *** herzmeister[m] has joined #bitcoin-core-dev
2872017-08-11T18:31:29  *** Chris_Stewart_5 has quit IRC
2882017-08-11T18:31:39  *** promag has joined #bitcoin-core-dev
2892017-08-11T18:32:25  *** niska has joined #bitcoin-core-dev
2902017-08-11T18:34:43  *** kewde[m] has joined #bitcoin-core-dev
2912017-08-11T18:35:49  *** promag has joined #bitcoin-core-dev
2922017-08-11T18:47:14  *** jimpo has joined #bitcoin-core-dev
2932017-08-11T18:52:08  *** jimpo has quit IRC
2942017-08-11T19:03:41  *** jimpo has joined #bitcoin-core-dev
2952017-08-11T19:11:47  *** jimpo has quit IRC
2962017-08-11T19:16:05  *** Giszmo has quit IRC
2972017-08-11T19:16:44  *** Giszmo has joined #bitcoin-core-dev
2982017-08-11T19:44:56  *** jimpo has joined #bitcoin-core-dev
2992017-08-11T19:48:24  *** SopaXorzTaker has quit IRC
3002017-08-11T19:56:41  *** promag has quit IRC
3012017-08-11T19:57:17  *** d_t has quit IRC
3022017-08-11T20:01:39  *** kewde[m] has quit IRC
3032017-08-11T20:01:52  *** herzmeister[m] has quit IRC
3042017-08-11T20:03:37  *** herzmeister[m] has joined #bitcoin-core-dev
3052017-08-11T20:05:58  *** Ylbam has quit IRC
3062017-08-11T20:09:14  *** kewde[m] has joined #bitcoin-core-dev
3072017-08-11T20:14:57  *** Cheeseo has joined #bitcoin-core-dev
3082017-08-11T20:16:32  *** RoyceX has quit IRC
3092017-08-11T20:19:27  *** Giszmo has quit IRC
3102017-08-11T20:20:08  *** Giszmo has joined #bitcoin-core-dev
3112017-08-11T20:24:56  <jnewbery> (not for v0.15) I was thinking of adding 'bestblock' to the output from 'getwalletinfo', so if we implement something where the wallet stops advancing because of keypool deplation, at least there's an indication that your wallet is falling behind
3122017-08-11T20:26:15  <jnewbery> But bestblock is only updated when the block index is written to disk (usually once an hour), so I think without description, that might be very confusing for users (bestblock showing as some blocks behind, but transactions from recent blocks shown in wallet)
3132017-08-11T20:26:27  <jnewbery> any thoughts/suggestions?
3142017-08-11T20:28:12  <luke-jr> can we show the more up-to-date bestblock, but only store the block index as currently done?
3152017-08-11T20:30:39  <jnewbery> the wallet doesn't currently store its best block in memory. It only writes bestblock to disk when the node sends it SetBestChain (shutdown and block index flush)
3162017-08-11T20:31:11  <jnewbery> I suppose the wallet could store the most recent block connected when it gets BlockConnected. Is that safe?
3172017-08-11T20:36:32  <sipa> jnewbery: i think that's what needs to happen anyway, allow the wallet at any time to run behind the node, and make it catch up in the background
3182017-08-11T20:36:41  <sipa> so ack on adding bestblock to walletinfo output
3192017-08-11T20:36:49  *** jimpo has quit IRC
3202017-08-11T20:37:28  *** jimpo has joined #bitcoin-core-dev
3212017-08-11T20:40:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3222017-08-11T20:42:17  *** vicenteH has joined #bitcoin-core-dev
3232017-08-11T20:45:38  *** vicenteH has quit IRC
3242017-08-11T20:45:52  *** vicenteH has joined #bitcoin-core-dev
3252017-08-11T20:47:20  <ryanofsky> #10286 adds CWallet::m_last_block_processed, which is a better name than bestblock imo
3262017-08-11T20:47:22  <gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
3272017-08-11T20:47:49  <jnewbery> sipa : does storing the hash of the most recent BlockConnected seem like the right thing to do?
3282017-08-11T20:48:46  <jnewbery> ryanofsky oh great. Thanks
3292017-08-11T20:49:04  <ryanofsky> 10286 stores it as a cblockindex pointer, but #10973 turns that into a hash, so either way seems fine
3302017-08-11T20:49:05  <gribble> https://github.com/bitcoin/bitcoin/issues/10973 | WIP: Add IPC layer between node and wallet by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
3312017-08-11T20:49:17  *** LeMiner has joined #bitcoin-core-dev
3322017-08-11T20:59:59  *** elkalamar_ is now known as elkalamar
3332017-08-11T21:02:30  *** d_t has joined #bitcoin-core-dev
3342017-08-11T21:05:02  *** justanotheruser has joined #bitcoin-core-dev
3352017-08-11T21:08:41  *** chjj has quit IRC
3362017-08-11T21:16:00  *** Victor_sueca is now known as Victorsueca
3372017-08-11T21:31:44  *** Guyver2 has quit IRC
3382017-08-11T21:33:53  *** jimpo has quit IRC
3392017-08-11T21:39:26  *** justanotheruser has quit IRC
3402017-08-11T21:45:09  *** justanotheruser has joined #bitcoin-core-dev
3412017-08-11T21:55:50  *** jimpo has joined #bitcoin-core-dev
3422017-08-11T21:57:28  *** Chris_Stewart_5 has quit IRC
3432017-08-11T22:04:32  *** chjj has joined #bitcoin-core-dev
3442017-08-11T22:09:54  *** justanotheruser has quit IRC
3452017-08-11T22:11:09  *** jimmysong has quit IRC
3462017-08-11T22:11:27  *** justanotheruser has joined #bitcoin-core-dev
3472017-08-11T22:12:18  *** jimmysong has joined #bitcoin-core-dev
3482017-08-11T22:16:28  *** jimmysong has quit IRC
3492017-08-11T22:37:05  *** jimpo has quit IRC
3502017-08-11T22:45:34  *** justanotheruser has quit IRC
3512017-08-11T22:47:07  *** justanotheruser has joined #bitcoin-core-dev
3522017-08-11T22:49:21  *** Dizzle has quit IRC
3532017-08-11T22:49:50  *** jimpo has joined #bitcoin-core-dev
3542017-08-11T22:55:31  *** promag has joined #bitcoin-core-dev
3552017-08-11T23:15:02  *** jimpo has quit IRC
3562017-08-11T23:18:50  *** smill has quit IRC
3572017-08-11T23:21:30  *** justanotheruser has quit IRC
3582017-08-11T23:24:29  *** Giszmo has quit IRC
3592017-08-11T23:24:41  *** Giszmo has joined #bitcoin-core-dev
3602017-08-11T23:44:49  *** justanotheruser has joined #bitcoin-core-dev
3612017-08-11T23:45:21  *** alreadylate has joined #bitcoin-core-dev
3622017-08-11T23:47:59  *** jimpo has joined #bitcoin-core-dev
3632017-08-11T23:56:16  *** alreadylate has quit IRC
3642017-08-11T23:58:03  *** jimpo has quit IRC
3652017-08-11T23:58:16  *** justanotheruser has quit IRC