12017-08-16T00:10:01 *** d9b4bef9 has quit IRC
22017-08-16T00:11:08 *** d9b4bef9 has joined #bitcoin-core-dev
32017-08-16T00:13:08 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7db65c363a0c...b6a48914c506
42017-08-16T00:13:09 <bitcoin-git> bitcoin/master 6e8c48d practicalswift: Add const to methods that do not modify the object for which it is called
52017-08-16T00:13:09 <bitcoin-git> bitcoin/master b6a4891 MarcoFalke: Merge #9964: Add const to methods that do not modify the object for which it is called...
62017-08-16T00:13:20 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9964: Add const to methods that do not modify the object for which it is called (master...const) https://github.com/bitcoin/bitcoin/pull/9964
72017-08-16T00:17:11 *** chjj has joined #bitcoin-core-dev
82017-08-16T00:20:50 *** Austindoggie_ has quit IRC
92017-08-16T00:20:53 <gmaxwell> 0.15 branch has a warning now
102017-08-16T00:20:54 <gmaxwell> wallet/wallet.cpp:3668:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
112017-08-16T00:20:58 <gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
122017-08-16T00:21:01 <gmaxwell> ^
132017-08-16T00:21:03 <gmaxwell> wallet/wallet.cpp:3668:80: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
142017-08-16T00:21:06 <gmaxwell> return setExternalKeyPool.size() >= min_keys && (setInternalKeyPool.size() >= min_keys || !CanSupportFeature(FEATURE_HD_SPLIT));
152017-08-16T00:24:41 <BlueMatt> well we're gonna do an rc2 anyway, for the version issue, right?
162017-08-16T00:27:05 <Lightsword> has anyone verified that getentropy is getting built for release builds on osx?
172017-08-16T00:32:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6a48914c506...655970d9c60a
182017-08-16T00:32:35 <bitcoin-git> bitcoin/master 9862550 practicalswift: Use the noexcept specifier (C++11) instead of deprecated throw()
192017-08-16T00:32:36 <bitcoin-git> bitcoin/master 655970d MarcoFalke: Merge #10965: Replace deprecated throw() with noexcept specifier (C++11)...
202017-08-16T00:33:07 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10965: Replace deprecated throw() with noexcept specifier (C++11) (master...noexcept) https://github.com/bitcoin/bitcoin/pull/10965
212017-08-16T00:34:07 <jimpo> Is it preferred to have function/method comments in the header files or cpp files? (I would think header?)
222017-08-16T00:34:59 <sipa> yes, header
232017-08-16T00:35:04 <sipa> unless they're implementation details
242017-08-16T00:36:06 *** Cheeseo has joined #bitcoin-core-dev
252017-08-16T00:37:21 <gmaxwell> jimpo: header should comment the interface, cpp the implementation, generally. (I don't think we've documented it in our coding style docs, but it's my preference)
262017-08-16T00:37:45 <jimpo> Understood, thx
272017-08-16T00:46:43 *** Murch has quit IRC
282017-08-16T00:47:14 *** RoyceX has joined #bitcoin-core-dev
292017-08-16T00:48:30 *** Cheeseo has quit IRC
302017-08-16T00:48:38 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/655970d9c60a...a46a671e2535
312017-08-16T00:48:39 <bitcoin-git> bitcoin/master 3eb53b8 practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
322017-08-16T00:48:39 <bitcoin-git> bitcoin/master a46a671 MarcoFalke: Merge #10957: Avoid returning a BIP9Stats object with uninitialized values...
332017-08-16T00:49:06 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10957: Avoid returning a BIP9Stats object with uninitialized values (master...bip9status) https://github.com/bitcoin/bitcoin/pull/10957
342017-08-16T00:50:57 *** Deacydal has quit IRC
352017-08-16T00:51:28 *** Deacydal has joined #bitcoin-core-dev
362017-08-16T00:52:41 *** Cheeseo has joined #bitcoin-core-dev
372017-08-16T00:55:10 *** RoyceX has quit IRC
382017-08-16T01:08:25 *** dabura667 has joined #bitcoin-core-dev
392017-08-16T01:15:08 *** twistedline has quit IRC
402017-08-16T01:15:22 *** twistedline has joined #bitcoin-core-dev
412017-08-16T01:20:26 *** Cheeseo has quit IRC
422017-08-16T01:25:47 <bitcoin-git> [bitcoin] jimpo opened pull request #11058: Comments: More comments on functions/globals in standard.h. (master...standard-comments) https://github.com/bitcoin/bitcoin/pull/11058
432017-08-16T01:32:25 *** dabura667 has quit IRC
442017-08-16T01:32:35 *** jimpo has quit IRC
452017-08-16T01:32:46 *** dabura667 has joined #bitcoin-core-dev
462017-08-16T01:40:49 *** jtimon has joined #bitcoin-core-dev
472017-08-16T01:41:21 *** trippysalmon has quit IRC
482017-08-16T01:52:59 *** Chris_Stewart_5 has quit IRC
492017-08-16T01:54:26 *** trippysalmon has joined #bitcoin-core-dev
502017-08-16T02:03:02 *** jimpo has joined #bitcoin-core-dev
512017-08-16T02:05:01 *** Austindoggie has joined #bitcoin-core-dev
522017-08-16T02:13:32 *** jtimon has quit IRC
532017-08-16T02:15:14 <bitcoin-git> [bitcoin] Ilikenumber0 opened pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059
542017-08-16T02:17:42 <bitcoin-git> [bitcoin] sipa closed pull request #11059: Its just for education, not a real pull request (master...master) https://github.com/bitcoin/bitcoin/pull/11059
552017-08-16T02:25:59 *** d_t has quit IRC
562017-08-16T02:59:11 *** Deacyded has joined #bitcoin-core-dev
572017-08-16T03:02:31 *** Deacydal has quit IRC
582017-08-16T03:08:05 *** jimpo has quit IRC
592017-08-16T03:10:23 *** Austindoggie_ has joined #bitcoin-core-dev
602017-08-16T03:14:25 *** Austindoggie has quit IRC
612017-08-16T03:29:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
622017-08-16T03:45:14 *** jimpo has joined #bitcoin-core-dev
632017-08-16T03:57:29 *** Chris_Stewart_5 has quit IRC
642017-08-16T04:00:52 *** jimpo has quit IRC
652017-08-16T04:02:02 *** d9b4bef9 has quit IRC
662017-08-16T04:03:08 *** d9b4bef9 has joined #bitcoin-core-dev
672017-08-16T04:04:01 *** d9b4bef9 has quit IRC
682017-08-16T04:05:07 *** d9b4bef9 has joined #bitcoin-core-dev
692017-08-16T04:09:47 *** jimpo has joined #bitcoin-core-dev
702017-08-16T04:17:12 *** jimpo has quit IRC
712017-08-16T04:30:31 *** chjj has quit IRC
722017-08-16T04:59:41 *** Deacydal has joined #bitcoin-core-dev
732017-08-16T05:03:40 *** Deacyded has quit IRC
742017-08-16T05:08:14 *** arubi has quit IRC
752017-08-16T05:09:37 *** miknotauro has joined #bitcoin-core-dev
762017-08-16T05:16:44 *** arubi has joined #bitcoin-core-dev
772017-08-16T05:17:17 *** treebear_ has quit IRC
782017-08-16T05:22:39 *** jimpo has joined #bitcoin-core-dev
792017-08-16T05:26:31 *** d_t has joined #bitcoin-core-dev
802017-08-16T05:30:03 *** treebeardd has joined #bitcoin-core-dev
812017-08-16T05:41:44 *** elkalamar has quit IRC
822017-08-16T05:51:59 *** d_t has quit IRC
832017-08-16T05:56:56 *** Deacyded has joined #bitcoin-core-dev
842017-08-16T05:58:25 *** chjj has joined #bitcoin-core-dev
852017-08-16T06:00:19 *** Deacydal has quit IRC
862017-08-16T06:11:40 *** Deacydal has joined #bitcoin-core-dev
872017-08-16T06:15:01 *** Deacyded has quit IRC
882017-08-16T06:22:13 <wumpus> cfields_: as long as it is deterministic, it is no big deal
892017-08-16T06:30:39 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a46a671e2535...d451d0bcf15d
902017-08-16T06:30:39 <bitcoin-git> bitcoin/master 844b73e Gregory Sanders: disable jni in builds
912017-08-16T06:30:40 <bitcoin-git> bitcoin/master d451d0b Wladimir J. van der Laan: Merge #11056: disable jni in builds...
922017-08-16T06:31:19 <bitcoin-git> [bitcoin] laanwj closed pull request #11056: disable jni in builds (master...disablejni) https://github.com/bitcoin/bitcoin/pull/11056
932017-08-16T06:40:35 *** jimpo has quit IRC
942017-08-16T06:57:37 *** BashCo has quit IRC
952017-08-16T06:58:52 *** klebs has joined #bitcoin-core-dev
962017-08-16T07:02:53 *** klebs has quit IRC
972017-08-16T07:03:16 *** promag has joined #bitcoin-core-dev
982017-08-16T07:17:26 *** BashCo has joined #bitcoin-core-dev
992017-08-16T07:18:08 *** treebeardd has quit IRC
1002017-08-16T07:19:38 *** cfields_ is now known as cfields
1012017-08-16T07:20:25 *** cfields has joined #bitcoin-core-dev
1022017-08-16T07:36:47 <wumpus> as I had to test binary upload I've already uploaded rc1 to both sites https://bitcoin.org/bin/bitcoin-core-0.15.0/test.rc1/ https://bitcoincore.org/bin/bitcoin-core-0.15.0/test.rc1/ - but we should wait with announcing this publicly until there's at least two more gitian sigs for the code-signed executables
1032017-08-16T07:50:09 *** cryptapus has joined #bitcoin-core-dev
1042017-08-16T07:56:10 *** promag has quit IRC
1052017-08-16T07:58:02 *** promag has joined #bitcoin-core-dev
1062017-08-16T08:06:40 *** promag has quit IRC
1072017-08-16T08:12:41 *** Austindoggie_ has quit IRC
1082017-08-16T08:25:22 <bitcoin-git> [bitcoin] kallewoof opened pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (master...mempool-alreadythere) https://github.com/bitcoin/bitcoin/pull/11062
1092017-08-16T08:31:06 *** fanquake has joined #bitcoin-core-dev
1102017-08-16T08:31:13 <fanquake> wumpus I've pushed up signed sigs
1112017-08-16T08:42:34 *** Austindoggie_ has joined #bitcoin-core-dev
1122017-08-16T08:46:36 *** vicenteH has joined #bitcoin-core-dev
1132017-08-16T08:52:30 *** Austindoggie_ has quit IRC
1142017-08-16T08:58:03 *** grandfso has joined #bitcoin-core-dev
1152017-08-16T09:20:07 *** goatpig has joined #bitcoin-core-dev
1162017-08-16T09:22:56 *** miknotauro has quit IRC
1172017-08-16T09:35:30 *** Guyver2 has joined #bitcoin-core-dev
1182017-08-16T09:40:50 *** justan0theruser has quit IRC
1192017-08-16T10:07:43 *** JackH has quit IRC
1202017-08-16T10:23:33 *** AaronvanW has joined #bitcoin-core-dev
1212017-08-16T10:48:18 <wumpus> fanquake: thanks!
1222017-08-16T10:59:59 *** shesek has joined #bitcoin-core-dev
1232017-08-16T11:00:08 *** shesek has joined #bitcoin-core-dev
1242017-08-16T11:19:51 *** promag has joined #bitcoin-core-dev
1252017-08-16T11:26:57 *** AaronvanW has quit IRC
1262017-08-16T11:31:33 *** AaronvanW has joined #bitcoin-core-dev
1272017-08-16T11:37:29 *** jtimon has joined #bitcoin-core-dev
1282017-08-16T11:39:47 *** grandfso_ has joined #bitcoin-core-dev
1292017-08-16T11:42:57 *** grandfso has quit IRC
1302017-08-16T11:50:05 *** grandfso_ has quit IRC
1312017-08-16T11:50:12 *** grandfso has joined #bitcoin-core-dev
1322017-08-16T11:57:41 *** Deacyde has joined #bitcoin-core-dev
1332017-08-16T11:59:46 *** Deacydal has quit IRC
1342017-08-16T12:09:42 *** fanquake has quit IRC
1352017-08-16T12:12:43 *** dabura667 has quit IRC
1362017-08-16T12:46:28 *** justanotheruser has joined #bitcoin-core-dev
1372017-08-16T12:51:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1382017-08-16T13:02:17 *** promag has quit IRC
1392017-08-16T13:26:38 *** promag has joined #bitcoin-core-dev
1402017-08-16T13:37:26 *** jtimon has quit IRC
1412017-08-16T13:59:06 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d451d0bcf15d...c484ec6c9b85
1422017-08-16T13:59:06 <bitcoin-git> bitcoin/master 36d326e practicalswift: Use nullptr instead of zero (0) as the null pointer constant
1432017-08-16T13:59:07 <bitcoin-git> bitcoin/master c484ec6 MarcoFalke: Merge #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant...
1442017-08-16T13:59:26 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10645: Use nullptr (C++11) instead of zero (0) as the null pointer constant (master...welcome-nullptr-goodbye-0) https://github.com/bitcoin/bitcoin/pull/10645
1452017-08-16T14:00:49 *** arubi has quit IRC
1462017-08-16T14:01:19 *** arubi has joined #bitcoin-core-dev
1472017-08-16T14:12:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c484ec6c9b85...22e301a3d56d
1482017-08-16T14:12:48 <bitcoin-git> bitcoin/master a622a17 João Barbosa: Fix constness of ArgsManager methods
1492017-08-16T14:12:50 <bitcoin-git> bitcoin/master 22e301a MarcoFalke: Merge #10901: Fix constness of ArgsManager methods...
1502017-08-16T14:13:20 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10901: Fix constness of ArgsManager methods (master...2017-07-args-manager-constness) https://github.com/bitcoin/bitcoin/pull/10901
1512017-08-16T14:45:13 *** Chris_Stewart_5 has quit IRC
1522017-08-16T14:45:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1532017-08-16T14:50:04 *** Skynets has quit IRC
1542017-08-16T14:50:24 *** Cheeseo has joined #bitcoin-core-dev
1552017-08-16T14:50:29 *** Murch has joined #bitcoin-core-dev
1562017-08-16T14:51:20 *** Skynets has joined #bitcoin-core-dev
1572017-08-16T14:58:54 *** grandfso has quit IRC
1582017-08-16T15:07:27 <BlueMatt> alrighty, what should I be reviewing?
1592017-08-16T15:20:54 *** hwl3o has joined #bitcoin-core-dev
1602017-08-16T15:24:01 <promag> BlueMatt: #11006 it's one line :P
1612017-08-16T15:28:42 <bitcoin-git> [bitcoin] practicalswift opened pull request #11066: Document the preference of nullptr over NULL or (void*)0 (master...document-nullptr-preference) https://github.com/bitcoin/bitcoin/pull/11066
1622017-08-16T15:36:06 <gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
1632017-08-16T15:49:55 <BlueMatt> cfields: can you rebase #10756 ?
1642017-08-16T15:51:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11067: [qa] TestNode: Add wait_until_node_stopped helper method (master...Mf1708-qaTestnodeWaitStopHelper) https://github.com/bitcoin/bitcoin/pull/11067
1652017-08-16T15:51:53 <cfields> BlueMatt: sure
1662017-08-16T15:55:39 *** BashCo has quit IRC
1672017-08-16T16:01:17 <gribble> https://github.com/bitcoin/bitcoin/issues/10756 | net processing: swap out signals for an interface class by theuni · Pull Request #10756 · bitcoin/bitcoin · GitHub
1682017-08-16T16:08:01 <BlueMatt> cfields: thnks, gonna take a crack at rebasing on it :)
1692017-08-16T16:14:42 *** BashCo has joined #bitcoin-core-dev
1702017-08-16T16:17:43 *** SopaXorzTaker has quit IRC
1712017-08-16T16:19:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11068: [WIP] qa: Replace wait_until with wait_until_mn (scripted) (master...Mf1708-qaWaitUntilMiniNode) https://github.com/bitcoin/bitcoin/pull/11068
1722017-08-16T16:25:00 *** d_t has joined #bitcoin-core-dev
1732017-08-16T16:56:16 <bitcoin-git> [bitcoin] popenkomaksim opened pull request #11069: Trivial: Lossless image optimization. (master...master) https://github.com/bitcoin/bitcoin/pull/11069
1742017-08-16T17:03:47 *** jtimon has joined #bitcoin-core-dev
1752017-08-16T17:04:52 *** PaulCapestany has quit IRC
1762017-08-16T17:15:59 *** Chris_Stewart_5 has quit IRC
1772017-08-16T17:17:03 *** Giszmo has joined #bitcoin-core-dev
1782017-08-16T17:17:57 *** ekerstein has joined #bitcoin-core-dev
1792017-08-16T17:17:57 *** promag has quit IRC
1802017-08-16T17:18:08 *** PaulCapestany has joined #bitcoin-core-dev
1812017-08-16T17:18:46 *** paveljanik has quit IRC
1822017-08-16T17:18:59 *** paveljanik has joined #bitcoin-core-dev
1832017-08-16T17:19:47 *** paveljanik has quit IRC
1842017-08-16T17:19:57 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1852017-08-16T17:31:48 <cfields> morcos: ping
1862017-08-16T17:33:17 <cfields> morcos: while profiling some new net code yesterday, i noticed that TxConfirmStats::UpdateMovingAverages is a notable hotspot
1872017-08-16T17:34:00 <cfields> during IBD, it accounted for ~5-10% of the message handler thread
1882017-08-16T17:34:59 *** cheese_ has joined #bitcoin-core-dev
1892017-08-16T17:35:46 <cfields> cpu usage, that is
1902017-08-16T17:37:28 *** vicenteH has quit IRC
1912017-08-16T17:38:09 *** Austindoggie_ has joined #bitcoin-core-dev
1922017-08-16T17:39:19 <sipa> cfields: during IBD? :o
1932017-08-16T17:39:52 <cfields> sipa: that was my thought :\
1942017-08-16T17:40:03 <cfields> IBD up to 200k blocks, anyway
1952017-08-16T17:45:23 <BlueMatt> cfields: well, it'll be in the background in 16 :/
1962017-08-16T17:46:12 <cfields> BlueMatt: surely it's not necessary until we're nearly caught up?
1972017-08-16T17:51:40 <sdaftuar> cfields: i'd guess the implementation is probably just trying to make sure that the estimates properly decay when a node is catching up after being down for a while
1982017-08-16T17:55:07 <cfields> well i have a quick optim to speed up that function, but i figured it'd just result in a discussion about avoiding it during early IBD
1992017-08-16T17:55:24 <gmaxwell> I assume a simple branch to skip decays when everything is zero would speed that right up.
2002017-08-16T17:55:46 <cfields> I'll PR the speedup, and create an issue to discuss avoidance
2012017-08-16T17:56:22 <gmaxwell> sipa: we test too much with reindex chainstate
2022017-08-16T17:56:23 *** Austindoggie_ has quit IRC
2032017-08-16T17:56:50 <cfields> gmaxwell: ah, i was wondering why you hadn't nagged about it :)
2042017-08-16T18:04:12 *** To7 has quit IRC
2052017-08-16T18:06:21 *** RoyceX has joined #bitcoin-core-dev
2062017-08-16T18:08:50 *** Cheeseo has quit IRC
2072017-08-16T18:11:26 *** RoyceX has quit IRC
2082017-08-16T18:20:28 *** jimpo has joined #bitcoin-core-dev
2092017-08-16T18:20:58 *** jtimon has quit IRC
2102017-08-16T18:21:28 *** owowo has quit IRC
2112017-08-16T18:22:53 <cfields> BlueMatt: rebased
2122017-08-16T18:26:29 *** owowo has joined #bitcoin-core-dev
2132017-08-16T18:37:50 *** Giszmo has quit IRC
2142017-08-16T18:44:56 *** elkalamar has joined #bitcoin-core-dev
2152017-08-16T18:45:20 *** SopaXorzTaker has joined #bitcoin-core-dev
2162017-08-16T18:55:46 *** ekerstein has quit IRC
2172017-08-16T18:58:50 <BlueMatt> gmaxwell: well its gonna be slow after sync anyway, so just move it into the background where it wont slow down ibd at all and will be fast later, too :p
2182017-08-16T18:58:52 <BlueMatt> cfields: thanks
2192017-08-16T19:00:10 <gmaxwell> BlueMatt: well I agree, but a branch on already zero is perhaps a four line change.
2202017-08-16T19:03:44 *** ekerstein has joined #bitcoin-core-dev
2212017-08-16T19:04:17 <BlueMatt> gmaxwell: a branch to put it in the background is probably 3 at this point :p
2222017-08-16T19:06:28 <BlueMatt> can someone remind me whats left to switch the sync.h stuff to std::mutex?
2232017-08-16T19:06:41 <BlueMatt> looks like it may be needed for #10923
2242017-08-16T19:07:05 <gribble> https://github.com/bitcoin/bitcoin/issues/10923 | Use -Wthread-safety-analysis if available (+ -Werror=[â¦] if --enable-werror) by practicalswift · Pull Request #10923 · bitcoin/bitcoin · GitHub
2252017-08-16T19:13:51 *** goatpig has quit IRC
2262017-08-16T19:15:05 *** Chris_Stewart_5 has quit IRC
2272017-08-16T19:15:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2282017-08-16T19:22:26 *** ekerstein has quit IRC
2292017-08-16T19:27:44 *** justanotheruser has quit IRC
2302017-08-16T19:33:39 *** ekerstein has joined #bitcoin-core-dev
2312017-08-16T19:34:28 <bitcoin-git> [bitcoin] practicalswift opened pull request #11071: Use static_assert(â¦, â¦) instead of assert(â¦) where appropriate (master...static_assert) https://github.com/bitcoin/bitcoin/pull/11071
2322017-08-16T19:37:11 <morcos> cfields: hmm... that's somewhat surprising, but yes i guess if all the other operations are basically very quick with the early blocks, that one takes just as long
2332017-08-16T19:37:19 <morcos> i'd be happy to look at your speedup
2342017-08-16T19:38:15 <morcos> i think we could also do something relatively simple to avoid doing it if blocks are less than some reasonable checkpointed height or something
2352017-08-16T19:38:47 *** Austindoggie_ has joined #bitcoin-core-dev
2362017-08-16T19:42:09 *** ekerstei_ has joined #bitcoin-core-dev
2372017-08-16T19:42:13 *** eck has quit IRC
2382017-08-16T19:42:28 *** ekerstein has quit IRC
2392017-08-16T19:42:32 *** eck has joined #bitcoin-core-dev
2402017-08-16T19:42:57 *** Chris_Stewart_5 has quit IRC
2412017-08-16T19:44:13 *** eck has quit IRC
2422017-08-16T19:44:31 *** eck has joined #bitcoin-core-dev
2432017-08-16T19:44:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2442017-08-16T19:46:13 *** eck has quit IRC
2452017-08-16T19:46:40 *** eck has joined #bitcoin-core-dev
2462017-08-16T19:48:20 *** eck has joined #bitcoin-core-dev
2472017-08-16T19:52:58 *** Chris_Stewart_5 has quit IRC
2482017-08-16T19:54:27 *** SopaXorzTaker has quit IRC
2492017-08-16T19:55:05 <BlueMatt> morcos: the height-at-which-0.15-was-released is sufficient, cause your estimates get wiped anyway :p
2502017-08-16T19:55:52 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2512017-08-16T20:01:09 *** Skynets has quit IRC
2522017-08-16T20:02:58 *** Chris_Stewart_5 has quit IRC
2532017-08-16T20:03:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2542017-08-16T20:04:54 *** vicenteH has joined #bitcoin-core-dev
2552017-08-16T20:32:30 *** Austindoggie_ has quit IRC
2562017-08-16T20:39:28 *** Austindoggie_ has joined #bitcoin-core-dev
2572017-08-16T20:54:43 *** treebeardd has joined #bitcoin-core-dev
2582017-08-16T21:00:45 <jimpo> If I rebroadcast an already-confirmed transaction, will Bitcoin Core nodes add it as an orphan tx?
2592017-08-16T21:03:14 <sipa> it may
2602017-08-16T21:04:54 <jimpo> I see this https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L545
2612017-08-16T21:05:42 <jimpo> When would an old output be in the pcoinsTip cache?
2622017-08-16T21:06:14 <sipa> because its output isn't spent yet
2632017-08-16T21:06:37 <jimpo> OK, makes sense
2642017-08-16T21:17:11 <jimpo> So in the case where you rebroadcast a transaction with all spent outputs, and it is added as an orphan, the node will then reject all of the parent transactions to that one?
2652017-08-16T21:17:20 <jimpo> request* not reject
2662017-08-16T21:17:40 <sipa> right, which other peers likely don't have anymore
2672017-08-16T21:23:28 *** jimpo has quit IRC
2682017-08-16T21:31:08 *** harrymm1 has joined #bitcoin-core-dev
2692017-08-16T21:32:20 *** harrymm has quit IRC
2702017-08-16T21:34:51 *** jimpo has joined #bitcoin-core-dev
2712017-08-16T21:48:50 *** Chris_Stewart_5 has quit IRC
2722017-08-16T21:50:09 *** Guyver2 has quit IRC
2732017-08-16T21:55:33 *** ekerstei_ has quit IRC
2742017-08-16T23:30:29 *** echonaut has quit IRC
2752017-08-16T23:30:51 *** echonaut has joined #bitcoin-core-dev
2762017-08-16T23:35:42 *** shesek has quit IRC
2772017-08-16T23:36:36 *** jtimon has joined #bitcoin-core-dev
2782017-08-16T23:39:01 *** juscamarena has joined #bitcoin-core-dev
2792017-08-16T23:39:25 *** juscamarena is now known as Guest18809
2802017-08-16T23:41:01 *** juscamarena_ has quit IRC
2812017-08-16T23:46:30 *** Murch has quit IRC
2822017-08-16T23:47:01 *** d9b4bef9 has quit IRC
2832017-08-16T23:48:07 *** d9b4bef9 has joined #bitcoin-core-dev
2842017-08-16T23:52:12 *** justanotheruser has joined #bitcoin-core-dev
2852017-08-16T23:52:56 *** justanotheruser has joined #bitcoin-core-dev
2862017-08-16T23:59:20 *** belcher has quit IRC