12017-08-26T00:01:09 <bitcoin-git> [bitcoin] danra opened pull request #11151: Fix header guards using reserved identifiers (master...fix/header-guards) https://github.com/bitcoin/bitcoin/pull/11151
22017-08-26T00:22:04 <jimpo> I know you guys are busy with the 0.15 release, but I'd really appreciate a review on either 11116 or 11113.
32017-08-26T00:22:25 *** tiagotrs has quit IRC
42017-08-26T00:27:26 <gmaxwell> jimpo: Thanks!
52017-08-26T00:29:21 *** justanotheruser has quit IRC
62017-08-26T00:33:41 *** AaronvanW has quit IRC
72017-08-26T01:00:03 *** cheese_ has joined #bitcoin-core-dev
82017-08-26T01:02:48 *** RoyceX has quit IRC
92017-08-26T01:07:34 *** Yogaqueef has quit IRC
102017-08-26T01:13:18 *** Chris_Stewart_5 has quit IRC
112017-08-26T01:29:35 *** Chris_Stewart_5 has joined #bitcoin-core-dev
122017-08-26T01:41:32 <bitcoin-git> [bitcoin] RHavar opened pull request #11152: Increase DEFAULT_ANCESTOR_LIMIT and DEFAULT_DESCENDANT_LIMIT to 100 (master...limits) https://github.com/bitcoin/bitcoin/pull/11152
132017-08-26T01:57:49 *** justanotheruser has joined #bitcoin-core-dev
142017-08-26T02:15:51 *** praxeology has joined #bitcoin-core-dev
152017-08-26T02:22:52 *** Dyaheon has quit IRC
162017-08-26T02:26:34 *** Dyaheon has joined #bitcoin-core-dev
172017-08-26T02:28:17 *** Chris_Stewart_5 has quit IRC
182017-08-26T02:33:13 <bitcoin-git> [bitcoin] RHavar closed pull request #11152: Increase DEFAULT_ANCESTOR_LIMIT and DEFAULT_DESCENDANT_LIMIT to 100 (master...limits) https://github.com/bitcoin/bitcoin/pull/11152
192017-08-26T02:35:34 <jtimon> ping https://github.com/bitcoin/bitcoin/pull/10669
202017-08-26T02:38:59 <jtimon> I know nobody cares about this and that's why it's taken ages, but I think it's good even if I didn't care about signed blocks...
212017-08-26T02:47:00 <meshcollider> I'll review in a second :)
222017-08-26T02:51:53 *** ems has joined #bitcoin-core-dev
232017-08-26T02:54:25 <meshcollider> lgtm
242017-08-26T03:07:36 *** justanotheruser has quit IRC
252017-08-26T03:13:19 *** justanotheruser has joined #bitcoin-core-dev
262017-08-26T03:15:52 *** justanotheruser has quit IRC
272017-08-26T03:19:04 *** goatpig has quit IRC
282017-08-26T03:21:37 *** justanotheruser has joined #bitcoin-core-dev
292017-08-26T03:27:30 *** justanotheruser has quit IRC
302017-08-26T03:29:29 *** RoyceX has joined #bitcoin-core-dev
312017-08-26T03:31:28 *** ems has quit IRC
322017-08-26T03:32:16 *** cheese_ has quit IRC
332017-08-26T03:59:43 *** Soligor has quit IRC
342017-08-26T04:00:42 *** afk11 has quit IRC
352017-08-26T04:07:43 *** afk11 has joined #bitcoin-core-dev
362017-08-26T04:30:01 *** Dyaheon has quit IRC
372017-08-26T04:32:42 *** Dyaheon has joined #bitcoin-core-dev
382017-08-26T04:46:46 *** rhavar has quit IRC
392017-08-26T04:54:47 *** justanotheruser has joined #bitcoin-core-dev
402017-08-26T05:25:50 *** RoyceX has quit IRC
412017-08-26T06:25:48 *** jtimon has quit IRC
422017-08-26T06:27:13 *** ems has joined #bitcoin-core-dev
432017-08-26T06:31:29 *** ems has quit IRC
442017-08-26T07:12:24 <bitcoin-git> [bitcoin] MeshCollider opened pull request #11153: Add meshcollider Gitian PGP key (master...201708_add_meshcollider_gpg) https://github.com/bitcoin/bitcoin/pull/11153
452017-08-26T07:15:10 *** SopaXorzTaker has quit IRC
462017-08-26T07:15:45 *** SopaXorzTaker has joined #bitcoin-core-dev
472017-08-26T08:21:23 *** promag has joined #bitcoin-core-dev
482017-08-26T08:25:36 *** promag has quit IRC
492017-08-26T08:38:55 *** nanotube has quit IRC
502017-08-26T08:49:19 *** SopaXorzTaker has quit IRC
512017-08-26T08:58:11 *** AaronvanW has joined #bitcoin-core-dev
522017-08-26T09:02:55 *** SopaXorzTaker has joined #bitcoin-core-dev
532017-08-26T09:08:29 *** promag has joined #bitcoin-core-dev
542017-08-26T09:13:09 *** nanotube has joined #bitcoin-core-dev
552017-08-26T09:21:40 *** promag has quit IRC
562017-08-26T09:22:21 *** sanada has quit IRC
572017-08-26T09:32:08 *** sanada has joined #bitcoin-core-dev
582017-08-26T09:39:49 *** nanotube has quit IRC
592017-08-26T09:50:27 *** nanotube has joined #bitcoin-core-dev
602017-08-26T10:21:32 <bitcoin-git> [bitcoin] danra opened pull request #11155: Trivial: Documentation fixes for CVectorWriter ctors (master...patch-8) https://github.com/bitcoin/bitcoin/pull/11155
612017-08-26T10:27:26 *** nanotube has quit IRC
622017-08-26T10:28:51 *** Yogaqueef has joined #bitcoin-core-dev
632017-08-26T10:29:29 <bitcoin-git> [bitcoin] danra opened pull request #11156: Fix memory leaks in qt/guiutil.cpp (master...fix/qt-guiutil-memory-leaks) https://github.com/bitcoin/bitcoin/pull/11156
642017-08-26T10:39:56 *** Yogaqueef has quit IRC
652017-08-26T10:49:08 *** nanotube has joined #bitcoin-core-dev
662017-08-26T10:55:28 *** tiagotrs has joined #bitcoin-core-dev
672017-08-26T11:00:05 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07c92b98e2a0...7fd49d01dc2e
682017-08-26T11:00:05 <bitcoin-git> bitcoin/master bc70ab5 Dan Raviv: Fix header guards using reserved identifiers...
692017-08-26T11:00:06 <bitcoin-git> bitcoin/master 7fd49d0 Wladimir J. van der Laan: Merge #11151: Fix header guards using reserved identifiers...
702017-08-26T11:00:45 <bitcoin-git> [bitcoin] laanwj closed pull request #11151: Fix header guards using reserved identifiers (master...fix/header-guards) https://github.com/bitcoin/bitcoin/pull/11151
712017-08-26T11:01:09 *** tiagotrs has quit IRC
722017-08-26T11:01:09 *** tiagotrs has joined #bitcoin-core-dev
732017-08-26T11:14:32 *** promag has joined #bitcoin-core-dev
742017-08-26T11:15:03 *** Veseli_Zagorec has joined #bitcoin-core-dev
752017-08-26T11:28:30 *** promag has quit IRC
762017-08-26T11:33:44 *** promag has joined #bitcoin-core-dev
772017-08-26T11:34:58 *** nanotube has quit IRC
782017-08-26T11:40:07 *** Dyaheon has quit IRC
792017-08-26T11:40:15 *** nanotube has joined #bitcoin-core-dev
802017-08-26T11:40:18 *** shesek has quit IRC
812017-08-26T11:41:09 *** Dyaheon has joined #bitcoin-core-dev
822017-08-26T12:03:17 *** promag has quit IRC
832017-08-26T12:12:35 <bitcoin-git> [bitcoin] danra opened pull request #11160: Tests: Improve versionbits_computeblockversion test code consistency and fix⦠(master...patch-9) https://github.com/bitcoin/bitcoin/pull/11160
842017-08-26T12:25:30 *** shesek has joined #bitcoin-core-dev
852017-08-26T12:25:30 *** shesek has joined #bitcoin-core-dev
862017-08-26T12:34:17 *** promag has joined #bitcoin-core-dev
872017-08-26T12:39:45 *** promag has quit IRC
882017-08-26T12:41:37 *** shesek has quit IRC
892017-08-26T13:04:35 *** tiagotrs has quit IRC
902017-08-26T13:04:37 *** shesek has joined #bitcoin-core-dev
912017-08-26T13:04:41 *** shesek has joined #bitcoin-core-dev
922017-08-26T13:25:40 *** Guyver2 has joined #bitcoin-core-dev
932017-08-26T13:38:37 <bitcoin-git> [bitcoin] danra opened pull request #11161: Remove redundant explicitly defined CFeeRate copy ctor. (master...fix/redundant-CFeeRate-copy-ctor) https://github.com/bitcoin/bitcoin/pull/11161
942017-08-26T13:43:30 *** Veseli_Zagorec has quit IRC
952017-08-26T13:49:06 *** Aaronvan_ has joined #bitcoin-core-dev
962017-08-26T13:49:43 *** Learner0826 has joined #bitcoin-core-dev
972017-08-26T13:51:29 *** AaronvanW has quit IRC
982017-08-26T13:56:32 *** belcher has joined #bitcoin-core-dev
992017-08-26T13:57:53 *** justanotheruser has quit IRC
1002017-08-26T13:57:57 *** Veseli_Zagorec has joined #bitcoin-core-dev
1012017-08-26T14:15:09 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1022017-08-26T14:17:25 *** Learner0826 has quit IRC
1032017-08-26T14:42:08 *** praxeology has quit IRC
1042017-08-26T14:46:28 *** cheese_ has joined #bitcoin-core-dev
1052017-08-26T14:48:33 *** Chris_Stewart_5 has quit IRC
1062017-08-26T14:50:47 *** shesek has quit IRC
1072017-08-26T14:51:21 *** belcher has quit IRC
1082017-08-26T14:55:36 *** ems has joined #bitcoin-core-dev
1092017-08-26T15:00:25 *** nemgun has joined #bitcoin-core-dev
1102017-08-26T15:01:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1112017-08-26T15:02:35 *** jtimon has joined #bitcoin-core-dev
1122017-08-26T15:06:35 *** nemgun has quit IRC
1132017-08-26T15:06:37 *** dave___ has joined #bitcoin-core-dev
1142017-08-26T15:21:29 *** Chris_St1 has joined #bitcoin-core-dev
1152017-08-26T15:21:47 *** Chris_Stewart_5 has quit IRC
1162017-08-26T15:22:04 *** shesek has joined #bitcoin-core-dev
1172017-08-26T15:27:09 *** RoyceX has joined #bitcoin-core-dev
1182017-08-26T15:30:08 *** cheese_ has quit IRC
1192017-08-26T15:35:27 *** justanotheruser has joined #bitcoin-core-dev
1202017-08-26T15:41:02 *** d9b4bef9 has quit IRC
1212017-08-26T15:47:15 *** belcher has joined #bitcoin-core-dev
1222017-08-26T15:52:45 *** Aaronvan_ has quit IRC
1232017-08-26T15:54:09 *** justanotheruser has quit IRC
1242017-08-26T15:55:17 *** promag has joined #bitcoin-core-dev
1252017-08-26T16:01:07 *** cheese_ has joined #bitcoin-core-dev
1262017-08-26T16:01:28 *** riemann has joined #bitcoin-core-dev
1272017-08-26T16:04:17 *** RoyceX has quit IRC
1282017-08-26T16:07:19 *** promag has quit IRC
1292017-08-26T16:26:28 *** RoyceX has joined #bitcoin-core-dev
1302017-08-26T16:28:50 *** cheese_ has quit IRC
1312017-08-26T16:34:36 <bitcoin-git> [bitcoin] danra opened pull request #11163: Remove redundant explicitly defined CTxMemPoolEntry copy ctor (master...fix/redundant-CTxMemPoolEntry-copy-ctor) https://github.com/bitcoin/bitcoin/pull/11163
1322017-08-26T16:37:55 *** cheese_ has joined #bitcoin-core-dev
1332017-08-26T16:40:17 *** RoyceX has quit IRC
1342017-08-26T16:40:31 *** Chris_St1 has quit IRC
1352017-08-26T16:40:41 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1362017-08-26T16:44:43 *** tiagotrs has joined #bitcoin-core-dev
1372017-08-26T16:46:52 *** AaronvanW has joined #bitcoin-core-dev
1382017-08-26T16:48:52 *** Austindoggie has joined #bitcoin-core-dev
1392017-08-26T17:01:28 *** promag has joined #bitcoin-core-dev
1402017-08-26T17:02:05 *** AaronvanW has quit IRC
1412017-08-26T17:02:57 *** Deacyded has joined #bitcoin-core-dev
1422017-08-26T17:04:47 *** AaronvanW has joined #bitcoin-core-dev
1432017-08-26T17:06:08 *** Deacydal has quit IRC
1442017-08-26T17:09:28 *** promag has quit IRC
1452017-08-26T17:14:21 *** btcdrak has quit IRC
1462017-08-26T17:17:18 *** sam_c has quit IRC
1472017-08-26T17:17:45 *** sam_c has joined #bitcoin-core-dev
1482017-08-26T17:19:09 *** Giszmo has quit IRC
1492017-08-26T17:29:37 *** riemann_ has joined #bitcoin-core-dev
1502017-08-26T17:29:37 *** riemann has quit IRC
1512017-08-26T17:48:50 *** JeremyRubin has joined #bitcoin-core-dev
1522017-08-26T17:53:25 <luke-jr> weird, I've got an apparent memory leak in custom bitcoind code, and valgrind fails to see it at all :/
1532017-08-26T17:54:40 <luke-jr> valgrind says 142 MB memory used total (incl reachable), yet ps shows 12.5 GB memory use, and if I run outside valgrind I rapidly hit swap
1542017-08-26T17:58:52 *** tiagotrs has quit IRC
1552017-08-26T18:03:36 <gmaxwell> there are allocations happening via things other than malloc (and new) so valgrind can't see them.
1562017-08-26T18:03:54 <bitcoin-git> [bitcoin] danra closed pull request #11163: Remove redundant explicitly defined CTxMemPoolEntry copy ctor (master...fix/redundant-CTxMemPoolEntry-copy-ctor) https://github.com/bitcoin/bitcoin/pull/11163
1572017-08-26T18:04:41 <gmaxwell> are you sure it's allocations and not mmaped files
1582017-08-26T18:06:25 <luke-jr> gmaxwell: well, things get real slow when I begin swapping
1592017-08-26T18:06:39 <luke-jr> I'd expect mmap can't do that
1602017-08-26T18:10:38 <luke-jr> thankfully, the actual code being executed is relatively small, I guess I can just start commenting out parts to see where the culprit is
1612017-08-26T18:10:51 <luke-jr> (the wallet rescan logic specifically)
1622017-08-26T18:13:39 <luke-jr> curiously, valgrind did report: crypto/common.h:48:22: runtime error: load of misaligned address 0x000046682d26 for type 'uint32_t', which requires 4 byte alignment
1632017-08-26T18:13:45 *** GAit has quit IRC
1642017-08-26T18:14:05 <luke-jr> and it looks like our SHA2 code does such access without checking alignment. wonder why it works.
1652017-08-26T18:14:29 <luke-jr> (but this is an older codebase, maybe already changed)
1662017-08-26T18:14:33 *** belcher has quit IRC
1672017-08-26T18:14:44 *** Giszmo has joined #bitcoin-core-dev
1682017-08-26T18:15:16 *** justanotheruser has joined #bitcoin-core-dev
1692017-08-26T18:16:15 *** justanotheruser has quit IRC
1702017-08-26T18:16:35 *** justanotheruser has joined #bitcoin-core-dev
1712017-08-26T18:17:05 <gmaxwell> that should be fixed. alignment isn't required on x86, so it works even though its undefined behavior.
1722017-08-26T18:19:04 <sipa> luke-jr: which function is that?
1732017-08-26T18:19:17 <luke-jr> SSSE3 definitely segfaulted when not aligned on my Haswell CPU, but that's another specific case :p
1742017-08-26T18:19:27 <sipa> last line of WriteLE32 ?
1752017-08-26T18:19:27 <luke-jr> sipa: ReadBE32
1762017-08-26T18:20:06 <sipa> what version is that?
1772017-08-26T18:20:40 <luke-jr> 0.13.2-based
1782017-08-26T18:20:46 <luke-jr> I think this is a close stack http://codepad.org/oA6M1Oef
1792017-08-26T18:21:10 <sipa> fixed in #9512
1802017-08-26T18:22:34 <gmaxwell> luke-jr: yes, unaligned aligned simd reads can crash on x86.
1812017-08-26T18:23:12 <luke-jr> gmaxwell: the fun part of that was that glibc did it for memcpy XD
1822017-08-26T18:23:32 * luke-jr ended up just adding -mno-ssse3 to his CFLAGS
1832017-08-26T18:24:14 <gmaxwell> wtf. memcpy has no alignment requirements.
1842017-08-26T18:26:52 <sipa> gmaxwell: but memcpy may be implemented by casting pointers to int pointers and then assigning
1852017-08-26T18:26:59 <sipa> (i assume that's what luke meant)
1862017-08-26T18:27:29 <luke-jr> right
1872017-08-26T18:30:41 * luke-jr should set a ulimit so he can test this without his system coming to a crawl when he steps away for a second :|
1882017-08-26T18:46:53 *** GAit has joined #bitcoin-core-dev
1892017-08-26T18:52:14 *** promag has joined #bitcoin-core-dev
1902017-08-26T18:54:33 *** promag has quit IRC
1912017-08-26T19:01:08 *** praxeology has joined #bitcoin-core-dev
1922017-08-26T19:03:32 *** Tia has quit IRC
1932017-08-26T19:05:00 <bitcoin-git> [bitcoin] danra opened pull request #11164: Fix boost headers included as user instead of system headers (master...fix/boost-system-includes) https://github.com/bitcoin/bitcoin/pull/11164
1942017-08-26T19:06:07 *** promag has joined #bitcoin-core-dev
1952017-08-26T19:21:50 *** Chris_Stewart_5 has quit IRC
1962017-08-26T19:22:09 *** d9b4bef9 has joined #bitcoin-core-dev
1972017-08-26T19:23:17 *** jtimon has quit IRC
1982017-08-26T19:37:25 *** SopaXorzTaker has quit IRC
1992017-08-26T19:42:41 *** justanotheruser has quit IRC
2002017-08-26T19:45:36 *** adiabat has quit IRC
2012017-08-26T19:47:41 *** Veseli_Zagorec has quit IRC
2022017-08-26T19:52:00 *** promag has quit IRC
2032017-08-26T20:13:46 *** chjj has quit IRC
2042017-08-26T20:22:26 *** ekerstein has joined #bitcoin-core-dev
2052017-08-26T20:36:21 *** shesek has quit IRC
2062017-08-26T20:44:01 *** AaronvanW has quit IRC
2072017-08-26T20:44:39 *** AaronvanW has joined #bitcoin-core-dev
2082017-08-26T20:49:07 *** ekerstein has quit IRC
2092017-08-26T20:56:55 *** Guyver2 has quit IRC
2102017-08-26T21:10:34 *** shesek has joined #bitcoin-core-dev
2112017-08-26T21:10:34 *** shesek has joined #bitcoin-core-dev
2122017-08-26T21:17:30 *** chjj has joined #bitcoin-core-dev
2132017-08-26T21:28:45 *** telberrak has joined #bitcoin-core-dev
2142017-08-26T21:33:34 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2152017-08-26T21:50:57 *** bytting has joined #bitcoin-core-dev
2162017-08-26T21:54:08 *** cheese_ has quit IRC
2172017-08-26T21:54:31 *** adiabat has joined #bitcoin-core-dev
2182017-08-26T21:58:24 *** cheese_ has joined #bitcoin-core-dev
2192017-08-26T22:03:45 *** cheese_ has quit IRC
2202017-08-26T22:05:42 *** riemann_ has quit IRC
2212017-08-26T22:06:57 *** Chris_Stewart_5 has quit IRC
2222017-08-26T22:13:04 *** btcdrak has joined #bitcoin-core-dev
2232017-08-26T22:18:43 <bitcoin-git> [bitcoin] sipa opened pull request #11167: Full BIP173 (Bech32) support (master...201708_bech32) https://github.com/bitcoin/bitcoin/pull/11167
2242017-08-26T22:20:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2252017-08-26T22:23:56 *** Renee has joined #bitcoin-core-dev
2262017-08-26T22:29:17 *** Chris_Stewart_5 has quit IRC
2272017-08-26T22:43:01 *** Renee has quit IRC
2282017-08-26T22:44:29 *** targon has joined #bitcoin-core-dev
2292017-08-26T23:10:59 <luke-jr> oh. it seems -fsanitize=undefined causes the memory leak -.-
2302017-08-26T23:11:22 <gmaxwell> that isn't a memory leak.
2312017-08-26T23:11:44 <gmaxwell> msan needs scads of virtual address space and a fair amount of ram.
2322017-08-26T23:11:54 <luke-jr> gmaxwell: over 20 GB?
2332017-08-26T23:12:15 <luke-jr> also, this is undefined sanitizer, not msan <.<
2342017-08-26T23:12:22 *** justanotheruser has joined #bitcoin-core-dev
2352017-08-26T23:12:23 <gmaxwell> same reason.
2362017-08-26T23:12:36 <gmaxwell> I've seen it get up to a petabyte of virt.
2372017-08-26T23:12:50 <luke-jr> it wasn't merely virt
2382017-08-26T23:12:54 <gmaxwell> (oh actually no, .1 PB)
2392017-08-26T23:13:03 <gmaxwell> yes, it uses a lot more RES too...
2402017-08-26T23:13:51 *** justanotheruser has quit IRC
2412017-08-26T23:13:53 <luke-jr> kinda makes it useless :/
2422017-08-26T23:14:11 *** justanotheruser has joined #bitcoin-core-dev
2432017-08-26T23:15:03 <gmaxwell> have more ram...
2442017-08-26T23:15:55 <luke-jr> UBSAN claims "The checks have small runtime costâ¦"
2452017-08-26T23:17:19 <gmaxwell> hm. I was confused above, I thought you were using asan. I'm not aware of undefined using a lot of ram.
2462017-08-26T23:17:35 *** chjj has quit IRC
2472017-08-26T23:19:32 *** bytting has quit IRC
2482017-08-26T23:19:37 <gmaxwell> jonasschnelli: I just had someone on IRC that had their GUI not displaying after upgrading to 0.14.2 ... this fixed it https://github.com/bitcoin/bitcoin/issues/7869#issuecomment-209265754 is there some underlying bug we need to fix?
2492017-08-26T23:25:20 *** Deacydal has joined #bitcoin-core-dev
2502017-08-26T23:28:20 *** justanotheruser has quit IRC
2512017-08-26T23:28:35 *** Deacyded has quit IRC
2522017-08-26T23:28:39 *** justanotheruser has joined #bitcoin-core-dev
2532017-08-26T23:28:55 <Lightsword> do we need to bump the OSX SDK version? I think itâs on 10.11 which doesnât seem to have getentropy
2542017-08-26T23:33:20 *** Cryptocide has quit IRC
2552017-08-26T23:33:39 *** justanotheruser has quit IRC
2562017-08-26T23:33:54 *** Cryptocide has joined #bitcoin-core-dev
2572017-08-26T23:33:58 *** justanotheruser has joined #bitcoin-core-dev
2582017-08-26T23:57:50 *** telberrak has quit IRC