12017-09-06T00:04:37 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/28485c783d82...6866b4912b80
22017-09-06T00:04:37 <bitcoin-git> bitcoin/master 352d582 Marko Bencun: Add vConnect to CConnman::Options...
32017-09-06T00:04:38 <bitcoin-git> bitcoin/master 6866b49 Wladimir J. van der Laan: Merge #10596: Add vConnect to CConnman::Options...
42017-09-06T00:04:57 <bitcoin-git> [bitcoin] laanwj closed pull request #10596: Add vConnect to CConnman::Options (master...connmanoptions_connect) https://github.com/bitcoin/bitcoin/pull/10596
52017-09-06T00:06:46 *** Chris_Stewart_5 has joined #bitcoin-core-dev
62017-09-06T00:08:25 <bitcoin-git> [bitcoin] jtimon closed pull request #10822: RPC: Also serve txo from gettxout (not just utxo and mempool) (master...b15-rpc-txo) https://github.com/bitcoin/bitcoin/pull/10822
72017-09-06T00:12:23 *** Murch has joined #bitcoin-core-dev
82017-09-06T00:16:54 <esotericnonsense> a question which I think is related to core dev, apologies if not
92017-09-06T00:17:12 <esotericnonsense> so the RPC interface should only be exposed to trusted clients in the sense of wallet commands etc
102017-09-06T00:17:54 <esotericnonsense> however, is it otherwise expected to be hardened? e.g. if I have some software running in a VM or on another machine, and give it access to the RPC, would it be reasonable to assume that it shouldn't be able to raise privileges and execute commands on the host
112017-09-06T00:18:31 <esotericnonsense> (basically, if i'm -disablewalleted, should I worry about anything other than possible DoS
122017-09-06T00:22:45 <jonasschnelli> esotericnonsense: Even without your wallet enabled you should threat your RPC interface private.
132017-09-06T00:22:56 *** Chris_Stewart_5 has quit IRC
142017-09-06T00:23:09 <jonasschnelli> If you want to access it remotely, use VPN, SSH, stunnel or something.
152017-09-06T00:23:29 <jonasschnelli> Don't expose the RPC interface to the public internet
162017-09-06T00:23:48 <esotericnonsense> jonasschnelli: indeed. i suppose essentially what i'm wondering is how carefully I need to vet software which interfaces with the RPC.
172017-09-06T00:23:52 <jonasschnelli> (you could use an Apache or so reverse proxy with SSL auth)
182017-09-06T00:24:20 <jonasschnelli> I would do it carefully... use a VPN, reverse proxy or connect via SSH and use bitcoin-cli
192017-09-06T00:24:31 <esotericnonsense> for example, core node running on host1, host2 runs some software which interfaces with host1, but host2 is malicious for whatever reason; can host1 be broken into (overflows on rpc commands, etc)
202017-09-06T00:25:06 <esotericnonsense> i guess the actual answer is to run the core node in a sandbox to avoid this coming up at all
212017-09-06T00:25:52 <jonasschnelli> if host2 is assumed to be malicious then it should not be capable to access to the RPC interface
222017-09-06T00:26:18 <esotericnonsense> understood
232017-09-06T00:26:55 <esotericnonsense> for reference i'm going to play around with writing some nodejs code to interface with the RPC and I find npm an utter clusterf.ck to deal with in terms of security :P
242017-09-06T00:34:28 <bitcoin-git> [bitcoin] instagibbs opened pull request #11252: when clearing addrman clear mapInfo and mapAddr (master...recreateaddrman) https://github.com/bitcoin/bitcoin/pull/11252
252017-09-06T00:40:28 *** Murch has quit IRC
262017-09-06T00:47:50 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #11253: Add != to Base58 class (master...add_neq_ctxdest) https://github.com/bitcoin/bitcoin/pull/11253
272017-09-06T01:00:49 *** Dyaheon has quit IRC
282017-09-06T01:04:52 *** Dyaheon has joined #bitcoin-core-dev
292017-09-06T01:05:59 *** Deacydal has quit IRC
302017-09-06T01:09:10 *** dabura667 has joined #bitcoin-core-dev
312017-09-06T01:16:27 *** Deacyde has joined #bitcoin-core-dev
322017-09-06T01:21:01 *** AaronvanW has quit IRC
332017-09-06T01:23:44 *** Deacyde has quit IRC
342017-09-06T01:23:49 *** cam9956 has joined #bitcoin-core-dev
352017-09-06T01:23:58 <cam9956> hello! anybody there?
362017-09-06T01:24:19 <cam9956> i need some help
372017-09-06T01:24:48 <cam9956> _flow_ are you there?
382017-09-06T01:25:05 <meshcollider> Hi, what do you need help with?
392017-09-06T01:26:17 <cam9956> i had a question, when i relese the coin does it have to be mined for anybody to get some or when i release it i get a few coins to sell out
402017-09-06T01:27:03 <meshcollider> This channel is for discussion about bitcoin core development sorry, try #bitcoin or https://bitcoin.stackexchange.com/
412017-09-06T01:27:49 <cam9956> yeah this is about bitcoin, i want to devalop my own coin with the bitcoin source
422017-09-06T01:28:16 <meshcollider> Again, this is for bitcoin *core* development, not general questions sorry :)
432017-09-06T01:29:00 <cam9956> what do you mean by "core development" and is there a irc i can contact for this?
442017-09-06T01:30:02 <praxeology> cam9956: probably #bitcoin would be your best bet
452017-09-06T01:30:23 <cam9956> ok
462017-09-06T01:30:28 <praxeology> oh, your own coin
472017-09-06T01:30:47 <cam9956> yeah with the bitcoin source code
482017-09-06T01:31:07 <praxeology> go to #yet_another_bitcoin_fork
492017-09-06T01:31:12 <cam9956> basically distributing
502017-09-06T01:31:23 <cam9956> as the channel?
512017-09-06T01:33:47 <Chicago> cam9956, They're saying go find another channel because clone coins are off-topic for here as they do not generally pertain to Bitcoin Core development.
522017-09-06T01:34:27 <cam9956> what is bitcoin "core development" though
532017-09-06T01:35:27 <meshcollider> Bitcoin Core is the reference client for bitcoin
542017-09-06T01:35:56 <cam9956> oh ok bye!
552017-09-06T01:36:08 *** cam9956 has quit IRC
562017-09-06T01:36:18 *** promag has quit IRC
572017-09-06T01:37:53 *** cam8857_ has joined #bitcoin-core-dev
582017-09-06T01:37:57 <cam8857_> when i release the coin does it have to be mined for anybody to get some or when i release it i get a few coins to sell out?
592017-09-06T01:39:39 <Chicago> cam8857_, you can have a 100% premine. Just let us know when you release so that we can buy them on the open market.
602017-09-06T01:39:43 <Chicago> <.<
612017-09-06T01:39:47 <Chicago> >.>
622017-09-06T01:40:06 <cam8857_> premine? what do you mean?
632017-09-06T01:41:54 <cam8857_> ohh wait im in the wrong irc...
642017-09-06T01:48:56 *** cam8857_ has quit IRC
652017-09-06T01:52:48 *** dcousens has joined #bitcoin-core-dev
662017-09-06T02:06:20 *** afk11 has quit IRC
672017-09-06T02:10:41 *** afk11 has joined #bitcoin-core-dev
682017-09-06T02:25:20 *** Deacyde has joined #bitcoin-core-dev
692017-09-06T02:30:05 *** promag has joined #bitcoin-core-dev
702017-09-06T02:34:29 *** promag has quit IRC
712017-09-06T02:50:04 *** Chris_Stewart_5 has joined #bitcoin-core-dev
722017-09-06T02:51:08 *** chjj has quit IRC
732017-09-06T02:54:45 *** chjj has joined #bitcoin-core-dev
742017-09-06T02:56:42 *** Chris_Stewart_5 has quit IRC
752017-09-06T03:01:51 *** hxz has joined #bitcoin-core-dev
762017-09-06T03:07:05 *** Dyaheon has quit IRC
772017-09-06T03:09:00 *** Dyaheon has joined #bitcoin-core-dev
782017-09-06T03:23:30 *** PRab has joined #bitcoin-core-dev
792017-09-06T03:24:03 *** ula has quit IRC
802017-09-06T03:26:12 *** PRab has quit IRC
812017-09-06T03:27:36 *** PRab has joined #bitcoin-core-dev
822017-09-06T03:29:36 *** promag has joined #bitcoin-core-dev
832017-09-06T03:34:34 *** promag has quit IRC
842017-09-06T03:39:36 *** qrestlove has quit IRC
852017-09-06T03:45:35 *** hxz has quit IRC
862017-09-06T04:02:55 *** qrestlove has joined #bitcoin-core-dev
872017-09-06T04:15:54 *** Gunnie has joined #bitcoin-core-dev
882017-09-06T04:20:50 *** RubenSomsen has joined #bitcoin-core-dev
892017-09-06T04:21:45 *** Gunnie has quit IRC
902017-09-06T04:24:01 *** Alina-malina has quit IRC
912017-09-06T04:29:36 *** Alina-malina has joined #bitcoin-core-dev
922017-09-06T04:51:55 *** meshcollider has quit IRC
932017-09-06T05:00:19 *** Alina-malina has quit IRC
942017-09-06T05:00:19 *** Alina-malina has joined #bitcoin-core-dev
952017-09-06T05:01:31 * kallewoof pokes Travis with a stick.
962017-09-06T05:02:01 *** Cory has quit IRC
972017-09-06T05:08:03 *** Gunnie has joined #bitcoin-core-dev
982017-09-06T05:17:47 *** promag has joined #bitcoin-core-dev
992017-09-06T05:18:16 *** meshcollider has joined #bitcoin-core-dev
1002017-09-06T05:22:10 *** promag has quit IRC
1012017-09-06T05:47:48 *** Murch has joined #bitcoin-core-dev
1022017-09-06T05:54:38 *** Jey has joined #bitcoin-core-dev
1032017-09-06T05:54:41 <dcousens> am I missing something in https://github.com/bitcoin/bitcoin/pull/11201#issuecomment-327379774 ?
1042017-09-06T05:58:40 <kallewoof> signraw works but sendraw fails in some cases.
1052017-09-06T05:59:01 <kallewoof> This function is supposed to find those cases and tell you without actually sending the tx to the network.
1062017-09-06T05:59:03 <dcousens> kallewoof: right, but the OP doesn't want to send at all, so that is OK?
1072017-09-06T05:59:16 <dcousens> signraw doesn't send either
1082017-09-06T05:59:18 <dcousens> ?
1092017-09-06T05:59:58 <kallewoof> Idea is, you sign, then you verify and if everything is cool you do whatever other last minute checks (double check addy or such) and then you finally sendraw.
1102017-09-06T06:00:18 <kallewoof> Or you mkae a tx using custom software and you just wanna see if it will relay without actually sending it.
1112017-09-06T06:00:24 <kallewoof> (signing using said custom sw)
1122017-09-06T06:00:34 <dcousens> kallewoof: right, but you can still use signrawtransaction in the custom software case
1132017-09-06T06:00:39 <dcousens> (I do)
1142017-09-06T06:01:21 *** jtimon has quit IRC
1152017-09-06T06:01:35 <dcousens> I leave the private keys blank, and don't have a bitcoind w/ wallet support, and it verifies whether the tx is complete or has errors etc
1162017-09-06T06:05:17 <dcousens> kallewoof: eg I just created a tx with bitcoinjs, signed it using bitcoinjs, then signrawtx [txhex, inputs, []], complete: true, then I modified inputs to have a different id, same txhex, and I get a checksig error
1172017-09-06T06:08:09 *** Murch has quit IRC
1182017-09-06T06:11:33 <kallewoof> dcounsens: there are cases where signraw succeeds and sendraw fails, though. This is meant to catch those. Am I misundersatnding you?
1192017-09-06T06:12:23 <dcousens> kallewoof: right, signraw will fail for policy reasons, which is why I suggested, why not just a policy check flag?
1202017-09-06T06:12:35 <dcousens> rather than a new RPC command
1212017-09-06T06:12:40 <dcousens> uh, won't fail***
1222017-09-06T06:12:46 <dcousens> signraw won't fail for policy reasons
1232017-09-06T06:13:38 <sipa> signraw _only_ checks script validity
1242017-09-06T06:13:43 <sipa> not transaction validity
1252017-09-06T06:14:35 <sipa> things like locktime, feerate, inputs unspent, input value >= output value, ...
1262017-09-06T06:14:42 <sipa> that's not just policy
1272017-09-06T06:15:52 <dcousens> ok
1282017-09-06T06:16:19 <dcousens> ta :), i'll modify my reply
1292017-09-06T06:17:17 *** promag has joined #bitcoin-core-dev
1302017-09-06T06:18:28 <dcousens> ta sipa
1312017-09-06T06:18:35 <dcousens> (and kallewoof )
1322017-09-06T06:21:38 *** promag has quit IRC
1332017-09-06T06:48:23 *** DrOlmer has joined #bitcoin-core-dev
1342017-09-06T06:50:05 *** BashCo has quit IRC
1352017-09-06T06:56:03 *** DrOlmer has quit IRC
1362017-09-06T06:56:32 *** LeMiner has joined #bitcoin-core-dev
1372017-09-06T07:02:52 *** promag has joined #bitcoin-core-dev
1382017-09-06T07:04:51 *** promag has quit IRC
1392017-09-06T07:12:17 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #11253: Add != to Base58 class (master...add_neq_ctxdest) https://github.com/bitcoin/bitcoin/pull/11253
1402017-09-06T07:13:11 *** BashCo has joined #bitcoin-core-dev
1412017-09-06T07:20:04 *** arubi has quit IRC
1422017-09-06T07:20:32 *** arubi has joined #bitcoin-core-dev
1432017-09-06T07:25:13 *** promag has joined #bitcoin-core-dev
1442017-09-06T07:28:47 <promag> sipa: isn´t this https://github.com/bitcoin/bitcoin/pull/11117/files#r137145517 worth the change?
1452017-09-06T07:33:10 *** promag has quit IRC
1462017-09-06T07:34:48 *** timothy has joined #bitcoin-core-dev
1472017-09-06T07:38:35 *** laurentmt has joined #bitcoin-core-dev
1482017-09-06T07:39:07 *** laurentmt has quit IRC
1492017-09-06T07:40:41 *** promag has joined #bitcoin-core-dev
1502017-09-06T07:46:30 *** promag has quit IRC
1512017-09-06T07:52:02 *** hxz has joined #bitcoin-core-dev
1522017-09-06T07:56:36 *** paveljanik has joined #bitcoin-core-dev
1532017-09-06T07:57:52 *** RubenSomsen has quit IRC
1542017-09-06T07:59:31 *** promag has joined #bitcoin-core-dev
1552017-09-06T08:04:26 *** promag has quit IRC
1562017-09-06T08:25:24 *** AaronvanW has joined #bitcoin-core-dev
1572017-09-06T08:30:05 *** AaronvanW has quit IRC
1582017-09-06T08:33:21 *** Cory has joined #bitcoin-core-dev
1592017-09-06T08:42:06 *** RubenSomsen has joined #bitcoin-core-dev
1602017-09-06T08:52:38 *** laurentmt has joined #bitcoin-core-dev
1612017-09-06T08:53:12 *** laurentmt has quit IRC
1622017-09-06T08:55:12 *** promag has joined #bitcoin-core-dev
1632017-09-06T08:59:46 *** promag has quit IRC
1642017-09-06T09:02:20 *** AaronvanW has joined #bitcoin-core-dev
1652017-09-06T09:12:13 *** Aaronvan_ has joined #bitcoin-core-dev
1662017-09-06T09:15:22 *** AaronvanW has quit IRC
1672017-09-06T09:19:05 *** ula has joined #bitcoin-core-dev
1682017-09-06T09:31:36 *** hxz has quit IRC
1692017-09-06T09:45:24 *** Jey has quit IRC
1702017-09-06T09:54:03 *** Gunnie has quit IRC
1712017-09-06T10:08:56 *** promag has joined #bitcoin-core-dev
1722017-09-06T10:17:52 *** promag has quit IRC
1732017-09-06T10:23:59 *** Ankush has joined #bitcoin-core-dev
1742017-09-06T10:30:14 *** Ankush has quit IRC
1752017-09-06T10:31:16 <bitcoin-git> [bitcoin] ysangkok opened pull request #11255: Release Notes: Fix SHA256-with-SSE4 PR link (0.15...patch-1) https://github.com/bitcoin/bitcoin/pull/11255
1762017-09-06T10:36:26 *** laurentmt has joined #bitcoin-core-dev
1772017-09-06T10:58:57 *** paveljanik has quit IRC
1782017-09-06T10:59:24 *** paveljanik has joined #bitcoin-core-dev
1792017-09-06T11:03:27 *** paveljanik has quit IRC
1802017-09-06T11:03:51 *** promag has joined #bitcoin-core-dev
1812017-09-06T11:04:16 *** marcus-doodley has joined #bitcoin-core-dev
1822017-09-06T11:07:56 *** promag has quit IRC
1832017-09-06T11:09:07 <bitcoin-git> [bitcoin] esotericnonsense opened pull request #11256: RPC: add weight to mempool entry output (master...2017-09-add-weight-to-mempool-entry) https://github.com/bitcoin/bitcoin/pull/11256
1842017-09-06T11:10:57 *** Aaronvan_ has quit IRC
1852017-09-06T11:11:37 *** AaronvanW has joined #bitcoin-core-dev
1862017-09-06T11:18:39 *** marcus-doodley is now known as halform
1872017-09-06T11:18:53 *** halform has quit IRC
1882017-09-06T11:19:25 *** halform has joined #bitcoin-core-dev
1892017-09-06T11:23:23 *** halform has quit IRC
1902017-09-06T11:23:53 *** halform has joined #bitcoin-core-dev
1912017-09-06T11:37:36 *** halform has quit IRC
1922017-09-06T11:46:17 *** SopaXorzTaker has joined #bitcoin-core-dev
1932017-09-06T11:46:57 *** wxxs has joined #bitcoin-core-dev
1942017-09-06T11:48:49 *** RubenSomsen has quit IRC
1952017-09-06T11:49:54 *** laurentmt has quit IRC
1962017-09-06T11:52:39 *** LampTreadStone07 has joined #bitcoin-core-dev
1972017-09-06T11:54:12 *** LampTreadStone07 has quit IRC
1982017-09-06T11:55:23 *** RubenSomsen has joined #bitcoin-core-dev
1992017-09-06T11:58:15 *** LampTreadStone07 has joined #bitcoin-core-dev
2002017-09-06T12:07:19 *** Gunnie has joined #bitcoin-core-dev
2012017-09-06T12:13:36 *** LampTreadStone07 has quit IRC
2022017-09-06T12:18:32 *** halform has joined #bitcoin-core-dev
2032017-09-06T12:20:29 *** Orion3k has quit IRC
2042017-09-06T12:21:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2052017-09-06T12:22:46 *** Orion3k has joined #bitcoin-core-dev
2062017-09-06T12:29:30 *** dabura667 has quit IRC
2072017-09-06T12:38:22 *** promag has joined #bitcoin-core-dev
2082017-09-06T12:55:19 *** Guyver2 has joined #bitcoin-core-dev
2092017-09-06T12:55:35 *** jtimon has joined #bitcoin-core-dev
2102017-09-06T13:05:10 *** Chris_Stewart_5 has quit IRC
2112017-09-06T13:19:18 *** jtimon has quit IRC
2122017-09-06T13:19:47 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2132017-09-06T13:28:50 *** Murch has joined #bitcoin-core-dev
2142017-09-06T13:35:08 *** Dizzle has joined #bitcoin-core-dev
2152017-09-06T13:49:34 *** shesek has joined #bitcoin-core-dev
2162017-09-06T13:49:41 *** shesek has joined #bitcoin-core-dev
2172017-09-06T13:51:49 *** ChickenMustNotDi has joined #bitcoin-core-dev
2182017-09-06T13:53:46 *** ChickenMustNotDi has quit IRC
2192017-09-06T14:00:55 *** halform has quit IRC
2202017-09-06T14:05:49 *** Ruben has joined #bitcoin-core-dev
2212017-09-06T14:06:21 *** RubenSomsen has quit IRC
2222017-09-06T14:13:34 *** Gunnie has quit IRC
2232017-09-06T14:15:09 *** ensign has quit IRC
2242017-09-06T14:21:21 *** Dyaheon has quit IRC
2252017-09-06T14:21:51 *** Dyaheon has joined #bitcoin-core-dev
2262017-09-06T14:22:05 *** Chris_Stewart_5 has quit IRC
2272017-09-06T14:23:40 *** Murch has quit IRC
2282017-09-06T14:25:59 *** ensign has joined #bitcoin-core-dev
2292017-09-06T14:51:44 *** dcousens has quit IRC
2302017-09-06T14:58:18 *** chjj has quit IRC
2312017-09-06T15:02:24 *** Ylbam has joined #bitcoin-core-dev
2322017-09-06T15:11:55 *** meshcollider has quit IRC
2332017-09-06T15:13:45 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2342017-09-06T15:16:38 *** halform has joined #bitcoin-core-dev
2352017-09-06T15:34:11 *** halform_ has joined #bitcoin-core-dev
2362017-09-06T15:36:35 *** halform has quit IRC
2372017-09-06T15:37:38 *** BashCo has quit IRC
2382017-09-06T15:38:14 *** BashCo has joined #bitcoin-core-dev
2392017-09-06T15:42:27 *** BashCo has quit IRC
2402017-09-06T16:00:25 <promag> MarcoFalke: done https://github.com/bitcoin/bitcoin/pull/11125
2412017-09-06T16:01:08 *** Gunnie has joined #bitcoin-core-dev
2422017-09-06T16:01:12 *** jtimon has joined #bitcoin-core-dev
2432017-09-06T16:04:47 *** halform_ has quit IRC
2442017-09-06T16:05:35 *** Gunnie has quit IRC
2452017-09-06T16:08:22 <MarcoFalke> promag: Great. Going to take a look today
2462017-09-06T16:12:25 *** Murch has joined #bitcoin-core-dev
2472017-09-06T16:14:00 <promag> MarcoFalke: review commit by commit, I think it's the best. I'll be around if you need to discuss it.
2482017-09-06T16:18:11 *** promag has quit IRC
2492017-09-06T16:22:19 *** halform has joined #bitcoin-core-dev
2502017-09-06T16:25:58 *** BashCo has joined #bitcoin-core-dev
2512017-09-06T16:35:10 *** halform has quit IRC
2522017-09-06T16:38:53 *** promag has joined #bitcoin-core-dev
2532017-09-06T16:39:14 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/48790e0efaf4...134d824193a0
2542017-09-06T16:39:14 <bitcoin-git> bitcoin/0.15 58f1e54 Janus Troelsen: Release Notes: Fix SHA256-with-SSE4 PR link
2552017-09-06T16:39:15 <bitcoin-git> bitcoin/0.15 134d824 Wladimir J. van der Laan: Merge #11255: Release Notes: Fix SHA256-with-SSE4 PR link...
2562017-09-06T16:43:16 *** promag has quit IRC
2572017-09-06T16:50:41 *** AaronvanW has quit IRC
2582017-09-06T16:54:13 *** halform has joined #bitcoin-core-dev
2592017-09-06T17:01:40 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6866b4912b80...815fe62421cb
2602017-09-06T17:01:41 <bitcoin-git> bitcoin/master 0311836 Suhas Daftuar: Allow setting nMinimumChainWork on command line
2612017-09-06T17:01:41 <bitcoin-git> bitcoin/master eac64bb Suhas Daftuar: [qa] Test nMinimumChainWork...
2622017-09-06T17:01:42 <bitcoin-git> bitcoin/master 815fe62 Wladimir J. van der Laan: Merge #10357: Allow setting nMinimumChainWork on command line...
2632017-09-06T17:02:00 <bitcoin-git> [bitcoin] laanwj closed pull request #10357: Allow setting nMinimumChainWork on command line (master...2017-05-chainwork-commandline) https://github.com/bitcoin/bitcoin/pull/10357
2642017-09-06T17:07:27 *** halform has quit IRC
2652017-09-06T17:09:00 *** Gunnie has joined #bitcoin-core-dev
2662017-09-06T17:09:29 *** halform has joined #bitcoin-core-dev
2672017-09-06T17:12:08 *** Ylbam has quit IRC
2682017-09-06T17:19:55 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/815fe62421cb...5368614aa106
2692017-09-06T17:19:56 <bitcoin-git> bitcoin/master dea086f MeshCollider: Stop test_bitcoin-qt touching ~/.bitcoin
2702017-09-06T17:19:56 <bitcoin-git> bitcoin/master 5368614 Wladimir J. van der Laan: Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin...
2712017-09-06T17:20:08 *** AaronvanW has joined #bitcoin-core-dev
2722017-09-06T17:20:35 <bitcoin-git> [bitcoin] laanwj closed pull request #11210: Stop test_bitcoin-qt touching ~/.bitcoin (master...201708_qt_test_dir) https://github.com/bitcoin/bitcoin/pull/11210
2732017-09-06T17:21:50 *** Provoostenator has joined #bitcoin-core-dev
2742017-09-06T17:25:45 *** chjj has joined #bitcoin-core-dev
2752017-09-06T17:26:36 *** Gunnie has joined #bitcoin-core-dev
2762017-09-06T17:33:53 *** Gunnie has quit IRC
2772017-09-06T17:39:46 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5368614aa106...21e2f2f79961
2782017-09-06T17:39:47 <bitcoin-git> bitcoin/master 62ecce7 João Barbosa: [doc] Add RPC response notes
2792017-09-06T17:39:47 <bitcoin-git> bitcoin/master 21e2f2f Wladimir J. van der Laan: Merge #11135: Update developer notes with RPC response guidelines...
2802017-09-06T17:40:26 <bitcoin-git> [bitcoin] laanwj closed pull request #11135: Update developer notes with RPC response guidelines (master...2017-08-rpc-response-notes) https://github.com/bitcoin/bitcoin/pull/11135
2812017-09-06T17:40:41 *** promag has joined #bitcoin-core-dev
2822017-09-06T17:43:51 *** kinlo has quit IRC
2832017-09-06T17:45:06 *** promag has quit IRC
2842017-09-06T17:45:23 *** kinlo has joined #bitcoin-core-dev
2852017-09-06T17:46:15 *** halform has quit IRC
2862017-09-06T17:52:08 *** AaronvanW has quit IRC
2872017-09-06T17:58:43 *** SopaXorzTaker has quit IRC
2882017-09-06T18:04:23 *** Provoostenator has quit IRC
2892017-09-06T18:05:58 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/21e2f2f79961...31809d6f8514
2902017-09-06T18:05:59 <bitcoin-git> bitcoin/master faa8d95 MarcoFalke: [qa] TestNode: Add wait_until_stopped helper method
2912017-09-06T18:05:59 <bitcoin-git> bitcoin/master 31809d6 MarcoFalke: Merge #11067: [qa] TestNode: Add wait_until_stopped helper method...
2922017-09-06T18:06:22 *** AaronvanW has joined #bitcoin-core-dev
2932017-09-06T18:06:37 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11067: [qa] TestNode: Add wait_until_stopped helper method (master...Mf1708-qaTestnodeWaitStopHelper) https://github.com/bitcoin/bitcoin/pull/11067
2942017-09-06T18:14:53 <bitcoin-git> [bitcoin] jnewbery opened pull request #11258: [WIP] [rpc] Add initialblockdownload to getblockchaininfo (master...expose_ibd) https://github.com/bitcoin/bitcoin/pull/11258
2952017-09-06T18:15:51 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/31809d6f8514...59e17899a762
2962017-09-06T18:15:51 <bitcoin-git> bitcoin/master 37495e0 Jeremy Rubin: Reorder C{,Mutable}Transaction for better packing
2972017-09-06T18:15:52 <bitcoin-git> bitcoin/master 59e1789 Wladimir J. van der Laan: Merge #8330: Structure Packing Optimizations in C{,Mutable}Transaction...
2982017-09-06T18:17:05 *** bitsegwit has quit IRC
2992017-09-06T18:20:43 *** AaronvanW has quit IRC
3002017-09-06T18:22:57 *** Chris_Stewart_5 has quit IRC
3012017-09-06T18:24:39 *** AaronvanW has joined #bitcoin-core-dev
3022017-09-06T18:54:15 <GAit> is github user promag in IRC?
3032017-09-06T18:54:32 <GAit> oh he usually is just not now, fair enough
3042017-09-06T18:54:33 <sipa> sometimes
3052017-09-06T18:55:01 *** promag has joined #bitcoin-core-dev
3062017-09-06T18:55:10 <sipa> he's here now :p
3072017-09-06T18:55:14 <promag> :)
3082017-09-06T18:55:14 <promag> ´
3092017-09-06T18:55:21 <promag> sup?
3102017-09-06T18:55:45 <promag> GAit: need something?
3112017-09-06T18:57:14 <GAit> oh I just wanted to say I am not ignoring your suggestion re: 11099 with the multiple failure modes of DumpMempool, i.e. the test doesn't exercise the "return false" within the exception handler but i think that's much harder to cause and i wanted to minimize changes to DumpMempool or how it affects other callers
3122017-09-06T18:57:26 <GAit> and also i wanted to thank you for all the feedback, very valuable
3132017-09-06T18:58:33 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/59e17899a762...d745b4cf7b09
3142017-09-06T18:58:34 <bitcoin-git> bitcoin/master 7e5d596 Suhas Daftuar: RPC: add wtxid to mempool entry output
3152017-09-06T18:58:34 <bitcoin-git> bitcoin/master 617c459 Suhas Daftuar: qa: rpc test for wtxid in mempool entry
3162017-09-06T18:58:35 <bitcoin-git> bitcoin/master d745b4c Wladimir J. van der Laan: Merge #11203: rpc: add wtxid to mempool entry output...
3172017-09-06T18:58:36 *** Dizzle has quit IRC
3182017-09-06T18:58:43 <promag> there's also "Also, RenameOver() doesn't throw, and IMO we should fail if the mempool.dat can't be updated"
3192017-09-06T18:59:02 <promag> maybe in a follow up patch add handling for that
3202017-09-06T18:59:03 <GAit> right but that's IMHO for a different PR
3212017-09-06T18:59:08 <bitcoin-git> [bitcoin] laanwj closed pull request #11203: rpc: add wtxid to mempool entry output (master...2017-08-add-wtxid-to-mempool-entry) https://github.com/bitcoin/bitcoin/pull/11203
3222017-09-06T18:59:09 <promag> voila
3232017-09-06T18:59:28 <promag> I can create that, it's on the todo list
3242017-09-06T18:59:36 <GAit> i'll be happy to review
3252017-09-06T19:00:09 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3262017-09-06T19:17:44 *** wxxs_ has joined #bitcoin-core-dev
3272017-09-06T19:19:35 *** wxxs has quit IRC
3282017-09-06T19:19:39 *** wxxs_ is now known as wxxs
3292017-09-06T19:20:00 *** Murch has quit IRC
3302017-09-06T19:27:35 *** wxxs has quit IRC
3312017-09-06T19:35:45 *** Cheeseo has joined #bitcoin-core-dev
3322017-09-06T19:38:52 *** promag has quit IRC
3332017-09-06T19:40:08 *** cheese_ has joined #bitcoin-core-dev
3342017-09-06T19:41:30 <bitcoin-git> [bitcoin] laanwj closed pull request #10872: Docs: Syntax highlight shell commands in the building notes (master...hilite) https://github.com/bitcoin/bitcoin/pull/10872
3352017-09-06T19:43:11 *** Cheeseo has quit IRC
3362017-09-06T19:45:04 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d745b4cf7b09...39ae41389a86
3372017-09-06T19:45:04 <bitcoin-git> bitcoin/master 41bf159 practicalswift: Remove unreachable code
3382017-09-06T19:45:05 <bitcoin-git> bitcoin/master 39ae413 Wladimir J. van der Laan: Merge #10845: Remove unreachable code...
3392017-09-06T19:45:31 <bitcoin-git> [bitcoin] laanwj closed pull request #10845: Remove unreachable code (master...remove-unreachable-code) https://github.com/bitcoin/bitcoin/pull/10845
3402017-09-06T19:46:20 *** Cheeseo has joined #bitcoin-core-dev
3412017-09-06T19:48:00 *** cheese_ has quit IRC
3422017-09-06T19:48:16 *** promag has joined #bitcoin-core-dev
3432017-09-06T19:52:26 *** madness has joined #bitcoin-core-dev
3442017-09-06T19:52:49 *** madness is now known as Guest72310
3452017-09-06T19:53:40 *** PaulCapestany has quit IRC
3462017-09-06T19:56:06 <promag> jnewbery: in portuguese, xpto it's like foo :)
3472017-09-06T19:56:40 *** PaulCapestany has joined #bitcoin-core-dev
3482017-09-06T19:58:14 *** Guest72310 has quit IRC
3492017-09-06T20:01:28 *** timothy has quit IRC
3502017-09-06T20:01:29 *** Murch has joined #bitcoin-core-dev
3512017-09-06T20:02:47 *** timothy has joined #bitcoin-core-dev
3522017-09-06T20:17:26 *** chjj has quit IRC
3532017-09-06T20:20:56 *** chjj has joined #bitcoin-core-dev
3542017-09-06T20:22:44 *** eenoch has quit IRC
3552017-09-06T20:32:02 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/39ae41389a86...961901f77e55
3562017-09-06T20:32:03 <bitcoin-git> bitcoin/master 5c8ff0d Pieter Wuille: Introduce wrappers around CBitcoinAddress...
3572017-09-06T20:32:03 <bitcoin-git> bitcoin/master 864cd27 Pieter Wuille: Move CBitcoinAddress to base58.cpp
3582017-09-06T20:32:04 <bitcoin-git> bitcoin/master 961901f Wladimir J. van der Laan: Merge #11117: Prepare for non-Base58 addresses...
3592017-09-06T20:32:35 <bitcoin-git> [bitcoin] laanwj closed pull request #11117: Prepare for non-Base58 addresses (master...201708_nocbitcoinaddress) https://github.com/bitcoin/bitcoin/pull/11117
3602017-09-06T20:41:48 *** Gunnie has joined #bitcoin-core-dev
3612017-09-06T20:49:17 *** chjj has quit IRC
3622017-09-06T20:51:28 *** chjj has joined #bitcoin-core-dev
3632017-09-06T20:52:00 <bitcoin-git> [bitcoin] promag opened pull request #11259: Remove duplicate destination decoding (master...2017-09-remove-duplicate-destination-decoding) https://github.com/bitcoin/bitcoin/pull/11259
3642017-09-06T20:52:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/961901f77e55...bc561b4b7d6a
3652017-09-06T20:52:56 <bitcoin-git> bitcoin/master 467cbbc Lawrence Nahum: Add return value to DumpMempool
3662017-09-06T20:52:56 <bitcoin-git> bitcoin/master 1aa97ee Lawrence Nahum: Add savemempool RPC
3672017-09-06T20:52:57 <bitcoin-git> bitcoin/master bc561b4 MarcoFalke: Merge #11099: [RPC][mempool]: Add savemempool RPC...
3682017-09-06T20:53:26 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11099: [RPC][mempool]: Add savemempool RPC (master...dump_mempool_rpc) https://github.com/bitcoin/bitcoin/pull/11099
3692017-09-06T20:59:12 *** Guyver2 has quit IRC
3702017-09-06T21:10:43 *** eenoch has joined #bitcoin-core-dev
3712017-09-06T21:12:12 *** Ruben has quit IRC
3722017-09-06T21:17:07 *** meshcollider has joined #bitcoin-core-dev
3732017-09-06T21:34:12 *** PRab has quit IRC
3742017-09-06T21:34:22 *** promag has quit IRC
3752017-09-06T21:41:40 *** promag has joined #bitcoin-core-dev
3762017-09-06T21:54:53 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc561b4b7d6a...6acdb1fab770
3772017-09-06T21:54:53 <bitcoin-git> bitcoin/master c001992 MeshCollider: Fix potential null dereferences
3782017-09-06T21:54:54 <bitcoin-git> bitcoin/master 6acdb1f Wladimir J. van der Laan: Merge #11238: Add assertions before potential null deferences...
3792017-09-06T21:55:35 <bitcoin-git> [bitcoin] laanwj closed pull request #11238: Add assertions before potential null deferences (master...201708_fbinfer_fixes) https://github.com/bitcoin/bitcoin/pull/11238
3802017-09-06T22:05:08 *** Chris_Stewart_5 has quit IRC
3812017-09-06T22:05:53 *** Murch has quit IRC
3822017-09-06T22:06:00 *** LeMiner2 has joined #bitcoin-core-dev
3832017-09-06T22:08:32 *** LeMiner has quit IRC
3842017-09-06T22:11:04 *** dermoth has quit IRC
3852017-09-06T22:11:39 *** dermoth has joined #bitcoin-core-dev
3862017-09-06T22:16:54 *** Timber_ has joined #bitcoin-core-dev
3872017-09-06T22:17:59 <jnewbery> promag : obrigado :)
3882017-09-06T22:18:42 <promag> jnewbery: np
3892017-09-06T22:19:20 <bitcoin-git> [bitcoin] laanwj closed pull request #10889: Docs: Run windows build in a clean path (master...docswin) https://github.com/bitcoin/bitcoin/pull/10889
3902017-09-06T22:19:28 *** dermoth has quit IRC
3912017-09-06T22:19:52 *** dermoth has joined #bitcoin-core-dev
3922017-09-06T22:23:38 *** spinza has quit IRC
3932017-09-06T22:24:33 *** Murch has joined #bitcoin-core-dev
3942017-09-06T22:28:12 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11260: travis: Check that default datadir is never created, Check SHAs only once (master...Mf1708-travisYaml) https://github.com/bitcoin/bitcoin/pull/11260
3952017-09-06T22:28:53 *** Giszmo has quit IRC
3962017-09-06T22:33:21 *** spinza has joined #bitcoin-core-dev
3972017-09-06T22:41:51 <wumpus> looks like we have a few new warnings:
3982017-09-06T22:41:52 <wumpus> base58.cpp:308:6: warning: âbool {anonymous}::CBitcoinAddress::IsScript() constâ defined but not used [-Wunused-function]
3992017-09-06T22:42:00 <wumpus> base58.cpp:298:6: warning: âbool {anonymous}::CBitcoinAddress::GetKeyID(CKeyID&) constâ defined but not used [-Wunused-function]
4002017-09-06T22:43:07 <wumpus> promag: mind to addresss ^^ in #11259?
4012017-09-06T22:43:17 <promag> np
4022017-09-06T22:43:48 <wumpus> at least, if it's not result of a bug or something, haven't looked in detail yet
4032017-09-06T22:43:58 <promag> I'll take a look
4042017-09-06T22:45:07 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6acdb1fab770...bcc8a620eae9
4052017-09-06T22:45:07 <bitcoin-git> bitcoin/master 478d4fb Sjors Provoost: [docs] explain how to recompile only what bitcoind tests need...
4062017-09-06T22:45:08 <bitcoin-git> bitcoin/master bcc8a62 Wladimir J. van der Laan: Merge #11219: [docs] explain how to recompile a modified unit test...
4072017-09-06T22:45:52 <bitcoin-git> [bitcoin] laanwj closed pull request #11219: [docs] explain how to recompile a modified unit test (master...patch-1) https://github.com/bitcoin/bitcoin/pull/11219
4082017-09-06T22:46:24 <wumpus> so the compiler can identify unused *methods* now? that's interesting - i guess because it's local to the file
4092017-09-06T22:48:35 <wumpus> that was with gcc 6.3.0, btw
4102017-09-06T22:48:45 *** laurentmt has joined #bitcoin-core-dev
4112017-09-06T22:49:09 *** laurentmt has quit IRC
4122017-09-06T22:49:14 <promag> wumpus: rebased, new commit
4132017-09-06T22:50:38 <promag> wumpus: I think so too
4142017-09-06T22:53:55 *** timothy has quit IRC
4152017-09-06T22:57:31 <wumpus> promag: thanks, will rebuild to check
4162017-09-06T23:00:20 *** Murch has quit IRC
4172017-09-06T23:01:13 <bitcoin-git> [bitcoin] practicalswift opened pull request #11261: scripted-diff: Use <cxxx> instead of deprecated <xxx.h> when including C compatibility headers (master...cinclude) https://github.com/bitcoin/bitcoin/pull/11261
4182017-09-06T23:03:43 <promag> is it me or github mail notifications are lagging?
4192017-09-06T23:05:48 <wumpus> yes, it seems slow
4202017-09-06T23:09:27 *** vicenteH is now known as Zenton
4212017-09-06T23:23:15 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bcc8a620eae9...089b742a210b
4222017-09-06T23:23:16 <bitcoin-git> bitcoin/master 8d0041e João Barbosa: Remove unused GetKeyID and IsScript methods from CBitcoinAddress
4232017-09-06T23:23:17 <bitcoin-git> bitcoin/master 86e6dd4 João Barbosa: Remove duplicate destination decoding
4242017-09-06T23:23:17 <bitcoin-git> bitcoin/master 089b742 Wladimir J. van der Laan: Merge #11259: Remove duplicate destination decoding...
4252017-09-06T23:23:57 <bitcoin-git> [bitcoin] laanwj closed pull request #11259: Remove duplicate destination decoding (master...2017-09-remove-duplicate-destination-decoding) https://github.com/bitcoin/bitcoin/pull/11259
4262017-09-06T23:24:25 *** Timber_ has quit IRC
4272017-09-06T23:26:11 <MarcoFalke> wumpus: 10838
4282017-09-06T23:29:18 <wumpus> MarcoFalke: hmm?
4292017-09-06T23:29:28 <MarcoFalke> ready for merge ;)
4302017-09-06T23:29:37 <promag> MarcoFalke: 11125
4312017-09-06T23:29:48 <wumpus> even without your release notes change? ok
4322017-09-06T23:30:15 <wumpus> yes 11125 is ready
4332017-09-06T23:30:29 <MarcoFalke> The release notes change will force another pull to be rebased
4342017-09-06T23:30:36 <MarcoFalke> , which already has some utACKs
4352017-09-06T23:30:46 <wumpus> true
4362017-09-06T23:31:09 <wumpus> right, I missed that there was a reasoning behind skipping it
4372017-09-06T23:31:21 <promag> sipa: care to rebase 11167?
4382017-09-06T23:31:35 <promag> I don't mind adding the release notes..
4392017-09-06T23:32:22 <MarcoFalke> wumpus: I never shared the reasoning. Either BlueMatt missed it or did it on purpose. Either way is fine, heh
4402017-09-06T23:32:35 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/089b742a210b...66a5b419eff5
4412017-09-06T23:32:36 <bitcoin-git> bitcoin/master aece8a4 Matt Corallo: (finally) remove getinfo in favor of more module-specific infos
4422017-09-06T23:32:36 <bitcoin-git> bitcoin/master 66a5b41 Wladimir J. van der Laan: Merge #10838: (finally) remove getinfo...
4432017-09-06T23:33:00 <bitcoin-git> [bitcoin] laanwj closed pull request #10838: (finally) remove getinfo (master...2017-07-seriously-fuck-getinfo) https://github.com/bitcoin/bitcoin/pull/10838
4442017-09-06T23:33:27 <wumpus> argh 11125 needs rebase too, now @promag
4452017-09-06T23:33:52 <BlueMatt> hmmm, what'd i do?
4462017-09-06T23:34:16 <wumpus> conflict: test/functional/bitcoin_cli.py
4472017-09-06T23:34:21 <promag> great branch name 2017-07-seriously-fuck-getinfo
4482017-09-06T23:34:29 <wumpus> nothing that could be avoided anyhwo
4492017-09-06T23:34:37 <promag> wumpus: 1 sec
4502017-09-06T23:34:42 <wumpus> lol nice
4512017-09-06T23:39:49 <promag> wumpus: rebased 11125
4522017-09-06T23:40:48 <wumpus> thanks
4532017-09-06T23:41:02 <promag> renamed cli_get_info to cli_response and rpc_get_info to rpc_response, I can revert thou
4542017-09-06T23:41:59 <promag> I was going to inline like assert_equal(self.nodes[0].cli.getblockchaininfo(), self.nodes[0].getblockchaininfo())
4552017-09-06T23:44:14 <meshcollider> how is fanquake able to add and remove labels, etc if hes not a member?
4562017-09-06T23:44:32 <meshcollider> or is he a member but just hasn't set it to display
4572017-09-06T23:45:07 <wumpus> he is a member
4582017-09-06T23:47:17 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/66a5b419eff5...645a7ecc0b8d
4592017-09-06T23:47:19 <bitcoin-git> bitcoin/master 7696841 João Barbosa: Fix style in -stdin and -stdinrpcpass handling
4602017-09-06T23:47:19 <bitcoin-git> bitcoin/master e127494 João Barbosa: [test] Improve assert_raises_jsonrpc docstring
4612017-09-06T23:47:20 <bitcoin-git> bitcoin/master 5c18a84 João Barbosa: [test] Add support for custom arguments to TestNodeCLI
4622017-09-06T23:47:53 <bitcoin-git> [bitcoin] laanwj closed pull request #11125: Add bitcoin-cli -stdin and -stdinrpcpass functional tests (master...2017-08-stdinrpcpass-functional-test) https://github.com/bitcoin/bitcoin/pull/11125
4632017-09-06T23:48:00 <meshcollider> things have been moving so fast these last couple of days, its awesome
4642017-09-06T23:48:05 <meshcollider> so many merges
4652017-09-06T23:49:31 <wumpus> yes we've caught up a little bit on the PR backlog :)
4662017-09-06T23:50:06 <MarcoFalke> Like 12 new pulls and 14 merged/closed. Delta is like two or something
4672017-09-06T23:50:37 <wumpus> yeah...
4682017-09-06T23:51:14 <promag> still, merge fest!
4692017-09-06T23:52:02 <sipa> ya
4702017-09-06T23:52:17 <MarcoFalke> ja, who's not ready for bed by now?
4712017-09-06T23:52:44 <meshcollider> its only midday over here in NZ ;)
4722017-09-06T23:53:24 <promag> 1am here, must take kids to school by 8am, I can troll a bit more