12017-09-07T00:01:14  <wumpus> getting quite tired too
  22017-09-07T00:03:45  <meshcollider> wumpus: re https://github.com/bitcoin/bitcoin/pull/10793#discussion_r137361636 did you want me to change it?
  32017-09-07T00:04:12  <meshcollider> or was that just a reply to dcousens
  42017-09-07T00:04:35  *** esotericnonsense has quit IRC
  52017-09-07T00:05:26  <wumpus> meshcollider: I'd prefer that - I think it'd make sense to restrict that PR what it says in the title;  generally changing &vec[i] to vec.data() + i does nothing to avoid UB
  62017-09-07T00:05:48  <wumpus> which was the idea behind &var[0] to var.data()
  72017-09-07T00:06:39  <sipa> wumpus: &var[0] is inherently invalid for empty vectorz
  82017-09-07T00:06:51  <sipa> while var.data() is allowed for empty vectors
  92017-09-07T00:07:08  <sipa> you're still not allowed to dereference the result of var.data()
 102017-09-07T00:07:25  <sipa> but with &var[0] it's already invalid, whether you use it not
 112017-09-07T00:07:52  <wumpus> yes, I know that
 122017-09-07T00:08:22  <wumpus> that was my point, &var[0] to .data() makes sense, but e.g. &var[42] to var.data()+42 does not
 132017-09-07T00:08:35  <wumpus> which is what meshcollider has extended to scope to in some places in that PR
 142017-09-07T00:08:40  <sipa> oh, i see
 152017-09-07T00:08:41  <meshcollider> yeah I'll revert that
 162017-09-07T00:09:12  <sipa> well, &var[42] is also invalid for a var of length 42 or less
 172017-09-07T00:09:31  <sipa> while var.data() + 42 is always valid, as long as you don't use it
 182017-09-07T00:10:09  <wumpus> still, it's getting used in all those cases
 192017-09-07T00:10:19  <sipa> okay!
 202017-09-07T00:10:20  <wumpus> which is UB in any case
 212017-09-07T00:10:31  <meshcollider> yeah its usually used with memcpy()'s
 222017-09-07T00:13:39  *** esotericnonsense has joined #bitcoin-core-dev
 232017-09-07T00:16:22  <meshcollider> fixed
 242017-09-07T00:16:44  <meshcollider> poor Travis will be having a hard time with all these commits recently lol
 252017-09-07T00:17:49  *** Giszmo has joined #bitcoin-core-dev
 262017-09-07T00:19:38  <promag> speaking of that, wumpus any idea when you'll check #11006?
 272017-09-07T00:20:53  <promag> It can save some travis resources
 282017-09-07T00:21:03  *** dcousens has joined #bitcoin-core-dev
 292017-09-07T00:25:28  <wumpus> I'm really confused about that one
 302017-09-07T00:28:28  <wumpus> can't reproduce any problems with it locally, but I'm afraid of bringing back random travis failures. I much prefer it taking somewhat longer to random failures that make people lose trust in the tests
 312017-09-07T00:29:09  <wumpus> I'm not sure what the problem was back then and if you can remove that workaround now, what made it go away
 322017-09-07T00:30:04  <promag> I would say merge as it get a couple more ACK, revert later if needed
 332017-09-07T00:31:26  <promag> I can't figure out if you did that, pass nullptr to timeout
 342017-09-07T00:32:03  <wumpus> no, I never did that, because it means that bitcoind will never terminate if there are open rpc connectinos
 352017-09-07T00:32:07  <wumpus> AFAIK
 362017-09-07T00:34:20  <promag> that is correct, but if the connections are closed then it quits immediately, if not then it will break as it is now
 372017-09-07T00:34:37  <wumpus> so the timeout is there to force any existing RPC connections to terminate
 382017-09-07T00:35:02  <promag> right, for instance, some dumb tests, whatever
 392017-09-07T00:36:01  <wumpus> yes, could be for various reasons, our examples pretty much encourage keeping connections open between commands
 402017-09-07T00:36:16  <promag> in the best scenario, there are no active events and the loop can exit right away
 412017-09-07T00:36:33  <wumpus> (which is more efficient than opening a new connection for every commmand, but we don't want this to hold up the shutdown process, people will get confused)
 422017-09-07T00:36:57  <wumpus> stop means that the process must exit, despite open connections
 432017-09-07T00:37:19  <wumpus> yes, I agree ideally it should exit immediately if there are no active eventw
 442017-09-07T00:37:29  <wumpus> and in say, 3 seconds if there are active events
 452017-09-07T00:37:34  <wumpus> that's why the code is so complicated
 462017-09-07T00:39:08  <promag> so, on my side I did test with different libevent versions, run test suite multiple times.. no issue so far
 472017-09-07T00:40:02  <wumpus> yes, but did you try keeping connections open to the daemon after sending stop?
 482017-09-07T00:40:15  <wumpus> e.g. trying to prevent it from exiting
 492017-09-07T00:40:31  <promag> yes, I did this https://github.com/bitcoin/bitcoin/pull/11006#issuecomment-321954764
 502017-09-07T00:40:46  <wumpus> you've checked that it doesn't quit prematurely, which is great, but only part of the functionality
 512017-09-07T00:41:20  <wumpus> what if you change the sleep(3) to sleep(1000)
 522017-09-07T00:41:27  <wumpus> does it wait 1000 seconds to actually exit?
 532017-09-07T00:41:30  <wumpus> or does it give up after a while
 542017-09-07T00:41:50  <promag> 1001sec please
 552017-09-07T00:42:13  <wumpus> lol
 562017-09-07T00:42:24  <promag> but I guess it will break, because of the current code
 572017-09-07T00:42:46  <promag> I mean, it's not graceful quit
 582017-09-07T00:43:39  <promag> err, rebuild, removed worktree
 592017-09-07T00:50:14  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/645a7ecc0b8d...f65614726de2
 602017-09-07T00:50:14  <bitcoin-git> bitcoin/master e91b961 flack: Create dependencies.md, and link dependencies file from README & build docs
 612017-09-07T00:50:15  <bitcoin-git> bitcoin/master f656147 Wladimir J. van der Laan: Merge #10779: Create dependencies.md...
 622017-09-07T00:50:39  <bitcoin-git> [bitcoin] laanwj closed pull request #10779: Create dependencies.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/10779
 632017-09-07T00:55:23  *** halform has joined #bitcoin-core-dev
 642017-09-07T00:56:07  <meshcollider> also wumpus, re #11237, do you want me to fix the weird commit split or leave it as-is
 652017-09-07T00:59:10  *** halform has quit IRC
 662017-09-07T00:59:26  *** halform has joined #bitcoin-core-dev
 672017-09-07T01:04:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 682017-09-07T01:07:17  *** halform has quit IRC
 692017-09-07T01:12:28  *** promag has quit IRC
 702017-09-07T01:12:54  <esotericnonsense> hm. promag: i'm looking at adding tests for the weight field in mempool now. can get it to work for txid2 and txid3 but not txid1. sdaftuar's 'add wtxid to mempool entry output'
 712017-09-07T01:13:04  <esotericnonsense> also fails on txid1 if I reuse his test.
 722017-09-07T01:13:07  *** Chris_Stewart_5 has quit IRC
 732017-09-07T01:16:14  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f65614726de2...2a56baf395bf
 742017-09-07T01:16:14  <bitcoin-git> bitcoin/master ca67ddf esneider: Move the AreInputsStandard documentation next to its implementation
 752017-09-07T01:16:15  <bitcoin-git> bitcoin/master 2a56baf MarcoFalke: Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation...
 762017-09-07T01:16:36  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10682: Trivial: Move the AreInputsStandard documentation next to its implementation (master...move-doc) https://github.com/bitcoin/bitcoin/pull/10682
 772017-09-07T01:19:02  *** hxz has joined #bitcoin-core-dev
 782017-09-07T01:20:50  <esotericnonsense> i've amended the PR and pointed out the test that fails. my knowledge here is lacking unfortunately.
 792017-09-07T01:27:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 802017-09-07T01:28:19  *** goatpig has joined #bitcoin-core-dev
 812017-09-07T01:41:05  *** dcousens has quit IRC
 822017-09-07T01:41:35  *** Dyaheon has quit IRC
 832017-09-07T01:43:01  *** Dyaheon has joined #bitcoin-core-dev
 842017-09-07T01:54:26  *** promag has joined #bitcoin-core-dev
 852017-09-07T01:58:51  *** promag has quit IRC
 862017-09-07T02:05:00  *** Ruben has joined #bitcoin-core-dev
 872017-09-07T02:11:16  *** DrOlmer has joined #bitcoin-core-dev
 882017-09-07T02:15:09  *** dabura667 has joined #bitcoin-core-dev
 892017-09-07T02:17:11  *** promag has joined #bitcoin-core-dev
 902017-09-07T02:18:09  *** dabura667 has quit IRC
 912017-09-07T02:22:29  *** promag has quit IRC
 922017-09-07T02:28:17  *** cluelessperson has quit IRC
 932017-09-07T02:30:28  *** Orion3k has quit IRC
 942017-09-07T02:33:51  *** cluelessperson has joined #bitcoin-core-dev
 952017-09-07T02:40:29  *** Orion3k has joined #bitcoin-core-dev
 962017-09-07T02:46:27  *** Orion3k has quit IRC
 972017-09-07T02:47:21  *** Orion3k has joined #bitcoin-core-dev
 982017-09-07T02:54:14  <meshcollider> esotericnonsense: isn't it failing because txid1 has no witness
 992017-09-07T02:58:31  <meshcollider> hmm idk
1002017-09-07T02:59:41  <esotericnonsense> meshcollider: it might be that i'm getting lost in the python framework's definitions
1012017-09-07T02:59:41  *** promag has joined #bitcoin-core-dev
1022017-09-07T03:00:37  *** alxlu has quit IRC
1032017-09-07T03:02:03  <esotericnonsense> from BIP141 i interpret 'base tx size' as tx.serialize() (because it is equivalent to tx.serialize_without_witness()), and tx.serialize_with_witness() as being total transaction size BIP141
1042017-09-07T03:03:49  <meshcollider> yeah that sounds right
1052017-09-07T03:04:08  *** promag has quit IRC
1062017-09-07T03:04:21  *** Chris_Stewart_5 has quit IRC
1072017-09-07T03:05:12  <esotericnonsense> 'size' in the mempool rpc is virtual tx size (weight/4)
1082017-09-07T03:06:21  <esotericnonsense> argh. doh. this makes the entire thing pointless. brain fart.
1092017-09-07T03:07:18  <meshcollider> hmm not quite, virtual size is rounded up to the nearest integer so they're not entirely the same
1102017-09-07T03:07:29  <esotericnonsense> ah yes that's true.
1112017-09-07T03:09:49  <sipa> it's (3*size_without_witness + size + 3)/4
1122017-09-07T03:11:22  <esotericnonsense> size == math.ceil(weight/4) checks out for all three tx in segwit.py. it's just this one for which tx.serialize()*3 + tx.serialize_with_witness() != weight.
1132017-09-07T03:11:32  <esotericnonsense> hm.
1142017-09-07T03:11:51  <meshcollider> sipa: where does the extra +3 come from?
1152017-09-07T03:12:16  <esotericnonsense> meshcollider: it just accomplishes the ceiling function
1162017-09-07T03:13:17  <esotericnonsense> e.g. (3*nowitness + size + 3)/4 == ceil((3*nowitness+size)/4)
1172017-09-07T03:13:30  <esotericnonsense> (where the former uses integer division)
1182017-09-07T03:15:58  <sipa> meshcollider: to round up
1192017-09-07T03:16:06  <sipa> esotericnonsense: right
1202017-09-07T03:16:24  <meshcollider> ok yeah so it relies on integer division, that's where I was confused
1212017-09-07T03:16:40  <meshcollider> Was thinking there might be some reason it was always exactly an integer lol
1222017-09-07T03:16:45  <esotericnonsense> the problem is that i misinterpreted the original rpc call, so knowing size and weight is not useful for my particular case, which means that my PR is probably pointless :)
1232017-09-07T03:16:57  <esotericnonsense> (the intention was to know 'is this a segwit tx')
1242017-09-07T03:17:18  <meshcollider> also kinda relevant is issue #11218, sipa suggested renaming size to vsize
1252017-09-07T03:18:20  <esotericnonsense> the other PR accomplishes what I need, (just check wtxid against txid)
1262017-09-07T03:20:00  <esotericnonsense> if it were base size and not vsize, then my check of bsize*4 != weight would work
1272017-09-07T03:29:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1282017-09-07T03:34:25  *** Chris_Stewart_5 has quit IRC
1292017-09-07T03:38:37  *** PRab has joined #bitcoin-core-dev
1302017-09-07T03:41:30  *** promag has joined #bitcoin-core-dev
1312017-09-07T03:45:49  *** promag has quit IRC
1322017-09-07T04:03:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1332017-09-07T04:12:44  *** dabura667 has joined #bitcoin-core-dev
1342017-09-07T04:12:58  *** lynx has joined #bitcoin-core-dev
1352017-09-07T04:13:21  *** lynx is now known as Guest59971
1362017-09-07T04:14:24  *** Chris_Stewart_5 has quit IRC
1372017-09-07T04:18:28  *** Deacydal has joined #bitcoin-core-dev
1382017-09-07T04:18:32  *** Cheeseo has quit IRC
1392017-09-07T04:18:40  *** Cheeseo has joined #bitcoin-core-dev
1402017-09-07T04:19:02  *** d9b4bef9 has quit IRC
1412017-09-07T04:19:35  *** Guest59971 has quit IRC
1422017-09-07T04:19:35  *** PRab_ has joined #bitcoin-core-dev
1432017-09-07T04:19:44  *** RubenSomsen has joined #bitcoin-core-dev
1442017-09-07T04:19:50  *** praxeology1 has joined #bitcoin-core-dev
1452017-09-07T04:19:54  *** esotericnonsense has quit IRC
1462017-09-07T04:19:54  *** Evel-Knievel has quit IRC
1472017-09-07T04:19:55  *** da2ce7 has quit IRC
1482017-09-07T04:20:16  *** esotericnonsense has joined #bitcoin-core-dev
1492017-09-07T04:20:16  *** Gunnie has quit IRC
1502017-09-07T04:20:16  *** kayamm has quit IRC
1512017-09-07T04:20:24  *** Evel-Knievel has joined #bitcoin-core-dev
1522017-09-07T04:20:34  *** LeMiner has joined #bitcoin-core-dev
1532017-09-07T04:20:47  *** adiabat has quit IRC
1542017-09-07T04:20:48  *** molz has quit IRC
1552017-09-07T04:20:48  *** jonasschnelli has quit IRC
1562017-09-07T04:20:49  *** Lightsword has quit IRC
1572017-09-07T04:21:20  *** LeMiner2 has quit IRC
1582017-09-07T04:21:20  *** praxeology has quit IRC
1592017-09-07T04:21:21  *** LeMiner is now known as LeMiner2
1602017-09-07T04:21:41  *** spinza has quit IRC
1612017-09-07T04:21:52  *** PRab has quit IRC
1622017-09-07T04:21:52  *** Ruben has quit IRC
1632017-09-07T04:21:52  *** Deacyde has quit IRC
1642017-09-07T04:21:54  *** PRab_ is now known as PRab
1652017-09-07T04:22:07  *** d9b4bef9 has joined #bitcoin-core-dev
1662017-09-07T04:22:17  *** Lightsword has joined #bitcoin-core-dev
1672017-09-07T04:22:20  *** spinza has joined #bitcoin-core-dev
1682017-09-07T04:23:13  *** promag has joined #bitcoin-core-dev
1692017-09-07T04:24:22  *** adiabat has joined #bitcoin-core-dev
1702017-09-07T04:24:22  *** jonasschnelli has joined #bitcoin-core-dev
1712017-09-07T04:24:40  *** molz has joined #bitcoin-core-dev
1722017-09-07T04:25:03  *** da2ce7 has joined #bitcoin-core-dev
1732017-09-07T04:25:18  *** kayamm has joined #bitcoin-core-dev
1742017-09-07T04:25:18  *** kayamm has joined #bitcoin-core-dev
1752017-09-07T04:27:13  *** adam3us has quit IRC
1762017-09-07T04:27:21  *** esotericnonsens_ has joined #bitcoin-core-dev
1772017-09-07T04:27:28  *** promag has quit IRC
1782017-09-07T04:27:34  *** rjak has quit IRC
1792017-09-07T04:27:54  *** gwillen has quit IRC
1802017-09-07T04:28:16  *** ryan-c has quit IRC
1812017-09-07T04:29:21  *** esotericnonsense has quit IRC
1822017-09-07T04:29:23  *** esotericnonsens_ is now known as esotericnonsense
1832017-09-07T04:29:32  *** gwillen has joined #bitcoin-core-dev
1842017-09-07T04:29:45  *** adam3us has joined #bitcoin-core-dev
1852017-09-07T04:30:24  <jtimon> jnewbery: does BitcoinTestFramework.add_nodes() need to get num_nodes as param, isn't that internal now?
1862017-09-07T04:31:42  <jtimon> never mind, let me read more...
1872017-09-07T04:32:50  *** Giszmo has quit IRC
1882017-09-07T04:39:40  *** rjak has joined #bitcoin-core-dev
1892017-09-07T04:44:21  *** ryan-c has joined #bitcoin-core-dev
1902017-09-07T04:57:37  *** go1111111 has joined #bitcoin-core-dev
1912017-09-07T05:02:21  *** DrOlmer has quit IRC
1922017-09-07T05:03:27  *** DrOlmer has joined #bitcoin-core-dev
1932017-09-07T05:04:45  *** zmin has joined #bitcoin-core-dev
1942017-09-07T05:05:01  *** promag has joined #bitcoin-core-dev
1952017-09-07T05:05:10  <meshcollider> can someone with travis powers restart the failed one here, should be unrelated: https://travis-ci.org/bitcoin/bitcoin/jobs/272710677
1962017-09-07T05:07:08  <meshcollider> can only members with write access restart travis? Seems like that should be a weaker permission, but not really sure how githubs permission model works
1972017-09-07T05:09:22  *** promag has quit IRC
1982017-09-07T05:10:08  *** zmin has quit IRC
1992017-09-07T05:10:51  *** zmin has joined #bitcoin-core-dev
2002017-09-07T05:13:17  *** zmin has quit IRC
2012017-09-07T05:13:43  *** zmin has joined #bitcoin-core-dev
2022017-09-07T05:15:08  <kallewoof> meshcollider: restarted
2032017-09-07T05:29:41  *** Gunnie has joined #bitcoin-core-dev
2042017-09-07T05:38:05  *** RubenSomsen has quit IRC
2052017-09-07T05:39:17  *** RubenSomsen has joined #bitcoin-core-dev
2062017-09-07T05:46:58  *** promag has joined #bitcoin-core-dev
2072017-09-07T05:51:20  *** zmin has quit IRC
2082017-09-07T05:51:35  *** promag has quit IRC
2092017-09-07T06:00:18  *** RubenSomsen has quit IRC
2102017-09-07T06:28:29  *** promag has joined #bitcoin-core-dev
2112017-09-07T06:32:46  *** promag has quit IRC
2122017-09-07T06:53:52  *** promag has joined #bitcoin-core-dev
2132017-09-07T06:54:03  *** BashCo has quit IRC
2142017-09-07T06:54:30  *** promag has quit IRC
2152017-09-07T07:00:15  *** Gunnie has quit IRC
2162017-09-07T07:06:33  <meshcollider> thanks :)
2172017-09-07T07:10:14  *** promag has joined #bitcoin-core-dev
2182017-09-07T07:11:41  *** jtimon has quit IRC
2192017-09-07T07:14:56  *** promag has quit IRC
2202017-09-07T07:18:07  *** BashCo has joined #bitcoin-core-dev
2212017-09-07T07:32:02  *** d9b4bef9 has quit IRC
2222017-09-07T07:33:08  *** d9b4bef9 has joined #bitcoin-core-dev
2232017-09-07T07:41:05  *** Orion3k has quit IRC
2242017-09-07T07:42:57  *** timothy has joined #bitcoin-core-dev
2252017-09-07T07:46:37  *** timothy has quit IRC
2262017-09-07T07:56:01  <meshcollider> So no IRC meeting this week right?
2272017-09-07T07:58:00  *** Gunnie has joined #bitcoin-core-dev
2282017-09-07T08:18:33  *** Orion3k has joined #bitcoin-core-dev
2292017-09-07T08:22:05  *** Gunnie has quit IRC
2302017-09-07T08:31:13  *** promag has joined #bitcoin-core-dev
2312017-09-07T08:31:45  *** afk11 has quit IRC
2322017-09-07T08:32:05  *** afk11 has joined #bitcoin-core-dev
2332017-09-07T08:33:16  *** esotericnonsense has quit IRC
2342017-09-07T08:35:35  *** promag has quit IRC
2352017-09-07T08:38:17  *** promag has joined #bitcoin-core-dev
2362017-09-07T08:38:57  *** esotericnonsense has joined #bitcoin-core-dev
2372017-09-07T08:43:44  *** esotericnonsens_ has joined #bitcoin-core-dev
2382017-09-07T08:45:45  *** esotericnonsense has quit IRC
2392017-09-07T08:45:47  *** esotericnonsens_ is now known as esotericnonsense
2402017-09-07T08:56:07  *** laurentmt has joined #bitcoin-core-dev
2412017-09-07T08:56:42  *** laurentmt has quit IRC
2422017-09-07T09:00:54  *** praxeology1 has left #bitcoin-core-dev
2432017-09-07T09:02:07  *** hxz has quit IRC
2442017-09-07T09:02:31  *** timothy has joined #bitcoin-core-dev
2452017-09-07T09:08:11  *** RubenSomsen has joined #bitcoin-core-dev
2462017-09-07T09:11:35  *** promag has quit IRC
2472017-09-07T09:13:32  *** promag has joined #bitcoin-core-dev
2482017-09-07T09:31:26  *** laurentmt has joined #bitcoin-core-dev
2492017-09-07T09:34:01  *** belcher has quit IRC
2502017-09-07T09:55:01  *** Gunnie has joined #bitcoin-core-dev
2512017-09-07T10:09:52  *** promag has quit IRC
2522017-09-07T10:11:51  *** promag has joined #bitcoin-core-dev
2532017-09-07T10:23:30  *** promag has quit IRC
2542017-09-07T10:24:36  *** promag has joined #bitcoin-core-dev
2552017-09-07T10:37:59  *** promag has joined #bitcoin-core-dev
2562017-09-07T10:38:32  *** laurentmt has quit IRC
2572017-09-07T10:49:13  *** promag has quit IRC
2582017-09-07T10:51:25  *** promag has joined #bitcoin-core-dev
2592017-09-07T11:00:12  *** promag has quit IRC
2602017-09-07T11:05:26  *** tiagotrs has joined #bitcoin-core-dev
2612017-09-07T11:10:26  *** dabura667 has quit IRC
2622017-09-07T11:24:40  *** laurentmt has joined #bitcoin-core-dev
2632017-09-07T11:24:42  *** laurentmt has quit IRC
2642017-09-07T11:33:04  *** hxz has joined #bitcoin-core-dev
2652017-09-07T11:34:06  <meshcollider> is this intended behavior? https://i.imgur.com/juKAf1O.png the credit shows the full 7 BTC which was received by the wallet, but it was received on 2 separate addresses in the same transaction (3 and 4 BTC respectively), because from looking at that transaction details window it looks like the full 7 BTC was received on just that one address
2662017-09-07T11:35:49  <meshcollider> heh I forgot, everyones in SF so no one will be online at 4:30am sf time
2672017-09-07T11:37:49  <meshcollider> but I have a feeling this might be what the change to transactiondesc.cpp in #7101 was trying to fix
2682017-09-07T11:46:19  <esotericnonsense> meshcollider: this is feeling oddly familiar, i think i encountered this years ago when splitting coins
2692017-09-07T11:52:02  *** d9b4bef9 has quit IRC
2702017-09-07T11:53:08  *** d9b4bef9 has joined #bitcoin-core-dev
2712017-09-07T11:59:47  *** laurentmt has joined #bitcoin-core-dev
2722017-09-07T12:01:03  *** laurentmt has quit IRC
2732017-09-07T12:10:10  <esotericnonsense> meshcollider: i just tried to test this but forgot that there's special behaviour if you send to your own wallet, doh
2742017-09-07T12:11:16  <meshcollider> I just ran 2 regtest nodes on the same machine to do this
2752017-09-07T12:12:00  <meshcollider> just run one with -port=whatever and then addnode=127.0.0.1:whatever in the other nodes config
2762017-09-07T12:13:57  <esotericnonsense> crafted another one by using -wallet.
2772017-09-07T12:14:34  <esotericnonsense> this tx, with 4 outputs, 3 to 'wallet2' and 1 to change in 'wallet1', is showing as three seperate entries/rows in the 'wallet2' node.
2782017-09-07T12:15:14  <meshcollider> yep but if you go into the full details of each row, do they all just give the total, not the individual received by that address?
2792017-09-07T12:15:43  <esotericnonsense> ah yes.
2802017-09-07T12:16:12  <esotericnonsense> it's a bit odd in any case. on the 'sending wallet' it apportions the fee arbitrarily to one output.
2812017-09-07T12:17:56  <meshcollider> indeed
2822017-09-07T12:18:08  <meshcollider> seems like lots of little bugs are mixed up in this
2832017-09-07T12:18:17  <esotericnonsense> receiving end https://i.imgur.com/w4zF6FL.png https://i.imgur.com/SjAAd4x.png https://live.blockcypher.com/btc-testnet/tx/a739c64487f122f8b41644d2f703811167e8613ef616d17346a4570d72f20698/
2842017-09-07T12:19:00  <esotericnonsense> it's difficult for me to reason about what you even want it to show really :P
2852017-09-07T12:21:05  <meshcollider> Yeah I guess the fee being attributed to a random output kinda makes sense right, its gotta be shown somewhere and you wouldn't want to make another whole row for it in the table
2862017-09-07T12:22:44  <meshcollider> its just the full details page, if you open it for any row from the same transaction it should show all inputs from that same transaction right, not just the one. Then it would make sense to have a total on there
2872017-09-07T12:23:29  <meshcollider> in a similar way to how its shown on the sending node
2882017-09-07T12:24:45  *** SopaXorzTaker has joined #bitcoin-core-dev
2892017-09-07T12:25:58  *** laurentmt has joined #bitcoin-core-dev
2902017-09-07T12:26:04  <meshcollider> like, this makes sense for sending https://i.imgur.com/Oz5X45l.png but this doesn't make sense to me for receiving https://i.imgur.com/H5wHdmJ.png
2912017-09-07T12:27:13  <bitcoin-git> [bitcoin] practicalswift opened pull request #11264: [doc] Fix broken Markdown table in dependencies.md (master...dependencies-capitalization) https://github.com/bitcoin/bitcoin/pull/11264
2922017-09-07T12:37:14  *** promag has joined #bitcoin-core-dev
2932017-09-07T12:41:37  *** promag has quit IRC
2942017-09-07T13:02:56  *** DrOlmer has quit IRC
2952017-09-07T13:03:11  *** DrOlmer has joined #bitcoin-core-dev
2962017-09-07T13:10:24  *** tiagotrs has quit IRC
2972017-09-07T13:13:15  *** Guyver2 has joined #bitcoin-core-dev
2982017-09-07T13:17:00  *** tiagotrs has joined #bitcoin-core-dev
2992017-09-07T13:57:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3002017-09-07T14:18:52  *** btcdrak has quit IRC
3012017-09-07T14:40:34  *** tiagotrs has quit IRC
3022017-09-07T14:51:14  *** Zenton has quit IRC
3032017-09-07T14:51:21  *** Zenton has joined #bitcoin-core-dev
3042017-09-07T14:53:59  *** BashCo has quit IRC
3052017-09-07T14:54:30  *** laurentmt has quit IRC
3062017-09-07T14:54:34  *** BashCo has joined #bitcoin-core-dev
3072017-09-07T14:54:43  *** Zenton is now known as zenton
3082017-09-07T14:55:37  *** Alina-malina has quit IRC
3092017-09-07T14:59:10  *** BashCo has quit IRC
3102017-09-07T15:13:36  *** RubenSomsen has quit IRC
3112017-09-07T15:23:41  *** hxz has quit IRC
3122017-09-07T15:25:58  *** hxz has joined #bitcoin-core-dev
3132017-09-07T15:33:29  *** promag has joined #bitcoin-core-dev
3142017-09-07T15:40:28  *** promag has quit IRC
3152017-09-07T15:43:28  *** hxz has quit IRC
3162017-09-07T15:44:26  *** jonasschnelli has quit IRC
3172017-09-07T15:44:26  *** jonasschnelli has joined #bitcoin-core-dev
3182017-09-07T15:58:42  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10731: Escape rather than remove any printable characters in UAs (master...log_more_uacomment) https://github.com/bitcoin/bitcoin/pull/10731
3192017-09-07T16:00:02  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10748: [config] Help text cleanup (master...helptextcleanup) https://github.com/bitcoin/bitcoin/pull/10748
3202017-09-07T16:01:18  *** promag has joined #bitcoin-core-dev
3212017-09-07T16:01:48  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a56baf395bf...9c8f3655cc68
3222017-09-07T16:01:48  <bitcoin-git> bitcoin/master d2be7b2 James Evans: Typo in optionsdialog.ui...
3232017-09-07T16:01:49  <bitcoin-git> bitcoin/master 9c8f365 Jonas Schnelli: Merge #10911: [qt] Fix typo and access key in optionsdialog.ui...
3242017-09-07T16:02:23  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10911: [qt] Fix typo and access key in optionsdialog.ui (master...master) https://github.com/bitcoin/bitcoin/pull/10911
3252017-09-07T16:04:28  <MarcoFalke> wumpus: Mind to add the git log to the release notes?
3262017-09-07T16:04:37  <MarcoFalke> I'd like to take a look before tagging final
3272017-09-07T16:05:55  *** promag has quit IRC
3282017-09-07T16:06:56  *** meshcollider has quit IRC
3292017-09-07T16:20:23  <bitcoin-git> [bitcoin] laanwj opened pull request #11267: rpc: update cli for estimatefee argument rename (master...2017_09_renamed_estimatefee_arg) https://github.com/bitcoin/bitcoin/pull/11267
3302017-09-07T16:20:47  <wumpus> MarcoFalke: ah shit, still need to do that, good point. Not sure I have all the tooling here.
3312017-09-07T16:21:23  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9c8f3655cc68...ea729d55b4db
3322017-09-07T16:21:23  <bitcoin-git> bitcoin/master ee4d149 Matt Corallo: Drop upgrade-cancel callback registration for a generic "resumeable"...
3332017-09-07T16:21:24  <bitcoin-git> bitcoin/master ea729d5 Jonas Schnelli: Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable"...
3342017-09-07T16:21:48  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10770: Drop upgrade-cancel callback registration for a generic "cancelable" (master...2017-07-upgrade-cancel-nits) https://github.com/bitcoin/bitcoin/pull/10770
3352017-09-07T16:23:28  *** shesek has quit IRC
3362017-09-07T16:24:27  *** AaronvanW has quit IRC
3372017-09-07T16:26:01  *** d9b4bef9 has quit IRC
3382017-09-07T16:27:08  *** d9b4bef9 has joined #bitcoin-core-dev
3392017-09-07T16:27:10  *** AaronvanW has joined #bitcoin-core-dev
3402017-09-07T16:27:22  *** Giszmo has joined #bitcoin-core-dev
3412017-09-07T16:30:19  *** laurentmt has joined #bitcoin-core-dev
3422017-09-07T16:36:38  *** Aaronvan_ has joined #bitcoin-core-dev
3432017-09-07T16:39:34  *** AaronvanW has quit IRC
3442017-09-07T16:49:24  *** LeMiner has joined #bitcoin-core-dev
3452017-09-07T16:51:44  *** LeMiner2 has quit IRC
3462017-09-07T16:51:44  *** LeMiner is now known as LeMiner2
3472017-09-07T16:52:13  <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #10748: [config] Help text cleanup (master...helptextcleanup) https://github.com/bitcoin/bitcoin/pull/10748
3482017-09-07T16:56:22  *** Murch has joined #bitcoin-core-dev
3492017-09-07T16:58:04  *** Chris_Stewart_5 has quit IRC
3502017-09-07T16:58:39  *** timothy has quit IRC
3512017-09-07T16:59:09  *** abpa has joined #bitcoin-core-dev
3522017-09-07T17:01:34  *** blznblzn2 has quit IRC
3532017-09-07T17:02:49  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea729d55b4db...a3624ddb1a3b
3542017-09-07T17:02:49  <bitcoin-git> bitcoin/master 9b348ff Dan Raviv: Fix memory leaks in qt/guiutil.cpp...
3552017-09-07T17:02:50  <bitcoin-git> bitcoin/master a3624dd Jonas Schnelli: Merge #11156: Fix memory leaks in qt/guiutil.cpp...
3562017-09-07T17:02:56  *** BashCo has joined #bitcoin-core-dev
3572017-09-07T17:03:02  *** promag has joined #bitcoin-core-dev
3582017-09-07T17:03:22  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11156: Fix memory leaks in qt/guiutil.cpp (master...fix/qt-guiutil-memory-leaks) https://github.com/bitcoin/bitcoin/pull/11156
3592017-09-07T17:05:18  *** blznblzn2 has joined #bitcoin-core-dev
3602017-09-07T17:07:30  *** promag has quit IRC
3612017-09-07T17:16:29  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #11268: [macOS] remove Growl support, remove unused code (master...2017/09/rm_growl) https://github.com/bitcoin/bitcoin/pull/11268
3622017-09-07T17:21:42  *** laurentmt has quit IRC
3632017-09-07T17:21:58  *** promag has joined #bitcoin-core-dev
3642017-09-07T17:34:10  *** Murch has quit IRC
3652017-09-07T17:37:21  *** promag has quit IRC
3662017-09-07T17:38:10  *** AaronvanW has joined #bitcoin-core-dev
3672017-09-07T17:39:48  *** Aaronvan_ has quit IRC
3682017-09-07T17:42:23  *** RubenSomsen has joined #bitcoin-core-dev
3692017-09-07T17:45:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3702017-09-07T17:45:37  *** owowo has quit IRC
3712017-09-07T17:49:34  <MarcoFalke> cfields: Our travis builds are still broken since yesterday (they bumped the trusty image)
3722017-09-07T17:49:40  <MarcoFalke> I have no idea what is going on
3732017-09-07T17:49:44  <MarcoFalke> Mind to take a look?
3742017-09-07T17:49:46  <MarcoFalke> https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437
3752017-09-07T17:50:21  *** jtimon has joined #bitcoin-core-dev
3762017-09-07T17:50:37  <MarcoFalke> We could reroll to the deprecated image, maybe
3772017-09-07T17:51:45  *** owowo has joined #bitcoin-core-dev
3782017-09-07T17:58:02  *** promag has joined #bitcoin-core-dev
3792017-09-07T17:59:32  *** nelruk has joined #bitcoin-core-dev
3802017-09-07T18:01:35  *** Alina-malina has joined #bitcoin-core-dev
3812017-09-07T18:02:16  *** promag has quit IRC
3822017-09-07T18:02:54  *** skoko961 has joined #bitcoin-core-dev
3832017-09-07T18:05:41  *** Alina-malina has quit IRC
3842017-09-07T18:05:41  *** Alina-malina has joined #bitcoin-core-dev
3852017-09-07T18:06:11  *** skoko961 has quit IRC
3862017-09-07T18:06:12  *** promag has joined #bitcoin-core-dev
3872017-09-07T18:08:32  *** RubenSomsen has quit IRC
3882017-09-07T18:09:01  *** RubenSomsen has joined #bitcoin-core-dev
3892017-09-07T18:10:40  *** owowo has quit IRC
3902017-09-07T18:12:26  *** promag has quit IRC
3912017-09-07T18:12:47  *** SopaXorzTaker has quit IRC
3922017-09-07T18:15:47  *** owowo has joined #bitcoin-core-dev
3932017-09-07T18:17:04  <bitcoin-git> [bitcoin] donaloconnor opened pull request #11269: [Trivial Fix] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps param type (master...fix_params_branch) https://github.com/bitcoin/bitcoin/pull/11269
3942017-09-07T18:20:04  <wumpus> uh oh, the travis upgrade thing happened?
3952017-09-07T18:20:23  <wumpus> travisgeddon
3962017-09-07T18:21:45  <MarcoFalke> Yeah, looks like other projects are switichg back to the "deprecated" image
3972017-09-07T18:22:21  <MarcoFalke> If someone feels like creating a pr: Add `group: deprecated-2017Q3` to .travis.yml
3982017-09-07T18:29:19  *** laurentmt has joined #bitcoin-core-dev
3992017-09-07T18:33:08  *** promag has joined #bitcoin-core-dev
4002017-09-07T18:34:04  *** laurentmt has quit IRC
4012017-09-07T18:37:16  *** promag has quit IRC
4022017-09-07T18:47:17  <kanzure> for this meeting i will be typing everyone's messages. thanks.
4032017-09-07T18:52:48  <aj> kanzure: always wanted to be a relay bot when you grew up?
4042017-09-07T18:55:20  <wumpus> MarcoFalke etc: draft PR list for 0.15.0 is here https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary)
4052017-09-07T18:55:52  *** meshcollider has joined #bitcoin-core-dev
4062017-09-07T18:56:06  <sipa> that's a long list!
4072017-09-07T18:56:41  <wumpus> yes, it's scary :)
4082017-09-07T18:57:07  <wumpus> and that's already with most trivials and refactors removed
4092017-09-07T18:57:10  <sipa> is it usually that long for a major release?
4102017-09-07T18:57:53  <wumpus> a new record every release
4112017-09-07T18:58:32  <wumpus> unless I screwed something up while generating it and this is the list since 0.3.x instead ;)
4122017-09-07T18:58:44  <sipa> ha
4132017-09-07T19:00:07  <sipa> MEETING
4142017-09-07T19:00:27  <wumpus> lol
4152017-09-07T19:01:01  <achow101> meeting
4162017-09-07T19:01:03  <sdaftuar> hi
4172017-09-07T19:01:03  <achow101> ?
4182017-09-07T19:01:11  <jnewbery> hi
4192017-09-07T19:01:23  <meshcollider> Hello :)
4202017-09-07T19:01:33  *** fpgaminer has joined #bitcoin-core-dev
4212017-09-07T19:01:38  <gmaxwell> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
4222017-09-07T19:01:52  <instagibbs> hi
4232017-09-07T19:01:54  <BlueMatt> no?
4242017-09-07T19:01:59  <bitcoin-git> [bitcoin] laanwj opened pull request #11270: travis: Use deprecated trusty image (master...2017_09_travis_deprecated_image) https://github.com/bitcoin/bitcoin/pull/11270
4252017-09-07T19:02:00  <MarcoFalke> wha?
4262017-09-07T19:02:01  <CodeShark> are we doing this meeting? lol
4272017-09-07T19:02:08  <MarcoFalke> topics ... ?
4282017-09-07T19:02:11  <cfields> hi
4292017-09-07T19:02:14  <BlueMatt> we already said we were not doing meeting this week
4302017-09-07T19:02:16  <BlueMatt> iirc
4312017-09-07T19:02:18  * sipa suggests: lunch
4322017-09-07T19:02:23  <BlueMatt> ^^^
4332017-09-07T19:02:25  <wumpus> lol did you ac tually start the meeting?
4342017-09-07T19:02:36  <achow101> no one started it yet
4352017-09-07T19:02:56  <cdecker> The one time I could participate...
4362017-09-07T19:03:16  <jonasschnelli> hi
4372017-09-07T19:03:42  <achow101> how about we meet irl ad kanzure transcribes to irc
4382017-09-07T19:03:51  <achow101> s/ad/and/
4392017-09-07T19:04:10  <gmaxwell> We can tell sdaftuar all the great work we came up with for him to handle.
4402017-09-07T19:04:33  <BlueMatt> yea, sdaftuar is building segwit-wallet, right?
4412017-09-07T19:04:56  <BlueMatt> and sipa is being force-nominated wallet maintainer,  so gets to review all of it :p
4422017-09-07T19:05:05  <luke-jr> I thought we would meet IRL, and kanzure transcribe it all to IRC
4432017-09-07T19:05:17  * sdaftuar hides
4442017-09-07T19:05:32  <meshcollider> lol
4452017-09-07T19:06:00  <kanzure> hi.
4462017-09-07T19:06:18  <kanzure> yeah i'm fine wit hthat
4472017-09-07T19:06:34  <sdaftuar> if you can predict the times i'll chime in and type that up as well that'd be great k thanks
4482017-09-07T19:06:45  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a3624ddb1a3b...e7f125562fbb
4492017-09-07T19:06:45  <bitcoin-git> bitcoin/master 3b69a08 MeshCollider: Fix division by zero in time remaining
4502017-09-07T19:06:46  <bitcoin-git> bitcoin/master c8d38ab MeshCollider: Refactor tipUpdate as per style guide
4512017-09-07T19:06:46  <bitcoin-git> bitcoin/master e7f1255 Wladimir J. van der Laan: Merge #11237: qt: Fixing division by zero in time remaining...
4522017-09-07T19:07:22  <bitcoin-git> [bitcoin] laanwj closed pull request #11237: qt: Fixing division by zero in time remaining (master...201709_fix_estimated_time) https://github.com/bitcoin/bitcoin/pull/11237
4532017-09-07T19:08:37  <jtimon> perhaps a short summary of how are things going in the phisical meeting instead of the IRC meeting?
4542017-09-07T19:08:57  <jtimon> or kanzure's option sounds good too
4552017-09-07T19:09:37  <kanzure> there's various text from last few days, although not as much as zurich
4562017-09-07T19:09:42  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7f125562fbb...2f0d3e604aa9
4572017-09-07T19:09:42  <bitcoin-git> bitcoin/master 061297f jjz: Ensure that data types are consistent...
4582017-09-07T19:09:43  <bitcoin-git> bitcoin/master 2f0d3e6 Wladimir J. van der Laan: Merge #11232: Ensure that data types are consistent...
4592017-09-07T19:09:53  <meshcollider> wumpus: #11265 can be closed now that #11237 was merged, GitHub must not understand a comma separated list of issues being fixed
4602017-09-07T19:10:22  <bitcoin-git> [bitcoin] laanwj closed pull request #11232: Ensure that data types are consistent (master...master) https://github.com/bitcoin/bitcoin/pull/11232
4612017-09-07T19:10:25  *** goatpig has quit IRC
4622017-09-07T19:11:49  <instagibbs> kanzure, are the digests published already
4632017-09-07T19:11:59  <wumpus> meshcollider: thanks for letting me know
4642017-09-07T19:12:53  <kanzure> there's one or two vulnerabilities that i shouldn't publish
4652017-09-07T19:15:15  <instagibbs> meshcollider, sdaftuar and anyone else not physically present, please bring up topics of choice if you have them.
4662017-09-07T19:17:50  <jtimon> so what topics have you been talking about there?
4672017-09-07T19:18:22  <jtimon> I assume 0.15.1 has bee na big topic
4682017-09-07T19:18:23  <kanzure> signature aggregation
4692017-09-07T19:18:30  <kanzure> coin selection
4702017-09-07T19:19:35  <wumpus> 0.15.1 (segwit wallet) was a big topic, yes
4712017-09-07T19:19:39  <kanzure> rescans
4722017-09-07T19:21:01  <gmaxwell> I think we know what we're doing for segwit wallet.
4732017-09-07T19:21:25  <gmaxwell> after discussion pieter proposed a quick path for it that basically does an addwitness on every address in the wallet.
4742017-09-07T19:21:41  <gmaxwell> Which we concluded didn't create any more debt than we already have, since people aleady can do that.
4752017-09-07T19:21:59  *** Chris_Stewart_5 has quit IRC
4762017-09-07T19:22:27  <gmaxwell> (We also spent a while talking about ways that things could be handled in the future and have good ideas there too)
4772017-09-07T19:23:35  *** fpgaminer has left #bitcoin-core-dev
4782017-09-07T19:24:06  <meshcollider> gmaxwell: would this happen if the user decides to do a full wallet upgrade to segwit?
4792017-09-07T19:24:21  <meshcollider> No mix between segwit and non-segwit right?
4802017-09-07T19:24:27  <kanzure> i wanted to cause more discussion about rolling utxo hashes but one of the necessary people seems to be absent today
4812017-09-07T19:24:52  <gmaxwell> meshcollider: we must support mixed wallets already because people already have them.
4822017-09-07T19:25:22  <kanzure> also jonasschnelli gave a talk on bip150 and bip151 the other day http://diyhpl.us/wiki/transcripts/sf-bitcoin-meetup/2017-09-04-jonas-schenlli-bip150-bip151/
4832017-09-07T19:25:30  <wumpus> mixed wallets are pretty much a neccesity
4842017-09-07T19:25:30  <gmaxwell> we won't be supporting 'segwit only' in 0.15.1 at least just because it's a bigger change. (rather than the couple line core change needed to just auto-addwitness to everything)
4852017-09-07T19:25:40  <gmaxwell> kanzure: that talk will have a video online in a bit.
4862017-09-07T19:25:57  <meshcollider> addwitness newaddresses or existing addresses too?
4872017-09-07T19:26:04  <gmaxwell> But perhaps in the future we will have wallets that are segwit only except for imported keys.
4882017-09-07T19:26:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4892017-09-07T19:26:12  <gmaxwell> meshcollider: all due to backup recovery.
4902017-09-07T19:26:37  <michagogo> fakeping :-(
4912017-09-07T19:26:43  <gmaxwell> if you only do 'new' then you need a way of storing where you started doing that.
4922017-09-07T19:27:58  <meshcollider> Right, makes sense yep 👍
4932017-09-07T19:29:58  <MarcoFalke> cfields: https://github.com/bitcoin/bitcoin/pull/10753
4942017-09-07T19:30:38  <kanzure> luke-jr wanted to talk about #7533 and #10391
4952017-09-07T19:32:04  *** promag has joined #bitcoin-core-dev
4962017-09-07T19:32:08  <MarcoFalke> cfields: You can find a MWE here: https://github.com/travis-ci/travis-ci/issues/8315#issuecomment-327537437
4972017-09-07T19:32:30  <MarcoFalke> (scroll up a bit)
4982017-09-07T19:32:40  <MarcoFalke> for the yaml
4992017-09-07T19:33:48  <jtimon> any talks about creating a testnet for developing and testing signature aggregation? (shameless escuse to review beg https://github.com/bitcoin/bitcoin/pull/8994 )
5002017-09-07T19:34:17  <kanzure> signature aggregation will land in libsecp256k1 at some point
5012017-09-07T19:35:33  <jtimon> yeah, still too early to create a testnet, on the bright side I'm reading a lot of test code every time I rebase that...
5022017-09-07T19:35:59  *** promag has quit IRC
5032017-09-07T19:38:24  *** cbits has joined #bitcoin-core-dev
5042017-09-07T19:38:30  *** timothy has joined #bitcoin-core-dev
5052017-09-07T19:38:33  *** blogibub has joined #bitcoin-core-dev
5062017-09-07T19:40:33  <meshcollider> I'll review that a bit later today jtimon, I like the sound of it
5072017-09-07T19:40:45  <meshcollider> Any new bugs reported in rc3?
5082017-09-07T19:40:46  <jtimon> meshcollider: awesome!
5092017-09-07T19:41:55  <meshcollider> This segfault issue with Qt keeps coming up, #11262 yesterday is the third issue I've seen
5102017-09-07T19:44:36  <jonasschnelli> Yes. The segfault things is ugly... it seems to happen for self-compiled Bitcoin-Qts only. So it could be a Qt5.5 bug. Couldn't track it down so far
5112017-09-07T19:45:25  <meshcollider> Dooglus used 5.7.1 here https://github.com/bitcoin/bitcoin/issues/9883#issuecomment-325217617
5122017-09-07T19:49:12  <jonasschnelli> hmm... good point.
5132017-09-07T19:50:38  <wumpus> yes the crashes in the sorting of the transaction list are vaguely worrying
5142017-09-07T19:51:00  <wumpus> seems some rare race condition
5152017-09-07T19:55:04  *** promag has joined #bitcoin-core-dev
5162017-09-07T19:57:30  *** PaulCapestany has quit IRC
5172017-09-07T19:59:47  *** promag has quit IRC
5182017-09-07T20:00:31  <jtimon> end meeting?
5192017-09-07T20:01:06  <kanzure> it's endless
5202017-09-07T20:01:11  <jtimon> thanks for the summary, looking forward to see the talks and transcripts
5212017-09-07T20:01:28  <kanzure> there's not as much text, but there's some.
5222017-09-07T20:03:04  <meshcollider> Are there any PRs for things like segwit wallet ready for review yet, are they incoming next few days or what
5232017-09-07T20:04:11  <MarcoFalke> cfields: With group edge `pyenv versions` is empty: https://travis-ci.org/MarcoFalke/bitcoin/jobs/273047509/config
5242017-09-07T20:05:05  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2f0d3e604aa9...e6ab88a4524a
5252017-09-07T20:05:06  <bitcoin-git> bitcoin/master 5cb3da0 Marko Bencun: keystore GetKeys(): return result instead of writing to reference...
5262017-09-07T20:05:07  <bitcoin-git> bitcoin/master fe09b01 Marko Bencun: add missing lock to crypter GetKeys()...
5272017-09-07T20:05:07  <bitcoin-git> bitcoin/master e6ab88a Wladimir J. van der Laan: Merge #10916: add missing lock to crypter GetKeys()...
5282017-09-07T20:05:34  <bitcoin-git> [bitcoin] laanwj closed pull request #10916: add missing lock to crypter GetKeys() (master...GetKeys) https://github.com/bitcoin/bitcoin/pull/10916
5292017-09-07T20:06:02  <wumpus> meshcollider: some from https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.15.1
5302017-09-07T20:07:03  <wumpus> so if everyone is ok with the pull list in  https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Pulls-listing-for-0.15.0-(temporary)  I'm going to paste it into the relnotes for 0.15.0 and tag final, if anyone still plans on looking through it (to find misattributions and such) let me know
5312017-09-07T20:11:16  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6ab88a4524a...52f8877525d5
5322017-09-07T20:11:16  <bitcoin-git> bitcoin/master fa40b0e MarcoFalke: travis: Assert default datadir isn't created, Run scripted diff only once
5332017-09-07T20:11:17  <bitcoin-git> bitcoin/master 52f8877 MarcoFalke: Merge #11260: travis: Assert default datadir isn't created, Run scripted diff only once...
5342017-09-07T20:11:19  <sipa> i'd like to see #11174 addressed
5352017-09-07T20:11:56  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11260: travis: Assert default datadir isn't created, Run scripted diff only once (master...Mf1708-travisYaml) https://github.com/bitcoin/bitcoin/pull/11260
5362017-09-07T20:14:01  <meshcollider> #11245 got tagged for 0.15.0 four hours ago, what's happening there
5372017-09-07T20:15:18  <meshcollider> If the issue isnt present in rc3 then there isn't much point including the fix in 0.15.0 release notes, but we don't know if it really got fixed
5382017-09-07T20:17:34  *** cbits has quit IRC
5392017-09-07T20:20:01  *** d9b4bef9 has quit IRC
5402017-09-07T20:21:07  *** d9b4bef9 has joined #bitcoin-core-dev
5412017-09-07T20:21:26  <bitcoin-git> [bitcoin] theuni opened pull request #11271: travis: filter out pyenv (master...travis-fix-pyenv) https://github.com/bitcoin/bitcoin/pull/11271
5422017-09-07T20:22:27  <MarcoFalke> wumpus: I will look at the pull list
5432017-09-07T20:22:35  *** Gunnie has quit IRC
5442017-09-07T20:27:08  *** Chris_Stewart_5 has quit IRC
5452017-09-07T20:28:56  <bitcoin-git> [bitcoin] laanwj closed pull request #11270: travis: Use deprecated trusty image (master...2017_09_travis_deprecated_image) https://github.com/bitcoin/bitcoin/pull/11270
5462017-09-07T20:29:22  *** kyzeeruz has joined #bitcoin-core-dev
5472017-09-07T20:29:26  <bitcoin-git> [bitcoin] laanwj closed pull request #11245: [0.15] Mention offscreen issue in release notes (0.15...201709_offscreen_release_note) https://github.com/bitcoin/bitcoin/pull/11245
5482017-09-07T20:30:18  <kyzeeruz> Hello world!
5492017-09-07T20:31:01  <meshcollider> What's needed for 11174 re: rescanning?
5502017-09-07T20:31:26  <meshcollider> I can make a PR if no one else is going to
5512017-09-07T20:31:51  <kyzeeruz> what is PR?
5522017-09-07T20:32:02  <meshcollider> Pull request
5532017-09-07T20:32:29  <meshcollider> But it sounded like gmaxwell was leaving a mental note for himself
5542017-09-07T20:32:57  <kyzeeruz> Is there somebody can give me a free web link to learn bitcoin coding?
5552017-09-07T20:33:34  <meshcollider> I think you're in the wrong channel, try #bitcoin :)
5562017-09-07T20:33:38  <bitcoin-git> [bitcoin] rawodb closed pull request #11177: Support for SegWit Addresses in RPC  calls and change addresses (master...pr/rpc_getsegwitaddresses) https://github.com/bitcoin/bitcoin/pull/11177
5572017-09-07T20:35:01  <kyzeeruz> I want to create and build a bitcoin web game or either transforming an online game while playing earn a real bitcoin on it live online.
5582017-09-07T20:35:23  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #11272: CKeystore/CCrypter: move relevant implementation out of the header (master...2017/09/wallet_refact) https://github.com/bitcoin/bitcoin/pull/11272
5592017-09-07T20:35:43  <meshcollider> Is the meeting over?
5602017-09-07T20:35:56  <bitcoin-git> [bitcoin] Xekyo opened pull request #11273: WIP: Ignore old format estimation file (master...ignoreOldFeeEstimates) https://github.com/bitcoin/bitcoin/pull/11273
5612017-09-07T20:36:22  <kyzeeruz> Is there any possible to use an old computer as a main miner to generate bitcoin?
5622017-09-07T20:36:27  <michagogo> meshcollider: it didn't happen
5632017-09-07T20:36:29  <michagogo> despite the ping
5642017-09-07T20:36:30  <jonasschnelli> meshcollider: because most of the devs are working in the same physical location right now, the meeting was not really happening...
5652017-09-07T20:36:43  <michagogo> kyzeeruz: short answer: no. Anyway, this is the wrong place
5662017-09-07T20:36:52  <jonasschnelli> yeah.. next week it will be again in the normal fashion
5672017-09-07T20:36:57  <jonasschnelli> sorry about that.
5682017-09-07T20:37:10  <kyzeeruz> thanks michagogo
5692017-09-07T20:37:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5702017-09-07T20:38:06  <meshcollider> Ok sweet, just confused about the ping and thought it was started :)
5712017-09-07T20:38:50  <meshcollider> Hope the last day of SF goes well then
5722017-09-07T20:38:59  *** promag has joined #bitcoin-core-dev
5732017-09-07T20:45:51  <bitcoin-git> [bitcoin] mess110 opened pull request #11274: [tests] Cleanup wildcard imports in functional tests (master...cleanup-wildcard-in-functional-tests) https://github.com/bitcoin/bitcoin/pull/11274
5742017-09-07T20:54:04  *** arowser has quit IRC
5752017-09-07T20:55:20  *** arowser has joined #bitcoin-core-dev
5762017-09-07T20:58:55  *** nelruk has quit IRC
5772017-09-07T20:59:45  <kyzeeruz> What repositories maen?
5782017-09-07T20:59:55  <sipa> kyzeeruz: #bitcoin please
5792017-09-07T21:02:41  *** DrOlmer has quit IRC
5802017-09-07T21:03:30  *** DrOlmer has joined #bitcoin-core-dev
5812017-09-07T21:07:58  <esotericnonsense> is it expected that pruning can become a limiting factor in IBD? testing now and by increasing my prune size (essentially, temporarily disabling it) it seems to have increased sync rate by approx 30%
5822017-09-07T21:08:35  <esotericnonsense> the cache seems to flush on each pruning event
5832017-09-07T21:09:25  <esotericnonsense> testing ramdisk with prune=5000 vs ssd with prune=50000 -> 30% faster off the ssd (and seemingly improving as dbcache increases)
5842017-09-07T21:10:09  *** blogibub has quit IRC
5852017-09-07T21:11:04  *** promag has quit IRC
5862017-09-07T21:12:57  <MarcoFalke> wumpus: Pull list looks fine
5872017-09-07T21:28:00  *** kyzeeruz has quit IRC
5882017-09-07T21:31:04  <wumpus> MarcoFalke: thanks for checking
5892017-09-07T21:31:55  *** promag has joined #bitcoin-core-dev
5902017-09-07T21:36:01  *** promag has quit IRC
5912017-09-07T21:37:13  *** Guyver2 has quit IRC
5922017-09-07T21:42:41  *** Cheeseo has quit IRC
5932017-09-07T21:43:21  *** Cheeseo has joined #bitcoin-core-dev
5942017-09-07T21:51:48  *** RubenSomsen has quit IRC
5952017-09-07T21:58:04  *** Chris_Stewart_5 has quit IRC
5962017-09-07T22:04:15  *** cheese_ has joined #bitcoin-core-dev
5972017-09-07T22:07:25  <BlueMatt> gah, mk229797 shows up on an issue and tells someone to download a datadir snapshot
5982017-09-07T22:07:35  <BlueMatt> I assume its not a real person...wumpus wanna ban that account?
5992017-09-07T22:08:05  <BlueMatt> hmm, maybe not?
6002017-09-07T22:08:08  <wumpus> banned
6012017-09-07T22:08:15  <BlueMatt> seems like a person, but thats a strange response
6022017-09-07T22:08:39  <BlueMatt> eh, whatever
6032017-09-07T22:08:46  <BlueMatt> they'll come here and complain if they're real
6042017-09-07T22:09:23  <wumpus> right, it was definitely not ok
6052017-09-07T22:15:07  <wumpus> hm, strange, I pushed the PR list in the release notes to the 0.15 branch and github's bot didnt trigger
6062017-09-07T22:15:22  <BlueMatt> :O
6072017-09-07T22:16:05  <wumpus> maybe it's overloaded
6082017-09-07T22:16:29  <BlueMatt> github has had a lot of notification delays of late...there's been a few days where their email was super slow for a few hours
6092017-09-07T22:16:53  <wumpus> I hope it's not our fault for merging so much :)
6102017-09-07T22:20:49  <BlueMatt> heh, I hope it is :p
6112017-09-07T22:20:55  <BlueMatt> (though other projects are larger...)
6122017-09-07T22:26:37  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #11276: Update CONTRIBUTRING.md to reduce unnecesarry review workload (master...2017/09/cont) https://github.com/bitcoin/bitcoin/pull/11276
6132017-09-07T22:30:27  <wumpus> the IRC bot is definitely backlogged
6142017-09-07T22:30:53  <bitcoin-git> [bitcoin] laanwj closed pull request #11205: Make fixed CAmounts and related sanity function constexpr (master...refactor/constexpr-amount) https://github.com/bitcoin/bitcoin/pull/11205
6152017-09-07T22:32:33  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11274: [tests] Cleanup wildcard imports in functional tests (master...cleanup-wildcard-in-functional-tests) https://github.com/bitcoin/bitcoin/pull/11274
6162017-09-07T22:32:40  <bitcoin-git> [bitcoin] ryanofsky opened pull request #11277: Fix uninitialized URI in batch RPC requests (master...pr/mb) https://github.com/bitcoin/bitcoin/pull/11277
6172017-09-07T22:33:36  *** promag has joined #bitcoin-core-dev
6182017-09-07T22:34:53  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/d4c9d00e7e79958dea9586f927778dba2be8230a
6192017-09-07T22:34:54  <bitcoin-git> bitcoin/0.15 d4c9d00 Wladimir J. van der Laan: doc: Add PRs list to release notes...
6202017-09-07T22:38:15  *** promag has quit IRC
6212017-09-07T22:39:15  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/52f8877525d5...638e6c59da4f
6222017-09-07T22:39:15  <bitcoin-git> bitcoin/master aa2e0f0 Cory Fields: travis: filter out pyenv
6232017-09-07T22:39:16  <bitcoin-git> bitcoin/master 638e6c5 MarcoFalke: Merge #11271: travis: filter out pyenv...
6242017-09-07T22:39:22  *** zenton has quit IRC
6252017-09-07T22:39:23  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11271: travis: filter out pyenv (master...travis-fix-pyenv) https://github.com/bitcoin/bitcoin/pull/11271
6262017-09-07T22:41:28  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11279: doc: Add missing contributors to release notes (0.15...Mf1708-doc015rel) https://github.com/bitcoin/bitcoin/pull/11279
6272017-09-07T22:44:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/d4c9d00e7e79...adcc788f2a89
6282017-09-07T22:44:46  <bitcoin-git> bitcoin/0.15 fad16a9 MarcoFalke: doc: Add missing contributors to release notes...
6292017-09-07T22:44:47  <bitcoin-git> bitcoin/0.15 adcc788 Wladimir J. van der Laan: Merge #11279: doc: Add missing contributors to release notes...
6302017-09-07T22:44:53  <bitcoin-git> [bitcoin] laanwj closed pull request #11279: doc: Add missing contributors to release notes (0.15...Mf1708-doc015rel) https://github.com/bitcoin/bitcoin/pull/11279
6312017-09-07T22:49:23  <meshcollider> in #11174, it says to add release notes for rescanning an encrypted wallet
6322017-09-07T22:49:34  <meshcollider> is that basically putting https://github.com/bitcoin/bitcoin/issues/11249 into the release notes
6332017-09-07T22:51:17  <MarcoFalke> meshcollider: pulls welcome :)
6342017-09-07T22:51:39  <meshcollider> yeah I'm working on it at the moment but I'm just trying to work out what gmaxwell's mental note meant ;)
6352017-09-07T22:51:47  <meshcollider> < gmaxwell> mental note: we need release notes on the topup stuff and instructions for rescanning
6362017-09-07T22:52:41  <meshcollider> Also should this be a new section in the release notes? 'Notes for 0.15.0' or something?
6372017-09-07T22:54:44  <wumpus> maybe at the beginning, after the upgrade/compatibility instructions
6382017-09-07T22:57:12  *** abpa has quit IRC
6392017-09-07T23:01:52  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11280: [0.15] Final to-do's for 0.15.0 release notes (0.15...201709_release_note_015_todo) https://github.com/bitcoin/bitcoin/pull/11280
6402017-09-07T23:02:18  <bitcoin-git> [bitcoin] laanwj closed pull request #10756: net processing: swap out signals for an interface class (master...no-net-signals2) https://github.com/bitcoin/bitcoin/pull/10756
6412017-09-07T23:09:48  *** justanotheruser has joined #bitcoin-core-dev
6422017-09-07T23:13:12  *** cheese_ has quit IRC
6432017-09-07T23:15:07  *** promag has joined #bitcoin-core-dev
6442017-09-07T23:18:13  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/723e5806578b...efb4383ef6c6
6452017-09-07T23:18:14  <bitcoin-git> bitcoin/master 592404f MeshCollider: Changing &vec[0] to vec.data(), what 9804 missed
6462017-09-07T23:18:14  <bitcoin-git> bitcoin/master efb4383 Wladimir J. van der Laan: Merge #10793: Changing &var[0] to var.data()...
6472017-09-07T23:18:38  <bitcoin-git> [bitcoin] laanwj closed pull request #10793: Changing &var[0] to var.data() (master...prefer-vector-data) https://github.com/bitcoin/bitcoin/pull/10793
6482017-09-07T23:19:20  *** promag has quit IRC
6492017-09-07T23:21:31  *** justanotheruser has quit IRC
6502017-09-07T23:21:50  *** justanotheruser has joined #bitcoin-core-dev
6512017-09-07T23:24:18  *** PRab has quit IRC
6522017-09-07T23:33:00  <wumpus> can people please review https://github.com/bitcoin/bitcoin/pull/11280? (final release notes updates for 0.15.0)
6532017-09-07T23:33:01  *** justanotheruser has quit IRC
6542017-09-07T23:37:01  <meshcollider> especially sipa and gmaxwell since they added the todo list :)
6552017-09-07T23:37:28  <wumpus> yes
6562017-09-07T23:38:09  <wumpus> I think this is the first time that tagging a release is blocked on the release notes :)
6572017-09-07T23:39:35  <sipa> haha
6582017-09-07T23:40:24  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #11281: Avoid pemanent cs_main/cs_wallet lock during RescanFromTime (master...2017/09/rescan_locks) https://github.com/bitcoin/bitcoin/pull/11281
6592017-09-07T23:41:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/efb4383ef6c6...791a0e6ddade
6602017-09-07T23:41:54  <meshcollider> hmm i'm not sure how to fix instagibbs comment, it would sound weird to just say "(this is not a regression)" right
6612017-09-07T23:41:54  <bitcoin-git> bitcoin/master 9c76ba1 John Newbery: [wallet] Rename InitLoadWallet() to OpenWallets()...
6622017-09-07T23:41:55  <bitcoin-git> bitcoin/master 1b9cee6 John Newbery: [wallet] Rename WalletVerify() to VerifyWallets()...
6632017-09-07T23:41:56  <bitcoin-git> bitcoin/master 2da5eaf John Newbery: [wallet] Add FlushWallets() function to wallet/init.cpp
6642017-09-07T23:42:13  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10767: [wallet] Clarify wallet initialization / destruction interface (master...walletinit2) https://github.com/bitcoin/bitcoin/pull/10767
6652017-09-07T23:42:26  *** Deadhand has quit IRC
6662017-09-07T23:42:51  <meshcollider> actually dw I think I've got it
6672017-09-07T23:45:35  *** Deadhand has joined #bitcoin-core-dev
6682017-09-07T23:52:42  <meshcollider> All good to go? Cancel travis again if you want :)
6692017-09-07T23:53:43  <luke-jr> wumpus: well, to be fair, IMO it *should* be blocked on the hiding GUI issue <.<
6702017-09-07T23:54:06  <meshcollider> wouldn't that require an rc4 though?
6712017-09-07T23:54:11  <luke-jr> yes :/
6722017-09-07T23:56:20  <meshcollider> According to discussion in #11245 it might have been fixed somehow upstream or something
6732017-09-07T23:57:14  <meshcollider> no one is really sure so I don't think blocking release on that would be worth it, the fix can get  in to 0.15.1 anyway