12017-09-08T00:00:35  *** NicolasDorier has quit IRC
  22017-09-08T00:00:46  <wumpus> luke-jr: no, it's not even clear the issue exists on the rc binaries, jonasschnelli tried on a few windows VMs andcouldn't reproduce with the rcs
  32017-09-08T00:00:55  *** NicolasDorier has joined #bitcoin-core-dev
  42017-09-08T00:01:37  <jonasschnelli> luke-jr: I could reproduce the GUI offset issue with 0.14.1 on Win7, 8.1 and 10. But 0.15.0rc2 did not had the issue anymore.
  52017-09-08T00:01:48  <jonasschnelli> Either its fixed in Qt5.7 or without our sources
  62017-09-08T00:02:06  <jonasschnelli> It may still happen to users compiling with an older Qt version (not confirmed)
  72017-09-08T00:02:30  <jonasschnelli> (like the tray icon but, etc.)
  82017-09-08T00:02:40  <luke-jr> hmm
  92017-09-08T00:02:45  <wumpus> yes don't get started on the tray icon... :p
 102017-09-08T00:03:02  <luke-jr> can we contact the users who experienced it in RCs, and confirm their setup?
 112017-09-08T00:03:23  <luke-jr> gmaxwell said he knew of at least a few
 122017-09-08T00:05:09  <midnightmagic> jonasschnelli: Is there somewhere that you've more-strongly linked your GPG key to yourself? Maybe a video or something?
 132017-09-08T00:05:44  <wumpus> a gpg key video? lol
 142017-09-08T00:07:05  <wumpus> if it is an issue in 0.14.1 it's not a regression in 0.15 anyhow
 152017-09-08T00:07:29  <wumpus> there's 0 reasons to hold the release for it, sorry
 162017-09-08T00:07:41  <luke-jr> just strange that the reports came in when 0.15rc was out
 172017-09-08T00:07:46  <midnightmagic> wumpus: :-) peter todd did one where he reads out the fingerprint.
 182017-09-08T00:08:08  <luke-jr> midnightmagic: jonas has lots of signatures on his key :P
 192017-09-08T00:08:54  <meshcollider> gmaxwell did you see instagibbs comment on #11280
 202017-09-08T00:08:58  <meshcollider> there is no rescan RPC
 212017-09-08T00:09:47  <jonasschnelli> midnightmagic: a video?
 222017-09-08T00:10:32  <jonasschnelli> there are tons of merges and commits with my GPG signature... what would a video improve?
 232017-09-08T00:10:48  <jonasschnelli> There will soon be a video from the SF bitcoin dev meetup with my key fingerprint on the slides.
 242017-09-08T00:10:51  <jonasschnelli> That may help
 252017-09-08T00:11:29  * luke-jr modifies the slides in that video /s
 262017-09-08T00:11:45  <wumpus> no, there is no rescan RPC, just the command line argument
 272017-09-08T00:12:02  <midnightmagic> luke-jr: yep. secondary trust is sort of meaningless to me in this context
 282017-09-08T00:12:04  <luke-jr> also rescanning isn't possible for pruned nodes?
 292017-09-08T00:12:18  <meshcollider> so what's gmaxwell talking about in his comment, if restarting with -rescan won't work with encrypted wallets then is there no fix?
 302017-09-08T00:12:30  <wumpus> import* have a  'rescan' argument but I'm not sure that's what is meant
 312017-09-08T00:12:52  <luke-jr> I think the "fix" is to unlock the wallet immediately when it starts?
 322017-09-08T00:13:16  <meshcollider> nah I doubt that's what he meant, would be pretty hacky if people were required to use an import command to get the rescan going
 332017-09-08T00:13:34  <jonasschnelli> There is a rescan RPC call PR: https://github.com/bitcoin/bitcoin/pull/7061
 342017-09-08T00:13:42  <jonasschnelli> (begs for reviews)
 352017-09-08T00:14:13  <jonasschnelli> with that rescans would be possible for pruned peers (if one wants to rescan not below the pruned depth)
 362017-09-08T00:15:50  <meshcollider>  hmm yeah that'd be good, I'll review that later too, but that means we have no fix for 0.15.0?
 372017-09-08T00:16:13  <meshcollider> Should I remove that section from the notes entirely or just make a note that support for rescanning will come in a new version
 382017-09-08T00:16:16  *** luke-jr has quit IRC
 392017-09-08T00:16:25  <gmaxwell> meshcollider: you can rescan from RPC.
 402017-09-08T00:16:26  *** luke-jr has joined #bitcoin-core-dev
 412017-09-08T00:16:37  <meshcollider> using import commands?
 422017-09-08T00:16:42  <gmaxwell> you can use yea..
 432017-09-08T00:16:46  <gmaxwell> importmulti
 442017-09-08T00:17:02  *** d9b4bef9 has quit IRC
 452017-09-08T00:17:04  <wumpus> importmulti without any actual keys or so?
 462017-09-08T00:17:16  <wumpus> that definitely needs to be documented, I was not aware of that
 472017-09-08T00:17:19  <gmaxwell> but indeed I was forgetting that there is no freestanding 'rescan'.
 482017-09-08T00:17:25  <jonasschnelli> with a dummy key/address generated in bip32.org or so
 492017-09-08T00:17:34  <gmaxwell> you can scan with a dummy.
 502017-09-08T00:17:46  <gmaxwell> which I guess we need to suggest. :(
 512017-09-08T00:18:09  *** d9b4bef9 has joined #bitcoin-core-dev
 522017-09-08T00:18:29  <meshcollider> importmulti [] {"rescan":true}
 532017-09-08T00:18:37  <meshcollider> empty array will work or nah?
 542017-09-08T00:18:52  <meshcollider> it doesnt seem to throw any errors
 552017-09-08T00:18:54  <jonasschnelli> i don't think so
 562017-09-08T00:19:28  <gmaxwell> It won't rescan if there is nothing to do.
 572017-09-08T00:20:08  <wumpus> that kind of makes sense, though it's sad in this case
 582017-09-08T00:20:51  <midnightmagic> .../lastlog jonasschnelli
 592017-09-08T00:21:00  <midnightmagic> sorry
 602017-09-08T00:21:05  <luke-jr> jonasschnelli: ! no:|
 612017-09-08T00:21:16  <jonasschnelli> aha. :)
 622017-09-08T00:21:20  <luke-jr> importing random untrusted stuff is not safe and should definitely not be advised..
 632017-09-08T00:21:42  <wumpus> there are certainly some risks to that
 642017-09-08T00:22:04  <midnightmagic> jonasschnelli: Yes. That SF bitcoin meetup is perfect. That's neat that peter todd stuffed a blockchain hash into his signature in a certificate notation. I wonder if I'm the only one that's actually checked that. :-)
 652017-09-08T00:22:15  <jonasschnelli> Yes. Indeed. You may import a random address from another wallet to trigger a rescan
 662017-09-08T00:22:30  <jonasschnelli> But that's why we need #7061
 672017-09-08T00:22:33  <jonasschnelli> We are claiming rescans are not required since years... but it seems like they are
 682017-09-08T00:23:05  <midnightmagic> jonasschnelli: The consistency of the signatures is not an identity verification of the guy that everyone else has met (but I have not.) :-)
 692017-09-08T00:24:06  <jonasschnelli> midnightmagic: happy to drink a coffee with you somewhere in the world.
 702017-09-08T00:24:24  <midnightmagic> I would be happy to have a coffee with you if we are ever in the same place together. \o
 712017-09-08T00:25:00  <jonasschnelli> That's the difficulty... indeed
 722017-09-08T00:27:08  <meshcollider> something like this fine then? https://github.com/bitcoin/bitcoin/pull/11280
 732017-09-08T00:27:11  <luke-jr> so encrypted HD backup tl;dr = no solution?
 742017-09-08T00:27:56  <meshcollider> no good solution, yeah, they'd have to load another wallet, generate a dummy address, then load their encrypted one and import with rescan
 752017-09-08T00:28:53  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/791a0e6ddade...c22a53cd6351
 762017-09-08T00:28:54  <bitcoin-git> bitcoin/master d4c18f7 Andrew Chow: Bump wallet version number to 159900
 772017-09-08T00:28:54  <bitcoin-git> bitcoin/master 713a920 Andrew Chow: Remove usehd option and warn when it is used...
 782017-09-08T00:28:55  <bitcoin-git> bitcoin/master c22a53c Wladimir J. van der Laan: Merge #11250: Bump wallet version to 159900 and remove the `usehd` option...
 792017-09-08T00:29:33  <bitcoin-git> [bitcoin] laanwj closed pull request #11250: Bump wallet version to 159900 and remove the `usehd` option (master...bump-wallet-version) https://github.com/bitcoin/bitcoin/pull/11250
 802017-09-08T00:30:32  <luke-jr> not sure if release notes are really the place for hacky workarounds for long-standing issues
 812017-09-08T00:30:36  <wumpus> meshcollider: thanks for doing 11280, seems it's more work than planned for
 822017-09-08T00:30:54  <wumpus> how long-standing?
 832017-09-08T00:31:17  <meshcollider> thats fine :) Yeah I'm happy to remove the rescan stuff if needed
 842017-09-08T00:31:21  <luke-jr> ever since HD wallets were introduced?
 852017-09-08T00:31:51  <meshcollider> Yeah ^ and it will be a hacky-fix-issue until the rescan RPC is merged I guess which means we should all go review jonas's PR asap lol
 862017-09-08T00:32:11  <wumpus> well a hacky workaround is better than losing funds
 872017-09-08T00:32:31  *** promag has joined #bitcoin-core-dev
 882017-09-08T00:32:56  <luke-jr> wumpus: right, but it's not a new issue, so maybe it should just be a blog post or smth?
 892017-09-08T00:33:03  <meshcollider> True, people can still ask for support on stackexchange or whatever though, doesn't have to be in the release notes I guess
 902017-09-08T00:33:20  * luke-jr watches wumpus put his laptop away
 912017-09-08T00:33:40  <meshcollider> Has anyone reported having issues with it so far or is it just a 'could happen'
 922017-09-08T00:35:30  <meshcollider> Well, my vote is to leave it in there, having a short Notes/Known Issues section in each release notes is quite a nice idea anyway imo
 932017-09-08T00:35:53  <luke-jr> meshcollider: we're all packing up and leaving, so expect a delay in response
 942017-09-08T00:36:43  *** promag has quit IRC
 952017-09-08T00:39:59  *** hxz has joined #bitcoin-core-dev
 962017-09-08T00:40:46  *** fanquake has joined #bitcoin-core-dev
 972017-09-08T00:51:27  *** luke-jr has quit IRC
 982017-09-08T00:51:35  *** luke-jr has joined #bitcoin-core-dev
 992017-09-08T00:55:58  *** fanquake has quit IRC
1002017-09-08T02:02:20  *** zmin has joined #bitcoin-core-dev
1012017-09-08T02:14:26  *** dabura667 has joined #bitcoin-core-dev
1022017-09-08T02:41:04  *** promag has joined #bitcoin-core-dev
1032017-09-08T02:45:45  *** promag has quit IRC
1042017-09-08T02:46:06  *** shesek has joined #bitcoin-core-dev
1052017-09-08T03:03:48  *** RubenSomsen has joined #bitcoin-core-dev
1062017-09-08T03:15:16  *** PaulCapestany has joined #bitcoin-core-dev
1072017-09-08T04:01:50  *** PaulCapestany has quit IRC
1082017-09-08T04:02:27  *** PaulCapestany has joined #bitcoin-core-dev
1092017-09-08T04:09:04  *** hxz has quit IRC
1102017-09-08T04:30:33  *** shesek has quit IRC
1112017-09-08T04:34:05  *** jtimon has quit IRC
1122017-09-08T04:45:47  *** otoburb has quit IRC
1132017-09-08T05:02:28  *** Gunnie has joined #bitcoin-core-dev
1142017-09-08T05:03:21  *** DrOlmer has quit IRC
1152017-09-08T05:03:47  *** DrOlmer has joined #bitcoin-core-dev
1162017-09-08T05:30:48  <bitcoin-git> [bitcoin] ajtowns opened pull request #11284: Fix invalid memory access in CScript::operator+= (master...cscript_insert) https://github.com/bitcoin/bitcoin/pull/11284
1172017-09-08T05:33:35  *** zmin has quit IRC
1182017-09-08T05:35:54  *** Pebblesbaby has joined #bitcoin-core-dev
1192017-09-08T05:37:46  *** Pebblesbaby has quit IRC
1202017-09-08T05:42:24  *** AaronvanW has quit IRC
1212017-09-08T05:50:03  *** AaronvanW has joined #bitcoin-core-dev
1222017-09-08T06:25:03  *** tripleslash has quit IRC
1232017-09-08T06:34:57  *** tripleslash has joined #bitcoin-core-dev
1242017-09-08T07:13:57  *** laurentmt has joined #bitcoin-core-dev
1252017-09-08T07:19:04  <meshcollider> the fact that -usehd is still used in wallet.cpp#L3845 is causing all travis builds on master to fail
1262017-09-08T07:19:08  *** promag has joined #bitcoin-core-dev
1272017-09-08T07:19:22  <meshcollider> because contrib/devtools/check-doc.py thinks it needs documentation
1282017-09-08T07:19:54  <meshcollider> so we can either remove it from wallet.cpp, or add an exclusion to check-doc.py I guess
1292017-09-08T07:20:26  <meshcollider> oh wait actually theres already a list of excluded arguments in check-doc, ill just add it in there
1302017-09-08T07:23:23  *** promag has quit IRC
1312017-09-08T07:24:25  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11285: Add -usehd to excluded args in check-doc.py (master...201709_fix_usehd_checkdocs) https://github.com/bitcoin/bitcoin/pull/11285
1322017-09-08T07:25:50  <meshcollider> That should probably be reviewed quickly because all Travis builds depend on it ^
1332017-09-08T07:40:18  *** RubenSomsen has quit IRC
1342017-09-08T07:41:04  *** RubenSomsen has joined #bitcoin-core-dev
1352017-09-08T07:41:26  *** promag has joined #bitcoin-core-dev
1362017-09-08T07:55:35  *** RubenSomsen has quit IRC
1372017-09-08T07:59:58  *** promag has quit IRC
1382017-09-08T08:03:02  *** d9b4bef9 has quit IRC
1392017-09-08T08:04:08  *** d9b4bef9 has joined #bitcoin-core-dev
1402017-09-08T08:16:06  *** timothy has joined #bitcoin-core-dev
1412017-09-08T08:19:03  *** hxz has joined #bitcoin-core-dev
1422017-09-08T08:33:34  <bitcoin-git> [bitcoin] fanquake opened pull request #11286: [depends] Don't build libevent sample code (master...dont-build-libevent-samples) https://github.com/bitcoin/bitcoin/pull/11286
1432017-09-08T08:35:16  *** Guyver2 has joined #bitcoin-core-dev
1442017-09-08T08:42:35  *** hxz has quit IRC
1452017-09-08T08:43:42  *** Zenton has joined #bitcoin-core-dev
1462017-09-08T08:49:04  *** VictorSN has joined #bitcoin-core-dev
1472017-09-08T08:51:30  *** promag has joined #bitcoin-core-dev
1482017-09-08T08:55:49  *** promag has quit IRC
1492017-09-08T09:16:17  *** RubenSomsen has joined #bitcoin-core-dev
1502017-09-08T09:33:41  *** satoshi has joined #bitcoin-core-dev
1512017-09-08T09:34:31  *** satoshi has left #bitcoin-core-dev
1522017-09-08T09:38:36  *** laurentmt1 has joined #bitcoin-core-dev
1532017-09-08T09:40:15  *** laurentmt has quit IRC
1542017-09-08T09:40:16  *** laurentmt1 is now known as laurentmt
1552017-09-08T09:51:21  *** AaronvanW has quit IRC
1562017-09-08T10:09:03  *** AaronvanW has joined #bitcoin-core-dev
1572017-09-08T10:11:38  *** echonaut4 has joined #bitcoin-core-dev
1582017-09-08T10:12:13  *** echonaut has quit IRC
1592017-09-08T10:13:06  *** hxz has joined #bitcoin-core-dev
1602017-09-08T10:18:08  *** VictorSN has quit IRC
1612017-09-08T10:20:11  *** SopaXorzTaker has joined #bitcoin-core-dev
1622017-09-08T10:24:03  *** belcher has joined #bitcoin-core-dev
1632017-09-08T10:35:40  *** rockhouse has quit IRC
1642017-09-08T10:36:56  *** meshcollider has quit IRC
1652017-09-08T10:37:47  <bitcoin-git> [bitcoin] danra opened pull request #11287: DRY config header inclusion (master...refactor/dry-config) https://github.com/bitcoin/bitcoin/pull/11287
1662017-09-08T10:58:18  *** gmaxwell has quit IRC
1672017-09-08T10:59:01  *** gmaxwell has joined #bitcoin-core-dev
1682017-09-08T10:59:32  *** gmaxwell is now known as Guest9986
1692017-09-08T11:09:05  *** promag has joined #bitcoin-core-dev
1702017-09-08T11:10:16  *** promag has quit IRC
1712017-09-08T11:11:05  *** chjj has quit IRC
1722017-09-08T11:12:33  *** da2ce7 has quit IRC
1732017-09-08T11:13:00  *** AaronvanW has quit IRC
1742017-09-08T11:13:32  *** promag has joined #bitcoin-core-dev
1752017-09-08T11:13:35  *** AaronvanW has joined #bitcoin-core-dev
1762017-09-08T11:16:03  *** da2ce7 has joined #bitcoin-core-dev
1772017-09-08T11:17:42  *** DrOlmer has quit IRC
1782017-09-08T11:17:55  *** AaronvanW has quit IRC
1792017-09-08T11:32:45  *** VictorSN has joined #bitcoin-core-dev
1802017-09-08T11:38:45  *** promag has quit IRC
1812017-09-08T11:43:43  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11288: More user-friendly error message when partially signing (master...201709_partial_sign_error) https://github.com/bitcoin/bitcoin/pull/11288
1822017-09-08T12:04:29  *** rockhouse has joined #bitcoin-core-dev
1832017-09-08T12:04:41  *** rockhouse has joined #bitcoin-core-dev
1842017-09-08T12:06:37  *** promag has joined #bitcoin-core-dev
1852017-09-08T12:07:33  *** AaronvanW has joined #bitcoin-core-dev
1862017-09-08T12:09:22  *** VictorSN has quit IRC
1872017-09-08T12:09:38  *** VictorSN has joined #bitcoin-core-dev
1882017-09-08T12:09:57  *** Aaronvan_ has joined #bitcoin-core-dev
1892017-09-08T12:10:56  *** promag has quit IRC
1902017-09-08T12:12:44  *** AaronvanW has quit IRC
1912017-09-08T12:13:09  *** dermoth_ has joined #bitcoin-core-dev
1922017-09-08T12:13:26  *** dermoth has quit IRC
1932017-09-08T12:13:28  *** dermoth_ is now known as dermoth
1942017-09-08T12:23:36  *** ferdousbhai has joined #bitcoin-core-dev
1952017-09-08T12:23:51  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11289: Add wallet backup text to import* and add* RPCs (master...201709_add_help_text) https://github.com/bitcoin/bitcoin/pull/11289
1962017-09-08T12:27:09  *** meshcollider has joined #bitcoin-core-dev
1972017-09-08T12:29:03  *** VictorSN has quit IRC
1982017-09-08T12:31:13  *** promag has joined #bitcoin-core-dev
1992017-09-08T12:31:15  *** ferdousbhai has quit IRC
2002017-09-08T12:38:40  *** promag has quit IRC
2012017-09-08T12:39:09  *** VictorSN has joined #bitcoin-core-dev
2022017-09-08T12:52:54  *** Aaronvan_ has quit IRC
2032017-09-08T12:53:32  *** AaronvanW has joined #bitcoin-core-dev
2042017-09-08T12:55:16  *** promag has joined #bitcoin-core-dev
2052017-09-08T12:57:37  *** AaronvanW has quit IRC
2062017-09-08T13:02:07  *** promag has quit IRC
2072017-09-08T13:04:48  *** dabura667 has quit IRC
2082017-09-08T13:07:11  *** promag has joined #bitcoin-core-dev
2092017-09-08T13:11:14  *** promag has quit IRC
2102017-09-08T13:12:33  *** promag has joined #bitcoin-core-dev
2112017-09-08T13:13:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2122017-09-08T13:22:17  *** promag has quit IRC
2132017-09-08T13:22:50  *** promag has joined #bitcoin-core-dev
2142017-09-08T13:28:35  *** kinlo has quit IRC
2152017-09-08T13:31:08  *** kinlo has joined #bitcoin-core-dev
2162017-09-08T13:37:35  *** kinlo has quit IRC
2172017-09-08T13:38:22  *** kinlo has joined #bitcoin-core-dev
2182017-09-08T13:38:46  *** shesek has joined #bitcoin-core-dev
2192017-09-08T13:38:47  *** shesek has joined #bitcoin-core-dev
2202017-09-08T13:39:39  *** jtimon has joined #bitcoin-core-dev
2212017-09-08T13:55:49  *** Gunnie has quit IRC
2222017-09-08T13:57:36  <jtimon> Args undocumented: 1
2232017-09-08T13:57:36  <jtimon> set(['-usehd'])
2242017-09-08T14:08:13  *** wxxs has joined #bitcoin-core-dev
2252017-09-08T14:22:25  *** promag has quit IRC
2262017-09-08T14:25:32  *** RubenSomsen has quit IRC
2272017-09-08T14:25:58  *** RubenSomsen has joined #bitcoin-core-dev
2282017-09-08T14:30:33  *** RubenSomsen has quit IRC
2292017-09-08T15:07:12  *** hxz has quit IRC
2302017-09-08T15:12:38  *** Gunnie has joined #bitcoin-core-dev
2312017-09-08T15:13:01  *** VictorSN has quit IRC
2322017-09-08T15:13:20  *** VictorSN has joined #bitcoin-core-dev
2332017-09-08T15:26:21  *** Mattie161 has quit IRC
2342017-09-08T15:36:56  *** meshcollider has quit IRC
2352017-09-08T15:38:41  *** wxxs has quit IRC
2362017-09-08T15:45:12  *** wxxs has joined #bitcoin-core-dev
2372017-09-08T16:00:46  *** abpa has joined #bitcoin-core-dev
2382017-09-08T16:10:39  <sdaftuar> sipa: is using upper case in the human readable part of bech32 addresses not allowed?  that wasn't clear to me from the bip, but it seems to result in broken behavior with eg the python implementation (if i'm doing this right)
2392017-09-08T16:11:15  *** Zenton has quit IRC
2402017-09-08T16:12:05  <sdaftuar> ie if you call encode and pass an hrp that contains an upper-case character, then the result doesn't seem to decode
2412017-09-08T16:21:44  *** pigsalsa has quit IRC
2422017-09-08T16:22:41  *** LampTreadStone07 has joined #bitcoin-core-dev
2432017-09-08T16:33:46  <Guest9986> sdaftuar: you have to make the whole thing uppercase or whole thing lowercase.
2442017-09-08T16:34:14  <sdaftuar> Guest9986: if i understand hrp expansion correctly though, that changes the interpretation of the hrp
2452017-09-08T16:34:25  <sdaftuar> implying that only lower case is allowed for hrp?
2462017-09-08T16:36:05  *** Murch has joined #bitcoin-core-dev
2472017-09-08T16:37:09  <Guest9986> That isn't the intent, for the checksum the lowercase value is used. I think the BIP may be a big ambigious there.
2482017-09-08T16:37:33  *** LampTreadStone07 has quit IRC
2492017-09-08T16:37:50  <sdaftuar> i don't think the lowercase value of the hrp is used -- just the lowercase value of the data
2502017-09-08T16:38:13  *** Guest9986 has quit IRC
2512017-09-08T16:38:13  *** Guest9986 has joined #bitcoin-core-dev
2522017-09-08T16:38:22  *** Guest9986 is now known as gmaxwell
2532017-09-08T16:38:49  *** VictorSN has quit IRC
2542017-09-08T16:39:39  <sdaftuar> so do you think hrp expansion should first convert to lowercase?
2552017-09-08T16:42:39  <gmaxwell> both bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4 and BC1QW508D6QEJXTDG4Y5R3ZARVARY0C5XW7KV8F3T4 are accepted by the reference code for me
2562017-09-08T16:42:58  *** cluelessperson has quit IRC
2572017-09-08T16:42:59  <sdaftuar> right, but try encoding something with an hrp using capital letters, say "BC"
2582017-09-08T16:43:05  <sdaftuar> and then try decoding
2592017-09-08T16:43:23  <sdaftuar> i think that will fail
2602017-09-08T16:45:06  <gmaxwell> The BIP says: "The lowercase form is used when determining a character's value for checksum purposes.", and the ref code correctly accepts upper and lowercase versions of the same string.  So I think what you're saying is that the encoder doesn't convert the case, but the decoder works fine.
2612017-09-08T16:45:29  <gmaxwell> So if one uses the encoder with an uppercase hrp you'll get a value that never decodes.
2622017-09-08T16:45:33  <sdaftuar> yes
2632017-09-08T16:46:13  <gmaxwell> seems plausable to me, sounds like an implementation bug, though not one that would be a problem for us. (not like the HRP is a user specified value)
2642017-09-08T16:46:55  *** laurentmt has quit IRC
2652017-09-08T16:47:04  <sdaftuar> well i wasn't sure if it was an implementation bug or a misunderstanding in my reading of the BIP
2662017-09-08T16:48:02  <gmaxwell> No misunderstanding on your part, I think: consider, since the decoder works with strings converted to uppercase, your uppercase encodes could never work, not exactly all that useful. :P
2672017-09-08T16:48:04  <sdaftuar> if we are converting the hrp to lowercase when we encode, then the BIP should probably just make that clear, that hrp values are more restricted
2682017-09-08T16:49:13  <sdaftuar> if the hrp expansion function treated upper case hrp's the same as lower-case hrp's, it woulnd't be a problem either i guess
2692017-09-08T16:51:30  *** RubenSomsen has joined #bitcoin-core-dev
2702017-09-08T16:53:49  *** pigsalsa has joined #bitcoin-core-dev
2712017-09-08T17:05:16  *** timothy has quit IRC
2722017-09-08T17:10:57  *** sanjeev has joined #bitcoin-core-dev
2732017-09-08T17:31:34  <jimpo> Would appreciate reviews on 11113 and 11116
2742017-09-08T17:43:07  <achow101> seems like travis is all messed up now
2752017-09-08T18:03:38  *** SopaXorzTaker has quit IRC
2762017-09-08T18:08:14  *** SopaXorzTaker has joined #bitcoin-core-dev
2772017-09-08T18:14:24  *** jtimon has quit IRC
2782017-09-08T18:15:04  *** SopaXorzTaker has quit IRC
2792017-09-08T18:21:21  <instagibbs> achow101, ok, not just me then
2802017-09-08T18:22:43  <achow101> instagibbs: apparently that's my fault. We need to merge 11285.
2812017-09-08T18:23:22  <achow101> I guess this is what happens when things are merged right before leaving for dinner
2822017-09-08T18:24:43  *** jtimon has joined #bitcoin-core-dev
2832017-09-08T18:40:49  *** jamesob has joined #bitcoin-core-dev
2842017-09-08T18:41:08  <jamesob> Have 4 hours on a plane to write some unittests. Any recommendations?
2852017-09-08T18:41:45  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c22a53cd6351...3255d6347b1f
2862017-09-08T18:41:45  <bitcoin-git> bitcoin/master 7d03418 MeshCollider: Add -usehd to excluded args in check-doc.py
2872017-09-08T18:41:46  <bitcoin-git> bitcoin/master 3255d63 Pieter Wuille: Merge #11285: Add -usehd to excluded args in check-doc.py...
2882017-09-08T18:42:33  <bitcoin-git> [bitcoin] sipa closed pull request #11285: Add -usehd to excluded args in check-doc.py (master...201709_fix_usehd_checkdocs) https://github.com/bitcoin/bitcoin/pull/11285
2892017-09-08T18:44:17  <sipa> restarting jobs that failed due to usehd doc
2902017-09-08T18:45:29  <instagibbs> jamesob, feel like there should be a coverage report to look at...
2912017-09-08T19:06:03  *** AdrianG is now known as aleph_null
2922017-09-08T19:15:45  <jamesob> instagibbs thanks, I'll take a look at the gcov output
2932017-09-08T19:16:35  <achow101> jamesob: you can do `./configure --enable-lcov` and then `make cov` and that will make you a testing coverage report
2942017-09-08T19:17:18  <jamesob> thanks, achow101.
2952017-09-08T19:42:58  *** jamesob has quit IRC
2962017-09-08T19:47:35  *** vicenteH has joined #bitcoin-core-dev
2972017-09-08T20:22:05  *** owowo has quit IRC
2982017-09-08T20:27:08  *** owowo has joined #bitcoin-core-dev
2992017-09-08T20:45:05  *** owowo has quit IRC
3002017-09-08T20:51:29  *** rockhouse has quit IRC
3012017-09-08T21:00:41  *** owowo has joined #bitcoin-core-dev
3022017-09-08T21:01:36  *** meshcollider has joined #bitcoin-core-dev
3032017-09-08T21:25:25  <meshcollider> Anyone else want to review #11280 (release notes)?
3042017-09-08T21:36:06  *** Guyver2 has quit IRC
3052017-09-08T21:56:02  *** wxxs has quit IRC
3062017-09-08T21:57:46  *** promag has joined #bitcoin-core-dev
3072017-09-08T22:00:55  *** promag_ has joined #bitcoin-core-dev
3082017-09-08T22:04:02  *** promag has quit IRC
3092017-09-08T22:06:22  *** Chris_Stewart_5 has quit IRC
3102017-09-08T22:16:56  *** AaronvanW has joined #bitcoin-core-dev
3112017-09-08T22:18:14  *** Aaronvan_ has joined #bitcoin-core-dev
3122017-09-08T22:21:02  *** chjj has joined #bitcoin-core-dev
3132017-09-08T22:21:32  *** AaronvanW has quit IRC
3142017-09-08T22:30:33  *** promag_ has quit IRC
3152017-09-08T22:35:27  <bitcoin-git> [bitcoin] dongsam opened pull request #11291: Fix PEP8 warnings about formatting (master...Fix-PEP8-warnings) https://github.com/bitcoin/bitcoin/pull/11291
3162017-09-08T22:38:56  *** Gunnie has quit IRC
3172017-09-08T22:41:30  <meshcollider> sipa: the fix for travis isn't on the 0.15 branch
3182017-09-08T22:41:52  <meshcollider> That's why its failing for the release notes
3192017-09-08T22:42:24  <sipa> meshcollider: oh!
3202017-09-08T22:42:33  <sipa> meshcollider: what commit needs backport?
3212017-09-08T22:43:08  <meshcollider> https://github.com/bitcoin/bitcoin/commit/aa2e0f09ec94dd0908f792ebc2249859ad174586 I believe
3222017-09-08T23:08:37  *** Austindoggie has joined #bitcoin-core-dev
3232017-09-08T23:11:44  *** abpa has quit IRC
3242017-09-08T23:12:35  *** RubenSomsen has quit IRC
3252017-09-08T23:13:11  *** promag has joined #bitcoin-core-dev
3262017-09-08T23:16:11  *** dabura667 has joined #bitcoin-core-dev
3272017-09-08T23:16:22  *** PaulCapestany has quit IRC
3282017-09-08T23:17:03  *** PaulCape_ has joined #bitcoin-core-dev
3292017-09-08T23:17:29  *** promag has quit IRC
3302017-09-08T23:21:21  <bitcoin-git> [bitcoin] sipa opened pull request #11292: travis: filter out pyenv (0.15...backport_11271) https://github.com/bitcoin/bitcoin/pull/11292
3312017-09-08T23:28:35  *** dabura667 has quit IRC
3322017-09-08T23:30:09  *** PaulCape_ has quit IRC
3332017-09-08T23:31:23  *** Aaronvan_ has quit IRC
3342017-09-08T23:32:01  *** AaronvanW has joined #bitcoin-core-dev
3352017-09-08T23:32:08  *** PaulCapestany has joined #bitcoin-core-dev
3362017-09-08T23:35:57  *** cluelessperson has joined #bitcoin-core-dev
3372017-09-08T23:36:47  *** AaronvanW has quit IRC
3382017-09-08T23:39:28  *** PaulCapestany has quit IRC
3392017-09-08T23:43:33  *** PaulCapestany has joined #bitcoin-core-dev
3402017-09-08T23:54:25  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/adcc788f2a89...5f2cf88c2311
3412017-09-08T23:54:26  <bitcoin-git> bitcoin/0.15 0ced455 Cory Fields: travis: filter out pyenv
3422017-09-08T23:54:26  <bitcoin-git> bitcoin/0.15 5f2cf88 Pieter Wuille: Merge #11292: travis: filter out pyenv...
3432017-09-08T23:54:38  *** promag has joined #bitcoin-core-dev
3442017-09-08T23:59:14  *** promag has quit IRC