12017-09-15T00:18:23 *** Squidicuz has quit IRC
22017-09-15T00:19:20 *** molz has joined #bitcoin-core-dev
32017-09-15T00:20:51 *** Squidicuz has joined #bitcoin-core-dev
42017-09-15T00:27:35 *** Alina-malina has quit IRC
52017-09-15T00:28:23 *** Murch has quit IRC
62017-09-15T00:28:46 *** Alina-malina has joined #bitcoin-core-dev
72017-09-15T00:33:41 *** AaronvanW has quit IRC
82017-09-15T00:58:50 *** dabura667 has joined #bitcoin-core-dev
92017-09-15T01:01:42 *** harrymm has quit IRC
102017-09-15T01:05:13 *** harrymm has joined #bitcoin-core-dev
112017-09-15T01:12:56 *** dabura667 has quit IRC
122017-09-15T01:14:06 *** clarkmoody has quit IRC
132017-09-15T01:14:24 *** clarkmoody has joined #bitcoin-core-dev
142017-09-15T01:16:20 *** dabura667 has joined #bitcoin-core-dev
152017-09-15T01:19:17 *** Ylbam has quit IRC
162017-09-15T01:27:09 *** AaronvanW has joined #bitcoin-core-dev
172017-09-15T01:51:55 *** alxlu has joined #bitcoin-core-dev
182017-09-15T01:52:53 *** pbase has joined #bitcoin-core-dev
192017-09-15T01:55:40 *** RubenSomsen has joined #bitcoin-core-dev
202017-09-15T02:04:34 *** fluidjax has quit IRC
212017-09-15T02:05:52 *** dabura667_ has joined #bitcoin-core-dev
222017-09-15T02:06:05 *** dabura667 has quit IRC
232017-09-15T02:25:21 *** justan0theruser has joined #bitcoin-core-dev
242017-09-15T02:43:23 *** AaronvanW has quit IRC
252017-09-15T02:49:17 *** AaronvanW has joined #bitcoin-core-dev
262017-09-15T03:09:20 *** jtimon has quit IRC
272017-09-15T03:14:48 *** justan0theruser has quit IRC
282017-09-15T03:31:22 *** justan0theruser has joined #bitcoin-core-dev
292017-09-15T03:36:54 *** Giszmo has quit IRC
302017-09-15T03:38:29 *** bane5000 has joined #bitcoin-core-dev
312017-09-15T03:54:29 *** Alina-malina has quit IRC
322017-09-15T03:54:30 *** Alina-malina has joined #bitcoin-core-dev
332017-09-15T03:57:59 <achow101> was there any agreement on whether there would be a 0.15.0.1 with BlueMatt's fix for the customfeeradio thing?
342017-09-15T03:58:44 <gmaxwell> No soap radio.
352017-09-15T03:59:05 * luke-jr thinks it'd be better to do 0.15.1 with a few more fixes
362017-09-15T03:59:47 <gmaxwell> achow101: I think the plan right now is that we will fix things and get them into the 0.15 branch ASAP, then wladimir will decide to do a release or not.
372017-09-15T04:00:08 <achow101> ok
382017-09-15T04:00:36 <achow101> I'm working on the permanent fix right now
392017-09-15T04:01:18 <luke-jr> ie removing the radio entirely?
402017-09-15T04:01:21 <gmaxwell> luke-jr: what other moderately important things are there that we know of now
412017-09-15T04:01:37 <achow101> luke-jr: yes
422017-09-15T04:02:28 <luke-jr> gmaxwell: if it was important, it'd have blocked 0.15.0; is there a reason *not* to backport the GUI positioning fix & similar stuff, if we're doing another RC cycle?
432017-09-15T04:03:02 * luke-jr wonders what changed with PPA stuff to break the build there.
442017-09-15T04:03:04 <gmaxwell> oh did we make a post 0.15 positioning fix too
452017-09-15T04:03:25 <achow101> I don't think so
462017-09-15T04:03:37 <luke-jr> #11208 ?
472017-09-15T04:03:39 <gribble> https://github.com/bitcoin/bitcoin/issues/11208 | Fixing offscreen GUI issue by MeshCollider · Pull Request #11208 · bitcoin/bitcoin · GitHub
482017-09-15T04:03:56 <achow101> I thought that was determined to not be a problem by jonasschnelli
492017-09-15T04:04:17 <achow101> I believe the problem was I was testing on either an old version or with custom something that gave me the error
502017-09-15T04:04:26 <achow101> s/error/issue
512017-09-15T04:04:28 <jonasschnelli> achow101: it may be a problem for the PPA.
522017-09-15T04:04:54 <jonasschnelli> From what I knew so far was that the offscreen issue only affected windows
532017-09-15T04:05:10 <luke-jr> gitian binaries are not the only supported (or even preferred) deployment..
542017-09-15T04:05:18 <gmaxwell> I believe there are still problems. Go position the window as far down and left as you can, then restart... But perhaps for 0.15.0.1 we would just disable remembered position rather than twiddling around with it.
552017-09-15T04:05:21 <jonasschnelli> Offscreen situations are usually handled by the OS
562017-09-15T04:06:10 *** pbase has quit IRC
572017-09-15T04:06:17 <jonasschnelli> stop remembering position would be reducing a feature for a few having problem with it.
582017-09-15T04:06:57 <gmaxwell> Yes, but the feature is minor (the software already takes a very long time to start) and the issue is very severe.
592017-09-15T04:07:13 <gmaxwell> I'm not saying that I think it should go away forever.
602017-09-15T04:07:26 <jonasschnelli> Some users arrange windows pixel by pixel.. :)
612017-09-15T04:08:00 <gmaxwell> But if we want to make a quick release it would be an easy way to prevent it from being a problem for sure.
622017-09-15T04:09:24 <meshcollider> 11208 checks for full window inclusion on the screen, and uses available screen geometry not full screen so that whatever taskbars or things dont get in the way either
632017-09-15T04:09:49 <meshcollider> so I think its still an improvement even if the original issue is gone
642017-09-15T04:10:08 <gmaxwell> meshcollider: that sounds like the right thing to do. But also sounds like it deserves non-trivial testing with weird setups.
652017-09-15T04:10:44 <bitcoin-git> [bitcoin] achow101 opened pull request #11334: Remove custom fee radio group and remove nCustomFeeRadio setting (master...rm-nCustomFeeRadio) https://github.com/bitcoin/bitcoin/pull/11334
662017-09-15T04:10:49 <jonasschnelli> gmaxwell: I just moved the windows as far down as possible and it reopened there... is that a problem?
672017-09-15T04:10:51 <jonasschnelli> Same happends to notepad.exe
682017-09-15T04:10:57 <jonasschnelli> *happens
692017-09-15T04:11:14 <jonasschnelli> (Windows 8.1)
702017-09-15T04:12:11 <gmaxwell> can you get it back out of that position again
712017-09-15T04:13:04 <jonasschnelli> Yes.
722017-09-15T04:13:22 <jonasschnelli> (Testing 0.15)
732017-09-15T04:13:28 <luke-jr> what if you use the keyboard to move it such that the titlebar isn't visible?
742017-09-15T04:13:54 <bane5000> so i've enabled pruning on my core wallet (by creating bitcoin.conf in ~/.bitcoin/) and adding pruning=10000
752017-09-15T04:14:14 <bane5000> i've restarted the bitcoin-qt, however, the old blocks do not seem to be disappearing, as my harddrive space has not been reduced
762017-09-15T04:14:15 <luke-jr> bane5000: you mean prune=10000 ? note that user issues should be in #bitcoin though
772017-09-15T04:14:29 <gmaxwell> e.g. if your screen is 1920x1080, what happens if the location is 1919,1079
782017-09-15T04:14:41 <bane5000> luke-jr: Whoopsy :)
792017-09-15T04:15:27 <bane5000> luke-jr: Would you recommend keeping a certain amount of blocks? Perhaps 20 gigs?
802017-09-15T04:15:43 <luke-jr> bane5000: #bitcoin please
812017-09-15T04:15:49 <bane5000> ugh :(
822017-09-15T04:15:57 <bane5000> You probably give a better opinion though, but fine
832017-09-15T04:16:04 <luke-jr> I'm there too
842017-09-15T04:16:28 <jonasschnelli> gmaxwell: I guess you can only position to right-bottom -1,-1 with rededit.exe
852017-09-15T04:16:51 <bane5000> okay :)
862017-09-15T04:16:51 <jonasschnelli> IMO it reacts as expected and identical to any other window based windows application
872017-09-15T04:17:27 <gmaxwell> jonasschnelli: I think you could do so pretty easily like this: increase your resolution, position it to the right bottom of your lower resolution, decrease resolution.
882017-09-15T04:17:44 <gmaxwell> Though there may be other ways to end up there.
892017-09-15T04:17:49 <meshcollider> but its not practical if it appears mostly offscreen, having to manually move it, even if thats what other windows do
902017-09-15T04:18:08 <jonasschnelli> gmaxwell: I did change the screen size and it relocates to center at a certain point.
912017-09-15T04:18:49 <jonasschnelli> Maybe (like in a flexible screen size vm like I test in) you can end up by only showing a single pixel of the window... but I guess the OS makes sure you always see the left-top icon
922017-09-15T04:19:06 <jonasschnelli> However, I think this is not a problem anymore in 0.15 gitian binaries...
932017-09-15T04:19:25 <gmaxwell> if the OS does then thats probably sufficient, but then I don't understand how we ended up completely off the screen.
942017-09-15T04:19:32 <jonasschnelli> I'm unsure about compiling it manually ... though I'm not sure how you would do this on windows
952017-09-15T04:19:55 <gmaxwell> jonasschnelli: we still support QT4 and earlier QT5 too.. it's not fixed unless we have a workaround or refuse to build with incompatible versions.
962017-09-15T04:20:07 <jonasschnelli> gmaxwell: completely off the screen with 0.15 gitian binaries on Windows seems very unlikely (I could not reproduce it and I tried for 1-2 h)
972017-09-15T04:20:48 <jonasschnelli> gmaxwell: I agree about Qt4. But I don't think anyone builds a Windows binary without our depends system. It would be a nightmare
982017-09-15T04:20:58 <gmaxwell> maybe for windows you could argue to ignore anything but gitian but we could end up off screen on linux too.. can't we
992017-09-15T04:21:50 <achow101> is qt4 supported only for the ppa?
1002017-09-15T04:21:53 <jonasschnelli> I have testes offscreen on Ubuntu 14, 16 and could also not reproduce it (by fiddling with the QSettings to set if offscreen). But possible for Qt5.
1012017-09-15T04:21:56 <jonasschnelli> Qt4, I meant
1022017-09-15T04:22:25 <jonasschnelli> achow101: I think BlueMatt has a reason to build it against Qt4... some KDE or something
1032017-09-15T04:22:40 <luke-jr> jonasschnelli: testing merely Ubuntu is not meaningful.. there are many WMs, and Ubuntu only uses one or two
1042017-09-15T04:23:09 <jonasschnelli> luke-jr: Yes. I agree. But IMO this is why we use Qt. Offscreen is either a OS thing or a QT thing.
1052017-09-15T04:23:25 <luke-jr> I suppose testing without a WM (X11 and Wayland?) might be a good approach
1062017-09-15T04:23:36 <jonasschnelli> If we are going to add patch for every WM, we will have a horrific cross-platform source code base
1072017-09-15T04:23:44 <jonasschnelli> *add patches
1082017-09-15T04:24:01 <luke-jr> I don't see why that'd be necessary
1092017-09-15T04:24:13 <luke-jr> fixing it for the dumb-WM-with-no-protection should fix it for all
1102017-09-15T04:24:22 <jonasschnelli> Offscreen seems very upstreamish... we (or someone else) need to fix it there (if its really an issue)
1112017-09-15T04:24:39 <luke-jr> that assumes we're using upstream correctly
1122017-09-15T04:24:56 <gmaxwell> saving location _at all_ seems upstreamish, but we have an implementation of that-- it seems to me that if we're implementing it, we're probably stuck implementing it completely.
1132017-09-15T04:25:14 <jonasschnelli> I'm happy to review a patch... but quick-cross-platform fixed did turn out to be much more complicated then often initially intended
1142017-09-15T04:25:16 <luke-jr> gmaxwell: +1
1152017-09-15T04:25:25 <jonasschnelli> gmaxwell: Indeed
1162017-09-15T04:26:57 <jonasschnelli> related: http://doc.qt.io/qt-4.8/restoring-geometry.html
1172017-09-15T04:27:16 <jonasschnelli> Document still available in the Qt5.9 docs: http://doc.qt.io/qt-5/restoring-geometry.html
1182017-09-15T04:27:40 <achow101> jonasschnelli: can we not just do that then to support the fix for qt4 and 5?
1192017-09-15T04:27:59 <jonasschnelli> achow101: do what?
1202017-09-15T04:28:02 <meshcollider> Should I modify 11208 to just call restoreGeometry
1212017-09-15T04:28:38 <luke-jr> we should investigate if Qt actually implements it sanely
1222017-09-15T04:28:40 <achow101> jonasschnelli: whatever those pages say to restore geometry
1232017-09-15T04:29:04 <meshcollider> Those pages suggest either using restoreGeometry OR doing it how 11208 does it I believe
1242017-09-15T04:29:13 <luke-jr> "The restore function also checks if the restored geometry is outside the available screen geometry, and modifies it as appropriate if it is:" sounds hopeful
1252017-09-15T04:29:20 <jonasschnelli> achow101: Yes. We should update to restoreGeometry... maybe this does internally check the bounds.
1262017-09-15T04:29:45 <jonasschnelli> Seems the much better approach then fiddling with the position (which is what Qt is supposed to do)
1272017-09-15T04:30:09 <jonasschnelli> luke-jr: +1
1282017-09-15T04:31:39 <jonasschnelli> Yes should replace our own saveWindowGeometry/restoreWindowGeometry with the Qt ones (not directly possible for the save)
1292017-09-15T04:32:23 <gmaxwell> I wonder how this stuff interacts with -geometry
1302017-09-15T04:32:47 <achow101> jonasschnelli: I tried with gmaxwell's suggestion of 1919,1079 and the window is definitely not visible on screen
1312017-09-15T04:33:10 <jonasschnelli> achow101: via regedit.exe?
1322017-09-15T04:33:14 <achow101> yeah
1332017-09-15T04:33:34 <jonasschnelli> 0.15.0 gitian binaries?
1342017-09-15T04:33:39 <achow101> yes, from bitcoin.org
1352017-09-15T04:33:57 <jonasschnelli> What happens if you place then +2 px?
1362017-09-15T04:35:03 <jonasschnelli> achow101: Maybe this is the expected behavior: if you place the window in screen (manually with RedEdit.exe), you want to reopen there? To hit this by accident seems very unlikely
1372017-09-15T04:35:33 <gmaxwell> jonasschnelli: I explained before. If you increase your resolution, position there. Shut down bitcoin. Reduce resolution. You will be in this state.
1382017-09-15T04:35:48 <jonasschnelli> gmaxwell: That's a different issue.. that is solved.
1392017-09-15T04:35:55 <luke-jr> â¦
1402017-09-15T04:35:57 <gmaxwell> It's a hard state to get into, but then "my bitcoins are gone!" -- a typical user will not be able to recover without a tech guru friend at least.
1412017-09-15T04:35:57 <jonasschnelli> achow101: placed it in-screen (-1,-1)
1422017-09-15T04:36:11 <luke-jr> jonasschnelli: you can get (1919,1079) the way gmaxwell describes
1432017-09-15T04:36:16 *** harrymm has quit IRC
1442017-09-15T04:36:21 <jonasschnelli> luke-jr: how?
1452017-09-15T04:36:32 <luke-jr> jonasschnelli: try to position it on the second monitor without snapping
1462017-09-15T04:36:41 <achow101> jonasschnelli: anything that is technically on screen like 1919,1079 will not be fixed. but the user can't get to it
1472017-09-15T04:37:03 <jonasschnelli> luke-jr: Thats indeed a viable argument
1482017-09-15T04:37:21 <jonasschnelli> But wait...
1492017-09-15T04:37:25 <gmaxwell> jonasschnelli: with a higher resolution you can easily drag to 1919,1079 (for example).
1502017-09-15T04:37:28 <achow101> jonasschnelli: I increased the position so that I could see it. most of the window is off screen, but the corner that matters is
1512017-09-15T04:37:42 <achow101> it can easily be covered up by the taskbar too so users can't get to it
1522017-09-15T04:37:57 <jonasschnelli> I wonder how other applicationes (test Notepad.exe) would react in this case
1532017-09-15T04:38:07 <luke-jr> stupidly IIRC
1542017-09-15T04:38:20 <gmaxwell> (and there is probably a few pixel radius which is totally inaccessible but technically on the screen where the current behavior is not sufficient. But meshcollider's or hopefully QT's would be.
1552017-09-15T04:38:54 <gmaxwell> Even if notepad is wrong (would be interesting to find out!) that still doesn't excuse bitcoin-- losing notepad is less serious then your wallet. :)
1562017-09-15T04:38:59 <achow101> jonasschnelli: it does exactly the same thing; so long as the top left corner is technically on screen, it stays there
1572017-09-15T04:39:06 <luke-jr> we can actually continue saving as we do now, but after restoring, call restoreWindowGeometry(saveWindowGeometry())â¦
1582017-09-15T04:39:17 <luke-jr> gmaxwell: but my metadata!
1592017-09-15T04:39:23 <meshcollider> Somethign like this: https://github.com/MeshCollider/bitcoin/commit/e70a784486fdda12a8a949dbb3f5fe5ea1054511
1602017-09-15T04:39:26 <jonasschnelli> I think we should update our codebase to use the Qt designated functions for restoring geometry (also available on Qt4) and see if this is better,.. then decide to patch this edge-case explicit in our codebase
1612017-09-15T04:39:26 <meshcollider> havent tested yet though
1622017-09-15T04:39:44 <jonasschnelli> achow101: you mean with Notepad.exe?
1632017-09-15T04:39:47 <gmaxwell> yea, well I think we have a target edge case to test now. Hopefully QT does the right thing.
1642017-09-15T04:40:36 <achow101> jonasschnelli: yes
1652017-09-15T04:40:43 <jonasschnelli> I'm still convinced that this issue needs to be fixed in the cross-platform layer (Qt) rather then in the application GUI logic
1662017-09-15T04:41:21 <jonasschnelli> I saw many cross-platform projects struggle after adding to much cross-platform UI patches and glitch-foixes
1672017-09-15T04:41:24 <jonasschnelli> *fixes
1682017-09-15T04:41:58 <achow101> jonasschnelli: it shouldn't be a problem if we use the Qt sanctioned method, no?
1692017-09-15T04:42:23 <jonasschnelli> achow101: you mean http://doc.qt.io/qt-5/qwidget.html#restoreGeometry?
1702017-09-15T04:42:35 <bitcoin-git> [bitcoin] MeshCollider opened pull request #11335: [WIP] Replace save|restoreWindowGeometry with Qt functions (master...201709_fix_offscreen_2) https://github.com/bitcoin/bitcoin/pull/11335
1712017-09-15T04:42:41 <achow101> yes
1722017-09-15T04:42:57 <jonasschnelli> I'm not sure if this would fix it... haven't tested it. Haven't checked the upstream by-platform code for restoreGeometry
1732017-09-15T04:43:05 <jonasschnelli> But we should def. use it
1742017-09-15T04:43:19 *** GypsyScotty has quit IRC
1752017-09-15T04:43:20 <jonasschnelli> Rather then implementing it in our layer
1762017-09-15T04:43:34 <meshcollider> Agreed
1772017-09-15T04:43:51 <luke-jr> https://gist.github.com/5c7afe24d6d4cb512c9d0940c91d5ac4
1782017-09-15T04:43:53 <achow101> well then lets try and see what it does
1792017-09-15T04:44:03 <jonasschnelli> meshcollider: Oh. Great, ... you already PRed #11335
1802017-09-15T04:44:04 <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | [WIP] Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
1812017-09-15T04:44:06 <jonasschnelli> I'll go a gitian build
1822017-09-15T04:44:19 <jonasschnelli> *do
1832017-09-15T04:45:01 <meshcollider> Oh that looks a lot better if it also checks for maximised and minimised right?
1842017-09-15T04:45:14 <meshcollider> luke-jr: is that from Qt 4
1852017-09-15T04:45:21 <gmaxwell> this code looks like it'll handle it.
1862017-09-15T04:45:21 <meshcollider> or 5
1872017-09-15T04:45:41 <luke-jr> meshcollider: 5.7
1882017-09-15T04:46:03 <gmaxwell> might want to take a quick look at 4.x just to see if it still looks sufficient there.
1892017-09-15T04:46:18 <luke-jr> so long as the current version works, IMO it's not our problem if older ones are broken
1902017-09-15T04:46:48 <achow101> luke-jr: well qt4 is still used and supported, so we want to make sure that works too
1912017-09-15T04:46:50 <luke-jr> (so long as we're outsourcing to Qt)
1922017-09-15T04:46:59 <gmaxwell> luke-jr: meh, if we build with it, it should work. at least against serious issues (and I think the program being totally inoperable is serious)
1932017-09-15T04:47:06 <meshcollider> speaking of Qt issues, does 5.9 fix any of the segfault crashes like #9683? (cf 10505)
1942017-09-15T04:47:08 <gribble> https://github.com/bitcoin/bitcoin/issues/9683 | random abort running master/HEAD · Issue #9683 · bitcoin/bitcoin · GitHub
1952017-09-15T04:47:11 <jonasschnelli> https://bitcoin.jonasschnelli.ch/build/305
1962017-09-15T04:47:22 <luke-jr> gmaxwell: disable restoring position on Qt4? :p
1972017-09-15T04:47:56 <achow101> luke-jr: qt4 has the same functions, we should check their behavior
1982017-09-15T04:47:58 <gmaxwell> luke-jr: maybe you could argue that it was sufficient if the latest QT4 had it, in any case I expect it does have similar code. This stuff seems like GUI101.
1992017-09-15T04:48:00 <meshcollider> I'd imagine 4 would still have decent restoring function anyway lol
2002017-09-15T04:48:01 <luke-jr> achow101: sure
2012017-09-15T04:48:14 <jonasschnelli> Qt4 support doesn't need to support everything: https://github.com/bitcoin/bitcoin/blob/f65614726de21e116966366d6abdf025dfeb6db2/doc/build-osx.md#L27
2022017-09-15T04:48:22 <luke-jr> gmaxwell: the Qt5 code there suggests it changed around 5.3
2032017-09-15T04:48:23 <gmaxwell> thou shall not restore the window to a location which is completely inaccessible to the user.
2042017-09-15T04:49:43 <jonasschnelli> Can we just get rid of Qt4 support? Qt 4.8 seems unmaintaned since a couple of years... very bad for a cross-platform layer
2052017-09-15T04:51:10 <luke-jr> no objection from me anymore
2062017-09-15T04:51:12 <luke-jr> fwiw
2072017-09-15T04:51:15 <gmaxwell> I dont even understand why this is coming up here.
2082017-09-15T04:51:30 <gmaxwell> Roughly the same code is in QT4. so it should be fine too.
2092017-09-15T04:52:57 <jonasschnelli> Unrelated to the offscreen bug, yes.
2102017-09-15T04:53:26 <jonasschnelli> Switching to Qt5 would allow to remove legacy code and use Qt5 features like lambdas, etc.
2112017-09-15T04:53:29 <jonasschnelli> Simpler signal bindings
2122017-09-15T04:53:45 <gmaxwell> Well, on all my machines Qt4 is the only version installed I think. I think it's still the default even in debian testing (though QT5 is available there).
2132017-09-15T04:57:33 <luke-jr> oh :/
2142017-09-15T04:57:49 <luke-jr> Now that you mention it, I do recall seeing Qt4 on Devuan
2152017-09-15T04:59:04 <gmaxwell> I'm no expert and perhaps a fresh install would change some default. And maybe we could just address by providing more install instructions.
2162017-09-15T04:59:31 <achow101> gmaxwell: perhaps you need a new laptop :p
2172017-09-15T05:03:10 <gmaxwell> your inside jokes might confuse people. :P fwiw, on an up to date debian testing system, which was QT4 only, you can parallel install QT5, but it seems bitcoin-qt still builds using QT4 even with QT5 'installed'.
2182017-09-15T05:10:13 *** Murch has joined #bitcoin-core-dev
2192017-09-15T05:18:46 *** Lauda has quit IRC
2202017-09-15T05:18:59 *** pbase has joined #bitcoin-core-dev
2212017-09-15T05:18:59 *** Lauda has joined #bitcoin-core-dev
2222017-09-15T05:23:26 *** tErik_mc has joined #bitcoin-core-dev
2232017-09-15T05:29:05 *** RubenSomsen has quit IRC
2242017-09-15T05:34:08 *** Ylbam has joined #bitcoin-core-dev
2252017-09-15T05:49:19 <meshcollider> hmmm it seems that its working, but if you move it right to the very very edge of the screen you literally cant see it, you can grab it again with the mouse but theres no way you'd be able to find it again lol
2262017-09-15T05:49:34 <meshcollider> that'd be a rare case though I'd imaging
2272017-09-15T05:49:42 <meshcollider> s/imaging/imagine/
2282017-09-15T05:52:37 <achow101> meshcollider: that's exactly the case that gmaxwell and I were testing earlier
2292017-09-15T05:53:25 <achow101> and that case is kind of the worst case scenario, not off screen, but not on screen enough to be usable
2302017-09-15T05:56:40 *** chriswakare has joined #bitcoin-core-dev
2312017-09-15T05:59:18 *** Murch has quit IRC
2322017-09-15T06:06:55 *** Guest65485 is now known as ndrst
2332017-09-15T06:07:01 *** ndrst has joined #bitcoin-core-dev
2342017-09-15T06:07:52 *** chriswakare has left #bitcoin-core-dev
2352017-09-15T06:10:19 <meshcollider> mhm but if we rely on Qt restore and save, its not really fixable by us. I'd say its a non-issue if its exactly how other OS programs behave like notepad?
2362017-09-15T06:10:57 <meshcollider> As long as its possible to get it back on screen with just the mouse, which it is, as long as you can find it lol
2372017-09-15T06:21:32 *** Dummbatz has joined #bitcoin-core-dev
2382017-09-15T06:21:46 <gmaxwell> bleh, I suppose. why do other things find that behavior tolerable.
2392017-09-15T06:22:29 <sipa> there is some key shortcut to move a window
2402017-09-15T06:23:01 <cfields_> ctrl+space gives you the min/max/move context-menu
2412017-09-15T06:23:19 <cfields_> er, alt+space
2422017-09-15T06:23:32 <meshcollider> yeah or you can shift+rightclick on the icon in the taskbar
2432017-09-15T06:23:48 * cfields_ just can't seem to leave his windows days behind him
2442017-09-15T06:24:40 <cfields_> and fwiw, i only know that because programs would end up out-of-view now and then
2452017-09-15T06:27:36 <gmaxwell> things really can get out of view and then save and restore it across restarts... how the heck have they not fixed that.
2462017-09-15T06:31:03 <meshcollider> huh I figured out an even easier way to get it back on screen, windows key + arrow
2472017-09-15T06:31:05 <cfields_> gmaxwell: well i haven't messed with it since xp, I assume they've made some progress :)
2482017-09-15T06:33:46 <midnightmagic> meh. it's qt. they only fix stuff for corps that have an upper-tier support contract.
2492017-09-15T06:34:31 <cfields_> midnightmagic: regardless of qt, the window manager is ultimately in charge of positioning
2502017-09-15T06:34:41 <cfields_> which i assume was gmaxwell's point
2512017-09-15T06:37:08 <meshcollider> ^ use a tiling window manager and all your problems disappear ;)
2522017-09-15T06:43:03 *** promag has joined #bitcoin-core-dev
2532017-09-15T06:45:34 <midnightmagic> cfields_: no, memory of a window position is not something dwm does, and I use dwm-- "we" had issues with qt windows doing stupid things, fixing it was a pointless chore.
2542017-09-15T06:46:56 <midnightmagic> xterm positioning for a new window is similar-- you pass in X geometry, and/or dwm guesses a top-left position for it, that's pretty much it
2552017-09-15T06:47:25 *** promag has quit IRC
2562017-09-15T06:49:19 <midnightmagic> eh, I might be misremembering. we had a lot of qt problems. a lot. lotta lot..
2572017-09-15T06:56:00 *** DrOlmer has quit IRC
2582017-09-15T06:56:59 *** DrOlmer has joined #bitcoin-core-dev
2592017-09-15T07:09:51 *** pbase has quit IRC
2602017-09-15T07:15:37 *** pbase has joined #bitcoin-core-dev
2612017-09-15T07:44:00 *** harrymm has joined #bitcoin-core-dev
2622017-09-15T07:47:46 *** timothy has joined #bitcoin-core-dev
2632017-09-15T07:48:28 *** drizztbsd has joined #bitcoin-core-dev
2642017-09-15T07:49:48 *** laurentmt has joined #bitcoin-core-dev
2652017-09-15T07:50:04 *** laurentmt has quit IRC
2662017-09-15T07:52:23 *** laurentmt has joined #bitcoin-core-dev
2672017-09-15T07:52:58 *** timothy has quit IRC
2682017-09-15T07:53:04 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f399a9ff227...ae233c4ec3d1
2692017-09-15T07:53:04 <bitcoin-git> bitcoin/master dc2f737 danra: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY
2702017-09-15T07:53:05 <bitcoin-git> bitcoin/master ae233c4 MarcoFalke: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY...
2712017-09-15T07:53:46 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY (master...patch-10) https://github.com/bitcoin/bitcoin/pull/11330
2722017-09-15T07:53:54 *** AaronvanW has quit IRC
2732017-09-15T07:55:54 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae233c4ec3d1...09627b1dd41d
2742017-09-15T07:55:54 <bitcoin-git> bitcoin/master cdaf3a1 Matt Corallo: Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected...
2752017-09-15T07:55:55 <bitcoin-git> bitcoin/master 09627b1 Wladimir J. van der Laan: Merge #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt)...
2762017-09-15T07:56:35 <bitcoin-git> [bitcoin] laanwj closed pull request #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) (master...2017/09/qsettings_1) https://github.com/bitcoin/bitcoin/pull/11332
2772017-09-15T07:57:39 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/46c8d23dad216d990564014f4c8000b79fd36f4e
2782017-09-15T07:57:39 <bitcoin-git> bitcoin/0.15 46c8d23 Matt Corallo: Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected...
2792017-09-15T07:58:58 *** AaronvanW has joined #bitcoin-core-dev
2802017-09-15T08:15:59 *** timothy has joined #bitcoin-core-dev
2812017-09-15T08:16:25 *** drizztbsd has quit IRC
2822017-09-15T08:18:16 <bitcoin-git> [bitcoin] danra opened pull request #11337: Fix code constness in CBlockIndex::GetAncestor() overloads (master...fix/const-get-ancestor) https://github.com/bitcoin/bitcoin/pull/11337
2832017-09-15T08:44:39 <bitcoin-git> [bitcoin] laanwj closed pull request #11208: Fixing offscreen GUI issue (master...201709_offscreen_fix) https://github.com/bitcoin/bitcoin/pull/11208
2842017-09-15T08:52:17 <wumpus> meshcollider: "mhm but if we rely on Qt restore and save, its not really fixable by us" <- well, as we never managed t oget it right in years of trying, please don't be angry at me for thinking maybe the qt devs know more about handling this and can do this better? :)
2852017-09-15T08:52:49 <meshcollider> wumpus: yeah im not saying we should do it, I'm just saying its their problem now :)
2862017-09-15T08:52:59 <wumpus> we can try this, give it one try, if it's flaky as well, I'd say we remove the functionality
2872017-09-15T08:53:16 <meshcollider> their restore and save function have a lot more benefits than ours anyway, like the maximisation issue I mentioned in my PR
2882017-09-15T08:53:22 <wumpus> it's not worth spending too much cycles on
2892017-09-15T08:53:54 <wumpus> but I'd bet quite a lot that their function received significantly more testing than us
2902017-09-15T08:53:59 <wumpus> ours*
2912017-09-15T08:55:45 <wumpus> I don't understand why this triggers yet another qt 4 discussion though, the function has existed for about forever
2922017-09-15T08:55:50 <wumpus> or is there some subtlety there?
2932017-09-15T08:56:04 *** promag has joined #bitcoin-core-dev
2942017-09-15T09:00:14 <promag> what does the "n" prefix means in nRPCConsoleWindow ?
2952017-09-15T09:01:46 *** Ylbam has quit IRC
2962017-09-15T09:01:49 *** rjak has joined #bitcoin-core-dev
2972017-09-15T09:08:21 <wumpus> "number" I guess
2982017-09-15T09:09:26 <wumpus> all of the qt settings have weird names, AFAIK it's based on satoshi's naming scheme for settings when they were still in the wallet
2992017-09-15T09:10:10 <wumpus> anyhow it doesn't really matter what the names are, as long as the names are unique within bitcoin-qt
3002017-09-15T09:10:53 <wumpus> for new settings I'd say use a plainer scheme
3012017-09-15T09:11:09 <meshcollider> its a perfect time to change the nRPCConsoleWindow and nWindow ones if you want to because theyre both new to this PR
3022017-09-15T09:11:21 <meshcollider> nRPCConsoleWindowGeometry and nWindowGeometry
3032017-09-15T09:11:27 <wumpus> but I don't care, no one is supposed to see them
3042017-09-15T09:11:44 <wumpus> right
3052017-09-15T09:12:33 <promag> yeah, I would rename since they hold a different value/type
3062017-09-15T09:13:04 <promag> the suffix "Geometry" sounds enough
3072017-09-15T09:14:04 <wumpus> yes, it's enough
3082017-09-15T09:14:20 <meshcollider> so just get rid of the 'n' at the front?
3092017-09-15T09:14:25 <meshcollider> RPCConsoleWindowGeometry and WindowGeometry ?
3102017-09-15T09:14:30 <wumpus> sounds good to me
3112017-09-15T09:14:44 <wumpus> maybe MainWindowGeometry
3122017-09-15T09:15:43 <promag> was going to say the same
3132017-09-15T09:16:58 <meshcollider> sweet done ð
3142017-09-15T09:19:48 <promag> so the old settings will stay?
3152017-09-15T09:20:46 <meshcollider> the old settings weren't called Geometry anyway, they saved position and size seperately in nWindowPos and nWindowSize
3162017-09-15T09:21:36 <meshcollider> But yeah those Pos and Size will stay in there unused
3172017-09-15T09:22:51 <wumpus> adding upgrade handling code just to remove them sounds like overkill
3182017-09-15T09:35:07 <promag> and for some reason the user can keep 2 versions installed
3192017-09-15T09:36:10 *** promag has quit IRC
3202017-09-15T09:37:58 *** promag has joined #bitcoin-core-dev
3212017-09-15T09:38:13 *** promag has joined #bitcoin-core-dev
3222017-09-15T09:43:12 <wumpus> right, or some sinister altcoin that uses the same settings directory :-)
3232017-09-15T09:43:31 *** goatpig has joined #bitcoin-core-dev
3242017-09-15T09:43:36 *** Dummbatz has left #bitcoin-core-dev
3252017-09-15T09:45:31 *** promag has joined #bitcoin-core-dev
3262017-09-15T09:47:44 *** promag has quit IRC
3272017-09-15T09:49:48 *** ula has joined #bitcoin-core-dev
3282017-09-15T09:57:31 <bitcoin-git> [bitcoin] laanwj opened pull request #11338: qt: Backup former GUI settings on `-resetguisettings` (master...2017_10_backup_resetguisettings) https://github.com/bitcoin/bitcoin/pull/11338
3292017-09-15T10:11:11 <meshcollider> Are there any other goals for 0.15.1 other than the segwit wallet support sipa is working on?
3302017-09-15T10:15:53 <bitcoin-git> [bitcoin] danra opened pull request #11339: Minor improvements to checkpoints code (master...refactor/checkpoints) https://github.com/bitcoin/bitcoin/pull/11339
3312017-09-15T10:16:09 *** supay has joined #bitcoin-core-dev
3322017-09-15T10:16:28 <supay> i was wondering if it would be possible to create a contact system where individuals grant access to another individuals contact information on top of the blockchain
3332017-09-15T10:16:38 <supay> i believe a peer-to-peer ledger recording the level of access granted or revoked could enable an open social graph
3342017-09-15T10:16:53 <supay> once there is a clean method to grant and update contact information across users, there is also now a social graph with information tiering, allowing a user-controlled and defined connection level between individuals.
3352017-09-15T10:17:04 <meshcollider> supay: wrong channel, try #bitcoin
3362017-09-15T10:17:58 <supay> meshcollider: tried :(
3372017-09-15T10:18:25 *** SopaXorzTaker has joined #bitcoin-core-dev
3382017-09-15T10:20:30 <venzen> supay: Namecoin provides namespaces for ID information
3392017-09-15T10:21:56 <supay> venzen: but no open social graph!
3402017-09-15T10:22:14 <supay> on #bitcoin ali1234 mentioned that there are still analog holes
3412017-09-15T10:22:30 <meshcollider> supay venzen: this channel is only for discussion of bitcoin core, please take this discussion to another channel
3422017-09-15T10:22:32 <supay> but i see this as a powerful p2p contact exchange and/or social graph
3432017-09-15T10:22:38 <venzen> supay: we shouldn't really discuss that here, it's off-topic for this dev channel
3442017-09-15T10:22:56 <supay> venzen: can i pm?
3452017-09-15T10:23:14 <venzen> sure
3462017-09-15T10:34:50 *** RubenSomsen has joined #bitcoin-core-dev
3472017-09-15T10:36:25 <wumpus> meshcollider: no other features at least, bugfixes are always good of course
3482017-09-15T10:44:19 <bitcoin-git> [bitcoin] danra opened pull request #11340: Trivial: Fix validation.cpp comment, BIP113 already deployed (master...patch-12) https://github.com/bitcoin/bitcoin/pull/11340
3492017-09-15T11:15:29 <bitcoin-git> [bitcoin] danra closed pull request #11331: Trivial: Update outdated comment in validation.h (master...patch-11) https://github.com/bitcoin/bitcoin/pull/11331
3502017-09-15T11:15:39 <bitcoin-git> [bitcoin] danra closed pull request #11328: Move comment about transaction/block weight calculation (master...fix/weight-comment) https://github.com/bitcoin/bitcoin/pull/11328
3512017-09-15T11:27:16 <aj> wumpus: hey, now 0.15 is out, should i ping back about #10996 (network.conf) ? we were worrying about qt/bitcoind initialisation diverging and generally making that stuff harder to understand, and potentially tests and such
3522017-09-15T11:27:18 <gribble> https://github.com/bitcoin/bitcoin/issues/10996 | [WIP] Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub
3532017-09-15T11:48:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3542017-09-15T12:16:30 <wumpus> aj: yes, agreed
3552017-09-15T12:17:07 *** dabura667_ has quit IRC
3562017-09-15T12:20:44 <wumpus> so, do a 0.15.0.1 with just #11332 or merge #11335 and maybe #11338 as well?
3572017-09-15T12:20:46 <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
3582017-09-15T12:20:47 <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
3592017-09-15T12:20:49 <gribble> https://github.com/bitcoin/bitcoin/issues/11338 | qt: Backup former GUI settings on `-resetguisettings` by laanwj · Pull Request #11338 · bitcoin/bitcoin · GitHub
3602017-09-15T12:21:21 *** Chris_Stewart_5 has quit IRC
3612017-09-15T12:21:40 <wumpus> all are necessary qt gui changes, though only the former is a crash issue
3622017-09-15T12:24:59 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3632017-09-15T12:29:38 *** pit has joined #bitcoin-core-dev
3642017-09-15T12:34:52 *** pit has quit IRC
3652017-09-15T12:44:35 *** belcher has joined #bitcoin-core-dev
3662017-09-15T12:53:33 <MarcoFalke> What is the deadline for 0.15.0.1?
3672017-09-15T12:53:53 <MarcoFalke> I might prepare some qa backports, so that people won't run into the intermittent errors we saw on travis
3682017-09-15T12:54:24 *** jtimon has joined #bitcoin-core-dev
3692017-09-15T12:54:33 <wumpus> I don't know - would be nice to have something as soon as possible to recommend to people experiencing crashes, though
3702017-09-15T12:54:34 *** promag has joined #bitcoin-core-dev
3712017-09-15T12:54:52 <wumpus> that's the motivation for it
3722017-09-15T12:55:34 <MarcoFalke> hmm, in which case it should be tagged today. To give some time for builders
3732017-09-15T12:56:55 <wumpus> if we only include 11338 do we even need a RC phase?
3742017-09-15T12:57:24 <wumpus> I guess it would be better to do one anyway, a very short one
3752017-09-15T12:58:16 <wumpus> ok, will do the version bump, update translations and tag rc1
3762017-09-15T13:00:21 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11341: [0.15.0] Bump manpages (0.15...Mf1709-docMan15) https://github.com/bitcoin/bitcoin/pull/11341
3772017-09-15T13:00:43 <MarcoFalke> wumpus: Someone complained about the manpages ^
3782017-09-15T13:02:02 <wumpus> ah yes, was just about to do that
3792017-09-15T13:02:18 <wumpus> but need after the 0.15.0.1 bump
3802017-09-15T13:05:13 <MarcoFalke> Maybe we don't need an rc phase for this 1 LOC change...
3812017-09-15T13:05:40 <wumpus> yes, maybe not
3822017-09-15T13:05:56 <MarcoFalke> If it is broken (despite testing) don't push the binaries.
3832017-09-15T13:06:23 <wumpus> and make a 0.15.0.2? :)
3842017-09-15T13:07:47 <MarcoFalke> ja :)
3852017-09-15T13:09:15 <promag> wumpus: do you think the backup filename should have the datetime?
3862017-09-15T13:11:05 <promag> also, if the file already exists it is appended, not really a backup imo
3872017-09-15T13:11:37 <wumpus> no need for a datetime, it's a one-time thing
3882017-09-15T13:11:38 <promag> *appended as in the settings are added or updated
3892017-09-15T13:11:43 *** pbase has quit IRC
3902017-09-15T13:11:44 <wumpus> oh, good point, it should be cleared first
3912017-09-15T13:12:04 <promag> thats why I thought about the timestamp
3922017-09-15T13:12:54 <wumpus> I'll just add a dst.clear()
3932017-09-15T13:14:32 <wumpus> I prefer a fixed name as I don't want people to end up with zillions of files in their datadir
3942017-09-15T13:16:06 <promag> allright
3952017-09-15T13:16:36 <promag> nit: backupSettings(filename, src) swap: backupSettings(const QSettings &src, const fs::path &filename)? :P
3962017-09-15T13:16:45 <wumpus> why?
3972017-09-15T13:17:17 *** dermoth has joined #bitcoin-core-dev
3982017-09-15T13:17:19 <promag> ah I see you prefer dst, src
3992017-09-15T13:17:22 <wumpus> yes
4002017-09-15T13:17:34 <promag> why? :P
4012017-09-15T13:18:00 <wumpus> don't feel like arguing this
4022017-09-15T13:19:11 <wumpus> both options are equally valid and it really doesn't matter here, it's an internal function not an official API
4032017-09-15T13:19:46 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11339: Minor improvements to checkpoints code (master...refactor/checkpoints) https://github.com/bitcoin/bitcoin/pull/11339
4042017-09-15T13:22:09 <warren> Does bitcoin-cli have any tool that will tell you the feerate of a rawtx?
4052017-09-15T13:22:30 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/46c8d23dad21...7123b95bea5b
4062017-09-15T13:22:30 <bitcoin-git> bitcoin/0.15 8432332 Wladimir J. van der Laan: build: Bump version to 0.15.0.1...
4072017-09-15T13:22:31 <bitcoin-git> bitcoin/0.15 7123b95 Wladimir J. van der Laan: doc: Bump manpages to 0.15.0.1...
4082017-09-15T13:24:21 <wumpus> warren: no, as that information is not in a raw transaction, it'd need the parent transactions (which aren't available without txindex)
4092017-09-15T13:25:19 <promag> unless the transaction is in your wallet
4102017-09-15T13:28:01 <promag> wumpus: in #11338 `T &x` should be `T& x`
4112017-09-15T13:28:03 <gribble> https://github.com/bitcoin/bitcoin/issues/11338 | qt: Backup former GUI settings on `-resetguisettings` by laanwj · Pull Request #11338 · bitcoin/bitcoin · GitHub
4122017-09-15T13:28:20 <wumpus> sure, but in that case you don't need a call that works on raw transactions, but would just use the wallet api...
4132017-09-15T13:29:01 <wumpus> promag: can you please do minor nits the issue instead of IRC, otherwise I'm bound to forget about them
4142017-09-15T13:30:21 <bitcoin-git> [bitcoin] laanwj closed pull request #11341: [0.15.0] Bump manpages (0.15...Mf1709-docMan15) https://github.com/bitcoin/bitcoin/pull/11341
4152017-09-15T13:37:40 <promag> wumpus: sure, done
4162017-09-15T13:37:52 <wumpus> thanks
4172017-09-15T13:40:48 *** justan0theruser has quit IRC
4182017-09-15T13:42:17 *** supay has quit IRC
4192017-09-15T13:43:03 *** BashCo_ has quit IRC
4202017-09-15T13:49:13 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/f266f2668bf8fd73015bf8265f0d00f5e858b577
4212017-09-15T13:49:14 <bitcoin-git> bitcoin/0.15 f266f26 Wladimir J. van der Laan: qt: Translations update pre-0.15.0.1...
4222017-09-15T13:51:04 *** Guyver2 has joined #bitcoin-core-dev
4232017-09-15T13:55:08 <achow101> so is 0.15.0.1 just #11332?
4242017-09-15T13:55:10 <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
4252017-09-15T13:55:46 <wumpus> yes
4262017-09-15T13:57:44 <promag> Why #11332 removes nCustomFeeRadio usage? achow101
4272017-09-15T13:57:49 <gribble> https://github.com/bitcoin/bitcoin/issues/11332 | Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt) by jonasschnelli · Pull Request #11332 · bitcoin/bitcoin · GitHub
4282017-09-15T13:57:54 <achow101> promag: no need for it
4292017-09-15T13:58:18 <wumpus> promag: see https://github.com/bitcoin/bitcoin/pull/11334
4302017-09-15T13:58:19 <promag> no need for the checkbox?
4312017-09-15T13:58:20 <achow101> it was only to store which of the custom fee radio buttons were selected, but now there is only one option, so no need for it
4322017-09-15T13:59:17 *** BashCo has joined #bitcoin-core-dev
4332017-09-15T13:59:19 <achow101> the checkbox is unrelated to that
4342017-09-15T14:00:03 <promag> ops, meant radio button
4352017-09-15T14:01:41 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/fb7b5293844ea6adc5dcf5ad0a0c5890b4495939
4362017-09-15T14:01:41 <bitcoin-git> bitcoin/0.15 fb7b529 Wladimir J. van der Laan: doc: Release notes for 0.15.0.1...
4372017-09-15T14:02:19 <promag> achow101: remove ui->labelCustomPerKilobyte->setEnable?
4382017-09-15T14:02:53 <promag> IIRC setEnabled on labels does nothing
4392017-09-15T14:02:55 <achow101> promag: no, that's required to make that row grayed out if checkBoxMinimumFee is checked
4402017-09-15T14:02:58 <achow101> I think
4412017-09-15T14:06:40 *** BashCo has quit IRC
4422017-09-15T14:07:19 <wumpus> yes the proper fix needs more review, which is why we went with the minimal fix that avoids the crash in 0.15.0.1
4432017-09-15T14:07:51 <wumpus> * [new tag] v0.15.0.1 -> v0.15.0.1
4442017-09-15T14:15:34 *** DrOlmer has quit IRC
4452017-09-15T14:15:44 *** BashCo has joined #bitcoin-core-dev
4462017-09-15T14:18:00 *** pbase has joined #bitcoin-core-dev
4472017-09-15T14:22:57 *** BashCo has quit IRC
4482017-09-15T14:23:46 <promag> wumpus: do you think Copy/BackupSettings should be in src/qt/guiutil.cpp since they are "general function"
4492017-09-15T14:24:02 <wumpus> not as long as they're only used in one place IMO
4502017-09-15T14:24:24 <wumpus> guiutil is a grab-bag for common shared stuff
4512017-09-15T14:24:28 *** BashCo has joined #bitcoin-core-dev
4522017-09-15T14:24:45 <wumpus> if something is used in only one compilation unit, better to have it static and local
4532017-09-15T14:24:57 <wumpus> can always be moved later
4542017-09-15T14:25:04 <wumpus> let's not try to overdesign this anyhow
4552017-09-15T14:25:52 <wumpus> another case of both choices being valid, it doesn't really matter
4562017-09-15T14:27:10 *** Murch has joined #bitcoin-core-dev
4572017-09-15T14:31:47 <meshcollider> sipa: why didn't you choose a 2 character HRP for bech32 regtest addresses if testnet and mainnet are both 2 characters? 'rb' or something?
4582017-09-15T14:36:19 <wumpus> probably because he didn't want to 'burn' a 2 character code on regtest, which is only meant for local testing
4592017-09-15T14:37:00 <wumpus> unlike testnet3 and mainnet it's not an 'official' network
4602017-09-15T14:47:21 *** promag has quit IRC
4612017-09-15T14:48:00 *** promag has joined #bitcoin-core-dev
4622017-09-15T14:48:01 *** Chris_Stewart_5 has quit IRC
4632017-09-15T14:53:55 *** zxzzt has quit IRC
4642017-09-15T14:53:55 *** sdaftuar has quit IRC
4652017-09-15T14:54:07 *** jnewbery has quit IRC
4662017-09-15T14:54:48 *** zxzzt has joined #bitcoin-core-dev
4672017-09-15T14:55:30 *** jnewbery has joined #bitcoin-core-dev
4682017-09-15T14:55:31 *** sdaftuar has joined #bitcoin-core-dev
4692017-09-15T14:55:31 *** sdaftuar has joined #bitcoin-core-dev
4702017-09-15T15:00:44 <morcos> achow101: while you're playing around in the QT code, i think we want to eliminate the checkbox for "Pay only the required fee ..."
4712017-09-15T15:00:59 <morcos> maybe separate PR in case we want to back port 11334
4722017-09-15T15:01:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4732017-09-15T15:02:21 <achow101> why?
4742017-09-15T15:03:12 *** AaronvanW has quit IRC
4752017-09-15T15:06:34 <morcos> sorry, why what?
4762017-09-15T15:09:36 *** AaronvanW has joined #bitcoin-core-dev
4772017-09-15T15:10:15 *** promag has quit IRC
4782017-09-15T15:12:20 <achow101> morcos: why remove that checkbox? It just means that you will be paying the minrelayfee
4792017-09-15T15:12:31 <achow101> (although the wording on it probably needs to be changed)
4802017-09-15T15:13:16 <morcos> achow101: because you can just select the minrelayfee in the custom box if you want to pay that
4812017-09-15T15:13:36 <morcos> it doesn't seem like selecting it as a stand alone option really sends the right message
4822017-09-15T15:13:42 <achow101> morcos: the user may not know what the minrelayfee is
4832017-09-15T15:14:15 <achow101> also, doesn't it change if the mempool is full?
4842017-09-15T15:14:23 <morcos> that number does not change
4852017-09-15T15:14:32 <morcos> but regardless of getting rid of that checkbox
4862017-09-15T15:14:59 <morcos> i am realizing that it's a bit annoying that you don't know what the minimum is you need to put on your transaction if you are selecting current fee
4872017-09-15T15:15:14 <morcos> perhaps we want to output a : minimum to currently be accepted in the mempool fee
4882017-09-15T15:15:29 <morcos> but i would suggest people be forced to type that into the box
4892017-09-15T15:15:45 <morcos> making it too easy to select that implies it could could be a good idea
4902017-09-15T15:15:52 <morcos> unless you're seeing that returned in fee estimation
4912017-09-15T15:15:56 <morcos> it's proably not a good idea
4922017-09-15T15:16:48 <achow101> we could change it to update the custom fee box with the fee rate that it would be using
4932017-09-15T15:17:34 <morcos> not sure i follow
4942017-09-15T15:17:44 <morcos> it uses the fee rate you give it
4952017-09-15T15:17:59 <morcos> if you're using custom fee (as opposed to recommended)
4962017-09-15T15:18:07 <morcos> even if such fee would not get you accepted to the mempool
4972017-09-15T15:19:07 <achow101> I meant that if you check the box to use minrelayfee, it can display the fee rate that it is using in the custom fee rate box right above it
4982017-09-15T15:19:44 <morcos> i just don't think we should give users an option to use the minimum
4992017-09-15T15:20:28 <morcos> it has very limited benefit... the options should be.. recommended (for a given target) or you specify
5002017-09-15T15:20:42 <morcos> we discussed in SF, and i thought there was other agreement with this idea
5012017-09-15T15:22:01 <bitcoin-git> [bitcoin] danra opened pull request #11342: Add sanity assert in CheckSequenceLocks (master...patch-13) https://github.com/bitcoin/bitcoin/pull/11342
5022017-09-15T15:22:08 <achow101> I'm afraid that if someone wants to use the minimum that they will accidentally enter 1 sat/kB (not 1000 sat/kB) in the box if they don't have the option to use the minimum
5032017-09-15T15:22:25 <morcos> well, in that case it'll be changed to 1000 for them
5042017-09-15T15:22:28 <achow101> although I suppose that can be fixed by lower bounding the box to the minrelayfee
5052017-09-15T15:22:55 *** Dizzle has joined #bitcoin-core-dev
5062017-09-15T15:23:44 <morcos> it already lower bounds.. but it doesn't really tell you it's going to
5072017-09-15T15:24:27 <morcos> in any case, i suppose there are a lot of options for how to improve this area... so maybe its not critical right now
5082017-09-15T15:28:02 <gmaxwell> you could also put 0 in the custom box and get clamped to min relay fee. no
5092017-09-15T15:28:50 <gmaxwell> oh nevermind
5102017-09-15T15:29:20 <luke-jr> another reason I thought of, that people might want to keep it: this way you can check the min fee checkbox, while retaining the current saved value for the manual fee
5112017-09-15T15:29:39 <luke-jr> but that use case might be better served by allowing users to define pre-set values
5122017-09-15T15:30:23 <morcos> gmaxwell: yes that does work
5132017-09-15T15:31:41 <gmaxwell> the nevermind was because on the line before mine you pointe dthat out. :)
5142017-09-15T15:32:00 <morcos> i'm not sure of the QT mojo to do this easily, but seems like the best outcome might be to replace the checkbox with a display of what the mempool min fee is, and have a way to click that and have it populated into the custom box
5152017-09-15T15:32:51 <morcos> then we're missing informing people of what the min relay fee is in case they actually wanted to do a tx that wouldn't yet be accepted into the mempool, but that seems pretty advanced, and maybe people will know that if they want to do it
5162017-09-15T15:33:35 <morcos> submitting these super low fee txs does have the use case for manually managed rbf bumping
5172017-09-15T15:37:52 *** jtimon has quit IRC
5182017-09-15T15:39:07 *** PaulCapestany has quit IRC
5192017-09-15T15:41:55 *** PaulCapestany has joined #bitcoin-core-dev
5202017-09-15T15:51:32 *** Chris_Stewart_5 has quit IRC
5212017-09-15T15:55:31 *** fengling has quit IRC
5222017-09-15T15:55:37 *** promag has joined #bitcoin-core-dev
5232017-09-15T15:55:39 *** fengling_ has joined #bitcoin-core-dev
5242017-09-15T15:58:24 *** riemann has joined #bitcoin-core-dev
5252017-09-15T16:04:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5262017-09-15T16:12:50 *** promag has quit IRC
5272017-09-15T16:18:06 *** JackH has quit IRC
5282017-09-15T16:37:22 *** meshcollider has quit IRC
5292017-09-15T16:44:00 <bitcoin-git> [bitcoin] isghe opened pull request #11343: added `-walletallowsymboliclink` (default false) (0.15...wallet-allow-symbolic-link) https://github.com/bitcoin/bitcoin/pull/11343
5302017-09-15T16:48:32 *** riemann has quit IRC
5312017-09-15T17:05:46 *** timothy has quit IRC
5322017-09-15T17:07:39 *** Lauda has quit IRC
5332017-09-15T17:07:53 *** Lauda has joined #bitcoin-core-dev
5342017-09-15T17:10:15 *** Aaronvan_ has joined #bitcoin-core-dev
5352017-09-15T17:12:16 *** Ylbam has joined #bitcoin-core-dev
5362017-09-15T17:12:58 *** AaronvanW has quit IRC
5372017-09-15T17:13:27 *** promag has joined #bitcoin-core-dev
5382017-09-15T17:14:26 *** abpa has joined #bitcoin-core-dev
5392017-09-15T17:14:30 *** atroxes has quit IRC
5402017-09-15T17:15:47 *** atroxes has joined #bitcoin-core-dev
5412017-09-15T17:17:41 *** promag has quit IRC
5422017-09-15T17:18:39 *** pergaminho has joined #bitcoin-core-dev
5432017-09-15T17:21:30 *** Chris_Stewart_5 has quit IRC
5442017-09-15T17:29:27 *** atroxes has quit IRC
5452017-09-15T17:30:36 <warren> Yikes. I had been using my wallet as a symbolic link for years now.
5462017-09-15T17:31:10 <sipa> i wasn't even aware that could work...
5472017-09-15T17:31:23 *** atroxes has joined #bitcoin-core-dev
5482017-09-15T17:31:43 <warren> It worked just fine.
5492017-09-15T17:33:22 *** RubenSomsen has quit IRC
5502017-09-15T17:35:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
5512017-09-15T17:39:29 *** laurentmt has quit IRC
5522017-09-15T17:41:05 <luke-jr> it shouldn't..?
5532017-09-15T17:41:17 *** SopaXorzTaker has quit IRC
5542017-09-15T17:44:36 <warren> It worked for me for years. #10885 sounds like it got more complicated with the possibility of the same wallet being opened multiple times after multi wallet was added
5552017-09-15T17:44:39 <gribble> https://github.com/bitcoin/bitcoin/issues/10885 | Reject invalid wallets by promag · Pull Request #10885 · bitcoin/bitcoin · GitHub
5562017-09-15T17:44:56 <warren> was there concern about single wallet being broken with a symlink? that worked for me for years
5572017-09-15T17:47:41 <luke-jr> warren: the concern is situations like your own: it doesn't work in a way that is useful
5582017-09-15T17:47:48 <gmaxwell> wallets being on different media than the /database directory will result in corruption.
5592017-09-15T17:47:52 <luke-jr> warren: wallet.dat being on an encrypted fs doesn't provide you any security
5602017-09-15T17:49:29 * BlueMatt also got someone on IRC asking why the PPA broke his wallet-symlink
5612017-09-15T17:49:44 <BlueMatt> I was like "oh, please dont do that...I mean will usually work, but if your system crashes, you may get fucked"
5622017-09-15T17:51:26 <warren> OK, maybe I was lucky to never run into problems.
5632017-09-15T17:52:30 <BlueMatt> well we have a loop that compacts wallet like every 100ms, and (usually) if you crash post-compact pre-writing-new-stuff you're ok, but bdb makes no guarantees there, and certainly you can get screwed if you miss the time window there
5642017-09-15T17:54:41 *** RubenSomsen has joined #bitcoin-core-dev
5652017-09-15T17:55:01 *** promag has joined #bitcoin-core-dev
5662017-09-15T17:58:01 <luke-jr> and I'd expect the wallet data to be written to the unencrypted database/ dir before getting into wallet.dat
5672017-09-15T17:58:21 <BlueMatt> i believe it does, yes
5682017-09-15T17:58:24 <BlueMatt> or the .log file
5692017-09-15T17:58:48 <gmaxwell> everything written to wallet.dat first goes through the database/ dir. IIRC
5702017-09-15T17:59:31 *** promag has quit IRC
5712017-09-15T18:01:38 *** delinquentme has joined #bitcoin-core-dev
5722017-09-15T18:01:39 *** Dizzle has quit IRC
5732017-09-15T18:01:55 *** promag has joined #bitcoin-core-dev
5742017-09-15T18:03:43 <delinquentme> running bitcoind w the option --assumevalid=<blah> but Im not seeing an update in the "verificationprogress" ... If i've given it a block that is only hours old ... shouldnt that verification shoot up?
5752017-09-15T18:04:22 <gmaxwell> Nope.
5762017-09-15T18:05:16 <gmaxwell> assume valid means skipping script processing, it doesn't (and cannot) avoid having to process blocks.
5772017-09-15T18:06:57 <gmaxwell> also, setting an assumevalid right now won't do much, as the default is a fairly recent.
5782017-09-15T18:07:58 <delinquentme> so if I've got a low compute node that I want this on, my best option for speeding up the verification is side loading it?
5792017-09-15T18:08:25 *** adiabat has quit IRC
5802017-09-15T18:08:37 *** adiabat has joined #bitcoin-core-dev
5812017-09-15T18:09:13 <gmaxwell> delinquentme: yes, or just be patient, if your system is fast enough to keep up it will catch up.
5822017-09-15T18:09:34 *** Dizzle has joined #bitcoin-core-dev
5832017-09-15T18:11:36 <BlueMatt> also -dbcache
5842017-09-15T18:12:15 <gmaxwell> BlueMatt: I didn't suggest that because most cpu starved things don't have ram.
5852017-09-15T18:13:13 <BlueMatt> ah, well sure, just saying crank it if possible
5862017-09-15T18:17:09 <delinquentme> yeah I've got that specd at 8 gigs on the machine doing the sideloading
5872017-09-15T18:17:24 <delinquentme> I've got a total of 16 ... any reason I shouldn't make it 12g?
5882017-09-15T18:22:24 <sipa> it won't use that much
5892017-09-15T18:22:37 <sipa> i believe it maxes out at around dbcache=6000
5902017-09-15T18:22:49 <sipa> but setting it higher won't hurt
5912017-09-15T18:26:35 <BlueMatt> ha! https://github.com/bitcoin/bitcoin/pull/11226#issuecomment-329289991 <-- fuck yea, I add locks
5922017-09-15T18:29:17 <sdaftuar> everyone needs a hobby! :)
5932017-09-15T18:29:50 <StopAndDecrypt_> gmaxwell, how do you measure your sync time data?
5942017-09-15T18:30:04 *** singhj has joined #bitcoin-core-dev
5952017-09-15T18:30:04 <StopAndDecrypt_> pen and pencil or do you monitor with a tool?
5962017-09-15T18:30:27 <BlueMatt> sdaftuar: considering my current push is refactoring the world to remove lockorder dependancies that may actually be true........
5972017-09-15T18:30:29 <StopAndDecrypt_> im gonna be setting up 0.15 on a rapberry pi3 in the next few weeks if you want i can try and share the info
5982017-09-15T18:30:37 <StopAndDecrypt_> if it would be useful
5992017-09-15T18:32:46 *** singhj has quit IRC
6002017-09-15T18:34:04 *** laurentmt has joined #bitcoin-core-dev
6012017-09-15T18:35:29 <gmaxwell> StopAndDecrypt_: debug log timestamp differences.
6022017-09-15T18:35:41 <gmaxwell> you can make the logs have microsecond precision too.
6032017-09-15T18:36:15 <achow101> StopAndDecrypt_: Look at the debug.log file and check the timestamps for when you start the sync and when IsInitialBlockDownload is finished
6042017-09-15T18:37:23 <StopAndDecrypt_> makes sense, just curious if that info would be useful.
6052017-09-15T18:40:37 <bitcoin-git> [bitcoin] jnewbery opened pull request #11345: [tests] Check connectivity before sending in assumevalid.py (master...assume_valid_improvement) https://github.com/bitcoin/bitcoin/pull/11345
6062017-09-15T18:46:17 *** RubenSomsen has quit IRC
6072017-09-15T18:59:50 <BlueMatt> jonasschnelli: do you believe the latest qt only fixed the offscreen issue, or did you also intend to imply that it also fixed the setSortingEnabled thing?
6082017-09-15T19:03:45 *** rpifan has joined #bitcoin-core-dev
6092017-09-15T19:07:45 *** Alina-malina has quit IRC
6102017-09-15T19:08:49 *** jtimon has joined #bitcoin-core-dev
6112017-09-15T19:08:54 *** Chris_Stewart_5 has quit IRC
6122017-09-15T19:09:45 *** Alina-malina has joined #bitcoin-core-dev
6132017-09-15T19:09:46 *** Alina-malina has joined #bitcoin-core-dev
6142017-09-15T19:13:30 *** Austindoggie has joined #bitcoin-core-dev
6152017-09-15T19:22:05 *** tErik_mc has quit IRC
6162017-09-15T19:22:57 *** pbase has quit IRC
6172017-09-15T19:24:07 *** alreadylate has joined #bitcoin-core-dev
6182017-09-15T19:31:44 *** riemann has joined #bitcoin-core-dev
6192017-09-15T19:33:53 *** Alina-malina has quit IRC
6202017-09-15T19:33:57 *** Cheeseo has joined #bitcoin-core-dev
6212017-09-15T19:34:58 *** owowo has quit IRC
6222017-09-15T19:38:09 *** Alina-malina has joined #bitcoin-core-dev
6232017-09-15T19:39:40 *** promag has quit IRC
6242017-09-15T19:40:25 *** Alina-malina has quit IRC
6252017-09-15T19:40:25 *** Alina-malina has joined #bitcoin-core-dev
6262017-09-15T19:41:16 *** owowo has joined #bitcoin-core-dev
6272017-09-15T19:57:33 *** cheese_ has joined #bitcoin-core-dev
6282017-09-15T19:58:32 *** Cheeseo has quit IRC
6292017-09-15T19:59:23 *** Aaronvan_ has quit IRC
6302017-09-15T20:00:00 *** AaronvanW has joined #bitcoin-core-dev
6312017-09-15T20:02:07 *** promag has joined #bitcoin-core-dev
6322017-09-15T20:05:19 *** laurentmt has quit IRC
6332017-09-15T20:06:25 *** promag has quit IRC
6342017-09-15T20:19:06 *** brianhoffman_ has quit IRC
6352017-09-15T20:22:29 *** laurentmt has joined #bitcoin-core-dev
6362017-09-15T20:23:06 *** laurentmt has quit IRC
6372017-09-15T20:25:34 *** pergaminho has quit IRC
6382017-09-15T20:38:20 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6392017-09-15T21:09:41 *** meshcollider has joined #bitcoin-core-dev
6402017-09-15T21:11:51 *** RoyceX has joined #bitcoin-core-dev
6412017-09-15T21:14:32 *** cheese_ has quit IRC
6422017-09-15T21:20:40 *** alreadylate has quit IRC
6432017-09-15T21:21:20 *** brianhoffman_ has joined #bitcoin-core-dev
6442017-09-15T21:47:25 *** rpifan has quit IRC
6452017-09-15T21:52:26 *** Guyver2 has quit IRC
6462017-09-15T22:08:13 *** promag has joined #bitcoin-core-dev
6472017-09-15T22:11:42 *** riemann_ has joined #bitcoin-core-dev
6482017-09-15T22:13:26 *** Dizzle has quit IRC
6492017-09-15T22:13:52 *** delinquentme has quit IRC
6502017-09-15T22:14:01 *** riemann has quit IRC
6512017-09-15T22:15:12 *** tknp has joined #bitcoin-core-dev
6522017-09-15T22:24:25 *** delinquentme has joined #bitcoin-core-dev
6532017-09-15T22:26:47 *** Chris_Stewart_5 has quit IRC
6542017-09-15T22:39:48 *** riemann_ has quit IRC
6552017-09-15T22:58:42 *** promag has quit IRC
6562017-09-15T23:07:37 *** promag has joined #bitcoin-core-dev
6572017-09-15T23:19:21 *** meshcollider has quit IRC
6582017-09-15T23:24:27 *** promag has quit IRC
6592017-09-15T23:26:23 *** cdodd has joined #bitcoin-core-dev
6602017-09-15T23:30:06 *** meshcollider has joined #bitcoin-core-dev
6612017-09-15T23:33:03 <jonasschnelli> BlueMatt: I don't think setSortingEnabled is fixed in newer Qt versions
6622017-09-15T23:39:04 *** cdodd has quit IRC
6632017-09-15T23:46:16 *** goatpig has quit IRC
6642017-09-15T23:55:24 *** tknp has quit IRC
6652017-09-15T23:57:34 *** abpa has quit IRC