12017-09-22T00:09:48  *** promag has quit IRC
  22017-09-22T00:11:26  <gmaxwell> Patches to AFL that let you target specific parts of code, e.g. to fuzz test a patch: https://github.com/aflgo/aflgo
  32017-09-22T00:12:30  *** promag has joined #bitcoin-core-dev
  42017-09-22T00:12:53  *** jl2012 has quit IRC
  52017-09-22T00:21:29  *** Deacyde has joined #bitcoin-core-dev
  62017-09-22T00:23:16  *** Geoffy has quit IRC
  72017-09-22T00:32:06  *** JackH has quit IRC
  82017-09-22T00:42:09  *** Ylbam has quit IRC
  92017-09-22T00:45:58  *** veleiro has joined #bitcoin-core-dev
 102017-09-22T00:47:06  *** dcousens has joined #bitcoin-core-dev
 112017-09-22T00:47:10  *** fengling_ has quit IRC
 122017-09-22T00:50:15  *** veleiro has quit IRC
 132017-09-22T00:51:47  *** Giszmo has quit IRC
 142017-09-22T01:00:10  *** dabura667 has joined #bitcoin-core-dev
 152017-09-22T01:07:28  *** veleiro has joined #bitcoin-core-dev
 162017-09-22T01:07:38  *** Giszmo has joined #bitcoin-core-dev
 172017-09-22T01:08:54  *** Miezel has quit IRC
 182017-09-22T01:13:55  *** fengling_ has joined #bitcoin-core-dev
 192017-09-22T01:16:01  *** Giszmo has quit IRC
 202017-09-22T01:17:35  *** Chris_Stewart_5 has quit IRC
 212017-09-22T01:26:17  *** promag has quit IRC
 222017-09-22T01:27:59  *** promag has joined #bitcoin-core-dev
 232017-09-22T01:32:18  *** promag has quit IRC
 242017-09-22T01:35:22  *** justanotheruser has joined #bitcoin-core-dev
 252017-09-22T01:47:27  *** Murch has quit IRC
 262017-09-22T01:59:20  *** Giszmo has joined #bitcoin-core-dev
 272017-09-22T02:15:30  *** owowo has quit IRC
 282017-09-22T02:16:29  *** tErik_mc has joined #bitcoin-core-dev
 292017-09-22T02:18:38  *** owowo has joined #bitcoin-core-dev
 302017-09-22T02:25:48  *** justanotheruser has quit IRC
 312017-09-22T02:45:51  *** justanotheruser has joined #bitcoin-core-dev
 322017-09-22T02:53:45  *** jl2012 has joined #bitcoin-core-dev
 332017-09-22T03:20:08  *** Miezel has joined #bitcoin-core-dev
 342017-09-22T03:49:01  *** d9b4bef9 has quit IRC
 352017-09-22T03:50:08  *** d9b4bef9 has joined #bitcoin-core-dev
 362017-09-22T03:59:11  *** veleiro has left #bitcoin-core-dev
 372017-09-22T04:03:20  *** ThomasV has joined #bitcoin-core-dev
 382017-09-22T04:17:37  *** jtimon has quit IRC
 392017-09-22T04:20:49  *** chjj has quit IRC
 402017-09-22T04:24:23  *** promag has joined #bitcoin-core-dev
 412017-09-22T04:28:28  *** promag has quit IRC
 422017-09-22T04:37:04  <ossifrage> FYI the twitching "Reindexing blocks on disk..." did not damp out as I made progress, now it is at 76% and twitching between 7 and 30 weeks
 432017-09-22T04:54:04  *** intcat has quit IRC
 442017-09-22T04:54:05  *** dermoth has quit IRC
 452017-09-22T04:54:05  *** afk11 has quit IRC
 462017-09-22T04:54:05  *** ghost43 has quit IRC
 472017-09-22T04:54:05  *** arubi has quit IRC
 482017-09-22T04:55:19  *** ghost43 has joined #bitcoin-core-dev
 492017-09-22T04:55:22  *** afk11 has joined #bitcoin-core-dev
 502017-09-22T04:58:28  *** arubi has joined #bitcoin-core-dev
 512017-09-22T05:06:32  *** harrymm has quit IRC
 522017-09-22T05:19:10  *** harrymm has joined #bitcoin-core-dev
 532017-09-22T05:28:48  <bitcoin-git> [bitcoin] Gazer022 opened pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384
 542017-09-22T05:29:37  <bitcoin-git> [bitcoin] Gazer022 closed pull request #11384: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/11384
 552017-09-22T05:30:07  *** intcat has joined #bitcoin-core-dev
 562017-09-22T05:38:39  *** Ylbam has joined #bitcoin-core-dev
 572017-09-22T05:43:58  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/49f3d57eeb66...6c4fecfaf7be
 582017-09-22T05:43:58  <bitcoin-git> bitcoin/master 2a07f87 Dan Raviv: Refactor: Modernize disallowed copy constructors/assignment...
 592017-09-22T05:43:59  <bitcoin-git> bitcoin/master 6c4fecf Pieter Wuille: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment...
 602017-09-22T05:44:39  <bitcoin-git> [bitcoin] sipa closed pull request #11351: Refactor: Modernize disallowed copy constructors/assignment (master...refactor/modernize-no-copy) https://github.com/bitcoin/bitcoin/pull/11351
 612017-09-22T05:47:24  *** ghost43 has quit IRC
 622017-09-22T05:47:50  *** ghost43 has joined #bitcoin-core-dev
 632017-09-22T06:03:12  *** ThomasV has quit IRC
 642017-09-22T06:05:03  *** SopaXorzTaker has joined #bitcoin-core-dev
 652017-09-22T06:05:10  *** SopaXorzTaker has quit IRC
 662017-09-22T06:05:48  *** SopaXorzTaker has joined #bitcoin-core-dev
 672017-09-22T06:06:52  *** SopaXorzTaker has quit IRC
 682017-09-22T06:07:10  *** SopaXorzTaker has joined #bitcoin-core-dev
 692017-09-22T06:25:58  *** promag has joined #bitcoin-core-dev
 702017-09-22T06:30:18  *** promag has quit IRC
 712017-09-22T06:34:35  *** lvmbdv has quit IRC
 722017-09-22T06:45:56  <bitcoin-git> [bitcoin] sipa opened pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
 732017-09-22T06:47:25  *** ghost43 has quit IRC
 742017-09-22T06:47:53  *** ghost43 has joined #bitcoin-core-dev
 752017-09-22T06:54:15  *** lvmbdv has joined #bitcoin-core-dev
 762017-09-22T06:55:57  *** BashCo has quit IRC
 772017-09-22T07:11:27  *** promag has joined #bitcoin-core-dev
 782017-09-22T07:15:20  *** promag has quit IRC
 792017-09-22T07:16:04  *** promag has joined #bitcoin-core-dev
 802017-09-22T07:17:00  *** promag has quit IRC
 812017-09-22T07:17:35  *** BashCo has joined #bitcoin-core-dev
 822017-09-22T07:17:50  *** ThomasV has joined #bitcoin-core-dev
 832017-09-22T07:18:49  *** paveljanik has quit IRC
 842017-09-22T07:19:43  *** Ruben has joined #bitcoin-core-dev
 852017-09-22T07:21:37  *** RubenSomsen has quit IRC
 862017-09-22T07:22:14  *** promag has joined #bitcoin-core-dev
 872017-09-22T07:22:59  *** JackH has joined #bitcoin-core-dev
 882017-09-22T07:25:51  *** timothy has joined #bitcoin-core-dev
 892017-09-22T07:34:53  *** promag has quit IRC
 902017-09-22T07:35:35  *** Ruben has quit IRC
 912017-09-22T07:42:26  *** pbase has joined #bitcoin-core-dev
 922017-09-22T07:43:24  *** alreadylate has joined #bitcoin-core-dev
 932017-09-22T07:52:18  *** dcousens has quit IRC
 942017-09-22T07:59:04  *** laurentmt has joined #bitcoin-core-dev
 952017-09-22T07:59:34  <sipa> question: how to deal with existing tests that use getnewaddress/sendtoaddress? they often don't work without modification, as spends from segwit outputs don't work before segwit activates (in block 432 on regtest)
 962017-09-22T07:59:48  <sipa> 1) force all tests to stick with legacy addresses
 972017-09-22T08:00:32  *** ghost43 has quit IRC
 982017-09-22T08:00:33  *** arubi has quit IRC
 992017-09-22T08:00:33  *** afk11 has quit IRC
1002017-09-22T08:00:33  *** intcat has quit IRC
1012017-09-22T08:01:17  <sipa> 2) make getnewaddress etc fall back to legacy addresses before segwit activation (but that's not something you want on mainnet, as it could lead to accidentally creating a legacy address if you're too fast
1022017-09-22T08:02:47  <sipa> 3) have an cmdline argument to make segwit activate from genesis in regtest (which would be on by default, excepr for tests that actually test the transition)
1032017-09-22T08:04:16  <sipa> 4) use -prematurewitness liberally, for cases where it's only wallet logic that is being tested (not validation/consensus)
1042017-09-22T08:04:21  *** tripleslash has quit IRC
1052017-09-22T08:04:41  *** asoltys has quit IRC
1062017-09-22T08:04:52  *** [b__b] has quit IRC
1072017-09-22T08:04:52  *** timothy has quit IRC
1082017-09-22T08:05:01  *** spinza has quit IRC
1092017-09-22T08:05:01  *** eck has quit IRC
1102017-09-22T08:05:11  *** [b__b] has joined #bitcoin-core-dev
1112017-09-22T08:05:17  *** timothy has joined #bitcoin-core-dev
1122017-09-22T08:05:41  *** tripleslash has joined #bitcoin-core-dev
1132017-09-22T08:06:14  *** afk11 has joined #bitcoin-core-dev
1142017-09-22T08:06:34  *** ghost43 has joined #bitcoin-core-dev
1152017-09-22T08:06:56  *** intcat has joined #bitcoin-core-dev
1162017-09-22T08:06:59  *** arubi has joined #bitcoin-core-dev
1172017-09-22T08:07:01  *** asoltys has joined #bitcoin-core-dev
1182017-09-22T08:07:05  <sipa> 5) adapt all tests to mine enough blocks up front (but that's a lot of changes... getbalance calls everywhere)
1192017-09-22T08:08:01  *** phantomcircuit has quit IRC
1202017-09-22T08:09:05  *** victorSN has quit IRC
1212017-09-22T08:10:46  *** eck has joined #bitcoin-core-dev
1222017-09-22T08:11:25  *** spinza has joined #bitcoin-core-dev
1232017-09-22T08:12:22  *** phantomcircuit has joined #bitcoin-core-dev
1242017-09-22T08:13:00  *** afk11 has quit IRC
1252017-09-22T08:16:55  *** JackH has quit IRC
1262017-09-22T08:17:09  *** JackH has joined #bitcoin-core-dev
1272017-09-22T08:19:48  *** afk11 has joined #bitcoin-core-dev
1282017-09-22T08:22:51  *** victorSN has joined #bitcoin-core-dev
1292017-09-22T08:34:37  *** vicenteH has joined #bitcoin-core-dev
1302017-09-22T08:35:12  *** dabura667 has quit IRC
1312017-09-22T08:47:22  *** Ylbam has quit IRC
1322017-09-22T08:53:49  *** Evel-Knievel has quit IRC
1332017-09-22T09:02:12  <jl2012> sipa: I think 3) is the best, as it could also show all existing tests pass with the segwit getnewaddress
1342017-09-22T09:03:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11343: added `-walletallowsymboliclink` (default false) (0.15...wallet-allow-symbolic-link) https://github.com/bitcoin/bitcoin/pull/11343
1352017-09-22T09:04:26  <meshcollider> I agree, 2 is quite nice in theory but I think 3 is best practically
1362017-09-22T09:06:46  *** Evel-Knievel has joined #bitcoin-core-dev
1372017-09-22T09:07:48  <MarcoFalke> 5 is an ugly workaround, lets not do that.
1382017-09-22T09:19:10  *** alreadylate has quit IRC
1392017-09-22T09:19:27  *** alreadylate has joined #bitcoin-core-dev
1402017-09-22T09:26:11  *** Geoffy has joined #bitcoin-core-dev
1412017-09-22T09:35:27  *** dabura667 has joined #bitcoin-core-dev
1422017-09-22T09:46:34  <gmaxwell> 5 is strictly worse than 3.  I like 3.  technically we could make mainnet activate segwit at the same time as p2sh, which would also result in regtest being born-segwit... but it would break transistion tests.
1432017-09-22T09:47:04  <gmaxwell> I don't really think we need transition tests anymore, but they're probably also incidentally testing other useful things so probably not great to just drop them.
1442017-09-22T09:53:00  *** niska has quit IRC
1452017-09-22T09:57:07  *** jtimon has joined #bitcoin-core-dev
1462017-09-22T09:57:59  *** niska has joined #bitcoin-core-dev
1472017-09-22T09:58:24  *** ThomasV has quit IRC
1482017-09-22T10:12:32  *** StopAndDecrypt_ has quit IRC
1492017-09-22T10:16:32  *** StopAndDecrypt_ has joined #bitcoin-core-dev
1502017-09-22T10:24:11  *** ThomasV has joined #bitcoin-core-dev
1512017-09-22T10:28:17  *** Sentineo has quit IRC
1522017-09-22T10:29:46  *** Shaun3811 has joined #bitcoin-core-dev
1532017-09-22T10:35:17  *** Sentineo has joined #bitcoin-core-dev
1542017-09-22T11:04:59  *** promag has joined #bitcoin-core-dev
1552017-09-22T11:07:34  *** ThomasV has quit IRC
1562017-09-22T11:16:52  *** Sentineo has quit IRC
1572017-09-22T11:16:52  *** Sentineo has joined #bitcoin-core-dev
1582017-09-22T11:18:01  *** adiabat has quit IRC
1592017-09-22T11:26:22  *** promag has quit IRC
1602017-09-22T11:30:29  *** ThomasV has joined #bitcoin-core-dev
1612017-09-22T11:30:54  *** promag has joined #bitcoin-core-dev
1622017-09-22T11:32:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c4fecfaf7be...390771be6276
1632017-09-22T11:32:16  <bitcoin-git> bitcoin/master 6951a1c MeshCollider: Remove extremely outdated share/certs dir
1642017-09-22T11:32:17  <bitcoin-git> bitcoin/master 390771b Wladimir J. van der Laan: Merge #11380: Remove outdated share/certs/ directory...
1652017-09-22T11:32:51  <bitcoin-git> [bitcoin] laanwj closed pull request #11380: Remove outdated share/certs/ directory (master...201709_remove_old_certs) https://github.com/bitcoin/bitcoin/pull/11380
1662017-09-22T11:34:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/390771be6276...94c9015bca86
1672017-09-22T11:34:06  <bitcoin-git> bitcoin/master 46c9043 Pieter Wuille: Remove some unused functions and methods...
1682017-09-22T11:34:07  <bitcoin-git> bitcoin/master 94c9015 Wladimir J. van der Laan: Merge #11385: Remove some unused functions and methods...
1692017-09-22T11:34:47  <bitcoin-git> [bitcoin] laanwj closed pull request #11385: Remove some unused functions and methods (master...201709_misc_cleanups) https://github.com/bitcoin/bitcoin/pull/11385
1702017-09-22T11:39:24  <wumpus> it's kind of sad that we never merged #9937 and no one followed up on it
1712017-09-22T11:39:25  <gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
1722017-09-22T11:40:22  <wumpus> thinking about it, I don't really think "The change as written now allows to test the existence of any file." is a concern that should have prevented it from being merged, it's much better than being able to overwrite every file
1732017-09-22T11:44:30  *** promag has quit IRC
1742017-09-22T11:45:21  <bitcoin-git> [bitcoin] laanwj reopened pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
1752017-09-22T11:45:47  *** dcousens has joined #bitcoin-core-dev
1762017-09-22T11:54:15  *** promag has joined #bitcoin-core-dev
1772017-09-22T12:07:51  *** pbase has quit IRC
1782017-09-22T12:08:10  *** promag has quit IRC
1792017-09-22T12:10:47  *** promag has joined #bitcoin-core-dev
1802017-09-22T12:11:40  <morcos> sipa: i'm in favor of 3 or even just dumping transition tests entirely.  i know sdaftuar was looking at these for his attempts to have segwit active earlier, we should get his opinion
1812017-09-22T12:12:47  *** ThomasV has quit IRC
1822017-09-22T12:15:27  *** promag has quit IRC
1832017-09-22T12:20:07  *** dcousens has quit IRC
1842017-09-22T12:21:29  *** promag has joined #bitcoin-core-dev
1852017-09-22T12:23:29  *** dabura667 has quit IRC
1862017-09-22T12:24:01  *** Miezel has joined #bitcoin-core-dev
1872017-09-22T12:24:54  *** dabura667 has joined #bitcoin-core-dev
1882017-09-22T12:28:52  <sdaftuar> sipa: i agree with 3) as the best idea for now.
1892017-09-22T12:29:22  *** dabura667 has quit IRC
1902017-09-22T12:30:43  <sdaftuar> gmaxwell: sipa: i was experimenting with moving segwit activation back to p2sh activation for mainnet, to see how much code simplification we could get
1912017-09-22T12:30:56  <sdaftuar> it ended up being a lot messier than i thought and i got a little stuck on that project--
1922017-09-22T12:31:31  <sdaftuar> moving SCRIPT_VERIFY_WITNESS enforcement back is a straightforward change, but the rules around witness commitments in the coinbase are not really changeable, as far as i can tell
1932017-09-22T12:31:55  *** dabura667 has joined #bitcoin-core-dev
1942017-09-22T12:32:51  <sdaftuar> the simplest example -- pre-segwit, someone mines a block with a witness commitment that commits to the transactions all not having a witness -- doesn't validate, because checking the commitment
1952017-09-22T12:33:02  <sdaftuar> requires checking the witness nonce, which is not present
1962017-09-22T12:33:27  <sdaftuar> never mind if there are blocks which have an incorrect commitment (pre-activation) -- i assume those exist too
1972017-09-22T12:34:30  <sdaftuar> so i was left wondering if it was worth splitting segwit activation into two parts -- one where witness commitments are only checked at some height, but SCRIPT_VERIFY_WITNESS is enforced eg from genesis
1982017-09-22T12:34:40  <sdaftuar> and my instinct was that was only complicating things, and not simplifying
1992017-09-22T12:34:49  <sdaftuar> but i'd be interested in others' opinions
2002017-09-22T12:35:53  *** dabura667 has quit IRC
2012017-09-22T12:37:06  *** dabura667 has joined #bitcoin-core-dev
2022017-09-22T12:37:57  *** dabura667 has quit IRC
2032017-09-22T12:38:11  *** veleiro has joined #bitcoin-core-dev
2042017-09-22T12:38:19  *** veleiro has left #bitcoin-core-dev
2052017-09-22T12:54:22  *** veleiro has joined #bitcoin-core-dev
2062017-09-22T12:55:28  *** promag has quit IRC
2072017-09-22T13:07:39  *** Guyver2 has joined #bitcoin-core-dev
2082017-09-22T13:39:16  *** alreadylate has quit IRC
2092017-09-22T13:43:29  *** sdfgsdfg has quit IRC
2102017-09-22T13:45:47  *** Miezel has quit IRC
2112017-09-22T13:48:26  *** veleiro has quit IRC
2122017-09-22T13:55:08  <jnewbery> sdaftuar: I think it's still worthwhile, even if you need to split SCRIPT_VERIFY_WITNESS enforcement from witness commitment verification. We could then change SCRIPT_VERIFY_WITNES activation height on regtest to 0 and remove all the transition tests (except one test for verifying that witness commitment verification is not enforced before witness commitment verification height)
2132017-09-22T13:56:04  *** meshcollider has quit IRC
2142017-09-22T13:57:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2152017-09-22T13:58:13  *** ThomasV has joined #bitcoin-core-dev
2162017-09-22T13:58:20  <jnewbery> sipa: (3) is best for now. It'd be nice to eventually dump most transition tests if possible
2172017-09-22T13:58:33  *** promag has joined #bitcoin-core-dev
2182017-09-22T14:02:10  *** justanotheruser has quit IRC
2192017-09-22T14:07:33  *** lifeofguenter has quit IRC
2202017-09-22T14:13:26  *** lifeofguenter has joined #bitcoin-core-dev
2212017-09-22T14:20:48  *** jtimon has quit IRC
2222017-09-22T14:30:03  *** promag has quit IRC
2232017-09-22T14:30:15  *** alreadylate has joined #bitcoin-core-dev
2242017-09-22T14:30:40  *** promag has joined #bitcoin-core-dev
2252017-09-22T14:32:27  *** veleiro has joined #bitcoin-core-dev
2262017-09-22T14:36:47  *** veleiro has quit IRC
2272017-09-22T14:38:49  *** promag has quit IRC
2282017-09-22T14:42:31  *** promag has joined #bitcoin-core-dev
2292017-09-22T14:44:48  *** promag has quit IRC
2302017-09-22T14:47:02  *** promag has joined #bitcoin-core-dev
2312017-09-22T14:57:00  *** AaronvanW has joined #bitcoin-core-dev
2322017-09-22T15:13:08  *** newbie is now known as newbie--
2332017-09-22T15:15:32  <instagibbs> how would people feel about removing mempoolreplacement arg? There's no tests, and I have yet to hear a reason to not allow it.(or people setting it to off)
2342017-09-22T15:23:13  *** JackH has quit IRC
2352017-09-22T15:27:02  *** promag has quit IRC
2362017-09-22T15:29:21  <jonasschnelli> wumpus: Oh. I completely forgot #9937. We should have merged it, yes.
2372017-09-22T15:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/9937 | rpc: Prevent `dumpwallet` from overwriting files by laanwj · Pull Request #9937 · bitcoin/bitcoin · GitHub
2382017-09-22T15:30:39  <Sentineo>  /window 3
2392017-09-22T15:33:43  *** RubenSomsen has joined #bitcoin-core-dev
2402017-09-22T15:38:32  <jnewbery> luke-jr: I'm looking at #11383 (nice work btw!). I don't understand the comment about it requiring #10615. It looks like they're basically orthogonal (except a bit of overlap in the RPC console). I think it'll probably aid review if you separate them out so there's no cross-dependency.
2412017-09-22T15:38:34  <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
2422017-09-22T15:38:35  <gribble> https://github.com/bitcoin/bitcoin/issues/10615 | RPC: Allow rpcauth configs to specify a 4th parameter naming a specific wallet (multiwallet RPC support) by luke-jr · Pull Request #10615 · bitcoin/bitcoin · GitHub
2432017-09-22T15:41:59  *** promag has joined #bitcoin-core-dev
2442017-09-22T15:47:25  *** adiabat has joined #bitcoin-core-dev
2452017-09-22T15:48:45  *** Murch has joined #bitcoin-core-dev
2462017-09-22T15:51:33  *** promag has quit IRC
2472017-09-22T16:00:36  *** alreadylate has quit IRC
2482017-09-22T16:02:42  *** ThomasV has quit IRC
2492017-09-22T16:07:55  *** BashCo has quit IRC
2502017-09-22T16:10:41  *** ThomasV has joined #bitcoin-core-dev
2512017-09-22T16:18:06  *** SopaXorzTaker has quit IRC
2522017-09-22T16:21:25  *** SopaXorzTaker has joined #bitcoin-core-dev
2532017-09-22T16:31:53  *** BashCo has joined #bitcoin-core-dev
2542017-09-22T16:43:31  <luke-jr> jnewbery: 10615 has the commit resolving the wallet for RPC earlier, so GUI can assign it
2552017-09-22T16:48:02  *** laurentmt has quit IRC
2562017-09-22T16:50:12  *** ThomasV has quit IRC
2572017-09-22T16:52:47  *** ThomasV has joined #bitcoin-core-dev
2582017-09-22T16:56:12  *** abpa has joined #bitcoin-core-dev
2592017-09-22T16:59:03  *** Chris_Stewart_5 has quit IRC
2602017-09-22T17:07:03  *** promag has joined #bitcoin-core-dev
2612017-09-22T17:10:49  *** Ylbam has joined #bitcoin-core-dev
2622017-09-22T17:12:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2632017-09-22T17:17:21  *** timothy has quit IRC
2642017-09-22T17:17:56  *** promag has quit IRC
2652017-09-22T17:20:32  *** Giszmo has quit IRC
2662017-09-22T17:20:35  *** Alina-malina has quit IRC
2672017-09-22T17:21:06  *** Giszmo has joined #bitcoin-core-dev
2682017-09-22T17:21:29  <jnewbery> luke-jr : That's only used for the RPC console. If I just cherry-pick all the commits apart from that, then it works fine without 10615. There are still several outstanding concerns in 10615, so I think it makes sense to separate the two PRs and allow them to be reviewed separately
2692017-09-22T17:30:07  *** Alina-malina has joined #bitcoin-core-dev
2702017-09-22T17:32:54  *** ThomasV has quit IRC
2712017-09-22T17:34:41  *** Alina-malina has quit IRC
2722017-09-22T17:34:42  *** Alina-malina has joined #bitcoin-core-dev
2732017-09-22T17:35:50  *** ula has joined #bitcoin-core-dev
2742017-09-22T17:38:37  *** promag has joined #bitcoin-core-dev
2752017-09-22T17:38:51  *** promag has joined #bitcoin-core-dev
2762017-09-22T17:40:52  *** alreadylate has joined #bitcoin-core-dev
2772017-09-22T17:40:53  *** laurentmt has joined #bitcoin-core-dev
2782017-09-22T17:43:31  *** Emcy has joined #bitcoin-core-dev
2792017-09-22T17:45:37  *** Emcy_ has quit IRC
2802017-09-22T17:55:21  *** abpa has quit IRC
2812017-09-22T17:59:46  *** vicenteH has quit IRC
2822017-09-22T18:04:22  *** alreadylate has quit IRC
2832017-09-22T18:12:37  *** Emcy_ has joined #bitcoin-core-dev
2842017-09-22T18:14:35  *** Emcy has quit IRC
2852017-09-22T18:15:15  *** Emcy has joined #bitcoin-core-dev
2862017-09-22T18:17:46  *** Emcy_ has quit IRC
2872017-09-22T18:23:22  <luke-jr> jnewbery: it should be used by WalletModel too (although maybe it isn't yet)
2882017-09-22T18:23:31  <luke-jr> (pretty sure it is tho)
2892017-09-22T18:35:12  *** Emcy_ has joined #bitcoin-core-dev
2902017-09-22T18:37:48  *** Emcy has quit IRC
2912017-09-22T18:46:43  *** Emcy has joined #bitcoin-core-dev
2922017-09-22T18:48:09  <achow101> .... wow. I managed to get bitcoin 0.1.0 to start syncing off of Core 0.15.99
2932017-09-22T18:48:44  *** alreadylate has joined #bitcoin-core-dev
2942017-09-22T18:49:21  *** Emcy_ has quit IRC
2952017-09-22T18:49:50  <sipa> achow101: i assume you needed to patch 0.1.0 a bit?
2962017-09-22T18:50:16  <achow101> sipa: I patched Core to speak 0.1.0
2972017-09-22T18:50:35  <achow101> and apparently bitcoin.org's docs are wrong
2982017-09-22T18:50:41  <sipa> fix them!
2992017-09-22T18:50:45  <achow101> I will
3002017-09-22T18:53:25  *** ThomasV has joined #bitcoin-core-dev
3012017-09-22T18:53:55  <sipa> morcos: perhaps you can answer https://bitcoin.stackexchange.com/questions/59854/where-are-the-new-smart-fee-estimate-data-saved-can-the-file-be-re-used
3022017-09-22T18:59:47  *** promag has quit IRC
3032017-09-22T19:06:44  *** SopaXorzTaker has quit IRC
3042017-09-22T19:07:35  *** jtimon has joined #bitcoin-core-dev
3052017-09-22T19:08:35  <morcos> sipa: ok done
3062017-09-22T19:08:51  <achow101> are coinbase transactions supposed to have witnesses?
3072017-09-22T19:09:12  <achow101> I'm seeing coinbase transactions with witness fields of 32 bytes of 0's
3082017-09-22T19:09:29  <achow101> *1 stack item of 32 bytes of 0's
3092017-09-22T19:09:31  <sipa> achow101: yes
3102017-09-22T19:09:42  <sipa> achow101: they're a field intended for extensibility
3112017-09-22T19:10:11  <achow101> sipa: oh, ok. I don't see that in the BIPs though..
3122017-09-22T19:10:38  <achow101> oh, nvm. found it in bip 141
3132017-09-22T19:10:48  *** RubenSomsen has quit IRC
3142017-09-22T19:10:57  <sipa> it's called 'witness reserved value' in the bip
3152017-09-22T19:11:01  *** alreadylate has quit IRC
3162017-09-22T19:18:25  *** afk11 has quit IRC
3172017-09-22T19:18:45  *** afk11 has joined #bitcoin-core-dev
3182017-09-22T19:22:03  *** Emcy_ has joined #bitcoin-core-dev
3192017-09-22T19:22:23  *** SopaXorzTaker has joined #bitcoin-core-dev
3202017-09-22T19:24:16  *** Emcy has quit IRC
3212017-09-22T19:26:52  *** thomas__ has joined #bitcoin-core-dev
3222017-09-22T19:27:52  <thomas__> Hey guys, new here. Does someone have to work on windows and has a good workflow set up ?
3232017-09-22T19:28:11  <sipa> a good workflow for what?
3242017-09-22T19:28:24  <thomas__> to dev
3252017-09-22T19:30:49  *** promag has joined #bitcoin-core-dev
3262017-09-22T19:31:57  <thomas__> I'll be rebuilding a lot this weekend to see how things work, if someone has a way to make it less painful I'd like to hear from him ^^
3272017-09-22T19:32:14  <achow101> thomas__: use linux and read the Bitcoin Core docs
3282017-09-22T19:33:01  <thomas__> damit, everyone has the same answer. I have an ubuntu set up on my computer, but I also have to do stuff on windows. I don't see myself switching 3 times a day between both.
3292017-09-22T19:33:20  <achow101> thomas__: then use a VM
3302017-09-22T19:33:22  *** Chris_Stewart_5 has quit IRC
3312017-09-22T19:33:35  <achow101> developing things is infintely easier to do in a *nix environment than windows
3322017-09-22T19:33:39  *** promag has quit IRC
3332017-09-22T19:33:42  <sipa> how well does bash-on-windows work these days?
3342017-09-22T19:34:17  <achow101> sipa: pretty well, but AFAIK, no gui support
3352017-09-22T19:34:22  <thomas__> the wsl works if you keep all your file on the linux side
3362017-09-22T19:34:27  <achow101> i.e. can't run bitcoin-qt
3372017-09-22T19:35:05  <thomas__> I'm cross compiling right now, I'll know after that
3382017-09-22T19:35:26  *** alreadylate has joined #bitcoin-core-dev
3392017-09-22T19:35:39  <achow101> thomas__: I suppose you could use wsl and cross compile. note that cross compiling with ubuntu 15.10+ (wsl uses ubuntu 16.04) is a bit flaky
3402017-09-22T19:35:43  *** Emcy has joined #bitcoin-core-dev
3412017-09-22T19:37:10  <thomas__> Apparently mine uses: Description:    Ubuntu 14.04.5 LTS
3422017-09-22T19:37:18  <thomas__> So should be ok then
3432017-09-22T19:38:05  <bitcoin-git> [bitcoin] runn1ng opened pull request #11386: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (master...univalue_bikeshed) https://github.com/bitcoin/bitcoin/pull/11386
3442017-09-22T19:38:17  *** SopaXorzTaker has quit IRC
3452017-09-22T19:38:51  *** Emcy_ has quit IRC
3462017-09-22T19:42:40  *** SopaXorzTaker has joined #bitcoin-core-dev
3472017-09-22T19:53:36  *** SopaXorzTaker has quit IRC
3482017-09-22T19:55:18  *** Emcy_ has joined #bitcoin-core-dev
3492017-09-22T19:57:30  *** SopaXorzTaker has joined #bitcoin-core-dev
3502017-09-22T19:57:41  *** Emcy has quit IRC
3512017-09-22T20:03:36  *** SopaXorzTaker has quit IRC
3522017-09-22T20:07:31  *** alreadylate has quit IRC
3532017-09-22T20:12:54  *** alreadylate has joined #bitcoin-core-dev
3542017-09-22T20:12:55  <achow101> with old versions of bitcoin (e.g. 0.1.0), what happens if they receive blocks out of order?
3552017-09-22T20:14:29  *** alreadylate has quit IRC
3562017-09-22T20:16:27  *** vicenteH has joined #bitcoin-core-dev
3572017-09-22T20:17:35  <sipa> achow101: stored as orphans in memory until the parent is fetched
3582017-09-22T20:18:09  <sipa> at some point we limited the size of the orphan block pool, which resulted in the same blocks being fetched over and over again
3592017-09-22T20:18:12  *** Emcy has joined #bitcoin-core-dev
3602017-09-22T20:18:15  <sipa> until headers-sync in 0.10
3612017-09-22T20:21:05  *** Emcy_ has quit IRC
3622017-09-22T20:25:50  *** laurentmt has quit IRC
3632017-09-22T20:26:37  *** ossifrage has quit IRC
3642017-09-22T20:27:50  *** Emcy_ has joined #bitcoin-core-dev
3652017-09-22T20:30:05  *** SopaXorzTaker has joined #bitcoin-core-dev
3662017-09-22T20:30:35  *** Emcy has quit IRC
3672017-09-22T20:32:16  <esotericnonsense> thomas__: if you haven't spent much time working in VM's I'd really recommend it. on modern hardware it's a treat.
3682017-09-22T20:32:47  <thomas__> A few years ago a lot of people were bitching about it and so I never took the time to really try
3692017-09-22T20:32:49  * esotericnonsense is pleased to see virgl slowly working its way into kvm
3702017-09-22T20:34:23  *** promag has joined #bitcoin-core-dev
3712017-09-22T20:35:29  *** darkROL has joined #bitcoin-core-dev
3722017-09-22T20:35:35  *** SopaXorzTaker has quit IRC
3732017-09-22T20:38:35  *** promag has quit IRC
3742017-09-22T20:38:43  *** Emcy has joined #bitcoin-core-dev
3752017-09-22T20:41:46  *** Emcy_ has quit IRC
3762017-09-22T20:47:06  *** abpa has joined #bitcoin-core-dev
3772017-09-22T20:48:12  *** darkROL has quit IRC
3782017-09-22T20:50:36  *** SopaXorzTaker has joined #bitcoin-core-dev
3792017-09-22T20:50:49  <jonasschnelli> Should we tolerate lost GUI window positions in 0.16 (the window will recenter in 0.16 when merging #11335)
3802017-09-22T20:50:52  <gribble> https://github.com/bitcoin/bitcoin/issues/11335 | Replace save|restoreWindowGeometry with Qt functions by MeshCollider · Pull Request #11335 · bitcoin/bitcoin · GitHub
3812017-09-22T20:52:58  *** laurentmt has joined #bitcoin-core-dev
3822017-09-22T20:56:22  *** SopaXorzTaker has quit IRC
3832017-09-22T20:57:05  *** danra has joined #bitcoin-core-dev
3842017-09-22T20:58:20  *** laurentmt has quit IRC
3852017-09-22T21:03:39  *** Emcy_ has joined #bitcoin-core-dev
3862017-09-22T21:05:17  *** Emcy has quit IRC
3872017-09-22T21:05:45  *** ThomasV has quit IRC
3882017-09-22T21:10:05  *** Sinclair6 has joined #bitcoin-core-dev
3892017-09-22T21:12:17  *** Guyver2 has quit IRC
3902017-09-22T21:22:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3912017-09-22T21:22:34  * luke-jr ponders if BIP editor should be enabled to fix spelling/grammar without going through the author
3922017-09-22T21:26:59  *** promag has joined #bitcoin-core-dev
3932017-09-22T21:27:57  *** SopaXorzTaker has joined #bitcoin-core-dev
3942017-09-22T21:33:48  *** SopaXorzTaker has quit IRC
3952017-09-22T21:42:35  *** Chris_Stewart_5 has quit IRC
3962017-09-22T21:43:12  *** Emcy has joined #bitcoin-core-dev
3972017-09-22T21:45:54  *** Emcy_ has quit IRC
3982017-09-22T21:50:54  *** SopaXorzTaker has joined #bitcoin-core-dev
3992017-09-22T21:56:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4002017-09-22T21:59:03  *** danra has quit IRC
4012017-09-22T22:02:09  *** Aaronvan_ has joined #bitcoin-core-dev
4022017-09-22T22:02:34  *** Emcy_ has joined #bitcoin-core-dev
4032017-09-22T22:02:56  *** Aaronvan_ has joined #bitcoin-core-dev
4042017-09-22T22:04:37  *** Emcy has quit IRC
4052017-09-22T22:05:09  *** AaronvanW has quit IRC
4062017-09-22T22:07:54  *** Miezel has joined #bitcoin-core-dev
4072017-09-22T22:09:35  *** SopaXorzTaker has quit IRC
4082017-09-22T22:15:30  *** thomas__ has quit IRC
4092017-09-22T22:18:54  *** promag has quit IRC
4102017-09-22T22:23:28  *** fengling_ has quit IRC
4112017-09-22T22:24:05  *** fengling_ has joined #bitcoin-core-dev
4122017-09-22T22:25:58  *** chjj has joined #bitcoin-core-dev
4132017-09-22T22:27:21  *** ossifrage has joined #bitcoin-core-dev
4142017-09-22T22:27:21  *** ossifrage has joined #bitcoin-core-dev
4152017-09-22T22:27:51  <ossifrage> That is really annoying chrome decided to eat up all the memory, but the oom killer took out bitcoin (while doing a reindex) and somehow the progress went from 99ish% to 85%, that is quite a bit of rollback
4162017-09-22T22:31:35  *** Chris_Stewart_5 has quit IRC
4172017-09-22T22:31:59  <esotericnonsense> ossifrage: how long does the entire reindex take? if it's the same mechanism as during IBD then with a high dbcache value it's just every N minutes/hours (don't remember the figure)
4182017-09-22T22:32:53  <esotericnonsense> (sorry, that's a flush happening every N minutes/hours)
4192017-09-22T22:33:06  <gmaxwell> ossifrage: it'll rollback to the last flush. In the future we'll hopefully switch to more incremental flushing which will roll back less far in the event of a crash during initial sync.
4202017-09-22T22:34:11  <ossifrage> gmaxwell, I had a 4G dbcache which was part of the reason the oom killer picked on bitcoin
4212017-09-22T22:34:22  <esotericnonsense> static const unsigned int DATABASE_FLUSH_INTERVAL = 24 * 60 * 60;
4222017-09-22T22:34:39  <esotericnonsense> O_o
4232017-09-22T22:34:42  <gmaxwell> I wish linux mem handling had a "shrink now or you're gonna get killed" signal.
4242017-09-22T22:35:19  <gmaxwell> esotericnonsense: that means it'll force a flush once a day if it hasn't been triggered by the cache filling.
4252017-09-22T22:35:31  <gmaxwell> during IBD cache filling triggers the flushes.
4262017-09-22T22:35:35  *** To7 has joined #bitcoin-core-dev
4272017-09-22T22:36:18  <ossifrage> esotericnonsense, I am generating the full tx index (txindex=1) and it is taking a very long time [I'm not sure when I started it, the debug.log got truncated]
4282017-09-22T22:36:26  <ossifrage> >24 hours ago
4292017-09-22T22:37:09  <gmaxwell> >24 hours with a 4gb dbcache. damn txindex.
4302017-09-22T22:37:52  <esotericnonsense> think my laptop was sub 24hours when I did it and it's not super-fast or anything. though that was syncing over LAN rather than reindex.
4312017-09-22T22:38:04  <esotericnonsense> (with txindex on).
4322017-09-22T22:38:37  <esotericnonsense> is that on a HDD?
4332017-09-22T22:38:44  <ossifrage> gmaxwell, it doesn't seem to be IO or CPU bound, but I am using spinning rust, it seemed wasteful to eat up a large % of my ssd on bitcoin
4342017-09-22T22:38:49  <esotericnonsense> ah yeah.
4352017-09-22T22:40:06  <gmaxwell> ossifrage: with a large dbcache it doesn't matter if you're on a SSD or rust when txindex is not in use, alas...
4362017-09-22T22:40:47  <ossifrage> If I turn txindex off, do I have to start over again when I turn it back on?
4372017-09-22T22:43:09  <ossifrage> The last log entry was 96% with a 2446MB dbcache and it rolled back to 84% (my memory of almost done was faulty)
4382017-09-22T22:46:29  *** promag has joined #bitcoin-core-dev
4392017-09-22T22:50:41  *** promag has quit IRC
4402017-09-22T23:06:31  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/94c9015bca86...877678710800
4412017-09-22T23:06:32  <bitcoin-git> bitcoin/master 6059182 Marko Bencun: add m_added_nodes to connman options
4422017-09-22T23:06:32  <bitcoin-git> bitcoin/master 35e5c22 Marko Bencun: remove unused IsArgSet check...
4432017-09-22T23:06:33  <bitcoin-git> bitcoin/master 8776787 Pieter Wuille: Merge #11301: add m_added_nodes to connman options...
4442017-09-22T23:07:18  <bitcoin-git> [bitcoin] sipa closed pull request #11301: add m_added_nodes to connman options (master...addnode) https://github.com/bitcoin/bitcoin/pull/11301
4452017-09-22T23:07:23  <esotericnonsense> ossifrage: if you have enough log, you can go back and find the time when dbcache reset, that will be the last flush probably at 84%.
4462017-09-22T23:09:31  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/877678710800...c6223b3daab0
4472017-09-22T23:09:31  <bitcoin-git> bitcoin/master 22fd04b Gregory Maxwell: Remove nBlockMaxSize from miner opt struct as it is no longer used.
4482017-09-22T23:09:32  <bitcoin-git> bitcoin/master c6223b3 Pieter Wuille: Merge #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used....
4492017-09-22T23:10:11  <bitcoin-git> [bitcoin] sipa closed pull request #11362: Remove nBlockMaxSize from miner opt struct as it is no longer used. (master...2017_09_rm_nBlockMaxSize) https://github.com/bitcoin/bitcoin/pull/11362
4502017-09-22T23:10:44  *** meshcollider has joined #bitcoin-core-dev
4512017-09-22T23:12:05  *** dcousens has joined #bitcoin-core-dev
4522017-09-22T23:16:28  <bitcoin-git> [bitcoin] theuni opened pull request #11387: net: remove more CConnman globals (master...more-connman-params) https://github.com/bitcoin/bitcoin/pull/11387
4532017-09-22T23:18:08  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6223b3daab0...aeed345c9bad
4542017-09-22T23:18:09  <bitcoin-git> bitcoin/master e912118 Johnson Lau: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck
4552017-09-22T23:18:09  <bitcoin-git> bitcoin/master 3a131b7 Johnson Lau: Rename out to m_tx_out in CScriptCheck
4562017-09-22T23:18:10  <bitcoin-git> bitcoin/master aeed345 Pieter Wuille: Merge #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck...
4572017-09-22T23:18:33  <bitcoin-git> [bitcoin] sipa closed pull request #10953: [Refactor] Combine scriptPubKey and amount as CTxOut in CScriptCheck (master...combine_script_amount) https://github.com/bitcoin/bitcoin/pull/10953
4582017-09-22T23:35:54  *** dcousens has quit IRC
4592017-09-22T23:41:19  *** Emcy has joined #bitcoin-core-dev
4602017-09-22T23:43:08  *** promag has joined #bitcoin-core-dev
4612017-09-22T23:43:18  *** Miezel has quit IRC
4622017-09-22T23:44:09  *** Emcy_ has quit IRC
4632017-09-22T23:46:16  *** promag has quit IRC
4642017-09-22T23:46:33  *** promag has joined #bitcoin-core-dev
4652017-09-22T23:50:56  *** promag has quit IRC
4662017-09-22T23:51:03  *** Emcy_ has joined #bitcoin-core-dev
4672017-09-22T23:52:21  *** justanotheruser has joined #bitcoin-core-dev
4682017-09-22T23:52:48  *** Emcy has quit IRC