12017-09-26T00:00:43 *** Ylbam has quit IRC
22017-09-26T00:21:46 *** Miezel has quit IRC
32017-09-26T00:27:13 *** chjj has joined #bitcoin-core-dev
42017-09-26T00:58:03 *** dabura667 has joined #bitcoin-core-dev
52017-09-26T00:59:05 *** promag has joined #bitcoin-core-dev
62017-09-26T00:59:50 *** Miezel has joined #bitcoin-core-dev
72017-09-26T01:08:28 *** Alina-malina has quit IRC
82017-09-26T01:09:50 *** promag has quit IRC
92017-09-26T01:10:02 *** Miezel has quit IRC
102017-09-26T01:10:25 *** Alina-malina has joined #bitcoin-core-dev
112017-09-26T01:11:06 *** Miezel has joined #bitcoin-core-dev
122017-09-26T01:15:03 *** dynm_ has joined #bitcoin-core-dev
132017-09-26T01:18:06 *** [Author] has joined #bitcoin-core-dev
142017-09-26T01:20:27 *** promag has joined #bitcoin-core-dev
152017-09-26T01:37:34 *** promag has quit IRC
162017-09-26T01:49:56 <bitcoin-git> [bitcoin] sipa opened pull request #11403: SegWit wallet support (master...201709_segwitwallet2) https://github.com/bitcoin/bitcoin/pull/11403
172017-09-26T01:53:43 *** merehap has quit IRC
182017-09-26T01:53:55 *** merehap has joined #bitcoin-core-dev
192017-09-26T01:55:27 *** RubenSomsen has joined #bitcoin-core-dev
202017-09-26T01:55:31 <analiser> look like #10783 041dad9 RCP Various rpc argument fixes(instagiibbs) in the 0.15 channelog is what cause some errors in python bicoinlib module i just solve the issue removing from module bitcoin SelectParams() attribute and from bitcoin.rpc remove Proxy() attribute hope that work for any here
212017-09-26T01:55:33 <gribble> https://github.com/bitcoin/bitcoin/issues/10783 | [RPC] Various rpc argument fixes by instagibbs · Pull Request #10783 · bitcoin/bitcoin · GitHub
222017-09-26T02:00:08 *** merehap has quit IRC
232017-09-26T02:00:20 *** merehap has joined #bitcoin-core-dev
242017-09-26T02:01:46 *** merehap_ has joined #bitcoin-core-dev
252017-09-26T02:02:25 *** merehap has quit IRC
262017-09-26T02:21:29 *** Miezel has quit IRC
272017-09-26T02:46:34 *** Murch has joined #bitcoin-core-dev
282017-09-26T02:59:00 <bitcoin-git> [bitcoin] jtimon opened pull request #11404: RPC: Chainparams: Simplify -rpcport and CBaseMainParams (master...b16-chainparams-rpcport) https://github.com/bitcoin/bitcoin/pull/11404
292017-09-26T03:20:24 *** ensign has quit IRC
302017-09-26T03:24:13 *** ensign has joined #bitcoin-core-dev
312017-09-26T03:24:42 *** merehap_ has quit IRC
322017-09-26T03:24:52 *** merehap_ has joined #bitcoin-core-dev
332017-09-26T03:26:22 *** merehap_ has quit IRC
342017-09-26T03:26:32 *** merehap_ has joined #bitcoin-core-dev
352017-09-26T03:37:43 *** jcorgan has quit IRC
362017-09-26T03:40:05 *** RubenSomsen has quit IRC
372017-09-26T03:42:50 *** ula has quit IRC
382017-09-26T03:45:32 *** Murch has quit IRC
392017-09-26T03:46:07 *** tknp has joined #bitcoin-core-dev
402017-09-26T03:46:13 *** RubenSomsen has joined #bitcoin-core-dev
412017-09-26T03:53:53 *** dynm_ has quit IRC
422017-09-26T03:54:07 *** Ruben has joined #bitcoin-core-dev
432017-09-26T03:56:32 *** RubenSomsen has quit IRC
442017-09-26T03:58:35 *** Ruben has quit IRC
452017-09-26T04:00:08 *** PatBoy has quit IRC
462017-09-26T04:08:34 *** chartractegg has joined #bitcoin-core-dev
472017-09-26T04:15:41 *** instagibbs has quit IRC
482017-09-26T04:16:22 *** chartractegg has quit IRC
492017-09-26T04:24:25 *** instagibbs has joined #bitcoin-core-dev
502017-09-26T04:28:43 *** wittysense has quit IRC
512017-09-26T04:41:01 *** ThomasV has joined #bitcoin-core-dev
522017-09-26T04:41:46 *** justanotheruser has quit IRC
532017-09-26T04:50:00 *** ThomasV has quit IRC
542017-09-26T05:02:29 *** justanotheruser has joined #bitcoin-core-dev
552017-09-26T05:03:06 *** tripleslash has quit IRC
562017-09-26T05:12:58 *** AaronvanW has joined #bitcoin-core-dev
572017-09-26T05:19:28 *** chjj has quit IRC
582017-09-26T05:23:21 *** AaronvanW has quit IRC
592017-09-26T05:25:12 *** andytoshi has quit IRC
602017-09-26T05:25:46 *** andytoshi has joined #bitcoin-core-dev
612017-09-26T05:26:57 *** instagibbs has quit IRC
622017-09-26T05:29:00 *** instagibbs has joined #bitcoin-core-dev
632017-09-26T05:44:24 *** Murch has joined #bitcoin-core-dev
642017-09-26T05:53:50 *** tknp has quit IRC
652017-09-26T05:57:31 *** Alina-malina has quit IRC
662017-09-26T05:57:31 *** Alina-malina has joined #bitcoin-core-dev
672017-09-26T06:00:16 *** Murch has quit IRC
682017-09-26T06:03:38 *** Murch has joined #bitcoin-core-dev
692017-09-26T06:07:06 *** Murch has quit IRC
702017-09-26T06:11:16 *** meshcollider has quit IRC
712017-09-26T06:16:38 *** RubenSomsen has joined #bitcoin-core-dev
722017-09-26T06:24:12 *** arubi has quit IRC
732017-09-26T06:32:37 *** JackH has quit IRC
742017-09-26T06:41:50 *** arubi has joined #bitcoin-core-dev
752017-09-26T06:42:36 *** Deacyded has joined #bitcoin-core-dev
762017-09-26T06:46:15 *** Deacydal has quit IRC
772017-09-26T06:46:18 *** dermoth has joined #bitcoin-core-dev
782017-09-26T06:49:05 *** BashCo has quit IRC
792017-09-26T06:49:46 *** BashCo has joined #bitcoin-core-dev
802017-09-26T06:52:17 *** EVM has joined #bitcoin-core-dev
812017-09-26T06:52:25 <EVM> hi
822017-09-26T06:54:13 *** BashCo has quit IRC
832017-09-26T06:59:37 *** JackH has joined #bitcoin-core-dev
842017-09-26T07:01:45 *** meshcollider has joined #bitcoin-core-dev
852017-09-26T07:09:56 *** arubi has quit IRC
862017-09-26T07:10:22 *** arubi has joined #bitcoin-core-dev
872017-09-26T07:10:57 *** BashCo has joined #bitcoin-core-dev
882017-09-26T07:14:20 *** bigcheap has joined #bitcoin-core-dev
892017-09-26T07:22:05 *** arubi has quit IRC
902017-09-26T07:22:37 *** arubi has joined #bitcoin-core-dev
912017-09-26T07:34:33 *** circ-user-2HbxE has joined #bitcoin-core-dev
922017-09-26T07:38:17 *** promag has joined #bitcoin-core-dev
932017-09-26T07:41:16 *** promag has quit IRC
942017-09-26T07:46:13 *** promag has joined #bitcoin-core-dev
952017-09-26T07:50:34 *** promag has quit IRC
962017-09-26T07:58:05 *** timothy has joined #bitcoin-core-dev
972017-09-26T07:59:08 *** afk11 has quit IRC
982017-09-26T08:00:03 *** afk11 has joined #bitcoin-core-dev
992017-09-26T08:02:30 *** EVM has quit IRC
1002017-09-26T08:02:59 *** pbase has joined #bitcoin-core-dev
1012017-09-26T08:12:59 *** Victor_sueca has joined #bitcoin-core-dev
1022017-09-26T08:16:07 *** Victorsueca has quit IRC
1032017-09-26T08:16:17 *** promag has joined #bitcoin-core-dev
1042017-09-26T08:27:51 *** goatpig has quit IRC
1052017-09-26T08:55:32 *** ula has joined #bitcoin-core-dev
1062017-09-26T08:56:16 *** pbase has quit IRC
1072017-09-26T09:09:18 *** promag has quit IRC
1082017-09-26T09:31:05 *** Guyver2 has joined #bitcoin-core-dev
1092017-09-26T09:48:13 *** Miezel has joined #bitcoin-core-dev
1102017-09-26T09:51:00 *** bigcheap has quit IRC
1112017-09-26T10:01:32 *** dabura667 has quit IRC
1122017-09-26T10:28:16 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8cf88b4aaeaf...67879b7c4431
1132017-09-26T10:28:16 <bitcoin-git> bitcoin/master 28d4542 Matt Corallo: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds
1142017-09-26T10:28:17 <bitcoin-git> bitcoin/master 67879b7 Wladimir J. van der Laan: Merge #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds...
1152017-09-26T10:28:51 <bitcoin-git> [bitcoin] laanwj closed pull request #11377: Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds (master...2017-09-bitcoin-tx-uncompressed-segwit) https://github.com/bitcoin/bitcoin/pull/11377
1162017-09-26T10:29:10 *** circ-user-2HbxE has quit IRC
1172017-09-26T10:29:26 *** circ-user-2HbxE has joined #bitcoin-core-dev
1182017-09-26T11:08:23 *** circ-user-2HbxE has quit IRC
1192017-09-26T11:13:08 *** justanotheruser has quit IRC
1202017-09-26T11:42:28 *** promag has joined #bitcoin-core-dev
1212017-09-26T11:56:27 *** circ-user-2HbxE has joined #bitcoin-core-dev
1222017-09-26T12:08:09 *** PatBoy has joined #bitcoin-core-dev
1232017-09-26T12:09:54 *** PatBoy has joined #bitcoin-core-dev
1242017-09-26T12:25:13 *** Geoffy has joined #bitcoin-core-dev
1252017-09-26T12:29:24 *** circ-user-2HbxE has quit IRC
1262017-09-26T12:29:51 *** wittysense has joined #bitcoin-core-dev
1272017-09-26T12:36:34 *** SopaXorzTaker has joined #bitcoin-core-dev
1282017-09-26T12:39:44 *** promag has quit IRC
1292017-09-26T12:43:19 *** AaronvanW has joined #bitcoin-core-dev
1302017-09-26T12:47:35 *** LeMiner2 has joined #bitcoin-core-dev
1312017-09-26T12:49:36 *** LeMiner has quit IRC
1322017-09-26T12:49:36 *** LeMiner2 is now known as LeMiner
1332017-09-26T12:53:47 *** Victor_sueca is now known as Victorsueca
1342017-09-26T12:54:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1352017-09-26T13:00:53 *** justanotheruser has joined #bitcoin-core-dev
1362017-09-26T13:02:30 *** promag has joined #bitcoin-core-dev
1372017-09-26T13:04:37 *** AaronvanW has quit IRC
1382017-09-26T13:06:40 *** promag has quit IRC
1392017-09-26T13:08:54 *** justanotheruser has quit IRC
1402017-09-26T13:09:14 *** justanotheruser has joined #bitcoin-core-dev
1412017-09-26T13:12:33 *** promag has joined #bitcoin-core-dev
1422017-09-26T13:15:26 *** AaronvanW has joined #bitcoin-core-dev
1432017-09-26T13:28:52 *** Evel-Knievel has quit IRC
1442017-09-26T13:32:17 *** Chris_Stewart_5 has quit IRC
1452017-09-26T13:37:01 *** SopaXorzTaker has quit IRC
1462017-09-26T13:38:17 *** SopaXorzTaker has joined #bitcoin-core-dev
1472017-09-26T13:39:29 *** promag has quit IRC
1482017-09-26T13:46:31 *** promag has joined #bitcoin-core-dev
1492017-09-26T13:48:11 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1502017-09-26T13:50:15 *** SopaXorzTaker has quit IRC
1512017-09-26T13:50:43 *** promag has quit IRC
1522017-09-26T13:59:15 *** SopaXorzTaker has joined #bitcoin-core-dev
1532017-09-26T14:01:34 *** justanotheruser has quit IRC
1542017-09-26T14:06:02 *** AaronvanW has quit IRC
1552017-09-26T14:11:16 *** meshcollider has quit IRC
1562017-09-26T14:12:02 *** d9b4bef9 has quit IRC
1572017-09-26T14:15:07 *** d9b4bef9 has joined #bitcoin-core-dev
1582017-09-26T14:15:08 *** dermoth has quit IRC
1592017-09-26T14:17:19 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/67879b7c4431...0f8e09599db6
1602017-09-26T14:17:19 <bitcoin-git> bitcoin/master df10edf MeshCollider: More user-friendly error message when partially signing
1612017-09-26T14:17:20 <bitcoin-git> bitcoin/master 0f8e095 Wladimir J. van der Laan: Merge #11288: More user-friendly error message when partially signing...
1622017-09-26T14:17:23 *** dermoth has joined #bitcoin-core-dev
1632017-09-26T14:18:15 <bitcoin-git> [bitcoin] laanwj closed pull request #11288: More user-friendly error message when partially signing (master...201709_partial_sign_error) https://github.com/bitcoin/bitcoin/pull/11288
1642017-09-26T14:21:04 *** victorSN has joined #bitcoin-core-dev
1652017-09-26T14:21:10 *** promag has joined #bitcoin-core-dev
1662017-09-26T14:24:54 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f8e09599db6...dc597bb895ef
1672017-09-26T14:24:54 <bitcoin-git> bitcoin/master d01a968 Suhas Daftuar: wallet: update stored witness in AddToWallet...
1682017-09-26T14:24:55 <bitcoin-git> bitcoin/master dc597bb Wladimir J. van der Laan: Merge #11225: wallet: update stored witness in AddToWallet...
1692017-09-26T14:25:34 <bitcoin-git> [bitcoin] laanwj closed pull request #11225: wallet: update stored witness in AddToWallet (master...2017-09-update-tx-witness) https://github.com/bitcoin/bitcoin/pull/11225
1702017-09-26T14:32:58 *** promag has quit IRC
1712017-09-26T14:34:42 *** Chris_Stewart_5 has quit IRC
1722017-09-26T14:38:01 *** AaronvanW has joined #bitcoin-core-dev
1732017-09-26T14:49:15 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1742017-09-26T14:51:00 *** AaronvanW has quit IRC
1752017-09-26T14:56:10 *** RubenSomsen has quit IRC
1762017-09-26T15:16:33 *** AaronvanW has joined #bitcoin-core-dev
1772017-09-26T15:43:15 *** Miezel has quit IRC
1782017-09-26T15:44:41 *** Miezel has joined #bitcoin-core-dev
1792017-09-26T15:52:37 *** promag has joined #bitcoin-core-dev
1802017-09-26T15:54:22 *** BashCo has quit IRC
1812017-09-26T15:57:06 *** promag has quit IRC
1822017-09-26T15:57:54 *** RubenSomsen has joined #bitcoin-core-dev
1832017-09-26T15:58:37 *** promag has joined #bitcoin-core-dev
1842017-09-26T16:03:58 <promag> jnewbery: https://github.com/bitcoin/bitcoin/pull/11031/commits/a6919d9a6908efaf0c913cccda21d63ed1517b3c s/enablerpcmethod/deprecatedrpc
1852017-09-26T16:05:39 *** promag has quit IRC
1862017-09-26T16:06:05 *** benma has joined #bitcoin-core-dev
1872017-09-26T16:09:41 *** Miezel has quit IRC
1882017-09-26T16:11:22 *** Miezel has joined #bitcoin-core-dev
1892017-09-26T16:19:57 *** BashCo has joined #bitcoin-core-dev
1902017-09-26T16:27:26 <jnewbery> promag: thanks, fixed
1912017-09-26T16:43:42 *** Ylbam has joined #bitcoin-core-dev
1922017-09-26T16:52:12 <maaku> I'm considering removing the 200 non-push opcode limit and SIGOP counting for my tail-call proposal. I would be interested in feedback as to why this would be a terrible idea.
1932017-09-26T16:54:18 *** AaronvanW has quit IRC
1942017-09-26T16:58:58 *** AaronvanW has joined #bitcoin-core-dev
1952017-09-26T17:02:17 *** AaronvanW has quit IRC
1962017-09-26T17:05:25 *** AaronvanW has joined #bitcoin-core-dev
1972017-09-26T17:05:58 *** victorSN has quit IRC
1982017-09-26T17:06:05 *** Aaronvan_ has joined #bitcoin-core-dev
1992017-09-26T17:10:11 *** AaronvanW has quit IRC
2002017-09-26T17:11:33 *** Aaronvan_ has quit IRC
2012017-09-26T17:28:28 *** jtimon has joined #bitcoin-core-dev
2022017-09-26T17:28:58 *** goatpig has joined #bitcoin-core-dev
2032017-09-26T17:30:12 *** benma has quit IRC
2042017-09-26T17:30:51 *** Chris_Stewart_5 has quit IRC
2052017-09-26T17:33:35 *** AaronvanW has joined #bitcoin-core-dev
2062017-09-26T17:36:26 <bitcoin-git> [bitcoin] jtimon closed pull request #11404: RPC: Chainparams: Simplify -rpcport and CBaseMainParams (master...b16-chainparams-rpcport) https://github.com/bitcoin/bitcoin/pull/11404
2072017-09-26T17:36:45 *** Murch has joined #bitcoin-core-dev
2082017-09-26T17:43:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2092017-09-26T17:44:21 *** PaulCapestany has quit IRC
2102017-09-26T17:49:47 *** PaulCapestany has joined #bitcoin-core-dev
2112017-09-26T17:51:49 <instagibbs> what interval if any does travis run extended functional tests?
2122017-09-26T17:53:46 *** AaronvanW has quit IRC
2132017-09-26T17:57:49 *** AaronvanW has joined #bitcoin-core-dev
2142017-09-26T18:11:44 *** analiser has quit IRC
2152017-09-26T18:18:19 *** Squidicuz has quit IRC
2162017-09-26T18:22:35 *** victorSN has joined #bitcoin-core-dev
2172017-09-26T18:24:04 *** victorSN has quit IRC
2182017-09-26T18:31:28 *** Chris_Stewart_5 has quit IRC
2192017-09-26T18:32:01 <jtimon> sipa: what's the reasoning for the bias for nodes using the default port? that seems weird
2202017-09-26T18:33:03 <sipa> jtimon: otherwise you can spam the network with addr messages for services you don't like, and get the whole bitcoin network to try connecting to them
2212017-09-26T18:33:39 <jtimon> how is that affected by the port, I don't follow...
2222017-09-26T18:33:55 <sipa> with the bias, that can pretty much only happen for P2P default port, which is very unlikely to have any interesting services running, other than bitcoin :)
2232017-09-26T18:34:29 <jtimon> oh, I see
2242017-09-26T18:34:44 <jtimon> I think I get it...
2252017-09-26T18:34:47 *** victorSN has joined #bitcoin-core-dev
2262017-09-26T18:35:19 <jtimon> in any case, as said seems unrelated to #11404
2272017-09-26T18:35:30 <gribble> https://github.com/bitcoin/bitcoin/issues/11404 | RPC: Chainparams: Simplify -rpcport and CBaseMainParams by jtimon · Pull Request #11404 · bitcoin/bitcoin · GitHub
2282017-09-26T18:35:49 <sipa> well you're giving all networks the same default port
2292017-09-26T18:36:04 <sipa> meaning that if you want to run more than one network on the same machine, one of them will need a non-default port
2302017-09-26T18:36:42 <jtimon> the same defaul rpc port
2312017-09-26T18:36:55 <esotericnonsense> yes, it's the rpc port only in the PR, was a bit confused by your comment sipa
2322017-09-26T18:37:02 <sipa> oh!
2332017-09-26T18:37:08 <sipa> this is about the RPC port
2342017-09-26T18:37:11 <esotericnonsense> i still dislike the behaviour of having to specify a different rpcport for testnet/regtest though
2352017-09-26T18:37:22 <esotericnonsense> though that's just a quality-of-life annoyance
2362017-09-26T18:37:31 <sipa> yes, agree - though that's much less bad than having the same P2P port
2372017-09-26T18:37:54 <sipa> sorry, i misunderstood!
2382017-09-26T18:38:47 <esotericnonsense> while we're on the subject is there any preference for connecting to nodes with a different IP (perhaps based on this standard port bias)? e.g. if I run 50000 nodes from one IP and spam addr messages
2392017-09-26T18:38:57 <gmaxwell> it just makes them unusable by default, I cannot fathom why we would do that.
2402017-09-26T18:39:53 <sipa> esotericnonsense: we never make more than 1 outgoing connection to the same 'network group' (whose definition is dependent on the network, but for IPv4 it's a /16 i think)
2412017-09-26T18:40:02 <esotericnonsense> aha.
2422017-09-26T18:40:41 <sipa> and without -addnode we'll never connect to an unroutable address (so not to 192.168.x, not 127.0.0.1, not 10.x, etc)
2432017-09-26T18:41:15 <sipa> i think we should at some point have local network discovery and try to connect within your own network, but not using the same external connection slots)
2442017-09-26T18:42:30 <gmaxwell> sipa: I started working on that and didn't have a good way to eliminate the duplicate connections.
2452017-09-26T18:42:43 <gmaxwell> E.g. hosts A and B on the local network, both connect to each other.
2462017-09-26T18:43:53 <gmaxwell> I thought perhaps just a stupid hurestic, "if you listen, connect only to lower sort-order addresses than yours".
2472017-09-26T18:44:43 <sipa> or just test for duplicate IP pairs? within a local network you can probably assume that both parties will see each other's by their actual IP (not NAT etc0
2482017-09-26T18:45:19 <sipa> so don't connect out to any IP you're seeing an incoming connection from
2492017-09-26T18:46:29 <gmaxwell> Good point. What about the race when two connect at the same time
2502017-09-26T18:46:44 <jtimon> esotericnonsense: for bitcoin-cli, specifying -testnet does the same as -rpcport=18332, if you specify rpcport, specifying -testnet is completely meaningless
2512017-09-26T18:47:03 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2522017-09-26T18:47:05 *** AaronvanW has quit IRC
2532017-09-26T18:47:38 <jtimon> gmaxwell: what is made unusable by default? I don't follow
2542017-09-26T18:48:16 <sipa> gmaxwell: if you have a duplicate pair among actual connections, and your IP is the lexicographically lower of the two, disconnect?
2552017-09-26T18:48:54 <Sentineo> gmaxwell: sipa it sounds like split horizont in routing protocols what discuss ...
2562017-09-26T18:49:07 <Sentineo> what you discuss
2572017-09-26T18:49:29 <gmaxwell> jtimon: Making everything use the same rpc port means you cannot run testnet and bitcoin at the same time anymore except through manually configuring them.
2582017-09-26T18:50:29 <Sentineo> btw sipa why is a node keeping 8 connetions outside ? I have a node with 123 connection, 8 of them always go outside. I would assume my node should prefer inbound connections.
2592017-09-26T18:50:48 <jtimon> oh, that. yeah. if you want to use both in the same machine you have to specify a different rpc port in one of the,
2602017-09-26T18:50:58 <jtimon> them
2612017-09-26T18:51:09 <sipa> Sentineo: we always make 8 outgoing connections - regardless of how many incoming connections you have
2622017-09-26T18:51:14 *** AaronvanW has joined #bitcoin-core-dev
2632017-09-26T18:51:29 <sipa> outgoing connections are far more sybil resistant, as their endpoints are under your own control
2642017-09-26T18:52:00 <jtimon> I don't think that unusable, but ok
2652017-09-26T18:52:02 <gmaxwell> Sentineo: "prefer inbound" ?!?! ... the inbound could all be a single badguy. We consider inbounds irrelevant for security because of that.
2662017-09-26T18:52:54 <Sentineo> yeah, did not thing of that. Was lookng at it the "i serve the network" point of view, which is stupid from security standpoing ...
2672017-09-26T18:57:01 *** AaronvanW has quit IRC
2682017-09-26T18:57:15 *** cdecker has quit IRC
2692017-09-26T19:00:28 *** AaronvanW has joined #bitcoin-core-dev
2702017-09-26T19:03:29 *** harrymm has quit IRC
2712017-09-26T19:08:46 *** Chris_Stewart_5 has quit IRC
2722017-09-26T19:10:05 <maaku> sipa: Bonjour/Zeroconf would make initial sync of new devices without blowing data caps much more idiot proof
2732017-09-26T19:11:49 <maaku> it would also make sense to combine that with preferring making block requests to local peers during IBD
2742017-09-26T19:12:48 *** RubenSomsen has quit IRC
2752017-09-26T19:13:27 <sipa> the IBD sync will already prefer faster peers, and will disconnect peers that prevent it from going faster - so i hope no special logic for that is needed
2762017-09-26T19:14:22 <sipa> i haven't looked at any of those local connection services
2772017-09-26T19:16:38 <gmaxwell> they are awful zeroday magnets.
2782017-09-26T19:16:44 <gmaxwell> of course.
2792017-09-26T19:16:52 *** harrymm has joined #bitcoin-core-dev
2802017-09-26T19:17:44 <maaku> sipa: the disconnect actually sounds somewhat dangerous. could I used fast connectivity and network attacks to partition someone off during IBD?
2812017-09-26T19:18:51 <sipa> maaku: there is certainly an increased attack vector, but you'd at least need to combine it with other strategies to control the new connections being made (eclipse attacks etc)
2822017-09-26T19:19:09 <sipa> maaku: in general i do think that partitioning during IBD is less of an issue - you know you're not caught up
2832017-09-26T19:23:27 <TD-Linux> bonjour is a pretty sensible protocol for that
2842017-09-26T19:23:40 <gmaxwell> you're still making progress and you already have your headers. There is an argument, however, that 'after' IBD we should dump most of our outbound peers.
2852017-09-26T19:24:29 <gmaxwell> but that is complicated by there not being a clear 'after'.
2862017-09-26T19:27:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2872017-09-26T19:36:45 <maaku> right
2882017-09-26T19:38:38 *** Cheeseo has joined #bitcoin-core-dev
2892017-09-26T19:40:17 *** timothy has quit IRC
2902017-09-26T19:44:33 <gmaxwell> TD-Linux: things like bonjour don't help doing things like having connections inside amazon regions for hosts on aws, which have radically less expensive bandwidth than bandwidth to the internet.
2912017-09-26T19:46:38 *** promag has joined #bitcoin-core-dev
2922017-09-26T19:50:35 *** promag has quit IRC
2932017-09-26T19:51:21 *** Chris_Stewart_5 has quit IRC
2942017-09-26T19:53:57 *** cheese_ has joined #bitcoin-core-dev
2952017-09-26T19:57:12 *** Cheeseo has quit IRC
2962017-09-26T19:59:45 *** Miezel has quit IRC
2972017-09-26T20:00:12 *** promag has joined #bitcoin-core-dev
2982017-09-26T20:01:00 *** AaronvanW has quit IRC
2992017-09-26T20:01:14 *** promag has quit IRC
3002017-09-26T20:02:26 *** chjj has joined #bitcoin-core-dev
3012017-09-26T20:04:29 <TD-Linux> gmaxwell, nope. I guess you could ship lists of these
3022017-09-26T20:04:48 *** AaronvanW has joined #bitcoin-core-dev
3032017-09-26T20:11:35 *** promag has joined #bitcoin-core-dev
3042017-09-26T20:14:14 *** AaronvanW has quit IRC
3052017-09-26T20:17:18 *** promag has quit IRC
3062017-09-26T20:25:59 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11406: Add state message print to AcceptBlock failure message. (master...2017-09-checkblock-fail-print) https://github.com/bitcoin/bitcoin/pull/11406
3072017-09-26T20:29:22 *** meshcollider has joined #bitcoin-core-dev
3082017-09-26T20:34:45 <jtimon> does anybody use -mempoolreplacement=0 ? would it make sense to do https://github.com/ElementsProject/elements/pull/248 in bitcoin ?
3092017-09-26T20:36:15 *** promag has joined #bitcoin-core-dev
3102017-09-26T20:44:40 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3112017-09-26T20:45:22 <luke-jr> jtimon: yes, people use it, and removing it would likely make a ruckus. There's also zero harm in leaving it.
3122017-09-26T20:45:53 <jtimon> yeah, if people use it, no point in removing it
3132017-09-26T20:47:45 *** Alina-malina has quit IRC
3142017-09-26T20:48:56 *** promag has quit IRC
3152017-09-26T20:49:51 *** Alina-malina has joined #bitcoin-core-dev
3162017-09-26T20:54:20 *** promag has joined #bitcoin-core-dev
3172017-09-26T20:56:18 <promag> achow101: in https://github.com/bitcoin/bitcoin/pull/10583/commits/8d5d4cf4c3077e8f3269fab3b98da7413e100081 commit message there is a double space. Also, Validateaddress should always be lowercase?
3182017-09-26T20:59:50 <promag> jnewbery: so -deprecatedrpc can be used to enable some deprecated params? I thought is to enable the full (deprecated) rpc
3192017-09-26T21:05:05 *** Cory has quit IRC
3202017-09-26T21:07:59 <achow101> promag: who cares
3212017-09-26T21:08:27 <achow101> promag: super nitty things like that don't really matter and are not particularly conducive to development
3222017-09-26T21:10:47 *** Pasha has joined #bitcoin-core-dev
3232017-09-26T21:11:28 <promag> that's ok, I was reading your code and figured you want to know about that if by any change you happen to fix something else
3242017-09-26T21:11:37 <promag> *chance
3252017-09-26T21:13:58 *** Pasha is now known as Cory
3262017-09-26T21:14:11 <promag> talking about nitty things https://github.com/bitcoin/bitcoin/pull/11395#issuecomment-332308834
3272017-09-26T21:15:27 <promag> luke-jr: if you run clang-format as per developer notes you will see those details
3282017-09-26T21:16:12 *** BashCo has quit IRC
3292017-09-26T21:17:12 *** Alina-malina has quit IRC
3302017-09-26T21:18:48 <promag> if there is such guide, which took some community effort to write why not follow it? I would say top core developers should be the first to comply? It's not that it takes a lot of time doing so.
3312017-09-26T21:20:20 *** Alina-malina has joined #bitcoin-core-dev
3322017-09-26T21:20:44 *** BashCo has joined #bitcoin-core-dev
3332017-09-26T21:24:57 *** RoyceX has joined #bitcoin-core-dev
3342017-09-26T21:25:13 <bitcoin-git> [bitcoin] instagibbs opened pull request #11407: add functional test for mempoolreplacement command line arg (master...testmempoolreplacearg) https://github.com/bitcoin/bitcoin/pull/11407
3352017-09-26T21:27:52 *** cheese_ has quit IRC
3362017-09-26T21:34:31 *** Squidicuz has joined #bitcoin-core-dev
3372017-09-26T21:34:57 *** Chris_Stewart_5 has quit IRC
3382017-09-26T21:36:19 *** Guyver2 has quit IRC
3392017-09-26T21:37:43 <sipa> promag: there is balance between costs and benefits of enforcing style
3402017-09-26T21:38:06 <sipa> it adds overhead to both people who write patches and those who reviee
3412017-09-26T21:41:48 *** Cory has quit IRC
3422017-09-26T21:42:46 *** belcher has quit IRC
3432017-09-26T21:44:52 *** belcher has joined #bitcoin-core-dev
3442017-09-26T21:46:12 *** abpa has joined #bitcoin-core-dev
3452017-09-26T21:48:44 *** Cory has joined #bitcoin-core-dev
3462017-09-26T21:51:20 <jnewbery> promag: I personally think it's fine to use -deprecatedrpc to signal that you want to receive an RPC return object in the old format
3472017-09-26T21:55:13 <promag> sipa: the problem is to find the sweet spot for everyone. Running clang-format-diff.py is not that big overhead is it? Anyway, I'll stop nitpicking.
3482017-09-26T21:55:55 <promag> jnewbery: I guess so, and should tests all deprecated keys or one is enough?
3492017-09-26T21:59:35 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc597bb895ef...2505c5c0a9f8
3502017-09-26T21:59:35 <bitcoin-git> bitcoin/master 7b137ac Lucas Betschart: [Qt] Add delay before filtering transactions...
3512017-09-26T21:59:36 <bitcoin-git> bitcoin/master 2505c5c Jonas Schnelli: Merge #11015: [Qt] Add delay before filtering transactions...
3522017-09-26T22:00:06 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11015: [Qt] Add delay before filtering transactions (master...searchDelay) https://github.com/bitcoin/bitcoin/pull/11015
3532017-09-26T22:01:50 <sipa> promag: i'm personally in favor of more strict style conventions, and would very much like the project to force one style... but that's just not feasible. nitpicking everything kills people's motivation to work
3542017-09-26T22:06:11 <CryptAxe> Is it possible for nodes that don't understand the extended transaction serialization format for segwit to still validate blocks with those transactions inside of them?
3552017-09-26T22:06:57 <goatpig> they cant check the scriptsigs
3562017-09-26T22:07:14 <goatpig> but otherwise pre SW nodes can verify SW transactions
3572017-09-26T22:08:12 <sipa> CryptAxe: sure, they just won't see the witnesses
3582017-09-26T22:08:25 <sipa> (as peers will strip the witness before relaying to a non-segwit peer)
3592017-09-26T22:08:57 <bitcoin-git> [bitcoin] PierreRochard opened pull request #11408: Trivial: Fix parameter name typo in ErasePurpose walletdb method (master...walletdb-typo) https://github.com/bitcoin/bitcoin/pull/11408
3602017-09-26T22:09:31 *** promag has quit IRC
3612017-09-26T22:09:31 <CryptAxe> So they can still deserialize the transaction? Cool, I think this part: https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L204-L212 made me think that they would have an empty vin and it would be invalid
3622017-09-26T22:09:40 *** maaku has left #bitcoin-core-dev
3632017-09-26T22:10:01 <CryptAxe> Ahhh so the transactions are relayed in a different format to old nodes
3642017-09-26T22:10:06 <CryptAxe> I didn't see that part
3652017-09-26T22:10:10 <sipa> CryptAxe: if they see the witness, the serialization will very deliberately fail
3662017-09-26T22:10:42 <sipa> CryptAxe: the reason segwit is a softfork is the fact that it is possible to strip out the witness without invalidating the transaction (from the perspective of old nodes)
3672017-09-26T22:11:07 <CryptAxe> goatpig and sipa thank you, I have more reading to do now :)
3682017-09-26T22:11:29 <sipa> it's probably better to think of the witness as not actually part of the transaction - it's just some auxilliary data - which _only for relay_ is relayed in a weird interspersed way inside the normal tx data
3692017-09-26T22:12:06 <CryptAxe> sipa so the stripped format has some kind of dummy vin or something?
3702017-09-26T22:12:10 <sipa> no
3712017-09-26T22:12:14 *** promag has joined #bitcoin-core-dev
3722017-09-26T22:12:21 *** cheese_ has joined #bitcoin-core-dev
3732017-09-26T22:12:22 <sipa> the stripped format is just the old transaction format
3742017-09-26T22:12:33 <sipa> it has inputs and outputs, and no witnesses
3752017-09-26T22:12:43 <sipa> ah, i see what you mean
3762017-09-26T22:12:49 <sipa> yes, the scriptSigs are empty
3772017-09-26T22:12:58 <sipa> but the rest of the inputs is intact
3782017-09-26T22:13:03 <CryptAxe> Thank you, a bit confused about all that
3792017-09-26T22:13:35 *** promag has quit IRC
3802017-09-26T22:15:32 *** RoyceX has quit IRC
3812017-09-26T22:17:22 <CryptAxe> sipa without the scriptSigs why aren't the transactions invalid to the older nodes?
3822017-09-26T22:17:42 <sipa> CryptAxe: because their scriptPubKeys don't require a scriptSig
3832017-09-26T22:17:49 <CryptAxe> Ah!
3842017-09-26T22:17:58 <sipa> (they have the form OP_0 <20-byte hash>)
3852017-09-26T22:18:05 <CryptAxe> genius
3862017-09-26T22:18:57 <sipa> if segwit is used in P2SH-wrapped form, the scriptPubKey is a P2SH output with Hash(OP_0 <20-byte hash>), and the scriptSig contains _only_ the redeemscript (which is equal to the actual OP_0 <20 byte hash>)
3872017-09-26T22:19:07 *** Miezel has joined #bitcoin-core-dev
3882017-09-26T22:21:24 <CryptAxe> Cool, thanks again guys!
3892017-09-26T22:25:46 *** wittysense has quit IRC
3902017-09-26T22:30:23 *** belcher has quit IRC
3912017-09-26T22:36:05 *** Alina-malina has quit IRC
3922017-09-26T22:38:25 *** Alina-malina has joined #bitcoin-core-dev
3932017-09-26T22:53:41 *** Alina-malina has quit IRC
3942017-09-26T22:57:30 *** Alina-malina has joined #bitcoin-core-dev
3952017-09-26T23:04:35 *** abpa has quit IRC
3962017-09-26T23:05:26 *** promag has joined #bitcoin-core-dev
3972017-09-26T23:18:42 *** promag has quit IRC
3982017-09-26T23:19:28 *** laurentmt has joined #bitcoin-core-dev
3992017-09-26T23:20:17 *** belcher has joined #bitcoin-core-dev
4002017-09-26T23:25:05 *** vicenteH has quit IRC
4012017-09-26T23:29:01 *** Alina-malina has quit IRC
4022017-09-26T23:30:58 *** Alina-malina has joined #bitcoin-core-dev
4032017-09-26T23:39:40 *** circ-user-2HbxE has joined #bitcoin-core-dev
4042017-09-26T23:43:22 *** circ-user-2HbxE has quit IRC
4052017-09-26T23:57:20 *** laurentmt1 has joined #bitcoin-core-dev
4062017-09-26T23:59:28 *** laurentmt has quit IRC
4072017-09-26T23:59:28 *** laurentmt1 is now known as laurentmt