12017-10-17T00:14:28  *** jb55 has quit IRC
  22017-10-17T00:15:19  *** vicenteH has quit IRC
  32017-10-17T00:15:27  *** vicenteH has joined #bitcoin-core-dev
  42017-10-17T00:33:53  *** Ylbam has quit IRC
  52017-10-17T00:36:11  *** [Author] has quit IRC
  62017-10-17T00:38:56  *** [Author] has joined #bitcoin-core-dev
  72017-10-17T00:42:09  *** wumpus has quit IRC
  82017-10-17T00:47:58  *** rafalcpp_ has joined #bitcoin-core-dev
  92017-10-17T00:48:11  *** [Author] has quit IRC
 102017-10-17T00:48:26  *** rafalcpp has quit IRC
 112017-10-17T00:51:00  *** [Author] has joined #bitcoin-core-dev
 122017-10-17T00:53:23  *** jb55 has joined #bitcoin-core-dev
 132017-10-17T00:55:53  *** kiswe has joined #bitcoin-core-dev
 142017-10-17T00:55:54  *** kiswe has left #bitcoin-core-dev
 152017-10-17T00:56:43  *** wumpus has joined #bitcoin-core-dev
 162017-10-17T00:56:50  *** promag has quit IRC
 172017-10-17T00:57:50  *** dabura667 has joined #bitcoin-core-dev
 182017-10-17T01:02:41  *** AaronvanW has quit IRC
 192017-10-17T01:03:35  *** jb55 has quit IRC
 202017-10-17T01:04:48  *** rafalcpp_ has quit IRC
 212017-10-17T01:05:32  *** rafalcpp_ has joined #bitcoin-core-dev
 222017-10-17T01:09:15  *** jb55 has joined #bitcoin-core-dev
 232017-10-17T01:12:59  *** [Author] has quit IRC
 242017-10-17T01:13:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 252017-10-17T01:18:08  *** [Author] has joined #bitcoin-core-dev
 262017-10-17T01:19:07  *** Chris_Stewart_5 has quit IRC
 272017-10-17T01:24:55  *** btcdrak has joined #bitcoin-core-dev
 282017-10-17T01:26:37  *** BashCo_ has joined #bitcoin-core-dev
 292017-10-17T01:26:57  *** BashCo has quit IRC
 302017-10-17T01:27:24  *** [Author] has quit IRC
 312017-10-17T01:29:32  *** [Author] has joined #bitcoin-core-dev
 322017-10-17T01:42:35  *** dabura667 has quit IRC
 332017-10-17T01:49:54  *** deikiyoch has joined #bitcoin-core-dev
 342017-10-17T01:49:55  *** deikiyoch has left #bitcoin-core-dev
 352017-10-17T01:53:08  *** dabura667 has joined #bitcoin-core-dev
 362017-10-17T02:01:07  *** dabura667 has quit IRC
 372017-10-17T02:05:18  *** rafalcpp_ has quit IRC
 382017-10-17T02:06:03  *** rafalcpp_ has joined #bitcoin-core-dev
 392017-10-17T02:07:48  <bitcoin-git> [bitcoin] jnewbery opened pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
 402017-10-17T02:09:03  *** JackH has quit IRC
 412017-10-17T02:18:01  *** wxss has quit IRC
 422017-10-17T02:22:53  *** dabura667 has joined #bitcoin-core-dev
 432017-10-17T02:25:32  *** owowo has quit IRC
 442017-10-17T02:30:02  *** owowo has joined #bitcoin-core-dev
 452017-10-17T02:30:03  *** owowo has joined #bitcoin-core-dev
 462017-10-17T02:53:32  *** jb55 has quit IRC
 472017-10-17T03:08:39  *** rafalcpp_ has quit IRC
 482017-10-17T03:09:24  *** rafalcpp_ has joined #bitcoin-core-dev
 492017-10-17T03:14:20  *** eck has quit IRC
 502017-10-17T03:14:58  *** eck has joined #bitcoin-core-dev
 512017-10-17T03:17:06  *** dabura667 has quit IRC
 522017-10-17T03:25:26  *** jb55 has joined #bitcoin-core-dev
 532017-10-17T03:26:36  *** [Author] has quit IRC
 542017-10-17T03:53:19  *** [Author] has joined #bitcoin-core-dev
 552017-10-17T03:56:24  *** rafalcpp__ has joined #bitcoin-core-dev
 562017-10-17T03:56:32  *** rafalcpp_ has quit IRC
 572017-10-17T03:58:36  *** [Author] has quit IRC
 582017-10-17T04:02:39  *** rafalcpp__ has quit IRC
 592017-10-17T04:03:29  *** [Author] has joined #bitcoin-core-dev
 602017-10-17T04:03:56  *** rafalcpp__ has joined #bitcoin-core-dev
 612017-10-17T04:05:51  *** Apocalyptic has quit IRC
 622017-10-17T04:08:10  *** Apocalyptic has joined #bitcoin-core-dev
 632017-10-17T04:20:27  *** jb55 has quit IRC
 642017-10-17T04:26:21  *** rafalcpp__ has quit IRC
 652017-10-17T04:27:06  *** rafalcpp__ has joined #bitcoin-core-dev
 662017-10-17T04:47:29  *** rafalcpp__ has quit IRC
 672017-10-17T04:49:30  *** rafalcpp has joined #bitcoin-core-dev
 682017-10-17T04:58:46  *** shesek has joined #bitcoin-core-dev
 692017-10-17T05:07:45  *** harrymm_ has quit IRC
 702017-10-17T05:21:16  *** harrymm_ has joined #bitcoin-core-dev
 712017-10-17T05:23:58  *** Ylbam has joined #bitcoin-core-dev
 722017-10-17T05:24:34  *** rafalcpp has quit IRC
 732017-10-17T05:25:20  *** rafalcpp has joined #bitcoin-core-dev
 742017-10-17T05:33:44  *** rafalcpp has quit IRC
 752017-10-17T05:34:28  *** rafalcpp has joined #bitcoin-core-dev
 762017-10-17T05:49:07  *** Emcy has quit IRC
 772017-10-17T06:11:23  *** dermoth has quit IRC
 782017-10-17T06:11:45  *** dermoth has joined #bitcoin-core-dev
 792017-10-17T06:14:35  *** Emcy has joined #bitcoin-core-dev
 802017-10-17T06:54:09  *** BashCo_ has quit IRC
 812017-10-17T07:05:02  *** alreadylate has joined #bitcoin-core-dev
 822017-10-17T07:14:21  *** dgenr8 has quit IRC
 832017-10-17T07:15:22  *** dgenr8 has joined #bitcoin-core-dev
 842017-10-17T07:16:23  *** BashCo has joined #bitcoin-core-dev
 852017-10-17T07:18:55  *** harrymm_ has quit IRC
 862017-10-17T07:20:01  *** dgenr8 has quit IRC
 872017-10-17T07:20:21  *** alreadylate has quit IRC
 882017-10-17T07:20:23  *** dabura667 has joined #bitcoin-core-dev
 892017-10-17T07:20:27  *** dgenr8 has joined #bitcoin-core-dev
 902017-10-17T07:21:18  *** alreadylate has joined #bitcoin-core-dev
 912017-10-17T07:24:22  *** AaronvanW has joined #bitcoin-core-dev
 922017-10-17T07:25:18  *** dermoth has quit IRC
 932017-10-17T07:25:44  *** dermoth has joined #bitcoin-core-dev
 942017-10-17T07:28:18  *** Emcy has quit IRC
 952017-10-17T07:28:21  *** laurentmt has joined #bitcoin-core-dev
 962017-10-17T07:29:03  *** Aaronvan_ has joined #bitcoin-core-dev
 972017-10-17T07:32:07  *** harrymm_ has joined #bitcoin-core-dev
 982017-10-17T07:32:42  *** AaronvanW has quit IRC
 992017-10-17T07:36:20  *** Guyver2 has joined #bitcoin-core-dev
1002017-10-17T07:42:27  *** AaronvanW has joined #bitcoin-core-dev
1012017-10-17T07:44:12  *** goatpig has joined #bitcoin-core-dev
1022017-10-17T07:44:46  *** Aaronvan_ has quit IRC
1032017-10-17T07:47:08  *** sybarite has joined #bitcoin-core-dev
1042017-10-17T07:52:08  *** ula has quit IRC
1052017-10-17T07:54:37  *** [Author] has quit IRC
1062017-10-17T08:03:37  *** Aaronvan_ has joined #bitcoin-core-dev
1072017-10-17T08:03:39  *** btcdrak has quit IRC
1082017-10-17T08:05:41  *** AaronvanW has quit IRC
1092017-10-17T08:09:30  *** Emcy has joined #bitcoin-core-dev
1102017-10-17T08:09:49  *** intcat has quit IRC
1112017-10-17T08:25:42  *** intcat has joined #bitcoin-core-dev
1122017-10-17T08:29:04  *** promag has joined #bitcoin-core-dev
1132017-10-17T08:32:46  *** promag has quit IRC
1142017-10-17T08:34:47  *** timothy has joined #bitcoin-core-dev
1152017-10-17T08:38:26  *** [Author] has joined #bitcoin-core-dev
1162017-10-17T08:38:35  *** Deckard has joined #bitcoin-core-dev
1172017-10-17T08:39:54  *** Deckard has left #bitcoin-core-dev
1182017-10-17T08:41:59  *** shesek has quit IRC
1192017-10-17T08:45:57  *** TheLive1 has left #bitcoin-core-dev
1202017-10-17T08:55:00  *** Ylbam has quit IRC
1212017-10-17T08:55:44  *** alreadylate has quit IRC
1222017-10-17T09:39:48  *** alreadylate has joined #bitcoin-core-dev
1232017-10-17T09:40:57  *** alreadylate has quit IRC
1242017-10-17T09:41:59  *** alreadylate has joined #bitcoin-core-dev
1252017-10-17T09:44:47  *** oakley91 has quit IRC
1262017-10-17T09:57:50  *** Emcy has quit IRC
1272017-10-17T09:58:36  *** Emcy has joined #bitcoin-core-dev
1282017-10-17T10:20:11  *** Guyver2 has quit IRC
1292017-10-17T10:25:57  *** musalbas has quit IRC
1302017-10-17T10:27:07  *** dabura667 has quit IRC
1312017-10-17T10:35:06  *** jb55 has joined #bitcoin-core-dev
1322017-10-17T10:45:22  *** jtimon has joined #bitcoin-core-dev
1332017-10-17T10:50:41  *** jtimon has quit IRC
1342017-10-17T11:02:41  *** AaronvanW has joined #bitcoin-core-dev
1352017-10-17T11:05:02  *** jtimon has joined #bitcoin-core-dev
1362017-10-17T11:06:13  *** Aaronvan_ has quit IRC
1372017-10-17T11:10:59  *** Emcy has quit IRC
1382017-10-17T11:11:15  *** Emcy has joined #bitcoin-core-dev
1392017-10-17T11:24:31  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1402017-10-17T11:24:32  *** Cogito_Ergo_Sum has quit IRC
1412017-10-17T11:24:32  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1422017-10-17T11:32:32  *** ula has joined #bitcoin-core-dev
1432017-10-17T11:37:14  *** SopaXorzTaker has joined #bitcoin-core-dev
1442017-10-17T11:40:35  *** jtimon has quit IRC
1452017-10-17T12:04:08  *** jtimon has joined #bitcoin-core-dev
1462017-10-17T12:15:08  *** reds-stripe has joined #bitcoin-core-dev
1472017-10-17T12:17:02  *** Emcy has quit IRC
1482017-10-17T12:17:21  *** Emcy has joined #bitcoin-core-dev
1492017-10-17T12:21:14  *** Emcy has quit IRC
1502017-10-17T12:21:51  *** Emcy has joined #bitcoin-core-dev
1512017-10-17T12:24:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1522017-10-17T12:26:06  *** rafalcpp has quit IRC
1532017-10-17T12:26:44  <aj> jtimon: re: getblockstats rpc tests, aren't tx sizes non-deterministic due to the signatures sometimes being a byte short due to a leading \x00 getting skipped due to DER encoding?
1542017-10-17T12:30:39  *** intcat has quit IRC
1552017-10-17T12:31:35  *** intcat has joined #bitcoin-core-dev
1562017-10-17T12:32:42  <jtimon> aj: oh, right, that must be it...
1572017-10-17T12:33:19  <jtimon> isn't there a way to solve that?
1582017-10-17T12:34:14  *** Banzai10 has joined #bitcoin-core-dev
1592017-10-17T12:39:45  <sipa> aj: how does thatmake them nondeterministic?
1602017-10-17T12:39:53  <sipa> DER is deterministic
1612017-10-17T12:42:16  *** BashCo has quit IRC
1622017-10-17T12:52:49  <sipa> or you mean the low-S malleability?
1632017-10-17T12:57:47  *** wxss has joined #bitcoin-core-dev
1642017-10-17T13:04:20  *** promag has joined #bitcoin-core-dev
1652017-10-17T13:11:16  <gmaxwell> sipa: I think he thinks the signature is non-determinstic?
1662017-10-17T13:17:37  *** alreadylate has quit IRC
1672017-10-17T13:20:59  *** BashCo has joined #bitcoin-core-dev
1682017-10-17T13:22:47  *** Chris_Stewart_5 has quit IRC
1692017-10-17T13:23:36  *** promag has quit IRC
1702017-10-17T13:27:20  *** promag has joined #bitcoin-core-dev
1712017-10-17T13:29:43  *** promag has quit IRC
1722017-10-17T13:29:52  <aj> sipa: running the same test case repeatedly doesn't generate the same R each time does it?
1732017-10-17T13:30:17  <gmaxwell> it will if the transaction is the same.
1742017-10-17T13:30:33  <gmaxwell> (and key)
1752017-10-17T13:32:06  <aj> context is https://github.com/bitcoin/bitcoin/pull/10757#issuecomment-337212106 fwiw
1762017-10-17T13:32:59  *** promag has joined #bitcoin-core-dev
1772017-10-17T13:34:25  *** alreadylate has joined #bitcoin-core-dev
1782017-10-17T13:37:37  *** roadcrap has quit IRC
1792017-10-17T13:37:59  <sipa> aj: you can always choose to create a tx with a larger or smaller sig
1802017-10-17T13:38:04  <sipa> by grinding
1812017-10-17T13:38:24  *** jtimon has quit IRC
1822017-10-17T13:38:51  <sipa> but if you have an actual tx, the serialization of that sig is fixed
1832017-10-17T13:39:02  *** jtimon has joined #bitcoin-core-dev
1842017-10-17T13:41:07  <aj> sipa: ack. but the test suite doesn't ensure it produces a deterministic chain, so txes will vary between test suite runs, yes/no?
1852017-10-17T13:42:43  <sipa> no, our own signing is deterministic
1862017-10-17T13:42:47  *** esotericnonsense has quit IRC
1872017-10-17T13:43:17  <sipa> you can't assume that other's signatures are - but the ones we create ourselves are
1882017-10-17T13:43:46  *** jtimon has quit IRC
1892017-10-17T13:43:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1902017-10-17T13:47:18  *** jtimon has joined #bitcoin-core-dev
1912017-10-17T13:53:37  *** jtimon has quit IRC
1922017-10-17T13:53:46  *** jtimon_ has joined #bitcoin-core-dev
1932017-10-17T13:56:02  *** alreadylate has quit IRC
1942017-10-17T14:02:45  <aj> sipa: okay, again, correct me if i'm wrong, but i'm seeing "self.nodes[0].getnewaddress()" giving different results between test_runner.py invocations, which (even despite deterministic signing) should result in non-deterministic tx sizes aiui
1952017-10-17T14:03:14  <sipa> aj: oh, sure
1962017-10-17T14:03:19  <sipa> if the the transaction isn't the same
1972017-10-17T14:03:45  *** jtimon_ has quit IRC
1982017-10-17T14:03:54  *** jtimon has joined #bitcoin-core-dev
1992017-10-17T14:04:37  <aj> sipa: yeah. i wasn't following whether the implication was that there was meant to be deterministic generation of addresses/chains to have the test suite results be deterministic
2002017-10-17T14:04:47  *** reds-stripe has quit IRC
2012017-10-17T14:05:15  <sipa> aj: i just read some more context of the discussion, i wasn't aware you were talking about entire tests being deterministic
2022017-10-17T14:06:04  *** d_p has quit IRC
2032017-10-17T14:08:17  <bitcoin-git> [bitcoin] promag opened pull request #11514: Iterate and remove nodes without container copy (master...201710-node-iterate-and-erase) https://github.com/bitcoin/bitcoin/pull/11514
2042017-10-17T14:11:00  *** wasi has quit IRC
2052017-10-17T14:11:09  <bitcoin-git> [bitcoin] promag opened pull request #11515: Assert cs_main is held when retrieving node state (master...201710-node-state-guard) https://github.com/bitcoin/bitcoin/pull/11515
2062017-10-17T14:12:07  *** shesek has joined #bitcoin-core-dev
2072017-10-17T14:12:08  *** shesek has joined #bitcoin-core-dev
2082017-10-17T14:12:24  *** d_p has joined #bitcoin-core-dev
2092017-10-17T14:12:43  *** meshcollider has quit IRC
2102017-10-17T14:15:05  *** jtimon has quit IRC
2112017-10-17T14:16:27  *** promag has quit IRC
2122017-10-17T14:22:01  *** Emcy has quit IRC
2132017-10-17T14:22:32  *** Emcy has joined #bitcoin-core-dev
2142017-10-17T14:30:02  *** shesek has quit IRC
2152017-10-17T14:33:07  *** clarkmoody has quit IRC
2162017-10-17T14:35:25  *** Cogito_Ergo_Sum has quit IRC
2172017-10-17T14:36:05  *** sybarite has quit IRC
2182017-10-17T14:45:02  <bitcoin-git> [bitcoin] practicalswift opened pull request #11516: crypto: Avoid creating of one-past-the-end pointer and performing a noop memset call (HMAC-SHA{256,512}) (master...one-past-the-end) https://github.com/bitcoin/bitcoin/pull/11516
2192017-10-17T14:56:35  <bitcoin-git> [bitcoin] simonmulser closed pull request #11510: Net: Log when peer reached MAX_BLOCKS_IN_TRANSIT_PER_PEER (master...add_log) https://github.com/bitcoin/bitcoin/pull/11510
2202017-10-17T15:35:59  *** Chris_Stewart_5 has quit IRC
2212017-10-17T15:38:58  *** pedrobranco has joined #bitcoin-core-dev
2222017-10-17T15:42:51  <pedrobranco> Hello, any change of getting https://github.com/bitcoin/bitcoin/pull/11483 merged soon since it's a bug in importmulti?
2232017-10-17T15:57:32  *** Dizzle has joined #bitcoin-core-dev
2242017-10-17T16:08:45  <jonasschnelli> pedrobranco: Needs more reviews first..
2252017-10-17T16:08:59  <jonasschnelli> Is it something we want to backport, right?
2262017-10-17T16:21:33  <pedrobranco> jonasschnelli: Yes it needs more reviews.
2272017-10-17T16:29:02  <bitcoin-git> [bitcoin] martinus opened pull request #11517: Tests: Improve benchmark precision by inlining performance critical code (master...improved-benchmarking) https://github.com/bitcoin/bitcoin/pull/11517
2282017-10-17T16:33:01  <jonasschnelli> pedrobranco: I guess another one and we'll be fine. Its a simple change
2292017-10-17T16:44:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2302017-10-17T16:59:11  *** timothy has quit IRC
2312017-10-17T17:03:22  *** Banzai10 has quit IRC
2322017-10-17T17:04:03  *** mess110 has joined #bitcoin-core-dev
2332017-10-17T17:07:02  <pedrobranco> jonasschnelli: ty
2342017-10-17T17:09:43  *** mmgen has joined #bitcoin-core-dev
2352017-10-17T17:12:09  *** Ylbam has joined #bitcoin-core-dev
2362017-10-17T17:15:39  *** pedrobranco has quit IRC
2372017-10-17T17:15:47  *** pedrobranco has joined #bitcoin-core-dev
2382017-10-17T17:22:50  *** Emcy has quit IRC
2392017-10-17T17:25:00  *** mmgen has quit IRC
2402017-10-17T17:25:01  *** intcat has quit IRC
2412017-10-17T17:25:01  *** dermoth has quit IRC
2422017-10-17T17:25:32  *** d_p has quit IRC
2432017-10-17T17:25:33  *** arubi has quit IRC
2442017-10-17T17:28:03  <BlueMatt> #11483 could get a merge, imo, dunno if anyone merging is around today, though
2452017-10-17T17:28:05  <gribble> https://github.com/bitcoin/bitcoin/issues/11483 | Fix importmulti bug when importing an already imported key by pedrobranco · Pull Request #11483 · bitcoin/bitcoin · GitHub
2462017-10-17T17:29:44  *** Aaronvan_ has joined #bitcoin-core-dev
2472017-10-17T17:32:41  *** AaronvanW has quit IRC
2482017-10-17T17:33:17  *** AaronvanW has joined #bitcoin-core-dev
2492017-10-17T17:34:18  *** tripleslash has quit IRC
2502017-10-17T17:34:25  *** Aaronvan_ has joined #bitcoin-core-dev
2512017-10-17T17:37:23  *** laurentmt has quit IRC
2522017-10-17T17:37:35  *** AaronvanW has quit IRC
2532017-10-17T17:39:10  <mess110> hi, working on adding a proxy icon, wanted to ask for feedback.
2542017-10-17T17:39:15  <mess110> do you think this icon https://ibb.co/eP9mGR is better than https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png ?
2552017-10-17T17:39:19  <mess110> it is made out of chevron-left and 3 device-desktop from http://s-ings.com/typicons/
2562017-10-17T17:46:04  *** arubi has joined #bitcoin-core-dev
2572017-10-17T17:48:18  *** d_p_ has joined #bitcoin-core-dev
2582017-10-17T17:53:40  *** intcat has joined #bitcoin-core-dev
2592017-10-17T17:54:00  *** Aaronvan_ is now known as AaronvanW
2602017-10-17T18:01:53  *** SopaXorzTaker has quit IRC
2612017-10-17T18:04:49  *** meshcollider has joined #bitcoin-core-dev
2622017-10-17T18:04:55  *** pedrobranco has quit IRC
2632017-10-17T18:26:05  *** mess110 has quit IRC
2642017-10-17T18:41:12  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2652017-10-17T18:41:12  *** Cogito_Ergo_Sum has quit IRC
2662017-10-17T18:41:12  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2672017-10-17T18:42:31  *** pergaminho has joined #bitcoin-core-dev
2682017-10-17T19:07:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2c66cea2d186...14b860bf6402
2692017-10-17T19:07:25  <bitcoin-git> bitcoin/master fc0176d John Newbery: [tests] use python3 for authproxy.py
2702017-10-17T19:07:25  <bitcoin-git> bitcoin/master 323d8f6 John Newbery: [tests] fix flake8 warnings in authproxy.py
2712017-10-17T19:07:26  <bitcoin-git> bitcoin/master 8f9e362 John Newbery: [tests] authproxy.py: tidy up __init__()
2722017-10-17T19:08:00  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11513: [trivial] [tests] A few Python3 tidy ups (master...authproxy_tidyups) https://github.com/bitcoin/bitcoin/pull/11513
2732017-10-17T19:38:39  *** laurentmt has joined #bitcoin-core-dev
2742017-10-17T19:44:35  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/14b860bf6402...808c84f89d0e
2752017-10-17T19:44:36  <bitcoin-git> bitcoin/master a44a215 Pedro Branco: Fix importmulti bug when importing an already imported key
2762017-10-17T19:44:37  <bitcoin-git> bitcoin/master 808c84f MarcoFalke: Merge #11483: Fix importmulti bug when importing an already imported key...
2772017-10-17T19:45:05  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483
2782017-10-17T19:46:48  *** roadcrap has joined #bitcoin-core-dev
2792017-10-17T19:47:06  *** mess110 has joined #bitcoin-core-dev
2802017-10-17T19:47:22  *** mmgen has joined #bitcoin-core-dev
2812017-10-17T19:53:27  *** musalbas has joined #bitcoin-core-dev
2822017-10-17T19:56:33  *** Guyver2 has joined #bitcoin-core-dev
2832017-10-17T20:01:16  *** pergaminho has quit IRC
2842017-10-17T20:03:59  *** PaulCapestany has quit IRC
2852017-10-17T20:06:47  *** PaulCapestany has joined #bitcoin-core-dev
2862017-10-17T20:10:45  <cfields> sipa: i forget your preference. You like a github review (batch), or individual comments?
2872017-10-17T20:17:50  *** chjj has quit IRC
2882017-10-17T20:21:30  <BlueMatt> cfields: for the sake of (most peoples') inbox, batch
2892017-10-17T20:23:19  <cfields> heh, fair enough. iirc someone complained about the batches because it screwed up their workflow.
2902017-10-17T20:23:32  <cfields> hmm, maybe that was you, with your online/offline split?
2912017-10-17T20:26:01  *** Cheeseo has joined #bitcoin-core-dev
2922017-10-17T20:31:03  *** Giszmo has quit IRC
2932017-10-17T20:34:45  *** laurentmt has quit IRC
2942017-10-17T20:35:22  *** pergaminho has joined #bitcoin-core-dev
2952017-10-17T20:39:38  <sdaftuar> cfields: i'm thinking about adding a way to mock out addrman for the purposes of regtest-testing our outbound peer logic.  does that sound like a reasonable thing to do?
2962017-10-17T20:40:10  <cfields> sdaftuar: yep! I've already got it halfway done, though...
2972017-10-17T20:40:19  <sdaftuar> oh, cool
2982017-10-17T20:40:29  <sdaftuar> any chance you have a commit i can steal then? :)
2992017-10-17T20:40:45  <cfields> heh, it's just waiting on #11457
3002017-10-17T20:40:47  <gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
3012017-10-17T20:40:55  <cfields> sure
3022017-10-17T20:41:08  <cfields> it's broken out the same way
3032017-10-17T20:42:26  <cfields> sdaftuar: will push it up tonight, need to clean up/rebase
3042017-10-17T20:42:43  <sdaftuar> cool, thanks.  i'll takea  look at 11457
3052017-10-17T20:46:43  *** karelb has quit IRC
3062017-10-17T20:48:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #11518: [WIP] [tests] Simplify/clarify the NodeConn/NodeConnCB mininode classes (master...node_conn_big_refactor) https://github.com/bitcoin/bitcoin/pull/11518
3072017-10-17T20:50:05  *** roadcrap has quit IRC
3082017-10-17T21:00:10  *** lightningbot has joined #bitcoin-core-dev
3092017-10-17T21:02:00  *** goatpig has quit IRC
3102017-10-17T21:02:19  *** LeMiner has quit IRC
3112017-10-17T21:02:57  *** laurentmt has joined #bitcoin-core-dev
3122017-10-17T21:03:36  *** LeMiner has joined #bitcoin-core-dev
3132017-10-17T21:06:39  *** Chris_Stewart_5 has quit IRC
3142017-10-17T21:11:49  *** promag has joined #bitcoin-core-dev
3152017-10-17T21:14:56  *** jb55 has quit IRC
3162017-10-17T21:19:16  *** victorSN has quit IRC
3172017-10-17T21:21:03  *** laurentmt has quit IRC
3182017-10-17T21:23:13  *** jb55 has joined #bitcoin-core-dev
3192017-10-17T21:29:27  *** jb55 has quit IRC
3202017-10-17T21:31:05  *** pergaminho has quit IRC
3212017-10-17T21:33:00  *** d_p_ has quit IRC
3222017-10-17T21:35:54  *** chjj has joined #bitcoin-core-dev
3232017-10-17T21:38:06  *** d_p has joined #bitcoin-core-dev
3242017-10-17T21:43:51  *** Cheeseo has quit IRC
3252017-10-17T21:50:51  *** pergaminho has joined #bitcoin-core-dev
3262017-10-17T21:51:28  *** jb55 has joined #bitcoin-core-dev
3272017-10-17T21:54:17  *** Guyver2 has quit IRC
3282017-10-17T21:56:54  *** pergaminho has quit IRC
3292017-10-17T22:01:35  *** jb55 has quit IRC
3302017-10-17T22:06:15  *** jb55 has joined #bitcoin-core-dev
3312017-10-17T22:06:28  *** Cogito_Ergo_Sum has quit IRC
3322017-10-17T22:08:48  <promag> jnewbery: where is P2PInterface?
3332017-10-17T22:10:02  <promag> jnewbery: https://travis-ci.org/bitcoin/bitcoin/jobs/289221884#L741
3342017-10-17T22:11:33  <promag> nevermind 1st question
3352017-10-17T22:12:22  *** mess110 has quit IRC
3362017-10-17T22:13:26  *** d_p has quit IRC
3372017-10-17T22:14:15  *** d_p_ has joined #bitcoin-core-dev
3382017-10-17T22:17:16  *** tripleslash has joined #bitcoin-core-dev
3392017-10-17T22:22:57  *** dgenr8 has quit IRC
3402017-10-17T22:23:00  *** cheese_ has joined #bitcoin-core-dev
3412017-10-17T22:23:48  *** dgenr8 has joined #bitcoin-core-dev
3422017-10-17T22:44:35  *** promag has quit IRC
3432017-10-17T22:55:41  *** vicenteH has quit IRC
3442017-10-17T23:08:39  *** nds_ has joined #bitcoin-core-dev
3452017-10-17T23:17:57  *** cheese_ has quit IRC
3462017-10-17T23:31:46  *** Dizzle has quit IRC
3472017-10-17T23:48:48  *** Emcy has joined #bitcoin-core-dev
3482017-10-17T23:49:17  *** jb55 has quit IRC
3492017-10-17T23:49:35  *** jb55 has joined #bitcoin-core-dev
3502017-10-17T23:51:43  *** rhavar has joined #bitcoin-core-dev
3512017-10-17T23:56:49  *** AaronvanW has quit IRC
3522017-10-17T23:57:27  *** AaronvanW has joined #bitcoin-core-dev
3532017-10-17T23:57:35  *** jb55 has quit IRC