12017-10-26T00:00:50  *** mxg has quit IRC
  22017-10-26T00:01:31  *** StopAndDecrypt has quit IRC
  32017-10-26T00:22:17  *** StopAndDecrypt has joined #bitcoin-core-dev
  42017-10-26T00:43:55  *** mxg has joined #bitcoin-core-dev
  52017-10-26T00:45:00  *** mxg has quit IRC
  62017-10-26T00:45:30  *** mxg has joined #bitcoin-core-dev
  72017-10-26T00:51:13  <bitcoin-git> [bitcoin] promag opened pull request #11563: Improve CheckBlockIndex performance (master...2017-10-improve-checkblockindex) https://github.com/bitcoin/bitcoin/pull/11563
  82017-10-26T01:00:07  *** dabura667 has joined #bitcoin-core-dev
  92017-10-26T01:01:57  *** Ylbam has quit IRC
 102017-10-26T01:04:09  *** tripleslash has quit IRC
 112017-10-26T01:05:01  *** promag has quit IRC
 122017-10-26T01:05:47  *** StopAndDecrypt has quit IRC
 132017-10-26T01:16:07  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 142017-10-26T01:17:24  *** Antranik has joined #bitcoin-core-dev
 152017-10-26T01:19:12  *** StopAndDecrypt has joined #bitcoin-core-dev
 162017-10-26T01:22:20  *** axsion has joined #bitcoin-core-dev
 172017-10-26T01:25:26  <Antranik> how about them dev forks ey
 182017-10-26T01:26:55  *** axsion has quit IRC
 192017-10-26T01:39:00  *** arowser has quit IRC
 202017-10-26T01:46:20  *** Chris_Stewart_5 has quit IRC
 212017-10-26T02:00:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 222017-10-26T02:17:21  *** Chris_Stewart_5 has quit IRC
 232017-10-26T02:18:37  <jb55> #bitcoin-forks
 242017-10-26T02:26:19  *** xinxi has quit IRC
 252017-10-26T02:26:54  *** xinxi has joined #bitcoin-core-dev
 262017-10-26T02:46:57  *** justanotheruser has quit IRC
 272017-10-26T02:50:45  *** justanotheruser has joined #bitcoin-core-dev
 282017-10-26T02:54:37  *** Giszmo has quit IRC
 292017-10-26T02:54:38  *** xinxi has quit IRC
 302017-10-26T02:55:56  *** xinxi has joined #bitcoin-core-dev
 312017-10-26T02:57:01  *** chjj has joined #bitcoin-core-dev
 322017-10-26T03:00:12  *** xinxi has quit IRC
 332017-10-26T03:08:44  *** Giszmo has joined #bitcoin-core-dev
 342017-10-26T03:20:18  *** wxss has quit IRC
 352017-10-26T03:27:20  *** xinxi has joined #bitcoin-core-dev
 362017-10-26T03:54:42  *** xinxi has quit IRC
 372017-10-26T03:54:58  *** mxg has quit IRC
 382017-10-26T04:00:07  <gmaxwell> sdaftuar: do we learn about a peer's tip from GETHEADERS messages they send us... e.g. if they send us a getheaders whos locator starts with our current tip will we update them to that
 392017-10-26T04:09:37  *** justanotheruser has quit IRC
 402017-10-26T04:21:43  *** xinxi has joined #bitcoin-core-dev
 412017-10-26T04:27:22  *** xinxi has quit IRC
 422017-10-26T04:27:49  *** justanotheruser has joined #bitcoin-core-dev
 432017-10-26T04:41:05  *** sipa has quit IRC
 442017-10-26T04:41:19  *** sipa has joined #bitcoin-core-dev
 452017-10-26T04:49:32  *** justanotheruser has quit IRC
 462017-10-26T05:01:24  *** cheetah2 has joined #bitcoin-core-dev
 472017-10-26T05:02:01  *** jtimon has quit IRC
 482017-10-26T05:02:54  *** randy-waterhouse has joined #bitcoin-core-dev
 492017-10-26T05:03:10  *** randy-waterhouse has joined #bitcoin-core-dev
 502017-10-26T05:04:32  *** randy-waterhouse has quit IRC
 512017-10-26T05:06:00  *** randy-waterhouse has joined #bitcoin-core-dev
 522017-10-26T05:06:08  *** justanotheruser has joined #bitcoin-core-dev
 532017-10-26T05:06:24  *** randy-waterhouse has quit IRC
 542017-10-26T05:06:25  *** randy-waterhouse has joined #bitcoin-core-dev
 552017-10-26T05:24:06  *** xinxi has joined #bitcoin-core-dev
 562017-10-26T05:27:10  *** Ejy_ has joined #bitcoin-core-dev
 572017-10-26T05:32:06  *** Cryptobit has joined #bitcoin-core-dev
 582017-10-26T05:42:59  *** Provoostenator has joined #bitcoin-core-dev
 592017-10-26T05:52:14  *** jonasschnelli has quit IRC
 602017-10-26T05:52:14  *** jonasschnelli has joined #bitcoin-core-dev
 612017-10-26T05:55:29  *** roadcrap has joined #bitcoin-core-dev
 622017-10-26T05:58:03  *** Cryptobit has quit IRC
 632017-10-26T06:00:23  *** cheetah2 has quit IRC
 642017-10-26T06:02:49  *** Ejy_ has quit IRC
 652017-10-26T06:07:32  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 662017-10-26T06:07:32  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 672017-10-26T06:22:23  *** xinxi has quit IRC
 682017-10-26T06:23:48  *** Ylbam has joined #bitcoin-core-dev
 692017-10-26T06:37:10  *** jdouglas74 has joined #bitcoin-core-dev
 702017-10-26T06:37:17  <bitcoin-git> [bitcoin] fanquake closed pull request #7601: [WIP] HTLC implementation in the wallet (master...zkcp) https://github.com/bitcoin/bitcoin/pull/7601
 712017-10-26T06:47:20  *** jdouglas74 has quit IRC
 722017-10-26T07:19:28  *** xinxi has joined #bitcoin-core-dev
 732017-10-26T07:20:52  *** randy-waterhouse has quit IRC
 742017-10-26T07:23:35  *** xinxi has quit IRC
 752017-10-26T07:26:35  *** Provoostenator has quit IRC
 762017-10-26T07:41:40  *** AaronvanW has joined #bitcoin-core-dev
 772017-10-26T07:48:08  *** timothy has joined #bitcoin-core-dev
 782017-10-26T07:58:06  *** laurentmt has joined #bitcoin-core-dev
 792017-10-26T08:01:24  *** xinxi has joined #bitcoin-core-dev
 802017-10-26T08:04:16  *** alreadylate has joined #bitcoin-core-dev
 812017-10-26T08:05:52  *** xinxi has quit IRC
 822017-10-26T08:06:02  *** d9b4bef9 has quit IRC
 832017-10-26T08:13:27  *** Emcy has quit IRC
 842017-10-26T08:21:09  *** promag has joined #bitcoin-core-dev
 852017-10-26T08:23:02  *** jb55 has quit IRC
 862017-10-26T08:23:15  *** decho has joined #bitcoin-core-dev
 872017-10-26T08:27:29  *** decho has quit IRC
 882017-10-26T08:33:14  *** CubicEarth has joined #bitcoin-core-dev
 892017-10-26T08:33:44  *** CubicEarth has joined #bitcoin-core-dev
 902017-10-26T08:38:22  *** CubicEarth has quit IRC
 912017-10-26T08:39:13  *** CubicEarth has joined #bitcoin-core-dev
 922017-10-26T08:43:57  *** marko_ has joined #bitcoin-core-dev
 932017-10-26T08:44:52  *** marko_ has quit IRC
 942017-10-26T08:51:00  *** Ylbam has quit IRC
 952017-10-26T08:56:33  *** wumpus has quit IRC
 962017-10-26T08:58:49  *** wumpus has joined #bitcoin-core-dev
 972017-10-26T08:59:33  *** Emcy has joined #bitcoin-core-dev
 982017-10-26T09:02:48  *** xinxi has joined #bitcoin-core-dev
 992017-10-26T09:06:06  *** Emcy_ has joined #bitcoin-core-dev
1002017-10-26T09:07:22  *** Emcy has quit IRC
1012017-10-26T09:08:32  *** Giszmo has quit IRC
1022017-10-26T09:09:39  *** Emcy has joined #bitcoin-core-dev
1032017-10-26T09:12:08  *** Emcy_ has quit IRC
1042017-10-26T09:12:56  *** Emcy_ has joined #bitcoin-core-dev
1052017-10-26T09:16:06  *** Emcy has quit IRC
1062017-10-26T09:18:17  *** jb55 has joined #bitcoin-core-dev
1072017-10-26T09:23:52  *** CubicEar_ has joined #bitcoin-core-dev
1082017-10-26T09:24:16  *** CubicEarth has quit IRC
1092017-10-26T09:24:18  *** promag has quit IRC
1102017-10-26T09:28:35  *** Giszmo has joined #bitcoin-core-dev
1112017-10-26T09:28:43  *** promag has joined #bitcoin-core-dev
1122017-10-26T09:29:00  <sdaftuar> gmaxwell: my understanding of the scheduler is that it'll start scheduling callbacks at some point after startup, so i wouldn't expect the network to be completely synced
1132017-10-26T09:29:18  <sdaftuar> gmaxwell: also there's random drift, since the scheduler schedules the next callback N milliseconds after the prior one finishes
1142017-10-26T09:29:39  <sdaftuar> but worth discussing whether the interval is short enough that there still might be too much concentration of everyone trying to find a new peer
1152017-10-26T09:30:12  <sdaftuar> gmaxwell: regarding getheaders/locator -- no we don't update pindexBestKnownBlock from a peer's locator
1162017-10-26T09:30:25  <sdaftuar> we use pindexBestKnownBlock to figure out what blocks we can download from our peer
1172017-10-26T09:30:57  <sdaftuar> and the peer will update its locator based on headers it knows (not blocks!) during initial headers sync
1182017-10-26T09:31:33  <sdaftuar> in order to sync the whole headers chain (and given the MAX_HEADERS_RESULTS constraint on headers messages)
1192017-10-26T09:38:39  *** jb55 has quit IRC
1202017-10-26T09:41:17  *** m8tion has joined #bitcoin-core-dev
1212017-10-26T09:45:00  *** promag has quit IRC
1222017-10-26T09:47:04  *** promag has joined #bitcoin-core-dev
1232017-10-26T09:48:25  *** Guyver2 has joined #bitcoin-core-dev
1242017-10-26T09:55:18  *** promag has quit IRC
1252017-10-26T09:57:21  *** xinxi has quit IRC
1262017-10-26T09:58:44  *** promag has joined #bitcoin-core-dev
1272017-10-26T10:06:20  *** AaronvanW has quit IRC
1282017-10-26T10:06:21  *** promag has quit IRC
1292017-10-26T10:07:06  *** AaronvanW has joined #bitcoin-core-dev
1302017-10-26T10:14:13  *** Emcy_ has quit IRC
1312017-10-26T10:15:01  *** Emcy has joined #bitcoin-core-dev
1322017-10-26T10:17:43  *** promag has joined #bitcoin-core-dev
1332017-10-26T10:20:56  <bitcoin-git> [bitcoin] Sjors closed pull request #11557: WIP: Use Sat/WU instead of (μ/m)BTC/kB (master...fee-sat-per-wu) https://github.com/bitcoin/bitcoin/pull/11557
1342017-10-26T10:26:01  *** dabura667 has quit IRC
1352017-10-26T10:43:34  *** xinxi has joined #bitcoin-core-dev
1362017-10-26T10:51:55  *** promag has quit IRC
1372017-10-26T10:56:41  *** xinxi has quit IRC
1382017-10-26T11:13:12  <bitcoin-git> [bitcoin] ryanofsky opened pull request #11565: Make listsinceblock refuse unknown block hash (master...pr/since) https://github.com/bitcoin/bitcoin/pull/11565
1392017-10-26T11:23:52  *** xinxi has joined #bitcoin-core-dev
1402017-10-26T11:31:21  *** SopaXorzTaker has joined #bitcoin-core-dev
1412017-10-26T11:32:26  *** ula has joined #bitcoin-core-dev
1422017-10-26T11:34:07  *** alreadylate has quit IRC
1432017-10-26T11:47:04  *** wxss has joined #bitcoin-core-dev
1442017-10-26T11:48:32  *** laurentmt has quit IRC
1452017-10-26T11:50:51  *** Antranik has quit IRC
1462017-10-26T11:51:18  *** d9b4bef9 has joined #bitcoin-core-dev
1472017-10-26T12:05:09  *** d_p_ has quit IRC
1482017-10-26T12:05:09  *** ghost43 has quit IRC
1492017-10-26T12:05:09  *** dermoth has quit IRC
1502017-10-26T12:05:09  *** arubi has quit IRC
1512017-10-26T12:05:09  *** intcat has quit IRC
1522017-10-26T12:05:58  *** ghost43 has joined #bitcoin-core-dev
1532017-10-26T12:06:19  *** intcat has joined #bitcoin-core-dev
1542017-10-26T12:07:27  *** arubi has joined #bitcoin-core-dev
1552017-10-26T12:11:37  *** d_p has joined #bitcoin-core-dev
1562017-10-26T12:33:55  *** arubi has quit IRC
1572017-10-26T12:41:27  *** Giszmo has quit IRC
1582017-10-26T12:41:57  *** CubicEar_ has quit IRC
1592017-10-26T12:51:33  *** arubi has joined #bitcoin-core-dev
1602017-10-26T12:59:27  *** spinza has quit IRC
1612017-10-26T13:04:19  *** promag has joined #bitcoin-core-dev
1622017-10-26T13:09:22  *** rafalcpp_ has quit IRC
1632017-10-26T13:09:45  *** rafalcpp has joined #bitcoin-core-dev
1642017-10-26T13:16:06  *** Giszmo has joined #bitcoin-core-dev
1652017-10-26T13:17:10  *** spinza has joined #bitcoin-core-dev
1662017-10-26T13:19:56  *** justanotheruser has quit IRC
1672017-10-26T13:20:19  *** Giszmo has quit IRC
1682017-10-26T13:38:32  *** justanotheruser has joined #bitcoin-core-dev
1692017-10-26T13:39:00  *** Giszmo has joined #bitcoin-core-dev
1702017-10-26T13:41:32  *** arubi has quit IRC
1712017-10-26T13:44:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1722017-10-26T13:45:37  *** arubi has joined #bitcoin-core-dev
1732017-10-26T13:53:49  *** Emcy has quit IRC
1742017-10-26T13:53:54  *** BashCo has quit IRC
1752017-10-26T13:54:09  *** Emcy has joined #bitcoin-core-dev
1762017-10-26T13:57:02  *** alreadylate has joined #bitcoin-core-dev
1772017-10-26T13:58:19  *** BashCo has joined #bitcoin-core-dev
1782017-10-26T13:59:13  *** Guyver2 has quit IRC
1792017-10-26T13:59:19  *** Guest21 has joined #bitcoin-core-dev
1802017-10-26T13:59:37  *** Giszmo has quit IRC
1812017-10-26T14:04:56  *** Guyver2 has joined #bitcoin-core-dev
1822017-10-26T14:14:28  *** nony has joined #bitcoin-core-dev
1832017-10-26T14:16:11  *** BashCo has quit IRC
1842017-10-26T14:16:14  *** promag has quit IRC
1852017-10-26T14:18:31  *** Giszmo has joined #bitcoin-core-dev
1862017-10-26T14:27:20  *** Chris_Stewart_5 has quit IRC
1872017-10-26T14:33:11  *** nony has quit IRC
1882017-10-26T14:35:13  *** Giszmo has quit IRC
1892017-10-26T14:41:05  *** dgenr8 has quit IRC
1902017-10-26T14:42:03  *** dgenr8 has joined #bitcoin-core-dev
1912017-10-26T14:48:11  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1922017-10-26T14:48:52  *** jb55 has joined #bitcoin-core-dev
1932017-10-26T14:48:58  *** Emcy has quit IRC
1942017-10-26T14:49:34  *** Emcy has joined #bitcoin-core-dev
1952017-10-26T14:49:41  *** Emcy has quit IRC
1962017-10-26T14:49:42  *** Emcy has joined #bitcoin-core-dev
1972017-10-26T14:55:44  *** Emcy has quit IRC
1982017-10-26T14:58:41  *** jtimon has joined #bitcoin-core-dev
1992017-10-26T15:01:45  *** gaf_ has quit IRC
2002017-10-26T15:08:46  *** Chris_Stewart_5 has quit IRC
2012017-10-26T15:11:53  *** Giszmo has joined #bitcoin-core-dev
2022017-10-26T15:16:34  *** jb55 has quit IRC
2032017-10-26T15:26:01  *** BashCo has joined #bitcoin-core-dev
2042017-10-26T15:27:47  <bitcoin-git> [bitcoin] pkaksha opened pull request #11566: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/11566
2052017-10-26T15:28:11  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57ee73990f1c...cf8c4a7633b1
2062017-10-26T15:28:11  <bitcoin-git> bitcoin/master fa81534 MarcoFalke: Add share/rpcuser to dist. source code archive
2072017-10-26T15:28:12  <bitcoin-git> bitcoin/master cf8c4a7 Wladimir J. van der Laan: Merge #11530: Add share/rpcuser to dist. source code archive...
2082017-10-26T15:28:53  <bitcoin-git> [bitcoin] laanwj closed pull request #11530: Add share/rpcuser to dist. source code archive (master...Mf1710-distShare) https://github.com/bitcoin/bitcoin/pull/11530
2092017-10-26T15:29:01  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.15: https://github.com/bitcoin/bitcoin/commit/265bb214ecf616a7a55fc979a227d5f215046d84
2102017-10-26T15:29:01  <bitcoin-git> bitcoin/0.15 265bb21 MarcoFalke: Add share/rpcuser to dist. source code archive...
2112017-10-26T15:34:07  *** Giszmo has quit IRC
2122017-10-26T15:34:18  *** Giszmo has joined #bitcoin-core-dev
2132017-10-26T15:36:38  *** BashCo_ has joined #bitcoin-core-dev
2142017-10-26T15:38:31  *** BashCo has quit IRC
2152017-10-26T15:42:36  *** timothy has quit IRC
2162017-10-26T15:47:07  <bitcoin-git> [bitcoin] sipa closed pull request #11566: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/11566
2172017-10-26T15:49:39  *** intcat has quit IRC
2182017-10-26T15:50:43  *** intcat has joined #bitcoin-core-dev
2192017-10-26T15:52:02  *** d9b4bef9 has quit IRC
2202017-10-26T15:53:09  *** d9b4bef9 has joined #bitcoin-core-dev
2212017-10-26T15:57:33  *** meshcollider has quit IRC
2222017-10-26T16:16:31  *** dgenr8 has quit IRC
2232017-10-26T16:17:27  *** dgenr8 has joined #bitcoin-core-dev
2242017-10-26T16:25:36  *** jb55 has joined #bitcoin-core-dev
2252017-10-26T16:26:05  *** Giszmo has quit IRC
2262017-10-26T16:27:09  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2272017-10-26T16:28:46  *** BashCo_ has quit IRC
2282017-10-26T16:36:55  *** BashCo has joined #bitcoin-core-dev
2292017-10-26T16:50:17  *** quantbot has quit IRC
2302017-10-26T16:50:43  *** quantbot has joined #bitcoin-core-dev
2312017-10-26T16:52:30  *** m8tion has quit IRC
2322017-10-26T16:56:50  <bitcoin-git> [bitcoin] sdaftuar closed pull request #11534: Evict outbound peers if tip is stale (master...2017-10-stale-tip-eviction) https://github.com/bitcoin/bitcoin/pull/11534
2332017-10-26T17:08:16  *** pergaminho has quit IRC
2342017-10-26T17:12:40  *** vicenteH has quit IRC
2352017-10-26T17:12:48  *** vicenteH has joined #bitcoin-core-dev
2362017-10-26T17:15:58  *** BashCo has quit IRC
2372017-10-26T17:20:07  *** ula has quit IRC
2382017-10-26T17:28:36  *** BashCo has joined #bitcoin-core-dev
2392017-10-26T17:29:29  *** Emcy has joined #bitcoin-core-dev
2402017-10-26T17:31:41  *** quantbot has quit IRC
2412017-10-26T17:43:04  *** laurentmt has joined #bitcoin-core-dev
2422017-10-26T17:44:08  *** RubenSomsen has joined #bitcoin-core-dev
2432017-10-26T17:55:26  *** quantbot has joined #bitcoin-core-dev
2442017-10-26T17:56:51  *** Testing has joined #bitcoin-core-dev
2452017-10-26T17:57:14  *** Testing is now known as Guest9936
2462017-10-26T17:58:55  *** xinxi has quit IRC
2472017-10-26T17:59:29  *** xinxi has joined #bitcoin-core-dev
2482017-10-26T18:01:54  *** quantbot has quit IRC
2492017-10-26T18:02:20  *** quantbot has joined #bitcoin-core-dev
2502017-10-26T18:06:27  *** quantbot has quit IRC
2512017-10-26T18:12:54  *** ula has joined #bitcoin-core-dev
2522017-10-26T18:21:46  *** BashCo has quit IRC
2532017-10-26T18:35:53  *** SopaXorzTaker has quit IRC
2542017-10-26T18:52:51  *** promag has joined #bitcoin-core-dev
2552017-10-26T18:55:42  *** meshcollider has joined #bitcoin-core-dev
2562017-10-26T18:55:48  *** maaku has joined #bitcoin-core-dev
2572017-10-26T18:55:59  *** clarkmoody has joined #bitcoin-core-dev
2582017-10-26T18:59:49  *** Guest9936 has quit IRC
2592017-10-26T19:00:12  <achow101> meeting?
2602017-10-26T19:00:15  <sdaftuar> meeting
2612017-10-26T19:00:33  <promag> +1
2622017-10-26T19:00:35  *** StopAndDecrypt|p has joined #bitcoin-core-dev
2632017-10-26T19:00:53  <wumpus> #startmeeting
2642017-10-26T19:00:53  <lightningbot> Meeting started Thu Oct 26 19:00:53 2017 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
2652017-10-26T19:00:53  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
2662017-10-26T19:01:10  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101
2672017-10-26T19:01:17  <achow101> hi
2682017-10-26T19:01:19  <meshcollider> Hi
2692017-10-26T19:01:49  <kanzure> hi.
2702017-10-26T19:02:04  <wumpus> #topic 0.15.0.2
2712017-10-26T19:02:18  <cfields> hi
2722017-10-26T19:02:18  *** alreadylate has quit IRC
2732017-10-26T19:02:38  <wumpus> anything ready for merge there?
2742017-10-26T19:02:42  <maaku> present
2752017-10-26T19:02:48  <sdaftuar> i think #11490 is ready?  maybe needs another ACK?
2762017-10-26T19:02:51  <gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub
2772017-10-26T19:03:21  <jtimon> hi
2782017-10-26T19:03:38  <wumpus> ok, good to know
2792017-10-26T19:03:50  <wumpus> #action merge 11490
2802017-10-26T19:03:51  <gmaxwell> Hi.
2812017-10-26T19:04:19  <cfields> 11490 looked good last i looked, will take a quick look at the last changes and re-ack
2822017-10-26T19:04:26  <gmaxwell> sdaftuar: I already ACKed it.  I think it's pretty great.
2832017-10-26T19:04:29  <sdaftuar> thanks!
2842017-10-26T19:04:32  <achow101> gmaxwell: found a peer that his node with 11490 kicked. we're not sure whether it was kicked for being brain dead or spynode
2852017-10-26T19:04:39  <achow101> or ibd
2862017-10-26T19:04:48  <gmaxwell> but is should have been kicked regardless.
2872017-10-26T19:05:02  <wumpus> yes was about to say that
2882017-10-26T19:05:18  <wumpus> seems an improvement in any case to kick it :)
2892017-10-26T19:05:21  <jtimon> I was going to say if there was anything stopping 8994, but it needs rebase...
2902017-10-26T19:05:24  <achow101> ok, I just wasn't sure that it would effect nodes in inbd
2912017-10-26T19:05:34  <gmaxwell> Yes, I've had a node running the patch for a few days and after the first day I started cycling out all my outbounds every few hours with the hopes of hitting some broken peers.
2922017-10-26T19:05:49  <gmaxwell> achow101: yes, it should-- they're useless to us as outbound targets.
2932017-10-26T19:06:09  <achow101> oh right, duh. outbound..
2942017-10-26T19:06:17  <gmaxwell> .yes, this is outbound only
2952017-10-26T19:06:44  <gmaxwell> and it avoids acting on 4 peers. so even if it goes nuts and kicks things it shouldn't the damage is limited.
2962017-10-26T19:08:02  <bitcoin-git> [bitcoin] sdaftuar opened pull request #11568: Disconnect outbound peers on invalid chains (master...2017-10-disconnect-outbound-peers-on-invalid-chains) https://github.com/bitcoin/bitcoin/pull/11568
2972017-10-26T19:08:14  <sdaftuar> also i think i have a fix to #11446 that should satisfy concerns raised in that PR ^^^
2982017-10-26T19:08:16  <gribble> https://github.com/bitcoin/bitcoin/issues/11446 | Disconnect Peers for Duplicate Invalid blocks. by achow101 · Pull Request #11446 · bitcoin/bitcoin · GitHub
2992017-10-26T19:08:24  <achow101> sdaftuar: yay
3002017-10-26T19:08:30  <cfields> tangentially, does it not make sense to take their blockheight in version into consideration? sure it can be spoofed higher, but if it's low and we're in IBD (and presumably they are too), is it worth it to hang around?
3012017-10-26T19:08:35  <gmaxwell> to reiterite why this specific patch is important; beyond general braindead peer elimination, it addresses the case where you have peers on incompatible consensus rules which you aren't discovering because their chain has less work, so you aren't fetching their invalid blocks.
3022017-10-26T19:08:48  <sdaftuar> it's a refactor unfortunately, so not sure it is a good candidate for backport to 0.15.  but it was simple to do
3032017-10-26T19:08:53  *** BashCo has joined #bitcoin-core-dev
3042017-10-26T19:09:01  <gmaxwell> cfields: well someone could have a lower height but more work chain
3052017-10-26T19:09:29  <wumpus> yes, so for 0.15.0.2 we have open at the moment, apart from the one just discussed:  #11560 #11446 #10593
3062017-10-26T19:09:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub
3072017-10-26T19:09:32  <gribble> https://github.com/bitcoin/bitcoin/issues/11446 | Disconnect Peers for Duplicate Invalid blocks. by achow101 · Pull Request #11446 · bitcoin/bitcoin · GitHub
3082017-10-26T19:09:34  <gribble> https://github.com/bitcoin/bitcoin/issues/10593 | Relax punishment for peers relaying invalid blocks and headers by luke-jr · Pull Request #10593 · bitcoin/bitcoin · GitHub
3092017-10-26T19:09:57  <sdaftuar> #11560 as well
3102017-10-26T19:09:59  <gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub
3112017-10-26T19:10:03  <sdaftuar> oh nvm you had that
3122017-10-26T19:10:07  <wumpus>  #11446 has some doubts from BlueMatt
3132017-10-26T19:10:09  <gribble> https://github.com/bitcoin/bitcoin/issues/11446 | Disconnect Peers for Duplicate Invalid blocks. by achow101 · Pull Request #11446 · bitcoin/bitcoin · GitHub
3142017-10-26T19:10:47  <meshcollider> Is #11531 also aimed for 0.15.0.2?
3152017-10-26T19:10:48  <gribble> https://github.com/bitcoin/bitcoin/issues/11531 | Check that new headers are not a descendant of an invalid block (more effeciently) by TheBlueMatt · Pull Request #11531 · bitcoin/bitcoin · GitHub
3162017-10-26T19:10:58  <jnewbery> #10593 seems to be reverting unrelated code with no rationale, so I think that can be untagged
3172017-10-26T19:11:00  <gribble> https://github.com/bitcoin/bitcoin/issues/10593 | Relax punishment for peers relaying invalid blocks and headers by luke-jr · Pull Request #10593 · bitcoin/bitcoin · GitHub
3182017-10-26T19:11:18  <achow101> I guess 11446 has some edge cases that could be problematic
3192017-10-26T19:11:27  <gmaxwell> for some reason I thought what we were doing in 11446 was outbound only. I agree that our agressiveness increases here should be outbound only.
3202017-10-26T19:11:45  <luke-jr> jnewbery: reverting what? it removes tests that check for the behaviour that is being removed
3212017-10-26T19:11:47  <wumpus> ok added 11531
3222017-10-26T19:11:47  <gmaxwell> it's important that we don't fully partition old nodes during a softfork.
3232017-10-26T19:12:01  <achow101> it would be better if we could get more granular errors from processnewblockheaders
3242017-10-26T19:12:02  <wumpus> how much time do we have left?
3252017-10-26T19:12:07  <sdaftuar> 11568 is the same as 11446, except it avoids disconnecting hb compact block peers, and only applies to outbound peers
3262017-10-26T19:12:22  <wumpus> sdaftuar: ok we should remove one, then :)
3272017-10-26T19:12:43  <sdaftuar> agreed :)
3282017-10-26T19:12:56  <wumpus> eh wait 11568 isn't tagged 0.15.0.2 at all
3292017-10-26T19:13:00  <cfields> heh, it's getting hard to keep up with these
3302017-10-26T19:13:04  <achow101> wumpus: it was just made
3312017-10-26T19:13:17  <sdaftuar> i was trying to open it before the meeting started, doh
3322017-10-26T19:13:27  <wumpus> cfields: very hard, yes
3332017-10-26T19:13:29  <achow101> if 11568 is 11446 but only for outbound peers, I'm fine with that
3342017-10-26T19:13:42  <jnewbery> luke-jr: I haven't fully dug into it, but it regresses #8305, no?
3352017-10-26T19:13:44  <gribble> https://github.com/bitcoin/bitcoin/issues/8305 | Improve handling of unconnecting headers by sdaftuar · Pull Request #8305 · bitcoin/bitcoin · GitHub
3362017-10-26T19:13:56  <wumpus> ok, replacing 11446 then
3372017-10-26T19:13:59  <BlueMatt> I mean if we want a 0.15.0.2 we literally need to rc tomorrow or this weekend, imo
3382017-10-26T19:14:48  <gmaxwell> 11568 looks good on first run through.
3392017-10-26T19:15:04  <cfields> disclosure there: I'll be away after tomorrow night until tuesday morning
3402017-10-26T19:15:24  <wumpus> BlueMatt: what can we realistically merge before that time?
3412017-10-26T19:15:40  <luke-jr> jnewbery: I don't think so - 8305 disconnects under certain conditions, but 10593 disconnects a superset of those conditions
3422017-10-26T19:15:42  <cfields> i can make plans to be available for building if really necessary
3432017-10-26T19:15:55  <BlueMatt> wumpus: I dont think a sufficient set to make 0.15.0.2 worth it
3442017-10-26T19:16:08  <gmaxwell> I think probably if you try you can merge one PR per minute... we could empty out github by then, no problem.. just lots of button pushing!
3452017-10-26T19:16:21  <meshcollider> lol
3462017-10-26T19:16:23  <wumpus> well we have some fixes on the 0.15 branch already that are nice
3472017-10-26T19:16:24  <BlueMatt> heh
3482017-10-26T19:16:34  <wumpus> but I agree it kind of misses the point
3492017-10-26T19:16:39  <BlueMatt> wumpus: anything worth an 0.15.0.2?
3502017-10-26T19:17:05  <wumpus> BlueMatt: well it's a minor-minor release, that's not a high bar, but yes
3512017-10-26T19:17:19  <BlueMatt> I mean things like #11531, which may be important as far as our b2x-shitshow fixes go, are smack-dab in the middle of consensus code and have not review yet?
3522017-10-26T19:17:21  <gribble> https://github.com/bitcoin/bitcoin/issues/11531 | Check that new headers are not a descendant of an invalid block (more effeciently) by TheBlueMatt · Pull Request #11531 · bitcoin/bitcoin · GitHub
3532017-10-26T19:17:24  <wumpus> BlueMatt: nothing that warrants hurring it though
3542017-10-26T19:17:37  *** Cheeseo has joined #bitcoin-core-dev
3552017-10-26T19:17:44  <BlueMatt> I suppose it may be worth it to get an 0.15.0.2 out like day-before b2x-shitshow
3562017-10-26T19:17:58  <gmaxwell> even a small portion of the network running it is protective.
3572017-10-26T19:18:00  <BlueMatt> then at least if some asshat spins up a billion stupid sybil nodes there is a response
3582017-10-26T19:18:12  <morcos> BlueMatt: +1
3592017-10-26T19:18:20  <BlueMatt> but we need to be clear what our target is here
3602017-10-26T19:18:22  <gmaxwell> at least if we cover the major possible cases:  Fork has low to no hashpower, fork has higher hashpower for the case where we're completely partitioned by surrounded by forknodes or where we're partially surrounded.
3612017-10-26T19:18:23  <BlueMatt> and really focus on it
3622017-10-26T19:18:29  <BlueMatt> there hasnt been much progress the last 3 weeks
3632017-10-26T19:18:45  <BlueMatt> (I'm to blame there, too, I've been mostly mia)
3642017-10-26T19:18:46  <gmaxwell> I think there has been a lot of progress.
3652017-10-26T19:18:53  *** jb55 has quit IRC
3662017-10-26T19:18:59  <gmaxwell> sdaftuar has been right on top of making changes.
3672017-10-26T19:19:07  <BlueMatt> sorry, lots of progress on making new prs, rewriting prs, talking about issues, lack of *merge* progress
3682017-10-26T19:19:14  <wumpus> yes there absolutely has been a lot of progress, PR after PR
3692017-10-26T19:19:15  <BlueMatt> or finalizing review for things to get merged
3702017-10-26T19:19:25  <wumpus> but very little merging, yeah
3712017-10-26T19:19:38  <morcos> have we finalized the list
3722017-10-26T19:19:43  <morcos> lets focus on that
3732017-10-26T19:19:55  <morcos> and then everyone commit to reviewing 2 of them over the next 24 hours
3742017-10-26T19:19:58  <BlueMatt> well one thing on it was opened today cause it was decided to also be important/replace other things
3752017-10-26T19:19:58  <morcos> and we'll see where we stand
3762017-10-26T19:20:05  <wumpus> no, it seems to change every week
3772017-10-26T19:20:11  <morcos> wumpus: exactly
3782017-10-26T19:20:18  <BlueMatt> but, yea, I think if we want to see hhis happen, we can get it out day-or-two-before-ish, but we need review *today*
3792017-10-26T19:20:25  <cfields> agree with gmaxwell about focusing on those things that may actually be of significance in the next month
3802017-10-26T19:20:26  <wumpus> as cfieds said it's hard to keep track of
3812017-10-26T19:20:35  <BlueMatt> I think they're all tagged now, no?
3822017-10-26T19:20:40  <gmaxwell> To get the full coverage of those sets of cases, we need 11490, 11560, and 11568-or-11446
3832017-10-26T19:20:45  <morcos> focus... BlueMatt, sipa, gmaxwell, sdaftuar you guys have been thinking abou tthis the most... look at the list right now and be confident it is right and if not fix it
3842017-10-26T19:20:48  <BlueMatt> except #10593, ignore that
3852017-10-26T19:20:50  <gribble> https://github.com/bitcoin/bitcoin/issues/10593 | Relax punishment for peers relaying invalid blocks and headers by luke-jr · Pull Request #10593 · bitcoin/bitcoin · GitHub
3862017-10-26T19:20:52  <achow101> I think we can remove 10593
3872017-10-26T19:21:00  <morcos> stop arguing with Belshe on the web
3882017-10-26T19:21:06  <sdaftuar> :)
3892017-10-26T19:21:24  <wumpus> ok removed 10593
3902017-10-26T19:21:25  <BlueMatt> yea, 10593 got nack'ed (correctly, imo) a while ago
3912017-10-26T19:21:29  <gmaxwell> 11490 covers the case where fork has lower hashpower and doesn't completely surround you,  11560 covers where it has higher hashpower, 11568-or-11446 covers where it has lower and may completely surround you.
3922017-10-26T19:21:36  <luke-jr> does something else cover the cases 10593 does?
3932017-10-26T19:21:57  <rafalcpp> sorry if stupid question,  but re   `semOutbound = new CSemaphore(std::min((nMaxOutbound + nMaxFeeler + nMaxExtraOutbound), nMaxConnections));`   if we're at nMaxOutbound == nMaxConnections  doesn't it mean node in such conditin will not try to resolve being stalled?  dunno if that's any issue
3942017-10-26T19:22:03  <morcos> luke-jr: explicit case you're worried about not being covered (soft forks? , we can worry abou tthose later)
3952017-10-26T19:22:04  <BlueMatt> luke-jr: tbh, I dont actually have any fucking clue what that pr is *supposed* to do in the context on b2x-shitshow
3962017-10-26T19:22:09  <achow101> rafalcpp: not now
3972017-10-26T19:22:29  <sdaftuar> rafalcpp: let's discuss after (thanks for taking a look!)
3982017-10-26T19:22:36  <BlueMatt> rafalcpp: sorry, mid-meeting atm
3992017-10-26T19:22:44  <morcos> rafalcpp: hi
4002017-10-26T19:23:01  <gmaxwell> achow101: that was related to the PR that adds an extra connection
4012017-10-26T19:23:10  <luke-jr> morcos: Bitcoin is almost a softfork relative to 2X
4022017-10-26T19:23:28  <luke-jr> BlueMatt: it is necessary for people to switch from 2X to Bitcoin, or run them both
4032017-10-26T19:23:32  *** IniGit has joined #bitcoin-core-dev
4042017-10-26T19:23:46  <IniGit> hello
4052017-10-26T19:23:48  <BlueMatt> luke-jr: you cannot switch back and forth, your blockindex will be corrupt (yay shitty fork developers)
4062017-10-26T19:24:00  <IniGit> I read the whitepaper of ethereum and I have a question (it is the same for bitcoin):
4072017-10-26T19:24:00  <IniGit> APPLY(S,TX) -> S'
4082017-10-26T19:24:00  <IniGit> My question is since S is defined as a set of UTXO, but the blockchain does not store each balance in a block, is this set of UTXO only preset in RAM and not on the blockchain. Is it calculated by the node by going thhrough each block since the genesis block and only present in RAM?
4092017-10-26T19:24:00  <luke-jr> BlueMatt: different datadirs..
4102017-10-26T19:24:12  <luke-jr> or even different machines
4112017-10-26T19:24:14  <wumpus> IniGit: not here, not now
4122017-10-26T19:24:18  <morcos> luke-jr has a bit of a point there
4132017-10-26T19:24:30  <gmaxwell> luke-jr: it's unclear of specifically what you're turned about, don't get into an argument in the weeds, state what the overall concern is.
4142017-10-26T19:24:43  <IniGit> where can I ask this question and get more knowledge?
4152017-10-26T19:24:52  <gmaxwell> IniGit: #bitcoin
4162017-10-26T19:24:53  <sdaftuar> are we talking about relaxing bans to be disconnects instead?  i generally agree with that
4172017-10-26T19:24:55  <BlueMatt> luke-jr: tbh, so what? our banning is deliberately slow, if you get banned from some small percentage of the network, slowly, over time, for running 2x, sucks for you
4182017-10-26T19:24:56  <morcos> gmaxwell: if someone on your IP runs a 2X node, your IP gets banned, and you cna't then run or simulataneiously run a core node
4192017-10-26T19:25:02  <luke-jr> gmaxwell: right now, we can peers that send invalid blocks, which means their Bitcoin nodes will get rejected from the p2p network too
4202017-10-26T19:25:06  <BlueMatt> (like one peer per block kinda slow)
4212017-10-26T19:25:06  <achow101> gmaxwell: I think the concern is if someone runs 2x and gets themselves banned, if they switch back to bitcoin they can't connect to the network anymore
4222017-10-26T19:25:22  <luke-jr> ban*
4232017-10-26T19:25:30  <gmaxwell> morcos: nothign we can do about that now regardless; as it's a property of the widely deployed network.
4242017-10-26T19:25:44  <wumpus> achow101: only if *everyone* banned them, which is unlikely as hell!
4252017-10-26T19:25:58  <wumpus> achow101: if a few nodes they were connected to banned them they will certainly find others
4262017-10-26T19:26:04  <luke-jr> wumpus: when 2X gets banned from Peer A, it will move on to Peer B, etc
4272017-10-26T19:26:09  <morcos> gmaxwell: hmm.. ok fair, and it'll take a lot of blocks to get banned by most of the network...
4282017-10-26T19:26:29  <gmaxwell> luke-jr: yes, but this takes longer than a day to cycle through all reachable nodes that way.
4292017-10-26T19:26:30  <luke-jr> gmaxwell: so long as not all peers ban, they will eventually find ones with the newer code..
4302017-10-26T19:26:31  <morcos> luke-jr's pull should be maybe considered for soon release, in case there is extended period of two chains
4312017-10-26T19:26:34  *** quantbot has joined #bitcoin-core-dev
4322017-10-26T19:26:35  <karelb> sorry for breaking in, the plan is that you cannot simultaneously run 2x and btc on the same IP? that is unfortunate
4332017-10-26T19:26:40  <morcos> but maybe 0.15.1 espeically if its not ready yet
4342017-10-26T19:26:47  <wumpus> gmaxwell: and by that time the first ones will have unbanned them again
4352017-10-26T19:26:49  *** BashCo has quit IRC
4362017-10-26T19:26:51  <luke-jr> gmaxwell: even with the peers banning them?
4372017-10-26T19:27:04  <morcos> karelb: that's not the plan, thats an unfortunate side effect of the existing software
4382017-10-26T19:27:10  <gmaxwell> luke-jr: yes, because the banning goes slowly.
4392017-10-26T19:27:38  <gmaxwell> karelb: 2x foolishly connects to non-2x nodes and will relay them invalid blocks, so it will get itself banned.
4402017-10-26T19:27:42  <achow101> banning also requires blocks to be found, so ...
4412017-10-26T19:28:17  <achow101> that means 144 peers to switch through per day, on average
4422017-10-26T19:28:39  <luke-jr> gmaxwell: just because it hits 20% DoS penalty each header?
4432017-10-26T19:28:46  <wumpus> karelb: it could have been resolved with e.g. service bits if 2x was willing, but they're insisting on making this a mess, so we have to do the least harmful thing for the existing bitcoin network
4442017-10-26T19:28:48  <karelb> oh OK. That happens with the current core node
4452017-10-26T19:28:53  <BlueMatt> karelb: if you run 2x nodes without their broken -pretendimnot2x then no, you cannot, if you dont use that option, you should be fine
4462017-10-26T19:28:57  <gmaxwell> karelb: yes.
4472017-10-26T19:29:18  <wumpus> BlueMatt: exactly
4482017-10-26T19:29:23  <karelb> BlueMatt  👍  great
4492017-10-26T19:29:36  <BlueMatt> (which is another point against 10593)
4502017-10-26T19:29:39  <gmaxwell> luke-jr: also as matt points out, if you don't undermine service flag disconnects you won't get banned by bitcoin 0.15+ peers, so I think that answers your concern/.
4512017-10-26T19:29:45  <luke-jr> ok
4522017-10-26T19:30:10  <BlueMatt> if you run with -imstupidandignorereason, you should get banned, thats your problem, not mine
4532017-10-26T19:30:12  <karelb> what would be the reason of running that option? what is the incentive for the 2x node to connect to core nodes?
4542017-10-26T19:30:25  <gmaxwell> in the long run I want to move away from banning more or less entirely but that isn't a thing to worry about for now.
4552017-10-26T19:30:26  <BlueMatt> karelb: please not mid-meeting
4562017-10-26T19:30:28  <karelb> ok
4572017-10-26T19:30:30  <morcos> ok yes, thats a good point that we should publish, unfortunately lots of companies will need to run both
4582017-10-26T19:30:30  <karelb> sorry
4592017-10-26T19:30:53  <BlueMatt> gmaxwell: lots to be fixed in our dos/ban/disconnect logic, indeed
4602017-10-26T19:31:12  <morcos> ok back to question... list is good, please ack if you know what you're talking about.   alex was here.
4612017-10-26T19:31:20  <sdaftuar> getting back to 0.15.0.2 -- i think the currently tagged PRs cover all the cases i think we would ideally cover pre-b2x
4622017-10-26T19:31:24  <achow101> list looks good to me
4632017-10-26T19:31:35  <wumpus> sdaftuar: great!
4642017-10-26T19:31:46  <gmaxwell> What sdaftuar said
4652017-10-26T19:31:50  <wumpus> let's focus on getting these reviewed and merged as soon as possible then
4662017-10-26T19:31:56  <achow101> +1
4672017-10-26T19:31:57  <wumpus> and lot's not add any new ones unless absolutely necessary
4682017-10-26T19:32:19  <gmaxwell> unless some interesting bug crops up I don't see why we would.
4692017-10-26T19:32:24  <meshcollider> Sounds good
4702017-10-26T19:32:26  <BlueMatt> ok, so #action 24-hour review sprint?
4712017-10-26T19:32:36  <gmaxwell> like maybe B2X's developer tells us about this mysterious instability in 0.15. :)
4722017-10-26T19:32:53  <morcos> i can't wait to tell them about my embargoed accidental hard fork
4732017-10-26T19:33:00  <BlueMatt> gmaxwell: lol, uh huhhhhh
4742017-10-26T19:33:55  <luke-jr> FTR, the problematic option is -advertise2x=0 or -noadvertise2x
4752017-10-26T19:34:21  <BlueMatt> aka -shootmeinthefacekthx
4762017-10-26T19:34:24  <cfields> BlueMatt: i'll commit to a 24hr sprint, at least ack/nack/cfields was here on all of those PRs.
4772017-10-26T19:34:56  <wumpus> I'll try
4782017-10-26T19:34:57  <gmaxwell> I'll test and review all that I haven't yet, of course.
4792017-10-26T19:35:15  <BlueMatt> ok, just gotta finish caching debug.log writing on fibre nodes then I'll do it
4802017-10-26T19:35:31  <BlueMatt> 30+ms pauses fron debug.log prints, ftr...........
4812017-10-26T19:35:42  <gmaxwell> BlueMatt: we could also release note this point-- that running -shootmeinthefacekthx will cause your IP to get banned by bitcoin nodes when the fork happens and make it harder to switch back or run both.
4822017-10-26T19:35:52  <gmaxwell> so uh. I hate to do this.
4832017-10-26T19:35:54  <gmaxwell> but
4842017-10-26T19:35:58  <achow101> oh no
4852017-10-26T19:36:27  <gmaxwell> ... I believe a one liner is possible to detect if our chainstate DB has been corrupted by running b2x post fork... would it be worthwhile to have that?
4862017-10-26T19:36:44  <gmaxwell> e.g. check out block at the fork height and see if its too big.
4872017-10-26T19:36:47  <kanzure> detect and warn?
4882017-10-26T19:36:54  <wumpus> yes, that would be worth it
4892017-10-26T19:36:58  <gmaxwell> and then shut down with a polite fuck you instead of just sitting stuck.
4902017-10-26T19:37:03  <kanzure> detect and exit?
4912017-10-26T19:37:06  <wumpus> yes
4922017-10-26T19:37:08  <BlueMatt> yea, I think so :'(
4932017-10-26T19:37:10  <cfields> gmaxwell: that sounds like exactly the kind of thing we should be aiming for in 0.15.0.2 :(
4942017-10-26T19:37:13  <gmaxwell> all we can do is exit and tell you to reindex.
4952017-10-26T19:37:15  <achow101> I guess..
4962017-10-26T19:37:17  <morcos> in my opinion it'll be more than 24 hours until we agree if a 1-liner makes sense.  i think we should just tell people you must reindex chainstate if you switch back...
4972017-10-26T19:37:18  <jnewbery> polite fuck you == "please use invalidateblock RPC" ?
4982017-10-26T19:37:19  <BlueMatt> i guess at least thats easy to review
4992017-10-26T19:37:28  <luke-jr> gmaxwell: why shut down? we can already rewind..
5002017-10-26T19:37:29  <gmaxwell> oaky I'm sorry for the scope creep. It should be a near oneliner.
5012017-10-26T19:37:40  <luke-jr> jnewbery: need to automatic it, because RPC won't work if we shutdown
5022017-10-26T19:37:49  <BlueMatt> jnewbery: no, I think probably easier to just printf("please reindex") exit();
5032017-10-26T19:37:56  *** pavle has joined #bitcoin-core-dev
5042017-10-26T19:37:57  <wumpus> that's more work
5052017-10-26T19:37:59  <gmaxwell> it's not easy to test unfortunately.
5062017-10-26T19:38:04  <luke-jr> BlueMatt: we already have code to rewind for segwit rechecking
5072017-10-26T19:38:05  <wumpus> for master it probably makes sense to make it automatic
5082017-10-26T19:38:10  <wumpus> but that's not realistic for 0.15.0.2
5092017-10-26T19:38:13  <BlueMatt> yea, i dont want to test any of this, or think about complicated interactions
5102017-10-26T19:38:17  <BlueMatt> just printf and exit
5112017-10-26T19:38:21  <wumpus> as gmaxwell says, warn+exit is better than mystieriously getting stuck
5122017-10-26T19:38:23  <wumpus> that's the aim here
5132017-10-26T19:38:36  <achow101> I support the thing that requires less work to review
5142017-10-26T19:38:54  <sdaftuar> i don't know that i think it's worth it, but i don't object i guess if other people want to add this "feature"
5152017-10-26T19:39:11  <gmaxwell> okay, I'll do the simplest possible first we could also consider others for master/later/etc...
5162017-10-26T19:39:15  <BlueMatt> morcos: points out this does not work on a pruned node, i forgot about that....
5172017-10-26T19:39:18  <wumpus> sdaftuar: less mysterious bug reports...
5182017-10-26T19:39:22  <wumpus> sdaftuar: that's always a plus
5192017-10-26T19:39:30  <morcos> can we agree that this extra PR is lower priority than the others, lets not risk getting 0 of them out
5202017-10-26T19:39:39  <gmaxwell> SURE
5212017-10-26T19:39:40  <wumpus> morcos: I agree with that too
5222017-10-26T19:39:55  <gmaxwell> I don't even 'want' it so much as I realized it was a problem people will encounter which we could address.
5232017-10-26T19:39:56  <wumpus> I think it's worth doing in general, don't care if it doesn't get into 0.15.0.2
5242017-10-26T19:39:57  <morcos> tag it "Extra Credit"
5252017-10-26T19:40:05  <sdaftuar> haha sounds good to me
5262017-10-26T19:40:13  <wumpus> fine for 0.15.1 too
5272017-10-26T19:40:20  <wumpus> heh
5282017-10-26T19:40:26  *** spudowiar has joined #bitcoin-core-dev
5292017-10-26T19:40:34  <gmaxwell> well I'll try something. decide if you want to review it or not.
5302017-10-26T19:40:40  <kanzure> might make sense for flip floppers later
5312017-10-26T19:41:08  <gmaxwell> after the fork it can just hardcode the hash. :)
5322017-10-26T19:41:17  <wumpus> yep
5332017-10-26T19:41:29  <gmaxwell> e.g. like doing an invalidateblock <b2xcrap> at startup.
5342017-10-26T19:42:18  <gmaxwell> I agree it's certantly less important in part because we can address with announcements/release notes-- don't do this.
5352017-10-26T19:42:42  * sipa here for a minute
5362017-10-26T19:43:02  <BlueMatt> sipa: we're doing 24 hour code review spring for 0.15.0.2, you owe us review on 4 prs today! :p
5372017-10-26T19:43:53  <sipa> BlueMatt: i'll try!
5382017-10-26T19:44:11  *** fengling_ has quit IRC
5392017-10-26T19:44:15  <achow101> not just 4 PRs, the 4 PRs tagged for 0.15.0.2
5402017-10-26T19:45:46  <luke-jr> we could make a BLOCK_OPT_WITNESS-like thing and require it for the 2X height block only.. but that'll break normal upgrades too
5412017-10-26T19:45:51  <luke-jr> not sure it's worth it
5422017-10-26T19:46:01  <spudowiar> Which PRs are those? https://github.com/bitcoin/bitcoin/projects/8 shows one PR under "Review priority for 0.15.0.2"
5432017-10-26T19:46:11  <achow101> spudowiar: https://github.com/bitcoin/bitcoin/milestone/32
5442017-10-26T19:46:16  <wumpus> spudowiar: just use the milestone https://github.com/bitcoin/bitcoin/milestone/32
5452017-10-26T19:46:20  <spudowiar> Thanks, sorry
5462017-10-26T19:46:35  <wumpus> yeah no problem, I'll update review priority too
5472017-10-26T19:47:01  <achow101> other topics?
5482017-10-26T19:49:15  <wumpus> apparently not
5492017-10-26T19:49:16  <achow101> In other news, I got someone to write meeting notes for the website. we'll try to get through all of the meetings missed too
5502017-10-26T19:49:26  <wumpus> achow101: that's great news!
5512017-10-26T19:49:33  <meshcollider> \o/
5522017-10-26T19:50:00  *** jb55 has joined #bitcoin-core-dev
5532017-10-26T19:50:07  <gmaxwell> bad news is that the someone is roger ver.
5542017-10-26T19:50:12  <gmaxwell> :P
5552017-10-26T19:50:23  <achow101> lol. no
5562017-10-26T19:50:24  <wumpus> hahahaha
5572017-10-26T19:50:59  <luke-jr> XD
5582017-10-26T19:51:02  *** d9b4bef9 has quit IRC
5592017-10-26T19:51:10  <luke-jr> achow101: you've checked?
5602017-10-26T19:51:25  <meshcollider> Comic relief would be the whole meeting notes
5612017-10-26T19:51:37  <achow101> luke-jr: unless I am blind, I am pretty sure the person writing the notes next to me is roger ver
5622017-10-26T19:51:43  <achow101> *is not
5632017-10-26T19:51:47  <gmaxwell> uh oh.
5642017-10-26T19:51:52  <luke-jr> achow101: maybe on his payroll :P
5652017-10-26T19:52:07  * gmaxwell imagines the delayed correction coming after a sharp poke to the ribs
5662017-10-26T19:52:08  *** d9b4bef9 has joined #bitcoin-core-dev
5672017-10-26T19:52:11  <achow101> now we got our comic relief :p
5682017-10-26T19:52:51  <wumpus> #endmeeting
5692017-10-26T19:52:51  <lightningbot> Meeting ended Thu Oct 26 19:52:51 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5702017-10-26T19:52:51  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-26-19.00.html
5712017-10-26T19:52:51  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-26-19.00.txt
5722017-10-26T19:52:51  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-10-26-19.00.log.html
5732017-10-26T19:53:02  <sdaftuar> ico time?
5742017-10-26T19:53:38  <BlueMatt> sdaftuar: wait, we cant both ICO, I'm ICOing first!
5752017-10-26T19:53:39  <gmaxwell> ICO time.
5762017-10-26T19:53:55  <gmaxwell> pretty sure everyone can ICO, theres is like an app for it or something.
5772017-10-26T19:54:06  <clarkmoody> When your One More Thing (TM) comes from gmaxwell ...
5782017-10-26T19:54:11  <sdaftuar> rafalcpp: if you had questions about #11560 i'd be happy to discuss
5792017-10-26T19:54:12  <gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub
5802017-10-26T19:54:14  <gmaxwell> I heard about it in an email with the subject lime "Make Money Fast".
5812017-10-26T19:54:22  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf8c4a7633b1...d93fa261f079
5822017-10-26T19:54:23  <bitcoin-git> bitcoin/master c60fd71 Suhas Daftuar: Disconnecting from bad outbound peers in IBD...
5832017-10-26T19:54:24  <bitcoin-git> bitcoin/master 5a6d00c Suhas Daftuar: Permit disconnection of outbound peers on bad/slow chains...
5842017-10-26T19:54:24  <bitcoin-git> bitcoin/master e065249 Suhas Daftuar: Add unit test for outbound peer eviction
5852017-10-26T19:54:25  <achow101> mmm. subject limes
5862017-10-26T19:54:27  <cfields> gmaxwell: it matters who's first though. If only we had some way to trustlessly timestamp things...
5872017-10-26T19:54:31  <luke-jr> ICO is just scamcoins 2.0; BlueMatt once had a generator..
5882017-10-26T19:54:33  <sdaftuar> wumpus: thanks!
5892017-10-26T19:54:41  <esotericnonsense> gmaxwell: well the title isn't wrong.
5902017-10-26T19:54:42  <sdaftuar> rebase time...
5912017-10-26T19:54:46  <rafalcpp> sdaftuar: right, it's the question that was posted above
5922017-10-26T19:54:58  * esotericnonsense wanders off to 'make some money' on regtest
5932017-10-26T19:55:06  <gmaxwell> cfields: it could be a device that ticks at a regular interval
5942017-10-26T19:55:10  <bitcoin-git> [bitcoin] laanwj closed pull request #11490: Disconnect from outbound peers with bad headers chains (master...2017-10-outbound-peers-good-chain) https://github.com/bitcoin/bitcoin/pull/11490
5952017-10-26T19:55:19  <maaku> esotericnonsense: don't you go monetizing regtest coins!
5962017-10-26T19:55:20  *** jb55 has quit IRC
5972017-10-26T19:55:46  <sdaftuar> nMaxConnections is generally much larger than nMaxOutbound, but yes if someone set nMaxConnections very low, then i think that could cause issues.  but that's no different eg than running with -connect= or something, i think?
5982017-10-26T19:56:00  <sdaftuar> rafalcpp: ie if you run with non-standard p2p config, then i think you could run into issues... maybe worth release noting?
5992017-10-26T19:56:16  <cfields> gmaxwell: 15 seconds? :p
6002017-10-26T19:57:07  <luke-jr> btw, the advertise2x warning seems more appropriate for a blog post than release notes, since it has nothing to do with our release
6012017-10-26T19:57:20  <meshcollider> Only 3 PRs left to review now :)
6022017-10-26T19:57:23  <rafalcpp> sdaftuar: dunno, maybe? :) I didn't yet developed on bitcoin.  Wouldn't it be possible to increase both sides of min?
6032017-10-26T19:58:51  <gmaxwell> luke-jr: well I dunno the release note is "if you plan on using this program with that program on the same computer"
6042017-10-26T19:58:59  <rafalcpp> though then we're skipping check for system limit of connections so maybe not. sdaftuar
6052017-10-26T19:59:04  <sdaftuar> rafalcpp: i think it makes more sense for the user to continue to have a toggle for the overall number of connections, and just explain what the consequence is
6062017-10-26T19:59:09  <luke-jr> gmaxwell: it's also true for older releases of ours though
6072017-10-26T19:59:33  <gmaxwell> if we have a zillion inbound connections we probably don't need the anti-partition rotation anyways.
6082017-10-26T19:59:34  <wumpus> meshcollider: review is still welcome after something is merged :)
6092017-10-26T19:59:43  *** promag has quit IRC
6102017-10-26T20:02:43  *** notmike has joined #bitcoin-core-dev
6112017-10-26T20:02:53  <notmike> Its time. I'm ready.
6122017-10-26T20:04:07  <rafalcpp> sdaftuar: to me a release note sounds good. unless also logging a warning when it happens, if that code isn't frozen
6132017-10-26T20:07:42  *** jb55 has joined #bitcoin-core-dev
6142017-10-26T20:07:57  *** promag has joined #bitcoin-core-dev
6152017-10-26T20:17:02  *** jb55 has quit IRC
6162017-10-26T20:20:40  *** jb55 has joined #bitcoin-core-dev
6172017-10-26T20:25:37  *** jb55 has quit IRC
6182017-10-26T20:26:15  *** laurentmt has quit IRC
6192017-10-26T20:29:43  *** BashCo has joined #bitcoin-core-dev
6202017-10-26T20:31:00  *** promag has quit IRC
6212017-10-26T20:31:47  *** tripleslash has joined #bitcoin-core-dev
6222017-10-26T20:32:31  *** cheese_ has joined #bitcoin-core-dev
6232017-10-26T20:33:37  *** RoyceX has joined #bitcoin-core-dev
6242017-10-26T20:35:51  *** Cheeseo has quit IRC
6252017-10-26T20:36:51  *** cheese_ has quit IRC
6262017-10-26T20:39:23  *** Stephanzf has joined #bitcoin-core-dev
6272017-10-26T20:39:46  *** alreadylate has joined #bitcoin-core-dev
6282017-10-26T20:48:40  *** alreadylate has quit IRC
6292017-10-26T20:50:40  *** Stephanzf has quit IRC
6302017-10-26T20:51:04  *** promag has joined #bitcoin-core-dev
6312017-10-26T20:54:22  *** IniGit1 has joined #bitcoin-core-dev
6322017-10-26T20:55:28  *** IniGit has quit IRC
6332017-10-26T20:57:26  *** RubenSomsen has quit IRC
6342017-10-26T21:02:24  *** alreadylate has joined #bitcoin-core-dev
6352017-10-26T21:05:13  *** clarkmoody has quit IRC
6362017-10-26T21:06:12  *** BashCo has quit IRC
6372017-10-26T21:06:37  *** Chris_Stewart_5 has quit IRC
6382017-10-26T21:06:43  *** Guyver2 has quit IRC
6392017-10-26T21:07:24  *** BashCo has joined #bitcoin-core-dev
6402017-10-26T21:11:50  *** BashCo has quit IRC
6412017-10-26T21:14:20  *** promag has quit IRC
6422017-10-26T21:14:41  *** jb55 has joined #bitcoin-core-dev
6432017-10-26T21:16:30  *** warxhead has joined #bitcoin-core-dev
6442017-10-26T21:16:34  *** wxss has quit IRC
6452017-10-26T21:16:54  *** maaku has left #bitcoin-core-dev
6462017-10-26T21:22:09  *** otium has joined #bitcoin-core-dev
6472017-10-26T21:25:29  *** notmike has left #bitcoin-core-dev
6482017-10-26T21:35:08  *** IniGit1 has quit IRC
6492017-10-26T21:40:25  *** alreadylate has quit IRC
6502017-10-26T21:49:57  *** jb55 has quit IRC
6512017-10-26T21:50:02  *** PaulCapestany has joined #bitcoin-core-dev
6522017-10-26T21:51:52  *** wxss has joined #bitcoin-core-dev
6532017-10-26T21:55:05  *** jb55 has joined #bitcoin-core-dev
6542017-10-26T22:01:19  *** Squidicc has joined #bitcoin-core-dev
6552017-10-26T22:04:27  *** Squidicuz has quit IRC
6562017-10-26T22:05:02  *** Squidicc is now known as squidicuz
6572017-10-26T22:06:05  *** spudowiar has quit IRC
6582017-10-26T22:09:36  *** cheese_ has joined #bitcoin-core-dev
6592017-10-26T22:17:08  <bitcoin-git> [bitcoin] jnewbery reopened pull request #10160: [WIP] updatepeer RPC (master...updatepeer) https://github.com/bitcoin/bitcoin/pull/10160
6602017-10-26T22:21:31  *** Cogito_Ergo_Sum has quit IRC
6612017-10-26T22:22:01  *** pavle has quit IRC
6622017-10-26T22:31:08  *** jb55 has quit IRC
6632017-10-26T22:33:15  *** jb55 has joined #bitcoin-core-dev
6642017-10-26T22:51:58  *** JackH has quit IRC
6652017-10-26T22:52:56  *** JackH has joined #bitcoin-core-dev
6662017-10-26T23:05:49  *** mxg has joined #bitcoin-core-dev
6672017-10-26T23:06:14  *** JackH has quit IRC
6682017-10-26T23:07:47  *** mxg has quit IRC
6692017-10-26T23:10:48  *** Giszmo has joined #bitcoin-core-dev
6702017-10-26T23:15:28  *** vicenteH has quit IRC
6712017-10-26T23:17:57  *** jb55 has quit IRC
6722017-10-26T23:22:33  *** JackH has joined #bitcoin-core-dev
6732017-10-26T23:25:03  *** RoyceX has quit IRC
6742017-10-26T23:27:42  *** cheese_ has quit IRC
6752017-10-26T23:29:57  *** warxhead has quit IRC
6762017-10-26T23:34:25  *** JackH has quit IRC
6772017-10-26T23:39:16  *** BashCo has joined #bitcoin-core-dev
6782017-10-26T23:42:59  *** JackH has joined #bitcoin-core-dev
6792017-10-26T23:46:09  *** Emcy_ has joined #bitcoin-core-dev
6802017-10-26T23:47:46  *** Emcy has quit IRC
6812017-10-26T23:54:02  *** rafalcpp has quit IRC
6822017-10-26T23:57:50  *** BashCo has quit IRC