12017-10-30T00:07:41  *** Chris_Stewart_5 has quit IRC
  22017-10-30T00:16:52  *** AaronvanW has quit IRC
  32017-10-30T00:20:27  *** jtimon has quit IRC
  42017-10-30T00:23:12  *** wxss has quit IRC
  52017-10-30T00:29:48  *** str4d has quit IRC
  62017-10-30T00:31:18  *** str4d has joined #bitcoin-core-dev
  72017-10-30T00:34:50  *** LumberCartel_ has joined #bitcoin-core-dev
  82017-10-30T00:36:16  *** LumberCartel has quit IRC
  92017-10-30T00:45:06  *** meshcollider has quit IRC
 102017-10-30T00:46:44  *** dc0de has quit IRC
 112017-10-30T00:49:08  *** PaulCapestany has quit IRC
 122017-10-30T00:52:03  *** quantbot has quit IRC
 132017-10-30T00:53:03  *** quantbot has joined #bitcoin-core-dev
 142017-10-30T00:53:21  *** quantbot has quit IRC
 152017-10-30T00:53:49  *** PaulCapestany has joined #bitcoin-core-dev
 162017-10-30T00:54:21  *** quantbot has joined #bitcoin-core-dev
 172017-10-30T00:54:49  *** quantbot has quit IRC
 182017-10-30T00:55:03  *** quantbot has joined #bitcoin-core-dev
 192017-10-30T00:55:53  *** quantbot has joined #bitcoin-core-dev
 202017-10-30T00:56:04  *** grio has joined #bitcoin-core-dev
 212017-10-30T00:56:33  *** quantbot has joined #bitcoin-core-dev
 222017-10-30T00:56:33  *** fanquake has joined #bitcoin-core-dev
 232017-10-30T00:57:39  <fanquake> cfields Could the fact that our GCC func attribute macro is missing the check for fallthrough be contributing to any issues?
 242017-10-30T00:57:55  *** dabura667 has joined #bitcoin-core-dev
 252017-10-30T00:58:54  *** goatpig has quit IRC
 262017-10-30T00:58:55  *** fanquake has quit IRC
 272017-10-30T00:58:57  *** LumberCartel_ has quit IRC
 282017-10-30T00:59:21  *** meshcollider has joined #bitcoin-core-dev
 292017-10-30T01:01:19  *** quantbot has quit IRC
 302017-10-30T01:04:59  *** fanquake has joined #bitcoin-core-dev
 312017-10-30T01:29:11  *** ula has quit IRC
 322017-10-30T01:47:31  *** uneeb has joined #bitcoin-core-dev
 332017-10-30T01:52:21  *** quantbot has joined #bitcoin-core-dev
 342017-10-30T01:56:46  *** grio has quit IRC
 352017-10-30T02:09:50  *** warxhead has joined #bitcoin-core-dev
 362017-10-30T02:32:04  *** grio has joined #bitcoin-core-dev
 372017-10-30T02:34:32  *** dermoth has quit IRC
 382017-10-30T02:34:57  *** dermoth has joined #bitcoin-core-dev
 392017-10-30T02:39:35  *** jb55 has joined #bitcoin-core-dev
 402017-10-30T03:10:30  <cluelessperson> ;;blocks
 412017-10-30T03:10:30  <gribble> 492291
 422017-10-30T03:10:34  <cluelessperson> WOOT
 432017-10-30T03:10:40  <cluelessperson> first pruned up up
 442017-10-30T03:12:26  <cluelessperson> looks like a pruned node of 550 MB took me from 2017-10-29 21:37:55 to 2017-10-30 03:10:21 to sync.
 452017-10-30T03:14:20  <esotericnonsense> \o/
 462017-10-30T03:14:45  <cluelessperson> End pruned size, 3.6 GB
 472017-10-30T03:15:07  <cluelessperson> 508Mblocks
 482017-10-30T03:15:14  <cluelessperson> 3.0Gchainstate
 492017-10-30T03:15:26  <cluelessperson> 115Mdebug.log
 502017-10-30T03:16:24  <esotericnonsense> cluelessperson: if the log is not sensitive it might be useful for https://github.com/bitcoin/bitcoin/pull/11359
 512017-10-30T03:16:58  <esotericnonsense> this PR does not seem popular (sdaftuar's comments on flushes will likely lead to a better solution)
 522017-10-30T03:17:21  <esotericnonsense> but from the log file it should be possible to guess at time wasted :)
 532017-10-30T03:21:33  <cluelessperson> esotericnonsense: These are just tests pointed at the localhost node, on a PCISSD, so yeah, I can share
 542017-10-30T03:21:44  <cluelessperson> esotericnonsense: you want me to just attach the log file to that link?
 552017-10-30T03:22:07  <esotericnonsense> cluelessperson: re your chat in #bitcoin if you actually want to and have time it would be nice to see a benchmark of non-pruning sync time against the same target (e.g. without network node variance)
 562017-10-30T03:22:21  <esotericnonsense> sure maybe gzip it or something though :P
 572017-10-30T03:23:09  <cluelessperson> esotericnonsense: to summarize agreed point, you'd like me to resync under the same conditions, without pruning?
 582017-10-30T03:23:19  <cluelessperson> esotericnonsense: allowing you to view pruned and non-pruned results?
 592017-10-30T03:23:45  <esotericnonsense> yeah. it's not that important, I already know the results, i'm just interested in precisely how much fastr it ends up being
 602017-10-30T03:23:47  <esotericnonsense> faster*
 612017-10-30T03:24:59  <cluelessperson> esotericnonsense: how much faster pruning ends up being? or not pruning ends up being than pruned?
 622017-10-30T03:25:07  <cluelessperson> and GO!
 632017-10-30T03:25:09  <cluelessperson> it's running
 642017-10-30T03:25:31  <esotericnonsense> cluelessperson: not pruning should be faster because the utxo cache gets flushed completely on every prune event
 652017-10-30T03:25:44  <esotericnonsense> which is every ~128mb
 662017-10-30T03:25:50  <cluelessperson> ah
 672017-10-30T03:26:37  <cluelessperson> esotericnonsense: for the record, these are my settings https://hastebin.com/raw/povagogajo
 682017-10-30T03:27:26  <cluelessperson> esotericnonsense: I have the dbcache set to 10000
 692017-10-30T03:30:36  <cluelessperson> esotericnonsense: it looks faster
 702017-10-30T03:31:55  <esotericnonsense> it won't make much difference until you get a sizeable dbcache but yeah it is faster. just wondering whether it's actually say half the time. i killed it at block 200K because I only have one ssd and need the space :P
 712017-10-30T03:32:57  <cluelessperson> esotericnonsense: it's already at 10%
 722017-10-30T03:57:44  *** twistedline has quit IRC
 732017-10-30T04:02:11  *** twistedline has joined #bitcoin-core-dev
 742017-10-30T04:12:16  *** quantbot has quit IRC
 752017-10-30T04:14:00  *** quantbot has joined #bitcoin-core-dev
 762017-10-30T04:35:24  <cluelessperson> esotericnonsense: well, unfortunately, I ran out of space
 772017-10-30T04:35:28  <cluelessperson> esotericnonsense: but it seems WAY faster
 782017-10-30T04:43:13  *** chjj has quit IRC
 792017-10-30T04:44:22  *** LumberCartel has joined #bitcoin-core-dev
 802017-10-30T05:03:41  *** uneeb has quit IRC
 812017-10-30T05:06:27  *** twistedline has quit IRC
 822017-10-30T05:11:36  *** twistedline has joined #bitcoin-core-dev
 832017-10-30T05:14:46  *** adiabat has quit IRC
 842017-10-30T05:15:57  *** twistedline has quit IRC
 852017-10-30T05:20:21  *** twistedline has joined #bitcoin-core-dev
 862017-10-30T05:38:04  *** d9b4bef9 has quit IRC
 872017-10-30T05:39:10  *** d9b4bef9 has joined #bitcoin-core-dev
 882017-10-30T05:49:21  *** grio has quit IRC
 892017-10-30T06:34:01  *** dermoth has quit IRC
 902017-10-30T06:34:26  *** dermoth has joined #bitcoin-core-dev
 912017-10-30T06:36:03  *** thebadguy has joined #bitcoin-core-dev
 922017-10-30T06:38:11  *** thebadguy has quit IRC
 932017-10-30T06:53:03  *** quantbot has quit IRC
 942017-10-30T07:10:25  *** justanotheruser has quit IRC
 952017-10-30T07:11:11  *** ula has joined #bitcoin-core-dev
 962017-10-30T07:13:03  *** sukdctliht has joined #bitcoin-core-dev
 972017-10-30T07:18:04  *** tripleslash has quit IRC
 982017-10-30T07:18:58  *** jouke has quit IRC
 992017-10-30T07:20:32  *** vzjrsrdtsu has joined #bitcoin-core-dev
1002017-10-30T07:20:57  *** ygrkppfmsv has joined #bitcoin-core-dev
1012017-10-30T07:30:30  *** tripleslash has joined #bitcoin-core-dev
1022017-10-30T07:34:23  *** justanotheruser has joined #bitcoin-core-dev
1032017-10-30T07:35:08  *** jouke has joined #bitcoin-core-dev
1042017-10-30T07:41:35  *** jouke has quit IRC
1052017-10-30T07:46:22  *** rlnbbyxnek has joined #bitcoin-core-dev
1062017-10-30T07:53:16  *** mhldybpsda has joined #bitcoin-core-dev
1072017-10-30T07:59:57  *** jouke has joined #bitcoin-core-dev
1082017-10-30T08:11:46  *** AaronvanW has joined #bitcoin-core-dev
1092017-10-30T08:21:03  *** laurentmt has joined #bitcoin-core-dev
1102017-10-30T08:39:54  *** venzen has quit IRC
1112017-10-30T09:15:31  *** Guyver2 has joined #bitcoin-core-dev
1122017-10-30T09:21:03  *** d9b4bef9 has quit IRC
1132017-10-30T09:22:20  *** d9b4bef9 has joined #bitcoin-core-dev
1142017-10-30T09:27:05  *** wxss has joined #bitcoin-core-dev
1152017-10-30T09:33:38  <bitcoin-git> [bitcoin] practicalswift opened pull request #11577: Fix warnings (-Wsign-compare) when building with DEBUG_ADDRMAN (master...DEBUG_ADDRMAN-warnings) https://github.com/bitcoin/bitcoin/pull/11577
1162017-10-30T09:37:20  *** timothy has joined #bitcoin-core-dev
1172017-10-30T09:41:34  *** warxhead has quit IRC
1182017-10-30T09:42:27  *** Emcy_ has quit IRC
1192017-10-30T09:58:17  *** Emcy has joined #bitcoin-core-dev
1202017-10-30T09:59:42  *** intcat has quit IRC
1212017-10-30T10:00:39  *** intcat has joined #bitcoin-core-dev
1222017-10-30T10:12:18  *** promag has joined #bitcoin-core-dev
1232017-10-30T10:23:46  *** dabura667 has quit IRC
1242017-10-30T10:39:07  *** xinxi has quit IRC
1252017-10-30T10:39:41  *** xinxi has joined #bitcoin-core-dev
1262017-10-30T10:40:44  *** m8tion has joined #bitcoin-core-dev
1272017-10-30T11:00:08  *** xinxi has quit IRC
1282017-10-30T11:01:49  *** xinxi has joined #bitcoin-core-dev
1292017-10-30T11:06:02  *** xinxi has quit IRC
1302017-10-30T11:09:12  *** promag has quit IRC
1312017-10-30T11:15:10  *** promag has joined #bitcoin-core-dev
1322017-10-30T11:22:11  *** Aaronvan_ has joined #bitcoin-core-dev
1332017-10-30T11:22:36  *** Aaronvan_ is now known as AaronvanW_
1342017-10-30T11:25:07  *** AaronvanW has quit IRC
1352017-10-30T11:31:59  *** quantbot has joined #bitcoin-core-dev
1362017-10-30T11:32:22  *** xinxi has joined #bitcoin-core-dev
1372017-10-30T11:34:38  *** mmgen has joined #bitcoin-core-dev
1382017-10-30T11:36:32  *** quantbot has quit IRC
1392017-10-30T11:39:20  *** pergaminho has joined #bitcoin-core-dev
1402017-10-30T11:47:57  *** str4d has quit IRC
1412017-10-30T11:52:04  *** m8tion has quit IRC
1422017-10-30T11:52:54  *** str4d has joined #bitcoin-core-dev
1432017-10-30T12:04:57  *** str4d has quit IRC
1442017-10-30T12:06:08  *** Deadhand has quit IRC
1452017-10-30T12:06:16  *** Deadhandd has joined #bitcoin-core-dev
1462017-10-30T12:10:09  *** Deadhandd has quit IRC
1472017-10-30T12:10:56  *** Deadhand has joined #bitcoin-core-dev
1482017-10-30T12:14:25  *** xinxi has quit IRC
1492017-10-30T12:19:10  *** m8tion has joined #bitcoin-core-dev
1502017-10-30T12:22:37  *** xinxi has joined #bitcoin-core-dev
1512017-10-30T12:27:13  *** xinxi has quit IRC
1522017-10-30T12:41:36  *** xinxi has joined #bitcoin-core-dev
1532017-10-30T12:44:05  *** tripleslash has quit IRC
1542017-10-30T12:47:56  *** tripleslash has joined #bitcoin-core-dev
1552017-10-30T12:50:47  *** jtimon has joined #bitcoin-core-dev
1562017-10-30T12:57:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1572017-10-30T13:06:07  *** promag has quit IRC
1582017-10-30T13:21:31  *** pbase has joined #bitcoin-core-dev
1592017-10-30T13:22:28  *** owowo has quit IRC
1602017-10-30T13:25:06  *** meshcollider has quit IRC
1612017-10-30T13:27:36  *** owowo has joined #bitcoin-core-dev
1622017-10-30T13:32:04  *** d9b4bef9 has quit IRC
1632017-10-30T13:32:42  *** promag has joined #bitcoin-core-dev
1642017-10-30T13:33:10  *** quantbot has joined #bitcoin-core-dev
1652017-10-30T13:33:19  *** d9b4bef9 has joined #bitcoin-core-dev
1662017-10-30T13:33:41  *** quantbot has quit IRC
1672017-10-30T13:33:44  *** grio has joined #bitcoin-core-dev
1682017-10-30T13:34:06  *** quantbot has joined #bitcoin-core-dev
1692017-10-30T13:35:03  *** quantbot has joined #bitcoin-core-dev
1702017-10-30T13:36:44  *** mmgen has quit IRC
1712017-10-30T13:36:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #11578: net: Add missing lock in ProcessHeadersMessage(...) (master...ProcessHeadersMessage) https://github.com/bitcoin/bitcoin/pull/11578
1722017-10-30T13:37:31  *** SopaXorzTaker has joined #bitcoin-core-dev
1732017-10-30T13:38:15  *** quantbot has left #bitcoin-core-dev
1742017-10-30T13:40:01  *** promag has quit IRC
1752017-10-30T13:53:47  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1762017-10-30T13:53:47  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1772017-10-30T13:58:49  <bitcoin-git> [bitcoin] gladosconn opened pull request #11579: Fix int uint64_t comparison warning. (master...master) https://github.com/bitcoin/bitcoin/pull/11579
1782017-10-30T14:09:03  *** mmgen has joined #bitcoin-core-dev
1792017-10-30T14:12:10  *** promag has joined #bitcoin-core-dev
1802017-10-30T14:20:57  *** AaronvanW_ is now known as AaronvanW
1812017-10-30T14:27:00  *** JohnDoe_ has joined #bitcoin-core-dev
1822017-10-30T14:28:26  *** LumberCartel_ has joined #bitcoin-core-dev
1832017-10-30T14:30:30  *** quantbot_ has joined #bitcoin-core-dev
1842017-10-30T14:31:02  *** LumberCartel has quit IRC
1852017-10-30T14:31:38  <bitcoin-git> [bitcoin] gladosconn closed pull request #11579: Fix int uint64_t comparison warning. (master...master) https://github.com/bitcoin/bitcoin/pull/11579
1862017-10-30T14:32:03  *** LumberCartel_ has quit IRC
1872017-10-30T14:32:26  *** LumberCartel has joined #bitcoin-core-dev
1882017-10-30T14:33:27  *** wolfspraul has quit IRC
1892017-10-30T14:33:34  *** wolfspraul has joined #bitcoin-core-dev
1902017-10-30T14:36:57  *** grio has quit IRC
1912017-10-30T14:40:12  *** quantbot_ has quit IRC
1922017-10-30T14:40:42  *** quantbot has joined #bitcoin-core-dev
1932017-10-30T14:41:41  *** quantbot has joined #bitcoin-core-dev
1942017-10-30T14:45:37  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11580: Do not send (potentially) invalid headers in response to getheaders (master...2017-10-getheaders-valid-only) https://github.com/bitcoin/bitcoin/pull/11580
1952017-10-30T14:56:49  <wxss> sipa mentioned undocumented -stopatheight here yesterday. Is the opposite possible, to restart downloading at/from a specified block height?
1962017-10-30T14:57:22  <promag> BlueMatt: mapBlockIndex can contain "invalid" blocks (where IsValid(BLOCK_VALID_SCRIPTS) is false)?
1972017-10-30T15:01:35  <sipa> promag: yes, absolutely
1982017-10-30T15:01:43  <sipa> as blocks are only validated after storing them
1992017-10-30T15:01:53  <jimpo> promag: They wouldn't necessarily be "invalid", just not known to be valid.
2002017-10-30T15:02:10  <sipa> mapBlockIndex only guarantees that the *headers* are valid
2012017-10-30T15:02:22  <jimpo> Though I think the index includes invalid blocks as well
2022017-10-30T15:02:31  <sipa> the blocks themselves are downloaded afterwards, and may turn out to be invalid
2032017-10-30T15:02:52  <sipa> jimpo: yes, we store invalid blocks in the index
2042017-10-30T15:03:15  <promag> and once invalid it is kept in the index?
2052017-10-30T15:03:20  <sipa> yes
2062017-10-30T15:03:27  <sipa> the header will be marked as invalid even
2072017-10-30T15:04:13  *** quantbot has quit IRC
2082017-10-30T15:04:36  <promag> so the following can be simplified:
2092017-10-30T15:04:38  <promag> if (punish_duplicate_invalid && mapBlockIndex.find(first_invalid_header.GetHash()) != mapBlockIndex.end())
2102017-10-30T15:04:39  *** quantbot has joined #bitcoin-core-dev
2112017-10-30T15:04:58  <promag> because if the header is invalid then it is not in the block index right?
2122017-10-30T15:05:30  *** quantbot has quit IRC
2132017-10-30T15:05:36  *** quantbot has joined #bitcoin-core-dev
2142017-10-30T15:06:10  <promag> since above you said "mapBlockIndex only guarantees that the *headers* are valid"
2152017-10-30T15:07:05  *** pbase has quit IRC
2162017-10-30T15:07:53  <luke-jr> hmm, is there a good overview of what is needed to add -usehd=0 back in?
2172017-10-30T15:08:18  <BlueMatt> promag: you mean in sdaftuar's pr?
2182017-10-30T15:08:21  <luke-jr> basically just make sure it works without a default key, right?
2192017-10-30T15:08:42  <BlueMatt> promag: no, the point of that check is to see if the header was accepted (ie if it is known to be a valid header)
2202017-10-30T15:09:19  *** quantbot has quit IRC
2212017-10-30T15:09:46  *** quantbot has joined #bitcoin-core-dev
2222017-10-30T15:13:31  *** fanquake has quit IRC
2232017-10-30T15:14:07  *** quantbot has quit IRC
2242017-10-30T15:15:57  <promag> @BlueMatt please correct me if this isn't the same: if (punish_duplicate_invalid && !first_invalid_header.IsNull())
2252017-10-30T15:23:33  *** jb55 has quit IRC
2262017-10-30T15:26:19  *** chjj has joined #bitcoin-core-dev
2272017-10-30T15:35:23  *** Alkhara has quit IRC
2282017-10-30T15:38:03  *** ghost43 has quit IRC
2292017-10-30T15:38:27  *** ghost43 has joined #bitcoin-core-dev
2302017-10-30T15:44:02  *** grio has joined #bitcoin-core-dev
2312017-10-30T15:44:50  *** quantbot has joined #bitcoin-core-dev
2322017-10-30T15:45:46  *** quantbot has joined #bitcoin-core-dev
2332017-10-30T15:58:59  *** LumberCartel has quit IRC
2342017-10-30T16:06:16  *** jb55 has joined #bitcoin-core-dev
2352017-10-30T16:16:56  *** quantbot_ has joined #bitcoin-core-dev
2362017-10-30T16:20:08  *** quantbot has quit IRC
2372017-10-30T16:21:24  *** quantbot_ has quit IRC
2382017-10-30T16:33:23  *** wolfspraul has quit IRC
2392017-10-30T16:33:32  *** wolfspraul has joined #bitcoin-core-dev
2402017-10-30T16:37:52  *** LumberCartel has joined #bitcoin-core-dev
2412017-10-30T16:46:23  *** esotericnonsense has quit IRC
2422017-10-30T16:55:36  *** Chris_Stewart_5 has quit IRC
2432017-10-30T16:56:56  <sdaftuar> can someone tag #11578 for backport to 0.15.0.2?
2442017-10-30T16:56:58  <gribble> https://github.com/bitcoin/bitcoin/issues/11578 | net: Add missing lock in ProcessHeadersMessage(...) by practicalswift · Pull Request #11578 · bitcoin/bitcoin · GitHub
2452017-10-30T17:03:22  *** pergaminho has quit IRC
2462017-10-30T17:03:23  *** jb55 has quit IRC
2472017-10-30T17:04:39  <wumpus> sdaftuar: done
2482017-10-30T17:04:46  <sdaftuar> thanks!
2492017-10-30T17:05:14  *** pergaminho has joined #bitcoin-core-dev
2502017-10-30T17:17:40  <achow101> luke-jr: it has to work without a default key and cannot be downgraded
2512017-10-30T17:18:37  <achow101> promag: the first_invalid_header could be in mapBlockIndex
2522017-10-30T17:19:42  *** jb55 has joined #bitcoin-core-dev
2532017-10-30T17:21:49  <achow101> promag: specifically if a block was invalid but the header was valid, the header would be in mapBlockIndex. if another peer sent us the exact same header, it would still be in mapBlockIndex and that is what that if statement is checking for
2542017-10-30T17:28:01  *** xinxi has quit IRC
2552017-10-30T17:28:36  *** Dizzle has joined #bitcoin-core-dev
2562017-10-30T17:28:36  *** xinxi has joined #bitcoin-core-dev
2572017-10-30T17:46:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2582017-10-30T18:00:17  *** timothy has quit IRC
2592017-10-30T18:01:45  *** Gnof has joined #bitcoin-core-dev
2602017-10-30T18:02:56  *** SopaXorzTaker has quit IRC
2612017-10-30T18:11:46  *** quantbot has joined #bitcoin-core-dev
2622017-10-30T18:12:11  *** quantbot has joined #bitcoin-core-dev
2632017-10-30T18:20:31  *** m8tion has quit IRC
2642017-10-30T18:27:51  <sdaftuar> has travis been flaky lately?  i'm seeing a wallet.py error in one of the functional tests runs for #11560
2652017-10-30T18:27:53  <gribble> https://github.com/bitcoin/bitcoin/issues/11560 | Connect to a new outbound peer if our tip is stale by sdaftuar · Pull Request #11560 · bitcoin/bitcoin · GitHub
2662017-10-30T18:28:37  *** Chris_Stewart_5 has quit IRC
2672017-10-30T18:29:38  <sipa> badstatusline
2682017-10-30T18:29:44  *** quantbot has quit IRC
2692017-10-30T18:29:46  <sipa> (line 2818)
2702017-10-30T18:29:58  *** quantbot has joined #bitcoin-core-dev
2712017-10-30T18:29:59  <sdaftuar> yeah i don't know what would cause that
2722017-10-30T18:30:45  <sipa> let's try restarting
2732017-10-30T18:32:14  <sdaftuar> restarted
2742017-10-30T18:34:40  *** LumberCartel has quit IRC
2752017-10-30T18:34:41  <BlueMatt> ryanofsky: did you actually see the test in #11531 hang?
2762017-10-30T18:34:43  <gribble> https://github.com/bitcoin/bitcoin/issues/11531 | Check that new headers are not a descendant of an invalid block (more effeciently) by TheBlueMatt · Pull Request #11531 · bitcoin/bitcoin · GitHub
2772017-10-30T18:34:45  <BlueMatt> I can bump the timeout there
2782017-10-30T18:34:55  <ryanofsky> no
2792017-10-30T18:35:39  <ryanofsky> the code just seems unnecessarily complicated and probably flaky
2802017-10-30T18:36:35  <BlueMatt> I mean all I can do is bump the timeout there, really
2812017-10-30T18:36:47  <BlueMatt> I think when i go to rewrite the dos logic stuff soon it will change behavior
2822017-10-30T18:36:53  <BlueMatt> and no need for the test to test for it
2832017-10-30T18:37:48  *** wxss has quit IRC
2842017-10-30T18:39:05  <ryanofsky> can you simplify the test by skipping the ping and just waiting for the disconnect?
2852017-10-30T18:40:08  <BlueMatt> no, because I believe it currently does not disconnect
2862017-10-30T18:40:11  <BlueMatt> right now it uses the ping path
2872017-10-30T18:40:17  <BlueMatt> but really it should be disconnecting
2882017-10-30T18:41:26  <ryanofsky> then i don't see what you lose by dropping the exception handler completely and updating the test when you do add a disconnect
2892017-10-30T18:41:42  <BlueMatt> because I'm probably gonna need the exception handler in like a month
2902017-10-30T18:41:52  <BlueMatt> and testing for something that bitcoind really shouldnt be doing anyway is kinda nonsense
2912017-10-30T18:42:27  <ryanofsky> how do you even know the exception handler works?
2922017-10-30T18:43:48  <BlueMatt> i tested it :)
2932017-10-30T18:44:20  <BlueMatt> iirc you can just change the dos points for whatever case its using to make the block invalid trivially and it'll keep chugging along
2942017-10-30T18:48:22  <ryanofsky> ok well do what you want, but if were me i would opt for not adding a potentially flaky 1-sec timeout and confusing code that doesn't get executed
2952017-10-30T18:50:07  <bitcoin-git> [bitcoin] luke-jr opened pull request #11582: wallet: Restore -usehd=0 option (master...usehd) https://github.com/bitcoin/bitcoin/pull/11582
2962017-10-30T18:50:25  *** warxhead has joined #bitcoin-core-dev
2972017-10-30T18:52:49  <BlueMatt> i mean its not like we dont have other timeouts in the tests, no?
2982017-10-30T18:52:55  *** pergaminho has quit IRC
2992017-10-30T18:52:57  <BlueMatt> I can set it higher if that makes it much less flaky
3002017-10-30T18:53:40  *** wxss has joined #bitcoin-core-dev
3012017-10-30T18:54:45  *** pergaminho has joined #bitcoin-core-dev
3022017-10-30T18:58:29  *** intcat has quit IRC
3032017-10-30T18:59:37  *** intcat has joined #bitcoin-core-dev
3042017-10-30T19:00:43  *** pergaminho has quit IRC
3052017-10-30T19:02:08  *** pergaminho has joined #bitcoin-core-dev
3062017-10-30T19:03:53  *** quantbot has quit IRC
3072017-10-30T19:04:29  *** quantbot has joined #bitcoin-core-dev
3082017-10-30T19:05:18  *** quantbot has quit IRC
3092017-10-30T19:05:33  *** quantbot has joined #bitcoin-core-dev
3102017-10-30T19:12:47  *** laurentmt has quit IRC
3112017-10-30T19:30:12  *** Cheeseo has joined #bitcoin-core-dev
3122017-10-30T19:34:58  *** cheese_ has joined #bitcoin-core-dev
3132017-10-30T19:38:31  *** Cheeseo has quit IRC
3142017-10-30T19:43:34  *** esotericnonsense has joined #bitcoin-core-dev
3152017-10-30T19:45:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3162017-10-30T19:50:27  *** jb55 has quit IRC
3172017-10-30T19:58:34  *** Chris_Stewart_5 has quit IRC
3182017-10-30T20:02:32  *** cheese_ has quit IRC
3192017-10-30T20:03:01  *** cheese_ has joined #bitcoin-core-dev
3202017-10-30T20:03:44  *** Dizzle has quit IRC
3212017-10-30T20:06:45  *** meshcollider has joined #bitcoin-core-dev
3222017-10-30T20:11:24  *** LumberCartel has joined #bitcoin-core-dev
3232017-10-30T20:16:30  *** maaku has joined #bitcoin-core-dev
3242017-10-30T20:17:03  <maaku> does anyone have a list of version bits currently being used, including unofficially?
3252017-10-30T20:19:25  <ossifrage> I wonder what the 0.15.x based btc1 code did to break networking during initial block download (it runs for a while, then all the peers timeout, then I get nothing but version handshake timeouts and it makes minimal further progress with 0 or 1 peers)
3262017-10-30T20:21:35  *** jb55 has joined #bitcoin-core-dev
3272017-10-30T20:30:57  *** LumberCartel has quit IRC
3282017-10-30T20:34:40  *** Gnof has quit IRC
3292017-10-30T20:37:06  <gmaxwell> ossifrage: sounds like you're confirming something like wxss's result-- but sadly, this is offtopic for here, as we don't debug adversarial fork's problems here. :)
3302017-10-30T20:38:38  <ossifrage> gmaxwell, I agree, I was just curious how it could break in such a odd way.
3312017-10-30T20:41:58  *** maaku has left #bitcoin-core-dev
3322017-10-30T20:55:33  <wxss> gmaxwell, absolutely agree. My issue was different, but this is not the place for analyzing it further
3332017-10-30T20:57:39  *** quantbot has joined #bitcoin-core-dev
3342017-10-30T21:01:24  *** quantbot has quit IRC
3352017-10-30T21:02:00  *** quantbot has joined #bitcoin-core-dev
3362017-10-30T21:04:26  *** quantbot has quit IRC
3372017-10-30T21:04:39  *** quantbot has joined #bitcoin-core-dev
3382017-10-30T21:15:31  *** quantbot has quit IRC
3392017-10-30T21:17:27  *** mmgen has quit IRC
3402017-10-30T21:20:49  *** quantbot has joined #bitcoin-core-dev
3412017-10-30T21:38:09  *** jb55 has quit IRC
3422017-10-30T21:40:03  *** RoyceX has joined #bitcoin-core-dev
3432017-10-30T21:53:35  *** grio has quit IRC
3442017-10-30T22:06:34  *** jb55 has joined #bitcoin-core-dev
3452017-10-30T22:15:40  *** ghost43 has quit IRC
3462017-10-30T22:16:03  *** ghost43 has joined #bitcoin-core-dev
3472017-10-30T22:24:04  *** d9b4bef9 has quit IRC
3482017-10-30T22:25:10  *** d9b4bef9 has joined #bitcoin-core-dev
3492017-10-30T22:28:06  *** intcat has quit IRC
3502017-10-30T22:32:33  *** intcat has joined #bitcoin-core-dev
3512017-10-30T22:37:46  *** Cogito_Ergo_Sum has quit IRC
3522017-10-30T22:39:35  *** Guyver2 has quit IRC
3532017-10-30T23:00:38  *** Deacyde has joined #bitcoin-core-dev
3542017-10-30T23:01:34  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11583: Do not make it trivial for inbound peers to generate log entries (master...2017-10-no-net-log) https://github.com/bitcoin/bitcoin/pull/11583
3552017-10-30T23:07:09  *** LumberCartel has joined #bitcoin-core-dev
3562017-10-30T23:12:58  *** cheese_ has quit IRC
3572017-10-30T23:16:16  *** RoyceX has quit IRC
3582017-10-30T23:21:27  *** LumberCartel has quit IRC
3592017-10-30T23:21:41  *** Deacyde has quit IRC
3602017-10-30T23:22:05  *** Deacyde has joined #bitcoin-core-dev
3612017-10-30T23:27:07  *** Deacyde has quit IRC
3622017-10-30T23:27:45  *** Deacyde has joined #bitcoin-core-dev
3632017-10-30T23:29:40  *** Deacyde has joined #bitcoin-core-dev
3642017-10-30T23:32:20  *** Deacyde has quit IRC
3652017-10-30T23:32:50  *** Deacyde has joined #bitcoin-core-dev
3662017-10-30T23:38:07  *** jb55 has quit IRC
3672017-10-30T23:50:19  *** quantbot has quit IRC