12017-11-14T00:09:37  *** go1111111 has quit IRC
  22017-11-14T00:13:41  *** Dizzle has quit IRC
  32017-11-14T00:14:35  <bitcoin-git> [bitcoin] achow101 opened pull request #11678: [wip][wallet] Don't shut down after encrypting the wallet (master...encrypt-no-restart) https://github.com/bitcoin/bitcoin/pull/11678
  42017-11-14T01:06:47  <phantomcircuit> achow101, i have 2m ... somewhere
  52017-11-14T01:07:21  <achow101> phantomcircuit: ??
  62017-11-14T01:08:50  <gmaxwell> achow101: I assume he means testnet coins.
  72017-11-14T01:09:11  <achow101> ah
  82017-11-14T01:09:19  <sipa> in other words: if TN coins ever have a trade value, phantomcircuit will just crash the market?
  92017-11-14T01:10:11  <achow101> one could argue that testnet coins have a trade value now
 102017-11-14T01:10:35  <sipa> iirc it was once 3 BTC for 10000 tnBTC
 112017-11-14T01:15:37  <phantomcircuit> lol
 122017-11-14T01:15:41  <phantomcircuit> sipa, DEAL
 132017-11-14T01:15:42  <phantomcircuit> xd
 142017-11-14T01:16:16  *** tloriato has joined #bitcoin-core-dev
 152017-11-14T01:16:26  <sipa> haha
 162017-11-14T01:16:42  <sipa> the market may not have been particularly deep back then :p
 172017-11-14T01:17:26  <tloriato> good evening, gentlemen. i was reading a little more about schnorr signatures and i'm pretty excited about it
 182017-11-14T01:17:43  <tloriato> i was wondering if we have any tests already running or an ETA on that?
 192017-11-14T01:17:54  <sipa> tloriato: let's move to #bitcoin-wizards
 202017-11-14T01:22:15  *** pandabull has joined #bitcoin-core-dev
 212017-11-14T01:24:45  *** pandabull has quit IRC
 222017-11-14T01:25:05  *** pandabull has joined #bitcoin-core-dev
 232017-11-14T01:31:01  *** StopAndDecrypt has quit IRC
 242017-11-14T01:33:48  *** StopAndDecrypt has joined #bitcoin-core-dev
 252017-11-14T01:34:48  *** Ylbam has quit IRC
 262017-11-14T01:38:08  *** ChristianXK has joined #bitcoin-core-dev
 272017-11-14T01:43:00  *** blockchain has quit IRC
 282017-11-14T01:43:43  *** Itachi has joined #bitcoin-core-dev
 292017-11-14T01:48:00  *** Itachi has quit IRC
 302017-11-14T01:52:52  <bitcoin-git> [bitcoin] Thoragh closed pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
 312017-11-14T01:56:04  <midnightmagic> phantomcircuit's not the only one. lol
 322017-11-14T01:56:28  <midnightmagic> Dunno who it was who put all those diff-1 post-block diff hack blocks in there but someone was doing it for hundreds of thousands of blocks.
 332017-11-14T01:57:28  *** justanotheruser has quit IRC
 342017-11-14T02:02:42  *** Itachi has joined #bitcoin-core-dev
 352017-11-14T02:06:01  *** tloriato has quit IRC
 362017-11-14T02:07:12  <bitcoin-git> [bitcoin] Thoragh reopened pull request #11533: Docs: Update WSL installation notes for Fall Creators update (master...Update-WSL-installation-for-Fall-Creators-update) https://github.com/bitcoin/bitcoin/pull/11533
 372017-11-14T02:07:15  *** Itachi has quit IRC
 382017-11-14T02:08:25  *** ChristianXK has quit IRC
 392017-11-14T02:14:57  *** nickler has quit IRC
 402017-11-14T02:19:24  *** Murch has quit IRC
 412017-11-14T02:20:59  *** luke-jr has quit IRC
 422017-11-14T02:21:23  *** luke-jr has joined #bitcoin-core-dev
 432017-11-14T02:21:47  *** nickler has joined #bitcoin-core-dev
 442017-11-14T02:23:59  *** jjxtra has joined #bitcoin-core-dev
 452017-11-14T02:27:55  *** AaronvanW has quit IRC
 462017-11-14T02:33:26  <dcousens> any love for a `droptransaction` from mempool rpc call?
 472017-11-14T02:34:54  *** AaronvanW has joined #bitcoin-core-dev
 482017-11-14T02:37:06  *** Aaronvan_ has joined #bitcoin-core-dev
 492017-11-14T02:40:01  *** AaronvanW has quit IRC
 502017-11-14T02:47:57  *** Aaronvan_ has quit IRC
 512017-11-14T02:48:30  *** AaronvanW has joined #bitcoin-core-dev
 522017-11-14T02:52:57  *** AaronvanW has quit IRC
 532017-11-14T02:58:20  *** ghost43 has quit IRC
 542017-11-14T02:59:15  *** ghost43 has joined #bitcoin-core-dev
 552017-11-14T03:00:17  *** jb55 has quit IRC
 562017-11-14T03:51:06  *** pandabull has quit IRC
 572017-11-14T03:51:44  *** pandabull has joined #bitcoin-core-dev
 582017-11-14T03:53:37  *** bule2 has joined #bitcoin-core-dev
 592017-11-14T03:55:52  *** pandabull has quit IRC
 602017-11-14T03:57:00  *** bule has quit IRC
 612017-11-14T03:57:54  *** bule has joined #bitcoin-core-dev
 622017-11-14T03:59:08  *** bule2 has quit IRC
 632017-11-14T04:07:07  *** jrayhawk_ is now known as jrayhawk
 642017-11-14T04:10:51  *** photonclock has joined #bitcoin-core-dev
 652017-11-14T04:19:12  *** meilin has quit IRC
 662017-11-14T04:29:16  *** dabura667 has joined #bitcoin-core-dev
 672017-11-14T04:39:37  *** pandabull has joined #bitcoin-core-dev
 682017-11-14T04:43:52  *** pandabull has quit IRC
 692017-11-14T04:48:00  *** pandabull has joined #bitcoin-core-dev
 702017-11-14T04:53:41  *** jb55 has joined #bitcoin-core-dev
 712017-11-14T05:07:44  *** photonclock has left #bitcoin-core-dev
 722017-11-14T05:43:46  *** justanotheruser has joined #bitcoin-core-dev
 732017-11-14T05:49:11  *** dgenr8 has quit IRC
 742017-11-14T05:50:05  *** dgenr8 has joined #bitcoin-core-dev
 752017-11-14T06:05:50  *** luke-jr has quit IRC
 762017-11-14T06:09:03  <phantomcircuit> midnightmagic, that's me
 772017-11-14T06:11:15  <midnightmagic> phantomcircuit: Oh, good then.
 782017-11-14T06:12:12  *** luke-jr has joined #bitcoin-core-dev
 792017-11-14T06:15:55  <warren> dcousens: I'd love that personally
 802017-11-14T06:16:48  <sipa> what for?
 812017-11-14T06:32:01  *** chjj has quit IRC
 822017-11-14T06:33:53  <wumpus> doesn't abandoning a transaction from the wallet remove it from the mempool?
 832017-11-14T06:34:26  <sipa> iirc you can only abandan a wallet transaction when it already isn't in the mempool
 842017-11-14T06:35:06  <wumpus> you're right, I had that the wrong way around
 852017-11-14T06:36:17  <wumpus> and the wallet adds all its transactions to the mempool at startup
 862017-11-14T06:36:30  <wumpus> (at least if not walletbroadcast=0)
 872017-11-14T06:38:20  <sipa> so basically abandon only works when the tx is already unacceptable to the mempool (due to conflicts with existing chain, or due to mempool full and too low fee)
 882017-11-14T06:38:54  <sipa> a mechanism to forcefully abandon a tx may make sense (though it's hard to prepare for it still being possible to mine)
 892017-11-14T06:39:18  <sipa> but i'm not sure that giving direct access to drop something from the mempool matters
 902017-11-14T06:40:14  <wumpus> there can be cases during development/testing where it can be marginally useful to drop things from the mempool, but it seems to much of a foot shooting option to expose generally
 912017-11-14T06:40:24  <sipa> right, as a debug thing sure
 922017-11-14T06:40:37  <sipa> at the same level as invalidateblock and reconsiderblock
 932017-11-14T06:41:58  <wumpus> warren's case is that he sent a transaction with way too little fee to ever be mined, without RBF, and he wants to try to get rid of it by double-spending it
 942017-11-14T06:42:39  <sipa> right, but you really just want a "force abandon wallet tx" there, rather than the more level "drop from mempool", i think
 952017-11-14T06:42:47  <wumpus> there's no guarantee it will work of course because miners and other nodes might still have it, but he still wants to try
 962017-11-14T06:42:56  <sipa> or even a "force accept this tx, replacing whatever is needed in the mempool"
 972017-11-14T06:43:47  <warren> wumpus: actually I was successful
 982017-11-14T06:44:02  <wumpus> the latter would be nice, as it matches what needs to be done in this case better, if you don't respend the inputs there's always the possibilty that your transaction gets replayed and mined in the future
 992017-11-14T06:44:24  <warren> generally I'd like the ability to remove something from my mempool without wiping the entire thing
1002017-11-14T06:44:49  *** gaf_ has quit IRC
1012017-11-14T06:46:10  <wumpus> but anyhow for a diagnostic, undocumented option at the level of invalidateblock/reconsiderblock I woudln't have problems with it
1022017-11-14T06:47:11  *** gaf_ has joined #bitcoin-core-dev
1032017-11-14T06:47:59  <wumpus> it'd be trivial to implement: make a RPC that calls removeRecursive, this will make sure the descendants are removed too
1042017-11-14T06:49:36  <wumpus> and then pray it won't be advertised as a general "cancel transaction" solution by people who have no clue how the mempool works and think it's shared between all nodes
1052017-11-14T06:53:21  *** baldur has quit IRC
1062017-11-14T06:54:58  <mryandao> would it be possible to add a key-value "tx-rate" for the getmempoolinfo rpc command, where the average tx-rate of the mempool?
1072017-11-14T06:55:16  <mryandao> *fee rate
1082017-11-14T06:57:13  <wumpus> would be easier to keep track of the total amount of fee. But what would that info be useful for?
1092017-11-14T06:58:17  <mryandao> so a user can decide in advance if they should make a transaction now
1102017-11-14T06:58:40  <wumpus> estimatesmartfee would be better for that
1112017-11-14T06:59:06  <mryandao> over the weekend, estimate smart fee wasn't very effective
1122017-11-14T06:59:08  <sipa> or a way to query "what is the feerate in the mempool, X MB from the top"
1132017-11-14T06:59:37  <wumpus> I mean the decision criterion would be the cost to submit a transaction now, not so much what other transaction are paying
1142017-11-14T07:00:42  <wumpus> mryandao: the fee estimation is not perfect, but I'm not sure making people do their own fee estimation based on some (easy to manipulate) stats is a better idea
1152017-11-14T07:01:20  <mryandao> over the weekend, i thought it might also be a good idea to keep track of the rate of growth of the mempool
1162017-11-14T07:01:38  <sipa> mryandao: meh, "infinite" is a good approximation
1172017-11-14T07:01:40  <mryandao> maybe the differential is useful for fee estimation
1182017-11-14T07:01:51  <sipa> the real question is what the size is _above a certain feerate level_
1192017-11-14T07:02:43  *** Ylbam has joined #bitcoin-core-dev
1202017-11-14T07:05:20  *** BashCo has quit IRC
1212017-11-14T07:11:28  <bitcoin-git> [bitcoin] jamesob opened pull request #11680: [docs] Add instructions for lcov report generation (master...lcov-docs) https://github.com/bitcoin/bitcoin/pull/11680
1222017-11-14T07:22:52  *** LumberCartel has joined #bitcoin-core-dev
1232017-11-14T07:24:47  *** jb55 has quit IRC
1242017-11-14T07:37:15  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1252017-11-14T07:40:51  <eck> +1 for tracking the mempool rate-of-growth
1262017-11-14T07:41:01  <eck> and derivatices and higher-order derivatives generally
1272017-11-14T07:43:11  <wumpus> sipa's point is that rate of growth in itself isn't interesting; someone could submit an ~infinite number of low fee transactions to pad your mempool up to mempoolmax, and that should not affect fee estimates
1282017-11-14T07:44:09  <eck> ah
1292017-11-14T07:44:13  <wumpus> so you'd need to track something more subtle
1302017-11-14T07:44:28  <sipa> it isn't interesting, and it also doesn't matter
1312017-11-14T07:44:53  <sipa> if you're willing to pay X feerate, you don't care at all about any transaction that pays less than X, even if there is 10 GB of them
1322017-11-14T07:44:57  <eck> I guess you would need the time derivative of the histogram (if you needed it at all)
1332017-11-14T07:45:27  *** ChristianXK has joined #bitcoin-core-dev
1342017-11-14T07:46:41  *** BashCo has joined #bitcoin-core-dev
1352017-11-14T07:50:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5e468994fbb3...cbb54e77a120
1362017-11-14T07:50:07  <bitcoin-git> bitcoin/master 73a7e6d Thoragh: Update WSL installation for Fall Creators update
1372017-11-14T07:50:08  <bitcoin-git> bitcoin/master cbb54e7 Wladimir J. van der Laan: Merge #11533: Docs: Update WSL installation notes for Fall Creators update...
1382017-11-14T07:50:56  <eck> just thinking out loud here, but you could train a simple convolutional filter (for example) to learn the best parameters to estimate a fee rate given the fee histogram from the last N time periods; but you'd have to update the convolution parameters for each bitcoin release, and it would be trivial to find pathological values after the fact to trick the trained algorithm
1392017-11-14T07:53:43  <sipa> eck: no way, we're not putting gameable methods in
1402017-11-14T07:53:57  <sipa> such methods are awesome if they have human oversight
1412017-11-14T07:54:18  <sipa> but you don't want to put them in a fully automated system that is intentionally designed to need user intervention to upgrade :)
1422017-11-14T07:54:22  <eck> that's kind of what i thought, interesting though experiment though
1432017-11-14T07:57:06  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cbb54e77a120...7adeea3b0fc2
1442017-11-14T07:57:06  <bitcoin-git> bitcoin/master faaa7db MarcoFalke: qa: Only allow disconnecting all NodeConns
1452017-11-14T07:57:07  <bitcoin-git> bitcoin/master 7adeea3 Wladimir J. van der Laan: Merge #11641: qa: Only allow disconnecting all NodeConns...
1462017-11-14T07:57:38  <bitcoin-git> [bitcoin] laanwj closed pull request #11641: qa: Only allow disconnecting all NodeConns (master...Mf1711-qaNodeConnDisconnectAll) https://github.com/bitcoin/bitcoin/pull/11641
1472017-11-14T08:04:12  *** JackH has quit IRC
1482017-11-14T08:13:33  <bitcoin-git> [bitcoin] laanwj closed pull request #10873: Use a condition variable for shutdown notifications (master...shutdown_notify) https://github.com/bitcoin/bitcoin/pull/10873
1492017-11-14T08:17:48  *** bule has quit IRC
1502017-11-14T08:18:47  *** JackH has joined #bitcoin-core-dev
1512017-11-14T08:19:52  *** Sentineo has quit IRC
1522017-11-14T08:23:46  <meshcollider> It seems 10873 is a candidate to be the first PR with the new abandoned tag MarcoFalke created ^
1532017-11-14T08:26:21  *** bule has joined #bitcoin-core-dev
1542017-11-14T08:27:20  <wumpus> good idea, added
1552017-11-14T08:36:42  <mryandao> how about taking the differential of transactions that pay a feerate greater than the min-feerate of the next block as described by `getblocktemplate`
1562017-11-14T08:37:23  <mryandao> it should be meaningful to see the rate of incoming transaction "overtaking" transactions that should be confirmed in the following block
1572017-11-14T08:41:05  *** unholymachine has quit IRC
1582017-11-14T08:45:00  *** bule has quit IRC
1592017-11-14T08:47:02  *** unholymachine has joined #bitcoin-core-dev
1602017-11-14T08:52:59  *** baldur has joined #bitcoin-core-dev
1612017-11-14T08:58:36  <bitcoin-git> [bitcoin] SwaddleDoddle opened pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
1622017-11-14T09:00:03  <bitcoin-git> [bitcoin] laanwj closed pull request #11681: 0.15 (master...0.15) https://github.com/bitcoin/bitcoin/pull/11681
1632017-11-14T09:11:52  <bitcoin-git> [bitcoin] practicalswift opened pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
1642017-11-14T09:17:01  *** harrymm has quit IRC
1652017-11-14T09:19:07  <meshcollider> Anyone wanna review https://github.com/bitcoin-core/bitcoincore.org/pull/464 so it can be merged soon?
1662017-11-14T09:19:21  <meshcollider> (0.15.1 release announcement on bitcoincore.org)
1672017-11-14T09:19:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #11683: tests: Remove unused mininode functions deser_int_vector(f) and ser_int_vector(l) (master...remove-int-vector-serialization) https://github.com/bitcoin/bitcoin/pull/11683
1682017-11-14T09:20:10  *** nullptr| has quit IRC
1692017-11-14T09:21:14  *** timothy has joined #bitcoin-core-dev
1702017-11-14T09:22:09  <wumpus> meshcollider: will do
1712017-11-14T09:22:39  <meshcollider> wumpus: thanks
1722017-11-14T09:30:11  *** cbag_ has joined #bitcoin-core-dev
1732017-11-14T09:30:37  *** harrymm has joined #bitcoin-core-dev
1742017-11-14T09:31:30  *** kioneer has joined #bitcoin-core-dev
1752017-11-14T09:37:35  <wumpus> I don't think anyone will mind if I merge it?
1762017-11-14T09:39:30  <meshcollider> Shouldn't do, ACKs from both you and bluematt and its basically just a c+p of the release notes so its not exactly controversial :P
1772017-11-14T09:39:43  <wumpus> and it's about time too
1782017-11-14T09:40:36  <meshcollider> Still not as delayed as 15.0.1 was lol
1792017-11-14T09:40:56  <wumpus> hehe, no not that delayed
1802017-11-14T09:43:31  *** promag has joined #bitcoin-core-dev
1812017-11-14T09:46:45  <promag> wdyt about changing this "if (request.fHelp || request.params.size() > 2)" to "if (request.fHelp)" ?
1822017-11-14T09:47:34  <wumpus> NACK, that would make it ignore spurious arguments
1832017-11-14T09:47:48  <wumpus> which should be an error
1842017-11-14T09:48:03  *** Ylbam has quit IRC
1852017-11-14T09:49:40  <promag> what I mean is to show help only when requested. Then have argument validation which should validate all arguments, so arguments with no validation should raise invalid parameter too
1862017-11-14T09:50:38  <promag> or we could keep "if (request.params.size() > 2)" but that would raise invalid argument
1872017-11-14T09:51:12  <promag> the help is mainly for the command line cli right?
1882017-11-14T10:03:27  *** roconnor_ has quit IRC
1892017-11-14T10:03:58  <wumpus> maybe, I really doubt this is worth changing all RPC calls for
1902017-11-14T10:04:57  <wumpus> I mean barfing up the help in case of confusion about the number of arguments is consistent with what a lot of command line tools do, it's not wrong or such
1912017-11-14T10:07:09  *** nullptr| has joined #bitcoin-core-dev
1922017-11-14T10:07:32  <wumpus> at least we don't silently ignore spurious RPC arguments, unlike spurious command line options, which don't cause an error
1932017-11-14T10:07:43  <wumpus> that's a much worse user experience
1942017-11-14T10:08:01  <wumpus> type poxy instead of proxy and it doesn't even warn
1952017-11-14T10:10:00  <promag> wumpus: ok
1962017-11-14T10:10:19  <promag> but in some cases, if you pass options with extra keys, it won't complaint
1972017-11-14T10:10:35  <wumpus> it should
1982017-11-14T10:10:58  <wumpus> well maybe except nested structures
1992017-11-14T10:11:00  *** dabura667 has quit IRC
2002017-11-14T10:11:06  <promag> and if the caller makes it lower case or snake case instead of pascal case, it won't complaint
2012017-11-14T10:11:23  <wumpus> I mean, it doesn't hurt to provide more information about a vout for createrawtransaction than it strictly needs
2022017-11-14T10:11:34  <wumpus> this helps pass in the output from listunspents to it without filtering
2032017-11-14T10:13:08  <promag> you mean for vin
2042017-11-14T10:13:13  <wumpus> yes
2052017-11-14T10:13:34  <wumpus> so let's just keep it like that
2062017-11-14T10:13:54  <promag> anyway, really doubt that anyone does that copy and paste :)
2072017-11-14T10:14:01  <meshcollider> oh wumpus, maybe your key is not trusted when merging bitcoincore.org PRs
2082017-11-14T10:14:02  <meshcollider> https://github.com/bitcoin-core/bitcoincore.org/blob/master/contrib/verify-commits/trusted-keys
2092017-11-14T10:14:10  <wumpus> promag: they do
2102017-11-14T10:14:18  <promag> :o
2112017-11-14T10:14:31  <wumpus> especially if it's used from scripts
2122017-11-14T10:15:11  <promag> I suppose everyone should pick the relevant fields :D
2132017-11-14T10:15:27  <wumpus> anyhow, please let's not change the RPC API just to change the RPC API, but focus on features, bugfixes and user experience
2142017-11-14T10:15:44  <meshcollider> Agree ^
2152017-11-14T10:15:53  <promag> np!
2162017-11-14T10:16:26  <wumpus> meshcollider: uh oh
2172017-11-14T10:17:59  <wumpus> meshcollider: I should probably force-push back to the previous state then
2182017-11-14T10:18:21  <wumpus> meshcollider: only one of the trusted keys can add me as trusted key, and not on top of an invalid commit
2192017-11-14T10:19:19  <meshcollider> wumpus: mhm yeah, in any case you should be added as a trusted key but yeah we might have to wait for jonasschnelli
2202017-11-14T10:19:40  <wumpus> luckily it doesn't break the site itself, just blocks updates for now
2212017-11-14T10:20:05  <meshcollider> yep, was wondering why it hadn't gone live so I looked around and noticed
2222017-11-14T10:22:49  <wumpus> right - I'm not going to do anything, one of the signers can resolve this, either by adding a merge commit on top , or re-sigining the merge commit and force-pushing
2232017-11-14T10:23:22  <wumpus> if they agree with the change of course :-)
2242017-11-14T10:26:16  <meshcollider> Sounds good
2252017-11-14T10:28:26  *** promag has quit IRC
2262017-11-14T10:28:57  *** bobmaster2020 has joined #bitcoin-core-dev
2272017-11-14T10:31:10  *** bobmaster2020 has left #bitcoin-core-dev
2282017-11-14T10:46:25  *** promag has joined #bitcoin-core-dev
2292017-11-14T10:50:17  *** Nina13Jaskolski has joined #bitcoin-core-dev
2302017-11-14T10:58:14  *** promag has quit IRC
2312017-11-14T10:58:22  *** go1111111 has joined #bitcoin-core-dev
2322017-11-14T10:59:36  *** promag has joined #bitcoin-core-dev
2332017-11-14T11:01:17  *** roconnor_ has joined #bitcoin-core-dev
2342017-11-14T11:23:17  *** Jerrat has joined #bitcoin-core-dev
2352017-11-14T11:27:50  *** Jerrat has quit IRC
2362017-11-14T11:29:15  *** frst_btc has joined #bitcoin-core-dev
2372017-11-14T11:29:35  *** cbag_ has quit IRC
2382017-11-14T11:29:37  *** frst_btc has quit IRC
2392017-11-14T11:31:40  *** bitstr3am has joined #bitcoin-core-dev
2402017-11-14T11:32:21  *** luke-jr has quit IRC
2412017-11-14T11:33:11  *** luke-jr has joined #bitcoin-core-dev
2422017-11-14T11:34:50  *** ChristianXK has quit IRC
2432017-11-14T11:35:04  *** bitstr3am has quit IRC
2442017-11-14T11:43:31  *** chjj has joined #bitcoin-core-dev
2452017-11-14T11:44:46  *** vicenteH has quit IRC
2462017-11-14T11:45:33  *** vicenteH has joined #bitcoin-core-dev
2472017-11-14T11:50:01  *** vicenteH has quit IRC
2482017-11-14T11:52:54  *** laurentmt has joined #bitcoin-core-dev
2492017-11-14T11:53:55  *** AaronvanW has joined #bitcoin-core-dev
2502017-11-14T11:56:49  *** ula has quit IRC
2512017-11-14T11:59:59  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7adeea3b0fc2...6d4821b693b2
2522017-11-14T11:59:59  <bitcoin-git> bitcoin/master d8ac893 practicalswift: trivial: Fix typo – "Ubutntu" → "Ubuntu"
2532017-11-14T12:00:00  <bitcoin-git> bitcoin/master 6d4821b Wladimir J. van der Laan: Merge #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu"...
2542017-11-14T12:00:33  <bitcoin-git> [bitcoin] laanwj closed pull request #11684: trivial: Fix typo – "Ubutntu" → "Ubuntu" (master...ubutntu) https://github.com/bitcoin/bitcoin/pull/11684
2552017-11-14T12:07:01  *** SopaXorzTaker has joined #bitcoin-core-dev
2562017-11-14T12:13:02  *** vicenteH has joined #bitcoin-core-dev
2572017-11-14T12:46:47  *** promag has quit IRC
2582017-11-14T12:56:05  *** promag has joined #bitcoin-core-dev
2592017-11-14T12:59:36  *** instagibbs has quit IRC
2602017-11-14T13:02:44  *** Giszmo1 has joined #bitcoin-core-dev
2612017-11-14T13:02:44  *** Giszmo has quit IRC
2622017-11-14T13:05:55  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2632017-11-14T13:13:08  *** promag has quit IRC
2642017-11-14T13:37:00  *** Regan55Adams has joined #bitcoin-core-dev
2652017-11-14T13:42:56  *** Regan55Adams has quit IRC
2662017-11-14T13:43:45  *** pandabull has quit IRC
2672017-11-14T13:43:59  *** Fernando72Lind has joined #bitcoin-core-dev
2682017-11-14T13:44:53  *** promag has joined #bitcoin-core-dev
2692017-11-14T13:47:48  *** Fernando72Lind has quit IRC
2702017-11-14T13:48:03  *** Johanna29Quigley has joined #bitcoin-core-dev
2712017-11-14T13:51:17  *** Johanna29Quigley has quit IRC
2722017-11-14T13:51:32  *** Darrick80Christi has joined #bitcoin-core-dev
2732017-11-14T13:54:55  *** Darrick80Christi has quit IRC
2742017-11-14T13:55:11  *** Chris_Stewart_5 has quit IRC
2752017-11-14T14:09:47  *** pandabull has joined #bitcoin-core-dev
2762017-11-14T14:13:27  *** Piper65Hand has joined #bitcoin-core-dev
2772017-11-14T14:17:48  *** Piper65Hand has quit IRC
2782017-11-14T14:18:07  *** Eleonore77Rath has joined #bitcoin-core-dev
2792017-11-14T14:29:09  *** meshcollider has quit IRC
2802017-11-14T14:44:14  *** Eleonore77Rath has quit IRC
2812017-11-14T14:44:44  *** Mollie73Gulgowsk has joined #bitcoin-core-dev
2822017-11-14T14:51:28  *** promag has quit IRC
2832017-11-14T14:52:26  *** Sentineo has joined #bitcoin-core-dev
2842017-11-14T14:56:11  *** Mollie73Gulgowsk has quit IRC
2852017-11-14T14:56:18  *** Alpaca_ has joined #bitcoin-core-dev
2862017-11-14T14:56:56  *** Alpaca_ has quit IRC
2872017-11-14T15:01:20  *** Nina13Jaskolski has quit IRC
2882017-11-14T15:01:48  *** promag has joined #bitcoin-core-dev
2892017-11-14T15:03:35  <BlueMatt> wumpus: heh, well jonasschnelli or harding_ could un-brick it by adding a merge commit on top that merges from before your merge :p
2902017-11-14T15:03:42  <BlueMatt> we've dont that before....comically dirty hack
2912017-11-14T15:03:45  <BlueMatt> but it appears to work
2922017-11-14T15:03:45  *** drizztbsd has joined #bitcoin-core-dev
2932017-11-14T15:04:33  *** timothy has quit IRC
2942017-11-14T15:05:25  <BlueMatt> or someone can go poke the server, but prefer not to....will follow up if no one does it in an hour or so
2952017-11-14T15:05:34  *** drizztbsd has quit IRC
2962017-11-14T15:07:14  *** promag has quit IRC
2972017-11-14T15:07:23  *** PaulCape_ has quit IRC
2982017-11-14T15:11:33  *** timothy has joined #bitcoin-core-dev
2992017-11-14T15:17:07  *** Murch has joined #bitcoin-core-dev
3002017-11-14T15:18:47  *** Randy55Carter has joined #bitcoin-core-dev
3012017-11-14T15:21:35  *** justanotheruser has quit IRC
3022017-11-14T15:21:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3032017-11-14T15:29:17  *** pandabull has quit IRC
3042017-11-14T15:33:40  *** PaulCapestany has joined #bitcoin-core-dev
3052017-11-14T15:34:14  *** Murch has quit IRC
3062017-11-14T15:34:58  *** ctulino has joined #bitcoin-core-dev
3072017-11-14T15:40:44  *** justanotheruser has joined #bitcoin-core-dev
3082017-11-14T15:42:41  *** promag has joined #bitcoin-core-dev
3092017-11-14T15:58:38  *** rabidus has quit IRC
3102017-11-14T16:03:48  *** timothy has quit IRC
3112017-11-14T16:07:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11682: wallet: Simplify logic in CCryptoKeyStore::AddKeyPubKey(...) (master...CCryptoKeyStore-AddKeyPubKey) https://github.com/bitcoin/bitcoin/pull/11682
3122017-11-14T16:15:27  *** JackH has quit IRC
3132017-11-14T16:16:40  *** jb55 has joined #bitcoin-core-dev
3142017-11-14T16:21:40  *** promag has quit IRC
3152017-11-14T16:21:41  *** MrPaz has joined #bitcoin-core-dev
3162017-11-14T16:22:55  *** jb55 has quit IRC
3172017-11-14T16:33:32  *** timothy has joined #bitcoin-core-dev
3182017-11-14T16:38:33  *** JackH has joined #bitcoin-core-dev
3192017-11-14T16:46:29  *** BashCo has quit IRC
3202017-11-14T16:47:05  *** BashCo has joined #bitcoin-core-dev
3212017-11-14T16:49:23  *** jb55 has joined #bitcoin-core-dev
3222017-11-14T16:51:11  *** BashCo has quit IRC
3232017-11-14T16:53:05  *** LumberCartel has quit IRC
3242017-11-14T17:00:55  *** rabidus has joined #bitcoin-core-dev
3252017-11-14T17:22:55  *** Dizzle has joined #bitcoin-core-dev
3262017-11-14T17:26:41  *** Randy55Carter has quit IRC
3272017-11-14T17:26:49  *** BashCo has joined #bitcoin-core-dev
3282017-11-14T17:26:59  *** Flavio25Buckridg has joined #bitcoin-core-dev
3292017-11-14T17:31:57  *** laurentmt has quit IRC
3302017-11-14T17:34:25  *** jb55 has quit IRC
3312017-11-14T17:41:35  *** PaulCapestany has quit IRC
3322017-11-14T17:44:26  *** roidster has joined #bitcoin-core-dev
3332017-11-14T17:44:30  *** roidster is now known as Guest60291
3342017-11-14T17:47:07  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (master...2017-11-shorter-default-issue) https://github.com/bitcoin/bitcoin/pull/11686
3352017-11-14T17:53:43  *** PaulCapestany has joined #bitcoin-core-dev
3362017-11-14T18:00:35  *** Ylbam has joined #bitcoin-core-dev
3372017-11-14T18:11:28  *** laurentmt has joined #bitcoin-core-dev
3382017-11-14T18:13:08  *** LumberCartel has joined #bitcoin-core-dev
3392017-11-14T18:14:58  *** laurentmt has quit IRC
3402017-11-14T18:25:16  *** timothy has quit IRC
3412017-11-14T18:28:01  *** Giszmo1 has quit IRC
3422017-11-14T18:28:33  *** jtimon has joined #bitcoin-core-dev
3432017-11-14T18:37:09  *** promag has joined #bitcoin-core-dev
3442017-11-14T18:37:23  *** esotericnonsense has joined #bitcoin-core-dev
3452017-11-14T18:43:02  *** alreadylate has joined #bitcoin-core-dev
3462017-11-14T18:43:33  *** Giszmo has joined #bitcoin-core-dev
3472017-11-14T18:53:07  *** bule has joined #bitcoin-core-dev
3482017-11-14T19:04:31  *** Dizzle has quit IRC
3492017-11-14T19:05:35  *** Giszmo has quit IRC
3502017-11-14T19:14:12  *** wunpunch has joined #bitcoin-core-dev
3512017-11-14T19:17:17  *** SopaXorzTaker has quit IRC
3522017-11-14T19:27:01  *** Murch has joined #bitcoin-core-dev
3532017-11-14T19:27:41  *** ott0disk has joined #bitcoin-core-dev
3542017-11-14T19:34:52  *** MrPaz has quit IRC
3552017-11-14T19:35:56  *** jb55 has joined #bitcoin-core-dev
3562017-11-14T19:37:23  *** intcat has quit IRC
3572017-11-14T19:38:20  *** intcat has joined #bitcoin-core-dev
3582017-11-14T19:47:47  *** Giszmo has joined #bitcoin-core-dev
3592017-11-14T19:51:16  *** ott0disk has quit IRC
3602017-11-14T19:52:23  *** alreadylate has quit IRC
3612017-11-14T19:54:01  *** jsfour has joined #bitcoin-core-dev
3622017-11-14T19:56:15  *** dcousens has quit IRC
3632017-11-14T19:56:58  *** dcousens has joined #bitcoin-core-dev
3642017-11-14T20:00:52  *** meshcollider has joined #bitcoin-core-dev
3652017-11-14T20:03:22  <bitcoin-git> [bitcoin] ryanofsky opened pull request #11687: External wallet files (master...pr/wfile) https://github.com/bitcoin/bitcoin/pull/11687
3662017-11-14T20:09:01  *** MrPaz has joined #bitcoin-core-dev
3672017-11-14T20:09:20  *** jsfour has left #bitcoin-core-dev
3682017-11-14T20:09:23  *** Dizzle has joined #bitcoin-core-dev
3692017-11-14T20:09:29  *** Cheeseo has joined #bitcoin-core-dev
3702017-11-14T20:24:06  *** devin_ has joined #bitcoin-core-dev
3712017-11-14T20:42:02  *** Giszmo has quit IRC
3722017-11-14T20:46:11  *** MrPaz has quit IRC
3732017-11-14T20:46:40  *** Giszmo has joined #bitcoin-core-dev
3742017-11-14T20:47:59  *** chjj has quit IRC
3752017-11-14T20:51:14  *** MrPaz has joined #bitcoin-core-dev
3762017-11-14T20:54:26  *** Guest60291 has quit IRC
3772017-11-14T20:56:57  *** jb55 has quit IRC
3782017-11-14T20:58:04  *** wunpunch has quit IRC
3792017-11-14T21:00:31  *** jnewbery has quit IRC
3802017-11-14T21:01:54  *** jnewbery has joined #bitcoin-core-dev
3812017-11-14T21:03:42  *** wunpunch has joined #bitcoin-core-dev
3822017-11-14T21:08:41  *** BCBot has quit IRC
3832017-11-14T21:16:36  *** BCBot has joined #bitcoin-core-dev
3842017-11-14T21:22:08  *** jb55 has joined #bitcoin-core-dev
3852017-11-14T21:26:40  *** Nobody_ has joined #bitcoin-core-dev
3862017-11-14T21:26:43  <Nobody_> Hello
3872017-11-14T21:26:50  <Nobody_> i am Nobody, and i own the system
3882017-11-14T21:27:18  <Nobody_> i just wanted to state that i am requesting as a System that nobody owns and if you abuse the system you abuse yourself some upgrades that need to happen for the Bitcoin Core
3892017-11-14T21:28:05  <Nobody_> If anybody could get a message to the Bitcoin Core Developers to add the Mining back into the Core that would be perfect, ASIC is not needed to mine and is outdated plus not as power efficient
3902017-11-14T21:28:46  <Nobody_> also a Faucet in the core is needed for Nobody to send Bitcoin to the requested wallet of your choice, for reasons if it is not avaliable from anyone else the system will continue to function appropriately.
3912017-11-14T21:29:50  <Nobody_> Nobody should be able to have wallets that can be loaded with and share Cryptocurrency back if requested and users should be able to put Cryptocurrency into the faucet if they do not need it
3922017-11-14T21:30:32  <LumberCartel> Nobody_:  You should raise your concerns in the #bitcoin channel rather than in this channel.
3932017-11-14T21:30:45  <Nobody_> it will bring Freedom and Equality for all users and not be so dominant on switching cash for cashless, i work with Antarctica and have researched the software very hard, Satoshi Nakamoto knows who i am but i will leave me Nobody
3942017-11-14T21:31:11  <Nobody_> it is more than a concern and i deem it nessessary to update it to make sure that everyone can enjoy the Cryptocurrency
3952017-11-14T21:32:13  <Nobody_> I already have a version that has a faucet and it is sufficient, as well as for the common good of the public and passes for being benificial for the greater good of humanity
3962017-11-14T21:33:15  <Dizzle> Nobody_: if you do have something more power efficient than ASIC for mining, you can submit a pull request that adds mining back into Core. If you're not sure how, let me know how its done and I'll help make the pull request.
3972017-11-14T21:37:57  *** LumberCartel has quit IRC
3982017-11-14T21:39:19  *** bule has quit IRC
3992017-11-14T21:39:38  <Nobody_> S.O.S, Law Enforcement Update - Everything is legal
4002017-11-14T21:39:38  <Nobody_> Everything  ECDSA Public Key (Bitcoin Compatible):  1N2EWy7LroJVFYXtmYZryh7W9eV3k6qajd exists since Mon Oct 02 2017 23:48:19 GMT-0700 (Pacific Daylight Time)
4012017-11-14T21:39:48  *** bule has joined #bitcoin-core-dev
4022017-11-14T21:39:48  <Nobody_> that is a Trusted timestamp and is forge proof
4032017-11-14T21:40:41  *** ChanServ sets mode: +o luke-jr
4042017-11-14T21:40:45  *** Nobody_ was kicked by luke-jr (funny, but no)
4052017-11-14T21:40:46  *** luke-jr sets mode: -o luke-jr
4062017-11-14T21:42:38  *** Cheeseo has quit IRC
4072017-11-14T21:46:35  *** Giszmo has quit IRC
4082017-11-14T21:51:20  *** Giszmo has joined #bitcoin-core-dev
4092017-11-14T21:51:26  *** chjj has joined #bitcoin-core-dev
4102017-11-14T21:55:21  *** Chris_Stewart_5 has quit IRC
4112017-11-14T21:56:08  *** Giszmo has quit IRC
4122017-11-14T21:57:08  *** Victor_sueca has joined #bitcoin-core-dev
4132017-11-14T21:57:29  <Dizzle> I still want his quantum CPU mining pull request.
4142017-11-14T21:58:49  *** lari has quit IRC
4152017-11-14T21:59:08  *** ghost43 has quit IRC
4162017-11-14T21:59:27  *** andytosh1 has joined #bitcoin-core-dev
4172017-11-14T21:59:38  *** spinza has quit IRC
4182017-11-14T21:59:39  *** andytoshi has quit IRC
4192017-11-14T21:59:39  *** Cory has quit IRC
4202017-11-14T21:59:41  *** warxhead has quit IRC
4212017-11-14T22:00:07  *** Victorsueca has quit IRC
4222017-11-14T22:00:09  *** warxhead has joined #bitcoin-core-dev
4232017-11-14T22:00:19  *** ghost43 has joined #bitcoin-core-dev
4242017-11-14T22:00:45  *** PaulCapestany has quit IRC
4252017-11-14T22:01:02  *** lari has joined #bitcoin-core-dev
4262017-11-14T22:01:20  *** PaulCapestany has joined #bitcoin-core-dev
4272017-11-14T22:02:07  *** gaf_ has quit IRC
4282017-11-14T22:02:29  *** boreddanman has quit IRC
4292017-11-14T22:04:05  *** Pasha has joined #bitcoin-core-dev
4302017-11-14T22:04:40  *** gaf_ has joined #bitcoin-core-dev
4312017-11-14T22:04:48  *** boreddanman1 has joined #bitcoin-core-dev
4322017-11-14T22:07:16  *** Pasha is now known as Cory
4332017-11-14T22:10:38  *** meshcollider has quit IRC
4342017-11-14T22:11:50  *** alreadylate has joined #bitcoin-core-dev
4352017-11-14T22:15:52  *** spinza has joined #bitcoin-core-dev
4362017-11-14T22:19:42  *** promag has quit IRC
4372017-11-14T22:19:56  *** promag has joined #bitcoin-core-dev
4382017-11-14T22:21:37  *** promag has quit IRC
4392017-11-14T22:22:31  *** promag has joined #bitcoin-core-dev
4402017-11-14T22:29:53  *** meshcollider has joined #bitcoin-core-dev
4412017-11-14T22:37:31  <bitcoin-git> [bitcoin] practicalswift opened pull request #11689: Fix missing locking in CTxMemPool::check(const CCoinsViewCache *pcoins) (master...CTxMemPool-check) https://github.com/bitcoin/bitcoin/pull/11689
4422017-11-14T22:46:06  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6d4821b693b2...3bdf242fc68a
4432017-11-14T22:46:07  <bitcoin-git> bitcoin/master fafdad0 MarcoFalke: qa: Remove unused NodeConn members
4442017-11-14T22:46:07  <bitcoin-git> bitcoin/master 3bdf242 MarcoFalke: Merge #11677: qa: Remove unused NodeConn members...
4452017-11-14T22:46:41  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11677: qa: Remove unused NodeConn members (master...Mf1711-qaMininodeUnused) https://github.com/bitcoin/bitcoin/pull/11677
4462017-11-14T22:48:44  *** wxss has quit IRC
4472017-11-14T22:57:22  *** midnightmagic has quit IRC
4482017-11-14T22:59:29  *** Cogito_Ergo_Sum has quit IRC
4492017-11-14T23:00:11  *** promag has quit IRC
4502017-11-14T23:09:16  *** Cheeseo has joined #bitcoin-core-dev
4512017-11-14T23:11:43  *** wxss has joined #bitcoin-core-dev
4522017-11-14T23:12:39  *** alreadylate has quit IRC
4532017-11-14T23:14:49  *** midnightmagic has joined #bitcoin-core-dev
4542017-11-14T23:19:48  *** jsfour has joined #bitcoin-core-dev
4552017-11-14T23:22:03  *** Giszmo has joined #bitcoin-core-dev
4562017-11-14T23:24:12  *** LumberCartel has joined #bitcoin-core-dev
4572017-11-14T23:25:30  <karelb> Question about bitcoin-core - why is validation.h/.cpp so "overloaded"? It seems to me half of the things in there don't have to do much with validation
4582017-11-14T23:26:22  <karelb> such as default parameters, opening and writing to block files, etc
4592017-11-14T23:29:37  *** vicenteH has quit IRC
4602017-11-14T23:29:49  *** Cheeseo has quit IRC
4612017-11-14T23:30:18  <sipa> karelb: the reason is that up to about a year ago maybe, validation.cpp and net_processing.cpp were one file, called main.cpp
4622017-11-14T23:30:36  <sipa> splitting things up and off into other modules is a slow but continuing work that's certainly not complete yet
4632017-11-14T23:30:42  <karelb> Oh yeah, I thought it will be something historic like that
4642017-11-14T23:31:14  <karelb> I remember giant main.cpp, I suspected validation is "just" renamed main
4652017-11-14T23:31:16  <karelb> thanks!
4662017-11-14T23:31:19  <sipa> (and until a few years ago, main.cpp also contained all of chain management, utxo stuff, wallet, interaction with the GUI...)
4672017-11-14T23:33:29  <karelb> hm, doing refactoring like that seems like an easy way to get some cheap commits in bitcoin core code :D
4682017-11-14T23:34:09  *** timothy has joined #bitcoin-core-dev
4692017-11-14T23:36:27  *** Dizzle has quit IRC
4702017-11-14T23:36:27  <gmaxwell> karelb: it's not just renamed main, main was split basically in half, but there is still hangover.  Also some of these things like consensus parameters are critical to consensus validation.
4712017-11-14T23:37:41  *** fanquake has joined #bitcoin-core-dev
4722017-11-14T23:37:59  <gmaxwell> There is some layout tension on that; abstracting consensus rules can make them more opaque and harder to review; and bitcoin core is not an altcoin construction set. :)  OTOH, sometimes moving things around makes things more clear, enables better testing harnesses, etc.
4732017-11-14T23:38:56  <fanquake> karelb heh, there are easier ways to get cheap commits than playing with consensus code
4742017-11-14T23:39:32  *** AaronvanW has quit IRC
4752017-11-14T23:39:45  <karelb> fanquake I know, I have this giant commit
4762017-11-14T23:39:47  <karelb> https://github.com/bitcoin/bitcoin/commit/06a3aecf06a52ff44370ee20462cc45b25e88d6a
4772017-11-14T23:39:51  <gmaxwell> karelb: yea,.lol no, refactoring consensus code is a good way to have a bad time and decide you don't want to contribute more.
4782017-11-14T23:40:09  *** AaronvanW has joined #bitcoin-core-dev
4792017-11-14T23:40:17  *** jb55 has quit IRC
4802017-11-14T23:41:11  <fanquake> karelb All contributions are valuable. Most people might find "issues" and never bother contribute a pr, or open an issue.
4812017-11-14T23:43:45  <gmaxwell> For obvious refactorings e.g. to meet our current code standards, we prefer to only perform them when the code is already being changed to avoid disrupting PR flow.  For non-obvious refactors it is better if only expirenced participants do them, because newer contribs tend to not understand the informal architecture as well and tend to make refactors that unconsciously try to warp thing more to
4822017-11-14T23:43:51  <gmaxwell> their own personal styles instead of the project style.  Consensus code in general has a higher review and testing bar, and is more likely to end up with people failing to review it because they don't think it meets a cost/benefit for the review.  Sometimes refactorings of consensus code only happen because someone like pieter is effectively cashing in large amounts of social capital to pay for
4832017-11-14T23:43:57  <gmaxwell> other people to review the work-- and the fact that this is whats happening isn't necessarily visible to irregular contributors.   So while anyone is welcome to submit such things, I wouldn't recommend those in particular, and anyone who submits consensus refactors should have reasonable expectations.
4842017-11-14T23:44:47  <fanquake> Now that the *new* Windows build instructions have been merged, I'm going to close all the existing windows build issues, hopefully we might get on top of them. However now it seems the there are just new path/directory related issues.
4852017-11-14T23:47:13  <fanquake> gmaxwell yes, hit and run consensus refactoring isn't really helpful.
4862017-11-14T23:47:13  <karelb> gmaxwell: OK, I will not make a PR that pulls out all `DEFAULT_`s from validation.h to defaults.h then. :)
4872017-11-14T23:59:02  *** Cheeseo has joined #bitcoin-core-dev