12017-11-18T00:14:28  *** luke-jr has quit IRC
  22017-11-18T00:14:55  *** luke-jr has joined #bitcoin-core-dev
  32017-11-18T00:26:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  42017-11-18T00:34:18  *** Khunbish has left #bitcoin-core-dev
  52017-11-18T00:35:43  *** Chris_Stewart_5 has quit IRC
  62017-11-18T00:36:47  *** chjj has quit IRC
  72017-11-18T00:53:12  *** LumberCartel has quit IRC
  82017-11-18T00:54:22  *** Cogito_Ergo_Sum has quit IRC
  92017-11-18T01:00:25  *** chjj has joined #bitcoin-core-dev
 102017-11-18T01:08:21  *** LumberCartel has joined #bitcoin-core-dev
 112017-11-18T01:19:20  *** LumberCartel has quit IRC
 122017-11-18T01:20:29  *** goatpig has quit IRC
 132017-11-18T01:20:58  *** LumberCartel has joined #bitcoin-core-dev
 142017-11-18T01:24:08  *** yunhai has joined #bitcoin-core-dev
 152017-11-18T01:25:53  *** jb55 has quit IRC
 162017-11-18T01:28:35  *** yunhai has quit IRC
 172017-11-18T01:30:12  *** grio has quit IRC
 182017-11-18T01:35:27  *** LumberCartel has quit IRC
 192017-11-18T01:44:06  *** Ylbam has quit IRC
 202017-11-18T02:11:09  *** Dummbatz has joined #bitcoin-core-dev
 212017-11-18T02:13:53  *** RubenSomsen has joined #bitcoin-core-dev
 222017-11-18T02:21:45  *** LumberCartel has joined #bitcoin-core-dev
 232017-11-18T02:35:20  *** LumberCartel_ has joined #bitcoin-core-dev
 242017-11-18T02:36:49  *** LumberCartel has quit IRC
 252017-11-18T02:38:55  *** jtimon has quit IRC
 262017-11-18T02:41:05  *** StopAndDecrypt_ has quit IRC
 272017-11-18T02:41:32  *** StopAndDecrypt has joined #bitcoin-core-dev
 282017-11-18T02:45:00  *** LumberCartel_ has quit IRC
 292017-11-18T02:45:15  *** LumberCartel has joined #bitcoin-core-dev
 302017-11-18T02:45:48  *** StopAndDecrypt_ has joined #bitcoin-core-dev
 312017-11-18T02:46:05  *** StopAndDecrypt has quit IRC
 322017-11-18T02:59:57  *** bule has quit IRC
 332017-11-18T03:36:57  <meshcollider> should doc/files.md reflect what would be created on a clean install, or should it take into account legacy locations in use for compatibility?
 342017-11-18T03:38:00  <meshcollider> Specifically, for #11466, should I only mentioned wallets/database/*, wallets/db.log and wallets/wallet.dat ? Or does it need a node that they might be in the root dir instead?
 352017-11-18T03:38:03  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
 362017-11-18T03:38:14  <meshcollider> s/node/note/
 372017-11-18T03:55:30  <sipa> noded.
 382017-11-18T03:57:07  <luke-jr> meshcollider: see the existing entries..
 392017-11-18T03:57:15  <luke-jr> there's separate section for old files
 402017-11-18T03:58:05  <meshcollider> luke-jr: Oh true, thanks
 412017-11-18T04:00:18  <meshcollider> luke-jr: but I'm unsure, because if you upgrade an existing node to, say, 0.16.0 when it is released, it will still use the old file location. This change only effects new installs
 422017-11-18T04:00:38  <meshcollider> Should that still just be in its own section at the bottom?
 432017-11-18T04:00:42  <luke-jr> not sure
 442017-11-18T04:01:13  <luke-jr> IMO do what makes sense to you, and see if anyone complains on the PR
 452017-11-18T04:01:33  <meshcollider> Alright sure :)
 462017-11-18T04:13:42  *** bitstr3am has joined #bitcoin-core-dev
 472017-11-18T04:15:01  *** StopAndDecrypt_ has quit IRC
 482017-11-18T04:15:13  *** d9b4bef9 has quit IRC
 492017-11-18T04:16:20  *** d9b4bef9 has joined #bitcoin-core-dev
 502017-11-18T04:16:31  *** bitstr3am has quit IRC
 512017-11-18T04:27:26  *** RubenSomsen has quit IRC
 522017-11-18T04:42:09  *** Cory has quit IRC
 532017-11-18T04:48:57  *** Cory has joined #bitcoin-core-dev
 542017-11-18T04:54:03  *** Evel-Knievel has quit IRC
 552017-11-18T05:11:58  *** Murch has quit IRC
 562017-11-18T06:03:35  *** Evel-Knievel has joined #bitcoin-core-dev
 572017-11-18T06:10:01  *** Evel-Knievel has quit IRC
 582017-11-18T06:24:18  <jonasschnelli> sipa: how can you leak specific data in ECDSA's r and s through nonce generation? Try and error until you have a couple of desired bytes at the end of r or s?
 592017-11-18T06:25:42  <gmaxwell> no.
 602017-11-18T06:25:44  *** intcat has quit IRC
 612017-11-18T06:25:44  *** ghost43 has quit IRC
 622017-11-18T06:25:44  *** arubi has quit IRC
 632017-11-18T06:25:44  *** dermoth has quit IRC
 642017-11-18T06:26:52  <jonasschnelli> gmaxwell: does it require to generate a bunch of signatures?
 652017-11-18T06:27:05  <gmaxwell> jonasschnelli: for a very dumb example,  set the nonce to be k = H(message hash || constant the attacker knows).   Now the attacker sees any transaction signed by this device, he instantly knows the nonce, and can determine the private key.   That was is kinda boring because other people could learn the value and steal those too.
 662017-11-18T06:27:59  <gmaxwell> jonasschnelli: so we can do better,  k = H( xQ || message)   where x is the user's private key, Q is some attacker public key.   now only the attacker can derrive the nonce and steal the users private key.
 672017-11-18T06:29:14  <gmaxwell> To send a message, do any of the above schemes, but steal some bits of the nonce (like 16 bits) have the attacker try all of them and you send 16 bits of additional data per signature, while also giving the attacker each private key you signed with. For example the additional data could leak the chaining code, so the attacker could derrive all past and future keys as well.
 682017-11-18T06:30:18  <jonasschnelli> gmaxwell: but how does one extract the nonce from the signature?
 692017-11-18T06:31:26  *** intcat has joined #bitcoin-core-dev
 702017-11-18T06:31:58  <gmaxwell> in the first example the attacker just does the same computation the wallet did to generate it.  In the second example,  the attacker takes his private key x'  and multiplies it by the users public key that is signing. k = H( x'P || message).
 712017-11-18T06:32:25  *** ghost43 has joined #bitcoin-core-dev
 722017-11-18T06:32:33  *** arubi has joined #bitcoin-core-dev
 732017-11-18T06:32:36  <gmaxwell> x'P == xQ   because  Q = x'G  and P = xG  so both of them are  x'xG.
 742017-11-18T06:32:44  <gmaxwell> (thats just ECDH)
 752017-11-18T06:33:16  <gmaxwell> so user and attacker compute the same shared secret, hash it with the message being signed.. and use that as the nonce.
 762017-11-18T06:33:40  <gmaxwell> so the attacker knows the nonce, and with the nonce can just derrive the secret key.
 772017-11-18T06:34:58  * jonasschnelli reading and thinking... 
 782017-11-18T06:38:17  <jonasschnelli> gmaxwell: first Q. Why is H( xQ || message) better then H( attacker-constant || message)? Is there a difference if one learns the constant versus attackers pubkey Q?
 792017-11-18T06:38:55  <jonasschnelli> or is xQ ECDH?
 802017-11-18T06:39:03  <gmaxwell> imagine that some third party, not the attacker, and not the victim gets their hands on a backdoored device. They disassemble it and they learn the attacker-constant... then they could steal the coins themselves.
 812017-11-18T06:39:12  <meshcollider> jonasschnelli: you need the attacker's private key not the public key
 822017-11-18T06:39:34  <jonasschnelli> meshcollider: okay. I see. What notation is xQ? Multiplication?
 832017-11-18T06:40:11  <gmaxwell> with xQ  (the users private key times the attackers public key) then a third party which only knows the users and attacker's public keys, at msot, cannot steal the coins.
 842017-11-18T06:40:24  <jonasschnelli> Okay. Got that
 852017-11-18T06:40:26  <meshcollider> yes EC scalar multiplication
 862017-11-18T06:40:52  <gmaxwell> so use of the ECDH is better because it makes the attack exclusive for the attacker.
 872017-11-18T06:41:08  <jonasschnelli> Yes. Indeed
 882017-11-18T06:42:18  <jonasschnelli> gmaxwell: And with the 16 stealed nonce bits, you could export the devices 256bit master seed (requires 16 signatures)...
 892017-11-18T06:42:53  <jonasschnelli> But an attacked would have to try all 16bit combinations from all public known bitcoin signatures?
 902017-11-18T06:43:56  <gmaxwell> yes, so for each transaction he wants to check, he's have to do 2^16 hashes... which would take like.. a microsecond. :)
 912017-11-18T06:44:06  <jonasschnelli> okay.. I see
 922017-11-18T06:45:01  <jonasschnelli> gmaxwell, meshcollider: Thanks. Got it. Thumbs up for the explanation...
 932017-11-18T06:45:12  <gmaxwell> given bitcoin transaction rates perhaps he could plausably steal 32 of those bits per signature instead of 16.
 942017-11-18T06:46:16  <jonasschnelli> gmaxwell: More stolen bytes = longer computation time? Thats the only limit, right?
 952017-11-18T06:48:02  <gmaxwell> yes, but it goes up exponentially.
 962017-11-18T06:49:12  <gmaxwell> to steal 4 extra-bytes per signature the attack is doing 2^32 work ... one thing an attacker might do is steal 16 bits in the first signature of a txn, and then 32 in all subsiquent signatures... so they can identify transactions relatively fast.
 972017-11-18T06:49:38  <gmaxwell> so a transaction with three inputs would leak 10 bytes of data.
 982017-11-18T06:50:08  *** bob_ has joined #bitcoin-core-dev
 992017-11-18T06:51:34  <jonasschnelli> And I guess if he got around 200bits of the HWW master seed, he can calculate the seed by deriving keys and compare against the signatures...
1002017-11-18T06:52:39  <gmaxwell> also there is an extra fun trick,  if the attack code picks the extra data by indexing   short  chaincode[16]; ...  extra_data = chaincode[messagehash%16];  then he might need to see many more than 16 signatures to steal the whole chain code.  But if first the chaincode is expanded up with error correction,  then the stolen data is a random chunk of the much larger error correction data... then
1012017-11-18T06:52:45  <gmaxwell> the attacker will almost certantly be able to recover after seeing 16 signatures.  (for a 32 byte extra-secret).
1022017-11-18T06:52:52  *** bob_ has quit IRC
1032017-11-18T06:52:58  <gmaxwell> and of course in all of this, a single signature always leaks the private key of the public key it was signing for.
1042017-11-18T06:53:24  <gmaxwell> so the only reason to steal extra data is to just get a master secret for other accounts, or so it can steal coins for addresses that are only used once.
1052017-11-18T06:57:20  <jonasschnelli> gmaxwell: I don't understand the "pick extra data by indexing". But if a signature can leak 16 bits, wouldn't it always be sufficient to have 16 signatures to leak 256bit? Under the assumption the leak-data code does sufficient up-count of the "already-sent-index" (maybe through EEPROM usage to avoid power-loss reset)
1062017-11-18T07:02:45  <aj> jonasschnelli: yeah, if you didn't have EEPROM to know which bits to leak, you could pick the data to leak based on the hash you're signing, but then you'd need >>16 sigs to leak 256 bits
1072017-11-18T07:03:10  <aj> jonasschnelli: but if you do erasure coding, you could leak 256 bits in 16 sigs without needing an EEPROM
1082017-11-18T07:04:03  <jonasschnelli> Ah. Now I got it (partially understand erasure coding).
1092017-11-18T07:06:29  <jonasschnelli> Conclusion: Only HODL with HWW's until sipa's proposed scheme is available. :)
1102017-11-18T07:07:56  <jonasschnelli> I mean the MCU on the PCB could be tempered. Could have 512kb flash instead of 256kb and could shadow the bootloader/firmware... hard to impossible to detect I guess.
1112017-11-18T07:13:02  *** d_t has quit IRC
1122017-11-18T07:19:56  *** d_t has joined #bitcoin-core-dev
1132017-11-18T07:25:23  *** kryptokapusta has joined #bitcoin-core-dev
1142017-11-18T07:26:33  *** kryptokapusta has quit IRC
1152017-11-18T07:35:26  *** SopaXorzTaker has joined #bitcoin-core-dev
1162017-11-18T07:36:27  *** d_t has quit IRC
1172017-11-18T07:38:10  *** Ylbam has joined #bitcoin-core-dev
1182017-11-18T08:00:19  <bitcoin-git> [bitcoin] sipsorcery opened pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
1192017-11-18T08:02:11  *** d9b4bef9 has quit IRC
1202017-11-18T08:03:16  *** d9b4bef9 has joined #bitcoin-core-dev
1212017-11-18T08:06:12  <gmaxwell> aj: if you use a counter to choose the data your signature is no longer determinstic, so that might be obvious.
1222017-11-18T08:06:59  <gmaxwell> aj: if you use the message hash to index, your signature is determinstic, and externally indistinguishable from normal behavior.
1232017-11-18T08:11:20  <aj> gmaxwell: good point
1242017-11-18T08:21:29  *** Evel-Knievel has joined #bitcoin-core-dev
1252017-11-18T08:34:06  *** d_t has joined #bitcoin-core-dev
1262017-11-18T08:43:35  *** d_t has quit IRC
1272017-11-18T08:48:06  *** dermoth has joined #bitcoin-core-dev
1282017-11-18T08:57:21  <bitcoin-git> [bitcoin] jamesob opened pull request #11714: [tests] Test that mempool rejects coinbase transactions (master...test-mempool-rejects-coinbase) https://github.com/bitcoin/bitcoin/pull/11714
1292017-11-18T09:32:02  *** Provoostenator has joined #bitcoin-core-dev
1302017-11-18T09:53:22  *** ekrok_ has quit IRC
1312017-11-18T10:04:07  *** roconnor_ has quit IRC
1322017-11-18T10:30:51  *** wunpunch has joined #bitcoin-core-dev
1332017-11-18T10:46:52  *** ekrok has joined #bitcoin-core-dev
1342017-11-18T11:06:37  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/142913296f00...938863965f14
1352017-11-18T11:06:37  <bitcoin-git> bitcoin/master dcfef27 Wladimir J. van der Laan: cli: Reject arguments to -getinfo...
1362017-11-18T11:06:38  <bitcoin-git> bitcoin/master 9388639 Wladimir J. van der Laan: Merge #11710: cli: Reject arguments to -getinfo...
1372017-11-18T11:07:12  <bitcoin-git> [bitcoin] laanwj closed pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
1382017-11-18T11:15:52  *** SopaXorzTaker has quit IRC
1392017-11-18T11:17:21  *** ekrok has quit IRC
1402017-11-18T11:17:41  *** ekrok has joined #bitcoin-core-dev
1412017-11-18T11:19:46  *** fanquake has joined #bitcoin-core-dev
1422017-11-18T11:24:02  *** jtimon has joined #bitcoin-core-dev
1432017-11-18T11:45:06  *** timothy has joined #bitcoin-core-dev
1442017-11-18T12:03:16  *** riemann has joined #bitcoin-core-dev
1452017-11-18T12:40:20  *** goatpig has joined #bitcoin-core-dev
1462017-11-18T12:46:11  *** SopaXorzTaker has joined #bitcoin-core-dev
1472017-11-18T12:49:16  *** wunpunch has quit IRC
1482017-11-18T12:54:21  *** ekrok has quit IRC
1492017-11-18T12:55:56  *** SopaXorzTaker has quit IRC
1502017-11-18T12:56:40  *** SopaXorzTaker has joined #bitcoin-core-dev
1512017-11-18T13:03:49  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/938863965f14...49667a77e76a
1522017-11-18T13:03:50  <bitcoin-git> bitcoin/master f94c2ec Aaron Clauson: Fix for mismatched extern definition in wallet test classes which was breaking msvc linking.
1532017-11-18T13:03:50  <bitcoin-git> bitcoin/master 49667a7 Wladimir J. van der Laan: Merge #11713: Fix for mismatched extern definition in wallet tests...
1542017-11-18T13:04:20  <bitcoin-git> [bitcoin] laanwj closed pull request #11713: Fix for mismatched extern definition in wallet tests (master...externfix) https://github.com/bitcoin/bitcoin/pull/11713
1552017-11-18T13:05:57  *** riemann has quit IRC
1562017-11-18T13:11:43  *** mcxden has joined #bitcoin-core-dev
1572017-11-18T13:14:59  <bitcoin-git> [bitcoin] laanwj opened pull request #11718: tests: move pwalletMain to wallet test fixture (master...2017_11_wallet_test_fixture) https://github.com/bitcoin/bitcoin/pull/11718
1582017-11-18T13:16:00  *** Khunbish has joined #bitcoin-core-dev
1592017-11-18T13:16:56  *** Khunbish has left #bitcoin-core-dev
1602017-11-18T13:19:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1612017-11-18T13:20:16  *** roconnor_ has joined #bitcoin-core-dev
1622017-11-18T13:26:50  *** roconnor_ has quit IRC
1632017-11-18T13:30:25  *** mcxden has quit IRC
1642017-11-18T13:30:27  *** Chris_Stewart_5 has quit IRC
1652017-11-18T13:41:52  <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/49667a77e76a...d080a7d5030e
1662017-11-18T13:41:53  <bitcoin-git> bitcoin/master 0530ba0 MeshCollider: Add -walletdir parameter to specify custom wallet dir
1672017-11-18T13:41:54  <bitcoin-git> bitcoin/master 80c5cbc MeshCollider: Add test for -walletdir
1682017-11-18T13:41:54  <bitcoin-git> bitcoin/master d987889 MeshCollider: Add release notes for -walletdir and wallets/ dir
1692017-11-18T13:42:16  <bitcoin-git> [bitcoin] laanwj closed pull request #11466: Specify custom wallet directory with -walletdir param (master...201710_walletdir) https://github.com/bitcoin/bitcoin/pull/11466
1702017-11-18T13:54:09  *** AaronvanW has joined #bitcoin-core-dev
1712017-11-18T14:09:48  *** ula has joined #bitcoin-core-dev
1722017-11-18T14:14:58  *** DrFeelGood has joined #bitcoin-core-dev
1732017-11-18T14:15:11  *** DrFeelGood has quit IRC
1742017-11-18T14:17:23  *** DrFeelGood has joined #bitcoin-core-dev
1752017-11-18T14:20:03  *** DrFeelGood has quit IRC
1762017-11-18T14:28:52  *** fanquake has quit IRC
1772017-11-18T14:29:03  *** Olufunmilayo has joined #bitcoin-core-dev
1782017-11-18T14:30:57  *** Olufunmilayo has quit IRC
1792017-11-18T14:33:42  *** jb55 has joined #bitcoin-core-dev
1802017-11-18T14:39:04  *** DrFeelGood has joined #bitcoin-core-dev
1812017-11-18T14:51:11  *** meshcollider has quit IRC
1822017-11-18T14:57:03  *** Provoostenator has quit IRC
1832017-11-18T15:01:29  *** arubi has quit IRC
1842017-11-18T15:02:30  *** arubi has joined #bitcoin-core-dev
1852017-11-18T15:36:27  *** BCBot has quit IRC
1862017-11-18T15:37:23  *** PaulCape_ has quit IRC
1872017-11-18T15:38:58  *** cdecker has quit IRC
1882017-11-18T15:39:33  *** riemann has joined #bitcoin-core-dev
1892017-11-18T15:39:54  *** BCBot has joined #bitcoin-core-dev
1902017-11-18T15:57:11  *** d9b4bef9 has quit IRC
1912017-11-18T15:58:17  *** d9b4bef9 has joined #bitcoin-core-dev
1922017-11-18T16:05:28  *** asdadad has joined #bitcoin-core-dev
1932017-11-18T16:07:53  *** asdadad has quit IRC
1942017-11-18T16:08:07  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1952017-11-18T16:08:07  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
1962017-11-18T16:12:32  *** jb55 has quit IRC
1972017-11-18T16:13:00  *** jb55 has joined #bitcoin-core-dev
1982017-11-18T16:29:35  *** cdecker has joined #bitcoin-core-dev
1992017-11-18T16:34:12  *** Emcy has quit IRC
2002017-11-18T16:36:17  *** jb55 has quit IRC
2012017-11-18T16:36:36  *** Emcy has joined #bitcoin-core-dev
2022017-11-18T16:36:46  *** jb55 has joined #bitcoin-core-dev
2032017-11-18T16:42:35  *** jb55 has quit IRC
2042017-11-18T16:42:56  *** jb55 has joined #bitcoin-core-dev
2052017-11-18T16:44:41  *** chartractegg has joined #bitcoin-core-dev
2062017-11-18T16:47:12  *** chartractegg has left #bitcoin-core-dev
2072017-11-18T17:11:26  *** alreadylate has joined #bitcoin-core-dev
2082017-11-18T17:38:59  *** justanotheruser has quit IRC
2092017-11-18T17:40:22  *** alreadylate has quit IRC
2102017-11-18T17:43:06  *** mxg has joined #bitcoin-core-dev
2112017-11-18T17:49:26  *** mxg is now known as maxgiraldo
2122017-11-18T18:05:33  *** alreadylate has joined #bitcoin-core-dev
2132017-11-18T18:17:03  *** d_t has joined #bitcoin-core-dev
2142017-11-18T18:18:41  *** alreadylate has quit IRC
2152017-11-18T18:24:19  *** alreadylate has joined #bitcoin-core-dev
2162017-11-18T18:30:28  *** alreadylate has quit IRC
2172017-11-18T18:39:45  *** chjj has quit IRC
2182017-11-18T18:45:04  *** alreadylate has joined #bitcoin-core-dev
2192017-11-18T18:52:10  *** alreadylate has quit IRC
2202017-11-18T18:54:26  *** alreadylate has joined #bitcoin-core-dev
2212017-11-18T18:58:35  *** LumberCartel has quit IRC
2222017-11-18T19:02:34  *** alreadylate has quit IRC
2232017-11-18T19:10:41  *** maxgiraldo has quit IRC
2242017-11-18T19:13:34  *** alreadylate has joined #bitcoin-core-dev
2252017-11-18T19:19:30  *** LumberCartel has joined #bitcoin-core-dev
2262017-11-18T19:20:50  *** alreadylate has quit IRC
2272017-11-18T19:24:23  *** paracyst has quit IRC
2282017-11-18T19:25:09  *** paracyst has joined #bitcoin-core-dev
2292017-11-18T19:28:22  *** alreadylate has joined #bitcoin-core-dev
2302017-11-18T19:29:01  *** emzy has quit IRC
2312017-11-18T19:30:16  *** emzy has joined #bitcoin-core-dev
2322017-11-18T19:32:00  *** mxg has joined #bitcoin-core-dev
2332017-11-18T19:32:24  *** alreadylate has quit IRC
2342017-11-18T19:33:30  *** mxg has quit IRC
2352017-11-18T19:34:50  *** meshcollider has joined #bitcoin-core-dev
2362017-11-18T19:39:03  <bitcoin-git> [bitcoin] tjps opened pull request #11722: Switched sync.{cpp,h} to std threading primitives. (master...tjps_sync_antiboost) https://github.com/bitcoin/bitcoin/pull/11722
2372017-11-18T19:40:19  *** d9b4bef9 has quit IRC
2382017-11-18T19:43:16  *** d9b4bef9 has joined #bitcoin-core-dev
2392017-11-18T19:44:14  *** d9b4bef9 has quit IRC
2402017-11-18T19:45:32  *** d9b4bef9 has joined #bitcoin-core-dev
2412017-11-18T19:50:34  *** emzy has quit IRC
2422017-11-18T19:50:34  *** emzy has joined #bitcoin-core-dev
2432017-11-18T19:54:07  *** darkua has joined #bitcoin-core-dev
2442017-11-18T19:56:25  *** roadcrap has quit IRC
2452017-11-18T19:57:21  <Lauda> Is the "spend unconfirmed change" feature not supposed to allow you to spend unconfirmed amounts coming from elsewhere?
2462017-11-18T19:57:27  *** LumberCartel has quit IRC
2472017-11-18T19:57:34  <Lauda> That should probably be added as well IMO.
2482017-11-18T19:58:28  <sipa> no, it's about unconfirmed *change*, meaning money coming from yourself
2492017-11-18T19:59:21  <Lauda> What do you think about adding a option for all unconfirmed outputs?
2502017-11-18T19:59:36  <Lauda> i.e. is there a reason why the wallet does not have this?
2512017-11-18T19:59:52  <sipa> yes, you know you won't doublespend your own money
2522017-11-18T20:00:10  <sipa> you don't know that about money coming from elsewhere
2532017-11-18T20:00:24  <Lauda> Well as an advanced feature, I know what I am doing. :P
2542017-11-18T20:00:24  <Lauda> The use cases is probably just sending money to yourself from a second wallet
2552017-11-18T20:00:28  <Lauda> and then wanting to move it elsewhere quickly
2562017-11-18T20:00:33  <Lauda> as is, you have to wait
2572017-11-18T20:00:46  <sipa> right, as an expert option i don't object
2582017-11-18T20:00:56  <sipa> you can do it anyway through raw transaction interface
2592017-11-18T20:01:27  <Lauda> The wallet tab is all expert features anyways. I think this would be a decent addition. + is likely to be needed post multiwallet GUI interface
2602017-11-18T20:01:42  *** SopaXorzTaker has quit IRC
2612017-11-18T20:01:51  <Lauda> needed more often*
2622017-11-18T20:03:01  *** roadcrap has joined #bitcoin-core-dev
2632017-11-18T20:08:26  <Lauda> I've opened an issue requesting such a feature.
2642017-11-18T20:19:17  *** darkua has quit IRC
2652017-11-18T20:23:37  *** darkua has joined #bitcoin-core-dev
2662017-11-18T20:26:20  *** ghost43 has quit IRC
2672017-11-18T20:32:35  *** ghost43 has joined #bitcoin-core-dev
2682017-11-18T20:35:41  *** LumberCartel has joined #bitcoin-core-dev
2692017-11-18T20:36:17  *** promag has joined #bitcoin-core-dev
2702017-11-18T20:38:51  *** hanbingsy has joined #bitcoin-core-dev
2712017-11-18T20:39:45  *** enwrong has joined #bitcoin-core-dev
2722017-11-18T20:41:30  *** hanbingsy has quit IRC
2732017-11-18T20:44:57  *** darkua has quit IRC
2742017-11-18T20:49:14  *** justanotheruser has joined #bitcoin-core-dev
2752017-11-18T20:51:51  *** justanotheruser has joined #bitcoin-core-dev
2762017-11-18T21:05:10  *** enwrong has quit IRC
2772017-11-18T21:13:11  *** cl0uding has quit IRC
2782017-11-18T21:14:09  *** justanotheruser has quit IRC
2792017-11-18T21:14:11  *** nickler has quit IRC
2802017-11-18T21:16:19  *** nickler has joined #bitcoin-core-dev
2812017-11-18T21:22:58  *** xrt9 has joined #bitcoin-core-dev
2822017-11-18T21:25:35  *** cl0uding has joined #bitcoin-core-dev
2832017-11-18T21:27:32  *** xrt9 has quit IRC
2842017-11-18T21:30:02  *** promag has quit IRC
2852017-11-18T21:31:02  *** warxhead has quit IRC
2862017-11-18T21:38:47  *** darkua has joined #bitcoin-core-dev
2872017-11-18T21:52:41  *** jtimon has quit IRC
2882017-11-18T21:58:06  *** jtimon has joined #bitcoin-core-dev
2892017-11-18T22:06:36  *** merehap has joined #bitcoin-core-dev
2902017-11-18T22:09:00  *** DigitalDank has joined #bitcoin-core-dev
2912017-11-18T22:13:29  *** darkua has quit IRC
2922017-11-18T22:14:23  *** LumberCartel has quit IRC
2932017-11-18T22:15:59  <merehap> Hi all, I just ran "make cov" on bitcoin core, looking for low hanging fruit for writing new unit tests. I found that src/rpc/blockchain.cpp has low coverage. Are there any objections to me adding unit tests for this file? Any caveats?
2942017-11-18T22:18:37  *** darkua has joined #bitcoin-core-dev
2952017-11-18T22:19:42  *** laurentmt has joined #bitcoin-core-dev
2962017-11-18T22:29:48  <sipa> merehap: by all means!
2972017-11-18T22:31:30  <merehap> sipa: Awesome, will get started on that now then.
2982017-11-18T22:32:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/d080a7d5030e...0d89fa087793
2992017-11-18T22:32:34  <bitcoin-git> bitcoin/master 2613c54 John Newbery: [tests] fix flake8 warnings in sendheaders.py
3002017-11-18T22:32:34  <bitcoin-git> bitcoin/master f39d4bb John Newbery: [tests] tidy up BaseNode in sendheaders.py
3012017-11-18T22:32:35  <bitcoin-git> bitcoin/master 25fd6e2 John Newbery: [tests] refactor check_last_announcement() in sendheaders.py...
3022017-11-18T22:33:08  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11707: [tests] Fix sendheaders (master...fix_sendheaders) https://github.com/bitcoin/bitcoin/pull/11707
3032017-11-18T22:33:58  *** justanotheruser has joined #bitcoin-core-dev
3042017-11-18T22:34:53  *** darkua has quit IRC
3052017-11-18T22:35:46  *** riemann has quit IRC
3062017-11-18T22:38:45  *** darkua has joined #bitcoin-core-dev
3072017-11-18T22:39:21  *** justanotheruser has quit IRC
3082017-11-18T22:50:02  *** darkua has quit IRC
3092017-11-18T22:51:56  *** PaulCapestany has joined #bitcoin-core-dev
3102017-11-18T22:52:44  *** darkua has joined #bitcoin-core-dev
3112017-11-18T22:54:10  *** booyah_ has joined #bitcoin-core-dev
3122017-11-18T22:59:04  *** jake_ has joined #bitcoin-core-dev
3132017-11-18T22:59:18  *** jb55 has quit IRC
3142017-11-18T22:59:19  *** jake_ has quit IRC
3152017-11-18T23:02:03  *** AaronvanW has quit IRC
3162017-11-18T23:02:47  *** AaronvanW has joined #bitcoin-core-dev
3172017-11-18T23:14:07  *** justanotheruser has joined #bitcoin-core-dev
3182017-11-18T23:15:58  *** booyah_ has quit IRC
3192017-11-18T23:16:05  *** booyah_ has joined #bitcoin-core-dev