12017-12-04T00:08:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
22017-12-04T00:13:26 *** zshlyk has quit IRC
32017-12-04T00:15:24 *** go1111111 has quit IRC
42017-12-04T00:16:36 *** promag has quit IRC
52017-12-04T00:17:18 *** wunpunch has quit IRC
62017-12-04T00:33:39 *** Emcy_ has quit IRC
72017-12-04T00:34:08 *** Emcy_ has joined #bitcoin-core-dev
82017-12-04T00:35:55 *** jb55 has quit IRC
92017-12-04T00:37:53 *** go1111111 has joined #bitcoin-core-dev
102017-12-04T00:40:31 *** jb55 has joined #bitcoin-core-dev
112017-12-04T00:45:58 *** jb55 has quit IRC
122017-12-04T00:46:33 *** bitmangw has left #bitcoin-core-dev
132017-12-04T00:47:11 *** jb55 has joined #bitcoin-core-dev
142017-12-04T00:50:44 *** Emcy has joined #bitcoin-core-dev
152017-12-04T00:53:27 *** Emcy_ has quit IRC
162017-12-04T00:54:34 *** wxss has quit IRC
172017-12-04T00:55:12 *** DvdKhl has quit IRC
182017-12-04T00:57:05 *** jb55 has quit IRC
192017-12-04T01:00:00 *** dabura667 has joined #bitcoin-core-dev
202017-12-04T01:03:45 *** dqx_ has joined #bitcoin-core-dev
212017-12-04T01:04:35 *** dqx has quit IRC
222017-12-04T01:08:18 *** dqx has joined #bitcoin-core-dev
232017-12-04T01:11:18 *** dqx_ has quit IRC
242017-12-04T01:12:30 *** nelruk has joined #bitcoin-core-dev
252017-12-04T01:32:47 *** baltakatei has quit IRC
262017-12-04T01:35:45 *** zshlyk has joined #bitcoin-core-dev
272017-12-04T01:40:15 *** nelruk has quit IRC
282017-12-04T01:43:26 *** Randolf has joined #bitcoin-core-dev
292017-12-04T01:45:20 *** baltakatei has joined #bitcoin-core-dev
302017-12-04T01:45:43 *** Ylbam has quit IRC
312017-12-04T01:56:27 *** Krellan has quit IRC
322017-12-04T01:57:07 *** Krellan has joined #bitcoin-core-dev
332017-12-04T01:58:26 *** Chris_Stewart_5 has quit IRC
342017-12-04T02:03:27 *** meshcollider has quit IRC
352017-12-04T02:07:20 *** Emcy_ has joined #bitcoin-core-dev
362017-12-04T02:08:35 *** dqx has quit IRC
372017-12-04T02:09:56 *** Emcy has quit IRC
382017-12-04T02:10:51 *** zshlyk has quit IRC
392017-12-04T02:11:38 *** zshlyk has joined #bitcoin-core-dev
402017-12-04T02:12:19 *** Chris_Stewart_5 has joined #bitcoin-core-dev
412017-12-04T02:21:51 *** Chris_Stewart_5 has quit IRC
422017-12-04T02:22:48 *** Victorsueca has quit IRC
432017-12-04T02:24:14 *** Victorsueca has joined #bitcoin-core-dev
442017-12-04T02:30:48 *** jb55 has joined #bitcoin-core-dev
452017-12-04T02:31:45 *** zshlyk has quit IRC
462017-12-04T02:32:31 *** zshlyk has joined #bitcoin-core-dev
472017-12-04T02:34:41 *** xRavenheart has joined #bitcoin-core-dev
482017-12-04T02:35:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
492017-12-04T02:35:33 <xRavenheart> anyone able to assist me in my queries about a school project please?
502017-12-04T02:40:48 *** dqx has joined #bitcoin-core-dev
512017-12-04T02:41:55 *** Dizzle has joined #bitcoin-core-dev
522017-12-04T02:42:47 *** xRavenheart has quit IRC
532017-12-04T02:47:32 <Randolf> xRavenheart: What's your school project about? Bitcoin development?
542017-12-04T02:50:20 *** xRavenheart has joined #bitcoin-core-dev
552017-12-04T02:50:39 <xRavenheart> hi anyone able to assist me in a school project related question?
562017-12-04T02:51:42 <sipa> 02:47:32 < Randolf> xRavenheart: What's your school project about? Bitcoin development?
572017-12-04T02:51:44 <luke-jr> xRavenheart: not here
582017-12-04T02:55:03 *** dqx has quit IRC
592017-12-04T02:55:28 <Randolf> luke-jr: You're right. However, they just contacted me via PM in response to my response, so they probably have a secondary account watching this channel (I suspect).
602017-12-04T02:58:48 <Dizzle> Randolf: he's here, rejoined. I think luke-jr was just suggesting he ask elsewhere, e.g. #bitcoin
612017-12-04T02:58:58 <sipa> i'm talking in PM to him
622017-12-04T03:00:58 *** baltakatei has quit IRC
632017-12-04T03:03:02 *** jb55 has quit IRC
642017-12-04T03:05:01 <xRavenheart> Ok guys, it seems like i should raise the question here instead of PM-ing
652017-12-04T03:06:01 <xRavenheart> Basically, im a final year student doing FYP and my project scope is to modify on an existing lightweight client by bringing in optimizations from other clients (full/lightweight).
662017-12-04T03:06:19 <Randolf> Dizzle: Ah, yes. I suggested that asking here may be appropriate since it might involve core development. I also suggested that they ask in the #bitcoin and ##altcoins channel.
672017-12-04T03:06:30 <xRavenheart> This optimization may be in any form such as block headers download, transacting speed, retrieving of wallet addresses, etc etc.
682017-12-04T03:06:33 *** zshlyk has quit IRC
692017-12-04T03:06:42 *** Chris_Stewart_5 has quit IRC
702017-12-04T03:07:03 <sipa> xRavenheart: you're welcome here to ask questions about bitcoin's design and operation
712017-12-04T03:07:07 <xRavenheart> E.g. For instance Bitcoin Core has optimizations 1,2 and Electrum has optimizations 3,4
722017-12-04T03:07:21 *** zshlyk has joined #bitcoin-core-dev
732017-12-04T03:07:21 <xRavenheart> I'm required to bring together these optimizations into one application
742017-12-04T03:07:32 <sipa> though as i told, most of that will not be applicable to other types of clients
752017-12-04T03:07:45 <xRavenheart> Is anyone able to first provide me with a clear architecture diagram of bitcoin?
762017-12-04T03:07:58 *** jb55 has joined #bitcoin-core-dev
772017-12-04T03:08:03 <xRavenheart> I've been trying to understand the system but it is way too broad and i have no clear idea of where to start
782017-12-04T03:08:09 <sipa> ii don't think that exists
792017-12-04T03:20:03 *** Chris_Stewart_5 has joined #bitcoin-core-dev
802017-12-04T03:25:29 *** zshlyk has quit IRC
812017-12-04T03:26:45 *** zshlyk has joined #bitcoin-core-dev
822017-12-04T03:30:05 *** Randolf has quit IRC
832017-12-04T03:37:35 *** Chris_Stewart_5 has quit IRC
842017-12-04T03:42:11 *** jb55 has quit IRC
852017-12-04T03:46:28 *** Randolf has joined #bitcoin-core-dev
862017-12-04T03:51:22 *** jb55 has joined #bitcoin-core-dev
872017-12-04T03:53:05 *** Randolf has quit IRC
882017-12-04T04:00:28 *** arubi has quit IRC
892017-12-04T04:01:25 *** arubi has joined #bitcoin-core-dev
902017-12-04T04:10:33 *** Krellan has quit IRC
912017-12-04T04:11:37 *** Krellan has joined #bitcoin-core-dev
922017-12-04T04:21:20 *** ghost43 has quit IRC
932017-12-04T04:21:20 *** zshlyk has quit IRC
942017-12-04T04:21:20 *** dermoth has quit IRC
952017-12-04T04:21:20 *** arubi has quit IRC
962017-12-04T04:21:35 *** ghost43 has joined #bitcoin-core-dev
972017-12-04T04:21:43 *** arubi has joined #bitcoin-core-dev
982017-12-04T04:23:08 *** zshlyk has joined #bitcoin-core-dev
992017-12-04T04:29:50 *** zshlyk has quit IRC
1002017-12-04T04:30:25 *** zshlyk has joined #bitcoin-core-dev
1012017-12-04T04:30:40 *** Randolf has joined #bitcoin-core-dev
1022017-12-04T04:31:38 *** Randolf has joined #bitcoin-core-dev
1032017-12-04T04:32:35 *** zshlyk has quit IRC
1042017-12-04T04:33:28 *** zshlyk has joined #bitcoin-core-dev
1052017-12-04T04:33:36 *** Krellan has quit IRC
1062017-12-04T05:08:33 *** roidster has joined #bitcoin-core-dev
1072017-12-04T05:08:38 *** roidster is now known as Guest94795
1082017-12-04T05:09:37 *** Guest94795 is now known as roidster
1092017-12-04T05:10:36 *** zshlyk has quit IRC
1102017-12-04T05:11:21 *** zshlyk has joined #bitcoin-core-dev
1112017-12-04T05:12:14 *** Dizzle has quit IRC
1122017-12-04T05:18:51 *** zshlyk has quit IRC
1132017-12-04T05:19:35 *** zshlyk has joined #bitcoin-core-dev
1142017-12-04T05:31:35 *** roidster_ has joined #bitcoin-core-dev
1152017-12-04T05:32:12 *** roidster has quit IRC
1162017-12-04T05:32:19 *** roidster_ is now known as roidster
1172017-12-04T05:32:48 *** roidster is now known as Guest84550
1182017-12-04T05:33:27 *** Guest84550 is now known as roidster
1192017-12-04T05:36:03 *** kilicu has joined #bitcoin-core-dev
1202017-12-04T05:36:41 <achow101> is there any particular reason that Core is using 26 GB of RAM during a reindex?
1212017-12-04T05:36:52 <achow101> (out of 32 available on my machine)
1222017-12-04T05:37:03 <gmaxwell> sipa: ^
1232017-12-04T05:37:04 <achow101> my dbcache is only set to 6000
1242017-12-04T05:37:10 <gmaxwell> achow101: master, right?
1252017-12-04T05:37:14 <achow101> gmaxwell: yeah
1262017-12-04T05:37:35 <gmaxwell> achow101: sipa saw this on his odroid too, thought it was a bug in master, but I think he had some reproduction problems.
1272017-12-04T05:37:45 <gmaxwell> It may be a leak that depends on particular dependency versions.
1282017-12-04T05:38:17 <achow101> I can consistently reproduce it by starting it, letting it go, and then waiting for my computer to freeze up.
1292017-12-04T05:38:26 <achow101> then reboot and repeat :/
1302017-12-04T05:41:49 <gmaxwell> any chance you could run in valgrind, let it obviously bloat up a bit then issue a clean stop? if it's a true leak valgrind will report it.
1312017-12-04T05:42:14 <achow101> Yeah, I'll do that once I reboot it again
1322017-12-04T05:42:19 <gmaxwell> (I'd bet it's not actually a true leak... we have far too little manual memory management for that to be likely... but worth checking)
1332017-12-04T05:44:01 <Randolf> I could try running bitcoind to confirm memory usage too -- I've got bitcoind v0.15.1 on Windows 10 (64-bit) handy.
1342017-12-04T05:44:10 <Randolf> Which command-line parameters are you using?
1352017-12-04T05:44:35 <gmaxwell> 0.15.1 doesn't exhibit this behavior in any testing we've seen so far.
1362017-12-04T05:44:43 <Randolf> Oh. Which version are you using?
1372017-12-04T05:45:01 <gmaxwell> git master... the current in-development stuff.
1382017-12-04T05:45:06 <Randolf> Oh. I see.
1392017-12-04T05:45:22 <achow101> Some build of master from sometime in the last few days
1402017-12-04T05:46:00 <achow101> This is fairly recent, I think it's from yesterday or the day before
1412017-12-04T05:46:05 *** brianhoffman has quit IRC
1422017-12-04T05:46:16 <achow101> Although maybe I only noticed it now because I had to reindex
1432017-12-04T05:46:33 <Randolf> Which OS are you running on?
1442017-12-04T05:46:41 <achow101> Ubuntu 17.10
1452017-12-04T05:47:08 <Randolf> Oh, I don't have that available. I have a NetBSD server I could run it on if you need an extra test run.
1462017-12-04T05:48:04 <Randolf> I'd have to get sync'd though because I don't have bitcoind running there now. Maybe I should see if I can get it going and get the sync started for now.
1472017-12-04T05:50:25 <achow101> also, i'm running bitcoin-qt right now, not bitcoind
1482017-12-04T05:50:54 *** brianhoffman has joined #bitcoin-core-dev
1492017-12-04T05:57:34 <Randolf> These servers don't have any GUI stuff installed. So I won't be able to try bitcoin-qt on them. But I could at least try bitcoin-qt on Windows 10 to confirm whether the same problem occurs cross-platform.
1502017-12-04T05:58:25 *** ufukkilic has joined #bitcoin-core-dev
1512017-12-04T05:58:32 *** kilicu has quit IRC
1522017-12-04T06:01:27 *** nsh has quit IRC
1532017-12-04T06:03:05 <achow101> btw I'm using commit 00d25e90db06149fa456b0a8f15b7b68005ff9c5 which is the current head of master
1542017-12-04T06:03:31 *** zshlyk has quit IRC
1552017-12-04T06:04:22 *** zshlyk has joined #bitcoin-core-dev
1562017-12-04T06:09:49 <achow101> gmaxwell, sipa: when did you observe this issue on the odroid?
1572017-12-04T06:13:17 *** nsh has joined #bitcoin-core-dev
1582017-12-04T06:13:39 *** Taek has quit IRC
1592017-12-04T06:13:50 *** Taek has joined #bitcoin-core-dev
1602017-12-04T06:15:11 *** Emcy has joined #bitcoin-core-dev
1612017-12-04T06:17:35 <Randolf> Hmm, I'm running into problems getting bitcoind compiled on NetBSD, but I've had problems getting other things to compile due to a learning curve on my part so I'll have to work on this. In the meantime, I'll look into commit 00d25e90db06149fa456b0a8f15b7b68005ff9c5 (as I continue to learn more
1622017-12-04T06:17:54 *** Emcy_ has quit IRC
1632017-12-04T06:19:25 <achow101> it might be useful to walk back through the commit history testing each merge until we get to one that doesn't exhibit the leak. that would then tell us what commit introduced the problem, in theory.
1642017-12-04T06:19:34 <achow101> although that will be very tedious to do
1652017-12-04T06:19:46 <sipa> achow101: i have a difficult time reproducing it; i just saw it twice
1662017-12-04T06:19:47 <Randolf> about GitHub) to see if there's something in there that I can test out on Windows.
1672017-12-04T06:19:56 <sipa> it would be asome if you can bisect
1682017-12-04T06:20:18 *** roidster has quit IRC
1692017-12-04T06:20:40 <achow101> sipa: I'm going to try that once I finish this valgrind test
1702017-12-04T06:20:45 <sipa> great
1712017-12-04T06:20:52 <achow101> but because it's valgrind, it's going slowly
1722017-12-04T06:20:55 <sipa> i do know 0.15.1 is unaffected
1732017-12-04T06:21:31 <achow101> will bisect work with 0.15.1 even though it is not part of master's commit history
1742017-12-04T06:22:23 <sipa> if not, you can always use the last common forking point between master and 0.15.1 is goof
1752017-12-04T06:22:36 <achow101> indeed
1762017-12-04T06:23:01 <sipa> *good, not goof
1772017-12-04T06:28:24 *** arubi has quit IRC
1782017-12-04T06:28:48 *** arubi has joined #bitcoin-core-dev
1792017-12-04T06:30:32 *** zshlyk has quit IRC
1802017-12-04T06:31:43 *** zshlyk has joined #bitcoin-core-dev
1812017-12-04T06:35:37 *** xRavenheart has quit IRC
1822017-12-04T06:38:23 <Varunram> achow101: If you set the dbcache in the GUI, you might be affected by this: #11788
1832017-12-04T06:38:24 <gribble> https://github.com/bitcoin/bitcoin/issues/11788 | Bitcoin-Qt (Settings) reports incorrect "Size of database cache" · Issue #11788 · bitcoin/bitcoin · GitHub
1842017-12-04T06:38:34 <achow101> Varunram: bitcoin.conf, not gui
1852017-12-04T06:38:44 <achow101> I don't use the gui for any settings at all
1862017-12-04T06:39:31 <Varunram> phew, along those messages, I read somewhere you were running qt, so..
1872017-12-04T06:39:58 <achow101> I do run qt for testing things, and I noticed this issue while running qt
1882017-12-04T06:40:05 <sipa> that's very unlikely to be related
1892017-12-04T06:40:16 <achow101> but I'm just running bitcoind in valgrind right now
1902017-12-04T06:40:22 <Varunram> yep, mostly not :) just wondered
1912017-12-04T06:47:02 *** ghost43 has quit IRC
1922017-12-04T06:47:17 *** ghost43 has joined #bitcoin-core-dev
1932017-12-04T07:01:10 <achow101> damn valgrind is slow
1942017-12-04T07:03:13 <eck> should be about 10x slower
1952017-12-04T07:03:53 <sipa> much worse for cryptographic code
1962017-12-04T07:04:07 <achow101> It's still in the rescanning part of init
1972017-12-04T07:04:32 <eck> the actual numbers depend on how many memory accesses you are doing, all of the instructions that hit main memory are "emulated"
1982017-12-04T07:04:53 <sipa> all instructions are emulated
1992017-12-04T07:05:00 <sipa> it's not like it's running in a VM
2002017-12-04T07:05:21 <sipa> but memory access get additional instrumentation
2012017-12-04T07:06:12 <eck> i thought it worked by rewriting all of the instructions that access main memory, and then sort of fusing the non-memory instructions, i read julian seward's paper on it a long time ago
2022017-12-04T07:06:28 <eck> but i certainly could be wrong
2032017-12-04T07:06:40 <sipa> hmm, so could i
2042017-12-04T07:06:45 *** jb55 has quit IRC
2052017-12-04T07:08:46 <sipa> i didn't know it was that advanced, actually but it certainly could be
2062017-12-04T07:13:48 <eck> in some cases it has to emulate cpu registers, in other cases the emulated cpu register may be the actual host cpu registers, section 3.4 http://www.valgrind.org/docs/valgrind2007.pdf
2072017-12-04T07:14:19 <eck> clearly if the registers need to be emulated the overhead will be quite high
2082017-12-04T07:23:48 *** zshlyk has quit IRC
2092017-12-04T07:24:39 *** zshlyk has joined #bitcoin-core-dev
2102017-12-04T07:26:17 *** jtimon has quit IRC
2112017-12-04T07:32:36 *** zshlyk has quit IRC
2122017-12-04T07:33:44 *** zshlyk has joined #bitcoin-core-dev
2132017-12-04T07:33:47 *** indistylo has joined #bitcoin-core-dev
2142017-12-04T07:34:20 *** roidster has joined #bitcoin-core-dev
2152017-12-04T07:34:52 *** roidster is now known as Guest82416
2162017-12-04T07:39:07 *** Ylbam has joined #bitcoin-core-dev
2172017-12-04T07:44:34 *** arubi has quit IRC
2182017-12-04T07:44:37 *** arubi_ has joined #bitcoin-core-dev
2192017-12-04T07:47:47 *** Guest82416 has quit IRC
2202017-12-04T07:48:09 <Randolf> Well, I was unsuccessful at getting bitcoind to compile on NetBSD because of problems with Berkeley DB API function naming, and Boost incompatibility problems. I'll have to try again when get some more time (and I will try again).
2212017-12-04T07:52:40 *** meshcollider has joined #bitcoin-core-dev
2222017-12-04T08:07:34 *** gwillen has quit IRC
2232017-12-04T08:07:53 <eck> fyi if you run configure with --disable-wallet you don't need berkeleydb, which would just leave you to figure out boost
2242017-12-04T08:14:32 *** zshlyk has quit IRC
2252017-12-04T08:16:27 *** zshlyk has joined #bitcoin-core-dev
2262017-12-04T08:18:29 <achow101> I gave up on valgrind. It was doing the rescanning thing and moving at one percent per hour. I'm going to do the git bisect stuff tomorrow
2272017-12-04T08:27:29 <eck> were you using massif or memcheck?
2282017-12-04T08:27:35 <achow101> memcheck
2292017-12-04T08:27:50 <eck> massif will just straight up tell you at any given point of time, where all the allocations came from
2302017-12-04T08:28:26 <eck> which is useful if you can't wait for the program to run to completion
2312017-12-04T08:28:56 <eck> iirc it's even slower than memcheck though
2322017-12-04T08:28:58 <achow101> the problem was that it wasn't getting passed the init part. the leak is definitely coming from somwehere past the init part
2332017-12-04T08:30:07 <eck> i have heard that ASAN is faster than valgrind but i haven't used it
2342017-12-04T08:30:18 <eck> http://www.chromium.org/developers/testing/addresssanitizer http://www.chromium.org/developers/testing/leaksanitizer
2352017-12-04T08:30:20 <eck> it's built into vlang
2362017-12-04T08:30:22 <eck> *clang
2372017-12-04T08:31:37 <eck> this is for a rescan?
2382017-12-04T08:32:44 <achow101> reindex
2392017-12-04T08:33:07 <achow101> the rescan I think is part of the reindex because the reindex was killed before it flushed
2402017-12-04T08:35:00 <eck> i might take a look at that this week (if i can reproduce it), i was interested in generally profiling bitocind -reindex using systemtap
2412017-12-04T08:37:24 <achow101> made an issue for this #11822
2422017-12-04T08:37:26 <gribble> https://github.com/bitcoin/bitcoin/issues/11822 | Severe memory leak on current master · Issue #11822 · bitcoin/bitcoin · GitHub
2432017-12-04T08:48:31 *** noglar_ has quit IRC
2442017-12-04T08:59:25 <Randolf> eck: Thanks. There's an incompatibility because I have the wrong version of Boost.
2452017-12-04T09:00:09 <eck> it is pretty straightforward to build, if you have the patience
2462017-12-04T09:01:10 *** noglar_ has joined #bitcoin-core-dev
2472017-12-04T09:01:32 <Randolf> eck: I have plenty of patience, but my problem is meeting other deadlines at the moment so I've put this on hold for now. I also need to learn more about compiling.
2482017-12-04T09:07:02 *** timothy has joined #bitcoin-core-dev
2492017-12-04T09:13:02 *** laurentmt has joined #bitcoin-core-dev
2502017-12-04T09:13:48 *** timothy has joined #bitcoin-core-dev
2512017-12-04T09:17:07 <achow101> I fairly quick and rather unscientific git bisect says that e545dedf72bff2bd41c93c93eb576929fce37112 is the commit that introduces the problem.
2522017-12-04T09:17:39 <achow101> so if you want to investigate, that commit and commits in its vicinity should be looked at. But I need to sleep, so I'll look at it tomorrow.
2532017-12-04T09:18:06 *** eck has quit IRC
2542017-12-04T09:18:36 *** eck has joined #bitcoin-core-dev
2552017-12-04T09:18:55 *** tiagotrs has joined #bitcoin-core-dev
2562017-12-04T09:29:36 *** zshlyk has quit IRC
2572017-12-04T09:34:07 *** rtm1046 has joined #bitcoin-core-dev
2582017-12-04T09:35:31 *** zshlyk has joined #bitcoin-core-dev
2592017-12-04T09:38:51 *** promag has joined #bitcoin-core-dev
2602017-12-04T09:53:37 *** rtm1046 has quit IRC
2612017-12-04T09:55:14 *** ghost43 has quit IRC
2622017-12-04T09:55:17 *** ufukkilic has quit IRC
2632017-12-04T09:55:50 *** ghost43 has joined #bitcoin-core-dev
2642017-12-04T09:57:51 *** go1111111 has quit IRC
2652017-12-04T10:01:38 *** go1111111 has joined #bitcoin-core-dev
2662017-12-04T10:10:42 *** warxhead has quit IRC
2672017-12-04T10:14:33 *** zshlyk has quit IRC
2682017-12-04T10:15:37 *** zshlyk has joined #bitcoin-core-dev
2692017-12-04T10:16:12 *** ghost43 has quit IRC
2702017-12-04T10:26:50 *** ghost43 has joined #bitcoin-core-dev
2712017-12-04T10:32:42 *** go1111111 has quit IRC
2722017-12-04T10:48:10 *** dermoth has joined #bitcoin-core-dev
2732017-12-04T10:48:27 *** mryandao has quit IRC
2742017-12-04T10:48:56 *** jtimon has joined #bitcoin-core-dev
2752017-12-04T10:50:12 *** arubi_ has quit IRC
2762017-12-04T10:50:32 *** arubi has joined #bitcoin-core-dev
2772017-12-04T10:54:39 *** zshlyk has quit IRC
2782017-12-04T10:55:25 *** zshlyk has joined #bitcoin-core-dev
2792017-12-04T11:04:03 *** mryandao has joined #bitcoin-core-dev
2802017-12-04T11:05:03 *** zshlyk has quit IRC
2812017-12-04T11:05:25 *** zshlyk has joined #bitcoin-core-dev
2822017-12-04T11:06:37 *** zshlyk has quit IRC
2832017-12-04T11:07:57 *** zshlyk has joined #bitcoin-core-dev
2842017-12-04T11:08:38 *** go1111111 has joined #bitcoin-core-dev
2852017-12-04T11:13:59 *** go1111111 has quit IRC
2862017-12-04T11:14:10 *** dqx has joined #bitcoin-core-dev
2872017-12-04T11:16:16 *** SopaXorzTaker has joined #bitcoin-core-dev
2882017-12-04T11:17:53 *** tiagotrs has quit IRC
2892017-12-04T11:18:29 *** dqx has quit IRC
2902017-12-04T11:18:29 *** Victorsueca has quit IRC
2912017-12-04T11:19:52 *** Victorsueca has joined #bitcoin-core-dev
2922017-12-04T11:29:22 *** mmhhtt has joined #bitcoin-core-dev
2932017-12-04T11:31:26 *** laurentmt has quit IRC
2942017-12-04T11:31:51 *** tiagotrs has joined #bitcoin-core-dev
2952017-12-04T11:32:21 *** dqx has joined #bitcoin-core-dev
2962017-12-04T11:32:22 <mmhhtt> Hello, Is there anyone knows to how can build a exchange market for other country? Is there any request from bitcoin company to me for making exc market?
2972017-12-04T11:33:13 <mmhhtt> also how can work payment for buy/sell btc for other country local money?
2982017-12-04T11:39:42 *** promag has quit IRC
2992017-12-04T11:43:21 *** dqx has quit IRC
3002017-12-04T11:45:12 *** go1111111 has joined #bitcoin-core-dev
3012017-12-04T12:04:52 *** dqx has joined #bitcoin-core-dev
3022017-12-04T12:08:22 *** str4d has quit IRC
3032017-12-04T12:13:43 <sipa> achow101: that's what i feared...
3042017-12-04T12:14:49 *** wxss has joined #bitcoin-core-dev
3052017-12-04T12:15:23 *** dqx has quit IRC
3062017-12-04T12:16:20 *** dqx has joined #bitcoin-core-dev
3072017-12-04T12:22:02 *** dqx has quit IRC
3082017-12-04T12:26:04 *** zshlyk has quit IRC
3092017-12-04T12:26:54 *** zshlyk has joined #bitcoin-core-dev
3102017-12-04T12:27:22 *** dabura667 has quit IRC
3112017-12-04T12:28:46 *** zshlyk has quit IRC
3122017-12-04T12:29:49 *** zshlyk has joined #bitcoin-core-dev
3132017-12-04T12:43:57 *** meshcollider has quit IRC
3142017-12-04T13:10:13 *** RK_ has joined #bitcoin-core-dev
3152017-12-04T13:11:01 <RK_> Hello
3162017-12-04T13:11:48 <RK_> I want to know about bitcoin
3172017-12-04T13:14:56 *** RK_ has quit IRC
3182017-12-04T13:17:14 *** dreamrunner has joined #bitcoin-core-dev
3192017-12-04T13:21:09 *** zshlyk has quit IRC
3202017-12-04T13:21:55 *** dreamrunner has quit IRC
3212017-12-04T13:21:55 *** zshlyk has joined #bitcoin-core-dev
3222017-12-04T13:23:31 *** laurentmt has joined #bitcoin-core-dev
3232017-12-04T13:25:34 *** laurentmt has quit IRC
3242017-12-04T13:25:35 *** zshlyk has quit IRC
3252017-12-04T13:26:45 *** zshlyk has joined #bitcoin-core-dev
3262017-12-04T13:28:11 <mmhhtt> #bitcoin-core-dev
3272017-12-04T13:28:16 <mmhhtt> hello
3282017-12-04T13:28:39 <mmhhtt> Is there any one?
3292017-12-04T13:30:12 *** mmhhtt has quit IRC
3302017-12-04T13:47:13 *** jtimon has quit IRC
3312017-12-04T13:49:33 *** dermoth has quit IRC
3322017-12-04T13:50:42 *** dermoth has joined #bitcoin-core-dev
3332017-12-04T13:51:27 *** tiagotrs has quit IRC
3342017-12-04T13:52:42 *** laurentmt has joined #bitcoin-core-dev
3352017-12-04T13:54:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3362017-12-04T13:57:10 *** promag has joined #bitcoin-core-dev
3372017-12-04T14:03:35 *** zshlyk has quit IRC
3382017-12-04T14:04:30 *** zshlyk has joined #bitcoin-core-dev
3392017-12-04T14:11:40 *** zshlyk has quit IRC
3402017-12-04T14:12:22 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3412017-12-04T14:12:22 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3422017-12-04T14:12:39 *** notabot_ has joined #bitcoin-core-dev
3432017-12-04T14:12:55 *** zshlyk has joined #bitcoin-core-dev
3442017-12-04T14:16:45 <notabot_> mmhhtt: try #bitcoin channel or reddit
3452017-12-04T14:17:37 <notabot_> RK_: bitcoin.org is the best place to start.
3462017-12-04T14:17:57 *** notabot_ has quit IRC
3472017-12-04T14:24:17 *** Murphy40Hermann has joined #bitcoin-core-dev
3482017-12-04T14:29:27 *** Chris_Stewart_5 has quit IRC
3492017-12-04T14:32:24 *** rafalcpp has quit IRC
3502017-12-04T14:32:45 *** rafalcpp has joined #bitcoin-core-dev
3512017-12-04T14:33:20 *** laurentmt has quit IRC
3522017-12-04T14:43:20 *** CubicEarth has joined #bitcoin-core-dev
3532017-12-04T14:46:55 *** arubi has quit IRC
3542017-12-04T14:48:07 *** arubi has joined #bitcoin-core-dev
3552017-12-04T14:49:23 *** dqx has joined #bitcoin-core-dev
3562017-12-04T14:53:27 *** dqx has quit IRC
3572017-12-04T14:54:21 *** CubicEarth has quit IRC
3582017-12-04T15:02:08 *** indistylo has quit IRC
3592017-12-04T15:07:32 *** dqx has joined #bitcoin-core-dev
3602017-12-04T15:08:10 *** izadev has joined #bitcoin-core-dev
3612017-12-04T15:08:38 *** izadev has quit IRC
3622017-12-04T15:09:31 *** dqx has quit IRC
3632017-12-04T15:10:57 *** Victorsueca has quit IRC
3642017-12-04T15:11:22 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3652017-12-04T15:11:59 *** Chris_Stewart_5 has quit IRC
3662017-12-04T15:12:09 *** Victorsueca has joined #bitcoin-core-dev
3672017-12-04T15:19:29 *** wxss has quit IRC
3682017-12-04T15:24:46 *** roidster has joined #bitcoin-core-dev
3692017-12-04T15:24:46 *** roidster is now known as Guest37184
3702017-12-04T15:25:27 *** Guest37184 is now known as roidster
3712017-12-04T15:26:25 *** zshlyk has quit IRC
3722017-12-04T15:26:34 *** yoctopede has joined #bitcoin-core-dev
3732017-12-04T15:28:25 *** jtimon has joined #bitcoin-core-dev
3742017-12-04T15:32:54 *** saint_ has joined #bitcoin-core-dev
3752017-12-04T15:34:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3762017-12-04T15:39:51 *** laurentmt has joined #bitcoin-core-dev
3772017-12-04T15:41:39 *** yoctopede has quit IRC
3782017-12-04T15:42:23 *** yoctopede has joined #bitcoin-core-dev
3792017-12-04T15:54:24 *** Murch has joined #bitcoin-core-dev
3802017-12-04T16:00:09 *** tiagotrs has joined #bitcoin-core-dev
3812017-12-04T16:00:10 *** tiagotrs has joined #bitcoin-core-dev
3822017-12-04T16:03:02 *** yoctopede has quit IRC
3832017-12-04T16:03:54 *** yoctopede has joined #bitcoin-core-dev
3842017-12-04T16:04:09 <BlueMatt> sipa: #11403 looks to have failed travis to to a bad iterator deref ( https://travis-ci.org/bitcoin/bitcoin/jobs/309801879#L2838 )
3852017-12-04T16:04:14 <gribble> https://github.com/bitcoin/bitcoin/issues/11403 | SegWit wallet support by sipa · Pull Request #11403 · bitcoin/bitcoin · GitHub
3862017-12-04T16:05:23 *** roidster has quit IRC
3872017-12-04T16:06:53 *** wxss has joined #bitcoin-core-dev
3882017-12-04T16:07:41 *** yoctopede has quit IRC
3892017-12-04T16:08:29 *** yoctopede has joined #bitcoin-core-dev
3902017-12-04T16:23:07 *** Guyver2 has joined #bitcoin-core-dev
3912017-12-04T16:25:11 *** Emcy_ has joined #bitcoin-core-dev
3922017-12-04T16:26:26 *** promag has quit IRC
3932017-12-04T16:26:38 *** wxss has quit IRC
3942017-12-04T16:27:45 *** wxss has joined #bitcoin-core-dev
3952017-12-04T16:28:41 *** roidster has joined #bitcoin-core-dev
3962017-12-04T16:28:51 *** Emcy has quit IRC
3972017-12-04T16:29:04 *** roidster is now known as Guest290
3982017-12-04T16:29:05 *** Guest290 is now known as roidster
3992017-12-04T16:40:32 *** Dizzle has joined #bitcoin-core-dev
4002017-12-04T16:49:12 *** roidster_ has joined #bitcoin-core-dev
4012017-12-04T16:49:41 *** roidster has quit IRC
4022017-12-04T16:49:44 *** roidster_ is now known as roidster
4032017-12-04T16:49:47 *** Randolf has quit IRC
4042017-12-04T16:59:22 *** AaronvanW has joined #bitcoin-core-dev
4052017-12-04T17:00:26 *** Murphy40Hermann has quit IRC
4062017-12-04T17:00:32 *** Aaronvan_ has joined #bitcoin-core-dev
4072017-12-04T17:04:22 *** AaronvanW has quit IRC
4082017-12-04T17:14:32 *** musalbas has quit IRC
4092017-12-04T17:25:42 *** microapple has joined #bitcoin-core-dev
4102017-12-04T17:26:36 *** yoctopede has quit IRC
4112017-12-04T17:27:01 *** promag has joined #bitcoin-core-dev
4122017-12-04T17:27:47 *** yoctopede has joined #bitcoin-core-dev
4132017-12-04T17:30:55 *** Randolf has joined #bitcoin-core-dev
4142017-12-04T17:37:40 *** timothy has quit IRC
4152017-12-04T17:44:02 *** gevs has joined #bitcoin-core-dev
4162017-12-04T17:49:26 *** microapple has quit IRC
4172017-12-04T17:51:11 *** laurentmt has quit IRC
4182017-12-04T17:56:27 *** jb55 has joined #bitcoin-core-dev
4192017-12-04T17:58:19 *** indistylo has joined #bitcoin-core-dev
4202017-12-04T18:01:55 *** microapple has joined #bitcoin-core-dev
4212017-12-04T18:05:17 *** Randolf has quit IRC
4222017-12-04T18:08:21 *** jb55 has quit IRC
4232017-12-04T18:16:21 *** Emcy has joined #bitcoin-core-dev
4242017-12-04T18:18:22 *** Emcy_ has quit IRC
4252017-12-04T18:22:37 *** yoctopede has quit IRC
4262017-12-04T18:23:37 *** yoctopede has joined #bitcoin-core-dev
4272017-12-04T18:23:58 *** Randolf has joined #bitcoin-core-dev
4282017-12-04T18:26:59 <BlueMatt> wumpus: I believe #10773 can be merge
4292017-12-04T18:27:00 <BlueMatt> d
4302017-12-04T18:27:01 <gribble> https://github.com/bitcoin/bitcoin/issues/10773 | Shell script cleanups by practicalswift · Pull Request #10773 · bitcoin/bitcoin · GitHub
4312017-12-04T18:42:42 *** Randolf has quit IRC
4322017-12-04T18:44:27 *** Emcy_ has joined #bitcoin-core-dev
4332017-12-04T18:46:55 *** Emcy has quit IRC
4342017-12-04T18:47:11 <BlueMatt> achow101: ping
4352017-12-04T18:47:20 <BlueMatt> can you reliably reproduce #11822 ?
4362017-12-04T18:47:21 <gribble> https://github.com/bitcoin/bitcoin/issues/11822 | Severe memory leak on current master · Issue #11822 · bitcoin/bitcoin · GitHub
4372017-12-04T18:47:24 <achow101> BlueMatt: pong-ish
4382017-12-04T18:47:26 <achow101> yes
4392017-12-04T18:47:27 *** Emcy has joined #bitcoin-core-dev
4402017-12-04T18:48:08 *** gwillen has joined #bitcoin-core-dev
4412017-12-04T18:48:16 <achow101> I'm trying it in valgrind again, it's still going very slowly
4422017-12-04T18:49:05 *** Emcy_ has quit IRC
4432017-12-04T18:50:18 <BlueMatt> sec, I doubt its actually a leak, maybe just validation running ahead of wallet
4442017-12-04T18:50:22 <BlueMatt> do you have a big(ish) wallet?
4452017-12-04T18:51:06 <BlueMatt> achow101: can you try https://github.com/TheBlueMatt/bitcoin/tree/2017-12-11822-debug and see what debug log looks like?
4462017-12-04T18:51:16 <BlueMatt> do you get a ton of events generated and then not executed?
4472017-12-04T18:51:47 * BlueMatt didnt think this bug was realistically worse than previous master, but it may be, wasnt sure...
4482017-12-04T18:54:36 *** DvdKhl has joined #bitcoin-core-dev
4492017-12-04T18:55:49 *** yoctopede has quit IRC
4502017-12-04T18:56:36 *** yoctopede has joined #bitcoin-core-dev
4512017-12-04T19:00:43 *** yoctopede has quit IRC
4522017-12-04T19:01:34 *** yoctopede has joined #bitcoin-core-dev
4532017-12-04T19:02:40 <achow101> BlueMatt: the wallet is literally empty
4542017-12-04T19:02:50 <achow101> I haven't used it; it's completely fresh
4552017-12-04T19:02:56 <BlueMatt> but it has a wallet?
4562017-12-04T19:03:00 <achow101> yes
4572017-12-04T19:03:05 <BlueMatt> can you test with that patch? may be a lock issue or so
4582017-12-04T19:03:35 <achow101> I'll try as soon as it responds to the stop command
4592017-12-04T19:06:19 <GAit> am I correct if I say that the rpc doesn't support socket file?
4602017-12-04T19:06:48 <sipa> GAit: what rpc?
4612017-12-04T19:07:10 <GAit> bitcoin core rpc. Using a socket file rather than a port
4622017-12-04T19:07:46 <achow101> GAit: as in unix sockets?
4632017-12-04T19:07:49 <sipa> iirc there was a PR for that, but it needed a new version of libevent at the time
4642017-12-04T19:07:55 <BlueMatt> it does not (currently), I believe wumpus had some stuff to get it to work, but ...yea, libevent
4652017-12-04T19:08:03 <GAit> yes. Thinking because of Abcore. Other apps could connect to it.
4662017-12-04T19:08:17 <GAit> with a socket file i can prevent that. android app have a different user per app
4672017-12-04T19:08:21 *** SopaXorzTaker has quit IRC
4682017-12-04T19:08:23 <achow101> #9979
4692017-12-04T19:08:25 <gribble> https://github.com/bitcoin/bitcoin/issues/9979 | p2p: Bare minimum to support UNIX sockets by laanwj · Pull Request #9979 · bitcoin/bitcoin · GitHub
4702017-12-04T19:08:43 <achow101> and #9919
4712017-12-04T19:08:46 <gribble> https://github.com/bitcoin/bitcoin/issues/9919 | UNIX sockets support for RPC by laanwj · Pull Request #9919 · bitcoin/bitcoin · GitHub
4722017-12-04T19:08:46 <GAit> I managed to compile core for android with ndk by the way, which means i don't need the glibc hack + ld library path with archlinux/debian glibc
4732017-12-04T19:09:48 <GAit> thanks sipa & achow101
4742017-12-04T19:10:14 *** Emcy has quit IRC
4752017-12-04T19:12:07 <sipa> GAit: cool!
4762017-12-04T19:22:58 *** jb55 has joined #bitcoin-core-dev
4772017-12-04T19:24:32 *** yoctopede has quit IRC
4782017-12-04T19:24:55 *** intcat has joined #bitcoin-core-dev
4792017-12-04T19:29:33 <achow101> BlueMatt: running your patch now. what exactly do you want?
4802017-12-04T19:30:56 <BlueMatt> achow101: looking for a pattern of debug.log entries like a bunch of "X event queued!" but not (enough) corresponding "X event executing..."
4812017-12-04T19:30:56 <BlueMatt> s
4822017-12-04T19:31:02 <BlueMatt> (or just paste debug log
4832017-12-04T19:31:47 <achow101> eyballing this debug.log tail looks like each one is properly paired
4842017-12-04T19:31:57 <BlueMatt> hmmm, ok, so not the issue i assumed :(
4852017-12-04T19:32:00 <BlueMatt> but the memory is growing?
4862017-12-04T19:32:07 <achow101> yes
4872017-12-04T19:32:14 <BlueMatt> hmmmm
4882017-12-04T19:32:24 <achow101> not as quickly as yesterday since I dropped the dbcache, but growing much faster than it did with 0.15.1
4892017-12-04T19:32:25 <BlueMatt> ok, then its news to me, have you checked a heap profile?
4902017-12-04T19:32:39 <achow101> no
4912017-12-04T19:33:30 <BlueMatt> well i guess thats next? (did valgrind give you any actual leaks?)
4922017-12-04T19:33:36 <BlueMatt> i assuming circular shared_ptr refs
4932017-12-04T19:36:07 *** wunpunch has joined #bitcoin-core-dev
4942017-12-04T19:36:16 <achow101> valgrind... died
4952017-12-04T19:36:21 <achow101> (I killed it)
4962017-12-04T19:37:11 <BlueMatt> ah :/
4972017-12-04T19:38:01 <achow101> but while it was running it did not output anything
4982017-12-04T19:39:12 <achow101> I'll try it again and be more patient this time
4992017-12-04T19:42:23 *** tiagotrs has quit IRC
5002017-12-04T19:43:31 *** Emcy has joined #bitcoin-core-dev
5012017-12-04T19:51:58 <ryanofsky> it's pretty use address sanitizer too. just: "./configure CXX=clang++ CXXFLAGS=-fsanitize=address LDFLAGS=-fsanitize=address" and run normally. it prints leaks at the end
5022017-12-04T19:54:21 <BlueMatt> ugh, fuck you cfields, you sent me down a rabbit hole to replace cvBlockChanged with CValidationInterface, but I think I decided that has to wait on replacing the signals backend with our own thing
5032017-12-04T19:55:14 <BlueMatt> cause you really end up wanting the validation interface stuff to have eg two threads where the ordering guarantees are only made per-client, and each new client that gets connected only receives events generated *after* when it was connected
5042017-12-04T19:55:15 <cfields> BlueMatt: heh, sorry
5052017-12-04T19:55:38 <BlueMatt> (pretty easy to do, I think, you just make events eg a struct and put shared_ptrs to it in each listener's queue)
5062017-12-04T19:55:56 <BlueMatt> but its way more work than just fixing a fucking missing cs_main
5072017-12-04T19:56:08 <BlueMatt> and is gonna have to wait for 20 other higher-priority things
5082017-12-04T19:57:23 <achow101> ryanofsky: will try that at some point
5092017-12-04T19:57:30 <BlueMatt> the cvBlockChanged/csBestBlock garbage is....garbage now that we have "real interfaces" to get notifications of validation events
5102017-12-04T19:59:45 <cfields> BlueMatt: fwiw, i was picturing just adding a cached uint256 and a function to update it rather than notifying the cv directly
5112017-12-04T20:00:19 <BlueMatt> i know you were, but lets *please* not add more in-thread callbacks out of validation :(
5122017-12-04T20:00:28 <BlueMatt> I've been working too hard to get rid of those things
5132017-12-04T20:00:28 <cfields> i understand your point about using our interfaces. but weighing quick fix against quick fix, that seems better to me
5142017-12-04T20:00:46 <BlueMatt> meh, its a short cs_main, why not just take the cs_main
5152017-12-04T20:02:47 <cfields> i'm worried that we'll end up locked there for milliseconds where we wouldn't have otherwise. Granted, the re-locking of cs_main at the bottom kinda nullifies that argument.
5162017-12-04T20:03:03 <BlueMatt> yea, we re-lock anyway
5172017-12-04T20:03:21 <BlueMatt> and, more importantly no one uses longpolling anyway
5182017-12-04T20:03:22 <BlueMatt> afaiu
5192017-12-04T20:04:10 *** promag has quit IRC
5202017-12-04T20:04:25 *** promag has joined #bitcoin-core-dev
5212017-12-04T20:06:07 <BlueMatt> achow101: you said you can repro by just -reindex'ing?
5222017-12-04T20:06:13 <achow101> BlueMatt: yes
5232017-12-04T20:12:01 *** indistylo has quit IRC
5242017-12-04T20:12:51 *** intcat has quit IRC
5252017-12-04T20:13:36 *** intcat has joined #bitcoin-core-dev
5262017-12-04T20:14:07 *** gevs has quit IRC
5272017-12-04T20:24:51 *** Cheeseo has joined #bitcoin-core-dev
5282017-12-04T20:25:21 *** wunpunch has quit IRC
5292017-12-04T20:25:31 <BlueMatt> concept review on #11799 would be appreciated - ignore the code thats there, its useless, but the question is do we want negative-lock-annotations (ie you may not hold cs_main when calling function x) when they are only enforced if the lock is taken directly in the calling function (unlike the requires-lock annotations, these ones dont require you pollute your entire codebase to fully document locking states)
5302017-12-04T20:25:32 *** laurentmt has joined #bitcoin-core-dev
5312017-12-04T20:25:33 <gribble> https://github.com/bitcoin/bitcoin/issues/11799 | wallet: Add compile-time checking of (non-)locking assumptions for BlockUntilSyncedToCurrentChain() [wip] by practicalswift · Pull Request #11799 · bitcoin/bitcoin · GitHub
5322017-12-04T20:25:37 *** wunpunch has joined #bitcoin-core-dev
5332017-12-04T20:26:37 <BlueMatt> someone want to close #11823 as NOTABUG
5342017-12-04T20:26:38 <gribble> https://github.com/bitcoin/bitcoin/issues/11823 | Shouldnt this be nOut? · Issue #11823 · bitcoin/bitcoin · GitHub
5352017-12-04T20:27:35 *** laurentmt has quit IRC
5362017-12-04T20:29:30 <bitcoin-git> [bitcoin] practicalswift closed pull request #11799: wallet: Add compile-time checking of (non-)locking assumptions for BlockUntilSyncedToCurrentChain() [wip] (master...BlockUntilSyncedToCurrentChain-compile-time-warnings) https://github.com/bitcoin/bitcoin/pull/11799
5372017-12-04T20:30:38 *** intcat has quit IRC
5382017-12-04T20:31:52 *** intcat has joined #bitcoin-core-dev
5392017-12-04T20:35:06 *** arubi has quit IRC
5402017-12-04T20:35:30 *** arubi has joined #bitcoin-core-dev
5412017-12-04T20:40:19 <achow101> hmm. valgrind didn't turn up with anything too frightetning, nor did the address sanitizer
5422017-12-04T20:40:46 <achow101> only 160 bytes leaked (granted I only ran then for ~10 minutes each)
5432017-12-04T20:42:36 <BlueMatt> achow101: nvm, i got it
5442017-12-04T20:42:37 *** promag has quit IRC
5452017-12-04T20:42:47 <achow101> .. ok?
5462017-12-04T20:43:59 <achow101> BlueMatt: got it as in reproduced or found the leak?
5472017-12-04T20:44:20 <BlueMatt> working on fix
5482017-12-04T20:44:20 <BlueMatt> sec
5492017-12-04T20:54:41 <BlueMatt> achow101: heh, well maybe I didnt have it, can repro and ran into a seemingly-related bug, however
5502017-12-04T20:58:48 *** jnewbery_ is now known as jnewbery
5512017-12-04T21:01:10 *** Aaronvan_ is now known as AaronvanW
5522017-12-04T21:05:09 <BlueMatt> achow101: nope, nvm, my first guess was right
5532017-12-04T21:05:48 <sipa> BlueMatt: care to elaborate?
5542017-12-04T21:06:20 <BlueMatt> validation running ahead of validationinterface, you end up with a deep queue of shared_ptr<CBlock>s of all the shit you connected
5552017-12-04T21:06:36 <BlueMatt> not normally an issue, but reindex is particularly easy to hit there
5562017-12-04T21:07:09 <sipa> i would guess the solution is to block progress if the queue gets too long?
5572017-12-04T21:07:31 <BlueMatt> indeed
5582017-12-04T21:08:33 *** tiagotrs has joined #bitcoin-core-dev
5592017-12-04T21:10:24 <achow101> BlueMatt: oh, I see now. so that's probably why valgrind and address sanitizer wasn't catching it
5602017-12-04T21:11:02 <BlueMatt> its not a leak, thats why :p
5612017-12-04T21:11:08 <BlueMatt> just an unbounded queue
5622017-12-04T21:12:15 <achow101> was my git bisect correct?
5632017-12-04T21:12:21 <BlueMatt> yes
5642017-12-04T21:12:28 <achow101> :D
5652017-12-04T21:14:54 *** intcat has quit IRC
5662017-12-04T21:16:41 *** intcat has joined #bitcoin-core-dev
5672017-12-04T21:17:49 *** tiagotrs has quit IRC
5682017-12-04T21:17:50 *** tiagotrs has joined #bitcoin-core-dev
5692017-12-04T21:18:10 *** Victorsueca has quit IRC
5702017-12-04T21:19:24 *** Victorsueca has joined #bitcoin-core-dev
5712017-12-04T21:19:30 *** roidster has quit IRC
5722017-12-04T21:24:32 *** Randolf has joined #bitcoin-core-dev
5732017-12-04T21:24:34 *** rhavar has joined #bitcoin-core-dev
5742017-12-04T21:32:15 *** shesek has quit IRC
5752017-12-04T21:41:42 <cfields> BlueMatt: Hmm. doesn't that imply that at the time something (say wallet) is running a callback, chainActive's tip could've progressed significantly past the payload block?
5762017-12-04T21:42:07 <BlueMatt> cfields: yes, but that was always assumed to be allowed?
5772017-12-04T21:43:08 *** Emcy_ has joined #bitcoin-core-dev
5782017-12-04T21:43:28 <BlueMatt> cfields: heh, you're gonna murder me...the "quick fix" for this requires a net_processing-specific CNode boolean to be added :/
5792017-12-04T21:43:37 <cfields> BlueMatt: how would that have manifested before moving to the scheduler thread?
5802017-12-04T21:43:50 <BlueMatt> well, the "super quick fix" is to add a bunch of std::this_thread::yield()s, butttt....
5812017-12-04T21:44:08 <BlueMatt> cfields: it wouldnt have, cause the calls are all on the thread that is generating the events
5822017-12-04T21:44:46 <cfields> BlueMatt: right. I'm trying to reconsile that with "yes, but that was always assumed to be allowed?"
5832017-12-04T21:45:17 <BlueMatt> oh, sorry, yes, just meant that that is the design of validationinterface now
5842017-12-04T21:45:30 <BlueMatt> ie shouldnt be news if you reviewed the last 5 prs :p
5852017-12-04T21:45:41 *** Emcy has quit IRC
5862017-12-04T21:46:21 <cfields> well i didn't have this issue in mind, as I was still thinking too serially. Now I need to go re-review :(
5872017-12-04T21:46:39 <BlueMatt> heh, sorry
5882017-12-04T21:46:42 *** jamesob has joined #bitcoin-core-dev
5892017-12-04T21:46:44 <cfields> *synchronously
5902017-12-04T21:48:51 *** shesek has joined #bitcoin-core-dev
5912017-12-04T21:48:52 *** shesek has joined #bitcoin-core-dev
5922017-12-04T21:49:15 *** r0d3r5 has joined #bitcoin-core-dev
5932017-12-04T21:52:40 *** r0d3r5 has quit IRC
5942017-12-04T22:01:30 *** ds4tews has joined #bitcoin-core-dev
5952017-12-04T22:06:07 *** ds4tews has quit IRC
5962017-12-04T22:10:56 *** intcat has quit IRC
5972017-12-04T22:11:43 *** intcat has joined #bitcoin-core-dev
5982017-12-04T22:19:39 *** intcat has quit IRC
5992017-12-04T22:20:53 *** intcat has joined #bitcoin-core-dev
6002017-12-04T22:20:53 *** meshcollider has joined #bitcoin-core-dev
6012017-12-04T22:43:57 *** Randolf has quit IRC
6022017-12-04T22:44:17 *** Chris_Stewart_5 has quit IRC
6032017-12-04T22:44:28 *** promag has joined #bitcoin-core-dev
6042017-12-04T22:47:05 *** Cogito_Ergo_Sum has quit IRC
6052017-12-04T22:51:15 <cfields> BlueMatt: see: SyncTransaction -> AddToWalletIfInvolvingMe -> MarkConflicted. That ends up testing against chainActive for conflicts rather than the view from the callback :(
6062017-12-04T22:52:37 <BlueMatt> cfields: heh, I know :(
6072017-12-04T22:53:04 <BlueMatt> oh, wait, sec
6082017-12-04T22:53:09 <BlueMatt> missed your point, sorry
6092017-12-04T22:54:25 *** jb55 has quit IRC
6102017-12-04T22:54:39 *** Cheeseo has quit IRC
6112017-12-04T22:54:59 <cfields> BlueMatt: assuming the callbacks are lagging and chainActive is significantly ahead, MarkConflicted could be looking for conflicts on some future (or reorg'd) chain
6122017-12-04T22:56:15 <cfields> (i'm just looking around for things that could accidentally be using chainActive on the callback thread)
6132017-12-04T23:01:53 *** JackH has quit IRC
6142017-12-04T23:14:36 <jamesob> cfields: you're looking into the shared_ptr<CBlock> backup?
6152017-12-04T23:15:32 *** bule has joined #bitcoin-core-dev
6162017-12-04T23:15:58 <cfields> just having another look over the change that moves the validatioininterface callbacks to the scheduler thread. I guess that's what you mean?
6172017-12-04T23:16:06 <jamesob> yeah
6182017-12-04T23:16:43 *** Guyver2 has quit IRC
6192017-12-04T23:17:40 <jamesob> didn't know if there was a particular fix in mind for that yet
6202017-12-04T23:23:01 *** tiagotrs has quit IRC
6212017-12-04T23:23:42 *** Victorsueca has quit IRC
6222017-12-04T23:24:41 *** intcat has quit IRC
6232017-12-04T23:24:54 *** Victorsueca has joined #bitcoin-core-dev
6242017-12-04T23:25:34 *** intcat has joined #bitcoin-core-dev
6252017-12-04T23:25:43 *** intcat has quit IRC
6262017-12-04T23:26:26 *** intcat has joined #bitcoin-core-dev
6272017-12-04T23:29:40 *** intcat has quit IRC
6282017-12-04T23:30:15 *** Dizzle has quit IRC
6292017-12-04T23:30:28 *** intcat has joined #bitcoin-core-dev
6302017-12-04T23:30:36 <sipa> BlueMatt, cfields: if the wallet notifications can lag behind chainActive, the wallet needs its own "tip" to test against, no?
6312017-12-04T23:34:50 <BlueMatt> cfields: sorry, was just finishing the queue-drain branch...I do not believe that to be an issue? Specifically, in the conflicted case you mention here, the only way to hit it is if the wallet lags behind and the block that made a transaction conflict is already reorg'd off the main chain, in which case you dont want to mark it conflicted, and if its still gonna be conflicted once you get to the best chain a later callback will mark
6322017-12-04T23:34:50 <BlueMatt> it conflicted appropriately
6332017-12-04T23:34:54 <BlueMatt> jamesob: yes, I have a branch
6342017-12-04T23:35:31 <BlueMatt> sipa: I do not believe that to be the case (currently), please prove me wrong!
6352017-12-04T23:36:10 <achow101> BlueMatt: cfields: are you working on the fix for the queue thing or something else?
6362017-12-04T23:36:37 <BlueMatt> achow101: yes
6372017-12-04T23:36:48 <BlueMatt> though cfields is trying to find other issues in the original pr
6382017-12-04T23:36:52 <achow101> ok
6392017-12-04T23:38:22 <sipa> BlueMatt: it certainly sounds safer...
6402017-12-04T23:38:46 <cfields> sipa: agreed
6412017-12-04T23:39:23 <BlueMatt> sipa: I agree, but to do that you'd rewrite about another 10 functions in the wallet and probably end up refactoring half of it
6422017-12-04T23:39:27 <BlueMatt> (again, please prove me wrong :p)
6432017-12-04T23:39:49 <cfields> even if the conflicts aren't an issue, i still really don't like that we're testing against some seemingly random chain
6442017-12-04T23:40:12 <BlueMatt> well in that one specific case its fine (and kinda the way the function was written to begin with, strangely)
6452017-12-04T23:40:12 <sipa> BlueMatt: hmm, really? I would just replace every call to chainActive in the wallet with a local variable, which gets updated through the callbac
6462017-12-04T23:40:23 <cfields> BlueMatt: at least for the stuff affected by callbacks, can't we just pass a pindex around instead?
6472017-12-04T23:41:26 <BlueMatt> cfields: isnt that like the one place that matters from the callbacks (its been like 8 months since I've looked though)
6482017-12-04T23:41:58 <cfields> BlueMatt: unsure. I'll take a closer look before commenting further
6492017-12-04T23:41:58 <BlueMatt> sipa: the number of places I'd have to go read to make sure GetDepthInMainChain being disconnected from main chain is fine to be convinced of that is....high
6502017-12-04T23:42:07 <BlueMatt> sipa: though I'm sure ryanofsky would appreciate it greatly
6512017-12-04T23:44:01 <BlueMatt> sipa: the obvious issue is that gui would have to be aware of the wallet chain state
6522017-12-04T23:44:24 <sipa> right
6532017-12-04T23:44:45 <sipa> and if there's anything that looks at pcoinsTip from the wallet (is there?) that would also be affected
6542017-12-04T23:45:00 <BlueMatt> I dont think there is
6552017-12-04T23:45:32 *** jb55 has joined #bitcoin-core-dev
6562017-12-04T23:48:32 <BlueMatt> sipa: ReacceptWalletTransactions/RelayWalletTransactions would need a only-if-caught-up-to-main-chain condition, but thats the only obvious ones in wallet.cpp...it may be much easier than I thought, but I already have too many open prs to want to do it any time soon
6572017-12-04T23:51:31 *** wunpunch has quit IRC
6582017-12-04T23:52:27 *** D__ has joined #bitcoin-core-dev
6592017-12-04T23:52:29 <D__> Dd
6602017-12-04T23:52:38 *** bule2 has joined #bitcoin-core-dev
6612017-12-04T23:52:46 *** bule has quit IRC
6622017-12-04T23:52:50 *** D__ is now known as Guest72935
6632017-12-04T23:57:10 *** Guest72935 has quit IRC