12018-01-17T00:00:00 *** echelon has quit IRC
22018-01-17T00:00:52 *** echelon has joined #bitcoin-core-dev
32018-01-17T00:01:06 *** mandric has quit IRC
42018-01-17T00:05:19 *** Randolf has quit IRC
52018-01-17T00:08:08 *** owowo has quit IRC
62018-01-17T00:08:21 *** owowo has joined #bitcoin-core-dev
72018-01-17T00:12:34 *** Randolf has joined #bitcoin-core-dev
82018-01-17T00:13:07 *** Asa89Marvin has joined #bitcoin-core-dev
92018-01-17T00:14:56 *** vicenteH has quit IRC
102018-01-17T00:15:33 *** anome has quit IRC
112018-01-17T00:16:47 *** Chris_Stewart_5 has quit IRC
122018-01-17T00:27:16 *** promag has joined #bitcoin-core-dev
132018-01-17T00:28:22 <promag> is #12194 something to go in the next version?
142018-01-17T00:28:24 <gribble> https://github.com/bitcoin/bitcoin/issues/12194 | Add change type option to fundrawtransaction by promag · Pull Request #12194 · bitcoin/bitcoin · GitHub
152018-01-17T00:30:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
162018-01-17T00:31:17 *** wacawacawaca has joined #bitcoin-core-dev
172018-01-17T00:39:18 *** Victor_sueca has quit IRC
182018-01-17T00:40:26 *** Victor_sueca has joined #bitcoin-core-dev
192018-01-17T00:46:37 *** goatpig has quit IRC
202018-01-17T00:48:35 *** luke-jr has quit IRC
212018-01-17T00:48:52 *** luke-jr has joined #bitcoin-core-dev
222018-01-17T00:51:04 *** stevenroose_ has quit IRC
232018-01-17T00:52:26 *** stevenroose has joined #bitcoin-core-dev
242018-01-17T00:53:06 <meshcollider> do we want #11708 in 0.16 as well for better P2SH-P2WSH support or no
252018-01-17T00:53:08 <gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub
262018-01-17T00:57:35 *** wacawacawaca has quit IRC
272018-01-17T01:00:10 *** dabura667 has joined #bitcoin-core-dev
282018-01-17T01:04:36 *** belcher has quit IRC
292018-01-17T01:05:43 *** Tennis has quit IRC
302018-01-17T01:06:09 *** AaronvanW has quit IRC
312018-01-17T01:09:03 *** flokie has joined #bitcoin-core-dev
322018-01-17T01:10:01 *** jb55 has quit IRC
332018-01-17T01:10:13 *** YellowSphere has quit IRC
342018-01-17T01:18:30 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12206: qa: Have wallet wait for TransactionAddedToMempool (master...Mf1801-qaWalletMempoolAsync) https://github.com/bitcoin/bitcoin/pull/12206
352018-01-17T01:25:45 *** hirish is now known as hirishaway
362018-01-17T01:33:08 *** Randolf has quit IRC
372018-01-17T01:34:29 *** JackH has quit IRC
382018-01-17T01:37:49 *** ghost43 has quit IRC
392018-01-17T01:38:31 *** ghost43 has joined #bitcoin-core-dev
402018-01-17T01:44:26 *** mrannanay has quit IRC
412018-01-17T01:46:19 *** wacawacawaca has joined #bitcoin-core-dev
422018-01-17T01:51:01 *** wacawacawaca has quit IRC
432018-01-17T01:54:53 *** jb55 has joined #bitcoin-core-dev
442018-01-17T02:06:14 *** Krellan has quit IRC
452018-01-17T02:06:42 *** Krellan has joined #bitcoin-core-dev
462018-01-17T02:08:26 *** twoken has joined #bitcoin-core-dev
472018-01-17T02:09:55 *** echelon has quit IRC
482018-01-17T02:11:43 *** Krellan has quit IRC
492018-01-17T02:12:31 *** rattlnbones has joined #bitcoin-core-dev
502018-01-17T02:13:34 *** rattlnbones has quit IRC
512018-01-17T02:13:51 *** coincrispy has joined #bitcoin-core-dev
522018-01-17T02:16:55 *** Chris_Stewart_5 has quit IRC
532018-01-17T02:21:08 *** echelon has joined #bitcoin-core-dev
542018-01-17T02:28:53 *** Scrat has quit IRC
552018-01-17T02:30:11 *** intcat has quit IRC
562018-01-17T02:30:25 *** Chris_Stewart_5 has joined #bitcoin-core-dev
572018-01-17T02:33:29 *** intcat has joined #bitcoin-core-dev
582018-01-17T02:37:59 *** wxss has quit IRC
592018-01-17T02:39:40 *** ghost43 has quit IRC
602018-01-17T02:42:29 *** ula has quit IRC
612018-01-17T02:47:08 *** ghost43 has joined #bitcoin-core-dev
622018-01-17T02:49:06 *** Giszmo has joined #bitcoin-core-dev
632018-01-17T02:51:05 *** DarylSharp has joined #bitcoin-core-dev
642018-01-17T03:12:01 *** Randolf has joined #bitcoin-core-dev
652018-01-17T03:15:39 *** dabura667 has quit IRC
662018-01-17T03:18:03 *** Giszmo has quit IRC
672018-01-17T03:20:06 *** indistylo has joined #bitcoin-core-dev
682018-01-17T03:21:41 *** Chris_Stewart_5 has quit IRC
692018-01-17T03:29:18 *** jb55 has quit IRC
702018-01-17T03:31:10 *** aruns has joined #bitcoin-core-dev
712018-01-17T03:33:20 *** indistylo has quit IRC
722018-01-17T03:35:51 *** aruns has quit IRC
732018-01-17T03:46:02 *** jb55 has joined #bitcoin-core-dev
742018-01-17T03:59:31 *** tknp has quit IRC
752018-01-17T04:00:38 *** arubi has quit IRC
762018-01-17T04:01:41 *** arubi has joined #bitcoin-core-dev
772018-01-17T04:02:01 *** echelon has quit IRC
782018-01-17T04:06:27 *** dermoth has quit IRC
792018-01-17T04:07:50 *** jtimon has quit IRC
802018-01-17T04:35:12 *** rafalcpp_ has joined #bitcoin-core-dev
812018-01-17T04:35:35 *** rabidus has quit IRC
822018-01-17T04:35:35 *** boblee has quit IRC
832018-01-17T04:35:35 *** boblee has joined #bitcoin-core-dev
842018-01-17T04:35:37 *** rafalcpp has quit IRC
852018-01-17T04:36:22 *** rabidus has joined #bitcoin-core-dev
862018-01-17T04:42:50 *** tknp has joined #bitcoin-core-dev
872018-01-17T04:42:56 *** echelon has joined #bitcoin-core-dev
882018-01-17T04:47:00 *** rafalcpp__ has joined #bitcoin-core-dev
892018-01-17T04:47:29 *** rafalcpp_ has quit IRC
902018-01-17T04:58:43 *** arubi has quit IRC
912018-01-17T05:02:33 *** arubi has joined #bitcoin-core-dev
922018-01-17T05:18:27 <meshcollider> poor travis is still having a rest
932018-01-17T05:50:35 *** shesek has joined #bitcoin-core-dev
942018-01-17T05:57:50 *** arcz has joined #bitcoin-core-dev
952018-01-17T06:00:51 *** eck has joined #bitcoin-core-dev
962018-01-17T06:01:45 *** eck has joined #bitcoin-core-dev
972018-01-17T06:08:57 *** eck has quit IRC
982018-01-17T06:11:33 *** arcz has quit IRC
992018-01-17T06:20:13 <bitcoin-git> [bitcoin] CryptAxe opened pull request #12207: Start renaming functional tests & update test runner (master...updateTests) https://github.com/bitcoin/bitcoin/pull/12207
1002018-01-17T06:21:19 *** goksinen has quit IRC
1012018-01-17T06:21:25 *** goksinen has joined #bitcoin-core-dev
1022018-01-17T06:21:43 *** mrannanay has joined #bitcoin-core-dev
1032018-01-17T06:24:34 *** windsok has quit IRC
1042018-01-17T06:26:01 *** d9b4bef9 has quit IRC
1052018-01-17T06:27:08 *** d9b4bef9 has joined #bitcoin-core-dev
1062018-01-17T06:33:48 <bitcoin-git> [bitcoin] CryptAxe closed pull request #12207: Start renaming functional tests & update test runner (master...updateTests) https://github.com/bitcoin/bitcoin/pull/12207
1072018-01-17T06:49:04 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cad504bf4c30...062c8b69f4cc
1082018-01-17T06:49:04 <bitcoin-git> bitcoin/master 63ac890 Sjors Provoost: [qt] receive tab: bech32 address opt-in checkbox...
1092018-01-17T06:49:05 <bitcoin-git> bitcoin/master 062c8b6 Jonas Schnelli: Merge #11991: [qt] Receive: checkbox for bech32 address...
1102018-01-17T06:49:47 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11991: [qt] Receive: checkbox for bech32 address (master...segwit-qt-bech32-receive) https://github.com/bitcoin/bitcoin/pull/11991
1112018-01-17T06:56:31 *** daouzo23 has joined #bitcoin-core-dev
1122018-01-17T06:56:37 *** daouzo23 has quit IRC
1132018-01-17T06:58:38 *** tknp has quit IRC
1142018-01-17T07:03:54 <luke-jr> ⦠that tooltip kinda sucks. people don't spend from addresses :/
1152018-01-17T07:10:57 <sipa> luke-jr: improve it!
1162018-01-17T07:11:11 <luke-jr> working on it ;)
1172018-01-17T07:11:38 *** ryan-c has quit IRC
1182018-01-17T07:12:07 <luke-jr> I wonder if there's a nicer name than "Bech32" to use here
1192018-01-17T07:13:32 <jonasschnelli> luke-jr: 11937 uses "Native SegWit (Bech32)"
1202018-01-17T07:13:45 <jonasschnelli> s/B/b
1212018-01-17T07:14:53 <luke-jr> sgtm
1222018-01-17T07:15:05 <jonasschnelli> sipa: since you have commented on #11281 (0.16 milestone), I'd like to see your ack there...
1232018-01-17T07:15:09 <gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid permanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
1242018-01-17T07:18:02 <sipa> jonasschnelli: about to pack and fly, but i'm fine with the split of the cs if it's documented
1252018-01-17T07:18:19 <jonasschnelli> sipa: Okay. No hurry... thanks
1262018-01-17T07:26:10 <bitcoin-git> [bitcoin] luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default (master...gui_legacy_bech32) https://github.com/bitcoin/bitcoin/pull/12208
1272018-01-17T07:30:27 *** Krellan has joined #bitcoin-core-dev
1282018-01-17T07:30:39 *** Krellan has joined #bitcoin-core-dev
1292018-01-17T07:32:51 <meshcollider> sipa: may want to delete the weird comment here https://github.com/bitcoin/bitcoin/commit/d4aa54c5af925bd0ed81c7a9ffab457149e5d682#commitcomment-26900790
1302018-01-17T07:32:52 <jonasschnelli> luke-jrl: whats the reason to do that: https://github.com/bitcoin/bitcoin/pull/12208/files#diff-dd8e54f9b8311348e3abf1ecb65eda10R151?
1312018-01-17T07:33:14 <jonasschnelli> If someone wants Bech32, why override to OUTPUT_TYPE_P2SH_SEGWIT?
1322018-01-17T07:34:43 <sipa> meshcollider: can't do that right now (on phone)
1332018-01-17T07:34:54 <luke-jr> jonasschnelli: that's if the checkbox is unchecked
1342018-01-17T07:35:04 <luke-jr> if they have it set to Bech32, the checkbox is checked by default
1352018-01-17T07:35:04 <meshcollider> sipa: all good, sorry I posted that before I read your message about packing :)
1362018-01-17T07:35:12 <meshcollider> maybe jonasschnelli can then
1372018-01-17T07:35:37 <jonasschnelli> meshcollider: done
1382018-01-17T07:40:31 *** windsok has joined #bitcoin-core-dev
1392018-01-17T07:46:30 *** dabura667 has joined #bitcoin-core-dev
1402018-01-17T07:48:21 <luke-jr> should we bump libsecp256k1 for 0.16? not sure how big a deal the optimisations are
1412018-01-17T07:53:13 <sipa> i don't think there is anything very important
1422018-01-17T07:54:42 <jonasschnelli> luke-jr: I was just confuse that you called OUTPUT_TYPE_P2SH_SEGWIT legacy
1432018-01-17T07:55:42 <luke-jr> jonasschnelli: I did?
1442018-01-17T07:56:02 <jonasschnelli> <bitcoin-git> [bitcoin] luke-jr opened pull request #12208: GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default
1452018-01-17T07:56:04 <gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
1462018-01-17T07:56:19 <luke-jr> jonasschnelli: that's referring to the ability to use Bech32, if your addresstype=legacy
1472018-01-17T07:57:04 <jonasschnelli> Ah.. now I see.
1482018-01-17T07:59:02 <luke-jr> jonasschnelli: squashed
1492018-01-17T08:01:07 *** echelon has quit IRC
1502018-01-17T08:05:09 *** whphhg has quit IRC
1512018-01-17T08:07:54 *** whphhg has joined #bitcoin-core-dev
1522018-01-17T08:08:13 *** echelon has joined #bitcoin-core-dev
1532018-01-17T08:21:41 *** Cogito_Ergo_Sum has quit IRC
1542018-01-17T08:22:57 <gmaxwell> sipa: https://github.com/bitcoin/bitcoin/pull/11991#issuecomment-357039103 < this QR encoded Bech32 address is apparently truncated in the QR code itself and it doesn't appear to be in allcaps.
1552018-01-17T08:24:56 <gmaxwell> oh, I see, it's regtest, that threw me.
1562018-01-17T08:25:36 <gmaxwell> but it still isn't allcaps and should be.
1572018-01-17T08:28:35 *** gielbier has quit IRC
1582018-01-17T08:31:39 *** lnostdal has quit IRC
1592018-01-17T08:33:58 <gmaxwell> nevermind, I see there is a PR for that
1602018-01-17T08:36:09 <wumpus> only an issue
1612018-01-17T08:36:40 <gmaxwell> oh I see, issue. (ah, thats why I didn't previously see it on the PR list-- I was wondering how I missed it!)
1622018-01-17T08:39:33 *** promag has quit IRC
1632018-01-17T08:43:15 <jonasschnelli> gmaxwell: The QRCode truncation should be fixed in master
1642018-01-17T08:43:27 <jonasschnelli> #12173
1652018-01-17T08:43:29 <gribble> https://github.com/bitcoin/bitcoin/issues/12173 | [Qt] Use flexible font size for QRCode image address by jonasschnelli · Pull Request #12173 · bitcoin/bitcoin · GitHub
1662018-01-17T08:43:55 <jonasschnelli> allcaps is a different thing
1672018-01-17T08:44:32 *** atroxes has quit IRC
1682018-01-17T08:44:50 *** timothy has joined #bitcoin-core-dev
1692018-01-17T08:45:24 <gmaxwell> jonasschnelli: I was confused by the regtest prefix and thought the prefix was getting truncated.
1702018-01-17T08:47:12 <wumpus> probably want only the URL encoding to capitalize it, and not in other places like below the image
1712018-01-17T08:47:49 *** Victor_sueca is now known as Victorsueca
1722018-01-17T08:48:54 <gmaxwell> Personally I think allcaps monospace addresses usually look nicer, at least when presented in isolation. might want to look at it both ways before deciding.
1732018-01-17T08:49:16 *** drizztbsd has joined #bitcoin-core-dev
1742018-01-17T08:49:19 <wumpus> but I think caps are wider so it'd have to use an even smaller font
1752018-01-17T08:49:54 <gmaxwell> they're the same size in monospace font.
1762018-01-17T08:49:57 *** timothy has quit IRC
1772018-01-17T08:50:06 <wumpus> yes
1782018-01-17T08:51:21 *** jtimon has joined #bitcoin-core-dev
1792018-01-17T08:52:05 *** echelon has quit IRC
1802018-01-17T08:57:43 *** atroxes has joined #bitcoin-core-dev
1812018-01-17T08:58:07 *** trotski2000 has joined #bitcoin-core-dev
1822018-01-17T08:58:14 *** trotski2000 has quit IRC
1832018-01-17T08:58:14 *** trotski2000 has joined #bitcoin-core-dev
1842018-01-17T08:58:14 *** trotski2000 has quit IRC
1852018-01-17T08:58:14 *** trotski2000 has joined #bitcoin-core-dev
1862018-01-17T09:04:49 *** echelon has joined #bitcoin-core-dev
1872018-01-17T09:20:40 *** anome has joined #bitcoin-core-dev
1882018-01-17T09:32:54 *** eck has joined #bitcoin-core-dev
1892018-01-17T09:35:00 *** vicenteH has joined #bitcoin-core-dev
1902018-01-17T09:37:57 *** anome has quit IRC
1912018-01-17T09:42:54 *** eck has quit IRC
1922018-01-17T09:45:26 *** AriseChikun has quit IRC
1932018-01-17T09:45:53 *** shesek has quit IRC
1942018-01-17T09:46:19 *** AaronvanW has joined #bitcoin-core-dev
1952018-01-17T09:49:02 *** Krellan has quit IRC
1962018-01-17T09:49:56 *** Krellan has joined #bitcoin-core-dev
1972018-01-17T09:50:27 *** anuby has quit IRC
1982018-01-17T09:55:44 *** eck has joined #bitcoin-core-dev
1992018-01-17T10:02:16 *** anome has joined #bitcoin-core-dev
2002018-01-17T10:02:50 *** larafale has joined #bitcoin-core-dev
2012018-01-17T10:03:20 *** laurenwoods has joined #bitcoin-core-dev
2022018-01-17T10:04:19 *** laurenwoods has quit IRC
2032018-01-17T10:05:33 *** [Author] has quit IRC
2042018-01-17T10:07:33 *** anome has quit IRC
2052018-01-17T10:08:34 *** [Author] has joined #bitcoin-core-dev
2062018-01-17T10:08:35 *** jtimon has quit IRC
2072018-01-17T10:15:55 *** AaronvanW has quit IRC
2082018-01-17T10:16:33 *** AaronvanW has joined #bitcoin-core-dev
2092018-01-17T10:17:08 *** anome has joined #bitcoin-core-dev
2102018-01-17T10:18:57 *** goksinen has quit IRC
2112018-01-17T10:19:23 *** goksinen has joined #bitcoin-core-dev
2122018-01-17T10:23:48 *** eck has quit IRC
2132018-01-17T10:23:57 *** goksinen has quit IRC
2142018-01-17T10:30:04 *** anome has quit IRC
2152018-01-17T10:32:57 *** lnostdal has joined #bitcoin-core-dev
2162018-01-17T10:33:24 *** larafale has quit IRC
2172018-01-17T10:34:37 *** goksinen has joined #bitcoin-core-dev
2182018-01-17T10:35:11 *** Asa89Marvin has quit IRC
2192018-01-17T10:35:17 *** goksinen has quit IRC
2202018-01-17T10:35:32 *** goksinen has joined #bitcoin-core-dev
2212018-01-17T10:39:58 *** AaronvanW has quit IRC
2222018-01-17T10:41:58 *** AaronvanW has joined #bitcoin-core-dev
2232018-01-17T10:42:58 *** lnostdal has quit IRC
2242018-01-17T10:46:32 *** dabura667 has quit IRC
2252018-01-17T10:49:42 *** larafale has joined #bitcoin-core-dev
2262018-01-17T10:50:47 *** anome has joined #bitcoin-core-dev
2272018-01-17T10:57:30 *** lnostdal has joined #bitcoin-core-dev
2282018-01-17T11:02:03 *** tomatopeel has quit IRC
2292018-01-17T11:04:35 *** moctost has joined #bitcoin-core-dev
2302018-01-17T11:09:21 *** larafale has quit IRC
2312018-01-17T11:09:23 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/062c8b69f4cc...adce1de9a6ce
2322018-01-17T11:09:23 <bitcoin-git> bitcoin/master 49e5f3f Wladimir J. van der Laan: rpc: Add deprecation error for `getinfo`...
2332018-01-17T11:09:24 <bitcoin-git> bitcoin/master adce1de Wladimir J. van der Laan: Merge #12198: rpc: Add deprecation error for `getinfo`...
2342018-01-17T11:09:26 *** moctost has quit IRC
2352018-01-17T11:09:59 *** larafale has joined #bitcoin-core-dev
2362018-01-17T11:10:13 <bitcoin-git> [bitcoin] laanwj closed pull request #12198: rpc: Add deprecation error for `getinfo` (master...2018_01_getinfo_deprecation_message) https://github.com/bitcoin/bitcoin/pull/12198
2372018-01-17T11:13:07 *** Jaiden19Jakubows has joined #bitcoin-core-dev
2382018-01-17T11:14:27 *** larafale has quit IRC
2392018-01-17T11:16:02 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2402018-01-17T11:16:03 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2412018-01-17T11:16:25 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/adce1de9a6ce...c7978be89964
2422018-01-17T11:16:26 <bitcoin-git> bitcoin/master 0b63e3c Andrew Chow: Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds...
2432018-01-17T11:16:26 <bitcoin-git> bitcoin/master 134cdc7 Andrew Chow: Test walletpassphrase timeout bounds and clamping
2442018-01-17T11:16:27 <bitcoin-git> bitcoin/master c7978be Wladimir J. van der Laan: Merge #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds...
2452018-01-17T11:17:05 <bitcoin-git> [bitcoin] laanwj closed pull request #12101: Clamp walletpassphrase timeout to 2^30 seconds and check its bounds (master...wallet-unlock-time-int32) https://github.com/bitcoin/bitcoin/pull/12101
2462018-01-17T11:20:14 *** eck has joined #bitcoin-core-dev
2472018-01-17T11:23:32 *** eck has quit IRC
2482018-01-17T11:24:28 *** DarylSharp2 has joined #bitcoin-core-dev
2492018-01-17T11:24:36 *** promag has joined #bitcoin-core-dev
2502018-01-17T11:25:43 *** Cogito_Ergo_Sum has quit IRC
2512018-01-17T11:27:35 *** DarylSharp has quit IRC
2522018-01-17T11:27:44 *** drizztbsd is now known as timothy
2532018-01-17T11:30:56 *** wxss has joined #bitcoin-core-dev
2542018-01-17T11:36:32 *** promag has quit IRC
2552018-01-17T11:44:59 *** echelon has quit IRC
2562018-01-17T11:48:18 *** echelon has joined #bitcoin-core-dev
2572018-01-17T11:52:16 <meshcollider> What actually needs to be done for #11048, since its in the 0.16 milestone
2582018-01-17T11:52:17 <gribble> https://github.com/bitcoin/bitcoin/issues/11048 | Weird gettransaction details on testnet with segwit · Issue #11048 · bitcoin/bitcoin · GitHub
2592018-01-17T11:52:34 <meshcollider> do the current PRs resolve that or does it still need work
2602018-01-17T11:56:20 <gmaxwell> I think thats a non-issue.
2612018-01-17T11:56:31 <gmaxwell> non-change send to selfs are not hidden.
2622018-01-17T11:56:53 *** promag has joined #bitcoin-core-dev
2632018-01-17T11:57:03 <gmaxwell> otherwise a service with multiple users which sends funds on user commands would lose payments when one user sends to another user by address.
2642018-01-17T11:59:55 <luke-jr> I agree that looks as expected in RPC
2652018-01-17T12:00:20 <gmaxwell> (and 'custom change' to a non-change address is not treated as change)
2662018-01-17T12:01:09 <meshcollider> ok, wumpus or someone can remove it from the milestone then :)
2672018-01-17T12:01:19 <luke-jr> I really don't see the use case for 'custom change'.
2682018-01-17T12:02:16 <gmaxwell> I whined a bit about it when implemented. I could contrive up some for you, e.g. you're slowly migrating from one old wallet to a new one, and want all your change to go to the new one.
2692018-01-17T12:02:53 <gmaxwell> it's certantly an advanced feature.
2702018-01-17T12:03:15 <luke-jr> hmm, that's an interesting idea
2712018-01-17T12:03:45 <gmaxwell> I can't think of any other usecase.
2722018-01-17T12:04:04 <gmaxwell> oh sorry, I know another one but its bad.
2732018-01-17T12:04:17 <gmaxwell> E.g. user really insistant on keeping all their funds on a single address.
2742018-01-17T12:04:26 <gmaxwell> Which there can be justifications for, but they're still bad. :)
2752018-01-17T12:05:07 <wumpus> meshcollider: ok
2762018-01-17T12:05:29 *** larafale has joined #bitcoin-core-dev
2772018-01-17T12:10:41 <sipa> i can't ooen an issue now, but we should mark addwitnessaddress as deprecated
2782018-01-17T12:14:18 <gmaxwell> Does it do anything anymore?
2792018-01-17T12:14:59 <gmaxwell> meshcollider: I went and added some explination to that issue with the sends to self.
2802018-01-17T12:15:13 <meshcollider> gmaxwell: sounds good, thanks
2812018-01-17T12:15:44 <gmaxwell> meshcollider: thanks for bringing attention to it.
2822018-01-17T12:19:52 *** zautomata has joined #bitcoin-core-dev
2832018-01-17T12:20:01 <sipa> gmaxwell: it probably at least resets the address label
2842018-01-17T12:22:19 <wumpus> something like #12210?
2852018-01-17T12:22:20 <gribble> https://github.com/bitcoin/bitcoin/issues/12210 | wallet: Deprecate addwitnessaddress by laanwj · Pull Request #12210 · bitcoin/bitcoin · GitHub
2862018-01-17T12:22:22 <bitcoin-git> [bitcoin] laanwj opened pull request #12210: wallet: Deprecate addwitnessaddress (master...2018_01_deprecate_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/12210
2872018-01-17T12:29:34 *** CubicEarths has quit IRC
2882018-01-17T12:29:45 <meshcollider> ping kallewoof: are you going to reopen #11489 for 0.16?
2892018-01-17T12:29:47 <gribble> https://github.com/bitcoin/bitcoin/issues/11489 | [wallet] sendtoaddress style argument by kallewoof · Pull Request #11489 · bitcoin/bitcoin · GitHub
2902018-01-17T12:29:57 <meshcollider> to close #11134
2912018-01-17T12:29:58 <gribble> https://github.com/bitcoin/bitcoin/issues/11134 | Sendtoaddress flag for sending change to a segwit address? · Issue #11134 · bitcoin/bitcoin · GitHub
2922018-01-17T12:33:31 <meshcollider> wumpus: is that !IsDeprecatedRPCEnabled() stuff overkill for this case
2932018-01-17T12:33:32 *** gaf_ has quit IRC
2942018-01-17T12:34:09 <gmaxwell> probably, but uniformity is cheap.
2952018-01-17T12:34:37 <meshcollider> gmaxwell: I mean he hasn't currently used it, was wondering if that was a deliberate choice :)
2962018-01-17T12:34:48 <gmaxwell> ah!
2972018-01-17T12:35:48 <wumpus> meshcollider: how does that work?
2982018-01-17T12:36:12 <wumpus> FWIW I've added it to the release notes as well now
2992018-01-17T12:36:20 <meshcollider> wumpus: its the stuff which forces you to use -deprecatedrpc=addwitnessaddress argument to use it
3002018-01-17T12:36:45 <meshcollider> like estimatefee uses
3012018-01-17T12:36:53 <wumpus> oh I see, sure
3022018-01-17T12:36:56 <gmaxwell> might be premature to do that?
3032018-01-17T12:37:05 <gmaxwell> do we want it to immediately stop working without settings?
3042018-01-17T12:37:15 <gmaxwell> (I'm asking, no strong opinions)
3052018-01-17T12:37:19 <meshcollider> are we planning on removing it in 0.17?
3062018-01-17T12:37:29 *** wacawacawaca has joined #bitcoin-core-dev
3072018-01-17T12:37:40 <wumpus> I was assuming it would be removed in next major release, if not, should update the release notes :)
3082018-01-17T12:37:57 <meshcollider> It should be a trivial transition for most use cases I'd imagine, and it was always advertised as experimental so I'd say its fine how it is
3092018-01-17T12:38:02 <wumpus> waiting another release and going for 0.18 is fine with me too
3102018-01-17T12:38:09 <gmaxwell> yea, I suppose! if we're going to remove it in 0.17 then the disruptive choice is probably the right one.
3112018-01-17T12:38:24 <meshcollider> nah it shouldn't have gained enough use in this short timeframe to be necessary waiting another whole release
3122018-01-17T12:38:30 <meshcollider> i vote remove in 17
3132018-01-17T12:38:54 <gmaxwell> strangly I don't feel any cosmic force hurrying the removal of no-op RPCs. Perhaps one GOOD argument for going faster is this: people are going to keep following old "how to segwit" guides.
3142018-01-17T12:39:15 *** Guyver2 has joined #bitcoin-core-dev
3152018-01-17T12:39:34 <wumpus> gmaxwell: which is another good reason to use the IsDeprecatedRPCEnabled() stuff, I guess, as otherwise it will seem to just keep working a s intended
3162018-01-17T12:39:49 <gmaxwell> yes, exactly, sorry "going faster" wasn't clear.
3172018-01-17T12:39:59 <meshcollider> yeah users tend to ignore help text even if it is in caps ;)
3182018-01-17T12:40:12 <gmaxwell> banner blindness.
3192018-01-17T12:40:30 <wumpus> well, more that they'll not look at the help if they 'help' is some online or wiki guide
3202018-01-17T12:41:53 <gmaxwell> right, which is why its important to fail. I would sort of like if in general we start breaking interfaces a little faster, at least until we cause complaints. we've gone to far in the never breaking things direction for too long. :) and IsDeprecatedRPCEnabled is a pretty nice middle ground.
3212018-01-17T12:42:25 *** gaf_ has joined #bitcoin-core-dev
3222018-01-17T12:44:09 *** goatpig has joined #bitcoin-core-dev
3232018-01-17T12:55:13 *** promag has quit IRC
3242018-01-17T12:55:46 *** UnderDog_ has joined #bitcoin-core-dev
3252018-01-17T12:56:04 <UnderDog_> good morning
3262018-01-17T12:56:12 *** moctost has joined #bitcoin-core-dev
3272018-01-17T12:57:09 <meshcollider> UnderDog_: maybe for some ;)
3282018-01-17T12:57:25 *** AaronvanW has quit IRC
3292018-01-17T12:57:31 <UnderDog_> work got cancled today
3302018-01-17T12:57:34 <UnderDog_> bad freeze
3312018-01-17T12:58:08 <UnderDog_> i still woke up at 4am and so i decided to make a whiskey and do laundry
3322018-01-17T12:59:01 *** d9b4bef9 has quit IRC
3332018-01-17T12:59:45 <UnderDog_> i haven't used IRC in almost 20 years
3342018-01-17T13:00:08 *** d9b4bef9 has joined #bitcoin-core-dev
3352018-01-17T13:00:29 *** CubicEarths has joined #bitcoin-core-dev
3362018-01-17T13:00:30 <meshcollider> UnderDog_: I think you might be in the wrong channel, maybe try #bitcoin for general discussion on it, this channel is just for bitcoin core development
3372018-01-17T13:01:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3382018-01-17T13:01:05 *** anome has quit IRC
3392018-01-17T13:02:22 <UnderDog_> well i'm not part of the development team but I did not see another IRC available and thought I might be likely to find similar persons of interest here.
3402018-01-17T13:03:31 <sipa> #bitcoin may be a better place
3412018-01-17T13:04:19 <UnderDog_> ok
3422018-01-17T13:05:02 *** CubicEarths has quit IRC
3432018-01-17T13:05:11 <UnderDog_> only think I might be able to help with is thermodynamic's and heat extraction designs for your servers
3442018-01-17T13:05:27 <UnderDog_> no need ofr 's
3452018-01-17T13:05:29 <UnderDog_> for*
3462018-01-17T13:08:52 *** JackH has joined #bitcoin-core-dev
3472018-01-17T13:10:35 *** UnderDog_ has quit IRC
3482018-01-17T13:11:46 *** atroxes has quit IRC
3492018-01-17T13:12:00 *** atroxes has joined #bitcoin-core-dev
3502018-01-17T13:12:28 *** dermoth has joined #bitcoin-core-dev
3512018-01-17T13:12:38 *** atroxes has quit IRC
3522018-01-17T13:12:58 *** atroxes has joined #bitcoin-core-dev
3532018-01-17T13:24:44 *** AaronvanW has joined #bitcoin-core-dev
3542018-01-17T13:24:56 *** echelon has quit IRC
3552018-01-17T13:25:42 *** echelon has joined #bitcoin-core-dev
3562018-01-17T13:25:51 *** wtabata has quit IRC
3572018-01-17T13:26:52 *** wtabata has joined #bitcoin-core-dev
3582018-01-17T13:31:20 *** Jaiden19Jakubows has quit IRC
3592018-01-17T13:34:02 *** CubicEarths has joined #bitcoin-core-dev
3602018-01-17T13:38:39 *** CubicEarths has quit IRC
3612018-01-17T13:45:15 *** keks has joined #bitcoin-core-dev
3622018-01-17T13:51:48 *** laurentmt has joined #bitcoin-core-dev
3632018-01-17T13:52:56 *** laurentmt has quit IRC
3642018-01-17T14:00:30 *** intcat has quit IRC
3652018-01-17T14:04:02 *** intcat has joined #bitcoin-core-dev
3662018-01-17T14:06:43 *** waseem has joined #bitcoin-core-dev
3672018-01-17T14:07:55 <waseem> /UNIGNORE a5m0
3682018-01-17T14:08:14 *** waseem has quit IRC
3692018-01-17T14:09:48 *** laurentmt has joined #bitcoin-core-dev
3702018-01-17T14:12:26 *** CubicEarths has joined #bitcoin-core-dev
3712018-01-17T14:13:01 *** piedpiper has joined #bitcoin-core-dev
3722018-01-17T14:13:08 *** Walton89Wisozk has joined #bitcoin-core-dev
3732018-01-17T14:14:10 *** piedpiper is now known as PiedPiper
3742018-01-17T14:14:18 *** PiedPiper has left #bitcoin-core-dev
3752018-01-17T14:14:53 *** PiedPiper has joined #bitcoin-core-dev
3762018-01-17T14:15:44 *** AriseChikun has joined #bitcoin-core-dev
3772018-01-17T14:16:35 *** CubicEarths has quit IRC
3782018-01-17T14:18:57 *** ma1210 has joined #bitcoin-core-dev
3792018-01-17T14:19:45 *** Chris_Stewart_5 has quit IRC
3802018-01-17T14:19:57 *** ma1210 has quit IRC
3812018-01-17T14:21:51 *** PiedPiper has quit IRC
3822018-01-17T14:22:02 *** PiedPiper has joined #bitcoin-core-dev
3832018-01-17T14:23:59 *** Walton89Wisozk has quit IRC
3842018-01-17T14:24:35 *** echelon has quit IRC
3852018-01-17T14:26:05 *** echelon has joined #bitcoin-core-dev
3862018-01-17T14:31:21 *** anome has joined #bitcoin-core-dev
3872018-01-17T14:36:56 *** satwo has quit IRC
3882018-01-17T14:42:19 *** echelon has quit IRC
3892018-01-17T14:43:26 *** AaronvanW has quit IRC
3902018-01-17T14:46:30 *** Giszmo has joined #bitcoin-core-dev
3912018-01-17T14:48:23 *** jtimon has joined #bitcoin-core-dev
3922018-01-17T14:49:05 *** promag has joined #bitcoin-core-dev
3932018-01-17T14:54:10 *** AaronvanW has joined #bitcoin-core-dev
3942018-01-17T14:54:27 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3952018-01-17T14:54:56 *** Cogito_Ergo_Sum has quit IRC
3962018-01-17T14:55:11 *** echelon has joined #bitcoin-core-dev
3972018-01-17T14:55:43 *** Aaronvan_ has joined #bitcoin-core-dev
3982018-01-17T14:56:10 *** Victorsueca has quit IRC
3992018-01-17T14:57:22 *** Victorsueca has joined #bitcoin-core-dev
4002018-01-17T14:58:37 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4012018-01-17T14:58:37 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4022018-01-17T14:58:38 *** AaronvanW has quit IRC
4032018-01-17T15:01:59 *** zautomata has quit IRC
4042018-01-17T15:02:35 *** echelon has quit IRC
4052018-01-17T15:02:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4062018-01-17T15:11:45 *** PiedPiper has quit IRC
4072018-01-17T15:12:20 *** PiedPiper has joined #bitcoin-core-dev
4082018-01-17T15:13:08 *** Duncan27Auer has joined #bitcoin-core-dev
4092018-01-17T15:14:26 *** eck has joined #bitcoin-core-dev
4102018-01-17T15:14:49 *** SopaXorzTaker has joined #bitcoin-core-dev
4112018-01-17T15:18:45 *** Pritty_Kitty has joined #bitcoin-core-dev
4122018-01-17T15:19:38 *** marku_ has joined #bitcoin-core-dev
4132018-01-17T15:23:13 *** Pritty_Kitty has quit IRC
4142018-01-17T15:23:13 *** Duncan27Auer has quit IRC
4152018-01-17T15:23:18 *** promag has quit IRC
4162018-01-17T15:23:19 *** marku_ is now known as Pritty_Kitty
4172018-01-17T15:27:55 <Pritty_Kitty> Hello and thank you to all good Core developers for what you do.
4182018-01-17T15:28:03 <Pritty_Kitty> I'm trying to learn the system and use it but hope to get answer for a question:
4192018-01-17T15:28:12 <Pritty_Kitty> I have a 0.15.1 node with a "testnet=true" setting. getblocktemplate gives me a template where "txid" and "hash" field are identical for transaction.
4202018-01-17T15:28:19 <Pritty_Kitty> Should they not be different for SegWit is running on testnet?
4212018-01-17T15:28:29 <Pritty_Kitty> Will i use the "hash" field to create my witness hash tree and put a commit in my coinbase value? Do i put this commit value AFTER the BIP34 blockheight value?
4222018-01-17T15:29:32 <Pritty_Kitty> I am trying to make blocks.
4232018-01-17T15:29:48 <Pritty_Kitty> I want them SegWit compatible
4242018-01-17T15:31:30 *** Giszmo has quit IRC
4252018-01-17T15:33:21 *** eck has quit IRC
4262018-01-17T15:33:40 *** lnostdal has quit IRC
4272018-01-17T15:44:37 *** promag has joined #bitcoin-core-dev
4282018-01-17T15:45:49 *** promag has quit IRC
4292018-01-17T15:46:27 *** CubicEarths has joined #bitcoin-core-dev
4302018-01-17T15:51:29 *** CubicEarths has quit IRC
4312018-01-17T15:53:47 *** promag has joined #bitcoin-core-dev
4322018-01-17T15:53:57 *** echelon has joined #bitcoin-core-dev
4332018-01-17T15:57:41 *** Aaronvan_ is now known as AaronvanW
4342018-01-17T16:00:48 *** Giszmo has joined #bitcoin-core-dev
4352018-01-17T16:01:35 *** meshcollider has quit IRC
4362018-01-17T16:03:42 *** AaronvanW has quit IRC
4372018-01-17T16:04:19 *** AaronvanW has joined #bitcoin-core-dev
4382018-01-17T16:06:28 <wxss> t
4392018-01-17T16:08:50 *** AaronvanW has quit IRC
4402018-01-17T16:08:50 *** wtabata has quit IRC
4412018-01-17T16:09:14 *** wtabata has joined #bitcoin-core-dev
4422018-01-17T16:13:08 *** Layla19Tillman has joined #bitcoin-core-dev
4432018-01-17T16:14:40 *** jtimon has quit IRC
4442018-01-17T16:15:56 *** dermoth has quit IRC
4452018-01-17T16:16:41 *** dermoth has joined #bitcoin-core-dev
4462018-01-17T16:17:50 *** Layla19Tillman has quit IRC
4472018-01-17T16:20:19 *** AaronvanW has joined #bitcoin-core-dev
4482018-01-17T16:24:11 *** AaronvanW has quit IRC
4492018-01-17T16:24:29 *** AaronvanW has joined #bitcoin-core-dev
4502018-01-17T16:25:01 *** CubicEarths has joined #bitcoin-core-dev
4512018-01-17T16:25:58 <Randolf> Pritty_Kitty: You seem to be asking a "how to use Bitcoin" type of question. You'll likely find that such questions are better suited for the #bitcoin channel as this one you're asking in now is specifically focused on Bitcoin core software development.
4522018-01-17T16:29:10 *** wraithm has joined #bitcoin-core-dev
4532018-01-17T16:29:20 *** CubicEarths has quit IRC
4542018-01-17T16:30:43 *** Emcy has quit IRC
4552018-01-17T16:31:14 *** Emcy has joined #bitcoin-core-dev
4562018-01-17T16:33:41 *** jb55 has quit IRC
4572018-01-17T16:38:42 *** CubicEarths has joined #bitcoin-core-dev
4582018-01-17T16:43:13 *** CubicEarths has quit IRC
4592018-01-17T16:46:10 *** intcat has quit IRC
4602018-01-17T16:47:44 *** jb55 has joined #bitcoin-core-dev
4612018-01-17T16:48:21 *** intcat has joined #bitcoin-core-dev
4622018-01-17T16:48:30 *** mhnd has joined #bitcoin-core-dev
4632018-01-17T16:52:29 *** Randolf has quit IRC
4642018-01-17T16:57:01 *** d9b4bef9 has quit IRC
4652018-01-17T16:58:08 *** d9b4bef9 has joined #bitcoin-core-dev
4662018-01-17T16:59:02 *** d9b4bef9 has quit IRC
4672018-01-17T17:00:08 *** d9b4bef9 has joined #bitcoin-core-dev
4682018-01-17T17:01:52 *** anome has quit IRC
4692018-01-17T17:02:15 *** CubicEarths has joined #bitcoin-core-dev
4702018-01-17T17:02:24 *** AaronvanW has quit IRC
4712018-01-17T17:06:01 *** marku_ has joined #bitcoin-core-dev
4722018-01-17T17:06:17 *** anome has joined #bitcoin-core-dev
4732018-01-17T17:07:07 *** CubicEarths has quit IRC
4742018-01-17T17:08:04 *** daouzo23 has joined #bitcoin-core-dev
4752018-01-17T17:08:45 *** Pritty_Kitty has quit IRC
4762018-01-17T17:08:53 *** marku_ is now known as Pritty_Kitty
4772018-01-17T17:09:48 *** mandric has joined #bitcoin-core-dev
4782018-01-17T17:10:29 *** Giszmo has quit IRC
4792018-01-17T17:11:10 *** Randolf has joined #bitcoin-core-dev
4802018-01-17T17:13:07 *** Roel41Schinner has joined #bitcoin-core-dev
4812018-01-17T17:15:17 <Pritty_Kitty> No no i am a developer asking technical questions about bitcoin. I have built php code to deserialize transactions and build a merkle tree. Now i am working on the witness tree.
4822018-01-17T17:17:00 <Pritty_Kitty> But i could just mine regular blocks without SegWit. But I know you want SegWit so i hope for answers to my questions
4832018-01-17T17:17:56 *** flokie has quit IRC
4842018-01-17T17:18:13 *** Roel41Schinner has quit IRC
4852018-01-17T17:18:28 *** hirishaway is now known as hirish
4862018-01-17T17:20:35 *** Cogito_Ergo_Sum has quit IRC
4872018-01-17T17:21:39 *** StopAndDecrypt has quit IRC
4882018-01-17T17:23:06 <instagibbs> Pritty_Kitty, this isn't a question for Bitcoin Core development though. maybe #bitcoin-dev
4892018-01-17T17:23:27 <Pritty_Kitty> ok ty i will try there
4902018-01-17T17:23:53 *** AaronvanW has joined #bitcoin-core-dev
4912018-01-17T17:24:57 *** owowo has quit IRC
4922018-01-17T17:25:03 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4932018-01-17T17:25:03 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
4942018-01-17T17:25:19 *** Pritty_Kitty has left #bitcoin-core-dev
4952018-01-17T17:26:14 *** daouzo23 has quit IRC
4962018-01-17T17:29:30 *** AaronvanW has quit IRC
4972018-01-17T17:29:45 *** owowo has joined #bitcoin-core-dev
4982018-01-17T17:29:46 *** owowo has joined #bitcoin-core-dev
4992018-01-17T17:30:31 *** intcat has quit IRC
5002018-01-17T17:31:04 *** Victorsueca has quit IRC
5012018-01-17T17:31:31 *** intcat has joined #bitcoin-core-dev
5022018-01-17T17:32:22 *** Victorsueca has joined #bitcoin-core-dev
5032018-01-17T17:33:54 *** Arise2 has joined #bitcoin-core-dev
5042018-01-17T17:33:56 *** goksinen has quit IRC
5052018-01-17T17:33:57 *** AriseChikun has quit IRC
5062018-01-17T17:35:57 *** promag has quit IRC
5072018-01-17T17:38:21 *** AaronvanW has joined #bitcoin-core-dev
5082018-01-17T17:39:32 *** PiedPiper has left #bitcoin-core-dev
5092018-01-17T17:39:42 *** PiedPiper has joined #bitcoin-core-dev
5102018-01-17T17:39:52 *** AaronvanW has quit IRC
5112018-01-17T17:40:30 *** CubicEarths has joined #bitcoin-core-dev
5122018-01-17T17:41:09 *** AaronvanW has joined #bitcoin-core-dev
5132018-01-17T17:41:52 *** AaronvanW has quit IRC
5142018-01-17T17:44:26 *** mrannanay has quit IRC
5152018-01-17T17:45:20 *** CubicEarths has quit IRC
5162018-01-17T17:49:45 *** eck has joined #bitcoin-core-dev
5172018-01-17T17:53:28 *** timothy has quit IRC
5182018-01-17T17:58:18 *** mrannanay has joined #bitcoin-core-dev
5192018-01-17T17:59:15 *** moctost has quit IRC
5202018-01-17T18:05:04 *** eenoch has quit IRC
5212018-01-17T18:11:24 *** JC has joined #bitcoin-core-dev
5222018-01-17T18:13:08 *** Odessa20Kautzer has joined #bitcoin-core-dev
5232018-01-17T18:15:50 *** JC has quit IRC
5242018-01-17T18:15:53 *** Dr10450 has joined #bitcoin-core-dev
5252018-01-17T18:16:02 *** mhnd has quit IRC
5262018-01-17T18:17:35 *** Odessa20Kautzer has quit IRC
5272018-01-17T18:18:09 *** DoC10450 has quit IRC
5282018-01-17T18:21:05 *** jtimon has joined #bitcoin-core-dev
5292018-01-17T18:21:47 *** satwo has joined #bitcoin-core-dev
5302018-01-17T18:25:41 *** SopaXT has joined #bitcoin-core-dev
5312018-01-17T18:25:56 *** daouzo23 has joined #bitcoin-core-dev
5322018-01-17T18:26:05 *** SopaXorzTaker has quit IRC
5332018-01-17T18:27:03 *** daouzo23 has quit IRC
5342018-01-17T18:28:05 *** SopaXT has quit IRC
5352018-01-17T18:28:25 *** dermoth has quit IRC
5362018-01-17T18:28:29 *** SopaXT has joined #bitcoin-core-dev
5372018-01-17T18:30:21 *** PotentiallyGreat has quit IRC
5382018-01-17T18:30:29 *** dermoth has joined #bitcoin-core-dev
5392018-01-17T18:30:49 <bitcoin-git> [bitcoin] ryanofsky opened pull request #12211: Avoid potential null dereference in ReceiveCoinsDialog constructor (master...pr/nullrecv) https://github.com/bitcoin/bitcoin/pull/12211
5402018-01-17T18:33:52 *** dermoth has quit IRC
5412018-01-17T18:34:23 *** Emcy_ has joined #bitcoin-core-dev
5422018-01-17T18:34:27 *** dermoth has joined #bitcoin-core-dev
5432018-01-17T18:35:54 *** SopaXorzTaker has joined #bitcoin-core-dev
5442018-01-17T18:37:40 *** SopaXT has quit IRC
5452018-01-17T18:38:09 *** Emcy has quit IRC
5462018-01-17T18:38:09 *** vicenteH has quit IRC
5472018-01-17T18:41:57 *** Deacyde has joined #bitcoin-core-dev
5482018-01-17T18:44:08 *** daouzo23 has joined #bitcoin-core-dev
5492018-01-17T18:53:54 *** larafale has quit IRC
5502018-01-17T18:54:31 *** larafale has joined #bitcoin-core-dev
5512018-01-17T18:54:47 *** mandric_ has joined #bitcoin-core-dev
5522018-01-17T18:55:13 *** CubicEarths has joined #bitcoin-core-dev
5532018-01-17T18:56:53 *** mandric has quit IRC
5542018-01-17T18:58:57 *** larafale has quit IRC
5552018-01-17T18:59:23 *** ohnx has quit IRC
5562018-01-17T19:00:10 *** Scrat has joined #bitcoin-core-dev
5572018-01-17T19:03:42 *** ohnx- has joined #bitcoin-core-dev
5582018-01-17T19:03:50 *** daouzo23 has quit IRC
5592018-01-17T19:05:19 *** harrymm has joined #bitcoin-core-dev
5602018-01-17T19:05:26 *** owowo has quit IRC
5612018-01-17T19:05:39 *** Emcy_ has quit IRC
5622018-01-17T19:06:17 *** Emcy_ has joined #bitcoin-core-dev
5632018-01-17T19:06:35 *** harrymm_ has quit IRC
5642018-01-17T19:09:33 *** PiedPiper has quit IRC
5652018-01-17T19:09:46 *** Giszmo has joined #bitcoin-core-dev
5662018-01-17T19:09:52 *** PiedPiper has joined #bitcoin-core-dev
5672018-01-17T19:10:23 *** owowo has joined #bitcoin-core-dev
5682018-01-17T19:10:47 *** PiedPiper has quit IRC
5692018-01-17T19:10:58 *** PiedPiper has joined #bitcoin-core-dev
5702018-01-17T19:11:05 *** jb55 has quit IRC
5712018-01-17T19:12:46 *** PiedPiper has quit IRC
5722018-01-17T19:13:07 *** Anya20Hayes has joined #bitcoin-core-dev
5732018-01-17T19:15:13 *** PiedPiper has joined #bitcoin-core-dev
5742018-01-17T19:15:48 *** twoken has quit IRC
5752018-01-17T19:18:12 *** Anya20Hayes has quit IRC
5762018-01-17T19:20:00 *** ohnx- is now known as ohnx
5772018-01-17T19:20:37 *** PiedPiper has quit IRC
5782018-01-17T19:20:48 *** PiedPiper has joined #bitcoin-core-dev
5792018-01-17T19:22:40 *** Emcy has joined #bitcoin-core-dev
5802018-01-17T19:23:46 *** twoken has joined #bitcoin-core-dev
5812018-01-17T19:24:48 *** ghost43 has quit IRC
5822018-01-17T19:24:49 *** intcat has quit IRC
5832018-01-17T19:25:33 *** Emcy_ has quit IRC
5842018-01-17T19:26:15 *** intcat has joined #bitcoin-core-dev
5852018-01-17T19:26:17 *** ghost43 has joined #bitcoin-core-dev
5862018-01-17T19:30:57 *** wumpus has quit IRC
5872018-01-17T19:32:31 *** wumpus has joined #bitcoin-core-dev
5882018-01-17T19:32:45 *** Giszmo has quit IRC
5892018-01-17T19:36:04 *** harrymm_ has joined #bitcoin-core-dev
5902018-01-17T19:37:57 *** harrymm has quit IRC
5912018-01-17T19:38:51 *** belcher has joined #bitcoin-core-dev
5922018-01-17T19:39:05 *** aj has quit IRC
5932018-01-17T20:00:30 *** lightningbot has joined #bitcoin-core-dev
5942018-01-17T20:00:55 <jojeyh> Can anyboyd give me a brief explanation for "struct zero_after_free_allocator" ?
5952018-01-17T20:01:19 <jojeyh> What is the point of this object instead of a traditional std::allocator ?
5962018-01-17T20:01:27 *** vghy has joined #bitcoin-core-dev
5972018-01-17T20:01:33 *** Giszmo has quit IRC
5982018-01-17T20:01:50 <jojeyh> in file "bitcoin/src/support/allocators/zeroafterfree.h"
5992018-01-17T20:02:08 *** vghy has quit IRC
6002018-01-17T20:02:09 *** Evel-Knievel has quit IRC
6012018-01-17T20:02:26 *** daouzo235 has joined #bitcoin-core-dev
6022018-01-17T20:02:26 *** Evel-Knievel has joined #bitcoin-core-dev
6032018-01-17T20:04:29 *** daouzo23 has quit IRC
6042018-01-17T20:06:38 <luke-jr> jojeyh: std::allocator probably doesn't zero when freeing
6052018-01-17T20:06:50 <jojeyh> can you explain what this means?
6062018-01-17T20:06:53 <luke-jr> jojeyh: in other words, it leaves the data in memory
6072018-01-17T20:07:20 <luke-jr> which means when something else is allocated (hypothetically even in another program), it might have the data in its new memory
6082018-01-17T20:07:28 <jojeyh> luke-jr: ok, so basically if a std::allocator were used then even after the memory is freed the bits will still be nonzero ?
6092018-01-17T20:07:34 <luke-jr> right
6102018-01-17T20:07:42 <jojeyh> k thanks
6112018-01-17T20:08:01 <luke-jr> this is particularly bad if the memory might contain private key or passphrase info
6122018-01-17T20:08:36 <jojeyh> ah that makes sense
6132018-01-17T20:10:44 *** ohnx has quit IRC
6142018-01-17T20:10:56 *** ohnx has joined #bitcoin-core-dev
6152018-01-17T20:13:08 *** Lynn39Sanford has joined #bitcoin-core-dev
6162018-01-17T20:15:15 *** daouzo235 has quit IRC
6172018-01-17T20:16:05 *** Giszmo has joined #bitcoin-core-dev
6182018-01-17T20:21:14 *** Lynn39Sanford has quit IRC
6192018-01-17T20:27:39 *** Cogito_Ergo_Sum has quit IRC
6202018-01-17T20:30:01 *** SopaXorzTaker has quit IRC
6212018-01-17T20:35:32 *** daouzo235 has joined #bitcoin-core-dev
6222018-01-17T20:41:23 *** mandric_ has quit IRC
6232018-01-17T20:42:03 *** Giszmo has quit IRC
6242018-01-17T20:48:19 *** eck has quit IRC
6252018-01-17T20:53:59 *** daouzo235 has quit IRC
6262018-01-17T20:54:29 *** daouzo235 has joined #bitcoin-core-dev
6272018-01-17T20:55:24 *** lnostdal has joined #bitcoin-core-dev
6282018-01-17T21:00:50 *** PiedPiper has joined #bitcoin-core-dev
6292018-01-17T21:06:36 *** BashCo has quit IRC
6302018-01-17T21:12:51 *** anome has quit IRC
6312018-01-17T21:13:02 *** PiedPiper has quit IRC
6322018-01-17T21:13:07 *** Flavio12Hilpert has joined #bitcoin-core-dev
6332018-01-17T21:13:17 *** PiedPiper has joined #bitcoin-core-dev
6342018-01-17T21:14:29 *** PiedPiper has quit IRC
6352018-01-17T21:14:52 *** PiedPiper has joined #bitcoin-core-dev
6362018-01-17T21:16:03 *** bule has joined #bitcoin-core-dev
6372018-01-17T21:17:59 *** Flavio12Hilpert has quit IRC
6382018-01-17T21:22:18 *** Dizzle has joined #bitcoin-core-dev
6392018-01-17T21:24:06 *** BashCo has joined #bitcoin-core-dev
6402018-01-17T21:30:46 *** promag has joined #bitcoin-core-dev
6412018-01-17T21:40:15 *** mandric has joined #bitcoin-core-dev
6422018-01-17T21:44:14 *** shesek has joined #bitcoin-core-dev
6432018-01-17T21:44:14 *** shesek has joined #bitcoin-core-dev
6442018-01-17T21:53:01 *** meshcollider has joined #bitcoin-core-dev
6452018-01-17T21:59:38 *** lio17 has quit IRC
6462018-01-17T21:59:41 *** mandric has quit IRC
6472018-01-17T22:02:52 *** PiedPiper has quit IRC
6482018-01-17T22:03:06 *** PiedPiper has joined #bitcoin-core-dev
6492018-01-17T22:03:14 *** bitzap has joined #bitcoin-core-dev
6502018-01-17T22:04:17 *** harrymm_ has quit IRC
6512018-01-17T22:10:22 *** goksinen has joined #bitcoin-core-dev
6522018-01-17T22:13:08 *** Eulah88Witting has joined #bitcoin-core-dev
6532018-01-17T22:16:34 *** harrymm_ has joined #bitcoin-core-dev
6542018-01-17T22:16:40 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
6552018-01-17T22:17:35 *** Eulah88Witting has quit IRC
6562018-01-17T22:18:09 *** lio17 has joined #bitcoin-core-dev
6572018-01-17T22:23:39 *** daouzo235 has quit IRC
6582018-01-17T22:38:27 <bitcoin-git> [bitcoin] bitspill opened pull request #12212: fix spelling (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12212
6592018-01-17T22:40:16 <mrannanay> #11227 seems to have both milestones covered. Needs rebase.
6602018-01-17T22:40:19 <gribble> https://github.com/bitcoin/bitcoin/issues/11227 | WIP: switch to libevent for node socket handling by theuni · Pull Request #11227 · bitcoin/bitcoin · GitHub
6612018-01-17T22:42:35 *** Dizzle has quit IRC
6622018-01-17T22:42:52 *** lio1754 has joined #bitcoin-core-dev
6632018-01-17T22:44:14 *** wacawacawaca has quit IRC
6642018-01-17T22:44:23 *** lio17 has quit IRC
6652018-01-17T22:47:22 *** Victorsueca has quit IRC
6662018-01-17T22:48:38 *** Victorsueca has joined #bitcoin-core-dev
6672018-01-17T22:49:15 *** wacawacawaca has joined #bitcoin-core-dev
6682018-01-17T22:50:11 <promag> sipa: addmultisigaddress should have address_type option?
6692018-01-17T22:56:09 *** Randolf has quit IRC
6702018-01-17T22:56:57 *** jb55 has quit IRC
6712018-01-17T23:01:29 *** jojeyh has quit IRC
6722018-01-17T23:04:59 *** bule2 has joined #bitcoin-core-dev
6732018-01-17T23:05:47 *** shesek has quit IRC
6742018-01-17T23:07:09 *** Guyver2 has quit IRC
6752018-01-17T23:07:42 *** bule has quit IRC
6762018-01-17T23:12:54 *** goksinen has quit IRC
6772018-01-17T23:13:07 *** Rodolfo42Boehm has joined #bitcoin-core-dev
6782018-01-17T23:16:49 *** lio175456 has joined #bitcoin-core-dev
6792018-01-17T23:18:45 *** lio1754 has quit IRC
6802018-01-17T23:21:25 *** gwillen has joined #bitcoin-core-dev
6812018-01-17T23:23:14 *** anome has joined #bitcoin-core-dev
6822018-01-17T23:30:09 *** anome has quit IRC
6832018-01-17T23:30:37 *** anome has joined #bitcoin-core-dev
6842018-01-17T23:31:21 *** netcraftdev has joined #bitcoin-core-dev
6852018-01-17T23:32:20 *** netcraftdev has joined #bitcoin-core-dev
6862018-01-17T23:33:50 *** netcraftdev has left #bitcoin-core-dev
6872018-01-17T23:39:11 *** Chris_Stewart_5 has quit IRC
6882018-01-17T23:40:48 <bitcoin-git> [bitcoin] promag opened pull request #12213: 2018 01 addmultisigaddress address type (master...2018-01-addmultisigaddress-address-type) https://github.com/bitcoin/bitcoin/pull/12213
6892018-01-17T23:42:53 *** JackH has quit IRC
6902018-01-17T23:45:32 *** ula has joined #bitcoin-core-dev
6912018-01-17T23:47:13 *** jb55 has joined #bitcoin-core-dev
6922018-01-17T23:51:16 *** anome has quit IRC
6932018-01-17T23:52:22 *** AaronvanW has joined #bitcoin-core-dev
6942018-01-17T23:55:23 *** belcher has quit IRC
6952018-01-17T23:57:57 *** wxss has quit IRC
6962018-01-17T23:58:00 *** Cogito_Ergo_Sum has quit IRC
6972018-01-17T23:58:45 *** wacawacawaca has quit IRC