12018-01-31T00:00:56  *** vicenteH has quit IRC
  22018-01-31T00:01:37  <jtimon> btw, iirc libbitcoin implemented bip90 as an option despite the complains
  32018-01-31T00:02:42  <jtimon> I don't think the option is very interesting (since the result will always be the same unless very bad things happen, just to further note is not bitcoin core specific)
  42018-01-31T00:03:12  *** moctost has quit IRC
  52018-01-31T00:03:40  <michagogo> Hm, does anyone have any idea why my gitian build is crashing?
  62018-01-31T00:06:56  <michagogo> http://paste.ubuntu.com/26492234/
  72018-01-31T00:07:13  <michagogo> (tail -n10000 build.log)
  82018-01-31T00:08:05  *** Allison19Schinne has quit IRC
  92018-01-31T00:08:10  *** Victorsueca has quit IRC
 102018-01-31T00:16:48  *** promag has quit IRC
 112018-01-31T00:18:30  <MarcoFalke> Just noting that the 0.16 gh branch is not "protecte" like the other branches...
 122018-01-31T00:20:54  *** d_t has joined #bitcoin-core-dev
 132018-01-31T00:21:19  *** finkan has joined #bitcoin-core-dev
 142018-01-31T00:28:06  *** jojeyh has joined #bitcoin-core-dev
 152018-01-31T00:28:11  *** PaulCape_ has quit IRC
 162018-01-31T00:36:31  *** PaulCapestany has joined #bitcoin-core-dev
 172018-01-31T00:39:54  *** d_t has quit IRC
 182018-01-31T00:41:26  <MarcoFalke> s/protecte/protected/
 192018-01-31T00:50:51  *** kallewoof has quit IRC
 202018-01-31T00:50:53  *** ProfMac has joined #bitcoin-core-dev
 212018-01-31T00:51:29  *** kallewoof has joined #bitcoin-core-dev
 222018-01-31T00:53:07  *** justan0theruser has quit IRC
 232018-01-31T00:58:47  *** justanotheruser has joined #bitcoin-core-dev
 242018-01-31T00:59:02  *** justanotheruser has joined #bitcoin-core-dev
 252018-01-31T01:01:10  *** Dizzle has quit IRC
 262018-01-31T01:01:24  *** Camryn27Rolfson has joined #bitcoin-core-dev
 272018-01-31T01:03:30  *** finkan has quit IRC
 282018-01-31T01:04:26  *** jb55 has joined #bitcoin-core-dev
 292018-01-31T01:05:48  *** jojeyh has quit IRC
 302018-01-31T01:07:10  *** jojeyh has joined #bitcoin-core-dev
 312018-01-31T01:08:50  *** Tennis has quit IRC
 322018-01-31T01:15:47  *** Victorsueca has joined #bitcoin-core-dev
 332018-01-31T01:18:44  <achow101> Uhh, so it seems like sendtoaddress can sometimes make an invalid/non-standard transaction.. Or maybe my coin selection code somehow messes with that
 342018-01-31T01:19:00  <achow101> I'm very confused now
 352018-01-31T01:19:31  *** bear_ has quit IRC
 362018-01-31T01:19:34  <gmaxwell> invalid in what way?!?!?!?!???!??!?!?!?
 372018-01-31T01:19:46  <achow101> 64: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)
 382018-01-31T01:20:23  <achow101> that's the error I get when I try to sendrawtransaction with it
 392018-01-31T01:20:43  <achow101> basically what I was doing was sendtoaddress, then gettransaction, then sendrawtransaction the hex
 402018-01-31T01:20:58  <achow101> and then that error happened
 412018-01-31T01:32:34  *** jamesob has joined #bitcoin-core-dev
 422018-01-31T01:37:11  *** james has joined #bitcoin-core-dev
 432018-01-31T01:37:35  *** james is now known as Guest13391
 442018-01-31T01:37:57  *** Victorsueca has quit IRC
 452018-01-31T01:39:29  <achow101> so AFAICT that error means that the signature is being produced incorrectly
 462018-01-31T01:42:04  *** Victorsueca has joined #bitcoin-core-dev
 472018-01-31T01:42:13  <arubi> so there is a signature in the script \ witness at all?  are you signing something malformed?
 482018-01-31T01:45:09  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
 492018-01-31T01:47:28  *** jojeyh has quit IRC
 502018-01-31T01:47:56  <achow101> There's a signature
 512018-01-31T01:48:12  <achow101> the transaction _looks_ right, besides the fact that I can't mentally verify signatures
 522018-01-31T01:48:41  <arubi> signrawtransaction along with the utxo in json should give a more verbose error about what's wrong
 532018-01-31T01:50:21  <arubi> unless it's really all it is and the signature is invalid for the tx..  that's pretty scary
 542018-01-31T01:52:18  *** Camryn27Rolfson has quit IRC
 552018-01-31T01:59:24  *** Rowena86Larkin has joined #bitcoin-core-dev
 562018-01-31T01:59:56  *** belcher has quit IRC
 572018-01-31T02:00:56  *** denis2342 has quit IRC
 582018-01-31T02:08:33  *** Victorsueca has quit IRC
 592018-01-31T02:08:48  *** droark has quit IRC
 602018-01-31T02:15:06  <achow101> hmm. It looks like there's a signature hash mis-calculation
 612018-01-31T02:15:36  <achow101> the signer signed one sighash but a different sighash was calculated when verifying before the send
 622018-01-31T02:15:56  <achow101> I've only observed this on segwit, so I think this may actually be a blocker for 0.16
 632018-01-31T02:20:09  *** Victorsueca has joined #bitcoin-core-dev
 642018-01-31T02:20:17  <arubi> can you tell which of the hashes is the correct one?
 652018-01-31T02:20:19  *** jamesob has quit IRC
 662018-01-31T02:20:36  *** jamesob has joined #bitcoin-core-dev
 672018-01-31T02:24:16  <achow101> https://github.com/bitcoin/bitcoin/issues/12307
 682018-01-31T02:27:09  <arubi> oh cool
 692018-01-31T02:29:14  <arubi> achow101, can you paste the payment to this tx please?
 702018-01-31T02:29:42  <achow101> what do you mean "payment to"?
 712018-01-31T02:29:45  <achow101> Like the input txs?
 722018-01-31T02:30:00  <kallewoof> I'd like to see the raw tx hex as well
 732018-01-31T02:30:02  <arubi> right, to know the amounts
 742018-01-31T02:30:22  <kallewoof> oops it's there nvm
 752018-01-31T02:30:23  <arubi> the raw hex for the spend is in the issue, but I wanna see what the sighash is supposed to be
 762018-01-31T02:31:00  *** Giszmo has joined #bitcoin-core-dev
 772018-01-31T02:32:07  <arubi> oh it does show the amount for the failed one nValue=4.68120500 , probably stopped because it's the first one
 782018-01-31T02:32:37  <arubi> ah no it's the output
 792018-01-31T02:33:05  <achow101> there's a lot of inputs...
 802018-01-31T02:33:25  <achow101> I can drop the wallet file instead and you can go find the transactions yourself
 812018-01-31T02:33:40  <arubi> sounds good
 822018-01-31T02:35:09  <achow101> updated the issue
 832018-01-31T02:35:20  <arubi> cheers
 842018-01-31T02:38:24  *** Tyth4n has joined #bitcoin-core-dev
 852018-01-31T02:39:40  *** To7 has quit IRC
 862018-01-31T02:47:45  *** Tyth4n has quit IRC
 872018-01-31T02:49:37  *** cdecker has quit IRC
 882018-01-31T02:49:56  *** Murch has quit IRC
 892018-01-31T02:50:46  *** cdecker has joined #bitcoin-core-dev
 902018-01-31T02:52:17  <kallewoof> newbie question but how would you dump the wallet info from that? :]
 912018-01-31T02:52:49  <arubi> I'm getting ba89d6d01bdfd4b611757e38802c5a09255659ae7d2d42ae3f0729e7f261de1f as sighash for the first input..
 922018-01-31T02:53:06  <arubi> (not 0.16)
 932018-01-31T02:53:18  *** droark has joined #bitcoin-core-dev
 942018-01-31T02:53:41  <arubi> kallewoof, you can 'gettransaction' for the txids in the inputs to the one posted
 952018-01-31T02:54:00  <arubi> pretty much only need the amounts from there
 962018-01-31T02:54:11  <kallewoof> Oh.. I tried listunspent but it was empty. Thanks
 972018-01-31T02:56:43  <kallewoof> I'm getting Invalid or non-wallet transaction id. I'm just starting a regtest instance with -datadir set to one containing that wallet.dat file, though.
 982018-01-31T02:57:46  <achow101> You have to use 0.16 or mater
 992018-01-31T02:57:48  <achow101> *master
1002018-01-31T02:58:20  <achow101> arubi: that's what the verifier got. it's just byteswapped
1012018-01-31T02:58:22  <kallewoof> This is master.. (well, as of jan 24)
1022018-01-31T02:58:47  <arubi> ah!
1032018-01-31T02:59:02  <achow101> usual byteswap stuff
1042018-01-31T02:59:26  <achow101> kallewoof: really? It should be in the wallet
1052018-01-31T02:59:52  <achow101> use decoderawtransaction on the tx hex and then fetch the input tx with gettransaction
1062018-01-31T03:00:19  <arubi> I'm running this on pre-0.16 on regtest too
1072018-01-31T03:00:30  <kallewoof> dumpwallet gave me a ton of stuff, but yeah. I did decoderaw and tried to gettx the first input (cf0996c1b356bf7df7ef81d65c6741d5db6058826be47842ab45e18afd36dd03)
1082018-01-31T03:01:21  <arubi> should work.  sure you're using gettransaction and not getrawtransaction?
1092018-01-31T03:01:24  <achow101> arubi: if you're using a version of master after september or som ething it should be fine
1102018-01-31T03:01:57  <kallewoof> Yes, I'm using gettransaction.
1112018-01-31T03:02:21  <achow101> strange
1122018-01-31T03:02:23  <arubi> I'm using jl2012's latest bip114 client (vault branch)
1132018-01-31T03:03:20  <arubi> ah, it's from september
1142018-01-31T03:03:41  <cfields> achow101: regtest?
1152018-01-31T03:03:56  <achow101> cfields: yes. from the test framework (which is what my simulator does)
1162018-01-31T03:03:59  <achow101> s/does/uses
1172018-01-31T03:04:23  <cfields> achow101: we'll need your chain data :)
1182018-01-31T03:04:32  <achow101> oh, duh
1192018-01-31T03:05:30  <achow101> cfields: updated in the issue
1202018-01-31T03:06:09  <kallewoof> Doh. I put wallet.dat in datadir/ not datadir/regtest/wallets/. Works now.
1212018-01-31T03:15:38  <achow101> oh shit. I fucked up my coin selection stuff
1222018-01-31T03:15:42  <achow101> that's the problem, the amount is wrong
1232018-01-31T03:18:01  <arubi> phew :)
1242018-01-31T03:22:56  *** echeveria has quit IRC
1252018-01-31T03:23:23  *** TD-Linux has quit IRC
1262018-01-31T03:23:23  *** windsok has quit IRC
1272018-01-31T03:23:48  *** ProfMac has quit IRC
1282018-01-31T03:24:03  <achow101> I guess this is why I shouldn't suppress exceptions :/
1292018-01-31T03:24:42  *** echeveria has joined #bitcoin-core-dev
1302018-01-31T03:24:43  *** TD-Linux has joined #bitcoin-core-dev
1312018-01-31T03:25:16  *** windsok has joined #bitcoin-core-dev
1322018-01-31T03:25:25  *** ProfMac has joined #bitcoin-core-dev
1332018-01-31T03:28:07  *** goatpig has quit IRC
1342018-01-31T03:34:49  *** victor__ has joined #bitcoin-core-dev
1352018-01-31T03:35:10  *** jb55 has quit IRC
1362018-01-31T03:36:24  *** victor__ has quit IRC
1372018-01-31T03:48:23  *** denis2342 has joined #bitcoin-core-dev
1382018-01-31T03:54:12  *** jojeyh has joined #bitcoin-core-dev
1392018-01-31T04:03:17  *** moctost has joined #bitcoin-core-dev
1402018-01-31T04:04:04  *** jb55 has joined #bitcoin-core-dev
1412018-01-31T04:04:08  *** dabura667 has joined #bitcoin-core-dev
1422018-01-31T04:07:16  *** wxss has quit IRC
1432018-01-31T04:20:18  *** jb55 has quit IRC
1442018-01-31T04:24:18  *** jb55 has joined #bitcoin-core-dev
1452018-01-31T04:24:57  *** Krellan has quit IRC
1462018-01-31T04:27:40  *** jamesob has quit IRC
1472018-01-31T04:28:04  *** Guest13391 has quit IRC
1482018-01-31T04:30:47  *** cryptojanitor has joined #bitcoin-core-dev
1492018-01-31T04:31:58  *** checksauce has joined #bitcoin-core-dev
1502018-01-31T04:33:13  *** checksauce has joined #bitcoin-core-dev
1512018-01-31T04:34:48  *** checksau_ has joined #bitcoin-core-dev
1522018-01-31T04:37:18  *** checksauce has quit IRC
1532018-01-31T04:38:27  *** jb55 has quit IRC
1542018-01-31T04:42:40  *** Lynet_ has quit IRC
1552018-01-31T04:43:32  *** unholymachine has quit IRC
1562018-01-31T04:54:00  *** mrannanay has joined #bitcoin-core-dev
1572018-01-31T05:01:51  *** Rowena86Larkin has quit IRC
1582018-01-31T05:05:12  *** arubi has quit IRC
1592018-01-31T05:06:15  *** arubi has joined #bitcoin-core-dev
1602018-01-31T05:10:53  *** arubi has quit IRC
1612018-01-31T05:10:56  *** arubi_ has joined #bitcoin-core-dev
1622018-01-31T05:13:05  *** Giszmo has quit IRC
1632018-01-31T05:14:49  *** arubi_ has quit IRC
1642018-01-31T05:15:16  *** arubi has joined #bitcoin-core-dev
1652018-01-31T05:21:13  *** justan0theruser has joined #bitcoin-core-dev
1662018-01-31T05:22:09  *** justanotheruser has quit IRC
1672018-01-31T05:30:12  *** flokie has quit IRC
1682018-01-31T05:30:50  *** arbitrary_guy has quit IRC
1692018-01-31T05:45:17  *** checksau_ has quit IRC
1702018-01-31T05:55:47  *** aruns__ has joined #bitcoin-core-dev
1712018-01-31T05:56:10  *** indistylo has joined #bitcoin-core-dev
1722018-01-31T05:57:40  *** aruns has joined #bitcoin-core-dev
1732018-01-31T05:59:31  *** Lauriane29Rolfso has joined #bitcoin-core-dev
1742018-01-31T06:00:57  *** aruns__ has quit IRC
1752018-01-31T06:01:23  *** aruns__ has joined #bitcoin-core-dev
1762018-01-31T06:01:35  *** indistylo has quit IRC
1772018-01-31T06:21:42  *** ghost43 has quit IRC
1782018-01-31T06:21:48  *** shesek has joined #bitcoin-core-dev
1792018-01-31T06:21:57  *** ghost43 has joined #bitcoin-core-dev
1802018-01-31T06:40:57  *** Lauriane29Rolfso has quit IRC
1812018-01-31T06:43:14  *** Krellan has joined #bitcoin-core-dev
1822018-01-31T06:44:08  *** Emcy has joined #bitcoin-core-dev
1832018-01-31T06:47:22  <michagogo> Dammit. The compiler just keeps segfaulting, somewhere else every time
1842018-01-31T06:47:40  <gmaxwell> memtest86 time
1852018-01-31T06:47:45  *** Krellan has quit IRC
1862018-01-31T06:47:50  <michagogo> D:
1872018-01-31T06:48:18  <michagogo> Hm, I wonder if shutting down the VM and starting it again might help
1882018-01-31T06:56:29  <michagogo> gmaxwell: (on the physical machine, right? Or can running it in the VM also be relevant?)
1892018-01-31T06:59:24  *** Charles26Aufderh has joined #bitcoin-core-dev
1902018-01-31T07:03:15  <kallewoof> michagogo: i get that if I don't bump the RAM of the VM. esp if i use -j with make.
1912018-01-31T07:03:41  <michagogo> I thought about that
1922018-01-31T07:04:01  *** Charles26Aufderh has quit IRC
1932018-01-31T07:04:04  <michagogo> Took it down from -j5 to -j3, and had htop open
1942018-01-31T07:04:23  <michagogo> I don’t think it reached 3GB
1952018-01-31T07:04:35  <michagogo> (The VM has almost 6)
1962018-01-31T07:06:04  *** Krellan has joined #bitcoin-core-dev
1972018-01-31T07:07:47  *** Krellan has joined #bitcoin-core-dev
1982018-01-31T07:08:23  *** indistylo has joined #bitcoin-core-dev
1992018-01-31T07:08:45  *** aruns has quit IRC
2002018-01-31T07:08:48  *** aruns__ has quit IRC
2012018-01-31T07:08:52  *** aruns has joined #bitcoin-core-dev
2022018-01-31T07:15:04  *** aruns has quit IRC
2032018-01-31T07:15:19  *** aruns has joined #bitcoin-core-dev
2042018-01-31T07:15:22  *** aruns__ has joined #bitcoin-core-dev
2052018-01-31T07:15:30  *** indistylo has quit IRC
2062018-01-31T07:18:14  *** RubenSomsen has joined #bitcoin-core-dev
2072018-01-31T07:20:36  *** aruns__ has quit IRC
2082018-01-31T07:20:56  *** indistylo has joined #bitcoin-core-dev
2092018-01-31T07:35:18  *** jtimon has quit IRC
2102018-01-31T07:37:33  *** arowser has joined #bitcoin-core-dev
2112018-01-31T07:44:19  *** meshcollider has quit IRC
2122018-01-31T07:54:46  *** Victorsueca has quit IRC
2132018-01-31T07:56:02  *** Victorsueca has joined #bitcoin-core-dev
2142018-01-31T07:59:24  *** Ivory52Hartmann has joined #bitcoin-core-dev
2152018-01-31T08:04:27  *** mrannanay has quit IRC
2162018-01-31T08:09:06  *** aruns__ has joined #bitcoin-core-dev
2172018-01-31T08:11:35  *** indistylo has quit IRC
2182018-01-31T08:11:55  *** aruns has quit IRC
2192018-01-31T08:12:14  *** indistylo has joined #bitcoin-core-dev
2202018-01-31T08:27:42  *** ula has quit IRC
2212018-01-31T08:34:07  *** Ivory52Hartmann has quit IRC
2222018-01-31T08:34:41  *** nickler has quit IRC
2232018-01-31T08:36:45  *** nickler has joined #bitcoin-core-dev
2242018-01-31T08:41:50  *** xabbix has quit IRC
2252018-01-31T08:44:41  *** dafuq has joined #bitcoin-core-dev
2262018-01-31T08:59:24  *** Elisha60Jaskolsk has joined #bitcoin-core-dev
2272018-01-31T09:02:13  *** gelango has joined #bitcoin-core-dev
2282018-01-31T09:02:35  *** gelango has left #bitcoin-core-dev
2292018-01-31T09:02:44  *** gelango has joined #bitcoin-core-dev
2302018-01-31T09:03:10  *** capa66 has quit IRC
2312018-01-31T09:04:10  *** gelango has quit IRC
2322018-01-31T09:05:36  *** gelango has joined #bitcoin-core-dev
2332018-01-31T09:06:03  *** Cogito_Ergo_Sum has quit IRC
2342018-01-31T09:25:25  *** gelango has quit IRC
2352018-01-31T09:26:01  *** Krellan has quit IRC
2362018-01-31T09:27:18  *** Krellan has joined #bitcoin-core-dev
2372018-01-31T09:30:50  *** gelango has joined #bitcoin-core-dev
2382018-01-31T09:31:11  *** RubenSomsen has quit IRC
2392018-01-31T09:36:11  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0295becbf3e...216f9a42e689
2402018-01-31T09:36:12  <bitcoin-git> bitcoin/master 4c85517 Alex Vear: Add NetBSD build instruction links
2412018-01-31T09:36:12  <bitcoin-git> bitcoin/master ee5e896 Alex Vear: Organise Linux build instructions to be categorised by distro
2422018-01-31T09:36:13  <bitcoin-git> bitcoin/master 216f9a4 Wladimir J. van der Laan: Merge #12306: Docs: Improvements to UNIX documentation...
2432018-01-31T09:37:14  <bitcoin-git> [bitcoin] laanwj closed pull request #12306: Docs: Improvements to UNIX documentation (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/12306
2442018-01-31T09:38:02  *** d9b4bef9 has quit IRC
2452018-01-31T09:39:07  *** d9b4bef9 has joined #bitcoin-core-dev
2462018-01-31T09:40:45  *** promag has joined #bitcoin-core-dev
2472018-01-31T09:49:13  *** vicenteH has joined #bitcoin-core-dev
2482018-01-31T09:53:15  *** wxss has joined #bitcoin-core-dev
2492018-01-31T09:54:16  *** wxss has quit IRC
2502018-01-31T09:54:38  *** wxss has joined #bitcoin-core-dev
2512018-01-31T09:56:16  *** aruns has joined #bitcoin-core-dev
2522018-01-31T09:59:14  *** aruns__ has quit IRC
2532018-01-31T09:59:18  *** indistylo has quit IRC
2542018-01-31T09:59:33  *** indistylo has joined #bitcoin-core-dev
2552018-01-31T09:59:52  *** meshcollider has joined #bitcoin-core-dev
2562018-01-31T10:06:35  *** Elisha60Jaskolsk has quit IRC
2572018-01-31T10:07:22  *** p3tr has joined #bitcoin-core-dev
2582018-01-31T10:13:54  *** aruns has quit IRC
2592018-01-31T10:14:08  *** aruns has joined #bitcoin-core-dev
2602018-01-31T10:14:14  *** aruns__ has joined #bitcoin-core-dev
2612018-01-31T10:14:18  *** indistylo has quit IRC
2622018-01-31T10:17:35  *** larafale has joined #bitcoin-core-dev
2632018-01-31T10:18:16  *** aruns has quit IRC
2642018-01-31T10:18:42  *** aruns has joined #bitcoin-core-dev
2652018-01-31T10:20:33  *** aruns__ has quit IRC
2662018-01-31T10:21:07  *** denis2342 has joined #bitcoin-core-dev
2672018-01-31T10:21:11  *** aruns__ has joined #bitcoin-core-dev
2682018-01-31T10:22:59  *** aruns__ has joined #bitcoin-core-dev
2692018-01-31T10:25:51  *** aruns has quit IRC
2702018-01-31T10:26:08  *** aruns__ has quit IRC
2712018-01-31T10:29:29  <bitcoin-git> [bitcoin] laanwj opened pull request #12308: contrib: Add support for out-of-tree builds in gen-manpages.sh (master...2018_01_genmanpages_outoftree) https://github.com/bitcoin/bitcoin/pull/12308
2722018-01-31T10:30:05  *** gelango has quit IRC
2732018-01-31T10:32:05  *** gelango has joined #bitcoin-core-dev
2742018-01-31T10:33:40  *** larafale has quit IRC
2752018-01-31T10:34:26  *** larafale has joined #bitcoin-core-dev
2762018-01-31T10:36:07  *** gelango has quit IRC
2772018-01-31T10:36:28  *** gelango has joined #bitcoin-core-dev
2782018-01-31T10:37:22  *** gelango has quit IRC
2792018-01-31T10:38:57  *** larafale has quit IRC
2802018-01-31T10:44:47  *** checksauce has joined #bitcoin-core-dev
2812018-01-31T10:46:59  *** gelango has joined #bitcoin-core-dev
2822018-01-31T10:47:19  *** gelango has quit IRC
2832018-01-31T10:49:29  *** denis2342 has quit IRC
2842018-01-31T10:49:47  *** promag has quit IRC
2852018-01-31T10:54:45  *** promag has joined #bitcoin-core-dev
2862018-01-31T10:55:33  *** promag has quit IRC
2872018-01-31T10:58:38  *** tryphe_ has joined #bitcoin-core-dev
2882018-01-31T10:59:23  *** Lavonne24Walker has joined #bitcoin-core-dev
2892018-01-31T11:01:40  *** tryphe has quit IRC
2902018-01-31T11:08:28  *** denis2342 has joined #bitcoin-core-dev
2912018-01-31T11:12:51  *** Guyver2 has joined #bitcoin-core-dev
2922018-01-31T11:15:17  *** tryphe_ has quit IRC
2932018-01-31T11:15:41  *** tryphe_ has joined #bitcoin-core-dev
2942018-01-31T11:27:34  *** jtimon has joined #bitcoin-core-dev
2952018-01-31T11:28:12  <michagogo> Oh, good, it worked.
2962018-01-31T11:28:50  <michagogo> Don’t know if it was rebooting the VM, updating vbox, rebooting the host, or some combination
2972018-01-31T11:30:57  <bitcoin-git> [bitcoin] laanwj opened pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
2982018-01-31T11:42:27  *** arbitrary_guy has joined #bitcoin-core-dev
2992018-01-31T11:50:29  <wumpus> ah yes VMs, aren't they delightful, combining the flakyness of hardware with the labyrinthine complexity of software
3002018-01-31T11:51:04  <michagogo> Uh, WTF? Build-windows.md has instructions that I’m pretty sure will completely hose any Xenial system
3012018-01-31T11:51:40  <michagogo> Namely, adding the apt repo for a newer release
3022018-01-31T11:52:07  <wumpus> unfortunately there is no way to cross-build to windows from xenial otherwise
3032018-01-31T11:52:43  <michagogo> Maybe there’s a way to just get the new versions of the relevant packages, I don’t know
3042018-01-31T11:52:50  <wumpus> the mingw-gcc in that ubuntu release is hosed. THere used to be a warning to simply not do that, but to some people that wasn't good enough...
3052018-01-31T11:53:02  <michagogo> But those instructions will trash the system
3062018-01-31T11:53:02  *** Krellan has quit IRC
3072018-01-31T11:53:21  <michagogo> They tell you to apt-get upgrade. With the wrong repos.
3082018-01-31T11:54:09  <michagogo> wumpus: yeah, I know about that issue
3092018-01-31T11:54:11  <wumpus> maybe they'd rather break their system than simply admit something is not possible and use a different release
3102018-01-31T11:54:21  <michagogo> Maybe
3112018-01-31T11:54:33  <michagogo> But the problem is that we’re telling people to do that
3122018-01-31T11:54:34  <wumpus> I mean it's windows users, they're doing this in a sandbox that can be nuked and re-instated with one button push
3132018-01-31T11:54:54  <michagogo> With a little footnote saying “this might cause issues”
3142018-01-31T11:55:03  <wumpus> also they're probably not doing anything else in these VMs than building bitcoin
3152018-01-31T11:55:09  <michagogo> Rather than “this is guaranteed to completely break the system”
3162018-01-31T11:55:18  *** dabura667 has quit IRC
3172018-01-31T11:55:26  <wumpus> anyhow, feel free to add proper warnings to the document, I've given up on that
3182018-01-31T11:55:49  <wumpus> it's not that I didn't mention that in reviews but who listens to me, maybe they listen to you
3192018-01-31T11:56:03  <michagogo> Is there a way to safely get just the newer compiler packages?
3202018-01-31T11:56:18  <michagogo> Some ppa, backports, something like that?
3212018-01-31T11:58:39  <wumpus> you could build your own toolchain, I'm partial to crosstool-ng myself as it comes with a nice menu configuration tool
3222018-01-31T12:00:09  <wumpus> you need some patience but at least you can configure anything you'd ever wanted (and not wanted) to configure about the toolchain, and you're not bound to a certain version of binutils, gcc, libc, etc, that happens to come with your distro
3232018-01-31T12:01:22  <wumpus> I use this for ARM boards all the time as ubuntu's default cross compilers only target a specific sw/hw combo, but i think it can do mingw-something as well.
3242018-01-31T12:03:17  *** Krellan has joined #bitcoin-core-dev
3252018-01-31T12:06:03  <wumpus> of course for a guide it's much easier to just say 'use ubunu 16.10 or higher', but I digress, that's what we already tried...
3262018-01-31T12:07:03  <wumpus> at least we'll hopefully have 18.04 soon so there's a new LTS that can (hopefully) build working windows executables
3272018-01-31T12:09:30  *** tryphe_ is now known as tryphe
3282018-01-31T12:21:30  *** mrannanay has joined #bitcoin-core-dev
3292018-01-31T12:26:36  *** denis2342 has quit IRC
3302018-01-31T12:30:06  *** indistylo has joined #bitcoin-core-dev
3312018-01-31T12:30:55  <michagogo> Yeah
3322018-01-31T12:31:13  <michagogo> Btw, someone in #ubuntu pointed out that zesty is EOL...
3332018-01-31T12:31:20  <michagogo> So even those instructions won’t work
3342018-01-31T12:31:43  <michagogo> I wonder how much trouble it would be to get mingw backported
3352018-01-31T12:31:51  *** anil_ has joined #bitcoin-core-dev
3362018-01-31T12:32:01  <anil_> hello
3372018-01-31T12:32:12  *** anil_ is now known as anil_1524
3382018-01-31T12:32:16  <michagogo> Hi.
3392018-01-31T12:33:26  *** AaronvanW has joined #bitcoin-core-dev
3402018-01-31T12:33:31  <anil_1524> What is the easiest way to install the Berkeley DB dependencies on Debian Stretch?
3412018-01-31T12:34:35  <wumpus> contrib/install_db4.sh
3422018-01-31T12:35:41  <wumpus> michagogo: just use 17.10 then...
3432018-01-31T12:35:44  *** aruns has joined #bitcoin-core-dev
3442018-01-31T12:36:09  <wumpus> it will be EOL july 2018, but by that time you can upgrade to 18.04
3452018-01-31T12:36:56  <anil_1524> wumpus: thanks
3462018-01-31T12:37:03  *** anil_1524 has quit IRC
3472018-01-31T12:37:45  *** denis2342 has joined #bitcoin-core-dev
3482018-01-31T12:38:16  <wumpus> I've heard of people here using the 18.04 pre-release dailies but that's really living on the edge
3492018-01-31T12:38:25  *** indistylo has quit IRC
3502018-01-31T12:39:13  *** belcher has joined #bitcoin-core-dev
3512018-01-31T12:44:04  *** AaronvanW has quit IRC
3522018-01-31T12:44:45  *** AaronvanW has joined #bitcoin-core-dev
3532018-01-31T12:44:57  <bitcoin-git> [bitcoin] practicalswift closed pull request #10975: [script] Return early if no valid opcodes found in CountWitnessSigOps(...) (master...return-early-in-CountWitnessSigOps) https://github.com/bitcoin/bitcoin/pull/10975
3542018-01-31T12:45:18  *** AaronvanW has quit IRC
3552018-01-31T12:46:19  *** AaronvanW has joined #bitcoin-core-dev
3562018-01-31T12:51:16  *** AaronvanW has quit IRC
3572018-01-31T12:57:17  *** checksauce has quit IRC
3582018-01-31T12:58:16  *** aruns__ has joined #bitcoin-core-dev
3592018-01-31T13:00:40  *** aruns has quit IRC
3602018-01-31T13:07:26  *** Lavonne24Walker has quit IRC
3612018-01-31T13:09:49  <provoostenator> I'm one of those people living on the edge with 18.04 pre-release. I sometimes fall off the edge :-)
3622018-01-31T13:10:11  <provoostenator> (in a VM, that I don't really need)
3632018-01-31T13:10:28  <wumpus> well someone needs to do the testing :)
3642018-01-31T13:11:27  <provoostenator> Oh and with production c-lightning :-)
3652018-01-31T13:11:33  <wumpus> the danger of succesfully discouraging people from using pre-release software is that the released software will be less well-tested and thus increases risk for the rest.
3662018-01-31T13:11:59  <wumpus> this is, FWIW, why I'm not super enthusiastic about #12300
3672018-01-31T13:12:01  <gribble> https://github.com/bitcoin/bitcoin/issues/12300 | [Build] Adding --enable-mainnet configuration option for running mainnet by jeffrade · Pull Request #12300 · bitcoin/bitcoin · GitHub
3682018-01-31T13:13:22  <wumpus> yes let's not get started about production c-lighting :)
3692018-01-31T13:13:59  <provoostenator> That PR does seem a bit pedantic. Anyone who compiles from source should know what they're doing. But adding a flag isn't a show-stopper either.
3702018-01-31T13:14:32  *** zautomata1 has joined #bitcoin-core-dev
3712018-01-31T13:15:30  <wumpus> no, it's not, though having experience from having to type --with-incompatible-bdb 20 times a day (okay, overstating a bit) do we want another flag we always need :-)
3722018-01-31T13:15:38  <provoostenator> What would be more useful for me is being able to have testnet=1 in bitcoin.conf and then launch with -mainnet, because I do make that mistake quite often on my dev account.
3732018-01-31T13:16:20  <wumpus> I think the long-term idea is to have a -network=<bla> or -chain=<bla> instead of separate options for testnet, mainnet, regtest
3742018-01-31T13:16:33  *** zautomata has quit IRC
3752018-01-31T13:16:34  <wumpus> this resolves the case of conflicting options while specifying multiple
3762018-01-31T13:17:02  <provoostenator> I also want to be able to configure them differently, I believe there's a PR for that, e.g. I don't care about pruning testnet.
3772018-01-31T13:17:10  <wumpus> I mean if you specify -regtest -testnet -mainnet who is the code to know what you really want?
3782018-01-31T13:17:42  <provoostenator> That should be an error. Generally commandline flags override options in a config file, right?
3792018-01-31T13:17:47  <wumpus> it *is* an error
3802018-01-31T13:18:04  <wumpus> (at least specifying -regtest and -testnet at the same time)
3812018-01-31T13:18:10  <provoostenator> At least that's how -changetype behave now
3822018-01-31T13:18:25  <wumpus> but with -chain=... you could use simple override and it would simply work without having to special case them
3832018-01-31T13:18:47  *** aruns has joined #bitcoin-core-dev
3842018-01-31T13:18:53  <provoostenator> Yes, I agree -chain=testnet is more sensible than -testnet=1
3852018-01-31T13:19:37  *** meshcollider has quit IRC
3862018-01-31T13:19:38  <Sentineo> +1 on that :) I remember I was confused the first time I saw it
3872018-01-31T13:20:48  *** aruns__ has quit IRC
3882018-01-31T13:21:00  <bitcoin-git> [bitcoin] rutkov opened pull request #12311:  build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
3892018-01-31T13:22:06  <bitcoin-git> [bitcoin] fanquake closed pull request #12311:  build: bump version to 0.15.0 (master...master) https://github.com/bitcoin/bitcoin/pull/12311
3902018-01-31T13:22:33  <wumpus> bump version to 0.15.0? have I traveled back in time?
3912018-01-31T13:51:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/216f9a42e689...895fbd768f0c
3922018-01-31T13:51:28  <bitcoin-git> bitcoin/master 7f968ae Wladimir J. van der Laan: doc: Explain how to update chainTxData in release process...
3932018-01-31T13:51:29  <bitcoin-git> bitcoin/master 895fbd7 MarcoFalke: Merge #12309: doc: Explain how to update chainTxData in release process...
3942018-01-31T13:52:28  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12309: doc: Explain how to update chainTxData in release process (master...2018_01_release_process_chaintxstats) https://github.com/bitcoin/bitcoin/pull/12309
3952018-01-31T13:53:42  *** aruns__ has joined #bitcoin-core-dev
3962018-01-31T13:56:23  *** larafale has joined #bitcoin-core-dev
3972018-01-31T13:56:27  *** aruns has quit IRC
3982018-01-31T13:56:42  *** AaronvanW has joined #bitcoin-core-dev
3992018-01-31T13:59:31  *** Marilie13Nader has joined #bitcoin-core-dev
4002018-01-31T14:10:59  *** jamesob has joined #bitcoin-core-dev
4012018-01-31T14:12:48  *** anil_1524 has joined #bitcoin-core-dev
4022018-01-31T14:13:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4032018-01-31T14:14:33  *** Krellan has quit IRC
4042018-01-31T14:15:32  *** james has joined #bitcoin-core-dev
4052018-01-31T14:15:56  *** james is now known as Guest3712
4062018-01-31T14:16:10  *** Krellan has joined #bitcoin-core-dev
4072018-01-31T14:16:16  *** anil_1524 has quit IRC
4082018-01-31T14:16:28  *** anil_1524 has joined #bitcoin-core-dev
4092018-01-31T14:21:26  *** anil_1524 has quit IRC
4102018-01-31T14:22:41  *** meshcollider has joined #bitcoin-core-dev
4112018-01-31T14:26:16  *** Giszmo has joined #bitcoin-core-dev
4122018-01-31T14:27:50  *** promag has joined #bitcoin-core-dev
4132018-01-31T14:28:04  <promag> jamesob: https://github.com/bitcoin/bitcoin/pull/12305/files#diff-321303fddcf725df060981d626a05df9R38 paths or path?
4142018-01-31T14:30:13  <jamesob> promag: I'm fine with either
4152018-01-31T14:30:32  <cfields> jonasschnelli: ping
4162018-01-31T14:30:40  <promag> jamesob: remove https://github.com/bitcoin/bitcoin/pull/12305/files#diff-3b23ce4d86903a432863cfb3a1f1e547R10?
4172018-01-31T14:31:10  <jamesob> promag: but the fs namespace is used in that file?
4182018-01-31T14:33:38  <promag> jamesob: it is, but it's an unnecessary change in your PR. I mean, there are tons of other "missing" includes I guess
4192018-01-31T14:34:09  <promag> jamesob: if by any chance you have to amend, consider removing it
4202018-01-31T14:35:41  <jamesob> promag: will do, thanks. If others have similar feelings I'm happy to - just hard to tell when to make small improvements. I figured since this is a fairly low-risk, small change that an addition like that couldn't hurt, but maybe I'm wrong about that.
4212018-01-31T14:36:11  <jamesob> s/change/changeset
4222018-01-31T14:39:24  <promag> jamesob: I know that feeling. Usually I do secondary changes "near" the primary changes. I avoid unrelated changes (even simple changes). Maybe submit them in other pulls..
4232018-01-31T14:40:20  <jamesob> promag: just don't want to become the guy who opens PRs for #include changes (more than I already am ;)
4242018-01-31T14:41:19  <promag> jamesob: right, just don't do it then :) unless you have to
4252018-01-31T14:41:34  <arubi> seems that dumpwallet puts base58 addresses in the dump when the wallet is set to bech32 (getnewaddress returns bech32)
4262018-01-31T14:44:50  *** Giszmo has quit IRC
4272018-01-31T14:49:23  *** Pavle has joined #bitcoin-core-dev
4282018-01-31T14:54:32  *** aruns has joined #bitcoin-core-dev
4292018-01-31T14:55:02  *** aruns__ has quit IRC
4302018-01-31T14:58:18  *** DDDev has joined #bitcoin-core-dev
4312018-01-31T14:58:48  <DDDev> Hi there, guys!
4322018-01-31T14:59:08  <DDDev> Have you ever seen deleted transaction in the blockchain?
4332018-01-31T15:00:54  <DDDev> For instance, you sent 10BTC and your transaction was unconfirmed for a long period of time. And after that the transaction became removed from the blockchain
4342018-01-31T15:02:27  <AndyS2> It's not even on the blockchain if it is unconfirmed. It's just in the mempool to be potentially added. There's #bitcoin-dev for more general development questions, btw. This channel is more so for development of Bitcoin Core (an implementation of the protocol).
4352018-01-31T15:05:28  <DDDev> Thank you, AndyS2
4362018-01-31T15:06:18  *** DDDev has quit IRC
4372018-01-31T15:07:00  *** Marilie13Nader has quit IRC
4382018-01-31T15:09:18  *** aruns has quit IRC
4392018-01-31T15:14:27  *** mrannanay has quit IRC
4402018-01-31T15:14:39  *** Pavle has quit IRC
4412018-01-31T15:16:59  *** unholymachine has joined #bitcoin-core-dev
4422018-01-31T15:20:48  *** Krellan has quit IRC
4432018-01-31T15:21:25  *** Krellan has joined #bitcoin-core-dev
4442018-01-31T15:23:20  *** AaronvanW has quit IRC
4452018-01-31T15:31:04  *** Krellan has quit IRC
4462018-01-31T15:36:25  <provoostenator> I just noticed this by chance: #12312
4472018-01-31T15:36:26  <gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
4482018-01-31T15:36:57  *** Krellan has joined #bitcoin-core-dev
4492018-01-31T15:40:54  *** To7 has joined #bitcoin-core-dev
4502018-01-31T15:41:12  *** Krellan has quit IRC
4512018-01-31T15:41:26  *** wraithm has joined #bitcoin-core-dev
4522018-01-31T15:47:20  *** Krellan has joined #bitcoin-core-dev
4532018-01-31T15:50:25  *** SopaXorzTaker has joined #bitcoin-core-dev
4542018-01-31T15:59:23  *** Ewell74Mann has joined #bitcoin-core-dev
4552018-01-31T15:59:40  *** sd_ has joined #bitcoin-core-dev
4562018-01-31T16:04:17  *** Ewell74Mann has quit IRC
4572018-01-31T16:04:21  *** Giszmo has joined #bitcoin-core-dev
4582018-01-31T16:19:11  <arubi> does making dumpwallet use bech32 for the addresses if addresstype is bech32 or p2sh-segwit and base58 if it's legacy sound ok?
4592018-01-31T16:22:57  *** Giszmo has quit IRC
4602018-01-31T16:27:17  *** pedrobranco has joined #bitcoin-core-dev
4612018-01-31T16:33:09  <bitcoin-git> [bitcoin] Schallabeer opened pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
4622018-01-31T16:39:27  *** dcousens has quit IRC
4632018-01-31T16:39:37  *** meshcollider has quit IRC
4642018-01-31T16:40:04  *** Giszmo has joined #bitcoin-core-dev
4652018-01-31T16:40:30  *** dcousens has joined #bitcoin-core-dev
4662018-01-31T16:40:45  <promag> tag #12312 as bug?
4672018-01-31T16:40:46  <gribble> https://github.com/bitcoin/bitcoin/issues/12312 | QT ignores -changetype=bech32 when coin control features are enabled · Issue #12312 · bitcoin/bitcoin · GitHub
4682018-01-31T16:59:23  *** Aron81Hahn has joined #bitcoin-core-dev
4692018-01-31T17:07:11  *** RubenSomsen has joined #bitcoin-core-dev
4702018-01-31T17:08:33  *** Giszmo has quit IRC
4712018-01-31T17:09:02  *** Victorsueca has quit IRC
4722018-01-31T17:09:53  *** Krellan has quit IRC
4732018-01-31T17:10:14  *** Victorsueca has joined #bitcoin-core-dev
4742018-01-31T17:11:05  <bitcoin-git> [bitcoin] fivepiece opened pull request #12315: Bech32 addresses in dumpwallet (master...dumpwallet-bech32) https://github.com/bitcoin/bitcoin/pull/12315
4752018-01-31T17:11:08  *** AaronvanW has joined #bitcoin-core-dev
4762018-01-31T17:11:20  *** indistylo has joined #bitcoin-core-dev
4772018-01-31T17:12:10  *** timothy has joined #bitcoin-core-dev
4782018-01-31T17:20:17  *** Krellan has joined #bitcoin-core-dev
4792018-01-31T17:24:27  *** Derrekito has joined #bitcoin-core-dev
4802018-01-31T17:24:35  *** Giszmo has joined #bitcoin-core-dev
4812018-01-31T17:26:45  *** Chris_Stewart_5 has quit IRC
4822018-01-31T17:31:13  *** Aron81Hahn has quit IRC
4832018-01-31T17:42:10  *** RubenSomsen has quit IRC
4842018-01-31T17:42:17  *** RubenSomsen has joined #bitcoin-core-dev
4852018-01-31T17:45:41  *** timothy has quit IRC
4862018-01-31T17:52:39  *** reardencode has joined #bitcoin-core-dev
4872018-01-31T17:54:46  *** Krellan has quit IRC
4882018-01-31T17:55:49  *** Krellan has joined #bitcoin-core-dev
4892018-01-31T17:59:05  *** RubenSomsen has quit IRC
4902018-01-31T17:59:23  *** Gardner37Bernier has joined #bitcoin-core-dev
4912018-01-31T18:00:22  *** RubenSomsen has joined #bitcoin-core-dev
4922018-01-31T18:00:46  *** pedrobranco has quit IRC
4932018-01-31T18:01:19  *** pedrobranco has joined #bitcoin-core-dev
4942018-01-31T18:01:59  *** pedrobranco has joined #bitcoin-core-dev
4952018-01-31T18:04:10  *** Gardner37Bernier has quit IRC
4962018-01-31T18:07:55  *** jb55 has joined #bitcoin-core-dev
4972018-01-31T18:14:58  *** Krellan has quit IRC
4982018-01-31T18:15:53  *** Krellan has joined #bitcoin-core-dev
4992018-01-31T18:16:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5002018-01-31T18:16:47  *** keks_ has joined #bitcoin-core-dev
5012018-01-31T18:17:45  *** indistylo has quit IRC
5022018-01-31T18:17:45  <gmaxwell> ugh. I really dislike 12300.
5032018-01-31T18:18:26  <gmaxwell> If we want to reduce screw up risk we should make the github default branch a release branch; not boobytrap the prerelease software.
5042018-01-31T18:21:36  <gmaxwell> for the original ask, a developer that doesn't want to mess up their own wallets, could be just as well addressed with a --disable-mainnet configure option that they could setup to normally use.
5052018-01-31T18:36:24  *** Dizzle has joined #bitcoin-core-dev
5062018-01-31T18:39:12  <bitcoin-git> [bitcoin] thijstriemstra opened pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316
5072018-01-31T18:40:55  *** Murch has joined #bitcoin-core-dev
5082018-01-31T18:42:21  *** vicenteH has quit IRC
5092018-01-31T18:44:07  <jonasschnelli> gmaxwell: agree
5102018-01-31T18:46:08  <gmaxwell> achow101: so your belief is that for some input conditions the signer is producing an invalid signature?
5112018-01-31T18:46:36  *** pedrobranco has quit IRC
5122018-01-31T18:48:05  *** RubenSomsen has quit IRC
5132018-01-31T18:50:22  <bitcoin-git> [bitcoin] jnewbery opened pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
5142018-01-31T18:50:59  *** Victorsueca has quit IRC
5152018-01-31T18:52:14  *** Victorsueca has joined #bitcoin-core-dev
5162018-01-31T18:52:57  <cfields> gmaxwell / jonasschnelli: I agree as well. If anything, I think that's kinda dangerous as downstreams can just quietly remove the ifdef, and users think they're shielded from mainnet
5172018-01-31T18:54:52  <cfields> i can see the need for some kind of switch like that, but I'd rather do it in the appropriate place. ie If exposing the wallet to mainnet is scary, then add something there.
5182018-01-31T18:55:22  *** AaronvanW has quit IRC
5192018-01-31T18:56:40  *** RubenSomsen has joined #bitcoin-core-dev
5202018-01-31T18:56:49  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12313: 0.16 (master...0.16) https://github.com/bitcoin/bitcoin/pull/12313
5212018-01-31T18:59:24  *** Felipe64Satterfi has joined #bitcoin-core-dev
5222018-01-31T19:03:01  *** Tennis has joined #bitcoin-core-dev
5232018-01-31T19:12:34  *** adiabat has quit IRC
5242018-01-31T19:14:34  *** adiabat has joined #bitcoin-core-dev
5252018-01-31T19:17:50  *** mandric has quit IRC
5262018-01-31T19:26:07  *** SopaXorzTaker has quit IRC
5272018-01-31T19:27:18  *** Felipe64Satterfi has quit IRC
5282018-01-31T19:33:59  *** Giszmo has quit IRC
5292018-01-31T19:37:07  *** laurentmt has joined #bitcoin-core-dev
5302018-01-31T19:38:40  *** orenamsalem has joined #bitcoin-core-dev
5312018-01-31T19:41:11  *** jb55 has quit IRC
5322018-01-31T19:41:58  *** meshcollider has joined #bitcoin-core-dev
5332018-01-31T19:46:15  *** shesek has quit IRC
5342018-01-31T19:51:44  *** dcousens has quit IRC
5352018-01-31T19:57:19  *** dcousens has joined #bitcoin-core-dev
5362018-01-31T19:59:28  *** Leonel25Stamm has joined #bitcoin-core-dev
5372018-01-31T20:02:07  *** shesek has joined #bitcoin-core-dev
5382018-01-31T20:02:07  *** shesek has joined #bitcoin-core-dev
5392018-01-31T20:05:20  *** goatpig has joined #bitcoin-core-dev
5402018-01-31T20:13:31  *** AaronvanW has joined #bitcoin-core-dev
5412018-01-31T20:18:59  *** laurentmt has quit IRC
5422018-01-31T20:27:27  *** jamesob has quit IRC
5432018-01-31T20:32:44  *** Krellan has quit IRC
5442018-01-31T20:33:53  *** Krellan has joined #bitcoin-core-dev
5452018-01-31T20:42:32  *** dermoth has quit IRC
5462018-01-31T20:45:41  *** vicenteH has joined #bitcoin-core-dev
5472018-01-31T20:47:04  *** merehap has joined #bitcoin-core-dev
5482018-01-31T20:56:09  *** dermoth has joined #bitcoin-core-dev
5492018-01-31T20:56:41  *** moctost has quit IRC
5502018-01-31T20:56:53  *** moctost has joined #bitcoin-core-dev
5512018-01-31T20:57:08  *** moctost has joined #bitcoin-core-dev
5522018-01-31T20:58:24  *** Guest3712 has quit IRC
5532018-01-31T20:58:45  *** Leonel25Stamm has quit IRC
5542018-01-31T21:00:27  *** cloaks has quit IRC
5552018-01-31T21:01:52  *** cloaks has joined #bitcoin-core-dev
5562018-01-31T21:05:39  *** Victorsueca has quit IRC
5572018-01-31T21:06:47  *** Victorsueca has joined #bitcoin-core-dev
5582018-01-31T21:09:27  *** AaronvanW has quit IRC
5592018-01-31T21:10:11  *** eklitzke has quit IRC
5602018-01-31T21:11:15  *** dund has joined #bitcoin-core-dev
5612018-01-31T21:15:17  <jtimon> what is this label supposed to mean? https://github.com/bitcoin/bitcoin/labels/good%20first%20issue
5622018-01-31T21:16:20  <phantomcircuit> jtimon, i assume things someone can work on as their first pr
5632018-01-31T21:16:47  <jtimon> oh, I see, thanks
5642018-01-31T21:20:09  *** RubenSomsen has quit IRC
5652018-01-31T21:21:35  *** Dizzle has quit IRC
5662018-01-31T21:22:35  *** cloaks has quit IRC
5672018-01-31T21:25:24  *** eklitzke has joined #bitcoin-core-dev
5682018-01-31T21:45:51  <mryandao> are there any plans to implement compact filters for bitcoin-core?
5692018-01-31T21:46:04  <mryandao> to deprecate bip37 bloom filter service?
5702018-01-31T21:46:18  *** Chris_Stewart_5 has quit IRC
5712018-01-31T21:49:20  *** dafuq[m] has joined #bitcoin-core-dev
5722018-01-31T21:50:10  <achow101> gmaxwell: I just screwed up BnB, that's all
5732018-01-31T21:51:40  *** meshcollider has quit IRC
5742018-01-31T21:51:57  <jtimon> review begging for https://github.com/bitcoin/bitcoin/pull/12128/files I think it's a simple to review but nice simplification (sorry for the redundancy)
5752018-01-31T21:53:04  *** dafuq[m] has quit IRC
5762018-01-31T21:53:18  *** dafuq[m] has joined #bitcoin-core-dev
5772018-01-31T21:53:18  *** dafuq[m] has joined #bitcoin-core-dev
5782018-01-31T21:59:22  *** Lolita12Robel has joined #bitcoin-core-dev
5792018-01-31T22:00:57  *** Murch has quit IRC
5802018-01-31T22:01:18  *** dafuq[m] has quit IRC
5812018-01-31T22:02:49  *** Murch has joined #bitcoin-core-dev
5822018-01-31T22:03:54  *** dafuq[m] has joined #bitcoin-core-dev
5832018-01-31T22:03:54  *** dafuq[m] has joined #bitcoin-core-dev
5842018-01-31T22:04:18  *** Lolita12Robel has quit IRC
5852018-01-31T22:06:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5862018-01-31T22:08:41  <gmaxwell> achow101: whew. what did you screw up?
5872018-01-31T22:09:09  <achow101> gmaxwell: amounts. I was using the effective value of the utxo when signing instead of its actual value
5882018-01-31T22:09:40  <gmaxwell> doh
5892018-01-31T22:20:34  *** Murch has quit IRC
5902018-01-31T22:21:59  *** Murch has joined #bitcoin-core-dev
5912018-01-31T22:22:52  <jimpo> mryandao: https://github.com/bitcoin/bitcoin/pull/12254. Could use some review if you have time. :-)
5922018-01-31T22:22:57  *** Chris_Stewart_5 has quit IRC
5932018-01-31T22:24:17  <gmaxwell> achow101: I'm super glad you're working on BnB again.
5942018-01-31T22:27:47  *** Tennis has quit IRC
5952018-01-31T22:42:24  *** keks_ has quit IRC
5962018-01-31T22:47:19  *** Giszmo has joined #bitcoin-core-dev
5972018-01-31T22:52:52  <mryandao> how often should I follow up on a pending PR to get it closed?
5982018-01-31T22:54:03  <mryandao> jimpo: cool! good to see that there'll be less spying going on eventually.
5992018-01-31T22:54:39  *** Krellan has quit IRC
6002018-01-31T22:55:18  *** Krellan has joined #bitcoin-core-dev
6012018-01-31T22:57:17  *** orenamsalem has quit IRC
6022018-01-31T22:57:30  *** Giszmo has quit IRC
6032018-01-31T22:59:06  <midnightmagic> What's BnB? :-)
6042018-01-31T22:59:23  *** Gaylord37Sanford has joined #bitcoin-core-dev
6052018-01-31T23:01:39  *** Giszmo has joined #bitcoin-core-dev
6062018-01-31T23:04:38  <gmaxwell> Branch and Bound.  Solvers that can construct changeless transactions.
6072018-01-31T23:15:28  *** wxss has quit IRC
6082018-01-31T23:17:58  <midnightmagic> nice.
6092018-01-31T23:18:01  <midnightmagic> \o/
6102018-01-31T23:31:48  *** meshcollider has joined #bitcoin-core-dev
6112018-01-31T23:32:30  *** mlz has quit IRC
6122018-01-31T23:34:03  *** larafale has quit IRC
6132018-01-31T23:34:09  *** larafale has joined #bitcoin-core-dev
6142018-01-31T23:34:55  <bitcoin-git> [bitcoin] Empact opened pull request #12319: Add size checking to CPubKey::IsValid, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319
6152018-01-31T23:35:06  *** mlz has joined #bitcoin-core-dev
6162018-01-31T23:37:47  *** wraithm has quit IRC
6172018-01-31T23:38:27  *** Giszmo has quit IRC
6182018-01-31T23:44:02  *** AaronvanW has joined #bitcoin-core-dev
6192018-01-31T23:49:27  *** AaronvanW has quit IRC
6202018-01-31T23:53:23  *** Guyver2 has quit IRC