12018-02-02T00:14:25  *** CubicEarths has joined #bitcoin-core-dev
  22018-02-02T00:18:30  *** CubicEarths has quit IRC
  32018-02-02T00:19:28  *** CubicEarths has joined #bitcoin-core-dev
  42018-02-02T00:21:41  *** CubicEarths has quit IRC
  52018-02-02T00:26:07  *** Krellan has quit IRC
  62018-02-02T00:29:50  *** CubicEarths has joined #bitcoin-core-dev
  72018-02-02T00:37:38  *** promag has joined #bitcoin-core-dev
  82018-02-02T00:47:06  *** wxss has quit IRC
  92018-02-02T00:48:22  *** CubicEarths has quit IRC
 102018-02-02T00:58:16  <meshcollider> wumpus: I think I've finished off the release notes
 112018-02-02T00:58:34  <meshcollider> If others could double check I haven't made any stupid mistakes or left anything out that'd be good
 122018-02-02T00:58:46  <meshcollider> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
 132018-02-02T01:01:29  <sipa> meshcollider: address_type is also added to getnewaddress
 142018-02-02T01:01:54  <meshcollider> sipa: but that RPC is deprecated now so should we even bother adding that?
 152018-02-02T01:02:22  <sipa> what?
 162018-02-02T01:02:43  <meshcollider> oh sorry I misread and thought you said addwitnessaddress
 172018-02-02T01:02:43  <sipa> you're confusing getnewaddress with addwitnessaddress, i think?
 182018-02-02T01:02:46  <meshcollider> yeah
 192018-02-02T01:03:14  <sipa> also, with the inclusion of scripts in dump/import, i think those RPCs may just work fine
 202018-02-02T01:04:05  <meshcollider> sipa: true, we should test it properly first before claiming though IMO?
 212018-02-02T01:04:11  *** Dizzle has quit IRC
 222018-02-02T01:04:33  <sipa> meshcollider: yes, absolutely
 232018-02-02T01:04:48  <sipa> but i think there's a good chance it just works now
 242018-02-02T01:04:49  <meshcollider> Oh I'll just remove mention of those RPCs altogether for now rather than saying they are or are not supported
 252018-02-02T01:05:07  <sipa> sign/verify and importmulti definitely don't support segwit addresses
 262018-02-02T01:06:27  *** Murch has quit IRC
 272018-02-02T01:08:49  <promag> s/segwit/SegWit ?
 282018-02-02T01:09:01  *** fanquake has joined #bitcoin-core-dev
 292018-02-02T01:09:02  <promag> or who cares?
 302018-02-02T01:09:48  *** dabura667 has joined #bitcoin-core-dev
 312018-02-02T01:12:08  <promag> #low-level-rpc-changes should mention fundrawtransaction change type and addmultisigaddress address type ?
 322018-02-02T01:13:24  <sipa> meshcollider: validateaddress has had many changes
 332018-02-02T01:13:42  <meshcollider> promag: you can change them all if you want :)
 342018-02-02T01:13:56  <sipa> just mentioning it now in case someone wants to do a writeup
 352018-02-02T01:14:01  <sipa> if not, i'll do so in a few days
 362018-02-02T01:14:25  <meshcollider> promag: I added them to the segwit sections rather than the low level RPC changes, IMO no point duplicating the info as long as its in a logical place
 372018-02-02T01:15:01  <promag> ok cool
 382018-02-02T01:15:02  <meshcollider> sipa: what kind of changes, andrews PR hasnt been merged yet has it
 392018-02-02T01:15:09  <meshcollider> I must have missed something
 402018-02-02T01:15:52  <sipa> meshcollider: included in 11403
 412018-02-02T01:16:17  <sipa> commit 3eaa003c8
 422018-02-02T01:16:55  <fanquake> In the SHA256 ASM section. s/has/have s/this was/they were s/but is/but are and remove "is no" .
 432018-02-02T01:17:12  <fanquake> Can we get conflicts when editing the wiki? I don't want to touch it in case I mess up your good work.
 442018-02-02T01:17:32  <sipa> meshcollider: specifically, there are new "embedded" and "pubkeys" fields that apply to non-segwit as well
 452018-02-02T01:18:15  <meshcollider> fanquake: I guess there might be conflicts if we edited the same part but I'm not currently editing so it should be ok
 462018-02-02T01:18:27  <meshcollider> sipa: ooh ok I missed those, will add then
 472018-02-02T01:19:20  <sipa> also, validateaddress has new functionality related to P2SH-P2WPKH, so that doesn't fit under BIP173 support
 482018-02-02T01:23:46  <promag> do we have any idea what are the top 5 of most called RPC
 492018-02-02T01:27:25  <gmaxwell> it's very different for different users.
 502018-02-02T01:27:45  <gmaxwell> getblocktemplate and listtransactions are probably the most common rpcs (for miners, and people getting payments, respectively)
 512018-02-02T01:28:13  <gmaxwell> and then other than a few status things, I'd expect everything else to be basically insubstantial compared to those.
 522018-02-02T01:28:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 532018-02-02T01:31:08  *** intcat has quit IRC
 542018-02-02T01:32:11  *** acehighwind has joined #bitcoin-core-dev
 552018-02-02T01:37:12  *** jamesob has joined #bitcoin-core-dev
 562018-02-02T01:38:06  *** intcat has joined #bitcoin-core-dev
 572018-02-02T01:38:54  <promag> gmaxwell: listunspent?
 582018-02-02T01:39:24  *** unholymachine has quit IRC
 592018-02-02T01:39:41  <gmaxwell> I wouldn't expect listunspent to be called more than sendrawtransaction, which would be rare since we know that network wide there is only a certian amount of that.
 602018-02-02T01:39:43  *** unholymachine has joined #bitcoin-core-dev
 612018-02-02T01:40:53  *** bule has quit IRC
 622018-02-02T01:46:41  <promag> ok ty
 632018-02-02T01:52:49  *** acehighwind has quit IRC
 642018-02-02T02:02:07  <promag> gmaxwell: does this make sense https://github.com/promag/bitcoin/commit/c409b1adac59329b78b8c48f131f8ca032988412 ?
 652018-02-02T02:04:27  <gmaxwell> I don't think so-- at least if I understand it correctly. listtransactions should be atomic with the blockchain. If the chain reorgs you shouldn't get mixed data on transactions. An example of how this could result in funds loss, say I pay you with a transaction then doublespend it to pay more fees with another txn also paying you.  If you see a reorg that goes from one to the other during a lis
 662018-02-02T02:04:33  <gmaxwell> ttransactions, they you might see both payments as confirmed and credit the user twice.
 672018-02-02T02:07:06  <promag> gmaxwell: it's still atomic
 682018-02-02T02:07:29  <promag> sorting the output is done without the locks
 692018-02-02T02:08:47  <gmaxwell> hm? is it copying all the data then? otherwise confirm counts and whatnot would get updated, no?
 702018-02-02T02:09:05  <promag> i think so, AcentryToJSON
 712018-02-02T02:09:57  <gmaxwell> oh I see how I was misreading it.
 722018-02-02T02:10:03  <gmaxwell> okay thats plausable
 732018-02-02T02:10:39  <promag> I guess this is easy to bench
 742018-02-02T02:12:50  *** intcat has quit IRC
 752018-02-02T02:13:22  <bitcoin-git> [bitcoin] promag opened pull request #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions (master...2018-02-listtransactions) https://github.com/bitcoin/bitcoin/pull/12330
 762018-02-02T02:13:27  *** tknp has joined #bitcoin-core-dev
 772018-02-02T02:14:37  *** intcat has joined #bitcoin-core-dev
 782018-02-02T02:15:34  *** RubenSomsen has joined #bitcoin-core-dev
 792018-02-02T02:21:48  *** Chris_Stewart_5 has quit IRC
 802018-02-02T02:22:35  *** Giszmo has quit IRC
 812018-02-02T02:26:01  *** d9b4bef9 has quit IRC
 822018-02-02T02:27:08  *** d9b4bef9 has joined #bitcoin-core-dev
 832018-02-02T02:27:20  *** promag has quit IRC
 842018-02-02T02:31:11  *** veleiro has joined #bitcoin-core-dev
 852018-02-02T02:36:59  *** fanquake has quit IRC
 862018-02-02T02:40:33  *** Giszmo has joined #bitcoin-core-dev
 872018-02-02T02:42:55  *** goatpig has quit IRC
 882018-02-02T02:49:53  *** ossifrage has quit IRC
 892018-02-02T02:55:25  *** jamesob has quit IRC
 902018-02-02T02:58:41  *** belcher has quit IRC
 912018-02-02T03:03:59  *** mandric has joined #bitcoin-core-dev
 922018-02-02T03:04:53  *** ossifrage has joined #bitcoin-core-dev
 932018-02-02T03:05:00  *** instagibbs has quit IRC
 942018-02-02T03:05:58  *** instagibbs has joined #bitcoin-core-dev
 952018-02-02T03:08:13  *** Franklin_ has joined #bitcoin-core-dev
 962018-02-02T03:11:05  *** punch has quit IRC
 972018-02-02T03:12:17  *** DrFeelGood has joined #bitcoin-core-dev
 982018-02-02T03:21:27  *** RubenSomsen has quit IRC
 992018-02-02T03:25:06  *** mandric has quit IRC
1002018-02-02T03:28:13  *** quer has joined #bitcoin-core-dev
1012018-02-02T03:35:15  *** quer has quit IRC
1022018-02-02T03:38:18  *** bule has joined #bitcoin-core-dev
1032018-02-02T03:46:20  <Franklin_> does anyone have examples of cross chain atomic swap script(s) for onchain swaps?
1042018-02-02T03:49:44  *** quer has joined #bitcoin-core-dev
1052018-02-02T03:58:50  *** Randolf has joined #bitcoin-core-dev
1062018-02-02T04:03:12  *** quer has quit IRC
1072018-02-02T04:03:30  *** quer has joined #bitcoin-core-dev
1082018-02-02T04:12:59  *** ghost43 has quit IRC
1092018-02-02T04:13:43  *** RubenSomsen has joined #bitcoin-core-dev
1102018-02-02T04:15:33  <dafuq> could someone who knows unix/linux possibly chime in on PR #12322?
1112018-02-02T04:15:35  <gribble> https://github.com/bitcoin/bitcoin/issues/12322 | Docs: Remove step making cloned repository world-writable for Windows build. by murrayn · Pull Request #12322 · bitcoin/bitcoin · GitHub
1122018-02-02T04:17:53  *** ghost43 has joined #bitcoin-core-dev
1132018-02-02T04:22:45  *** RubenSomsen has quit IRC
1142018-02-02T04:23:07  *** RubenSomsen has joined #bitcoin-core-dev
1152018-02-02T04:24:41  *** quer has quit IRC
1162018-02-02T04:24:41  *** quer has joined #bitcoin-core-dev
1172018-02-02T04:24:41  *** RubenSomsen has quit IRC
1182018-02-02T04:27:27  *** Aliencorpse has joined #bitcoin-core-dev
1192018-02-02T04:28:41  *** quer has quit IRC
1202018-02-02T04:30:18  *** instagibbs has quit IRC
1212018-02-02T04:31:12  *** quer has joined #bitcoin-core-dev
1222018-02-02T04:32:07  *** instagibbs has joined #bitcoin-core-dev
1232018-02-02T04:36:40  *** Giszmo has quit IRC
1242018-02-02T04:41:34  *** justan0theruser is now known as justanotheruser
1252018-02-02T05:00:24  *** tknp has quit IRC
1262018-02-02T05:23:17  *** checksauce has joined #bitcoin-core-dev
1272018-02-02T05:26:22  *** checksauce has quit IRC
1282018-02-02T05:29:03  *** checksau_ has joined #bitcoin-core-dev
1292018-02-02T05:42:10  *** g00d_N1ght_ has joined #bitcoin-core-dev
1302018-02-02T05:45:34  <gmaxwell> wumpus: I think the FD issue is likely fixed.  I ran RC1 in valgrind and after a few minutes of running had a branch on uninitilized in socket close.
1312018-02-02T05:45:56  <gmaxwell> I pulled up to master, compiled, restarted, and now hours later no such error.
1322018-02-02T05:46:26  <gmaxwell> As suspected, an uninitilied close was closing random FDs.
1332018-02-02T05:47:56  *** g00d_N1ght_ has quit IRC
1342018-02-02T05:48:18  *** aruns__ has joined #bitcoin-core-dev
1352018-02-02T05:49:18  *** ossifrage has quit IRC
1362018-02-02T05:50:52  *** justan0theruser has joined #bitcoin-core-dev
1372018-02-02T05:53:12  *** justanotheruser has quit IRC
1382018-02-02T06:08:08  *** veleiro has quit IRC
1392018-02-02T06:11:01  <meshcollider> That's good \o/
1402018-02-02T06:21:57  *** ossifrage has joined #bitcoin-core-dev
1412018-02-02T06:25:17  *** bule has quit IRC
1422018-02-02T06:26:01  *** checksauce has joined #bitcoin-core-dev
1432018-02-02T06:28:18  *** flokie has quit IRC
1442018-02-02T06:29:47  *** checksau_ has quit IRC
1452018-02-02T06:40:24  *** Franklin_ has quit IRC
1462018-02-02T06:52:27  *** aruns__ has quit IRC
1472018-02-02T06:54:26  *** aruns__ has joined #bitcoin-core-dev
1482018-02-02T07:29:23  *** veleiro has joined #bitcoin-core-dev
1492018-02-02T07:34:04  *** veleiro has quit IRC
1502018-02-02T07:41:51  *** shesek has quit IRC
1512018-02-02T07:43:32  <bitcoin-git> [bitcoin] murrayn opened pull request #12331: Docs: Properly alphabetize output of CLI --help option. (master...help_changes) https://github.com/bitcoin/bitcoin/pull/12331
1522018-02-02T07:45:46  *** justan0theruser is now known as justanotheruser
1532018-02-02T07:47:57  *** veleiro has joined #bitcoin-core-dev
1542018-02-02T07:54:40  *** shesek has joined #bitcoin-core-dev
1552018-02-02T07:55:32  *** promag has joined #bitcoin-core-dev
1562018-02-02T07:57:08  *** veleiro has left #bitcoin-core-dev
1572018-02-02T08:05:25  *** promag has quit IRC
1582018-02-02T08:13:38  *** farsider350 has quit IRC
1592018-02-02T08:16:04  *** farsider350 has joined #bitcoin-core-dev
1602018-02-02T08:19:49  *** promag has joined #bitcoin-core-dev
1612018-02-02T08:20:31  *** meshcollider has quit IRC
1622018-02-02T08:20:47  *** promag has quit IRC
1632018-02-02T08:20:53  *** farsider350 has quit IRC
1642018-02-02T08:23:59  *** twoken has quit IRC
1652018-02-02T08:24:17  *** farsider350 has joined #bitcoin-core-dev
1662018-02-02T08:24:23  *** twoken has joined #bitcoin-core-dev
1672018-02-02T08:48:26  *** Arokh has quit IRC
1682018-02-02T08:51:24  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41363fe11df5...aa360e76a74b
1692018-02-02T08:51:24  <bitcoin-git> bitcoin/master 660f5f1 Cory Fields: net: don't retry failed oneshot connections forever
1702018-02-02T08:51:25  <bitcoin-git> bitcoin/master aa360e7 Wladimir J. van der Laan: Merge #12329: net: don't retry failed oneshot connections forever...
1712018-02-02T08:52:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/e54c1ac11066...5303970c26a5
1722018-02-02T08:52:02  <bitcoin-git> bitcoin/0.16 0dc6a30 João Barbosa: [gui] Defer coin control instancing...
1732018-02-02T08:52:03  <bitcoin-git> bitcoin/0.16 5303970 Cory Fields: net: don't retry failed oneshot connections forever...
1742018-02-02T08:52:13  <bitcoin-git> [bitcoin] laanwj closed pull request #12329: net: don't retry failed oneshot connections forever (master...no-infinite-oneshot) https://github.com/bitcoin/bitcoin/pull/12329
1752018-02-02T08:53:35  *** booyah has quit IRC
1762018-02-02T08:54:45  *** booyah has joined #bitcoin-core-dev
1772018-02-02T09:01:33  *** booyah has quit IRC
1782018-02-02T09:03:39  *** booyah has joined #bitcoin-core-dev
1792018-02-02T09:04:07  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/f17942a3bc810d981724228bb5c99b5fb572efbe
1802018-02-02T09:04:08  <bitcoin-git> bitcoin/0.16 f17942a Wladimir J. van der Laan: qt: Pre-rc2 translations update...
1812018-02-02T09:05:26  *** Arokh has joined #bitcoin-core-dev
1822018-02-02T09:11:40  *** promag has joined #bitcoin-core-dev
1832018-02-02T09:12:31  *** arbitrary_guy has quit IRC
1842018-02-02T09:13:47  <wumpus> rc2 coming up, please interrupt me asap if I forgot something
1852018-02-02T09:18:10  <wumpus> so we have: fix for the fd issue (cfields, confirmed by gmaxwell above), fix for eternal retry of onetries (cfields), and fix for coin-control-bechs32-change (promag) in. I've updated the translations from transifex. Should be good to go.
1862018-02-02T09:18:28  <promag> ok
1872018-02-02T09:25:32  *** AaronvanW has joined #bitcoin-core-dev
1882018-02-02T09:27:17  *** Aaronvan_ has joined #bitcoin-core-dev
1892018-02-02T09:28:22  *** Aaronvan_ has joined #bitcoin-core-dev
1902018-02-02T09:31:05  *** AaronvanW has quit IRC
1912018-02-02T09:33:04  *** Aaronvan_ has quit IRC
1922018-02-02T09:35:23  *** zelest has left #bitcoin-core-dev
1932018-02-02T09:40:42  <wumpus>  * [new tag]         v0.16.0rc2 -> v0.16.0rc2
1942018-02-02T09:42:23  *** ghost43 has quit IRC
1952018-02-02T09:42:51  *** AaronvanW has joined #bitcoin-core-dev
1962018-02-02T09:43:20  *** ghost43 has joined #bitcoin-core-dev
1972018-02-02T09:45:46  *** vicenteH has joined #bitcoin-core-dev
1982018-02-02T09:46:11  *** Victorsueca has quit IRC
1992018-02-02T09:47:18  *** AaronvanW has quit IRC
2002018-02-02T09:47:28  *** Victorsueca has joined #bitcoin-core-dev
2012018-02-02T09:49:46  *** AaronvanW has joined #bitcoin-core-dev
2022018-02-02T10:04:08  *** checksau_ has joined #bitcoin-core-dev
2032018-02-02T10:05:19  *** checksauce has quit IRC
2042018-02-02T10:10:53  *** larafale has joined #bitcoin-core-dev
2052018-02-02T10:12:48  *** droark has quit IRC
2062018-02-02T10:22:38  <promag> gmaxwell: see #12330
2072018-02-02T10:22:39  <gribble> https://github.com/bitcoin/bitcoin/issues/12330 | Reduce scope of cs_main and cs_wallet locks in listtransactions by promag · Pull Request #12330 · bitcoin/bitcoin · GitHub
2082018-02-02T10:23:39  <wumpus> how do we want to call it in the release notes, SegWit, Segwit, segwit? it's kind of inconsistent at the moment
2092018-02-02T10:24:34  <gmaxwell> SeGwIt
2102018-02-02T10:24:58  <luke-jr> maybe markdown can be extended to randomize the case per view
2112018-02-02T10:25:06  <aj> it's "segwit" in --help
2122018-02-02T10:25:18  <luke-jr> "segwit" does seem to be the most common
2132018-02-02T10:26:54  <aj> "SegWit" in "addnode -help" rpc
2142018-02-02T10:27:11  <wumpus> ok so "segwit" captilized only as necessary?
2152018-02-02T10:27:20  <promag> https://bitcoincore.org/en/2016/01/26/segwit-benefits/ lowercase unless start of sentence
2162018-02-02T10:27:34  <gmaxwell> +1
2172018-02-02T10:27:36  <wumpus> right
2182018-02-02T10:27:47  <gmaxwell> or SeGregAteDWitness as appropriate.
2192018-02-02T10:28:20  <aj> greg should stop eating witnesses
2202018-02-02T10:28:31  <promag> aj: should we fix that?
2212018-02-02T10:28:44  <promag> "fix"
2222018-02-02T10:28:56  <gmaxwell> it's okay, I'm full.
2232018-02-02T10:29:16  <wumpus> hehehe
2242018-02-02T10:29:47  * aj wonders if SeGreg is as popular as selinux
2252018-02-02T10:30:45  * luke-jr wonders if GPL'd DNA mods cause reproduction to be copyright infringment
2262018-02-02T10:31:24  <sipa> wumpus: any of those three are fine, but concistency is nice
2272018-02-02T10:31:41  <sipa> i'm not such a fan of gmaxwell's capitalization preferences
2282018-02-02T10:32:04  <wumpus> yep, I've updated the wiki page to use "segwit" consistently
2292018-02-02T10:32:15  <wumpus> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.16.0-Release-notes
2302018-02-02T10:33:10  <midnightmagic> heh so greg ate de witness.
2312018-02-02T10:33:52  <gmaxwell> no sogregatede is something else, I'm pretty sure.
2322018-02-02T10:34:01  <luke-jr> Ated might have been better there.
2332018-02-02T10:34:18  <midnightmagic> not if you're quebecois
2342018-02-02T10:35:54  *** meshcollider has joined #bitcoin-core-dev
2352018-02-02T10:37:11  <wumpus> another word consistency issue (sorry) is it BIP 123 or BIP123?
2362018-02-02T10:38:06  *** fanquake has joined #bitcoin-core-dev
2372018-02-02T10:38:17  <wumpus> sometimes it says BIP 173, then BIP173, there is even a BIP-125
2382018-02-02T10:38:26  <wumpus> but BIP123 style seems most common
2392018-02-02T10:39:09  <aj> BIP123 seems most common in the code
2402018-02-02T10:39:20  <fanquake> I'll claim squashing "SSE" and 4 earlier today :p
2412018-02-02T10:39:22  <mesh_> I know I was a bit sloppy with the consistency there sorry, was copying and pasting things from all over the place
2422018-02-02T10:39:26  <wumpus> yes, ok, let's standardize on that
2432018-02-02T10:40:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa360e76a74b...1b06ed136f17
2442018-02-02T10:40:01  <bitcoin-git> bitcoin/master 1340eda practicalswift: Fix typos
2452018-02-02T10:40:02  <bitcoin-git> bitcoin/master 1b06ed1 MarcoFalke: Merge #12283: Fix typos...
2462018-02-02T10:40:04  <meshcollider> Yep no space is probably most sensible, slightly less neat than space though IMO
2472018-02-02T10:40:07  <aj> yeah, it's BIP123 in src/qt/locale/* in particular.
2482018-02-02T10:40:08  <wumpus> mesh_: no worries, this is mostly editorializing, the content is most important :)
2492018-02-02T10:40:40  <fanquake> Last I checked dropping the 0. was most important ;)
2502018-02-02T10:40:45  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12283: Fix typos (master...typos-20180128) https://github.com/bitcoin/bitcoin/pull/12283
2512018-02-02T10:40:49  <meshcollider> wumpus: has anyone addresses sipa's validateaddress changes earlier, I ran out of time
2522018-02-02T10:40:55  <meshcollider> Addressed*
2532018-02-02T10:43:07  <wumpus> the only mention of validateaddress is in BIP173 support
2542018-02-02T10:43:54  <provoostenator> Re release notes: "When launched with -addresstype=legacy it is unchecked and disabled." -> it's actually hidden.
2552018-02-02T10:44:26  <meshcollider> provoostenator: oh ok, I got that from the PR description ;)
2562018-02-02T10:44:54  <provoostenator> I changed it based on feedback, but probably forgot to update that part of the descrioption.
2572018-02-02T10:44:57  <meshcollider> wumpus: ok that's a to-do then, move it out of the BIP 173 section and write about all the other changes that happened to it
2582018-02-02T10:45:21  <meshcollider> I'll do it tomorrow, more of a mental note unless someone else does
2592018-02-02T10:45:54  <meshcollider> provoostenator: that's all good
2602018-02-02T10:45:56  <provoostenator> The behavior around (change) address types is currently spread accross several parts of the release notes. Maybe better to just have one section Address Types and discuss the various defaults, launch flags and RPC params there.
2612018-02-02T10:46:03  *** dabura667 has quit IRC
2622018-02-02T10:47:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b06ed136f17...4cad91663df3
2632018-02-02T10:47:17  <bitcoin-git> bitcoin/master 9bb59cf Jorge Timón: QA: segwit.py: s/find_unspent/find_spendable_utxo/
2642018-02-02T10:47:18  <bitcoin-git> bitcoin/master 4cad916 MarcoFalke: Merge #11869: QA: segwit.py: s/find_unspent/find_spendable_utxo/...
2652018-02-02T10:47:19  <wumpus> provoostenator: right; I've lazily grouped the address changes under wallet changes, because that's where people will be looking for them. I know some non-wallet utility functions are also affected.
2662018-02-02T10:47:26  <meshcollider> Btw wumpus it'd be cool if we added sjors to the github org, I mentioned it a while back and it got lost :)
2672018-02-02T10:47:38  <wumpus> meshcollider: yes
2682018-02-02T10:47:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11869:  QA: segwit.py: s/find_unspent/find_spendable_utxo/ (master...b16-segwit-test-fix) https://github.com/bitcoin/bitcoin/pull/11869
2692018-02-02T10:48:15  <wumpus> but explaining the types of addresses in a separate section wouldn't hurt
2702018-02-02T10:48:52  <wumpus> I'm done editing the wiki for now, so if anyone wants to have a go
2712018-02-02T10:48:53  <provoostenator> Being part of the github org is what gets you the T-Shirt, right?
2722018-02-02T10:48:59  <gmaxwell> do mention 'bc1' when talking about BIP173 addresses, since thats how users will identify them.
2732018-02-02T10:51:08  <wumpus> provoostenator: I'm not sure; maybe someone still has a stack of bitcoin core t-shirts from one of the real life dev meetings
2742018-02-02T10:51:24  <wumpus> I do have a lot of bitcoin core stickers
2752018-02-02T10:51:43  <provoostenator> I was kidding, but good to know there actually _are_ T-Shirts.
2762018-02-02T10:52:26  <meshcollider> provoostenator: there'll be t-shirts at coredev apparently :)
2772018-02-02T10:52:45  <meshcollider> wumpus: you should bring some stickers too then hehe
2782018-02-02T10:53:45  <meshcollider> provoostenator: I assume the t-shirts look like John's one on twitter
2792018-02-02T10:56:18  <wumpus> invited provoostenator for bitcoin and bitcoin-core orgs
2802018-02-02T10:56:30  <wumpus> meshcollider:sure!
2812018-02-02T10:56:58  <meshcollider> wumpus: can I join bitcoin-core too
2822018-02-02T10:57:01  <wumpus> meshcollider:  there is a photo from coredev zurich somewhere where almost everyone is wearing one
2832018-02-02T10:57:07  <wumpus> meshcollider: oh I forgot that?
2842018-02-02T10:57:17  <meshcollider> Oh nice!
2852018-02-02T10:57:21  <meshcollider> Yah haha
2862018-02-02T10:58:47  *** wxss has joined #bitcoin-core-dev
2872018-02-02T10:59:37  <meshcollider> Thanks :)
2882018-02-02T11:01:15  <provoostenator> wumpus: received invite, thanks
2892018-02-02T11:04:43  <provoostenator> "Uses of "µBTC" in the GUI now use the more colloquial term "bits". -> clarify that this is _in addition to_ uBTC, otherwise people might go mad without actually checking the app.
2902018-02-02T11:05:55  <gmaxwell> hah I was annoyed before I got to the end of provoostenator's message.
2912018-02-02T11:07:28  <provoostenator> gmaxwell: that's why I always nag about screenshots: https://github.com/bitcoin/bitcoin/pull/12035#issuecomment-354297195
2922018-02-02T11:07:34  <sipa> a 100 megabit/s network connection sounds very expensive now
2932018-02-02T11:07:45  * sipa computes
2942018-02-02T11:07:51  <sipa> crap.
2952018-02-02T11:08:00  <gmaxwell> lol
2962018-02-02T11:12:35  <meshcollider> provoostenator: is it *always* in addition to, or sometimes? Because the code had like a "short" and "long" version
2972018-02-02T11:12:43  <gmaxwell> somewhere some french altcoiners people are cacking at bitcoiners trying get everyone to measure their bitcoin in millièmebite.
2982018-02-02T11:13:34  <provoostenator> meshcollider: sometimes. See the screenshots in that link. Dropdown menus show both terms, which is where it matters the most I think. But there's some places where it just says "bits" now.
2992018-02-02T11:13:56  <wumpus> sipa: so does it always cost 100 megabit/s or is that just the channel capacity and based on use? :)
3002018-02-02T11:14:13  <meshcollider> provoostenator: ah yep I see, cool
3012018-02-02T11:14:30  <meshcollider> A megabit is 1 bitcoin?
3022018-02-02T11:15:07  <wumpus> meshcollider: yes :-)
3032018-02-02T11:15:25  <gmaxwell> now I'll at least remember what unit 'bits' is.
3042018-02-02T11:15:26  <meshcollider> At least I can still do basic math then :)
3052018-02-02T11:15:27  <wumpus> even 80's mobile data must have been cheaper
3062018-02-02T11:15:28  <provoostenator> Yeah, nobody liked my idea of redefining 1 satoshi as 10^-9 BTC :-)
3072018-02-02T11:15:41  <gmaxwell> provoostenator: is 10 nanobitcoin so hard to use?
3082018-02-02T11:15:56  <provoostenator> And then just use kilosat instead of uBTC or bits
3092018-02-02T11:17:06  <meshcollider> A satoshi is just 10 microbits
3102018-02-02T11:17:17  <provoostenator> Say "That'll be twenty three nanobitcoin and three hundred third five  picobitcoin please" 20 times out loud and I'll consider it.
3112018-02-02T11:17:35  <aj> meshcollider: millibits?
3122018-02-02T11:17:39  <meshcollider> Milli* yes oops
3132018-02-02T11:18:11  <sipa> millibitcoins = mils, microbitcoins = mikes, nanobitcoins = nans, picobitcoins = pikes
3142018-02-02T11:18:14  <sipa> was that so hard?
3152018-02-02T11:18:17  <sipa> ;)
3162018-02-02T11:18:33  <provoostenator> nans is nice
3172018-02-02T11:18:56  <gmaxwell> ten nans walk into a bar.
3182018-02-02T11:18:57  <meshcollider> brb, changing my twitter name to something like [NO BIP176][MIKES]
3192018-02-02T11:18:58  <provoostenator> NaN nans please
3202018-02-02T11:19:04  <aj> sipa: because "mils" isn't already used for enough different measurements
3212018-02-02T11:19:08  <wumpus> provoostenator: standardizing SI units in common language would be awesome, but not my fight
3222018-02-02T11:20:03  * wumpus likes sipa's suggestions
3232018-02-02T11:20:12  <wumpus> nan bread
3242018-02-02T11:20:35  <sipa> aj: oh?
3252018-02-02T11:21:17  <promag> who loves univalue raise hand
3262018-02-02T11:21:23  <provoostenator> There's also no point in standardizing these things when prices can change by an order of magnitude every year. If and when it becomes a unit of account, people will come with words for it.
3272018-02-02T11:21:32  <aj> sipa: oh, mostly just still bitter over discovering that when an american says "mils" that's not a nickname for millimetres
3282018-02-02T11:21:39  <wumpus> univalue?
3292018-02-02T11:22:09  <gmaxwell> provoostenator: well I suppose it's poor form to complain that people are coming up with words with the argument that they'll come up with words. :) (or perhaps I misunderstood)
3302018-02-02T11:22:16  <provoostenator> aj: they do for guns though, right?
3312018-02-02T11:22:23  <promag> wumpus: src/univalue/include/univalue.h :P
3322018-02-02T11:22:40  <promag> seems so slow
3332018-02-02T11:22:42  <wumpus> promag: oh, I think we were still in the context of units
3342018-02-02T11:22:53  <promag> sorry for the interrupt :P
3352018-02-02T11:22:56  <meshcollider> milliunivalue
3362018-02-02T11:23:14  <wumpus> deprecate SI units and unify all units to, univalue!
3372018-02-02T11:23:15  <provoostenator> gmaxwell: I think it's fine that people come with words. I mean there's not much use in "centrally" dictating those words.
3382018-02-02T11:23:21  <wumpus> that's 100 univalue please
3392018-02-02T11:23:37  <gmaxwell> promag: it was an order of magnitude speedup from jsonspirit as we were using it before, and eliminated problems with number mangling.
3402018-02-02T11:23:57  <aj> provoostenator: yeah, as i understand it, guns and drugs, at the forefront of bringing SI measurements to the US
3412018-02-02T11:24:10  <sipa> wumpus: yes, i wish people would learn SI units for daily life usage... but indeed, not something i'm going to waste my time on
3422018-02-02T11:24:13  <meshcollider> Well sipa has his own unit, we could call uBTC the laan
3432018-02-02T11:24:14  <wumpus> for a mass of 123 univalue of 100 univalue capacitors
3442018-02-02T11:24:52  <sipa> also, as the SI unit for weight is the kilogram, should it not be millikilogram instead of gram?
3452018-02-02T11:25:07  <wumpus> promag: we're basically its maintainers, feel free to optimize it
3462018-02-02T11:25:28  <provoostenator> The nice thing about computers is that they allow standards to just exist in the background. Precise time measurement is crucial, but most people don't need to think in UTC because their phone handles the conversion.
3472018-02-02T11:25:32  <meshcollider> sipa: unfortunately so lol
3482018-02-02T11:25:46  <aj> oh no, not time measurement
3492018-02-02T11:26:02  * sipa tries to reintroduce the beat
3502018-02-02T11:26:18  <provoostenator> In fact, we could just go back to each city having a time based on where the sun is. Though coordinating meetings would be a pain without good tools.
3512018-02-02T11:26:22  <gmaxwell> provoostenator: irony... considering that we have to hold our meetings here in UTC times to avoid having people witness multiple DST changes per year
3522018-02-02T11:26:26  <aj> sipa: that'll improve morale
3532018-02-02T11:26:51  <gmaxwell> (and at random seeming different times than their local dst changes)
3542018-02-02T11:27:42  <provoostenator> Right, that's because coordinating meeting times is still generally done with words.
3552018-02-02T11:27:50  <meshcollider> I prefer to measure time in microfortnights
3562018-02-02T11:28:10  <wumpus> my preference is kiloseconds, megaseconds, gigaseconds
3572018-02-02T11:28:28  <sipa> gigaseconds are kinda bulky
3582018-02-02T11:28:41  <wumpus> do away with planet or solar-system-specific time units
3592018-02-02T11:28:45  <sipa> few people see more than 3 in their lifetime
3602018-02-02T11:28:48  <gmaxwell> provoostenator: the time can't be set in any timezone with dst regardless of how you communicate about it, because if it is, people in other zones will witness their own time change as well as the other one.
3612018-02-02T11:28:54  <wumpus> agreed, it's a big milestone
3622018-02-02T11:29:05  <provoostenator> DST needs to die.
3632018-02-02T11:29:16  <sipa> wumpus: a *kilometerstone*
3642018-02-02T11:29:24  <wumpus> sipa: oooh yes, sorry
3652018-02-02T11:29:25  <gmaxwell> (since north and souther hemispheres dst in opposing directions, and US and europe on different dates)
3662018-02-02T11:30:08  *** AaronvanW has quit IRC
3672018-02-02T11:30:45  *** AaronvanW has joined #bitcoin-core-dev
3682018-02-02T11:30:50  <sipa> wumpus: i think we should do everything in planck units
3692018-02-02T11:32:49  * sipa zZzZ
3702018-02-02T11:34:57  *** AaronvanW has quit IRC
3712018-02-02T11:46:03  <bitcoin-git> [bitcoin] promag opened pull request #12333: Make CWallet::ListCoins atomic (master...2018-02-atomic-listcoins) https://github.com/bitcoin/bitcoin/pull/12333
3722018-02-02T11:48:10  *** RubenSomsen has joined #bitcoin-core-dev
3732018-02-02T12:03:17  *** AaronvanW has joined #bitcoin-core-dev
3742018-02-02T12:25:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3752018-02-02T12:26:03  *** AaronvanW has quit IRC
3762018-02-02T12:26:39  *** AaronvanW has joined #bitcoin-core-dev
3772018-02-02T12:29:00  *** AaronvanW has quit IRC
3782018-02-02T12:29:30  *** AaronvanW has joined #bitcoin-core-dev
3792018-02-02T12:30:06  *** belcher has joined #bitcoin-core-dev
3802018-02-02T12:31:28  <fanquake> pushed some rc2 sigs up
3812018-02-02T12:33:57  *** AaronvanW has quit IRC
3822018-02-02T12:42:23  *** pergaminho has joined #bitcoin-core-dev
3832018-02-02T12:45:53  *** checksau_ has quit IRC
3842018-02-02T12:48:51  *** promag has quit IRC
3852018-02-02T12:49:15  *** Chris_Stewart_5 has quit IRC
3862018-02-02T12:53:05  *** tryphe has quit IRC
3872018-02-02T12:53:10  *** tryphe_ has joined #bitcoin-core-dev
3882018-02-02T12:55:35  *** AaronvanW has joined #bitcoin-core-dev
3892018-02-02T13:13:41  *** RubenSomsen has quit IRC
3902018-02-02T13:16:47  *** Victorsueca has quit IRC
3912018-02-02T13:17:58  *** Victorsueca has joined #bitcoin-core-dev
3922018-02-02T13:19:03  <wumpus> sipa: yes, planck units would be even better, at least then we could stop using floating point/decimal and account all physics in discrete units in 128 or 256 bit integers
3932018-02-02T13:19:36  *** pgupta has joined #bitcoin-core-dev
3942018-02-02T13:19:48  <wumpus> also it's based on a constant of nature instead of an arbitrary human measure
3952018-02-02T13:20:07  *** AaronvanW has quit IRC
3962018-02-02T13:20:48  <wumpus> we're going to need larger SI-prefixes though
3972018-02-02T13:21:59  *** fanquake has quit IRC
3982018-02-02T13:22:23  *** AaronvanW has joined #bitcoin-core-dev
3992018-02-02T13:27:28  *** AaronvanW has quit IRC
4002018-02-02T13:28:37  *** AaronvanW has joined #bitcoin-core-dev
4012018-02-02T13:33:36  *** AaronvanW has quit IRC
4022018-02-02T13:34:40  *** Giszmo has joined #bitcoin-core-dev
4032018-02-02T13:38:35  *** AaronvanW has joined #bitcoin-core-dev
4042018-02-02T13:39:56  <wumpus> fanquake: also pushed my sigs, you were first though!
4052018-02-02T13:43:31  *** AaronvanW has quit IRC
4062018-02-02T13:50:08  *** owowo has joined #bitcoin-core-dev
4072018-02-02T13:55:38  *** meshcollider has quit IRC
4082018-02-02T14:02:48  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4092018-02-02T14:05:58  *** sanada has quit IRC
4102018-02-02T14:09:16  *** sanada has joined #bitcoin-core-dev
4112018-02-02T14:09:32  *** promag has joined #bitcoin-core-dev
4122018-02-02T14:14:45  *** promag has quit IRC
4132018-02-02T14:28:11  *** AaronvanW has joined #bitcoin-core-dev
4142018-02-02T14:32:13  *** Guyver2 has joined #bitcoin-core-dev
4152018-02-02T14:32:30  *** AaronvanW has quit IRC
4162018-02-02T14:35:20  *** promag has joined #bitcoin-core-dev
4172018-02-02T14:38:24  *** Dizzle has joined #bitcoin-core-dev
4182018-02-02T14:39:59  *** promag has quit IRC
4192018-02-02T14:43:34  *** goatpig has joined #bitcoin-core-dev
4202018-02-02T14:49:12  *** lnostdal has quit IRC
4212018-02-02T14:50:09  *** lnostdal has joined #bitcoin-core-dev
4222018-02-02T14:58:15  *** punch has joined #bitcoin-core-dev
4232018-02-02T15:00:54  *** AaronvanW has joined #bitcoin-core-dev
4242018-02-02T15:04:30  *** lnostdal has quit IRC
4252018-02-02T15:05:04  *** lnostdal has joined #bitcoin-core-dev
4262018-02-02T15:12:52  *** promag has joined #bitcoin-core-dev
4272018-02-02T15:14:56  *** echelon has quit IRC
4282018-02-02T15:15:38  *** echelon has joined #bitcoin-core-dev
4292018-02-02T15:17:26  *** Murch has joined #bitcoin-core-dev
4302018-02-02T15:17:36  *** promag has quit IRC
4312018-02-02T15:23:12  *** tknp has joined #bitcoin-core-dev
4322018-02-02T15:26:02  *** promag has joined #bitcoin-core-dev
4332018-02-02T15:30:48  *** promag has quit IRC
4342018-02-02T15:41:38  *** pgupta has quit IRC
4352018-02-02T15:45:05  *** promag has joined #bitcoin-core-dev
4362018-02-02T15:50:09  *** promag has quit IRC
4372018-02-02T15:53:48  *** belcher has quit IRC
4382018-02-02T16:02:57  <esotericnonsense> hm. how much space should test_runner.py require? seems it can't run in tmpfs on my laptop (only has 2GB /tmp, got to 1.9GB then started giving space errors)
4392018-02-02T16:04:45  <esotericnonsense> found the --tmpdirprefix switch. :)
4402018-02-02T16:05:06  *** AaronvanW has quit IRC
4412018-02-02T16:05:09  *** promag has joined #bitcoin-core-dev
4422018-02-02T16:05:12  *** mandric has joined #bitcoin-core-dev
4432018-02-02T16:09:59  *** promag has quit IRC
4442018-02-02T16:11:52  *** CubicEarths has joined #bitcoin-core-dev
4452018-02-02T16:13:15  *** mandric has quit IRC
4462018-02-02T16:24:26  *** AaronvanW has joined #bitcoin-core-dev
4472018-02-02T16:26:30  *** mandric has joined #bitcoin-core-dev
4482018-02-02T16:27:58  *** bule has joined #bitcoin-core-dev
4492018-02-02T16:28:56  *** jamesob has joined #bitcoin-core-dev
4502018-02-02T16:31:01  *** bule has quit IRC
4512018-02-02T16:36:18  *** AaronvanW has quit IRC
4522018-02-02T16:36:41  *** bhj has joined #bitcoin-core-dev
4532018-02-02T16:40:56  *** promag has joined #bitcoin-core-dev
4542018-02-02T16:45:31  *** AaronvanW has joined #bitcoin-core-dev
4552018-02-02T16:45:57  *** promag has quit IRC
4562018-02-02T16:48:18  *** Randolf has quit IRC
4572018-02-02T16:50:25  *** CubicEarths has quit IRC
4582018-02-02T16:50:53  *** promag has joined #bitcoin-core-dev
4592018-02-02T16:54:22  *** SopaXorzTaker has joined #bitcoin-core-dev
4602018-02-02T16:54:53  *** AaronvanW has quit IRC
4612018-02-02T16:55:27  *** promag has quit IRC
4622018-02-02T17:00:27  *** Squidicuz has quit IRC
4632018-02-02T17:02:28  <AndyS2> Newbie to C++ and bitcoin core here. I've been looking at EvalScript in interpreter.cpp, and from what I gathered it seems to push things onto 'stack' or return an error if something isn't kosher. But when/where is the stack actually 'executed'. EvalScript doesn't seem to evaluate the script anywhere I could see.
4642018-02-02T17:03:29  <AndyS2> And functions calling EvalScript didn't seem to immediately get to work on that stack, either, but I might have missed something
4652018-02-02T17:06:58  <achow101> AndyS2: the stack is not something where code is executed. It is just a place to store data temporarily
4662018-02-02T17:07:14  <achow101> Opcodes execute things typically by popping things off of the stack
4672018-02-02T17:07:22  <achow101> those opcodes do not actually get pushed to the stack
4682018-02-02T17:17:06  <luke-jr> well, they do for p2sh and segwit
4692018-02-02T17:18:42  *** Giszmo has quit IRC
4702018-02-02T17:21:00  *** Randolf has joined #bitcoin-core-dev
4712018-02-02T17:26:01  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4cad91663df3...85123be78df5
4722018-02-02T17:26:01  <bitcoin-git> bitcoin/master 7444149 John Newbery: Document method for reviewers to verify chainTxData...
4732018-02-02T17:26:02  <bitcoin-git> bitcoin/master 85123be Wladimir J. van der Laan: Merge #12317: Document method for reviewers to verify chainTxData...
4742018-02-02T17:26:08  *** Randolf has quit IRC
4752018-02-02T17:26:51  <bitcoin-git> [bitcoin] laanwj closed pull request #12317: Document method for reviewers to verify chainTxData (master...verify_chainTxData) https://github.com/bitcoin/bitcoin/pull/12317
4762018-02-02T17:27:14  *** lnostdal has quit IRC
4772018-02-02T17:34:00  *** ProfMac has joined #bitcoin-core-dev
4782018-02-02T17:38:21  *** laurentmt has joined #bitcoin-core-dev
4792018-02-02T17:41:10  *** Victorsueca has quit IRC
4802018-02-02T17:42:28  *** Victorsueca has joined #bitcoin-core-dev
4812018-02-02T17:45:24  <AndyS2> achow101: you are right, I don't know how I could mis-read all that code. Thanks for the correction. So EvalScript is actually where the script is evaluated, and the name fits :)
4822018-02-02T17:46:09  <AndyS2> I'll look at p2sh specialities later, thanks for the hint.
4832018-02-02T17:47:02  *** AaronvanW has joined #bitcoin-core-dev
4842018-02-02T17:49:44  *** AaronvanW has quit IRC
4852018-02-02T17:50:53  *** Randolf has joined #bitcoin-core-dev
4862018-02-02T17:51:50  *** droark has joined #bitcoin-core-dev
4872018-02-02T17:59:03  *** mandric has quit IRC
4882018-02-02T18:04:33  *** Chris_Stewart_5 has quit IRC
4892018-02-02T18:12:23  *** mandric has joined #bitcoin-core-dev
4902018-02-02T18:12:48  *** anome has joined #bitcoin-core-dev
4912018-02-02T18:15:25  *** anome has quit IRC
4922018-02-02T18:18:50  *** Randolf has quit IRC
4932018-02-02T18:19:43  *** anome has joined #bitcoin-core-dev
4942018-02-02T18:24:51  *** promag has joined #bitcoin-core-dev
4952018-02-02T18:28:20  *** anome has quit IRC
4962018-02-02T18:29:27  *** promag has quit IRC
4972018-02-02T18:31:20  *** anome has joined #bitcoin-core-dev
4982018-02-02T18:36:43  *** promag has joined #bitcoin-core-dev
4992018-02-02T18:37:04  <esotericnonsense> never mind DST. the fact that timezones don't change with latitude is absurd
5002018-02-02T18:39:14  *** CubicEarths has joined #bitcoin-core-dev
5012018-02-02T18:40:05  *** CubicEarths has joined #bitcoin-core-dev
5022018-02-02T18:40:57  *** promag has quit IRC
5032018-02-02T18:41:06  <sipa> esotericnonsense: iceland has no dst for a reason :)
5042018-02-02T18:41:51  *** AaronvanW has joined #bitcoin-core-dev
5052018-02-02T18:42:09  *** vicenteH has quit IRC
5062018-02-02T18:43:02  <esotericnonsense> it's more that spain is utc+1 and the UK is utc which is just odd
5072018-02-02T18:43:08  <esotericnonsense> there is probably some historical reason
5082018-02-02T18:46:10  *** AaronvanW has quit IRC
5092018-02-02T18:47:38  *** CubicEarths has quit IRC
5102018-02-02T18:48:05  <esotericnonsense> apparently it was for political alignment with central europe, heh
5112018-02-02T18:55:29  *** dermoth_ has joined #bitcoin-core-dev
5122018-02-02T18:55:29  *** dermoth has quit IRC
5132018-02-02T18:55:46  *** dermoth_ is now known as dermoth
5142018-02-02T18:57:44  *** Randolf has joined #bitcoin-core-dev
5152018-02-02T19:02:06  *** Krellan has joined #bitcoin-core-dev
5162018-02-02T19:02:46  *** Randolf has quit IRC
5172018-02-02T19:02:59  *** Randolf has joined #bitcoin-core-dev
5182018-02-02T19:07:04  *** wxss has quit IRC
5192018-02-02T19:07:22  *** promag has joined #bitcoin-core-dev
5202018-02-02T19:12:12  *** promag has quit IRC
5212018-02-02T19:12:41  *** Dizzle has quit IRC
5222018-02-02T19:15:54  *** dermoth has quit IRC
5232018-02-02T19:16:08  *** JackH has quit IRC
5242018-02-02T19:16:51  *** dermoth has joined #bitcoin-core-dev
5252018-02-02T19:24:05  *** lnostdal has joined #bitcoin-core-dev
5262018-02-02T19:26:11  *** ewilly has joined #bitcoin-core-dev
5272018-02-02T19:29:03  *** promag has joined #bitcoin-core-dev
5282018-02-02T19:29:04  *** Randolf has quit IRC
5292018-02-02T19:30:46  *** meshcollider has joined #bitcoin-core-dev
5302018-02-02T19:31:28  *** JackH has joined #bitcoin-core-dev
5312018-02-02T19:33:27  *** promag has quit IRC
5322018-02-02T19:34:47  *** promag has joined #bitcoin-core-dev
5332018-02-02T19:36:01  *** Randolf has joined #bitcoin-core-dev
5342018-02-02T19:39:19  *** pergaminho has quit IRC
5352018-02-02T19:39:20  *** JackH has quit IRC
5362018-02-02T19:40:51  *** mandric has quit IRC
5372018-02-02T19:41:44  *** JackH has joined #bitcoin-core-dev
5382018-02-02T19:42:57  *** Randolf has quit IRC
5392018-02-02T19:43:19  *** laurentmt has quit IRC
5402018-02-02T19:46:09  <bitcoin-git> [bitcoin] jnewbery opened pull request #12336: Remove deprecated rpc options (master...remove_deprecated_rpcs) https://github.com/bitcoin/bitcoin/pull/12336
5412018-02-02T19:46:45  *** echelon has quit IRC
5422018-02-02T19:47:13  *** JackH_ has joined #bitcoin-core-dev
5432018-02-02T19:48:35  *** JackH has quit IRC
5442018-02-02T19:52:40  *** JackH_ has quit IRC
5452018-02-02T19:52:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
5462018-02-02T19:53:13  *** Randolf has joined #bitcoin-core-dev
5472018-02-02T19:54:36  *** JackH has joined #bitcoin-core-dev
5482018-02-02T19:54:48  *** dcousens has quit IRC
5492018-02-02T19:55:11  *** Victorsueca has quit IRC
5502018-02-02T19:56:27  *** Victorsueca has joined #bitcoin-core-dev
5512018-02-02T19:57:07  *** dcousens has joined #bitcoin-core-dev
5522018-02-02T20:00:55  *** Randolf has quit IRC
5532018-02-02T20:17:10  <GitHub24> [bitcoin-detached-sigs] jonasschnelli opened pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
5542018-02-02T20:17:16  *** SopaXorzTaker has quit IRC
5552018-02-02T20:19:22  *** mandric has joined #bitcoin-core-dev
5562018-02-02T20:20:18  *** laurentmt has joined #bitcoin-core-dev
5572018-02-02T20:21:08  *** AaronvanW has joined #bitcoin-core-dev
5582018-02-02T20:40:18  <cfields> uh
5592018-02-02T20:40:24  <cfields> well that's shitty timing...
5602018-02-02T20:40:45  <cfields> I just ran my last sanity check on rc2 before pushing the sigs, and hit an asserstion at shutdown :(
5612018-02-02T20:48:03  *** larafale has quit IRC
5622018-02-02T20:48:53  *** larafale has joined #bitcoin-core-dev
5632018-02-02T20:51:09  <GitHub149> [bitcoin-detached-sigs] theuni closed pull request #2: 0.16: osx signatures for 0.16.0rc2 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/2
5642018-02-02T20:53:45  <cfields> gitian builders: v0.16.0rc2 sigs are pushed
5652018-02-02T20:53:52  <cfields> also, #12337
5662018-02-02T20:53:54  <gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub
5672018-02-02T20:53:57  <cfields> BlueMatt: ^^
5682018-02-02T20:54:49  *** vicenteH has joined #bitcoin-core-dev
5692018-02-02T20:55:40  <BlueMatt> oh ffs
5702018-02-02T20:59:32  *** Derrekito has joined #bitcoin-core-dev
5712018-02-02T21:03:21  <BlueMatt> weird, that would imply Shutdown() wasnt called
5722018-02-02T21:04:05  <cfields> hmm?
5732018-02-02T21:05:33  <BlueMatt> Shutdown() waits for the threadGroup to exit fully, and a long time ago due to some other bug I made sure Shutdown() gets acalled always in bitcoind shutdown, and I thought i did for qt too
5742018-02-02T21:05:40  <BlueMatt> but I dont have a good understanding of how that works
5752018-02-02T21:05:57  <BlueMatt> I assume you did a pretty quick shutdown and not a full init, cfields?
5762018-02-02T21:06:22  <cfields> yes, just long enough to display the version#
5772018-02-02T21:07:14  <cfields> BlueMatt: there's a note somewhere in init.cpp about aborting halfway through. Not sure if it's stale or not.
5782018-02-02T21:09:12  <cfields> nm, not relevant
5792018-02-02T21:09:59  <BlueMatt> not if you finish AppInitMain
5802018-02-02T21:18:35  <BlueMatt> does anyone actually understand qt init/shutdown?
5812018-02-02T21:22:36  <cfields> BlueMatt: I managed to grab the log, AppInitMain indeed doesn't finish. It caught the shutdown check at init.cpp:1578
5822018-02-02T21:24:38  *** dermoth has quit IRC
5832018-02-02T21:25:07  *** dermoth has joined #bitcoin-core-dev
5842018-02-02T21:25:15  *** AaronvanW has quit IRC
5852018-02-02T21:25:17  <BlueMatt> cfields: in bitcoind (and I was very sure bitcoin-qt) if AppInitMain ever *enters* it should still call Shutdown()
5862018-02-02T21:27:32  <cfields> BlueMatt: yes, I see that for bitcoind. Looking at qt with you.
5872018-02-02T21:27:34  *** cheese_ has joined #bitcoin-core-dev
5882018-02-02T21:27:35  <BlueMatt> hmm, it looks like maybe qt doesnt call Shutdown there, fucking qt/bitcoind init differences :(
5892018-02-02T21:27:54  <BlueMatt> i guess quit() doesnt call shutdown() when called from initializeResult
5902018-02-02T21:28:00  *** Cheeseo has quit IRC
5912018-02-02T21:28:06  <BlueMatt> I'll wait for jonasschnelli or someone who knows how the fuck qt works to figure out how to fix
5922018-02-02T21:30:11  <BlueMatt> cfields: https://github.com/bitcoin/bitcoin/issues/12337#issuecomment-362713279 <-- seem reasonable?
5932018-02-02T21:30:11  *** Victorsueca has quit IRC
5942018-02-02T21:31:04  <cfields> BlueMatt: yes, though I'm a few min behind you
5952018-02-02T21:31:31  *** Victorsueca has joined #bitcoin-core-dev
5962018-02-02T21:34:26  <cfields> BlueMatt: hmm. As a hack, I wonder if we can just add a "StartShutdown();" before every "return false" in AppInitMain
5972018-02-02T21:35:31  <cfields> blah, we'd still have to get qt to wait on that, which is basically the same problem. nm.
5982018-02-02T21:36:15  <BlueMatt> cfields: no, but we could change AppInitMain to { bool ret = AppInitMainReal(); if (!ret) Shutdown(); return ret }
5992018-02-02T21:36:34  <cfields> heh
6002018-02-02T21:36:59  <BlueMatt> but we shouldnt do that, we should fucking fix qt to actually have the same goddamned init/shutdown process as bitcoind, otherwise we're just keep going with this constant stream of init/shutdown problems on one or the other cause the person writing the code was only considering one or the other and assumed the other did the same thing
6012018-02-02T21:37:01  <BlueMatt> cause....duh
6022018-02-02T21:37:03  <cfields> looking at all of the qt shutdown signals, I'm afraid that would screw something up
6032018-02-02T21:37:25  <BlueMatt> i mean we can do a different fix on master vs qt
6042018-02-02T21:37:34  <BlueMatt> but lets see what someone who knows the qt init/shutdown stuff says
6052018-02-02T21:37:39  <BlueMatt> err, vs 16
6062018-02-02T21:38:00  <cfields> yes, agreed on sharing behavior as much as possible. Some is beyond our control, though.
6072018-02-02T21:39:23  <achow101> so 0.16 rc2 is DOA
6082018-02-02T21:40:53  <cfields> nah, I think we should urge people to test it
6092018-02-02T21:42:02  <cfields> rc1 had a bug that was so bad that _any_ bug report would've been unhelpful. For rc2, there's just a unlikely, known, startup issue
6102018-02-02T21:42:57  <mlz> what's the difference between "origin/0.16" and "v0.16.0rc2" and which one should i test?
6112018-02-02T21:42:57  *** Chris_Stewart_5 has quit IRC
6122018-02-02T21:43:19  *** arbitrary_guy has joined #bitcoin-core-dev
6132018-02-02T21:45:01  <cfields> miz: former is branch, latter is tag. You probably want the tag.
6142018-02-02T21:46:23  <achow101> cfields: does the assertion always happen or just sometimes?
6152018-02-02T21:46:49  <mlz> cfields, ok, thank you
6162018-02-02T21:47:16  <cfields> BlueMatt: for 0.16, can we not just start the scheduler thread until last thing in AppInitMain? Surely nothing depends on it running in there
6172018-02-02T21:47:33  <cfields> grr.. or does reindexing and crap rely on the callbacks?
6182018-02-02T21:47:56  <cfields> achow101: I only ran it once, but it only triggered because I shutdown immediately
6192018-02-02T21:48:03  <achow101> ah, ok
6202018-02-02T21:49:11  <BlueMatt> cfields: hmmm, I dont *think* anything depends on it, but i was trying to keep the diff when compared to previously where the scheduler is started early low
6212018-02-02T21:49:18  <BlueMatt> and at least that change is harder to audit
6222018-02-02T21:49:27  <BlueMatt> achow101: it should always crash if you quit bitcoin-qt while its loading
6232018-02-02T21:49:36  <BlueMatt> if it finishes loading you should be fine
6242018-02-02T21:54:07  <achow101> is the issue present on master?
6252018-02-02T21:54:12  <cfields> yes
6262018-02-02T21:54:53  <cfields> BlueMatt: actually, starting the thread last-thing sounds like a good idea anyway. Exactly to ensure that the scheduler isn't used at startup.
6272018-02-02T21:55:29  <achow101> is it windows only? I can't seem to replicate on Ubuntu
6282018-02-02T21:55:30  <cfields> i'll track down potential users
6292018-02-02T21:55:41  <cfields> achow101: testing bitcoin-qt ?
6302018-02-02T21:55:45  <achow101> yeah
6312018-02-02T21:56:09  <cfields> I don't see anything that would make it win only...
6322018-02-02T21:56:21  <cfields> you should be able to force it by throwing a "return false" into init
6332018-02-02T21:57:10  <BlueMatt> cfields: hmmm...I mean maybe? I dont really want to go read through everything that AppInitMain calls recursively to ensure that is actually the case, but if we want to do that for 17 it seems reasonable
6342018-02-02T21:57:33  <cfields> achow101: at init.cpp:1576, s/fRequestShutdown/true/
6352018-02-02T21:58:53  *** Guyver2 has quit IRC
6362018-02-02T22:00:47  *** cloaks has quit IRC
6372018-02-02T22:06:57  <achow101> cfields: nope, didn't work
6382018-02-02T22:09:23  *** ghost43 has quit IRC
6392018-02-02T22:10:02  *** ghost43 has joined #bitcoin-core-dev
6402018-02-02T22:11:49  <cfields> achow101: hmm, not sure why
6412018-02-02T22:12:04  <achow101> I'm trying rc2 now, instead of master
6422018-02-02T22:13:01  <achow101> nope, not even that had an error
6432018-02-02T22:13:22  <cfields> BlueMatt: i think i might see the issue
6442018-02-02T22:15:05  <cfields> BlueMatt: BitcoinApplication connects requestedShutdown to shutdown(), but SplashScreen connects it to close()
6452018-02-02T22:15:39  <cfields> so it looks like we should re-route that after AppInitMain has started
6462018-02-02T22:26:35  <BlueMatt> lol
6472018-02-02T22:28:32  *** Randolf has joined #bitcoin-core-dev
6482018-02-02T22:28:55  *** jamesob has quit IRC
6492018-02-02T22:32:49  *** larafale has quit IRC
6502018-02-02T22:34:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6512018-02-02T22:40:00  *** Giszmo has joined #bitcoin-core-dev
6522018-02-02T22:40:16  *** rumbaltd has joined #bitcoin-core-dev
6532018-02-02T22:50:28  *** meshcollider has quit IRC
6542018-02-02T22:53:24  *** rumbaltd has left #bitcoin-core-dev
6552018-02-02T22:55:38  *** mandric has quit IRC
6562018-02-02T23:02:59  *** Chris_Stewart_5 has quit IRC
6572018-02-02T23:04:20  *** Murch has quit IRC
6582018-02-02T23:06:21  *** Murch has joined #bitcoin-core-dev
6592018-02-02T23:12:29  *** pgupta has joined #bitcoin-core-dev
6602018-02-02T23:21:04  *** Chris_Stewart_5 has joined #bitcoin-core-dev
6612018-02-02T23:29:37  *** Randolf has quit IRC
6622018-02-02T23:32:57  *** Giszmo has quit IRC
6632018-02-02T23:33:07  *** AaronvanW has joined #bitcoin-core-dev
6642018-02-02T23:35:01  *** pgupta has quit IRC
6652018-02-02T23:35:57  *** wampum has quit IRC
6662018-02-02T23:36:12  *** Aaronvan_ has joined #bitcoin-core-dev
6672018-02-02T23:38:21  *** wampum has joined #bitcoin-core-dev
6682018-02-02T23:39:57  *** AaronvanW has quit IRC
6692018-02-02T23:45:06  *** tknp has quit IRC
6702018-02-02T23:49:36  *** pgupta has joined #bitcoin-core-dev
6712018-02-02T23:50:35  *** Murch has quit IRC
6722018-02-02T23:53:48  *** pgupta has quit IRC