12018-02-16T00:02:05  *** Jasmin42Hahn has quit IRC
  22018-02-16T00:09:57  *** grafcaps has quit IRC
  32018-02-16T00:21:40  *** AaronvanW has joined #bitcoin-core-dev
  42018-02-16T00:22:08  *** grafcaps has joined #bitcoin-core-dev
  52018-02-16T00:23:33  *** promag has quit IRC
  62018-02-16T00:27:02  *** AaronvanW has quit IRC
  72018-02-16T00:28:34  <achow101> at least they kept the copyright header this time
  82018-02-16T00:30:31  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fa556aee203...a233fb4f1d03
  92018-02-16T00:30:31  <bitcoin-git> bitcoin/master fafbf7f MarcoFalke: devtools: Exclude patches from lint-whitespace
 102018-02-16T00:30:32  <bitcoin-git> bitcoin/master a233fb4 MarcoFalke: Merge #12442: devtools: Exclude patches from lint-whitespace...
 112018-02-16T00:30:54  <gmaxwell> yea, they changed their strategy from removing the attribution to leaving it and falsely announcing that people were contributing to their project: https://twitter.com/jimmysong/status/952611979742601216
 122018-02-16T00:31:31  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12442: devtools: Exclude patches from lint-whitespace (master...Mf1802-devtoolsLintWhitespaceExcludePatches) https://github.com/bitcoin/bitcoin/pull/12442
 132018-02-16T00:32:05  <jimmysong> for what it's worth, deadalnix told me that one was specific to me because he wanted me to "choose sides"
 142018-02-16T00:32:22  * dongcarl *facepalm*
 152018-02-16T00:32:24  <jimmysong> no interest in aligning there
 162018-02-16T00:34:04  *** Cogito_Ergo_Sum has quit IRC
 172018-02-16T00:35:55  <Emcy_> lolol
 182018-02-16T00:36:06  <Emcy_> pick a side or we will pick one for you
 192018-02-16T00:36:46  <esotericnonsense> well, there is the flip side
 202018-02-16T00:37:12  <gmaxwell> :(
 212018-02-16T00:37:22  <esotericnonsense> as a bitcoin ABC contributor, I can go ahead and claim expert authority on the project being a nonsense
 222018-02-16T00:37:23  <Emcy_> youll have to bunk with rog if you choose the flip side
 232018-02-16T00:37:27  <gmaxwell> how did he expect that to work
 242018-02-16T00:37:38  <gmaxwell> meh, sorry I'm being offtopic
 252018-02-16T00:38:37  *** Murch has quit IRC
 262018-02-16T00:39:01  <Emcy_> jimmysong isnt deadlnix one of them libertarian voluntaryists ive heard so much about
 272018-02-16T00:39:06  <Emcy_> really interesting praxis
 282018-02-16T00:39:35  *** dfgsr has joined #bitcoin-core-dev
 292018-02-16T00:40:24  <jimmysong> i guess he wanted me to say "yes i'm a contributor to bch"
 302018-02-16T00:40:26  <jimmysong> or something like that
 312018-02-16T00:40:54  <esotericnonsense> heh
 322018-02-16T00:41:07  <Emcy_> bolster the 'multiple independent developers' rhetoric id guess
 332018-02-16T00:41:14  <jimmysong> something like that
 342018-02-16T00:41:21  <jimmysong> still don't understand why he did it that way
 352018-02-16T00:41:28  <jimmysong> just makes him look bad
 362018-02-16T00:41:39  <Emcy_> because hes a prick
 372018-02-16T00:41:42  <Emcy_> applying occams razor
 382018-02-16T00:42:00  <sipa> please, can we stick to technical topics relating to bitcoin core here
 392018-02-16T00:42:05  <jimmysong> sorry
 402018-02-16T00:49:38  *** hsmiths has quit IRC
 412018-02-16T00:49:39  *** dfgsr has quit IRC
 422018-02-16T00:50:42  *** hsmiths has joined #bitcoin-core-dev
 432018-02-16T00:51:02  *** anome has quit IRC
 442018-02-16T00:52:41  *** Francisco16Schow has joined #bitcoin-core-dev
 452018-02-16T00:53:55  *** sengehest has joined #bitcoin-core-dev
 462018-02-16T00:55:04  *** farmerwampum_ has joined #bitcoin-core-dev
 472018-02-16T00:59:24  *** dabura667 has joined #bitcoin-core-dev
 482018-02-16T01:01:04  *** sengehest has quit IRC
 492018-02-16T01:05:30  *** Emcy_ has quit IRC
 502018-02-16T01:15:07  *** Emcy has joined #bitcoin-core-dev
 512018-02-16T01:15:53  <Emcy> whoops i thought this was forks sorry
 522018-02-16T01:20:44  *** Emcy has quit IRC
 532018-02-16T01:23:18  *** Emcy has joined #bitcoin-core-dev
 542018-02-16T01:25:20  *** Murch has joined #bitcoin-core-dev
 552018-02-16T01:39:54  *** jamespeerless has joined #bitcoin-core-dev
 562018-02-16T01:54:49  *** sengehest has joined #bitcoin-core-dev
 572018-02-16T01:58:49  *** Francisco16Schow has quit IRC
 582018-02-16T01:59:29  *** sengehest has quit IRC
 592018-02-16T02:23:02  *** Murch has quit IRC
 602018-02-16T02:25:35  *** jb55 has joined #bitcoin-core-dev
 612018-02-16T02:45:46  *** ProfMac has quit IRC
 622018-02-16T02:47:37  *** sengehest has joined #bitcoin-core-dev
 632018-02-16T02:51:57  *** sengehest has quit IRC
 642018-02-16T02:52:43  *** Andreanne8Howe has joined #bitcoin-core-dev
 652018-02-16T02:57:27  *** Andreanne8Howe has quit IRC
 662018-02-16T03:02:38  *** sengehest has joined #bitcoin-core-dev
 672018-02-16T03:04:26  *** Giszmo has joined #bitcoin-core-dev
 682018-02-16T03:07:05  *** sengehest has quit IRC
 692018-02-16T03:09:55  *** meshcollider_ has joined #bitcoin-core-dev
 702018-02-16T03:10:11  *** meshcollider_ has quit IRC
 712018-02-16T03:18:45  *** ProfMac has joined #bitcoin-core-dev
 722018-02-16T03:18:51  *** jamespeerless has quit IRC
 732018-02-16T03:47:20  *** sengehest has joined #bitcoin-core-dev
 742018-02-16T03:48:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 752018-02-16T03:51:40  *** sengehest has quit IRC
 762018-02-16T03:52:35  *** Robin53Bartell has joined #bitcoin-core-dev
 772018-02-16T03:53:39  *** sengehest has joined #bitcoin-core-dev
 782018-02-16T03:57:57  *** sengehest has quit IRC
 792018-02-16T04:00:08  *** Chris_Stewart_5 has quit IRC
 802018-02-16T04:00:10  *** Madars has quit IRC
 812018-02-16T04:01:09  *** AriseChikun has quit IRC
 822018-02-16T04:05:27  *** Madars has joined #bitcoin-core-dev
 832018-02-16T04:15:28  <fanquake> meshcollider could you do that script testing on your own repo?
 842018-02-16T04:16:25  <meshcollider> fanquake: sorry, is it emailing you? Just finished testing it on my repo so its done anyway :)
 852018-02-16T04:18:55  <fanquake> meshcollider yes, ok
 862018-02-16T04:19:34  *** jojeyh has joined #bitcoin-core-dev
 872018-02-16T04:19:35  <meshcollider> fanquake: why is it emailing you if travis isn't even enabled on the repo? Or does it notify you of all PR changes?
 882018-02-16T04:21:17  <fanquake> meshcolllier you get notified of PR changes
 892018-02-16T04:24:13  *** AriseChikun has joined #bitcoin-core-dev
 902018-02-16T04:36:04  *** AriseChikun has quit IRC
 912018-02-16T04:36:32  *** AriseChikun has joined #bitcoin-core-dev
 922018-02-16T04:39:54  *** justan0theruser has joined #bitcoin-core-dev
 932018-02-16T04:40:19  *** justanotheruser has quit IRC
 942018-02-16T04:41:52  *** Giszmo has quit IRC
 952018-02-16T04:48:25  *** sengehest has joined #bitcoin-core-dev
 962018-02-16T04:52:57  *** sengehest has quit IRC
 972018-02-16T05:06:32  *** PINKY62 has joined #bitcoin-core-dev
 982018-02-16T05:24:17  *** niska has quit IRC
 992018-02-16T05:32:53  *** niska has joined #bitcoin-core-dev
1002018-02-16T05:33:58  *** fb has joined #bitcoin-core-dev
1012018-02-16T05:34:21  *** fb is now known as Guest2711
1022018-02-16T05:36:33  *** Guest2711 has quit IRC
1032018-02-16T05:36:53  *** cryptojanitor has quit IRC
1042018-02-16T05:45:08  *** ProfMac has quit IRC
1052018-02-16T05:47:38  *** sengehest has joined #bitcoin-core-dev
1062018-02-16T05:47:43  *** jb55 has quit IRC
1072018-02-16T05:49:14  *** grafcaps has quit IRC
1082018-02-16T05:57:05  *** neha has quit IRC
1092018-02-16T05:58:24  *** neha has joined #bitcoin-core-dev
1102018-02-16T06:00:14  *** PINKY62 has quit IRC
1112018-02-16T06:00:57  *** sengehest has quit IRC
1122018-02-16T06:07:21  *** harrymm_ has quit IRC
1132018-02-16T06:10:14  *** mmgen has joined #bitcoin-core-dev
1142018-02-16T06:20:34  *** harrymm_ has joined #bitcoin-core-dev
1152018-02-16T06:32:19  <GitHub1> [bitcoin-detached-sigs] jonasschnelli opened pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
1162018-02-16T06:46:33  *** meshcollider has quit IRC
1172018-02-16T07:00:23  *** windsok has quit IRC
1182018-02-16T07:00:55  *** windsok has joined #bitcoin-core-dev
1192018-02-16T07:07:35  *** mmgen has quit IRC
1202018-02-16T07:09:36  *** mmgen has joined #bitcoin-core-dev
1212018-02-16T07:34:16  *** denis2342 has joined #bitcoin-core-dev
1222018-02-16T07:36:19  <denis2342> I have a small build regression on freebsd with 0.16.0rc4: https://pastebin.com/i9zPDKXd
1232018-02-16T07:36:33  <denis2342> seems a header is missing
1242018-02-16T07:48:11  <denis2342> adding #include <signal.h> to src/test/util_tests.cpp fixes the problem
1252018-02-16T08:04:15  *** promag has joined #bitcoin-core-dev
1262018-02-16T08:04:32  *** tryphe has quit IRC
1272018-02-16T08:04:56  *** tryphe has joined #bitcoin-core-dev
1282018-02-16T08:07:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a233fb4f1d03...1f055ef9d798
1292018-02-16T08:07:25  <bitcoin-git> bitcoin/master d7f438a Cory Fields: gitian: bump descriptors for (0.)17
1302018-02-16T08:07:26  <bitcoin-git> bitcoin/master 1f055ef Wladimir J. van der Laan: Merge #12444: gitian: bump descriptors for (0.)17...
1312018-02-16T08:08:21  <bitcoin-git> [bitcoin] laanwj closed pull request #12444: gitian: bump descriptors for (0.)17 (master...gitian-bump) https://github.com/bitcoin/bitcoin/pull/12444
1322018-02-16T08:10:15  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f055ef9d798...26dc2daf82d2
1332018-02-16T08:10:15  <bitcoin-git> bitcoin/master be45a67 Richard Kiss: Add some script tests related to BOOL ops and odd values like negative 0.
1342018-02-16T08:10:16  <bitcoin-git> bitcoin/master 26dc2da Wladimir J. van der Laan: Merge #12425: Add some script tests...
1352018-02-16T08:11:03  <bitcoin-git> [bitcoin] laanwj closed pull request #12425: Add some script tests (master...feature/bool_tests) https://github.com/bitcoin/bitcoin/pull/12425
1362018-02-16T08:19:17  <wumpus> denis2342: hrm, I'll try rebuildilng my freebsd node and see if I run into the same
1372018-02-16T08:19:32  *** dund has quit IRC
1382018-02-16T08:21:31  *** promag has quit IRC
1392018-02-16T08:33:41  *** anome has joined #bitcoin-core-dev
1402018-02-16T08:40:20  *** meshcollider has joined #bitcoin-core-dev
1412018-02-16T08:48:10  *** tma98 has joined #bitcoin-core-dev
1422018-02-16T08:48:53  <tma98> hi
1432018-02-16T08:54:08  *** tma98 has quit IRC
1442018-02-16T09:05:54  *** anome has quit IRC
1452018-02-16T09:24:30  *** promag has joined #bitcoin-core-dev
1462018-02-16T09:26:17  *** d3vt4r has joined #bitcoin-core-dev
1472018-02-16T09:27:29  *** timothy has joined #bitcoin-core-dev
1482018-02-16T09:32:51  *** denis2342_ has joined #bitcoin-core-dev
1492018-02-16T09:33:51  *** lnostdal has joined #bitcoin-core-dev
1502018-02-16T09:34:11  *** denis2342 has quit IRC
1512018-02-16T09:38:14  *** d_t has quit IRC
1522018-02-16T09:45:02  *** lnostdal has quit IRC
1532018-02-16T09:45:17  *** lnostdal has joined #bitcoin-core-dev
1542018-02-16T09:46:19  *** larafale has joined #bitcoin-core-dev
1552018-02-16T09:55:37  *** anome has joined #bitcoin-core-dev
1562018-02-16T10:01:00  *** Guyver2 has joined #bitcoin-core-dev
1572018-02-16T10:13:54  *** d3vt4r has quit IRC
1582018-02-16T10:18:49  *** larafale has quit IRC
1592018-02-16T10:26:33  <fanquake> wumpus I agree with closing https://github.com/bitcoin-core/gitian.sigs/pull/614
1602018-02-16T10:27:57  <fanquake> #678 is more interesting as a quick check, making sure that submitters are only modifying a single dir. However that is still a trivial thing to check anyways.
1612018-02-16T10:27:58  <gribble> https://github.com/bitcoin/bitcoin/issues/678 | changing the GUI language · Issue #678 · bitcoin/bitcoin · GitHub
1622018-02-16T10:28:15  *** AaronvanW has joined #bitcoin-core-dev
1632018-02-16T10:29:20  *** Aaronvan_ has joined #bitcoin-core-dev
1642018-02-16T10:29:32  <wumpus> fanquake: I think it's difficult, I mwan from a user perspective it's useful to be alerted when signatures diverge, what "m less convinced about is that travis is always the right hammer for the job
1652018-02-16T10:30:16  <wumpus> FWIW this is the same feeling that I have with hooking all kinds of things like whitespace linters into travis. If there was a better way to customize the message/icon that appears in the github issue it'd be better.
1662018-02-16T10:30:17  <fanquake> I also agree that diverging/"incorrect" signatures should be merged regardless.
1672018-02-16T10:30:30  <wumpus> yep, something could warn after merging
1682018-02-16T10:32:40  *** AaronvanW has quit IRC
1692018-02-16T10:39:19  <promag> wumpus: https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
1702018-02-16T10:39:46  <promag> circle does what you want https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159
1712018-02-16T10:41:17  *** larafale has joined #bitcoin-core-dev
1722018-02-16T11:02:40  <bitcoin-git> [bitcoin] laanwj opened pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447
1732018-02-16T11:03:35  *** promag has quit IRC
1742018-02-16T11:08:38  <wumpus> promag: interesting!
1752018-02-16T11:17:28  *** laurentmt has joined #bitcoin-core-dev
1762018-02-16T11:17:31  *** denis2342_ has quit IRC
1772018-02-16T11:20:25  *** larafale has quit IRC
1782018-02-16T11:21:40  *** Robin53Bartell has quit IRC
1792018-02-16T11:40:05  *** dabura667 has quit IRC
1802018-02-16T11:52:35  *** Garrison16Lockma has joined #bitcoin-core-dev
1812018-02-16T11:58:33  *** cryptojanitor has joined #bitcoin-core-dev
1822018-02-16T12:14:18  *** anome has quit IRC
1832018-02-16T12:19:28  *** jamesob has joined #bitcoin-core-dev
1842018-02-16T12:21:01  *** promag has joined #bitcoin-core-dev
1852018-02-16T12:25:19  *** shesek has quit IRC
1862018-02-16T12:32:47  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1872018-02-16T12:36:40  *** laurentmt has quit IRC
1882018-02-16T12:40:26  *** jojeyh has quit IRC
1892018-02-16T12:43:16  *** Deinogalerix21 has joined #bitcoin-core-dev
1902018-02-16T12:45:54  *** laurentmt has joined #bitcoin-core-dev
1912018-02-16T13:03:32  <bitcoin-git> [bitcoin] promag opened pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448
1922018-02-16T13:06:56  *** dermoth has joined #bitcoin-core-dev
1932018-02-16T13:09:29  <promag> wumpus: what kind of test?
1942018-02-16T13:09:54  <promag> generate bigcount and in parallel quit?
1952018-02-16T13:10:16  <wumpus> well in this case a test that does generateblock 10000 then sends an interrupt request and checks that bitcoin shuts down cleanly
1962018-02-16T13:10:23  <wumpus> though I'd argue this is not an important one to test
1972018-02-16T13:10:48  <wumpus> the early-outs in init, are
1982018-02-16T13:11:24  <promag> right
1992018-02-16T13:11:54  <promag> I was benchmarking stuff and did generate 100000
2002018-02-16T13:11:55  *** SopaXorzTaker has joined #bitcoin-core-dev
2012018-02-16T13:11:58  <wumpus> (that is where we had two fixes for, in the rc cycle... because early-outs leave the process in an inconsistent, or at least unpexpected state that may cause trouble later)
2022018-02-16T13:12:08  <promag> and then I had to kill -9 otherwise it didn't stop
2032018-02-16T13:12:53  <wumpus> which is fine, no one does software development perfectly, seeing all potential conseequences to a change (if only!), but illustrates tests are needed
2042018-02-16T13:13:32  <promag> and generateBlocks is non main net right?
2052018-02-16T13:15:47  *** Deinogalerix21 has quit IRC
2062018-02-16T13:19:04  *** promag has quit IRC
2072018-02-16T13:19:04  <wumpus> if you can use it for mainnet, interrupting *between* blocks isn't going to help you
2082018-02-16T13:20:02  <wumpus> even generating one block at the current difficulty with the naive, single-threaded miner meant for regtest is going to take a million years
2092018-02-16T13:40:00  *** jochemin has quit IRC
2102018-02-16T13:40:27  *** jochemin has joined #bitcoin-core-dev
2112018-02-16T13:40:40  *** laurentmt has quit IRC
2122018-02-16T13:41:09  *** Chris_Stewart_5 has quit IRC
2132018-02-16T13:47:39  *** fanquake has quit IRC
2142018-02-16T13:48:32  *** dermoth has quit IRC
2152018-02-16T13:49:09  *** jochemin has quit IRC
2162018-02-16T13:49:40  *** dermoth has joined #bitcoin-core-dev
2172018-02-16T13:55:16  *** jamespeerless has joined #bitcoin-core-dev
2182018-02-16T13:58:23  *** jamesob has quit IRC
2192018-02-16T14:00:51  *** esotericnonsense has quit IRC
2202018-02-16T14:01:10  *** Garrison16Lockma has quit IRC
2212018-02-16T14:03:03  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #12451: Bump leveldb subtree (master...Mf1802-leveldbSubtreeBump) https://github.com/bitcoin/bitcoin/pull/12451
2222018-02-16T14:04:43  *** esotericnonsense has joined #bitcoin-core-dev
2232018-02-16T14:04:49  *** jamespeerless has quit IRC
2242018-02-16T14:18:13  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26dc2daf82d2...4a62ddd01873
2252018-02-16T14:18:13  <bitcoin-git> bitcoin/master dd7e42c Wladimir J. van der Laan: test: Add missing signal.h header...
2262018-02-16T14:18:14  <bitcoin-git> bitcoin/master 4a62ddd MarcoFalke: Merge #12447: test: Add missing signal.h header...
2272018-02-16T14:19:05  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447
2282018-02-16T14:21:46  *** farmerwampum_ has quit IRC
2292018-02-16T14:26:44  *** jamesob has joined #bitcoin-core-dev
2302018-02-16T14:32:06  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2312018-02-16T14:35:08  *** jamespeerless has joined #bitcoin-core-dev
2322018-02-16T14:36:46  *** promag has joined #bitcoin-core-dev
2332018-02-16T14:37:41  <provoostenator> I added an #ifdef ENABLE_WALLET in guiutil.h, but the compiler seems to think this is undefined for this particular file even though I configured with the wallet enabled.
2342018-02-16T14:41:04  *** promag has quit IRC
2352018-02-16T14:45:40  <kallewoof> provoostenator: you may need to do the HAVE_CONFIG_H deal first? (e.g. compat.h style)
2362018-02-16T14:47:00  *** promag has joined #bitcoin-core-dev
2372018-02-16T14:49:08  <provoostenator> kallewoof: thanks, that did the trick. What does it do?
2382018-02-16T14:52:35  *** Georgiana72West has joined #bitcoin-core-dev
2392018-02-16T14:55:05  *** promag has quit IRC
2402018-02-16T15:00:14  *** Aaronvan_ is now known as AaronvanW
2412018-02-16T15:04:10  *** ProfMac has joined #bitcoin-core-dev
2422018-02-16T15:11:01  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2432018-02-16T15:11:01  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2442018-02-16T15:13:37  *** Georgiana72West has quit IRC
2452018-02-16T15:14:07  *** laurentmt has joined #bitcoin-core-dev
2462018-02-16T15:14:17  *** laurentmt has quit IRC
2472018-02-16T15:23:11  <kallewoof> provoostenator: it pulls in defines from autoconf etc, I believe
2482018-02-16T15:27:55  *** mirese_ has joined #bitcoin-core-dev
2492018-02-16T15:31:04  *** mirese has quit IRC
2502018-02-16T15:34:57  *** dcousens has quit IRC
2512018-02-16T15:35:40  *** dcousens has joined #bitcoin-core-dev
2522018-02-16T15:36:27  *** promag has joined #bitcoin-core-dev
2532018-02-16T15:41:23  *** promag has quit IRC
2542018-02-16T15:46:20  *** rosdi has joined #bitcoin-core-dev
2552018-02-16T15:52:36  *** Maynard11Spinka has joined #bitcoin-core-dev
2562018-02-16T15:53:24  *** rosdi has quit IRC
2572018-02-16T15:58:31  *** AriseChikun has quit IRC
2582018-02-16T16:00:40  *** RubenSomsen has joined #bitcoin-core-dev
2592018-02-16T16:02:33  *** Maynard11Spinka has quit IRC
2602018-02-16T16:05:05  *** belcher has joined #bitcoin-core-dev
2612018-02-16T16:07:44  *** Victorsueca has quit IRC
2622018-02-16T16:08:53  *** Victorsueca has joined #bitcoin-core-dev
2632018-02-16T16:36:31  <cfields> yep
2642018-02-16T16:36:45  <cfields> it's so that you can tell the difference between autoconf'd builds and non
2652018-02-16T16:37:39  <cfields> for ex, you can (or could at one point) build bitcoind with MSVC, you just have to define all of the stuff that autoconf would've detected for you
2662018-02-16T16:39:09  *** Deinogalerix21 has joined #bitcoin-core-dev
2672018-02-16T16:40:39  <bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/4a62ddd01873...59e032b43cea
2682018-02-16T16:40:40  <bitcoin-git> bitcoin/master 5a10859 fanquake: [depends] expat 2.2.5
2692018-02-16T16:40:40  <bitcoin-git> bitcoin/master 61647a4 fanquake: [depends] ccache 3.4.1
2702018-02-16T16:40:41  <bitcoin-git> bitcoin/master 41550d6 fanquake: [depends] miniupnpc 2.0.20180203
2712018-02-16T16:41:27  <bitcoin-git> [bitcoin] laanwj closed pull request #12402: [depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203 (master...depends-02-2018) https://github.com/bitcoin/bitcoin/pull/12402
2722018-02-16T16:42:13  <cfields> wumpus: that one wasn't ready yet :\
2732018-02-16T16:51:23  *** grafcaps has joined #bitcoin-core-dev
2742018-02-16T16:52:15  *** promag has joined #bitcoin-core-dev
2752018-02-16T16:52:35  *** Ericka76Shields has joined #bitcoin-core-dev
2762018-02-16T16:57:12  *** promag has quit IRC
2772018-02-16T16:57:26  *** grafcaps has quit IRC
2782018-02-16T17:02:38  *** Ericka76Shields has quit IRC
2792018-02-16T17:04:34  <wumpus> cfields: what's the problem?
2802018-02-16T17:11:46  *** Randolf has joined #bitcoin-core-dev
2812018-02-16T17:11:59  *** instagibbs has quit IRC
2822018-02-16T17:18:43  *** meshcollider has quit IRC
2832018-02-16T17:19:57  *** instagibbs has joined #bitcoin-core-dev
2842018-02-16T17:26:20  *** grafcaps has joined #bitcoin-core-dev
2852018-02-16T17:39:56  *** owowo has quit IRC
2862018-02-16T17:41:44  *** promag has joined #bitcoin-core-dev
2872018-02-16T17:42:25  *** RubenSomsen has quit IRC
2882018-02-16T17:43:55  *** jb55 has joined #bitcoin-core-dev
2892018-02-16T17:44:47  *** owowo has joined #bitcoin-core-dev
2902018-02-16T17:46:41  *** promag has quit IRC
2912018-02-16T17:47:26  *** Murch has joined #bitcoin-core-dev
2922018-02-16T17:52:35  *** Curtis27Boyle has joined #bitcoin-core-dev
2932018-02-16T17:56:37  <gmaxwell> Someone noticed again that cross chain swaps can be broken due to different size limits on different systems https://bitcointalk.org/index.php?topic=2960023.0
2942018-02-16T17:56:45  <gmaxwell> sipa: do you recall where this was previously pointed out?
2952018-02-16T18:03:13  *** timothy has quit IRC
2962018-02-16T18:19:10  *** Curtis27Boyle has quit IRC
2972018-02-16T18:21:56  <GitHub194> [bitcoin-detached-sigs] theuni closed pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
2982018-02-16T18:23:02  <cfields> gitian builders: v0.16.0rc4 detached sigs are pushed
2992018-02-16T18:23:35  <cfields> wumpus: the darwin define for miniupnpc is done universally
3002018-02-16T18:23:47  <cfields> I'll nag on the PR
3012018-02-16T18:25:26  <wumpus> cfields: whoops so that define is for upnp itself, not a hint to darwin. I thought it was the latter so defining it universally wouldn't hurt.
3022018-02-16T18:26:22  <cfields> right. it's unlikely to be an issue, but if it turned out to manifest somewhere, it'd be really nasty to track down
3032018-02-16T18:30:05  *** Deinogalerix21 has quit IRC
3042018-02-16T18:30:26  *** Victorsueca has quit IRC
3052018-02-16T18:31:52  *** Victorsueca has joined #bitcoin-core-dev
3062018-02-16T18:34:53  <jcorgan> is there a how-to-do-gitian-builds-for-fun-and-profit-and-mental-health.md somewhere?
3072018-02-16T18:36:23  <achow101> jcorgan: https://github.com/bitcoin-core/docs/tree/master/gitian-building and https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md
3082018-02-16T18:36:24  <achow101> good luck
3092018-02-16T18:38:27  <jcorgan> if you don't hear from me in 72 hours send out the search teams
3102018-02-16T18:39:10  <wumpus> achow101: he's gonna need it
3112018-02-16T18:43:53  *** farmerwampum has joined #bitcoin-core-dev
3122018-02-16T18:49:51  <jnewbery> review beg: #10583 . achow101 has rebased about a squillion times
3132018-02-16T18:49:56  <gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub
3142018-02-16T18:50:37  <bitcoin-git> [bitcoin] DaveFromBinary opened pull request #12452: [Docs] Clarified systemd installation instructions in init.md for Ubuntu users. (master...doc-init-updates) https://github.com/bitcoin/bitcoin/pull/12452
3152018-02-16T18:52:38  *** Hector67Nader has joined #bitcoin-core-dev
3162018-02-16T18:53:19  *** belcher has quit IRC
3172018-02-16T18:57:27  *** Hector67Nader has quit IRC
3182018-02-16T18:57:47  *** jb55 has quit IRC
3192018-02-16T19:06:31  <bitcoin-git> [bitcoin] Empact opened pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455
3202018-02-16T19:12:17  *** promag has joined #bitcoin-core-dev
3212018-02-16T19:16:38  *** promag has quit IRC
3222018-02-16T19:20:06  *** promag has joined #bitcoin-core-dev
3232018-02-16T19:24:10  *** promag has quit IRC
3242018-02-16T19:29:54  <ProfMac> I did a gitian build back in 0.14.xx.  The process was not well documented, and I could not reproduce whatever I did from my notes.  Is the documentation process any better now?
3252018-02-16T19:30:11  *** d_t has joined #bitcoin-core-dev
3262018-02-16T19:39:11  <wumpus> https://github.com/bitcoin-core/docs/blob/master/gitian-building.md
3272018-02-16T19:39:25  <wumpus> improvements are always welcome
3282018-02-16T19:40:48  <achow101> I don't think the problem is documentation but rather that gitian doesn't always work
3292018-02-16T19:43:51  *** promag has joined #bitcoin-core-dev
3302018-02-16T19:46:13  <MarcoFalke> It is like Jenga. All the virtualizations or OSes that it depends on pull out sticks and you wait until it breaks
3312018-02-16T19:48:42  *** promag has quit IRC
3322018-02-16T19:52:36  *** Leopoldo4Heaney has joined #bitcoin-core-dev
3332018-02-16T19:54:02  *** mmgen has quit IRC
3342018-02-16T20:00:22  *** grafcaps has quit IRC
3352018-02-16T20:02:39  *** Leopoldo4Heaney has quit IRC
3362018-02-16T20:05:46  *** promag has joined #bitcoin-core-dev
3372018-02-16T20:10:13  *** intcat has quit IRC
3382018-02-16T20:10:41  *** promag has quit IRC
3392018-02-16T20:11:08  *** d_t has quit IRC
3402018-02-16T20:11:50  <bitcoin-git> [bitcoin] Empact opened pull request #12458: Enforce that amount is provided for signrawtransaction prevtxs (master...rawtransaction-amount-required) https://github.com/bitcoin/bitcoin/pull/12458
3412018-02-16T20:12:12  *** intcat has joined #bitcoin-core-dev
3422018-02-16T20:25:55  *** jb55 has joined #bitcoin-core-dev
3432018-02-16T20:28:57  <esotericnonsense> is univalue compiled seperately without C++11 ? i'm struggling with my make-fu
3442018-02-16T20:29:06  <esotericnonsense> it disagrees with my use of nullptr
3452018-02-16T20:29:46  *** SopaXorzTaker has quit IRC
3462018-02-16T20:33:50  <esotericnonsense> yeah, that's it.
3472018-02-16T20:37:53  <bitcoin-git> [bitcoin] Empact opened pull request #12459: Assert compressed / compact keys and sigs are strictly shorter than regular (master...assert-compressed-smaller) https://github.com/bitcoin/bitcoin/pull/12459
3482018-02-16T20:38:01  <bitcoin-git> [bitcoin] Empact opened pull request #12460: Assert CPubKey::ValidLength to the pubkey's header-relevent size (master...key-size-check-header) https://github.com/bitcoin/bitcoin/pull/12460
3492018-02-16T20:39:41  <bitcoin-git> [bitcoin] Empact opened pull request #12461: Refactor key / signature size consts to be relative to their relevant class (master...key-size-consts) https://github.com/bitcoin/bitcoin/pull/12461
3502018-02-16T20:39:47  *** promag has joined #bitcoin-core-dev
3512018-02-16T20:40:57  <bitcoin-git> [bitcoin] Empact closed pull request #12319: Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319
3522018-02-16T20:42:01  <cfields> esotericnonsense: "yeah, that's it" ?
3532018-02-16T20:43:48  <esotericnonsense> cfields: if I hack in g++ -std=c++11 into the makefile for univalue that works (I'm currently trying to figure out how to do this properly and fixing up some other compilation errors)
3542018-02-16T20:44:03  <cfields> yikes!
3552018-02-16T20:44:10  *** promag has quit IRC
3562018-02-16T20:44:31  <esotericnonsense> what's yikes? that we weren't using c++11 for univalue? the concept of using it? :)
3572018-02-16T20:44:49  *** grubles has quit IRC
3582018-02-16T20:44:59  <cfields> yikes that we're possibly mixing ABIs in our binaries
3592018-02-16T20:45:16  <cfields> I'm surprised we haven't seen issues from that yet
3602018-02-16T20:45:54  <esotericnonsense> mmm. unfortunately my knowledge of this stuff has kind of faded after spending years in python-land. slowly getting there again.
3612018-02-16T20:46:23  *** Chris_Stewart_5 has quit IRC
3622018-02-16T20:46:31  <cfields> heh, no worries
3632018-02-16T20:46:52  <cfields> I'll PR a fix, unless you want to drill down into it
3642018-02-16T20:48:17  <esotericnonsense> up to you. i'm making a small change to univalue that requires it, but my knowledge of make is very limited (i'
3652018-02-16T20:48:32  <esotericnonsense> (i'd just be hacking in -std=c+11 into flags until it works on my box)
3662018-02-16T20:49:01  <esotericnonsense> well it doesn't require it because I don't _need_ to use nullptr it's just consistent that way
3672018-02-16T20:49:11  <bitcoin-git> [bitcoin] Empact opened pull request #12463: Drop the return argument from CValidationState::DoS and Invalid (master...drop-dos-return) https://github.com/bitcoin/bitcoin/pull/12463
3682018-02-16T20:49:46  <bitcoin-git> [bitcoin] Empact closed pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357
3692018-02-16T20:51:03  <cfields> well, we haven't discussed it afaik, but it makes sense to keep univalue c++03 simply because it already is
3702018-02-16T20:52:40  *** Mona87Dooley has joined #bitcoin-core-dev
3712018-02-16T20:53:15  <sipa> cfields: using c++11 may be more efficient
3722018-02-16T20:53:56  <sipa> because it gives stl automagival rvalue support
3732018-02-16T20:54:02  <sipa> *automagical
3742018-02-16T20:54:09  <cfields> sipa: sure. I think it makes sense to discuss bumping. It'd just be senseless to bump for some trivial change
3752018-02-16T20:54:29  <cfields> sipa: or did you mean just compiling as c++11?
3762018-02-16T20:54:55  <jnewbery> second review beg: #10579 for the same reasons as 10583. (Obviously not as important as anything v0.16 related, but I think for achow's sanity we should merge soon)
3772018-02-16T20:54:57  <cfields> 'cause, yea, we'd see the rvalue optims from that alone
3782018-02-16T20:54:58  <gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub
3792018-02-16T20:55:03  *** jb552 has joined #bitcoin-core-dev
3802018-02-16T20:55:29  <sipa> jnewbery: yes, absolutely
3812018-02-16T20:55:33  <cfields> beg threshold hit, will review :)
3822018-02-16T20:56:12  <cfields> sipa: my immediate concern is catching exceptions across ABIs, though
3832018-02-16T20:56:54  *** jb55 has quit IRC
3842018-02-16T20:57:01  <jnewbery> thanks sipa, thanks cfields!
3852018-02-16T20:57:27  *** Mona87Dooley has quit IRC
3862018-02-16T20:58:37  <instagibbs> i know I've reviewed that PR before... no comments, hm. Will do again.
3872018-02-16T20:59:28  *** grubles has joined #bitcoin-core-dev
3882018-02-16T21:00:26  *** promag has joined #bitcoin-core-dev
3892018-02-16T21:01:41  <bitcoin-git> [bitcoin] jnewbery opened pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464
3902018-02-16T21:05:35  *** jb552 has quit IRC
3912018-02-16T21:05:35  *** Randolf has quit IRC
3922018-02-16T21:08:51  <achow101> jnewbery: sanity? What's that?
3932018-02-16T21:09:20  *** jb552 has joined #bitcoin-core-dev
3942018-02-16T21:09:26  *** grafcaps has joined #bitcoin-core-dev
3952018-02-16T21:11:13  *** zautomata1 has joined #bitcoin-core-dev
3962018-02-16T21:11:29  *** owowo has quit IRC
3972018-02-16T21:12:05  *** Victorsueca has quit IRC
3982018-02-16T21:12:08  *** zautomata has quit IRC
3992018-02-16T21:12:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/59e032b43cea...27c59dc502f2
4002018-02-16T21:12:28  <bitcoin-git> bitcoin/master df47afb John Newbery: Revert "[tests] bind functional test nodes to 127.0.0.1"...
4012018-02-16T21:12:29  <bitcoin-git> bitcoin/master 27c59dc MarcoFalke: Merge #12464: Revert "[tests] bind functional test nodes to 127.0.0.1"...
4022018-02-16T21:13:17  *** Victorsueca has joined #bitcoin-core-dev
4032018-02-16T21:13:23  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464
4042018-02-16T21:13:43  *** zautomata2 has joined #bitcoin-core-dev
4052018-02-16T21:14:59  *** grubles has quit IRC
4062018-02-16T21:15:34  *** promag has quit IRC
4072018-02-16T21:15:35  *** zautomata1 has quit IRC
4082018-02-16T21:16:45  *** owowo has joined #bitcoin-core-dev
4092018-02-16T21:17:27  *** neha has quit IRC
4102018-02-16T21:18:21  *** intcat has quit IRC
4112018-02-16T21:18:28  <jnewbery> :)
4122018-02-16T21:19:00  *** neha has joined #bitcoin-core-dev
4132018-02-16T21:20:14  *** intcat has joined #bitcoin-core-dev
4142018-02-16T21:23:31  *** Giszmo has joined #bitcoin-core-dev
4152018-02-16T21:23:32  *** Giszmo has quit IRC
4162018-02-16T21:23:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27c59dc502f2...23481fa50301
4172018-02-16T21:23:59  <bitcoin-git> bitcoin/master e710387 Ben Woosley: test: Fix bip68 sequence test to reflect updated rpc error message...
4182018-02-16T21:24:00  <bitcoin-git> bitcoin/master 23481fa MarcoFalke: Merge #12455: Fix bip68 sequence test to reflect updated rpc error message...
4192018-02-16T21:24:05  *** Giszmo has joined #bitcoin-core-dev
4202018-02-16T21:24:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455
4212018-02-16T21:27:10  *** jb553 has joined #bitcoin-core-dev
4222018-02-16T21:30:24  *** jb552 has quit IRC
4232018-02-16T21:33:35  <esotericnonsense> cfields: changed the univalue stuff to just use NULL instead of nullptr
4242018-02-16T21:38:11  *** jb554 has joined #bitcoin-core-dev
4252018-02-16T21:40:51  *** jb553 has quit IRC
4262018-02-16T21:52:23  *** Randolf has joined #bitcoin-core-dev
4272018-02-16T21:52:36  *** Cortez83Doyle has joined #bitcoin-core-dev
4282018-02-16T21:52:45  *** jb554 has quit IRC
4292018-02-16T21:53:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4302018-02-16T21:55:36  *** mirese has joined #bitcoin-core-dev
4312018-02-16T21:56:10  *** mirese__ has joined #bitcoin-core-dev
4322018-02-16T21:57:32  *** Cortez83Doyle has quit IRC
4332018-02-16T21:59:33  *** mirese_ has quit IRC
4342018-02-16T21:59:48  *** mirese has quit IRC
4352018-02-16T22:05:29  *** mirese has joined #bitcoin-core-dev
4362018-02-16T22:06:36  *** justan0theruser has quit IRC
4372018-02-16T22:08:52  *** mirese__ has quit IRC
4382018-02-16T22:10:08  *** mirese_ has joined #bitcoin-core-dev
4392018-02-16T22:11:34  *** mirese__ has joined #bitcoin-core-dev
4402018-02-16T22:13:40  *** mirese has quit IRC
4412018-02-16T22:15:10  *** mirese_ has quit IRC
4422018-02-16T22:34:50  *** jb554 has joined #bitcoin-core-dev
4432018-02-16T22:36:13  *** spinza has quit IRC
4442018-02-16T22:40:35  *** Giszmo has quit IRC
4452018-02-16T22:44:34  *** Chris_Stewart_5 has quit IRC
4462018-02-16T22:51:48  *** spinza has joined #bitcoin-core-dev
4472018-02-16T22:51:52  *** mirese has joined #bitcoin-core-dev
4482018-02-16T22:52:23  *** mirese_ has joined #bitcoin-core-dev
4492018-02-16T22:52:35  *** Thomas64Runte has joined #bitcoin-core-dev
4502018-02-16T22:52:47  *** jamespeerless has quit IRC
4512018-02-16T22:52:57  *** jamesob has quit IRC
4522018-02-16T22:53:52  *** mirese___ has joined #bitcoin-core-dev
4532018-02-16T22:54:40  *** mirese__ has quit IRC
4542018-02-16T22:56:28  *** mirese has quit IRC
4552018-02-16T22:57:02  *** mirese_ has quit IRC
4562018-02-16T22:57:32  *** Thomas64Runte has quit IRC
4572018-02-16T23:01:12  *** Murch has quit IRC
4582018-02-16T23:04:58  *** Guyver2 has quit IRC
4592018-02-16T23:14:09  *** StopAndDecrypt has quit IRC
4602018-02-16T23:15:07  *** StopAndDecrypt has joined #bitcoin-core-dev
4612018-02-16T23:15:17  *** StopAndDecrypt has quit IRC
4622018-02-16T23:15:17  *** StopAndDecrypt has joined #bitcoin-core-dev
4632018-02-16T23:15:57  *** promag has joined #bitcoin-core-dev
4642018-02-16T23:21:27  *** StopAndDecrypt has quit IRC
4652018-02-16T23:21:48  *** StopAndDecrypt has joined #bitcoin-core-dev
4662018-02-16T23:21:58  *** StopAndDecrypt has quit IRC
4672018-02-16T23:21:58  *** StopAndDecrypt has joined #bitcoin-core-dev
4682018-02-16T23:26:22  *** Victorsueca has quit IRC
4692018-02-16T23:27:47  *** Victorsueca has joined #bitcoin-core-dev
4702018-02-16T23:30:54  *** meshcollider has joined #bitcoin-core-dev
4712018-02-16T23:37:21  *** Murch has joined #bitcoin-core-dev
4722018-02-16T23:41:02  *** jojeyh has joined #bitcoin-core-dev
4732018-02-16T23:52:35  *** Kali58Bayer has joined #bitcoin-core-dev
4742018-02-16T23:57:06  *** Randolf has quit IRC
4752018-02-16T23:57:40  *** Kali58Bayer has quit IRC