12018-03-01T00:00:04 *** weez17 has quit IRC
22018-03-01T00:00:50 *** weez17 has joined #bitcoin-core-dev
32018-03-01T00:04:20 *** timothy has joined #bitcoin-core-dev
42018-03-01T00:05:36 *** kurito has quit IRC
52018-03-01T00:10:12 *** timothy has quit IRC
62018-03-01T00:19:44 *** arbitrary_guy has joined #bitcoin-core-dev
72018-03-01T00:40:53 *** fanquake has joined #bitcoin-core-dev
82018-03-01T00:42:42 *** MrPaz has quit IRC
92018-03-01T00:45:53 *** rantahu has joined #bitcoin-core-dev
102018-03-01T00:51:32 *** belcher has quit IRC
112018-03-01T00:59:31 *** Bosma has joined #bitcoin-core-dev
122018-03-01T00:59:59 *** Krellan has joined #bitcoin-core-dev
132018-03-01T01:01:22 *** CubicEarths has joined #bitcoin-core-dev
142018-03-01T01:01:44 *** lnostdal has quit IRC
152018-03-01T01:14:28 *** dabura667 has joined #bitcoin-core-dev
162018-03-01T01:15:02 *** lnostdal has joined #bitcoin-core-dev
172018-03-01T01:21:16 *** ohnx has quit IRC
182018-03-01T01:23:15 *** arbitrary_guy has quit IRC
192018-03-01T01:24:07 *** arbitrary_guy has joined #bitcoin-core-dev
202018-03-01T01:27:32 *** dafunkizdiz has joined #bitcoin-core-dev
212018-03-01T01:29:33 *** CubicEarths has quit IRC
222018-03-01T01:33:37 *** CubicEarths has joined #bitcoin-core-dev
232018-03-01T01:37:02 *** MrPaz has joined #bitcoin-core-dev
242018-03-01T01:43:07 *** grafcaps has quit IRC
252018-03-01T01:44:30 *** rantahu has quit IRC
262018-03-01T01:44:58 *** rantahu has joined #bitcoin-core-dev
272018-03-01T01:48:31 *** promag has quit IRC
282018-03-01T01:48:52 *** promag has joined #bitcoin-core-dev
292018-03-01T01:49:15 *** promag has quit IRC
302018-03-01T01:49:21 *** rantahu has quit IRC
312018-03-01T01:50:17 *** Arokh has quit IRC
322018-03-01T01:50:21 *** ghost43 has quit IRC
332018-03-01T01:50:43 *** Arokh has joined #bitcoin-core-dev
342018-03-01T01:50:47 *** intcat has quit IRC
352018-03-01T01:52:46 *** intcat has joined #bitcoin-core-dev
362018-03-01T01:53:31 *** ghost43 has joined #bitcoin-core-dev
372018-03-01T02:02:40 *** grafcaps has joined #bitcoin-core-dev
382018-03-01T02:04:33 *** dafunkizdiz has quit IRC
392018-03-01T02:05:35 *** shesek has joined #bitcoin-core-dev
402018-03-01T02:05:35 *** shesek has joined #bitcoin-core-dev
412018-03-01T02:06:05 *** Arokh has quit IRC
422018-03-01T02:06:41 *** Arokh has joined #bitcoin-core-dev
432018-03-01T02:06:59 *** lnostdal has quit IRC
442018-03-01T02:07:29 *** Randolf has quit IRC
452018-03-01T02:10:12 *** Lucile39Klocko has quit IRC
462018-03-01T02:15:31 *** kexkey has joined #bitcoin-core-dev
472018-03-01T02:20:50 *** lnostdal has joined #bitcoin-core-dev
482018-03-01T02:32:34 *** Davion25Cole has joined #bitcoin-core-dev
492018-03-01T02:33:06 *** jojeyh has joined #bitcoin-core-dev
502018-03-01T02:40:10 *** rantahu has joined #bitcoin-core-dev
512018-03-01T02:48:59 *** rongze has joined #bitcoin-core-dev
522018-03-01T02:52:24 *** Randolf has joined #bitcoin-core-dev
532018-03-01T02:55:27 *** MrPaz has quit IRC
542018-03-01T03:00:10 *** rongze has quit IRC
552018-03-01T03:00:39 *** rongze has joined #bitcoin-core-dev
562018-03-01T03:01:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
572018-03-01T03:16:17 *** lnostdal has quit IRC
582018-03-01T03:18:12 *** ohnx has joined #bitcoin-core-dev
592018-03-01T03:24:35 *** Randolf has quit IRC
602018-03-01T03:28:59 *** rongze_ has joined #bitcoin-core-dev
612018-03-01T03:31:53 *** rongze has quit IRC
622018-03-01T03:35:12 *** CubicEarths has quit IRC
632018-03-01T03:35:58 *** Krellan has quit IRC
642018-03-01T03:44:33 *** Chris_Stewart_5 has quit IRC
652018-03-01T03:53:09 *** fanquake has quit IRC
662018-03-01T03:59:05 *** rantahu has quit IRC
672018-03-01T04:05:52 *** meshcollider has quit IRC
682018-03-01T04:12:40 *** CubicEarths has joined #bitcoin-core-dev
692018-03-01T05:06:20 *** Randolf has joined #bitcoin-core-dev
702018-03-01T05:10:40 *** cryptojanitor has quit IRC
712018-03-01T05:11:54 *** rongze has joined #bitcoin-core-dev
722018-03-01T05:15:36 *** rongze_ has quit IRC
732018-03-01T05:22:22 *** Murch has quit IRC
742018-03-01T05:35:30 <bitcoin-git> [bitcoin] kostaz opened pull request #12570: Add test cases for HexStr (std::reverse_iterator and corner cases) (master...master) https://github.com/bitcoin/bitcoin/pull/12570
752018-03-01T05:35:46 *** indistylo has joined #bitcoin-core-dev
762018-03-01T05:39:41 *** aruns has joined #bitcoin-core-dev
772018-03-01T05:40:37 *** indistylo has quit IRC
782018-03-01T05:41:23 *** aruns__ has joined #bitcoin-core-dev
792018-03-01T05:44:35 *** aruns has quit IRC
802018-03-01T05:54:17 *** fanquake has joined #bitcoin-core-dev
812018-03-01T05:58:58 *** fanquake has quit IRC
822018-03-01T06:02:33 *** jouke_ has quit IRC
832018-03-01T06:03:41 *** jouke has joined #bitcoin-core-dev
842018-03-01T06:05:55 *** MrPaz has joined #bitcoin-core-dev
852018-03-01T06:46:54 *** aruns has joined #bitcoin-core-dev
862018-03-01T06:49:22 *** aruns__ has quit IRC
872018-03-01T07:02:43 *** shesek has quit IRC
882018-03-01T07:04:21 *** meshcollider has joined #bitcoin-core-dev
892018-03-01T07:08:23 *** jma has joined #bitcoin-core-dev
902018-03-01T07:08:57 *** MrPaz has quit IRC
912018-03-01T07:09:21 *** jma is now known as jma01
922018-03-01T07:22:05 *** jma01 has quit IRC
932018-03-01T07:22:40 *** jma01 has joined #bitcoin-core-dev
942018-03-01T07:27:18 *** jma01 has quit IRC
952018-03-01T07:27:30 *** jma01 has joined #bitcoin-core-dev
962018-03-01T07:43:29 *** aruns has quit IRC
972018-03-01T07:45:49 *** rongze_ has joined #bitcoin-core-dev
982018-03-01T07:49:11 *** rongze has quit IRC
992018-03-01T07:49:34 *** aruns has joined #bitcoin-core-dev
1002018-03-01T07:50:53 *** aruns__ has joined #bitcoin-core-dev
1012018-03-01T07:53:07 *** Krellan has joined #bitcoin-core-dev
1022018-03-01T07:54:05 *** aruns has quit IRC
1032018-03-01T07:55:07 *** fanquake has joined #bitcoin-core-dev
1042018-03-01T07:55:22 *** SopaXorzTaker has joined #bitcoin-core-dev
1052018-03-01T07:55:24 *** rongze has joined #bitcoin-core-dev
1062018-03-01T07:56:47 <bitcoin-git> [bitcoin] AkioNak opened pull request #12572: [script] lint-whitespace: improve print linenumber (master...morelinenumber) https://github.com/bitcoin/bitcoin/pull/12572
1072018-03-01T07:59:37 *** fanquake has quit IRC
1082018-03-01T07:59:38 *** rongze_ has quit IRC
1092018-03-01T08:08:04 *** aruns has joined #bitcoin-core-dev
1102018-03-01T08:08:10 *** timothy has joined #bitcoin-core-dev
1112018-03-01T08:09:22 *** jma01 has quit IRC
1122018-03-01T08:09:49 *** jma01 has joined #bitcoin-core-dev
1132018-03-01T08:10:20 *** timothy has quit IRC
1142018-03-01T08:10:43 *** aruns__ has quit IRC
1152018-03-01T08:11:49 *** timothy has joined #bitcoin-core-dev
1162018-03-01T08:12:12 *** rantahu has joined #bitcoin-core-dev
1172018-03-01T08:13:46 *** lnostdal has joined #bitcoin-core-dev
1182018-03-01T08:16:55 *** mmgen has joined #bitcoin-core-dev
1192018-03-01T08:18:17 *** rantahu has quit IRC
1202018-03-01T08:18:43 *** rantahu has joined #bitcoin-core-dev
1212018-03-01T08:21:28 *** btcdrak has joined #bitcoin-core-dev
1222018-03-01T08:24:30 *** rantahu has quit IRC
1232018-03-01T08:24:53 *** rantahu has joined #bitcoin-core-dev
1242018-03-01T08:29:21 *** rantahu has quit IRC
1252018-03-01T08:29:48 *** rex_4539 has joined #bitcoin-core-dev
1262018-03-01T08:37:23 *** jma01 has quit IRC
1272018-03-01T08:37:30 *** jma01 has joined #bitcoin-core-dev
1282018-03-01T08:38:27 *** laurentmt has joined #bitcoin-core-dev
1292018-03-01T08:40:07 *** laurentmt has quit IRC
1302018-03-01T08:50:54 *** lightningbot has joined #bitcoin-core-dev
1312018-03-01T08:55:20 *** CubicEarths has quit IRC
1322018-03-01T08:57:13 *** CubicEarths has joined #bitcoin-core-dev
1332018-03-01T08:58:11 *** jma01 has quit IRC
1342018-03-01T08:58:43 *** jma01 has joined #bitcoin-core-dev
1352018-03-01T09:01:27 *** CubicEarths has quit IRC
1362018-03-01T09:02:41 *** murrayn has quit IRC
1372018-03-01T09:03:09 *** jimpo_ has quit IRC
1382018-03-01T09:10:21 *** jma01 has quit IRC
1392018-03-01T09:10:29 *** jma01 has joined #bitcoin-core-dev
1402018-03-01T09:16:24 *** jma01 has quit IRC
1412018-03-01T09:19:35 *** murrayn has joined #bitcoin-core-dev
1422018-03-01T09:19:35 *** murrayn has joined #bitcoin-core-dev
1432018-03-01T09:23:55 <bitcoin-git> [bitcoin] 532479301 opened pull request #12573: Consensus: Fix bug when compiler do not support __builtin_clz* (master...vs2017) https://github.com/bitcoin/bitcoin/pull/12573
1442018-03-01T09:31:36 *** arbitrary_guy has quit IRC
1452018-03-01T09:32:17 *** CubicEarths has joined #bitcoin-core-dev
1462018-03-01T09:36:13 *** CubicEarths has quit IRC
1472018-03-01T09:37:28 *** rongze_ has joined #bitcoin-core-dev
1482018-03-01T09:40:49 *** rongze has quit IRC
1492018-03-01T09:46:02 <pierre_rochard> Is there an equivalent to ScriptToAsmStr for an CTxInâs scriptWitness?
1502018-03-01T09:46:47 <pierre_rochard> the current implementation of TxToUniv in core_write.cpp just uses HexStr
1512018-03-01T09:51:33 *** Krellan has quit IRC
1522018-03-01T09:53:51 *** promag has joined #bitcoin-core-dev
1532018-03-01T09:56:12 *** fanquake has joined #bitcoin-core-dev
1542018-03-01T10:00:52 *** fanquake has quit IRC
1552018-03-01T10:03:25 <wumpus> pierre_rochard: I don't think so
1562018-03-01T10:06:21 <pierre_rochard> Ok, Iâll settle for HexStr until I really need it, then Iâll try my hand at a PR :)
1572018-03-01T10:06:56 <pierre_rochard> Thank you for the quick response wumpus!
1582018-03-01T10:07:09 <wumpus> I'm not sure it's possible to unambigiously distinguish between data encodings there, so it's shown as just hex. But maybe something better could be done, not sure...
1592018-03-01T10:07:42 *** Krellan has joined #bitcoin-core-dev
1602018-03-01T10:12:41 *** dabura667 has quit IRC
1612018-03-01T10:24:19 *** Victorsueca has quit IRC
1622018-03-01T10:25:46 *** Victorsueca has joined #bitcoin-core-dev
1632018-03-01T10:53:16 *** Deinogalerix21 has joined #bitcoin-core-dev
1642018-03-01T10:56:38 *** cryptojanitor has joined #bitcoin-core-dev
1652018-03-01T11:04:55 *** aruns__ has joined #bitcoin-core-dev
1662018-03-01T11:05:21 *** aruns has quit IRC
1672018-03-01T11:06:25 *** aruns has joined #bitcoin-core-dev
1682018-03-01T11:09:21 *** aruns__ has quit IRC
1692018-03-01T11:09:25 *** promag has quit IRC
1702018-03-01T11:13:36 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e2ed253f505...32987d5aebc4
1712018-03-01T11:13:37 <bitcoin-git> bitcoin/master f0e7aa7 Evan Klitzke: Add new prevector benchmarks....
1722018-03-01T11:13:37 <bitcoin-git> bitcoin/master e46be25 Akio Nakamura: Reduce redundant code of prevector and speed it up...
1732018-03-01T11:13:38 <bitcoin-git> bitcoin/master 5aad635 Evan Klitzke: Use memset() to optimize prevector::resize()...
1742018-03-01T11:14:36 <bitcoin-git> [bitcoin] laanwj closed pull request #12549: Make prevector::resize() and other prevector operations much faster (master...prevector) https://github.com/bitcoin/bitcoin/pull/12549
1752018-03-01T11:18:15 *** booyah has quit IRC
1762018-03-01T11:18:41 *** lnostdal has quit IRC
1772018-03-01T11:19:09 *** belcher has joined #bitcoin-core-dev
1782018-03-01T11:19:25 *** booyah has joined #bitcoin-core-dev
1792018-03-01T11:20:02 *** ken2812221 has joined #bitcoin-core-dev
1802018-03-01T11:24:59 *** CubicEarths has joined #bitcoin-core-dev
1812018-03-01T11:27:01 *** rongze_ has quit IRC
1822018-03-01T11:29:43 *** CubicEarths has quit IRC
1832018-03-01T11:30:48 *** rongze has joined #bitcoin-core-dev
1842018-03-01T11:32:57 *** rex_4539 has quit IRC
1852018-03-01T11:33:26 *** rongze_ has joined #bitcoin-core-dev
1862018-03-01T11:34:28 *** rex_4539 has joined #bitcoin-core-dev
1872018-03-01T11:37:14 *** rongze has quit IRC
1882018-03-01T11:37:24 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/32987d5aebc4...be263faf871f
1892018-03-01T11:37:24 <bitcoin-git> bitcoin/master e7d9fc5 Sjors Provoost: [qt] navigate to transaction history page after send...
1902018-03-01T11:37:25 <bitcoin-git> bitcoin/master be263fa Wladimir J. van der Laan: Merge #12421: [qt] navigate to transaction history page after send...
1912018-03-01T11:38:09 <bitcoin-git> [bitcoin] laanwj closed pull request #12421: [qt] navigate to transaction history page after send (master...2018/02/qt-goto-transactions-after-send) https://github.com/bitcoin/bitcoin/pull/12421
1922018-03-01T11:45:41 *** SopaXorzTaker has quit IRC
1932018-03-01T11:55:39 *** SopaXorzTaker has joined #bitcoin-core-dev
1942018-03-01T12:01:10 *** lnostdal has joined #bitcoin-core-dev
1952018-03-01T12:03:25 *** Deinogalerix21 has quit IRC
1962018-03-01T12:05:01 *** lnostdal has quit IRC
1972018-03-01T12:05:43 *** btcdrak has quit IRC
1982018-03-01T12:07:10 *** lnostdal has joined #bitcoin-core-dev
1992018-03-01T12:13:32 *** Krellan has quit IRC
2002018-03-01T12:17:24 *** Krellan has joined #bitcoin-core-dev
2012018-03-01T12:22:17 *** Krellan has quit IRC
2022018-03-01T12:23:08 *** Krellan has joined #bitcoin-core-dev
2032018-03-01T12:25:25 *** promag has joined #bitcoin-core-dev
2042018-03-01T12:25:52 *** meshcollider has quit IRC
2052018-03-01T12:27:56 *** promag has quit IRC
2062018-03-01T12:37:47 *** rongze_ has quit IRC
2072018-03-01T12:39:59 *** btcdrak has joined #bitcoin-core-dev
2082018-03-01T12:49:01 *** CubicEarths has joined #bitcoin-core-dev
2092018-03-01T12:51:03 *** ken2812221 has quit IRC
2102018-03-01T12:51:31 *** ken2812221 has joined #bitcoin-core-dev
2112018-03-01T12:53:07 *** CubicEarths has quit IRC
2122018-03-01T12:54:12 *** ken2812221 has quit IRC
2132018-03-01T12:55:37 *** ken2812221 has joined #bitcoin-core-dev
2142018-03-01T12:59:00 *** aruns__ has joined #bitcoin-core-dev
2152018-03-01T12:59:21 *** belcher has quit IRC
2162018-03-01T13:01:21 *** aruns has quit IRC
2172018-03-01T13:02:18 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2182018-03-01T13:03:46 *** lnostdal has quit IRC
2192018-03-01T13:04:10 *** lnostdal has joined #bitcoin-core-dev
2202018-03-01T13:04:37 *** aruns__ has quit IRC
2212018-03-01T13:07:19 *** Krellan has quit IRC
2222018-03-01T13:11:29 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/be263faf871f...39dcac27a1be
2232018-03-01T13:11:30 <bitcoin-git> bitcoin/master 90eac8c Kosta Zertsekel: Add tests for HexStr corner cases...
2242018-03-01T13:11:30 <bitcoin-git> bitcoin/master ac48861 Kosta Zertsekel: Add tests for HexStr std::reverse_iterator cases...
2252018-03-01T13:11:31 <bitcoin-git> bitcoin/master 39dcac2 Wladimir J. van der Laan: Merge #12570: Add test cases for HexStr (std::reverse_iterator and corner cases)...
2262018-03-01T13:11:52 *** belcher has joined #bitcoin-core-dev
2272018-03-01T13:12:25 <bitcoin-git> [bitcoin] laanwj closed pull request #12570: Add test cases for HexStr (std::reverse_iterator and corner cases) (master...master) https://github.com/bitcoin/bitcoin/pull/12570
2282018-03-01T13:12:28 *** Krellan has joined #bitcoin-core-dev
2292018-03-01T13:12:33 *** indistylo has joined #bitcoin-core-dev
2302018-03-01T13:16:21 *** cryptojanitor has quit IRC
2312018-03-01T13:19:25 *** luke-jr has quit IRC
2322018-03-01T13:19:42 *** luke-jr has joined #bitcoin-core-dev
2332018-03-01T13:20:11 *** CubicEarths has joined #bitcoin-core-dev
2342018-03-01T13:24:13 *** CubicEarths has quit IRC
2352018-03-01T13:25:21 *** Chris_Stewart_5 has quit IRC
2362018-03-01T13:26:10 *** shesek has joined #bitcoin-core-dev
2372018-03-01T13:39:07 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2382018-03-01T13:42:41 *** lnostdal has quit IRC
2392018-03-01T13:42:42 *** Davion25Cole has quit IRC
2402018-03-01T13:45:44 *** luke-jr has quit IRC
2412018-03-01T13:45:53 *** luke-jr has joined #bitcoin-core-dev
2422018-03-01T13:49:09 *** cryptojanitor has joined #bitcoin-core-dev
2432018-03-01T13:56:11 *** promag has joined #bitcoin-core-dev
2442018-03-01T13:57:19 *** ken2812221 has quit IRC
2452018-03-01T13:57:42 *** fanquake has joined #bitcoin-core-dev
2462018-03-01T13:57:59 *** ken2812221 has joined #bitcoin-core-dev
2472018-03-01T13:59:13 *** hkjn0 has quit IRC
2482018-03-01T14:00:28 *** rongze has joined #bitcoin-core-dev
2492018-03-01T14:00:46 *** larafale has joined #bitcoin-core-dev
2502018-03-01T14:02:22 *** fanquake has quit IRC
2512018-03-01T14:04:34 *** dermoth has joined #bitcoin-core-dev
2522018-03-01T14:05:41 *** hkjn0 has joined #bitcoin-core-dev
2532018-03-01T14:14:21 <promag> review request #12559
2542018-03-01T14:14:23 <gribble> https://github.com/bitcoin/bitcoin/issues/12559 | Avoid locking cs_main in some wallet RPC by promag · Pull Request #12559 · bitcoin/bitcoin · GitHub
2552018-03-01T14:19:53 *** lnostdal has joined #bitcoin-core-dev
2562018-03-01T14:21:27 *** Chris_Stewart_5 has quit IRC
2572018-03-01T14:23:08 *** ken2812221 has quit IRC
2582018-03-01T14:25:43 *** ken2812221 has joined #bitcoin-core-dev
2592018-03-01T14:31:56 <bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/39dcac27a1be...5c2aff8d95a9
2602018-03-01T14:31:57 <bitcoin-git> bitcoin/master 31c45a9 Jonas Schnelli: Accept addresses with NODE_NETWORK_LIMITED flag
2612018-03-01T14:31:57 <bitcoin-git> bitcoin/master 6fe57bd Jonas Schnelli: Connect to peers signaling NODE_NETWORK_LIMITED when out-of-IBD
2622018-03-01T14:31:57 <provoostenator> Is bitcoind --daemon supposed to keep a macOS machine awake?
2632018-03-01T14:31:58 <bitcoin-git> bitcoin/master fa999af Jonas Schnelli: [QA] Allow addrman loopback tests (add debug option -addrmantest)
2642018-03-01T14:32:09 <bitcoin-git> [bitcoin] laanwj closed pull request #10387: Eventually connect to NODE_NETWORK_LIMITED peers (master...2017/05/node_network_limited) https://github.com/bitcoin/bitcoin/pull/10387
2652018-03-01T14:32:34 *** Lloyd87Hudson has joined #bitcoin-core-dev
2662018-03-01T14:32:38 *** lnostdal has quit IRC
2672018-03-01T14:34:09 *** indistylo has quit IRC
2682018-03-01T14:39:06 *** rongze has quit IRC
2692018-03-01T14:46:49 <Randolf> provoostenator: Normally, when running any sort of a server daemon, sleep mode isn't typically wanted. After all, if the machine is in sleep mode, the daemon can't respond to any inbound queries.
2702018-03-01T14:48:08 <provoostenator> Right, that's what I would expect too...
2712018-03-01T14:48:11 <Randolf> provoostenator: There are some hardware configurations which can "wake up" the machine when network traffic is received, but since Bitcoin has a constant flow of data even this would in effect be pointless.
2722018-03-01T14:48:31 <Randolf> ...because the machine would constantly be waking up if ever it could get into sleep mode in the first place.
2732018-03-01T14:48:57 <provoostenator> Maybe we can add --caffeinate as a flag (for OSX, maybe Linux has a similar thing)?
2742018-03-01T14:50:04 <provoostenator> https://discussions.apple.com/thread/7858428
2752018-03-01T14:50:45 <Randolf> provoostenator: I think it's better to leave the power management to the OS. I also think it's reasonable to assume that someone running a server daemon should also have enough knowledge to manage their power settings according to their needs.
2762018-03-01T14:51:28 *** CubicEarths has joined #bitcoin-core-dev
2772018-03-01T14:51:31 <provoostenator> Yeah, that's what I thought to. But apparently I'm not not knowledgeable enough. :-)
2782018-03-01T14:52:28 <Randolf> If Bitcoin were to add options to manage power settings, then that would also be adding complexity to the project which I think would generally be beyond the scope of what Bitcoin is.
2792018-03-01T14:52:52 <Randolf> And then whenever a vendor changes their power management API, precious development time gets taken away from more important things.
2802018-03-01T14:53:43 <provoostenator> I probably made the mistake of logging out all users from the UI. It probably turned itself off once I closed the last SSH connection into the machine, despite bitcoind and a detached virtual box sessions.
2812018-03-01T14:54:29 <provoostenator> I tend to agree bitcoind shouldn't do that for the OS. Though we could add some installation instructions / hints.
2822018-03-01T14:55:01 <Randolf> provoostenator: I think that knowing how to change your system's power management configuration is something you'll have to master.
2832018-03-01T14:55:25 <Randolf> Again, power management is, in my view, beyond the scope of what Bitcoin does.
2842018-03-01T14:55:29 *** reardencode has quit IRC
2852018-03-01T14:55:36 <Randolf> It could be good for a Wiki page.
2862018-03-01T14:56:02 *** CubicEarths has quit IRC
2872018-03-01T14:57:02 *** Lloyd87Hudson has quit IRC
2882018-03-01T14:58:24 <Randolf> provoostenator: Consider this: Windows 10 regulatly reboots to install updates without asking the user first. Should Bitcoin's instructions tell users how to change the settings in Windows 10 to stop this from happening? And then update those instructions every time Microsoft changes the way
2892018-03-01T14:59:47 <Randolf> And again, I think it's reasonable to assume that anyone who wants to run bitcoind is knowledgeable enough to manage their own OS accordingly.
2902018-03-01T14:59:48 <Randolf> those settings are configured? I think this would also be beyond the scope of what Bitcoin does.
2912018-03-01T15:06:10 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2922018-03-01T15:12:02 *** Murch has joined #bitcoin-core-dev
2932018-03-01T15:13:42 <promag> wumpus: does this make sense https://github.com/bitcoin/bitcoin/blame/5c2aff8d95a932f82a9472975b1d183da6c99e5f/src/qt/transactionrecord.cpp#L140 ?
2942018-03-01T15:15:57 <promag> why is the fee added? fwiw rpc gettransaction separates amount and fee (in details field)
2952018-03-01T15:16:00 *** Giszmo has joined #bitcoin-core-dev
2962018-03-01T15:16:24 <promag> I wonder if we could remove that
2972018-03-01T15:18:47 *** belcher has quit IRC
2982018-03-01T15:18:57 *** Krellan has quit IRC
2992018-03-01T15:20:07 *** CubicEarths has joined #bitcoin-core-dev
3002018-03-01T15:23:19 *** Krellan has joined #bitcoin-core-dev
3012018-03-01T15:24:13 *** harrymm has quit IRC
3022018-03-01T15:30:59 *** CubicEarths has quit IRC
3032018-03-01T15:31:14 *** belcher has joined #bitcoin-core-dev
3042018-03-01T15:32:34 *** Delmer63Stamm has joined #bitcoin-core-dev
3052018-03-01T15:34:21 *** harrymm has joined #bitcoin-core-dev
3062018-03-01T15:35:10 *** intcat has quit IRC
3072018-03-01T15:36:34 *** intcat has joined #bitcoin-core-dev
3082018-03-01T15:37:49 *** grafcaps has quit IRC
3092018-03-01T15:37:50 *** jimpo has joined #bitcoin-core-dev
3102018-03-01T15:38:38 *** MrPaz has joined #bitcoin-core-dev
3112018-03-01T15:38:49 *** promag has quit IRC
3122018-03-01T15:47:59 *** rongze has joined #bitcoin-core-dev
3132018-03-01T15:48:57 *** Krellan has quit IRC
3142018-03-01T15:52:15 *** kexkey has quit IRC
3152018-03-01T15:54:12 *** Krellan has joined #bitcoin-core-dev
3162018-03-01T15:56:19 *** grafcaps has joined #bitcoin-core-dev
3172018-03-01T15:56:31 *** Delmer63Stamm has quit IRC
3182018-03-01T15:59:02 *** fanquake has joined #bitcoin-core-dev
3192018-03-01T16:00:08 *** Mrrt has joined #bitcoin-core-dev
3202018-03-01T16:00:26 *** bule has joined #bitcoin-core-dev
3212018-03-01T16:01:37 *** grafcaps has quit IRC
3222018-03-01T16:04:14 *** fanquake has quit IRC
3232018-03-01T16:04:50 *** bule has quit IRC
3242018-03-01T16:05:20 *** bule has joined #bitcoin-core-dev
3252018-03-01T16:07:07 *** rongze has quit IRC
3262018-03-01T16:07:41 *** rongze has joined #bitcoin-core-dev
3272018-03-01T16:08:23 *** bule has quit IRC
3282018-03-01T16:08:51 *** bule has joined #bitcoin-core-dev
3292018-03-01T16:10:44 *** bule has quit IRC
3302018-03-01T16:11:19 *** bule has joined #bitcoin-core-dev
3312018-03-01T16:11:52 *** rongze has quit IRC
3322018-03-01T16:22:45 *** grafcaps has joined #bitcoin-core-dev
3332018-03-01T16:32:34 *** Reanna69Herzog has joined #bitcoin-core-dev
3342018-03-01T16:38:20 *** larafale has quit IRC
3352018-03-01T16:44:22 *** lnostdal has joined #bitcoin-core-dev
3362018-03-01T17:02:02 *** ExtraCrispy has joined #bitcoin-core-dev
3372018-03-01T17:04:17 *** lnostdal has quit IRC
3382018-03-01T17:15:04 *** bule has quit IRC
3392018-03-01T17:15:59 *** bule has joined #bitcoin-core-dev
3402018-03-01T17:17:47 *** bule has quit IRC
3412018-03-01T17:18:16 *** bule has joined #bitcoin-core-dev
3422018-03-01T17:22:56 *** promag has joined #bitcoin-core-dev
3432018-03-01T17:26:27 *** lnostdal has joined #bitcoin-core-dev
3442018-03-01T17:35:43 *** btcdrak has quit IRC
3452018-03-01T17:42:24 *** jaranGoyang has joined #bitcoin-core-dev
3462018-03-01T17:44:20 *** lnostdal has quit IRC
3472018-03-01T17:46:02 *** d9b4bef9 has quit IRC
3482018-03-01T17:47:07 *** d9b4bef9 has joined #bitcoin-core-dev
3492018-03-01T17:56:36 *** zks_ has joined #bitcoin-core-dev
3502018-03-01T17:59:46 *** fanquake has joined #bitcoin-core-dev
3512018-03-01T18:02:30 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c2aff8d95a9...987a80995a69
3522018-03-01T18:02:31 <bitcoin-git> bitcoin/master 8222e05 Jonas Schnelli: Disable wallet fallbackfee by default on mainnet
3532018-03-01T18:02:31 <bitcoin-git> bitcoin/master 3f592b8 Jonas Schnelli: [QA] add wallet-rbf test
3542018-03-01T18:02:32 <bitcoin-git> bitcoin/master 987a809 Wladimir J. van der Laan: Merge #11882: Disable default fallbackfee on mainnet...
3552018-03-01T18:03:01 <bitcoin-git> [bitcoin] laanwj closed pull request #11882: Disable default fallbackfee on mainnet (master...2017/12/feeest_readyness) https://github.com/bitcoin/bitcoin/pull/11882
3562018-03-01T18:03:12 <zks_> Guys, I'm new to Bitcoin Core source code... and I have a question - why base_blob::GetHex() reverses the base_blob::data[WIDTH] array?
3572018-03-01T18:03:23 *** bule has quit IRC
3582018-03-01T18:03:30 <zks_> Hope it is an appropriate place to ask questions...
3592018-03-01T18:03:57 *** fanquake has quit IRC
3602018-03-01T18:04:18 *** bule has joined #bitcoin-core-dev
3612018-03-01T18:06:20 *** Reanna69Herzog has quit IRC
3622018-03-01T18:06:30 <wumpus> zks_: that's an old tradition, to represent hashes in reversed order
3632018-03-01T18:06:59 <zks_> wumpus: Thanks for the answer! But why?
3642018-03-01T18:07:05 <wumpus> zks_: we inherited it from satoshi and it's not realistic to change the entire interface
3652018-03-01T18:07:13 <zks_> wumpus: Is it related to network byte order?
3662018-03-01T18:07:23 <wumpus> no, definitely not
3672018-03-01T18:07:34 <mmgen> zks_: possibly because it shows leading zeroes of the block header as *leading* zeroes
3682018-03-01T18:07:41 <zks_> wumpus: Ok. Got it. Historic reasons...
3692018-03-01T18:07:46 <mmgen> zks_: block header hash
3702018-03-01T18:07:48 <wumpus> hashes are just blobs of data, their 'network byte order' is simply their memory representation
3712018-03-01T18:07:51 <wumpus> there is no logic to it
3722018-03-01T18:08:21 *** timothy has quit IRC
3732018-03-01T18:09:15 <mmgen> zks_: that's my reasoning on why Satoshi did it that way
3742018-03-01T18:09:18 <zks_> mmgen: wumpus: If I get it right - there is no difference how to store the hashes (regular or reversed order). It just has to be this way or the other...
3752018-03-01T18:09:48 <wumpus> I'm not sure GetHex on blob is the best place to do that swap, as it precludes using it in a neutral fashion, should probably ave been an external function GetWackyExternalRepresentation() but meh...
3762018-03-01T18:09:53 <mmgen> zks_: this is how they're represented, not how they're stored
3772018-03-01T18:10:33 <wumpus> indeed, internally the data is in normal order, just for external representation it's swapped
3782018-03-01T18:11:01 <wumpus> makes sense to use the same conventions in your own software, swap it only for communication with bitcoind
3792018-03-01T18:11:32 <zks_> so, in the blockchain "database" the hashes are always in the natural order and only printed in reverse?
3802018-03-01T18:11:38 <wumpus> yep
3812018-03-01T18:12:08 <zks_> ok, ... moving on guys... thx!
3822018-03-01T18:12:47 <wumpus> satoshi's orignal vision: print hashes in reversed order :-)
3832018-03-01T18:13:21 *** Scrat has joined #bitcoin-core-dev
3842018-03-01T18:13:31 <Chris_Stewart_5> *vein pulses in forehead*
3852018-03-01T18:14:16 <luke-jr> XD
3862018-03-01T18:22:36 *** bule has quit IRC
3872018-03-01T18:23:17 *** bule has joined #bitcoin-core-dev
3882018-03-01T18:27:24 *** Randolf has quit IRC
3892018-03-01T18:28:06 *** SopaXorzTaker has quit IRC
3902018-03-01T18:31:28 <bitcoin-git> [bitcoin] promag opened pull request #12578: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578
3912018-03-01T18:31:57 <promag> wumpus: not sure if this makes sense ^ but please comment since you wrote the origin code
3922018-03-01T18:32:01 <promag> *original
3932018-03-01T18:32:29 <wumpus> promag: no, I did not write that code, that came literally from the satoshi wxwindows code
3942018-03-01T18:32:30 <promag> I'll update the PR description and add a before image later
3952018-03-01T18:32:37 *** Kirk51VonRueden has joined #bitcoin-core-dev
3962018-03-01T18:32:40 <promag> oh :P
3972018-03-01T18:32:42 <wumpus> I think it's correct, though a bit weird
3982018-03-01T18:33:01 <promag> it's weird to see the fee as debit in the first output
3992018-03-01T18:33:20 <wumpus> the idea is that the total works out
4002018-03-01T18:33:24 <promag> we could "hide" fee records by default with a checkbox
4012018-03-01T18:33:35 <promag> right
4022018-03-01T18:34:06 <wumpus> so satoshi's reasoning there is that it doesn't matter which of the outputs the fee is added to, but it must be added to one, otherwise the total doesn't match
4032018-03-01T18:34:38 <wumpus> probably there's something similar in the RPC wallet
4042018-03-01T18:36:17 *** reardencode has joined #bitcoin-core-dev
4052018-03-01T18:39:09 *** promag has quit IRC
4062018-03-01T18:40:20 *** promag has joined #bitcoin-core-dev
4072018-03-01T18:43:14 <bitcoin-git> [bitcoin] laanwj closed pull request #12518: [0.16] Bump leveldb subtree (0.16...Mf1802-leveldbSubtreeBump) https://github.com/bitcoin/bitcoin/pull/12518
4082018-03-01T18:43:39 *** MrPaz has quit IRC
4092018-03-01T18:46:40 <promag> wumpus: maybe in listtransactions, I'll check later
4102018-03-01T18:47:02 <promag> btw, pr description updated
4112018-03-01T18:47:23 *** promag has quit IRC
4122018-03-01T18:47:39 *** arbitrary_guy has joined #bitcoin-core-dev
4132018-03-01T18:52:14 *** MrPaz has joined #bitcoin-core-dev
4142018-03-01T18:55:27 *** bule2 has joined #bitcoin-core-dev
4152018-03-01T18:57:41 *** bule has quit IRC
4162018-03-01T18:58:19 *** Randolf has joined #bitcoin-core-dev
4172018-03-01T19:01:22 <Randolf> wumpus: Perhaps the "hashes in reverse" routine could be analogous to AMBULANCE written backward on ambulances?
4182018-03-01T19:02:04 *** moneyball has joined #bitcoin-core-dev
4192018-03-01T19:02:53 <jcorgan> meeting?
4202018-03-01T19:03:02 <Randolf> jcorgan++
4212018-03-01T19:03:37 <sipa> meetung
4222018-03-01T19:03:45 <jcorgan> not sure the world could handle two of me
4232018-03-01T19:03:48 <achow101> meeting.
4242018-03-01T19:04:02 <wumpus> #startmeeting
4252018-03-01T19:04:02 <lightningbot> Meeting started Thu Mar 1 19:04:02 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
4262018-03-01T19:04:02 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4272018-03-01T19:04:18 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
4282018-03-01T19:04:40 <wumpus> Randolf: yes, like that, hash mirroring (TM)
4292018-03-01T19:04:53 <wumpus> #topic high priority for review
4302018-03-01T19:04:53 * Randolf smiles
4312018-03-01T19:05:15 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
4322018-03-01T19:05:29 <wumpus> a few of the PRs really need rebase
4332018-03-01T19:06:07 *** bule2 has quit IRC
4342018-03-01T19:06:39 *** bule2 has joined #bitcoin-core-dev
4352018-03-01T19:06:40 <wumpus> but we managed to merge a few this week, so if you have nothing on that list yet, proposals are welcome
4362018-03-01T19:06:41 <sipa> many people at FC18 right now, btw
4372018-03-01T19:06:42 <Randolf> I have purposely NOT rebased PR #12501 fully yet because it turned into some discussion about the "virtual size" of transactions.
4382018-03-01T19:06:45 <gribble> https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub
4392018-03-01T19:07:00 <Randolf> I hoped that last week it would be an easy one to complete, but turns out this wasn't so straight-forward.
4402018-03-01T19:07:28 <wumpus> there are certainly valid reasons to not rebase something
4412018-03-01T19:07:34 <Randolf> I think that PR #12567 can probably be closed, but a few more people might want to take a quick look at it first.
4422018-03-01T19:07:37 <gribble> https://github.com/bitcoin/bitcoin/issues/12567 | util: Print timestamp strings in logs using ISO 8601 formatting by practicalswift · Pull Request #12567 · bitcoin/bitcoin · GitHub
4432018-03-01T19:07:55 <Randolf> I think that PR #12546 should be merged.
4442018-03-01T19:07:57 <wumpus> on the other hand, if something runs out of sync with current master, then reviewing it in the current state makes less sense
4452018-03-01T19:07:57 <gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility Notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub
4462018-03-01T19:07:57 *** ExtraCrispy has quit IRC
4472018-03-01T19:07:58 <luke-jr> #11383 is probably ready for merge, just only one recent utACK
4482018-03-01T19:08:02 <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
4492018-03-01T19:08:04 <Randolf> (Sorry, I meant "merged" earlier rather than "closed.")
4502018-03-01T19:08:26 *** rongze has joined #bitcoin-core-dev
4512018-03-01T19:08:45 <wumpus> 12501 isn't on that list, should it be?
4522018-03-01T19:08:53 <Randolf> I suspect that PR 12501 probably needs more peer-review and discussion.
4532018-03-01T19:09:00 <wumpus> luke-jr: great!
4542018-03-01T19:09:24 <wumpus> luke-jr: looks like jonasschnelli has some, unreplied to comments there
4552018-03-01T19:09:32 *** promag has joined #bitcoin-core-dev
4562018-03-01T19:09:32 *** Victorsueca has quit IRC
4572018-03-01T19:10:04 <wumpus> it's fine to say that you're leaving them for a later PR, but please do reply to ereview comments
4582018-03-01T19:10:13 <Randolf> Okay.
4592018-03-01T19:10:40 <kanzure> hi.
4602018-03-01T19:10:47 *** Victorsueca has joined #bitcoin-core-dev
4612018-03-01T19:11:15 <promag> hi
4622018-03-01T19:11:54 <kanzure> btw i am still seeking topic suggestions (either stuff you want to talk about, or you want other people to talk about) for next week's event.
4632018-03-01T19:12:26 <kanzure> speaking of which, we should decide about next weekly meeting timing since i imagine some folks will be traveling
4642018-03-01T19:12:31 <wumpus> #action send kanzure further topic suggestions
4652018-03-01T19:12:33 *** rongze has quit IRC
4662018-03-01T19:12:47 <wumpus> right, I'll definitely not be there next week
4672018-03-01T19:13:10 <wumpus> will be travellingback at that time
4682018-03-01T19:13:15 <kanzure> wasn't aware we'd lose a bunch of people to fc18 but makes sense.
4692018-03-01T19:13:27 <promag> regarding multiwallet, there are other details that can be left for other pulls
4702018-03-01T19:13:27 <wumpus> indeed, apparently same problem this week
4712018-03-01T19:13:33 <sipa> sorry!
4722018-03-01T19:13:51 <luke-jr> sipa: next time, schedule FC so it doesn't conflict.
4732018-03-01T19:13:57 <sipa> haha!
4742018-03-01T19:13:57 <luke-jr> :p
4752018-03-01T19:14:00 * Randolf laughs
4762018-03-01T19:14:02 <wumpus> so I think we should skip next week's IRC meeting
4772018-03-01T19:14:10 <achow101> ack
4782018-03-01T19:14:13 <Randolf> Ack.
4792018-03-01T19:14:23 <kanzure> we can move it forward if we want.. since a lot of folks in same room. but it's sort of redundant.
4802018-03-01T19:14:41 <wumpus> right
4812018-03-01T19:15:05 <sipa> sgtm
4822018-03-01T19:15:18 <luke-jr> I suggest we have kanzure transcribe RL stuff to #bitcoin-core-dev in real time
4832018-03-01T19:15:31 <kanzure> that's okay with me since roasbeef wont be there
4842018-03-01T19:15:31 *** btcdrak has joined #bitcoin-core-dev
4852018-03-01T19:15:34 <luke-jr> lol
4862018-03-01T19:15:39 <kanzure> (i love him tho)
4872018-03-01T19:15:43 <wumpus> hehe
4882018-03-01T19:15:56 <btcdrak> oh what did I miss?
4892018-03-01T19:16:03 <luke-jr> 1/4th of the meeting
4902018-03-01T19:16:13 <wumpus> <luke-jr> I suggest we have kanzure transcribe RL stuff to #bitcoin-core-dev in real time
4912018-03-01T19:16:13 <wumpus> <kanzure> that's okay with me since roasbeef wont be there
4922018-03-01T19:16:29 <wumpus> not much is going on, everyone is at FC apparently
4932018-03-01T19:16:50 <luke-jr> end early and spend 45 minutes on #11383 ? :D
4942018-03-01T19:16:54 <gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
4952018-03-01T19:16:58 <wumpus> but if anyone has a topic they like to discuss with the three of us, please mention
4962018-03-01T19:17:03 <Randolf> btcdrak: I suggested merging PRs 12567 and 12546 and luke-jr suggested merging PR 11383.
4972018-03-01T19:17:31 <luke-jr> wumpus, luke-jr, sipa, btcdrak, kanzure, achow101, Randolf, promag = 8
4982018-03-01T19:17:35 <sdaftuar> hi
4992018-03-01T19:17:36 <wumpus> 12546 is obvious / documentation only
5002018-03-01T19:17:48 <Randolf> Yes.
5012018-03-01T19:18:13 <luke-jr> Randolf: well, it'd be nice to get a few more utACKs first (although I've shipped 11383 in Knots so long that I doubt there's any problems to find left)
5022018-03-01T19:19:24 <achow101> I'll take a look at 11383
5032018-03-01T19:20:28 <promag> luke-jr: I'll review again
5042018-03-01T19:21:28 <Randolf> wumpus: In PR 12501 an issue arose about the "virtual size" of the transaction. I'm thinking that it would probably be best to not mention this so as not to confuse end-users, but there's one person who's in favour of specifying this. If there's a link to documentation that can get into the
5052018-03-01T19:22:36 <Randolf> "See also," not see all. :)
5062018-03-01T19:22:36 <Randolf> details of the virtual size of the transaction, then I'm also thinking that including the link in the tooltip as a "see all" item should keep everyone happy?
5072018-03-01T19:23:16 <luke-jr> Randolf: the value being configured is fundamentally tied to virtual size. I don't think it's avoidable.
5082018-03-01T19:23:36 <wumpus> it's most important to be correct / complete
5092018-03-01T19:23:53 <luke-jr> "adjusted size" might be more understandable in plain English
5102018-03-01T19:24:06 <luke-jr> but there's no precedent for calling it that yet
5112018-03-01T19:24:24 <wumpus> in general, even if certain terms might confuse users, it's better to mention something than leave it out and say the wrong thing
5122018-03-01T19:24:28 <wumpus> but yeah, virtual size is confusing
5132018-03-01T19:24:29 <Randolf> Okay. I want the tooltip to be correct without adding confusion.
5142018-03-01T19:24:54 <luke-jr> weight-adjusted size?
5152018-03-01T19:25:09 <wumpus> but calling it differently might be even worse
5162018-03-01T19:25:10 <wumpus> I don't know
5172018-03-01T19:25:25 <wumpus> (as you can't google it then!)
5182018-03-01T19:25:30 *** jtimon has joined #bitcoin-core-dev
5192018-03-01T19:26:22 <luke-jr> it's really a different way of speaking of the weight, not the size
5202018-03-01T19:26:28 <Randolf> From a plain-English perspective, "weight-adjusted size" is much nicer, but that point about it being a new term is an important one because then it needs to be in the full documentation too.
5212018-03-01T19:26:28 <luke-jr> I can't think up a nice way to call it
5222018-03-01T19:26:57 <Randolf> Originally, I didn't have the word "virtual" in there.
5232018-03-01T19:27:04 <luke-jr> I suggest we just stick to "virtual size" until some English genius thinks up a better name
5242018-03-01T19:27:07 <wumpus> if there are new terms there's a good rationale to only use a single term for it, not make up multiple terms just because they sound nicer
5252018-03-01T19:27:18 <Randolf> I agree.
5262018-03-01T19:27:55 <wumpus> so if it is virtual size, I think we need to bite the bullet and simply use that
5272018-03-01T19:28:34 <wumpus> any other topics?
5282018-03-01T19:28:37 <Randolf> Alright. So, if the current wording in most recent commit - https://github.com/bitcoin/bitcoin/pull/12501/commits/a6a800cc4b3c1cbc4e5199563e2de1b5228ff9e2 - looks fine, then I'll go ahead and rebase.
5292018-03-01T19:29:29 <luke-jr> lgtn
5302018-03-01T19:29:30 <luke-jr> lgtm*
5312018-03-01T19:29:48 <wumpus> yes
5322018-03-01T19:29:53 <wumpus> #endmeeting
5332018-03-01T19:29:53 <lightningbot> Meeting ended Thu Mar 1 19:29:53 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5342018-03-01T19:29:53 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.html
5352018-03-01T19:29:53 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.txt
5362018-03-01T19:29:53 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.log.html
5372018-03-01T19:29:57 <Randolf> Thanks.
5382018-03-01T19:30:59 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/987a80995a69...a4a5fc7c17cd
5392018-03-01T19:30:59 <bitcoin-git> bitcoin/master b22c289 Randolf Richardson: [docs] Minor improvements to Compatibility Notes...
5402018-03-01T19:31:00 <bitcoin-git> bitcoin/master a4a5fc7 Wladimir J. van der Laan: Merge #12546: [docs] Minor improvements to Compatibility Notes...
5412018-03-01T19:31:51 <bitcoin-git> [bitcoin] laanwj closed pull request #12546: [docs] Minor improvements to Compatibility Notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/12546
5422018-03-01T19:32:39 *** moneyball has quit IRC
5432018-03-01T19:33:09 <bitcoin-git> [bitcoin] achow101 closed pull request #12180: scripted-diff: change kB to kvB, kilobyte to kilovbyte for transaction fee rate things (master...use-vbytes) https://github.com/bitcoin/bitcoin/pull/12180
5442018-03-01T19:33:16 *** promag has quit IRC
5452018-03-01T19:43:35 <jtimon> I guess "weight / 4" is more confusing than "virtual size"
5462018-03-01T19:48:14 <wumpus> yes
5472018-03-01T19:48:47 <wumpus> and even if you explain how it is computed, you'd still need to mention the term
5482018-03-01T19:48:50 <sipa> i wish we just everyone changed 'size' to mean vsize
5492018-03-01T19:48:54 <sipa> *everywhere
5502018-03-01T19:49:07 <sipa> but it's probably too late for that
5512018-03-01T19:50:52 *** loop_ has joined #bitcoin-core-dev
5522018-03-01T19:51:42 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4a5fc7c17cd...90a0aed51194
5532018-03-01T19:51:42 <bitcoin-git> bitcoin/master 19ac86e Alin Rus: Remove useless string initialization.
5542018-03-01T19:51:43 <bitcoin-git> bitcoin/master 90a0aed Wladimir J. van der Laan: Merge #12182: Remove useless string initializations...
5552018-03-01T19:52:27 <bitcoin-git> [bitcoin] laanwj closed pull request #12182: Remove useless string initializations (master...remove_useless_string_init) https://github.com/bitcoin/bitcoin/pull/12182
5562018-03-01T19:54:06 <wumpus> sipa: that would be the neatest solution, just have 'size' interpreted as 'vsize' everywhere
5572018-03-01T19:54:15 *** jaranGoyang has quit IRC
5582018-03-01T19:54:35 <Randolf> wumpus and jtimon: PR #12501 has been rebased, and I wrote a comment to @dooglus explaining where we're at.
5592018-03-01T19:54:37 <gribble> https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub
5602018-03-01T19:55:40 <Randolf> sipa: I wonder if it might be helpful to have a glossary of terms included in a separate file.
5612018-03-01T19:59:04 <wumpus> it would be something to put in the UI user documentation, if we had any :)
5622018-03-01T20:00:42 *** fanquake has joined #bitcoin-core-dev
5632018-03-01T20:03:14 <Randolf> I suppose bits and pieces could be put together at first, and then later formed into a proper document.
5642018-03-01T20:03:55 <Randolf> I guess there would be two documentation files -- one for bitcoind, and the other for the GUI.
5652018-03-01T20:04:21 <Randolf> Or perhaps they should just be separate chapters to avoid overlap.
5662018-03-01T20:04:57 *** fanquake has quit IRC
5672018-03-01T20:06:49 <rex_4539> Are you interested in a PR about fixing all the potential typos in the source code? I could go through all the source code, fix all typos, and squash to a single commit. If you are interested, let me know if you want me to fix all typos (comments and readable messages) or just a particular type. I have already fixed them in Zcash and Monero projects.
5682018-03-01T20:10:34 *** meshcollider has joined #bitcoin-core-dev
5692018-03-01T20:11:31 *** promag has joined #bitcoin-core-dev
5702018-03-01T20:12:04 *** bule2 has quit IRC
5712018-03-01T20:12:22 <Randolf> rex_4539: How does one fix "potential typos?"
5722018-03-01T20:12:40 <Randolf> Fixing existing typos is always welcome.
5732018-03-01T20:12:59 *** bule2 has joined #bitcoin-core-dev
5742018-03-01T20:13:46 <rex_4539> Very tedious work, I can assure you :) Not a developer but willing to help in any capacity I can.
5752018-03-01T20:13:54 <Randolf> That's fantastic.
5762018-03-01T20:13:57 <Randolf> My suggestion is this...
5772018-03-01T20:14:22 <Randolf> Do all the corrections in documentation in one PR, and do all the corrections in source code in another PR.
5782018-03-01T20:14:34 <Randolf> That is, if you want to keep the number of PRs down to a minimum.
5792018-03-01T20:14:47 <Randolf> You're also welcome to break them apart into smaller PRs if you like.
5802018-03-01T20:15:28 <Randolf> One of the advantages of smaller PRs is that it's easier to get them reviewed and merged.
5812018-03-01T20:18:13 *** Guyver2 has joined #bitcoin-core-dev
5822018-03-01T20:20:16 <rex_4539> The good thing with typos is that they are extremely trivial to review. Shouldn't take more than 5 minutes for the whole Bitcoin project.
5832018-03-01T20:21:00 <Randolf> Your contributions are most certainly welcome. :)
5842018-03-01T20:21:34 <Randolf> Please feel free to connect with me on GitHub as well: https://www.github.com/randolf
5852018-03-01T20:21:46 *** MrPaz has quit IRC
5862018-03-01T20:22:50 <rex_4539> Do you want me to fix also comments or just readable messages?
5872018-03-01T20:23:28 *** promag has quit IRC
5882018-03-01T20:23:40 *** Giszmo has quit IRC
5892018-03-01T20:23:48 *** Tennis has joined #bitcoin-core-dev
5902018-03-01T20:24:01 *** promag has joined #bitcoin-core-dev
5912018-03-01T20:24:12 <Randolf> rex_4539: That's entirely up to you as this is a volunteer effort after all.
5922018-03-01T20:24:33 <jcorgan> PRs with changes that are scattered through the code, like typo fixes, can sometimes make other PRs need rebasing (if merged)
5932018-03-01T20:25:36 <rex_4539> I'm asking because each team works differently. Zcash team was happy to have all fixed, Monero wanted just readable comments.
5942018-03-01T20:25:51 <rex_4539> *messages
5952018-03-01T20:26:00 <Randolf> rex_4539: Oh, I see. All fixes are welcome.
5962018-03-01T20:26:15 *** Kirk51VonRueden has quit IRC
5972018-03-01T20:26:37 <rex_4539> Don't worry, I will not touch typos in the actual code, just comments and readable messages.
5982018-03-01T20:27:11 <Randolf> jcorgan: Does it make a difference if the changes are in a very small number of very large PRs, or if the changes are in a lot of smaller PRs?
5992018-03-01T20:28:07 *** loop_ has quit IRC
6002018-03-01T20:28:10 *** grafcaps has quit IRC
6012018-03-01T20:28:17 <rex_4539> In my experience in the 2 previous projects, they wanted one big BR because each separate PR was using the CI machines all the time :P
6022018-03-01T20:28:39 *** promag has quit IRC
6032018-03-01T20:28:52 <jcorgan> i think there's a way to comment your PR so it gets ignored by CI, don't remember
6042018-03-01T20:29:45 <jcorgan> appropriate for doc only changes, but not for code comments, as you might accidentally break syntax
6052018-03-01T20:30:11 *** grafcaps has joined #bitcoin-core-dev
6062018-03-01T20:31:27 <Randolf> Oh, I'd like to know how to comment my PR to prevent the CI checks. That would reduce system resource load then.
6072018-03-01T20:31:47 <jcorgan> but i wouldn't worry so much about it now, i'd focus on getting the work done and submit a single PR for it, then if it needs breaking into multiple ones it will come out in the review
6082018-03-01T20:32:05 <rex_4539> I think there is a rollup command for the bot.
6092018-03-01T20:32:11 <Chris_Stewart_5> isn't travis 'free' for open source projects?
6102018-03-01T20:32:24 <Randolf> I still think it would be good to separate documentation updates from code/comment updates into two PRs though, at least.
6112018-03-01T20:32:29 <jcorgan> free, but capacity limited and might only run one job at a time
6122018-03-01T20:32:36 *** Adela50Torp has joined #bitcoin-core-dev
6132018-03-01T20:32:49 <jcorgan> agree on code/comment and doc separation
6142018-03-01T20:33:10 <Randolf> Chris_Stewart_5: For doc-only PRs that I've been submitting, if I knew I could do something to prevent unnecessary resource usage, I would have been happy to do it.
6152018-03-01T20:33:21 <rex_4539> Sure, 2 separate PRs it is then. Will get to it in a couple of days.
6162018-03-01T20:33:28 <Randolf> rex_4539: Wow, thank you!
6172018-03-01T20:35:18 *** Victorsueca has quit IRC
6182018-03-01T20:35:24 <jcorgan> another general purpose consideration for pull requests is that independent things don't get combined into one request, as the maintainer can't selectively merge one or the other
6192018-03-01T20:36:17 <jcorgan> anyway, just some thoughts from experience as a maintainer elsewhere, carry on :-)
6202018-03-01T20:36:25 <rex_4539> Yes, but maintainer can comment on the ones he disagrees and I can revert those commits.
6212018-03-01T20:36:46 *** Victorsueca has joined #bitcoin-core-dev
6222018-03-01T20:37:03 <jcorgan> in general, the less work the maintainer and reviewers need to do, the more likely it is to get merged
6232018-03-01T20:37:27 <Randolf> That's why I suggested smaller PRs.
6242018-03-01T20:38:31 *** Giszmo has joined #bitcoin-core-dev
6252018-03-01T20:41:40 <eklitzke> I found a bug in GCC 8.0 (not yet stable) as a result of that prevector optimization, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84656
6262018-03-01T20:43:48 <wumpus> I agree with jcorgan
6272018-03-01T20:43:57 <wumpus> eklitzke: congrats on finding a gcc bug
6282018-03-01T20:45:50 *** Tennis has quit IRC
6292018-03-01T20:46:09 <Randolf> Chris_Stewart_5: Apparently the [ci-skip]"
6302018-03-01T20:46:46 <Randolf> Chris_Stewart_5: Apparently, including the text "[ci-skip]" (without the quotation marks) in a PR's message will prevent Travis-CI from attempting a build.
6312018-03-01T20:46:59 *** Tennis has joined #bitcoin-core-dev
6322018-03-01T20:47:36 <Randolf> rex_4539: You may want to include this text in your doc-only PRs to prevent the build process: [ci-skip]
6332018-03-01T20:47:49 <Randolf> rex_4539: When changing comments, you should still let the build occur.
6342018-03-01T20:48:56 *** Tennis has quit IRC
6352018-03-01T20:50:30 <wumpus> I found a clang bug once: https://github.com/bitcoin-core/secp256k1/issues/445
6362018-03-01T20:51:33 <eklitzke> your bug is a lot more interesting than mine
6372018-03-01T20:54:54 *** Chris_Stewart_5 has quit IRC
6382018-03-01T20:56:10 <rex_4539> Randolf, is it [ci-skip] [ci skip] or [skip ci]? Found all cases in GitHub :P
6392018-03-01T20:56:24 <rex_4539> https://github.com/bitcoin/bitcoin/commit/e3a820751f11b3b30ac19d8118df3e755132e470
6402018-03-01T20:56:31 <rex_4539> https://github.com/bitcoin/bitcoin/pull/7658
6412018-03-01T20:56:51 <Randolf> Someone in the #travis channel just indicated to me that it's this: [ci-skip]
6422018-03-01T20:57:05 <Randolf> If they all work (which would be good), then it doesn't matter.
6432018-03-01T20:59:09 <Randolf> I suggest using the in-comment style that in PR #7658 instead of including it in the PR's title -- keeping those titles simple is generally encouraged, and they're also limited in size anyway as far as I know.
6442018-03-01T20:59:11 <gribble> https://github.com/bitcoin/bitcoin/issues/7658 | Add curl to Gitian setup instructions by btcdrak · Pull Request #7658 · bitcoin/bitcoin · GitHub
6452018-03-01T21:04:14 *** BashCo has quit IRC
6462018-03-01T21:10:40 *** promag has joined #bitcoin-core-dev
6472018-03-01T21:11:52 *** laurentmt has joined #bitcoin-core-dev
6482018-03-01T21:13:13 *** Adela50Torp has quit IRC
6492018-03-01T21:13:14 *** BashCo has joined #bitcoin-core-dev
6502018-03-01T21:15:37 *** bule2 has quit IRC
6512018-03-01T21:15:57 *** Randolf has quit IRC
6522018-03-01T21:16:02 *** laurentmt1 has joined #bitcoin-core-dev
6532018-03-01T21:17:23 *** bule2 has joined #bitcoin-core-dev
6542018-03-01T21:19:27 *** laurentmt has quit IRC
6552018-03-01T21:19:27 *** laurentmt1 is now known as laurentmt
6562018-03-01T21:32:35 *** Efrain83Reichert has joined #bitcoin-core-dev
6572018-03-01T21:59:15 *** belcher has quit IRC
6582018-03-01T22:00:44 *** laurentmt has quit IRC
6592018-03-01T22:02:27 *** mirese has joined #bitcoin-core-dev
6602018-03-01T22:04:37 *** mmgen has quit IRC
6612018-03-01T22:05:53 *** mirese_ has quit IRC
6622018-03-01T22:05:53 *** Efrain83Reichert has quit IRC
6632018-03-01T22:06:32 <bitcoin-git> [bitcoin] dooglus opened pull request #12580: Show a transaction's virtual size in its details dialog (master...show_vsize) https://github.com/bitcoin/bitcoin/pull/12580
6642018-03-01T22:12:17 *** Giszmo has quit IRC
6652018-03-01T22:15:37 *** droark has quit IRC
6662018-03-01T22:16:36 *** Randolf has joined #bitcoin-core-dev
6672018-03-01T22:20:19 *** meshcollider has quit IRC
6682018-03-01T22:21:21 *** Randolf has quit IRC
6692018-03-01T22:22:06 *** Randolf has joined #bitcoin-core-dev
6702018-03-01T22:32:43 *** Frederic50Hermis has joined #bitcoin-core-dev
6712018-03-01T22:32:53 *** Randolf has quit IRC
6722018-03-01T22:37:48 *** Giszmo has joined #bitcoin-core-dev
6732018-03-01T22:39:07 *** rex_4539 has quit IRC
6742018-03-01T22:45:36 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
6752018-03-01T22:54:41 *** dermoth has quit IRC
6762018-03-01T22:55:41 *** dermoth has joined #bitcoin-core-dev
6772018-03-01T23:00:07 *** Victorsueca has quit IRC
6782018-03-01T23:00:34 <bitcoin-git> [bitcoin] laanwj closed pull request #10040: wallet: use headers chain for anti fee sniping (master...patch) https://github.com/bitcoin/bitcoin/pull/10040
6792018-03-01T23:01:17 *** Victorsueca has joined #bitcoin-core-dev
6802018-03-01T23:01:42 *** ula has joined #bitcoin-core-dev
6812018-03-01T23:02:48 *** Guyver2 has quit IRC
6822018-03-01T23:07:54 *** StopAndDecrypt has joined #bitcoin-core-dev
6832018-03-01T23:08:03 *** StopAndDecrypt has quit IRC
6842018-03-01T23:08:03 *** StopAndDecrypt has joined #bitcoin-core-dev
6852018-03-01T23:08:36 *** StopAndDecrypt_ has quit IRC
6862018-03-01T23:14:49 *** StopAndDecrypt has quit IRC
6872018-03-01T23:15:11 *** btcdrak has quit IRC
6882018-03-01T23:15:40 *** StopAndDecrypt has joined #bitcoin-core-dev
6892018-03-01T23:15:49 *** StopAndDecrypt has quit IRC
6902018-03-01T23:15:49 *** StopAndDecrypt has joined #bitcoin-core-dev
6912018-03-01T23:15:54 *** bule2 has quit IRC
6922018-03-01T23:16:41 *** bule2 has joined #bitcoin-core-dev
6932018-03-01T23:17:49 *** bule2 has joined #bitcoin-core-dev
6942018-03-01T23:22:17 *** bule2 has quit IRC
6952018-03-01T23:23:27 *** Frederic50Hermis has quit IRC
6962018-03-01T23:31:41 *** Randolf has joined #bitcoin-core-dev
6972018-03-01T23:32:34 *** Hilton61Hoeger has joined #bitcoin-core-dev
6982018-03-01T23:39:47 *** Cogito_Ergo_Sum has quit IRC
6992018-03-01T23:40:35 *** Hilton61Hoeger has quit IRC
7002018-03-01T23:43:03 *** Randolf has quit IRC